From patchwork Mon Feb 26 17:46:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 775953 Delivered-To: patch@linaro.org Received: by 2002:a5d:6103:0:b0:33d:da16:65b6 with SMTP id v3csp455014wrt; Mon, 26 Feb 2024 09:47:15 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCU3i0ejjIvLu/LjKbu9ACRBSNY99Jj5mRJJp204c/CGcfKuvj8rahqQqwaF67bFDDvaR53iEVvH3R4ydoktPllC X-Google-Smtp-Source: AGHT+IEXQGbUNl0ukd7Kk3ze8ijUHobq5N16qiX4UBBka3xVlB0HoB7ZfFU2aue8X3t23oxJLEGe X-Received: by 2002:ac8:5790:0:b0:42e:79e7:1e77 with SMTP id v16-20020ac85790000000b0042e79e71e77mr7663689qta.23.1708969635142; Mon, 26 Feb 2024 09:47:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1708969635; cv=none; d=google.com; s=arc-20160816; b=rtOmZDfhrC+9Ge5lYo8v122VwpwKlld0FeveESvJEgGP/XbHxfp7h79C/+gWAU2Ynj /A8J2rPIO3E2wml/NLiMvSavf9+v/MdTtty/9Vp5szSW+AuzzVByQOHlQB43eB6FKfFL OaYs6NgZ/NtOgTZSpIw88vxkHlv9KxSJQvHpnpbv2Atcq8hkjhUGDC24NKpsVXW1Mr+M I0mJF1dcobRaZCg2rmoYbhGoUHDy6Sqxe8JA1lmvN5CI1RTfVA3DQ0gr5lQLTqQ/mt5i lwPkVvW/g36XFIdevJ7IvLp7iIBVLfbX4NjLUBu/eWpE0lMJsaMyPgUksdHZ5VfytbGW PgGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=/iX7CVh0CvYZYKZo+EQYkcaTBYd6mrWc2+etueIh3hU=; fh=jUpKE2xnxMsyN0/pv376xeAx2+NoX7ZpLKTmYHVHrxk=; b=IvCGdELdhYqVLcgunK/xKrclVdybIGLjbfM+d5vMYbiIJG0rBW8BQ+tE9UNYatAmUP dGW+jZQNI24BDaKCZFy5jdGA8KeAHSVdMetjoqklsKoSGrEHW6q6Vh60j3VK9hges1UU hWVSBpIYfHhKcN6bvBaLGU8D5KJ9GU6UgZO4gCf9tjRqh1gHykV0A1g4T24vpgRguh6x Lgxid4gTMZtifCyPL1KFcilUlmfq1TYoKggxfIpP3AgIKKKVnrk2kiBNaComBqitruCD OiIszva/55b8FkmSJheNXRoNcFcDTsMmunszR+KRMRP5CaSNfKqx3JlpWRpupofr2h+W nh4w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xLeu3gy2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t12-20020ac8738c000000b0042db43ba9besi5386515qtp.505.2024.02.26.09.47.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Feb 2024 09:47:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xLeu3gy2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ref42-000642-HO; Mon, 26 Feb 2024 12:46:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ref3v-000601-6I for qemu-devel@nongnu.org; Mon, 26 Feb 2024 12:46:51 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ref3t-0000VO-OY for qemu-devel@nongnu.org; Mon, 26 Feb 2024 12:46:46 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-412a9a61545so2979675e9.2 for ; Mon, 26 Feb 2024 09:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708969603; x=1709574403; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/iX7CVh0CvYZYKZo+EQYkcaTBYd6mrWc2+etueIh3hU=; b=xLeu3gy2aLqQiw2WQeiqX6MYHD73ied/wQKujA5VWZy1936QngM643+M9Uf+t/HBH7 hrh9Xkgjq13ZNFrsdy5cU5YAoqgi0146uQNfuES8Kocj7Goia94Mj2YZXpv22gOUEzm7 hwqsh4TiEz3t7bTZe+CpAJdJVJ40Ks+Ekpav5VuHWvwZ64WXeeQszo/yvJ92r37BGWz0 zTJgGwKzevaHC7/mxIvMw3G9pvKZjAuXfXCsQx9FWqEL/3bZRcEpeUaT6BblbXoFqrq+ cyuF79d5SsgO2Woz7kz8K6QFJLVhogjAYY0293SK9NddnoSX8+yuHmhSmWkzox8TTKew 9XuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708969603; x=1709574403; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/iX7CVh0CvYZYKZo+EQYkcaTBYd6mrWc2+etueIh3hU=; b=sCsJFJiHOzr6XlphBVPc1YE4605thyQ7iAGZFoErRGrrPRbmvd1Dkq0l/j0xsyDPss 0Zzz3oyZYRYkYQawtzOJynL7KMvr0oA/Uqz522olWhkHmFtggZ82InJAKgT5PUQHOMAp 2p/lv6A0XVuX+ozfAdVLmo3Kx9eFQidhiTLoq9nLi8tWluOAeV1Sy6XbRIyyZ6DKeebC xLOJDUIlI0igWqrd84Ac38szhkp18J+EFqw0uc82Yf8ODkQVWu4ceHmKeJfkmxMt/02n d8Az1uccERpvcCY9RizeOmSM3s61IAMwB5P/bfzUi6XvEYIo5XJIwIG3uRYDCTC6sGNo IskA== X-Gm-Message-State: AOJu0YwFxiZrb3uK32j4f2jQuqfRfgw8v8a5CZjmHNAs9pLCnYWE4Nbe nX3J8dL5mTh8C+2+KJrbWhkkt5QlskI92em5FoZJHlJG+LDo0ru+vH7oSmWtbnM= X-Received: by 2002:a05:600c:35cb:b0:412:a1c1:207c with SMTP id r11-20020a05600c35cb00b00412a1c1207cmr3045480wmq.3.1708969603385; Mon, 26 Feb 2024 09:46:43 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id hi17-20020a05600c535100b0041290251dc2sm12361306wmb.14.2024.02.26.09.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 09:46:43 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 666AB5F753; Mon, 26 Feb 2024 17:46:42 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philipp?= =?utf-8?q?e_Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal Subject: [RFC PATCH] tests/vm: avoid re-building the VM images all the time Date: Mon, 26 Feb 2024 17:46:39 +0000 Message-Id: <20240226174639.438987-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org There are two problems. The first is a .PHONY target will always evaluate which triggers a full re-build of the VM images. Drop the requirement knowing that this introduces a manual step on freshly configure build dirs. The second is a minor unrelated tweak to the Makefile also triggers an expensive full re-build. Solve this be avoiding the dependency and putting a comment just above the bit that matters and hope developers notice the comment. Signed-off-by: Alex Bennée --- This is hacky and sub-optimal. There surely must be a way to have our cake and eat it? --- tests/vm/Makefile.include | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index bf12e0fa3c5..a109773c588 100644 --- a/tests/vm/Makefile.include +++ b/tests/vm/Makefile.include @@ -88,10 +88,11 @@ vm-build-all: $(addprefix vm-build-, $(IMAGES)) vm-clean-all: rm -f $(IMAGE_FILES) +# Rebuilding the VMs every time this Makefile is tweaked is very +# expensive for most users. If you tweak the recipe bellow you will +# need to manually zap $(IMAGES_DIR)/%.img to rebuild. $(IMAGES_DIR)/%.img: $(SRC_PATH)/tests/vm/% \ - $(SRC_PATH)/tests/vm/basevm.py \ - $(SRC_PATH)/tests/vm/Makefile.include \ - $(VM_VENV) + $(SRC_PATH)/tests/vm/basevm.py @mkdir -p $(IMAGES_DIR) $(call quiet-command, \ $(VM_PYTHON) $< \