From patchwork Mon Oct 7 17:55:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 175398 Delivered-To: patches@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp4606727ill; Mon, 7 Oct 2019 10:56:01 -0700 (PDT) X-Received: by 2002:a63:2581:: with SMTP id l123mr31578527pgl.293.1570470961693; Mon, 07 Oct 2019 10:56:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570470961; cv=none; d=google.com; s=arc-20160816; b=Hy+SpfTSMmi4XZTHeH4TBd276S7bhpY93XCP2pYPbnjIymNikfB+14BETNBAalIg+f YfOCE7YlH/DCb+GtFKdHqKrT4Yx+C7ijc+iQsZpjqseCWAAPQA5qpuSpnAcg0mGJ5+4J XZZaUR2tTs+03uzmTeyy0vQ1L7I+G2yl4+ChCkotE9kbgql6t2QSSGTDmNrV8G7vCNc4 D8Yc4/OJLzHw4KrfPN3CIu/TGuydwTEOEwzl1N7yl6yvsxCyBNC91pEd1JppQXjvjDzj b10Vgiq1f2qIoMfmYkoXnnprHHGTHKZ4Zy3R6Hk++Go39lcgMDIqe0J3rFFLK3ArcyVR NcTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BqAPbs/wZUWEhGivyo3NLB3Z3ocJiJHq8gLjsQrSOVI=; b=NnGZjQUDCxllWuwsDNEqG5PG6tLLSOp/w6ZwYJA8ahp7eF1mEFFjhsmltoFCEPpQd0 kNGjZ95KB+m0UWmUz/2cRHAJ0R9NiiFgnIpeGvprficzwI9fV45nqdHsmQDTFrPwMeVE SE4sBuflv/cmaeRyGtaTMz0jmhjDCmPnzyNKhExtrO6EOBmeabhlliRdQt0NDmAdVxAK NvX0FQGQ2bLLXTUop4KzVqVb0HyTKoXSLyp44FQQbrVo3ABAyCxxaVJAXxWe8SF8etVh WQ5E9kzR7KRIgJMnKYwLbM9m7Fz1Qb3G3fvea46aF5WAUu8P/gQhjCgqEr0CzMmueQjs a78g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zkLe1lXI; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id g8sor17086270pfk.3.2019.10.07.10.56.01 for (Google Transport Security); Mon, 07 Oct 2019 10:56:01 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zkLe1lXI; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BqAPbs/wZUWEhGivyo3NLB3Z3ocJiJHq8gLjsQrSOVI=; b=zkLe1lXI/kTfrysTVpJMwuaXco3MElI5JuoKHwGdd9huySPjwcnc3rUpITt2/11Zm5 tiXNO9v9vnVvIIZd94wdw/YiU4qkXUd98CG1rM8X+hL7q76fc91jo2CiIuKtM0jtJ9rL v/kOPD4SUR/VvcEUI+ziPVYPSPfQsN3CGSoWEWAGNtH2cGERQn01eSXsazGSuW5VlQBc XCg5L0bLn/3dNIkIPJ/E/0FVK8XV2n51gVKvv+dTLBeaGJMwc+fIFiXuQ8Yn0/Sq28RE 2z+dVzuJX2OsLboR4aXc7T1Ei8Y1KCFzodNnELOhDZ0euq7lSepkr59SyAKucel2Bn9c bjmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BqAPbs/wZUWEhGivyo3NLB3Z3ocJiJHq8gLjsQrSOVI=; b=Iix/GMe2wprnA4hk7Dlp+Kl7mF7IQeiIUBlTRqYOLWNI4350Fz7jaiONlW4AkK6OXf H0d5LgwAiKXczMMh+R70AQr2D2WFUMZDDIemqI1wz5VQ/njqX+PxMkqITXKuLT3Li1k2 vGXyaM+WfB4qEjArzSBH8LFjSoXHkjHRSFvu7Gs1F+Irn0aYaZ+ircxrzxRA7gbzuvZQ WuBR6m1AwZ5uWOe2JL7a0TwNZQmIDVd5QqaI3ND14c7djoGGgpAHngJsdmhWdmZI5Him kqg5PVuU1s2ir3C+p457cWahtaD0I8vXfbFHmcoceV8lEJIHHZ1a39iBxNeKXg0Li/Mz OUsw== X-Gm-Message-State: APjAAAX4Go72lnX6I4ewKGq27YLvlJbMYwHa9qkFki420hiwRVs1zyTJ Pa+B6YCBNjzERCG3SbrQHPq1KDr8 X-Google-Smtp-Source: APXvYqzR09qKYZDkL9zavOHzE5V/dTeZBEetwtzxc9ol5SRT48VvfuWeKP1zcPB5Go2sfBi0OZM/lA== X-Received: by 2002:a62:1516:: with SMTP id 22mr33771701pfv.87.1570470961345; Mon, 07 Oct 2019 10:56:01 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id k15sm3820096pgt.25.2019.10.07.10.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 10:56:00 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Greg Kroah-Hartman , Felipe Balbi , Andy Shevchenko , Rob Herring , Mark Rutland , Yu Chen , Matthias Brugger , Chunfeng Yun , linux-usb@vger.kernel.org, devicetree@vger.kernel.org Subject: [RFC][PATCH v2 1/5] dt-bindings: usb: dwc3: Add a property to do a CGTL soft reset on mode switching Date: Mon, 7 Oct 2019 17:55:49 +0000 Message-Id: <20191007175553.66940-2-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191007175553.66940-1-john.stultz@linaro.org> References: <20191007175553.66940-1-john.stultz@linaro.org> Provide a dt-binding for quirk needed to do a GCTL soft reset on mode switching Cc: Greg Kroah-Hartman Cc: Felipe Balbi Cc: Andy Shevchenko Cc: Rob Herring Cc: Mark Rutland Cc: Yu Chen Cc: Matthias Brugger Cc: Chunfeng Yun Cc: linux-usb@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: John Stultz --- Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++ 1 file changed, 2 insertions(+) -- 2.17.1 diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt index 66780a47ad85..cf4ef6c22fb3 100644 --- a/Documentation/devicetree/bindings/usb/dwc3.txt +++ b/Documentation/devicetree/bindings/usb/dwc3.txt @@ -77,6 +77,8 @@ Optional properties: during HS transmit. - snps,dis_metastability_quirk: when set, disable metastability workaround. CAUTION: use only if you are absolutely sure of it. + - snps,gctl-reset-quirk: when set, GCTL soft reset will be executed on mode + switch. - snps,is-utmi-l1-suspend: true when DWC3 asserts output signal utmi_l1_suspend_n, false when asserts utmi_sleep_n - snps,hird-threshold: HIRD threshold From patchwork Mon Oct 7 17:55:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 175399 Delivered-To: patches@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp4606770ill; Mon, 7 Oct 2019 10:56:04 -0700 (PDT) X-Received: by 2002:a63:6641:: with SMTP id a62mr30867484pgc.384.1570470963935; Mon, 07 Oct 2019 10:56:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570470963; cv=none; d=google.com; s=arc-20160816; b=BGmLU5naoH3t85W8bdnojuY4xOpkfflcajsn1EhBf62m/MuYjpeDcVzH1SyLjFhLLw gMrCcMTbqMF///1ki+bTUcdjAHToMwZbeEMesUPCAhqJTGZLt3mwFR0mCHqZM58O28Sx zaXaBkWeKhx3ZVAcyffmL62ivXD/qJsmCHhJLFVBOtl9nw+rLlW2q2JWwU64z5LTLJZt WZMbaNhcMwJWaq9T55rIpyqgyTgbTPuZCVBzLwi4pIO4NSQknlEAeyWNhFG0QCYPbDvN FNPHICOoXoRs2IjP/rKJPYZ+QCPGJZQOSx0bzo1s0a7nMTzAezrsKTxUVbyM3ZmKOEF1 yRbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YKLbWLWjJ/GA5qz2gzrLI3oAv45tZggVEaoyYmAEWtc=; b=JusGuhClW8fmfEA10uhLi3ItzYpZKCkV7z0xOD2OtRgr/oLu716mnF1zFDKhAPs7cy 1FKNhsQSjQ4FORTKeVmx2E8RErHhmakPoBBR2JhPfDX/ML7JjU5BhKBVuKffs2xOBhBg uNIh5u+Er3x5vDBJ1YXdR9UornJxSOxIFA309cF95eXnanplZxKuk6tlz9rWFf2b1oda 1xvQZMJD0z+RgcsSyYrLVeBacH+5V1w+C6Gzy4d1oPbXQAFR40bHmhA0ER9vOws5xwWl DZNcr1PdHmJ+TBNJBdIIiOxfHW5jnHu444NFreXmnyuCmf/LzjTBoeS0Loe/IQTDINoN ll1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UYzDC4h0; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id c64sor16703161pfa.21.2019.10.07.10.56.03 for (Google Transport Security); Mon, 07 Oct 2019 10:56:03 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UYzDC4h0; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YKLbWLWjJ/GA5qz2gzrLI3oAv45tZggVEaoyYmAEWtc=; b=UYzDC4h0moF6TQzBOgkcjKP7aKolNPTebeHscocKWyaubmFmhXEoRiaMdF5qy5ogAn mM09zumDqTlgW8ItdSALOkUZzEib3H67BIfdpf8Tcnhgtxgg588fAu1zMcQcOffL3GHj qKcJDmojl03dF9EWsgoSkdYCy5r5oCQx38zrCIcqPx4hFsKip6dNApLHQ5WDXIgZns5c 4cE7lgRV9iUVqM0hBX91Ni7uZU3+5WG5d9/+wgk1oSY1yoP3Z1Y+ecl0V37tSKe19lrX iELOP5B+MFN2IHQFsm3QMYYUlkQy45Q0XNI+ibrrKGNRFGNiWNZSZcYQAK/4EVIfmach kjfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YKLbWLWjJ/GA5qz2gzrLI3oAv45tZggVEaoyYmAEWtc=; b=UAqDMS/PvkixjQY5eecPUvoaErSkxc1Y0jeFijF2P3qx1J01DKL9gATT9o2nUS7w9h b7gXXVL1tDF6FiafWPAduE9GuytBNS08xGyxgBNubj9b+guWHyDZc8bB1GJqbuemubTs OncenNo9Fj+660Lahn6Mztv84D41cX8Db04JA5KvTg/son9pJZ7jM47druuTEif1XfzG e8r6ujwxLSkJUnR8+/jEv4mur++n4PmZbekWIckRKHCyhWqXEvFypp9LylSNJiqooRRP cauya2Fy8AXxQ54QUR/UcYL1Uhu8SMJV+1ayvannYZyAB/BpyrkLNyH1CNACTMi4yEzq RpwA== X-Gm-Message-State: APjAAAVyvs2TiSQ+Nijfxq9nu4ITi80m7dFZHkHrPbDLOiZd6CZ/aeYQ f3Hmq4bo/Q/+b4DrrwGtHTHmI2Pd X-Google-Smtp-Source: APXvYqyP5ZSRlyeJVHXlGMo3HFliZL7HfRt+pmiWd6boT4KjdSiMtolf+T6RLS6pFrH4tgGXlUcUKw== X-Received: by 2002:a62:7597:: with SMTP id q145mr33121812pfc.181.1570470963551; Mon, 07 Oct 2019 10:56:03 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id k15sm3820096pgt.25.2019.10.07.10.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 10:56:02 -0700 (PDT) From: John Stultz To: lkml Cc: Yu Chen , Greg Kroah-Hartman , Felipe Balbi , Andy Shevchenko , Rob Herring , Mark Rutland , Matthias Brugger , Chunfeng Yun , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, John Stultz Subject: [RFC][PATCH v2 2/5] usb: dwc3: Execute GCTL Core Soft Reset while switch mdoe for Hisilicon Kirin Soc Date: Mon, 7 Oct 2019 17:55:50 +0000 Message-Id: <20191007175553.66940-3-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191007175553.66940-1-john.stultz@linaro.org> References: <20191007175553.66940-1-john.stultz@linaro.org> From: Yu Chen A GCTL soft reset should be executed when switch mode for dwc3 core of Hisilicon Kirin Soc. Cc: Greg Kroah-Hartman Cc: Felipe Balbi Cc: Andy Shevchenko Cc: Rob Herring Cc: Mark Rutland Cc: Yu Chen Cc: Matthias Brugger Cc: Chunfeng Yun Cc: linux-usb@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Yu Chen Signed-off-by: John Stultz --- drivers/usb/dwc3/core.c | 20 ++++++++++++++++++++ drivers/usb/dwc3/core.h | 3 +++ 2 files changed, 23 insertions(+) -- 2.17.1 diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 999ce5e84d3c..440261432421 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -112,6 +112,19 @@ void dwc3_set_prtcap(struct dwc3 *dwc, u32 mode) dwc->current_dr_role = mode; } +static void dwc3_gctl_core_soft_reset(struct dwc3 *dwc) +{ + u32 reg; + + reg = dwc3_readl(dwc->regs, DWC3_GCTL); + reg |= DWC3_GCTL_CORESOFTRESET; + dwc3_writel(dwc->regs, DWC3_GCTL, reg); + + reg = dwc3_readl(dwc->regs, DWC3_GCTL); + reg &= ~DWC3_GCTL_CORESOFTRESET; + dwc3_writel(dwc->regs, DWC3_GCTL, reg); +} + static void __dwc3_set_mode(struct work_struct *work) { struct dwc3 *dwc = work_to_dwc(work); @@ -156,6 +169,10 @@ static void __dwc3_set_mode(struct work_struct *work) dwc3_set_prtcap(dwc, dwc->desired_dr_role); + /* Execute a GCTL Core Soft Reset when switch mode */ + if (dwc->gctl_reset_quirk) + dwc3_gctl_core_soft_reset(dwc); + spin_unlock_irqrestore(&dwc->lock, flags); switch (dwc->desired_dr_role) { @@ -1316,6 +1333,9 @@ static void dwc3_get_properties(struct dwc3 *dwc) dwc->dis_metastability_quirk = device_property_read_bool(dev, "snps,dis_metastability_quirk"); + dwc->gctl_reset_quirk = device_property_read_bool(dev, + "snps,gctl-reset-quirk"); + dwc->lpm_nyet_threshold = lpm_nyet_threshold; dwc->tx_de_emphasis = tx_de_emphasis; diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 1c8b349379af..b3cb6eec3f8f 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -1029,6 +1029,7 @@ struct dwc3_scratchpad_array { * 2 - No de-emphasis * 3 - Reserved * @dis_metastability_quirk: set to disable metastability quirk. + * @gctl_reset_quirk: set to do a gctl soft-reset while switch operation mode. * @imod_interval: set the interrupt moderation interval in 250ns * increments or 0 to disable. */ @@ -1219,6 +1220,8 @@ struct dwc3 { unsigned dis_metastability_quirk:1; + unsigned gctl_reset_quirk:1; + u16 imod_interval; }; From patchwork Mon Oct 7 17:55:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 175400 Delivered-To: patches@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp4606797ill; Mon, 7 Oct 2019 10:56:05 -0700 (PDT) X-Received: by 2002:aa7:8f08:: with SMTP id x8mr34922511pfr.48.1570470965416; Mon, 07 Oct 2019 10:56:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570470965; cv=none; d=google.com; s=arc-20160816; b=kJZBLtYtOVSRuoiBeDRocoUd4efRlx6opPytyMa+yGRvMxp4ElOk3o/EN3xIO4SNwB zwWkbR43puldUcikZifBbfUG9pLHWt7Q0Xucw+YkWQsYddej2IXSfMsB3Y0eilET1a2j vmHGwUEheNgI7CBtw/GMzQ4ApQjZljbHB2/oH1jDW+IGSjX0jw12qZ+T5JwJePzzY4uY VZJG8fUDgehHyyQZsjWpPib65npPXUjcmqsNswXDVV00kbknMoqLYDW1X1v8AGL+BpZb gypTnMmGyZgtuX9CJ/YmkaEqrGXM30eMyeO+5Z86DPpZ93BNFzQDzxli7q85OyKcvEZJ u5Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oFS6SaDoQ5fogHAHlhUMYfV/B7rrjNj6XYxhAXSXdHY=; b=R5+42htQFOqooC8bDwIe5j1hIV2mJvtjagvVVKOf8e37AMnaQP2/T6z3HkzguOLz7p ro6kYai2IyT6eVJLe1Jv7ZpaKed216S0SxRQMn1fH21quPiir+2ZjFX5niUgBKe3PQAZ fVpYoyHneRi1LtaoZuxjaZnDvCRxUjsxnL93ajgMUXaBKWkVCOggjvcpJEm2vbTuokuo maiBZx+1UPmoGRqQMJTKAZX+M6gQdoAVVOLfYQuNvp0+ANWg6vHHC0w2CHAU0P5kCSR9 AO3rg4ee/X/Nai5S44CI8R++C+DR1UnGfZhg4469CRIE4EIgd6MixZNn8KgXBWlKGZf6 JsEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x1nWDenY; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id w8sor16959750pfi.51.2019.10.07.10.56.05 for (Google Transport Security); Mon, 07 Oct 2019 10:56:05 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x1nWDenY; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oFS6SaDoQ5fogHAHlhUMYfV/B7rrjNj6XYxhAXSXdHY=; b=x1nWDenY+0OgbS5Si4sl4DdYea+ca+L0YaFIzXKakFAoV8rokW8Wv4O9U4fSg4XRT3 C36yiu+wbHF79WBypFf0D+jFIoGAugRVQALrQvA4zgQpwlAKaFe18wS0DG4ys81258Xg wgVcnDbTcYXFQ5a8ynD7RjXxF6GJRLeReKA3BBb1Pledy4pQNOgHWFZE4HNvX4cuLe2Y AnKZ+FLYTAUg3PJjrc2pUo26D4LnXuAiz8pV5Z9XiIjb7C+LtjsvwGCKtkfwh7TF0mNW tcEOos93Wrae9VkosnEAjX2oowhtK4u159OFqQL2v1Hlwc9MHeD5i9FPvfFkifEd8ISf lhyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oFS6SaDoQ5fogHAHlhUMYfV/B7rrjNj6XYxhAXSXdHY=; b=Rp/VEnL04CWLW2+22giC/mw5Er5HF8UFnrQTMqp4LHDZEo5mjkTMbSzEmLB2I1heYd kzpZtL3PIzl8tfGLC0D+vUVoOTlyKEI67XxYHVLTAP71T1zdbpO/j2sJhIX8iRsLw0TP +6zyAyTm/IcbsBamqzsK6G25Xvh4Px99i5bVwvuQzskg+Ev0X35nF2a4wMzAoabxVIf/ y1SJKM2NaJkVVupZw1QUhO/GFDg1m22RNRq/6g7TYo5LNMyhlRvUd6YbTt7h4Y42oDrv Pte/1KZCt0dkGqSFUpXQ4kWJ3R4HlQlOvvYGQYsh+fiaV9ePzsPTBDwcAFGSwiweCg/h 5hNw== X-Gm-Message-State: APjAAAUhuOOxz55ejUt97gY3Ar8qit7yD2UT1EKzJRabLetLBh3ESKNg iIyWsnEbGbrAww56cxJMCzW1qUxK X-Google-Smtp-Source: APXvYqwMP8ygmDxBtrmpiUIThUb/AoKHCnnSdgO0txYlKecbRvRqSCa7T55269OWxjGj1A/VvCtLzg== X-Received: by 2002:a62:ab04:: with SMTP id p4mr34552992pff.227.1570470965054; Mon, 07 Oct 2019 10:56:05 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id k15sm3820096pgt.25.2019.10.07.10.56.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 10:56:04 -0700 (PDT) From: John Stultz To: lkml Cc: Yu Chen , Greg Kroah-Hartman , Felipe Balbi , Andy Shevchenko , Rob Herring , Mark Rutland , Matthias Brugger , Chunfeng Yun , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, John Stultz Subject: [RFC][PATCH v2 3/5] usb: dwc3: Increase timeout for CmdAct cleared by device controller Date: Mon, 7 Oct 2019 17:55:51 +0000 Message-Id: <20191007175553.66940-4-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191007175553.66940-1-john.stultz@linaro.org> References: <20191007175553.66940-1-john.stultz@linaro.org> From: Yu Chen It needs more time for the device controller to clear the CmdAct of DEPCMD on Hisilicon Kirin Soc. Cc: Greg Kroah-Hartman Cc: Felipe Balbi Cc: Andy Shevchenko Cc: Rob Herring Cc: Mark Rutland Cc: Yu Chen Cc: Matthias Brugger Cc: Chunfeng Yun Cc: linux-usb@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Yu Chen Signed-off-by: John Stultz --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 8adb59f8e4f1..81907e163252 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -270,7 +270,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd, { const struct usb_endpoint_descriptor *desc = dep->endpoint.desc; struct dwc3 *dwc = dep->dwc; - u32 timeout = 1000; + u32 timeout = 5000; u32 saved_config = 0; u32 reg; From patchwork Mon Oct 7 17:55:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 175401 Delivered-To: patches@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp4606819ill; Mon, 7 Oct 2019 10:56:07 -0700 (PDT) X-Received: by 2002:a65:504c:: with SMTP id k12mr19191897pgo.252.1570470967211; Mon, 07 Oct 2019 10:56:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570470967; cv=none; d=google.com; s=arc-20160816; b=AxEwOfS5V5f55XD/iHVLbAPf9DULvgcmfKx04yN9xhsSLmhtQ2w+aDoxo5Ved4FPM3 APYjPT8ImEWJdJh3E/ZPsbMZ5CIoMU5aIrL4qrDpEQ4FBlY9vuFCaRKT/BFTHhi8uT/R uswFT1kp9LiNDg4RlBSE4qvvIAr9s7fSkGYjwMaD2iVuncns6GvsA2HmWWY/MjOaLh3V A3A74jgOCwPP5fIRLQOoQWD0cCIB1zR6yWSbQh+mzSbPiBUT8L/OpK4eLvmIyVrKFcYT 05zgoiUn2lUAY9lhPV3ma8RuTaWe7rwoHhRYmYkWNcNFDyz7jUVcmlzCul+NOuSafaQg 8lqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7/b3yUeZa8CC2Us86GgYloZCqUlnEcjewTRh+R9Lbvk=; b=qqUVMDOaf0lNtIvrZ1mI/UF1bA/cgduBnQFmvCXC0V5zlbQ4CvJyP523lH16UhL/fG gR1+68XZ/DFcc7vPY8RidHHSAyQiwJNSHRVeFt59RnJJbwEvqE+8ghoncEcNJV1y854b F/AoZ5/zn2XN0Z5wpPJFuWZDb3aUbAc8/CgFbtu/z5jahfAkQNpWfPaGLVnuazoXCe7b b/QO1XdVp2FznBuWiaKCWUih6FkmuAf1USvTlG6kvZ2gqdXMF9RTu3Qo2G41z6j9AoLM TNEIoUvdpez2sU5Q8W6lL+CVGJJ+UCIknP0xmtGdcAaT2gLlQbamOFAwg1A5zr9P7XaO 3yhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SlY3eXwv; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id r5sor18655142pli.61.2019.10.07.10.56.07 for (Google Transport Security); Mon, 07 Oct 2019 10:56:07 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SlY3eXwv; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7/b3yUeZa8CC2Us86GgYloZCqUlnEcjewTRh+R9Lbvk=; b=SlY3eXwvCRPmzMOhMJJSBUGa/3rX3D4MUbmP0Ohh4buo2qrQ3DCJIvh8hRcWXRpawv QB80v4EAGe5Dvtan+jOEazC5pe64LQb01TslpzL+J7t1hzRTuRhYCdxhfYXQBbAcI/Zq bFxGsoLTeC4mNqGdjuOKXVihqfjxr5ufHsZZa3pYGj05xoNRFOuWY4wLGePQIJcoC8ry GMomuuVRq9oKJMX/OvfgT19utBjL+NR1tT6xgcPkd9EQbEpXfqCeNm1eY8PSUaRHYgO2 PtJ+Dk4z1VlTkcHKjqtWtn47m3uJ2kJuZ2V8bSDM59Id/tThwdsiUSNhuXTu2pNkEHZM iIRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7/b3yUeZa8CC2Us86GgYloZCqUlnEcjewTRh+R9Lbvk=; b=FNj+yhEpJumpKybmwkMH5HTXSEuXE7Cy5DVYVlgWNllK3INhf3HF/FvIi4IgL0PvGB E7EgZETO2ojNuJoPzM7mPQaSptnFHR6EKcZhUt0PlzMIWvspqzTYc8VOfc8h3XIndQ8a Al10pwTPw41An1BcmVeAieCy5NO5p2VfggW+pkm3JAx9Nxa8GzhP4RIO5TU8TjkUfsaS KDBCO6mgNGo75dFi6IvJdQuEJPz7yYcWtmuzafOBD3Ud8lGV0H0LljL/VL0vLBojclOC fCJ0sYoNtK1nlTI/I605wDfXBzSxDSv1usM2moisdBWOoBXfxdKUZIUVgAYUMwHuPnwu jLwg== X-Gm-Message-State: APjAAAX3+GpE2B9g4F4SfVKy1Ji9ndyDN3L4N5IDrWFLo4UxNq6dPZdB Ma8n0IX9upvY5YAcbNdKkFerGAEs X-Google-Smtp-Source: APXvYqxzIFObkEZ3b71NwneTkjqqzC3Nj0N3NNcomwCN9GSXlPRZnaHZIfK+yVDlQ0vpXSE4EK6AaQ== X-Received: by 2002:a17:902:820f:: with SMTP id x15mr29187700pln.230.1570470966697; Mon, 07 Oct 2019 10:56:06 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id k15sm3820096pgt.25.2019.10.07.10.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 10:56:06 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Greg Kroah-Hartman , Felipe Balbi , Andy Shevchenko , Rob Herring , Mark Rutland , Yu Chen , Matthias Brugger , Chunfeng Yun , linux-usb@vger.kernel.org, devicetree@vger.kernel.org Subject: [RFC][PATCH v2 4/5] dt-bindings: usb: dwc3: of-simple: add compatible for HiSi Date: Mon, 7 Oct 2019 17:55:52 +0000 Message-Id: <20191007175553.66940-5-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191007175553.66940-1-john.stultz@linaro.org> References: <20191007175553.66940-1-john.stultz@linaro.org> Add necessary compatible flag for HiSi's DWC3 so dwc3-of-simple will probe. Cc: Greg Kroah-Hartman Cc: Felipe Balbi Cc: Andy Shevchenko Cc: Rob Herring Cc: Mark Rutland Cc: Yu Chen Cc: Matthias Brugger Cc: Chunfeng Yun Cc: linux-usb@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: John Stultz --- v2: Tweaked clock names as clk_usb3phy_ref didn't seem right. --- .../devicetree/bindings/usb/hisi,dwc3.txt | 52 +++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/hisi,dwc3.txt -- 2.17.1 diff --git a/Documentation/devicetree/bindings/usb/hisi,dwc3.txt b/Documentation/devicetree/bindings/usb/hisi,dwc3.txt new file mode 100644 index 000000000000..3a3e5c320f2a --- /dev/null +++ b/Documentation/devicetree/bindings/usb/hisi,dwc3.txt @@ -0,0 +1,52 @@ +HiSi SuperSpeed DWC3 USB SoC controller + +Required properties: +- compatible: should contain "hisilicon,hi3660-dwc3" for HiSi SoC +- clocks: A list of phandle + clock-specifier pairs for the + clocks listed in clock-names +- clock-names: Should contain the following: + "clk_abb_usb" USB reference clk + "aclk_usb3otg" USB3 OTG aclk + +- assigned-clocks: Should be: + HI3660_ACLK_GATE_USB3OTG +- assigned-clock-rates: Should be: + 229Mhz (229000000) for HI3660_ACLK_GATE_USB3OTG + +Optional properties: +- resets: Phandle to reset control that resets core and wrapper. + +Required child node: +A child node must exist to represent the core DWC3 IP block. The name of +the node is not important. The content of the node is defined in dwc3.txt. + +Example device nodes: + + usb3: hisi_dwc3 { + compatible = "hisilicon,hi3660-dwc3"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + clocks = <&crg_ctrl HI3660_CLK_ABB_USB>, + <&crg_ctrl HI3660_ACLK_GATE_USB3OTG>; + clock-names = "clk_abb_usb", "aclk_usb3otg"; + + assigned-clocks = <&crg_ctrl HI3660_ACLK_GATE_USB3OTG>; + assigned-clock-rates = <229 000 000>; + resets = <&crg_rst 0x90 8>, + <&crg_rst 0x90 7>, + <&crg_rst 0x90 6>, + <&crg_rst 0x90 5>; + + dwc3: dwc3@ff100000 { + compatible = "snps,dwc3"; + reg = <0x0 0xff100000 0x0 0x100000>; + interrupts = <0 159 4>, <0 161 4>; + phys = <&usb_phy>; + phy-names = "usb3-phy"; + dr_mode = "otg"; + + ... + }; + }; From patchwork Mon Oct 7 17:55:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 175402 Delivered-To: patches@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp4606854ill; Mon, 7 Oct 2019 10:56:08 -0700 (PDT) X-Received: by 2002:a63:790:: with SMTP id 138mr32810583pgh.220.1570470968784; Mon, 07 Oct 2019 10:56:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570470968; cv=none; d=google.com; s=arc-20160816; b=qZaf5Wh4SxVg3Vr0QinYqGcWgXNVy0IQKyMEIe2LVxWqVrm2ay25zFZFoLqGLZtjVd //YCEl+bevQsUdiVQ/esEbRrexTi94xNIi5gC2noT2qd4n+cfgDclS5Nw4JQUFWYUFXi BDT/s87IgIwBzTjJ38Gff6qXdWKGuXjJ6A+M3SSN7XYA22doB2LDfxduKfay9/s4+nDp BnKF2P/9yYO3jIL8ItOBvJABWH5YWfE92krGFTslAp38lX0nst/NzCMIgz0c6cn3ggy6 E0alYgmrJjWzsEfHC1symXJ4pOt0INfefRkoGYJksHWTCUCarQm8HBxpr7cDjQLrtJkC Me3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1oH7lj03wYz79i/zPzaUWTT6QxHftIiKZMYorEdLMBo=; b=HiX3BZA4nwi3yn+vtirdnMYV2wr+SUTKPxWxhAWpxtMPU/lCAMCRXdmSii6ijyqwhj 7TfgFRjxqjS6pdYUZWh/qZ+iB+Gea9ERVSMlpVGaZRytFMvBpX/iTVphWxkfXujelikk +wsgZ444lr9E65tLsyeLiQpoKXVwTY5TllgCNSSJOXcJL2uv6LAz6x3JbrkutcDxjVSl p8++QEADvdVtBpCeMmy9kBSLlo3cTjqRTfilluKI8nJpJpF4/pAL0QlMcZbiUyfhjwos cF62T4MEDP7ZTY3R+W49eEqTomYOE+s7v+15Tyvj45q3MGLgrCTFkhBOsb3VxAqABA19 6Bmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iD2o9He3; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id j10sor384867pjn.21.2019.10.07.10.56.08 for (Google Transport Security); Mon, 07 Oct 2019 10:56:08 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iD2o9He3; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1oH7lj03wYz79i/zPzaUWTT6QxHftIiKZMYorEdLMBo=; b=iD2o9He3U69q6RpgqdzxaCMFlm/KSulpW5frmlBOgF4pZ0uYO5c4gejji2HqtrMSQt 8JhD9FTrk7VwS9GB2wrv8Hba0ZUIEQWc9WuQjOP7YxIOKTfoneOS2w/L0Yeb+Ppfbn79 SWF99J20b4fqvta/nclqz+QzVDbV4tZIOQhTbnETRWBCpLXosYrqEgWPHgV0nEEVG5IE T9jbitj49uv/eck9gVcH09akU4ZrdFhTPVaX7LcuokFH39wF81h2s3f+Kx5TVU38lUwk +Sz21hlnZ3RyMbV0oqLJKa6oZqZICMTUv8vFFP0PxLuGOnFixbMAk5Z4XfOwdpENVbIe XJww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1oH7lj03wYz79i/zPzaUWTT6QxHftIiKZMYorEdLMBo=; b=EF9VdHsq8/A4ryHtQkNVRJnjUB3OKs4ZHP6SxTbByjV/tXLelT/npEdTn08cu4IK/R 7+bPu8XXd7K4agP38ebHfzi3KnvawMzzqRk++fgylCHFUI15HbyruoX6inHgVh3ppApo ElOB2DIPhqc0Hx6ItFK5Af+RkMz+j84vg2Vk7lbUrzqccQR6m6OtCoolq9N6QtZTpd2a ZuzC5ks8RfKblcxXqn6foQeLZa+HkHABkZgGl6v2jb3jng4UtuTuILJgxpW+G3wYWYAL fJdxSyH45ElCLYCKdOIRN1i1n0I1SnDoRCbpU300AAIXahsiCd2YE8t0JDou3N+J95bt 2HkA== X-Gm-Message-State: APjAAAWudMwXaWkiJUiRluyS6VrY48WNx1crbN4eaLbBOpKs+4Epxvwh ERgN18qJk0TQp56DFzTrqwsc9yZg X-Google-Smtp-Source: APXvYqz1K67CyWo0e/emHrkBQnZS3p/dyk4OrQ9OdF6w4uS+MO8fNgdny3guoMksP8tvRCj3SarDBw== X-Received: by 2002:a17:90a:fa0d:: with SMTP id cm13mr610912pjb.70.1570470968394; Mon, 07 Oct 2019 10:56:08 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id k15sm3820096pgt.25.2019.10.07.10.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 10:56:07 -0700 (PDT) From: John Stultz To: lkml Cc: Yu Chen , Greg Kroah-Hartman , Felipe Balbi , Andy Shevchenko , Rob Herring , Mark Rutland , Matthias Brugger , Chunfeng Yun , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, John Stultz Subject: [RFC][PATCH v2 5/5] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform Date: Mon, 7 Oct 2019 17:55:53 +0000 Message-Id: <20191007175553.66940-6-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191007175553.66940-1-john.stultz@linaro.org> References: <20191007175553.66940-1-john.stultz@linaro.org> From: Yu Chen This patch adds support for the poweron and shutdown of dwc3 core on Hisilicon Soc Platform. Cc: Greg Kroah-Hartman Cc: Felipe Balbi Cc: Andy Shevchenko Cc: Rob Herring Cc: Mark Rutland Cc: Yu Chen Cc: Matthias Brugger Cc: Chunfeng Yun Cc: linux-usb@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Yu Chen Signed-off-by: John Stultz --- drivers/usb/dwc3/dwc3-of-simple.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c index bdac3e7d7b18..78617500edee 100644 --- a/drivers/usb/dwc3/dwc3-of-simple.c +++ b/drivers/usb/dwc3/dwc3-of-simple.c @@ -51,7 +51,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev) * Some controllers need to toggle the usb3-otg reset before trying to * initialize the PHY, otherwise the PHY times out. */ - if (of_device_is_compatible(np, "rockchip,rk3399-dwc3")) + if (of_device_is_compatible(np, "rockchip,rk3399-dwc3") || + of_device_is_compatible(np, "hisilicon,hi3660-dwc3")) simple->need_reset = true; if (of_device_is_compatible(np, "amlogic,meson-axg-dwc3") || @@ -183,6 +184,7 @@ static const struct of_device_id of_dwc3_simple_match[] = { { .compatible = "amlogic,meson-axg-dwc3" }, { .compatible = "amlogic,meson-gxl-dwc3" }, { .compatible = "allwinner,sun50i-h6-dwc3" }, + { .compatible = "hisilicon,hi3660-dwc3" }, { /* Sentinel */ } }; MODULE_DEVICE_TABLE(of, of_dwc3_simple_match);