From patchwork Wed Nov 6 16:31:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 178723 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp845746ilf; Wed, 6 Nov 2019 08:32:09 -0800 (PST) X-Google-Smtp-Source: APXvYqy2jKySRNRaeDyHLpDa9PItOmwgz60X+IGS8tFWxDxHzLpsCYxU2eKknMNQTPoNoakiIAKH X-Received: by 2002:a50:9353:: with SMTP id n19mr3731906eda.258.1573057929476; Wed, 06 Nov 2019 08:32:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573057929; cv=none; d=google.com; s=arc-20160816; b=PyR/T7F0KafVTLM1KvS93Yrl48/xOW4RYKUAQ55X5MGiMNXg/GU4gt0IwbUkjJP3Dw 3Kt/U4dMPBiuJCPZYw2edgbvv2U5SX+RJfxGaGsMSqxmViDI+kixOdp/VmLf+NtotT+l zuTzn8mLuaXnrpvhF44P2+5IsncaYoY9IUDGNzPrNquz7D4KyGz8C4/vcrkPM+Dt/74u wUDEeDRr7+TzUmGkWeoU3OroriiSn0tN19Wn0a/AI1I+wCRAULi1dfxAAUckEq9QYrav t/YlcZEcSy8wN/x10mF+7HfO/kEFepVQDLtEMlO5bKMNWrugnfXJ2UiJvE8yABOWfEoF zBwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=T9yrIjRcGMXJPZr9R0o9cslCmGXUcwMolHkVFlGlDBE=; b=oo88zGwGcMGbsAhXqPPfTgq2Z3qnlgvtnePHE1wI4YRuarzVL7ay/gdxDicRmnYqxB pFdag0+7/tJ/e/tHutC03p5YpK7X872i60a9Ht02fcZRgDfc3lv6R4RLPFO5MqMqyQwL fSp2V6oh3EGydxGu0jpVadXpmtHd7okv9PEVZQWyA+XO4jrKC5zrdC4KAJZAMB4GAqcn 4nS57bH1wnTzeoHWkElEDyrOHPkddBp/ODCIpmwhypB6njoRJmLA4dwp77Euc4KF/Pu9 QYnSk34hc+ISAifalq8G+T/i9Fllwbxvs35l/OwQWKGC7V2rYxI58tQEctDOBWRrU2gv 1dWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YVc71Lga; spf=pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=dmaengine-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id mj25si5554689ejb.198.2019.11.06.08.32.09; Wed, 06 Nov 2019 08:32:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YVc71Lga; spf=pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=dmaengine-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbfKFQcI (ORCPT + 3 others); Wed, 6 Nov 2019 11:32:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:44036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727321AbfKFQcI (ORCPT ); Wed, 6 Nov 2019 11:32:08 -0500 Received: from localhost.localdomain (unknown [223.226.46.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 72DBE217F4; Wed, 6 Nov 2019 16:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573057928; bh=jhBOluiYCulN6apFlRvdHiaY/j9/f6jUmjIwgV1NBgo=; h=From:To:Cc:Subject:Date:From; b=YVc71Lga1sFKZaRp49BRIiWXw51YZqCsOvSa9d6DkMCQvcpwJlBKFtn61lo/jfBo7 bSiw4an/rwuUGasAcvBlUnEaqnQClxPO7mXTdt8rS+LYPX704vxb54hR6qbK05zeTD P6wCIjH2haeQ5jSIZwdUEkU02zPo8E/H9eG7vQg8= From: Vinod Koul To: dmaengine@vger.kernel.org Cc: jaswinder.singh@linaro.org, Vinod Koul , kbuild test robot Subject: [PATCH 1/2] dmaengine: milbeaut-hdmac: remove redundant error log Date: Wed, 6 Nov 2019 22:01:27 +0530 Message-Id: <20191106163128.1980714-1-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org platform_get_irq() prints the error message, so caller need not do so, remove the error line in this driver for platform_get_irq() Reported-by: kbuild test robot Signed-off-by: Vinod Koul --- drivers/dma/milbeaut-hdmac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.23.0 diff --git a/drivers/dma/milbeaut-hdmac.c b/drivers/dma/milbeaut-hdmac.c index 2bb33535ab9e..8853d442430b 100644 --- a/drivers/dma/milbeaut-hdmac.c +++ b/drivers/dma/milbeaut-hdmac.c @@ -431,11 +431,8 @@ static int milbeaut_hdmac_chan_init(struct platform_device *pdev, int irq, ret; irq = platform_get_irq(pdev, chan_id); - if (irq < 0) { - dev_err(&pdev->dev, "failed to get IRQ number for ch%d\n", - chan_id); + if (irq < 0) return irq; - } irq_name = devm_kasprintf(dev, GFP_KERNEL, "milbeaut-hdmac-%d", chan_id); From patchwork Wed Nov 6 16:31:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 178724 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp845797ilf; Wed, 6 Nov 2019 08:32:11 -0800 (PST) X-Google-Smtp-Source: APXvYqyCSUk/H6HVufdKSHepaqsCuWtMnOwcIIrZz/FvIXBslBziYKnFtr3Tkmd5oDIOYL5KGWJI X-Received: by 2002:a17:906:3d2:: with SMTP id c18mr27473972eja.111.1573057931285; Wed, 06 Nov 2019 08:32:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573057931; cv=none; d=google.com; s=arc-20160816; b=bN2EE9XvQNU6A4W05vIAByE0qMKfn1tGC2VfdKEJ0fEKQuoe6X+c1FQakBJ+BAdLYb uIQte07xPGbpiZBCBK63pnatHCO0vkmBppMZUk/hFp4fz2hhznzlDKOdRvrwUPTIFsXl OBndmNQcA80MpAz/ckkp/lykLnV5Cn3csyxLFBxzuNy7NPkwUB7C8A6jDpWFpTpCVs0P CH13TWzUb3avomKnjYqLUeTa/9wtz6OPpPdH6hbOt6iWDcN8qr6Au6CHJ0mk0CcS09ao 9d/Q0KC82NxUackWNPky7IMozzhUJg37XGrdwDxIhZKwkQTouDzJ6EV8BEFt4lCgT4hB 3faw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ScYzISksFSigH0HlQyw9Pwa1yjxcHdM6h54YPQciySs=; b=N7f3Dyalun2qL7VTD36TGKQZkvg9qFWFVOPCepskZJbKEdNYKQgiAK4nLq3dK4kz+Y SaLDNKZJr9fEES8hvt8Q9rSInEstYDi8EH8YfY48UTzpXMXEYYcE4K4wkEZFjj8Ky21+ 49UEKSvfznGzua0HTArwkRTqjkGY0pL1yL1emeDDcsxw4kfTDxUxvDGS0XcEZBNBfZu+ R8cm9p6dNRMvOOP/Xowzhkx0yZqPJl116nPDZwZ/37KlIB9EUfgIl7CHSGNb3nba5XYv 7yxobyttdGGolKv5uAGMJJWDJ2oDL8NUuK5ISNNEer2gye3fvqVhx/ey8AQSAxfZgeed ImVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Q3j94BBo; spf=pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=dmaengine-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id mj25si5554689ejb.198.2019.11.06.08.32.11; Wed, 06 Nov 2019 08:32:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Q3j94BBo; spf=pass (google.com: best guess record for domain of dmaengine-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=dmaengine-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727625AbfKFQcK (ORCPT + 3 others); Wed, 6 Nov 2019 11:32:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:44076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727321AbfKFQcK (ORCPT ); Wed, 6 Nov 2019 11:32:10 -0500 Received: from localhost.localdomain (unknown [223.226.46.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A39F22067B; Wed, 6 Nov 2019 16:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573057930; bh=UPtPfF84kJmerAR8ODzUcUrcSkzXPV5RdNC910/MOrA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q3j94BBoGTEvkJE8Oa0DtJRiNDJax2881WdNcXl+7Ud2OhX7PEUzuwIpY+IW9JyBo hhcCQfiqZUZzWnDBl65pcPuEssgahKuFoXHUYrmvPQxfX27Wea56YXbBCn0jYR0En4 uKlUfYHAFfreM7BqTdo8BWY0FCG1+7ziiSD5KG+o= From: Vinod Koul To: dmaengine@vger.kernel.org Cc: jaswinder.singh@linaro.org, Vinod Koul , kbuild test robot Subject: [PATCH 2/2] dmaengine: milbeaut-xdmac: remove redundant error log Date: Wed, 6 Nov 2019 22:01:28 +0530 Message-Id: <20191106163128.1980714-2-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191106163128.1980714-1-vkoul@kernel.org> References: <20191106163128.1980714-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org platform_get_irq() prints the error message, so caller need not do so, remove the error line in this driver for platform_get_irq() Reported-by: kbuild test robot Signed-off-by: Vinod Koul --- drivers/dma/milbeaut-xdmac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.23.0 diff --git a/drivers/dma/milbeaut-xdmac.c b/drivers/dma/milbeaut-xdmac.c index 3d5b1926a58d..ab3d2f395378 100644 --- a/drivers/dma/milbeaut-xdmac.c +++ b/drivers/dma/milbeaut-xdmac.c @@ -269,11 +269,8 @@ static int milbeaut_xdmac_chan_init(struct platform_device *pdev, int irq, ret; irq = platform_get_irq(pdev, chan_id); - if (irq < 0) { - dev_err(&pdev->dev, "failed to get IRQ number for ch%d\n", - chan_id); + if (irq < 0) return irq; - } irq_name = devm_kasprintf(dev, GFP_KERNEL, "milbeaut-xdmac-%d", chan_id);