From patchwork Fri Oct 25 14:28:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iulia Tanasescu X-Patchwork-Id: 838482 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011002.outbound.protection.outlook.com [52.101.65.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E757E212168 for ; Fri, 25 Oct 2024 14:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729866550; cv=fail; b=A6EHKYpn3U20xe2G96eZxW787rwLBXhfTf0RgS71QEio45bmHo0eoU5tY+4fkiTtXLYJrwRwXvofZft1R3sfgxsCv1SYri/UxUW31U76I4inAcQF123HLEHmlzwUumFq5j/HRCL9Z+5e1cREVRUganWq62r9tkXfcJKTKLRi8u0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729866550; c=relaxed/simple; bh=uNGHJfk0Im/KlhpMqmyZU7fjythUo4s3DU7QpXMRvCM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=qvX/V9yv2Y4RmQOgadfLezvKduRrKhYaVOpa9gd/I6BLmN5AO8IIj9xYZ9mPwU8kfteZwFNZ9l6rLQBck1EGyQKiyrNzey+fioN/ZPMqCjPAb4j4dnN7A1jm1W+q4OGrm9yDXCtfYX1TY8uODa5C2AcZ6e12uEn9fnKKzZzCFw8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=PU8chZVG; arc=fail smtp.client-ip=52.101.65.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="PU8chZVG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VjxlduNsfbfnZnVbSuKG4OoXRtOJfD1MjBF4iBszy2V/emdzOaeM/wH4Vu6hfrE0+0npE06vFcwyjIRVwSQ5eHHAHI+k6F8cC8wuW8MGgSNbrzxsewNME/w4g9rQWVwmLItRwag4W2kZTcLtXGwy9gKSHsiXtp4fYbSorciQoLMbQeRmgW1Ffj2UMW7B6/76Iw/AUB3h4qFYch6f5qXEdHB1pdaZuJhLT7YlWJ5wxwEQrrdnMrvuZEnhAL0VIlXIjpYrudJNcUq+JCXokTbPVfmHA1JzydgkFH7SOqljndOB1kToRDfc/EFMWFhlmy1DTHu1Y/V69ZqZpF6FJNIceQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lIWdNEytyQiLaUQSFA54wTadMX2WebXCnbRloWdg6jY=; b=X0wdUGyHgUwQ/KmMN7+dXd9ci+BBbg/xJ2S2zKeNvKHqqS8QwvWerb/W1ez6Ev/TQY5emcjVZT9MqoduucVTl7iDzZjovWIr2RHsT/l3evqb8W40t47a9MHuZPr/yNd+IeVcrPVIyJ65clmXTlXQKsOo3o1c2/jZPcqGkFlvlIBXy3c6muOSHDmZn5NOStaZyxesj0BZbVN7S+Vo+3WjJcVMGJ8WjiGJWLWwzHtSmDnrz560/+MH5atlnNFZLD7MglkCE1SnbUNsMGJgN4hdZroZhAGrpM19VzJokhxlYwBeMqZyoi0x8Tw9FSpQ2DbwOU/1x88o8gqBAMArPvXWqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lIWdNEytyQiLaUQSFA54wTadMX2WebXCnbRloWdg6jY=; b=PU8chZVGW1vlDcsGkagNf72ir51Rfv2X9kpzBouw1jGH20PhGmVcLPy10QIv/cswfbL/HS4moTwn3b8DzE6XsEjYVbi9t1R0s9B4VuYpJuVZrkhM8hFER99YVVpKi1twKNxitznAESAs83H+tuCm3JrwUT8JpKPd8fZ/KzzVcnsmzDLTiXrDj3/TKdacSsi+JHuGTHr5zrBi7hy0XtE5fE7wD7OxNncpObsJsruzHoDUgTGMIBqeUE6Xc13trm5IhE1i1LomFICZ030o23KQumxm1P5bPPGNgtXwwDqNSc8sK+apEcCdG5NiQJkZxaM+kxTmCmHFg4Ypgptm/BIbNg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8898.eurprd04.prod.outlook.com (2603:10a6:20b:42d::15) by DBAPR04MB7254.eurprd04.prod.outlook.com (2603:10a6:10:1a4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21; Fri, 25 Oct 2024 14:29:05 +0000 Received: from AS8PR04MB8898.eurprd04.prod.outlook.com ([fe80::5e22:869c:33c:9654]) by AS8PR04MB8898.eurprd04.prod.outlook.com ([fe80::5e22:869c:33c:9654%4]) with mapi id 15.20.8093.014; Fri, 25 Oct 2024 14:29:05 +0000 From: Iulia Tanasescu To: linux-bluetooth@vger.kernel.org Cc: claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com, andrei.istodorescu@nxp.com, luiz.dentz@gmail.com, Iulia Tanasescu Subject: [PATCH BlueZ 1/2] transport: Send reply to select/unselect Date: Fri, 25 Oct 2024 17:28:41 +0300 Message-ID: <20241025142842.46566-2-iulia.tanasescu@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241025142842.46566-1-iulia.tanasescu@nxp.com> References: <20241025142842.46566-1-iulia.tanasescu@nxp.com> X-ClientProxiedBy: AM8P191CA0020.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::25) To AS8PR04MB8898.eurprd04.prod.outlook.com (2603:10a6:20b:42d::15) Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8898:EE_|DBAPR04MB7254:EE_ X-MS-Office365-Filtering-Correlation-Id: ccd225ab-9aa4-4c1e-3a0c-08dcf50160f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: Fjreo8MXQR4btC+2McnrlyJO872IhjWH5EDl0wOdLDBqIP2Rgn2XcD/3C/VD9KVWjPbYBZLswxrwv3O8OzMiWrWyFTVMxEkuCv7YbfUK48fqBENYycspumPn2XSEaTGhe7adJ9Z8/MseZjgwOHf8dHb76DLQrpHqg2Qwu0VJS33C+jgRuEeVedhbruFfFJjtcmRGeXhaldtd8O/JXiZwLfaf0hC6Lk6bpSEUC26RrfhPiCzLJJXDaMT8gRMNLRsb63mr4zTF1KqbD3TBHjiISSDcN1AY+ogyQ5dz921+sSyfKBwd4CbZST1OdIgmoUG6KWLr51G37wvVza/NflIdP8gJtIrxQB+HXOPmNoGQ4KsGr/OLtIc0rKDkHXiAlm3KmySewGD7yUM9IIoPNki4ev7AtaYRsZUzSc19cg6QSLdnrN7XVzriDHqRCMlUZFfcd8RkyG/Sb7I/MC88CkDohB8zl0smkI+Iuau5ZT/3cjPTKVu2VhAfFP0IQMV+/ZFD9YVw4+kZZ1WxYwz0Y1AuMo+0V4xF2Z37HyUMa8bPU9zao6NmWpQLw7YHve97yzHOjz7/w8PR8rUJrzFgj6PVmV9tTv32szbR7rvG9u5O2YFmOuEBMP/GPAUDyN2bn7CXJcT/JoRgoLBAxDSo2n5tb1GJ/g3QutqHmYsh6t4p5luX/uzwQuX1CrnJjO+ZhDm++ZnAe3nclACABjjT/maqixmxdmcu6GuTFDW4r24MBO/89nWQ+Fwb0j+U9Gz3+PznpYeGI5/6qlx7XHDMv8BqsOjRQlDwODrQ84a0TbWYFEwwujCM4jscbDwwD1TK/mgShuUbHGG2/Se6yTIOrSs9XnTEYGwnJFAdg6LnnzVOkKwCKpH3SOpg5e6zZ9GW+GhoI/GdZXH1CCSdaKywgqTuxn9E1/r5oWV7pf6WAr9o38oGjgUDpIOLBstbi3nDpePmTB7NZ7wfxEIuCpqK+4YUYuZmnAC86vECy5U+SQFxcLBa/P16TfNHXnqW+8tOeKjbNbKLJoVBdvzCNseUKVTntYAhmpz+az7AkcYe59JG763OQu4bm7N15rfg3yvqoPrkENVNKVsPI3MpbN4nsqSj5qm/+InvpIdlUSBjoU1mpaF8KtfUeJBJ1nPHI8fd01z4ctIQpbmLk7peXRml+X8+0vs52azxdeUCeLvoc+04ubXgsYz3cIz7e6krrLsVP0kX9iW3wuXfm24HY8saQ+a1RDzPXylQcwAwGspk4lS0QlP5xjdcI3h6AyiIOYebZg/O0WlhS+PwdD0j+yi2DmTyTTKt/tw7fQTPH66zbfLdJrbU5vrRIKGK3E9baX+I/s9JG2ujY0PwZ6kJDtDmzoRL8luZgiejktFGPm4A4IcQO1Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8898.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KCkFUTiH2hBmzOFnRQbZJx3T0QFzZSXp3F878n7/4/Xef8FcBz5vKXe6LxVWLVSWBJcoJP46mw73mvBKi8Fipmpj2pgoL7qAbcXm7fMVamDm9eabNC9JswPMXEiVercfRHZqS/nOiq6Kj8uCP2RHPSBQ+/Vxqp0a2xgMoKJM1syBTiBoESgJ14CeoZ69YlCB58sDJcPEjgZq/4/m2kIhDxrEOxu3G5tZmlASRVHV6xmeQb/Q6FQps6VRPJYLeRzlOrGhsZOssemBj2+9EwKV+lwlxc3EsvSG38G+4sPU8OAq6kzm2E/AVdsHnoD6Sh4KfJpBsEio1OJitNvo0hq8GNU4NRpqtAybppC+URQjf2AHjOUXTG81eQWyeoIhSiro/Yv2zl7xxwsfM2w6hRGQ+dlF5kWvc4NoblN65wEcb0M23vldIFSPzrMMJLrKTUJ3FoQPIPF9ZjEthkqTLzSF8FcV0v/z1GO0JD9q9C8zRmnDk2mlL3Z4Cq2nBX1xLEysI56iUZY9tYFO3Lv914SENmO6A1okDQHi+bm7iE3+8RaHcN4j3DUN52EfAwMIWuGYm0IpX9vceO1quiQgLGVvRL4LGQ3idUUI9c4gdKfF0ikHGa/R1CLsEmlXGkyHLAUx2OOImmEx8IdH7qUTgWi6nSBskd8Dxtl44W4wbueQln5iB0LWbMR5TgkQjcYTFztHadmTwO08x62L0MQMMm/r6QkaHKWgD6PgLv0Z7dFufgthMVNXoEUEISSAsxiKAgTD+Zp80PjVr4xJCcofjYejUBvT0NMxzUV38+bBq3LRaDwbpXp/CrrmHzkfLx/YNT0fbMUL2MEvmwHi8zPmfbIf18CjNpK7FyMroFVSMRfgKAxVrhhKOvQFn0Ltr1ifAfe88Dl223b3Z1OC17Awmoo+Uj+kMpo2BC7nz9aLHftE2r85rHY6eJUvBNU2hSEWvYH+UB4nLyUbtRZt0DwV65Ulmi/2JOhYGUvFpA1L7Oc2ZFv5AXY/aPFG0CHtY7XjdQF5SiXTFIGhp5mXvm/3Rg9zJBM5QFt3BSBE4ZY/VryUmZC4Dd4CDQzod2npp6MsNhbFZ/jWFrIz2ep7LzGtiZWZcbRktpCWDDrU3vfj703rEUDKCuE5iiovpokaP+jrApyDmNUj0YqFYBpeDNQi0yNDFIHVRgblu6zC84mD0fH1SF8MzNYee7yVSWZ2Yo5xRYQU7pz72KDAr1TydfnXYqkRQORrEmgfuUq3OmizzE8AgfTMoRPwumZQ2kIh3ZSETPDFHFQSwwxySrliwJTm4ZVUkBDZgUioQVdTceiGpSOzZG5pqzBp75cVDT0XQYCA/47UdwMABoub8jCg/cHjhJoK+OKoPxTXWizM10InNg+1XZesoTnytIFSWKr1aVHgfjbKyHZCSfsM9pTUDO95X2iI/SQjK0WE8rbVEUpvKPx0MHKSdq1YoOjTzZjxDU44wie00tmggcve58KNLhf+NnU9q/cbroUv2P8F0pHc6r251Pl9JS9M28SeHqQm2RyiiZVrAObnnwebChWs5Ib1XmBH2Z/QwlDbULe3qMR37dCm0r/1UqfI3sm1WY4HWhkeAfFsj/SFdoe0lIAuOtUNHcub/w== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccd225ab-9aa4-4c1e-3a0c-08dcf50160f4 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 14:29:05.2223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AkhkmIuHdsmsGKkHybDYlX/cXS+RIetoDBn0UGP5PjX8C1YmSwFkaqZY/lxLWXIW3fzYCl0Gm+Nt/OaKx56HXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7254 When a transport is selected from bluetoothctl, a reply is expected. Currently, if the method call is successful, no reply is sent, causing the following error message in bluetoothctl: transport.Failed to select: org.freedesktop.DBus.Error.NoReply The same error can be reproduced for the unselect method. This commit updates the select and unselect methods to send reply messages. --- profiles/audio/transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c index 68192bae6..bc63772a6 100644 --- a/profiles/audio/transport.c +++ b/profiles/audio/transport.c @@ -1423,7 +1423,7 @@ static DBusMessage *select_transport(DBusConnection *conn, DBusMessage *msg, transport_update_playing(transport, TRUE); } - return NULL; + return dbus_message_new_method_return(msg); } static DBusMessage *unselect_transport(DBusConnection *conn, DBusMessage *msg, @@ -1436,7 +1436,7 @@ static DBusMessage *unselect_transport(DBusConnection *conn, DBusMessage *msg, transport_update_playing(transport, FALSE); } - return NULL; + return dbus_message_new_method_return(msg); } static void sink_state_changed(struct btd_service *service, From patchwork Fri Oct 25 14:28:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iulia Tanasescu X-Patchwork-Id: 838799 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011002.outbound.protection.outlook.com [52.101.65.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A46F1FB8BB for ; Fri, 25 Oct 2024 14:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729866552; cv=fail; b=Yy3Kb7n6+5sKyPD/fVafvZHKXcOwY8lsI1GeSStx0LlDO0ZSby8/VGoXHkMEm1fX+APkRXdyDCY8Bvcr/1WIExdp2tKa+QZKxHFGA7RwgZfkcbGhMezUzOszs28pBnLeQXXnPgJxIpp94pEPljXlNAeGAWvoeMrNiK796qCHLTo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729866552; c=relaxed/simple; bh=+Cg52JgZpTyFa3xpu0DCKrd7cBkj1fKCUXxW9U2BCzY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=bi0wFL+yH9KHrzKUUC43Rv643VtjUmrrlBlAtypKaf+yMQ2iEioEpZ1zHCdXpM1fzV2xYXZqtIdKkjYjtQP0VUc4VlLH7ouR8KD4ofQ4Od5jDFPJOYvHBwkKlyBh+x3aZmV65dmpqC7BvS894QkGGB1mxO7pUCgzUGz9bh3nrs4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=lJCGz1Ll; arc=fail smtp.client-ip=52.101.65.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="lJCGz1Ll" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ao8i9JUJIqhJll5OQVWvuk4cksw8uQLnGAqnmsfspMX5hSszsjfJq5I5L8Lv89weruplCwK8GEU91J0LGtimU4ToWw2eTfAf5vXxyi6IiIqxt+9bpZSS+Jkcn4kYjgExFvdX0UdVrSlkwY8GFffytTZRk3ojBTI+W4JiXlei6Zr82WdlNw8pbxrRdZuaazhcuQuJ+8K7huSTeDKJXZYAc47Nw32S1uQTe9NDI9YwIZ1osSgPLwxVuklTeBB2nvRQ6MLd0QsRkaTz3o51QIFtUa6fmv37ZZMexGGSf4CpiUGX03GmWSaqphkvWM73cR3wtV7Gb9rxftJ2TtkJ2QoJdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d1h52PkuAXPF4cHSIQ1j50LIxazIYFvfJP/DygbF1vQ=; b=ribSD305WWWZcOUls0TBtKntkCnAi5oQHuoB0evzGKYxkq8ykzEeX80Yvl0D5Fzd2K5FmCXDFaAYGYLqpwQRzT8KUS5gCilcs6XB5qs+yCKOQWTbMzMiUhArta2q9ciRksDKiU24Rc+7ZOGDCYxx9FydUS4JdaV21z63U8jpJwP2hKStaTFxHJ8AmSDLkx2MHkWK3ks8g9uPrjot07FTQCkWj8rTkWXBGNICx2/p/tnZ5nKAXOpF/DvGXZ0nHrvqWA9hMqh/rVTr2iVcRwwthhKplbvcVIHfky674z5UMI78AwB8MUPKFTfGdcO3a/tM0+v2nzAIfhY1YDG0ST9jxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d1h52PkuAXPF4cHSIQ1j50LIxazIYFvfJP/DygbF1vQ=; b=lJCGz1LldN6KiGQkvtTwNZDUEfNCCCml2X0EyrQAbyjkK7GhhERc3ykWZcb8rYo3GLlfRcgxVpaxeahwHenyGxwIOLnu0ncEAIgv2J9QFCTOKA8GGFeX8UFLJZK0wB02RrJhi9jMy4ZxFoG8JpYb6cK1M3DgTrAWP/KZConSfpANGuEdfj/x0YzTbqKLBmMu0aI9u3F5T70gW+849I+DGiR8ziJILL//rOUNkX+PJ9XdYoKLqFQROIQLITp9hvqVCSXXtaqnJiJ5pQqjBAGT7GHT99vXxgxHEaJBI+5Tk1vz0cmEYKT3A94ObWe3Jr0Hb0Ala8MkKA1HEG2+JfaEvQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8898.eurprd04.prod.outlook.com (2603:10a6:20b:42d::15) by DBAPR04MB7254.eurprd04.prod.outlook.com (2603:10a6:10:1a4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21; Fri, 25 Oct 2024 14:29:06 +0000 Received: from AS8PR04MB8898.eurprd04.prod.outlook.com ([fe80::5e22:869c:33c:9654]) by AS8PR04MB8898.eurprd04.prod.outlook.com ([fe80::5e22:869c:33c:9654%4]) with mapi id 15.20.8093.014; Fri, 25 Oct 2024 14:29:06 +0000 From: Iulia Tanasescu To: linux-bluetooth@vger.kernel.org Cc: claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com, andrei.istodorescu@nxp.com, luiz.dentz@gmail.com, Iulia Tanasescu Subject: [PATCH BlueZ 2/2] client/player: Fix select/unselect reply prints Date: Fri, 25 Oct 2024 17:28:42 +0300 Message-ID: <20241025142842.46566-3-iulia.tanasescu@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241025142842.46566-1-iulia.tanasescu@nxp.com> References: <20241025142842.46566-1-iulia.tanasescu@nxp.com> X-ClientProxiedBy: AM8P191CA0020.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::25) To AS8PR04MB8898.eurprd04.prod.outlook.com (2603:10a6:20b:42d::15) Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8898:EE_|DBAPR04MB7254:EE_ X-MS-Office365-Filtering-Correlation-Id: b4cfab1b-b8e2-4738-6215-08dcf50161ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: mhzFgEDkYzjryOiC973qekZU3yNBOyagKTQhJ5g7RrGrxGA09HIfl3fQprqo3wGZ/aFqDzhratbxE4lXAaAY+dL4AoA1r0oTWDQHOERhYvDtNg0DZr+gdZQgJXEJ8P206LDR5MqMGijot4ye3Z1pPwG/AKi842uDLLRnl70kFlG3Zzao+2a2sF9zacRfVfMAAeoi6ovQ8OV/yZVOrIEf11JvBovKXNK+xBKa8n0ffqF/yTu0Ke1M0WGKZDc9Y67fRa9EPJs9bUr75oAkEg+vext4b8K4icz1C7JTVTdf0LYKNdBbk8G65oH48OMmBnC8q+Eprwzx2nImCf/6VLOUmTJVz1xKS3Quu0//TAh/fTg6P9M6zy0uObxCbvjExMUXBg2Q8mXEy88h3OBZ4hsikIafZZ7msQO9/Mmg4IX80eOpTtgiC+QVzgdaNoU2O1gVd9o1H3rPIgj6k91UPoC3dUwPQB3y47GWHVTHDDW1XOgkFUHkQbBjckdC110QkeSR1g67O+u+7RoTUJejPJrSocLSndBUswgVenAiZ0ONbnWfi6kZU7if9C4NF/3KeIWLAIQl3ojbmGYek3w4j3jAYKCswT5QxFUMatm1fvkkvyC7gNy9VJcCys108QsthbOmKeu2qC3BvWC4znz/shyorLGGalb47d1/QdOi60TeTyJHdo/YJ8WSQGNYJICV/sYHzjC0af9DcUTeeqjqT7l9bBZ80hAy5hcmcG0fZCShBDs41lD2bPbDPx/Dwljtj2tLIooXs5BL7NPWIJVIEMuxefg9Y6ppIlKzRgSBzPHU2gODDGaWRvQ75yzaOVoPVJsw/qmHa93lsoPm9Vp75XVCY8r2GrkqxlJMc/Zq2J9hmj3Q4+9pM9WZpJ96mJiRLNrtAxkQxZeMZVcwcyPRfC6h1WoU+g+G3iksc7D77q5YKbGOymWQGzJusHjIyiA6Gsr9exhY15sfHzRPNfQvEVE7vU+GCBzHnOiboMtcvHfNDHZKTTTtFy/WVyaDR2PfKSc82yxxrtS0IGgemf80lvZLLwUQa6yMlwVVTugKTHrQfkFR6euDBq9a/7OGRYTN49j2SSZpDaHzh8uxbyfP9pgArbMh1bHREHR+VLIj2X3Cw45i0AgWO0I9Xq0j8aofoTpruYG6Es21VEGu3jsieCWezVUmOF+OEUig+XczkumLWr2GXkh07Th8ELNTUeCJsql/geXkuY07Zy/LSouNW6tfj/iqqaIm9OwbzwPZQyp1g9lCATc7pPu3yYE6/Q1AEFunne1zZSJ+f8XyXgaZ0eVpzkoQm32D321UQ7RB3T9vKAIDAUTOOicOgeMgvyALoBpIMLqJehX4jQdVBommwOyPcppO8EU/oNCXZVDnPbT0FG4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8898.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cgEUUNDkHBP3kZnt+K0Jj5/9DtiyiO+IQvX6OanMD+QWKi8hra2LEgsh3UdUtFpFbX4kznY9HJ/7e2OjZEiC8yqB+kw6iZQQRyaIBfRvsGzP17HYthpguODMPp8n5daZydQUWJd09ynhdrya1US3m6HuYCTK+0pdc99Vp7jEN3fxoEVOLh3I9jzMiFWNXKkhQChSetI43Qjcxz8U4l10yFrGtvILZSX7bwm61Pl9f412wZzWVc6diB5Blw3nT1IoMzPYR0O2fDY7lYQky7bmlJlb8i3G3LBs3/xoQrWDTg5TGJO7iv9ib1+zfM6YFAbJ1JrY/VxIP7lieWsrm3fyJBMPE35kO1q+qFcZlakSPHS4rk1zCUDVkM/UvT7hXWm1tjWAxQ12PVegFiI/0jfJqFB1EsOHDFHjIAn3f8Xos7fcc1oRWOADtZhs80eMj6a9OT2ozU8lS0N7Wmd8LbauGcu8PjcsEQ4PHFjbYwixik9i9gQU2m4TUMdxyaMpIu5Hc7fhM0bYS9wV+3ufao8YjKPS9NwVdxTofivuzVSVCiCXuIzrVM94jN9i/lhQvP3lH/SZir2DviSRkx4MSeW0SHLZW+3vZG/lFa/KrQSLYgMziFQeJM4elmpJmSgAXJW0MZszOcFdd0BzdSk+o22q5L9AKnFHiFCG0vnAKb0vHKXIbg4cMb3rvWSZc253AHR3nLbSEQtSjlkh+QMT5cc7Nlb1EKHmENnR4xGebCPW9yaTU3haTwW7S9OXJHS8ZAtwDBvoig+tohJATn5HFdy7SnoDybArlUSXpKyBdQVcI5okFGDjpiWlPfAZWqGndyCeJ8ynnfIaw+FTw/H6kiugMM8ajiM70GnfQ3CTvEnGVfl6tReAtxQKeDjGs0p3amBD2GQdYiq/xdDow4Uq/CjutGOxJOl/VGvQDQ6eF/LI4RGSgF7qSAzzVUFw3lQEGF/HUb9OVHsZLNUbyDqHr286lrUr57eGe8Xd1rHpNa3ZsJTNaa96yBr5y6hMPN+Fd39rufu60/x7glCPgPKAvZ4lvOwvY93KQCe2+ahIrpTWBVToQR5uFZFRTQrL24xOUqlswpYa8fkped8hrDcw6+146eDGB4pz2gTFBw4fDYAE5ic2QznBZyGfB+YzHuUJDEHREu0S9tLiuv8+XYb/8s7082NLtGL+AM6bhXQmzJJNPIlMsBiacL3Mc2q2FBUnZaNEr+nXYnRQrdYn5utkYWw6EQSPB0snSQpmp/VP8sRzbXOMUz+rOf8AGyejJZrjjnTmWW3Xo09Q/SuHcel/y4KsHBo+uObKXhK7fcRR+XcsMkyJGW29pDwOTHG90WfifR9NTt95+Cbc0yRZldlS4nLZHHaf9Rv9SBOCzFywLtTIk7n6+/YOXtEJ8ko5/M04jceg37nzphPQ5s0lmpcxisShkqlnB+dQitU8sWMUdUxSFAQ1dAHCUPOHB5UW66UysoqVdgsJCy94aR+pJw/7uxeNoyZN7YeFt/hBwmBNmUoe1VlyKT1aGUcysaNWT5Inj30/5XrAE2A6EyeGsnQQesQOehfJWi/Nd3sjzZv8y0MUyX7Kz+pFgBDjHefGrCVB5HXn+sHgdvX1CWvfzV7FwBL3Tg== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4cfab1b-b8e2-4738-6215-08dcf50161ef X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 14:29:06.8074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 38dX9IOdkzmc7Mwy6yIOm/09MuqBjFopW+vkDV7CHVn5RmurKbi17eySMZO7RpbBBViGrsG1tZg+WAhIFxhh+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7254 This updates the shell print messages for the transport select/unselect method replies. The bluetoothctl log below shows the fixed result: client/bluetoothctl [bluetooth]# endpoint.register 00001851-0000-1000-8000-00805f9b34fb 0x06 [/local/endpoint/ep0] Auto Accept (yes/no): y [/local/endpoint/ep0] Max Transports (auto/value): a [/local/endpoint/ep0] Locations: 1 [/local/endpoint/ep0] Supported Context (value): 1 Capabilities: 03 01 ff 00 02 02 03 05 04 1a 00 f0 00 02 03 01 Metadata: [bluetooth]# Endpoint /local/endpoint/ep0 registered [bluetooth]# scan on [bluetooth]# [NEW] Device 17:7A:80:64:A7:93 17-7A-80-64-A7-93 [17-7A-80-64-A7-93]# [NEW] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 [17-7A-80-64-A7-93]# transport.select /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 [17-7A-80-64-A7-93]# [CHG] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 State: broadcasting [17-7A-80-64-A7-93]# Select successful [17-7A-80-64-A7-93]# transport.unselect /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 [17-7A-80-64-A7-93]# [CHG] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 State: idle [17-7A-80-64-A7-93]# Unselect successful --- client/player.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/player.c b/client/player.c index 188378175..7a0631d2e 100644 --- a/client/player.c +++ b/client/player.c @@ -4870,7 +4870,7 @@ static void select_reply(DBusMessage *message, void *user_data) return bt_shell_noninteractive_quit(EXIT_FAILURE); } - bt_shell_printf("Select successful"); + bt_shell_printf("Select successful\n"); return bt_shell_noninteractive_quit(EXIT_SUCCESS); } @@ -4887,7 +4887,7 @@ static void unselect_reply(DBusMessage *message, void *user_data) return bt_shell_noninteractive_quit(EXIT_FAILURE); } - bt_shell_printf("Select successful"); + bt_shell_printf("Unselect successful\n"); return bt_shell_noninteractive_quit(EXIT_SUCCESS); }