From patchwork Fri Nov 1 00:27:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?KO2VmeyDnSkg7J6l7J246recICjsu7Ttk6jthLDqs7XtlZnqs7wp?= X-Patchwork-Id: 840252 Received: from SEVP216CU002.outbound.protection.outlook.com (mail-koreacentralazon11022137.outbound.protection.outlook.com [40.107.43.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ADA91C6A3; Fri, 1 Nov 2024 00:27:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.43.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730420886; cv=fail; b=S7rZX66fhJDVX07p3RMJ0Uy6yEFiY0R+rLG8Q6N92X14f/lDVaFALaAeiKqFmGMVxsD704rJazwY0YUX4mzSZwiPniwQv0BM9IPUsM6Eyr5kut8D3YiZ6nHbYaPmLhVKEGcwx7d25/4t9OuQoS+XXvY0K+U+/jxImMq6oH5JNjU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730420886; c=relaxed/simple; bh=c+JS1mlnx4+MbGkg0am97YrfTp0+JS2YJSpBuQsLT0I=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=jEDbfMXMD4nIxuIbEwpoclttu2uBU1QlBxg+i8vkAo3XDXvZn/GXgSRlMUyETbNfVKM5rAzXIYy7iT9t8ngWQ0so43mXyaKfDo2FO9fK+gWPhj4TgAGi85khf+XaaxF9ueHdtURM4aWXOYvD8H2sJwh3lcvRG6AzJ0u7xAONJ4g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=unist.ac.kr; spf=pass smtp.mailfrom=unist.ac.kr; dkim=pass (1024-bit key) header.d=unist.ac.kr header.i=@unist.ac.kr header.b=dzt0hhTU; arc=fail smtp.client-ip=40.107.43.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=unist.ac.kr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unist.ac.kr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=unist.ac.kr header.i=@unist.ac.kr header.b="dzt0hhTU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n4OXfb6l37sA9eTiDv5dl6bbDPQrKo+w2z0G/QP3LqOCFrA8JHaoScp6mDGmKRX7Zzol2XTU+mEbMyVRfSj27n3d7NfHAPQ7MeqG9LLGjJ7LfdfRfJvn7UY24fCITf3wRqTmiNCAFQ4q+cBxm6/wfE0irazyPXkvrYgT+d/TwVhQ9ovTEKl5JimqB2nYTGzTvKo5lb+JaImsw2gOYHR8bFi1ZQuje+GgrvbTRpMgKC7DnGNVEmYzOmsJB0sklM7+Po05LzNKxs4bG8oJEcqlPLYzLZxcEysUiBv2lNFYU9KzUd6QKdiZ/R76N2eNCwk9iOD8UI4nzAkd9jnTQphbvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c+JS1mlnx4+MbGkg0am97YrfTp0+JS2YJSpBuQsLT0I=; b=wZhRZ6pG6VZiZl/AGzTdlY2fnppqEqiI+rzYHKvZZQUiTyakiw/jOUTpp5MmmxF4qK0q6hii2XOJ2llsdDLQUoEEaW86F2b3oG9Pzy1CrT2X65Pv/iTQ0elCZHuz/VXuG4bJWy3eNHxCIjFkB13q6NvtrrUsTWyYBWcSTKz/oIYRzc1e072bxgcmF/MIk7EIVDDJgZJH6mMHp+cIC31GTbnHvCTxpEb7tm68dHlAcglvf8+Afn0QGM2dm+ieE/j3iRdctFuFjOxQ6saJOCPVnEaGvTU9B8QYOIUbePfPS36RorXxJybbC8ivH6A29TV+Z3erirRem+f/PtrMzJ/aXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=unist.ac.kr; dmarc=pass action=none header.from=unist.ac.kr; dkim=pass header.d=unist.ac.kr; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unist.ac.kr; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c+JS1mlnx4+MbGkg0am97YrfTp0+JS2YJSpBuQsLT0I=; b=dzt0hhTUgpk9ISMCZOKYnIstHgc0JwQGTCihW10Gp1kyaAR3SD5fKLlk0NloMmi3DhcHFTVJlyLMOabkJCktG6zEZmvmVHs8BNGligYnidTUOwrRX6VXjIcGu2LANaSS0DwhyHQuokksm0TztqJxlbZCBcf4D8lkSMMSb1jWbnU= Received: from PU4P216MB2281.KORP216.PROD.OUTLOOK.COM (2603:1096:301:12b::12) by SL2P216MB2109.KORP216.PROD.OUTLOOK.COM (2603:1096:101:155::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.25; Fri, 1 Nov 2024 00:27:56 +0000 Received: from PU4P216MB2281.KORP216.PROD.OUTLOOK.COM ([fe80::40c8:79b6:9574:33f0]) by PU4P216MB2281.KORP216.PROD.OUTLOOK.COM ([fe80::40c8:79b6:9574:33f0%4]) with mapi id 15.20.8114.023; Fri, 1 Nov 2024 00:27:56 +0000 From: =?ks_c_5601-1987?b?KMfQu/0pIMDlwM6x1CAoxMTHu8XNsPjH0LD6KQ==?= To: "James.Bottomley@HansenPartnership.com" , "martin.petersen@oracle.com" CC: "njavali@marvell.com" , "GR-QLogic-Storage-Upstream@marvell.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH] qla2xxx: Fix START_SP_W_RETRIES checks _rval with positive EAGAIN Thread-Topic: [PATCH] qla2xxx: Fix START_SP_W_RETRIES checks _rval with positive EAGAIN Thread-Index: Adsr9L81tsSQ65OtRyaJlDxp16PgvQ== Date: Fri, 1 Nov 2024 00:27:56 +0000 Message-ID: Accept-Language: ko-KR, en-US Content-Language: ko-KR X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=unist.ac.kr; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PU4P216MB2281:EE_|SL2P216MB2109:EE_ x-ms-office365-filtering-correlation-id: 40594038-2dba-4eae-998e-08dcfa0c0813 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|41320700013|366016|376014|38070700018; x-microsoft-antispam-message-info: =?ks_c_5601-1987?q?RvdR5d6f60RcPatfRtXfnb?= =?ks_c_5601-1987?q?BZtGg685uEJzJH1cNFWDUJDXSQ6X/plkL9z3g13xyqd8KiIOXrxZRnJS?= =?ks_c_5601-1987?q?DCusA3YRkrNqTTe/jq5cy6Q6sBRWcLikj1Q9lm9wDSKrQJXQUHeUeVsk?= =?ks_c_5601-1987?q?exqiAiMovcTVhnHvOmv9x/MtjbhJ/PyDLytpcAv0tE5u2UITLuyXraYI?= =?ks_c_5601-1987?q?R2DnCCVCAAPrTj8+wmiI61kF0d3H0FhlpdB28I2mWaL01iFUt9m/5LTa?= =?ks_c_5601-1987?q?sSKu0Augv+/LKgL0LSwNIiE/pOoSHnp+6WiG+6Ky6LCVlBZe17gBkLCG?= =?ks_c_5601-1987?q?OR8Mq4CIp2G4GHi5FL3FzqQNl86CIg5r1mhXi8m2AG1/JGjp5oGPCziJ?= =?ks_c_5601-1987?q?hG8EdrF3/vGOwz7wGmcNNVwj1XJtwhm3fVXbEcl0z4seEj3dRl4l3ChR?= =?ks_c_5601-1987?q?2CiZAZ28WHamicDCSD0rp4qKPDfbsLu7B7m+G0a50YS7pCjF9af0Cq0n?= =?ks_c_5601-1987?q?pP1Iz1RqQqHHrhsA2qPM6GGbRLUZpsXrDTtbdM/9qwlR+W0C4dAids4V?= =?ks_c_5601-1987?q?DkkMzHdniVzJ3fnqv1fcarGQ52o6LR9Khgj4/7aYHXS9hYK8/5HGAp71?= =?ks_c_5601-1987?q?16lsmOP7K9AiumtREYx+XArAA13/vgfg7ZOnY48Bf46QZVVJf1eR9jQr?= =?ks_c_5601-1987?q?mL8KtEyadoeJf3gcxoYpLBykbRibeTu/2nnEy6XmiKhoONOv8RpPYW+e?= =?ks_c_5601-1987?q?ZlKanEURu8Jboi5qxSdXi670NgDYM7UldOlnVOvSpHPuUiMvR5tqMfRT?= =?ks_c_5601-1987?q?PaYX21JNsYMmAPqSDYA25Z8jMEIoQU2AlzSI5fDGidNTU9wDGqCTdRpL?= =?ks_c_5601-1987?q?uVCnfMnxSwq/wkwkmdtDa4Uqe+6DWIBUafzg6aULXoJvnMHo34a4fAja?= =?ks_c_5601-1987?q?TXZeqbYUk019TuTXyLLNK8aJXT64VWRPLsuFBArKB4lOTIncd2b38kXG?= =?ks_c_5601-1987?q?05udcHM4KrQGxORkzALCRmiFmYqpO6u6uj3f51YzYbty6p5trGhEJ9/0?= =?ks_c_5601-1987?q?GhnSgC3L3f3hxHm20fIkBzS/2yA7bgNYqnC0c68Zsj569zayOEEylpKy?= =?ks_c_5601-1987?q?U6qoM+j9HoHNvcm/IVtAkVKQXo5iSrNoJ2TF4Z/b44ig9jBhoL2P6ztc?= =?ks_c_5601-1987?q?6K5b/izuLujqiDIIb8wxny3fdiHrBetrF0C2H84oSez46+nY7DKh595R?= =?ks_c_5601-1987?q?hrmE8OQORaiJ8szZfjBCRzA17lRN0/Yuu58mawNWA/JJOevUVb+nYVbl?= =?ks_c_5601-1987?q?Fr40woN8WrVgroYwr/L+xG63VDSvNTlFPXjqYrxbWip+FEzlQQ6FKMia?= =?ks_c_5601-1987?q?wpB3gjx1m4JVB+0VesNg6BpxrVEwrbjUgU+lmvz8hbHOv0fz90PYePqQ?= =?ks_c_5601-1987?q?HyssOJ/9Q5qPiQ6PWYKaCjnan3V0Jhz4fZOx1DSSto+76esLJolvDwOh?= =?ks_c_5601-1987?q?k8ucr0qM2VgQsrAi+GlNQ=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:ko; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PU4P216MB2281.KORP216.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(41320700013)(366016)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?ks_c_5601-1987?q?qcMbyjp+liLa5qtWkzO?= =?ks_c_5601-1987?q?h/+4GjK2CACFE5pTosJChBbfcC6XvhZa41uUu3lPkKnoo3g3aSyUdi/c?= =?ks_c_5601-1987?q?gkoaRLtWT5REXPhACAt01OU0JhiOTKcbYdTdy2J/pz7RAgk6zVP5bixP?= =?ks_c_5601-1987?q?MIHuGGEzuHRrN3pzckR+8QyrJUBtkVh42Lf6KBm83nLnfpyZB63ZE+pt?= =?ks_c_5601-1987?q?LDyPMN15TN3oIGjxuETF8at6k+Pz5Glm3y/a/maPZfQk9wbYw5EhNI0+?= =?ks_c_5601-1987?q?806tzCV6RX8/5NLmY3q9H8T3qXtaMjwl5/zFl1SCe/sVUtcPExq/lv3C?= =?ks_c_5601-1987?q?CcdsDSGBiGbNyTawdBL95N/8+/+uYrrhxZnZpwj0VY6pXBfXwqTvF8QW?= =?ks_c_5601-1987?q?hGFl3xDTc+emexrZyimNVRoUSZuh2FaoxxDnYF+9AuCKKuMMSGzhBbKY?= =?ks_c_5601-1987?q?owErw5bucOHvrvSIjY7vG7tov2u/UZBwmzFP2C91lCJtgt1Jrz+9/kMX?= =?ks_c_5601-1987?q?Qr1BSTG2Rp+BEGQb/ZZd30Gb/Xh1uPpceswdOcphOd1Hz5L/EK40v24O?= =?ks_c_5601-1987?q?PbaFq7/8L/NQ5RKWQv2LJP3U9pMfHADB4ztE5zJd8MkHYZnDnPDjVXeU?= =?ks_c_5601-1987?q?8t/Ni4xkHa+Pv2vK9LxHow0qiC4k28IYb8yGi+cguA/kUdlDm2A6DVwa?= =?ks_c_5601-1987?q?Y9IvPh9nbVNsAV4Mb2mA7cv4R22/G71OfF5BJmhl3hEo5AkbkxqdbgkP?= =?ks_c_5601-1987?q?IbtKvK7qa0ep2D+3XWpbKCXKPlOyrsFk92MtgaIp15GvvpjvDGyC/Ji+?= =?ks_c_5601-1987?q?Ghg5CpCo+6s19lYHJT8n3qVLPtLpwX1U6VAJuza5D66/nsHPPAxLTY2K?= =?ks_c_5601-1987?q?NBRjZJmz+dES3c68H5bKDYEcUExsq4seJrILvQGLoYZ02WFRoBMqNQHi?= =?ks_c_5601-1987?q?+uqQh4E5vBDYv0b2fO6OkY8m+/1DK/E6xUJqMweT3WVbWwh8J0x9H/zy?= =?ks_c_5601-1987?q?mtztdLLJdQBm9421ldRu7VM3wJ5yRG+L5IGINt6TRYyFwqqZFmvnWa0Y?= =?ks_c_5601-1987?q?cE9hHZf5HyKq2RKCkTyjvsgUVMsHL06skEr6n8PuMSIXI49IMD3e4nqT?= =?ks_c_5601-1987?q?3dL2NQ5+64tSVoetftexbWjziVJIDYVp8EpSjqYpw5wnoEeK3WfZo7b1?= =?ks_c_5601-1987?q?JJq/lFPv3/EjNy3umw8MR8iU+sIArvgKxI+7Kqrh5o/I001rRPzGJECx?= =?ks_c_5601-1987?q?EMMvWm4LpQw3tnSb+ke7ml9SwyC+bymQNINFixSrq4w2PWiiykVVMwIM?= =?ks_c_5601-1987?q?VCq61pbb5eFM3eh8KC46NxYwcwQCxMzlJK4sYXneKksI2vJiFR10NCIF?= =?ks_c_5601-1987?q?y/K4ueC/W8pEiCyceIpRL5ObP/vX3xwhVhRYbqBNyZd+RBcniVy/fO7d?= =?ks_c_5601-1987?q?j4xuYcg7rAkIGqn/dR/9eXd+vB3cD0kZDzNExS1X285qgqNXwBuJCGa6?= =?ks_c_5601-1987?q?4ZGRQoYlwgv/pa2B7IoG7rNty9p8gP/Qx9a3uVqMWjtx48h/YtZ4dWN3?= =?ks_c_5601-1987?q?VIVtsZFUF2fgcD0XsqNpaaR8u92ESjRm1cMJlfunEsLhC80NGMQZJXx3?= =?ks_c_5601-1987?q?PzPvoi32riO8OAAxAZMuLPi0FAq7BEBvpokHHB3VVAIk+o4/4hkIAal4?= =?ks_c_5601-1987?q?/eZcPuZlNxnM65t6dpVeAGDf1Y5eTKrxzow0Z0fTt1Z1/V1yZEkJkv9i?= =?ks_c_5601-1987?q?8o1UN5vppcK0k?= Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: unist.ac.kr X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PU4P216MB2281.KORP216.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 40594038-2dba-4eae-998e-08dcfa0c0813 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2024 00:27:56.1393 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e8715ec0-6179-432a-a864-54ea4008adc2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ABCEHFdmm6P0hIy4G+Kof6OGb8oNh0Ec7Iu6qc1+wul+bDi9CEw8DJRhPLfGTQPyGTWm920YMdV5Lm/xRhYZNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2P216MB2109 >From 6f450e20d42c29c623654553831bcba74a566da4 Mon Sep 17 00:00:00 2001 From: Ingyu Jang Date: Fri, 1 Nov 2024 09:17:10 +0900 Subject: [PATCH] qla2xxx: Fix START_SP_W_RETRIES checks _rval with positive EAGAIN The START_SP_W_RETRIES macro incorrectly checked _rval with a positive EAGAIN, despite qla2x00_start_sp consistently returning -EAGAIN for retriable conditions. This mismatch could cause improper looping behavior, failing to retry as intended and potentially leading to unintended results in the system. This patch fixes the macro to handle EAGAIN as -EAGAIN, ensuring consistent error handling. This change prevents any potential misinterpretation that could introduce unexpected behavior. Signed-off-by: Ingyu Jang --- drivers/scsi/qla2xxx/qla_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 31fc6a0eca3e..763bdcc47567 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -2063,7 +2063,7 @@ static void qla_marker_sp_done(srb_t *sp, int res) break; \ } \ _rval = qla2x00_start_sp(_sp); \ - if (_rval == EAGAIN) \ + if (_rval == -EAGAIN) \ msleep(1); \ else \ break; \