From patchwork Mon Nov 18 15:12:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vicentiu Galanopulo X-Patchwork-Id: 844215 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D1121B219F for ; Mon, 18 Nov 2024 15:12:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731942776; cv=none; b=RE2UmeDt6hTYphEXuNh5IZ5jkLSimouoovn9UucoanKOYVe49jbEi5CfxZ2UpAQ0St2dTGhZ9iV9Ge/xRhctFiOcfqJCUXbP7dKaEw1FkqpiqmkLFXFbp2YcR9p7r5R1FrUgYICxBsnTKVWN2/REKHIOg7t9qowtHRmuXOMJy+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731942776; c=relaxed/simple; bh=EbUd2+Uk9VF6AmI7jko2szQABwjudyxSbk/plvWGwiU=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Clnw6VwfEUjMtx0/i/VFskwuWQ61GNbFsgw6ubXBjT2EHR0zRpKajxxfoeG5bMrlpn1pJszGGDFpw76t1YXN9ST1iac2uSskcXDmZQpbiFPHeUDFPgsXuz0aUAOTBFxYPkNXnyfi/ublY+w/H0DVcMGHorCTIMtBEhE7hjSmoY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=remote-tech.co.uk; spf=pass smtp.mailfrom=remote-tech.co.uk; dkim=pass (2048-bit key) header.d=remote-tech-co-uk.20230601.gappssmtp.com header.i=@remote-tech-co-uk.20230601.gappssmtp.com header.b=W9i5MBNk; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=remote-tech.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=remote-tech.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=remote-tech-co-uk.20230601.gappssmtp.com header.i=@remote-tech-co-uk.20230601.gappssmtp.com header.b="W9i5MBNk" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a9e44654ae3so537450366b.1 for ; Mon, 18 Nov 2024 07:12:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remote-tech-co-uk.20230601.gappssmtp.com; s=20230601; t=1731942773; x=1732547573; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=tI7Buy3amAiI+3eJ7b453h1BbqT5wHqViKWf67eK67g=; b=W9i5MBNk4IPqFEWIY/qivpqAkCigZwJEtLgcBZrgg8VFoigEQblgQ0HAPNIRop3nxq 6UbPxk6Qse1bvMC67ZngI95npQT2nWTxv4X8U/rlfjYi8hk1dUc5nfsSMT1dMpRw2J2i 71oAu2UGGkJ9YTWB2ILXHVy+uysKeUh4YEzZ7p2vTyJ35MDnUp3I6YXKoutEXyost8Al 7KiS9QBoF2pnmHlJl4hCDlyKJtk7mSoIaFmZVjyldLSBMxShiUwI8eZTUzMIHmGwgxJC xBFDUNgZtpMGDjcCbZ3grm1HF8dPxix2xNyq/Ts+EfWX8HQlhzysRBlZv0S3RmVHB4Qr dNCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731942773; x=1732547573; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tI7Buy3amAiI+3eJ7b453h1BbqT5wHqViKWf67eK67g=; b=tZWu2aY+PZuNh9EYjIOGj7QoJERmOeQB0Bgl+Ylr+FzKuY/or5yckK7vnMvuiABbCx IZROlscYYPoPQ4p/BuJkGd5PLzQjAPzTuIZtv0kra7Z7hxpPqqbkes9JDbNZFgp/BrNZ s07Ey9u0U8nM2XJprSIzfWtQ4HLuPT9yPJ0JIV5ss/KrDFnqhKE3CYh+Yuq+AoGn6l1D z2TOz0vzj2ay/srHisVcLcPk6bd5FxiQrYVtuF/SmkcjUpAWW2af7GIrdujHywNzbXqg S/h6hfX/DjN1SsEgv/F11O1T6UNb9zCVMTN61Ruh2arSp4jyR/kxBrvk2g5uqXHYiM9a iolw== X-Forwarded-Encrypted: i=1; AJvYcCW5V2jkLNoLaik1uuf6bxsukUo0v087tG/7NoscDSreTAFliitayNtcb0AQqw0ba/J9ng956x5pR/X3@vger.kernel.org X-Gm-Message-State: AOJu0YzC/UCvm0+s7Ni4AoSJVQdEcyiiPPKV9UTzwL1QCiYPzrvUXh3b Lej5Gr5TY8bn6tsiqcGhpY8HafDl/yWtHuer+h42sQx2qeZ0evrwIlprr2UaavQRQT8HR9ZxhTO VE3ewbwwqM5P3oeH5Y5st7RfqgdMZNpF7XnGnpVleZw657wFiZf74tU5apftlEIwfxXcRWgU+TW Bi2fhFaC8OdE6Fh4Hg17Y3PGi7 X-Google-Smtp-Source: AGHT+IEAYf4xmFWVTTflHZgV2BGLLkT9aLVMx/4kAcNcN86TWJVZ9ONrVKNWdTzRkcgy+sJQDJ1R5A== X-Received: by 2002:a17:907:c24:b0:a9e:dab6:aa10 with SMTP id a640c23a62f3a-aa483507feemr1183398866b.41.1731942773476; Mon, 18 Nov 2024 07:12:53 -0800 (PST) Received: from localhost.localdomain ([178.27.36.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20dffd7e7sm548980366b.119.2024.11.18.07.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2024 07:12:53 -0800 (PST) From: Vicentiu Galanopulo To: Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Vicentiu Galanopulo , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: [PATCH v8 1/3] Documentation:leds: Add leds-st1202.rst Date: Mon, 18 Nov 2024 15:12:41 +0000 Message-Id: <20241118151246.7471-2-vicentiu.galanopulo@remote-tech.co.uk> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241118151246.7471-1-vicentiu.galanopulo@remote-tech.co.uk> References: <20241118151246.7471-1-vicentiu.galanopulo@remote-tech.co.uk> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add usage for sysfs hw_pattern entry for leds-st1202 Signed-off-by: Vicentiu Galanopulo --- - Changes in v3: Add leds-st1202 to index.rst - Changes in v2: Implement review comments Documentation/leds/index.rst | 1 + Documentation/leds/leds-st1202.rst | 36 ++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 Documentation/leds/leds-st1202.rst diff --git a/Documentation/leds/index.rst b/Documentation/leds/index.rst index 3ade16c18328..0ab0a2128a11 100644 --- a/Documentation/leds/index.rst +++ b/Documentation/leds/index.rst @@ -28,4 +28,5 @@ LEDs leds-mlxcpld leds-mt6370-rgb leds-sc27xx + leds-st1202.rst leds-qcom-lpg diff --git a/Documentation/leds/leds-st1202.rst b/Documentation/leds/leds-st1202.rst new file mode 100644 index 000000000000..e647966e496c --- /dev/null +++ b/Documentation/leds/leds-st1202.rst @@ -0,0 +1,36 @@ +.. SPDX-License-Identifier: GPL-2.0 + +============================================ +Kernel driver for STMicroelectronics LED1202 +============================================ + +/sys/class/leds//hw_pattern +-------------------------------- + +Specify a hardware pattern for the ST1202 LED. The LED +controller implements 12 low-side current generators +with independent dimming control. Internal volatile memory +allows the user to store up to 8 different patterns. +Each pattern is a particular output configuration in terms +of PWM duty-cycle and duration (ms). + +To be compatible with the hardware pattern +format, maximum 8 tuples of brightness (PWM) and duration must +be written to hw_pattern. + +- Min pattern duration: 22 ms +- Max pattern duration: 5660 ms + +The format of the hardware pattern values should be: +"brightness duration brightness duration ..." + +/sys/class/leds//repeat +---------------------------- + +Specify a pattern repeat number, which is common for all channels. +Default is 1; negative numbers and 0 are invalid. + +This file will always return the originally written repeat number. + +When the 255 value is written to it, all patterns will repeat +indefinitely. From patchwork Mon Nov 18 15:12:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vicentiu Galanopulo X-Patchwork-Id: 844603 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E7D41B85F8 for ; Mon, 18 Nov 2024 15:12:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731942780; cv=none; b=tq9aXU8sN8pNbcbBFCr2kbe94hnYMvEa68GQAlgt5410RMlEhmyWcTswliTcjpgwWF9qghnkzCmQqnvBYnelORr3sFIjORcjpr0WuidOhwl/Zm+EdWC0bs1Zz0WB0Ujekw7w7+rhk50WvzLl4dx/MlmBQBW+sikaDyTSH3dERNw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731942780; c=relaxed/simple; bh=/rk98YphhHbe/ZYSTzfJFAmQ84Ek4SJoyxchXfYoArI=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FeR5uQYQYuUWVpGuNV34QY/EKUVqgsigNnhFXL3zeaM5MZGIQEF4PS63K2xbcevP+Dufdbj+FKpv/+EO0EOHczNHa0DzG7iShGQh2yP1djEi4GSZFp2tjSJL4Od/Z0fGY7mkq6SzfXse4cQYR2Cgew2oBhVC60D7xprW2AZSDrs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=remote-tech.co.uk; spf=pass smtp.mailfrom=remote-tech.co.uk; dkim=pass (2048-bit key) header.d=remote-tech-co-uk.20230601.gappssmtp.com header.i=@remote-tech-co-uk.20230601.gappssmtp.com header.b=VQ64PJJ2; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=remote-tech.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=remote-tech.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=remote-tech-co-uk.20230601.gappssmtp.com header.i=@remote-tech-co-uk.20230601.gappssmtp.com header.b="VQ64PJJ2" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a9a6b4ca29bso491794866b.3 for ; Mon, 18 Nov 2024 07:12:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remote-tech-co-uk.20230601.gappssmtp.com; s=20230601; t=1731942777; x=1732547577; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Xjtc7Bjar9DjwKzmJO26f3PuO3HlGp9yAOlHl5sQvtU=; b=VQ64PJJ2VrIDl8GtFFWl341z2SyBWFqyo6EvFDSCbPzqLL4PH2trew2xzGvoSfveHi 2GeWVbUSj/VDPVjCposaj5CRK6kCpMsVgZ1XK1nWCi93UDy/mLlEx8b/fuLkCxn4KHs1 +owQDPl6THTh8Eek5V/DUHn8wLdD6vbWiq/tiptikeEeyLi/6yoOq3RPOJgmvzF1gKEp fn0E62kRDpRz/N9vAp0UEi40dZaDn2WOfjE7bZVbXiFy31CyGe59URuqd5trSe/iIdK0 Ci8PzO8+SKq8uiUDZ9DWfQEcLKYsSkoJaTcLTNjTM6ccB1oKZs7coPvsP2cx5HtLX9Hh igEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731942777; x=1732547577; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xjtc7Bjar9DjwKzmJO26f3PuO3HlGp9yAOlHl5sQvtU=; b=MZgcs9uXhGKZx6i4hgFzO2oAnMGgmMkB9kjBZ4i2+IOsZnLiWMb8sAw3UvtTFF6DSz DdM2bSAy9UJPuTqe6iDtQrehM/AuYRDV6GskyyfBnwGF2hAjJwgZj/SyYkZ9XSZEq2q1 Gxup7bzKHeTnMzn3GGeAQ5diHlr1ZXpIv8bL023eRGDHl1pcqi7flyuwBbG4NiAQCi1/ mmjg3qPPJD+yIoQz5rIzoo+biSZAO8i6reC0wWLAwOOG+mzgTarp01ha7QUqhlxv7fDH Yx+4pxH2pw+yIrS+aG/cFsT0O6La/FuISMjxv0J9enIFfQ8a8379u7nH+BfXvyShas8C FfTA== X-Forwarded-Encrypted: i=1; AJvYcCWDbwKf02Czkx0aC4BqrtfairiF17i2FeN5UyzukCLt/wip3yIu86KLpN3IDN1/GfqWyq2VbmV2wBLf@vger.kernel.org X-Gm-Message-State: AOJu0Ywnp2DIL+5hnZYE4DyQ2Txbg95xyrZXffDPfU4e0a7uxg5iV5yJ hpkA/jR5o69ddkx82dfhRV3Txa+njZBvSHGU7TCBnR40A/lTkUFUpxiCN9qmA0MJIiR8t7NJf/B 7Xk9zgaXdJz6NaL3ModYwxUF64HtI4FTHwhaTAie8oMUuOeKCYRtKmeJPMqAROysjVrWGBQKVMl t7mvSj7ZZQr3/FVfnVALasGYu+ X-Google-Smtp-Source: AGHT+IGn01qYxrkcgGk2ByU6YeVaMXTuwkTdujmrjKD2QI8hgy9MH0U2YQBR+0wavI+Xp12OZASqug== X-Received: by 2002:a17:907:3f8d:b0:a9a:597:8cca with SMTP id a640c23a62f3a-aa48350986bmr1111621366b.45.1731942777116; Mon, 18 Nov 2024 07:12:57 -0800 (PST) Received: from localhost.localdomain ([178.27.36.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20dffd7e7sm548980366b.119.2024.11.18.07.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2024 07:12:56 -0800 (PST) From: Vicentiu Galanopulo To: Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Vicentiu Galanopulo , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: [PATCH v8 2/3] dt-bindings: leds: Add LED1202 LED Controller Date: Mon, 18 Nov 2024 15:12:42 +0000 Message-Id: <20241118151246.7471-3-vicentiu.galanopulo@remote-tech.co.uk> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241118151246.7471-1-vicentiu.galanopulo@remote-tech.co.uk> References: <20241118151246.7471-1-vicentiu.galanopulo@remote-tech.co.uk> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The LED1202 is a 12-channel low quiescent current LED driver with: * Supply range from 2.6 V to 5 V * 20 mA current capability per channel * 1.8 V compatible I2C control interface * 8-bit analog dimming individual control * 12-bit local PWM resolution * 8 programmable patterns If the led node is present in the controller then the channel is set to active. Signed-off-by: Vicentiu Galanopulo --- v1: https://lore.kernel.org/lkml/ZnCnnQfwuRueCIQ0@admins-Air/T/ v2: https://lore.kernel.org/all/ZniNdGgKyUMV-hjq@admins-Air/T/ v3: https://lore.kernel.org/all/ZniNdGgKyUMV-hjq@admins-Air/T/ Changes in v4: - remove label property, use devm_led_classdev_register_ext instead Changes in v3: - remove active property Changes in v2: - renamed label to remove color from it - add color property for each node - add function and function-enumerator property for each node .../devicetree/bindings/leds/st,led1202.yaml | 132 ++++++++++++++++++ 1 file changed, 132 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/st,led1202.yaml diff --git a/Documentation/devicetree/bindings/leds/st,led1202.yaml b/Documentation/devicetree/bindings/leds/st,led1202.yaml new file mode 100644 index 000000000000..f1e5e4efaa3a --- /dev/null +++ b/Documentation/devicetree/bindings/leds/st,led1202.yaml @@ -0,0 +1,132 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/st,led1202.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ST LED1202 LED controllers + +maintainers: + - Vicentiu Galanopulo + +description: | + The LED1202 is a 12-channel low quiescent current LED controller + programmable via I2C; The output current can be adjusted separately + for each channel by 8-bit analog and 12-bit digital dimming control. + Datasheet available at + https://www.st.com/en/power-management/led1202.html + +properties: + compatible: + const: st,led1202 + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@[0-9a-f]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + minimum: 0 + maximum: 11 + + required: + - reg + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + #include + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + led-controller@58 { + compatible = "st,led1202"; + reg = <0x58>; + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0x0>; + function = LED_FUNCTION_STATUS; + color = ; + function-enumerator = <1>; + }; + + led@1 { + reg = <0x1>; + function = LED_FUNCTION_STATUS; + color = ; + function-enumerator = <2>; + }; + + led@2 { + reg = <0x2>; + function = LED_FUNCTION_STATUS; + color = ; + function-enumerator = <3>; + }; + + led@3 { + reg = <0x3>; + function = LED_FUNCTION_STATUS; + color = ; + function-enumerator = <4>; + }; + + led@4 { + reg = <0x4>; + function = LED_FUNCTION_STATUS; + color = ; + function-enumerator = <5>; + }; + + led@5 { + reg = <0x5>; + function = LED_FUNCTION_STATUS; + color = ; + function-enumerator = <6>; + }; + + led@6 { + reg = <0x6>; + function = LED_FUNCTION_STATUS; + color = ; + function-enumerator = <7>; + }; + + led@7 { + reg = <0x7>; + function = LED_FUNCTION_STATUS; + color = ; + function-enumerator = <8>; + }; + + led@8 { + reg = <0x8>; + function = LED_FUNCTION_STATUS; + color = ; + function-enumerator = <9>; + }; + }; + }; +... From patchwork Mon Nov 18 15:12:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vicentiu Galanopulo X-Patchwork-Id: 844214 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D71DF1BD9D4 for ; Mon, 18 Nov 2024 15:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731942785; cv=none; b=iQhs4SwH5CyOgpHWHm65xdjQngb2nzxz8slaIWDqBSWCxXlCfwv+TB+rA08GxWBsja9n8FkfK62GyLfwQAAKnoJNHkdsDQKsQnG+DJUtnkwC/a3Rl+e3mtHRvNpVaRvoO+seafw+ZHCI+OMvWOK7HyI5jpl8AnyiEM67tMTgjX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731942785; c=relaxed/simple; bh=QWSCyv1MeYMyvkdedkTsiIO9CUOT8SLLeozm4IOaTYw=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=UZHx47cqc5vrdnaGD8yemc5JRw8Cuy8JKMOR1L0/GbGVwxWichMyBefH9p6qUE3qnzAJqJxWpCu0FU6MWMTuuUMrNw69gNG3x0po9vevqp/NJxYwoXptbEiN+HaxqZ2WaRGVEHsH9GdJHx8svOuu84OzFdp+jHcn6tNVj4kKCDM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=remote-tech.co.uk; spf=pass smtp.mailfrom=remote-tech.co.uk; dkim=pass (2048-bit key) header.d=remote-tech-co-uk.20230601.gappssmtp.com header.i=@remote-tech-co-uk.20230601.gappssmtp.com header.b=Q6xBY28+; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=remote-tech.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=remote-tech.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=remote-tech-co-uk.20230601.gappssmtp.com header.i=@remote-tech-co-uk.20230601.gappssmtp.com header.b="Q6xBY28+" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a9a0ef5179dso835923466b.1 for ; Mon, 18 Nov 2024 07:13:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remote-tech-co-uk.20230601.gappssmtp.com; s=20230601; t=1731942781; x=1732547581; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=6umhBL0HbA5lcdxJ4R7NzruhWwkLIxauIYZBB37FaGc=; b=Q6xBY28+pch0kzVUzjjfm7dfnlsT/UalL5+LBtDrY7jbdx2pCSziGm9xbhsNM4DqeF HtLdpQ9ewURrzsTI2OrtAquKxwxNzerSKbJg1jS35a2Ga8YWOSfsLb1TUGWza/kQ3Phq fbv5MEygRbqq8xKRgNqrEWKvfXUfvdfi2sf6cKN9zqzCYI4aRGKfPc5ZPBJV0M9hlHFm 00kj9VRphg9FCc+HF8JR/IV42UF4X+heci79UiShw/mJPl6xAydabXMq1LfSwvNyhKqK dPp5mklcznhD7njAHbk21aPm3Cd8LSTGcWk9c7XdhYZSvy5XyU5uENbevzNyD01aPJKp WJSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731942781; x=1732547581; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6umhBL0HbA5lcdxJ4R7NzruhWwkLIxauIYZBB37FaGc=; b=rm+iclgqUYKUmer6xq1Gs/7J+FCtlm78OuYvIEiO0vPey2kwcQngoj4L/gbqfoeR4h /eXLAWM8r1inRk20Ko264BiCmgiZz3hHSxl1T3MenvyUG5dBm0Idngc/TMAq7QBokCDn mCbckJympSrqjUUWAXpu6K/24emSkppFABbmN2H7X5En8CSbwdeUgCJ3c1aabW0KlMGW RPeX98dVL7zEzoeVbSCtBRtxC8Go5/I0jDl6HO6rISyTnG5gkwF2+9B6zRTmBIb+KAEQ sM4l6KWZTwI5M4SeezKKAvk6HTXjbvpMXqotkZSXmU32z1DDRS7kj5xVgsaEJq8SJc0+ eozA== X-Forwarded-Encrypted: i=1; AJvYcCXjPanNZaO4CEWQQcDachRd/eaqtxqXNJr+EIZoCjiuFlOAAP6KxNPlxbkYU/vTi5z7c//7g9lWdH/e@vger.kernel.org X-Gm-Message-State: AOJu0YyIxt1/DJQ7EJG6HCrktVDGN46fg1BrZ+xRC0OiOUi5GQ7G8G2R UvTD62mq2IJh11YUH4NHkAcGXu0Kek5I7YSK1DqBiA9nAixGsw/0XGCvA4IHljTzq+SROfmuVLN lFdRzO++H1byHcJtjyyUQsVOlLZaD+h816i+7u9f9nNnesKWgI+gB5AdmKayvpBV75R0OiDFhrM 4RWMxfC2gn8ca0cmkfZtZDkUn8 X-Google-Smtp-Source: AGHT+IFo/Z8M9u6yb5nSzsNcyFJ2DJsjHME7lz+6h55nasvj8j95Do9g/2PYXyKqhzcN+OPz6TEgfA== X-Received: by 2002:a17:907:9621:b0:a99:4780:1af with SMTP id a640c23a62f3a-aa483482425mr1023225766b.31.1731942781090; Mon, 18 Nov 2024 07:13:01 -0800 (PST) Received: from localhost.localdomain ([178.27.36.125]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20dffd7e7sm548980366b.119.2024.11.18.07.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2024 07:13:00 -0800 (PST) From: Vicentiu Galanopulo To: Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Vicentiu Galanopulo , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: [PATCH v8 3/3] leds: Add LED1202 I2C driver Date: Mon, 18 Nov 2024 15:12:43 +0000 Message-Id: <20241118151246.7471-4-vicentiu.galanopulo@remote-tech.co.uk> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241118151246.7471-1-vicentiu.galanopulo@remote-tech.co.uk> References: <20241118151246.7471-1-vicentiu.galanopulo@remote-tech.co.uk> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The output current can be adjusted separately for each channel by 8-bit analog (current sink input) and 12-bit digital (PWM) dimming control. The LED1202 implements 12 low-side current generators with independent dimming control. Internal volatile memory allows the user to store up to 8 different patterns, each pattern is a particular output configuration in terms of PWM duty-cycle (on 4096 steps). Analog dimming (on 256 steps) is per channel but common to all patterns. Each device tree LED node will have a corresponding entry in /sys/class/leds with the label name. The brightness property corresponds to the per channel analog dimming, while the patterns[1-8] to the PWM dimming control. Signed-off-by: Vicentiu Galanopulo --- Changes in v7: - fix st1202_brightness_get() error: uninitialized symbol 'value' Changes in v6: - fix build error Changes in v5: - remove unused macros - switch to using devm_led_classdev_register_ext (struct st1202_led update) - add prescalar_to_milliseconds (convert [22..5660]ms to [0..255] reg value) - remove register range check in dt_init (range protected by yaml) - address all review comments in v4 Changes in v4: - Remove attributes/extended attributes implementation - Use /sys/class/leds//hw_pattern (Pavel suggestion) - Implement review findings of Christophe JAILLET Changes in v3: - Rename all ll1202 to st1202, including driver file name - Convert all magic numbers to defines - Refactor the show/store callbacks as per Lee's and Thomas's review - Remove ll1202_get_channel and use dev_ext_attributes instead - Log all error values for all the functions - Use sysfs_emit for show callbacks Changes in v2: - Fix build error for device_attribute modes drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/leds-st1202.c | 510 +++++++++++++++++++++++++++++++++++++ 3 files changed, 522 insertions(+) create mode 100644 drivers/leds/leds-st1202.c diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index b784bb74a837..c4fdacc00066 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -931,6 +931,17 @@ config LEDS_LM36274 Say Y to enable the LM36274 LED driver for TI LMU devices. This supports the LED device LM36274. +config LEDS_ST1202 + tristate "LED Support for STMicroelectronics LED1202 I2C chips" + depends on LEDS_CLASS + depends on I2C + depends on OF + select LEDS_TRIGGERS + help + Say Y to enable support for LEDs connected to LED1202 + LED driver chips accessed via the I2C bus. + Supported devices include LED1202. + config LEDS_TPS6105X tristate "LED support for TI TPS6105X" depends on LEDS_CLASS diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 18afbb5a23ee..e8b39ef760cc 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -81,6 +81,7 @@ obj-$(CONFIG_LEDS_POWERNV) += leds-powernv.o obj-$(CONFIG_LEDS_PWM) += leds-pwm.o obj-$(CONFIG_LEDS_REGULATOR) += leds-regulator.o obj-$(CONFIG_LEDS_SC27XX_BLTC) += leds-sc27xx-bltc.o +obj-$(CONFIG_LEDS_ST1202) += leds-st1202.o obj-$(CONFIG_LEDS_SUN50I_A100) += leds-sun50i-a100.o obj-$(CONFIG_LEDS_SUNFIRE) += leds-sunfire.o obj-$(CONFIG_LEDS_SYSCON) += leds-syscon.o diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c new file mode 100644 index 000000000000..f278e528c73f --- /dev/null +++ b/drivers/leds/leds-st1202.c @@ -0,0 +1,510 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * LED driver for STMicroelectronics LED1202 chip + * + * Copyright (C) 2024 Remote-Tech Ltd. UK + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define ST1202_CHAN_DISABLE_ALL 0x00 +#define ST1202_CHAN_ENABLE_HIGH 0x03 +#define ST1202_CHAN_ENABLE_LOW 0x02 +#define ST1202_CONFIG_REG 0x04 +/* PATS: Pattern sequence feature enable */ +#define ST1202_CONFIG_REG_PATS BIT(7) +/* PATSR: Pattern sequence runs (self-clear when sequence is finished) */ +#define ST1202_CONFIG_REG_PATSR BIT(6) +#define ST1202_CONFIG_REG_SHFT BIT(3) +#define ST1202_DEV_ENABLE 0x01 +#define ST1202_DEV_ENABLE_ON BIT(0) +#define ST1202_DEV_ENABLE_RESET BIT(7) +#define ST1202_DEVICE_ID 0x00 +#define ST1202_ILED_REG0 0x09 +#define ST1202_MAX_LEDS 12 +#define ST1202_MAX_PATTERNS 8 +#define ST1202_MILLIS_PATTERN_DUR_MAX 5660 +#define ST1202_MILLIS_PATTERN_DUR_MIN 22 +#define ST1202_PATTERN_DUR 0x16 +#define ST1202_PATTERN_PWM 0x1E +#define ST1202_PATTERN_REP 0x15 + +struct st1202_led { + struct fwnode_handle *fwnode; + struct led_classdev led_cdev; + struct st1202_chip *chip; + bool is_active; + int led_num; +}; + +struct st1202_chip { + struct i2c_client *client; + struct mutex lock; + struct st1202_led leds[ST1202_MAX_LEDS]; +}; + +static struct st1202_led *cdev_to_st1202_led(struct led_classdev *cdev) +{ + return container_of(cdev, struct st1202_led, led_cdev); +} + +static int st1202_read_reg(struct st1202_chip *chip, int reg, uint8_t *val) +{ + int ret; + + ret = i2c_smbus_read_byte_data(chip->client, reg); + if (ret < 0) + return ret; + + *val = (uint8_t)ret; + return 0; +} + +static int st1202_write_reg(struct st1202_chip *chip, int reg, uint8_t val) +{ + return i2c_smbus_write_byte_data(chip->client, reg, val); +} + +static uint8_t st1202_prescalar_to_miliseconds(unsigned int value) +{ + return value/ST1202_MILLIS_PATTERN_DUR_MIN - 1; +} + +static int st1202_pwm_pattern_write(struct st1202_chip *chip, int led_num, + int pattern, unsigned int value) +{ + u8 value_l, value_h; + int ret; + + value_l = (u8)value; + value_h = (u8)(value >> 8); + + /* + * Datasheet: Register address low = 1Eh + 2*(xh) + 18h*(yh), + * where x is the channel number (led number) in hexadecimal (x = 00h .. 0Bh) + * and y is the pattern number in hexadecimal (y = 00h .. 07h) + */ + ret = st1202_write_reg(chip, (ST1202_PATTERN_PWM + (led_num * 2) + 0x18 * pattern), + value_l); + if (ret != 0) { + dev_err(&chip->client->dev, "Failed writing value %d to register [0x%x], error: %d\n", + value_l, ST1202_PATTERN_PWM + (led_num * 2) + 0x18 * pattern, ret); + return ret; + } + + /* + * Datasheet: Register address high = 1Eh + 01h + 2(xh) +18h*(yh), + * where x is the channel number in hexadecimal (x = 00h .. 0Bh) + * and y is the pattern number in hexadecimal (y = 00h .. 07h) + */ + ret = st1202_write_reg(chip, (ST1202_PATTERN_PWM + 0x1 + (led_num * 2) + 0x18 * pattern), + value_h); + if (ret != 0) { + dev_err(&chip->client->dev, "Failed writing value %d to register [0x%x], error: %d\n", + value_h, ST1202_PATTERN_PWM + 0x1 + (led_num * 2) + 0x18 * pattern, ret); + return ret; + } + + return 0; +} + +static int st1202_duration_pattern_write(struct st1202_chip *chip, int pattern, + unsigned int value) +{ + int ret; + + ret = st1202_write_reg(chip, (ST1202_PATTERN_DUR + pattern), + st1202_prescalar_to_miliseconds(value)); + if (ret != 0) { + dev_err(&chip->client->dev, "Writing to register [0x%x] failed, value %u\n", + ST1202_PATTERN_DUR + pattern, value); + return ret; + } + + return 0; +} + +static void st1202_brightness_set(struct led_classdev *led_cdev, + enum led_brightness value) +{ + struct st1202_led *led; + struct st1202_chip *chip; + int ret; + + led = cdev_to_st1202_led(led_cdev); + chip = led->chip; + + mutex_lock(&chip->lock); + + ret = st1202_write_reg(chip, ST1202_ILED_REG0 + led->led_num, value); + if (ret != 0) + dev_err(&chip->client->dev, "Reading register [0x%x] failed, error: %d\n", + ST1202_ILED_REG0 + led->led_num, ret); + + mutex_unlock(&chip->lock); +} + +static enum led_brightness st1202_brightness_get(struct led_classdev *led_cdev) +{ + struct st1202_led *led; + struct st1202_chip *chip; + u8 value = 0; + int ret; + + led = cdev_to_st1202_led(led_cdev); + chip = led->chip; + + mutex_lock(&chip->lock); + + ret = st1202_read_reg(chip, ST1202_ILED_REG0 + led->led_num, + &value); + if (ret != 0) + dev_err(&chip->client->dev, "Reading register [0x%x] failed, error: %d\n", + ST1202_ILED_REG0 + led->led_num, ret); + + mutex_unlock(&chip->lock); + + return value; +} + +static int st1202_channel_set(struct st1202_chip *chip, int led_num, bool active) +{ + u8 chan_low, chan_high; + int ret; + + mutex_lock(&chip->lock); + + if (led_num <= 7) { + ret = st1202_read_reg(chip, ST1202_CHAN_ENABLE_LOW, &chan_low); + if (ret < 0) { + dev_err(&chip->client->dev, "Failed reading register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_LOW, ret); + goto exit; + } + + chan_low = active ? chan_low | BIT(led_num) : chan_low & ~BIT(led_num); + + ret = st1202_write_reg(chip, ST1202_CHAN_ENABLE_LOW, chan_low); + if (ret < 0) { + dev_err(&chip->client->dev, "Failed writing to register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_LOW, ret); + goto exit; + } + } else { + ret = st1202_read_reg(chip, ST1202_CHAN_ENABLE_HIGH, &chan_high); + if (ret < 0) { + dev_err(&chip->client->dev, "Failed reading register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_HIGH, ret); + goto exit; + } + + chan_high = active ? chan_high | (BIT(led_num) >> 8) : + chan_high & ~(BIT(led_num) >> 8); + + ret = st1202_write_reg(chip, ST1202_CHAN_ENABLE_HIGH, chan_high); + if (ret < 0) + dev_err(&chip->client->dev, "Failed writing to register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_HIGH, ret); + } + +exit: + mutex_unlock(&chip->lock); + return ret; +} + +static int st1202_led_set(struct led_classdev *ldev, enum led_brightness value) +{ + struct st1202_led *led; + struct st1202_chip *chip; + int ret; + + led = cdev_to_st1202_led(ldev); + chip = led->chip; + + ret = st1202_channel_set(chip, led->led_num, value == LED_OFF ? false : true); + + return ret; +} + +static int st1202_led_pattern_clear(struct led_classdev *ldev) +{ + struct st1202_led *led; + struct st1202_chip *chip; + int ret; + + led = cdev_to_st1202_led(ldev); + chip = led->chip; + + mutex_lock(&chip->lock); + + for (int patt = 0; patt < ST1202_MAX_PATTERNS; patt++) { + ret = st1202_pwm_pattern_write(chip, led->led_num, patt, LED_OFF); + if (ret != 0) + goto exit; + + ret = st1202_duration_pattern_write(chip, patt, ST1202_MILLIS_PATTERN_DUR_MIN); + if (ret != 0) + goto exit; + } + +exit: + mutex_unlock(&chip->lock); + + return ret; +} + +static int st1202_led_pattern_set(struct led_classdev *ldev, + struct led_pattern *pattern, + u32 len, int repeat) +{ + struct st1202_led *led; + struct st1202_chip *chip; + int ret; + + led = cdev_to_st1202_led(ldev); + chip = led->chip; + + if (len > ST1202_MAX_PATTERNS) + return -EINVAL; + + mutex_lock(&chip->lock); + + for (int patt = 0; patt < len; patt++) { + if (pattern[patt].delta_t < ST1202_MILLIS_PATTERN_DUR_MIN || + pattern[patt].delta_t > ST1202_MILLIS_PATTERN_DUR_MAX) { + ret = -EINVAL; + goto exit; + } + + ret = st1202_pwm_pattern_write(chip, led->led_num, patt, pattern[patt].brightness); + if (ret != 0) + goto exit; + + ret = st1202_duration_pattern_write(chip, patt, pattern[patt].delta_t); + if (ret != 0) + goto exit; + } + + ret = st1202_write_reg(chip, ST1202_PATTERN_REP, repeat); + if (ret != 0) { + dev_err(&chip->client->dev, "Writing register [0x%x] failed, error: %d\n", + ST1202_PATTERN_REP, ret); + goto exit; + } + + ret = st1202_write_reg(chip, ST1202_CONFIG_REG, + (ST1202_CONFIG_REG_PATSR | ST1202_CONFIG_REG_PATS | + ST1202_CONFIG_REG_SHFT)); + if (ret != 0) { + dev_err(&chip->client->dev, "Failed writing value %ld to register [0x%x], error: %d\n", + (ST1202_CONFIG_REG_PATSR | ST1202_CONFIG_REG_PATS | ST1202_CONFIG_REG_SHFT), + ST1202_CONFIG_REG, ret); + goto exit; + } + +exit: + mutex_unlock(&chip->lock); + + return ret; +} + +static int st1202_dt_init(struct st1202_chip *chip) +{ + struct device *dev = &chip->client->dev; + struct st1202_led *led; + int err, reg; + + for_each_available_child_of_node_scoped(dev_of_node(dev), child) { + struct led_init_data init_data = {}; + + err = of_property_read_u32(child, "reg", ®); + if (err) { + of_node_put(child); + return dev_err_probe(dev, err, "Invalid register, error: %d\n", err); + } + + led = &chip->leds[reg]; + led->is_active = true; + led->fwnode = of_fwnode_handle(child); + + led->led_cdev.max_brightness = U8_MAX; + led->led_cdev.brightness_set_blocking = st1202_led_set; + led->led_cdev.pattern_set = st1202_led_pattern_set; + led->led_cdev.pattern_clear = st1202_led_pattern_clear; + led->led_cdev.default_trigger = "pattern"; + + init_data.fwnode = led->fwnode; + init_data.devicename = "st1202"; + init_data.default_label = ":"; + err = devm_led_classdev_register_ext(dev, + &led->led_cdev, &init_data); + if (err < 0) { + dev_err_probe(dev, err, + "Failed to register LED class dev, error: %d\n", err); + return err; + } + led->led_cdev.brightness_set = st1202_brightness_set; + led->led_cdev.brightness_get = st1202_brightness_get; + } + + return 0; +} + +static int st1202_setup(struct st1202_chip *chip) +{ + int ret; + + mutex_lock(&chip->lock); + /* + * Once the supply voltage is applied, the LED1202 executes some internal checks, + * afterwords it stops the oscillator and puts the internal LDO in quiescent mode. + * To start the device, EN bit must be set inside the “Device Enable” register at + * address 01h. As soon as EN is set, the LED1202 loads the adjustment parameters + * from the internal non-volatile memory and performs an auto-calibration procedure + * in order to increase the output current precision. + * Such initialization lasts about 6.5 ms. + */ + + /* Reset the chip during setup */ + ret = st1202_write_reg(chip, ST1202_DEV_ENABLE, ST1202_DEV_ENABLE_RESET); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed to write to register [0x%x], error: %d\n", + ST1202_DEV_ENABLE, ret); + goto exit; + } + + /* Enable phase-shift delay feature */ + ret = st1202_write_reg(chip, ST1202_CONFIG_REG, ST1202_CONFIG_REG_SHFT); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed to write to register [0x%x], error: %d\n", + ST1202_CONFIG_REG, ret); + goto exit; + } + + /* Enable the device */ + ret = st1202_write_reg(chip, ST1202_DEV_ENABLE, ST1202_DEV_ENABLE_ON); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed to write to register [0x%x], error: %d\n", + ST1202_DEV_ENABLE, ret); + goto exit; + } + + /* Duration of initialization */ + usleep_range(6500, 10000); + + /* Deactivate all LEDS (channels) and activate only the ones found in Device Tree */ + ret = st1202_write_reg(chip, ST1202_CHAN_ENABLE_LOW, ST1202_CHAN_DISABLE_ALL); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed writing to register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_LOW, ret); + goto exit; + } + + ret = st1202_write_reg(chip, ST1202_CHAN_ENABLE_HIGH, ST1202_CHAN_DISABLE_ALL); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed writing to register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_HIGH, ret); + goto exit; + } + + ret = st1202_write_reg(chip, ST1202_CONFIG_REG, + ST1202_CONFIG_REG_PATS | ST1202_CONFIG_REG_PATSR); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed writing to register [0x%lx], error: %d\n", + ST1202_CONFIG_REG_PATS | ST1202_CONFIG_REG_PATSR, ret); + goto exit; + } + +exit: + mutex_unlock(&chip->lock); + return ret; +} + +static int st1202_probe(struct i2c_client *client) +{ + struct st1202_chip *chip; + struct st1202_led *led; + int ret; + + if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA)) + return dev_err_probe(&client->dev, -EIO, "SMBUS Byte Data not Supported\n"); + + chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); + if (!chip) + return -ENOMEM; + + i2c_set_clientdata(client, chip); + + devm_mutex_init(&client->dev, &chip->lock); + chip->client = client; + + ret = st1202_dt_init(chip); + if (ret < 0) + return ret; + + ret = st1202_setup(chip); + if (ret < 0) + return ret; + + for (int i = 0; i < ST1202_MAX_LEDS; i++) { + led = &chip->leds[i]; + led->chip = chip; + led->led_num = i; + + if (led->is_active) { + ret = st1202_channel_set(led->chip, led->led_num, true); + if (ret < 0) { + return dev_err_probe(&client->dev, -EIO, + "Failed to activate LED channel, error: %d\n", ret); + } + + ret = st1202_led_pattern_clear(&led->led_cdev); + if (ret < 0) { + return dev_err_probe(&client->dev, -EIO, + "Failed to clear LED pattern, error: %d\n", ret); + } + } + } + + return 0; +} + +static const struct i2c_device_id st1202_id[] = { + { "st1202-i2c" }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(i2c, st1202_id); + +static const struct of_device_id st1202_dt_ids[] = { + { .compatible = "st,led1202", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, st1202_dt_ids); + +static struct i2c_driver st1202_driver = { + .driver = { + .name = "leds-st1202", + .of_match_table = of_match_ptr(st1202_dt_ids), + }, + .probe = st1202_probe, + .id_table = st1202_id, +}; +module_i2c_driver(st1202_driver); + +MODULE_AUTHOR("Remote Tech LTD"); +MODULE_DESCRIPTION("STMicroelectronics LED1202 : 12-channel constant current LED driver"); +MODULE_LICENSE("GPL");