From patchwork Fri Nov 22 10:34:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 844913 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:8b:b0:382:43a8:7b94 with SMTP id m11csp2773935wrx; Fri, 22 Nov 2024 02:34:42 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXOUHrffGfl+9BTc8bqywLuNcj+Di0Gn6tMLUUyfRP1URNwVb0qSTf8LI3U3zlFlNUo6De8QA==@linaro.org X-Google-Smtp-Source: AGHT+IG60Qh8JuaWZsokbvQ+pkyH0JlJDlJXoA7yHIeeHEZvuw986wMi33y7lrfVXgRsX5HG+J0S X-Received: by 2002:a05:600c:1f88:b0:431:4e82:ffa6 with SMTP id 5b1f17b1804b1-433ce4962a5mr18631265e9.24.1732271682549; Fri, 22 Nov 2024 02:34:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1732271682; cv=none; d=google.com; s=arc-20240605; b=AZSWCvo01nDuvXMkmGN/6bMq+XxKvlqGnixzJm3/oAPiwoShBEu1e8I+yz+jWmjWVC +i3TZaHQfZ0RVKLAouyBJ/PUwOjnpelB76YQKgaFjqQB5s5GAz8qbE7bbzfDXPdCpHqU vqLB8Q+aVTMLI8NNPr84A1xa0h16nBpc3mX//rrnnlBJRUpBSToxZUlkLovRxT2lldKk Udu90vdLrLZs/y5PoGDMePRPzW42Hq1D1LMtQ5fInafzikkPtwbV0Fab0Pu+UA2ifJ7R umx8n+NFSvSC8Y93XwEN3UdICtBC/fwAmTDNUekYvVKnVx1FE1+UMI+iWr1Zs/E9rlrN sVCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=TbvDqEd1B3bnnTrloGtTMnweakIQQJasrSikw54dhrE=; fh=0+wQ+eO8XvgDL7Wn7iDTKzRvKrvxJyR2bVcrBDXp+dw=; b=OeAfu3jUgGfmxAuBouMtQzUtCoupx9nG6fHAI29TV0RCeRbam0PnK6aKfT7ElTK7wO BYHne+stDyoirk4nESN3/PjtUDnQS55PWWT9KFGVqNnj8yPdU4FhFn3mjBWaaMju4yBu SQFucGurAl4ro7lmY2xgTvxBTK9za9STOhnQXbcLDBv5iCU2u2HcEJCi7bR2ZdO+n6aw 4ljufHTG8FGxKCDmibGEJVWPrSqMK6KsteLVNurOMNCAu0g7AdUWSih9LoNBsuztx8O3 8n77Nqu1NPW2VyZ67VJIwNwpRm9Yftw/ZC3tdyo4t+a5fYKr08pgQqJgCHaHaj0dQPyC UAtw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nr9GkqLF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 5b1f17b1804b1-433cdec4254si9976765e9.198.2024.11.22.02.34.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Nov 2024 02:34:42 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nr9GkqLF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEQza-00055W-5F; Fri, 22 Nov 2024 05:34:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEQzY-00053r-AY for qemu-devel@nongnu.org; Fri, 22 Nov 2024 05:34:24 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEQzW-0008TD-RH for qemu-devel@nongnu.org; Fri, 22 Nov 2024 05:34:24 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4319399a411so17765925e9.2 for ; Fri, 22 Nov 2024 02:34:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732271661; x=1732876461; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TbvDqEd1B3bnnTrloGtTMnweakIQQJasrSikw54dhrE=; b=nr9GkqLFB0Ixkja8swJREm8KUh2coWy/YcXYoSWC1n2RRysl+BZv1WxJiB9uvSePW9 trk4ph5/rEt9Hnzx2e7hfUQiIawXtjW6aEDKFZZ/hPiTqsWfcg0+/cI2td8B4JcnQbMK V2Ku2rN0N+IGdhU2FszCAbgRV+XRERn266WrRRhouH+MRce46K1oWyzx+me6gOPzPbrw LT/ngt63AKdLh/5HPZBIvhCyNlFFgcgJhKPb7DvrpYGtJivrwziEPGB8bjO2X2cXw+yu tTzoXcDVi96xp1dd78HppIeAk5rtB3lsy/SoNHkxSI3+9jMgc/OYawmDc3OMVvcyinKy LFMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732271661; x=1732876461; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TbvDqEd1B3bnnTrloGtTMnweakIQQJasrSikw54dhrE=; b=EqzBqmcO6cVNYDJlu75C1/UOikj7mHBIES5JzJh3FlI5BBS2eq91S4x2mPR01sdUh9 Sy9aZd81IDNfwENIf7MUljCgbqgMDPTNWqjywQsFwWnWYcesBXQjhQvIDj1kJNKZ0UN3 zFHVXnv54mS0WiYeQfsMz/RboX/LuUI9JF/Za9kRXdcBBYvYROKZJFXk+ilxVDnSr6Ts KD7+Y2JKIqu6kzcoImIct+QVI5cqxeM8rMp2yiyESx3jjT0IhkB5n9Zm6Ip2xd0Ziqac tvz8Kfyc0VZ899jYNjf/AxSA2uNKrLDhZ8u2sLyoP5Cgh1c8nPKuglp8t9awHIbmV4jJ TfCQ== X-Gm-Message-State: AOJu0YywPUJpHaWIEiwjwJKzwOMOWHNeKhI0kQW14sTxuvVYOoqnNFFp dKCOKhfKKRKejJxDEemRX//5sitrmFtB2UK/SWHTgT5e0kamK0G7wLjs0ZGzGAHEHST9GSW7cvS Q X-Gm-Gg: ASbGncv7mUJZ2W3JCWFsjYysv1A7tdfENdzSra+TRX71dr+DHUVMNDAbDOnGKPeBi1B uz0ITFabepaNWQzVA9CHLHLnFNlTUxPvk6X1zmrXEJF6HF+EHlMGTbPR/AluIFRVSKjju5yUHjw woRzXC89plXbOh96/x2lDGcuuieABMwXHvGH/rT7hz53ilRSQmsDgb6L6xN7vg9i36SE8P2hbeZ iauBSGZpvp/GGxReqRFtq4c1a6n4MXgKZXNyVfnMD7z0y/l7yq5fmCmzC+ZmbvB9d31ftipsWKq X-Received: by 2002:a05:600c:19c9:b0:426:5269:1a50 with SMTP id 5b1f17b1804b1-433ce41ce42mr17547785e9.11.1732271660756; Fri, 22 Nov 2024 02:34:20 -0800 (PST) Received: from localhost.localdomain ([176.187.211.33]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b0139b22sm89075545e9.0.2024.11.22.02.34.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 22 Nov 2024 02:34:20 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Thomas Huth , "Michael S. Tsirkin" , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH] hw/pci: Remove unused pci_irq_pulse() method Date: Fri, 22 Nov 2024 11:34:18 +0100 Message-ID: <20241122103418.539-1-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Last use of pci_irq_pulse() was removed 7 years ago in commit 5e9aa92eb1 ("hw/block: Fix pin-based interrupt behaviour of NVMe"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- include/hw/pci/pci.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 135695c551..c0717e3121 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -670,16 +670,6 @@ static inline void pci_irq_deassert(PCIDevice *pci_dev) pci_set_irq(pci_dev, 0); } -/* - * FIXME: PCI does not work this way. - * All the callers to this method should be fixed. - */ -static inline void pci_irq_pulse(PCIDevice *pci_dev) -{ - pci_irq_assert(pci_dev); - pci_irq_deassert(pci_dev); -} - MSIMessage pci_get_msi_message(PCIDevice *dev, int vector); void pci_set_power(PCIDevice *pci_dev, bool state);