From patchwork Wed Nov 27 11:49:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastien Nocera X-Patchwork-Id: 846182 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E98891F8AE7 for ; Wed, 27 Nov 2024 11:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732708212; cv=none; b=TS5BMpylGS+tBFqImhDfdQpwA2DziNOzq+4Iqz6yJeL8zFF1iwQLJ6T2I5X3a+2OTydUijGsavASgAv/tyY2YIIZ3oQxqPaVZ8S5xs0AT3qroqJvXQwcVI/9QioRswAtL6brclASiy7u7Dndj6z+bT49rgAIWi37pvz0EBGbKE0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732708212; c=relaxed/simple; bh=OdbXDBuD9SKXy+heVAA1uhhwdkDB8Pp/v/ZxUFRP6+U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Eq+IRbEpTnVhAQnq/rPEuqOfPV8E4mqTcDPnF98iBGOfAjpCHvpXZb1ARXpxafjTI10vCBDZzyPwVJ7lRQbIXlmU4d0ZblELkr3FwOUvuc3H2/ZFcx+5AVXHitFwHFxrJ32VzDPJkUl91SJKe/h2Izq/bH8Gmx/C/d8pI0DAJDQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=hadess.net; spf=pass smtp.mailfrom=hadess.net; arc=none smtp.client-ip=217.70.183.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=hadess.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hadess.net Received: by mail.gandi.net (Postfix) with ESMTPSA id 40CE7E0007; Wed, 27 Nov 2024 11:50:08 +0000 (UTC) From: Bastien Nocera To: linux-bluetooth@vger.kernel.org Cc: Bastien Nocera Subject: [BlueZ 1/2] profiles/audio: Quiet plug-in warnings Date: Wed, 27 Nov 2024 12:49:52 +0100 Message-ID: <20241127115007.1303616-1-hadess@hadess.net> X-Mailer: git-send-email 2.47.0 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: hadess@hadess.net A normal daemon start should not throw warnings on a system in the default configuration. Quiet the plug-in warnings that require experimental features to be enabled. They will still appear in the debug output. bluetoothd[896]: profiles/audio/micp.c:micp_init() D-Bus experimental not enabled --- profiles/audio/media.c | 2 +- profiles/audio/micp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/profiles/audio/media.c b/profiles/audio/media.c index 746e538fcacd..062475e56c49 100644 --- a/profiles/audio/media.c +++ b/profiles/audio/media.c @@ -1249,7 +1249,7 @@ static bool endpoint_init_pac(struct media_endpoint *endpoint, uint8_t type, char *name; if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL)) { - warn("D-Bus experimental not enabled"); + DBG("D-Bus experimental not enabled"); *err = -ENOTSUP; return false; } diff --git a/profiles/audio/micp.c b/profiles/audio/micp.c index 452027c75da2..3f0845dcb328 100644 --- a/profiles/audio/micp.c +++ b/profiles/audio/micp.c @@ -318,7 +318,7 @@ static unsigned int micp_id; static int micp_init(void) { if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL)) { - warn("D-Bus experimental not enabled"); + DBG("D-Bus experimental not enabled"); return -ENOTSUP; } From patchwork Wed Nov 27 11:49:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastien Nocera X-Patchwork-Id: 845790 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48A931F943B for ; Wed, 27 Nov 2024 11:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732708213; cv=none; b=TYqlI9ZtP1Av/RwV4gmh9BFJrlNQ1vloaEaDsaloj7f4KhC+nzCgI69jded9PcNCe0SqDkZc6XKw+HjoABGn2xJNePv4ls2XbLVr825e5LSJf3s1Mb/ggRWNvipK+qTOYQd3b5vtPCdtHbuNIRH5atEinzt4fx0vK9FEvsRpI+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732708213; c=relaxed/simple; bh=TZQVNoevke7eCJcdgDHdlXODz789NNLjkRx2Ta+GExo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B/s8pQN98boaLgrOcllUbwjQqOAyhnj4ZpxOENiPNeT0YbGy2/KdIfOba3LqVjwtLpeSY/SpQ1CKAD15tSmpxjm//FCXyAnN0ZvqCJXz1GO4GiMpYy0jYhiM+i7bGl4oYKpONOivx17LZvQyTgT2E0OOOaeD8dw1XbhhAWnMwwk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=hadess.net; spf=pass smtp.mailfrom=hadess.net; arc=none smtp.client-ip=217.70.183.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=hadess.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hadess.net Received: by mail.gandi.net (Postfix) with ESMTPSA id 85CF6E0009; Wed, 27 Nov 2024 11:50:08 +0000 (UTC) From: Bastien Nocera To: linux-bluetooth@vger.kernel.org Cc: Bastien Nocera Subject: [BlueZ 2/2] plugin: Quiet start-up warnings Date: Wed, 27 Nov 2024 12:49:53 +0100 Message-ID: <20241127115007.1303616-2-hadess@hadess.net> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241127115007.1303616-1-hadess@hadess.net> References: <20241127115007.1303616-1-hadess@hadess.net> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: hadess@hadess.net It's not an error for a plug-in not to start if the hardware doesn't support it. Quiet the warnings that require specific hardware. The messages will still appear in the debug output. bluetoothd[896]: src/plugin.c:plugin_init() System does not support csip plugin bluetoothd[896]: src/plugin.c:plugin_init() System does not support micp plugin bluetoothd[896]: src/plugin.c:plugin_init() System does not support vcp plugin bluetoothd[896]: src/plugin.c:plugin_init() System does not support mcp plugin bluetoothd[896]: src/plugin.c:plugin_init() System does not support bass plugin bluetoothd[896]: src/plugin.c:plugin_init() System does not support bap plugin --- src/plugin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugin.c b/src/plugin.c index e6d05be4ce08..00d3d7b6a0b5 100644 --- a/src/plugin.c +++ b/src/plugin.c @@ -50,7 +50,7 @@ static int init_plugin(const struct bluetooth_plugin_desc *desc) err = desc->init(); if (err < 0) { if (err == -ENOSYS || err == -ENOTSUP) - warn("System does not support %s plugin", + DBG("System does not support %s plugin", desc->name); else error("Failed to init %s plugin",