From patchwork Thu Dec 12 20:22:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 181519 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp1386289ile; Thu, 12 Dec 2019 12:23:46 -0800 (PST) X-Google-Smtp-Source: APXvYqwOIMMMbgGoqv5Fvy7oYdxpyhM5FIXEJE/YF+38fdwqPq5yUCY7N47q/Ri4p4/7S7rp8zUT X-Received: by 2002:a62:6001:: with SMTP id u1mr12062771pfb.158.1576182226437; Thu, 12 Dec 2019 12:23:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576182226; cv=none; d=google.com; s=arc-20160816; b=0ecNRSpFUaWelDO3Pq6n39bJ1e9V2+TKmHeLTCmPVJmvSjlWBdDLYp1LsGpUyJoSPd lXJbv12z3i5cYF66qg+KvuRup6QpApLypfSm2Uh4v1NgBXqvyM3WbQLKPhWGSiixgg7y sGmaN209PxG/BlZslIbDqXQ/pQ9eCda5uZzVcA3KKAZBgVp3/VUh01m51XKD7Yokg9UD 9YWZmh1xV1ISHSWvuuAqDn6Qxy4RyytGSb4nlAyE7LqbBDCuZAiOzC+DpWU3G9aU3Bry a+dEeiQhuaZT8qJ02VmdbfYMCqCkfApJFutVP3RsO1XIG0Q40/YfhdFSgMiaWzj79FCR D/Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:delivered-to; bh=F9s1Y0zKCpQ/sFjxgNX5rq7ngsuXWXvXXR6UG6XAsqg=; b=HLMnur3PI0kyUB0k7jdUSq/TAzF9IrrwA+hwUKA8wjNyp0BXWjrq4wzOPeStCY4i3R hytE9T2vsYmbsKasJEr0esIcze6XcyIQrKkWQmGUruvR+043DiY362K+fCd9O2hqXsgp rjiE+2uWvWa+I3CNrBClmhA9qL7hiEYZ4HMAntoAexLUzc1uuFeCdlf5bB5bJmjgg55t CKSzcOCKe7fU37BDLMiPYSwkMapaxnntq8Lz8j+itk3zLawA4n5dlaTLHUCYHAwwSZum 5WnXbutsKFdkGw4rAqdcUMjxRml3CURHZmstz8WicVUH5nOjZzT9COSBwIdmv5qcof+R MYWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=FromEjRL; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id y18si6499475pfq.130.2019.12.12.12.23.46; Thu, 12 Dec 2019 12:23:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=FromEjRL; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from ec2-34-214-78-129.us-west-2.compute.amazonaws.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id D80407F98C; Thu, 12 Dec 2019 20:23:40 +0000 (UTC) X-Original-To: openembedded-devel@lists.openembedded.org Delivered-To: openembedded-devel@lists.openembedded.org Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by mail.openembedded.org (Postfix) with ESMTP id ED1CB7D200 for ; Thu, 12 Dec 2019 20:23:02 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id s18so1441379pfd.8 for ; Thu, 12 Dec 2019 12:23:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gCeGtM4q1T+AQpuzIL8rtY6QE/jV+19gDwBqjh2ibdg=; b=FromEjRLOZunuJgv+j/gWuKf793kwMQ+yqmJkqSKKMq6TPbkbNAkNm8R7H3d1biFIl PIUF9SEmQdmff/Q8qsaeQaMrX8g164taQQtFoSnzy7i4CndY6haUD4YXXzraJGEv+nuG FXVPW5pNESCchuvLJ3HsFR2YJPvqj8h61Wuacera2xHds9EoH7GJjA5GTBZ8+KUboqq6 CP5MfBD6gSs7Y456byD3g1rRnDvU+VNau1pDo1lsYhdFK+yc1EKHbMmdemijcV50SLXq v8l9OvD9V43ByZa8IWtWxZPmZVD0fjicak7MiicbDuaqNJlVD/NLUYqmWQUev15nDBkY /QWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gCeGtM4q1T+AQpuzIL8rtY6QE/jV+19gDwBqjh2ibdg=; b=FX54M3NvVh6mtyd1Xh+szYrgM5Dsc2V6TjbZY6A6xSvieowX5Btrf69WK++FfdWo9w ApofYdQ7wH3ojvdYHt7TFrBePqgjbEKontKgeUK+La6D6eRs77IR4OZ9FrMUn6esJME3 zonwhvfSpZNb5Tj7moZTBQkvJNw5mKoBfwQA4BcX/aM/DlwSVLZGNgKtprvQ1xvCyOjS 6ZbewteaSQs4sVxqujoFzA/WNcAVfNKWkKdt85eYCsmejk8YjIjUqFzVdBt8GNA5HqM3 gWZfFCqBXFsHyxqC9h0EMyUf7moUg6VGt3mqxAaq5Nj0DW0Z8SAppYFXA3cRR0ydqPDR HmHQ== X-Gm-Message-State: APjAAAVHe7pFLlssTUPheEbxkjXHiD8+bH7SOUM5oPJnFvrezpu9Tcvz fxo77tVrWpQ/CAv7mQgnQtwlNkdRwQw= X-Received: by 2002:a63:de4a:: with SMTP id y10mr12629898pgi.367.1576182182824; Thu, 12 Dec 2019 12:23:02 -0800 (PST) Received: from apollo.hsd1.ca.comcast.net ([2601:646:9200:4e0::3552]) by smtp.gmail.com with ESMTPSA id r66sm8730732pfc.74.2019.12.12.12.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2019 12:23:02 -0800 (PST) From: Khem Raj To: openembedded-devel@lists.openembedded.org Date: Thu, 12 Dec 2019 12:22:52 -0800 Message-Id: <20191212202252.2786262-3-raj.khem@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191212202252.2786262-1-raj.khem@gmail.com> References: <20191212202252.2786262-1-raj.khem@gmail.com> MIME-Version: 1.0 Subject: [oe] [meta-oe][PATCH] xterm: Fix latent issue found with musl X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-devel-bounces@lists.openembedded.org Errors-To: openembedded-devel-bounces@lists.openembedded.org [YOCTO #13691] Signed-off-by: Khem Raj Cc: Ross Burton Cc: Armin Kuster --- .../xorg-app/xterm/posix_ptys.patch | 29 +++++++++++++++++++ .../recipes-graphics/xorg-app/xterm_351.bb | 4 ++- 2 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 meta-oe/recipes-graphics/xorg-app/xterm/posix_ptys.patch -- 2.24.1 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel diff --git a/meta-oe/recipes-graphics/xorg-app/xterm/posix_ptys.patch b/meta-oe/recipes-graphics/xorg-app/xterm/posix_ptys.patch new file mode 100644 index 0000000000..54020d53e9 --- /dev/null +++ b/meta-oe/recipes-graphics/xorg-app/xterm/posix_ptys.patch @@ -0,0 +1,29 @@ +there is no test to define HAVE_GRANTPT_PTY_ISATTY and +_POSIX_SOURCE is app-defined not system +This fix ptys and launching xterm + +Upstream-Status: Pending + +Suggested By Rich Felker +Signed-off-by: Khem Raj + +--- a/main.c ++++ b/main.c +@@ -2892,7 +2892,7 @@ get_pty(int *pty, char *from GCC_UNUSED) + close(opened_tty); + opened_tty = -1; + } +-#elif defined(HAVE_POSIX_OPENPT) && defined(HAVE_PTSNAME) && defined(HAVE_GRANTPT_PTY_ISATTY) ++#elif defined(HAVE_POSIX_OPENPT) && defined(HAVE_PTSNAME) + if ((*pty = posix_openpt(O_RDWR)) >= 0) { + char *name = ptsname(*pty); + if (name != 0) { +@@ -4040,7 +4040,7 @@ spawnXTerm(XtermWidget xw, unsigned line + /* + * now in child process + */ +-#if defined(_POSIX_SOURCE) || defined(SVR4) || defined(__convex__) || defined(__SCO__) || defined(__QNX__) ++#if defined(_POSIX_VERSION) || defined(SVR4) || defined(__convex__) || defined(__SCO__) || defined(__QNX__) + int pgrp = setsid(); /* variable may not be used... */ + #else + int pgrp = getpid(); diff --git a/meta-oe/recipes-graphics/xorg-app/xterm_351.bb b/meta-oe/recipes-graphics/xorg-app/xterm_351.bb index 394d2cb9de..abfda8a5fa 100644 --- a/meta-oe/recipes-graphics/xorg-app/xterm_351.bb +++ b/meta-oe/recipes-graphics/xorg-app/xterm_351.bb @@ -4,7 +4,9 @@ DEPENDS = "libxaw xorgproto libxext libxau libxinerama libxpm ncurses" LIC_FILES_CHKSUM = "file://xterm.h;beginline=3;endline=31;md5=c7faceb872d90115e7c0ad90e90c390d" -SRC_URI = "http://invisible-mirror.net/archives/${BPN}/${BP}.tgz" +SRC_URI = "http://invisible-mirror.net/archives/${BPN}/${BP}.tgz \ + file://posix_ptys.patch \ + " SRC_URI[md5sum] = "a07edfbee2e2f4c6a9ddbf834fa4bbec" SRC_URI[sha256sum] = "760a8a10221c9c9744afd86db87c7ad95bbf9be4f5f525fecf39125f0d2a6e16"