From patchwork Mon Dec 9 18:52:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 848614 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2043.outbound.protection.outlook.com [40.107.212.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2787C1865E0; Mon, 9 Dec 2024 18:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.43 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770399; cv=fail; b=cp1/lfsMuAc6J9d3LarjGJqdKHdxUx8kotWguygO2Ge8mD7Sg36I/SStm4kaFw5aBBJniFl6DfqpSyKc7zTqJsKznc4DzE4B+7HmyFSYwb9fOq4atATZjUFllsifiBO83drr53uFAu0eXmjrsPTJmrmzz438vT/CV4xDNChu+48= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770399; c=relaxed/simple; bh=UeYbhWvQcmWInVcHnNY1JbEhvvPPfHrL8JLlYCSFOJE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QOh2rz58hCZAVhdSDDJrHcx5ihOC2Zf4oVrcxVLfJ1kC97m34C3Y7zy6cn//01+M3UOqPEq/FBBRJcCEpyN0kessZHt3rfgQVjAFAYz7HD1Bj7tu49gpwNUK4qK/EQvaJN0kxeelT7tS34jSSeP09EBCPP0dKmKF0QQqgqPih4I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=lEAhTSE6; arc=fail smtp.client-ip=40.107.212.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="lEAhTSE6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hWnjVUkMo9I7ayAJqM71zYu1VEC5Cabf97TuS7nDI9Hapa600w8j0UK4SO7+YGy83UUHJpyrQar4h89qX5GqFBABl3DFP/2P/9PCX4UyxEs6MJrYLH6RiYL58ymUqT1PGqQq10IdwgwWWyV7JvOg/9mQVHkazcUy6ywAvtQYlL2dxzTC0kdP6tFAQmT769M5FUwzEiABFimWOv9QJLSkjiPs9vVPeOAFlTJDdqCbN5kuXNym6SGxXAyWHajU7z2koF3FVpOpGBSHEPsTuu1Xv5bSPF5bxlIBo36bDUIufs1HQnv8SfZMMr1AvyRF7+UsA4MG230Hxwj7R1YPLhI0ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GFQ7YJImPddudTRBlzJyzW4I+aKSrlmWqIIyVP4Ca9c=; b=QMM9pLFZucQ/cC4buBbyCKfvvSyunDYe0iPDdrVhc9jct7IJ5YjDpkWDBtDGIeePDDcDt4AuD1mNSL5FQ6k1+Kb8pPA8LhhI+Tt1RNCYtWcgXvzVZ8NOkTWNtm3lOlCwL57CNQM1fCuV9JvugtPmGH7Sxkm/3xk3vt1bYLhowCzyLfe9vR1qBySE41OlLANpZWO+cB5ANhSNUR0wNkSuCDJU+nn/HHLAclDcIAhFWZEGU0ngA3lEkm3IboysjaKW5jfcbYa0A1sZH54CIvuhjK1krenqtyCHY5RiiSNa+H7GcLaKuMNX+9L4jbswtW5efYVmZz5vkz1sQtfIGdSS6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GFQ7YJImPddudTRBlzJyzW4I+aKSrlmWqIIyVP4Ca9c=; b=lEAhTSE6Vfy5A9sCtrTAJk8gyLtRtPXWKEDdBhNdyh88N08kZ9a0+lh6Drh1j4+PEvI9s+Motrz+SJXux6cnTSlpwR9xVA7r8JFJbazOHov4O+e43MltVH0me0IA/LCpTbkNn0BbR8Qx4shb4t3duAwPzEnmqVJ0tQVQ/KrfDBM= Received: from CH2PR19CA0020.namprd19.prod.outlook.com (2603:10b6:610:4d::30) by SA3PR12MB8811.namprd12.prod.outlook.com (2603:10b6:806:312::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.19; Mon, 9 Dec 2024 18:53:11 +0000 Received: from CH1PEPF0000A348.namprd04.prod.outlook.com (2603:10b6:610:4d:cafe::e7) by CH2PR19CA0020.outlook.office365.com (2603:10b6:610:4d::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.12 via Frontend Transport; Mon, 9 Dec 2024 18:53:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A348.mail.protection.outlook.com (10.167.244.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:10 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:09 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 01/15] cpufreq/amd-pstate: Store the boost numerator as highest perf again Date: Mon, 9 Dec 2024 12:52:34 -0600 Message-ID: <20241209185248.16301-2-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A348:EE_|SA3PR12MB8811:EE_ X-MS-Office365-Filtering-Correlation-Id: 49d8cd2f-e185-4c10-ae0d-08dd1882ba86 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: v/GfTwlUE9cHn9i1PC1zYAMqmLrox4KYq2w8/YbnkuEqDh0Lh8BbfifxPY8MxODjsP2Xkc2z6U7YoWCt7gNes1ey0x82GqQWHnBIgBIxEQjVXz/nl/s59d+sgTw8RUeCugf+DpST/S0LMXXEiadR61wJxKQu+35MrpiPn3aKsvqGg5YPQOYXAAA67gIO8tyj3qdlplaC7ReGUJPE54VSwEz9WC7maXJBukKoKRiwRTF/dEkXbgv8C15rfl23CJFQDk3SvtCHqfU3KG04BzBViZaTq70b/dtrt0aCiEccWQDkfjTQ0svtIOKjAb45VwyUOFmU6I9qxafjKkEbGXazMN9BcNJxsvL/MAaM7Qs2rXMyO3jOGnxxJeib5LrXbswLd/QjcemSGB1Q1q/AquMfZuXK/y8fbfetn3OPXDijK9+DZ1KU8r2ZtGyFn8H3Tvk4NhjvrrSK1AAodGNaeRLKZ7quhuijVGV2V/MAiMUApVLt3FU1olP/IRtN8wIAugp0fN2wikzN5ohyGyDangYD9wt+4KyGCS7qqWRSp1cezpsK9nHZpZi2rwP15l8shUQ29mkVU9rvWTuTFZB0slWMB0AuFoY17nWP5GqSYLljjBf8/QktmPwAa7WtnizxFo/iHKHBa6Faf4p3bqPohM8BklHWmqyJasJmJ94Z8NnOdEG0pVgjlXCVHUIrBNUYcYYZ7GgnMD5oDwV8ZmqQZE+ZuhxrRy0Hjn8S/4tmCUi0ml5k/Yn43zj5HqfbVOramZJ0M0WrM1KlUi3jWxjSKqTlwRaP89eB8wMu4nIDlqRrafPkqzk8BMbuweshpnA54uG7V3RSHEbxYHSxC4O8aLWNJBNXxYZjiGE9KiDNe4qOX9DsgjRFGh1s5+9eAOh3uQ2Plrrv7AfqqofdqNbKtuqlCx28ZooekY/7/8Ig5krf6ddkgDW9L0F5Z1xNTRR9oztceFmm+nh/SkyzdZ7nF45Jg26X5FH0jKhj+C6AEnWO1fnSv/XjvxrKZkYkqjpRJYze4BNFt6wobc9JP8/9q9Mf/LyWa7QPPTQPcSOEu77CaB0ddyEbXup4BzoyA9IbAeA4rcOD6mzLzLW/tjgf38UaeHhfFrZJDlrylUHxrdSkuYDPFane5FNnJG3j5XWskhH6Goqv7RX2gi8sdFI+a4QA8FGCOjE4VZuN8QGVZwR7rpcIJvcvw1Ejbcp6LYpaP3ALYd3xwSL6aitkqW9DOm/kegTEDjWO2L6sEaTa8nV5Pk09ln5nkbq//9tBu1ETgwLePiU6pCZFOIHWNVIaHqAaXU81Zpr69ai0vma6flktQpIzPo7Ant580AZq7evKFt6oNt1ZNH4zOaFN/y9mlx50tL7h04EyF3itkBGNJOyIoC5u8diRlRS8OQBb3C0DZtcs1oTbF0iBL6Ttnp/8G2OHcUoxwkCciAt7C1uUH+RtYeOTudWfguXdPG+erWFpirNZ X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:10.9744 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49d8cd2f-e185-4c10-ae0d-08dd1882ba86 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A348.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8811 commit ad4caad58d91d ("cpufreq: amd-pstate: Merge amd_pstate_highest_perf_set() into amd_get_boost_ratio_numerator()") changed the semantics for highest perf and commit 18d9b52271213 ("cpufreq/amd-pstate: Use nominal perf for limits when boost is disabled") worked around those semantic changes. This however is a confusing result and furthermore makes it awkward to change frequency limits and boost due to the scaling differences. Restore the boost numerator to highest perf again. Suggested-by: Dhananjay Ugwekar Reviewed-by: Gautham R. Shenoy Fixes: ad4caad58d91 ("cpufreq: amd-pstate: Merge amd_pstate_highest_perf_set() into amd_get_boost_ratio_numerator()") Signed-off-by: Mario Limonciello --- Documentation/admin-guide/pm/amd-pstate.rst | 4 +--- drivers/cpufreq/amd-pstate.c | 25 ++++++++++++--------- 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst index 210a808b74ec2..412423c54f258 100644 --- a/Documentation/admin-guide/pm/amd-pstate.rst +++ b/Documentation/admin-guide/pm/amd-pstate.rst @@ -251,9 +251,7 @@ performance supported in `AMD CPPC Performance Capability `_). In some ASICs, the highest CPPC performance is not the one in the ``_CPC`` table, so we need to expose it to sysfs. If boost is not active, but still supported, this maximum frequency will be larger than the one in -``cpuinfo``. On systems that support preferred core, the driver will have -different values for some cores than others and this will reflect the values -advertised by the platform at bootup. +``cpuinfo``. This attribute is read-only. ``amd_pstate_lowest_nonlinear_freq`` diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 66fb7aee95d24..c51026fe636a9 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -397,15 +397,19 @@ static inline int amd_pstate_cppc_enable(bool enable) static int msr_init_perf(struct amd_cpudata *cpudata) { - u64 cap1; + u64 cap1, numerator; int ret = rdmsrl_safe_on_cpu(cpudata->cpu, MSR_AMD_CPPC_CAP1, &cap1); if (ret) return ret; - WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1)); - WRITE_ONCE(cpudata->max_limit_perf, AMD_CPPC_HIGHEST_PERF(cap1)); + ret = amd_get_boost_ratio_numerator(cpudata->cpu, &numerator); + if (ret) + return ret; + + WRITE_ONCE(cpudata->highest_perf, numerator); + WRITE_ONCE(cpudata->max_limit_perf, numerator); WRITE_ONCE(cpudata->nominal_perf, AMD_CPPC_NOMINAL_PERF(cap1)); WRITE_ONCE(cpudata->lowest_nonlinear_perf, AMD_CPPC_LOWNONLIN_PERF(cap1)); WRITE_ONCE(cpudata->lowest_perf, AMD_CPPC_LOWEST_PERF(cap1)); @@ -417,13 +421,18 @@ static int msr_init_perf(struct amd_cpudata *cpudata) static int shmem_init_perf(struct amd_cpudata *cpudata) { struct cppc_perf_caps cppc_perf; + u64 numerator; int ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf); if (ret) return ret; - WRITE_ONCE(cpudata->highest_perf, cppc_perf.highest_perf); - WRITE_ONCE(cpudata->max_limit_perf, cppc_perf.highest_perf); + ret = amd_get_boost_ratio_numerator(cpudata->cpu, &numerator); + if (ret) + return ret; + + WRITE_ONCE(cpudata->highest_perf, numerator); + WRITE_ONCE(cpudata->max_limit_perf, numerator); WRITE_ONCE(cpudata->nominal_perf, cppc_perf.nominal_perf); WRITE_ONCE(cpudata->lowest_nonlinear_perf, cppc_perf.lowest_nonlinear_perf); @@ -912,7 +921,6 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata) { int ret; u32 min_freq, max_freq; - u64 numerator; u32 nominal_perf, nominal_freq; u32 lowest_nonlinear_perf, lowest_nonlinear_freq; u32 boost_ratio, lowest_nonlinear_ratio; @@ -934,10 +942,7 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata) nominal_perf = READ_ONCE(cpudata->nominal_perf); - ret = amd_get_boost_ratio_numerator(cpudata->cpu, &numerator); - if (ret) - return ret; - boost_ratio = div_u64(numerator << SCHED_CAPACITY_SHIFT, nominal_perf); + boost_ratio = div_u64(cpudata->highest_perf << SCHED_CAPACITY_SHIFT, nominal_perf); max_freq = (nominal_freq * boost_ratio >> SCHED_CAPACITY_SHIFT) * 1000; lowest_nonlinear_perf = READ_ONCE(cpudata->lowest_nonlinear_perf); From patchwork Mon Dec 9 18:52:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 849043 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2066.outbound.protection.outlook.com [40.107.244.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C02D91925AC; Mon, 9 Dec 2024 18:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770400; cv=fail; b=cu/NbTUwphUpGwJIr5jltDfy4JfCWKqrQ+gdqKJw9Ki7wkP9XUZl/O+T1q5+ELw9kKwZzp4btWTWzo5UrJAlgFR4GawKtjatRwcXDqt7v03m/5SaS7JW2yjjiHVijWVXYs5qFIj/SH5H/TzMpbYhlLwHyW8JZ3Qft0ADokFYXAQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770400; c=relaxed/simple; bh=1hJEV4TDhoGWDNUVBi1hBVjXPxwh22hJPz7IsiVQiEM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f7U5Jk0ItQcQrhvyhmQ14p1Iv2BgK7SlPw1BLsFR5rpe7mFTQAkl14pqvh5DrhzgbYRq7Lm5K44p1GxwMf9dvOHioCom9BiPA54MAcRph2Xa8upbTXewFWi+KEZcurRYe8831VmSC/spOBgKNnoXP/xzSbDu/HYqvBDAu81kwoI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=w36bWWlM; arc=fail smtp.client-ip=40.107.244.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="w36bWWlM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YAU5r+dbkj+MAjmh/83vmP3oKdhb5MKjaK6hLDg9XUQFSknhfhOoiaejEodH5vuHwQl0ZrR+BxHVgz+Gu87PH+SnhZdmBXJT5gJYo+t1Uh7AUuswFUQ7t/7FdHDiwETVSGkrCHhepmy3/pvAlI+Q/QG3+YYKTyDVVgupV2LSZCJPzJfmVngTfS2FzZgoQrwIuHw4I1qQ7GN+Vos7bGaYMde0x+oBHcKEZx4ayUQW3hL9yPB7d3hbRQc4t4m0UeOO2LISZqbfa5gZTSGX/5/fdHvXA5UdQ/T1nVtEAQPVnAXOWnM/MUgJAh19NfT+1Hf5tYzDpOzgSHfIa46NWbQoSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ucqe8HPLacp3VkKxDehsSMBwOsryPZmCHnwY2O0VS3Q=; b=RSI+yqAdj0yYTyZt6VKcQ8qEv8EtkZeCqsNns7hYq8/C2HgUpxO9TBjH5TaW1zCYmIozlg5yWoKqctbkTDBBbkaPXd3ZEDHitaicBxcoUbvTs8LvFHUVqHkD/0ul/P6HEkPqScDL36qtbhwlHRQyUE/xfJ9bh12T8EVCNxneYCP2zypBGsyzjG9hAOwc6jiFHrJDpi7LeVabGQOplnniWsIztu+S3kxgKefVyZRRiClG4/2DpOMU6JrnL+dW1AjW2vY5ZM8HNt/oUwO6+fr+dqVB6pnZyRVQ03Is7eLQ3DqV3nIPCVmjUZzq6UzNIzbpaz+fzLe3kk0ZN128AVHK7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ucqe8HPLacp3VkKxDehsSMBwOsryPZmCHnwY2O0VS3Q=; b=w36bWWlMVo98i+83kChrFMDc/BDNTUoGXZZt3njfIYLzDoMGHACxnPLHwL5XSlTpA5zcMmQFcanSTBSsQb52Pu6Rpl2oiXXfYdlQzAduCclKEeWznY+ArfQ4UhnJvHf4SQzECyvzGWPhVuPKtJhzkz0eRGq/7sGicdg7o17iT7U= Received: from CH5PR05CA0021.namprd05.prod.outlook.com (2603:10b6:610:1f0::18) by PH7PR12MB5710.namprd12.prod.outlook.com (2603:10b6:510:1e1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.18; Mon, 9 Dec 2024 18:53:13 +0000 Received: from CH1PEPF0000A34B.namprd04.prod.outlook.com (2603:10b6:610:1f0:cafe::55) by CH5PR05CA0021.outlook.office365.com (2603:10b6:610:1f0::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.12 via Frontend Transport; Mon, 9 Dec 2024 18:53:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A34B.mail.protection.outlook.com (10.167.244.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:13 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:10 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 02/15] cpufreq/amd-pstate: Use boost numerator for upper bound of frequencies Date: Mon, 9 Dec 2024 12:52:35 -0600 Message-ID: <20241209185248.16301-3-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34B:EE_|PH7PR12MB5710:EE_ X-MS-Office365-Filtering-Correlation-Id: aa0e1ab3-491c-4861-6450-08dd1882bbbd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: adSuj5qgR1obDd1DUedaC28FxhxB8rmM7W9VqJ8Ufe/CevUAXQMfvoXuKoLe1gEgneGz8ymYl9cUBpuMuzUMAM9LyRTm5NXeYhyca/OO32XJXqYD77A7lJaq1aq9FRssbBAQ9Cy+gd4D4TB+NnS2BPgneO2rWgXNK+sGXVa4q4xFR3gIwapUArTkcqL5G0WwQ+Rmm44ngjTsafY24tALaqUXtOfKEtByroGepaRCmtRxknm4l3dolYtK8SsxawqGNOB0ZOHzUOigFWgNzTn/Yjbzlusp3MWVY4+L0OU2xXgASROCI3eT2GL/+CdNf/eH8Cs0al4b3BEuvt5+MqDjy9Hjjsus1tvklJ2IYkouSS4LRbyag4UleHpbbuR/SI08qF/+FpfPoNxkG41h0mEJnt9dZwvgh++GMf8yBHEKnQ+LEmpzqgxnk0a2QG4AhobBYpbixQqiWi0f6PK8rQ8w4dSyDCxMb7BJkH2PKRNJsfAvbkjg1iY0KjkcG0DAOY7l4VmFID9K14qEoPDSoNypmmOhZBQb6pvj5o7Mk47StxtkoS7hz+E7DYwz39Yo9hwV/lCmpwhoEEtoP9hX+Onyrpegqu8Pc+6s2pJ1y1QnolAcKC4RsQAao5PMWku2OyzCKzFPkDee63np93zFrKx/uCF8FHbEmybUwpxLONpW1hVSP14N4Vk8HDq1+ktQ4dvR0JL0zFbOYclkVZhUUuTeF4zg+MeVhAaQ2PrHo8Zw/8v2xHs+EZi03mXfSwghZOD1nomk3SMytDQePMNerCuZqOFX7u3l2VeC4mdhftI/LL9dyZP6yP+ZuPJv93Q1oDnPRzFfs0Irrc5msjwCHpmVu2Dt09uuz5rNZoDIj1NT1lN2VWlERKs9UfT9Ksv9BDI9SJ35hBMsqNgunvKZfeHTV/EHu1hvYwubolJylejHwCej2sdRAeeqUEqt8AZYb81a0X4vaFl6Obu3sp1QYO3T6mZrUecw6JnL72BkP5BO0h0+ZAAMhe2U/HF2ScQW3Cd5ThuOvXK1Cl8A3s+/WotRNH5Bm7tLMoGHfwRaRvddZu9q9Gv0alA5oB1YBNisG7J9lQmCBSZF0NN06j24n6jZuqFny1fVnY1nucXd8nLHU0AyL9eHilOYaF2w+EpY8uD3fjCrJgA7vyfIv1y1C7tbNz9RABNtgiZaYFJcZFyRS+Wnnj+jE7VQ77IjLes4EVE+f0vYV7yaeEwx1be68IrI+now2IKzyLR3jwDLlAEQu57ELucagROrdG47q1QK6HPrZGTzeRwUNwgFgyDBBVF5Lv3TEEjEl0FOnDSGNAdp5QOCbck8cuYwwRL5D6spIquv8KYBN4oGZ0p263y7g7eE2VKTmy2VLki5jkUvenXx3F/mCkWGPdZc+Dom8r7C8dh/6+glxBTAgdJU9NTEFrDycN2X/sjpJtlXkc9Ox078ORt8ZGJt6+h1LKCTOGE0v9QD X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:13.0263 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa0e1ab3-491c-4861-6450-08dd1882bbbd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5710 commit 18d9b5227121 ("cpufreq/amd-pstate: Use nominal perf for limits when boost is disabled") introduced different semantics for min/max limits based upon whether the user turned off boost from sysfs. This however is not necessary when the highest perf value is the boost numerator. Suggested-by: Dhananjay Ugwekar Reviewed-by: Gautham R. Shenoy Fixes: 18d9b5227121 ("cpufreq/amd-pstate: Use nominal perf for limits when boost is disabled") Signed-off-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index c51026fe636a9..5e0edb65de32a 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -593,16 +593,13 @@ static int amd_pstate_verify(struct cpufreq_policy_data *policy_data) static int amd_pstate_update_min_max_limit(struct cpufreq_policy *policy) { - u32 max_limit_perf, min_limit_perf, lowest_perf, max_perf; + u32 max_limit_perf, min_limit_perf, lowest_perf, max_perf, max_freq; struct amd_cpudata *cpudata = policy->driver_data; - if (cpudata->boost_supported && !policy->boost_enabled) - max_perf = READ_ONCE(cpudata->nominal_perf); - else - max_perf = READ_ONCE(cpudata->highest_perf); - - max_limit_perf = div_u64(policy->max * max_perf, policy->cpuinfo.max_freq); - min_limit_perf = div_u64(policy->min * max_perf, policy->cpuinfo.max_freq); + max_perf = READ_ONCE(cpudata->highest_perf); + max_freq = READ_ONCE(cpudata->max_freq); + max_limit_perf = div_u64(policy->max * max_perf, max_freq); + min_limit_perf = div_u64(policy->min * max_perf, max_freq); lowest_perf = READ_ONCE(cpudata->lowest_perf); if (min_limit_perf < lowest_perf) From patchwork Mon Dec 9 18:52:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 848615 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2086.outbound.protection.outlook.com [40.107.243.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6CC717B4F6; Mon, 9 Dec 2024 18:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770398; cv=fail; b=Bmnp9mQRIi1XbuojzDj6woXCx1wwMvL66vrSaRg3UFq/2GvHWequhgbj7O/As9hl9FUppqj0Lvzmm0vi1uq1P6DxoBmTamV++iNmbHwVREvxLxg+J5v9KdNxgp9q9DEs57mc1q5Gcb2hdydpCZkACStqmdWLJkhGbtxn31voC/c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770398; c=relaxed/simple; bh=mbGSROJp4wSwquZuym2lRA9xfWQ7OOjejKLhk3ZWCuI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jXHJol95XVqv5CVPiicP6JvQZqmTRJcON7t0W1u6J9M6/DEHYtRCHEsT5jkEqS9Xytx/6RHLde3hRsWnJpI08HZTtuh3iit8Gq12x/6FR2N2bY7tKd+CtHxrlH2FEw+pTCWZy4H2vQhGvKr5mBqjaWUbFNS6V4pwYicFatZnWb0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=4ncNgQV+; arc=fail smtp.client-ip=40.107.243.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="4ncNgQV+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lioMm7tfbeIip2XA26pOIgAi/Jf9Zbo8PoSuUsc3CKR1hzsPrxRQ0PLkzHys6uXP0EhC+3onvAZ+vCvT1QwKhtvIOdiVW7N5HPf/E24mRlLBgKRrqFtRsDHRQoYPGBPXXftEQcAo+nOZy2Jbs9LGRIuK3CytZIWL7dOBIpXdm1haMIYplp42sJ2Jrk5RyWwpEXQquuL3kPOP9hQVk07tj+Hf8KcP+6vcHYmEagNRkffs+5jEuLGt6/ya5f/29BLVylQMUythMeRP38lOvgHXAixmlx4cC8KjtnWsP5lK6Boml/gRwHWc5n4exbc6LVry/vWzQyIIHasfURBPwcx8Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lo4tJVtZZmMIBRDMm+wEsoDtzBFcHTiYqL96ys7GfJQ=; b=mx6ly4hF5sExKq6ZnKsJAGY3Ak0YkKJo56Rt1R7lV0FCqpW4UnvqICWoWwaSBAqq8CrgkJqLTR4hgvySaWC/z7vM4pwz2pOiPAKBwhsZQSW0zCCNAn9GAsOvVwc6JX8oSxHJwc1w5PCcru7fycL3y23AkigbsHme/ZAAZINBsE1cFuF0aX8X4hbWrrGIHNpip7ceFLC2H9/r3FNoMrmLrJccZW0X3JT5/Ktb3pQauUbW92i39Vk7lOMsMPPy0HZmqdmmMhfliuFCpGfiDAeuTegk6z5bnlqZNZvTaTDD9fADVSGVNVGr/RNLy+Qm8jpv33u4c8zcwZGUUu99cci1VA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lo4tJVtZZmMIBRDMm+wEsoDtzBFcHTiYqL96ys7GfJQ=; b=4ncNgQV+FJe0+uyeInzKvcYsVpbh1RSqARWuLjuU3kH2JbPLPZjtWJnerCN+fb37zANFB8MglZ2bqYbOK2j1LUV6HXODmWwt6WrFxOZRDAX0/gRTa9G42LoARzP/xAXc1zuwx/bsKKPwIjWDaQVhZDQrYDNZCONK6aUUNmSSgQI= Received: from CH2PR19CA0027.namprd19.prod.outlook.com (2603:10b6:610:4d::37) by SJ0PR12MB6710.namprd12.prod.outlook.com (2603:10b6:a03:44c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.18; Mon, 9 Dec 2024 18:53:13 +0000 Received: from CH1PEPF0000A348.namprd04.prod.outlook.com (2603:10b6:610:4d:cafe::88) by CH2PR19CA0027.outlook.office365.com (2603:10b6:610:4d::37) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.12 via Frontend Transport; Mon, 9 Dec 2024 18:53:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A348.mail.protection.outlook.com (10.167.244.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:13 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:10 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 03/15] cpufreq/amd-pstate: Add trace event for EPP perf updates Date: Mon, 9 Dec 2024 12:52:36 -0600 Message-ID: <20241209185248.16301-4-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A348:EE_|SJ0PR12MB6710:EE_ X-MS-Office365-Filtering-Correlation-Id: dfc1c6e2-df0c-4000-2826-08dd1882bbe5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: iWJlMvkb1sqYRE7YTCAFl8/dlzd0e/n3tlWmQkmnym0rWycqynaXrOaSBYWZwM0fQWO3F9KPY4ymBrQslBc+j9aVduEw+iPWiC1Id+N58Xps4CTgOwevznNobwKABtU/3pCpoQGEMdG5XBUjgte0yOwMR7h3ynwe4uoPM+2j7O2CzUWCu9ebLbhoywsXGyQmJfikFbech75mFmIMfTHSwIgMQVcIA29rYaCqJSaSSnqIil1MbfNIYmtY52aTAM4wmxKdXC1rNDG4B40irFMaDSvGf5nTxQhPjZco4sF8PlP4iVaUcIytdrRUwReC22EfaUZjOnlvOI/fTTpMAnbgjxQlH3X2Z95pwYOhWlgPkVBLDjfnuzOR8qDHZkAFdXP1nzbkSh1NlkqFNgcIBdYrULJJtSCp+/OSbx1GPpoWgROtjvOJzJ9CMi1sxsuH8d05tahMSdX8br4CiZE1qU3Wj6GEwYHTkws6b+LWy8pRNo+Wknopxhr1p9JQepBSrlGc6WFAe738wx9P33Cg8+8g+VWiCYzV6GoURYImnmjtyui29950iC2WPwob25TM35mTcICQPNmeyvgOpbgSHkaQwuosZ4UzkSM9oFgJiJtwjRWx9BBgY0VLucwrxsTEBrt/qzQoBoK3SsHFQ/r7nkZxRwKGlB5FERW26MXzP4eokel+nmBJ59u9M4ALmC4b1WGFe5zOwkmjNIYu92q34dWXqJBJBtiheJnHqRIlRLFfwVvAyVdQU8FneENwXmGlsIND7A2hZAE00r374YYFInIvb1OnFiaAdcLXdfpZfqrwPaaDWaOJk7+bs/hnPbkn5s9qbK1xYqnUvISHOo+09wL27piGVTh1hHDnC2ZAcEJcfPLefnZeKTM/4IBPqaHzmsC7VGg1xUtpuYMQzOxjN4DfF4793aoLAuLW8LpFuHLe75Ik/oc/1c8tjWM+eeKNwt5j22Gt6vUEoxFCNp93SGtlaHDlr842dQJwyjITkhVFDt0SAXJeWAT9rUQQbkp4JB6NEDj3+2e6Bs4PXsrjrzHR3zoABAXp7FTgjdvs8qrVW9Dpx+TGmBd53MgLqB6coLlnzd2sk6MYM9Z5aOqTkx1E3uqE0aghaYoovOhqMiwVAhDFuGmhdP5cXaviqfjQghfTItIzkoDM0umOI7MsxaSbwTE5jaJRZwgXFyTxqmdo+p0jQARc51zt/T1MN3jEKm1n63o8QKoORfaJS85tbcw21VNB1M4mSaDHLrAO4cibB/yDKtsRbSBZUKoRsIFjD/xyiJ1aepudKZJhVDWD6PugvWaImxKnH0ACZmmfqWBtsm+QzzaJL4ymUyHJGpwPXiVvcrsEUHsUghXwtEyAftfNw0talbFl9VrmfmBaOkBYbAebS441fUfOrBKi4PmZCEo3g7XUtVofFNMx9mJq80sCHA7SV3OAMLRCApxR3v36qy2TKl5Q55zirQGRRft/7Dg8 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:13.2869 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dfc1c6e2-df0c-4000-2826-08dd1882bbe5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A348.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6710 In "active" mode the most important thing for debugging whether an issue is hardware or software based is to look at what was the last thing written to the CPPC request MSR or shared memory region. The 'amd_pstate_epp_perf' trace event shows the values being written for all CPUs. Reviewed-by: Perry Yuan Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- v2: * Fix boost in some calls --- drivers/cpufreq/amd-pstate-trace.h | 45 ++++++++++++++++++++++++++++++ drivers/cpufreq/amd-pstate.c | 28 +++++++++++++++++++ 2 files changed, 73 insertions(+) diff --git a/drivers/cpufreq/amd-pstate-trace.h b/drivers/cpufreq/amd-pstate-trace.h index 35f38ae67fb13..e2221a4b6901c 100644 --- a/drivers/cpufreq/amd-pstate-trace.h +++ b/drivers/cpufreq/amd-pstate-trace.h @@ -88,6 +88,51 @@ TRACE_EVENT(amd_pstate_perf, ) ); +TRACE_EVENT(amd_pstate_epp_perf, + + TP_PROTO(unsigned int cpu_id, + unsigned int highest_perf, + unsigned int epp, + unsigned int min_perf, + unsigned int max_perf, + bool boost + ), + + TP_ARGS(cpu_id, + highest_perf, + epp, + min_perf, + max_perf, + boost), + + TP_STRUCT__entry( + __field(unsigned int, cpu_id) + __field(unsigned int, highest_perf) + __field(unsigned int, epp) + __field(unsigned int, min_perf) + __field(unsigned int, max_perf) + __field(bool, boost) + ), + + TP_fast_assign( + __entry->cpu_id = cpu_id; + __entry->highest_perf = highest_perf; + __entry->epp = epp; + __entry->min_perf = min_perf; + __entry->max_perf = max_perf; + __entry->boost = boost; + ), + + TP_printk("cpu%u: [%u<->%u]/%u, epp=%u, boost=%u", + (unsigned int)__entry->cpu_id, + (unsigned int)__entry->min_perf, + (unsigned int)__entry->max_perf, + (unsigned int)__entry->highest_perf, + (unsigned int)__entry->epp, + (bool)__entry->boost + ) +); + #endif /* _AMD_PSTATE_TRACE_H */ /* This part must be outside protection */ diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 5e0edb65de32a..a59c897dd59c7 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -324,6 +324,14 @@ static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata, return -EBUSY; } + if (trace_amd_pstate_epp_perf_enabled()) { + trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, + epp, + AMD_CPPC_MIN_PERF(cpudata->cppc_req_cached), + AMD_CPPC_MAX_PERF(cpudata->cppc_req_cached), + cpudata->boost_state); + } + ret = amd_pstate_set_epp(cpudata, epp); return ret; @@ -1598,6 +1606,13 @@ static int amd_pstate_epp_update_limit(struct cpufreq_policy *policy) WRITE_ONCE(cpudata->cppc_req_cached, value); + if (trace_amd_pstate_epp_perf_enabled()) { + trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, epp, + cpudata->min_limit_perf, + cpudata->max_limit_perf, + policy->boost_enabled); + } + amd_pstate_update_perf(cpudata, cpudata->min_limit_perf, 0U, cpudata->max_limit_perf, false); @@ -1641,6 +1656,13 @@ static void amd_pstate_epp_reenable(struct amd_cpudata *cpudata) max_perf = READ_ONCE(cpudata->highest_perf); + if (trace_amd_pstate_epp_perf_enabled()) { + trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, + cpudata->epp_cached, + AMD_CPPC_MIN_PERF(cpudata->cppc_req_cached), + max_perf, cpudata->boost_state); + } + amd_pstate_update_perf(cpudata, 0, 0, max_perf, false); amd_pstate_set_epp(cpudata, cpudata->epp_cached); } @@ -1669,6 +1691,12 @@ static int amd_pstate_epp_cpu_offline(struct cpufreq_policy *policy) mutex_lock(&amd_pstate_limits_lock); + if (trace_amd_pstate_epp_perf_enabled()) { + trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, + AMD_CPPC_EPP_BALANCE_POWERSAVE, + min_perf, min_perf, policy->boost_enabled); + } + amd_pstate_update_perf(cpudata, min_perf, 0, min_perf, false); amd_pstate_set_epp(cpudata, AMD_CPPC_EPP_BALANCE_POWERSAVE); From patchwork Mon Dec 9 18:52:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 848608 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2045.outbound.protection.outlook.com [40.107.236.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A64EE19B5A3; Mon, 9 Dec 2024 18:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770406; cv=fail; b=fpDNkH4NCzBiYExz4OrJQruAu7lYdFOtUv71XCfleppxGgVFhMSwHUEpdNQ93JKoQU7r1Mw/1ls/DuntJ1U9YJgQbpg9oJKY1AgChLdcme1iP2IxNhF+YaRNmj+GS+mzXC3NLyP0TU1hXLpwhelO00DcNULRs1GdQ+/PtOkuJpQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770406; c=relaxed/simple; bh=8IcjiCBRBloocPYDiXM+yy0x6VYm2tN+z9Yn19WjWAs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fetwy9j/Az0XMhB6vS/aj3dRH93K/+awbEnp0jfTFNxadSpvnDiuczB88B6Fmo1l8AgRT9nVhuhHMjuwA86w4Q/UFuPtgcNLy6lC2Ksad48nwiV/2+zpa1/vpuHYQxQ77PzwCbJZ5/UXs3GkLTt+C4LvekdagVgRGlyiqSbSj/A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=DeqSfLnl; arc=fail smtp.client-ip=40.107.236.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="DeqSfLnl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R1n+p+lkNbXFMgcYfINW4m8uIZdwmWM4gbhUWkW1MvNTT9Cabllk2prr9CO53h4tGJxRxYz5kFwXNqr4BuAYX6yb+GwQbaRnC+lGyoiMDo7zMabANk7orrAJq0Hqd344mWPjN7YjVXX9+15sQR0WdtHRQ6hNmtu/1JSL8nj+/hFcsCTFE+52DaBmXklr6fQaMYwSpeGn8kp4jLYw1BASAi/sLf4NwY8cDpewnUtbvCs+gojfXodSVjZrVfvW10TQ3ce+dAwywAaO99k0rN1j2OojAY8I64oT16S/YHb9oI41upj6u+IuLDD9aGWSvAn9ot5gJ5S//G9FZ5NewDGxOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b9okcBsyNIrSTLz/dzY0VUNNUwo9aBdy5mYXE/fMqWg=; b=wICqK+cw9j1AQWofdkypuSZq58p3prutaAtE+B8Yc5zq09PhAP1SnfKo8fPolVKBUg1OxUkWx4u3Xxm3rDBXXLIZWffDag2v6ffJwr6UTxDrtpGM+mdw4P4JCaye6svFgNpuPhownT6oVYDHYe3Yhm0FZXf9KukSb8QxHYfqJWdYB4o1qRRwH5XA+dDZnuS55jkiN05b0aRZa83kooGKllNnfpUegllYZCriXHWV5jCXkPqGiqCyzwTrfrN1VYpg9kp8dTnsu+uFUXATlfFN4Kgy/4S42oLuDyQTAax5xFWqMieIfGg5pob8yAkbmqCyy6Qa/RXagwuJdNzIBdhQ+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b9okcBsyNIrSTLz/dzY0VUNNUwo9aBdy5mYXE/fMqWg=; b=DeqSfLnlii7HsFBPk+3OSrx1wwQ88Ld4D4xiBFlxwdRlBqDxFeLuCnw/YyY71acsah2k6hPGUFyJvbh3lSLYSp+jeIgKgbQ0UnrZToJ11k7TJQ6hI5bVtENz7GzaJbgQg4ZNLHfRsCMYwviX9kZ2oytyKcInP0glmQ6cOe0REqw= Received: from CH5PR05CA0023.namprd05.prod.outlook.com (2603:10b6:610:1f0::25) by SN7PR12MB6861.namprd12.prod.outlook.com (2603:10b6:806:266::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.26; Mon, 9 Dec 2024 18:53:14 +0000 Received: from CH1PEPF0000A34B.namprd04.prod.outlook.com (2603:10b6:610:1f0:cafe::c6) by CH5PR05CA0023.outlook.office365.com (2603:10b6:610:1f0::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.9 via Frontend Transport; Mon, 9 Dec 2024 18:53:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A34B.mail.protection.outlook.com (10.167.244.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:13 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:11 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 04/15] cpufreq/amd-pstate: convert mutex use to guard() Date: Mon, 9 Dec 2024 12:52:37 -0600 Message-ID: <20241209185248.16301-5-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34B:EE_|SN7PR12MB6861:EE_ X-MS-Office365-Filtering-Correlation-Id: b6112dc9-e337-4bb6-2323-08dd1882bc3e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: L/KN2QkJMIZUAnWO/8xxzw97xR/VWiAU1Vak3rY3ddiV4EIMQx7lsCvy2iTHgYQiHXW5mJQ77hiWzcFbeGGcYC63Z9LEIDFEPTJ1iXoleMRAyR3cLZO9NMbGlecJTG7bBwV8zxq2KQTYo7HQxBEXAHZUwKO4QkwA4HwGdlz3EgGsBXlLl9A+m2NNzpjmaWJpQV4RcR7M77sFBG5VBUYpFx+EXwZkpKY30UTcFOmIQvAAqtHqLc1e+vpmiETggJcmxLNWnHtk7de5zulU93P0U942fN5Tcd27ZjWfdOI7i6M7Wrx/kPEB8ouou14b5z9jbhwkMtMtbVmC1iC95jwsPaL9qIdau5lfuffPzlkr9t7MvAVgnxuzZ16WatyrkPenI7vgGo8UCp23+ITdD3C9chVBQ3Ee6PZ19KzuxOxT4ECrISu/iulwfIZxJPMNioL6fxI+O4WoWkz/vqJ3TwU0cExnt6E5GPobti+eR26AxrRGhyaAkaMzlFn08RZHDrmPVbxdeDFKuCz20CuMFQlFERUR0MFylue/ylwEeKlk8C6OMfM3+tlhJAapWZt1uvW9uY7zc/E/bCcex/JipSUnTnnfcWmUY0+33ac3mM8cEcU5XoFmAIBhUmbJqOZBGNEbqN4PsBvoOKoQE4U2kGQv9vtqKCu8EL1pGvu12acWJmiO29Gdcl+TKbIqZP6VkOVv2BTBrZpZVoFYQ63NNiTv9iS38XZ4PkWehvXxUINovcAZiSjJx/JeUQWSLFwsf7gHiSvfYePriT8qppsXbQ+EJimHmKCVSgYaj6v0tDp+9qeAB4sgxjK4GdpEX/amCMe3PwW0A67ORJkRWw3U78LHiB0UyKvrXXwWV6sv08s7w7UQQA6Xr910/dlnZU2vgQ1yNiKdkPCTAPafkGXFI4dlWpkMMfhI6/iWZNTpRlI+bzoFUenhvnv7kYwIRDSCcZ+TYhrreXQZHCXN3CqGpunQYkSHJ+kU+FCS/1H0sMzdyWvICweokAP+TIS6DWSXKIcoXlfCV5cVTEt6PCueB2YaZoYi4UFDVYFNLzR/lozaKXyCQtGGvJ2YrPcNEkxidOyaYKzbCCWELw2rrS3XU4MZ0UjxysxrzFsxzozhhvUTai7RXE9238SzOPPmlFKnoy7g43xL3g+9z6sjEC5c40Happy4USa6kdNMQfWPMVWs9MGqT/EHdklXShy+1sMaZxCchB9jBhcahzhjYLQGxgA6w43u0Rgrr0PNde1AvydlLBiM2Ze4ePMtaT0b3nucCyAJEqsdn4bUEOwTXfTJPNXNJ/E2n+6t3dznLGVnDi3CK9wy+C5nIuc1LtOgNddrhysGsD+BKO2/tVkheDZNe2n49fKqfiA55w+wlTPH7R7kTk+8QkENbWXvOiP7s4B36VGK9DqregSwaCYfqjez2HcLIeil7ywT/oH/VJV/9vJA5HVU1vfVwXDH5u2zt1gvRAW5 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:13.8544 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6112dc9-e337-4bb6-2323-08dd1882bc3e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6861 Using scoped guard declaration will unlock mutexes automatically. Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 32 ++++++++++++-------------------- 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index a59c897dd59c7..6a96d3a24c77e 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -758,12 +758,12 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) pr_err("Boost mode is not supported by this processor or SBIOS\n"); return -EOPNOTSUPP; } - mutex_lock(&amd_pstate_driver_lock); + guard(mutex)(&amd_pstate_driver_lock); + ret = amd_pstate_cpu_boost_update(policy, state); WRITE_ONCE(cpudata->boost_state, !ret ? state : false); policy->boost_enabled = !ret ? state : false; refresh_frequency_limits(policy); - mutex_unlock(&amd_pstate_driver_lock); return ret; } @@ -854,7 +854,8 @@ static void amd_pstate_update_limits(unsigned int cpu) if (!amd_pstate_prefcore) return; - mutex_lock(&amd_pstate_driver_lock); + guard(mutex)(&amd_pstate_driver_lock); + ret = amd_get_highest_perf(cpu, &cur_high); if (ret) goto free_cpufreq_put; @@ -874,7 +875,6 @@ static void amd_pstate_update_limits(unsigned int cpu) if (!highest_perf_changed) cpufreq_update_policy(cpu); - mutex_unlock(&amd_pstate_driver_lock); } /* @@ -1203,11 +1203,11 @@ static ssize_t store_energy_performance_preference( if (ret < 0) return -EINVAL; - mutex_lock(&amd_pstate_limits_lock); + guard(mutex)(&amd_pstate_limits_lock); + ret = amd_pstate_set_energy_pref_index(cpudata, ret); - mutex_unlock(&amd_pstate_limits_lock); - return ret ?: count; + return ret ? ret : count; } static ssize_t show_energy_performance_preference( @@ -1371,13 +1371,10 @@ EXPORT_SYMBOL_GPL(amd_pstate_update_status); static ssize_t status_show(struct device *dev, struct device_attribute *attr, char *buf) { - ssize_t ret; - mutex_lock(&amd_pstate_driver_lock); - ret = amd_pstate_show_status(buf); - mutex_unlock(&amd_pstate_driver_lock); + guard(mutex)(&amd_pstate_driver_lock); - return ret; + return amd_pstate_show_status(buf); } static ssize_t status_store(struct device *a, struct device_attribute *b, @@ -1386,9 +1383,8 @@ static ssize_t status_store(struct device *a, struct device_attribute *b, char *p = memchr(buf, '\n', count); int ret; - mutex_lock(&amd_pstate_driver_lock); + guard(mutex)(&amd_pstate_driver_lock); ret = amd_pstate_update_status(buf, p ? p - buf : count); - mutex_unlock(&amd_pstate_driver_lock); return ret < 0 ? ret : count; } @@ -1689,7 +1685,7 @@ static int amd_pstate_epp_cpu_offline(struct cpufreq_policy *policy) min_perf = READ_ONCE(cpudata->lowest_perf); - mutex_lock(&amd_pstate_limits_lock); + guard(mutex)(&amd_pstate_limits_lock); if (trace_amd_pstate_epp_perf_enabled()) { trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, @@ -1700,8 +1696,6 @@ static int amd_pstate_epp_cpu_offline(struct cpufreq_policy *policy) amd_pstate_update_perf(cpudata, min_perf, 0, min_perf, false); amd_pstate_set_epp(cpudata, AMD_CPPC_EPP_BALANCE_POWERSAVE); - mutex_unlock(&amd_pstate_limits_lock); - return 0; } @@ -1730,13 +1724,11 @@ static int amd_pstate_epp_resume(struct cpufreq_policy *policy) struct amd_cpudata *cpudata = policy->driver_data; if (cpudata->suspended) { - mutex_lock(&amd_pstate_limits_lock); + guard(mutex)(&amd_pstate_limits_lock); /* enable amd pstate from suspend state*/ amd_pstate_epp_reenable(cpudata); - mutex_unlock(&amd_pstate_limits_lock); - cpudata->suspended = false; } From patchwork Mon Dec 9 18:52:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 849045 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2087.outbound.protection.outlook.com [40.107.223.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3212B187844; Mon, 9 Dec 2024 18:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.87 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770399; cv=fail; b=VdFdcEZwcpnQuPiGtHO/zdzPZPZrjEQLkWlkdwF1mOWJpRKV011aw4qe0nDVOO4bjfeBJuNfw+L6FHCGVZ3gMk1PCZqoYFp5dSdwC24rqPaKUIwiO3Y16/TjI1mC11hLkAlxxlI7NjcL2pXgLXuS16Rf+YMG7ASl8sgnaBNrZ8o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770399; c=relaxed/simple; bh=6MTHRL5MHUSp36pwBet7p28UW/1GIbDwH06pyPCfy2s=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dUXGQ7sIBpqWD16RmtjcMz637bYRK+qzVc6PqetsbddJ1IzrpylJkG9vUdWnRm3mWSaY3v3Csa/MGTtbSsZBlozw4H1kEAR8VNCCIoqdc2wg4pzSORO8NNXij55gf+j8i7VxnkQuITwicp8LwNLwZYV1oHAIxTPUhgREVCj90R0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=S4D+G7of; arc=fail smtp.client-ip=40.107.223.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="S4D+G7of" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yMteiD9Gv4KCZf15kWg2A/SaE+eXT3lkaYH+N/YLq342e/Zkb2K3vCQ8dNZf81wbJj+PpvPSULhC0hfSjUi7+pY5bnIIYnjYRK4uEsJfzB/CyfzULP2z7rSMsSDVynMjlrSJWWBSv73JGLj4fdQgH9PR9i3SyLq3WdBJB8mEIYxmoWPC4Djd4DPEb2xQB1G5qfxEdhGtt50fuHTg2LyxK6N1kz7SV+COq7CeIu7DAuZkC6KJAdWcwHVaXDFBZBwywmT7kSGh5ozioiuC5wKpFnpM/kmp+y/KCeXwYEkpowuuC6HENM8ioIvTE+IFHm9bTuXPIZUUJtWHEgIIBmEocw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=saJk+iuS5VELA3XAGJetWjnvUPeLQzFGvShlQkEJD4k=; b=RhAiLb7Onxe96DvyXV6uOteMRaZlpI5eMAaY89gQ6yLB4JsRJ+m7LAIq3CaEQNV511WQR8WjQQAnW0i4qxeYY3xJy1uM4TJgAjxbpwHNK88MmcCGibpi3W+kLG5CRm5jiAvFKtVvsTyjhnMBBab5X78hJd91YCRpUUS7L2kwh0TNp8BTrRNKk4b1eHyoMfKv5ovOauroZ2NeOlluqI1zCV38reqUccQUAqY26FRaQn/LUC601st9g2Uvcb74oEp0qYgOuHh5Cnuh2yQxcKjy/InWoVJBVK/08mWIpl+gkIV2l6CImYRIkML/1swDH8ATldSArcgzlOAb2V2C1A0vWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=saJk+iuS5VELA3XAGJetWjnvUPeLQzFGvShlQkEJD4k=; b=S4D+G7of+btK1g3DdCwgFhSIca06ou6zL1paqgiZKrb4grgK17Yb6KBoCUHzSPuCA1asKyFkACwBVihvomO9LUqonn6DSHRJ7wxlX71qzv7dABa5mfslT+a6Ql8pUaxY+X7Nvxbkl45eqBlPIOJ3jI7EfblaIzm1NuoH9Q9w6jg= Received: from CH2PR19CA0023.namprd19.prod.outlook.com (2603:10b6:610:4d::33) by IA0PR12MB8207.namprd12.prod.outlook.com (2603:10b6:208:401::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.11; Mon, 9 Dec 2024 18:53:14 +0000 Received: from CH1PEPF0000A348.namprd04.prod.outlook.com (2603:10b6:610:4d:cafe::d1) by CH2PR19CA0023.outlook.office365.com (2603:10b6:610:4d::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.15 via Frontend Transport; Mon, 9 Dec 2024 18:53:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A348.mail.protection.outlook.com (10.167.244.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:14 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:11 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 05/15] cpufreq/amd-pstate: Drop cached epp_policy variable Date: Mon, 9 Dec 2024 12:52:38 -0600 Message-ID: <20241209185248.16301-6-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A348:EE_|IA0PR12MB8207:EE_ X-MS-Office365-Filtering-Correlation-Id: b5318070-06c0-48b8-d2c8-08dd1882bc71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: qXqTKB/KBiZE+Zr0SEbW+H6Ur9ZoFpDxsjFkpu4ZHYb/A23Bvu+vBLa/8QqkVCrBVHIAQ2/ZnhInjjAGIkp1Nkn5Vf05yTU3VLYZwosHS9opwLrv3CL3cB2/wg46iJB/mosezpM1C9ZhIygnVKYopC4/++FmXDvrl06pMfnGwTMkg9Q/6f9Ek7vXFLG/Of10M8TNIJTA3PDvoxEhgwAigQuHg2LnejYCLfPAp2QVXZmyeoye1/p9Y6zOFSjRCR1mvISmWjyjZR9NFgTnP3Vfh76gD9+veiuaNKd/BYf4PkfQb77B0y+llR6s6nIOuA7VH7rZCUNTy5UeVZeizGqxgCbsI+Oo8QlYZi/DsRg5i7cP9w10BzfXQa0dcLJryguScb8X9ufsojucXOiTHi9QN6lcmnan/VFipTT/Sd+v1qZKZmFVZWKGHnQdZ2ChCU8UM/TctUz3M9zUSc1EPLk0m0PMjPfiXHQ8gwtX/N7putevDoLCsirAUQFHJH4bHwfMuTzDGX7xWd3EMTKegyVTEcfG/TbJhwQh57FecJe68KlQlcA3b1kv5BqeqZnQim44UJw4p5kSMVGIeuRdQXg5m0qzyVrE2SkJ2pFD3tl+GxLOHm4NdPz++v0Ah9V0KeXpA5cvCUdQ4KEwispPnHvUwb47pUXxgJBjOWEC308s+xy8QP+Irqx9s/3RNl7rPRLQpOJLaWhkY5sqtuid5TUAUBUZz6r+pM2MMV5oY9WhEQwMTBL71bmfO4RC1I+TUhc/dRaVv1XuVdZ/NCUfFZZiTJdVs5LIqHM60nDYJrLbJtwKaLmh5CpufF7acDRAQ19J6s+Z6ERjKvEnEOKEs685UljRIKqJXxvzS94Y4TWSIPUJJObDxPvb8W6ie7Z/1cYrYkp+Lt8Chkfy2Oa9KOQqVv2DLSXTy7+iMxhTfHrLEtcjEh8aAW3gnpm2j8/zbRZiFeQWUT4tI8Z3jWLZraPBKZpEe5mKGHqRAXQhU2jmVN5jZ+YQLsOJdkG9gSHIQj7caV4oIKesBocqZv5N3HFLBnAzO3MgNG7sw78GILVog/nMERxTQaHD4kZJWJ4lzDJ+tmIHKVu7udC906JEC0uX/To3nq8kMygAkNaupF5ETtoR0tSeob0wm1iWWddb6MdQ8IHnCp8CrdiDGkBeJ/iVm5RrpMSXm0dyRQqQmw4dh17Fzs0MM4B2CM36ZMImSBUZ1I2OM4rcQl72MftnYT+9Gm3KDFFy7TTx6F79Amxm7nRkTESbEtSmGcQEoZSSI70SMy/GG6jgBjlwefefL6Mn4mTsCIXeJ806vpU1NveOq8PEj6goVwxg3ng0GRjIy1Wz5g0dauEu5cEh2a4ZSpJuXLFmduppVXSNj95HDEqePm/A3Gy2zRusDIvlmrUHBZ50wCuc13eT82Yli6HTqX1alOAyrnoGh9d76i9ivAL0cZFoufqpTw+3qvzKWT2h8wr3 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:14.1932 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5318070-06c0-48b8-d2c8-08dd1882bc71 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A348.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8207 epp_policy is not used by any of the current code and there is no need to cache it. Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 3 --- drivers/cpufreq/amd-pstate.h | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 6a96d3a24c77e..dd25e7e615984 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1478,7 +1478,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) return -ENOMEM; cpudata->cpu = policy->cpu; - cpudata->epp_policy = 0; ret = amd_pstate_init_perf(cpudata); if (ret) @@ -1585,8 +1584,6 @@ static int amd_pstate_epp_update_limit(struct cpufreq_policy *policy) value &= ~AMD_CPPC_DES_PERF(~0L); value |= AMD_CPPC_DES_PERF(0); - cpudata->epp_policy = cpudata->policy; - /* Get BIOS pre-defined epp value */ epp = amd_pstate_get_epp(cpudata, value); if (epp < 0) { diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h index cd573bc6b6db8..7765c82f975c6 100644 --- a/drivers/cpufreq/amd-pstate.h +++ b/drivers/cpufreq/amd-pstate.h @@ -57,7 +57,6 @@ struct amd_aperf_mperf { * @hw_prefcore: check whether HW supports preferred core featue. * Only when hw_prefcore and early prefcore param are true, * AMD P-State driver supports preferred core featue. - * @epp_policy: Last saved policy used to set energy-performance preference * @epp_cached: Cached CPPC energy-performance preference value * @policy: Cpufreq policy value * @cppc_cap1_cached Cached MSR_AMD_CPPC_CAP1 register value @@ -94,7 +93,6 @@ struct amd_cpudata { bool hw_prefcore; /* EPP feature related attributes*/ - s16 epp_policy; s16 epp_cached; u32 policy; u64 cppc_cap1_cached; From patchwork Mon Dec 9 18:52:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 848613 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2075.outbound.protection.outlook.com [40.107.236.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65BB518A6B2; Mon, 9 Dec 2024 18:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770400; cv=fail; b=uSg4kwR48kHcfj9U57exQhd/Vxuwe0Ty9XBqDnGBoTLwOFHioecJL6nsHXBZKVfIy8YoBkLJ9KL9PxEiom3eGaIYmF2tjcA5LY0bZ5Qo8wSGMPisex6F6rJmYzX6cXAOCL5AJuzA2PN+reOxAN3TpQnBuy8unAifpgKY/LfNQ+E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770400; c=relaxed/simple; bh=bIwEkB4RisuaBUId95SyAh/ypfFCch8mxVSwKmvYZ4g=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=r7sXAQt6ylfYDgxsChUDDNGA99BfqIKJ8j6oKe3itwj+aFdqoGUMjacy4BUYPUDeF2fhKXpqNv70AAmn/Hjk+YudekV/WZHjiQwSeyH7VnKkNcYWg0JgyJEPIZWHMKLRrzrQs6rVieKZS9BCxIEYlN7ZgdRwavOPJSbvniVyfFQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ap94FDAF; arc=fail smtp.client-ip=40.107.236.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ap94FDAF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LLlVCNvH5BsHVwZPLIq2kFbUyDIaYkEHWf6U4Vyyb/e2sUfXebBoQc2akR6sES/M2Jt6XGdeneRjyBcw/pvz6G6w1hFdF3rTlIW8QvFe/Sez/xgqi76MrPjg6VcpXrMrR9sexuIvVNCxJ2UUZOlLlRZRFmMKMVzLrTj8leTQeS0++SbwoQAbY/INl70VATvIA+NwDysZz/iVQZwAsunuIq+SyHVnpc2EZduHyKSIUpVDK+UqPjDr3WEgyToZGGLpe9lzQYKRrfC8oZOu2NQigS+yKFDKWi7/bMUilQEW7Iur3oe+pmx+EYr/ut+FqTnjwIIhRsOWr8Yzo/D0Rku9cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=58MdHhkW1tfwOPWWvmX8ZgK7hZsGT/j6kAdVv3nR6ZY=; b=Qe70Lkq1yiZ4LerfSlqE9rNJ9EUoaOTn0aSwnx1ykQ847gjEELkUgHUqeV/1rWiWjBIE8aTDNbmRYOl5cx1ag73C/lQLcafvQQBUr3E+QiFJQmQ4p5A0DxRZXyxcJGfHGTXjm84YiUgyBJq+vRVWLnnSJnytnrp/JEQ5r89wlE0xEEEi0KlduRWJBiwTs0rUK31QlpLrHiRVILLUcQiwddhHmt8s3hfbDQml4NXbLGgoGit7N1oj67SJ6X6jNwafmYYVLut50QOHC3JmSu7/sY+38QxcAc/s0f84iJSJyB9K1+zwe13L0il2y/5WX62S8lqgvOr76FkzVgpZ4GI4iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=58MdHhkW1tfwOPWWvmX8ZgK7hZsGT/j6kAdVv3nR6ZY=; b=ap94FDAFahSkU1grtgUdIq+BZ9bZBdjipctjNBvE86g++wf/+ZPVT2Iygf61p3kk2OAc17LOU+lqc+zIBwPso0R1G5J+FTMTamzrJAn/Q5/rIfj6Il/oaKiUq7/7B2cf6vNIVsyP7yiYbKIcoAEFuvRIYGl5zIbFSQoxsQlMLnY= Received: from CH5PR05CA0007.namprd05.prod.outlook.com (2603:10b6:610:1f0::12) by MN2PR12MB4206.namprd12.prod.outlook.com (2603:10b6:208:1d5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.18; Mon, 9 Dec 2024 18:53:14 +0000 Received: from CH1PEPF0000A34B.namprd04.prod.outlook.com (2603:10b6:610:1f0:cafe::94) by CH5PR05CA0007.outlook.office365.com (2603:10b6:610:1f0::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.9 via Frontend Transport; Mon, 9 Dec 2024 18:53:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A34B.mail.protection.outlook.com (10.167.244.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:14 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:11 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 06/15] cpufreq/amd-pstate: Use FIELD_PREP and FIELD_GET macros Date: Mon, 9 Dec 2024 12:52:39 -0600 Message-ID: <20241209185248.16301-7-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34B:EE_|MN2PR12MB4206:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f648dd5-64a8-4643-e50c-08dd1882bc80 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: iCyS5wPrWaG9+eOMWoD2cNntstkWO5xBElNMiCG0N40YUTbLfmiJpQzbr7Ysl81DTOijjpaxXExnwbpo9TyCR5dD7SyvKQ78GZ1WN4jpgRNt+7GpBnA9ZMvifneYW2ZNEc0nHe77WDqPjjrpsg8+2LFrVox+Bry3M0jG8cMUKsUwtP3y4vYxjn5IEF+gdnlHQByULnGrCIdrQlBvM7Gm0d2nBrK74ZNnsin4+DXr3e75apCaa79Y71WHt9eGgXOCbdcVdA5IUE3/q26dWFMwYbZoWELr14pJdE+Q7mtsijkYAqmR6lHpJJCZAB6O0V75gLempIfk12ut0FyoUlqKD9uIW52pciIE6FJCSdltDg3lKzZ3EK/Mi73qwdW32IqNodjehKFPs/kCWpWTB7W7Rn96wAmnZR8s8WBoRcAhHeJpdRQmd+7QRU1Jr4eiXs9keESPR+9nSw3YGp8pk/OMI+z5w/EzqArcm668g6sFKOInInJMAGWR5hEYKU8U6osxAnVIDdcHRbgIYkIUAVJx/MRMjDsPXOe0c2IoIjsnBdGKGF2+E4u1U5obUg2xkkMTD/nFZnG4ei0bfudv3gKTlNWplWe1RM6Rk8j+H1jxl1AzAE4ogevL50hXC2FgqHj4WgofKDpR1YOm3uP4n2HzqGCkyTT/E4R9c6/uciQDfi/pz6i/z5Ra3y8JjWT2UBQeJbq3EScuMgH+U6CkxaXH9AyiXywBWIKcKU18uVNe1En2ioFKwM8PRzb8D4jMQpaUyfXFMSTqP5lG731C/XoGQXNYhwjOqFOz/hWyzhpnchvgWMEwG15my7K6FFyD/t48Ja0KshWHEE9HqOQiwgiHClD4yXEV6kTmA5OdQXkZxb9R3F2qN1hvWrXxKUQPRqdvFlmKh9fJ0uWaTTsFKuHFCzB4ZUZDsqB9ufPNo2S38Pv3uJYsMybIXBp4JWQDoX4H1hJ6wjCAkqGFOG0noXrp4Ug0px5jAUQo+3bJaRvr6+FjE+Vsu6skQTCyru6uOU+AZGYq/tzYEwrB/Maw/Z5LUArC01gqrQs11HAsCfbbcV6PzWc0NIwUBR5Uo4f3OMXhiAvlCFUl8UJfZJhhsH5kNE6ft4why+pkqLDlvNQPY9N/bJI6b4DmYWkrtxZR0/FERxqLNGp7INFJTZSt0zx0Tl19eHWneYlmTg/j31TxMUJ/j2NVagMD4A02yxDFUgjMOvZZstgEik7QPfb+ZOwMfbtsm3NNk+RBf/DsWMYcB6Gms9I6nLDFnyNvolRmS85ZOV7ILBNULY1IEij9aY0gw++et39ZdHP5GsONCgG9gC//z1hEJPLJudO0BFU/7TPs5fogKqfjCTTScgcolYsssfm2xOIRfYp39iZBW1B1jcCb7Xaz8RfR/MO5cZY8efjQldQjLK+Zib42Yj92uVIC9KFIKx9IvRAvXv+V/Tnoq0QiOzJwvFs69UEWNJyO08rt X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:14.2919 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f648dd5-64a8-4643-e50c-08dd1882bc80 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4206 The FIELD_PREP and FIELD_GET macros improve readability and help to avoid shifting bugs. Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- v2: * Add a missing case to traces * Use AMD_CPPC instead of AMD_PSTATE --- drivers/cpufreq/amd-pstate.c | 51 ++++++++++++++++-------------------- 1 file changed, 23 insertions(+), 28 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index dd25e7e615984..0ed04316a8d80 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -22,6 +22,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include #include #include #include @@ -88,6 +89,11 @@ static bool cppc_enabled; static bool amd_pstate_prefcore = true; static struct quirk_entry *quirks; +#define AMD_CPPC_MAX_PERF_MASK GENMASK(7, 0) +#define AMD_CPPC_MIN_PERF_MASK GENMASK(15, 8) +#define AMD_CPPC_DES_PERF_MASK GENMASK(23, 16) +#define AMD_CPPC_EPP_PERF_MASK GENMASK(31, 24) + /* * AMD Energy Preference Performance (EPP) * The EPP is used in the CCLK DPM controller to drive @@ -182,7 +188,6 @@ static DEFINE_MUTEX(amd_pstate_driver_lock); static s16 msr_get_epp(struct amd_cpudata *cpudata, u64 cppc_req_cached) { - u64 epp; int ret; if (!cppc_req_cached) { @@ -192,9 +197,8 @@ static s16 msr_get_epp(struct amd_cpudata *cpudata, u64 cppc_req_cached) return ret; } } - epp = (cppc_req_cached >> 24) & 0xFF; - return (s16)epp; + return FIELD_GET(AMD_CPPC_EPP_PERF_MASK, cppc_req_cached); } DEFINE_STATIC_CALL(amd_pstate_get_epp, msr_get_epp); @@ -269,12 +273,11 @@ static inline void amd_pstate_update_perf(struct amd_cpudata *cpudata, static int msr_set_epp(struct amd_cpudata *cpudata, u32 epp) { - int ret; - u64 value = READ_ONCE(cpudata->cppc_req_cached); + int ret; - value &= ~GENMASK_ULL(31, 24); - value |= (u64)epp << 24; + value &= ~AMD_CPPC_EPP_PERF_MASK; + value |= FIELD_PREP(AMD_CPPC_EPP_PERF_MASK, epp); WRITE_ONCE(cpudata->cppc_req_cached, value); ret = wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, value); @@ -327,8 +330,8 @@ static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata, if (trace_amd_pstate_epp_perf_enabled()) { trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, epp, - AMD_CPPC_MIN_PERF(cpudata->cppc_req_cached), - AMD_CPPC_MAX_PERF(cpudata->cppc_req_cached), + FIELD_GET(AMD_CPPC_MIN_PERF_MASK, cpudata->cppc_req_cached), + FIELD_GET(AMD_CPPC_MAX_PERF_MASK, cpudata->cppc_req_cached), cpudata->boost_state); } @@ -542,18 +545,15 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, des_perf = 0; } - value &= ~AMD_CPPC_MIN_PERF(~0L); - value |= AMD_CPPC_MIN_PERF(min_perf); - - value &= ~AMD_CPPC_DES_PERF(~0L); - value |= AMD_CPPC_DES_PERF(des_perf); - /* limit the max perf when core performance boost feature is disabled */ if (!cpudata->boost_supported) max_perf = min_t(unsigned long, nominal_perf, max_perf); - value &= ~AMD_CPPC_MAX_PERF(~0L); - value |= AMD_CPPC_MAX_PERF(max_perf); + value &= ~(AMD_CPPC_MAX_PERF_MASK | AMD_CPPC_MIN_PERF_MASK | + AMD_CPPC_DES_PERF_MASK); + value |= FIELD_PREP(AMD_CPPC_MAX_PERF_MASK, max_perf); + value |= FIELD_PREP(AMD_CPPC_DES_PERF_MASK, des_perf); + value |= FIELD_PREP(AMD_CPPC_MIN_PERF_MASK, min_perf); if (trace_amd_pstate_perf_enabled() && amd_pstate_sample(cpudata)) { trace_amd_pstate_perf(min_perf, des_perf, max_perf, cpudata->freq, @@ -1573,16 +1573,11 @@ static int amd_pstate_epp_update_limit(struct cpufreq_policy *policy) if (cpudata->policy == CPUFREQ_POLICY_PERFORMANCE) min_perf = min(cpudata->nominal_perf, max_perf); - /* Initial min/max values for CPPC Performance Controls Register */ - value &= ~AMD_CPPC_MIN_PERF(~0L); - value |= AMD_CPPC_MIN_PERF(min_perf); - - value &= ~AMD_CPPC_MAX_PERF(~0L); - value |= AMD_CPPC_MAX_PERF(max_perf); - - /* CPPC EPP feature require to set zero to the desire perf bit */ - value &= ~AMD_CPPC_DES_PERF(~0L); - value |= AMD_CPPC_DES_PERF(0); + value &= ~(AMD_CPPC_MAX_PERF_MASK | AMD_CPPC_MIN_PERF_MASK | + AMD_CPPC_DES_PERF_MASK); + value |= FIELD_PREP(AMD_CPPC_MAX_PERF_MASK, max_perf); + value |= FIELD_PREP(AMD_CPPC_DES_PERF_MASK, 0); + value |= FIELD_PREP(AMD_CPPC_MIN_PERF_MASK, min_perf); /* Get BIOS pre-defined epp value */ epp = amd_pstate_get_epp(cpudata, value); @@ -1652,7 +1647,7 @@ static void amd_pstate_epp_reenable(struct amd_cpudata *cpudata) if (trace_amd_pstate_epp_perf_enabled()) { trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, cpudata->epp_cached, - AMD_CPPC_MIN_PERF(cpudata->cppc_req_cached), + FIELD_GET(AMD_CPPC_MIN_PERF_MASK, cpudata->cppc_req_cached), max_perf, cpudata->boost_state); } From patchwork Mon Dec 9 18:52:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 849044 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2070.outbound.protection.outlook.com [40.107.223.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62FA7189BB5; Mon, 9 Dec 2024 18:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770399; cv=fail; b=m9yOsBgx/ERArtFJS8NP8ApZ6776DDKAFcr/mqwP+AF/+1HRy/VBo1aHqeu8wfbVeozVJl5fqJlnhexHm3lPxVxaRZVMv4J02L6BKBXq19MphnNl4n+2TeTOkB32zKtUbkACBPCqQbycTDoJKu57o2c6zsTITNWb2hhWzsUsjkQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770399; c=relaxed/simple; bh=8rrIrjCDFbNsIF6xmI6OBAOMh30oWMQvH3qh+qoEXk8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lu9FDtYUekVUtAFO3kzmm1ceZNWsxL99BiHj2hHCZAsjJFfvITIQ2lQnfyELFzic+c3eShZ0lg3MSt/S22gr7pqysfmELHWW9mEHKhveMWUGznU4APFsv+MvP5M7XlzPi2qSD0gwefPLcSFDqXdKe6v2mrA+u0ZBSk2c1nY+zZU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=pBbJvxRI; arc=fail smtp.client-ip=40.107.223.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="pBbJvxRI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L9XKi85Ooww5SDTHWeU+79KQ/QtsCOgUHdiOVhdBo5G5b2DS900Rv9CEBNHi/GbEckrC0bwazkHQ93+oQgyFu9BpP1D/40k6hxJ9UDiYRxbJTLHAUmsUzHn11H90UFSNNGfNN+Gslx+1+FdiT47S7n49AWXWfW/J7tNFww1iQmCmOr6FtiJs3CHOrKbgcNTKB3pCNHHXTnpmRtaYyIeyfoz+OUpvYUb9lR/slCew6aOL64IvFVG+kUy3WZ6cX6RkAmuPu0jg8bRA2PgMoS5oV+I9hXuovuGnmMvnePV5XMqSNoBWF54SO/gdmdqE+cqM0jbTuQjUqxUMyfrzgFBoRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eroh5IEn3WgUrc3OYPL2JcIXey2+LfsFTzzdzmAMo+c=; b=P3BPSuN64X7dnnG6J/CVMq+V3wmfMfkp/vb89SnV6KmUgadahuH/W8rxJhfkHCLM3/gvKxAN+dP3u9GdXw0SRZ7Bbq2V+mx+hcgIfWIL8w3LPcJOQXXItIPzQoZ/gVUdCkQ36n5BK4lzh5jI5lpDXbWCMfXnLSVzV6ms8r+UAX2+XtXkanqYCFqeWNWo7KvARSog0/AyTmz9pLTlQ7ccOvOlJGEhVHXkkLmL7GwwALBeQh20Sz3JTCggYdcY5o045Bacw+fbbLqklfHb171/hjvXMRqxYjDGEJBuEEzb4K929O/wstVGh0igR0KiV7Zm6HhgkNZbrzkYta94FEcssQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eroh5IEn3WgUrc3OYPL2JcIXey2+LfsFTzzdzmAMo+c=; b=pBbJvxRIq/GfAgwsuvy2QaDnFhdgRXp69TUuDFkcsj0LodkC01oG0sbx/O1ODmi8Jxtyi2YSCDOnytcHvPBypxTmPZUbpdFUdz+b+5hNRSkCrH66UeMK4eZ+To5I/HsHo0LLAeerkmUzCQr6h4ZrThOgmHAmi2a7lAw1x7FLqLM= Received: from CH2PR19CA0028.namprd19.prod.outlook.com (2603:10b6:610:4d::38) by IA1PR12MB8465.namprd12.prod.outlook.com (2603:10b6:208:457::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.18; Mon, 9 Dec 2024 18:53:14 +0000 Received: from CH1PEPF0000A348.namprd04.prod.outlook.com (2603:10b6:610:4d:cafe::87) by CH2PR19CA0028.outlook.office365.com (2603:10b6:610:4d::38) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.10 via Frontend Transport; Mon, 9 Dec 2024 18:53:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A348.mail.protection.outlook.com (10.167.244.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:14 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:12 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 07/15] cpufreq/amd-pstate: Only update the cached value in msr_set_epp() on success Date: Mon, 9 Dec 2024 12:52:40 -0600 Message-ID: <20241209185248.16301-8-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A348:EE_|IA1PR12MB8465:EE_ X-MS-Office365-Filtering-Correlation-Id: 827873a5-6d8f-46ed-8059-08dd1882bcc0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|1800799024|376014; X-Microsoft-Antispam-Message-Info: dVG0vewoa1qE1UznaH9cq5mjy5MrWPb2S8jpWaKe+QFApfDk/DHvB/xZzjtVEZN203nTLBuLK+cCNmUhAEOpVfOVanuk73XpAQ+I4xQOwmZ4aPYGsldoXZ4qTLQ+CAszMrZX6/LWGtrkhzmAygQ+DMMi62xA7sSR+YO115ZuqYfmopgPagc2utXhqlU2JJ14JlqAUAaeLQjtHZFptBzQSODRWTvg1RjA4rOGc1Ojcns0+IuzveKDZQaIMzvgWIKiwFZL0RljUDQ3xJanKxXZL+5qMH6pdetFqwI6Fm3GnWmKISc4DJdCeSh4zlg3cTksk8HeMi3VEyU3Hwq5KzKJi9G73zStHqQ8dsvKFsEojx/YlV03QAsee8pZgR938KEEcNHfHrVl/irXJlY7ANlHmwM2P7A3NSFWE9WUHYHgiXWsdqLmYf1Bq8sig4ZUJIrVQL3cF4LIAW9RJSrWAET2MajJb2CULfOKJlM5fsONdMTPhsbBDVIa/Z41u7gu1JHioAU5+0A0iEGelu4GBO1/jbv6rzcVviuAKUk6DwyExj7URmukLFitnmpp8y1gprV/x+FnFZDOUk9G1msx92SkZUZBoC7N2eSOswrBBJ5233u/5n1wStGayR+fsIQHMas56CufQeSzd9atvy6xN+IaIWD0XcMlwFj2EddAIORA/GhJ8oKpng4keCbdjq7O6+ReSAviwRjRFib77usNv9K0H8Qi7vKYpkEc2LfxDjK4L4/sNdK6L+Np9dhP5eK8epHn/FObrbcbrO9biX+Kuq3cwW9Vo3V8jcKHVxdTd4KmcBzn5CWMJnxgOhSA4XMbF6a9tJuTfxwxs7KY1bUyWG4TfRAHcl86RMjvQGy+RWR07Xv8DS5YheRMcyLSEmOoevUdAMnuB0sUzDsJ4NkQ++vS1N5UErPk7JWZNa9Ja0BT3I+gUNbvI57yYDW6htv/nzJL6QTTur8GiN9kqraO+43SNhQ9CHbAbPm/pwI8YwEPztUWWhWQDG+A9WldMVwdVXUrPysQcorDbL1XBOIq58eFQ7FqhsFRV/IiN9w1Re8sIiHbEMH3E0HvGNKyz8SIZUGv5BkZRH1SXTsSZ0UqCvYDH4xsch5dxGYzsskNnZn4EZKYBRbG3o3OtwC6LrnXwEKN2IPFR79ACPuSxitkXKemdOPps/ihzrZIjrQsOR7eA+wirrk7MHCUdFXSmK0cR08waI76lvA8586gTD40ViXBZEDYN9ipaVvR181Ea0jSkbxqNK/FM9BKjrHeXZiTZgHH0NK6oWAYc/EdciVryxuheDrQC0UlJaB4qUQEjBxvYWjGVMoKmyHriav9bofFiaWgn/xTa4J1OUm8ATMxe2MrzEx1QNWrR36Kwij2bcqDXdkmeYGsus/uMRGj+YeUI2mcDyjJphW4GVii9mYIlGj1BrrIUr/mGsdzdBe1xjXQOFiuBw64MsmZpg4TEgnl/iSj X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:14.7244 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 827873a5-6d8f-46ed-8059-08dd1882bcc0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A348.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8465 If writing the MSR MSR_AMD_CPPC_REQ fails then the cached value in the amd_cpudata structure should not be updated. Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 0ed04316a8d80..263acce2f4b0c 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -278,11 +278,15 @@ static int msr_set_epp(struct amd_cpudata *cpudata, u32 epp) value &= ~AMD_CPPC_EPP_PERF_MASK; value |= FIELD_PREP(AMD_CPPC_EPP_PERF_MASK, epp); - WRITE_ONCE(cpudata->cppc_req_cached, value); ret = wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, value); - if (!ret) - cpudata->epp_cached = epp; + if (ret) { + pr_err("failed to set energy perf value (%d)\n", ret); + return ret; + } + + cpudata->epp_cached = epp; + WRITE_ONCE(cpudata->cppc_req_cached, value); return ret; } From patchwork Mon Dec 9 18:52:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 848610 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2045.outbound.protection.outlook.com [40.107.212.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B5AD1990BD; Mon, 9 Dec 2024 18:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770403; cv=fail; b=IQytblnLn5m91sxWJ2azxMa9jjB9P+fJd503URvNgJuUZz7U9jc87rCB62YV1u72+kprXTJtcPUMlzCwMMBYulcGclgCfKRDqpobRGFJ4kZs8zV0W4ThoCEdKaLW8/TJyWLCDgKIxYI8KJUkIO3h7xgyiTuQrmhHw3IXH9VZFUo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770403; c=relaxed/simple; bh=e/nZKuKpmaNRiIN279sc670kJiapvYTx0Nn8QYHyYVw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QJKjMYTcIlvH9g2mSgW7lhmy5dkdMLZCMh0qHSDSfHb3qRdLtRgpkdJepniemAWDGnlXVMNrQfWlpAUvSCO+mH7i0hfA1W8/a3EYoLFDffa5kbloT6IwCt7lYURy0fu/6t3Qf3XsFLtkdH+ILTe3S/2bs8k14RB6RI0Mlb/w5qY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ogb84ciJ; arc=fail smtp.client-ip=40.107.212.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ogb84ciJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QMJy/9nRsw+MYPh8MBGXqEwI+J1ZRPG4416uPsPXqX7G5P/arUp9U519p64JqR8UoqlHa4KogpnrLCxleLgkoOJRigNfjQWqn6b8fTV4gelA//BorfhaxZ6qttZI3U6yRKlB1NDjBdb4dHqdTKz6sjAhv68fVMg+3MVd+OvQzMPsQLEKUZ+6BWpUYtW/XBS/lT7KAfjnbxzaTAzxYKz0m+gxmantblb/Z+6oB6zmee4dBeV+vpCgl3wYNpJTmcpqGvRcrsPQjAhqRmYdR+lU3CW551ZV/4nu55Y8a5pLpRF2uc/xnaBjBGsqT4QsJdWgHOnhz2WH9UP9DOe2xj+KGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tdiBQkzENdfUo/VGDk/Uh8zIgQac56a333fBQCDwRRs=; b=GviEPgf0z2Ta3gNnMYALgYewycE6Ao83+frr7IAKgVyBWQvEVnWEroH0kBasAgDos5K1SiVKCiA1mbgwa3wpQMPRaTHq4/9H9WpL+/eLrrX5WMFbkkCF4d89b8jPMwpp96mO7apl9emj1U0iwJWpY4OxU6Z8ngr2ypWsK+HpHkz0/xpJfQEUksANIXHXPolNt4Gug3nlfr/1XMl1aAGXkHpweNXeZ7NPwT2pCr50M3hDkMI6CrXnhzPQmuBs7fcbD/ZMHxM39B3SG8rhMtXKqqGYq8Vxb5vLEr+aOsGFWTk78iH9M3kizu74mMAeFxn7/jR7SoJ7Sx7io63U4/97QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tdiBQkzENdfUo/VGDk/Uh8zIgQac56a333fBQCDwRRs=; b=ogb84ciJfhBNGl1XsJ4+UPO/JwTX77JIs8AujRHTZQ1DNxQHNTkOZXDxF0sExMl3rCTLeA6Y8yjPUP7i6irPN5Se+bqe1G9sPMC1iu2aWr/lHc2LucWO3KHcvxEEum6lljT5yLb5FfvVRzawIu8e8cXx3uCW8REXOoSNvYLcVag= Received: from CH5PR05CA0023.namprd05.prod.outlook.com (2603:10b6:610:1f0::25) by IA1PR12MB7589.namprd12.prod.outlook.com (2603:10b6:208:42b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.12; Mon, 9 Dec 2024 18:53:15 +0000 Received: from CH1PEPF0000A34B.namprd04.prod.outlook.com (2603:10b6:610:1f0:cafe::c9) by CH5PR05CA0023.outlook.office365.com (2603:10b6:610:1f0::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.9 via Frontend Transport; Mon, 9 Dec 2024 18:53:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A34B.mail.protection.outlook.com (10.167.244.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:14 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:12 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 08/15] cpufreq/amd-pstate: store all values in cpudata struct in khz Date: Mon, 9 Dec 2024 12:52:41 -0600 Message-ID: <20241209185248.16301-9-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34B:EE_|IA1PR12MB7589:EE_ X-MS-Office365-Filtering-Correlation-Id: 71f1a9c7-290c-438a-1c50-08dd1882bcd9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: 1UQzNHFCQS6osRtvTeg/kbCXFhUPfrfyI6ehqqJaXYPj0FzIB23mC9A56BExXBa8VyAnLj9JCaUv03oNqx4iPCTDZDyF9Z14FnEfMxtKpjdKN3LZyrQIIIxo56pDe07DuZ+QHK21LA/FP8PAk6f5csryx9Vv62aUmByiwmT3ZYT51xiDzY813Gj09EY2HAehF2yLsNiypkDh6STmPK77wPXRB8mnIQWt/sXCQBnTNc9/t5YL+HuqK88M/WslDYbDG1o4hqM8dGmPeD11N1SY28Bm2oNX/ZNet0BV2fm0XmDpGZqQ/Ug4dcvqPrPNkGpCGXxH4gHnQ3O4NoMn3QxO7jrZLLpxiEl/ks5q6mxzJf7yvtDBxk+V7faBHb1Y20WWGO+aryCh4loE3/pNbYmvCNJdNVhBblnh7cXjLgVp1q/Lp3fGc7wPMkAecPiB7gn2dzwvuPj6c7dwvExwAYVJ/fo4oTbNlMfJXtWnJozIo2tA0GKcxw9aJLo+Yfr/yXFxm1iVbix78x2JhQfmgyNCSKTEa3mKj/HbMAHeeeas4mMU8xYMdnrFICWlawm24qhaK4c4mjeOhX6I01fvVDicu4ox3VH37TJxt2LwJ/QMW3aCX0nyNSST9GeaCartE2PR2DbcrFAnvLKfTCxZRJkrhLrRKNhm+dutfUNU0TdKq1/IZo48FR6OWdtPjpMJYf5ORaJeaY9Tj3qzrgX3Ho3XMqDpXiljmv8lDzn+HCE7mr77yDOs33sHAdaIlVEFx8m1Et2u3iSV71GTyLGjC/TMaLXHk7e8i4jrrS7jjTD+Hyk2KaT5jdGjnn87q5mMg6qpWd8AwVNIoF8Ft2hxRyru1c74nKhqoV7tnlfQT30jebRhDtF1/CaizUZKX5NOcWxGRhJ2s/3oo2Xv7BwUMWxmeB4z5rgwC+KeQjKmAZUndVi0LDIrbZheU9rYF+s/gYXVk84A3E6C1BjIssY12xVhyW/sBS/Q90RSAY6mRzRskQfzy8O5fcs7dp0GeXR9dw7q9HTfy/drWAHmWQ0PM9l6yf+wvttf025cebK6RLHGBkTjn4hVbg7WMGJ62/51sM9A0Y6CtXwqBGlzJLtq56cX099Smlq2PG6CSUmtqrtoKPFc0C7Pha8ixAbRR0rUu6RzxqbcZZrRRwT+EotRm0o4yNv+ng1VAEY3YlktbIM9f1PAVDG6exN8x1Mli7tF9ybzLK7HUgRZtOoC6TTp5bOW+jsAGeeEpciQNEDtpw4xx7yL2GZAkdx3rKsJSJ8bzp7xfqzpVyHUsNkvPKKQEOw+EO9YD9rrPpmrY5WwD4Po3f9bbSDWNfrnAoG0sdIGm/0iN5cvrFgdVeaPMqZX0J5NdE7D/XHRc7tz+ly8+iYAg27BITuAJu2dDkLQd/aOtx4IYllkvrm7/DsJGV7uWph1uajHWkhuh4S3HDFL32tWre9G9rcK+YQWooVQAX88jJ7z X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:14.8701 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71f1a9c7-290c-438a-1c50-08dd1882bcd9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7589 Storing values in the cpudata structure in different units leads to confusion and hardcoded conversions elsewhere. After ratios are calculated store everything in khz for any future use. Adjust all relevant consumers for this change as well. Suggested-by: Dhananjay Ugwekar Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- v2: * Adjust checks to use nominal_freq for consistency --- drivers/cpufreq/amd-pstate-ut.c | 12 +++++------- drivers/cpufreq/amd-pstate.c | 28 ++++++++++++++-------------- 2 files changed, 19 insertions(+), 21 deletions(-) diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c index a261d7300951e..3a0a380c3590c 100644 --- a/drivers/cpufreq/amd-pstate-ut.c +++ b/drivers/cpufreq/amd-pstate-ut.c @@ -207,7 +207,6 @@ static void amd_pstate_ut_check_freq(u32 index) int cpu = 0; struct cpufreq_policy *policy = NULL; struct amd_cpudata *cpudata = NULL; - u32 nominal_freq_khz; for_each_possible_cpu(cpu) { policy = cpufreq_cpu_get(cpu); @@ -215,14 +214,13 @@ static void amd_pstate_ut_check_freq(u32 index) break; cpudata = policy->driver_data; - nominal_freq_khz = cpudata->nominal_freq*1000; - if (!((cpudata->max_freq >= nominal_freq_khz) && - (nominal_freq_khz > cpudata->lowest_nonlinear_freq) && + if (!((cpudata->max_freq >= cpudata->nominal_freq) && + (cpudata->nominal_freq > cpudata->lowest_nonlinear_freq) && (cpudata->lowest_nonlinear_freq > cpudata->min_freq) && (cpudata->min_freq > 0))) { amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL; pr_err("%s cpu%d max=%d >= nominal=%d > lowest_nonlinear=%d > min=%d > 0, the formula is incorrect!\n", - __func__, cpu, cpudata->max_freq, nominal_freq_khz, + __func__, cpu, cpudata->max_freq, cpudata->nominal_freq, cpudata->lowest_nonlinear_freq, cpudata->min_freq); goto skip_test; } @@ -236,13 +234,13 @@ static void amd_pstate_ut_check_freq(u32 index) if (cpudata->boost_supported) { if ((policy->max == cpudata->max_freq) || - (policy->max == nominal_freq_khz)) + (policy->max == cpudata->nominal_freq)) amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_PASS; else { amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL; pr_err("%s cpu%d policy_max=%d should be equal cpu_max=%d or cpu_nominal=%d !\n", __func__, cpu, policy->max, cpudata->max_freq, - nominal_freq_khz); + cpudata->nominal_freq); goto skip_test; } } else { diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 263acce2f4b0c..8a173359c2754 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -739,8 +739,8 @@ static int amd_pstate_cpu_boost_update(struct cpufreq_policy *policy, bool on) if (on) policy->cpuinfo.max_freq = max_freq; - else if (policy->cpuinfo.max_freq > nominal_freq * 1000) - policy->cpuinfo.max_freq = nominal_freq * 1000; + else if (policy->cpuinfo.max_freq > nominal_freq) + policy->cpuinfo.max_freq = nominal_freq; policy->max = policy->cpuinfo.max_freq; @@ -940,29 +940,29 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata) return ret; if (quirks && quirks->lowest_freq) - min_freq = quirks->lowest_freq * 1000; + min_freq = quirks->lowest_freq; else - min_freq = cppc_perf.lowest_freq * 1000; + min_freq = cppc_perf.lowest_freq; if (quirks && quirks->nominal_freq) - nominal_freq = quirks->nominal_freq ; + nominal_freq = quirks->nominal_freq; else nominal_freq = cppc_perf.nominal_freq; nominal_perf = READ_ONCE(cpudata->nominal_perf); boost_ratio = div_u64(cpudata->highest_perf << SCHED_CAPACITY_SHIFT, nominal_perf); - max_freq = (nominal_freq * boost_ratio >> SCHED_CAPACITY_SHIFT) * 1000; + max_freq = (nominal_freq * boost_ratio >> SCHED_CAPACITY_SHIFT); lowest_nonlinear_perf = READ_ONCE(cpudata->lowest_nonlinear_perf); lowest_nonlinear_ratio = div_u64(lowest_nonlinear_perf << SCHED_CAPACITY_SHIFT, nominal_perf); - lowest_nonlinear_freq = (nominal_freq * lowest_nonlinear_ratio >> SCHED_CAPACITY_SHIFT) * 1000; + lowest_nonlinear_freq = (nominal_freq * lowest_nonlinear_ratio >> SCHED_CAPACITY_SHIFT); - WRITE_ONCE(cpudata->min_freq, min_freq); - WRITE_ONCE(cpudata->lowest_nonlinear_freq, lowest_nonlinear_freq); - WRITE_ONCE(cpudata->nominal_freq, nominal_freq); - WRITE_ONCE(cpudata->max_freq, max_freq); + WRITE_ONCE(cpudata->min_freq, min_freq * 1000); + WRITE_ONCE(cpudata->lowest_nonlinear_freq, lowest_nonlinear_freq * 1000); + WRITE_ONCE(cpudata->nominal_freq, nominal_freq * 1000); + WRITE_ONCE(cpudata->max_freq, max_freq * 1000); /** * Below values need to be initialized correctly, otherwise driver will fail to load @@ -972,13 +972,13 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata) */ if (min_freq <= 0 || max_freq <= 0 || nominal_freq <= 0 || min_freq > max_freq) { pr_err("min_freq(%d) or max_freq(%d) or nominal_freq(%d) value is incorrect\n", - min_freq, max_freq, nominal_freq * 1000); + min_freq, max_freq, nominal_freq); return -EINVAL; } - if (lowest_nonlinear_freq <= min_freq || lowest_nonlinear_freq > nominal_freq * 1000) { + if (lowest_nonlinear_freq <= min_freq || lowest_nonlinear_freq > nominal_freq) { pr_err("lowest_nonlinear_freq(%d) value is out of range [min_freq(%d), nominal_freq(%d)]\n", - lowest_nonlinear_freq, min_freq, nominal_freq * 1000); + lowest_nonlinear_freq, min_freq, nominal_freq); return -EINVAL; } From patchwork Mon Dec 9 18:52:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 848612 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2050.outbound.protection.outlook.com [40.107.243.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 220A31946DA; Mon, 9 Dec 2024 18:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770400; cv=fail; b=clFPrNt0pQDT+E+kgxCZZif51IvXjP5v5mMMR6fCszQhSfMi5QakTC0Q4iugv1ydIoGB3JtreN/3Ibg1f6KSL61CpKDKQDMAhg8xgnYcRljH2jshq5CE3l6EOpRjr5yCVjnWZ6IFUkdlAlvrsQomRnluYv0gk/Y4Cx0+XdptE34= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770400; c=relaxed/simple; bh=cMivOQWZogQBB05LU5VTBgcnzLFViRdZ6a1taO7j+7w=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tzXrDB62S2VHM3UtFg7f3e/VSh7DY9GaOpT8VWTpRSY7+6fzIDW1MvS1cXeMeqBSjubTNOr6hMYdS0L/vss8ooujNkbuiXFYe6O3lvGttW4LjekOaKvoUGjEE3RmnCy5OwEYqV203EycARa+JtOkHO92tfqd1vZiLDVLBaZRxoQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=liLhrDH5; arc=fail smtp.client-ip=40.107.243.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="liLhrDH5" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bLDcVnlLD/YqjA2YRGVNfkCMo9F8mwVEJnrlSaoGa9FRNxEIuuC3dqZXxVvG68y+/MZKxKbY1xhLuadeyFeev0SE3h6f7TVQOoobyi8rDgB/Tr65dqmHfFqejV1ADAhpuFT0WkMJ0ZUO32TCNIakFqhUCUVqB7eCivf3MAKzd/+uxwK9w/OdPXj4VRZ8qeoipnzGjmWaVes1o14fTzEVg/iztmTi6Z16M29k3XZRuNCMErAVok89/P0J6wCJ1hmkCDaHPJiZYw7lHgrWMRewQwMZx1JBpApVZfHOihKXZpqu5/N4bCfonf0SWT3HB97IY+41G45Qv+4pOkrXGkoAMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jCd4s0IPHxRfilvupvmiDEaJQouGx2yoyCLixWtybzk=; b=IF2yDrha8Mohvyy3mQn8/KZJjsVbLl/qdQ2NMiEfBs6GjcsUWtTXlDig4y41MbtL/2YeehRJ4zdAtiYQ+GsgCBer3bHdhXFtk8E4N3/qHD59rgtzEoDz+SuwGSQKaYOubIffwuZaOppMZoYVAvr6rd+k/frUuOkXf4G/xcXNa8gFBg27xPE1PajhYTj3Xw5of+cepWXlMOKxaEgrPGYmtApNiFlt+hM9nhaa7wk4tWU2jBP22K70G8NwBRicrdEaT50mJGvwHB4IhoUTUDmAkWkLbK3IJ9W077n/y1WEVxnp5b8cZDHRLspD8Hy0m/ZkXdpS8CCjwYVJtsXIG2G+0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jCd4s0IPHxRfilvupvmiDEaJQouGx2yoyCLixWtybzk=; b=liLhrDH5zT80nhYda7pdMzt2o/eG41e2JcE5Rn095PpATxUrM/XvQDsyvQR7AQHAJVUjRmf4EVWcyO6A6cb4adH+nPyZdni82IPsAZcOSXX6owfzgz1vnpvYPZ0Q6djHZG/UXjtXvm5utrpik8iPYJz4Kt5IgwE4sU/s0eIp5MY= Received: from CH2PR19CA0018.namprd19.prod.outlook.com (2603:10b6:610:4d::28) by PH7PR12MB6834.namprd12.prod.outlook.com (2603:10b6:510:1b4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.11; Mon, 9 Dec 2024 18:53:15 +0000 Received: from CH1PEPF0000A348.namprd04.prod.outlook.com (2603:10b6:610:4d:cafe::5a) by CH2PR19CA0018.outlook.office365.com (2603:10b6:610:4d::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.13 via Frontend Transport; Mon, 9 Dec 2024 18:53:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A348.mail.protection.outlook.com (10.167.244.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:15 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:13 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 09/15] cpufreq/amd-pstate: Change amd_pstate_update_perf() to return an int Date: Mon, 9 Dec 2024 12:52:42 -0600 Message-ID: <20241209185248.16301-10-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A348:EE_|PH7PR12MB6834:EE_ X-MS-Office365-Filtering-Correlation-Id: 44178ff0-4bf6-4461-3fa7-08dd1882bd41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: ZoINt0oj0V324SUScG2jKFU05BfROoHBYwtMx4K9aibW2q/aZApVCxuu38tVrpOQwXwg5x0GY3f+FjIUp/mmsGk8u5gY5DoingiQ4jYQOQLgZWGIjDlcEzeDg05/8YIiN2ByQslLetjBFWfOlejSvB6n4NRgYkQY0fIArO4+wk09SyNRgriWwPoqDx5UkatqGEgGRawf7MsaE7HbijY6g3LttIAC/jp/dh5tEbrqE86fytrgymrTBjd0J9rgpEQ9jqEfAz6JAL+5n97RRt4TeVD205JN5/uPHQoH80aXpo8x+eJpS4/GPywCpS2gZ9QnYbrsdKHfE9WBcRozz92h3yM6lEwcME8BcSViDw16I8F0MtPTuPDm3Nm4NRqUgB8RgX41xNUv9jiRuyk1QMDZQsVpas2HAbR5ot5jBASOXRy0GZMPt9nd7iSAr9vb8XBTUXsldONM8zvFhnzG7I3eF40iFhMznss0+ceKeRrTnz4Suk+jgjDq4EXdt3RfOT3xIS45Q9GMXh1w4okH52mdplm4H1YSp3S6KXl2mb6MQoHUs4xwMP9vhEUxtRmQnBrqptsJy1M8vBfDhFv+Od4EEUEuLBVEO4H6bon8NBTjViGyDMbdX67ImyKd+A1WvGxU53l08jTW5BGqFG6b+F+3eQWywTGqg/Dz4wO3jhQBCxBjdO0iAx2j/w/xjVma2LkB/C29GW5JJwOXNoHZVfeUSLARKcr8Y3xVPchdzSi/JbIxyEkW2CA6RVo8kWYGUlQzCeKAeBaXKfnGg1CpB1I3MeKFFdxsikgF0vyQ4L4r1ol2fPOzZ80acB226oOOfQymL0rTp//YE8iUMIZxLI7HzqVxcHDZyewZ4ozwiesh1ylTbImO4tsAi5DwR/xgVlANoHhLwunvo/8yiVlRE7DnP6OE0GMVGvR+7GPdCFqVuqJRZFuiROcU8j8mgTndAKkUzGaRtVnjecyn1wJcMl8KffIedPhnGb9RDFVTUR8OiEfAwRBbr5WOrB60tMENrsQABIyhbw1GnGJLm3EYTCn4nxNmaTlIktBTo+Iczkiv/Xmnmm/gikFNhzipk6WDNZJ9wodAuBtpHwUQbwAFv7lZGw4btNhfqL4LaSL1ARorY4hW3X4dD7BKPt699o5YeWVv2MSQU3ggfEOPPO92fSEZ78+AbIN5XOv3/k2QTkasf3RubBkDlI4IInLHJt0bxATYbvwWgk/kc/DbaKGn7aqdqn/9H9nFf+HbvXf/ixOhDzhFdtPP04p77NBbdqt8SlVwlk4SiHprGTChNTOAHvJA2sbOvgKSal4PREYZip9Ukh5tHYRbzyt9WJ0T0phwmRYUb8UzgRfmu+XfdNEf8YBR0clwBrXvSFDNZADuOP6fd4fjhxrI/JGmGNlFSi67nOJtYXeGOQegWwDA6RDaGVUwGInFQVFSYfENbB4UNiJuZIvTexh/JesIFx/A+rcKSkSn X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:15.5525 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 44178ff0-4bf6-4461-3fa7-08dd1882bd41 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A348.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6834 As msr_update_perf() calls an MSR it's possible that it fails. Pass this return code up to the caller. Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 8a173359c2754..3a3df67c096d5 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -251,24 +251,26 @@ static int amd_pstate_get_energy_pref_index(struct amd_cpudata *cpudata) return index; } -static void msr_update_perf(struct amd_cpudata *cpudata, u32 min_perf, +static int msr_update_perf(struct amd_cpudata *cpudata, u32 min_perf, u32 des_perf, u32 max_perf, bool fast_switch) { - if (fast_switch) + if (fast_switch) { wrmsrl(MSR_AMD_CPPC_REQ, READ_ONCE(cpudata->cppc_req_cached)); - else - wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, - READ_ONCE(cpudata->cppc_req_cached)); + return 0; + } + + return wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, + READ_ONCE(cpudata->cppc_req_cached)); } DEFINE_STATIC_CALL(amd_pstate_update_perf, msr_update_perf); -static inline void amd_pstate_update_perf(struct amd_cpudata *cpudata, +static inline int amd_pstate_update_perf(struct amd_cpudata *cpudata, u32 min_perf, u32 des_perf, u32 max_perf, bool fast_switch) { - static_call(amd_pstate_update_perf)(cpudata, min_perf, des_perf, - max_perf, fast_switch); + return static_call(amd_pstate_update_perf)(cpudata, min_perf, des_perf, + max_perf, fast_switch); } static int msr_set_epp(struct amd_cpudata *cpudata, u32 epp) @@ -480,7 +482,7 @@ static inline int amd_pstate_init_perf(struct amd_cpudata *cpudata) return static_call(amd_pstate_init_perf)(cpudata); } -static void shmem_update_perf(struct amd_cpudata *cpudata, +static int shmem_update_perf(struct amd_cpudata *cpudata, u32 min_perf, u32 des_perf, u32 max_perf, bool fast_switch) { @@ -490,7 +492,7 @@ static void shmem_update_perf(struct amd_cpudata *cpudata, perf_ctrls.min_perf = min_perf; perf_ctrls.desired_perf = des_perf; - cppc_set_perf(cpudata->cpu, &perf_ctrls); + return cppc_set_perf(cpudata->cpu, &perf_ctrls); } static inline bool amd_pstate_sample(struct amd_cpudata *cpudata) From patchwork Mon Dec 9 18:52:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 849042 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2041.outbound.protection.outlook.com [40.107.223.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05D52196C7C; Mon, 9 Dec 2024 18:53:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770401; cv=fail; b=ujImfTSgn/tePv4pF7FHyAAJxmD+DbQdrwpyHDl8E5QMir5bgx2rOD4rdgL/AHsVfp2A0Jt+jY1BombKt1O6lJdJlwOsoFnbi51l6brhcOF5k1wqrhlfc2LbNzo61No/YdwZdWAjb9kQJfr2V3/8Am0dqJ8i3BBRwQ/vj8FryPc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770401; c=relaxed/simple; bh=AwZXjv+db6RTp0lU5VLcJiWHv2AG9kP+T4CZKHiGgRM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bDwHmY1pFCL3bw9JldXNjjfT1V5RbvY826sw5nNxpN6bpw2xk/FRxLEn59lgoaW2fMrlhJZd4lUKdnJclba8vQ4crao4p0T5mbvlz87BH+2yJdtPvdIY4LQeiq0zDu1hvZnIGFBtr79tpu64etLoBRuY+fXuxaVuNGyuZLRiLWY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=nIDbaPsG; arc=fail smtp.client-ip=40.107.223.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="nIDbaPsG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FZAUTssTvV+gFx6yx/SFSUWPSnCDeyAyc/3MTEwy/e0uSVGiuZT/Ix8NfAK3BMRrtCV6f/AkfaQLT+dhQkO02a8hv8fhGK6J9w3k99xkJLzxWmAm99OthmskZc0QAD9knNMIOSSV0odMo2uqwuntbgPXGIHq2pVBMnA81LrXCNAXWkAJ5IMS/xwSN986VI7GAGIFYlBMwP9UVDTenZK7tCnhZBa/2ke/NGmSfOcVsTncMrNnYa0/1kA1MMa5rFa+/XTWt8vWOMl2VYsJpm0YmkX2b9t3sSXduvKA4E9/8/cPwCaPVmoubmRrnZZY5iLCDcaDoi8GTtxsJFxjnCPtlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N1Rs8gVhH+rT2+4S+fdyTLEdm4k86DuUXXfVda7IC34=; b=k4qunucMwWHr+KcJ4IcaJ5fXGUkZVXCo20U4N6/aRWvR+qobgwBBvtxCKQc0GCm/r+Vp/36C90XOKuqgLzozl0SJtm3YvlD+2PouKEIHOjixBYMnu9nHZUPlEwIy5Ovz3QPMUQFQwjm7QtCghwborC3Eki/xZUptstfJk28z4etaJBwKYsh78Z8XSfsCY6wT2JH3npNGoO4HKrObUlWfHIwA7qznT3jeYMfrWZzqNuE42Ard0kQ7RxCCZWeR0vFo3qzsTc1EW5Ix7XJHCXNTR8ZaIGRK+sefwg8gVUTieR1ap6aoP9FHktKo0N4JyggTNleo9rhZ2OMbRAUqZ/ACaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N1Rs8gVhH+rT2+4S+fdyTLEdm4k86DuUXXfVda7IC34=; b=nIDbaPsGimZTwv1oGRtSDGPGaAsvR4xvtkPDX8TCQ/rXHiyaoOWvEkjPW0OSlA73EwiRR1gDi5NKmEkLha2/jcO53pdCS9haGHHs6UMRDVpDpyaYOHgV7ehYketI60HhXEQ7DsDJo3bljNJbMBqfRD3RfLs6mKial8HJYwlWMHs= Received: from CH5PR05CA0018.namprd05.prod.outlook.com (2603:10b6:610:1f0::28) by CH3PR12MB7522.namprd12.prod.outlook.com (2603:10b6:610:142::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.12; Mon, 9 Dec 2024 18:53:15 +0000 Received: from CH1PEPF0000A34B.namprd04.prod.outlook.com (2603:10b6:610:1f0:cafe::fc) by CH5PR05CA0018.outlook.office365.com (2603:10b6:610:1f0::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.11 via Frontend Transport; Mon, 9 Dec 2024 18:53:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A34B.mail.protection.outlook.com (10.167.244.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:15 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:13 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 10/15] cpufreq/amd-pstate: Move limit updating code Date: Mon, 9 Dec 2024 12:52:43 -0600 Message-ID: <20241209185248.16301-11-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34B:EE_|CH3PR12MB7522:EE_ X-MS-Office365-Filtering-Correlation-Id: e20f7c69-14d3-4c2d-2af2-08dd1882bd49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: lX7pbdOHck4DZcPpjD2mES6ftIZI1OSIxCad7vB9HxYrOYXnqsp/DQq8Ia7g0/bsFN+5BBTDtFnKKbkozaIY4Hqxspm6YGW2Q5PPtemWN0at1gEoCc36OugN8UN/+x2xby3ifRD8gul5Q2fKd+sijWBjo/tAzmsEW3hlgnNoeKifQ7YgCKYhFbTwq+wlL70F60JxsE4zrj61k2tKhVOXP4KW3HzJ6hhd676Dzbft38QunOyijTpYoQ7TswrBwPlwuoj9JCnnYr9LowfwfaadzA1iJACUzuZxBsNrhhJghLSw4Kw403DPx/VINc1guAlA/rkuDrUgX9hCPQZLXFK9QlLDqX5xsZKX2Ugcyv+l99EGZ1XnHoS+inSioq7g6pF1d3iv0GR6+WkDzhdLM2CZG53wfVDSk2NteSWe+UsSs600mGadx5lXlsXgOJCxF9vLMXkxsKZLKkx/gDOWw9jFsxgtrGAiM2cbL6+hg8OPXWh1f3WmWLM0yQgzrMQtp+0jNL+OyNQDF9ZWwNmvn7/foqxq8zfJJCRgjzza1nuIw9PkCu0di2B25MFG2VU73/+SKm7s+aj/jITES4p2UfapRuO3OgSec2TWo9mjDmNJnrjii9B6HDpJbp4u94psWBIrqFLOMiIAxgVzehF+eI/HvvfQ2tlbOhCLGxMpUZ6gXhLw72xaE59acKH4WvJ+wAv0TTeozUkxrqL1E2mPx+7gTMy4MaF8EUUOYU7nPjBv1vvWnWixJCb9VFdTQWkSjyIyiX51eleI1HiSMaqhxXQFOL99sleb/DVJUluiT9tLw7ffonknV5rzX+JU5E3EcFQl2MUmpSpz0X3vvODO2ZH63jCbC3Ieg8iA0cALxfj6N7r9Kl6OTNha6dj4vAEz16qGVlextSLZ1QiUN7u4Jx+wyFU4s+T3Cj7yeAsb0Hcs2n21vK971BZqtnIM3Md6PDiB0doMlnFbKokGF2JTCmAvZNQrpAxJDl/Iaf5ZD/e0maIuc+VKOiW+GqNQqTuHijLF/op58ndZ+sP9A1v5POdlTn5ZRhv7QPemicAIHBLg8hET8eW47hPhDXHqTeDgS1jKxW4Qx5iMrQagwWsQ+eX/oACQADdZzOvBgWJAkUMFnYvZGnaJWnT5XA6Cnv6hBVHVpsIGp8xmRLstF3Kkj/MgtCICHWtEwI07PdubRv9aTJSt3FHSgWPlSsT/zp1N91cHWcJle3OtsgRB8lxvOhUINAlM0jQJ8FKFZXOYqKsMRZm3Ln7A60jPK+33MQ1ZuUTmf1Vcn2GQOoA1q5TdC5HogB7MuFUwcespAIGf9MWPeHOaD75FMs3yoSB2DhMgNfj8pY01n/sfM/vyCSvtq2nsx6uUjFB9+6Ef7JVFuXwjRwFCJijH9fDoik9ra4weJEWosyRl92pATXTG2NHSZT2xJCPn+PfehX6Qu6jZhaICPgvr0HFc/irUeXuJGWqVi9z+ X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:15.6201 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e20f7c69-14d3-4c2d-2af2-08dd1882bd49 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7522 The limit updating code in amd_pstate_epp_update_limit() should not only apply to EPP updates. Move it to amd_pstate_update_min_max_limit() so other callers can benefit as well. With this move it's not necessary to have clamp_t calls anymore because the verify callback is called when setting limits. Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- v2: * Drop lowest_perf variable --- drivers/cpufreq/amd-pstate.c | 28 +++++----------------------- 1 file changed, 5 insertions(+), 23 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 3a3df67c096d5..dc3c45b6f5103 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -537,10 +537,6 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, u32 nominal_perf = READ_ONCE(cpudata->nominal_perf); u64 value = prev; - min_perf = clamp_t(unsigned long, min_perf, cpudata->min_limit_perf, - cpudata->max_limit_perf); - max_perf = clamp_t(unsigned long, max_perf, cpudata->min_limit_perf, - cpudata->max_limit_perf); des_perf = clamp_t(unsigned long, des_perf, min_perf, max_perf); max_freq = READ_ONCE(cpudata->max_limit_freq); @@ -607,7 +603,7 @@ static int amd_pstate_verify(struct cpufreq_policy_data *policy_data) static int amd_pstate_update_min_max_limit(struct cpufreq_policy *policy) { - u32 max_limit_perf, min_limit_perf, lowest_perf, max_perf, max_freq; + u32 max_limit_perf, min_limit_perf, max_perf, max_freq; struct amd_cpudata *cpudata = policy->driver_data; max_perf = READ_ONCE(cpudata->highest_perf); @@ -615,12 +611,8 @@ static int amd_pstate_update_min_max_limit(struct cpufreq_policy *policy) max_limit_perf = div_u64(policy->max * max_perf, max_freq); min_limit_perf = div_u64(policy->min * max_perf, max_freq); - lowest_perf = READ_ONCE(cpudata->lowest_perf); - if (min_limit_perf < lowest_perf) - min_limit_perf = lowest_perf; - - if (max_limit_perf < min_limit_perf) - max_limit_perf = min_limit_perf; + if (cpudata->policy == CPUFREQ_POLICY_PERFORMANCE) + min_limit_perf = min(cpudata->nominal_perf, max_limit_perf); WRITE_ONCE(cpudata->max_limit_perf, max_limit_perf); WRITE_ONCE(cpudata->min_limit_perf, min_limit_perf); @@ -1562,28 +1554,18 @@ static void amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) static int amd_pstate_epp_update_limit(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata = policy->driver_data; - u32 max_perf, min_perf; u64 value; s16 epp; - max_perf = READ_ONCE(cpudata->highest_perf); - min_perf = READ_ONCE(cpudata->lowest_perf); amd_pstate_update_min_max_limit(policy); - max_perf = clamp_t(unsigned long, max_perf, cpudata->min_limit_perf, - cpudata->max_limit_perf); - min_perf = clamp_t(unsigned long, min_perf, cpudata->min_limit_perf, - cpudata->max_limit_perf); value = READ_ONCE(cpudata->cppc_req_cached); - if (cpudata->policy == CPUFREQ_POLICY_PERFORMANCE) - min_perf = min(cpudata->nominal_perf, max_perf); - value &= ~(AMD_CPPC_MAX_PERF_MASK | AMD_CPPC_MIN_PERF_MASK | AMD_CPPC_DES_PERF_MASK); - value |= FIELD_PREP(AMD_CPPC_MAX_PERF_MASK, max_perf); + value |= FIELD_PREP(AMD_CPPC_MAX_PERF_MASK, cpudata->max_limit_perf); value |= FIELD_PREP(AMD_CPPC_DES_PERF_MASK, 0); - value |= FIELD_PREP(AMD_CPPC_MIN_PERF_MASK, min_perf); + value |= FIELD_PREP(AMD_CPPC_MIN_PERF_MASK, cpudata->min_limit_perf); /* Get BIOS pre-defined epp value */ epp = amd_pstate_get_epp(cpudata, value); From patchwork Mon Dec 9 18:52:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 848609 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2071.outbound.protection.outlook.com [40.107.96.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DD0A199EA3; Mon, 9 Dec 2024 18:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.96.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770405; cv=fail; b=YzEJPhRD6liXO8kHqhgnqFVHQjm/4LfEFVZ5iUro3YH3bQOpoX75A2EfMgzaCuPfVsHojC+GDJeaAfDAR9jCzmvNwZvkAh9FmQTmoU1DBYOiP/WNKPgGCRBoYQ8O36PK9+K0muKwNILa5ZE8xoBZmftCKt021UZHa1WN1hKy8PM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770405; c=relaxed/simple; bh=/TVV2dHV8Z7jzSu9v2b0756gAyUbIYlrUEKmtiqAsLU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cC9ALOihVpuPESVJsKDrKrBUJ1Tj0aC50pGmUCm8Dmh6mZo3LbaiTyuCr3TLBSeLq2Ui2EKQMJiNreUiVUFMzpwTEb0kWfKetpp4216L06wXO46+NA4RHXvr/jLhY/Bf/NqmkJI/ghZWhS226xdvK/1PLqK1yyYgYSoMqQ2BIGM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=AcK5so6i; arc=fail smtp.client-ip=40.107.96.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="AcK5so6i" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V9+T7TLb2Myf7KbjH8l3eRkdDYZ3ni6dFzOf7MaHxRGtVwQhBdwvHb19GNJv6gjrGvWmjirblkTb6gp/2GfNYVio2V0EzXoodJiARu4XhjC/seGNKjqc7RMqJ46Qp7agwA+oX5zMfUqKNogTTOtXHVY3NpYEYPe7NvFmlYalmF7/iyH1pT3EB2gvV0EPZpxN9I9Nq2q1YibytYkSMmTeUC71UhFB02516ikZoFqFxsDMczxLdefLNOAS95E//5c5z7Q53pKi9I3R6dVxWubAiwIcELodyPVmmTC0I0FbtsKEWaKI40xXm9tw2TQuWbTtBvC+zXaT/4rUMGRu44XTAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1pESds6HcfdNRNMtn6/Xfc/5VuKjuNDCl91K4Vnf4tk=; b=v4MC0bM05fvTavz10++xcLBsfJx0GVL+13jR/5xNpdH6YS0+Q31f3Kq1pldnHghP3kTLCvm7/EmfzFy4wwhLYP1s1XJXy36xoTxyeCjvibUDqansqNQjQwoowD7q9Z2FGQ+cmMSJjhCmAFcuH8TtF6psyDMQx26ATRAz1F+0qrZ5lNRBXPPfD7uePDPamnfZc8oTuccf4beJQ9AuwOPJybP0aDXMfG7jM2LXG4u9QAlsM/Kr0Gt5Q0BNCnpehMMIhkkllWn6dEDuR17QULenbfameYW40eGepm6uMRWMJsrVWoODPFDUFIcXDZJOyrOOPb24+nSLKrp7jTcUsIxt8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1pESds6HcfdNRNMtn6/Xfc/5VuKjuNDCl91K4Vnf4tk=; b=AcK5so6iKUokbjjcKmalwXRJPfng56q03VHs4mQUHZxunbPOmR7OiumBcIjt7BRyS48KkShzEKglS+PHUGsvZK95QY5YLQYeOqDqygUrx6vhcjJ7qFNEuRr5YOHMHVv11XsbXk5FXapvZqMDKEhPWcyVPskHdS9DuslF3mYjOH0= Received: from CH5PR05CA0006.namprd05.prod.outlook.com (2603:10b6:610:1f0::11) by DS0PR12MB8815.namprd12.prod.outlook.com (2603:10b6:8:14f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.11; Mon, 9 Dec 2024 18:53:16 +0000 Received: from CH1PEPF0000A34B.namprd04.prod.outlook.com (2603:10b6:610:1f0:cafe::c2) by CH5PR05CA0006.outlook.office365.com (2603:10b6:610:1f0::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.11 via Frontend Transport; Mon, 9 Dec 2024 18:53:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A34B.mail.protection.outlook.com (10.167.244.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:15 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:14 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 11/15] cpufreq/amd-pstate: Cache EPP value and use that everywhere Date: Mon, 9 Dec 2024 12:52:44 -0600 Message-ID: <20241209185248.16301-12-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34B:EE_|DS0PR12MB8815:EE_ X-MS-Office365-Filtering-Correlation-Id: daa8ec07-c63d-41f3-00e7-08dd1882bd80 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: GKZyS2mu6Q1dkZmGeoSWH+Wg0RpWnqK8jY+8eP+XuWNKzpTdUmPPwUVGdJQCDiXlJpfB69oh3CWtoZGBhfBYZ0X+nstG2T+xjwmmqlE+dBd8OAEbXuHh+sAkOqSCsf8eZxmmzeDjKctx8CkRBO0W/Sq5fl6flFh3rtTyq3YXUIi8Eg02a5xYegZxJ8E4nnrLKNrwjY1g0mJFyPnffmQDOOxZGYVJp9bzqLT2teb0TmMiUQd6935RRTLlE8YEpMXrrhvs0RB+4Ek5kZWFryXPVBY6ytYtBAKO79N028n4QX5BBh7Q3MNKWAOtsYizzJzHKZeXK4xLYOpE5X7y+6Z0jYtRTixsPiLvfuA7jqDgExCLt/PU/3XLnns8fSEhAKezX6tzs5B30KqCHBhAa7v8OaC6oMyQeNtpP5ooNL5jzu4F+l3iWcxTZc7iyOi84JRgLS6eIniHL3kRciOMn/nyrE3WlZ+pk0S4fohdJxIrgEuIV01cHCBRb2zBb2jcv5u4XklcjUGKBAGqW9KIjXySaS+b77UOpndcnKDAW3mNTjSHNvqfY+TzfJLR1m+wOd9DyIV9ii+4d8dEu+S0Ja4VbTBbY5wVBl/t/exrnTJ/AcGVzt44tStU+669u5vflUhp2YuYbv1wpaloCvwsnQbMe77SS4aigi6/wx2LfJ2CaPIs+ZOCFRhnQbL6cDPKV2/XhIaU4O4Y0ZaurQvePFr5P5o9mqRGqQuvtjG/Fur0lsGt4HoF7PcYFLINVxkL9c+VoUX7salWiPEHuvfg4AZGK2Q0WtKFKD8iQn/XPm6mZ/FTxii4WZZZHIdY1Lz7kTswsPPMn3NgDGHrmsTboOuc7qzgF4Lmy9yB8r/eb0vVNwK5tMaolSGfux6L6lXqSRKqmp28znuWpeZUMqE2pZ6gpDh7Uxxy/kAmKwl+tf4XtjQ8COh98x/ru0NCqbY//bpVUfQWbBt5tptDJSqh9xJ8SCTxhSXI3IPCZOBulfbkB9bMPt1zVEpKL0zeBeLhBnz7BJOqn3UrTODzEte54lBSOKkb0JRnh2b8W5jEJ8FHZmavqwMJ4TxgnYo3siC8n5+I/q4uGykvgR+JvQnoPtvFIEJY938Y+iJAF2/jPgKIE4xrSmvHIG6UQdLw59SQeecxYLh3Q/w8MlQclIpB6qvpM6lh8eYop41J82hCHsM4zjnNGOddG+YQ0C1KbxMJ5d5qMyy2BR895jtzMh9CM+zQF61Z7tkSv486DDNJB0q6ju5Dh3guO1y8TMSaRFjRLR1CxiuUMDO7EMeoLeka2rVLIoZ2rDpIb3fBZ7I0KkEZivHYDaiHILyN06aeo4s/F3CquwgB3BDe/FL0iSnFHZ7DG8y00l8I/nkV4O45Swq5O2tEPZzcD4yUloC64IPKwb/n8TopSbEDcOzMvzff0p+58tGJ59BNOw9Vi/aCINAEMKw125x60jcubtvafgLJsHPF X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:15.9795 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: daa8ec07-c63d-41f3-00e7-08dd1882bd80 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8815 Cache the value in cpudata->epp_cached, and use that for all callers. As all callers use cached value merge amd_pstate_get_energy_pref_index() into show_energy_performance_preference(). Check if the EPP value is changed before writing it to MSR or shared memory region. Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- v2: * Drop extra mutex --- drivers/cpufreq/amd-pstate.c | 105 ++++++++++++++--------------------- 1 file changed, 43 insertions(+), 62 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index dc3c45b6f5103..d21acd961edcd 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -186,29 +186,28 @@ static inline int get_mode_idx_from_str(const char *str, size_t size) static DEFINE_MUTEX(amd_pstate_limits_lock); static DEFINE_MUTEX(amd_pstate_driver_lock); -static s16 msr_get_epp(struct amd_cpudata *cpudata, u64 cppc_req_cached) +static s16 msr_get_epp(struct amd_cpudata *cpudata) { + u64 value; int ret; - if (!cppc_req_cached) { - ret = rdmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, &cppc_req_cached); - if (ret < 0) { - pr_debug("Could not retrieve energy perf value (%d)\n", ret); - return ret; - } + ret = rdmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, &value); + if (ret < 0) { + pr_debug("Could not retrieve energy perf value (%d)\n", ret); + return ret; } - return FIELD_GET(AMD_CPPC_EPP_PERF_MASK, cppc_req_cached); + return FIELD_GET(AMD_CPPC_EPP_PERF_MASK, value); } DEFINE_STATIC_CALL(amd_pstate_get_epp, msr_get_epp); -static inline s16 amd_pstate_get_epp(struct amd_cpudata *cpudata, u64 cppc_req_cached) +static inline s16 amd_pstate_get_epp(struct amd_cpudata *cpudata) { - return static_call(amd_pstate_get_epp)(cpudata, cppc_req_cached); + return static_call(amd_pstate_get_epp)(cpudata); } -static s16 shmem_get_epp(struct amd_cpudata *cpudata, u64 dummy) +static s16 shmem_get_epp(struct amd_cpudata *cpudata) { u64 epp; int ret; @@ -222,35 +221,6 @@ static s16 shmem_get_epp(struct amd_cpudata *cpudata, u64 dummy) return (s16)(epp & 0xff); } -static int amd_pstate_get_energy_pref_index(struct amd_cpudata *cpudata) -{ - s16 epp; - int index = -EINVAL; - - epp = amd_pstate_get_epp(cpudata, 0); - if (epp < 0) - return epp; - - switch (epp) { - case AMD_CPPC_EPP_PERFORMANCE: - index = EPP_INDEX_PERFORMANCE; - break; - case AMD_CPPC_EPP_BALANCE_PERFORMANCE: - index = EPP_INDEX_BALANCE_PERFORMANCE; - break; - case AMD_CPPC_EPP_BALANCE_POWERSAVE: - index = EPP_INDEX_BALANCE_POWERSAVE; - break; - case AMD_CPPC_EPP_POWERSAVE: - index = EPP_INDEX_POWERSAVE; - break; - default: - break; - } - - return index; -} - static int msr_update_perf(struct amd_cpudata *cpudata, u32 min_perf, u32 des_perf, u32 max_perf, bool fast_switch) { @@ -275,19 +245,23 @@ static inline int amd_pstate_update_perf(struct amd_cpudata *cpudata, static int msr_set_epp(struct amd_cpudata *cpudata, u32 epp) { - u64 value = READ_ONCE(cpudata->cppc_req_cached); + u64 value, prev; int ret; + value = prev = READ_ONCE(cpudata->cppc_req_cached); value &= ~AMD_CPPC_EPP_PERF_MASK; value |= FIELD_PREP(AMD_CPPC_EPP_PERF_MASK, epp); + if (value == prev) + return 0; + ret = wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, value); if (ret) { pr_err("failed to set energy perf value (%d)\n", ret); return ret; } - cpudata->epp_cached = epp; + WRITE_ONCE(cpudata->epp_cached, epp); WRITE_ONCE(cpudata->cppc_req_cached, value); return ret; @@ -305,13 +279,16 @@ static int shmem_set_epp(struct amd_cpudata *cpudata, u32 epp) int ret; struct cppc_perf_ctrls perf_ctrls; + if (epp == cpudata->epp_cached) + return 0; + perf_ctrls.energy_perf = epp; ret = cppc_set_epp_perf(cpudata->cpu, &perf_ctrls, 1); if (ret) { pr_debug("failed to set energy perf value (%d)\n", ret); return ret; } - cpudata->epp_cached = epp; + WRITE_ONCE(cpudata->epp_cached, epp); return ret; } @@ -1214,9 +1191,22 @@ static ssize_t show_energy_performance_preference( struct amd_cpudata *cpudata = policy->driver_data; int preference; - preference = amd_pstate_get_energy_pref_index(cpudata); - if (preference < 0) - return preference; + switch (cpudata->epp_cached) { + case AMD_CPPC_EPP_PERFORMANCE: + preference = EPP_INDEX_PERFORMANCE; + break; + case AMD_CPPC_EPP_BALANCE_PERFORMANCE: + preference = EPP_INDEX_BALANCE_PERFORMANCE; + break; + case AMD_CPPC_EPP_BALANCE_POWERSAVE: + preference = EPP_INDEX_BALANCE_POWERSAVE; + break; + case AMD_CPPC_EPP_POWERSAVE: + preference = EPP_INDEX_POWERSAVE; + break; + default: + return -EINVAL; + } return sysfs_emit(buf, "%s\n", energy_perf_strings[preference]); } @@ -1501,7 +1491,7 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) policy->driver_data = cpudata; - cpudata->epp_cached = cpudata->epp_default = amd_pstate_get_epp(cpudata, 0); + cpudata->epp_cached = cpudata->epp_default = amd_pstate_get_epp(cpudata); policy->min = policy->cpuinfo.min_freq; policy->max = policy->cpuinfo.max_freq; @@ -1555,35 +1545,26 @@ static int amd_pstate_epp_update_limit(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata = policy->driver_data; u64 value; - s16 epp; amd_pstate_update_min_max_limit(policy); value = READ_ONCE(cpudata->cppc_req_cached); value &= ~(AMD_CPPC_MAX_PERF_MASK | AMD_CPPC_MIN_PERF_MASK | - AMD_CPPC_DES_PERF_MASK); + AMD_CPPC_DES_PERF_MASK | AMD_CPPC_EPP_PERF_MASK); value |= FIELD_PREP(AMD_CPPC_MAX_PERF_MASK, cpudata->max_limit_perf); value |= FIELD_PREP(AMD_CPPC_DES_PERF_MASK, 0); value |= FIELD_PREP(AMD_CPPC_MIN_PERF_MASK, cpudata->min_limit_perf); - /* Get BIOS pre-defined epp value */ - epp = amd_pstate_get_epp(cpudata, value); - if (epp < 0) { - /** - * This return value can only be negative for shared_memory - * systems where EPP register read/write not supported. - */ - return epp; - } - if (cpudata->policy == CPUFREQ_POLICY_PERFORMANCE) - epp = 0; + WRITE_ONCE(cpudata->epp_cached, 0); + value |= FIELD_PREP(AMD_CPPC_EPP_PERF_MASK, cpudata->epp_cached); WRITE_ONCE(cpudata->cppc_req_cached, value); if (trace_amd_pstate_epp_perf_enabled()) { - trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, epp, + trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, + cpudata->epp_cached, cpudata->min_limit_perf, cpudata->max_limit_perf, policy->boost_enabled); @@ -1592,7 +1573,7 @@ static int amd_pstate_epp_update_limit(struct cpufreq_policy *policy) amd_pstate_update_perf(cpudata, cpudata->min_limit_perf, 0U, cpudata->max_limit_perf, false); - return amd_pstate_set_epp(cpudata, epp); + return amd_pstate_set_epp(cpudata, READ_ONCE(cpudata->epp_cached)); } static int amd_pstate_epp_set_policy(struct cpufreq_policy *policy) From patchwork Mon Dec 9 18:52:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 849039 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2050.outbound.protection.outlook.com [40.107.100.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 035CD19995E; Mon, 9 Dec 2024 18:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770405; cv=fail; b=etaAeMAQOBAceVhmRDWHodwtHMJXM22ITM5KB6TCMFPZ+Kx8N5NrkDvHXVrlF+ec4y5AcPOr0CGVYlXrUL/bZYzU+dbZMLibBAttJHQ8vGamK3DUiwsW5whA5JcHlvC4L3okKNZcafsIYrRw28Z5mcl5JFuApb4nKz8QeNbewuc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770405; c=relaxed/simple; bh=gQD6FKH8emXlgFIFhr0PiLn45yqwPWOHWKiQb6b0N2g=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jM/Iys/2D63KFx9R3Nv1+4HUznvuZCs5dHS/QVNJgt5Vgz/XR3A3HgdrnFkMK+TKCfLilnjjIibJ/Ldp0HLtD8SkRESHEVd6yl0miAvjASQAcnGFUvpfJwWHjf2wI9MuAoD/AW1onJADM+TvdAg9HlCXSLE7aGiE1UUrvUSbkZ4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=FoxWe1mD; arc=fail smtp.client-ip=40.107.100.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="FoxWe1mD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N1gaSjl/tV/esKaoPdmtS38l1X8nqDl//gpqPufBNvMkzfKnF6F1ChHlTsKAE6lPdc5fM5NEaBpWv6mUov0qgjP8ckyNmyTvRevLViSBsZkBnblcJgEIVEiMTGmxFke7Hik/GFdwp3RISKl1hQJdyeKQOtFfihUQ2MEf6Y5xNa0+y3HJ9yKPBOvDaUdSD424/Z6RH3+NMxgdaMFFXnDkHqACw3bRXVIbmrzrh5QMGjUGDrNIKEpAse7vvXi02Zh/Pzg39UJI+vcgiW9DJNUw/DRvLKzuVCmlMKAz79eML3euYTuQZQnNoYhjP6vKJEGNnCen9qqzZdvw1DSr5Kv2qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/32xu1DW/wwZdkvQdgmLaDFVjzOuUKbMneyzk8msQaQ=; b=VV1xrJkZrCxNzIt/lTjNAiTb01nFH1vDmgJFsPk48Vibrpset8gfq5K44onpetDrmYQ7NeiKX2cOtPIMPUxMrhYpYVyy3ubYJkl8j8+mYGqKHS5p4PMiSfueuhzvSf1dvkycHnNsR83FcPyPK+lgOmguI9vg2ngrzLSS/v8wkChRxYdEX5sbksQFRx/M3aR3J0ok6Ge7SV6q5Yc4mVbjyR14V+92tlkeePnNGjgSIvFpdxGIpUcR5zYd8R1+7fioH484bmzIrC1mIT1LA/vTxFi2I3DSWHFNMf5X+teMk+HXYwj8ppHndIzO+hA7eBUyVvxX+ep0nniPRdsuWnciJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/32xu1DW/wwZdkvQdgmLaDFVjzOuUKbMneyzk8msQaQ=; b=FoxWe1mD9G4aeMpxYgbGgbcmALS1ElAndDXd9Kjy4IkkBuI8+aGfBpWLVi4IpXhiEYDornDSbvEi6rwd5C1NecOVMAhvkQ5wpQxDLPE0wHb3olJiyZRjhc7zmsyPlxLMkkOMRr80uqKScoE4tZyqClgkiiTZFRAFBOJDsQoaEM0= Received: from CH5P222CA0017.NAMP222.PROD.OUTLOOK.COM (2603:10b6:610:1ee::21) by DS0PR12MB7897.namprd12.prod.outlook.com (2603:10b6:8:146::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.17; Mon, 9 Dec 2024 18:53:16 +0000 Received: from CH1PEPF0000A348.namprd04.prod.outlook.com (2603:10b6:610:1ee:cafe::c9) by CH5P222CA0017.outlook.office365.com (2603:10b6:610:1ee::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.15 via Frontend Transport; Mon, 9 Dec 2024 18:53:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A348.mail.protection.outlook.com (10.167.244.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:16 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:14 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 12/15] cpufreq/amd-pstate: Always write EPP value when updating perf Date: Mon, 9 Dec 2024 12:52:45 -0600 Message-ID: <20241209185248.16301-13-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A348:EE_|DS0PR12MB7897:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fc00e30-29dd-408e-143b-08dd1882bd97 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: mwsoRYbldHTNg0Vc9ru+r9zX6yxM34GSADILwPsdBH0peW7YGZP8zyZg9gqU3Ca8UqHNPE8K800mSULd5wpMWPfedsWKnv8zR3Y0PSz5VsEc8LZ2pRWFIUz6z+rGYWaSGuiD2r6BNOyl/7Q4PKRxh2kto7LGIUGGC/YprCJpCE6mA5zukdV3cSUJ7t5BeoU4engsM2frTLbbmy486su1ufn0hGLArBJlT2qtArfIUQ+zOeUxPv/xIRXRZ9RHom/pDu+3Gi4hRfqV62gM+rRk5QSIDktPq3ZQuJ+hYbl0Nx+tN2pO1EDlpEEZx3Rmz3aH+sulS2QCKkfrUMzNSKFgIAz4mclxXlj0OTm7HS3s2yXSJNzoRdLzjie/BIw2C0hJBzBXYukNHcO3Q/lUVEOOLUufeOYc48tCGTRMDyRYLTRLL3eqdtfmcnCaXtCFzg0gW1MeUfummcX7FnFfrrrZDyafMdGepszDQ7La0gTTNNH3sFTBkvuyN8FQYliIHwkyiBErL0xj3F7F7A/UWt1urPoeTj06chbEAEPD/pDl3A8kJ8plCRzh4foV97bY+yFTnF7ZvuOi/FqGJO+wX2hFWXTD03GAd17bFHi0anjV6Z18ChthlN8CBemDXs7naL3qURnSGXFZryY0BW1b8v4sYlpTVu2zvN2KQkhrcDh9qKWO3QIZ3/AgGo+MA3mpCpll8V4rlYLAHh+VYxzwcrsaGqqECasy+/4dITJSDYt/9uMbwtIfGNvkTZetvpwkLF4Iu3V04VEaLc8KYXce1TI5E6jvFtiVkt+vlspmPIGXZnahwTijO0dfOviS/8bi/8W7edq8xLZPJKjt9DjS5WN4paKHVeXap2uOqbecaC+2RuXdEXxMfdwxe/rLaqa36Lp7UsDE1tN32JzVFbVWUw82A1578sKrficsJ1N81YtzrOYQrH1o6C11Hw7JxFh7jIHpBDLdq2Ll9TxH3kGpP521qRnQJk8MAHt6eU5xH2pCHlNkM80rV2Ev2LEsSelQM2ZvwSyR/hwpMa8EHE6JjuuKoJMHU/vbSc2w2iFSF64BKhCeo/miZwh43eh0sQiM3auzB1TF6fasqp43kzLZOln3W25xxhI27jInaXQ3YF+fQ9w4GNqWqF0KtRL8b+0BLBfTtYRoVzJnhq+3SVFAgrQBxmJb4DvLb3vNYLkUl+HeS9UdwaU22FIc9Y5x2mWMNL2LnvVwOrNZkb7mSSjmq0iFzg9flppTmhcrF0/Bbeoq78hVz5lhKTHclze6FGL2PKHWKIM7iGsmNQtB1rYdH0gHvjdKdVCMiZ73Qdfqmcd+M223fIcPzXMP5NXK6vz0zxh+3zQJV2B5TpzF/IN4DNEn+a1HZRCvlyZRF3Y2K29/uby4r/N5rpXhKyw45yTiT3t8EVRrLWENcSkhJLsumQd0PqY2B61NX0WzgdzBscndzfjUsJs2yuV4LYEP2GWL+Iis X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:16.1151 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4fc00e30-29dd-408e-143b-08dd1882bd97 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A348.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7897 For MSR systems the EPP value is in the same register as perf targets and so divding them into two separate MSR writes is wasteful. In msr_update_perf(), update both EPP and perf values in one write to MSR_AMD_CPPC_REQ, and cache them if successful. To accomplish this plumb the EPP value into the update_perf call and modify all its callers to check the return value. As this unifies calls, ensure that the MSR write is necessary before flushing a write out. Also drop the comparison from the passive flow tracing. Signed-off-by: Mario Limonciello --- v3: * Squash "Always write EPP value when updating perf" and "Check if CPPC request has changed before writing to the MSR or shared memory" * Remove extra write to cached value * Add comment explaining why updating two cached variables --- drivers/cpufreq/amd-pstate-trace.h | 7 +- drivers/cpufreq/amd-pstate.c | 108 +++++++++++++++-------------- 2 files changed, 56 insertions(+), 59 deletions(-) diff --git a/drivers/cpufreq/amd-pstate-trace.h b/drivers/cpufreq/amd-pstate-trace.h index e2221a4b6901c..8d692415d9050 100644 --- a/drivers/cpufreq/amd-pstate-trace.h +++ b/drivers/cpufreq/amd-pstate-trace.h @@ -32,7 +32,6 @@ TRACE_EVENT(amd_pstate_perf, u64 aperf, u64 tsc, unsigned int cpu_id, - bool changed, bool fast_switch ), @@ -44,7 +43,6 @@ TRACE_EVENT(amd_pstate_perf, aperf, tsc, cpu_id, - changed, fast_switch ), @@ -57,7 +55,6 @@ TRACE_EVENT(amd_pstate_perf, __field(unsigned long long, aperf) __field(unsigned long long, tsc) __field(unsigned int, cpu_id) - __field(bool, changed) __field(bool, fast_switch) ), @@ -70,11 +67,10 @@ TRACE_EVENT(amd_pstate_perf, __entry->aperf = aperf; __entry->tsc = tsc; __entry->cpu_id = cpu_id; - __entry->changed = changed; __entry->fast_switch = fast_switch; ), - TP_printk("amd_min_perf=%lu amd_des_perf=%lu amd_max_perf=%lu freq=%llu mperf=%llu aperf=%llu tsc=%llu cpu_id=%u changed=%s fast_switch=%s", + TP_printk("amd_min_perf=%lu amd_des_perf=%lu amd_max_perf=%lu freq=%llu mperf=%llu aperf=%llu tsc=%llu cpu_id=%u fast_switch=%s", (unsigned long)__entry->min_perf, (unsigned long)__entry->target_perf, (unsigned long)__entry->capacity, @@ -83,7 +79,6 @@ TRACE_EVENT(amd_pstate_perf, (unsigned long long)__entry->aperf, (unsigned long long)__entry->tsc, (unsigned int)__entry->cpu_id, - (__entry->changed) ? "true" : "false", (__entry->fast_switch) ? "true" : "false" ) ); diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index d21acd961edcd..fc0eb268c0335 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -222,25 +222,47 @@ static s16 shmem_get_epp(struct amd_cpudata *cpudata) } static int msr_update_perf(struct amd_cpudata *cpudata, u32 min_perf, - u32 des_perf, u32 max_perf, bool fast_switch) + u32 des_perf, u32 max_perf, u32 epp, bool fast_switch) { + u64 value, prev; + + value = prev = READ_ONCE(cpudata->cppc_req_cached); + + value &= ~(AMD_CPPC_MAX_PERF_MASK | AMD_CPPC_MIN_PERF_MASK | + AMD_CPPC_DES_PERF_MASK | AMD_CPPC_EPP_PERF_MASK); + value |= FIELD_PREP(AMD_CPPC_MAX_PERF_MASK, max_perf); + value |= FIELD_PREP(AMD_CPPC_DES_PERF_MASK, des_perf); + value |= FIELD_PREP(AMD_CPPC_MIN_PERF_MASK, min_perf); + value |= FIELD_PREP(AMD_CPPC_EPP_PERF_MASK, epp); + + if (value == prev) + return 0; + if (fast_switch) { - wrmsrl(MSR_AMD_CPPC_REQ, READ_ONCE(cpudata->cppc_req_cached)); + wrmsrl(MSR_AMD_CPPC_REQ, value); return 0; + } else { + int ret = wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, value); + + if (ret) + return ret; } - return wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, - READ_ONCE(cpudata->cppc_req_cached)); + WRITE_ONCE(cpudata->cppc_req_cached, value); + WRITE_ONCE(cpudata->epp_cached, epp); + + return 0; } DEFINE_STATIC_CALL(amd_pstate_update_perf, msr_update_perf); static inline int amd_pstate_update_perf(struct amd_cpudata *cpudata, u32 min_perf, u32 des_perf, - u32 max_perf, bool fast_switch) + u32 max_perf, u32 epp, + bool fast_switch) { return static_call(amd_pstate_update_perf)(cpudata, min_perf, des_perf, - max_perf, fast_switch); + max_perf, epp, fast_switch); } static int msr_set_epp(struct amd_cpudata *cpudata, u32 epp) @@ -261,6 +283,7 @@ static int msr_set_epp(struct amd_cpudata *cpudata, u32 epp) return ret; } + /* update both so that msr_update_perf() can effectively check */ WRITE_ONCE(cpudata->epp_cached, epp); WRITE_ONCE(cpudata->cppc_req_cached, value); @@ -459,12 +482,18 @@ static inline int amd_pstate_init_perf(struct amd_cpudata *cpudata) return static_call(amd_pstate_init_perf)(cpudata); } -static int shmem_update_perf(struct amd_cpudata *cpudata, - u32 min_perf, u32 des_perf, - u32 max_perf, bool fast_switch) +static int shmem_update_perf(struct amd_cpudata *cpudata, u32 min_perf, + u32 des_perf, u32 max_perf, u32 epp, bool fast_switch) { struct cppc_perf_ctrls perf_ctrls; + if (cppc_state == AMD_PSTATE_ACTIVE) { + int ret = shmem_set_epp(cpudata, epp); + + if (ret) + return ret; + } + perf_ctrls.max_perf = max_perf; perf_ctrls.min_perf = min_perf; perf_ctrls.desired_perf = des_perf; @@ -510,9 +539,7 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, { unsigned long max_freq; struct cpufreq_policy *policy = cpufreq_cpu_get(cpudata->cpu); - u64 prev = READ_ONCE(cpudata->cppc_req_cached); u32 nominal_perf = READ_ONCE(cpudata->nominal_perf); - u64 value = prev; des_perf = clamp_t(unsigned long, des_perf, min_perf, max_perf); @@ -528,27 +555,14 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf, if (!cpudata->boost_supported) max_perf = min_t(unsigned long, nominal_perf, max_perf); - value &= ~(AMD_CPPC_MAX_PERF_MASK | AMD_CPPC_MIN_PERF_MASK | - AMD_CPPC_DES_PERF_MASK); - value |= FIELD_PREP(AMD_CPPC_MAX_PERF_MASK, max_perf); - value |= FIELD_PREP(AMD_CPPC_DES_PERF_MASK, des_perf); - value |= FIELD_PREP(AMD_CPPC_MIN_PERF_MASK, min_perf); - if (trace_amd_pstate_perf_enabled() && amd_pstate_sample(cpudata)) { trace_amd_pstate_perf(min_perf, des_perf, max_perf, cpudata->freq, cpudata->cur.mperf, cpudata->cur.aperf, cpudata->cur.tsc, - cpudata->cpu, (value != prev), fast_switch); + cpudata->cpu, fast_switch); } - if (value == prev) - goto cpufreq_policy_put; + amd_pstate_update_perf(cpudata, min_perf, des_perf, max_perf, 0, fast_switch); - WRITE_ONCE(cpudata->cppc_req_cached, value); - - amd_pstate_update_perf(cpudata, min_perf, des_perf, - max_perf, fast_switch); - -cpufreq_policy_put: cpufreq_cpu_put(policy); } @@ -1544,36 +1558,24 @@ static void amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) static int amd_pstate_epp_update_limit(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata = policy->driver_data; - u64 value; + u32 epp; amd_pstate_update_min_max_limit(policy); - value = READ_ONCE(cpudata->cppc_req_cached); - - value &= ~(AMD_CPPC_MAX_PERF_MASK | AMD_CPPC_MIN_PERF_MASK | - AMD_CPPC_DES_PERF_MASK | AMD_CPPC_EPP_PERF_MASK); - value |= FIELD_PREP(AMD_CPPC_MAX_PERF_MASK, cpudata->max_limit_perf); - value |= FIELD_PREP(AMD_CPPC_DES_PERF_MASK, 0); - value |= FIELD_PREP(AMD_CPPC_MIN_PERF_MASK, cpudata->min_limit_perf); - if (cpudata->policy == CPUFREQ_POLICY_PERFORMANCE) - WRITE_ONCE(cpudata->epp_cached, 0); - value |= FIELD_PREP(AMD_CPPC_EPP_PERF_MASK, cpudata->epp_cached); - - WRITE_ONCE(cpudata->cppc_req_cached, value); + epp = 0; + else + epp = READ_ONCE(cpudata->epp_cached); if (trace_amd_pstate_epp_perf_enabled()) { - trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, - cpudata->epp_cached, + trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, epp, cpudata->min_limit_perf, cpudata->max_limit_perf, policy->boost_enabled); } - amd_pstate_update_perf(cpudata, cpudata->min_limit_perf, 0U, - cpudata->max_limit_perf, false); - - return amd_pstate_set_epp(cpudata, READ_ONCE(cpudata->epp_cached)); + return amd_pstate_update_perf(cpudata, cpudata->min_limit_perf, 0U, + cpudata->max_limit_perf, epp, false); } static int amd_pstate_epp_set_policy(struct cpufreq_policy *policy) @@ -1602,7 +1604,7 @@ static int amd_pstate_epp_set_policy(struct cpufreq_policy *policy) return 0; } -static void amd_pstate_epp_reenable(struct amd_cpudata *cpudata) +static int amd_pstate_epp_reenable(struct amd_cpudata *cpudata) { u64 max_perf; int ret; @@ -1620,17 +1622,19 @@ static void amd_pstate_epp_reenable(struct amd_cpudata *cpudata) max_perf, cpudata->boost_state); } - amd_pstate_update_perf(cpudata, 0, 0, max_perf, false); - amd_pstate_set_epp(cpudata, cpudata->epp_cached); + return amd_pstate_update_perf(cpudata, 0, 0, max_perf, cpudata->epp_cached, false); } static int amd_pstate_epp_cpu_online(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata = policy->driver_data; + int ret; pr_debug("AMD CPU Core %d going online\n", cpudata->cpu); - amd_pstate_epp_reenable(cpudata); + ret = amd_pstate_epp_reenable(cpudata); + if (ret) + return ret; cpudata->suspended = false; return 0; @@ -1654,10 +1658,8 @@ static int amd_pstate_epp_cpu_offline(struct cpufreq_policy *policy) min_perf, min_perf, policy->boost_enabled); } - amd_pstate_update_perf(cpudata, min_perf, 0, min_perf, false); - amd_pstate_set_epp(cpudata, AMD_CPPC_EPP_BALANCE_POWERSAVE); - - return 0; + return amd_pstate_update_perf(cpudata, min_perf, 0, min_perf, + AMD_CPPC_EPP_BALANCE_POWERSAVE, false); } static int amd_pstate_epp_suspend(struct cpufreq_policy *policy) From patchwork Mon Dec 9 18:52:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 849041 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2073.outbound.protection.outlook.com [40.107.244.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 065231990AF; Mon, 9 Dec 2024 18:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.73 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770402; cv=fail; b=eub5WJptYdDnHXfDaaFYrJlr/gI+bUE49bvmmEi/AnYvzBB2g3XmrL0HgM8PXMugE4jhqFf6/zLKjzaH5AmMTa/BD/uJufqE8+x2ptKYiuwh2ZOBYItxzWuVAj1mQLki/OZdIJ55lp+bf78tjswxFLZEwl1CrK7sosaWqTm05iU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770402; c=relaxed/simple; bh=ybB0OJdHG53wlbveZS9VyjLH/B5ZhWlwyr2BdU5u4Hc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CdNIFDfQ5ZiXGrVyFzdlfyLTap5PNXkDfKzPz1O7DdTJh+yjqtzuR0+M/N2OoI8K8ObNJbfssGjZUXxRPPcGylClEyPkBtfrobTENduNI8/eMzAoWzTeHydSE0+iCII3p4saKqnAqJ6R9XQVsZAYbDPSgxtqHSmSRJGxnmA12GY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=EdRAIwNz; arc=fail smtp.client-ip=40.107.244.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="EdRAIwNz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vSlww3nH1LBPhdGL3KjYvDSJZlJ76tiD1pq3roueFG2M7QtaNBYpaae/vAzjDWe4WdQWNkw7gcLfy9TUKHRMt+n5EfENwzFENCRWVrklGKi2WHKb/dZiHUPV1i/JODjwpsrNqb9uykDoDuY4la8jO8pY6RzSeP6OAL1cXhDrbxX/apD2QSAm90rG55+EoA0gifrClchAE8QvgJKxT6vgyOlDFLixxSWwfBtd1mQeD5YHToKsd4tWHexKQna0sFNHyLBlFwoVSBrCKIkWjztgrDdWVhbnsZkx5X8fVODpz5/LjiqWbQ2UeogzStz2iN5VdqG5imztWUK/6bSzxY0KZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RKQ7IfoAnp5cuGuPhZSM4V+qRH+o6cleG2QgsnaELyc=; b=OnhpUEA1gCHaMVw4Uss16Z3/Wn4fNv2vG6s4a6BAWX4Rsp6ed9VBECFFiq7H+r0mDAFnY98h31Xf1KtOT8+oOFXZORTrc4EOJm1sZMoY+Jj2C+mlEdbsBaCc75vJNqBcaaMYI5HbNWxcgOYBpe48GV9QOcWnXq2WMsU6gsQ+XaJ9vDG5+FHAeMxCejKjd5qFKWEnD6Ios0SdfZB0gc5gddS+GMxejkLW6wgLwMS5L9H/L3wlvUYPUCEr0oYpuWjya0Cz+MSQCltQJVq094AeBHVjZX3choEwXc9Xg9TJMljBbAiHlspQHPeBZmR2AdZRpBIvHM0OAjMHfI9DFLRQkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RKQ7IfoAnp5cuGuPhZSM4V+qRH+o6cleG2QgsnaELyc=; b=EdRAIwNzm7A8Is5TlDqd2+C50DGcW6BxZUkr3yt8OXZLE0d1FtvHdE9EyExOvzA6nV8PHoK4GgK6EyD1Ii6/HE6SbPZt3M/kL9JiqIwP2OKKIp0iVTIcPCZG/NBOhXuIlfQ3SZ7UHWzj0wvUvvOUaGDQ32GkQxKj/4jtVSaXcKQ= Received: from CH5PR05CA0004.namprd05.prod.outlook.com (2603:10b6:610:1f0::9) by LV8PR12MB9154.namprd12.prod.outlook.com (2603:10b6:408:190::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.18; Mon, 9 Dec 2024 18:53:16 +0000 Received: from CH1PEPF0000A34B.namprd04.prod.outlook.com (2603:10b6:610:1f0:cafe::12) by CH5PR05CA0004.outlook.office365.com (2603:10b6:610:1f0::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.12 via Frontend Transport; Mon, 9 Dec 2024 18:53:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A34B.mail.protection.outlook.com (10.167.244.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:16 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:14 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello , Dhananjay Ugwekar Subject: [PATCH v3 13/15] cpufreq/amd-pstate: Drop ret variable from amd_pstate_set_energy_pref_index() Date: Mon, 9 Dec 2024 12:52:46 -0600 Message-ID: <20241209185248.16301-14-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34B:EE_|LV8PR12MB9154:EE_ X-MS-Office365-Filtering-Correlation-Id: 38b1901e-c56d-489b-4c54-08dd1882bdcc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: LmndC4mS7RcH9hE60Ov9gQad1jJG56WYdOJUJbEMks2T5VpiphgpsCG5ZztThJ1Eau450NjYohbOmbSLzWMn8TEqpK/8ER5Y1AlzWvcxVCeVbZ4cHeinao+IgOwKtTZFUOFzC5dM2A2QmJoJpETSluJ5wCEBLoNrrTE36kjpKSCVuJKQyVspxS/wCP3YYLNxfoviSRck1QYQqD3sOMfGMRW+mTFBapF8rN25u+WlkJb6HRF0Jv+p1ExOE7vNuyFmWYmoQM2FRpI25DO07u9Nl9OPYF5wLARpTTeK7FIb94Jr7amZhquaqwZcYQyoiHnM/T/qFscg630c2cjuCpKJByYX9bpoi9NVsgA3HKwINqxqd9wFwXq9Bt/4+4YOq1B9cS91EJk+GOb2clN5dVIJH32UAbJdsIg0N5tEywQax+guLfFpqoZG0ri+XLrqE0KW80rTN2GKEhLLEhRkBKmo8Gpr9zOvL2apeAH6WtCPdXpN1W6O4Y3dpmLZyCrQv2PhluRgU/+OxSvd5pcA98613E2N8vJGxwzHtvxITz8n6EF3Dx7056N5e4tqrNtxnPpMa0bkrXvWA1M0nhS5WEcYnmkOmyuneSKrJI92pu5u9C5Hg6FyaRkLTx+mwQEtT8+szi1UP1FGukCzUeqsSsOe5+F3HBWoyRam07se3Hb38FTFnGEYd1CKsQkWSdfoetPwdr/VmigeMWi69wbhSwPjyGY2Msa21sO9d3D7ULJjOWclMDV+E5DGQQTxqk2u7LAFKEEg41Ue3rsQ+tZuR0zWYKAXx3c0fm0My/ZiFOZohuLnRjmT9NgWRoqzEfg89cyGeIoGutq6jzTcMumhzgJSSXhJXESM2j8NRyoofP23Y4y7nQk9Tp56vi+YUUeS7eBFvHhOnhcS3mI7T0YeqAJhqVsiOOSVFosi/1njOvhifWfluTNzXZN8FCIWPO6urDSAq+VJaou9slFSQvJnl7p/2Z8kMS8ctjt3Jb0zTC9goB/klUVhaYaVvrA/MDAkpQUdur1f1ybnq1bIoEw72XG5V4Fulo2h14v6duvflYajeUneRPoimFML0ck9bamB3UCJFEspWXdJPWAG5Q4dwU2YIFA3yiPEFvUBHWojfcIwVIJUxPzguavelDoZbYqZ4uLpT1sNErv6vQpAModP0B/FZvEimXtZjKfMBy7mvOZy22t6onRiBQOlM7Pksqhqp8L0BhiSf3Sw8K60LlxSL44R08yKk+XY/KZ0dUWT5pSIjamEr8Lj6xfPoM/9LIivyvf34Lh8wRtL16AJ5R9rBLAC2sLFvh+Sim5MHfNS6WJOq6Bh5uzq56Ql7LiiVctFgiKB/1JKnwefWSpO9LFJSQxz1muNAA16RUjiRPp0Tfz9EwEeuFY75lZHGHcbiF8Q3hWwc5jW4BmfefPDSmj2x3KOv7fLGyTtCt801olnTBPth/zM6SGvifErNtUC4a8fjnIk X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:16.4794 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 38b1901e-c56d-489b-4c54-08dd1882bdcc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9154 The ret variable is not necessary. Reviewed-and-tested-by: Dhananjay Ugwekar Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index fc0eb268c0335..ead3a47570139 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -319,13 +319,11 @@ static int shmem_set_epp(struct amd_cpudata *cpudata, u32 epp) static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata, int pref_index) { - int epp = -EINVAL; - int ret; + int epp; if (!pref_index) epp = cpudata->epp_default; - - if (epp == -EINVAL) + else epp = epp_values[pref_index]; if (epp > 0 && cpudata->policy == CPUFREQ_POLICY_PERFORMANCE) { @@ -341,9 +339,7 @@ static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata, cpudata->boost_state); } - ret = amd_pstate_set_epp(cpudata, epp); - - return ret; + return amd_pstate_set_epp(cpudata, epp); } static inline int msr_cppc_enable(bool enable) From patchwork Mon Dec 9 18:52:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 848611 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2044.outbound.protection.outlook.com [40.107.220.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A51D9198A37; Mon, 9 Dec 2024 18:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770402; cv=fail; b=EwTJNkhNqr0dH02GKZ/xVKMXM2Oc4GoM/Nf59kJlvUR94qgTyJ3KpImSQSHzXom48Uua+IeeBykPLwCco8u28c8tLmnhM2H/jsEFvumjSD9o1C9RbnKbdeTX70GX7+QiLO0ZhN6wwHW7+9vOjKxhLjUe1G0FLHUwmr72MxrbVRE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770402; c=relaxed/simple; bh=1qO6n/C8t9LKZSkIGzDJx2RTReZncXFg7OJdetw0nTw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=opA1I1JboUZhaoMaxCWOombvADUXjMO8bzi3ueM9EUJaF7OfZeUz4ERBIx3+R4pnmkcXkMAxIKDOYuxjYdc5vfDtxF95yeHfcHh8HeakCElkOihGk5rfQnLZ/X9LSoMibiD+xyeSHY01jUaA0g5xpoaXkeKwvuqVK7qv630kE5U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=cMbtmK2L; arc=fail smtp.client-ip=40.107.220.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="cMbtmK2L" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KxwtD3Rbbnf1FVUw/Vth6rQLIzFL6wNHwfUegi6Wa2nnxpah8dLpJFFAKmrNB7g4jTw84SnercdxkD3Ntgq6e4qu7rkZro7fgERSpBj6GUiPCJ7pgiaa8ACbEgNqoOEkxoCqFWa6MOoEi3KzxVKXT/Ew/inkeMFRev6Y+wG3h72177xPlOWScG45fhY1bUOqH167Nuv4pYsLiN7Z/SYD09n8XB3okBIHPxpMZYrTH/uvtJZVZbedgvcMqnF9VqCqd1xDeUZ/LtV+Pymzc0jw3vTfbOCBTRM+T1FOvykUyO8U+wY3wtFI+miqY/BBPjaXyIoys7zyXZ37aYMBu+RNkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gr+LLu42PNwm+12VgTsevRYY2mCXSkUtQYPNq6cSIVw=; b=Fq/qkbYolpBZB+Y2f99ziPYZARLsAM7F/3XTlg0Rlh5IhkgyDB+tmMv5Ku2VffeGLm65KRh6H7MUVAhACHvREMmsCp8fPBfM2H8b8WeMZl3RWE5zdd9owO23qTrm7/sABufqbQOeLXQNrcoJjX/lRWOJlvChZJpgCgnKT/5c4xcr17YCCXJ3it0XoLcJmr2AvZH5dCdrN9L/u6EJzpZievIQt77OgCl1wNZDVIaaG4abS8RTgcdHuiPTz59bUePiusfVMGg3RKvkIg7psQ/eTiwvtsIBCbb4lWxuP3K8unaVXInZyioIvlNsvt7/YF0FSkSOxW2Ikar3qiMX7OusIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gr+LLu42PNwm+12VgTsevRYY2mCXSkUtQYPNq6cSIVw=; b=cMbtmK2LU59jMwIEiiXYux7/xyRWCuubcgiz4OxgITnpxjffwR0a5HECouZ1pmHXpojH+xOFy7wQWQf8/DCPlf+rpO5ChjJYrheZ4TFC9Gh7JXQCPEyuhmmoKRtD7MR9edGNdzVWoI0YNJNRX/1YQhPU+EfSkQvzm4b5Q4gRTrQ= Received: from CH5P222CA0002.NAMP222.PROD.OUTLOOK.COM (2603:10b6:610:1ee::22) by SA1PR12MB7319.namprd12.prod.outlook.com (2603:10b6:806:2b5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.18; Mon, 9 Dec 2024 18:53:17 +0000 Received: from CH1PEPF0000A348.namprd04.prod.outlook.com (2603:10b6:610:1ee:cafe::c7) by CH5P222CA0002.outlook.office365.com (2603:10b6:610:1ee::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8230.14 via Frontend Transport; Mon, 9 Dec 2024 18:53:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A348.mail.protection.outlook.com (10.167.244.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:16 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:15 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello , "Artem S . Tashkinov" , Dhananjay Ugwekar Subject: [PATCH v3 14/15] cpufreq/amd-pstate: Set different default EPP policy for Epyc and Ryzen Date: Mon, 9 Dec 2024 12:52:47 -0600 Message-ID: <20241209185248.16301-15-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A348:EE_|SA1PR12MB7319:EE_ X-MS-Office365-Filtering-Correlation-Id: db0cc331-1415-4167-4b3d-08dd1882bdef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: pTJ2nVNIek+AAJwQG75SKVAPYR8XzADQ6+jskPm9exw5LW3npzng0D6W9TDNFNIST2g8JQtjHpNOKSP86Okx4H5zIbbyjEUoMcE1QgQcUdAyTn8qjypfL+GSxY28YB6jzjfZw+ES8S0ZTW3CiOBWtXDdiPAsKNphroScNdQAiHfKdFZFtGeqwwnU/sCL92btxZx3BPmSvJPH3vtCXPqw7GUveLJ7SMsPBb40gnfDA6FBExhXA60QEgS4w0jSh2ym8gZRX9dNj/xCdT+RtIdVtiQvL09/WlKntcIxFrXwCC5yUy0pKHX0Ozhyl/qumXejfIh86IM2RYMlVH6siwY7m6hpOM7KKGGRLDorkTINGvarropPVZXS02DsawbNzMMwfv451wxqlY1v8jkIVsQTBPLk9vzfSV5jssIn1duBzy7wHcMpN7LOCo9NPSIXB9qwW2TZrWvCNEVCrXTSRYyM9afnUzT0lSEP8/9CCrTzolwphIPPWmuh/K0H+EJVbv8JD/C2sjof9B7XVnt6/wotY0jq/1SKXTQfSRWC422djIhsvw5TruEObDqlKvFJ3IyHJ5H9Jrd7LN3RJDyanmBxA8q8yC4FS+O+JZNw6IeTR24RpDgM1SZQBbk8BzaZKSeLqyj/v1H73iw8pf3cz01dEnCm/Y4Lfw5yCPIPVMG/rsNRumoXkx/zQIr6ZnUb5aGCTHSxWMAD8FdIaILwNGbmRpckZAqEXCHh0zpzg0Tu1wj3JC/ku6VaLHx1Lgt85fwBjXaoP2P/kTe1g/e1d1fLfqINdqArjP93SjulPSuqpFEFk5RuPVBIFB7Y52tJARz0fKIShkkv1Kwiuak7HgmeCmmRCq8Usjc9Pqg8krNg1nYCvGwRCrr2RudPA0rxRcAkKE9tqfWVEr/7wsk9GG9rWQNMBcimGtSXGKjNC/Hh5JCj8xu6srywUQcmKFV2+sohbRovCdfwRK/TY5Tdz1aEdM4zdfwG76A2tl3wZp3YnD4EOmNpyvTKHu2DnlJ3ZmGKgNOTV+GLNZQsjWDvaTJ1QVwx+oIg8NEeSfa1yyiMJ4PVMBzivEOmzYe1GOUjtAczrV0CFNhVpuPrlKNtuJtkR+MzMVKbNw7YcWfspJ5JeEVPb40k1PtC34wV2F48c5f6xy+bMeoGFIMwm3moy9mLgrqOjom+gDNcE2fLNGpSUhcZ6zow3f7FyrIdOaHdoOi0yGWJ76/u+6OXOvAuQ14CsEBCYf3WWxttFE7R7tcjDCHjjJPHbhZ40vV0Ox5XJKPFwePXPf8WKdcEX6Czad9ztOu/wb9m93xDU2UEoZDWg9tZHZrVIZiDnFOtr196dyCPTZXFNZFT/qxHYJ9s6Cei0u2E9yPDJVRdsH9sIUL+NKnT9jQAlWuVTorToUZaNU2BpH6HLUmQIG7e6mvIQpeXjlEdH1QXLEH+K8DxeQ+a5RGxkAWQO0lx4zE3IH1FxEFI X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:16.6932 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db0cc331-1415-4167-4b3d-08dd1882bdef X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A348.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7319 For Ryzen systems the EPP policy set by the BIOS is generally configured to performance as this is the default register value for the CPPC request MSR. If a user doesn't use additional software to configure EPP then the system will default biased towards performance and consume extra battery. Instead configure the default to "balanced_performance" for this case. Suggested-by: Artem S. Tashkinov Reviewed-by: Dhananjay Ugwekar Tested-by: Dhananjay Ugwekar Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219526 Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index ead3a47570139..308d30a25f100 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1501,8 +1501,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) policy->driver_data = cpudata; - cpudata->epp_cached = cpudata->epp_default = amd_pstate_get_epp(cpudata); - policy->min = policy->cpuinfo.min_freq; policy->max = policy->cpuinfo.max_freq; @@ -1513,10 +1511,13 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) * the default cpufreq governor is neither powersave nor performance. */ if (amd_pstate_acpi_pm_profile_server() || - amd_pstate_acpi_pm_profile_undefined()) + amd_pstate_acpi_pm_profile_undefined()) { policy->policy = CPUFREQ_POLICY_PERFORMANCE; - else + cpudata->epp_default = amd_pstate_get_epp(cpudata); + } else { policy->policy = CPUFREQ_POLICY_POWERSAVE; + cpudata->epp_default = AMD_CPPC_EPP_BALANCE_PERFORMANCE; + } if (cpu_feature_enabled(X86_FEATURE_CPPC)) { ret = rdmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, &value); @@ -1529,6 +1530,9 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) return ret; WRITE_ONCE(cpudata->cppc_cap1_cached, value); } + ret = amd_pstate_set_epp(cpudata, cpudata->epp_default); + if (ret) + return ret; current_pstate_driver->adjust_perf = NULL; From patchwork Mon Dec 9 18:52:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 849040 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2084.outbound.protection.outlook.com [40.107.243.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C35E01991BF; Mon, 9 Dec 2024 18:53:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770403; cv=fail; b=H8Pk77vbnb74Ug68DBN/nTkcepJZSM+y4YH61cF5Uod/04fxV3B9SymZJfWHK8MApacmdqYhqu6KZW61Bz7zJtXZaTd77QVFeri0awHIwAki1y4GV+BXnOoMqo2GP6tcBC539R9kpsuOll3z+E2steTtbgvpwGcHv7v05JmLcGA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733770403; c=relaxed/simple; bh=LQbVt5UTqakgrgRPhjSC+F66lLYCils0aKWae30sb1A=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uUxnLboPz55xIIOFsY8gJRwVnk8O+K8HyXm688pdPnfjLb5oN3VB4BVFXBYOUlvUywpk+qJqJkMxZWN22l2+rJJOzXL9phJdpHY12gTaG9FbMqkmMoQTnez8pyTjxmP3xLD1KwGuV8ItggnWZjOvugD85ke8dCIBf72aP58YfAg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=NZP/I159; arc=fail smtp.client-ip=40.107.243.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="NZP/I159" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OQzZWp4vWPGxtektQFkQUntMgYQPPxQ1bb6DbaMIZD356b1Y/Y+oiZ+n5z8u9FT5qV9oe8LbEz8zdhThBDv5z/2w5/g83zxxV2B/1CrWumMs++sQo4oLi+HDnZknlXawnVPdTsGScRXPdqatfqmti7MSeD+fVVEOGh3BOZzp/yF/6wPkPSGjd+unDi24mMocqCuF4vHtj2Q0em9OydmXfKFah8ELnYWFgAttHfc08iq7ELkAHqB7f8cnl/yz8603tYR5nd+UHQ50w1pT1vyAS8A39x6HNQxslrpf98app8ZoFud8gNOjG+Ei2+Z05hEL3UAemNY61gFSixkJv1YGFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M2iCgbCIsoW8ek4q1G5owfCjTWqZdu2I86kI10nIPJU=; b=JdWAjCIWefDCLQOc8uglC2Eiwuj01NoiNDCa0ftnXKMamiBrM6hXcvE2aIGC/EddAYYKawzmDyuWiNZHMtkXfbYxcKis4xSQI+MZvEhx003KyUIJa1k7/G/ZhevvoMarXqaNsRBUHXx9Ykr1Yhqk4oHB6/Y7lmcSLPtBKO33lT+R99fPNlauHLzSGQJBa3RsSXkGrUn4RgCq26Rjh9LDYcJQbq3ZBGT6Hmt4c03BPn74YZFUqNFOsk2Rq3jHPgnRRtzAakFkw2E3molQedJyW63QSEBLYjcxPJH8iJX1GVk7anHm8BCY4/gOIXJGSF72GRE6WlfFGeZKKoDPaK1TEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M2iCgbCIsoW8ek4q1G5owfCjTWqZdu2I86kI10nIPJU=; b=NZP/I159iORKrbdlGJmSsy22DbZyyNg8IRSA04We2htbwHSELew7FU6r5SBTIDETQHD+jcH30sHUIregIDw3uI2KHIvlpL7rPvEgPMagKL310SrmMNLONQnd4M9et1kiFb57uRheUyF8VejW/TOLtQFSycvfcDWHClsONnaIsMw= Received: from CH5PR05CA0008.namprd05.prod.outlook.com (2603:10b6:610:1f0::17) by LV3PR12MB9409.namprd12.prod.outlook.com (2603:10b6:408:21d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.18; Mon, 9 Dec 2024 18:53:17 +0000 Received: from CH1PEPF0000A34B.namprd04.prod.outlook.com (2603:10b6:610:1f0::4) by CH5PR05CA0008.outlook.office365.com (2603:10b6:610:1f0::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.11 via Frontend Transport; Mon, 9 Dec 2024 18:53:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH1PEPF0000A34B.mail.protection.outlook.com (10.167.244.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8230.7 via Frontend Transport; Mon, 9 Dec 2024 18:53:16 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 9 Dec 2024 12:53:15 -0600 From: Mario Limonciello To: "Gautham R . Shenoy" CC: Perry Yuan , , , Dhananjay Ugwekar , Mario Limonciello Subject: [PATCH v3 15/15] cpufreq/amd-pstate: Drop boost_state variable Date: Mon, 9 Dec 2024 12:52:48 -0600 Message-ID: <20241209185248.16301-16-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241209185248.16301-1-mario.limonciello@amd.com> References: <20241209185248.16301-1-mario.limonciello@amd.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A34B:EE_|LV3PR12MB9409:EE_ X-MS-Office365-Filtering-Correlation-Id: 14474434-b823-42cc-4962-08dd1882be0a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: eNmLjhPcD9nORovnbObWcTdExX5E92VZ4JEZQ9GOVFrqo7J2B4lq5QwwlWUmLoazpDqeA2Dv5wwYvYB3wYCooRoTUJQZsxrf8iM+tkloNeMaduwMObu0hk2dOZrkrVZzhDw72sAZLOk0eueF8spdJvFab+TiWZsIvrX32wVDP7iM/QKtSKdmn0Zbe6KzGHw5xDPDIhvF43q/XpOcsQkXQ1nNZ7HEZe+cij70h0umHtNiDVNKhJ734CI5udx88MFZYrvCrPuqZ+pr7vHQsEUI4vrDyzYIBsENxYKtoNwcn4UVEMp5PQuNwhSjmEYGbHI75B1O6kjLQaX/V4r+LvX9kE6cZSVB5LblE7/WsXIW4JaAQERkPHqOMAjKdtn3SKE9qDhH1uaYSVHlcIHmzod4u6JbzFGuQVviEBGKT/73qOor9ba1cQPE6f7+avl9vYZL4yb9OA4Rb0WNajC/qxM0vaDCBQPln6d8WRXuB6sz4zWSEMQBsQ8NVN/2slVPI7FCpYHm1MvPblg4E/do+edHZV8Zw68OO/Xc866yaRU7shd7a1lkN/6YWhX51GK2GLXEtJad+MvvDKsvd3L7B58Gk7xpvn4g0Iw4egaGGTcLUxGhKe+rfjpeKY6CDAkKXbFT5H/QHcB0bCOZEg072Fvj4i6Igioy3CQKTTcDwqwnyJwwXk+NfTjynQLeXOQjFHDhzUig0C3ZSBlLTjVjth54eCzW7tK+jSp7EB6nwtpG8vBvWF8tsLqhKTAJ6GxUxzvbtryBFAj4KzBPoMzqJ1TsTxuumDQeyp0p/KS/VYSaVDIt1XBIaAliBU7vpMON02qkX2Nvx/pb9b7RHWklfVy161xKsySax44eimw6WPbj8Si2NigkR92TCv7wEIYyXSUZbBrayvAUW3jXLQrLfTEVgTjXXctCfgXTDxYAWR/ZoxU9iK/ruGVQwAQMDywdDrLm6hH99Y0VpqascIQ1A4/91IZuxOBc9cvmItYup4yq1Cdrh9GWkfOzLoCIy1nOanR9FWZFHpg7VA0q3k7wN3bX+eBFJ+6JWxGkNjBhXX5IyiN9mQRqCKxFhUceiWqU90a/tC+b0rvK3U3fxItThZZPRZsDAA0cyN/IzO85IgFhOQPzZOfsEjRmfy4jsGetGoA6Paf69MASGHQUdGKagZyOaKA5Zm9FzWiR05uN90vvzgYBAQgCh0HFeLlBp02rnv4hv/++LZqUwvzMm+WywKwpa195wP27btw0gojdHZH3QPQJ6crs99nGOx3g/UaeC509PxX1FIeIZ3mU4dnYEyoJ238LeZ2K2skI/JmTve7B2AKhBnsP6Wr1a0DHx5rSyOBsNQPnysLRAo57i3ABRAj/mdVQ+dSALDa/2wywoJbM1jc28lo+ar3/qYROraoJ0u7r+oLxjLGur/M19CNxNXuHvAQ0UOJRFeeLQ2Ej/oRF3WEddjt1NbDBiAHSMm4Juz8H X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2024 18:53:16.8857 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14474434-b823-42cc-4962-08dd1882be0a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A34B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9409 Currently boost_state is cached for every processor in cpudata structure and driver boost state is set for every processor. Both of these aren't necessary as the driver only needs to set once and the policy stores whether boost is enabled. Move the driver boost setting to registration and adjust all references to cached value to pull from the policy instead. Reviewed-by: Gautham R. Shenoy Signed-off-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 26 +++++++++++++------------- drivers/cpufreq/amd-pstate.h | 1 - 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 308d30a25f100..f31703dbb754b 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -316,9 +316,10 @@ static int shmem_set_epp(struct amd_cpudata *cpudata, u32 epp) return ret; } -static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata, - int pref_index) +static int amd_pstate_set_energy_pref_index(struct cpufreq_policy *policy, + int pref_index) { + struct amd_cpudata *cpudata = policy->driver_data; int epp; if (!pref_index) @@ -336,7 +337,7 @@ static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata, epp, FIELD_GET(AMD_CPPC_MIN_PERF_MASK, cpudata->cppc_req_cached), FIELD_GET(AMD_CPPC_MAX_PERF_MASK, cpudata->cppc_req_cached), - cpudata->boost_state); + policy->boost_enabled); } return amd_pstate_set_epp(cpudata, epp); @@ -746,7 +747,6 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state) guard(mutex)(&amd_pstate_driver_lock); ret = amd_pstate_cpu_boost_update(policy, state); - WRITE_ONCE(cpudata->boost_state, !ret ? state : false); policy->boost_enabled = !ret ? state : false; refresh_frequency_limits(policy); @@ -768,9 +768,6 @@ static int amd_pstate_init_boost_support(struct amd_cpudata *cpudata) goto exit_err; } - /* at least one CPU supports CPB, even if others fail later on to set up */ - current_pstate_driver->boost_enabled = true; - ret = rdmsrl_on_cpu(cpudata->cpu, MSR_K7_HWCR, &boost_val); if (ret) { pr_err_once("failed to read initial CPU boost state!\n"); @@ -1176,7 +1173,6 @@ static ssize_t show_energy_performance_available_preferences( static ssize_t store_energy_performance_preference( struct cpufreq_policy *policy, const char *buf, size_t count) { - struct amd_cpudata *cpudata = policy->driver_data; char str_preference[21]; ssize_t ret; @@ -1190,7 +1186,7 @@ static ssize_t store_energy_performance_preference( guard(mutex)(&amd_pstate_limits_lock); - ret = amd_pstate_set_energy_pref_index(cpudata, ret); + ret = amd_pstate_set_energy_pref_index(policy, ret); return ret ? ret : count; } @@ -1265,6 +1261,9 @@ static int amd_pstate_register_driver(int mode) return ret; } + /* at least one CPU supports CPB */ + current_pstate_driver->boost_enabled = cpu_feature_enabled(X86_FEATURE_CPB); + ret = cpufreq_register_driver(current_pstate_driver); if (ret) { amd_pstate_driver_cleanup(); @@ -1604,8 +1603,9 @@ static int amd_pstate_epp_set_policy(struct cpufreq_policy *policy) return 0; } -static int amd_pstate_epp_reenable(struct amd_cpudata *cpudata) +static int amd_pstate_epp_reenable(struct cpufreq_policy *policy) { + struct amd_cpudata *cpudata = policy->driver_data; u64 max_perf; int ret; @@ -1619,7 +1619,7 @@ static int amd_pstate_epp_reenable(struct amd_cpudata *cpudata) trace_amd_pstate_epp_perf(cpudata->cpu, cpudata->highest_perf, cpudata->epp_cached, FIELD_GET(AMD_CPPC_MIN_PERF_MASK, cpudata->cppc_req_cached), - max_perf, cpudata->boost_state); + max_perf, policy->boost_enabled); } return amd_pstate_update_perf(cpudata, 0, 0, max_perf, cpudata->epp_cached, false); @@ -1632,7 +1632,7 @@ static int amd_pstate_epp_cpu_online(struct cpufreq_policy *policy) pr_debug("AMD CPU Core %d going online\n", cpudata->cpu); - ret = amd_pstate_epp_reenable(cpudata); + ret = amd_pstate_epp_reenable(policy); if (ret) return ret; cpudata->suspended = false; @@ -1690,7 +1690,7 @@ static int amd_pstate_epp_resume(struct cpufreq_policy *policy) guard(mutex)(&amd_pstate_limits_lock); /* enable amd pstate from suspend state*/ - amd_pstate_epp_reenable(cpudata); + amd_pstate_epp_reenable(policy); cpudata->suspended = false; } diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h index 7765c82f975c6..9747e3be6ceee 100644 --- a/drivers/cpufreq/amd-pstate.h +++ b/drivers/cpufreq/amd-pstate.h @@ -98,7 +98,6 @@ struct amd_cpudata { u64 cppc_cap1_cached; bool suspended; s16 epp_default; - bool boost_state; }; /*