From patchwork Fri Jan 10 18:12:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 856279 Delivered-To: patch@linaro.org Received: by 2002:a5d:525c:0:b0:385:e875:8a9e with SMTP id k28csp364448wrc; Fri, 10 Jan 2025 10:16:10 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU6ansoWiMDOwq62QydrB1RrV+EcHWWjBZdw6nk11OriLB5Rt+ynxS0smKdaOsL/4rkFar3gw==@linaro.org X-Google-Smtp-Source: AGHT+IHO7FK8jJBcAUJQ/SrKrEBnz7Q7nUBRk8ON1tAmIi77krQYuT7CSU9HzwLsmPA6K0GbPeQk X-Received: by 2002:a05:6102:3e0b:b0:4b2:48dd:aade with SMTP id ada2fe7eead31-4b3d0da25cemr12948853137.12.1736532970647; Fri, 10 Jan 2025 10:16:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1736532970; cv=pass; d=google.com; s=arc-20240605; b=kJgx5L1rY7kl1bMotnaPNveb3M9mY0kI2rtmipBTqsmQz4meEqysrMw4anQFtEBNyb EmK19b3rlUd6AkdqgvzssE7wGGIJxhYLfRXuS5RIHW9/ou/RVnDrrpzOITtePMyhyNpV 8nfmvuEVxKUiD07sRe3twHxClIP2Sc6BnkeLBMD7ETUg2FUi8Bu2X16VJYPgyMovcxgO ToTGycuhB8e2CWXurps3tkTCVq3JMzePaYJtx0XxVyOhfmv0dvclA0+2vdL5kzT7QIDm 1kqFEsgT55C1C1/IdvH3pN78J0Mnq9CgvRYShchk+hL/QvRXK5jenOD8ryWe4+A9cGVR 0e7A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-filter:arc-filter:dmarc-filter :delivered-to:dkim-filter; bh=N+bSfnCnJFwsJsd7ntcIRFcUszFo6hIdsthPVpz+IRA=; fh=d7KdQ+eBG5Owb97PZQUBRjccSsV/hB6hMlyGG6W37vA=; b=G0iAztRD6917yol6RIPb5NcBWGNUuYxgRQ529RgRRkY+nfomToNlHRNByWxxjt8dHB Qi7g/V+Kql1L2PN1RdWM0Z5nnSLPMjlPVbd6+RNh/6jjPhGyit3FmkG0EZhOO2EZMAJG FaLQjbV68zYBDWNPD26DOHb79Px/AQTLlfQWECW/SIX/DamkTFfi9DBiFX+IDb0U0bba Vk1UBC4bkpJn7sElirtWfrwm44wTeTgR2BzkHVTzIS5pzaVwbSlJskcOYFo8fx4iz+Q6 WqZueWx3JfaOS4x1rClOHZ6HjHsfwSKW6LjXrgkwkBu3s9T6v/K69VC52riu4aPvG4pC DBjQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FDsxlux0; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id ada2fe7eead31-4b60938223dsi1958224137.596.2025.01.10.10.16.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 10:16:10 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FDsxlux0; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 34DFB385828E for ; Fri, 10 Jan 2025 18:16:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 34DFB385828E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=FDsxlux0 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-vk1-xa35.google.com (mail-vk1-xa35.google.com [IPv6:2607:f8b0:4864:20::a35]) by sourceware.org (Postfix) with ESMTPS id AF6743858C35 for ; Fri, 10 Jan 2025 18:15:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF6743858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AF6743858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532916; cv=none; b=RwCM889DnZn3JbS/CYWIrdtxiDKmYBny6YdS/QDJ+CvaK/sK5H+FRIOAnRPkMxhLT3u1z+abGCz2zoCxeCZb32i35X97jzk8mBLqc9ecMcPAGHsqRFrMj9AjVIKlJeG+K+J++/PMYg603oYw16gC8THYnAW1x0S8yLrw9e+royI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532916; c=relaxed/simple; bh=HwlddIy+yuRcvrvvsXF9tW8UG2V7R/hOjcFram2805E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=p5gKxUy7P23nV8u5K6GsQM3Rumw0jcfeOFd4I5V9irBmdUhYpfpEwDJr7K6aXITCY1xlChU+eJCaQkCHhjJuNR5IT5QnM5TPmOHnR1wI5Yl8fzRl8NzEs/Fm4rRRe0JFVgVIQnoM88/f/9kGwlxzT0PasYRvLdRFB7dE20A2AsY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF6743858C35 Received: by mail-vk1-xa35.google.com with SMTP id 71dfb90a1353d-51bb029fdd1so1392772e0c.0 for ; Fri, 10 Jan 2025 10:15:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736532915; x=1737137715; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N+bSfnCnJFwsJsd7ntcIRFcUszFo6hIdsthPVpz+IRA=; b=FDsxlux0LKDX4EOeCkd7wSihZ/D/K13Bfk5ns1RvRXZyqJi7i70V9DHlex0Yj1haER R1YZD/j0RNNO9Bv5Yp9ZcpTJkPYT8IvNYTYl9bJSTpgicAw9cuxx7RNGx0r5jumKJFKk /eWQmB0jLK4D4eh9KsQuD9GhgyOKBk7sZYeTzKvPkAo90Ajs4bvRltTXLo+MbTyTDTCj vP8N7V9lfVAa172ZJ2pmJXgdtgU8MuW4BDbHRfDw0dkGd+WPPgUt4LJKeh/NhL3adlAd /ua8WWYd8OPh20r9lq+IjIRPR52dKcz9dNIjOMRUG1oeASB5Gddb9TbqrEfh0k2ANFgN Hm6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736532915; x=1737137715; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N+bSfnCnJFwsJsd7ntcIRFcUszFo6hIdsthPVpz+IRA=; b=rqtdM3hcxI/4nbAuVyqp5pRzbrnpklztn1he5Fp4CQOjdouLCmt46wcoxeRDu5Nkr6 0aCbfcEzi3NI/vDAXNtwyZoVIhGYwlFt/YBkMXd9J941bAtQznHP1Va2e2oA24YKOu/C LwtbCMOwDCBQQvyss3weRrNRke2UGOtHDvMAf7JJ0d/mO5mFhpQc9xCzSdLaXguKIJi9 25+YSr4IObfvj3rwZoQvUFwMQXSmkigN24SoIOmWess5qqe/hxpUA7somNMcC+JFfuEr +h27YNZ2KipSaStUKlMzWcjP75BhWBXqXn0hb/NmBivgGe9panHvHrHc81sQ3yqdQLIz f3xw== X-Gm-Message-State: AOJu0YwLhQiQaSI4pNt17eGn63fB1AZnKSkLqIXK46MgCu3jTCh7GDWE UZdUT25wcPkiUJMf/AGGGDZU95sDNzhk+Bqf893qcEG7TOfsiw6IAJxaHXzlYShYaSYHatPZYCk + X-Gm-Gg: ASbGncs2uExrVczG0T3SQxW6xTSyM+x9+BcpXwMjGZ9yYJdrHyzNj83jl36QAtaGLjD SWf2QYXuh9iygl8U0+LVAEMUd2QkF8V8HFGqw/eUxxJhKCAJ1zlS39BApD5IML9MD2Lx9lMqx4t R6abunm+83NtOl29RzULvFleKnqlcp5TMLryMufdeyFGDC/iPFgyvgn1gQjy0uUEhjtRUd1kFRa +0R8tOEvqt/Ts9A2ukvrjQv2qByqYt1fRSdY9mjgziAs3LW2yxiJOC1SyvieWBnuTDRtw== X-Received: by 2002:a05:6122:8f82:b0:515:f586:5298 with SMTP id 71dfb90a1353d-51c6c3237c2mr12005512e0c.7.1736532915630; Fri, 10 Jan 2025 10:15:15 -0800 (PST) Received: from ubuntu-vm.. ([191.23.120.207]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-51c7fb9d621sm2469139e0c.1.2025.01.10.10.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 10:15:14 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org Cc: Sam James , "H . J . Lu" Subject: [PATCH v2 1/4] aarch64: Use 64-bit variable to access the special registers Date: Fri, 10 Jan 2025 15:12:11 -0300 Message-ID: <20250110181508.350378-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250110181508.350378-1-adhemerval.zanella@linaro.org> References: <20250110181508.350378-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patch=linaro.org@sourceware.org clang issues: error: value size does not match register size specified by the constraint and modifier [-Werror,-Wasm-operand-widths] while tryng to use 32 bit variables with 'mrs' to get/set the fpsr, dczid_el0, and ctr. --- sysdeps/aarch64/fpu/fpu_control.h | 36 +++++++++++++------ sysdeps/aarch64/fpu/fraiseexcpt.c | 3 +- sysdeps/aarch64/sfp-machine.h | 2 +- .../unix/sysv/linux/aarch64/cpu-features.c | 2 +- sysdeps/unix/sysv/linux/aarch64/sysconf.c | 2 +- 5 files changed, 30 insertions(+), 15 deletions(-) diff --git a/sysdeps/aarch64/fpu/fpu_control.h b/sysdeps/aarch64/fpu/fpu_control.h index 5df6da3ffc..a93dbf5efa 100644 --- a/sysdeps/aarch64/fpu/fpu_control.h +++ b/sysdeps/aarch64/fpu/fpu_control.h @@ -29,17 +29,31 @@ # define _FPU_GETFPSR(fpsr) (fpsr = __builtin_aarch64_get_fpsr ()) # define _FPU_SETFPSR(fpsr) __builtin_aarch64_set_fpsr (fpsr) #else -# define _FPU_GETCW(fpcr) \ - __asm__ __volatile__ ("mrs %0, fpcr" : "=r" (fpcr)) - -# define _FPU_SETCW(fpcr) \ - __asm__ __volatile__ ("msr fpcr, %0" : : "r" (fpcr)) - -# define _FPU_GETFPSR(fpsr) \ - __asm__ __volatile__ ("mrs %0, fpsr" : "=r" (fpsr)) - -# define _FPU_SETFPSR(fpsr) \ - __asm__ __volatile__ ("msr fpsr, %0" : : "r" (fpsr)) +# define _FPU_GETCW(fpcr) \ + ({ \ + __uint64_t __fpcr; \ + __asm__ __volatile__ ("mrs %0, fpcr" : "=r" (__fpcr)); \ + fpcr = __fpcr; \ + }) + +# define _FPU_SETCW(fpcr) \ + ({ \ + __uint64_t __fpcr = fpcr; \ + __asm__ __volatile__ ("msr fpcr, %0" : : "r" (__fpcr)); \ + }) + +# define _FPU_GETFPSR(fpsr) \ + ({ \ + __uint64_t __fpsr; \ + __asm__ __volatile__ ("mrs %0, fpsr" : "=r" (__fpsr)); \ + fpsr = __fpsr; \ + }) + +# define _FPU_SETFPSR(fpsr) \ + ({ \ + __uint64_t __fpsr = fpsr; \ + __asm__ __volatile__ ("msr fpsr, %0" : : "r" (__fpsr)); \ + }) #endif /* Reserved bits should be preserved when modifying register diff --git a/sysdeps/aarch64/fpu/fraiseexcpt.c b/sysdeps/aarch64/fpu/fraiseexcpt.c index bf5862a56e..518a6eb321 100644 --- a/sysdeps/aarch64/fpu/fraiseexcpt.c +++ b/sysdeps/aarch64/fpu/fraiseexcpt.c @@ -19,11 +19,12 @@ #include #include #include +#include int __feraiseexcept (int excepts) { - int fpsr; + uint64_t fpsr; const float fp_zero = 0.0; const float fp_one = 1.0; const float fp_max = FLT_MAX; diff --git a/sysdeps/aarch64/sfp-machine.h b/sysdeps/aarch64/sfp-machine.h index a9ecdbf961..b41a9462df 100644 --- a/sysdeps/aarch64/sfp-machine.h +++ b/sysdeps/aarch64/sfp-machine.h @@ -74,7 +74,7 @@ do { \ const float fp_1e32 = 1.0e32f; \ const float fp_zero = 0.0; \ const float fp_one = 1.0; \ - unsigned fpsr; \ + uint64_t fpsr; \ if (_fex & FP_EX_INVALID) \ { \ __asm__ __volatile__ ("fdiv\ts0, %s0, %s0" \ diff --git a/sysdeps/unix/sysv/linux/aarch64/cpu-features.c b/sysdeps/unix/sysv/linux/aarch64/cpu-features.c index 26cf6d4a56..7ac228303f 100644 --- a/sysdeps/unix/sysv/linux/aarch64/cpu-features.c +++ b/sysdeps/unix/sysv/linux/aarch64/cpu-features.c @@ -128,7 +128,7 @@ init_cpu_features (struct cpu_features *cpu_features) cpu_features->midr_el1 = midr; /* Check if ZVA is enabled. */ - unsigned dczid; + uint64_t dczid; asm volatile ("mrs %0, dczid_el0" : "=r"(dczid)); if ((dczid & DCZID_DZP_MASK) == 0) diff --git a/sysdeps/unix/sysv/linux/aarch64/sysconf.c b/sysdeps/unix/sysv/linux/aarch64/sysconf.c index c0df3af28c..bca2e0d286 100644 --- a/sysdeps/unix/sysv/linux/aarch64/sysconf.c +++ b/sysdeps/unix/sysv/linux/aarch64/sysconf.c @@ -27,7 +27,7 @@ static long int linux_sysconf (int name); long int __sysconf (int name) { - unsigned ctr; + unsigned long int ctr; /* Unfortunately, the registers that contain the actual cache info (CCSIDR_EL1, CLIDR_EL1, and CSSELR_EL1) are protected by the Linux From patchwork Fri Jan 10 18:12:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 856281 Delivered-To: patch@linaro.org Received: by 2002:a5d:525c:0:b0:385:e875:8a9e with SMTP id k28csp366034wrc; Fri, 10 Jan 2025 10:19:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU9LqSZ2lqOtoGPjz4tyIkk/llUur65pVzV0EjTPyQywGhxcAXU6T5FqnndR0mEflLy47VZEQ==@linaro.org X-Google-Smtp-Source: AGHT+IEFsXf0+BuJE0gYXFCUpGObbkd0wE7NhE64D32qujd9+I8+8c0vGfR2oFtEXbMM4eNV6die X-Received: by 2002:a05:6102:1491:b0:4af:597b:ef with SMTP id ada2fe7eead31-4b3d0d9fcd1mr12793991137.8.1736533190068; Fri, 10 Jan 2025 10:19:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1736533190; cv=pass; d=google.com; s=arc-20240605; b=egpAmeQO5WkRIq3AM8coGDVvxKGeq8BMCeMaCaxkgNVE+X0KEyso36UTlG6j21T5TE 05aWiqbCfKqvuimQUA1DlW1ldpMeGx3OfvSyK0kbKSbGnYXgh8jcd+2HFeEiiwruFhhI LKjedN8VsRvhvsrJGAq8cwdx4+0X+R1NzcqVAxdbeJow3n3vevIkPWeAfgZDC7RYLGQx Y/E3K0gqHLVEHy+/2RN4OgAXNQ9jSEuYKWH+mFJKpZQBj/f9dHzXTErrFT5Vd8bp49TR RYD0T1UN+3mYiK2UEo3iPGPCw/KaeG8AeCIe8NualUVJ4wOzQRSopPBivnzPANsdelRd tGJg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-filter:arc-filter:dmarc-filter :delivered-to:dkim-filter; bh=XG0M8KDGOWezxvWHSSa73QDz5+gfIyEuB7XPIA0kOvU=; fh=d7KdQ+eBG5Owb97PZQUBRjccSsV/hB6hMlyGG6W37vA=; b=CA3mxhhRTB2w/WtCfcSWrajAhaW6CtVFKWwU7q7AhWxrnRKMwRnTYY3J3PvFwKKAfI 5KUF7C2ajvwEWpVFcf4lNC/YNXq0KcQBExwQShSw8ikRuJfKpPFDLZaxMM0MsVTMalcx scs6RZPNHioJxT9Pd+dFMQyD84bj1cjWyydW8cVU+c+7GCUrca9aIdll8JYaKL7IS9Bb l9zQETq9XzmvNVvouDONNmzLY3M2DVYCnKQThz/SSrGjI+lS9lcNjgDsqBh1XeHUQTC4 KGl67j25LyntLGJ+qLKiwbcKNGHnBlQqk7a19V8USUzsBXsSUrG9xq7o/ZbJoDJksAyZ GesA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E7F0o7+Y; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ada2fe7eead31-4b608fb2df9si1637853137.38.2025.01.10.10.19.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 10:19:50 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E7F0o7+Y; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 94ECD3858402 for ; Fri, 10 Jan 2025 18:19:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 94ECD3858402 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=E7F0o7+Y X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-vk1-xa2e.google.com (mail-vk1-xa2e.google.com [IPv6:2607:f8b0:4864:20::a2e]) by sourceware.org (Postfix) with ESMTPS id 06FE33858432 for ; Fri, 10 Jan 2025 18:15:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 06FE33858432 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 06FE33858432 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532920; cv=none; b=F/8bXfWJY2/ZTa1DICySsqVJq6Klla8wOat53FEa1DL/urrnCyBPRx1wplriS7cNT2ndgdcubX9xj0APe+k451tB51LorHyj66iC7PXdYwXYHa2LSHxBYOK+sYrZ1mCrdopU+uC56I4ExJ4HJ1ZrgDqWOHvHyYJtpMqxJzOAknI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532920; c=relaxed/simple; bh=DI16Ch1J3hsp5yY7yMSzEVqocLMGO4TFsWOoC3MMDeY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=uLhjHfiKaWp3Rr9lK8rRYyD5ZtkxpoDYmmnyVHuk4Hnhfg718YA+DnSeWkrM73FzkSzUXVoz8W0Ah+0pGQqdn1+1ohVdyx7Sm+C+CWO8ApzwpwmW5QJpHz4s8R0Fp8Z0J2o3z7cHX24A3s/L2D5qEcmsCJUb9h820AjIwb5iV04= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 06FE33858432 Received: by mail-vk1-xa2e.google.com with SMTP id 71dfb90a1353d-51c4bc9cd19so1291724e0c.3 for ; Fri, 10 Jan 2025 10:15:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736532919; x=1737137719; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XG0M8KDGOWezxvWHSSa73QDz5+gfIyEuB7XPIA0kOvU=; b=E7F0o7+YoeT4UPfTjnxTtqO9PHzg6sc0nlA672ObWtGw3jWnS36TgJWuBuLbf+6wgA UxfpqyAz0U99Yb4XptM/bszYe1i9T6pCAPVhDpQ/wQJB6jo0Hw9XKgA2Ku1lSxDpnxS2 GgEYbJzxeglYPamolUwRdEkLXGtG0EsB594X/enCcqH0GvDb3bXaGnKUJoqARM69OdLw kadcYyd7SRrg/usMkwLW6B+6LD3eB7MYYYGZmhk66veA7HdFc6fDsmq4RMdSF7sX7ISZ nYo+m/UkY6sqd0cMGulUi/IMUMKNXna+kZf2CiiLIhccJqWVz7CIZuFqRxNAabMrTBxm cvbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736532919; x=1737137719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XG0M8KDGOWezxvWHSSa73QDz5+gfIyEuB7XPIA0kOvU=; b=eTX7E6fqUFxSiDy/vaF7+O1sKEMvbONprRSlAnyCR1Q4GR5r+WTKTXTOiqBoRGs3Uq F+fI8H8CoUgkwYnHEb37apcAlBTfqF1RFA16wwUqy5Wd9TQP+mb1RH63oav9mB4qxz9R wBDL80HszUkWb9jBMNjjWrkcFhXCDPVoidSAcYt+yYD5slEgm98KNuWkJmeBFqECr/1O RjgGo2th6oA9THfL566rthhaPs1R9WdVHil0voNxYaZYvLNUWIdj0iivIZ+mka+WFEGm /W56Jpb+EHjW0WHq/tv6OE79sFKHRrqUkHVsUln1Ad2njEPafYyfO56gaTBZ9ghGnWyT kUFQ== X-Gm-Message-State: AOJu0YzYj1jUKk0+Ie9CbDlnS4/nIWs1TCNdUk85+HAoWYs+2jbCp8E6 bY3Fm7RSnTPAJeq/FHw01YnQpML7/uKWTvO8GoBLfxR+gzmoHZpkC4EqDg6UQ7/eDEqTeLYb0GT R X-Gm-Gg: ASbGncvpJpIE/Keg0R3Pqx3WVAENjjzMdRC4XewEfWvN0IkWqMIE16EDXVN6hfxVZyi UgkhJdA8kgxHx4D4ncQQIQ7yY5OnDpwst68cLtmbsMCNt6mI4EF/LWPQSNlJtX+BRT+g4YWtFGa gX3keDVCQiJd1GZZjKdcurAKkWoUhGnKZ6wqBEx4lSOnESr100XQ3vcxO2dgt0S0iNpRw4jtm9B 9Mp1P5n5UiEhYc0UL7vEVqVA88fdV+ZwKTgtfZOtrUbgYXR2+aQpSmHO4gXg3f9IBdUOA== X-Received: by 2002:a05:6122:8f82:b0:515:f586:5298 with SMTP id 71dfb90a1353d-51c6c3237c2mr12006190e0c.7.1736532918859; Fri, 10 Jan 2025 10:15:18 -0800 (PST) Received: from ubuntu-vm.. ([191.23.120.207]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-51c7fb9d621sm2469139e0c.1.2025.01.10.10.15.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 10:15:17 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org Cc: Sam James , "H . J . Lu" Subject: [PATCH v2 2/4] gmon: Disable tst-profile-static with clang Date: Fri, 10 Jan 2025 15:12:12 -0300 Message-ID: <20250110181508.350378-3-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250110181508.350378-1-adhemerval.zanella@linaro.org> References: <20250110181508.350378-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patch=linaro.org@sourceware.org clang does not support -profile: clang: error: unknown argument '-profile'; did you mean '-fprofile'? --- gmon/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gmon/Makefile b/gmon/Makefile index 6e39366a0c..26051ed2fb 100644 --- a/gmon/Makefile +++ b/gmon/Makefile @@ -42,7 +42,8 @@ tests = \ tst-mcount-overflow \ tst-sprofil \ # tests -ifeq ($(build-profile),yes) +# clang does not support -profile to instruct linker to use lc_p +ifeq ($(build-profile)$(have-test-clang),yesno) tests += tst-profile-static tests-static += tst-profile-static From patchwork Fri Jan 10 18:12:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 856278 Delivered-To: patch@linaro.org Received: by 2002:a5d:525c:0:b0:385:e875:8a9e with SMTP id k28csp364401wrc; Fri, 10 Jan 2025 10:16:04 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWd66fgte3Z7yGSRK5BtQ8KNe8bq9L3JzsSkEGCE2ugvS0DSBxCDEfIjZ8nrGe9mdN+ARrOHg==@linaro.org X-Google-Smtp-Source: AGHT+IE39zZIZjAoO9Ia6DcZeQT1H0zIWqW7pSPVnkfhujXnYuKUjNwdUjftdkLvWVePazXa1lOk X-Received: by 2002:a05:6122:6594:b0:518:7ab7:afbc with SMTP id 71dfb90a1353d-51c6c526332mr11830347e0c.7.1736532964094; Fri, 10 Jan 2025 10:16:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1736532964; cv=pass; d=google.com; s=arc-20240605; b=L1mvTK//tLaAjEsoAwZ9F54FPG32LnMy1pBRZ2aBqmKAEVpuMM7HLGIU8cNmPHlnRS ekiVGHDPMaUbjRK85p3XJ9y8X8USlMd++3w5Wlkm258hixrn+yzlns6znWlpotWWANnM FWXYMg6ZRtb4f8dsLsNR2ubWH1/og7/gDzwlt4bJur/bZ7f2EwDMy9jZzTj+YwKPV+R+ l7ZeSF5w0yw5n53MhOqgJo9eJJqliZF8beeOKjCKHCWUrzYMxpHkp7G3XGe7bRXC5+Ee g/jzbiNx9EqnoOsj/kjDSnHPp0pxN+h3+9OT1Oiv8WE2aFV5zdkL2ZrQHj+14J1HxG1l WoQA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-filter:arc-filter:dmarc-filter :delivered-to:dkim-filter; bh=4HDh5thW83Ip18sHqW3EDn+UqnXebLtL8s45M0CkvRY=; fh=d7KdQ+eBG5Owb97PZQUBRjccSsV/hB6hMlyGG6W37vA=; b=I3RLcRZG2vbT+Fh6oWH4xTV6hjCzXliCv59JznrN0/r0LEDhOE2+von+B6zuJwSZY1 DpTJ3NArZGADbGbEG5hmVIw1E3QaB1VB4+gBAGKhXKBy9xWJb0hfC11UISTm618o7MUh SXfckDVQxuJw7yxJnD1SF3bzzW838QHcT99LUk5IXP4IfyrHUapOrefjJIxzVbJAotXl f8JpVPEDr3YzmdHyMZOO+c2wwDUK4PnIwIcspcBRe8Qs8AjCpP9rwwXDPRZge9ReuA1B +Ktua+ZBx5Gw/9TUOQ1le0DMKKvMejPkCzaiJPMwp1c2LVZu7NPYEnfJwm7HVFtwOeYp HvdQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Zdu/R3pW"; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id 71dfb90a1353d-51c7fea15dbsi1943945e0c.219.2025.01.10.10.16.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 10:16:04 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Zdu/R3pW"; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6EE043858427 for ; Fri, 10 Jan 2025 18:15:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6EE043858427 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Zdu/R3pW X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com [IPv6:2607:f8b0:4864:20::a34]) by sourceware.org (Postfix) with ESMTPS id 0BCD23858CD9 for ; Fri, 10 Jan 2025 18:15:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0BCD23858CD9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0BCD23858CD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532922; cv=none; b=Sc+ZdFFOJ6fLNnA0lGgd0W2heGalpt7aTz66ZY677NxzW8aQ2bnIa02FkHMOQqt4gyNEb60RGghDHSiCkkyJrcM7TLnP6p2Ndm7NKjJupsSI0uZuWUa/b+UhUXsk57KObNj+Vm3TicHAiQc5yklZbAozTD8QWKitUl5hyAlyEYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532922; c=relaxed/simple; bh=N9LeVp+z32K4quAHKWPeuUpmSImw06bIY0asYrDTaA4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aUfgcz1qHroMCcT66eQiyqUUT6TQ00ePlM3FUslUWAlKMrjCsdA69Ss/CqyRFA79w1n/UWBhIWcPO2mBLIVZzT3UPEPuelQm8nNNBmMa6nVe7Aa6Y1Cf/Si7YBMi65nknfPt91Js6kWFnBe1HlDvUGQhaayDdWrjuR8BLnAuC8g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0BCD23858CD9 Received: by mail-vk1-xa34.google.com with SMTP id 71dfb90a1353d-51640f7bbd3so855427e0c.2 for ; Fri, 10 Jan 2025 10:15:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736532921; x=1737137721; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4HDh5thW83Ip18sHqW3EDn+UqnXebLtL8s45M0CkvRY=; b=Zdu/R3pWWDRc+yGPK6iWoatGDSfGEEPAWGqScGhtvumGIdEa5zuWVe989/1PqLjTry a9lwKDEvP2KRF1ZI7Kf5i6jLclnt2VF2ffT/X2J0r3grYnNyjs2EK3ni+QtMJz0Pc3Qm pSJX378vQ03hMosg3zDK9rw5AOvfY/nlKZubVrpymT7aCs5yizK1r8ECw5tC3mlMf1YO OA7U8FM7RjXD4ElGnYjaqtlHYX+Q3j0tFYX0Qm+xwuMrQ8cwiezvkSlaMXBuWK9Hcko+ G8tckprHh7x/fKYNM/NECyAfHcPHfT8HxC+M9hPrCY7HL+oY4uGanyBICTtJRhoqakDn VEtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736532921; x=1737137721; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4HDh5thW83Ip18sHqW3EDn+UqnXebLtL8s45M0CkvRY=; b=Sr//8wACsR9H8FhfvjgeLLk2cic9y8mPLGzyK8NkZ4KllSsrXrIF1E2fGd68S5sciY KvM/FGOWIkCjfI5W+DNM9LvyPQyeJkJhwKFikxnNkyplj4jzng78aaVToFJWNZzJcBQr 7yora4Sbx+edd7osQREixs301P+NMVMrCdfetWT1lIKBEncDIbhyh4yC7VINBVNJd38c pAwcNq+ujS6OF0iQv53oRFpCR3NHNb4MbjJOG0Zh1CHEOmYbtMhlKg7WeqpkMXBS8ii6 J/UU2xe34v6cLjrfJVGmzwpZ60D4PRuMeAms//r95kzypo+Pam9pbyhDQOZJJPgwJMCC 1W2A== X-Gm-Message-State: AOJu0YyAU54Xu9EBXr47Hsx14ExlBZ1j07A5bOopByxtbq9nj+6btQPC l5yJuE4JOZMgUCH65s/jwwjlcp/X75Gkml6Wb4JP4UQ1DicqggoKssCALkPTOnqqPYYApTZ8jd3 N X-Gm-Gg: ASbGncv/WZSQ/kBkZif6qMV5TThrKPrCUXAaZkIAFMjudxkYJRDPe3qe1KURWZ7iOzd Zc7W7+kbLUUxanr3SL2FMVKlymqzQvVhwnxkFhNmqIp709PczKVXxOLKJlpw+JFHv86QQEaxLk5 /uLUDZ54Uqw7ePgbFnJ0CPh4zTH7fjHTfepr9vKXakPXNrSmaJFqRop/R3qgj4TzXSQZ2SEPKMH zT4RZ9RmT1qVUBxR5/UcqTVgLPc41vLaWSN0sq195KFJoG4BirhgPqrm8U69KOYoX4sDw== X-Received: by 2002:a05:6122:318a:b0:50c:4707:df0 with SMTP id 71dfb90a1353d-51c6c464f01mr11244687e0c.5.1736532920918; Fri, 10 Jan 2025 10:15:20 -0800 (PST) Received: from ubuntu-vm.. ([191.23.120.207]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-51c7fb9d621sm2469139e0c.1.2025.01.10.10.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 10:15:20 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org Cc: Sam James , "H . J . Lu" Subject: [PATCH v2 3/4] elf: Suppress unused function clang for __ifunc_resolver Date: Fri, 10 Jan 2025 15:12:13 -0300 Message-ID: <20250110181508.350378-4-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250110181508.350378-1-adhemerval.zanella@linaro.org> References: <20250110181508.350378-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patch=linaro.org@sourceware.org The __ifunc_resolver macro expands to: extern __typeof (__redirect_name) name __attribute__ ((ifunc ("iname_ifunc"))); static __typeof (__redirect_name) *name_ifunc (void) { [...] }; And although NAME_IFUNC is and alias for NAME, clang-18 still emits an 'unused function 'name_ifunc' [-Werror,-Wunused-function]' warning. --- elf/ifuncmain9.c | 4 ++++ elf/tst-ifunc-fault-lazy.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c index b2c9547db3..64539b4a86 100644 --- a/elf/ifuncmain9.c +++ b/elf/ifuncmain9.c @@ -22,6 +22,7 @@ #include #include +#include #if __GNUC_PREREQ (5, 5) /* Do not use the test framework, so that the process setup is not @@ -41,6 +42,8 @@ implementation (void) return random_constant; } +DIAG_PUSH_NEEDS_COMMENT_CLANG; +DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wunused-function"); static __typeof__ (implementation) * inhibit_stack_protector resolver (void) @@ -50,6 +53,7 @@ resolver (void) } static int magic (void) __attribute__ ((ifunc ("resolver"))); +DIAG_POP_NEEDS_COMMENT_CLANG; int main (void) diff --git a/elf/tst-ifunc-fault-lazy.c b/elf/tst-ifunc-fault-lazy.c index c86edde06c..072d2c6a7b 100644 --- a/elf/tst-ifunc-fault-lazy.c +++ b/elf/tst-ifunc-fault-lazy.c @@ -21,6 +21,7 @@ relocations. */ #include +#include #ifdef HAVE_GCC_IFUNC @@ -34,6 +35,8 @@ implementation (void) *p = 0; } +DIAG_PUSH_NEEDS_COMMENT_CLANG; +DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wunused-function"); static __typeof__ (implementation) * resolver (void) { @@ -42,6 +45,7 @@ resolver (void) *p = 0; return implementation; } +DIAG_POP_NEEDS_COMMENT_CLANG; static void magic (void) __attribute__ ((ifunc ("resolver"))); From patchwork Fri Jan 10 18:12:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 856282 Delivered-To: patch@linaro.org Received: by 2002:a5d:525c:0:b0:385:e875:8a9e with SMTP id k28csp366617wrc; Fri, 10 Jan 2025 10:21:14 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXVu4iZ7sD+DUdTX34VCnEftrhHYXkM+w85DOAMgjw92wnNVcXA8y8RQF9+axqfxqXeS1TF6A==@linaro.org X-Google-Smtp-Source: AGHT+IFRllqwxB3HNswkFPQrOsii2ohJNB50Eb12rocMl+V6yk0XfL0PAf1H3zf+Nd3t6aHQ2Atl X-Received: by 2002:a05:6102:94a:b0:4b2:bceb:1ac6 with SMTP id ada2fe7eead31-4b3d0e5f60amr12405341137.17.1736533274310; Fri, 10 Jan 2025 10:21:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1736533274; cv=pass; d=google.com; s=arc-20240605; b=Yc/o6uZBnSMdTgTwsimv5Y87XAaAQuE7+C6wYHsu3pgR/8s8R9CCVYbhi3rBwuF30C 2dIE09wSu1JJ5GvssXxLwwv8cY7DqQkkcShUldNK26f18opRd0oFw/UBFHc7vdQ1gZuq 3UhGovi6znVNGkoDGODVcAbWQury7/hrOEAatufG10ek9zfyuGdy4ck0oykZUHi4eQC4 Cs3nwulMwQtgnskwV3uFuRMwKgsoh143t4f0e5+uhcY6G75/a+qwMItRNhMub3TJLX3F NArcvx34iAKLvMANwkQy60uCD9iD5drfjupEkHcjtRpn0Hdp5KMKgy2HrdZCrgVFwVF6 ONNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dkim-filter:arc-filter:dmarc-filter :delivered-to:dkim-filter; bh=gmAaSuT0ipWqpxpmqeUSjAJI5n1R9I1Bv5E0fJQtBCM=; fh=d7KdQ+eBG5Owb97PZQUBRjccSsV/hB6hMlyGG6W37vA=; b=G0k+tlI76HOt3pt/hFOjM9/Icgqdfs3SoMzNoi4rp9nfsw96v0c0h+xNiqERDb9VyI 56+aPJAhYpMHo2JuNl3qkaEwbv6gSTbQnix5HUZWlFlgacram+YZfYhAv3Q9VN32Fb2x vWOkuTCfyVGbhX70ES1ualKtEzJiripWlFOosysiM+B4wPLtXF8/qQJV2Sf4ZqWCwpaQ YtKfUHI9ExxwIxhXvgSmmm3J6oN5TPZRNqhISBIc+vvhgSyNiMLbR3bXjao3fE5Zq0+t Whb9NyP/1ssWLDcSL92b7qysnPFbb0xPDMXTZzI/0LmxHOLgD8SFJPIIgu6xpS6XCcdp NC3A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BT7Cjz4d; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ada2fe7eead31-4b608ff7272si367623137.189.2025.01.10.10.21.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 10:21:14 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BT7Cjz4d; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32EA53858C35 for ; Fri, 10 Jan 2025 18:21:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32EA53858C35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=BT7Cjz4d X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) by sourceware.org (Postfix) with ESMTPS id 592B13858402 for ; Fri, 10 Jan 2025 18:15:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 592B13858402 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 592B13858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532924; cv=none; b=ICxn5VpyfFinJtJct/OO1ldZEyZqpzdlq/RJyGpsEwJCSM/IErckEY3av2l36sA4of9pf1l0cRaunlRiDVOKtKySoSR7rifU6tldGy/6WH3hforOhVS+RiFDn+QRbGQ234fILYV7jfzcwwtYlF9BIoiJqPiAXx0OI5u1Sbmqt+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532924; c=relaxed/simple; bh=xvyKptPaMqeV4HdIjwp1BwA2j9M9zcmJ8FdYktH9Rzo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ek8BTnEdMDLGp7n0s4wdtoHDL2gsP2SU/FJODKYyr6peRp52bTGgcDFyBHqPZbki4vpxt7VT/n54gbjVVIAfyqaTht0eeNgH24X01pgHrd7qwxs+KEvSr8+sG2l3JYn9hxC0Yiia005kWUm3yAojxwcUVHGwMrq4gcoVQAEF1dg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 592B13858402 Received: by mail-vk1-xa2c.google.com with SMTP id 71dfb90a1353d-51889930cb1so779430e0c.0 for ; Fri, 10 Jan 2025 10:15:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736532923; x=1737137723; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gmAaSuT0ipWqpxpmqeUSjAJI5n1R9I1Bv5E0fJQtBCM=; b=BT7Cjz4dBp/k/IelDhG3uWgBUo2pMwQ0MlMJtdOFcX0lEdkdNrmsFu85Pg0VsE8ny9 eWT6l+MNDsxt292eSb9vOKtHGrz6tkxpQeRfth26I7QAQqLkcBv8V2Oc0rMvJzvPuwXV m6PZSAxAO2W7vqNYCCRPjbxStbFO6pUcRgv6s9m50XnNID2+3bjhzOFp+os3FymYapbm 8S6XkhXzNZeJWJYQACn4X9D6bslTp2FC7OI0iLS4nKGJybImAY4xbrWhwfkx8oFbU7bF vSAugc0Im1xVwPbW5Gu9rHKW/NrTqsxeq+jNJGhAN9wyO0mflX++gjVwm7a9ITI18lXH OhOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736532923; x=1737137723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gmAaSuT0ipWqpxpmqeUSjAJI5n1R9I1Bv5E0fJQtBCM=; b=Vgh/Lwi6/EjnZpvzr7tOS3h985Q16rJDDK2vKf+OfmcrTDDaMIrvJKceggIL5fLcGi y7KAfXovnevHPaZuTC5+j+TA/himq6T/AJG69L5+QMwmiM7SH8jGUCVUPqC3dO7jLnB0 0PLfKs7o2Yekj9FV1T9/A3wM/gtN56xOvabCGq5szMK/czQTdWtn6OQMA+2PGOhPzqcN 5viMQ+hKl0Y/b5GXi1uZnb2kexHJUHZM6c4Lm1lDH7kD1aWBnM1BXuKMpW5drB+5Hnse I2Kemxux4WU7Gq8BujG3KJNKq8j4AjFbIQ1APEqOqReBSCuin8jI0Nfz6zQUEmytqBTQ OACA== X-Gm-Message-State: AOJu0YySogYqKfznj0qXb7pXW7i+UqnGdmEFkPXfHF/xwzwWKH3k2870 n/vAN4pntv2Fgi9TVKUgroxga7y91XL8kKe2Pddx1u0FNxw1Y5TJDQS66E+OGNg7X2uaa11U8uM s X-Gm-Gg: ASbGncv6SjjIe+YcUU9WLZT1/6J8MO6Uq3qXGv3rtRDCsjPHOB2Lt8lIIszBN9QktjJ OV86ANUlzE4rxAg1B4odwvM+qsgO/6FLnAzAFXq6QHIObnepEzdt17kSMpiKQ4i5t8iVDq2ziwH F4fqVO1KPEwSWIcia0Ii6shzLvr0RVyq2Fmw8r8Ce1xoVvaXCeo/uBVwmIRYtr4P7dnra95JZwi wNq8SmAWNF21Hu5JVt5CZAgZnx4BFBcn1uJNSv/fqhrnDGmpF4BRyiBrFYY+8498cojkg== X-Received: by 2002:a05:6122:a29:b0:515:ed1b:e6dd with SMTP id 71dfb90a1353d-51c6c2b5573mr10866286e0c.0.1736532923309; Fri, 10 Jan 2025 10:15:23 -0800 (PST) Received: from ubuntu-vm.. ([191.23.120.207]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-51c7fb9d621sm2469139e0c.1.2025.01.10.10.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 10:15:22 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org Cc: Sam James , "H . J . Lu" Subject: [PATCH v2 4/4] stdio-common: Suppress Clang warnings on scanf13.c with fortify enable Date: Fri, 10 Jan 2025 15:12:14 -0300 Message-ID: <20250110181508.350378-5-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250110181508.350378-1-adhemerval.zanella@linaro.org> References: <20250110181508.350378-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patch=linaro.org@sourceware.org clang-19 shows: scanf13.c:28:40: error: 'sscanf' may overflow; destination buffer in argument 4 has size 8, but the corresponding specifier may require size 11 [-Werror,-Wfortify-source] 28 | "A%ms%10ms%4m[bcd]%4mcB", &sp1, &sp2, &sp3, &sp4) != 4) | ^ scanf13.c:94:34: error: 'sscanf' may overflow; destination buffer in argument 3 has size 8, but the corresponding specifier may require size 2049 [-Werror,-Wfortify-source] 94 | if (sscanf (buf, "%2048ms%mc", &sp3, &sp4) != 2) | ^ scanf13.c:110:61: error: 'sscanf' may overflow; destination buffer in argument 4 has size 8, but the corresponding specifier may require size 1501 [-Werror,-Wfortify-source] 110 | if (sscanf (buf, "%4mc%1500m[dr/]%548m[abc/d]%3mc", &sp1, &sp2, &sp3, &sp4) | ^ scanf13.c:110:67: error: 'sscanf' may overflow; destination buffer in argument 5 has size 8, but the corresponding specifier may require size 549 [-Werror,-Wfortify-source] 110 | if (sscanf (buf, "%4mc%1500m[dr/]%548m[abc/d]%3mc", &sp1, &sp2, &sp3, &sp4) --- stdio-common/scanf13.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/stdio-common/scanf13.c b/stdio-common/scanf13.c index 65b1429720..131abb33de 100644 --- a/stdio-common/scanf13.c +++ b/stdio-common/scanf13.c @@ -24,6 +24,7 @@ main (void) DIAG_PUSH_NEEDS_COMMENT_CLANG; DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wformat-invalid-specifier"); DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wformat-extra-args"); + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); if (sscanf ("A \xc3\x84-\t\t\xc3\x84-abcdefbcd\t\xc3\x84-B", "A%ms%10ms%4m[bcd]%4mcB", &sp1, &sp2, &sp3, &sp4) != 4) FAIL (); @@ -91,6 +92,8 @@ main (void) FAIL (); free (sp2); } + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); if (sscanf (buf, "%2048ms%mc", &sp3, &sp4) != 2) FAIL (); else @@ -131,6 +134,7 @@ main (void) FAIL (); free (sp4); } + DIAG_POP_NEEDS_COMMENT_CLANG; if (sscanf (buf, "%mS%mC", &lsp1, &lsp2) != 2) FAIL (); else @@ -150,6 +154,7 @@ main (void) DIAG_PUSH_NEEDS_COMMENT_CLANG; DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wformat-invalid-specifier"); DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wformat-extra-args"); + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); if (sscanf (buf, "%2048mls%mlc", &lsp3, &lsp4) != 2) FAIL (); else