From patchwork Mon Jan 13 07:30:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Werner X-Patchwork-Id: 857172 Received: from mail.systec-electronic.com (mail.systec-electronic.com [77.220.239.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FF541DFE1; Mon, 13 Jan 2025 07:30:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=77.220.239.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736753444; cv=none; b=FWnD36BB6eqODhr238yH0qBYEhZ53SugzL0XyHl0+1fPBnD9oYBTQk8TjAD9lM/TMBS6e3x2Zo/fzNAOFvLNL5PiAT9sDSt5WAS3MRN3DxAcKXxSw5mNx27xtv1u0sMNGEDtqmFKAFFltrp2yxTWUQ+jsIvyJMjtXJ/YCDwVRbc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736753444; c=relaxed/simple; bh=l5b6wy3duwqL3WY3LK0HKZFpwQdoy/YVYa+jIirql98=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VQcc++Mm0N8uAuT864hpHdMf3/6ZvVfzLFg8QPTMuAuCE77/SmfiwPyTYb9mahFjY4yMrKH0K8CJcukOdgdmME8cHMbUMjwIxT8T5XEVBUXuSBoN+oTk+QlPZ9TLwSXVh4K+0D8ZGJlk8F08iui16Qekv+pUYHYVBi1P1ZLe/48= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=systec-electronic.com; spf=pass smtp.mailfrom=systec-electronic.com; dkim=pass (2048-bit key) header.d=systec-electronic.com header.i=@systec-electronic.com header.b=dcbKDte4; arc=none smtp.client-ip=77.220.239.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=systec-electronic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=systec-electronic.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=systec-electronic.com header.i=@systec-electronic.com header.b="dcbKDte4" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.systec-electronic.com (Postfix) with ESMTP id 699E09400101; Mon, 13 Jan 2025 08:30:32 +0100 (CET) Received: from mail.systec-electronic.com ([127.0.0.1]) by localhost (mail.systec-electronic.com [127.0.0.1]) (amavis, port 10032) with ESMTP id pC6MxG5JuLwK; Mon, 13 Jan 2025 08:30:32 +0100 (CET) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.systec-electronic.com (Postfix) with ESMTP id 403EB94016AB; Mon, 13 Jan 2025 08:30:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.systec-electronic.com 403EB94016AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=systec-electronic.com; s=B34D3B04-5DC7-11EE-83E3-4D8CAB78E8CD; t=1736753432; bh=IMaFncpff1Uf5pfW/wTwQew07/JWnCIgy2xnF7SUMYc=; h=From:To:Date:Message-ID:MIME-Version; b=dcbKDte4EgnO5R1yHJp8b1PnUGMtgpRZcJ30v2G5bySX8QrrVzPmaAPAxWS22fFVF SBmy5oiMC+VaQtdtBOcA1/PS1OJzKuee7VTWc2pd2JMVKU+SbhgmOyGJjJM8PUyvfr 7bBpf9OJFzONa5cK4uKqrxp25ogVeLwEGs+69meWqbODj6t18DvmP1f/cURoPgVdXl 8AdKnZwC5j1+uFyyFHEJ10BxHL+WLJfaluo0pzeoIAz/vrjigBJ2Rd369viY/ZmFPt pctngfVSSCQNJCEDeOcqA7rd8dB4E7vHVBMxQEfX30XdU73VcRpL/TeQeHMcZKy8AH zpaqd/mfRpAKg== X-Virus-Scanned: amavis at systec-electronic.com Received: from mail.systec-electronic.com ([127.0.0.1]) by localhost (mail.systec-electronic.com [127.0.0.1]) (amavis, port 10026) with ESMTP id hRrvcNyO07We; Mon, 13 Jan 2025 08:30:32 +0100 (CET) Received: from ws565760.. (unknown [212.185.67.148]) by mail.systec-electronic.com (Postfix) with ESMTPSA id D1F2F9400101; Mon, 13 Jan 2025 08:30:31 +0100 (CET) From: Andre Werner To: gregkh@linuxfoundation.org, jirislaby@kernel.org, hvilleneuve@dimonoff.com, andy@kernel.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, lech.perczak@camlingroup.com, krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org, Andre Werner , Krzysztof Kozlowski Subject: [PATCH v6 1/2] dt-bindings: serial: sc16is7xx: Add description for polling mode Date: Mon, 13 Jan 2025 08:30:29 +0100 Message-ID: <20250113073030.15970-1-andre.werner@systec-electronic.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Polling mode is enabled if the "interrupts" property is missing. Thus, this commit deletes "interrupts" entry from "required" section and adds a description for the fallback to polling mode at the "interrupts" entry. Signed-off-by: Andre Werner Acked-by: Krzysztof Kozlowski --- V3: - No changes on source. - Add Acked-By to commit message. V4: - No changes V5: - No changes V6: - No changes --- Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml index 88871480018e..ab39b95dae40 100644 --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml @@ -23,6 +23,8 @@ properties: maxItems: 1 interrupts: + description: + When missing, device driver uses polling instead. maxItems: 1 clocks: @@ -76,7 +78,6 @@ properties: required: - compatible - reg - - interrupts allOf: - $ref: /schemas/spi/spi-peripheral-props.yaml# From patchwork Mon Jan 13 07:30:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Werner X-Patchwork-Id: 858111 Received: from mail.systec-electronic.com (mail.systec-electronic.com [77.220.239.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AC7F1E526; Mon, 13 Jan 2025 07:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=77.220.239.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736753444; cv=none; b=E7pPEgaQDT+/fCTOaPX4U20yQEO2fx4W9oHgRnfegjNRV6U4I+1YPaHihdf/D3WkTEVP15NEfBtXSVQ911LHK/ZLOupmfnWbbLVi6yC42AVnD8W2Mess4hZAPZEClvGg8VWMCRq6AE9q2f0XBd0mEZnm7CGThIsuAnpkWNLpbgI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736753444; c=relaxed/simple; bh=3Z6r7u2BE6G3e+u03Yxyn4RaztDi49i/brXUrQvgazs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KaCgGXu6T4Eihs2sSacnqEkEd5jpyXe8Uo2SmzNPkOlg1g8+S5X7nH0PVGMevFf4cNZdBzNgzFZORetJ7n6CmQBJmwNUFsmGZLPSHgz2W+rzP6JYWXD2N8DmFbnJBDOvcrSSlYNyObjaSlMAVoGiKsYx/b3RRUkWYUOjCB4uDb0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=systec-electronic.com; spf=pass smtp.mailfrom=systec-electronic.com; dkim=pass (2048-bit key) header.d=systec-electronic.com header.i=@systec-electronic.com header.b=Hyl72gbI; arc=none smtp.client-ip=77.220.239.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=systec-electronic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=systec-electronic.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=systec-electronic.com header.i=@systec-electronic.com header.b="Hyl72gbI" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.systec-electronic.com (Postfix) with ESMTP id B79DA94016AA; Mon, 13 Jan 2025 08:30:32 +0100 (CET) Received: from mail.systec-electronic.com ([127.0.0.1]) by localhost (mail.systec-electronic.com [127.0.0.1]) (amavis, port 10032) with ESMTP id q6WAzfTW0dOV; Mon, 13 Jan 2025 08:30:32 +0100 (CET) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.systec-electronic.com (Postfix) with ESMTP id 8CA7C94016AB; Mon, 13 Jan 2025 08:30:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.systec-electronic.com 8CA7C94016AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=systec-electronic.com; s=B34D3B04-5DC7-11EE-83E3-4D8CAB78E8CD; t=1736753432; bh=nEYKz6sL3x1PtFC6ENFLvLlIdTcdC01YGXgXIBfvUgU=; h=From:To:Date:Message-ID:MIME-Version; b=Hyl72gbIN5RqF94DYQBf/2qwwc8Vg72Ohwelcg5k/ZCNSKyMjgVxxx76jUxzQcQtX QdjWVJ+iSCUyWOCriU7ZWF1qiHhEHCt7MdAIw8GnyR9fi5Q8t12+itFBijgehMNbBX JVoBdPlXfxHXI2zpOo4GbSVxAjd79dBin9xh+iyBz8e3Fq71sA6vrzG5Fm4iNnb08f dhohLCUr0lG6kPRS/r81GFQ+mZ8QPG28+9Yqs1VNp+q1+EovCuWqMCFQBVXH2Py4ru 9qUZdqXdKBQqfwvrLNYfLsGtKquIMobq5veZk+vajJnMEAikXH2Sgrb7Fh6ad/I9HG lLsGPUxqNZElQ== X-Virus-Scanned: amavis at systec-electronic.com Received: from mail.systec-electronic.com ([127.0.0.1]) by localhost (mail.systec-electronic.com [127.0.0.1]) (amavis, port 10026) with ESMTP id mQJ7koRddDl9; Mon, 13 Jan 2025 08:30:32 +0100 (CET) Received: from ws565760.. (unknown [212.185.67.148]) by mail.systec-electronic.com (Postfix) with ESMTPSA id 3626194016AA; Mon, 13 Jan 2025 08:30:32 +0100 (CET) From: Andre Werner To: gregkh@linuxfoundation.org, jirislaby@kernel.org, hvilleneuve@dimonoff.com, andy@kernel.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, lech.perczak@camlingroup.com, krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org, Andre Werner Subject: [PATCH v6 2/2] serial: sc16is7xx: Add polling mode if no IRQ pin is available Date: Mon, 13 Jan 2025 08:30:30 +0100 Message-ID: <20250113073030.15970-2-andre.werner@systec-electronic.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250113073030.15970-1-andre.werner@systec-electronic.com> References: <20250113073030.15970-1-andre.werner@systec-electronic.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fall back to polling mode if no interrupt is configured because there is no possibility to connect the interrupt pin. If "interrupts" property is missing in devicetree the driver uses a delayed worker to pull the state of interrupt status registers. Signed-off-by: Andre Werner --- V2: - Change warning for polling mode to debug log entry - Correct typo: Resuse -> Reuse - Format define with missing tabs for SC16IS7XX_POLL_PERIOD - Format struct declaration sc16is7xx_one_config with missing tabs for polling and shutdown - Adapt dtbinding with new polling feature V3: - Use suffix with units and drop a comment SC16IS7XX_POLL_PERIOD_MS. Sorry for that miss. - Make Kernel lowercase. V4: - Reword commit messages for better understanding. - Remove 'shutdown' property for canceling delayed worker. - Rename worker function: sc16is7xx_transmission_poll -> sc16is7xx_poll_proc - Unify argument for worker functions: kthread_work *work -> kthread_work *ws V5: - Replace of_property check with IRQ number check to set polling property. This will add support for usage without device tree definitions. Thanks for that advice. - Add blank line es requested. V6: - Use polling mode for IRQ numbers <= 0 which encounter no valid IRQ were found/defined. --- drivers/tty/serial/sc16is7xx.c | 37 ++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index a3093e09309f..560f45ed19ae 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -314,6 +314,7 @@ #define SC16IS7XX_FIFO_SIZE (64) #define SC16IS7XX_GPIOS_PER_BANK 4 +#define SC16IS7XX_POLL_PERIOD_MS 10 #define SC16IS7XX_RECONF_MD BIT(0) #define SC16IS7XX_RECONF_IER BIT(1) #define SC16IS7XX_RECONF_RS485 BIT(2) @@ -348,6 +349,8 @@ struct sc16is7xx_port { u8 mctrl_mask; struct kthread_worker kworker; struct task_struct *kworker_task; + struct kthread_delayed_work poll_work; + bool polling; struct sc16is7xx_one p[]; }; @@ -861,6 +864,18 @@ static irqreturn_t sc16is7xx_irq(int irq, void *dev_id) return IRQ_HANDLED; } +static void sc16is7xx_poll_proc(struct kthread_work *ws) +{ + struct sc16is7xx_port *s = container_of(ws, struct sc16is7xx_port, poll_work.work); + + /* Reuse standard IRQ handler. Interrupt ID is unused in this context. */ + sc16is7xx_irq(0, s); + + /* Setup delay based on SC16IS7XX_POLL_PERIOD_MS */ + kthread_queue_delayed_work(&s->kworker, &s->poll_work, + msecs_to_jiffies(SC16IS7XX_POLL_PERIOD_MS)); +} + static void sc16is7xx_tx_proc(struct kthread_work *ws) { struct uart_port *port = &(to_sc16is7xx_one(ws, tx_work)->port); @@ -1149,6 +1164,7 @@ static int sc16is7xx_config_rs485(struct uart_port *port, struct ktermios *termi static int sc16is7xx_startup(struct uart_port *port) { struct sc16is7xx_one *one = to_sc16is7xx_one(port, port); + struct sc16is7xx_port *s = dev_get_drvdata(port->dev); unsigned int val; unsigned long flags; @@ -1211,6 +1227,10 @@ static int sc16is7xx_startup(struct uart_port *port) sc16is7xx_enable_ms(port); uart_port_unlock_irqrestore(port, flags); + if (s->polling) + kthread_queue_delayed_work(&s->kworker, &s->poll_work, + msecs_to_jiffies(SC16IS7XX_POLL_PERIOD_MS)); + return 0; } @@ -1232,6 +1252,9 @@ static void sc16is7xx_shutdown(struct uart_port *port) sc16is7xx_power(port, 0); + if (s->polling) + kthread_cancel_delayed_work_sync(&s->poll_work); + kthread_flush_worker(&s->kworker); } @@ -1538,6 +1561,11 @@ int sc16is7xx_probe(struct device *dev, const struct sc16is7xx_devtype *devtype, /* Always ask for fixed clock rate from a property. */ device_property_read_u32(dev, "clock-frequency", &uartclk); + s->polling = (irq <= 0); + if (s->polling) + dev_dbg(dev, + "No interrupt pin definition, falling back to polling mode\n"); + s->clk = devm_clk_get_optional(dev, NULL); if (IS_ERR(s->clk)) return PTR_ERR(s->clk); @@ -1665,6 +1693,12 @@ int sc16is7xx_probe(struct device *dev, const struct sc16is7xx_devtype *devtype, goto out_ports; #endif + if (s->polling) { + /* Initialize kernel thread for polling */ + kthread_init_delayed_work(&s->poll_work, sc16is7xx_poll_proc); + return 0; + } + /* * Setup interrupt. We first try to acquire the IRQ line as level IRQ. * If that succeeds, we can allow sharing the interrupt as well. @@ -1724,6 +1758,9 @@ void sc16is7xx_remove(struct device *dev) sc16is7xx_power(&s->p[i].port, 0); } + if (s->polling) + kthread_cancel_delayed_work_sync(&s->poll_work); + kthread_flush_worker(&s->kworker); kthread_stop(s->kworker_task);