From patchwork Thu Jan 16 19:30:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 858623 Received: from cloudserver094114.home.pl (cloudserver094114.home.pl [79.96.170.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21DFB22E409; Thu, 16 Jan 2025 19:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.96.170.134 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737055933; cv=none; b=KrF7Aa5v6qudIhw/On2PqeCssZSEYfNUhLkhhWDeVP+najG7OeFt4t6Jv4MjXuxK7FRYcDqsWclu36495pN0aFPL1zENclO+wQPd/4GVp/+yBuOfflr2WpgC4mHqklNxaNcsimsrzxkU/zQ1zB71EFNHTmqKrZvEXWxBJK/Qfc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737055933; c=relaxed/simple; bh=t+ODKSF2lgcrwPyi0CLV5sncFU9+BvQfEWjTtjhtmLI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BEJL0TI2JbycwyvFsU6AwEoSc/leRu2/nRQW7LzS9Xgm/Hn2aiP0ghJrUBFhZiRqOttNvYwm5lmos/HFK7mGUc5ltYzQL5Ef1ECI3oHIoH/Kmjp/rTklb1fFl2W2Wh9FFwXgroSDzH5Ga9ruzhT3TMZSvFBrnZo8GofFW1wG6e8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net; spf=pass smtp.mailfrom=rjwysocki.net; dkim=pass (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b=gTaEFclF; arc=none smtp.client-ip=79.96.170.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b="gTaEFclF" Received: from localhost (127.0.0.1) (HELO v370.home.net.pl) by /usr/run/smtp (/usr/run/postfix/private/idea_relay_lmtp) via UNIX with SMTP (IdeaSmtpServer 6.2.1) id a793888f2ca5859e; Thu, 16 Jan 2025 20:32:09 +0100 Received: from kreacher.localnet (unknown [195.136.19.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by cloudserver094114.home.pl (Postfix) with ESMTPSA id 5A1798E0B61; Thu, 16 Jan 2025 20:32:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rjwysocki.net; s=dkim; t=1737055928; bh=t+ODKSF2lgcrwPyi0CLV5sncFU9+BvQfEWjTtjhtmLI=; h=From:Subject:Date; b=gTaEFclFYZGxVw5y+j0IgDxlCD9PV5DvBjoV3kdYjjKm6ZrJc1enJvLSJZtHBaeiS tmP1NkoCypQwd5MFIsvdi8IbGpUmVKF3wuA6qBj4z/FD6I0jYjqMzEQbXMdIf+pVkZ szJPj0R8pUhLZhUd20z0mJR3epMoX6VBMH1l4Xh9vlHZ07theScQgRfUCjyXoTZl12 8wBkYrM1YxTw6fD9ZBY/MQXZ0LdkFS0PNrtDyUKt9yTuOiApLNdW+tnBnQ9QkFso4t mTW99/qJIvO/CmG6/5oS1xwy6qcTPBkgzkiOWxkEBEELDe+jQJCIvvv9ZfU+ztDPVQ hj19kXfR8IKFg== From: "Rafael J. Wysocki" To: Linux PM Cc: LKML , Daniel Lezcano , Lukasz Luba Subject: [PATCH v1 1/3] thermal: core: Rename callback functions in two governors Date: Thu, 16 Jan 2025 20:30:27 +0100 Message-ID: <5859084.DvuYhMxLoT@rjwysocki.net> In-Reply-To: <2772026.mvXUDI8C0e@rjwysocki.net> References: <2772026.mvXUDI8C0e@rjwysocki.net> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CLIENT-IP: 195.136.19.94 X-CLIENT-HOSTNAME: 195.136.19.94 X-VADE-SPAMSTATE: clean X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeefuddrudeiuddguddvfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfjqffogffrnfdpggftiffpkfenuceurghilhhouhhtmecuudehtdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepfdftrghfrggvlhculfdrucghhihsohgtkhhifdcuoehrjhifsehrjhifhihsohgtkhhirdhnvghtqeenucggtffrrghtthgvrhhnpedvffeuiedtgfdvtddugeeujedtffetteegfeekffdvfedttddtuefhgeefvdejhfenucfkphepudelhedrudefiedrudelrdelgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduleehrddufeeirdduledrleegpdhhvghlohepkhhrvggrtghhvghrrdhlohgtrghlnhgvthdpmhgrihhlfhhrohhmpehrjhifsehrjhifhihsohgtkhhirdhnvghtpdhnsggprhgtphhtthhopeegpdhrtghpthhtoheplhhinhhugidqphhmsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepuggrnhhivghlrdhlvgiitggrnhhosehlihhnrghrohdrohhrghdprhgtphhtthhopehluhhkrghsiidrlhhusggrsegrrhhmrdgtohhm X-DCC--Metrics: v370.home.net.pl 1024; Body=4 Fuz1=4 Fuz2=4 From: Rafael J. Wysocki The names of :trip_crossed() callback functions in the Bang-bang and User-space thermal governors don't match their current purpose any more after previous changes, so rename them. No functional impact. Signed-off-by: Rafael J. Wysocki --- drivers/thermal/gov_bang_bang.c | 10 +++++----- drivers/thermal/gov_user_space.c | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) --- a/drivers/thermal/gov_bang_bang.c +++ b/drivers/thermal/gov_bang_bang.c @@ -34,7 +34,7 @@ } /** - * bang_bang_control - controls devices associated with the given zone + * bang_bang_trip_crossed - controls devices associated with the given zone * @tz: thermal_zone_device * @trip: the trip point * @crossed_up: whether or not the trip has been crossed on the way up @@ -61,9 +61,9 @@ * (trip_temp - hyst) so that the fan gets turned off again. * */ -static void bang_bang_control(struct thermal_zone_device *tz, - const struct thermal_trip *trip, - bool crossed_up) +static void bang_bang_trip_crossed(struct thermal_zone_device *tz, + const struct thermal_trip *trip, + bool crossed_up) { const struct thermal_trip_desc *td = trip_to_trip_desc(trip); struct thermal_instance *instance; @@ -123,7 +123,7 @@ static struct thermal_governor thermal_gov_bang_bang = { .name = "bang_bang", - .trip_crossed = bang_bang_control, + .trip_crossed = bang_bang_trip_crossed, .manage = bang_bang_manage, .update_tz = bang_bang_update_tz, }; --- a/drivers/thermal/gov_user_space.c +++ b/drivers/thermal/gov_user_space.c @@ -23,16 +23,16 @@ } /** - * notify_user_space - Notifies user space about thermal events + * user_space_trip_crossed - Notify user space about trip crossing events * @tz: thermal_zone_device * @trip: trip point * @crossed_up: whether or not the trip has been crossed on the way up * * This function notifies the user space through UEvents. */ -static void notify_user_space(struct thermal_zone_device *tz, - const struct thermal_trip *trip, - bool crossed_up) +static void user_space_trip_crossed(struct thermal_zone_device *tz, + const struct thermal_trip *trip, + bool crossed_up) { char *thermal_prop[5]; int i; @@ -52,7 +52,7 @@ static struct thermal_governor thermal_gov_user_space = { .name = "user_space", - .trip_crossed = notify_user_space, + .trip_crossed = user_space_trip_crossed, .bind_to_tz = user_space_bind, }; THERMAL_GOVERNOR_DECLARE(thermal_gov_user_space); From patchwork Thu Jan 16 19:31:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 858064 Received: from cloudserver094114.home.pl (cloudserver094114.home.pl [79.96.170.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 353E922D4C3; Thu, 16 Jan 2025 19:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.96.170.134 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737055932; cv=none; b=DRE4kr1m51jVvL6B5Ssd2DmD4D+w/JQ32x8Q2Tk3TVc5St6byqqJC86++naYGAFDQvQv6dlMH6VbM2SVEKKk9aQVmeBv8/t9TarAReZQ9KX1HvCZuuDClM5yrazFvkXR9HAP85/ISHaOgZv7ag9u2die+jPhgvKQ91OodiUCIt4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737055932; c=relaxed/simple; bh=InTjOGXMdMmWfQ1igh6UvrRsQ9+skFaRH4B8Xvqev9c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EQBKPlwkVImFiVQVLiVVPkFgpOHAFESSmZsQ83tZvazq2NO9JtMTFa5JNvD3k8T/PJi8qiaIUeEKxjbuej3p/oa+GOGeudkrXQyq+FuuHgRKzr2PydhTO8AJOVuf5T98HcPKtn6wA7Q94U1pBKOxyT9Qb02HVjyr7dGZUFcGWRw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net; spf=pass smtp.mailfrom=rjwysocki.net; dkim=pass (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b=qLOskdVY; arc=none smtp.client-ip=79.96.170.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b="qLOskdVY" Received: from localhost (127.0.0.1) (HELO v370.home.net.pl) by /usr/run/smtp (/usr/run/postfix/private/idea_relay_lmtp) via UNIX with SMTP (IdeaSmtpServer 6.2.1) id 6fc857fda82aa2a0; Thu, 16 Jan 2025 20:32:08 +0100 Received: from kreacher.localnet (unknown [195.136.19.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by cloudserver094114.home.pl (Postfix) with ESMTPSA id 67A0E8E0B61; Thu, 16 Jan 2025 20:32:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rjwysocki.net; s=dkim; t=1737055927; bh=InTjOGXMdMmWfQ1igh6UvrRsQ9+skFaRH4B8Xvqev9c=; h=From:Subject:Date; b=qLOskdVY12FqGyWfSBRbzSFqGZybaVLH53LmeUVw7Emqwut95VSUmy22GCui5UR9R h+selmUSXkh8l+tXhcAmHmzMMA3E8zrt/hYZ95gE8LpRFAjFkz6wTPYWsDy7ROkPew 6eqyJA5w1EQUhSMQt8paXJMZP589hD4QsrStoK8ewKSu7d8REAtk6Q/tpOUbpIvAnJ QwJjwzuNDsIB0WP6N1Qit3Fl5WUDwgEjaLYIv1NrogLxHXuRpkQB6mucGMQwlFTcM0 H4Gh8KpyjabDp4QdzrULwORtAVK41pxSgHCUWjiuWY9rOiIfc51PUOZ7BVAeJ4UM1f ygnyBL9WjMX4g== From: "Rafael J. Wysocki" To: Linux PM Cc: LKML , Daniel Lezcano , Lukasz Luba Subject: [PATCH v1 2/3] thermal: gov_bang_bang: Relocate regulation logic description Date: Thu, 16 Jan 2025 20:31:11 +0100 Message-ID: <4987649.31r3eYUQgx@rjwysocki.net> In-Reply-To: <2772026.mvXUDI8C0e@rjwysocki.net> References: <2772026.mvXUDI8C0e@rjwysocki.net> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CLIENT-IP: 195.136.19.94 X-CLIENT-HOSTNAME: 195.136.19.94 X-VADE-SPAMSTATE: clean X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeefuddrudeiuddguddvgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfjqffogffrnfdpggftiffpkfenuceurghilhhouhhtmecuudehtdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepfdftrghfrggvlhculfdrucghhihsohgtkhhifdcuoehrjhifsehrjhifhihsohgtkhhirdhnvghtqeenucggtffrrghtthgvrhhnpedvffeuiedtgfdvtddugeeujedtffetteegfeekffdvfedttddtuefhgeefvdejhfenucfkphepudelhedrudefiedrudelrdelgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduleehrddufeeirdduledrleegpdhhvghlohepkhhrvggrtghhvghrrdhlohgtrghlnhgvthdpmhgrihhlfhhrohhmpehrjhifsehrjhifhihsohgtkhhirdhnvghtpdhnsggprhgtphhtthhopeegpdhrtghpthhtoheplhhinhhugidqphhmsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepuggrnhhivghlrdhlvgiitggrnhhosehlihhnrghrohdrohhrghdprhgtphhtthhopehluhhkrghsiidrlhhusggrsegrrhhmrdgtohhm X-DCC--Metrics: v370.home.net.pl 1024; Body=4 Fuz1=4 Fuz2=4 From: Rafael J. Wysocki Move the regulation logic description from the bang_bang_trip_crossed() kerneldoc to the preamble. No functional impact. Signed-off-by: Rafael J. Wysocki Reviewed-by: Lukasz Luba --- drivers/thermal/gov_bang_bang.c | 43 +++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 22 deletions(-) --- a/drivers/thermal/gov_bang_bang.c +++ b/drivers/thermal/gov_bang_bang.c @@ -7,6 +7,27 @@ * Based on step_wise.c with following Copyrights: * Copyright (C) 2012 Intel Corp * Copyright (C) 2012 Durgadoss R + * + * Regulation Logic: a two point regulation, deliver cooling state depending + * on the previous state shown in this diagram: + * + * Fan: OFF ON + * + * | + * | + * trip_temp: +---->+ + * | | ^ + * | | | + * | | Temperature + * (trip_temp - hyst): +<----+ + * | + * | + * | + * + * * If the fan is not running and temperature exceeds trip_temp, the fan + * gets turned on. + * * In case the fan is running, temperature must fall below + * (trip_temp - hyst) so that the fan gets turned off again. */ #include @@ -38,28 +59,6 @@ * @tz: thermal_zone_device * @trip: the trip point * @crossed_up: whether or not the trip has been crossed on the way up - * - * Regulation Logic: a two point regulation, deliver cooling state depending - * on the previous state shown in this diagram: - * - * Fan: OFF ON - * - * | - * | - * trip_temp: +---->+ - * | | ^ - * | | | - * | | Temperature - * (trip_temp - hyst): +<----+ - * | - * | - * | - * - * * If the fan is not running and temperature exceeds trip_temp, the fan - * gets turned on. - * * In case the fan is running, temperature must fall below - * (trip_temp - hyst) so that the fan gets turned off again. - * */ static void bang_bang_trip_crossed(struct thermal_zone_device *tz, const struct thermal_trip *trip, From patchwork Thu Jan 16 19:31:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 858624 Received: from cloudserver094114.home.pl (cloudserver094114.home.pl [79.96.170.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9F02159596; Thu, 16 Jan 2025 19:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.96.170.134 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737055931; cv=none; b=gD68Jv+uE8k8CwSiA5cLjIpkBThHrU9bF0ntmZx6TdrkCsduG9Ix5U6/u6dzZKfS06fJhxQp1iaER7VRyvtB9i0UNEId7fOmOzT+qxWkHYvdifBE5dIjma8lxr1HC20HYwk08yOiHiFvSJh7bSZfKOrVcuPVnDQKMG+FSro0jts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737055931; c=relaxed/simple; bh=7tXj09p8hK0yKi8DNdzUjjuozDFAuKv6sSxiGgSLqv4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KPuLaeDWi8urdFMdXhUMGVB8hpGGimgMZrCE3Zh4EumZD3IK33c+8K42P6ddW264EF8EJ3y9u6+xch+X1fPH6U9RjKubDvEIoWI38uB6NIPrigDAwyq1wOPcyO8vfv4BNjC5KJLkY/kMXscoJvrpNTlMatWtnBtd0zSJnKrIW7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net; spf=pass smtp.mailfrom=rjwysocki.net; dkim=pass (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b=XYHOViTU; arc=none smtp.client-ip=79.96.170.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rjwysocki.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rjwysocki.net header.i=@rjwysocki.net header.b="XYHOViTU" Received: from localhost (127.0.0.1) (HELO v370.home.net.pl) by /usr/run/smtp (/usr/run/postfix/private/idea_relay_lmtp) via UNIX with SMTP (IdeaSmtpServer 6.2.1) id cffb33421e741747; Thu, 16 Jan 2025 20:32:06 +0100 Received: from kreacher.localnet (unknown [195.136.19.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by cloudserver094114.home.pl (Postfix) with ESMTPSA id 23B958E0B71; Thu, 16 Jan 2025 20:32:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rjwysocki.net; s=dkim; t=1737055926; bh=7tXj09p8hK0yKi8DNdzUjjuozDFAuKv6sSxiGgSLqv4=; h=From:Subject:Date; b=XYHOViTU9xaTAYbTDYol8DaMxWL61icxfIWxEjRXKnWoTYDkVyrB8K0wtdZ3qmM7y ITPekfYOApfdVKp4TdQsDA91VP3btuzBf0iEG6Bk0M1Qqq7z+QF5Nz6/gMrAVC9wya Kcvc9YLpmZEqiPJalpeN7StRBO2JBvfyoN79PeV9AuwFWAB/IUs4nF/fHFMovjzSAK nUjbcwyuIEXtL/ss0iBwfC9X96/cmbs9VQiaji+lLW3W6yqbEXooITrT/1eQUTYQ0r 9qXB8BoDEFHeKrwh3KKeWSaGaidhCUBtoHr0qOFWih1o7L+OTheCyqy5TQFBJXdmVL nPddiuswkcgIA== From: "Rafael J. Wysocki" To: Linux PM Cc: LKML , Daniel Lezcano , Lukasz Luba Subject: [PATCH v1 3/3] thermal: core: Rename function argument related to trip crossing Date: Thu, 16 Jan 2025 20:31:56 +0100 Message-ID: <2360961.ElGaqSPkdT@rjwysocki.net> In-Reply-To: <2772026.mvXUDI8C0e@rjwysocki.net> References: <2772026.mvXUDI8C0e@rjwysocki.net> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CLIENT-IP: 195.136.19.94 X-CLIENT-HOSTNAME: 195.136.19.94 X-VADE-SPAMSTATE: clean X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeefuddrudeiuddguddvfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfjqffogffrnfdpggftiffpkfenuceurghilhhouhhtmecuudehtdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepfdftrghfrggvlhculfdrucghhihsohgtkhhifdcuoehrjhifsehrjhifhihsohgtkhhirdhnvghtqeenucggtffrrghtthgvrhhnpedvffeuiedtgfdvtddugeeujedtffetteegfeekffdvfedttddtuefhgeefvdejhfenucfkphepudelhedrudefiedrudelrdelgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduleehrddufeeirdduledrleegpdhhvghlohepkhhrvggrtghhvghrrdhlohgtrghlnhgvthdpmhgrihhlfhhrohhmpehrjhifsehrjhifhihsohgtkhhirdhnvghtpdhnsggprhgtphhtthhopeegpdhrtghpthhtoheplhhinhhugidqphhmsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepuggrnhhivghlrdhlvgiitggrnhhosehlihhnrghrohdrohhrghdprhgtphhtthhopehluhhkrghsiidrlhhusggrsegrrhhmrdgtohhm X-DCC--Metrics: v370.home.net.pl 1024; Body=4 Fuz1=4 Fuz2=4 From: Rafael J. Wysocki Rename the 'crossed_up' function argument to 'upward', which is more proper English and a better match for representing temperature change direction, everywhere in the code. No functional impact. Signed-off-by: Rafael J. Wysocki --- drivers/thermal/gov_bang_bang.c | 6 +++--- drivers/thermal/gov_user_space.c | 4 ++-- drivers/thermal/thermal_core.c | 10 +++++----- drivers/thermal/thermal_core.h | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) --- a/drivers/thermal/gov_bang_bang.c +++ b/drivers/thermal/gov_bang_bang.c @@ -58,11 +58,11 @@ * bang_bang_trip_crossed - controls devices associated with the given zone * @tz: thermal_zone_device * @trip: the trip point - * @crossed_up: whether or not the trip has been crossed on the way up + * @upward: whether or not the trip has been crossed on the way up */ static void bang_bang_trip_crossed(struct thermal_zone_device *tz, const struct thermal_trip *trip, - bool crossed_up) + bool upward) { const struct thermal_trip_desc *td = trip_to_trip_desc(trip); struct thermal_instance *instance; @@ -74,7 +74,7 @@ tz->temperature, trip->hysteresis); list_for_each_entry(instance, &td->thermal_instances, trip_node) - bang_bang_set_instance_target(instance, crossed_up); + bang_bang_set_instance_target(instance, upward); } static void bang_bang_manage(struct thermal_zone_device *tz) --- a/drivers/thermal/gov_user_space.c +++ b/drivers/thermal/gov_user_space.c @@ -26,13 +26,13 @@ * user_space_trip_crossed - Notify user space about trip crossing events * @tz: thermal_zone_device * @trip: trip point - * @crossed_up: whether or not the trip has been crossed on the way up + * @upward: whether or not the trip has been crossed on the way up * * This function notifies the user space through UEvents. */ static void user_space_trip_crossed(struct thermal_zone_device *tz, const struct thermal_trip *trip, - bool crossed_up) + bool upward) { char *thermal_prop[5]; int i; --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -454,23 +454,23 @@ static void thermal_governor_trip_crossed(struct thermal_governor *governor, struct thermal_zone_device *tz, const struct thermal_trip *trip, - bool crossed_up) + bool upward) { if (trip->type == THERMAL_TRIP_HOT || trip->type == THERMAL_TRIP_CRITICAL) return; if (governor->trip_crossed) - governor->trip_crossed(tz, trip, crossed_up); + governor->trip_crossed(tz, trip, upward); } static void thermal_trip_crossed(struct thermal_zone_device *tz, struct thermal_trip_desc *td, struct thermal_governor *governor, - bool crossed_up) + bool upward) { const struct thermal_trip *trip = &td->trip; - if (crossed_up) { + if (upward) { if (trip->type == THERMAL_TRIP_PASSIVE) tz->passive++; else if (trip->type == THERMAL_TRIP_CRITICAL || @@ -493,7 +493,7 @@ dev_info(&tz->device, "Trip crossed down: %d\n", trip->temperature - trip->hysteresis); } - thermal_governor_trip_crossed(governor, tz, trip, crossed_up); + thermal_governor_trip_crossed(governor, tz, trip, upward); } void thermal_zone_set_trip_hyst(struct thermal_zone_device *tz, --- a/drivers/thermal/thermal_core.h +++ b/drivers/thermal/thermal_core.h @@ -56,7 +56,7 @@ void (*unbind_from_tz)(struct thermal_zone_device *tz); void (*trip_crossed)(struct thermal_zone_device *tz, const struct thermal_trip *trip, - bool crossed_up); + bool upward); void (*manage)(struct thermal_zone_device *tz); void (*update_tz)(struct thermal_zone_device *tz, enum thermal_notify_event reason);