From patchwork Sat Feb 1 13:02:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 862321 Received: from LO0P265CU003.outbound.protection.outlook.com (mail-uksouthazolkn19012058.outbound.protection.outlook.com [52.103.37.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95F6F2C9A; Sat, 1 Feb 2025 13:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.37.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738414982; cv=fail; b=oLm/NHvbvSf7gnZ+PsRluDciTAGHj0tOgZTuiwfD5UThhl7YubVE/qPaSAbCs+QUE9VdtAOGBkejCV2d+2/bKFKyowD9u8YDa8MEWbHoQWDxWHG9SYh6LAi6Chv9tXCDjK2Z/1DYJX2PO369uivC8p3opnqR3oM3iNkDHuuYaVw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738414982; c=relaxed/simple; bh=hRVn4644dpgs01/+pFm+Kug1oolgFC1dj4b8PExnEKs=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=eRhqzq1akNeJZcp9UmWlsWtOrRrqMcZPTawK3t8vjWPNxeG8vuhRWqN/CYGXu8SLIQ2SErG2XR5xpFePL+grjzGI3FYh/nW6b0Xt6kb8IywlAlewbe8+Dk9J/K3p3CVqc5WOh97sXZLsRT+JoflxHAtLDIEruDXCAgmb/lKTsLw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=dw/tBbTH; arc=fail smtp.client-ip=52.103.37.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="dw/tBbTH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dilUZNw8gq4n2rx1pRkKtrVC++c/w5Jr51vuSZ7I815IFY1n8QDBi3rVnfIbhEuOL9F1A6+ISfXqixx+Zmyj0nBhpIimW1nouIMxbiWhyVpgVoCY5b7ficMEvbLue9jtS4VPVV6ld3/k+/wb77f2OZBKfihZD10PooqTDJyLDBC9e9z2FlGhY5IEEFJtyX6wUG38Vuo2GYH9rFsoKxS6GPxDJ0iYsOrILl07pGqVcSINSWpT7gVwOAIuSG1ebrbDx0SPeCX3CNIiyWsu+/GHOc3mN7lWNnAB3jeiPsrFweITx0iVZH0L47hJ/OAkszKnvyNO700H+YhsmOa9pKW9jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+ZJBY+tRiyU5lRK4Q9axrQ85I7SfOhWcopMeYJcKGDo=; b=E2PFOwNZOk+DPp46Hlz5ewfXrLXCJa5lAGD2bsMLDHlSgRV+6/EOuzUPb8F6p7PfuhmhTI6/OKnwNs1337OdlHTfCMl81E0e5QefPdkRkDBV9ej0uQY8GaE3PoOgXWMz28O4wDGH31qTS47gatuUSmHdZljjBa0YN/rgXw6Ui/zepFSaV52LaPkUgZhUk/sw2+8p0MGxL8686YIHwJat5EqQVWFNaXe94hfZMglNvjNKZ5abAtoF8tUvhnqDL9qQjDsBw/Xt9gyOzzQnf4lE04hpYIfSvYSBCGLmKvrLDiI7E0kUaaxCq3UAeCqMexa44DOagnEqJGC6IXrXnZYSjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ZJBY+tRiyU5lRK4Q9axrQ85I7SfOhWcopMeYJcKGDo=; b=dw/tBbTHVqJ/qaEr+GObfbEqQco8b6b2qw4XgdaIeHFKV1Vd7FCFL9JcAP2wgGtWKq4+/HDdZzg3yz2Bsq/MdSCqhO/S8BWAb/MMSK12lL6ICESQkTH65iM5Fbfgfan6ZVOcgP47+dg6ko9yhr5InieHChoflvZnnvzj+ff1nSwb12L3b8ETYB9DrePw0gX08AOqpd42YgQAddgnTBGIn8L8qHqh81+9FAfRxeOvkxLbvCaqBWUGe7D78omaBGg2sShK/a8eazemp46+swQUUehI0NP5j2rxGQtYlyQ6Hg2Njpt+lPrP3VmyqdHbSMiOrK0fSMEG78pJPQs+36dKwg== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by LOYP123MB2704.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:f2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.23; Sat, 1 Feb 2025 13:02:58 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%4]) with mapi id 15.20.8398.021; Sat, 1 Feb 2025 13:02:58 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 1/5] leds: leds-st1202: fix NULL pointer access on race condition Date: Sat, 1 Feb 2025 13:02:56 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: X-ClientProxiedBy: AS9PR05CA0351.eurprd05.prod.outlook.com (2603:10a6:20b:490::34) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250201130256.1682557-1-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|LOYP123MB2704:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a5ac7df-3923-4759-3d15-08dd42c0c023 X-Microsoft-Antispam: BCL:0; ARA:14566002|7092599003|8060799006|19110799003|5072599009|461199028|15080799006|440099028|3412199025|41001999003; X-Microsoft-Antispam-Message-Info: EphtgeYQQmUOcOodbByEpBlAU5ipgtIxahpaoQyjvfToaJ4rNcAN0Foomf3PsFNiaNMeNW3nTvzrH2fFyWbnDlIc/HnUp2Vs3LRbHRvjkakIIZl6BOBEPefOie0E2nhP2b7RdPyug0sZv6zhW/kUGvl1fkZsYJz//m20JVgWryFLaeW7g1jbv7alCTYM/wmX5tWp8PlHlcU1fs6WpUY7Moaz+Tg9ZeFKrh6yJUI6Jg441BsbAaz70faIlQnj8dHFQPb6Bl2MM9tBn1fsR7Iy0Ur28jDBVKnXYF6ynYpOfRWYLLDIfOJt1mrNDPXHMJcCffwKAEdRpWukvh21wGU147QdBY7RBZ8ZxxT3hxnIqufothcKXnDKgkC74o4dxncu4EkoDib8OZYLGAN5CqtBuWlHqg/i38SCU6siySR6kujbMWAoroeX8XtVqKifGIGWbNSxzUtRPE6VuQMY85TMAuYaTv1XF7+4XXWiDKZ3Dcja9fK/nsHOajLp94wqod00BPRDYa5giyhQhxra8qUpDAZpB6x4XAqsSoWSgB+WdN6gvATyznyeF2+UMJLxDGPGdavUnlRIM1Fdg4qXgHLtOMKrjNarO+Fp3zDe4IIojeiv98yqW+KJjjZJ8gQl512fYLh5Osb1VvGcuqNFNgMjAbhziswXvbi1bEY5j/2eUiA/CobHzLFDVW3qBHPqmHDAJmDO1Ym+5+JhKVo97Tk5f+bd+ncY7ouyvtsBkM+ve/JOhwgMFXHRnSnjJDBmY/HLpEIOgHU0cc0kRwrJ/QNeD2V8+uXsyDwNM4Wz/e7RFd7o1XlYYDs1azZVuv2SxbbkJ1T96zJOm3eDXcY7021AEGBt7OyPghFYcQ92ycZm82z5/I0bfwrPx+YQY1sGhGRE/4tS4P9nCBczeD3LL5/QoTMPVxCiLFtl3ikQyIc4GoIKvBzjIY78wCHmxrmb82Rcbqn8R4IULWLKTBHDWVwU0oj25YKxL8xGTqDitQSOriYAysEnAQQMNb/T+GZuiWrXdfBITbaeIgOg8cFYsbzOJVzNGGeVrFcZV+vquj1lKBQrugjimBfJvh55GTwNxTdl4ODFfvKN25rXdFuJNcuUHk8eLAbLnaHzM9+MRr6yAkY= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: O9lH20XcB2DyW3AzZ0oPRrtHpw0MDTluGzL6ZCEmMGo8LVrkGFdJVpRhWpROY6qMPJkryFNoHmIn0vOX2aF1wZ+21rDLeSjFrqphMhK8++fHQvFf8IgtgW2n/tNiR2seurWFCZjUqH3X3Z3KvMACpfrc6fWQeT1pPSwAUuTPxGOqZCRJASxhGPQdT5ixaQPCj1bQ1071ZdHOEfOfrjlfZakXHTU8k8VuvI2FDEsFgbtgl2xmbutwlqlLoJHN14xhBmtKUCrbmiZQux4exeVYXKA9jTPeGkzzWM5mdUFer0RdkjstkoiChPFGQvMgPUuMtRTtYAxS3mnPVhHn2aHfpqb6w6iEfVIH6tpS8bqUE3KBGWKKsYotT/H8Q1G61j8tc6nvjL/U1nZZQxsB3PfSqNw7/3QcLSATqgBeNDZp1UmQa1vkoGzWFUM4CtR7598qPKp85fAU73wJx2matsNvXrvKzWYsjqyGD2K0Qwl6pmeLvoyKd8HziFtbqJlptXqISweizkdfi0ZX/Uq9LTSQaw9m39fAWs96hBjJhrUwqGxKar9wQIuLN2s9zeN6BPEB5ObWCupfe6aJLVf66wWj1lURaR1vDERZo8iCrDvbb2+vI6fyIoJeURW1R48gNvq5FuO0xxBq3U9S/KbaMpbM0RaVQYVXmEK1mTG3uPAr1RrkuvAen7WbnSKomjHduVLLdVAwlvP3ZuuX/Pabe4gTaM114GapN5suY3UvjJcIA93+UIIX7vn7tjH1TTHRv+hfp8kuCodE3BzOQ7esnIp++h32f49IRmNw4AWHEXfrz0animo4ZUV7JSsZXyr553wtbETg08aQkaFuUG3cIyZuMlICjZwNuGEybdb49sUadzYGs0Obe81kuQn3Q9Cm2Y20Rgbz7GKJoOiwyN6ebifcxcbxhrxhQE+nyARe1mJODgrrdDW7QGS20ESRbsfvNTSVsjB7vT2ICwpjjX7fBYGcYz6SqhLuibKLZMnoW1YzXcxgk2CbaDBIvkxitpZLYYcNN+DNyQ/YPSNrIMcFsb9SRkvWOzyCvHNsoP7a9XgtOh64fdpxh6bXMyeYJIF+PGN78l2wwYmDGJ241MVX1sjNT1Bb+Cad5d/FL+kVeqXI7cLxtq6SFL9z5pLljJT7zckYYk2ljmg58u6FOv3hZfB1pXNY1EcbNt3QusYLME9omM2P7n4BUQlIIs0EwRCFwMvuA+nx2Ns7msJAMtsyrX5etnFzzqsZSDtRGCuutldY6r22aQSO+cKV5tkns0spsbHCXjyHnfY0WxTQS8V3xGc9Cpro2qdYVGA5xEFsv8XYtMA= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a5ac7df-3923-4759-3d15-08dd42c0c023 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2025 13:02:58.4228 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LOYP123MB2704 st1202_dt_init() calls devm_led_classdev_register_ext() before the internal data structures are properly setup, so the leds become visible to user space while being partially initialized, leading to a window where trying to access them causes a NULL pointer access. This change moves devm_led_classdev_register_ext() to the last thing to happen during initialization to eliminate it. Signed-off-by: Manuel Fombuena --- drivers/leds/leds-st1202.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index b691c4886993..e894b3f9a0f4 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -261,8 +261,6 @@ static int st1202_dt_init(struct st1202_chip *chip) int err, reg; for_each_available_child_of_node_scoped(dev_of_node(dev), child) { - struct led_init_data init_data = {}; - err = of_property_read_u32(child, "reg", ®); if (err) return dev_err_probe(dev, err, "Invalid register\n"); @@ -276,15 +274,6 @@ static int st1202_dt_init(struct st1202_chip *chip) led->led_cdev.pattern_set = st1202_led_pattern_set; led->led_cdev.pattern_clear = st1202_led_pattern_clear; led->led_cdev.default_trigger = "pattern"; - - init_data.fwnode = led->fwnode; - init_data.devicename = "st1202"; - init_data.default_label = ":"; - - err = devm_led_classdev_register_ext(dev, &led->led_cdev, &init_data); - if (err < 0) - return dev_err_probe(dev, err, "Failed to register LED class device\n"); - led->led_cdev.brightness_set = st1202_brightness_set; led->led_cdev.brightness_get = st1202_brightness_get; } @@ -368,6 +357,7 @@ static int st1202_probe(struct i2c_client *client) return ret; for (int i = 0; i < ST1202_MAX_LEDS; i++) { + struct led_init_data init_data = {}; led = &chip->leds[i]; led->chip = chip; led->led_num = i; @@ -384,6 +374,15 @@ static int st1202_probe(struct i2c_client *client) if (ret < 0) return dev_err_probe(&client->dev, ret, "Failed to clear LED pattern\n"); + + init_data.fwnode = led->fwnode; + init_data.devicename = "st1202"; + init_data.default_label = ":"; + + ret = devm_led_classdev_register_ext(&client->dev, &led->led_cdev, &init_data); + if (ret < 0) + return dev_err_probe(&client->dev, ret, + "Failed to register LED class device\n"); } return 0; From patchwork Sat Feb 1 13:04:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 861383 Received: from LO0P265CU003.outbound.protection.outlook.com (mail-uksouthazolkn19012058.outbound.protection.outlook.com [52.103.37.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B8472C9A; Sat, 1 Feb 2025 13:04:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.37.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738415053; cv=fail; b=iUWoNOvgGbbtRJbbeM9THU1ffMyI28bObYvDLCPTSBPUzjM0S9NG5EgGdo/vceQFuYP5Yz+1eRgpmfvf/xxVmEGyBzLqkPgufaU4wjOoQrH8byz+rj5rQ9FiSo2h6f7pgvHc/5D0PRX9SYMnTyNJnb284YoZ1tnnw+5hX9bKqMY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738415053; c=relaxed/simple; bh=WiG2bX6V1A0y46pxpoCSREfSI8ZkVt1LrWNMcECe918=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=QOanH7E/M2QU5oS12goEJuXyIRX29GuneKwolfpJvCqcH9d5Ds2TDNpPgXQ9fsbact4N7f1GIVK8fCdBslE9aCOPJYVMk2XBo+kVy4VffUrDgsms+BHhQNKyfKT/mupHshwJeg4t93CEyPGifVJYOBQ7SbYw3v8nLJWKkhBbosc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=hvjXA9jo; arc=fail smtp.client-ip=52.103.37.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="hvjXA9jo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YYx5AXuibBTnE0TBeLRdm7V+KQNQ7Sl84g1r/A0Sw4quT80dy7iBTIgVbU5liK1+UO/xg2gDHjObjKFs1pbwTxn+l9OL1duTDsJxad6IUSFiZMIOmeIB+TEGggei0uoVeQEnkvlH2cqV8Z85qowRTQA5JGesYbXh8iQE2wthSAAi+MS/olbslGM9b+b/D7sWEQS5k2ryitk7R7yimk7MmJmpuuf8NAgYMWFKXCFea5rES9WfghvnUG8KHNKEinl4EAanpJJIYyrGfzpVQGxHp89BqkCY6NSyaN3X79nHarRUPZ8i8zQvSItgs4TDoJmbXQkrW4XjvCRsYwPRfpr73A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0AzLQwmGaXuUyhKvYIvXIoJlxmpHxgvilNBqAEC+Ix8=; b=C97mkGX2+OA2dOfgiRrPeKQOc6My2yUEeG6QLzifmK9wFRKs5okOZq6BzXgHFJHnlq1GV2EJLCbslwwR66mSyVkBiHjoAmNqCXmrTgFOsckg9WwKUlfZd4/IbowFC+9qiyPNaXw73MX6QFcoE8GfWUkWqZR5ZokXmnn0LWhucggwuiZvR4qonIlM7jT+C5VNRy5sFP/cAg3x/m2zD7CCzkd583mqu4BA60x8TrOQ0Hsm1J64dCGaACcSNDvzv/kaL9iTx2NGMS3ul0WoExndD+D9x6qzpNLIL6dgHBDVeusjLUGC/7VFC55iF5XSth50gHYu6pw7vXiwnWtF5HtOVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0AzLQwmGaXuUyhKvYIvXIoJlxmpHxgvilNBqAEC+Ix8=; b=hvjXA9jomWDaPcpJlsB1YncS6dqqHrRsmUpjlrvz6ov3VbpFPjIoTXqHcJwjVJAdYqAx/wIuVQnaxmZHGgyJOf/nus+5Ko8wbs8rAb0HSQEsvOk0nPpNhboRhthqo/Ge51ZfjCifsZKrQ7nnxcnZvFbqxyC63+cn5OxrNdPpCNKxkb4nG/KuMxaetMhLIJkUoEYa2h0N6x6Hwr9dwGeLVy/aSw9X7TDi+MNkZ0HiyIYDkikep4FWhKRNdPqfrLFZAlfdzWMx391cWTulqRssovYMy3tYLtEn83OsdFEmQ/GSSNuqtzztKbSDVK7OENnZOpm6tme7Fd6JLZycAJVkuQ== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by LOYP123MB2704.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:f2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.23; Sat, 1 Feb 2025 13:04:09 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%4]) with mapi id 15.20.8398.021; Sat, 1 Feb 2025 13:04:09 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 2/5] leds: leds-st1202: initialize hardware before DT node child operations Date: Sat, 1 Feb 2025 13:04:07 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: X-ClientProxiedBy: AM6PR04CA0039.eurprd04.prod.outlook.com (2603:10a6:20b:f0::16) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250201130407.1688565-1-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|LOYP123MB2704:EE_ X-MS-Office365-Filtering-Correlation-Id: 12428587-9dc3-41ff-95be-08dd42c0ea50 X-Microsoft-Antispam: BCL:0; ARA:14566002|7092599003|8060799006|19110799003|5072599009|461199028|15080799006|440099028|3412199025|41001999003; X-Microsoft-Antispam-Message-Info: ZkXf7Kg9Tw664urAIAaNwMMHqYuiUDS7kfeDa7NPiXT41oTZL4mQVGTAWY6B9QtPg1jtQO5lAvVv9Atiw5/QwILJLb2XUo/IskO7mgYv3mmzhjh5ki+Ju0mH3AIkQZpynzrnQ/XNo/W4v0suuDpE6JqJAVxAu/xSAjq4RDFjUKmM2/flIuSOnFQ7ldDXj0JNqbGvhY5bmPHdJUqfuObL+oWxO/S2njchN9NeIL1vQiGsY90rKidSH0p6QGHJfYu3HtCOZ2Fx08QreiSG4aeqgoOLGKo5IRvll0KzKSj7/AgWTE3QMletMwmsDKkfJ5ZvHbVkoKECIxQana/YfjxArkN+GmExJRYh4RU5Lvf6Sb9/ZUTRUyiezWGLSHuEc0ghmrOvVPKWepw/ql0ejeDtKMFEnMkQ3EkuBf8c/gMQF4ycJKJ2OBXqMcHqaLGaRcBkYErdUMtzRz5kgoDDc6cI5G12w03Knc62SRi8haRzqhrUlolte160s9hF6MulrQdy6YBnhs2xQkUol5OwrF4aUGHCWEl7op7H9P8cl+YenCXWjPH2ZZS3hAdnssl9zBR9H62DmlrggZt7LWMAvsFMEF9ciRDaIRmwob8PALQyJa4C8715VmpgC9B/bU8M0lQcsAKuugmQ54qxL/pl9DjsFj7OdPnhVkVzEUsVfbIeTNtum19lvuns6Ybu9qeywk25rE91WTXW0xekT5aqSWTL+bKf+iAGmD8A5pQkzHLkFyinYFiGIumSs3RmFrVnBZ8TGm4aNferZGgdKXtFz7UhrsfjKPxo0lO//FiqIR2J/1vlli2FU0+J1oTIz9I9jMA7Sprqlu1QyfV6vKU5w009ewWqdWiY/aIEsTtMGmb4uEYqTJY0tgZrP3PTeRhDBSaJeLlvMi359iixND87mk/zbmH3BGVg8udSAgsPvpVTi5DrwjRM7/cA5iPTxIsa1UIapC5Rz64xK4DEJz3MdRW5/ZKNXlvdHcgoDfkFwv00BSQJfnkRy1BlJ6HRuAnOTr+AEH2F+X4GIrqkAnP27KvZ/UbPfN5D+szbuRlXxnID/mZKJ98T/1eyCWYfSd9GfJbNrgI94jdlw3ucz3KMnQX7gUQq3SrwWG7r7qFLcyVwKTE= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uyQQsE+zri0WR4bI/yWhBnPMC/b4cxoyJdiGCys2fv2/y0oe4Wo1FL+YFE8oS3d2BsuR70GJ5wm+o21nMVkBGm5KqUo7lBxE23qgG9/2s74bbhiNNYQn0NYF5aBStNfD12oa1jhM4HO03SfM+uJP5s1GHiS/ADBzaJZ8+ZYg/PNM+djdQ19X6a8NMocWX6RQiZdx20+kLvyBjx+ZrSJXliKD9LC6kK+KvTp1uoHGgxfwwnAzyv9PZ595fV4cuS8dAhfSomUWYZCdjnpj40tBHYDebNumcHXiR/Q5CUBfWT3Ub6ooAhvkhjfKbEA2n0eqQiCg1uFDWSMTV1c02xQu/FNQvZ8wVIj//UIoPX5Njaa2ONYZWbEUM4GrB6tis2Ay8zLOnipuiT59jP7xx+/A+srXpmucmy+tduqPe+lK1n3JAP+n1y8AAXA3YNv61i8TlkD+4sJr7hSQc1Q4hcqMO9T8KQPa/LpSzh9TUrLvsa9RcyLq8j4RnGx3U48JwXL5X7sZmQNqu1N6HDBu4IspBLbIwAk4+Id27lAJVeiUr9/QEzejt1zrB9R8flZcOItTmbewgfNcnU14NvzaPPGPoSdrts69bD9UWIHqQjly+scnhFq16ccU/Ve1onL1nzlKWHq3LKV6tvExvVxkzFMW2tVWKbC15ltPtKJ59/NcBSMDAc0cFbBGZZewhA/XJNNja8QALI07uLU7x84VrGmNDVjDhsHxmI2f/1TbFCOneDkYW7fasfzIcSp7TnoKUkWoxSr4S2T02hcddUkaW+wyxqo/GHS5ggJ6fKkJe39abi1W3P5E5ChxYgoQeSNRao2SZlF1/dtYTYlaR7JPLDczq7M/BOlWdJmEqJvWO6aRr73uz+MV6G0RsH5G03Xu6enh+6I5Cp0HtzGKGXhD46+WCg3BLVeJDfuAVcLNYjSpe0978bcgg+rTFR+dJVw7JY8VT0aw30aY4wtRE/IReCoTAub/GgViZGih4K4NKoYG8Yzd72NbLYxPUz6FHQ2wYf+wn4bbAiipBXIcmRJQ5ghkiV2EgF57wdXmU334eNhVNVNRdAZeOkqKeSQ+LJ6sN8mFfcBaph22ciOAARBeST1ls8CB4c7nQoQXqE7PUdDHs0pwNxmaksfeEOUb1OxgA1e5bB6s+0X/Zbd95tfL4RUztwRiB1RzG+melEeS7+y+z7/7lBCfHrTiFuAIZZzMS3BBDWd7IT2fB33EayxGBElgVbs3abV2eQAEYhju2yVUQ4mLG0GIiHiM6/7LoC3UtlsRtJhGhbSK07NdiKVcasF8I0trYavHwro/1zuVSbZCP4Q= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12428587-9dc3-41ff-95be-08dd42c0ea50 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2025 13:04:09.2202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LOYP123MB2704 Arguably, there are more chances of errors occurring during the initialization of the hardware, so this should complete successfully before the DT node childreen are initialized. Signed-off-by: Manuel Fombuena --- drivers/leds/leds-st1202.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index e894b3f9a0f4..927874f20839 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -348,11 +348,11 @@ static int st1202_probe(struct i2c_client *client) devm_mutex_init(&client->dev, &chip->lock); chip->client = client; - ret = st1202_dt_init(chip); + ret = st1202_setup(chip); if (ret < 0) return ret; - ret = st1202_setup(chip); + ret = st1202_dt_init(chip); if (ret < 0) return ret; From patchwork Sat Feb 1 13:04:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 862320 Received: from LO0P265CU003.outbound.protection.outlook.com (mail-uksouthazolkn19012054.outbound.protection.outlook.com [52.103.37.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA2CD2C9A; Sat, 1 Feb 2025 13:05:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.37.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738415111; cv=fail; b=jYW0Pp+4SKXzsTiUVgeLenfxoZJzZ09g6JOIVsNZcRU2MkkwctttQ9dHJyuSm+HzQ7OjMQ17WgDsDC8Yu6woBdbFil0rnp8lwzI5XYro62BJ7ihI41rgmtCJFPeMypfDpJ8B28avXnuS3r1y2aG6DQ+lO6a4KHHqaFuDI/fsB04= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738415111; c=relaxed/simple; bh=D4K9r6e8+Sk1BS+2VGhIrg5v2AEBsDv5XXQuSlnTfiY=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=J7OtR43PsEJ33o53/idDU4HYnlLweQXdoqQ+Dy0Wu12UyNOE9jPwjrxAKopMw9SMt0UPTdXIVSpeWqFmIWMi2UFiei8a9VoNN3P6ewfgV0kH9VHmLf3iaMabPuzEIEfsvc43DJjocJNaEwe7QeScF0+66Oye+fJDi4V2tbqtrlQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=nLf8FkVP; arc=fail smtp.client-ip=52.103.37.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="nLf8FkVP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k0cEhe9mBJX2EaI7O9oppt01c3Sq3DZWbZ3zkVVBk5LGxZrfwYZeqmxKdWNxTmIS12pRWoDGy/t6GxO+Z6EQoNvD6gdHqBZn0JRhugPe+IrliKe78MfB4SfcogzmsT8h0OrCNcXOMkvSRZHBQOcJ/v3mtuj47t94GyP2S+OXXlVU0jP3pqqJh6TB8gC8kjBAY+HSe3anXWS6UJBdXtetbvsbHoerwfDKQaoKtb0mawtoGHaqA9PNjZ9A3wwHCaobDKnJ00JGVm3Gy7bZwCkXviNRQjGQD1c61n+CgqgCKEc2D5RfbiMTWwRf0KDcQYgw/U5XqA1WQSqEfVX7laFOXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ogS6YfdqA8BdxG9LAhhchBsCc1A0frBaELQUTCigOQE=; b=fGeTx+WJtXjL0MhhWs+IBKzp49kAWcMjwAW3XH2WKKUNNaN0E2+EA0/21lHnx+oqfWLGFL2VglScIguJiyg37r8wEAIRISeYoPBDzCe8RA7Ch8dlqYzBAFOnlNQSb7YlMOoc0mG1jjyvbLh0PWBlNF0rrm/FMNplvXnk4Yq6ioB4JU0kSvBQ88ojzUS9QScvWFgZYWBgub5aFFEyM3yS7CaPZlGWHbKXqHSPeslfRNjNXxJh7AjwSpm8uqXC97k/Niu7Bi3I65BCh6jMtEtxFT2LomqqG/myofIRZ74RV2ZVByWOJyKDv8W7Dl1h38n7rPhR5Hm03dhkJPC7dzpYcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ogS6YfdqA8BdxG9LAhhchBsCc1A0frBaELQUTCigOQE=; b=nLf8FkVP6Oe8ME6RkzlukfND4IluADBsQL9qVPY2q+wuCEvzKfB0Axpbk9jHmiKdIUXUpca58Q+g0kFpY3zyL//s+Q0lAAJWl0wlH0SvsbErXKbwjLEQ4MTVj5CRgY/UMRVD+G6uUahv8NK4j/hQbaWUZ1DQdjs1j60Y7styc1IEokJSE5LurhIzCYnooDTiMvs9xiOu6uJNm+T/EYbWJRTLxcLi2y5nT55yRFpvTGHaOp9aumqSiWFNecJoTbZFP6dKMITHqFbJkA9D3WnoM8yOSDJ0ytnACWE2vHw5NJS5RbpqdjXEiDg0Gkb4r/46CWAZ+ebvRr4rRgZcC4/2mQ== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by LO4P123MB6306.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:299::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.22; Sat, 1 Feb 2025 13:05:06 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%4]) with mapi id 15.20.8398.021; Sat, 1 Feb 2025 13:05:06 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 3/5] leds: leds-st1202: spacing and proofreading editing Date: Sat, 1 Feb 2025 13:04:59 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: X-ClientProxiedBy: LO4P265CA0132.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::13) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250201130505.1693063-1-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|LO4P123MB6306:EE_ X-MS-Office365-Filtering-Correlation-Id: 68c811b1-e068-4ad9-aa43-08dd42c10c4d X-Microsoft-Antispam: BCL:0; ARA:14566002|5072599009|8060799006|19110799003|6090799003|7092599003|15080799006|461199028|3412199025|440099028|41001999003; X-Microsoft-Antispam-Message-Info: =?utf-8?q?clRYrF1mAKXvBisVw2VsOtFRJI1bjNP?= =?utf-8?q?69WcJwh48yWKCLXcSwbPl27pKme+pmVtAAGsi2To76XQTc4G6+zW7H71srYFMNeAQ?= =?utf-8?q?GBq5cCpyD/sRcemtB1gAkOaU22oVd/GMcGYDkEzZvySpQ7LuDt2HesBPMVPwaPBr2?= =?utf-8?q?UpGT3/FJech2jSWCYsAxrFTUTopARsoJ5Iu/1qNjDVhBAxb39wcS2MJIi6aOBWDdX?= =?utf-8?q?G4ZBQJJ2pQgdNT4pDzgcCGyh2mk8zpkX6JwWAcql7gcOem05JhA5vVmzBqYvlgSLJ?= =?utf-8?q?ulv735ZH9ApzCnEP/YJr98QF3aiQtv/L5SuRt7dkz7HMjuRdjlTthWRqafej2s5KO?= =?utf-8?q?C2ZpKq+r2kleSOybD5DIgve3u96LxVBkwTtV8vCsgUE6+nhoBFxmf++iw3N86PJpr?= =?utf-8?q?CH2sywQIlGJDCZkbGq3AbHKsLMK2Yx2sq2QNE7k3QBWWWxF4Z49wlAbyHe3CCZ+7o?= =?utf-8?q?Rx3V2Y+twrS9/t+U6lGnmV6hrGX2ny3Kn3EmSfHI4UmsmZilVumN6LguOltCm8XrP?= =?utf-8?q?L9ZYKKeuKoFZsweWBbZRaOdLc/d117zJKof1gf1UAS93dJBiye+M0ALfiT6m5/z5v?= =?utf-8?q?vaY1g222iyIyzPoSqoGNy8rpS31mowwNqYnXO14rgeP/aSLl+DeGt2REzEXQaYvyM?= =?utf-8?q?g/6Fa6Bcb/Q1dUCoC3lKTyeXvp6AlY2WBVS289uDs5uzyZ4Zezkpky/aG3kaIPHnD?= =?utf-8?q?CqnHhelhppMlFRzV3MYDzTPy/Uf/jq4t6BydoS56ztRwqLiCl8bdpsqzUjMqG3SHW?= =?utf-8?q?5xsCzY0uClH5B/Rlm+qwMOqXYB1dmT+7XHwEIS6M9cHbSoytHDEp+hlpgo19KzzOo?= =?utf-8?q?CEyZQCJYzazZGW79F9wHeFeyGdquXorsQ2Ftk3rk3WFfr1TQm5ySNSky8CoE8lu5V?= =?utf-8?q?+MaPnFTs9PfXEgnIr6RynTvbgc7lRjSHfTTAcaicVQ0lWWU23xFOGUxyDJ3/z7/tB?= =?utf-8?q?cQ9lmo3lpTjSecCVnQfbhC0Ob9hY/w/vUOuVSQ0MKHqTptugRvHRfwAvQxSyabVGD?= =?utf-8?q?UVYAafBR7tQUN/q3VMx6sqdNpcVFJUN43MAzEAw4+Q4jzLhgVE3SmUhWxidsTOqfA?= =?utf-8?q?Ic4z2c1x0jtpwwW0SqkAMfu4SyZoINvQI5Ulhg=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?8Fojtlmb3ko2bfOp3uSeOMBndHDh?= =?utf-8?q?10OktRsOeUc+InFQH8fMzx7GcVAy2X08DvQHTku+osFUXjm64RzLlelbwAaxGmdTZ?= =?utf-8?q?uxLXR5GsYrlfAI4TEtSiAHSxlEl4HGvjMRw7YoT4XzExsZ6gSerTHtfAinnoib8un?= =?utf-8?q?hFKiZ2z+25YrmYT31fGketoalan+GlzAY18YHCJ7Vf4e0laQpEstC+oWZ4JWOSCgL?= =?utf-8?q?GOoAsEwV1ZGmL3FW76T1Aku6yoyec+QAHUWxLxMfk/KL+2ZK+q8fy4U+uAUDF6wGr?= =?utf-8?q?n/F8bjh5NDxDmxFez56ej+5aKiWQwKtt3EkjhZaN6Li0DrxtjiaOa6fjKLHW4jDGY?= =?utf-8?q?2uE0rprSsx35zoPuq/Lk4WbG0QOeXcDRQ38vqQxHBktWyB0R5bcRk4aDOfDPdYy8r?= =?utf-8?q?C60bK0T2cCGlKFVvIm6F9IYgJHaVyMkIa9EOfBE9T959ZD3oIL7quIODdiXMtRZi7?= =?utf-8?q?D/g+7PIxudCiIoUMZUtXv8lTy/wz3CwenTSLzh+KvICYDz+LxNHSrW7gDgMNZ6WaT?= =?utf-8?q?6uy4AUUrKiEWCsEesHpyTxgutqShFBBOTieo5UTiduTgwwNW8RKTM2F5Y6OBzfPhx?= =?utf-8?q?s+z2kYcQLrxmMJiU7HmDRzdZ3hjWbslIn8FRSYRDlCsKfZBb4K3A0HyB+I9lG0k+/?= =?utf-8?q?FSXT/vp2AHcFdmsWOySYyKhxeZXMP30MTz10TH8d97HPFBoQkE04Dw4EefpHMhsXS?= =?utf-8?q?lLHo6XHDf2zMms8bspnwRMWXj7TzL23QGiYSU8EUE8KFWUzXHoaEvDn7RgIWCcnwp?= =?utf-8?q?XzddXaNIRWV6+UefSZHtOUjtiBBZaoBoDyBEBeAmXW8wqP+gQIaPHaJOd03FSWmLJ?= =?utf-8?q?bAHVMsqXzIS04QWEit0q6wqyn8odESOtYvUknmtzo7qwcwfmU75RNuxID7+S2vzG5?= =?utf-8?q?oeRR7jcnfp0CjDXdM9McWmrigwlTmtW4JYvz7BxZ3std34sxi2GPQTE0uY+2IZZhi?= =?utf-8?q?75Ip7lob1RNe6Jo86rpDzT2/AbWhQcZcYloUkgFFVZQlDj0RfDfIvEKbRCSCy/s2v?= =?utf-8?q?lkpqTvKUmvkQ56ydrb4GIZlOqinWqjSl91MFsSRJS1tnMoRotaf0FF1w8nFOdAdYv?= =?utf-8?q?fwkySxhh5NYHN+l4Lto1oV/xHhfZuFpuo5yd+LFHO8GQYRojFlHGjgziqdEGIWeet?= =?utf-8?q?kKk6lm3tmHrJbtMtSUN180Ilf3mo2yQDAWYUKYMXK+ExnmFYcee6b4Cf9ljMnndLS?= =?utf-8?q?rHyig86h0KIrlIogGBZtP6GG6xy+MmT9z/sQoTE5mD9zzmiMuWVq61NNJkcA=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68c811b1-e068-4ad9-aa43-08dd42c10c4d X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2025 13:05:06.2106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P123MB6306 Minor edits regarding use of spacing and proofreading. Signed-off-by: Manuel Fombuena --- drivers/leds/leds-st1202.c | 48 +++++++++++++++++++------------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index 927874f20839..cb4797ea8f3a 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -16,27 +16,27 @@ #include #include -#define ST1202_CHAN_DISABLE_ALL 0x00 -#define ST1202_CHAN_ENABLE_HIGH 0x03 -#define ST1202_CHAN_ENABLE_LOW 0x02 -#define ST1202_CONFIG_REG 0x04 +#define ST1202_CHAN_DISABLE_ALL 0x00 +#define ST1202_CHAN_ENABLE_HIGH 0x03 +#define ST1202_CHAN_ENABLE_LOW 0x02 +#define ST1202_CONFIG_REG 0x04 /* PATS: Pattern sequence feature enable */ -#define ST1202_CONFIG_REG_PATS BIT(7) +#define ST1202_CONFIG_REG_PATS BIT(7) /* PATSR: Pattern sequence runs (self-clear when sequence is finished) */ -#define ST1202_CONFIG_REG_PATSR BIT(6) -#define ST1202_CONFIG_REG_SHFT BIT(3) -#define ST1202_DEV_ENABLE 0x01 -#define ST1202_DEV_ENABLE_ON BIT(0) -#define ST1202_DEV_ENABLE_RESET BIT(7) -#define ST1202_DEVICE_ID 0x00 -#define ST1202_ILED_REG0 0x09 -#define ST1202_MAX_LEDS 12 -#define ST1202_MAX_PATTERNS 8 -#define ST1202_MILLIS_PATTERN_DUR_MAX 5660 -#define ST1202_MILLIS_PATTERN_DUR_MIN 22 -#define ST1202_PATTERN_DUR 0x16 -#define ST1202_PATTERN_PWM 0x1E -#define ST1202_PATTERN_REP 0x15 +#define ST1202_CONFIG_REG_PATSR BIT(6) +#define ST1202_CONFIG_REG_SHFT BIT(3) +#define ST1202_DEV_ENABLE 0x01 +#define ST1202_DEV_ENABLE_ON BIT(0) +#define ST1202_DEV_ENABLE_RESET BIT(7) +#define ST1202_DEVICE_ID 0x00 +#define ST1202_ILED_REG0 0x09 +#define ST1202_MAX_LEDS 12 +#define ST1202_MAX_PATTERNS 8 +#define ST1202_MILLIS_PATTERN_DUR_MAX 5660 +#define ST1202_MILLIS_PATTERN_DUR_MIN 22 +#define ST1202_PATTERN_DUR 0x16 +#define ST1202_PATTERN_PWM 0x1E +#define ST1202_PATTERN_REP 0x15 struct st1202_led { struct fwnode_handle *fwnode; @@ -99,9 +99,9 @@ static int st1202_pwm_pattern_write(struct st1202_chip *chip, int led_num, value_h = (u8)(value >> 8); /* - * Datasheet: Register address low = 1Eh + 2*(xh) + 18h*(yh), - * where x is the channel number (led number) in hexadecimal (x = 00h .. 0Bh) - * and y is the pattern number in hexadecimal (y = 00h .. 07h) + * Datasheet: Register address low = 1Eh + 2*(xh) + 18h*(yh), + * where x is the channel number (led number) in hexadecimal (x = 00h .. 0Bh) + * and y is the pattern number in hexadecimal (y = 00h .. 07h) */ ret = st1202_write_reg(chip, (ST1202_PATTERN_PWM + (led_num * 2) + 0x18 * pattern), value_l); @@ -288,8 +288,8 @@ static int st1202_setup(struct st1202_chip *chip) guard(mutex)(&chip->lock); /* - * Once the supply voltage is applied, the LED1202 executes some internal checks, - * afterwords it stops the oscillator and puts the internal LDO in quiescent mode. + * Once the supply voltage is applied, the LED1202 executes some internal checks. + * Afterwards, it stops the oscillator and puts the internal LDO in quiescent mode. * To start the device, EN bit must be set inside the “Device Enable” register at * address 01h. As soon as EN is set, the LED1202 loads the adjustment parameters * from the internal non-volatile memory and performs an auto-calibration procedure From patchwork Sat Feb 1 13:05:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 861382 Received: from LO0P265CU003.outbound.protection.outlook.com (mail-uksouthazolkn19012052.outbound.protection.outlook.com [52.103.37.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D95E2C9A; Sat, 1 Feb 2025 13:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.37.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738415161; cv=fail; b=sgwyADekK1nt1QLwbNZUlQO/yi4kzJWXrTL2Jd9Yq4zb7ypVx6Yt+bO4JZzmzEI99OkQ2FQZOO7o1Mbfd9Fj29sQLP3dbgkHsxuutKGUm66OW4RS/NcwTLAq0/1tTBLU+UaVEz3TOqjsvtM1o7rwQrdxEaQb6aGjDP/3f5ZDV8s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738415161; c=relaxed/simple; bh=CeEs0tEqh2VHiqu0nnNFXcqlyix7Jwj+FjjUb3X6PdA=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=FJjRiEpgpPNjisK9nkGAEed8NJrg0LFN4p2vA5a/NVAcKJdKOogvan5rnAMpFdL3B1YTX+4WvmKo2e2bqTngooeRREOlUrzy9F3Rjd09cYg2+vx1ot2FnSmyTWCPcv30jbbDATpxumab908r4hriozh5t6uFycP/k/HyVLLpmb4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=eFEObfOW; arc=fail smtp.client-ip=52.103.37.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="eFEObfOW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CqiKp0uMKU9Fz+7+b5jV+mKWKj1Ul7xcseqE4rEnWc9VyeeSSAJB9damFmAi6B/pOEnfqcNRIlH6dQMIrqfeAyoGpQnv0ndRZO+3LCAQcJCg3EhDDsDZwscm6V5zr/1us4jnhqUzDEOoNbHbHQMVTWIRg/fxZa0uX1iD5O0ZL61BM5b7Ki5Q2e8m17SzDadmhFhjikgI8AOJwharibgK46xBm5ucyp0Mv3U1WvuTdc/HTSnxp+Aefo+C8xXZF/Q5nMuE5Z1uN6Nf58qrVCA+XZa4Y9mLu1xHDnRIrmfUtJw6e8uwYjyY+6eMNdnaEOQV/h+t+9wtvNu/hb6c9m6Xtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BPY0T2zsvShqqsPZGHaIhc8jpaX8rvAk63Ts2YuoaZk=; b=CaZTKKWgwaWxsgFcHLtv1FJR4PTf+6jkH+msT5C0hIZKDM1hodfBQmkM2fSJZSnokIDdAqBWjyoU6msmD0UURJB0ksVyNIZJJbGZIMyEai75VISQ7+1yQbcmlRyAHdz8Qz0G9G7zKlm96lKHBp1GDkf2RjrGt3EzMwjzT7ow2EF2GUbLTsj2rcUf91vj5Yg45wpcHc8zhW7s83YA2FFEnbfrEF/AbrACG7xpk6D8TewtouiKl+KJXvYxCbsewazYNWUINIw9/TbRRJF6TassduAzIGTgaqasJhaCcuI6bq7BFYYJkcfvSYzqWAvlW71exm0/6a6KpYWwFkCVvxJVTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPY0T2zsvShqqsPZGHaIhc8jpaX8rvAk63Ts2YuoaZk=; b=eFEObfOW3W3jdfYGy/NcmXcxNN1zEzcpa7AnXnv/D/IUzrLb227erCQLiEmUIVoeU3iukoEZg3lgJ9SmRLmMzGazShccUOZjDsUcVhsW259lJS/l5pP8fmwlDLIQuL4/XmU0PhUJdlxxWJnWbb0wk9goNhbf5Kiw5PAcILbVGvnG2YowUL46lkWVGbDbJoxdT9B65lGuaN7/jKNX84kjZzxmKJBBwzjPbxOY2shmPaH+5s1fW8rnQzSrEW3jL+dSBuJ1Nof6Icq1h8xDr1ZEA/11AeOUha2NdMmq4cRDDIZ9aoxnONAlDd0kIlfwIGuQ3eS3UKCvQrf8yGENX2gFqw== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by LO4P123MB6306.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:299::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.22; Sat, 1 Feb 2025 13:05:57 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%4]) with mapi id 15.20.8398.021; Sat, 1 Feb 2025 13:05:57 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 4/5] leds: Kconfig: leds-st1202: add select for required LEDS_TRIGGER_PATTERN Date: Sat, 1 Feb 2025 13:05:56 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: X-ClientProxiedBy: LO4P123CA0633.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::20) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250201130556.1697791-1-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|LO4P123MB6306:EE_ X-MS-Office365-Filtering-Correlation-Id: 3289b6bf-68d1-4317-fe12-08dd42c12ac3 X-Microsoft-Antispam: BCL:0; ARA:14566002|5072599009|8060799006|19110799003|7092599003|15080799006|461199028|3412199025|440099028; X-Microsoft-Antispam-Message-Info: 6WtFGB2vsMkXvgTWdCRRTIdlwLWBTokvdD4m+dmy4k8p3r9FXhOPLV4V2C7CXYaNWsejIP2I1UxTDYmyK/de5NYig2FU8JFvbFTM81G4tOVulPrjefS7+m3A6fLldlSqU7NW1PXrcnS2KJYh0wWCKvM11ZF2KB/qkFfsgoHpMwcHUKphyrjeUhFfnuwHiSDO5HB3391FpbiiJTDXLV3cktznVFTdr67/fB/1bwYfiqSus2wGRekYBA0yfGn4VMAXkCnKaoupX9iQbxTKmujukR6j/DZ1F10/wSQ1y70Gv6e7JXPMff+7Z9WZFlb5ZI6D2nVEhUD5D3wbIWnpsoaMX3pvsTXWsythS47WBIoJSvzFP0yrieDtOl4WIMYAE/Q8sY23R4MRhQlXyE700dB9K4uRNbJsksEzIFVUKU4vtebO3kc9SXTxLwansKM6kxkoezI+8N0r2unU2xRT7LhoRHQZ2+FA8woDDsh7Zbdpxuj4OX26dlXT/bTA5oKKDppqYB1e3uwLtR4RVH0JtE3b0ax7GcL/XJY5wKZD2b7XACZ8CZ1Kptk1t/HlhA0AXa176GOMEt/naRL9ur1C0Bat1oseY70o3VxZp+X5zx8rK1ZHQXc5jM4knzfoQmZ41uk5N76qktrQlu27LwKuflS6aSVJfpjuqpaE/Q3JgGSdfrs/3FmOZnZC+VE0A3WlAyuI+0eYYezIZhrEEqAYPTj7/MHyqSxGckvDCsUK/x+4sPJcxK2TwQg8JDf75UNrl3eTawbYUsQ3HP7lnj2SdYRk7TWbGW273erhHWcOLGiXDGc80a7RvplN26CFIq2jS61Bnjbo5sr3TjEhXZjmfOnPI4+6+jofD/GLvDUajYiwRMzxFX6J02IJbAKauFGMqRcDJu1Z7RkNRjgbPBGz/M+GiYeSq1CCpglRKKM9NNpxqd7OI7ZPwzGK59NSK0OkeO0FGNVh59r4Oi3NCxUALMnRnYyt7FR5DcdkDBen3+EpuyLlPQdcdSvo1AVmsqrJSN6dfxVWFTslyywiHbuRUDaACEV+gRozHYCF6M9btLpH+4JFM+dxK5mmFCacKzhCalx176FDopCJUfusv/al/zJqbw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ft1Efd3F/pKwm4ucAARDODFyT69kOgQJtmAqSD2rKCvkwP70Ql+O/VTqBr6WVNFR6FB7jOy7MXInAQTlkZN6kNRghw3zOeDN3BCK9G8Y314J3gNM8aYk5PvrnhRZsNq+PmfkH7UxvAFgcNycVe+KhAt3aN1vPxNwWUVQ3BCV7iBNo171FLkRdDTRzxRPIFd+K7O0oRuEJGwvqZfoYoyoC1vGjtQYmIrH6XSnSrVbYsZnFnFJhN3NAH6qbxzHqIrKRQveHQzr5OOuaylOy4Pn6oIAnsITH5hHcdNWvt/qwndeVpjnAa3z4AGQzlXXGwVZOGKWgieOt8dSf3+6NOvCpWaRQjV1KKzr6DyHb8NuDY/njLmQJNb3H7G5eKkE+7/d1F/L5k/Th6144W0hk2jaVXfreDEp3iWn9RbOiqcZGg84sZrbQhQWt62l86V7ePw9K7i6WQD59PSGJJTAGQdI/xGh7P/xr1vYarjCUPZVH4GsqwxKMvjATEQfA8WBMI1pxKm8FDLbBCnmaJVrLsljbI58noIsdoEXr/EvhRQuDRjvHvLcyo0jsF3SbA0VpQxewuiLYGM9o3uH9B9dnXnyL54aKueBCqVztlwDhyoG9vt1oJ3wYiSQFGVlpY3BAJxXpKoAGL+wzOlUQv3dCRNjggnFVnClQnlwu8TCLLZmWHU/bkRWyseDAU7a41u3JovjhLn4M0zOycKGHZEeBiznks5Avc6KKFYIunb8hFD4LNFrfZ7+4xQE8aieV8Y+/DrJaw97egaiUcf1haZ/uhi/yz7e5jDSoV7zOVIpvG5c7VyCynvWi40454szF8EZO0yZbiJIL316gvAobEiVELWcuGulU9uf8h9MY8wTwzzY4WZYTzNpsobJF1jh8ZbOweFHRWoDQ3tk8b1+VWxxOEqM/v/VomdQaGnE72hXb0Uygx3nh27sqoYGsVhnG6b8q7QPaC7ML3GtNDZ26dznugm88z2Me2nQ+s/U2eYBr8uO5S0GXXzxuI8s3lNXNzdaChkDOzuMR3V75KIer3elR0dAev6XOzMB+MxHTAAt7gfVIoibBlHG/4u1knq7YXCWYAOHlKT1E9B+y8tIi5lsF+vu/cHM11baANWUAkHHauWYFUYPROBGIrO2EO/M/ZU56RVlV7M3k5xRkXXqB1T1Qsi4Co2gBO34c6W3uwPVj7+4Wv/PupGlrgaeoJHDuGAI4oEEbdIXc2pFCO6dBhAlCHNgc/OmD0Zl4hLVF8RAyIm1wucaxOD4bIHdEp4aVHZSx8YeaeMzuuc3cEOUrwCXyQG+JD9uuy4waCTFg68008Nf0C8= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3289b6bf-68d1-4317-fe12-08dd42c12ac3 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2025 13:05:57.3439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P123MB6306 leds-st1202 requires the LED Pattern Trigger (LEDS_TRIGGER_PATTERN), which is not selected when LED Trigger support is (LEDS_TRIGGERS). To reproduce this: - make menuconfig KCONFIG_CONFIG= - select LEDS_ST1202 dependencies OF, I2C and LEDS_CLASS. - select LEDS_ST1202 - LEDS_TRIGGERS is selected but LEDS_TRIGGER_PATTERN isn't. Add select LEDS_TRIGGER_PATTERN to Kconfig to meet the requirement and indirectly document it as well. Signed-off-by: Manuel Fombuena --- drivers/leds/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 6efd514bfb48..b585548c51cb 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -960,6 +960,7 @@ config LEDS_ST1202 depends on I2C depends on OF select LEDS_TRIGGERS + select LEDS_TRIGGER_PATTERN help Say Y to enable support for LEDs connected to LED1202 LED driver chips accessed via the I2C bus. From patchwork Sat Feb 1 13:07:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 862319 Received: from LO3P265CU004.outbound.protection.outlook.com (mail-uksouthazolkn19010003.outbound.protection.outlook.com [52.103.37.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0B272C9A; Sat, 1 Feb 2025 13:07:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.37.3 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738415227; cv=fail; b=JTBEHsSILBg4NsXr7OB1cMCH9ehWIZUFMoqaTmt89doK1CU6cjXnIAjjkhR8JW4nueFAYx3FO0iAabN+mnqBbcrNVVo0oj4DMTiiOLRZ0GpeSkLD1FnirtMA8a1ZGKtPDfYW0PEB442s4CrreiUpHypMa0qE0oS4yNiOrOryHcw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738415227; c=relaxed/simple; bh=lgiXXvCaKcBCyhP26HiVwsbPcg2M35/IDLImVgQ7rhc=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=oGCISN+omCnIVRUqpYg0DfP+OIdiUWMlxBs2ofn/nPZhBylkLR+xqVHY5jxK+Uy+g4DXSH80wmjyJI3xSuEXyQk7fEai/3uVi/Qx2tEpvGqtiSxn5WL0FYB0JggWvyOVoFaNW71hk/gJrXijsmjreLLdnnXginPXk1LAgi5wAuw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=E/dlCQB3; arc=fail smtp.client-ip=52.103.37.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="E/dlCQB3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ws9TuQ7K11x1r/3C77xELOxaTaAp7iCimevrMAyd5ecowvKSG3p9CQgdhFoPon/COLVaYQl6ZM6oCCJL2G1ficoDKCdlmc/u5FqARPSDZKuXhDLug/9L1KEhP9cfGwqeyl70TUWv2cHVfNy78oaNLvthCG/Ysnm7zPhPCQYQdJTyi4b72pnqOYI3eRYACilhTLk6zkV4uEpAKHSCuzYlNG5Gj/J2M0a3+HsQKEhzZUBId6qQnkwLUMRqSJex7l9y77/j3CL7q5mRKPhxkLIy0HHsLgPggSD4/gpJMbekrM3x+o7aW8Ce9Jbk3RAOReGKmkMOS3pGXlAasHGpbVhJiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c9v2O0/2Rxg68/EBe1Ab+v/cvXrGzztTeldf326wlbw=; b=Ku6nRBtXJ++VGBuWhqJHCKuFkMjXLo72odJjkGl4Cf3R5gx+7fPxv+l68zRlZk5XeiDstjpF6X1K9k5+gCqd9kzI2iumwsT9y0dkF5NtKyzaVLYBu9lb6n//LTJFCXLqjrIN2y346jyePFNMH1G9KZLjn2J5EySNlBSmgUt73QwYbonI1rp0bk1obGXn/mmxpJcECTJ2/+/XCHw0ukd83U3HiPa+zzme2fuUEjeyjIvfHXbBvKv8mLPmde+ye3Va6zmWHO0lsPq6juOSuTcLbuV3x2SEiVFfwY9uOvC3+1RrU6mvyIuk5Bx8KIM7AMckSEAxPVqCBbmS8n9xQspEnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c9v2O0/2Rxg68/EBe1Ab+v/cvXrGzztTeldf326wlbw=; b=E/dlCQB3n44y6NCPXD9MNoh5tariqiOcFcex+UR7KA3hNhL8/Eb8NGJPLkP5AUJFwVXvTjRBEPY4gMi7rCdcMA8s3/+ZNU8csTNhbyyuBgSNr64ecRJN8myxO8oUDhsBH9IMWey0aECcGOUtyAL5r53vcqhqpRsD4/dd2dsi3X+ejf/AoWhleG2kVBLKpt75ibjwUnYr9TDdB8N4TfsruFngU3RxHBselR5VZSdFu3ceUT8iQ9GlVwl2LAmz+TA2UkltkjrrBzycEczdPCMS6T+blGFqEaJ2t7Wdc+maJyM9LmMB+IbFFu9kCVTSiyU7VngOCBcwYSarHS47eHdCQg== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by LO4P123MB6306.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:299::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.22; Sat, 1 Feb 2025 13:07:03 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%4]) with mapi id 15.20.8398.021; Sat, 1 Feb 2025 13:07:03 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 5/5] Documentation: leds: remove .rst extension for leds-st1202 on index Date: Sat, 1 Feb 2025 13:07:01 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: X-ClientProxiedBy: AS9PR06CA0527.eurprd06.prod.outlook.com (2603:10a6:20b:49d::27) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250201130701.1703497-1-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|LO4P123MB6306:EE_ X-MS-Office365-Filtering-Correlation-Id: 54d93622-d9a2-4c5b-a071-08dd42c15220 X-Microsoft-Antispam: BCL:0; ARA:14566002|5072599009|8060799006|19110799003|7092599003|15080799006|461199028|3412199025|440099028; X-Microsoft-Antispam-Message-Info: 2xX1PGTfp1Y8fpbjj8NjMuqWU6GxLwqgDxJLNsvmLe8eXoB/W2nIaY5LjXIRzGJnTtC9P2TZ43Zcp8BYAzPqImMnJxsolsmYngoFavKx8GQvoJwnyOk0a002Rwsxbj4FX8q5AJNPOHIBYYOsPMcGWl+D+h4y83mgujHwJKbZhhUZhMt3m3zzQQM4aMUUsA7xMOBLqwGCmAykOOU8uk85ZMjK9+27aAt8WnhWeRMUpCGW6JH79pBr4WIA7ntqyvJAx18G/F4g/9cLBALPv5HbLig4c8rBN+CNc9Ep5dgIOEoMD5WOyVYilnkzVtwADhVrTLKQ35TN7fUQJfVA76t88iWxKzYd1Eai+96r4vAPC4Sev1xpxxDPgIka2qV4jlzE755uIhYwlrs6RX4+aWgVY6a4TedacSrKgJ1UqSXKNk6jb8swUD6UMFkUFo4UimT9hASvDb0RLtI8md7bZcQL+ELN3csnK5doDkRSpz64gNugknDYEEh6mwujzzMbajKGyMI+Aqv/ob9IX13mNOABMHrDl2f1XgoFAq57tYN2IhWnNrcGS9lYYGcxPolUSxHW5VcuQNpLuHcjdu20J17uK2XUvGDigFe2RQLZ3WVJCW9IIVdTKw7Z8lxdVPndbr72AfXDkgW5Gp0AYDaky3rMysbxKPukm6d9mV4chXnP4w03yXv8+6YVoaR3o0jQs3njmByu8sR7NJPeZUzKWPUOLXbPWCdRyLvkp0HR4xwxGzHJw3Cnfu12E6Sd6odNTt4RYxwnNdeuD+bzUmjLONoxfoHFqniFEotiziKZ8BcZwrglxL3ga0E0RkkuG8XukZVljbOBkKCNl58g9RDM1u9daWq9RbeO71VUAhdmpZtCLNPnekYngPW3VeYbUln31Qnp/SCsKDRy/gdxzKpeX1oyNiaWlBP64iAiVuHKmYo/cmPcy6ypmapaUyCySYdstuWkHoikqISzjoKaTDHC/+uW6TuBkfiI8/5un8Y7g6E0cFHFfrSyTMy7ompJGdf9AHdDc1G+tfb5NafQxbEBK3C5Iytc+pBQuY5ApPixDyaEzRKxfhRJljjXUPb3TJnaSIrzPPMCqmVkLeumGruzCi9wdQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YLTAN0EiEuQGpmdA54Xuxv73EquVjJ4pASPvTEJFfzUJwEMiaXrWA0+HKWkCpYRvbkxlweSSklG5M1MNVlfHpsTA2yEED80ygsKJlXutvSeBYA90J2oa/N+retRGtS6ABxWtrdiJoqI8kmLX4FBSzZxBJgEFJcpPS+eh1cnwLTh19NfP+Gek5p2HmEUzsOB5ekAr00BPy9MIke8JScgHzA6CxgYRk8m4KqCFEZc8H2mrC4bJMrRLF+r6bLaxsuz4bpThADXBH5m2zC8z0sblQMKOfiMDkpO7S0RYOagEhZfReKyts5bH4uKgrsy0CggtUmPiKXJ6EwQVwes0y8kMgW95W6w0o2nA1vf4NbZgPxlpUwQASCqQJmuMp0u8okVR6CWPFc6I/n+2egXRAAi0EdiCcFWLuLre5BsTEDNFyW6iFRaaqE9OlwyMDv43DAk1+i8HUutORFrPxzJJhHtKnpWTwBWznF58Bbh0Rx23XTayaiiqPnjVkGKzAVDM7oV9+PSAOSPed2Og9DvUgD15yaT4sIEdZRREP/eHv7OyrG3IPU5b/N/N6kGOpha37Wx8s6NY0qtqDOVUg8hojdsaQwinwvog8y9oi161AZjMuYKuG201NOjxH5Ks054tnrvc123ZflSc+Jt/kt9y1AGy/FT7VOLb1I76pD86hUJe4BULa+5zSDzB+tzJYKOLcI8iaIeFrRCUdrbUrIO3DlHnWcQpbfni8WrMHnd9TaPLAwQTf2Rn89/Fsfvr3f08DAoevyufVdbGZD9g7Mzncy/F4I1erC04L+O0lGMS8Qc2HbJ19XVYKZCtYfntA2wm36SQRE3NaWmhVuWN6lN6Dsvn0K16XeuuvT1u2Ec1KYvjmlBbirMSQfpe03CFUm+vmPrCv14RkjYx3lEDTWNwfgbV6WQHz1dVwWKqAk7gTY8fg9N50cV413ovRxro+YPamIREVSYxyLAc4RjK3kMPpLOjC7BZIRNTqLQc4mZMGtwGas70z2kAe8S9UQVQwx5ffltwFM6pjdcmNXilnFbm/pTRXqmBi0O7fbXNe8FAmevwLiQzNa8cQ+hSzSr0nuwM+f/aaibJ+wwFffGUCX9/v+bgNsEffd7YH0uOcqAgaAon2JKa2XekjYyJDZnfebBxYdnLyk/d0PKANbSLIo1wC8rC7N15sXrF7pMwVJpp2unkhkEulNUH9/CmZBLAGArCY6MK4YZ+NdMIfSzs6I2cQNBNVa5SHetvuwnunF6yMp8FVNWCZACfivkQRbm4vSOJoZJewkgj9g198ghrrUjTpRNjB7PNWiZ1a8SWirrXoGgWch8= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54d93622-d9a2-4c5b-a071-08dd42c15220 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2025 13:07:03.4211 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P123MB6306 No other LED driver is listed on index.rst with the .rst extension. Remove it. Signed-off-by: Manuel Fombuena --- Documentation/leds/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/leds/index.rst b/Documentation/leds/index.rst index 0ab0a2128a11..76fae171039c 100644 --- a/Documentation/leds/index.rst +++ b/Documentation/leds/index.rst @@ -28,5 +28,5 @@ LEDs leds-mlxcpld leds-mt6370-rgb leds-sc27xx - leds-st1202.rst + leds-st1202 leds-qcom-lpg