From patchwork Fri Feb 7 16:20:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 862999 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e42:0:b0:385:e875:8a9e with SMTP id r2csp411133wrt; Fri, 7 Feb 2025 08:22:47 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUos8Fuzv42wey4xhNIsyns5fxD67QflbWwt8QTsOHX9xC6k5rjWcUYDW8fcT8hlAD0JzBY2Q==@linaro.org X-Google-Smtp-Source: AGHT+IGiCwnNUvFeuOgpS6hQN1hRHZfh7zrY/j75+tIRdDfGBthWJSS98FsigSTStAztjLT3En0B X-Received: by 2002:a05:620a:270e:b0:7b6:d4df:2890 with SMTP id af79cd13be357-7c047ba6b25mr667835085a.4.1738945367376; Fri, 07 Feb 2025 08:22:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738945367; cv=none; d=google.com; s=arc-20240605; b=BbF7tIa/r2e1AuXu+UM9HCkMEU6KypuKaS7KbfPmrlQKsOEb/w9WLcX/yYJd/KYQH7 j9Ap6Gpu7B2HuFRLSO/GPxCvn4J9SE6lBa5Ich9bJNzJMbrOri09a3Oxpf0dmFtVe67N UKIPkaL/oLARZLYmvGoeaYfi22S9si9xugQ4+5UYCal4IRu7ifmiEy2+XhBzMmEmRAzB xJo+i0V41VP/Hie8Yj9GAfWTYxEIOs6Wg7nJ14Q5b0ub55boafxyTBEkhm7wqTvvuYZQ qnEBOtSnTsPYr9pKkwzXFbp/6yufJQsKGEdBhjm0sA89PIgJJAJu68wcA2Oh5uA99UjT wtEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zLnalPDK5Dw5CE83Liep9DcgASL15xi5RCTTFoM4WJU=; fh=xdrybiWREA6jAEjrAhg7pj8R7jHZrbWveh/i0RAAHt4=; b=dZvID1swEgI4Cc0SG0/KZZbmA35TnWLfj3ytQkyu7dS2qZO6icj8WaElOLODtnpyF/ FmlwsfWRGl53Cp6xuA2P8Z4Ve028HXNqFzCgHf0kc6aG6sIjoVjQfXbl4nUnIrlerwOs dAhIbeIK5DhmymHEZoW4Huv/wj9gCOxojlqskWpUu2/flHAbLbBN8/5ZUJH1CB2Mi1cT YgW60XTH+8ILBduEfAGOvZ8gSEfl7L/bd7zVfKYldm2xaNDCAcVrGYhFPFqrRJsytb0O 7hvLvjIqQyg+7HwDKEpo/E3NV/JpfQlkGhle8gT/sYD35vvLGkz5ghVgScrocrkkIlym 3bLA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=emWCn9pz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a1e0cc1a2514c-866f9832f83si792283241.175.2025.02.07.08.22.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Feb 2025 08:22:47 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=emWCn9pz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tgR6l-0000wB-WE; Fri, 07 Feb 2025 11:21:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgR6V-0000u9-Tj for qemu-devel@nongnu.org; Fri, 07 Feb 2025 11:21:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgR6U-0007ei-D0 for qemu-devel@nongnu.org; Fri, 07 Feb 2025 11:21:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738945277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zLnalPDK5Dw5CE83Liep9DcgASL15xi5RCTTFoM4WJU=; b=emWCn9pzDIU104CxssBtyb+dus5e+QDZpUgCDSm0bE8CYYNkemFxA2eN8rXGFIgD4I44sX uOg78+O2D90SX4IldgMgoulsdp3CEU6dG7F30Bm6qWLWpISpFTkwjw5w7M0gzxAtaYC7xm WmIY5CJrJ4Pwr9qLE0KO0hZ6ej5ozHg= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-E0q3J-dVOxqFu9AHSp0k1Q-1; Fri, 07 Feb 2025 11:21:14 -0500 X-MC-Unique: E0q3J-dVOxqFu9AHSp0k1Q-1 X-Mimecast-MFC-AGG-ID: E0q3J-dVOxqFu9AHSp0k1Q Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E4B6719560B9; Fri, 7 Feb 2025 16:21:11 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq2.redhat.com (dell-r430-03.lab.eng.brq2.redhat.com [10.37.153.18]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 613A31800878; Fri, 7 Feb 2025 16:21:10 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v2 07/10] accel/tcg: Simplify use of &first_cpu in rr_cpu_thread_fn() Date: Fri, 7 Feb 2025 17:20:45 +0100 Message-ID: <20250207162048.1890669-8-imammedo@redhat.com> In-Reply-To: <20250207162048.1890669-1-imammedo@redhat.com> References: <20250207162048.1890669-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Let vCPUs wait for themselves being ready first, then other ones. This allows the first thread to starts without the global vcpu queue (thus &first_cpu) being populated. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Igor Mammedov --- accel/tcg/tcg-accel-ops-rr.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index 028b385af9..d9eadd5ec4 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -197,16 +197,19 @@ static void *rr_cpu_thread_fn(void *arg) qemu_guest_random_seed_thread_part2(cpu->random_seed); /* wait for initial kick-off after machine start */ - while (first_cpu->stopped) { - qemu_cond_wait_bql(first_cpu->halt_cond); + while (cpu->stopped) { + CPUState *iter_cpu; + + qemu_cond_wait_bql(cpu->halt_cond); /* process any pending work */ - CPU_FOREACH(cpu) { - current_cpu = cpu; - qemu_wait_io_event_common(cpu); + CPU_FOREACH(iter_cpu) { + current_cpu = iter_cpu; + qemu_wait_io_event_common(iter_cpu); } } + g_assert(first_cpu); rr_start_kick_timer(); cpu = first_cpu; From patchwork Fri Feb 7 16:20:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 862998 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e42:0:b0:385:e875:8a9e with SMTP id r2csp410927wrt; Fri, 7 Feb 2025 08:22:26 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWssUnMXXQHddPmGplGSj917pZ+ZlyiVv/EixpT9TbZXTxFZWImoonmYpxeWt3C747iFNx1Wg==@linaro.org X-Google-Smtp-Source: AGHT+IETcnW4zNLXRUHChrKJVbfcrxukuNJZ0WDH+FAWtHcAfLGequBKGRnv/60rMtU7UreaSuSI X-Received: by 2002:a05:6122:54f:b0:518:a2af:d666 with SMTP id 71dfb90a1353d-51f2e0c4d56mr2763069e0c.1.1738945346423; Fri, 07 Feb 2025 08:22:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738945346; cv=none; d=google.com; s=arc-20240605; b=i3kQpP2sqwnhrkQKqwG2vNBc82vZPSk7kHDMxNEBroD71AzgiRNbZOHClVh5/Z/Kls zAO9pyVn6Xu2tw6CBgVIKAng6q8x6Zi0DeRfH48vBw5VVjupKvZGYfD7iTGawlOVJdQt EbT6tOrKpZqdEL/2yzbIaj4jIPIyYreeILboxpiG4GQ+jeo78l3yvHfY5dD2HWdLtMP/ t29XrGQYChQa4Bgknp2PhgIy8F3ukFOiJ3D2Y2ZAmNuulmRS7n3Cb6aVjq0lR7GWg+/+ 0jheCiFWusqoQM4loUDL7w7Tk7jquGg58ftkpFDr1iEV5Sis7U8WWazgtkINWCPlA+d7 G6RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dS3mG7q7Qhof/soXKvmjdSRvuo+ZNyeAZO9Cl/N//jo=; fh=Qm4he0j/2HEFEky1nY3wE0kJk/SPaNt21SupHmhsiC0=; b=KHyVmoKJYKyuBF3YRKxo9areAxpbcE222eg5Y8skcVMirfiXiqVo/n4NwV6G8dm86C ddVK86viHAa+vs+/Fn4mKf5uXtyxSbswvKis1jMboZXw8kkLjj84tnuDMVq7he3m3Kvf /zKLrlOtdJc5Pgy8WI4HJnS5fIgjHYD4TG92FtvQFYQS6JU1hLUapFMBdWNkvr/weAkw DlUCgCeFhvNK1WSlCIJ+FQZtG8Yu9law6Vre5Px5B5BhE9i/PYb9cwjxOHvOiARZ8jpW pLbKJYdqu4CPmON5Jrs0uYxaVsvtVIieP3ElP/4G4e1G3PC0ZKvrDdkyn6rBxpWHP/c0 7shA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NPMiKoPr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 71dfb90a1353d-51f3a08eae5si288536e0c.171.2025.02.07.08.22.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Feb 2025 08:22:26 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NPMiKoPr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tgR6p-0000y1-RR; Fri, 07 Feb 2025 11:21:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgR6e-0000up-65 for qemu-devel@nongnu.org; Fri, 07 Feb 2025 11:21:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgR6Y-0007jZ-Je for qemu-devel@nongnu.org; Fri, 07 Feb 2025 11:21:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738945281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dS3mG7q7Qhof/soXKvmjdSRvuo+ZNyeAZO9Cl/N//jo=; b=NPMiKoPr4vEGuKfi4pDfZtZjo8rkC7MD5BRZHEu99AvI2/voyDtgVPKIK4afSG/aTLUm7z Z4Wko7qjFI3Kaul22vMSYVk3nQ2F62tSEnANDPWqn7j17st37s1qBUl2QV/g0oDXfZuRo8 qzw5lqlqfyit9SVXPpIMQf3YzTn2vj8= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-oMh-emOuOZOhvvgumhecOA-1; Fri, 07 Feb 2025 11:21:18 -0500 X-MC-Unique: oMh-emOuOZOhvvgumhecOA-1 X-Mimecast-MFC-AGG-ID: oMh-emOuOZOhvvgumhecOA Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3713719560B5; Fri, 7 Feb 2025 16:21:17 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq2.redhat.com (dell-r430-03.lab.eng.brq2.redhat.com [10.37.153.18]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E602F18004A7; Fri, 7 Feb 2025 16:21:14 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , kvm@vger.kernel.org, peterx@redhat.com Subject: [PATCH v2 09/10] accel/kvm: Assert vCPU is created when calling kvm_dirty_ring_reap*() Date: Fri, 7 Feb 2025 17:20:47 +0100 Message-ID: <20250207162048.1890669-10-imammedo@redhat.com> In-Reply-To: <20250207162048.1890669-1-imammedo@redhat.com> References: <20250207162048.1890669-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Previous commits made sure vCPUs are realized before accelerators (such KVM) use them. Ensure that by asserting the vCPU is created, no need to return. For more context, see commit 56adee407fc ("kvm: dirty-ring: Fix race with vcpu creation"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Igor Mammedov --- CC: kvm@vger.kernel.org CC: peterx@redhat.com --- accel/kvm/kvm-all.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index c65b790433..cb56d120a9 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -831,13 +831,11 @@ static uint32_t kvm_dirty_ring_reap_one(KVMState *s, CPUState *cpu) uint32_t count = 0, fetch = cpu->kvm_fetch_index; /* - * It's possible that we race with vcpu creation code where the vcpu is + * It's not possible that we race with vcpu creation code where the vcpu is * put onto the vcpus list but not yet initialized the dirty ring - * structures. If so, skip it. + * structures. */ - if (!cpu->created) { - return 0; - } + assert(cpu->created); assert(dirty_gfns && ring_size); trace_kvm_dirty_ring_reap_vcpu(cpu->cpu_index); From patchwork Fri Feb 7 16:20:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 862997 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e42:0:b0:385:e875:8a9e with SMTP id r2csp410613wrt; Fri, 7 Feb 2025 08:21:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUugoP8kEQJQCOCxqwPzBUHCevncRiT2CpOXWZgBsgZ3RZBL7S1qMO74pi/CjbMaBYTKFUxVw==@linaro.org X-Google-Smtp-Source: AGHT+IHNO3KB+Hw237eErF3hLc0mMsNJC0b95HUd8NIolr4MwApumIw39uLQqFPW7ga0jBEbwlG0 X-Received: by 2002:a05:620a:bd5:b0:7b1:4f5c:a3a3 with SMTP id af79cd13be357-7c047c49ea9mr604003285a.56.1738945314177; Fri, 07 Feb 2025 08:21:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738945314; cv=none; d=google.com; s=arc-20240605; b=NAejk1e9BHJm3zeClYomhzP/+e4ixgeVrbBLJy/W+w8D5WiLAGqyR9cAW7UsSjCT2D gM7L1cOb51XFw3KEPowZpk2Iq8q8xTIwlXuph/xH4979KDRKVxpyDiBIrKEyRB6Tk2/i JnIu+5+DayqQ+w6IvBs3WOYN85qKCS4BeCgpdwTKEd/l0VHKqwxwQbH5IWR+jDrafvOl cXl3iQ40bDLlGN9zpkLPBC9QwPSaiimiNVPJqp2H0JDu+0E9uQUUhEIQdi5YX1MZPApR KCPlCiTQRoeFg5xI3+yciE5WxwfwI2y1VzfmTk3+WSDCATLLe/upAavinn7OewxEksZg iknA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3WVrexRlab32QyhpO6UTZhs06SRUtIvJ5qxTfzSBSSg=; fh=PgKpMPhWDepZ3bXqZokANgkoavwJ2TlblR8cMi91wfY=; b=iOpLiNUxqoleI7XDeK3zGBTsPJoyl4OcpGuDHghnczmVkUwrStK9EtTMgByaPv3gzL qOsAtSpU1IdNcUybiB4UfCOUs67wr78GthWI09vpu13GJ03Xlztr49Cm2HzqtznaVADK ikgeodbSsUMUJ7ClGDk/ezcARVI/wi0CLygNOs1IEOfUo8hhyKA58CFETO4yBX/wTpXs CTC56dcxjS65l7REETQmGoLDlteNZWu6fe+SjH5Ks4UsdV9Cgn+ppOFWsbFOfBKiklKi qB680nlXktXNf/slVWzzgmwyImJ1Bnz2bQ3JkynMJo0F08klxhF+xO4hKkG8wyx1WzXt B1WA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DWVulNy8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c041ee72e9si349872785a.634.2025.02.07.08.21.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Feb 2025 08:21:54 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DWVulNy8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tgR6p-0000y2-Rq; Fri, 07 Feb 2025 11:21:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgR6d-0000uo-98 for qemu-devel@nongnu.org; Fri, 07 Feb 2025 11:21:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgR6b-0007k6-Ps for qemu-devel@nongnu.org; Fri, 07 Feb 2025 11:21:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738945285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3WVrexRlab32QyhpO6UTZhs06SRUtIvJ5qxTfzSBSSg=; b=DWVulNy8o6pjNdhFMmNcUontmIS8VGSfaPJF/UFpPCLqDxQlQedlTh+vHQ9iPiungbqK9S uUqaXMOKNrzXc8+lcKKY8hH+JZMTId04LzefugOtRhRXFULENnu+KqCXJNoe+S76YYbgOu QqDLjhsai7HjfgYAeNY5UtrK1c7Npw0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-326--t9MizpNPHC3KSb7onlIuw-1; Fri, 07 Feb 2025 11:21:21 -0500 X-MC-Unique: -t9MizpNPHC3KSb7onlIuw-1 X-Mimecast-MFC-AGG-ID: -t9MizpNPHC3KSb7onlIuw Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6DC0219560AD; Fri, 7 Feb 2025 16:21:19 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq2.redhat.com (dell-r430-03.lab.eng.brq2.redhat.com [10.37.153.18]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9C870180087A; Fri, 7 Feb 2025 16:21:17 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , kvm@vger.kernel.org Subject: [PATCH v2 10/10] accel/kvm: Remove unreachable assertion in kvm_dirty_ring_reap*() Date: Fri, 7 Feb 2025 17:20:48 +0100 Message-ID: <20250207162048.1890669-11-imammedo@redhat.com> In-Reply-To: <20250207162048.1890669-1-imammedo@redhat.com> References: <20250207162048.1890669-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Previous commit passed all our CI tests, this assertion being never triggered. Remove it as dead code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Igor Mammedov --- CC: kvm@vger.kernel.org --- accel/kvm/kvm-all.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index cb56d120a9..814b1a53eb 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -830,13 +830,6 @@ static uint32_t kvm_dirty_ring_reap_one(KVMState *s, CPUState *cpu) uint32_t ring_size = s->kvm_dirty_ring_size; uint32_t count = 0, fetch = cpu->kvm_fetch_index; - /* - * It's not possible that we race with vcpu creation code where the vcpu is - * put onto the vcpus list but not yet initialized the dirty ring - * structures. - */ - assert(cpu->created); - assert(dirty_gfns && ring_size); trace_kvm_dirty_ring_reap_vcpu(cpu->cpu_index);