From patchwork Sat Feb 8 17:36:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 863489 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC9B11F30CC; Sat, 8 Feb 2025 17:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739036197; cv=none; b=hzGdxET6p/bhrGoQpCLJkWDreb4IAi04BvuELHYCsJm6d8vrdUK+N1I248iEyRnRY4x8n577CYRcUw/YjKierkW9wmPb8l2YT7qB7GNxY2cwwjVJR9zszuuXPsaCFXINFmvgMRhQLwmkm6T06JQghBHqEJG1EBSFnFbZoORx7dk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739036197; c=relaxed/simple; bh=UWXrf7WRGjQt+teMGQjTFxcuMT0+nwb9fGdcN/5Iv4c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=vEY1eWIHHheTb+Uf2SfAKlJX22fwDw4XubHkBqM+Ih1jofxIbpXB3xIoj7B57V5stAzy91MnJPdLyFrRlRNqsxGkJpYZjNmHd7QRSmJHbDDq1go+esdyh1wdHXbTaMp1UQTIbpiLEmektXIZzensordu6XVhS39ZPPuuGkxYYDk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EWYB7Otn; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EWYB7Otn" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-544107119b5so387464e87.0; Sat, 08 Feb 2025 09:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739036193; x=1739640993; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5qTyscYdIMBi+D+hFlA5BfNGHhqpENIsWeUFDb9bmok=; b=EWYB7OtnaghmYUQ/Qklyo81kU+SQsYjU7MiArTls6xiEIP6lH3YnKQ/sdOjy1Qbcl1 CWzAIV6W1SRgF8LGkNBVTBedWZwNmZthQbuSbeym+2juMgHtZ5kmG6J9to5Y5dJKC+0e RSn/3l3e9NWp6vPZt1+JbRjmBYQWye36J6njNO70OqZGukKPtSt/i0J3GkZm1ZCTAc8o EhKhOmPIboyLyEmM92jtJduhirl2ajEW/04qHWCwycZQ3GRFT+wQym6KjVh/ml8fkUGS 2RzzCTr1uoKKrB2jfeUVrt2O5pGqKqIasSj40g6nqul4cvTFXg2NXwmzOR5AhZT8U7r5 eeSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739036193; x=1739640993; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5qTyscYdIMBi+D+hFlA5BfNGHhqpENIsWeUFDb9bmok=; b=BvqIlhRfe3HxC1mtkvjWqmnpbL2pje7eAceKJUBpnu1YDXHKqf1Wfon5KHenFvFMJL J2yhrw2NPvHVtC5G4INhJmIcXjVj2VYA0nJ8RW6/2mi2UKoh8vuH7PhqT/yJj1KsAMKj f8Y3xgfwPCQWGQf6lJXPNsbUK4TPrglv/GzJSipfdRVQo7uUdpSU1qInYdgjSfAWfwXP dbDui5uBB6+lyjzRdj3a+xHYAUvArNLTKu2DEoUVl8ZK+9XComk6eA2eXHlMxqpQX0XQ SnoXQnzgYSiELAZ42/CYxlUddrk2NO+0/pdE0W5Sb5yF/Ai2pLCeuG/uDKdalf+saP6f CZCA== X-Forwarded-Encrypted: i=1; AJvYcCUgZ0ghAFKfSNfRtCjVuhgVHrnT0aVIlfagC8NM2jRW7GfAc8XU7FXz5liw71RHDvodrVNhoyZOwX/m@vger.kernel.org, AJvYcCWOQAVWizIT7wKsUDgkkIh8ndIXGl6lSfSRFMj+37bC1pGvah1K2RFZtL2xLgFXSeJD1gK8uM73SmdTgA==@vger.kernel.org X-Gm-Message-State: AOJu0YyrJP5UwjLpBfh2IkLFvS4Rtzx4+XxPNRyn8zW8vwYg5XHAXCyl 4nhtfv7CRmgwXAuCWWPwebv7sVU2zNoMo+Uo16zgw3hDnaNR1VYGDDht3g== X-Gm-Gg: ASbGncs0SvQ7hUx4a0kvQH2ROitBi/6sXY24tIkbmBI268jadqi/1Oh5LXiZfVD+CmV PuDu4SWzTtJNCK8CrBzn1Bt5c8MVHx+ekIrsM5FLoAteBWiM3BybEKIDEG83HH8n7L0bVGK+PsX /a0FBZNSjEyhYsps2AKxjBqEi2mV+E8DAwg+uoGzWt+O+Ejk1mdLrQ1CEZGxlTHMq7YXVTioIro lPJyJcrknXsLVRYocSUsGgAhLTvOdsiHA+ogZxSlLJFa9uvl4DW4J/QLFL0i+Djrw1vQvZOAa6A Ai90l7cB4sGqn0So7CuFdlKzY+bT4orhOMX2cSlz/VKlJlQD87C3yL5aW/Xmuw== X-Google-Smtp-Source: AGHT+IEzXg4/h1qW+N0hwaxDHvUXv1XDwdtP/qWm5ObOC7byJJ+Ur00PzE3XFWMLohbHM3WzHMfT2A== X-Received: by 2002:a05:6512:3ab:b0:545:760:44ca with SMTP id 2adb3069b0e04-54507604cc2mr116786e87.10.1739036192829; Sat, 08 Feb 2025 09:36:32 -0800 (PST) Received: from laptok.lan (89-64-31-140.dynamic.chello.pl. [89.64.31.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5441053ed99sm774808e87.3.2025.02.08.09.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 09:36:31 -0800 (PST) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: anssi.hannula@gmail.com, oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 1/3] MAINTAINERS: Update hid-universal-pidff entry Date: Sat, 8 Feb 2025 18:36:26 +0100 Message-ID: <20250208173628.5734-2-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250208173628.5734-1-tomasz.pakula.oficjalny@gmail.com> References: <20250208173628.5734-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add Makarenko Oleg as co-maintainer Signed-off-by: Tomasz Pakuła --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a7c37bb8f083..174d25d87371 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10258,9 +10258,10 @@ F: include/linux/hid-sensor-* HID UNIVERSAL PIDFF DRIVER M: Tomasz Pakuła +M: Makarenko Oleg L: linux-input@vger.kernel.org S: Maintained -B: https://github.com/Lawstorant/hid-universal-pidff/issues +B: https://github.com/JacKeTUs/universal-pidff/issues F: drivers/hid/hid-universal-pidff.c HID VRC-2 CAR CONTROLLER DRIVER From patchwork Sat Feb 8 17:36:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 863686 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC354241CBE; Sat, 8 Feb 2025 17:36:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739036198; cv=none; b=f9opkqZzj8R1OVleBuCEUE0jWtAWdDZQEqGeSgh8xsm5BWOKIccCHIcllNHEUkkhFzF2uO0MHUaKB3NdXOZfVr22GScInUSLXpZ5JcaXKR8MvfMxikkrpKai13d6Sl65RO/Q5fv/XC+XFqE+MjJP3u763CVJv482Ys6iMZVKMKo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739036198; c=relaxed/simple; bh=EFm9B1zuoNpYKwHlryPcFLvgSwAGhPb/usi94fz0fss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EIGxeUh2LHZm+ccLNR7rz01wntQkhOhFkC0HFEqsHPQfKPa+eGGdB3Cbj4WjobHpyq6ZjXBSs2C2tKvg96RRLVlGuSug0XfoC/fcSKyqGkCAQz7sJE2v0/XXVH5d1MRJL7J2rNQUkD6bOZxRi77f414g7VulzXAAEiFlY5e2XKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WXhj7X5g; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WXhj7X5g" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5450268e513so144646e87.3; Sat, 08 Feb 2025 09:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739036194; x=1739640994; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BsCCG2+d6Itgr8qq0djxtF9xLECC7cWts2B/KnnI0xo=; b=WXhj7X5gRmW1w7Cj4VRxP/LN7w5Qlkcz1NgTC4jOKAsLWysQnfpHZBBX+NLb5tEVEI 6eWDMUADqBoiXOUhnx4RCuqIRAFJsMIywMYyPHJ3D5DXaKxBeG9hehE19Goc7mDXWewP 5xipFWLZFNkHe4cma+KIVVWFC0TPbeyqUtCGRMAhTCT69R1Lr4Sp+5kp/ZRAtThwLa/n 3gMUq7GCyvmPJMgn4ZglFZzRj1fv/Hwe9EWK5B2Epnnu7+zjA4R0nTZSrXmtmYTL431W CgLDDWbRyoaKkHJYhV+pRLNMr3ckhB/uVGIO+XOlAAwwjczRuxDjGY+oJUVVgbuRltfP lT+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739036194; x=1739640994; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BsCCG2+d6Itgr8qq0djxtF9xLECC7cWts2B/KnnI0xo=; b=FPAtLdXLeOSNZB8TPVoYf+v8MMgI5Xhs5oFubQS1D2PaZBw7f1dIuNY3fNc60OKDKx gcC8+nuY+1myIeOg7Dta4C/latD8pxlAk2WRQHXSraG/ZxtqQGX6yB96ClpeeTWJJAAT 3EOwaAYXpTfAV7S71KGsyKho97FY+w3KFTuKRKXVP4UrXlx7IhoJNMy47MZVglZYR1N2 I0ZPuh8NQ86XiomVWwRDP6d18CYmKSqESrCrh/kzhGMpiveAvXr4/v4xLk4ZOgvEFj1Q o34MbxXhfuED1mvyybVv/3pBS0iHcja+J3lMhGWjKLBgDOZRdp9EY3kiO/OMXAALtbOd XU7A== X-Forwarded-Encrypted: i=1; AJvYcCUQwln6SQX0fRQtSjMiqUm4UMrJgwK8IiIDMOwWrN+tXeD5qE7bVJ2loaC8OSIPgYRP76uN4WK7biCThw==@vger.kernel.org, AJvYcCWWgMnNgW12sTm3WVPjHKnz5LWr26HmnHSuF21upL91zT6zJC6obAjtCoBZMcInJy5cmLdWYcvkRquX@vger.kernel.org X-Gm-Message-State: AOJu0YwTbGI5yXVxVP/Pj8aHpkWhnPWcMsr0AeaSaaBHKmHwJgZZH0PY Ye55Wh87qQp6HfnjNJqwqZg7Ovy9vI1n9h+RD27diI0iVY7/MqQO X-Gm-Gg: ASbGncugyxT2yjMwPLSLSMiQxz+MWNRmQXGDlJU6FgZX44ExrTodHiHDIHlO0dOQpj6 oT2EoWIF6uRNrbr3G6U9EfUArfK0iI1pvClg6tCW+CuHKjhxXhnEkUB90cKrdLD6NhDjkmsLe0O 2XF+NK1pPSN5IXGSB0s79FhiYUS3fZ5UgtMo9UNYXli05gUECPnxvEzen19L2BYraySFRQgpLz5 1JTr3oZk1Ctpc6HtZh1DrVeA1oHQ7F7KfZn4brEeoDDRhqulQpAU70up1+NMx2Fz78Oa0oD57K/ Ful18vrHLbUzh2z15lE8SPPqEZsW8uLndSZ+uwy/4QHF7gT/rsqgR1aLDIib9A== X-Google-Smtp-Source: AGHT+IEosY/otBc8OnVLqT6CbyGxzQPuSJHIEfGq1ufU7y/h67MwkRcHD3g9TobATdWNerO95qERzQ== X-Received: by 2002:a05:6512:31d0:b0:542:19ef:9888 with SMTP id 2adb3069b0e04-54414ab6965mr1010400e87.4.1739036193694; Sat, 08 Feb 2025 09:36:33 -0800 (PST) Received: from laptok.lan (89-64-31-140.dynamic.chello.pl. [89.64.31.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5441053ed99sm774808e87.3.2025.02.08.09.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 09:36:33 -0800 (PST) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: anssi.hannula@gmail.com, oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 2/3] HID: pidff: Make sure to fetch pool before checking SIMULTANEOUS_MAX Date: Sat, 8 Feb 2025 18:36:27 +0100 Message-ID: <20250208173628.5734-3-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250208173628.5734-1-tomasz.pakula.oficjalny@gmail.com> References: <20250208173628.5734-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As noted by Anssi some 20 years ago, pool report is sometimes messed up. This worked fine on many devices but casued oops on VRS DirectForce PRO. Here, we're making sure pool report is refetched before trying to access any of it's fields. While loop was replaced with a for loop + exit conditions were moved aroud to decrease the possibility of creating an infinite loop scenario. Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 34 ++++++++++++++++------------------ 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index f23381b6e344..acdcc0af86ba 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -604,28 +604,26 @@ static void pidff_reset(struct pidff_device *pidff) } /* - * Refetch pool report + * Fetch pool report */ static void pidff_fetch_pool(struct pidff_device *pidff) { - if (!pidff->pool[PID_SIMULTANEOUS_MAX].value) - return; - - int i = 0; - while (pidff->pool[PID_SIMULTANEOUS_MAX].value[0] < 2) { - hid_dbg(pidff->hid, "pid_pool requested again\n"); - hid_hw_request(pidff->hid, pidff->reports[PID_POOL], - HID_REQ_GET_REPORT); - hid_hw_wait(pidff->hid); - - /* break after 20 tries with SIMULTANEOUS_MAX < 2 */ - if (i++ > 20) { - hid_warn(pidff->hid, - "device reports %d simultaneous effects\n", - pidff->pool[PID_SIMULTANEOUS_MAX].value[0]); - break; - } + int i; + struct hid_device *hid = pidff->hid; + + /* Try 20 times if PID_SIMULTANEOUS_MAX < 2. + We must make sure this isn't just an error */ + for(i = 0; i < 20; i++) { + hid_hw_request(hid, pidff->reports[PID_POOL], HID_REQ_GET_REPORT); + hid_hw_wait(hid); + + if (!pidff->pool[PID_SIMULTANEOUS_MAX].value) + return; + if (pidff->pool[PID_SIMULTANEOUS_MAX].value[0] >= 2) + return; } + hid_warn(hid, "device reports %d simultaneous effects\n", + pidff->pool[PID_SIMULTANEOUS_MAX].value[0]); } /* From patchwork Sat Feb 8 17:36:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 863488 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712DB1F3B83; Sat, 8 Feb 2025 17:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739036199; cv=none; b=VueE1RhWduFfkiqzLBZpb4VD5tXRk/fj/LjBVnmiJBeqVjocoyLX3qeURz44Kb4w0m3a0crbPuoLSnqrPyZ0NBDzWx8RC+VISi3Mv2/J/TO+DmNFzYTz2x6jf5ek/c9yt6MIZwafAX8hX0i+M96lmoBaGMjv1ZI1SY1gAda1kww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739036199; c=relaxed/simple; bh=wJHdPFVGC+occ2U7UIpRUOC/DEmU7oK5Mm34Op+gOgY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uJZ1K0OjCmplz9F9SjL0B/cpUjNjjJFnqcGuUGntIk0LPKbtLzWp4Y7UCFashQ0QN9Xd+fYNrBKH46TBLE64vUk4vJFPpBVPXdEKypUYfuLumiSqTa6YWlfKg2thyydFr53sZ6scy83xgSFWV/+Ly10ioyk3YsTK8NPzF0hrjrQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CQMeB9Iv; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CQMeB9Iv" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-545061c740aso21522e87.0; Sat, 08 Feb 2025 09:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739036195; x=1739640995; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wlkH5nMfzqVF8gs4xkGrN3BI5XHhQSrRo6ixfZ5yb9M=; b=CQMeB9IvriXg+9oFRzfanhn5Q7LQN7SouSoJhlRKgbfxxK+YJkOpMAwH58hoVXWyrV KSuYiJ5lnoGT1HJD284Ip9A4S8yo5UP3z7d35BaG0+s3Ll3SPTRSNHv7wJ306g8PVfkQ dQRjMxNe49NHqMq64YcPW27ytuN5PJCDB78ITBouJPQOfJRgRN5jONJGUsQIVwstn/Qu 6s7SzbWQ/FFFKQ3BiSCDsZXn1AA9NU3qowEiQ8Th3nX9ARRvKJwiIVpRuMm89CdF7n9k uW7Xs1KUDeJt6U5HuHo5LbsFRwxMq8QjtGnyceJeyW86rCTw9Roq13xej7S1fu5Lm0Pd XLJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739036195; x=1739640995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wlkH5nMfzqVF8gs4xkGrN3BI5XHhQSrRo6ixfZ5yb9M=; b=P3n7utsa6JHoz7DKkt0mh3kckwfl44jeyANsG7+SwmAxiNxXEZ9r/tm3SEtNa8y96v ESQ77rcehZjcOMClonK4ZmTucBqKNaSYF3YXjA9S70FV0HdZHAlE5OLss5YPpikRvLHO VHWgXFwZ6CJYWv70MXsK8FCAfV8bj+R0psQ2+G1athtpbSS1FV7A2YOEfLcMLXgGXm+3 FONypMXvpt6UOzDo510ut9cljOWkY2F4kJ90qSMDJxdjBgtqivdbiPccIA/7Oku+EC/b L6R2NR4uOM0ODSAoeVgTzf7Jzg/0kGbLujjc/Ekq4HLPMZoyM7pYt3CbIxKaQ7hGvYpD 9TFg== X-Forwarded-Encrypted: i=1; AJvYcCW9lTSdrQEL1iy5nk0ZbKojUqCRRw21nd9rPmtPI53hcPsxjQQL1naom5IMrQWMIMh7bbM/J0XCOd6+5A==@vger.kernel.org, AJvYcCWmx0Ong+4XUx5xUb/LDckBB3hh5cAfcp7H1UHuJvaiBFb6YMJGu9fCdYHrrHvg2UjciYpr2TRJOlmS@vger.kernel.org X-Gm-Message-State: AOJu0YwzPR6M0RMuQnVEYzAX364f8bOfQiNcaZpjb4L3XplVfyVq7Gcb K+9Vs/j4DIP9MuZhiOmgWpmKqFPNpBB66PKYFtamF6sBiqOC53Q5/1YgBg== X-Gm-Gg: ASbGncsXvkPapGafPa/t/8Oz+a2wbiDKM8Amc6no71tMJploPOVI0ZhU22whXT7g7Su zH4Zd14LBR25/EyLeVTIvwNsTFTC+KTdTLsqgd66A5o4OusOBv/ZbFJ2PYuD1UXL6rH1XQKvSN1 XCSndCWQDZC2N3dyQOUZ+5AdQuMWLFmgF92YOhsAWMWnq+jkX0MbRv/R2dEeZ+t9xYxyA2MI0tZ 68v+piib90UNjSs/V9QLk86k73Jyqp1D/jlx9UDijJamO2WYa4PliqSp7qoBXsLpitdPVCPUFaU yzfrjHH4yYvlDVFHVypvPMT72oYKKRa1aD8MEQPIUqRyQl6Lb2alehEBneN4qA== X-Google-Smtp-Source: AGHT+IFijeM/0DacX9QB4pRuByHqnXgA7GzoztSYcM0PgME90zeEuiiXqrhjiVm+zcpWfXfiFXbw6Q== X-Received: by 2002:a05:6512:3088:b0:542:98bb:5681 with SMTP id 2adb3069b0e04-54414ab57b6mr950161e87.4.1739036195363; Sat, 08 Feb 2025 09:36:35 -0800 (PST) Received: from laptok.lan (89-64-31-140.dynamic.chello.pl. [89.64.31.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5441053ed99sm774808e87.3.2025.02.08.09.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 09:36:34 -0800 (PST) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: anssi.hannula@gmail.com, oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 3/3] HID: hid-universal-pidff: Add Asetek wheelbases support Date: Sat, 8 Feb 2025 18:36:28 +0100 Message-ID: <20250208173628.5734-4-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250208173628.5734-1-tomasz.pakula.oficjalny@gmail.com> References: <20250208173628.5734-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Adds Asetek vendor id and product ids for: - Invicta - Forte - La Prima - Tony Kanaan Signed-off-by: Tomasz Pakuła --- drivers/hid/hid-ids.h | 6 ++++++ drivers/hid/hid-universal-pidff.c | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index dbac05649e9d..860adabbc625 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -189,6 +189,12 @@ #define USB_DEVICE_ID_APPLE_TOUCHBAR_BACKLIGHT 0x8102 #define USB_DEVICE_ID_APPLE_TOUCHBAR_DISPLAY 0x8302 +#define USB_VENDOR_ID_ASETEK 0x2433 +#define USB_DEVICE_ID_ASETEK_INVICTA 0xf300 +#define USB_DEVICE_ID_ASETEK_FORTE 0xf301 +#define USB_DEVICE_ID_ASETEK_LA_PRIMA 0xf303 +#define USB_DEVICE_ID_ASETEK_TONY_KANAAN 0xf306 + #define USB_VENDOR_ID_ASUS 0x0486 #define USB_DEVICE_ID_ASUS_T91MT 0x0185 #define USB_DEVICE_ID_ASUSTEK_MULTITOUCH_YFO 0x0186 diff --git a/drivers/hid/hid-universal-pidff.c b/drivers/hid/hid-universal-pidff.c index 1b713b741d19..32f1c26f4cf4 100644 --- a/drivers/hid/hid-universal-pidff.c +++ b/drivers/hid/hid-universal-pidff.c @@ -179,6 +179,10 @@ static const struct hid_device_id universal_pidff_devices[] = { .driver_data = HID_PIDFF_QUIRK_PERIODIC_SINE_ONLY }, { HID_USB_DEVICE(USB_VENDOR_ID_LITE_STAR, USB_DEVICE_LITE_STAR_GT987_FF), .driver_data = HID_PIDFF_QUIRK_PERIODIC_SINE_ONLY }, + { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_INVICTA) }, + { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_FORTE) }, + { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_LA_PRIMA) }, + { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_TONY_KANAAN) }, { } }; MODULE_DEVICE_TABLE(hid, universal_pidff_devices);