From patchwork Sun Feb 9 07:26:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 863685 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19011033.outbound.protection.outlook.com [52.103.68.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9FC624337A; Sun, 9 Feb 2025 07:26:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.68.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739086012; cv=fail; b=rKvoxQJT+FFkTHPJEWLcKYrT+LEfnjGD/BWXzMV0jTx7gMgG+/wbvpT1DZ0JXsLTMUJdbIjUZkFpVGa6P4rxLG3FCOTBdPaRmtIeX7MTn/80yM80AL8XZNueYfGhSiWedcjUIrRE1aownruKZ6+YQ1l1nZQQq8Z37d8Tl5iQLDw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739086012; c=relaxed/simple; bh=WljrWjVcmKAHt9d8zCY9OMW+YRVZqAXDwuWddA5wW1U=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=YpsVz/KmU5TAh+eONeBI+7LqudTOziGQrsHYQojNaYHrQ8YksW3TUr4uNr4dMI/+pJASp7PYtoNcy8rteZXLMWfMfe98D4QeJoHYAEvw/+6mUPMGi6ROOxkoBIAfVhQJamjmkDpyXw0eLwmTjgCym3Zkr05NomGcULeLQnnMfEQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=mXkLHFsR; arc=fail smtp.client-ip=52.103.68.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="mXkLHFsR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N6NMWvcgsCm97UXrUtnD1YC6N9ZyWKyr0bhSUwwd+AtRYYdEtl4mhI5dFz754Ok/uVE3oo6iu75oY8K5rsCpKg5+E5rcZ8muhxcUEUBKMbYPRDhjtoCuIbEWt+ASoFtNPsXQ916f9HnWOCI2FXMAY8tSnSs2fT9JEpzNbV63uTrP24m8/mIMOP+/NQx4cArRWpDTFz8dL2YYJo5s6/ySkMHN3YyhLMVfAGH6i7q0vbczRxDQjBGE+PK2XsuATgCmxwEZp6Bk7rk1Lp63sPte7Oda322VHKtiUhFBoCRUw8wvZcU80mcjrr6f1sDS6ARFe3ZPEg0ICEuazYYJACvIzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WljrWjVcmKAHt9d8zCY9OMW+YRVZqAXDwuWddA5wW1U=; b=BACK18Lu4vGKrPf6ms7d7wJSYhS65RRCnPlZkwza+CMnAfEhPk/xH3g/f+anV9oH53YLX30m8LEAsd4FBKCoRS6nF90mjNz3OrmD/Iyo8lIHGVWDwe2qeQX5wB0c9ZIqr1ZXYs8FPSDqPZiSk/RDX00jgaE+iq83P7Dz2UiSGSLQycBI75xmgBOOjFPAzIkCgo9qPZGjpuv6di25AACRYYyAT+L0WDe/yTgp6eYjpRh6P3gjS4LquHmRulIVhuJ2IFSWxHjQzetw/0fctcelH/wI1iZ19sm69ws799AZpDOKRi1+1NZkJp6D77qVsfcJRI+A3HdC15XaWtTfS6mbTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WljrWjVcmKAHt9d8zCY9OMW+YRVZqAXDwuWddA5wW1U=; b=mXkLHFsRPOL5tp5DtWtw5Sre2EjNQjFgLSJ99ut8eBaqsRaQ0760Vrl7rWKqFijlKiKG58n9FFZitPUldA3XjtFSZHNMhCnK9CylfNZYPzCn07WSaTnJ7nrq61cEEaKkNLOZ0RiEWKfWVtkxQARZU1PGAaWG6+i2qZSAP/JP5xH6Q8yWC96MdV6iSJcMisd0nhyUKjd5PmUddCH7WqasOI6J+XBvJDktZAApijbgkanBd4lQpNMfU0+lxbVWlzWaym/xZrpsGtnJkzyDQk+Jha6RVkgOTgHHkExDpFd891zkD2MEmJkYzHWMR8o66SheDbvgr+faX5bACvdxSElArw== Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:110::10) by MA0PR01MB5755.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:48::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.17; Sun, 9 Feb 2025 07:26:46 +0000 Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde]) by PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde%5]) with mapi id 15.20.8422.015; Sun, 9 Feb 2025 07:26:46 +0000 From: Aditya Garg To: Jiri Kosina , "jkosina@suse.com" , Benjamin Tissoires , "bentiss@kernel.org" CC: Orlando Chamberlain , Kerem Karabay , "linux-input@vger.kernel.org" , Linux Kernel Mailing List Subject: [PATCH 1/2] HID: hid-appletb-kbd: make struct attribute *appletb_kbd_attrs[] static Thread-Topic: [PATCH 1/2] HID: hid-appletb-kbd: make struct attribute *appletb_kbd_attrs[] static Thread-Index: AQHbesP58EeHhXFtz0aeQpCXHLgaNw== Date: Sun, 9 Feb 2025 07:26:45 +0000 Message-ID: <3AE31FDA-2F6B-4CFA-9E19-0DEECE363D30@live.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN0PR01MB9608:EE_|MA0PR01MB5755:EE_ x-ms-office365-filtering-correlation-id: 61cdbad2-8318-42e6-36c2-08dd48db1be8 x-microsoft-antispam: BCL:0; ARA:14566002|8060799006|8022599003|461199028|15080799006|19110799003|5062599005|7092599003|8062599003|102099032|1602099012|10035399004|440099028|4302099013|3412199025; x-microsoft-antispam-message-info: =?utf-8?q?jyTLIe8FTB4ucsr/5VqYyXmP1mdbckx?= =?utf-8?q?Z8G07RhdHswCqklE5lthz0vvkjnEi6YoTJwOeiv0wYt9ZDLvYuCE8vBfwLEuxK4BV?= =?utf-8?q?Oebbx89jXsF6ZM+C3klENx4p0MBjfwnDvspavSw+Y29ZQTK/m3NWrHZuGCdl4Sg5s?= =?utf-8?q?OBTz1nJAEx6BsxNdm2j2c3ODO9KwwmeYjtc4W9+sjyvX5LoGmuoqdt4v+1HfQSrEx?= =?utf-8?q?AcXgC3jwWJbnEsX3/L+G6HBdltdfHNuTUPcJQBMQVk6Mn4Cv/wYlqDAtczAOZOW7K?= =?utf-8?q?TDzZRvFnLTWWkNClVJ/aYHhNdSbE7WUj98+79kTXc64SdN1Wuh0w4LAeAo5ICPYrK?= =?utf-8?q?1IsjW6E2Uehs0SdWTPWheVZFg0D9uodgBBQCmYkFOOt3UfQDVNu48OT/zHw3j/jFB?= =?utf-8?q?2Ni9awRiw14dPgVsbA8lqy0AxH7ZAIyoBokepsOCEbSpmtrkdINZk0+73O6hBgX8I?= =?utf-8?q?zS1KcoafGWdvHGo52tdmpODv9ymCdSjMec6CDypRDawonmIobZt/pizJvFlMT2/T8?= =?utf-8?q?wvNZwV6poE+76KFIOV//zMvHrgAvB1u555zZxs55Qx511jodgOY14JiFyaXmfnXkE?= =?utf-8?q?yMtfjOm2ltbr/YZYwc31tYLtT8A+APCZ5Jc5PmdfGFirxGdCHT023vW9OFwTxl3Ok?= =?utf-8?q?+GStWGCLAds49+8dWlqzVxZlwE/jmu42Kq9meW5xtu0JWSAJ4QkE19IZXkg77FOne?= =?utf-8?q?fT/cERf2T7p2GGv4iXo39joROmN35Vn38B+++dGPaM/SBaDA2ykhZkQbVE6ICIZp7?= =?utf-8?q?stHhCA8m4CnYPjDvtXUC2CLrsI2K/vyY/ri6efTQaXDA6czxDEJgYxecHSibR1HUj?= =?utf-8?q?8440eur/ZkZtz7KUJ3minprZHY7NhKdJs5AGrZdXNj77q5Up0mQnPHzo0kzd8F9Xs?= =?utf-8?q?bUjUcCEqKWT4fq0Ag+kTKnVgEnu6hnEnlXcq6RDoPoQ7Xy8KxqYG+8kZROIB884xX?= =?utf-8?q?BIlm4KHpP6cc7PIME06gbjs29VEDnBFRguObQH7LUWOg7ugXa3yguPKoZm6Osxutt?= =?utf-8?q?QGpm0dWGgfX3zkuZrYTiJmniqi/OeBQcjQN1Q3bPfSuxbHv+RqrVAXIS+f8L+/YRt?= =?utf-8?q?2psnYZck8MCr69SQlcm063apfDl0L975gq0UGIQgIc2wcnjGXnMIettGbu98iVLrD?= =?utf-8?q?0kfHqd1gXPOhim4HxR3AHOCUsBPkPMVC97sUOgEpHLqfgAzy30qRaMYAFeeIbxZRp?= =?utf-8?q?j3UImUcRgaRZThE059TGzi+QHlMJC7BKQsvoz2xgSv3Hth5IGTou30UH0=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?PPyMyQn6WI+wufFELSJhVRr4DigO?= =?utf-8?q?F8Aot0rwz1HmuD5JjONZjPVDw3l3nX1hTQoH7G+XDzyVhTSdJZjSgiGjUp10BFA6C?= =?utf-8?q?B9F0B9SEMZDBf7BFsbdfjDz5XNwB+Awmp4oOt9D6LxohoSwM0N1UUfHS0CKrBbXWw?= =?utf-8?q?h2gEHVvjzNeHM2IgqEnyvbMn5kwm0PI4bxoTspSZSfmd0mHKHnEO/7uasG38q2wPV?= =?utf-8?q?59RIGSzZr4qPkuNAn1N/m6mcmF7YCONsQx1s2l3CtZ8pn3kE+uq2nBfzY1UyeJVVb?= =?utf-8?q?3Xu/r9CG6Uv/41hsbVyEQvclpTb1EWoYsi1D0WzymaLfM/JwCPZsCV24cQBXJT3mR?= =?utf-8?q?7WvNebsQNUCV7J64QGUUrFAl4adWbbHSokGZpD6qBN/vscl4GitXRPDYyPJnI8M45?= =?utf-8?q?j+fbQ3GZZZ/dC6O22QdPSZbBJ1Na1cBwdGPYxKNzOcVGGGqFjlDEzNfZEgEZuQ4Y1?= =?utf-8?q?fDVehlyguY+JDD7yooBSws/uI9sg0fyUXox6jHWtLW6qwAG2u7FhESx9jD3vuvqkK?= =?utf-8?q?UJQo9bFsWeGCu+ExDvmflm41yrbWj2a5oZfX2j/H71dAXvmMf7M7M2FjjYkAEFm8k?= =?utf-8?q?ycod+VXHMUS3ukb0RrsJvswEI2DyR4vmYSxdHklp2wfWV2ewhAMEOBKj3GgjPtSTW?= =?utf-8?q?Ugs0V5OS8RhJKgzoMIftAP/WkknMSFDoCHJkD5LJ+hnrh6ZVJ3TBoBQEp3tAB90A2?= =?utf-8?q?sItDLLVXneJcJCfX0itKLnkeeMxFh4WEZlWbCz3rWSuPOwg1lZfn6IpzeoBmUb9xz?= =?utf-8?q?NxSD1jUSb+UQGCORz7wFm3PAptgKzdoqpZaZLbRoL+wepG9eqHzi7HCKkFLShHCh3?= =?utf-8?q?+BIYTvTPu3ogKvXYG2yGGGCzN26bvF5/1Zo24kZQXnWCGa8qanh6IIr5zmao4e5Mv?= =?utf-8?q?Aq9NVZ3v9Pk2+YGmVXRKC8pFcYi3YKmF13zjmahMW6c36sVPfNIvF3l0dqb2akhKY?= =?utf-8?q?8Sns8QYdlw5ThvaWkoyH0xiqdgEawIBGDeq4mvYqxwACB0MqbeIWfaaGOcsW7++fG?= =?utf-8?q?Dh3Oqm4tmJ90Hjr3Gn2VuWVl9qN63XU2zHp7K/2c9W1KLtVhTfAcdavn3Syei+xNj?= =?utf-8?q?RpD8j+dHtyFL0lgNx9DI/dNUj9wcoOLn6+jaGY/4N/JXqp0BcImMcfgd7DXh5qomd?= =?utf-8?q?HqZ/aNz5ei2An+9HsndZDKRwJxuksdVf4deWRHA8SO0WKzvM/e2slG2d7s8foQGMv?= =?utf-8?q?rDGTwY51yd+v4dmPH6ArFuF4yVqZw/OvcEL6qJoJgXTHDTBkEVrkQsD85zm/aQndG?= =?utf-8?q?FpyQTs42rZquk2dD?= Content-ID: <3A8C9B71E4FFC741A3F0B602EAA67B96@INDPRD01.PROD.OUTLOOK.COM> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 61cdbad2-8318-42e6-36c2-08dd48db1be8 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2025 07:26:45.9672 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA0PR01MB5755 From: Aditya Garg This commit addresses the sparse warning flagged by the kernel test robot. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202502091105.ZsLoBSIh-lkp@intel.com/ Signed-off-by: Aditya Garg --- drivers/hid/hid-appletb-kbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-appletb-kbd.c b/drivers/hid/hid-appletb-kbd.c index fa28a691d..38fc0e58c 100644 --- a/drivers/hid/hid-appletb-kbd.c +++ b/drivers/hid/hid-appletb-kbd.c @@ -4,7 +4,7 @@ * * Copyright (c) 2017-2018 Ronald Tschalär * Copyright (c) 2022-2023 Kerem Karabay - * Copyright (c) 2024 Aditya Garg + * Copyright (c) 2024-2025 Aditya Garg */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt @@ -143,7 +143,7 @@ static ssize_t mode_store(struct device *dev, } static DEVICE_ATTR_RW(mode); -struct attribute *appletb_kbd_attrs[] = { +static struct attribute *appletb_kbd_attrs[] = { &dev_attr_mode.attr, NULL }; From patchwork Sun Feb 9 07:27:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 863982 Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010011.outbound.protection.outlook.com [52.103.67.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5596B24337A; Sun, 9 Feb 2025 07:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.67.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739086080; cv=fail; b=GdHIt4pEv7Chkvd07U/vFEVBW+kOK//EFShozV3Lh/LZu/j2NWsTLu0tB4RChv5XlOGCd6bSo0xrxUIqZUwoXdsn2MDkKgIRA9jEdoctRlrsODm2YDToqTu/SXaNDx+PZ9yzbi0enyuLj3DJVqZ7Sg4km2yQvZ9/2EOmO11HJk0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739086080; c=relaxed/simple; bh=rN0XAr3fCamG7dMNctG45PyE/Rf+RoZJ99ONPZcdhZ8=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=hW2gK+sVXql4dfs0PXiHkvj05sTlJt1XaNFH8+jpxfYKr91+PakbYBFahqOou0d7+hbHCiXYGG3jdEHvBKIpodIJET4hcO52ywoCwMQBuHwIjT0bWc9MfpSbBLOjCBgqNRQJ6woWfhYnSgPQCimiRAWcKnUsWNWaqFla779Wy4Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=VUKwjxky; arc=fail smtp.client-ip=52.103.67.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="VUKwjxky" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b9Td1u0eDjXrqFaQ+ZxE6ta88k+KcBKfF33WeYU9WxIvD6lifrPH/oyDHxZFbJqo/kZmstTRPx5exuUMFcamcW/9oMqJ8y5lMxYPVrtXUudoSgSiwDJcdJjVHjdbaVv+jLPg6cOia1SsHNddlrwK2u4bpMhJZsQ+HeKtMRlKYx3D8+S9K9v7cwv3aLldoX7DTMy1evWKX4mueMhflLAdbDtH39aL1WdkgeLFxi6tJOCEtH3pRUaiJe2ebHZTMFqB9/m2w/nWUOmGu6L7hGnvRN22QeGxWtshIdGA4rNLuQFLcH57kddK3o0LyKZdtHOJpqquYyMBxGaOE4Qoe4BYHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EK+66BDPZ5zYvly1XejNwZlA/TopatFDZJ9TsnWDc68=; b=gQn6OAWgEgDot5+4fZM3ZQEr8aNwAF/tEX98OCX8Ey32B0S+UkBaXYLP6Vd5pA1KpPUguue6lW5M6kPmAo7U1TIQJ8MTktZ1/eWKlNaEahRA7wFSjDtZhlcqOtIfGXx7IlOpkCuKIdq3pQ6VXvsE7j/5Am/pyWMglJ3Y3vuYnuJgIuuQuVOvs2ike+gFMPk0Qw3cIOGi2RCcFkiFT0S1PjgQ3QBlXMrFLcSwKTQrcZjeYMv8OtYWgRe0wxJsT92MbKGGOqnofkBl/mvs+/E5mx5rnvFIH1uq8kH74vGp/w+FrAkrZ92WK3tXxho98s32Nw7hKwKqxrXi6Zl2ujbtEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EK+66BDPZ5zYvly1XejNwZlA/TopatFDZJ9TsnWDc68=; b=VUKwjxkylRAxVqLAfi+ph6XK1oKJD+7CazgCfRRwQSeQKHp/JmZdJSGKTzheq94FCsLHZxKj9uAVxMUmAdX9i/uiXOpIhPTnN9zr2oCRd3wqeMlq+B1h4E3K/N57CYDVG3NaIFf8kiuSYHOGqYQOadMkBPl0Dx93RAb2aWvc4hFxfdOw7ocBDzL/dImncERURyzdYToriXjesUBRwJcsedP3Fy8FshMSM8y8fI91UWKHggN1H/09HShV4goC0gV51i3oGkZfX7vQFAQHxX7kR/8fVmFaQKYTbkejymAU+HB0CDVAaE/+wvgwgITe4lpZmnSbCt6yT6qwWNkTcoZVLA== Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:110::10) by MA0PR01MB5755.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:48::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.17; Sun, 9 Feb 2025 07:27:52 +0000 Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde]) by PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde%5]) with mapi id 15.20.8422.015; Sun, 9 Feb 2025 07:27:52 +0000 From: Aditya Garg To: Jiri Kosina , "jkosina@suse.com" , Benjamin Tissoires , "bentiss@kernel.org" CC: Orlando Chamberlain , Kerem Karabay , "linux-input@vger.kernel.org" , Linux Kernel Mailing List Subject: [PATCH 2/2] HID: hid-appletb-bl: use appletb_bl_brightness_map instead of magic numbers to set default brightness Thread-Topic: [PATCH 2/2] HID: hid-appletb-bl: use appletb_bl_brightness_map instead of magic numbers to set default brightness Thread-Index: AQHbesQhdeRULc7s9U6qKH30xhbxng== Date: Sun, 9 Feb 2025 07:27:52 +0000 Message-ID: References: <3AE31FDA-2F6B-4CFA-9E19-0DEECE363D30@live.com> In-Reply-To: <3AE31FDA-2F6B-4CFA-9E19-0DEECE363D30@live.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN0PR01MB9608:EE_|MA0PR01MB5755:EE_ x-ms-office365-filtering-correlation-id: 3571c884-dd00-45d5-68b6-08dd48db43c9 x-microsoft-antispam: BCL:0; ARA:14566002|8060799006|461199028|15080799006|19110799003|7092599003|8062599003|102099032|440099028|3412199025; x-microsoft-antispam-message-info: cQuLths4rq6t9HmzY2VyFu0vcli4CYRDCyTgonNTNy6yT8njD2dmioA0Z6E0gadhhrMGWlu6q17gGQZigXmjIrWK1DZVHxZp/zunTKPPM6ZXHo/vSZupjlAjqE33igPZYZCAzxHQFrFEkm/AZwvuYm8XsyPWjz5UTs6beEPs975eQQqqEHnHq8rFIR99X5RWhHkCR6gPxPJYrXljLK4Zg3h1qULZtxIAr0gDD+GJkULtFnyGLnYiEJipwZhXrhey6hXTzueBAan0lfx3EsWxYRucgbDGqUz/VcoEfqfuZnxuYxJZ05XON5NZqxRgmEa95oKGw1sYNkIcr4+5/gTi1g9jTpJfbRxXkVSGAI+Vmtlarg5zVO4lglDA676cYf3S0I2ur8bh/1RMrVR4dXdAvpIIURg/fGK7c9vMnuTKMvSlwqHlInSVVDSQ5CtAIFF9tjBKpjnWR8Pwi6M1YSayIG+KQpxKKSwCO3FjFUzbya4OBcLcwB5Y8+Et0YQ2BLxFHn2Py1uv3DhvqMbXZNkVyCpmLF1xBHeu0UxSBc0ABENFhQi5yGKbGGr0aL8Wi9ernPEaJy7oZjFHxjnOmOxPh2Zc48jCxzcXWgp6i7hCs610IPWecGKOrUuPfDxpAmJaur9BEb6o6OTAzm3lTLityPN7kcjgxujOM6JA5PeVcOtAAZPIfhfjYXbraAz88MIoX938fLtAz8u6PbEAzQfKOrW/svMBy8muHAX6g1ZfZ0Q38VVg+ZtMnLME4ejVfTxItZARSzhHAtN1SwavSlXlHlaZs7tC1ZLTnybCIZBmV3lmfi2Lwu1TfdVpXfs+UPMlPptHjPJXEG7Nw9QXFJ0nV6/O8StluiY/eWFYJUx2kty4zEZZic8UBEXEdYuKLrjYWY6ruEjfPI7SERvgK9EZxRQ0DBBZQcPgGMIWxJ1Uyiq3rKZxCp+kJC6PBRAeU+yqYNa+0+GhnFGb0EwhbilSLoRabT7XD93SZV3+rq1jrbDua/obQQ74VbPsZcMHxRUoTsx6OQTX4FCr+aDeNOwehJBCO0UPqyvpRv63BrZ4ibpLrjZCDqFZavTBES9tlkJq4lFKBLdW41/Eo2UA4FPiew== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: rt712vMs8CVkc2N90QPhxHO3MKV0/7nrlwNJuC6pTUnDCFSUeZ2ctyb40SKONJG3ELquGhJuGsOQWGYpOSfH2HQ+bfN0Z1ugvbS1hwZWVydfetbfouYIzrRDVDlZEedtrCaMP21u78ZHEW6G/VzXt+WgKRV0YYXZTKpKSTjMAM6T1H6dcvJSX0uRg9MHAmvl16X+tLK8V9U49fqwbgYQ4cFSmyVeA/GMcFHi139gKrXgYTNLRhO7+AhRYX0HtUZ1dNQj78VK6d6/OoXx7ObXWT4R83/pGtQd15itm6roKgueAmfr/FaBKzB1EkRppTz4lPoktykEmw3dkP6t6hkBy1GV8hR5NY34ht24WgeoqlVTqR14umZazZi5T7PBnqJ1G/F7Xl91x+5Y+laKLR/TBhX5+L7z1reUEa99pblW6U8tDjAFnsIL0NFQn0mvnXrlBkrhMENOkC3vKT3tMLLS39TxcPJa82cBklYi7c1b4zJs9Qq3vKqGeeYUDP1/xCauhHnMtFPStshSf4AqEPtRcCrcavDhnp60JVw8Rlu50T89YVSdtKL9eghO1lmRnQ+55Y7eTVhCHWK4D7G3OS1vGEqIbAsggJqeFVivO7xIDZr6ub8F7+2jSnVEcFh1Kevq3jWtAEjh/mEIv1X10asExDxJjTTTQ+sDdD+KxBvkb6k9BC5pH18RDRrIJu1rXEa2zbfsBfxYBNR7TX7Y0mIPKTkryjcedx9stFZVgpMmxmuuhHZG3a+ZrERlyiclZn/Twvq1DBUpJVZqytIfurItMJ1MHjDyw+zOs41IC5RoNaDMUn4o1AeTAxY7uNO9dY4zjVhTvIl0M4Pq/jh/KNUacODC+aYf3LxkcZcJxddIPeiHFl/cgXaPhcI3JGQAqqvUjbNzhtq86vTHK08XAW9G49YoKczld9teQzzLcKYKrpQQNJjsp7KjuPpTL7Yz6Ml7XvUeUnlFUFlTnYz0VZkr6nSNsnNY5NEkt6UgGp4pBBAEjBNAhxa07mAaY2hIQQMIVmOKw2rCFnh/SikRB35FCmUqPYFGBTBHleF/4hcqRXQjc/gLYVFVHeHOdhi9i+vmrpYg9ylh7/IhyliLNjst8e4Mw+BI3OYAdZw31tChszQHnvGzOl4LJYVTISmHTm4b9IxpXxHgYX8h3zebm8LZBXj5q+5gf2BnDziCmLuDCh3b7PDQJ+wTA1smhTHEwRYktRjOVAwXrpWRj9vcebWgU1UQMaVhoeUQNz8bpigLdaHlTRo2duuivmmKcuBG1vU+u4m3RS59qYO70VtelADpYxt+DorO2DGpspextn2Mfpx+LX+0Uc3uBRt7Mg4C5qSN Content-ID: <86C17957A624084981E7B4162C48DD65@INDPRD01.PROD.OUTLOOK.COM> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 3571c884-dd00-45d5-68b6-08dd48db43c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2025 07:27:52.8184 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA0PR01MB5755 From: Aditya Garg This commit makes use of appletb_bl_brightness_map instead of using if statements and magic numbers to set default brightness, and thus simplifies the code. Signed-off-by: Aditya Garg --- drivers/hid/hid-appletb-bl.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-appletb-bl.c b/drivers/hid/hid-appletb-bl.c index 819157686..1a3dcd44b 100644 --- a/drivers/hid/hid-appletb-bl.c +++ b/drivers/hid/hid-appletb-bl.c @@ -141,12 +141,8 @@ static int appletb_bl_probe(struct hid_device *hdev, const struct hid_device_id bl->aux1_field = aux1_field; bl->brightness_field = brightness_field; - if (appletb_bl_def_brightness == 0) - ret = appletb_bl_set_brightness(bl, APPLETB_BL_OFF); - else if (appletb_bl_def_brightness == 1) - ret = appletb_bl_set_brightness(bl, APPLETB_BL_DIM); - else - ret = appletb_bl_set_brightness(bl, APPLETB_BL_ON); + ret = appletb_bl_set_brightness(bl, + appletb_bl_brightness_map[(appletb_bl_def_brightness > 2) ? 2 : appletb_bl_def_brightness]); if (ret) { dev_err_probe(dev, ret, "Failed to set touch bar brightness to off\n");