From patchwork Wed Feb 12 17:03:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 864555 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ACA125A2D3 for ; Wed, 12 Feb 2025 17:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379859; cv=none; b=b6rK2Cl2FtJOMJ2W9b31r9FAnjuA05OWEIV42LLTe03j4bY6WQQLZTyvRSuo8WmqR48ZUfJdPlosewBim6IERk+MU+WTQTIqL5JwhNX8CQUhcsDSast8Wjr6bY5ktmxdM7UXkLy3584Y/jfryBCp4RbXaT25BwcD+el1JiC1Oqg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379859; c=relaxed/simple; bh=sItJi983hvl01AxWCTmMFX7g70a0Fg4QZpXz/Tz/yyA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C1bformVZHJh6uAHa6E7Ow3vsEk8Nex/FlUrnD+QAL2no+TovFaTCcs6WXaHTKgq95wFiI6CYwx8BoDxsfFNO9UXLRc5HNH2ZZwuEQ8nH5pQ/pCxoyEuPYvf+QjrhHBrNQiS1h8bB38JTdCXCwY7EPnTnj8SUO+dx8ks+oii6bM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fplOecLa; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fplOecLa" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5dca468c5e4so10076448a12.1 for ; Wed, 12 Feb 2025 09:04:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379856; x=1739984656; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S6w5okXU2Yu7jFnBUo43BoM84SGqbG4jaCw++xQVChE=; b=fplOecLazFKo5bPFXcwrIqQPAKwTv/hZFpxZ3qpbztC1+19mMbHK2yFc9WbbDYe6ET nVv2e+6D9DuF8iYMYSAxCSn/+K7FkrhohfbI8R1ZB09JmdhREq+uNQG6asRfeB5jYh/R J+/O33zB22fnrkfnKzU0nYNvaA4t5FsRiE7uN6r2KtUFu6E5ep0JGhidgUksXKaX3ooF +6HzAoeAOFLQ0qAFQ8YyuRiHkQTRm496czah6qCk9eTAO8m8wW1gI4sW4WJr1RwIP3Gx Sd3sHqk/+hdVd6wIigKkkemT2eCMZZfsWf5jPlJ6LBsfXRPK/k3/hJMUk3yD2IN/i7aP HHJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379856; x=1739984656; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S6w5okXU2Yu7jFnBUo43BoM84SGqbG4jaCw++xQVChE=; b=RcPK5+i+2S7drsyHIxSUKTHYOqFI602AKGD0LUWEVU3gDPKh/wEoMQkZRtlYsBnhq1 Ov1mN9qNwN+RlW3JxQ4tXylG2RK69wa3SY2Cb1M99m+ArWoU3HFcmg9wIbMLz+FFB3bz +UZ6BgWvTMguKM2Ni+rRXDqz92FnWF+9RbuDbJpzRe4EwwqbzRFkdsAuZsP3OtCZTeBY gBbFuFBj2Dls/ds4YjBAxqEZfktt3CiQXKL9dmu/1tV7HwZTqsCXskfIlKN5/TKM8mX7 tnEcZKdjK2kUbIKvkB0LUsRrCLwKgdsRaMng+d29kvSitg2NGYYp1knD67VMxdCT/EWl uzdw== X-Forwarded-Encrypted: i=1; AJvYcCXb+z9CEH7mdIM2CgHI1aTlXY679WLnMmxWMFqDeWWibjvnFx639s4fHXwaxYyZ/ivLRV7X/y317do3fxQ4@vger.kernel.org X-Gm-Message-State: AOJu0YxiPmisatsZtdud3nodeg8LO3JHQd6sdhmkY14zGsBcqNnxVgbp nCQozWY68jQzYWf8j6wrFyUkLbjB2R5YwfuRGHehgsy+DjGFaV6/gtoWDZQ+1Jo= X-Gm-Gg: ASbGncuqRpHOXJ5tHrunOtqeFzPkLqkh5c6Qgr0duuUJl6hJHg+bjlcOqvIpyIoBL3O VtXIjDLGEgDeR8lXAY/X6CMVZHVzEsSDwzCern/FQ4XCxgKHuCMbSfXNg/Q5kk6rVB7ZqL27wqE e0Wc0rfTlULj7US0AZkV7RDojNhZchqcdH+9b3ip2U4LMFp0hWGoSeNFHOwbIDf0uZKtO3Ms4bI BdELz5D+qg5k5Ubw+ZxYyrxlaz10B9aznTR5NLWK3oTs8iwtWlMgteLtrTnJZtfYHgiXk9nVsNS LWwNDVJdSfrL06xEN4AX8dAoNm4x X-Google-Smtp-Source: AGHT+IEABcOOIELXz+JFdeOSsPBTKQScoxzR7QmtBueg1gF7h6+a32NeKWZuRnmzY2n57dt66bqjMQ== X-Received: by 2002:a05:6402:26cf:b0:5de:42f5:817b with SMTP id 4fb4d7f45d1cf-5deade15403mr3357122a12.31.1739379854662; Wed, 12 Feb 2025 09:04:14 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:14 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:48 +0100 Subject: [PATCH 2/8] arm64: dts: qcom: sm8450: Add missing properties for cryptobam Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250212-bam-dma-fixes-v1-2-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 num-channels and qcom,num-ees are required for BAM nodes without clock, because the driver cannot ensure the hardware is powered on when trying to obtain the information from the hardware registers. Specifying the node without these properties is unsafe and has caused early boot crashes for other SoCs before [1, 2]. Add the missing information from the hardware registers to ensure the driver can probe successfully without causing crashes. [1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/ [2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@linaro.org/ Cc: stable@vger.kernel.org Fixes: b92b0d2f7582 ("arm64: dts: qcom: sm8450: add crypto nodes") Signed-off-by: Stephan Gerhold --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 9c809fc5fa45a98ff5441a0b6809931588897243..419df72cd04b0c328756fdc484f4e46b6c325412 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -5283,6 +5283,8 @@ cryptobam: dma-controller@1dc4000 { interrupts = ; #dma-cells = <1>; qcom,ee = <0>; + qcom,num-ees = <4>; + num-channels = <16>; qcom,controlled-remotely; iommus = <&apps_smmu 0x584 0x11>, <&apps_smmu 0x588 0x0>, From patchwork Wed Feb 12 17:03:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 864554 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B7E325EF88 for ; Wed, 12 Feb 2025 17:04:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379864; cv=none; b=H6ZAneuWy+INt2UhhD7ThUUZ/o3w5aVckN5+Az1n3mr7nFoavCTVkLRIaNgPl1ccFVdObR5BZu5RG+lrAuC1Vf+4TuDAKwpuyNqp8k3bnqnQm2HUu7eTuxyOCJEtjJdMY7fYtu2jmROw2/nqGdT25FVOy3BWKQJGQAFM9NcqpV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379864; c=relaxed/simple; bh=/NYZuVJ5CW8Pc7756jGUtf0Lv3irVG+gP3QhGB2cFMI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X0sCh2YLMhH/aeEkuSp/vSGFnRiE3a6PTbsplpLbXaiwg+J6zx7pakbkBjv/KbNkhgiQt0p3wfUuG09S4s4m+KZG80uwWqhN57B8iyX+090lL11VsckgXxudESb38JcX+k6ytYT+RhUBEfcMeN032vilClCQRZHepaChlNf7HgQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PGxUY2on; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PGxUY2on" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5dccaaca646so2111378a12.0 for ; Wed, 12 Feb 2025 09:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379860; x=1739984660; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zYw0tG/nuWEvSbLScJnWGG2Q11zXbK7g2BHQcn5xcy0=; b=PGxUY2onQ7l/ynhXzdODhL+LJ84b/njUlAb0Qfc2wsoNq/3YrhAzm4R5yaGIUY7TOD J7mYNxdYBqbpL9kYY3Cw9M5Dt38OTiJdmuliWGbVGKFDoifnvU2MfyYj1qHDL2xR97TX Xtz0Zt8a94ML64LhZndC88WcnG4JFnO3RgnDroNATRZ/xzYFUKdKJyiy2M/aSsnQCbkc gaqEoab8HNblxbUHGmHGSVdH3tkwDiBQ3Fvxnh/L5T+FF9KGzJiEPahghjjQYFd/ChPI lRq8a8kLFlYNmI58PhtjUqt23Nh4jnoHHx/3z/ZOfsDBKfQMrkNsHxnIF2PRgllzSGQy INkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379860; x=1739984660; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zYw0tG/nuWEvSbLScJnWGG2Q11zXbK7g2BHQcn5xcy0=; b=n38LOVrcfUF2pxDI0o1c6hmva8qp+gi5pM0IYWv0cqFdisZjpwxaeROthpJpwCbxZ+ h0rgBvThevK7P1BU69PQdCd4lmvqUl0om2gGClSpT/5imi2PJV0LoZB//CS2dTpGSHxS nnHQP0DS2nygtcKBUkroGfeJj4cHnLgSFMu3DOesqL3tRdQzZ1n96OgZQJ3ZvOmWICbr EX3jVmtf28CSHxMsCPZNt+DB6gCGz5JUTALfAs7fqNDiUqqecPUyEtFFArxVtWQ8kGLn uEpOhB9/zqnpaL94owTXzrfLZkh1QQjuROPPw7hlsK55hoVBHir1vK2SleHtlwtWjQ4h 03Ug== X-Forwarded-Encrypted: i=1; AJvYcCUEAkphPmQ60GSpHqXCzfGRu9aBdVqlM0Vsip2RFiQbXaQyqdxZpSXue7jU7FnNf/LCT0rpUEuWUBaxxABE@vger.kernel.org X-Gm-Message-State: AOJu0YwRAArMvbaOBGCeuc9D9fJbwy+E/eLXnuOmD5tDNWLEN0W64xsb NrMdDlGvFOuVlGE+4zMxtfvQ8hfbzJytFtsU7W9HHdwadHqpxHUYsyLNuMUkcCk= X-Gm-Gg: ASbGncuJOBzKZ1xpgp6L40dGUHitCA8EAyEzvaz2AButLpW3+YAT5CkHCb77jNXcc7l gidn1I+ticd44eel2ftBky/bq2ibh7x04W8p1iabHfVtoK2BZ4z+tqewCModYP2ZZostb/l9Kkz 4YJA8HLAf03L965fEiHW0uErMBsSVDRYGT7JXLXIyFFneRNKJab43Di2ckrkYjNiwVx7X3FZaNJ L4tf/dCrqCqQ5Ys6zKneCZTfSVrpXVjko6Bnx/dtD4SDDK5ioID4SkUWN2RdvKRzzox9TpZgrwc uWYnwIsVJOQL+dqwc4nRQe3MFimO X-Google-Smtp-Source: AGHT+IGwS9pGhWIrn8y879zF3bgF1bakf9yBm5N5I3DRe/DsDY25Qv96woF2RY7pM8YiIFh7fSb+cg== X-Received: by 2002:a05:6402:27c9:b0:5dc:80ba:ddb1 with SMTP id 4fb4d7f45d1cf-5dec992221bmr34314a12.14.1739379860196; Wed, 12 Feb 2025 09:04:20 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:19 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:50 +0100 Subject: [PATCH 4/8] arm64: dts: qcom: sm8650: Add missing properties for cryptobam Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250212-bam-dma-fixes-v1-4-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 num-channels and qcom,num-ees are required for BAM nodes without clock, because the driver cannot ensure the hardware is powered on when trying to obtain the information from the hardware registers. Specifying the node without these properties is unsafe and has caused early boot crashes for other SoCs before [1, 2]. Add the missing information from the hardware registers to ensure the driver can probe successfully without causing crashes. [1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/ [2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@linaro.org/ Cc: stable@vger.kernel.org Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent device nodes") Signed-off-by: Stephan Gerhold --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index 86684cb9a9325618ddb74458621cf4bbdc1cc0d1..c8a2a76a98f000610f33cd1ada82eebd6ae95343 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -2533,6 +2533,8 @@ cryptobam: dma-controller@1dc4000 { <&apps_smmu 0x481 0>; qcom,ee = <0>; + qcom,num-ees = <4>; + num-channels = <20>; qcom,controlled-remotely; }; From patchwork Wed Feb 12 17:03:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 864553 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F347A260A5E for ; Wed, 12 Feb 2025 17:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379867; cv=none; b=I3Xh+FYiSZvJ8raGN5OOAXTkrMqIHWyrgqX6KL5/CKnmHQoUesRKVq1iF8yj430+OXYn+cWMBC1i2FrdZXMhAcTyvySevwmEMPus4UGsHL+olMiuYAv+A0Rag+x3PhYfN2bbw22DyYW1V0muylhHluqbFy8SfZIGGH6V1x1rKNs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379867; c=relaxed/simple; bh=75avUCDFzU7VeEjRm5mXzklFEoM13F5FbLiujKtYn8A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WPwZJpe/ymSj4/p2+dwEvk8w7yFMOPYossZN9+IbxUJVLoH7Ze2EdIj5b7uY07ehPd1zYSne3Uza7VWubHvJMPty+i1z2BK8nhxMG1mXdYnsU7wE/8HN426ZjHPIqPkvJnPZSBUIOG9sii04pw6CT1QXwLW/XfWa8HqI8RscWaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AK/CMOyD; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AK/CMOyD" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5de5a8a96abso7708302a12.3 for ; Wed, 12 Feb 2025 09:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379863; x=1739984663; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EdKs3PqjzG7VzXlZTliJiBHpYVpLmHoLigdOAH1jHUA=; b=AK/CMOyDspRGKpErBhsx0x9jrTAGA3yTTLt7nv3f+Fx2CyIPJ8DHxEoqmLc5K1hGKZ 7xM5cV+T1dpMq+lEh3xbbIJDdeBsBw98IBI7YElHf08W/M/gTDDBcZwPRZfCGPMqgwKS 5RWMre8Xn6+4kv6HflxGMaHOzPQAZdr+ZFOjVIarO1+dsjl2eT/KrMBwUfvNbXM8bhYp f5532u0xDJZrRL2tFFzo0qaTgT4tn381+/zK3aBfc1QTsRJzfxK6uhQLiTFZ9TRHV4Ge UTRpH41YuCwEiFoaHMdB3Hao8rfmhuzp7697rEOeP8LuVkiX0Q/6gC7DItrxry0BAnV1 QLeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379863; x=1739984663; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EdKs3PqjzG7VzXlZTliJiBHpYVpLmHoLigdOAH1jHUA=; b=OWhdYj36qKm9UEScscz3Du+dOS+enUuzaZzFuBgjvz/pnq2LZrVwvoNyJKzUHJC7Bn fMKITgeKjb0Q0Tilj1cF7VdU7yU7GDU9Dj46XTNSBhYev0bEMUvL9gHXQW5GLqt4LK20 IqUDzWkcrlN3lh6Kz/Zm3vtNqRndWHlwlCD1KbqeDFcjsp0dUjOf9tswjljnSvt3ct1r Le3PGQJiIexLB/DirwafhFyM0WH4hKatbjfqLG4XC9GRx3jlM1A788wnPfQBQhYrZW99 0Wxw95a7i0VraVOsjJtL0x8m6bDGcaZhLj1Fa9Q8+71OaP+deWSBWzYolygkiAnGLwBL dnvQ== X-Forwarded-Encrypted: i=1; AJvYcCVhNvOZ8K3oWT/bo0/ksT2n7IvOjcXDu+Aotopl+OTMlNk9z25SdLUOvURoeiga35eAOY1QPqDiRsI14R5n@vger.kernel.org X-Gm-Message-State: AOJu0YwRlVVz/QGyi1VHiSDFMGubMMPU7wWDRfMFhgWtNEos2KygF5CY Jf9A1N7qoDlDVnugC9oCTkhmqJ8SGHS2jhocZatZFKM1Ws2gAGDts0gJpdEN5h8= X-Gm-Gg: ASbGncvswD6QtoQk6my03v6uli5wBMAsVgoGYM7espnoY+sOMkETct+Clun5LMirNhv RSQenDsuQjLvAmFmhAZTlwDm6EEbJDVrGfzGf7YhimY0vMpuH8d3O6pUg7VvCOw1//o5qqR9w++ /9YPjRrh/ixDeCLhsJ2+h59leGmVjto7CxTtesCDSM+Q5DLiCy9UiVvz+VrK+7ujZtNZjnYd8ij k5fkjQniLFYPaDx9OvjECbzUGc3RI9cXazkZ54reIUW2Jb99v4UYL/zEnSRC5Bw2BGGuUM/pJVa gMYO7demHtNfDlXsCyuXuhXUwEm5 X-Google-Smtp-Source: AGHT+IEbKqXhYNAGULvZAeRYgXuqy5Tc0W6a9RU0CYtO1rrnjvygarfucO6BvycCtWQunp05lZe0WQ== X-Received: by 2002:a05:6402:518c:b0:5dc:d8d2:e38f with SMTP id 4fb4d7f45d1cf-5deadde71e1mr9275663a12.31.1739379863190; Wed, 12 Feb 2025 09:04:23 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:22 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:52 +0100 Subject: [PATCH 6/8] arm64: dts: qcom: ipq9574: Add missing properties for cryptobam Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250212-bam-dma-fixes-v1-6-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 num-channels and qcom,num-ees are required for BAM nodes without clock, because the driver cannot ensure the hardware is powered on when trying to obtain the information from the hardware registers. Specifying the node without these properties is unsafe and has caused early boot crashes for other SoCs before [1, 2]. Add the missing information from the hardware registers to ensure the driver can probe successfully without causing crashes. [1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/ [2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@linaro.org/ Cc: stable@vger.kernel.org Tested-by: Md Sadre Alam Fixes: ffadc79ed99f ("arm64: dts: qcom: ipq9574: Enable crypto nodes") Signed-off-by: Stephan Gerhold --- arch/arm64/boot/dts/qcom/ipq9574.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi index 9422900289725774da8cfea9848529891038e57a..3c02351fbb156a314b7911def3caeff0c14b92e4 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi @@ -378,6 +378,8 @@ cryptobam: dma-controller@704000 { interrupts = ; #dma-cells = <1>; qcom,ee = <1>; + qcom,num-ees = <4>; + num-channels = <16>; qcom,controlled-remotely; }; From patchwork Wed Feb 12 17:03:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 864552 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21F832627FE for ; Wed, 12 Feb 2025 17:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379871; cv=none; b=ERlr8jzuslpninTxiMHqcfYLO34sHrqDJhZl44E607OOCcL+CQn/KK9koWCgzr+HMQFKG1HnyUH3Kc7Egs4cLLLQovV+GIoqSNeDcP8lIhr/ueRjX+og81NcGe73dAjrYd6ovOVdslOGQnsBbi654aMCfUweeC7uQ92EI61T07g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739379871; c=relaxed/simple; bh=9GblvGNDG9q8+pnXs2ne763R+S7EoCxIKfwKsAhOSec=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q+MUGnF+OmuVp7y4qBUc3akmxHcNBkvnO6jZVbUICw3UzK8vAH+bVe0bja7IfSxpNNcyOEznr7RoXP/du4RkD7OvWVmbPtuxtTkp0kdFSvEYDu1oy9bqXDDjzUi7ICSE/AaRD7ou44C6G76L6oPWK4cABP+HrHRoUQjm3ihWnyg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zCOJZoAk; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zCOJZoAk" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-aaecf50578eso1382886766b.2 for ; Wed, 12 Feb 2025 09:04:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739379867; x=1739984667; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2u45ykvEMjVQISq5rnr9y3KabZa4tYoR1OiGAmXhk4I=; b=zCOJZoAkmZwNn/VaSbD0Kh5rRawMeIm8UJGZhx37Iy5x0RZ6Tv2IU5YaamE4o8YP3n W5kLzFlG6B1h+OxvZMDKg0q/Yp780eKg5d9Aa/7mDMvhfrvuUVQbjm2aAcgin4+36e9V r5ZNRwqtdIE33iVQISV+HxMKbXRJYbsAGl/7rk35zN1b2h3xp/Nl0FdCNr/dC2nPTAa9 CVCRsffpIGEW+z09RTkvuL9hu1BI2Q5+JTdwvz+HL/IylVqpptc8RfODS54hmIEU0RAt F06xoSmKwiZUN2mJMM6Cs3ct9WKCkj3hJyBP0jK7O/DzY5t3scb9ZbOvdkXn1IOBhinm xJWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739379867; x=1739984667; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2u45ykvEMjVQISq5rnr9y3KabZa4tYoR1OiGAmXhk4I=; b=h31wf0IVnWzX00X1ab5iZJ6K+31d0TZNMji7E5vgv7tAlHnT0/CVMYedv7tNRWkoFr s/ws9SSGtDSE7KlpQ87Dkd/ycvZqWA4NxeC+Of8JsvueO4AS1SNGUZBf9uOUsbA4+qaO KvyVjctiFH9pwtn3kEJajeVaDKd8hALwWe33BIeIblBBnApk0JVoEzet76NpP95EB+iR Ea0bRObynsUmhVV9els3D8aCfTP9Tp6T0Yoir5ysrRSnLlsGnRmmCNAKQqeuHl85X41f /NiPQCow5q2NBS6uPNJnjRVEn/UjZPy/WJIxIwbmWXwxbJSpWOYudM3jRuKJygGDQcjP ss4Q== X-Forwarded-Encrypted: i=1; AJvYcCVaGh1TK6QSiwZ0IpPcUdU0U2kypENzTdYlNuPJPU6nS4R0zpVkpu1KcITzPYZb4ztw5IObgzzqwwLHX0tM@vger.kernel.org X-Gm-Message-State: AOJu0Yy6ZyojhIzgGocK/z/xVczBHjYZkTfxrhxSAdWiJTDH6/TjyGN3 3GYtP5H2w73oGqcYxp6rzkK/CcDPf7ROd6MJpvqBIpktKiVr0LXjowlIYHIriWRGz7L0ObVsDtb W X-Gm-Gg: ASbGncvGsgKs9A6Z7sTwrtm2iWsZCuzK/8xNMaeXmFF26H7cYAu6cye8ySbyrqohbno VmcGJpgkhqDmePKWsGVnvQ5esV0MixZ4WapGaOi+/IUPJIPKF33MCPkUISU03USz1xqujnHTNPN MijtTRwZDWw8CIZbTQsF1nhP+bHRHF0+IXYw7nmmIBSlKccgEWIKUP1ebyz2XgmBZVE7UmtK5ZF OBexcwCx3cLG7k2kieAVVHFtoiiJ9lDIPsSkS1D7memGf4+Nm/9wD9edQ/C4e/P6B6NXL3LTJzh Gs8RpP+ArnJV16aczJPpTlirK2AK X-Google-Smtp-Source: AGHT+IFU/2F6t8+fSl2upjgpc8WvZ1eQ0SNs2R3uJxgo7UkoEsUqfjjBa1zq+PYhAKq2aV9hNjVY/Q== X-Received: by 2002:a17:907:1c8c:b0:ab7:ee47:9928 with SMTP id a640c23a62f3a-ab7f334aa8amr340585366b.12.1739379866508; Wed, 12 Feb 2025 09:04:26 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef41:52e8:f77:3aca:520e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5deb9f6e46bsm819230a12.71.2025.02.12.09.04.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 09:04:26 -0800 (PST) From: Stephan Gerhold Date: Wed, 12 Feb 2025 18:03:54 +0100 Subject: [PATCH 8/8] dmaengine: qcom: bam_dma: Fix DT error handling for num-channels/ees Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250212-bam-dma-fixes-v1-8-f560889e65d8@linaro.org> References: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> In-Reply-To: <20250212-bam-dma-fixes-v1-0-f560889e65d8@linaro.org> To: Vinod Koul , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Srinivas Kandagatla , Neil Armstrong , Yuvaraj Ranganathan , Anusha Rao , Md Sadre Alam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 When we don't have a clock specified in the device tree, we have no way to ensure the BAM is on. This is often the case for remotely-controlled or remotely-powered BAM instances. In this case, we need to read num-channels from the DT to have all the necessary information to complete probing. However, at the moment invalid device trees without clock and without num-channels still continue probing, because the error handling is missing return statements. The driver will then later try to read the number of channels from the registers. This is unsafe, because it relies on boot firmware and lucky timing to succeed. Unfortunately, the lack of proper error handling here has been abused for several Qualcomm SoCs upstream, causing early boot crashes in several situations [1, 2]. Avoid these early crashes by erroring out when any of the required DT properties are missing. Note that this will break some of the existing DTs upstream (mainly BAM instances related to the crypto engine). However, clearly these DTs have never been tested properly, since the error in the kernel log was just ignored. It's safer to disable the crypto engine for these broken DTBs. [1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@fairphone.com/ [2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@linaro.org/ Cc: stable@vger.kernel.org Fixes: 48d163b1aa6e ("dmaengine: qcom: bam_dma: get num-channels and num-ees from dt") Signed-off-by: Stephan Gerhold --- drivers/dma/qcom/bam_dma.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index c14557efd577046adc74fa83fd45eb239977b5fa..a2f1f8902c7f88398a5412e8673e24b3c10bb86f 100644 --- a/drivers/dma/qcom/bam_dma.c +++ b/drivers/dma/qcom/bam_dma.c @@ -1291,13 +1291,17 @@ static int bam_dma_probe(struct platform_device *pdev) if (!bdev->bamclk) { ret = of_property_read_u32(pdev->dev.of_node, "num-channels", &bdev->num_channels); - if (ret) + if (ret) { dev_err(bdev->dev, "num-channels unspecified in dt\n"); + return ret; + } ret = of_property_read_u32(pdev->dev.of_node, "qcom,num-ees", &bdev->num_ees); - if (ret) + if (ret) { dev_err(bdev->dev, "num-ees unspecified in dt\n"); + return ret; + } } ret = clk_prepare_enable(bdev->bamclk);