From patchwork Wed Feb 19 09:46:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Shiyan X-Patchwork-Id: 866620 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DFFE1BDA91 for ; Wed, 19 Feb 2025 09:46:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739958414; cv=none; b=JmM/iz8ECm2iJBTzq9BeMobPWrbjoBG9SczTKr+dH5NVRQYto7o9BXJX7D19DbkZiZkxdI0JWHtHSoiIfPk7FFiGeNd9G47ny5cV+3biC+iyB6MCQ3eNIZm6AHpI074NcP8yEdLEYtRBa/d47lRgKC5sBEPSXabnO7G2COBgK1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739958414; c=relaxed/simple; bh=7aVrX+tsiYUypnK79wOrxQjOeILMuWsPKifx4wjp8AA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=N3T4bBk76BY1UKOBhfwWD3HMo2WvnR0dp2Q/144HkDYr9hKT46cVfeL7wD2QNupopyovEv+rAwt5eQ32b4l46ZwE3sssC3Mm1nKZyXvUXKoRHK+ZsFxEKffctyzg+xcXr/DfWymIc3EbyR6tlNsCoKB5wBE0Drgnx4sL3VVM2mg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kUtLwaUl; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kUtLwaUl" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-54622829175so2799081e87.0 for ; Wed, 19 Feb 2025 01:46:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739958411; x=1740563211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KwQQHgcgyVvybzwjPohbyEnIVBvtAls979ypIqY6TOU=; b=kUtLwaUlUwXPq6N/IdIrqblCpxsPtGj6GMbHxSK8nCjyfvLJd1F3U6L3/D6g0EpP/J D6+sZiFv8cHCR+BYX3wj4ZZQuAVydEMPCxjcFBQk9w8qxKb0vrmoI3Ero8V5+LeGZWtM zPAQkNmE4zoob9BaAW6z65oj/Fe3tP6kUIIs/ZBhblCh/q2BS1Y3Z869IxnsdDRyqvG1 zyx5P94FidZowduDTI1vgAA6B0PhA4n6mbOypFXoBWzBJgKbkpxtNOvoy1ytUxgPHfLA owQcp6erzak4IX2IWpDn2Yk8Uda96Sqeq0BkTMwwT8DORUFvTIK8Q+A/rtx4LrqzugN9 zyqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739958411; x=1740563211; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KwQQHgcgyVvybzwjPohbyEnIVBvtAls979ypIqY6TOU=; b=unnLdoKi8jPpc5yAvl6ol+V+Y7Dm7O6frUKAgrJwYzogcGDAwO5jubCH86/nejT+iO dlsPY004teulQDXZ+gACmv/Izhr0Oj1yXKK7ZMn+iG9Pb2qJDZoYlVmZRwPNqeerA5ht oAIZh7Ok1tFGEJBj8sA+pzgGQyacDpn1XERzTkNS/tmYj41arImi+x28uhk+Ge3tSSFr tlGUSDacVh/2JFYWVAG0In4oVNTXbwTQEkIeHg8T7AJVrQPeEeVFQaJ6vnwOHzHBiQzk 41DkTn5cWfqYPoMmLDD019xOnDsnkcJmRaxFAtEWuO12sVEEVo+98KYb7Y+USeKYQdIe PFbA== X-Gm-Message-State: AOJu0YxIsWunQFJek/XJr+QTu0Z65P6I3FxCz8+h/RDiMt18wbGMwots 4rPnUDdvEq2Et0xnWo9P6SU2p2wJfzDV8ZWJug+DVZX9+vaqiRGd3BJJdQ== X-Gm-Gg: ASbGncsTQixEYdbl1nuMZVB+xG3HCzd1JCG8+oQg+g7UbvZcNHhSyTTlPKeZQ0z9zg2 CBnCAFbK8wwdthfJy4xx3o1nSES3s59/Z+B7tMcQrkC9MDpuFAgQcFfVZeaNh/9bSWSAxC5mWJT Fc+I/5pZo0vUBjpMFb7egXM/PzScyVQugUP9m1dxlEJeEjozlaWKPT44dRjES+Pik1SLWqKHvIs yRWXv2yGtoKzNz4drKmjC7XEuUukJOEBetm8RsWyaHBQ5oQcxhcbZaXH+uI2HXCPqb4rWQWpoAa hFCfWJXXqOMi5BbKVMYPQwCZsWPHfKv0mzi7wg== X-Google-Smtp-Source: AGHT+IHn3xo7xDyMEo4MP1VMnDZOCqW281J6pI2vuA4zswUqqkSslDY/AL+yQdz0/+hF9tKcXTWv4w== X-Received: by 2002:a19:910e:0:b0:546:2f4c:7f4f with SMTP id 2adb3069b0e04-5462f4c807amr787731e87.28.1739958410446; Wed, 19 Feb 2025 01:46:50 -0800 (PST) Received: from localhost.localdomain ([188.243.23.53]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5451f105fe5sm2095131e87.138.2025.02.19.01.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 01:46:48 -0800 (PST) From: Alexander Shiyan To: linux-media@vger.kernel.org Cc: Michael Riesch , Sakari Ailus , Mauro Carvalho Chehab , Alexander Shiyan Subject: [PATCH 1/4] media: i2c: imx415: Add get_mbus_config() pad operation support Date: Wed, 19 Feb 2025 12:46:34 +0300 Message-Id: <20250219094637.607615-1-eagle.alexander923@gmail.com> X-Mailer: git-send-email 2.39.1 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Allow the driver to report static media bus configuration using pad get_mbus_config() operation. Signed-off-by: Alexander Shiyan Reviewed-by: Dave Stevenson --- drivers/media/i2c/imx415.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c index 9f37779bd611..16a52900c61c 100644 --- a/drivers/media/i2c/imx415.c +++ b/drivers/media/i2c/imx415.c @@ -1076,6 +1076,18 @@ static int imx415_init_state(struct v4l2_subdev *sd, return 0; } +static int imx415_get_mbus_config(struct v4l2_subdev *sd, unsigned int pad_id, + struct v4l2_mbus_config *config) +{ + struct imx415 *sensor = to_imx415(sd); + + config->type = V4L2_MBUS_CSI2_DPHY; + config->bus.mipi_csi2.flags = 0; + config->bus.mipi_csi2.num_data_lanes = sensor->num_data_lanes; + + return 0; +} + static const struct v4l2_subdev_video_ops imx415_subdev_video_ops = { .s_stream = imx415_s_stream, }; @@ -1086,6 +1098,7 @@ static const struct v4l2_subdev_pad_ops imx415_subdev_pad_ops = { .get_fmt = v4l2_subdev_get_fmt, .set_fmt = imx415_set_format, .get_selection = imx415_get_selection, + .get_mbus_config = imx415_get_mbus_config, }; static const struct v4l2_subdev_ops imx415_subdev_ops = { From patchwork Wed Feb 19 09:46:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Shiyan X-Patchwork-Id: 866987 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D21B1684A4 for ; Wed, 19 Feb 2025 09:46:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739958417; cv=none; b=kBKR9o3SqVgUFogY3SFZGbhE5qCyty6+P2+AHROSMDwEsJg+ztvb9soFdV+f382hU1bhn9rXR8oLRAInxksJAFlxgTNptGq7aJDes5gxHLSbwV+fNvQZnuUiTq+VnmwuC8tb4XWv+s9+LHCamZAEHi2En/a6UjxFggDfooCO5/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739958417; c=relaxed/simple; bh=MSGahAspL0H7nN8WF1fpIWlDanBkpa2R3w3kTb6pCR4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qb5+RWFnH8+J9ElFjo8rdtZlF7JFj4wu06c61zj3nbZEluWjlH425KDbyGfTJH5IZ874NPYfc4Lu4Yan5nB4Rt7mHtv+0TBeXEYXLWkoslN8xlFHbd1Agy6jZQb2XxqHZ8r+5TL567pomtRDXoGf0qKn/rFYFbJEmlcsUP82iAs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MiFgEqi8; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MiFgEqi8" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-30762598511so62342461fa.0 for ; Wed, 19 Feb 2025 01:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739958413; x=1740563213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=27jbWYLsEblYbKzhUCnk+9LLkCJuxP9z70eUMMXUEj4=; b=MiFgEqi85XwZgDZdjCABNfcL3CpclAPDNGSuskY+baudLVcmTOmftbX+H1aE1kGOX6 myB6cHyKR3VPKoLyV+nD3an4CQH6x22QF5udFTPxCQ5dd56ZlMAIa+0MrgRMXHpvdmKv kLYOCkTsKEjt9Rtz4QcYvafThYq/cfEsciCISXrJtPwxCbZkJqw+qeon+5UCYsMnVmNK CZo5JwI8msuSVuP4IYHyVBEqBLS9HUE3Wx9so5N8scVsg6l0rpbEKKmtmatS4bMHKDak aQLLkatAV26AhE/y5p7aHPYMNawugYHgwDzvpnAHKMURodq3IB/3qg7VEAHarq7Wg7Oq JOzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739958413; x=1740563213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=27jbWYLsEblYbKzhUCnk+9LLkCJuxP9z70eUMMXUEj4=; b=PgooCT0Gwk3PDEqOl9TXkOtZZWdX8AvqQpzaQfEdJX60QPz6LnXHG8U8jOii50f1ys HHMWusZ1uzcBvxYhvfpn9Oe9WN/ttnC7Jy4WJQlNL9H4m2nGZBJcqnjFy8IvH9vldeJh xBj3c6kiLxnnwjuVavQZ+8TKw+MiIsNNrrQT9NyDTXr3ulBjwViZX15PXD6UWPWrCk9y 5uawSsDwCdXeihtW6dpbptE0wCNOXpGwFs/f/1ARMuOjX/w7zGVDZgDEYjIZCG9puHzN CWjL1YYTIo3qcN6Vdx4j2WKyJgPDN9uhe8/CQorRJs8XUiL+m+BMmoLPckcL7XFg17zA 2JHw== X-Gm-Message-State: AOJu0YwYnaSaH7h7fVibsFmgoBycrTfOFQvEbuq81lk10D0lCfQciJDE oDf70NpKNVj+gD5i7a4LpEKlaUIa+y3kWwS+nF8chM67jRrmeHwgBMC5mg== X-Gm-Gg: ASbGnctaeBLFBvTBAxpGSfnqNrl9Syo5jSOwR8Zh5r1043TDNlVOtcGy2zlrsr02laB 3Ux3HaRPDoLKUSmS7xiMesyDsGDpu3KtPPPeHaqvL9YPfycHHTuz+D8sjlPUZfUF47S5EBtpSgU Aqa5b332+nPPHRED+F8SxhCg+YT3JOs/qjEBN8PmNz/OQzUJD5KmSW4AJcr6UpBPLuWTA1vjbSd rSionxNjqJVUjW/Xxzad7i/l7GuwlLYsFrUcWcvgB8+KzmkiWApSpxPRQJIpbkL4ji4+9SJxhVu ZIu5OTLUbzs5w5SMn4JX06iiEzluZpj50q4W+w== X-Google-Smtp-Source: AGHT+IGcYmPTReGL0zG3/OVEcuOZiUOtQkTsq1nQtRn0UypinsHysqfrn+8mmfFTx9nxv57EuKlx9g== X-Received: by 2002:a05:6512:308d:b0:545:2f09:a3fc with SMTP id 2adb3069b0e04-5452fe26402mr7026380e87.3.1739958412466; Wed, 19 Feb 2025 01:46:52 -0800 (PST) Received: from localhost.localdomain ([188.243.23.53]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5451f105fe5sm2095131e87.138.2025.02.19.01.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 01:46:51 -0800 (PST) From: Alexander Shiyan To: linux-media@vger.kernel.org Cc: Michael Riesch , Sakari Ailus , Mauro Carvalho Chehab , Alexander Shiyan Subject: [PATCH 2/4] media: i2c: imx415: Add missing ADBIT1 register for setup output format Date: Wed, 19 Feb 2025 12:46:35 +0300 Message-Id: <20250219094637.607615-2-eagle.alexander923@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20250219094637.607615-1-eagle.alexander923@gmail.com> References: <20250219094637.607615-1-eagle.alexander923@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The imx415 sensor has one more register for setting the output format (10/12 bit), which is currently not in the driver. The patch adds it. Signed-off-by: Alexander Shiyan --- drivers/media/i2c/imx415.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c index 16a52900c61c..c5beba4da18b 100644 --- a/drivers/media/i2c/imx415.c +++ b/drivers/media/i2c/imx415.c @@ -77,6 +77,7 @@ #define IMX415_INCKSEL5 CCI_REG8(0x311e) #define IMX415_DIG_CLP_MODE CCI_REG8(0x32c8) #define IMX415_WRJ_OPEN CCI_REG8(0x3390) +#define IMX415_ADBIT1 CCI_REG8(0x3701) #define IMX415_SENSOR_INFO CCI_REG16_LE(0x3f12) #define IMX415_SENSOR_INFO_MASK 0xfff #define IMX415_CHIP_ID 0x514 @@ -581,6 +582,7 @@ static const struct cci_reg_sequence imx415_init_table[] = { { IMX415_REVERSE, 0x00 }, /* use RAW 10-bit mode */ { IMX415_ADBIT, 0x00 }, + { IMX415_ADBIT1, 0x00 }, { IMX415_MDBIT, 0x00 }, /* output VSYNC on XVS and low on XHS */ { IMX415_OUTSEL, 0x22 }, From patchwork Wed Feb 19 09:46:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Shiyan X-Patchwork-Id: 866619 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 499701CAA9E for ; Wed, 19 Feb 2025 09:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739958420; cv=none; b=MhtizHF+D0SCujgA/w6Ka/Ws0tvPdUhetniKaweZCjtOSW90cJUqL0jArjVu1FnloZEY4tvgsnQ27IqxgstveLafQT7tza8mxS3WyQ/BYC+R4nYayuM7l9hzzWrR0Dg5wbzhxyFlv1pdzXwp49tXBNOVvvrEYi7LeTuHL0OexxU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739958420; c=relaxed/simple; bh=HuoG0pD0aRPuyTiCCela6aZHU5vNELwP+TsQwNkpwNk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WrlDIFJr7vUQYVH7MB+vvHfTGLSBYPX6VLEB9CprK0I1IIS4msY8r3vUImQqpsb1UapvIU0j2f3POVYwk7NO/l5nOgGsPWv5CRdKRAkk1RKXQVQQtmSl1MUQW9gSipEj7a7qaYlF1AKsAv+2iBGubI8x/UpWbb2s/Glp2VNziZo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OcrVvyON; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OcrVvyON" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-30a2f240156so31824701fa.3 for ; Wed, 19 Feb 2025 01:46:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739958416; x=1740563216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u2F8TpMMCQLreKrgJmh9vSe09BpdK/XNLqOfMNu8CL0=; b=OcrVvyONDhJ8GjsO18NM7mmDiYe2iyN7Tz1qAldOHTdYr0UWGwwUeW7c9DHFrBrqYo S4ys3B26h0YNjmlBZOivqLRLHhE/vNa/Bas8BRre8oQihkcKjphPUjRnGrW/deHdvWYQ R96t0hE7IIe3K76//V5CfWNEaalNUz5sPHv7n+QrT6lNVOz6YkI9ifkBYkyEK0prar7p NZe4l9He6P0V579d4ttgYfaPqhL9/FKJd2r7mFog9h60k+YNTrfVsC+xU0BqSQBayvhA SGIHk0YI+LvMYgPfufpJQopBQhfjGv75mCU53aocbVKLCpGXgtLxZTI5icJuceUBVQdd 2l0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739958416; x=1740563216; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u2F8TpMMCQLreKrgJmh9vSe09BpdK/XNLqOfMNu8CL0=; b=p78Teqtt9JVl80c9nIpBAFb1n11sMfHmGL63rIQKqSnDH4zjFrJE8A5q8kPG9MXeUr jDS0Dnw9Zsl8cO73wJNNuyS4BHbr2vOO87Adt58U2yEZ13Ca1XQGB44fw9xgXO/IcX1l mwQMi8L4mloRb3mUMKczEE8E4V1khRoRqW5jlHKfaUdSzp+n1Pg2yM2DzHs8trYThFl2 XvBxkIwPqlSuF94qw3dk8JH3EYFqn3Eb+wBBLsSqHXfpiMBde3oOvEQQT4FdyPm/hRXM PHjCROv6PFV9tV8g/Yj3Hyygxb+u/Yvctf5ENlM7zh/MJ378QIe9ejTwgJzWopmqtBJB mJnQ== X-Gm-Message-State: AOJu0YyFERmYs6vyLCr9EP7+8qCqfDHRN9Fw3RLkbaNdFg5DOiwc43q9 QGCtE+NLPBJQQ0zGPPspK9euHdVy5cCC2xrR5GLJDbKMkQRnz9GfVt3TCg== X-Gm-Gg: ASbGncvuEb5Q4KN5euSjRJD1iV64AwR3LOgDoKWBpQ8yP1YR/tbjW/gbzddjTWtVBR2 7qAqYHIWfUp0nLHu60bFCZoLWoeHcBGf9fxYbyciLO33YZaXhl1Q0L0BLJkCYb5QaGjLMMH3eML zbrQGiArr0JIz0mAhMbqukxTuGw3KJbVyOvLuo5OQK2b3u3zupoc9uKzSfxMn105FIoLCkDjWQu E5Y+GwqScT2MjCPPLlDbzw4a0qcBRWfDcq7uNNNs7MuinjNinD1bsTgyGH9y7+XE0frM9Cljjf5 oHsarfwNLQ0gmqd7OHgsMbvQkEHin8zuudZJRw== X-Google-Smtp-Source: AGHT+IFdTCiZ04YmfjYiGFUj148O6xPw4dnZbr5lOeIGgaDlEMRt8yeWyqponvLSSkkY6RTRmNEXmg== X-Received: by 2002:a05:6512:10d6:b0:545:1104:616a with SMTP id 2adb3069b0e04-5462eed85d5mr1022282e87.2.1739958415680; Wed, 19 Feb 2025 01:46:55 -0800 (PST) Received: from localhost.localdomain ([188.243.23.53]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5451f105fe5sm2095131e87.138.2025.02.19.01.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 01:46:53 -0800 (PST) From: Alexander Shiyan To: linux-media@vger.kernel.org Cc: Michael Riesch , Sakari Ailus , Mauro Carvalho Chehab , Alexander Shiyan Subject: [PATCH 3/4] media: i2c: imx415: Add missing CSI configurations Date: Wed, 19 Feb 2025 12:46:36 +0300 Message-Id: <20250219094637.607615-3-eagle.alexander923@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20250219094637.607615-1-eagle.alexander923@gmail.com> References: <20250219094637.607615-1-eagle.alexander923@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Currently, not all variants for different lane rates are handled in the driver. This patch fills in the remaining possible CSI configurations for 2-lane mode. Signed-off-by: Alexander Shiyan Reviewed-by: Dave Stevenson --- drivers/media/i2c/imx415.c | 97 +++++++++++++++++++++++++++++++------- 1 file changed, 80 insertions(+), 17 deletions(-) diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c index c5beba4da18b..83b7929455b2 100644 --- a/drivers/media/i2c/imx415.c +++ b/drivers/media/i2c/imx415.c @@ -109,8 +109,8 @@ static const char *const imx415_supply_names[] = { * and converts them to link frequencies by a factor of two when needed. */ static const s64 link_freq_menu_items[] = { - 594000000 / 2, 720000000 / 2, 891000000 / 2, - 1440000000 / 2, 1485000000 / 2, + 594000000 / 2, 720000000 / 2, 891000000 / 2, 1440000000 / 2, + 1485000000 / 2, 1782000000 / 2, 2079000000 / 2, 2376000000 / 2, }; struct imx415_clk_params { @@ -453,6 +453,19 @@ static const struct imx415_clk_params imx415_clk_params[] = { }, }; +/* 594 Mbps CSI configuration */ +static const struct cci_reg_sequence imx415_linkrate_594mbps[] = { + { IMX415_TCLKPOST, 0x0067 }, + { IMX415_TCLKPREPARE, 0x0027 }, + { IMX415_TCLKTRAIL, 0x0027 }, + { IMX415_TCLKZERO, 0x00B7 }, + { IMX415_THSPREPARE, 0x002F }, + { IMX415_THSZERO, 0x004F }, + { IMX415_THSTRAIL, 0x002F }, + { IMX415_THSEXIT, 0x0047 }, + { IMX415_TLPX, 0x0027 }, +}; + /* 720 Mbps CSI configuration */ static const struct cci_reg_sequence imx415_linkrate_720mbps[] = { { IMX415_TCLKPOST, 0x006F }, @@ -466,6 +479,19 @@ static const struct cci_reg_sequence imx415_linkrate_720mbps[] = { { IMX415_TLPX, 0x0027 }, }; +/* 891 Mbps CSI configuration */ +static const struct cci_reg_sequence imx415_linkrate_891mbps[] = { + { IMX415_TCLKPOST, 0x007F }, + { IMX415_TCLKPREPARE, 0x0037 }, + { IMX415_TCLKTRAIL, 0x0037 }, + { IMX415_TCLKZERO, 0x00F7 }, + { IMX415_THSPREPARE, 0x003F }, + { IMX415_THSZERO, 0x006F }, + { IMX415_THSTRAIL, 0x003F }, + { IMX415_THSEXIT, 0x005F }, + { IMX415_TLPX, 0x002F }, +}; + /* 1440 Mbps CSI configuration */ static const struct cci_reg_sequence imx415_linkrate_1440mbps[] = { { IMX415_TCLKPOST, 0x009F }, @@ -479,17 +505,30 @@ static const struct cci_reg_sequence imx415_linkrate_1440mbps[] = { { IMX415_TLPX, 0x004F }, }; -/* 891 Mbps CSI configuration */ -static const struct cci_reg_sequence imx415_linkrate_891mbps[] = { - { IMX415_TCLKPOST, 0x007F }, - { IMX415_TCLKPREPARE, 0x0037 }, - { IMX415_TCLKTRAIL, 0x0037 }, - { IMX415_TCLKZERO, 0x00F7 }, - { IMX415_THSPREPARE, 0x003F }, - { IMX415_THSZERO, 0x006F }, - { IMX415_THSTRAIL, 0x003F }, - { IMX415_THSEXIT, 0x005F }, - { IMX415_TLPX, 0x002F }, +/* 1782 Mbps CSI configuration */ +static const struct cci_reg_sequence imx415_linkrate_1782mbps[] = { + { IMX415_TCLKPOST, 0x00B7 }, + { IMX415_TCLKPREPARE, 0x0067 }, + { IMX415_TCLKTRAIL, 0x006F }, + { IMX415_TCLKZERO, 0x01DF }, + { IMX415_THSPREPARE, 0x006F }, + { IMX415_THSZERO, 0x00CF }, + { IMX415_THSTRAIL, 0x006F }, + { IMX415_THSEXIT, 0x00B7 }, + { IMX415_TLPX, 0x005F }, +}; + +/* 2079 Mbps CSI configuration */ +static const struct cci_reg_sequence imx415_linkrate_2079mbps[] = { + { IMX415_TCLKPOST, 0x00D7 }, + { IMX415_TCLKPREPARE, 0x007F }, + { IMX415_TCLKTRAIL, 0x007F }, + { IMX415_TCLKZERO, 0x0237 }, + { IMX415_THSPREPARE, 0x0087 }, + { IMX415_THSZERO, 0x00EF }, + { IMX415_THSTRAIL, 0x0087 }, + { IMX415_THSEXIT, 0x00DF }, + { IMX415_TLPX, 0x006F }, }; struct imx415_mode_reg_list { @@ -505,6 +544,14 @@ struct imx415_mode { /* mode configs */ static const struct imx415_mode supported_modes[] = { + { + .lane_rate = 594000000, + .hmax_min = { 3300, 1320 }, + .reg_list = { + .num_of_regs = ARRAY_SIZE(imx415_linkrate_594mbps), + .regs = imx415_linkrate_594mbps, + }, + }, { .lane_rate = 720000000, .hmax_min = { 2032, 1066 }, @@ -513,6 +560,14 @@ static const struct imx415_mode supported_modes[] = { .regs = imx415_linkrate_720mbps, }, }, + { + .lane_rate = 891000000, + .hmax_min = { 2200, 1100 }, + .reg_list = { + .num_of_regs = ARRAY_SIZE(imx415_linkrate_891mbps), + .regs = imx415_linkrate_891mbps, + }, + }, { .lane_rate = 1440000000, .hmax_min = { 1066, 533 }, @@ -522,11 +577,19 @@ static const struct imx415_mode supported_modes[] = { }, }, { - .lane_rate = 891000000, - .hmax_min = { 2200, 1100 }, + .lane_rate = 1782000000, + .hmax_min = { 1100, 550 }, .reg_list = { - .num_of_regs = ARRAY_SIZE(imx415_linkrate_891mbps), - .regs = imx415_linkrate_891mbps, + .num_of_regs = ARRAY_SIZE(imx415_linkrate_1782mbps), + .regs = imx415_linkrate_1782mbps, + }, + }, + { + .lane_rate = 2079000000, + .hmax_min = { 1100, 550 }, + .reg_list = { + .num_of_regs = ARRAY_SIZE(imx415_linkrate_2079mbps), + .regs = imx415_linkrate_2079mbps, }, }, }; From patchwork Wed Feb 19 09:46:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Shiyan X-Patchwork-Id: 866986 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 702631CD213 for ; Wed, 19 Feb 2025 09:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739958422; cv=none; b=HQ0oSIBAlDwaV9Z4LCSYHNKIai6ydoXGkXbmxWKMliBFrye2hKvrFLGp6UNhcBOKwmHMwjVcxzMpg7EJENQ+Z0QxCTqNrhYWX3ZAV0TcXTUPK1uAB3etUgB0Ews/dChduGDl5dtW2tLTsqClKyFEThL1h27ED3L/CxToYKsdXBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739958422; c=relaxed/simple; bh=+tfQBP7HPvNr3+sASUOCG71uCpixrJhk1qNNSeFGQ1U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WHWvqGWPHZtnxHOSxZL+J/h6XWjCRV7McBMCzNyWaup6EqxTOduW3xmCIDvhp/k2nIpXakbTDdAxVP29BsXepfbfJMk2JSGZm2LaFtjRkWeuN/UM/9ikj/1CgFzrdhh09sOvY57BWzd/3B9xwB2g1PSlUNELDVnyvwEemJc8f1U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R74XcfYE; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R74XcfYE" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-3076262bfc6so68586581fa.3 for ; Wed, 19 Feb 2025 01:47:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739958418; x=1740563218; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EOeaYwoypX2Yk9dXqBFQfEbH2pm3V3Vk2f7EBAkfQ0I=; b=R74XcfYEIj8sMpV0AKN10JmjVzGZNWIyGcM4frJUTSDbyukXkPbfUY8h8/6KrfQ8m7 8fPOCB6DAkZ6x8zYBKyHtiSSaqY8hOi1wH5w4vR/O17WwPCC5g8fVDIKIsaAA/7J06kH oJUWCbxpcH90LKsZqi7klKckicBSIoiiq5hEQlSMRIUrCjRkqdz5vmhy13aiIggy81wk UCNm6tNRaLRtYuZq9P34yU7TapldjSh6qErPSThIdBsHTPZhHaxsVgdmI7tvb4UPs8Ps zalQCjFXwBqbUy6ISd5SUyi3r6pcH1qtHs02INoqzMo3/WvGieAP9kf3qI6D2LvuYNR0 b1iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739958418; x=1740563218; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EOeaYwoypX2Yk9dXqBFQfEbH2pm3V3Vk2f7EBAkfQ0I=; b=H5HCVm998JIAWKctpncibzfRwVLhwaoNKpKw+j/KWyX7XXD7H7IJOSQhdpnaML6+uI JHbMZUpRBSVeuhvgtEjfNcZNq4OCPx/1GgqWlgu4VuRLtTQK7WoGC82NTQJumISk6Kpa HdD8KTRnrG0YILUpGVpcPZk/NNHycTLuZfm7SGXjLphq45BluStnCg9ZXTIMT55UK7h6 piP9NGXl9Em2v7rLmdi8XQ6/q/i4YhGjOuh9KWlmH3NGX09z6xjmqhQSQifKnfZftHvJ qyvWsc4aMwSBOnBzqaPkLfaq0CAZQ8DIj7Z10sezARpgIKJYcARTTCQ36irN8jr7/eqJ DZMw== X-Gm-Message-State: AOJu0Yyu1OynSjOrEoq3vAaheQJjftiQNMNNfRlrTH4Hof2x3Ltj+IgO JwVu6MAxq2jbFI4IoKFHWvzQe/2TE6EEW+ItjtpGTuNuz7LMWvTdf1GJHg== X-Gm-Gg: ASbGncsFbMEWqjMxVVu0fKWIk+XIFrXgg/k5Z8mX0NdUjQE8Rzlhc9l4mqSHj76Arks ChNSCOmcBfRErpwiRuKBrEUvlLc5perPLRZgMsb1SKW2N6N1pOTQ0k44OSY5QMRF8Sfu4yla8jH xnpmhILTecXmF5AeQ5riabWclWxrZ1TzeaZxbQdmq1R2mA5kwZMzCpy9KNS1ibA/x9jH0STd9ds P8GRid/eM+pDkPC89yLDFnTGg7SU1vq8ZsVmHuciLRSqaR1MsO2uVTXoOB9igcT2beIGVR85GS5 xlpPxvM5+xAPlfljZu/H27BhPRI/sZFE9QmloA== X-Google-Smtp-Source: AGHT+IF2QJUV89hbOoKlLDMOKgRy+snFfDIGONA9Ro1hw2s3WtD7C03YJuTXsRL2dpbWCLFlEWkFgQ== X-Received: by 2002:a05:6512:4019:b0:545:bda:f10 with SMTP id 2adb3069b0e04-5452fe5bebbmr5661923e87.21.1739958417757; Wed, 19 Feb 2025 01:46:57 -0800 (PST) Received: from localhost.localdomain ([188.243.23.53]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5451f105fe5sm2095131e87.138.2025.02.19.01.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 01:46:57 -0800 (PST) From: Alexander Shiyan To: linux-media@vger.kernel.org Cc: Michael Riesch , Sakari Ailus , Mauro Carvalho Chehab , Alexander Shiyan Subject: [PATCH 4/4] media: i2c: imx415: Add missing 4-lane CSI configurations Date: Wed, 19 Feb 2025 12:46:37 +0300 Message-Id: <20250219094637.607615-4-eagle.alexander923@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20250219094637.607615-1-eagle.alexander923@gmail.com> References: <20250219094637.607615-1-eagle.alexander923@gmail.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Not all CSI configurations are suitable for both 2-lane and 4-lane mode. To solve this, let's use a zero value in the hmax_min[] field of the supported_modes[] structure to indicate which CSI configuration can not be used for 2-lane or 4-lane mode. Now that we have done that, let's add the remaining CSI configurations that can be used for 4-lane mode. Signed-off-by: Alexander Shiyan --- drivers/media/i2c/imx415.c | 46 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c index 83b7929455b2..5f18d3f38ded 100644 --- a/drivers/media/i2c/imx415.c +++ b/drivers/media/i2c/imx415.c @@ -505,6 +505,19 @@ static const struct cci_reg_sequence imx415_linkrate_1440mbps[] = { { IMX415_TLPX, 0x004F }, }; +/* 1485 Mbps CSI configuration */ +static const struct cci_reg_sequence imx415_linkrate_1485mbps[] = { + { IMX415_TCLKPOST, 0x00A7 }, + { IMX415_TCLKPREPARE, 0x0057 }, + { IMX415_TCLKTRAIL, 0x005F }, + { IMX415_TCLKZERO, 0x0197 }, + { IMX415_THSPREPARE, 0x005F }, + { IMX415_THSZERO, 0x00AF }, + { IMX415_THSTRAIL, 0x005F }, + { IMX415_THSEXIT, 0x009F }, + { IMX415_TLPX, 0x004F }, +}; + /* 1782 Mbps CSI configuration */ static const struct cci_reg_sequence imx415_linkrate_1782mbps[] = { { IMX415_TCLKPOST, 0x00B7 }, @@ -531,6 +544,19 @@ static const struct cci_reg_sequence imx415_linkrate_2079mbps[] = { { IMX415_TLPX, 0x006F }, }; +/* 2376 Mbps CSI configuration */ +static const struct cci_reg_sequence imx415_linkrate_2376mbps[] = { + { IMX415_TCLKPOST, 0x00E7 }, + { IMX415_TCLKPREPARE, 0x008F }, + { IMX415_TCLKTRAIL, 0x008F }, + { IMX415_TCLKZERO, 0x027F }, + { IMX415_THSPREPARE, 0x0097 }, + { IMX415_THSZERO, 0x010F }, + { IMX415_THSTRAIL, 0x0097 }, + { IMX415_THSEXIT, 0x00F7 }, + { IMX415_TLPX, 0x007F }, +}; + struct imx415_mode_reg_list { u32 num_of_regs; const struct cci_reg_sequence *regs; @@ -576,6 +602,14 @@ static const struct imx415_mode supported_modes[] = { .regs = imx415_linkrate_1440mbps, }, }, + { + .lane_rate = 1485000000, + .hmax_min = { 0, 550 }, + .reg_list = { + .num_of_regs = ARRAY_SIZE(imx415_linkrate_1485mbps), + .regs = imx415_linkrate_1485mbps, + }, + }, { .lane_rate = 1782000000, .hmax_min = { 1100, 550 }, @@ -592,6 +626,14 @@ static const struct imx415_mode supported_modes[] = { .regs = imx415_linkrate_2079mbps, }, }, + { + .lane_rate = 2376000000, + .hmax_min = { 0, 366 }, + .reg_list = { + .num_of_regs = ARRAY_SIZE(imx415_linkrate_2376mbps), + .regs = imx415_linkrate_2376mbps, + }, + }, }; static const char *const imx415_test_pattern_menu[] = { @@ -1375,9 +1417,13 @@ static int imx415_parse_hw_config(struct imx415 *sensor) } for (j = 0; j < ARRAY_SIZE(supported_modes); ++j) { + int lanes_idx = sensor->num_data_lanes == 2 ? 0 : 1; + if (bus_cfg.link_frequencies[i] * 2 != supported_modes[j].lane_rate) continue; + if (!supported_modes[j].hmax_min[lanes_idx]) + continue; sensor->cur_mode = j; break; }