From patchwork Wed Feb 26 15:23:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 868791 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11010060.outbound.protection.outlook.com [52.101.229.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D14E3227E8C; Wed, 26 Feb 2025 15:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583532; cv=fail; b=Sbg0gFfOWOhdFL68nJiVe8WX3VdkyJ7YGyxepMWWoziTsZaOpCUPFjT4KDenAZ2T9X4eMGFNEU2roGUzourH9rhn9kwAGzJ0tBIRmCNq/OPA0/jsLZklSqAGHilHUOkthKEDP7rinUQ62xMvvSwV+w9DcyLWlmcuB2PPqPzHWxE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583532; c=relaxed/simple; bh=PZtVuZgD0emfI/MeiU7kj8XJcg/h1dCcpCgIwdrV4ew=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=nHAwyttx2I5EUWfuy8Z0u2XUrv+E2Ea7H0+Q0oVLcS2L+xLdwaxT18iim1AQlP/ndo1+R1+XI9Or0PPwbBvibXplyWTs2AaYPIVnlmgUuq1c0Pt2oXXzkMvjeQOhtZAm2gWI2pkyVxsnx6fVQ9/KjY1Wa/bQFlVCT/WBQM28jVw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=AgjAx2n2; arc=fail smtp.client-ip=52.101.229.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="AgjAx2n2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t2aFkVGXK+YA0v1Vam0q5zbWwqe2ZjjaT4OXxbDuLHTPlw4R0Fa1TZdKu7/btSapoETlCXf3Z0z2ePSBUzsxuNatAgUYz/NMhDUBWMwsEqcSBzFpvceHs4AlaIIEvVodK0Bh4so6aHbCkxrwypilxZalmXCUGRIFQRC1XpFqZYI97F3BTo8tnQNZZXirjuN6PNdQlvljUBm/nlmQ43u1NGFECpBrFfeG7RpLywdE0pjVWA/CrE+XBfMfBSYCVp/ZD97vSSpprDqrDAVV39AtS9iXNHOfWer7Smk5/h9TmsaUYjR57t+ZmHQnr3hzlaU8IExe33U6/Sch06w2ulu0CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=csEGu3K8RSPvn/cNhtYuZmSgd2SAWhqhRDaSl2VQfJA=; b=aT4PkEjiiIcqvgpQ2Z89Q1Vd5hZE0VI2rqUg1ZMweIVzwAZcE0mkvS/8m4qcDXmRD7TPi6bWVaBlSB5L6hzxhfeyQgo+2fBc82UiMhT2BZ+eqFoCEGfcGuYOyiGRqU9BmzMP9liLGKGLNV6VfmMWlEFq2WQ0TO2CQrYaGzMT3THmhRPZQKb+7JwaKxYuwwo1tk5DwC3CFV9hD7g3QVr+MSFOKxf2GYo+vmA1ZUeqj9JeRX22qwTNxYhpJPcF6K1J3NZMF/QiKzB3ITEsnoSBTGD6v0pEWDarXVohmL6+4MCNCsVMCxOv1ni/7cEVhIBJtjujHyrBQ86YOwzpzKNHBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=csEGu3K8RSPvn/cNhtYuZmSgd2SAWhqhRDaSl2VQfJA=; b=AgjAx2n2WpT9d7+12b2GdEDI0C1T6Ghp63+A1b4aHyt0t3CJhD2IMPmvaSPTFQVGiyICo5uoawa/F2Qrh2/JLqPiSqQp6EE478O5ecu43wE1lB2WuDPGo27U1K8rQUfypxJC/Y0hvXF49W/PDuUPrrCAg/pjMu+GAApwCiiJRWw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) by OS3PR01MB10248.jpnprd01.prod.outlook.com (2603:1096:604:1e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.22; Wed, 26 Feb 2025 15:25:27 +0000 Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3]) by OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3%5]) with mapi id 15.20.8489.018; Wed, 26 Feb 2025 15:25:27 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Tommaso Merciai , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 02/17] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/G3E CSI-2 block Date: Wed, 26 Feb 2025 16:23:26 +0100 Message-ID: <20250226152418.1132337-3-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> References: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> X-ClientProxiedBy: FR4P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ce::13) To OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9PR01MB13950:EE_|OS3PR01MB10248:EE_ X-MS-Office365-Filtering-Correlation-Id: 84b08753-74cf-46a2-d90e-08dd5679cc2c X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: z0ROyQxOEcUbSHNyAgnIBAXKF1sot4Fjoy+zARqqgL9DVWp/Kmw4r0/EQjPHobLs0EKtlzBPBpAfVpuSAaepAsr9ZWztQFgUYebDViu7m2TWWzGG9FMC/HiLuhDDVgHVTAWkscC1wxGWsDRa2/JUa/PqIlfw799oePRraRypXLJ3YIkutIgq+0AmckF5vcCKWaHKKRzHez2i9XY5UI6v4PVyw77EWFGTql9Y9YGMtY57lXIvngHaz+mWphCrVyLu04CRsMoExPZhLXBu17foVJJrg/mM1Ll5WqEGPNR/h9/aRODxMWbhzPOLN3Z/eLoOrE9Pn/HH+2ro/fx58lX/UPvE7BnkgXGXVx5dla/9QvNC0KbIjJUNhYDrPWjgWmD18yIesmWlfrL5YH5OjNrn3M+2DFE8zpEHFAjdo+Qe8RjdOU/no4UjjXU2GK4BKdSNQI+d22s1HEljsNAqDMKnVAP1eERNjx8NShwaNTMaCZjSXzn8FDWgROyYFycVNhLbz+/iQTzPUwjpRnNbULH2OCCchoXlzm7LtwF49Ivrb2CDKfYtPep67XFS5/Qkb+fXSWr+/nxeLBkOdMFt1w5CbnY37r5BU4+Z/0oxyzFFQFSsTsC6brTfn0FnL7oBT0q0ivdLnSXNLLNd/mDdZC/ZbCW8nYX25glJMWRPQdI2e4MdEC+zDXqDyXfbLMTS9U7TbDrLBoIO5sVx7uidcMVS8r3x1nMlWk1VZvreaBM0Fer6mBadX8AsRcfQkYXvD0yW3SaftLqh+9TvTyCC9fhnZKXthzd1GNa1orwzgh9CuKWPeltYPCiVeOFf87tv7QYNEkj8DNGfSzlmmOwv0msx2NRtx/01tliIPkwMMqWoDjp2Ezqv1VAH1+fvV8Kgnbt6Ys40n2hMfm1WcpO54VnmF8lQw8XoM7bBNIVNu1Mp7BNPhwKGvejZ0Z4HRWqc/YcIeptEV54sxM+Nlixi/O/C2azRWEf1DRcQXAS5kDkN5HocH60BRo5kQ/tmIiICfievkxntl1NRCQ7kKHgtTEKYHoWvVSlk6kvmVTw3u+MiiLQE0fB7qYW8yph8ko4lduhDOQ90FwMjwHsCf5DQM2qaRXjVkVgZzKTJCyfrmzVLjhQPDVs2QATN6QZI923NTKmT4hvpSMNH1nzfajbmXKq48E+ZI+sKJrYoj79AWcFKzVWe/11gy+rmFFHFCDgCyhRprCJg4eeZiqQwHigX3XW5fZmyUmsjAQ7KbFALJKpKEF6t5zBVn0SNcFLGo/t0SeY3XLnXH/dgJ/Uba3lhkdW4lSRGbuk78WqtYK2+PxhNzy27O3RPTEPpAboEXK2t5H39vo9aT06+cxCxCjgu26S/Wyo1FD9q4pr5Xgl1j/L1tOAViCoAACkeey7dBo75blmPSSlQPE2FeHseEd9VUcZf2T3fciBTqSDGJrBqSvXXA6cB4sXdR3m5M0NhL7QXKkXT X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS9PR01MB13950.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(1800799024)(366016)(52116014)(376014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: In8H+4J0m6HYbwMIQdVBtVv93fESOkn7H0Z68VCVxbg9MxzwNRleCdNItZg36NBiy/VCk0cTYEQaSKk3PIgrP7O4ZJmlpI4OHsC2kAI8eWWeBxcq1BcVGYUhXCBzTEqAVEvoZEyP+oZIPoM9h8tgw7tZ/9paYgyIb1z0JxyAjTeuzE4UCzZgl4yJXLwvYccgE8gN1XIYc2LiIcMLCzDxSSU8nV9vn60e218d0SJTv9O0cG1OjHGYU4LhQNu62j3j5+/mVz74WtZplySd46CGvwBvhLqLm0DfbmavqvAbRTADtiiMs1X02iiVvl6u+NPJTXl84gb3ngwlWI7CF37GlNeZiCiiwK9TS/ruK3QUK+N3hkXnzq24TxIKp42B0mXZhING3FeSqaYgcsWNEebZEgt4Q3e1MJ8Gv56k+QIoVmavgJ7DtNG8VKszWPbxaD76WE8TjIWGllhcYJgARJ1ARawwpnZ/cQ+OMr/YmyU3RSEeBii07PKlN0poKAY9v794K40DNcliKOfRrzEsjf8v9DosATGAL1msKIAlsJvYIje48gHrHjqrnnvXGGzWckf5lelvLS0/YUw8m8AEGfLXBis4SwRcQyKfU1RdcYyNEauHyCIaTHH6cqbR9CrJoaQiOKXPQ+lgb3U1d9Ao6uC4Tao8/6GzFXoNF20N71d1F/YhaIM4OmrMcOREbvLrl2HrnkNW+/eAboGmHjpqCaESXBfIGYN1FeM2Wx9wIz4m5m+Ot9B+4lIHDPJx0ZM/eKZVBilRGi3qfMTfNu2uTOwzT5VMRrca/7bP7Y2pAs2yzGXV3FmJqBh15ELIDxpaEH+mk5eFnjpiXVzQv2ec1s6G8aTu0Y0OBjYSe44AFEBCAaAInGndSFDperO1sfQiBySjdyKUZHtefc1Oaqip5WgLrOj4T6yxKfxQkcWLdtByK+AUp/KuRqLBKFUE7b3/z/D/PpGx/eBGyitmrl2GvREppfxek4uho3LeJvc/1vpLMdmz2lWBl3SmKXLWRULzIykz2fqOQJDCB3g7gQQ3FwIBJqAXTImt8l5GUKuOabLBRAnS79StXGK6eqfloT/ut2PcEaGyS1AdAjK0DivgEOlfySktWCYwsU/ZVvoEDED13LQWnzpRuB+j8f5XndJTPbeY/2cR5Bh3o2ONKAsw2WDjQpsvyEDhmRFxE8ZxWnDO6lrevlpo/XjUO8R2CQ5LJAVCtx/f1/1Z04pfMGP3TKtV133nH4TZIFG8dlZLM3Jdwwt+Hx7wxmQhP4g6qjgaWMpJ3WUqNfKAzqr6BEVgFHn+Qujs8JCymzPUkLw5inqRV+lisc9EPSMoqOoGl66ZZy/Y999yPxwlvfKacpqNh1pbAc27Nr4oGFLHt26s5QVC+okUpEzj56OQA3pZT/BEqTM3dfHnG9x2kn2N0DxCS9hxhTu4xbkMZy6Fj6TeHZWbz2cmsfHNoqRd+U6JCENa1RMnpOcqNMNq1FZEvozmTCZYUxW61XQMB5ltbvuhxVTXuKQN51VRCfuRtJbMgZlSipQkcuSXPHrXrh1948rAHHGOwToTnL87+j/Z2M26VPtvS50lIb4cFRFmXNbmrZeHpsCHmq9T6loJhAfFzV5Uht98aSXhxnXbwrk/pW6YKejuEX4= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84b08753-74cf-46a2-d90e-08dd5679cc2c X-MS-Exchange-CrossTenant-AuthSource: OS9PR01MB13950.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 15:25:27.3903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bED4QPfndob/uw2LlJn1ObaSbl2xvbj1PbeHNxEUNrvl/b+Z9WHpLPf4CnEIkujxursLvxJZCMHwvkHH0A0QfApAVzUG4a2UjCu8y4CgYPq2Pvatxzl5GF2wmtP6l7Js X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB10248 Document the CSI-2 block which is part of CRU found in Renesas RZ/G3E SoC. The CSI-2 block on the RZ/G3E SoC is identical to one found on the RZ/V2H(P) SoC. Reviewed-by: Lad Prabhakar Reviewed-by: Laurent Pinchart Signed-off-by: Tommaso Merciai --- Changes since v2: - Fixed CRU_CMN_RSTB as suggested by LPinchart - Collected tags. .../devicetree/bindings/media/renesas,rzg2l-csi2.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml index 784ba88c9b8f..02297509a48e 100644 --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml @@ -24,6 +24,9 @@ properties: - renesas,r9a07g044-csi2 # RZ/G2{L,LC} - renesas,r9a07g054-csi2 # RZ/V2L - const: renesas,rzg2l-csi2 + - items: + - const: renesas,r9a09g047-csi2 # RZ/G3E + - const: renesas,r9a09g057-csi2 - const: renesas,r9a09g057-csi2 # RZ/V2H(P) reg: @@ -59,8 +62,8 @@ properties: items: - description: CRU_PRESETN reset terminal - description: - CRU_CMN_RSTB reset terminal (all but RZ/V2H(P)) or D-PHY reset (RZ/V2H(P)) - + CRU_CMN_RSTB reset terminal (except for RZ/V2H(P) and RZ/G3E) or + D-PHY reset (for RZ/V2H(P) and RZ/G3E). reset-names: items: - const: presetn From patchwork Wed Feb 26 15:23:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 868790 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11011068.outbound.protection.outlook.com [40.107.74.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99DBD225A59; Wed, 26 Feb 2025 15:25:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583545; cv=fail; b=BYUh52YyZ6v96laPaevmrUoHRO/pnWBxPaotfDFpcpXB6sWRg2lbdIUdVsqK04ltqoj8sJ42tXUOgYHybBSfOOBuH671Q0OOUVwRYtkRzC6pImskpAyynHyrMA1R7TBYrig7FxOd7cxfdM3VzTvG0XgpdLciyqX6VqPl6pSKfIM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583545; c=relaxed/simple; bh=OImP8N868sA9svr2gZKEzGmfQNaho8sk6AxuzXYzlMY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=W4i7P56MSkNfHYWqJGLtg28YhRQuHzJDZYJ7xfqbwjZaTR5V8txeClTt0SH7/+4PENglLyWPOIl/V0bQoSGsTSwsdOmWgtTWrdBb3uGOSOHQWvkBSIlZnRENsJ6IYf+69HWgEjmQjp5q0BYGPYdF6TkXogD45Sj2/puU5lfvuMo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=CwualKRi; arc=fail smtp.client-ip=40.107.74.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="CwualKRi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u3ckYOnHnEUXyJIu37Bam4gaTcI8sOXIATPQ9d2jIjr7pu87DmlFFLe8O0sIHf98jV/fVwOPKZVL8QTqn0cUEQp3AU+8QManwXlh/9W8iqaYCbo3i2kiIn5wvLudOTWw3Gc7M3NNQIxYY4L7f/SyuZ6wROv8lINpdYE6oohzJbEDs6fVe8wKk+bGNnmW7B+Oq924I1Gz8qa97JOLwmp2y2JSQX1B9OiWZXQzZC2QLvNWCt7JOVz7UvplCugt0Z9cWb2Jew5T1RhVAQ5J1i1y1VxauTqidvQBqEPr5Hd9e6fk1P3b+WJLTanamlCAlXfxZhv91lrhyGo9PhMVX1Gvyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PePgfD4GrURJ0pUGRT4e7YSpUFXsAzxMurwfw5TYoNE=; b=tt9/tQcbXyetxL61IwLAPhQysc54dBUmHebmUmRgfL2LjSI9UfdC24tab1en6o/TGxTe9vlObHa26Dm4qeaFUzejHGFU/JAV6tIoM1HNtEEhcAiHB5LGPDzo4ryWUcxIRFRlyUrMwTjr3d4Xe9yqwFOXO2vBQJnRDzx9ytutR8e/tohtiUb4N0ju+EQfCyD9ri5M/xsmNq4yz2xVfi2NiodMuChG7ntYW1t9dwpkmvHJlM111A8CHA/xGubZFzeGNb95oWy8h7UOOHQPtteTkbbIUTF+EVpQbZqBNp9uY1rlYKyTpN6bihoQvaf7T4on650bGNy0PUHzeC6aNU8lZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PePgfD4GrURJ0pUGRT4e7YSpUFXsAzxMurwfw5TYoNE=; b=CwualKRibUM6ItPobijCGp54FzSs9SoZf0l+AuvV14YUJhStSWOTX7jmMWvzHNg9bzKtzb7YWvM1w3WcjmigrZNenZvxcqXRzWzoGXLXdkYkCbFOYoOAq+NjrsZLEiV5zUPsH3GvdWt/mEzigho3QMstpKrjBcHPFwLeLWqFV90= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) by OS3PR01MB10248.jpnprd01.prod.outlook.com (2603:1096:604:1e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.22; Wed, 26 Feb 2025 15:25:41 +0000 Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3]) by OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3%5]) with mapi id 15.20.8489.018; Wed, 26 Feb 2025 15:25:41 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Laurent Pinchart , Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Geert Uytterhoeven , Magnus Damm , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 04/17] media: rzg2l-cru: csi2: Use local variable for struct device in rzg2l_csi2_probe() Date: Wed, 26 Feb 2025 16:23:28 +0100 Message-ID: <20250226152418.1132337-5-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> References: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> X-ClientProxiedBy: FR4P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ce::13) To OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9PR01MB13950:EE_|OS3PR01MB10248:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d1ac6e3-0e96-402a-bcce-08dd5679d478 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: chWlmsA/oDiGWLUWqI/tLuesIERh65o4DEObnnsWQ203Ww6P4IUvMqA1+EMigmH5ktKYX46G95H931qqeMvywlxG7Aei9gYnRYPoMHbPIImOGS/G1609ilvHMaMg4mQaE73mNqSFdiXbLrjDHYohIX7p4OrQ2h0tfA07GdLDHIA2C4ucSymCSjmtbtQ0jiFXLrUPP8sDWN7tNS/Er+uGrxL9sT0KiheZXCtAZfgH5FCLwrwkKzhdZuy/GzD7UkvhV52rps8Miw6Bz1+tRvxCSEvpsvWQphWcJ0X7tkhVxpAjmkmckDdN86jfTKO+mdxAGn+bIfipGs6D4TJ42kxNfc3kUdooQalboOAc1YedpZtU00lJkCWr/+II517tbIh32PMRtFpUBMTQ3S72s1dKR5MIomA0LBj4fjMxGZxHR2NrCAAifbvAE0OYzQQfseNf2eyAbl7BweTXFuXhMpRSDflFjZEI+60rHbAzPfWCL7QBxP6wweIVx0msKcaggFubSBg/jrIzh42f7WDyz0On94ZJbhXdL9Mw5+Iva+Nw0sIWkcXE/jRObwH//U1xeqwfTmtLvcu1NPhNgLFkXryEf6R0LighgpxCvHb/UkSqKv6KESzXU5QUdK0NrVboqr0szQTfMBkYvkvOg33r/2j8fP5O0tnVT6lor85DLXKFZQm/ZhTf9rPZsex1sWBfiBWMVpXivq7eXh49ANWKirqQdZCzW1BT29oVSLCbrufJb1Pa7SteGjMuoM3AUVfVbYMkVZUnMBltJz76+Np/n03l9LmNl3hRysQUBkHyS+9zp0tEzZTN6vpEHa4rPtAxYPMRL3vNOrf+1xv9O73BVvge/83+nFmHodxTg8If6U2mD3QL3sv/1b7aJ/IQKvoWdDWT/ci7FZB1F2ETkbNdjBl2ulwR3qIEAMY0xM0U6eQXpilYSG+g2IwMXcxIPRrDzCdZ8bvSJ42/MmO0iLrjNpF2J3DY6mPPVwfJcVufYx7RA8IYMFGTrmGOQfFwr7p/vM6TToZcTJJGApI5N9vSUkjFFtO4KI9MUsPLi8RElrI57hEdTDXQjEvO/gdruzWgrVmW39N5oirNr83RUkCtStnfZSSKqhJiNLRtbJTS1Tx5B5ohVCBI8WozFSPhbmtXO9Wng0KVJ0b8X8765NuhJbN0el4KLrzPTFFMkjqaZ9VKTvWE8BmfKhgEaV4kST0LVpjFCCVSugFdswNttp8Kr8Dw0zFwY812HYt0UFKWCqyOulMc6Tdv/ig+hIqqnqSeIJuVJQCC9kRP12J7nko3pfs+RfqmLa0tIyP7Tx684SU0j0pczX9qzDhcmg+iFMuaCa4HV1BRIkcRWM/njjOqsc7b1fZdZ0fw8SdmCwSm9aoGwWESJtR/PjHc1NTl8RpQ3+GseW5DHmMyew6MCHt0bUjxs9cJF76PwAD/AFmFPO9tnL/nLlcFa5+fbQkKWHIb4WlJ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS9PR01MB13950.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(1800799024)(366016)(52116014)(376014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QztOnmlHZk9Ak3AdY4/4Nj6Vpf0K7CRteOeePpknSwblCl4usLOYINrH7WDqtmCbFGI7p4edGqEUKFVwrMYYTh8hRa7xZL3xzQcg81vu21rkM7tSgDG+g4V1UfQ/ifzCFFzTPz2CZF1yJYS9D1Hx/oZVhSI2OdTIZ4tfEzr6bYbViEsRp5+ljB6Br4Ubj+ZtJ61qTcdnxnsr1HymbwZJr6cljCNTLg4gRYyXu6STbfyQF1s88EC50lGqzfrDNDBlkCZ85hCLyj8epnKqWMDLpWKgMcaPwiTzwWua0fvrh7vdVzmn0+ORrMAfxWsr7ojzSMmiikJWeUyRwOR7qi+UqMLn5gs7kBGsZweYzSi5eR4CSY2dSp7P+6ZkUhvQtqsI4ZFQHrhOMUpaRRmlbbPsGRwQn1BZENF0UxjOjyjogqsEj6LaLAueohhvQ7Rjsw81gPMvBZaYNNpUQbfVQtEPUjFLcR02yLE1k1HQc/qdQegJ0pqT/H87frwFCyjkiEKlyUOCawM6T7n6kFoH+0+ywsB9duI5pYsaJBDRXpd57rX4vS83amTlZNKOjnCAiktZ/ns0/D4/Z89UF1a3SHB3hUYlqy0zJk4NPTb81d8qLriNwDapharTsZiAcQXyoAeUq2XTydb9W0pVbQbSyxzOJMdPbOYYcgiSrSut3Wx0lL2uk0V7ps7U5RC5k0o7RMUDztSADyEcvwV7oeoZg3eRwGbheuf8bJoz7SKbKEh1tLw+lPjDaFXlpGwwO9/z2V/Tb0ZEc9ltp1OlkWy3D1YFa9EF0zYwQrdWb8s2jZ2hQyA7WJZIbOdLIe9rMSE7JtlWWKQn8sgxoVEhp4904apD7kQ2C1aPByw1+GOCGFw0SqsnBVYYtfuX0MlIjlqXhj3sLWjVCdL2/x+Q5wVbn+yOhpukJP8B4Dua90QzsOQYqOM9+dorj4jrDU8je6laD3bOlOKjj50Cso5rm/lIiuVr4RBNrMyaKWULQ+rOuX3zi7npx/qO3AgK6tPZjApiDt2SjqKomy5bkuYjnT1Of8SDfVnx+QihjzEWZnEwecm2NoUDlCDcqqRBMnUEjlhJfhefBqtm7+kGiv3WJclR9s82AVXSfJBGwOBaqxVZ3dRpCh4Cgrh+YZLRgGDhu+5HQA/YiR2IeSgYV6vZhhbpqqqYbVZynks4CLXOAd4SCZEla26yYHYDudRzNymCvEf2ghGQQ1+3ro7UulCbCVnaYUHf5+WCaXl/YqdnbYx5s1sOcshdvxsqFD/Nfhl21cVMVty6T73uFG5gANX2MYSC6gQk0EmzjUKG8tXECxquU+NWZd21R3Cg3rDeyTtRmsXJ1PyViBULDZ9VYhwdW3rHbMH/c2o2I/qllTauZ6hvP60Ph4ja++Kasj9M/2xvtqULRIp6M941oiEEsI5FwvBQyS3CnbPuEYceeAcbwkdQRn7FxMNfHCL6E74aEQlrsGqAVOdf0oDBta5D6+RYSoHulVDZitSviPEwqjbPtS0KeZmSjZ8mF4ROfaXta6NvH7fORkDlwj1kxWOkAcCUHWdElYu5NytvlrIJRzyUPI+yjNDd38XkHd8Z6UnYKJal6pEg9LnhKasLoDGHnGbSggnSx6yW6RgU78LNlKxYe7s/d6RRktY= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d1ac6e3-0e96-402a-bcce-08dd5679d478 X-MS-Exchange-CrossTenant-AuthSource: OS9PR01MB13950.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 15:25:41.3296 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lEm4kvQuOF5yzPtU3dsGxeDHRFR98as1WiYyCEDOaVco9wtgM4D3LBa7rL0o9rVGZkKHoc6ye49zksjSvLYaEgl18eyOP0UmYfB2sr21BsDKO9Fh5X2u6nny7P8Fxd4a X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB10248 From: Lad Prabhakar Use a local variable for the struct device pointers. This increases code readability with shortened lines. Reviewed-by: Laurent Pinchart Reviewed-by: Biju Das Signed-off-by: Lad Prabhakar Signed-off-by: Tommaso Merciai --- Changes since v1: - Fixed commit msg and commit body as suggested by LPinchart - Collected tags .../platform/renesas/rzg2l-cru/rzg2l-csi2.c | 31 ++++++++++--------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c index 881e910dce02..948f1917b830 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c @@ -764,10 +764,11 @@ static const struct media_entity_operations rzg2l_csi2_entity_ops = { static int rzg2l_csi2_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct rzg2l_csi2 *csi2; int ret; - csi2 = devm_kzalloc(&pdev->dev, sizeof(*csi2), GFP_KERNEL); + csi2 = devm_kzalloc(dev, sizeof(*csi2), GFP_KERNEL); if (!csi2) return -ENOMEM; @@ -775,28 +776,28 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) if (IS_ERR(csi2->base)) return PTR_ERR(csi2->base); - csi2->cmn_rstb = devm_reset_control_get_exclusive(&pdev->dev, "cmn-rstb"); + csi2->cmn_rstb = devm_reset_control_get_exclusive(dev, "cmn-rstb"); if (IS_ERR(csi2->cmn_rstb)) - return dev_err_probe(&pdev->dev, PTR_ERR(csi2->cmn_rstb), + return dev_err_probe(dev, PTR_ERR(csi2->cmn_rstb), "Failed to get cpg cmn-rstb\n"); - csi2->presetn = devm_reset_control_get_shared(&pdev->dev, "presetn"); + csi2->presetn = devm_reset_control_get_shared(dev, "presetn"); if (IS_ERR(csi2->presetn)) - return dev_err_probe(&pdev->dev, PTR_ERR(csi2->presetn), + return dev_err_probe(dev, PTR_ERR(csi2->presetn), "Failed to get cpg presetn\n"); - csi2->sysclk = devm_clk_get(&pdev->dev, "system"); + csi2->sysclk = devm_clk_get(dev, "system"); if (IS_ERR(csi2->sysclk)) - return dev_err_probe(&pdev->dev, PTR_ERR(csi2->sysclk), + return dev_err_probe(dev, PTR_ERR(csi2->sysclk), "Failed to get system clk\n"); - csi2->vclk = devm_clk_get(&pdev->dev, "video"); + csi2->vclk = devm_clk_get(dev, "video"); if (IS_ERR(csi2->vclk)) - return dev_err_probe(&pdev->dev, PTR_ERR(csi2->vclk), + return dev_err_probe(dev, PTR_ERR(csi2->vclk), "Failed to get video clock\n"); csi2->vclk_rate = clk_get_rate(csi2->vclk); - csi2->dev = &pdev->dev; + csi2->dev = dev; platform_set_drvdata(pdev, csi2); @@ -804,18 +805,18 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) if (ret) return ret; - pm_runtime_enable(&pdev->dev); + pm_runtime_enable(dev); ret = rzg2l_validate_csi2_lanes(csi2); if (ret) goto error_pm; - csi2->subdev.dev = &pdev->dev; + csi2->subdev.dev = dev; v4l2_subdev_init(&csi2->subdev, &rzg2l_csi2_subdev_ops); csi2->subdev.internal_ops = &rzg2l_csi2_internal_ops; - v4l2_set_subdevdata(&csi2->subdev, &pdev->dev); + v4l2_set_subdevdata(&csi2->subdev, dev); snprintf(csi2->subdev.name, sizeof(csi2->subdev.name), - "csi-%s", dev_name(&pdev->dev)); + "csi-%s", dev_name(dev)); csi2->subdev.flags = V4L2_SUBDEV_FL_HAS_DEVNODE; csi2->subdev.entity.function = MEDIA_ENT_F_VID_IF_BRIDGE; @@ -852,7 +853,7 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) v4l2_async_nf_cleanup(&csi2->notifier); media_entity_cleanup(&csi2->subdev.entity); error_pm: - pm_runtime_disable(&pdev->dev); + pm_runtime_disable(dev); return ret; } From patchwork Wed Feb 26 15:23:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 868789 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11011008.outbound.protection.outlook.com [40.107.74.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DE83227B83; Wed, 26 Feb 2025 15:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.8 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583561; cv=fail; b=Lg5FFGul0/5EtHtDyb61As8HhIU53ujLcmk/V8/x8DuHrEgOzpA7ckYL5ddbB7I377SEfPlpei216AUIcUThAWsAjOqlARxQQ+6Q7eb1rZv+LGORFJdHlOpJHqf356eDz8FeI84JK6vgyDgxH2tM0IqyBsxhUJuuhduK56T90Wo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583561; c=relaxed/simple; bh=LqfLMzDRg+QEn35zV+3oPZfAc+VImK8JMpyKyCgmZ6Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=dckdF7jAzTKl7IJUvJ0roGff+OMbEsf8z7chWTiQ9nL/GIoL9fD2sMwJV0i+PurEx6tM4Jvq0R1v/pweu+E+cxBNPd9vnrZ9rRnU4BPaGwhIzoSNprI72zJYuLhZpWFveRmEgo9MJqggMgklI9z75oXXtkhMAhIcwwN6x2MDwV4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=b0G0gsFn; arc=fail smtp.client-ip=40.107.74.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="b0G0gsFn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PcZehTdtqt3CuPKPQBVw7KUnZkJuR4yPaH3lqgixpFo8k8rTdy3EKFMvVGsJXDMFXfACwsUx17lOAHUVo7n47Ip5U5zGBsDDqH6x6daP3el0Nj7EbA44Y+OtrPDGEIneEAsIehy7f2ziuhlSUDDXeYqCwZONp+10fTSgzSVhKFx6k0aeiWx9pqiXKgxtamgU2OQA5FVU3IrF+ymy+JDovbGrEN36Bs8NUvVlamqPsA0XNqYw1z1Lnzn48dvLhV0yCFly5ha9dWBQ2NH3SV/yCSJFOYkDbmU5Cvva0MaiexYKVZWWGWF7JK+4BvTr+peKhEZhbuPmU4XgUbiYjCK04g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bjun3rYJFbgHoj2Fxbo7XX+LDOGEbWMW0HgfswOEADg=; b=JgqGQuSjxSaDtlSyDEKGcvCo8jg+eqb+aivVvmCLg5Q3Df7A7qInrO0vQPLXBMjX60x6Lt40e2Y2IS9WrvNRYkpUhD/DwEXF5Yv0h3kVzy23STveYJtomlKOFmoQYqsui/bSJks9xaGc8+bczFjoN533pnOlPv+p+egVSIH4IfIRBxLZXQHn/gf8ILkplntPdYkacZOusZ1N6GjHIdhpEKNgl3fI8ijkBvorMR3/ELSuQe9h7cY1Qom37y0JN+qqzU8XIpLBXaC848TcpCslkP5ZT5FdORn8pkc5Hf3ZSvOF90w48eDJvMGiEjCnHUjXgJ/0cP86T0fpYBZ2DI/kgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bjun3rYJFbgHoj2Fxbo7XX+LDOGEbWMW0HgfswOEADg=; b=b0G0gsFnNU2BHXNppZYuQK/YccGdnAb/9ONwY/5niybYOWqEiyjZwDhboklw6ByoPzafYMD28eiqfaeftNFZigsoR/BSAd/cX6ufNhJ0pa2Unu1X0s+W7cUoLreRwYNqMBqs7CdxZ+LaHcZtYXv713vAfGTVEX4FYReV0gWKpsg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) by OS3PR01MB10248.jpnprd01.prod.outlook.com (2603:1096:604:1e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.22; Wed, 26 Feb 2025 15:25:57 +0000 Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3]) by OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3%5]) with mapi id 15.20.8489.018; Wed, 26 Feb 2025 15:25:57 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Laurent Pinchart , Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Geert Uytterhoeven , Magnus Damm , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 06/17] media: rzg2l-cru: rzg2l-core: Use local variable for struct device in rzg2l_cru_probe() Date: Wed, 26 Feb 2025 16:23:30 +0100 Message-ID: <20250226152418.1132337-7-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> References: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> X-ClientProxiedBy: FR4P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ce::13) To OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9PR01MB13950:EE_|OS3PR01MB10248:EE_ X-MS-Office365-Filtering-Correlation-Id: d123e49f-81c1-4439-0a89-08dd5679ddc0 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: D2l7joOc0cwbbGjaUn6NSJG87b3EDwHZHFdMY+iIaBTaHkiaiHCIomFG/ZYcdmxZvGEAP349aLW1SUlMnMmaYCHJBnYE/QCKoZf9kJA6zGnSFtQw+rC/q4FeJGlgidGWx7woj7lyxabHXwalOgMnoe77vAf9LDNLGquluiYqyxKXb+//sRluKZubwYV4t2CDdwpJ98n68PdzNhENUeIdBIiPak+Sz876Pxag/1BGjmOBRMNKJ0dM8yV5q+6OhV5/Q/6WeCbdmG0Ka+qfOb/wsADoLYz2oD9GxjFMA+UgP85XsZoewQeTvpPu0Bqof0Yv+w0dHMDGz6BHAK4Hir+e3Ey3Ro5LQvM24n3QHe0y9BXW8MdvYbcbdev1ylXkmLc6yDc1GjpHps3PUu2TSiWeYhW/0AuKsOBrtqJZR7jW14Ou3xsAPhw3Sp1i3lvxtXjNOu4b024rZz5MlryLVOYXIiKiIgrtFPl7N6pgnlXMsVnwlZyL+USRJMa/6mufFwXjcUrQps7gQGmUDGD39iXFx3sPRUBC/GJEXM3hewyJ0Tg0VGmN5WpBWdRmJ36r1/y4eIqe0OJNE2eZGH4CUahw5Ov7Z6VnnFHfhYEVgxIbJN4WAq1H36Our4xTuGtm6nEMODSKo8afJk4GTTlgPe53tjEX5K4VLLfgfLbGamzt1yZZHMajVfpIGqAd8U/tImZa+8F/Ahc/sVXJQl/tzeafrWbV4RImn79ugnZmNOIXaBvh6ZgHyEdddB+G3+WfLLCbCuEbg27Nv38S5qVs670cJScIwmIz+JPslg6T4UOxfQ/dndna3DTu79W1UjPetE2grHDxfZt0PWUuu/g+XvODZUYhVZDD8FMAPrePdkM4NKyH76T7fAKl4crIq1rjJmQrC1IQoKaI6gik8qrB+yCij2tZs7RgZjTvpua2jyfH4w1QYdKDodBWXjba8oVReBgtEEIP6WU4uZJ+h2dLyp0rVYr4rSdP6epcjzij1RZKi5pX81aWnUvIBKC6CSeEqIDRv28QAX1aQy8WZV6kkSlNloMK0qFVzXc+KoQZ5QHrRmhF1kFBc9zkv0mr3oOjS89QOpWxbTBPe+Lk8rOVa5OOpRPxi4n4wZHVvvJXbheMZ7rzjB/TaSDP6cbZAkebXYpWLNpoHj+6pbqf7jE8VTjfYUSLPtQIpzdYsKe9gO7RPQ0FBewbKvxWV4WOiKLshKNub5ng7d2TIUItnhE40SYaK8cv7ZO1XTLpdU1lHdpV8gTFG5wFlJGnHAJevwEjHkBi+A6pfxyhaWmr8e8Af+ZSZgrV2KXM1FWxkBvTbMKjNupUuqEtvLg+bqBBUUqHU+6ppPozG1nTgr5z6pcqSDEIDse1RqwqCoF4q0F7inw1hBqAmBH4Kvf16HfhmCAPFKpmC4Z9opaTrVR90agrHSlapUAhQxYIQhZHV7cAovBUGukQmsB/7xVtCfkHzKUeqJYa X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS9PR01MB13950.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(1800799024)(366016)(52116014)(376014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GraazQWPplW5vfsM9ZcnMQfpo+bPPO+UI0KWpjjOhiPChhTGj2Wu/PPy7h/alNpHVjHTaj5rPkNBjPYgO223WVnTcpwtNugUjjW/hMqe7U/1+fq0f5+sP8yQJBJ3OivHyurPI1KwnrS+uOb7hqwegn0ssW7nyGtaXuKCZiebsnida2RWvY4AEAIKQPm7ESd+bbgiiZjoo2GDD6pujOAtKwBmvaT330kcMIT1p5TM1nCWNe/TdniJoSX1aMJu+5D+9G7e7tZdVDPRcTgmXD1ytLhQ17TfOUFLkaTjsDqgFxuyxA/hibXTmwkBe0sGaB42VF48JqZKXGbuqVJeNz2sBO6M/JlZRyr0uVO+lenL0OWlLk1ULiiD1Zbi530EfdD5v+zDLQwmColP8TpocY7koCT3ti9XEhO4ofCxs4ZD0a/LYvdCmLIv0W9ZtyZit8lmEoicXTOYCKapw3l0jf3++Hu23HsFP0D4oB/DN74kFmBrC1zPCr5TC22fZrmKJcUlcoV12JtbC5ADI9f2AVoyjQcd5ubMxV5a7VS3+F0l1Eewo62Iz6UmCGdfvN8oNeay0ei9y0o/CPsNSKgOtB4B7fmt2IrkE7y9gN3I3XWTZNUoiXmSdPtiZo0+IdWpaEdTa7Xm6iD1AfML6THPim9Emp/PpBbxGOpVivFEpOIqa160rkdTUuR/XgYl0IQnEU4xUAbQsuQ6+ZNXSZ5tlb8A1BvmBlmWCziBUDVUIcI0I/EUu9fubAfGlyOjQ3JLYBFX/T0AZlb89Clr44HMdkOcr8VkFDW6Mx30MnLgs3cLIxtqAW8DtQIuzo6CJfr6inDrDU4zRSv3P3XDDJKo3WtPWSL5+BPjb1uvycwSNISlJePFECt05ziaIjofWBn3InwlWWvInEu2dft0x1N2u1pFAkTBuTdddbwtDLjmZep/TLNnU90HVTPMXykaJWp9DXzUUa9ssSROI6Ch1PqWH6rBcX5Z7YoLOnl6rjPyGDGIAG/KtUYivB6TGupqUWt5ZIfqckoOd6C8zIp2/uEQbihJr1DgTgR5lDi5aV0fj/DxQP6QtVrScO0EglKEbgfWnCTlnyw55V+0ZUJIVWgCZbbGbQTGqRV4xH/+UWAMGokL9UZDD8P85Kx2ZnjOsf3Oun7Q/WgFIqrOsnqCxueD9WyrObKKRpcLvnNI9CkhMThA6u9MLw/iZmbYohXxJtUFmOFF3WiI0eC8CYdmajphuFLRVl/Rrm/pGeIzGPwJ+wO8AVetvYbMBJVYbRhk1CLipv/UaVx/UlPoLx+Yum+DMDGlu2dlfD0IRaqCOHHnYKkpOfBxoz/RtJscGhAAnOi1lYIbwbiNPH8+wadYJ1koaw1XDpQ6zzdRRH9xKwxkPtMGovLUz9ecv7bKurhyZBhkl4UUlJzETe/8JzC2nEdSDAXUXf1fqhWJKEmiTrEMRTPV2TSe2LCEH2qW6gObT40OKdyPlgXg825qsN85v2xbosDziBmo5y4WFc6/06qhXZzkLWzCgIQ3lcLLI8QMypf7oRg8e5hevOvVpSIsZyM4fEofadWxqOkHd/PFXny8Ouzym8NQLRIMDdxlSx/UvuiEYR3i3wPvu5YCqnRsTNYuNlVx7hzOtEH87nm9UC62WnQoANk= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: d123e49f-81c1-4439-0a89-08dd5679ddc0 X-MS-Exchange-CrossTenant-AuthSource: OS9PR01MB13950.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 15:25:56.9094 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hJxxMMkRLD4rI4cgEGH7yuVCdJB5/74lO4mmgj09ioYEgqS1Zc4nDeBF8pZsUpyg8KqkdrrVnIpFy4Ui0DI0tYsGIXr9kXEMLE0oC4d3vy7EiDsSNeT+X01fNIyP8BmJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB10248 From: Lad Prabhakar Use a local variable for the struct device pointers. This increases code readability with shortened lines. Reviewed-by: Laurent Pinchart Reviewed-by: Biju Das Signed-off-by: Lad Prabhakar Signed-off-by: Tommaso Merciai --- Changes since v1: - Fixed commit msg and commit body as suggested by LPinchart - Collected tags .../platform/renesas/rzg2l-cru/rzg2l-core.c | 29 ++++++++++--------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c index 89be584a4988..70fed0ce45ea 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c @@ -240,10 +240,11 @@ static int rzg2l_cru_media_init(struct rzg2l_cru_dev *cru) static int rzg2l_cru_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct rzg2l_cru_dev *cru; int irq, ret; - cru = devm_kzalloc(&pdev->dev, sizeof(*cru), GFP_KERNEL); + cru = devm_kzalloc(dev, sizeof(*cru), GFP_KERNEL); if (!cru) return -ENOMEM; @@ -251,32 +252,32 @@ static int rzg2l_cru_probe(struct platform_device *pdev) if (IS_ERR(cru->base)) return PTR_ERR(cru->base); - cru->presetn = devm_reset_control_get_shared(&pdev->dev, "presetn"); + cru->presetn = devm_reset_control_get_shared(dev, "presetn"); if (IS_ERR(cru->presetn)) - return dev_err_probe(&pdev->dev, PTR_ERR(cru->presetn), + return dev_err_probe(dev, PTR_ERR(cru->presetn), "Failed to get cpg presetn\n"); - cru->aresetn = devm_reset_control_get_exclusive(&pdev->dev, "aresetn"); + cru->aresetn = devm_reset_control_get_exclusive(dev, "aresetn"); if (IS_ERR(cru->aresetn)) - return dev_err_probe(&pdev->dev, PTR_ERR(cru->aresetn), + return dev_err_probe(dev, PTR_ERR(cru->aresetn), "Failed to get cpg aresetn\n"); - cru->vclk = devm_clk_get(&pdev->dev, "video"); + cru->vclk = devm_clk_get(dev, "video"); if (IS_ERR(cru->vclk)) - return dev_err_probe(&pdev->dev, PTR_ERR(cru->vclk), + return dev_err_probe(dev, PTR_ERR(cru->vclk), "Failed to get video clock\n"); - cru->dev = &pdev->dev; - cru->info = of_device_get_match_data(&pdev->dev); + cru->dev = dev; + cru->info = of_device_get_match_data(dev); irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; - ret = devm_request_irq(&pdev->dev, irq, rzg2l_cru_irq, 0, + ret = devm_request_irq(dev, irq, rzg2l_cru_irq, 0, KBUILD_MODNAME, cru); if (ret) - return dev_err_probe(&pdev->dev, ret, "failed to request irq\n"); + return dev_err_probe(dev, ret, "failed to request irq\n"); platform_set_drvdata(pdev, cru); @@ -285,8 +286,8 @@ static int rzg2l_cru_probe(struct platform_device *pdev) return ret; cru->num_buf = RZG2L_CRU_HW_BUFFER_DEFAULT; - pm_suspend_ignore_children(&pdev->dev, true); - pm_runtime_enable(&pdev->dev); + pm_suspend_ignore_children(dev, true); + pm_runtime_enable(dev); ret = rzg2l_cru_media_init(cru); if (ret) @@ -296,7 +297,7 @@ static int rzg2l_cru_probe(struct platform_device *pdev) error_dma_unregister: rzg2l_cru_dma_unregister(cru); - pm_runtime_disable(&pdev->dev); + pm_runtime_disable(dev); return ret; } From patchwork Wed Feb 26 15:23:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 868788 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11011048.outbound.protection.outlook.com [40.107.74.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B511E227EAC; Wed, 26 Feb 2025 15:26:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583576; cv=fail; b=TY5Mefo4iBnOrr78/81o+fTG50Kvg7q2neptGfsFI4goKs0VDMtafHaMbTS8WJK0a7B4Pm+AOV3u5gKj+p0JNpPtm5vLDrQJWH2bn8EnSlPhAplexAOmZak87VB2w+fUwdm6EMMR+xrnwh9MPC6WBsiDaC5XcHI8Js7xSlfxTdI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583576; c=relaxed/simple; bh=Wxv2NR4SPtkJtjm2fNJJtWbbSLqgBpIGMVvzd44aQhg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ahv8ZApQKKMvQaxV1G/CAeyRqTMmpXdBMjRJ51hXnb6yIUJ2wzAWfmEuorz41OZ4rsmVneA98RhEgCSysKQSdj9+BR4V3oImvrNLRZ/j/7MOD9I4aYU6Db65klJK0+ynCy/caTnku+7J2VzLHrRL8zsC40DnP4GsilTToc7tzmU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=FaY6kTb3; arc=fail smtp.client-ip=40.107.74.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="FaY6kTb3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o0n1Gne7gkMW2h7c7XuxuwQ0xtc7yhxhsGqQZZYtiFijs6rXcwY0zUbw0Z32TkyHRJYIsgUejXUz2YcRn8UQyoIImI6Hmi0veIKXORYKVaW11aTuMRvuyqkrOximI79eKkturZn9+Q9RJ17HlvFljzFUOwbOq2XhQBRZXWCKIDBtixO+Z/6SqduFM5Wk4IbEWTrh4JgkKOvnxJg3PsDPT0dg7ld9nIao653e2RNJ9d1ybEGjRTRigT1ShwFnYhbJXmdY4qgHUx6pz2EXP9J+ek6lWSWT9w/yn2gu7xP3hgNLvgc3hjHxdsAWfWlfme4L9/38+2Rob9nrxeZncsDM/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wAL8gQrgsvYymQ2b+dNwJ33LYhY2L+OhBRxp3zEx8Qo=; b=t4OGuX6eoQ9G0VUwufc17ESz2fH7Ziz+oq3Lh05mopvljmxWg5UZQ3xsgtU7ZpPFgiiNKyqp6dcGQWoKXFaCNTrSH75dAXiyd/KEmnawn3vPCkCoj6O0qy2JYRnH5c245R6KeOwKuSe74thZBvOxvJHi73EFJjgaeMY5lNd8J9HdD9rD1/7IYF/fguxVOCeNBsXt20gU+kAFDLDrwVrZ4dvR5sL1ubjV87AUkq545DeAdYcLi5xX6pfj3hUIstK4rtCSGzCtpUXicv3zPAb+AzQe3Z7PDAkKgFBjLtNcVr0JAOl/ww5xcEI9+pCoPtx69a/+4FuUEO1w/P7DcPdlzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wAL8gQrgsvYymQ2b+dNwJ33LYhY2L+OhBRxp3zEx8Qo=; b=FaY6kTb3un6DOJwN5uiCmt4ASP3lfTrgI4SdxdOUmIC/2VYGyPW1+uMkvJfFPDxZBXq2JrTrcT63btwuQz/oYmH6U3XQulFP4jW/8ftr83ELA9UY2haEKly4t9g1BvGgteYNsdvcM5r+kP2Icq/xqFZOjZCPQoQM26X5IKiKb1U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) by OS3PR01MB10248.jpnprd01.prod.outlook.com (2603:1096:604:1e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.22; Wed, 26 Feb 2025 15:26:12 +0000 Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3]) by OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3%5]) with mapi id 15.20.8489.018; Wed, 26 Feb 2025 15:26:12 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Laurent Pinchart , Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 08/17] media: rzg2l-cru: csi2: Introduce SoC-specific D-PHY handling Date: Wed, 26 Feb 2025 16:23:32 +0100 Message-ID: <20250226152418.1132337-9-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> References: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> X-ClientProxiedBy: FR4P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ce::13) To OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9PR01MB13950:EE_|OS3PR01MB10248:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b8ea24f-0c55-4cbf-c38b-08dd5679e72a X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: TVrLlN5lj9yBgXTNiTVIxjTPzEPmGNENdmEWNUjBCndyzOKfhQ1MdazG4xwxf93zGFJrhg4ExNop42ZS+4pla7LVODxn0rQqWYwfivhtahnuc8Uur73DaIRuSM4u+I4HjgU6SouuXNW9JHMnANxrtcTG9LwIGuMORX/2jfNj6OX58r0jgSfHkl375G3Yq5De5KZWYdccif0BDprNpDWD9c6EecDiHt7eIUzNJ1TUR9y3ofgZRDYE8BK5iXWELmOIH/nBO86ggLhfVaxpS/6+AGQsUrdSHJarW1ENHiCrGy0l8ajOwIhklyIRv4RB2tzmuS4P08CKHpVk90+tR8DGecjiA3kdlTbGFcniobmu8y7fF/LAYWutdpiyOexIaS7/rUs7iMX7rDo0np/tY2RL+PWzQ8a7ljwrPUsH2Ps8toDVWCeLyP8O8xIKWaa0zWEwBF/RvBR2PfqKmT3NAELJ1tR3oQ3ldv2ZqV63Vqt2pCudti+hjncTbK7SKHCtWvg5TR7V3vaa/42f2BV+0ICeInnT/1uQjK5Isda8UchTOmGoRmXKa6udg8NNtEyS57FBe83xXQczNUWcrwQDYHDUT6Fd3CLt5/Cax9xAXftPuQYXuR8Frb4yeLQnPJiH8zf0TkoUEcLynxwCf0O5dLGpocZ5osVOMvi5ImNMeSuYPhMNN7gUwWXiOeU7cSbPm2uqI7VEZ88t3HwthxmKnvIBT3J0DZTRRCXCgmkVerT9bB4ohDCmALPSkPeubTT7APt1cKzcrjwtrFcPzbUeMfdKp1HlUdTfLWPOWbs2zJjo/FR2xdEntMNUfTITpLBRjyHXooQBzVlEut9IVH5he+RLaFt83+xCRdWRC9nZwgG50Yh2uoUe5mtxW5arJX8IaH2g2cleJYA/slfx+uo0JiQrZFUVcSqiaLMlfWY/pylrzjAOnvy0jbql5vTq6bupvmX0qVxq8GLGzvxwxyCzkpCa5d5s4Ff0gCGV4nKyDdpgrypR/Wb6GfRaGqPVX+xdTfgLC56BviFl/JREPScM4X4nETJ3POboG9crq3SwW7ThGW5LD3rjVSc39z3B0f65S5vlnzIstmm347d56a4z0ttm2jwnyWHXrjRkLC65T1mRPYvqs0i5HxjzKIyZuJWUJoqKns3VV4fu6adnuOOqRVbnvbzYKcuw5KVAD8riSZj4G4g5Xr53faMOTNqkPDffMY5NgHjEzq8420ijo2HAoSjMi5kHU1Tn624ID6u3wV2OYDPjusB7EDFEnEJT45n2rGE9Q6gzgfyH1QzYrMwANeneNBiwRAnFr+5POcLw+Z3LEwPAqKgYQ7sL2pj9x/iL6P386Y5j6zW2+Wgpiow4mz3PuUxH3QmPXJM3qxrdZqjYovKQM7/IvtgdM9KfM378e5kOUJ+X9AK6gFOMW4MymGdA27CA7pM4GxUoNPydIEyD0qqU1RXGkxWIsWkmBk/21aWw X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS9PR01MB13950.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(1800799024)(366016)(52116014)(376014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: BtEx7DjTb9cRC4FM3Av+K/nO5cK2yoRgD+rXDPJ07suGic4erij38kktqEyWdhrPhhy6J8il264kkrbtg03lE+lwhp5qO0dwOErW4edbjaWqd+B0QIhFxoQ9lQTysFvauzlRyX2MoY1Atly0hGvNYtHVBJ4cV/UFmnVsr2+v7o1o04lNAUvNaGfaHUJ4sGtsw32HZPJKwsH+6OWAMDP98S6KEjQ79/Qf0DhsCstJ+D33p5e8WQ0jctzdGz4Is9Z4tSTukXBhAuW6v0Mt1rBbXR8wyZk4hcRN+a7WalkykLlI7SYQbS2QrSnp4oVtKB25oKlbk4CTxXmtZ+tCmGYCZqA42y8DKxFZFV2ypDS+ggHCHZ3cCUt3FThE8ZPg9zdc+4m3c7bVDgQ+qySabiA0im14dRIFDFfhfO5Q3Y6tmhAYPwDyjuOHpTXTIBrXyDBfZV8blCuqASLy9hE9xwCx1SLk9zjYA5JabfGlkd9b+u4WwSCK4XeQPI2SoqF5etqLcgSuSRSq+J6ak9UFBatOye47UmuW2MXY/oyNCOXjdLB3II4x/VtrU6C879VyYwUsuBWhhjRTcBWU9RsNuqp9Bj7gD/pTufFiytLz2vcJ8Y1168oxadgSgzNBzkKuiSC3K6QfRkZNVM/C7BaE8oAm7oPBHKdIg1uFctpx9GXZmFeFcjuVBrbudhYQpZGiNBTkSZtCzlHfKVxq6TUkUxHcTZY8KkxDgvJ5PyT2wodQpt5YZDLe1myy3Oi7mOHH2io6zvA6RR8xtwg/+vNLUy4TltF4uc0GaCo/iRPCRGWQTAVlNRGhn4BL+I1Am5OdV/g1ho0ZHFGQEnWHlHzveAT3aN5a4tKwJJYmvcG9n11TMpBurOLUz+K6NT/8/2qNbp5UxkMy4mIItm++MJopWVDqF/n1hZa+RBuC1AcnKrj83pwCQ2den/9Hq6jWdMMOb6+j6nTkrSZ88tNbj/51KoRtzXTFv/75dLvV7wtG7JaXHQ4cgIfc7oqcYyWmDbag0j7n3TMKCh7NbPbFRX5h2TSPiokmSVO0obJ2dEFoPH4roI8+WCN/vRitugNmg33BXvTF1pnHSXcBrHLystQHCZHhKiIuLqLezm/xAwrrSXIGuqeg6i6eiz6bv+LQWz5iv/co6aiP+DbNVQt8RlayA+Hx6QmPHg765tS0QWU/IcCfwJqwSCDxrmikdGguWSzOUlAynFQhG//uVkvK7NRXDAHkDqSv/AD5+DeBRz5cekknmX8Qx5XNs6erlCuLJGfE/UItGABSK241oKcGJc0Bia7WPf2yBFsmi1vktFEA7+/4lPde9nli7CdKaFoI80uPRD73B9lV++wfGvDmBokEuufAHWvTwxKM3UDVTyES1JcKUaCgY8YQxZ27s7Mfn7F4wclwGEU8BBxurYFYrpOIRCOrRd1alY5FmvcfjskW4399M1lPELy9kzmQwoULF81t0LA0UEYtqyWwJfJ7EBPqBNGj7Ig4iLCnxr/3eR1MwZXRfkePiVjWStPpywu7dvMDJdVVpLaPSx5uqeG7cEto62ThM7tES3+ttq7OpYTMUu5xeO/3leFM4fNPfdYOFTgB3S80wlPI2vEeGGBuc0flynIQ7pV/Z63JCdQ+5GOEOl/+M7U= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b8ea24f-0c55-4cbf-c38b-08dd5679e72a X-MS-Exchange-CrossTenant-AuthSource: OS9PR01MB13950.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 15:26:12.6757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RRiq+4YERGMwiqKIqrNYobkj3frjbQpJDpzrbutSgxl+ANG3pOX2bQQrWnDFnP/zGZqBBVr3OJCutQexbeMCrTxAMPuJXZykOZ5ypToBtswRwLShv0mee0TZ9msVVqI5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB10248 From: Lad Prabhakar In preparation for adding support for the RZ/V2H(P) SoC, where the D-PHY differs from the existing RZ/G2L implementation, introduce a new rzg2l_csi2_info structure. This structure provides function pointers for SoC-specific D-PHY enable and disable operations. Modify rzg2l_csi2_dphy_setting() to use these function pointers instead of calling rzg2l_csi2_dphy_enable() and rzg2l_csi2_dphy_disable() directly. Update the device match table to store the appropriate function pointers for each compatible SoC. This change prepares the driver for future extensions without affecting the current functionality for RZ/G2L. Reviewed-by: Laurent Pinchart Signed-off-by: Lad Prabhakar Signed-off-by: Tommaso Merciai --- Changes since v2: - Moved rzg2l_csi2_info below the definition of the rzg2l_csi2_dphy_enable() function as suggested by LPinchart - Collected tags .../platform/renesas/rzg2l-cru/rzg2l-csi2.c | 24 ++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c index 4ccf7c5ea58b..4aa5d58dde5b 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c @@ -107,6 +107,7 @@ struct rzg2l_csi2 { void __iomem *base; struct reset_control *presetn; struct reset_control *cmn_rstb; + const struct rzg2l_csi2_info *info; struct clk *sysclk; struct clk *vclk; unsigned long vclk_rate; @@ -123,6 +124,11 @@ struct rzg2l_csi2 { bool dphy_enabled; }; +struct rzg2l_csi2_info { + int (*dphy_enable)(struct rzg2l_csi2 *csi2); + int (*dphy_disable)(struct rzg2l_csi2 *csi2); +}; + struct rzg2l_csi2_timings { u32 t_init; u32 tclk_miss; @@ -355,14 +361,19 @@ static int rzg2l_csi2_dphy_enable(struct rzg2l_csi2 *csi2) return ret; } +static const struct rzg2l_csi2_info rzg2l_csi2_info = { + .dphy_enable = rzg2l_csi2_dphy_enable, + .dphy_disable = rzg2l_csi2_dphy_disable, +}; + static int rzg2l_csi2_dphy_setting(struct v4l2_subdev *sd, bool on) { struct rzg2l_csi2 *csi2 = sd_to_csi2(sd); if (on) - return rzg2l_csi2_dphy_enable(csi2); + return csi2->info->dphy_enable(csi2); - return rzg2l_csi2_dphy_disable(csi2); + return csi2->info->dphy_disable(csi2); } static int rzg2l_csi2_mipi_link_enable(struct rzg2l_csi2 *csi2) @@ -772,6 +783,10 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) if (!csi2) return -ENOMEM; + csi2->info = of_device_get_match_data(dev); + if (!csi2->info) + return dev_err_probe(dev, -EINVAL, "Failed to get OF match data\n"); + csi2->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(csi2->base)) return PTR_ERR(csi2->base); @@ -891,7 +906,10 @@ static const struct dev_pm_ops rzg2l_csi2_pm_ops = { }; static const struct of_device_id rzg2l_csi2_of_table[] = { - { .compatible = "renesas,rzg2l-csi2", }, + { + .compatible = "renesas,rzg2l-csi2", + .data = &rzg2l_csi2_info, + }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, rzg2l_csi2_of_table); From patchwork Wed Feb 26 15:23:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 868787 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11011018.outbound.protection.outlook.com [40.107.74.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A014A22157E; Wed, 26 Feb 2025 15:26:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.18 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583592; cv=fail; b=mNTF3rucmRcoZbzicE8XBzFkEHXN0vbjHgQDxx5ecRefjLrLLveLimVzzga489j9y5uTjARCrJ3TrvVA+/Y1XtMgCpKUBrmA0FSkXYT6mDQIZfvxTiv/+mmHb2JxS3lxZDiA5Z+hbtrYkRBC35CC9LG4Jxo0aJFvxiDt0D0PCs8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583592; c=relaxed/simple; bh=s0LbwMd+yNOrDuaI69BkfWNoj6IZMmF36hfugARTaZw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=BwEC6qI1e2yXiPd83zBxbO7LltTXJU94gRJ4vgKTRZHSWcMGBr8cXEiDpq6kqxM16KtsokzpZpAuoU49+Uak9wCiSv/taUyW2YAgT8AqjQ7s8IwGL8OGOuvYBrF0/7kuCcOiSpgBvxsx7CtNZtqswnfK9Yif2tYFTVO1goyXWRE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=cxagoxV9; arc=fail smtp.client-ip=40.107.74.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="cxagoxV9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hnzq6pBDSlMxZKBDtOdKqJ4m7Ww9DHSKGB5tFuD7MIYz3ezk6XKLcmisKk3/FRRpQ2aPdxWWcwjeFwrk1myv2OG5lUtQ8YbwEqQY2lJV5JHLRdlzHJBcm+eX0X18gvSU+eLrDNS+zg9sgPn/dxLFeoJCZxSP60A2yf85CL1dDuFcGLiZ+qGD1NlNlqWsGaCSoS7KISQAaf1wFsdqw6mnZscJ7zJacW7bMTMBU+22AV9J+qZBaQwLVzcFcekgZzr4EUVtfKq359EPq4T3TIvjxQOPhffqIO6tJ1E17oh+kFjkahW0nD+US6/DfHGjNlReAFzt3GoNqNKEa8ULln0W/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hlfJa5bXaEV/JpIyOlesXVZosJEKUGMLaFI88fiQ4fw=; b=rkTb58u5UxZpfgTl5Vv8tk6VT6Wc1mfI7y3O3db24FfoXcdBw0anQKN+N834AKO08jK06Xuc6xamRznZiElkCwIHMpGigacEOHXqeSouJ7jG9DPZRMIqdExS5V3gDp+rZgPg58pyO9y0uIPGdw+6ebKl8ujRiD2fxTo0LxWxhvP6QUCKh1GSy1SkrPCiOmb2N0bEMn67CRKqdYICZ8LiPzFp8QDDjI3ZCq7Ue2UZeA91T8rLSmg0s92QxiAF0f8hWRfB8y/L2Ri2FwqDNBqvc6pxwXRzyHwQbfaBgA2GxGe60yOWBgiJvbvha7wBOel0uxdaGnHzEpIbulXz/WPGkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hlfJa5bXaEV/JpIyOlesXVZosJEKUGMLaFI88fiQ4fw=; b=cxagoxV98jfWT7yE6z1OztgPFCPd+OnE/s5H0QuEdM3HvQ5Pv+BGn2Jxe/mKGafIgZ3AyJrHvuhso2CEpNjNoupjGkATsHIq/eqSK6rI3JuOUDH0cS4WCdrzjPU7Jy/fcoAn2IIVJdLs8QfEjzB6cC0eKW8sniWJxmxA+N8/UOo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) by OS3PR01MB10248.jpnprd01.prod.outlook.com (2603:1096:604:1e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.22; Wed, 26 Feb 2025 15:26:28 +0000 Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3]) by OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3%5]) with mapi id 15.20.8489.018; Wed, 26 Feb 2025 15:26:28 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Laurent Pinchart , Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Geert Uytterhoeven , Magnus Damm , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 10/17] media: rzg2l-cru: csi2: Add support for RZ/V2H(P) SoC Date: Wed, 26 Feb 2025 16:23:34 +0100 Message-ID: <20250226152418.1132337-11-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> References: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> X-ClientProxiedBy: FR4P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ce::13) To OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9PR01MB13950:EE_|OS3PR01MB10248:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e904416-9cd9-4b93-2b0c-08dd5679f09d X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: 28HxLzqac9GKwDrnXxIA3DMddAuuPiW+t+DL/bCSeQuJIh0+YKQtwjGw0hZX0NzEIKw/ul7fh7UZ9Jk1/zIalP5Ih5wMrDQGgiQx7sYrrE7rRjDKE3vjQF3E8VqowV9rb3Wit3IvKeGZzHPI+/GSDujxWeYZZLDY/mDNMKoBH9shGP2HL/h8dO/msnhrwBBpQ7g8NCbhAjJd0FgH3MNNZjEIONXSLMXFFRIgVjjfik80WPRjBsbl4KAZhMJcFoHYXNnBz8oV5gTPLPLCgkcL0Qgcbj35LUwcFWFdaThSvPRLthF0wTLdED4MIi3CVhrTs/MGAleT8Wb/Gmpa3ffeS/YRnwbpHpVo+fBK97ww4Kk1hK5D0zxy3Y6vZgzLSZZAICZqvRE92QSUoFjOyV3p8gEMgjr01lk+Lwm8jJNVHIwGymC4rBISlToOP17DJ+iQ1RUNIkrfhEl5W6FqzHy9sTI7mplyfkz/IyMKm3fL/D/2GG4DKRqCOffomYd8rVV5rm0tEneW4zPMDaEdDS4qd+Nqw5x03YQo1AMjRTMWlw9cL4MBMjw6bLm+qFG/e4kH/3Tg7g1tu8jJzjaIuyjpLcUs4mmWWubC2I1pQtBR785If0ou3pICFNN6HT0OOc0MUKdAU2x+8dsX3Lt/bEZopiKGtwnGVGhM3Tmez25RhwKZYKMFqckuOXR3rFMUxz27sVGosZBd7nsI7BhJpdfdfoj4bO/slgufPYTR2koYOYLdJNO+4Kqv0QPrFi9tnSfqUeo0QKsO2v1+2P2QtU0nZ5qkmqKix7IEnUIjL5QahMuQzBC9ihdNVibDBtM1tsMvGuJd8nnbSECWPguMCO8E/uFUBqDurv3Kg6mDCJaognV+/h/pGsOAwuEQSHwJSL0Mxnus5e5PuziwUHlA5bfeeIpnBgGXg07xAWJANYaG08p7ckSxENX96FxzcoJAQgOtmjeGQsnuZKL5FohTtIAz5vkXE4vDLVagQFUrQbbc9+D3V5NoqRdm57YHQ94Sar6/u1QF4svAxifq5NAIb4IbedLaTq5ZL5/56wQELoqFyAfZsDicIvDGoe5Puheb71ZNkgSaJi8NdnLEVNG4+13ZwoQmcllHFwrJg2nTMdq0eye0IbzeyscIRStdyJpix/V61c+KE0DGlVGAawCpH8LBNZ4iS8Qa87lnZxIBBHhhbEezv7Y2UERY8C3MUrd9xuWkzgwe/MdQPhuqR92HAurBHJklHHPiPMyIDH0NiNTZcg0re32+5+4VfTXlfbkQbsw/UbrF5lU2FoVnc+JuBooK8eGJ6YF0EogR23fbFKILXdcZhRnvvO52LY6holIfsxXR2lTo68TIpx0+lw1V0Ya4DqGCUYhmXMNfXfwZRdZb3TNbvuNNDIpJPz9JNkEb4hppRuVjL8swOMhJLIN6GTIneQSS7sMFim5zJF11SlmGmPjRo8bhEPLOrdM/uNqM4h3E X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS9PR01MB13950.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(1800799024)(366016)(52116014)(376014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lRt/p3u9wd1W+vWPOy9/7LGaL6erjv1Ii597oZ04Av/2TqFNjXSqPdtCXvI47achFzkziM4zETIKcX0ZezpHotmnqZ5IUKSgXDg6YXj+Gq1Tda0Y4O6Y13u4p5oucIOAraCv26+Lr0o7qbpMHqp/6iZTKVPUtzP5ebbP5q+olLrkQM6j/r8nkJS/0sn8sk1tMwpIrGHA/odEk4UyrzGSaOVKvg/f/OwWjOtzuREFau8pxEDnyTl1AhBeWQIzDyC0BdWvCUadT53VzDpM/n0FAdHIVELzxmQa8vQ3ahrELG62sFK7u+Ow+LVsvys1lvyb2Gch7bsI9WI5KQBhp4mZeHOoP6FafevABvLEakP4orTTeUlJ5xKHmXpfJKn1eeutfED6207tQ1xVcOL3Rk0GoIsCJ+GuJ0GlI8kH5TomhswGybd9yrR3D5+8Bm/zOAeEdSKi71KkaWCGDn459ghDRpHQJ6TT6CJ2PGI2u5ZPZZd5gEyuMnC+c7LCM/GTZUvIBlNC8x0TfBFVn+j19l6dZGxiUTppiFzU5vrhFYyEqUHR+rOsZXbuyuhS3ir8/oO28OvaSeExbdS9gycvLP8Ao2nl3pTtRhS149RlotbRr4kQtw/CfFYICy6s7gsly5HE5brWs71ZggO7Vqf1TGwF3uhwtsO98j8M+jRmhBpTNUUpdosb+NqU2MVnurV/4sPd4QLCDRzAREGH61zk5BCneL9ub8Xv/7WMlth58AYFrA/VXxB3BWZzKqrYvs9yfmDVZNbB+CdN+nkRNg/bQSjS97PyEu9Hc+rBH1PJagfEu8l5uE7OJDI5qGDlwlRix1uenxJf9pFdvfEFvGMh78jX1ZMMvNV6owMJhfcmEif5Y+FPdXm2zNmDqzPv9/H3geKrmke7D0IIBtdFXPE/SROjzK/mzf7y4rdCqJTxLPTe6s6ZQlJX8luzupdPsfr1VnhSYUqeQWcvjZHF/98Bu5LCbGpWkoZCSSCbjtK3Po0r6JVgIR5vh/XSrJRkXnTMo1ZZp1uVyCDPw2dXDxa3j3LvmZlPw+R2umfnZxcyFWQUEjYVflaQqm9MGrgqvsI87VcQ3v2xdteHcbekrdkXXLmshAwfBWCT3gys6wT8CA3rsh53dR6NdRybLdUSWviTK0cYMvIc3ApAlGZ9I6u05AHfq50CCKPry83qYGibdVtbVRrwyV6unqPB1FL8IKe3TY46x56x/GMr2Jxgc5yzPWcCpdQUlARaHVxK8G7DJS+iJMX81Q1Ph+WmrCHLL6ynvPiwPVVvHWP7WA35i1yHD98HqEUCDWRFUrL3wo5czDnibvOL5Wc6O+crC4FjAi/rLadVBSeCeMYMDKLP/DCTKggKaCyJlCdgCpyGYZp1ugK47FMUXI/lv6PnRYhSJoIoMwtI6EaBmHU5QOKo2sZUI12UBG8nIoUG6wNs9T7qFIGTaW2KHB7yKmNFz9ZJcZANFBdXvEXzljyJ6NB3KHWZ1jngoNyGLVO+gSuS96u6ToLZtqpmPX3e4BEIhBkIkN6osVfc3/I4nnwno544FKjvoseIatNCCmVvu//lIi/SKhFtJZu4llXEQkTA7QUsW6sH1AhVvgK3XVcMPrDvMVQrHnmE5CBjSLFbkisDwvoIu2kR36I= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e904416-9cd9-4b93-2b0c-08dd5679f09d X-MS-Exchange-CrossTenant-AuthSource: OS9PR01MB13950.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 15:26:28.7613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V3GgfXbKeQYDtzSu3ZAhAEoORNAv4+Bkwe8nZatHD3YmTmasnCZQW5BIz6w3+guFwAQO1MkGvIwErNBf7N/nclPL6TjUzQPGXMIWfmks+i/LdcMBgScT0Es99EqFoKvP X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB10248 From: Lad Prabhakar The D-PHY on the RZ/V2H(P) SoC is different from the D-PHY on the RZ/G2L SoC. To handle this difference, function pointers for D-PHY enable/disable have been added, and the `struct rzg2l_csi2_info` pointer is passed as OF data. Reviewed-by: Laurent Pinchart Signed-off-by: Lad Prabhakar Signed-off-by: Tommaso Merciai --- Changes since v2: - Moved CRUm_SWAPCTL write of rzv2h_csi2_dphy_enable function under the error check as suggested by LPinchart. - Moved rzv2h_csi2_info after rzv2h_csi2_dphy_enable() as suggested by LPinchart - Collected tag. .../platform/renesas/rzg2l-cru/rzg2l-csi2.c | 95 +++++++++++++++++++ 1 file changed, 95 insertions(+) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c index e4781105eadc..9243306e2aa9 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c @@ -85,6 +85,15 @@ CSIDPHYSKW0_UTIL_DL2_SKW_ADJ(1) | \ CSIDPHYSKW0_UTIL_DL3_SKW_ADJ(1)) +/* DPHY registers on RZ/V2H(P) SoC */ +#define CRUm_S_TIMCTL 0x41c +#define CRUm_S_TIMCTL_S_HSSETTLECTL(x) ((x) << 8) + +#define CRUm_S_DPHYCTL_MSB 0x434 +#define CRUm_S_DPHYCTL_MSB_DESKEW BIT(1) + +#define CRUm_SWAPCTL 0x438 + #define VSRSTS_RETRIES 20 #define RZG2L_CSI2_MIN_WIDTH 320 @@ -140,6 +149,30 @@ struct rzg2l_csi2_timings { u32 max_hsfreq; }; +struct rzv2h_csi2_s_hssettlectl { + unsigned int hsfreq; + u16 s_hssettlectl; +}; + +static const struct rzv2h_csi2_s_hssettlectl rzv2h_s_hssettlectl[] = { + { 90, 1 }, { 130, 2 }, { 180, 3 }, + { 220, 4 }, { 270, 5 }, { 310, 6 }, + { 360, 7 }, { 400, 8 }, { 450, 9 }, + { 490, 10 }, { 540, 11 }, { 580, 12 }, + { 630, 13 }, { 670, 14 }, { 720, 15 }, + { 760, 16 }, { 810, 17 }, { 850, 18 }, + { 900, 19 }, { 940, 20 }, { 990, 21 }, + { 1030, 22 }, { 1080, 23 }, { 1120, 24 }, + { 1170, 25 }, { 1220, 26 }, { 1260, 27 }, + { 1310, 28 }, { 1350, 29 }, { 1400, 30 }, + { 1440, 31 }, { 1490, 32 }, { 1530, 33 }, + { 1580, 34 }, { 1620, 35 }, { 1670, 36 }, + { 1710, 37 }, { 1760, 38 }, { 1800, 39 }, + { 1850, 40 }, { 1890, 41 }, { 1940, 42 }, + { 1980, 43 }, { 2030, 44 }, { 2070, 45 }, + { 2100, 46 }, +}; + static const struct rzg2l_csi2_timings rzg2l_csi2_global_timings[] = { { .max_hsfreq = 80, @@ -434,6 +467,64 @@ static int rzg2l_csi2_mipi_link_disable(struct rzg2l_csi2 *csi2) return 0; } +static int rzv2h_csi2_dphy_disable(struct rzg2l_csi2 *csi2) +{ + int ret; + + /* Reset the CRU (D-PHY) */ + ret = reset_control_assert(csi2->cmn_rstb); + if (ret) + return ret; + + csi2->dphy_enabled = false; + + return 0; +} + +static int rzv2h_csi2_dphy_enable(struct rzg2l_csi2 *csi2) +{ + unsigned int i; + u16 hssettle; + int mbps; + + mbps = rzg2l_csi2_calc_mbps(csi2); + if (mbps < 0) + return mbps; + + csi2->hsfreq = mbps; + + for (i = 0; i < ARRAY_SIZE(rzv2h_s_hssettlectl); i++) { + if (csi2->hsfreq <= rzv2h_s_hssettlectl[i].hsfreq) + break; + } + + if (i == ARRAY_SIZE(rzv2h_s_hssettlectl)) + return -EINVAL; + + rzg2l_csi2_write(csi2, CRUm_SWAPCTL, 0); + + hssettle = rzv2h_s_hssettlectl[i].s_hssettlectl; + rzg2l_csi2_write(csi2, CRUm_S_TIMCTL, + CRUm_S_TIMCTL_S_HSSETTLECTL(hssettle)); + + if (csi2->hsfreq > 1500) + rzg2l_csi2_set(csi2, CRUm_S_DPHYCTL_MSB, + CRUm_S_DPHYCTL_MSB_DESKEW); + else + rzg2l_csi2_clr(csi2, CRUm_S_DPHYCTL_MSB, + CRUm_S_DPHYCTL_MSB_DESKEW); + + csi2->dphy_enabled = true; + + return 0; +} + +static const struct rzg2l_csi2_info rzv2h_csi2_info = { + .dphy_enable = rzv2h_csi2_dphy_enable, + .dphy_disable = rzv2h_csi2_dphy_disable, + .has_system_clk = false, +}; + static int rzg2l_csi2_mipi_link_setting(struct v4l2_subdev *sd, bool on) { struct rzg2l_csi2 *csi2 = sd_to_csi2(sd); @@ -910,6 +1001,10 @@ static const struct dev_pm_ops rzg2l_csi2_pm_ops = { }; static const struct of_device_id rzg2l_csi2_of_table[] = { + { + .compatible = "renesas,r9a09g057-csi2", + .data = &rzv2h_csi2_info, + }, { .compatible = "renesas,rzg2l-csi2", .data = &rzg2l_csi2_info, From patchwork Wed Feb 26 15:23:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 868786 Received: from OS0P286CU010.outbound.protection.outlook.com (mail-japanwestazon11011018.outbound.protection.outlook.com [40.107.74.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF0FA22A4C5; Wed, 26 Feb 2025 15:26:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.74.18 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583615; cv=fail; b=g/+JfUhrv04y0TEySMeOcQic/NZ+PcugRD4vU0wzdAo0qrO2geEuL5ak6J2pqJlOqBfWeG0Wi4bOjRaMnnG5EaKR0mpbQd5xxw0qcCbEqXkTt6MtYxgQC5X/BUbhVEG4Fvf6Q+ulJRc9S9tsopGLA0Xh8XQQHftJ9VbINVqxiG0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583615; c=relaxed/simple; bh=R7e8sBeHKiF4O4mbOmtYo6FhJ/lbF58edsaRTia8At4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ttM98ToxxvzqtWfM9OhkLe72rhGra/1VOnlDJcSRLvNI1n+uCZ2RdxjbJrEblQ9pRjX7I6EBgmEzgt/+st2tyaVPYmvciBIcAr4c1jWmA1bq1qQwL8jp7YoEsxvj7rDJmJznEb7jDfpGyXKkeLoA1UzLTfGXLvuPGWnh4aLxDKs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=DbSdvn2G; arc=fail smtp.client-ip=40.107.74.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="DbSdvn2G" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Sp4hQHbG3M4LSDFR6lYmAPksXwjL1VH/SKg4uC64bChOJMGRlacE9kKOdarzkKigaZ9wOCFfjIdoIiKkJrxgkeejLtMQIk+4FWO/fWgZKXTFrqL4zZWpoQf0i2leBiCIEPIeJrGv6Yc/lZV7CqqMQZgckn08RhHxGO0LOAjWvYyQ1fzFrzlfQSgIL38l6/IMh7PNKyTvyoiws8p6K+IqiPlJ8x6M0XBmBRd+uky1pVy6YY9xZjO2k0zrBPLwU7OIgs85vXgQiHx2QZAndPaH3T1UcErBhBQ0ZXQT54F07jLXKCF2iKn8Iv6cz+OHIXQQea7cxvMWM/nelVTUgZPqFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=15/v3wlFz+7cQaYOHIKZDPeGhO6EtfNUagjuSLzJYj4=; b=HxzvNYglFBTPRjkqX91zNqX9f4sttOXtS7gQdFMvWXX0ot01SaoZsxOzrDH5fYDdJxmy/1AwAM9+zGwEfu9TW3VPA/0ldKHzOiKc1Kub2MP+rgs8eZ5PMmLR4jqpvJNedkPnzFN+XhdVaTfdrhuHn3GsfLqKulCo3EyxuM0X8bEAko5Xh2wZdpj0HQDYFH6dLQZMahs33+z8f5nh/vx5Xbr+Uh4Q+zakdK7GNJrYM3qajXR7U0VHm4A0N3FiUJUrD4bf0vLackkn2o9+SEZLB+fCZzwltgvBR8/ogMr4eYsQLwUqR4L587DtLqIsxZxsRBF2by+hqidBDgt2hPV+DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=15/v3wlFz+7cQaYOHIKZDPeGhO6EtfNUagjuSLzJYj4=; b=DbSdvn2GYddPAJxKIqhNHylepnf6lUxEJs8oKqil7s6OgdPZvghdoluyUc1nArrq4qxVY0MhSX8d8oW6taI3k4WpwspiWTGm2bigEOhzoemJAydoNMYk3v04spjG06EdqzFpIA0eDyaVZOvyJjJq1VIaImrOIvI3Z/WQN4ExXHA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) by OS3PR01MB10248.jpnprd01.prod.outlook.com (2603:1096:604:1e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.22; Wed, 26 Feb 2025 15:26:51 +0000 Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3]) by OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3%5]) with mapi id 15.20.8489.018; Wed, 26 Feb 2025 15:26:51 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Laurent Pinchart , Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 12/17] media: rzg2l-cru: Pass resolution limits via OF data Date: Wed, 26 Feb 2025 16:23:36 +0100 Message-ID: <20250226152418.1132337-13-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> References: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> X-ClientProxiedBy: FR4P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ce::13) To OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9PR01MB13950:EE_|OS3PR01MB10248:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b85e8ab-4fb7-45ff-e506-08dd5679fe3b X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: 3R3pJp9hlaW78YaATaA8lvMGvwzF61MRmUtDwx4A0hsVYjN14uSAF1Q08quJLKohbO1JdUzYPd3ZXgrj3K/T+t1WdXT2O9gQG94cCzep/iRj2tVoekkdGFQonh5OkjV0umZSr6znHLjqisK2/4iFgYMJ1AUxeF8F6Qu5aIIlziFli4imyran9Ot0Dhtt6TQdtiL47aHK1LJedB0HqSSQxCb5XT565uz4lG6AjC1WKon6nGAEuCs3VgcpBQ7wzffAFC+hv0WK9k1b0BhceFYl3vGIand+0GHbeb2cDWpIxtXwyP4E1fbU3kQezgTqEXZ5I8mjNufCRP7LeBdGevKfnp/qdDhaqAKmDOmeaOFxMkV8XyMJx4RuysPEm/k8F0pDHRZQH1bz+PIO+RxCmbtiZDn7nlqdm/mRGHlFMaRS4YhzYw5RvHqJgHIVy4XQGgi+OFJoIvYE/fCja35z7t3Hyb87pQ9t8q+xO9F3TV8Jas5gzxGqe6ir17dNnbIOHRQ6ekfUod/1nmGkO5rEZVf4Rvg6aN8tjQhPE8gzk2n5VeQ0nOUZFgAX/F4nVR80/dAJbN86W/sb79Bw4RDUtUdkwZXWazkvdRv1IwdON/VtuDr5A7HFKZOCLUNiGLVj+wKJ/Ul9tlry0RbLeyhEHzOccYriegsOwPn3d4tW210KtDEQIZZaJZuAwrXhjFvMmodDlEJ46KV82LOC7wQPy3tiZYvpP1+ZwZtbGCZY5EugNDyZ2nwWnipFKRDgtiaIVCZMLY3HzsEisSQkDiOTVLUTjxYhy+Ow5o6hREzfC3egexS+TIkBPZfNYyfqnT1vL+nLW0aCd1UAcv+oXeoYpiilmUsBVBJab5zm7pbmavYHA9nqKI7ng/rItDnaQaEVIIjvqBzQwHp8DZfH6Xt4PfqZKuU8L0Flu1h3LZzkJOxP5wgxNC6A2h34i6ArEVXy6kC/gbHi2hl7w8qTx/6Z8YXhIAJn/Bcx6Dhoi3QyUL8BtEm5yvlxZBKiRke9Js/NceCHJzQwQXN6Y3RraqKO7m1DNZYam6cV6lfbc9yZPyY0nWGSrJxZ1unyOfjuJzpib1MDt48SdgaXmJKn1UTzKcxEDmzK8W4mpZu26kt4cFMrV+I+DT7vBOztCj4b7N6yNje1QWipKubgMI1ZOILOqAIBcf/sLTiSSSnLBZGDFQlSyphwvA+LxAsXe9nfm4f15OzcZPtJltGQYo6385jW6GSKGLzlCeR22QU4Mkvbp0CLhjhGyokfeviR5Skh3Z2BAbuToco4+haDH5gzRldfjT2vQO5y0PGHw5ktbTgtGUFiP72p+ZjVVITqFt6Of6aVs7vIRMeLgZDV1UNK2N7gftZeBo4QQchZKr8VKSn0JQrjasj23dIl6o+TOlPH98M4IW068KStt6Bi2mMpVwJmyfILKmHkFtf1lqwgbKDaih6S6ziOUlk0A/A0I8xbISB+0uRl X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS9PR01MB13950.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(1800799024)(366016)(52116014)(376014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 2h/ZrGpi2rk9X2q5vQJUEi2OGqAYhHLpUuyY5VZG+/c7k8bdYDds4F1goNwll2oGI3vut75gSz+hZ948QpB15dYlbgBRQhLJgTQLr2FNgOHvyJquxJnmtoB5JU36ad/5XObOfHxnzvxHOk9o8Nxg0+iVK71OEcWtPj40TCAu+zxR/B2pMk5dBubEuAyQYoGYymqWmq9P2w5V5s2St/Yr30rfKs4pMWk2SXdcVzLIYS6zMH+uoaJPUegAYrcLd2JE+H3glLC3QQyuFq/iHodLJuWcZDX73tOJeVAoNMArchc+mHFlULww0oV6oMRV81+k3WKa9aapPdmqTt2Pg36C87Tfgj0ba95qL5iPuyiCFpt89lsrYx//1lZ2/dGGm27yg3v6nPI5Oowgp0Le68wPEIDMnYaNILVQWCL0U73838kRfn3pYp401XPwYFeL6N+NA45UsYDCJYQXFCIJ0Qho+IfGWuK4tFOUdGyyYVEqHfTglSnUTbwuGcqVEbwoWTJg9EJAmZHR1sD5xIF22JxARREkiC6q4/DFpP9hLVGHIPzI7sZcWWJZDCb0veKH7FTqXLU973c0TanziT5h3NrTOxeL2tucom+hZELKho1kTXat41e/zgXvgWV0B2tFmLwPcEXDL/b3aEWRbhYh43PT5dL0eH4qtsWYWhhwhd2AjfvL0uiqBaFeHvjRLHuCvyfUSt8JnttAO7elNWjbIxJ+jRqONz4fawgSpDlCfEX/eozUmcvOwlcCf8SSSkctUwKifV5zT5z5iYAe2LoYGqUceGYX6KiqXafb/Xgsy/iJ3BQ1D3nWFqtR+DqchXzd9BvGGpbhAkYjO3FeOvf2hVOXGWWfz3Ik94W3mgwnpQXiReYnH9+LOViI+sxYCQBaRMtUnjY22x3F+RyCVSGAcgkDNEySWIOpEoHosdR2Pu1tuDdbijEVRX5MezRhH+9Lh//DZt+nar0YF1ONKg4ymGVynS7v8uXMnlNvDDKxX7IHVy51a0TNwK0exmyOyq7K3aieUCCUomyQZy/J7+UHdCjplB/pYvBOg6BMaVeiy/WPo1A5XOEqvhV2AYjhobvpE10iFo9Xq93D5rg8tdsWxo5cUGY11o750D75EUY6v5VKAiNA8+149PeWm1iWEH3gWcCOVNkZvZ7Jbm/cL+ukQL9gi3p9dTizHMNYKYrcQNaBx5LkuvnCUU7BcIPxrADbsoAqDrdSf1qwLsarZA8tByC8zuPvGpTwB4kmx0RYslAJA4n6mTw1131sAlI9t7QnRjJgRgeBH0C6/18nOmStgrB2HyX54+wpyNlHPgRcy85lyO2nekSvNMCsuy2UvGdsG6qGx2RIUFoqENRmrseTeG7/lF+UFJbF1hLwRNZHYmr29xDUuVcKshZA9t4lMMUxSKZUUbGpipIj/LSv2ojPuO7aPJhXrkaD5tgfwfc4XcON+8FVOtXKy6oVegrqJGavWwpXuO2vWUgRLuKfRUqOFF8Z35+asONiawS3649xziMs/nN1sZP3ukX227khvd6UkFNLD9ZWmzrhQ33jp0sPXmvdQfwURkLJqv4mvbrZ9KQBKC++8MoLdtX85DFssIuqviUuzthSF9pI65FD/r/Ms3WTM0ExV93DztfL+r8jX1XCSKo= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b85e8ab-4fb7-45ff-e506-08dd5679fe3b X-MS-Exchange-CrossTenant-AuthSource: OS9PR01MB13950.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 15:26:51.6205 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: md+dOmXY+VCY6uexHD9qaNFqQ1Ik9ThVVkdVgTUPxohmG7by9qLaIjqYAeZqL/EFxw3Y3XB+BNwH5Xt5mgxPQkeuftKIqixCnBZOm2KTvCVGX0CdkTjqHZPyPW7hlglY X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB10248 From: Lad Prabhakar Pass `max_width` and `max_height` as part of the OF data to facilitate the addition of support for RZ/G3E and RZ/V2H(P) SoCs. These SoCs have a maximum resolution of 4096x4096 as compared to 2800x4095 on RZ/G2L SoC. This change prepares the driver for easier integration of these SoCs by defining the resolution limits in the `rzg2l_cru_info` structure. Reviewed-by: Laurent Pinchart Signed-off-by: Lad Prabhakar Signed-off-by: Tommaso Merciai --- Changes since v2: - Collected tag. .../media/platform/renesas/rzg2l-cru/rzg2l-core.c | 2 ++ .../media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 4 ++-- drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c | 13 +++++++++---- .../media/platform/renesas/rzg2l-cru/rzg2l-video.c | 5 +++-- 4 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c index abc2a979833a..19f93b7fe6fb 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c @@ -355,6 +355,8 @@ static const u16 rzg2l_cru_regs[] = { }; static const struct rzg2l_cru_info rzgl2_cru_info = { + .max_width = 2800, + .max_height = 4095, .regs = rzg2l_cru_regs, }; diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h index 00c3f7458e20..6a621073948a 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h @@ -27,9 +27,7 @@ #define RZG2L_CRU_CSI2_VCHANNEL 4 #define RZG2L_CRU_MIN_INPUT_WIDTH 320 -#define RZG2L_CRU_MAX_INPUT_WIDTH 2800 #define RZG2L_CRU_MIN_INPUT_HEIGHT 240 -#define RZG2L_CRU_MAX_INPUT_HEIGHT 4095 enum rzg2l_csi2_pads { RZG2L_CRU_IP_SINK = 0, @@ -81,6 +79,8 @@ struct rzg2l_cru_ip_format { }; struct rzg2l_cru_info { + unsigned int max_width; + unsigned int max_height; const u16 *regs; }; diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c index 76a2b451f1da..7836c7cd53dc 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c @@ -148,6 +148,8 @@ static int rzg2l_cru_ip_set_format(struct v4l2_subdev *sd, struct v4l2_subdev_state *state, struct v4l2_subdev_format *fmt) { + struct rzg2l_cru_dev *cru = v4l2_get_subdevdata(sd); + const struct rzg2l_cru_info *info = cru->info; struct v4l2_mbus_framefmt *src_format; struct v4l2_mbus_framefmt *sink_format; @@ -170,9 +172,9 @@ static int rzg2l_cru_ip_set_format(struct v4l2_subdev *sd, sink_format->ycbcr_enc = fmt->format.ycbcr_enc; sink_format->quantization = fmt->format.quantization; sink_format->width = clamp_t(u32, fmt->format.width, - RZG2L_CRU_MIN_INPUT_WIDTH, RZG2L_CRU_MAX_INPUT_WIDTH); + RZG2L_CRU_MIN_INPUT_WIDTH, info->max_width); sink_format->height = clamp_t(u32, fmt->format.height, - RZG2L_CRU_MIN_INPUT_HEIGHT, RZG2L_CRU_MAX_INPUT_HEIGHT); + RZG2L_CRU_MIN_INPUT_HEIGHT, info->max_height); fmt->format = *sink_format; @@ -197,6 +199,9 @@ static int rzg2l_cru_ip_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_state *state, struct v4l2_subdev_frame_size_enum *fse) { + struct rzg2l_cru_dev *cru = v4l2_get_subdevdata(sd); + const struct rzg2l_cru_info *info = cru->info; + if (fse->index != 0) return -EINVAL; @@ -205,8 +210,8 @@ static int rzg2l_cru_ip_enum_frame_size(struct v4l2_subdev *sd, fse->min_width = RZG2L_CRU_MIN_INPUT_WIDTH; fse->min_height = RZG2L_CRU_MIN_INPUT_HEIGHT; - fse->max_width = RZG2L_CRU_MAX_INPUT_WIDTH; - fse->max_height = RZG2L_CRU_MAX_INPUT_HEIGHT; + fse->max_width = info->max_width; + fse->max_height = info->max_height; return 0; } diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 792f0df51a4b..93a105dec8f1 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -736,6 +736,7 @@ int rzg2l_cru_dma_register(struct rzg2l_cru_dev *cru) static void rzg2l_cru_format_align(struct rzg2l_cru_dev *cru, struct v4l2_pix_format *pix) { + const struct rzg2l_cru_info *info = cru->info; const struct rzg2l_cru_ip_format *fmt; fmt = rzg2l_cru_ip_format_to_fmt(pix->pixelformat); @@ -758,8 +759,8 @@ static void rzg2l_cru_format_align(struct rzg2l_cru_dev *cru, } /* Limit to CRU capabilities */ - v4l_bound_align_image(&pix->width, 320, RZG2L_CRU_MAX_INPUT_WIDTH, 1, - &pix->height, 240, RZG2L_CRU_MAX_INPUT_HEIGHT, 2, 0); + v4l_bound_align_image(&pix->width, 320, info->max_width, 1, + &pix->height, 240, info->max_height, 2, 0); pix->bytesperline = pix->width * fmt->bpp; pix->sizeimage = pix->bytesperline * pix->height; From patchwork Wed Feb 26 15:23:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 868785 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11011052.outbound.protection.outlook.com [52.101.125.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E632231A37; Wed, 26 Feb 2025 15:27:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583639; cv=fail; b=dhKq0ypG2g187pLxlhre9wmdOzvtwVN3euHttfxqZyikMUK4Olmjljoip0j3hD/bL+3+q3uK6WAwIfvMCZgWVa0M86wGPWQhK8irURO8WKINhFb+eIavalDLQiXlFmxfkz00i6A3hMCq9jLwYKVI18w16yLjNkmKwHChpABkOxo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583639; c=relaxed/simple; bh=UKg1zHxKodbLnM5Z092xPJYbiyi9RVS9v5F4Nm3UE9s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=HiNbJy3VcfAsEbTTVS3hvOKgCuYPR8y2c278TMXOAxoGzQTDKBAGysPVLTNclu94zf2HNxIs2KA5mugmufRe9Oj5NVHftZ7125ocZSllYkcaN6p3GdCUrdiBPJNTZNhi9mIouUMb3zVAQiCdnR7VCaPl9Xd7jOPp8mYj1UQdm0c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=wvuZI8td; arc=fail smtp.client-ip=52.101.125.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="wvuZI8td" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FXRu0KeF00JUhjWhRv8g93XSUmSKMlc/Y8GvzyKwOwpuR2WwRyooSpgtveKUqHvAxVcWKgBLfzTGkwXy9/E9zMpDyGDWBBSOIOuWq5HQzLXYrSZ4nwZJgZOKqRxuTsCRXHRkuKurbPUYdNijXVMm2KbWjlHTjEuIANLnA3jhz973GIfV6yDdz/30T5mB8SijBY5o3/a1CIXq7Gjftg+xnvo8a8W9ojSuK1oOrK19vamWLQu2e4LaYg0+gfCzLZ6foCFmLylqaaAgy665C1Kt/veMrZ2UNzodHFXuATij6eo6vpZXxOd/taLzc0jMv3w3g4Vh4b5ioJBltqMKB+/bCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q1pltHDZfhSIrend9oly11YbV+aY6f95m/p4zfVuq1c=; b=LSMPbb3APCv44x6rpdciP1tglCSlgXuw3rQNeRpVyARnokWYrAXJLq27XcXRE9lUW8r4DqJKUjHrCAbjAFimNjTiNoZZ8978lx/Rvkg7o2UZQ6B/Sr8R2V+Cyu/xC0JcOoooaGVaZI6cs4cqXtQ5LtSqeTL0CkMEBtoBGjla/GJtk0HScsIdhKmo9ffVXmiPfLvvKrt0ItzUkDV5vtjj3Gn9RaTzthgDQxKvVOuE2W3GE0nQP6fHPKodVeeEsvccUmd2d+ID3cPm9sfQQ982Q/x3mF9F8g8QHQdAbduGCM6EcBEgXvNllircBIczQy9Pc6BXWr+ODb7iNmTlaN3G7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q1pltHDZfhSIrend9oly11YbV+aY6f95m/p4zfVuq1c=; b=wvuZI8tdJTsdJgp+oPTNI2YCHWk506lNW+8g8fcM7TB2KUmZlIIYpZTiYsPsZgoZ8SXf4tOCjDI9ialkl+Gk1tyG0TNYxMJttMvvutcBWZWu2igOl3rjYYa8aEI7OSj6FtpXT7k+NVpY6SSFW5B8aQ4n/6zQHZr1uWcY6jWrtNo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) by TY3PR01MB9826.jpnprd01.prod.outlook.com (2603:1096:400:229::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.19; Wed, 26 Feb 2025 15:27:11 +0000 Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3]) by OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3%5]) with mapi id 15.20.8489.018; Wed, 26 Feb 2025 15:27:11 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Laurent Pinchart , Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 14/17] media: rzg2l-cru: Add IRQ handler to OF data Date: Wed, 26 Feb 2025 16:23:38 +0100 Message-ID: <20250226152418.1132337-15-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> References: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> X-ClientProxiedBy: FR4P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ce::13) To OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9PR01MB13950:EE_|TY3PR01MB9826:EE_ X-MS-Office365-Filtering-Correlation-Id: 9415820b-10c8-4c6c-d3a8-08dd567a0a1f X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|52116014|376014|7416014|38350700014; X-Microsoft-Antispam-Message-Info: /GSBLyjXLOo9UQs/O3ebdRv48Ua7dPOKD5zZVnUmjeJWCOfs7U8Enx3iKCR/IN5h5NhRKUZ2YG/s7SbYdE3qFkjwRS1ZLrVw1jLjP0CmK/uKk+4MMm3t7wc76YpqRZrCEXupHkaL6OjGzX2JhqvQIy1ARulna+vmCrfpkysxMvbtmZSY69nBYNdCeLE1L6QFYq67/iB5tHy1RSOC2A1np68nBiPNJnKQlt3q6+iZF5E+uMIcrFt9iuIbkOUpUmX9iDqoX0SiIOzWLOLmtKEfYUSpJLgeIYC/EPQsq0vE8f3oTG8BAhNS0B0+WW8int3g6IHiS7/Nvc3Nx5U0lSYny+O3BhQJMdKNn81//9EVVdMtOKfi97oKEAK5maH47dE4Vr7cm+LRVEQDfpPe/3KNuoWIkCPTjD1XX1OfDIBB3Fn40Pf5fu2wNLf3bxoiOrP2pbbcdr0QwYkqh1TFpugYD6C6cop9XHKhvRUMbBPXAxIozx9DqOeWzBXfNCfMh5TIVsm3+lyaj2CfcDCbaDsFM9u87k7CW6xKK0qRgfH/xiviRo12AAUvkLkNldE20jc+bJdo5p2GOYLFfhVXWS54FoAA47FYdXxkOs3kDfSiDy08sNIbgc4sdLKh226dOsnj3d12MWvHuC6MtsNEJuffKYUEgi7gORhWiKi5p2+7B6UuG8lYkdLPqe/1a5SzMKZimOeeWGDG9XGBs0vm0QUsKv9slAIL033OGZ8S2KYfHeqpF0SXpBB9E/9tjTaNgR5zeLV1SrElV2mlWusSJXjJvpCqM5pYYcXr975JwweELSYRQY9MIEqgb5UwHJsoREiC9Yof9nCDYbVsGvmH2Q8I0V0i3f0wjTxlnW6wiDeUw/pQvJnSxvT//ReKQfBs97LlWQyX0F9uk2AYIR6pNH+XoDbIo3YtRnJb/0yByDoxp8tC6FDUE4K9wX3HyzEa3nVFRtIt+w6U5R4orMWC59H/DncNFVYQjZFDspIUpPrzshq413Dyj7naaj91JLh3DXQkjJGEXTjH94a5WFZtNh95sVc7KIz6AywWhduBGOZKRGsZifvgE+8IIGTA651/vF0P0sKiSC8gUcyTV471YlVN+OPa0+sTjRC7y4jl2KQWwuasRaWLnKiqWJq5IrhRYDzS9kk8rnCDw6WvXNcyAJwti/VIMNEQKE6voBhlhAda8v0x8j+ziGPXR8kvfzw4UGYePTkYV7wlYpQNWW70+DuueFav0j5uFQMlLqIqxV18kLsml8NGsNwsormLR9z5dg5ZYa2GUwB2AZ+dK/i4yOWLFG/S08A0NIzS9zkgD4TzefKdbaseXi9y5x9ib6CPQRXB0uqSMNhwvzEpJeA3ljfuXwpSvZ6Wqp1JOv6gMF66hWEWsRpQyyas0AsE80CzZuE8V5EshbNAk835OsWcfpAGOxskDgBDd1lnNQ9cnlOYbmPh3FRQ3wjYPblgwhbljAZ8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS9PR01MB13950.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(52116014)(376014)(7416014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MU1e60qt0digw0Fq0gyfbTT3xIdBk4ktlnHu65ZnuEmOw6z2GJ+CzEZnf0Ze6OIBbniDWjumw4S0Wp1cgFbtAZSm2u1DzWdx0cZJziw347WqZc/LfVOeprcNOZkAGAPayyNYDERnJxvr2Y4sbYsyIjceZ4Ga+zdaaTi5uOcYUqQDyBPJd2/1fCBUyormC3I6B2A5lbaM+LaCccQlCRqZykXDXsNDtsvBJvdkFr6cyuAB2+XSPpE1bafKkd5yBpiCF04/npQyAYKvPWxedInL3nkXMiaui+jN/hujkMzZycq8Z0Ir3AE5MeHRzWBn2253XFZjlrGX7tdgm7WfJCf3cgnn46pVe2Rxz1TsyWWMxB8Pbq+vj/CaFlADifCNcQ4d47NfRB8fJ2rgqvqBC7X4kLzw6MyO+/s8fzqnBoBtfON5sNPD2yzuNuobdiYSfBgVx8KFyjUguUh5B4q4f2RHykQuBY3uCHBHn+DpdsY7JLWeB01YL9wuRgBlXlphRcu02GlAuwaSQ3AcEoYkMiz+mJcE/FMWjw2+AwsQrIckyrCDQXJSmwrprPkkpEr7FWsxoWqdIzUU01yR128LAaWMoN0+S2aaHMt/DvQrxvvG3RHsfkoXH4UVEteWIcaS8XPmCo1NAhsTeXFdf00wNoz00QeV0SDbsghcjf2+YEOgb0P/xwAAaE8kzrgc68QbRjlUqOfzmM8b5IIgm1DY4bPO5hte+h7z/MSGturYULhZv6vA4IBWETMwjFauZhhVW7fn17zzDggJtpSFb9a0X+479+IsjGKDAXqVZ0apTzXwY0YqKX5RfiYtFV6R3KE9Lvet11ukBCUMiG/a/LhWpk5OyjRjuziCnG3cakBUii+n0yZ3LGbLgBBp8T9hP1pOuq10O5Kz391JiXvjHz3u3umpf1QO5sP2XrpZNXZ5Cmupwq0TwTR/0pGXochLBbiv8BCHl3Nkr+8EuMIQoUhXux0L3XHxRhdmFR3jh8MJEV6GuD3wEIo37QJgg6/k1/HVawb9g9Rat1uhnp0zIGXdAkFtGxbcbi9+bIoSTZifjvSBd9DBD0vC97jFfqrnYOtwq8KXSDgXgOcoXP8CcsJ3PEqYGbyehwLEiMo//nFJ95rtKgQ6YvGJRXA7xa6y2umhzAxbL6DrwrlQGTBcX+VsvdEXDrJHAhJcBYiwNpSdhVmhkd4349sKJzOx/Lu5325MzwXHm10pP+AVGBtd3GYXgpxLXryh0rZ1ue3+PoDkWaKT1qJSOx4v05twoHXw/7xfKG672XhNEcf890dk8YZ/Lk1lJTw6qsZE4cwW1caYb9aEV2m8Jgg8WPH+0UCzRWs1zCJDNXpdvxn13+jx5IKtClUha+oMXGZfmPTHqTGORbGQ/X+epk3GZe9z3zCYxsqP20WH/jOig1a/4NAfPMYueMv/MaUjxRnEXyaAnAwONgQhxCE5gUKktUeMqH4T2OU7axj26XMwLs6lSEy0ow/cLeB0NT7M5yXu0Cps+OnjHBiKikd6GZ1gVf0l9Xo60CFq3raCeN1wds5tokgLjY+Y4EBDsextKZBzuCdy/YsLulOtpN5E0R3j6vy01OQQ0GkdALs14Xv9CPygy73Ipfn8SpBm5DLZnji18eTVakG/3Gam83U= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9415820b-10c8-4c6c-d3a8-08dd567a0a1f X-MS-Exchange-CrossTenant-AuthSource: OS9PR01MB13950.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 15:27:11.5716 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XgnQUga+I0jayPVPovI9sOy8NRemVFnC2XHY9jJMf2fYWbN+hXCkENumC/ZHkLJkp7TBkrw1JBsam4n4tfGc2V7b7MvYE6y3PdvDwZMicdgfC5tyn0thrHb+4eSpsqCi X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB9826 From: Lad Prabhakar Add `irq_handler` to the `rzg2l_cru_info` structure and pass it as part of the OF data. This prepares for supporting RZ/G3E and RZ/V2H(P) SoCs, which require a different IRQ handler. Update the IRQ request code to use the handler from the OF data. Add `enable_interrupts` and `disable_interrupts` function pointers to the `rzg2l_cru_info` structure and pass them as part of the OF data. This prepares for supporting RZ/G3E and RZ/V2H(P) SoCs, which require different interrupt configurations. Implement `rzg2l_cru_enable_interrupts()` and `rzg2l_cru_disable_interrupts()` functions and update the code to use them instead of directly writing to interrupt registers. Reviewed-by: Laurent Pinchart Signed-off-by: Lad Prabhakar Signed-off-by: Tommaso Merciai --- Changes since v2: - Squashed patch 15 and 14 - Collected tag .../platform/renesas/rzg2l-cru/rzg2l-core.c | 5 ++++- .../platform/renesas/rzg2l-cru/rzg2l-cru.h | 8 ++++++++ .../platform/renesas/rzg2l-cru/rzg2l-video.c | 19 ++++++++++++++----- 3 files changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c index 7e94ae803967..302f792cb415 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c @@ -278,7 +278,7 @@ static int rzg2l_cru_probe(struct platform_device *pdev) if (irq < 0) return irq; - ret = devm_request_irq(dev, irq, rzg2l_cru_irq, 0, + ret = devm_request_irq(dev, irq, cru->info->irq_handler, 0, KBUILD_MODNAME, cru); if (ret) return dev_err_probe(dev, ret, "failed to request irq\n"); @@ -359,6 +359,9 @@ static const struct rzg2l_cru_info rzgl2_cru_info = { .max_height = 4095, .image_conv = ICnMC, .regs = rzg2l_cru_regs, + .irq_handler = rzg2l_cru_irq, + .enable_interrupts = rzg2l_cru_enable_interrupts, + .disable_interrupts = rzg2l_cru_disable_interrupts, }; static const struct of_device_id rzg2l_cru_of_id_table[] = { diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h index ca156772b949..3f694044d8cd 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h @@ -34,6 +34,8 @@ enum rzg2l_csi2_pads { RZG2L_CRU_IP_SOURCE, }; +struct rzg2l_cru_dev; + /** * enum rzg2l_cru_dma_state - DMA states * @RZG2L_CRU_DMA_STOPPED: No operation in progress @@ -83,6 +85,9 @@ struct rzg2l_cru_info { unsigned int max_height; u16 image_conv; const u16 *regs; + irqreturn_t (*irq_handler)(int irq, void *data); + void (*enable_interrupts)(struct rzg2l_cru_dev *cru); + void (*disable_interrupts)(struct rzg2l_cru_dev *cru); }; /** @@ -177,4 +182,7 @@ const struct rzg2l_cru_ip_format *rzg2l_cru_ip_code_to_fmt(unsigned int code); const struct rzg2l_cru_ip_format *rzg2l_cru_ip_format_to_fmt(u32 format); const struct rzg2l_cru_ip_format *rzg2l_cru_ip_index_to_fmt(u32 index); +void rzg2l_cru_enable_interrupts(struct rzg2l_cru_dev *cru); +void rzg2l_cru_disable_interrupts(struct rzg2l_cru_dev *cru); + #endif diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 5033c8d98639..8995aa254c17 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -300,8 +300,7 @@ void rzg2l_cru_stop_image_processing(struct rzg2l_cru_dev *cru) spin_lock_irqsave(&cru->qlock, flags); /* Disable and clear the interrupt */ - rzg2l_cru_write(cru, CRUnIE, 0); - rzg2l_cru_write(cru, CRUnINTS, 0x001F0F0F); + cru->info->disable_interrupts(cru); /* Stop the operation of image conversion */ rzg2l_cru_write(cru, ICnEN, 0); @@ -393,6 +392,17 @@ static int rzg2l_cru_get_virtual_channel(struct rzg2l_cru_dev *cru) return fd.entry[0].bus.csi2.vc; } +void rzg2l_cru_enable_interrupts(struct rzg2l_cru_dev *cru) +{ + rzg2l_cru_write(cru, CRUnIE, CRUnIE_EFE); +} + +void rzg2l_cru_disable_interrupts(struct rzg2l_cru_dev *cru) +{ + rzg2l_cru_write(cru, CRUnIE, 0); + rzg2l_cru_write(cru, CRUnINTS, 0x001f000f); +} + int rzg2l_cru_start_image_processing(struct rzg2l_cru_dev *cru) { struct v4l2_mbus_framefmt *fmt = rzg2l_cru_ip_get_src_fmt(cru); @@ -414,8 +424,7 @@ int rzg2l_cru_start_image_processing(struct rzg2l_cru_dev *cru) rzg2l_cru_write(cru, CRUnRST, CRUnRST_VRESETN); /* Disable and clear the interrupt before using */ - rzg2l_cru_write(cru, CRUnIE, 0); - rzg2l_cru_write(cru, CRUnINTS, 0x001f000f); + cru->info->disable_interrupts(cru); /* Initialize the AXI master */ rzg2l_cru_initialize_axi(cru); @@ -428,7 +437,7 @@ int rzg2l_cru_start_image_processing(struct rzg2l_cru_dev *cru) } /* Enable interrupt */ - rzg2l_cru_write(cru, CRUnIE, CRUnIE_EFE); + cru->info->enable_interrupts(cru); /* Enable image processing reception */ rzg2l_cru_write(cru, ICnEN, ICnEN_ICEN); From patchwork Wed Feb 26 15:23:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 868784 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11010001.outbound.protection.outlook.com [52.101.229.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEC5A227EA8; Wed, 26 Feb 2025 15:27:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583655; cv=fail; b=Y3YwfgAo+TpPDKCJoFYMU1Fzu04nL+UI01n6F6OTNDEvn0HtuXt5wMLgriRjY+g4pHZ16sdFT6cjiND1cY35yb9MMxHNx1V868Yww82FpDObxSB6ZMLBq0Oai1Fe+0dAl2QbRzdo/E/1h/zWXx7VV7I2cIUdA5zJ2S/hGYoVBX8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740583655; c=relaxed/simple; bh=9DWDlHAmyd0VJNycd3ZXUthqysKNwhsejI1DQdf3ELM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=N2Kojfm1OlBElscgThNDEbH+rlujo8Oqz8k5dmgt1LuNm9h4vQ1+9X/HMUej/FHPhNSigPI/8ImYNH5gykGF4wDn88ibCnHiNwNBnViB9R81usDExEs6BMNsMTKKpkNFwKyehU29lyPBaLLWsfrxvLQQjIkCvxn/X+j9XIaQhis= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=D+rgpY7E; arc=fail smtp.client-ip=52.101.229.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="D+rgpY7E" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RLFBhxRSR9ZZKlLToEgMhCpUugclAY6rKO54surjikLWYi207yIedY472aUFa8D0PbrHftv0aLhAJKVT3bj6UYRuvYp1TZIHZIRXadEnG1RwOiXWPMhMgC6My8dtpeza1DD768QI+zLasry1duRYlv4HKPKS9CrsPC/YdagVWBVFLdifW08AR1YOKGnvXlHmbqY/yi6RpH0AspiHyN+pVfy3UBFoP8K8hXmCXaVxDGzKp/T7JzWEVA7XCPPxbRc9DaJkhArxH8k7qI5HWg/XwcE7xvQ3v8lCJ6ZWJupUtpj39pBj7P2W+RI6NJ2yZP1APHWrnIZgLFXBIyTUhckEBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9shOnHi2lLf0mwVZQ0UKci5a3+D8SHoLbf0tvXU/1es=; b=NeZyfpbnhVNycnksoukCfuOIN2hiQnBopDxiw2PMh1FWyZRVxJGCewk3Kpvr5k6822lB12oe2N54laBsa2lVKJP4MIwN3dD7QpB5HN87fnEg7wIpMnVt3HwEzzZPtBoBMknZx/aiiRodFN0zlHcJUnptSMXV7ZZjW72X3BYJQlD3oqoRrgPwdIbEjSNXrhM4zKpqGBQYDNsoMmozg/Sr71hYDemlIU3omwoykK+fiHpx2qB0fIXeDm6828qQZRWreqOnnFbQBnsXSsEffi6y2FYm6qLqgnUc6uJmuZXXL0JhcCsSvua9FNS3+dsBjyUmUkZ/A7lqZypNSm4nwCw5eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9shOnHi2lLf0mwVZQ0UKci5a3+D8SHoLbf0tvXU/1es=; b=D+rgpY7EzG9kM3zqzrXH+etKaDoML74Q3RVjQhcjcVJBnxiPWSDlfFlxcdX30hqUOewCFg3eXg+EyZnCoVxXU42/ugQVsaizaXdIm29m7kiS7HOEKNSoID5mF6qa8bpiJrK2fwFpWQ7gz8zanK8tO1TEyIY/w/sTK0RxYLvwQow= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) by TY3PR01MB9826.jpnprd01.prod.outlook.com (2603:1096:400:229::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.19; Wed, 26 Feb 2025 15:27:31 +0000 Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3]) by OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3%5]) with mapi id 15.20.8489.018; Wed, 26 Feb 2025 15:27:31 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Laurent Pinchart , Tommaso Merciai , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 16/17] media: rzg2l-cru: Add function pointer to configure CSI Date: Wed, 26 Feb 2025 16:23:40 +0100 Message-ID: <20250226152418.1132337-17-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> References: <20250226152418.1132337-1-tommaso.merciai.xr@bp.renesas.com> X-ClientProxiedBy: FR4P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ce::13) To OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9PR01MB13950:EE_|TY3PR01MB9826:EE_ X-MS-Office365-Filtering-Correlation-Id: e2f75829-5715-41b8-a250-08dd567a15fd X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|52116014|376014|7416014|38350700014; X-Microsoft-Antispam-Message-Info: 7M1ZkleUtrjmBPUtS22MjoT+ZKi4iU5ERjiS8/woL7noUycrSjmZiUm6S51c8JXS5dH8Xm4ahMWIDS+yf1H+HNuiuyRFDwj3wjn8LZ1HwnksJQCogncC3yI7hkLRAZiqRkjBoFopAxo1uLwTer2leRqjvdgipM+ed6t8JCjqdc2jtkOQX3foE+5B0SR0b/MxdL5ommksRTOxXYX/8J5swfAHD+zSm/tUQnc+ifHJ96LJGNJ6K1+3a4CFO0JSh458nezZ2q+golZddkigKbQUbTDN4fp+Kyxm7RFTHpzvsOov1af9f/o3n+O57VnWoBTnLFov1swjksR/Er+ICKcAyKTyjHbXiStf5mYc+6fPCg4C3rQ5Pjpfqi0gk64gts6hr0boAU9hwXsIzQWCT4okObHO4DiPmyoHl7ZFHFRx1zdcNAAFncavq6k8/wDLDT+cvF6hHoG5lHVmEEdX9eGeK8UvCZrdNGcGbCQTmR/0oeyc0tDf5y9asCj+9OSTniRoIG4oBxpyE8gXbeKUbcscbBiREbsXxw50ZTs07AmHYKxrc+W3Msila3qix9p48WREQ73g145w3j54flJ9VEemZtwLAd+ogr3q3h+W0ycuwXCf0n6zPKseR1XMZWb7VO8E424ky4Gpd2GgfV4gh7Ndw6YDDbuY0g6GqRrrYiMvRTklO9lW7pZsZCmWYKJe5ssFBQmMZ0b4SrCdaVdzueAypn8odo3sbV8gNQOE1sUqrsEl1S36qhcjxrmeJ+qsvqqDcujGTpmvmLlzTxt+u17LuZuOXERdeY91jJiwEtBltGeZB2Rma/dABMiMz19kNJfgA0Z+nZeepeE347BuY/+HNYQX3dK29pr5ULhgTZkj2nWfnr3YTGXhIz6DQLZCtQW1NnUrEZIg4Y9+h5acYWejA9F8LDTrENeKMrsnQwsf67cmCmdKnm/OkuiplbqSgAcyDH0h7h3CbgPbc3GcULrLed1gny4VTcwQWPCvX6fAaTQHK4VyHiLZ1pLSI72p0yNaB7HKmfzlU7PENnZpq5eOTJJiRYJdNEh16E8Oh6OoU6nCvd06q5OoPmMA3Gno6w2JzeL59d8J0TL8lFk7oJaKV+twcURVZVL7t5vhSM8XM+btsqiJhK09cW1iKf/HpcG3Mfeij93Yn/fLDIxcxPiMH4cIYUS2IOcOI+1mW/eNsEBWF7beiZwNLy8KYCMxeCryRpeQeTsUptcSMH3qKlOvVJJbphRX0+fx6lXvFr3VRhQIeJhM46sxYuGLUCfo9hTVchA3xFGnMu1TkNsgvkqJNuZudtfAkq0fLf3A9ZWTsCN+8JAu3/bY0783iPyP4sE6q8brP4Rk7KmenAIoGxqxvI7n2yILHk8u9nPV8KM9ljJKult5xV73FupfeuNUBZHc3vddUi9pEVK2U9H+mquIlpwwfHHMJSV6FSdcquGxBhrA9R6mvimyHEg/CMeLOeO1 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS9PR01MB13950.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(52116014)(376014)(7416014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 3G6UqnxQDyCWmhP8NrbxqLZZOzQGZPbyCBNFTs8CuHBST+rFX1AHMFprXJA5nZs/yPBItGpsHmTrRjQzWErotHryx8PPs6JhNUBR2aP63oQyOBxij8c/k0jFoLXWE4a/I8/XdnywBhY34kA9eVmBqDaWTtzcsEqQ+oadOvB9L/FmAJCperBS/X9TgtD1+2l44uqSed6orcQ5zpBglJVs78ItG/uFp6swgsn0qg0reAjnnnKZo+Kkn28tsmvGR9P95u/THqtSBbYqR1RCdYZw2MbaXudHlmvFjtf6YaYcc2xnxoMP8Kpt+ef45+5R5mtrsuw4DNs0dOKUnf7bHx6a+Qx6NH/0Tb4vLpw2CfwV41s6axp2g49mstjdrxLm0VLMDy3Z2PJA+VTL1rLu2IVbFAJvoPs7HTnrDHBK/+RKDTyimeYJIO+cdlqG3KSaBESpzmJP6kC1jpu6UN5zPg1mjC6A7S9storYP/NHnE5vugParCPfzPfr52vAzaOTbTOrZ0o7/ZVVacXjLmdpHgC7LFbDk1UK903UAlzExaaHg0IdvpxIgMAsCSujXbr3nKBVlVO6oAWg1/KpEAcdoPLw/ik7wQepk8Gr5T3QbqiNkJqRMfs7tyiV1KghrD8vC/hPc2OWcew0DwtCp8OPnM2iW+zWorET0zzdjYZYgRXqUmivaHg9cH6MY+eGPKLKgAajL10NNl3tI6L8b6ciEyeY9H6+WMlGj1Kwq4uroAOCxAtmchypZM6KszamDVn4qaP/vR/Y0wq5gHsWoTRf4x9iQHsAXp9zi2DcsFuKhcYL0v48Gy/2WlGOuelEcimCGX7ayfczQ9/sLXxyZ3WKnp3U2oZoaMY1s87j2hL+4UiHDXitmGltoxN6qBD5Nf4zBSczV0uN+OdMh/d4EUTCJke+V6sfz1lvjFfvxq4DQXGZ0HdFMEbgU4GcsnRJJ7vjjxKA+Z1fo/b0Z0rj5FH+PVZn1Cx9AyAACTL7h3EvnR7ZwfYvq9iGG7UySDqF06x3jMsyk9abIazhz4xOHmSUA1e0cajp9oQPxGiDsXKgn5KpDUKICsPoezNeTz9vXwp4G/5Y/BuCXkg9gVv3kUEF6doQ7LxP/oiNL/nNxTZChTh6143MWUwtg8BRESOKVqdfPKusQ1LYe4AV6UjxXPNOaE/CxO2VutxECvnNNJkufFpyWncsrNCp7RdeYRdBzFoxMFCiA1MuF5iQmzjViG0rrolbX3JKb7qRNdsyGDFWC5QNlaZLDOWtSft7ieKY25UBOnAZWjxYkZmoBFkya4Kk47Xt09hMGvbDVBpCtRekNK+glMVj0UwW35Csh7BWP4zG7VoszTX0oerlVeAYoHudpBJ1PoCmqcxQ1UFUbNrT0iJu5cr2KY1iWv/QABSx3TnxME/ygzAxV4V69zRUpYxh/FnuB2qcFRqjC4pzpLPmdVeCM3NDysoUGKQUpmVBpzkF99p3/5IT+3SjIWOlD8MtQ0i+2eIwkaOx3PNvjxZ860320Vvt/GIF6KvS8vaAKdutWg2kLajboPbLnFrlyZcy+lELzIOrTjDiLUC7HnL4OTItRcfNDrgk0zvQOstmuFTxeBo2HgHOYYE2NvfJKTJXoNWQR10OCe9cbCgPl6AyBGq//c0= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2f75829-5715-41b8-a250-08dd567a15fd X-MS-Exchange-CrossTenant-AuthSource: OS9PR01MB13950.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 15:27:31.2689 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hjBWDTagkm0MMxwJsntMOD9xQB9YgZtW5s8fMvlz8uFZ3ITsD+Y+b6JdQSUiA6WGVL/CXF0eoFyRVfiivTi4e/NTaMnyvc5jmnqBvLY4DGfu0xVAhBWrlW3YLTKIZfsk X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB9826 From: Lad Prabhakar Add a `csi_setup` function pointer to the `rzg2l_cru_info` structure and pass it as part of the OF data. On RZ/G3E and RZ/V2H(P) SoCs, additional register configurations are required compared to the RZ/G2L SoC. Modify `rzg2l_cru_csi2_setup()` to be referenced through this function pointer and update the code to use it accordingly. This change is in preparation for adding support for RZ/G3E and RZ/V2H(P) SoCs. Reviewed-by: Laurent Pinchart Signed-off-by: Lad Prabhakar Signed-off-by: Tommaso Merciai --- Changes since v2: - Collected tag drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 1 + drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 6 ++++++ drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 8 ++++---- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c index e4fb3e12d6bf..3ae0cd83af16 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c @@ -363,6 +363,7 @@ static const struct rzg2l_cru_info rzgl2_cru_info = { .enable_interrupts = rzg2l_cru_enable_interrupts, .disable_interrupts = rzg2l_cru_disable_interrupts, .fifo_empty = rzg2l_fifo_empty, + .csi_setup = rzg2l_cru_csi2_setup, }; static const struct of_device_id rzg2l_cru_of_id_table[] = { diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h index 2e17bfef43ce..ccaba5220f1c 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h @@ -89,6 +89,9 @@ struct rzg2l_cru_info { void (*enable_interrupts)(struct rzg2l_cru_dev *cru); void (*disable_interrupts)(struct rzg2l_cru_dev *cru); bool (*fifo_empty)(struct rzg2l_cru_dev *cru); + void (*csi_setup)(struct rzg2l_cru_dev *cru, + const struct rzg2l_cru_ip_format *ip_fmt, + u8 csi_vc); }; /** @@ -187,5 +190,8 @@ void rzg2l_cru_enable_interrupts(struct rzg2l_cru_dev *cru); void rzg2l_cru_disable_interrupts(struct rzg2l_cru_dev *cru); bool rzg2l_fifo_empty(struct rzg2l_cru_dev *cru); +void rzg2l_cru_csi2_setup(struct rzg2l_cru_dev *cru, + const struct rzg2l_cru_ip_format *ip_fmt, + u8 csi_vc); #endif diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 83d7baa07dc7..a3c4e2a0bef6 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -242,9 +242,9 @@ static void rzg2l_cru_initialize_axi(struct rzg2l_cru_dev *cru) rzg2l_cru_write(cru, AMnAXIATTR, amnaxiattr); } -static void rzg2l_cru_csi2_setup(struct rzg2l_cru_dev *cru, - const struct rzg2l_cru_ip_format *ip_fmt, - u8 csi_vc) +void rzg2l_cru_csi2_setup(struct rzg2l_cru_dev *cru, + const struct rzg2l_cru_ip_format *ip_fmt, + u8 csi_vc) { const struct rzg2l_cru_info *info = cru->info; u32 icnmc = ICnMC_INF(ip_fmt->datatype); @@ -266,7 +266,7 @@ static int rzg2l_cru_initialize_image_conv(struct rzg2l_cru_dev *cru, const struct rzg2l_cru_ip_format *cru_ip_fmt; cru_ip_fmt = rzg2l_cru_ip_code_to_fmt(ip_sd_fmt->code); - rzg2l_cru_csi2_setup(cru, cru_ip_fmt, csi_vc); + info->csi_setup(cru, cru_ip_fmt, csi_vc); /* Output format */ cru_video_fmt = rzg2l_cru_ip_format_to_fmt(cru->format.pixelformat);