From patchwork Thu Feb 27 20:50:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 869415 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 249381AF0C9 for ; Thu, 27 Feb 2025 20:51:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740689461; cv=none; b=PgrNQEw7FS+78w0iSiHfYPYc5a1Uz9rxBh35Hdix0hbA5emEwUEcTCwtKUs6V5jGYcrjqnFDH0w/uk2kGn7FpoL+HIIEBhLzRNWbycb/wMWtcXvBnRCd/9CRM/ZxlUPVlIv5+KJ4afzp3kqU7UpJESG3rZ4AwU8doZ6rrQl4FEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740689461; c=relaxed/simple; bh=FJi+gWQ0Qfes3r9kYf5ehvZnEEXi/93JmDdcFqoAk3o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rvRLLhKJJCJ4UD/zo8D1QH5L/sE1LTWq1tmuz93IVbco9Af22oukGcYtxUbhxe0JxX8eaA8wRD4W1Wu6qRxWKaMnwn03fzSD4Zd3urjCTK/4PtsMKED2R0rzqaC5VpKDkXy/To/HcEH7yQ4DCt+gmxiXMA0k1DxHYCQy1bHfNJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aneDfZxT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aneDfZxT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 140E8C4CEED; Thu, 27 Feb 2025 20:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740689460; bh=FJi+gWQ0Qfes3r9kYf5ehvZnEEXi/93JmDdcFqoAk3o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aneDfZxT8OxsFlqMly47ioNhHk8AxKeSXzvayltN3BI56gH6W/Y980scvyrpM4fG1 M2ErDJtjaYHAi7c7dGZLqiiaNVrukRAs/nOwshLs6fdeYl9pSFqL9qtU6AFLJ93dFM tYZHZ6YncnoP0yxSxH8kinrYJ7JzMYOpyuAaCUtryx80Hg4y3BLxj1j6YoSWk5dRop 1bCc+zqbc+warKQh7AzpDBe9LqYOVWeodw8Me8o/R6BWteQixefzRc9SmEaTPiSUsV KnaJJnjNlsFUIZKquhssUom/6y958JKZgrj+CLgELgoqJvRSJOLvl5syT1p6HLPgJq YEzrjKevSkwUA== From: Mario Limonciello To: mario.limonciello@amd.com, Basavaraj.Natikar@amd.com, Shyam-sundar.S-k@amd.com, linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org Subject: [PATCH v3 2/2] pinctrl: amd: Add an LPS0 check() callback Date: Thu, 27 Feb 2025 14:50:17 -0600 Message-ID: <20250227205049.765309-3-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250227205049.765309-1-superm1@kernel.org> References: <20250227205049.765309-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Mario Limonciello During suspend the pinctrl_amd driver disables the interrupts for any GPIOs that are not marked as wake sources. This however does not prevent them from changing the wake status bit during suspend, it just stops the system from waking. If the system wakes from hardware sleep for another reason (such as plugging in the AC adapter) this wake bits might be active. This could potentially cause problems with going back to hardware sleep. Add an extra debugging message when PM debugging is enabled to help identify if this is happening. Acked-by: Linus Walleij Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3929 Signed-off-by: Mario Limonciello --- v3: * Add tag --- drivers/pinctrl/pinctrl-amd.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index 1d7fdcdec4c85..fdda8d1c4f344 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -37,6 +37,8 @@ #include "pinctrl-utils.h" #include "pinctrl-amd.h" +static struct amd_gpio *pinctrl_dev; + static int amd_gpio_get_direction(struct gpio_chip *gc, unsigned offset) { unsigned long flags; @@ -909,6 +911,29 @@ static bool amd_gpio_should_save(struct amd_gpio *gpio_dev, unsigned int pin) return false; } +static void amd_gpio_check_pending(void) +{ + struct amd_gpio *gpio_dev = pinctrl_dev; + struct pinctrl_desc *desc = gpio_dev->pctrl->desc; + int i; + + if (!pm_debug_messages_on) + return; + + for (i = 0; i < desc->npins; i++) { + int pin = desc->pins[i].number; + u32 tmp; + + tmp = readl(gpio_dev->base + pin * 4); + if (tmp & PIN_IRQ_PENDING) + pm_pr_dbg("%s: GPIO %d is active: 0x%x.\n", __func__, pin, tmp); + } +} + +static struct acpi_s2idle_dev_ops pinctrl_amd_s2idle_dev_ops = { + .check = amd_gpio_check_pending, +}; + static int amd_gpio_suspend_hibernate_common(struct device *dev, bool is_suspend) { struct amd_gpio *gpio_dev = dev_get_drvdata(dev); @@ -942,6 +967,7 @@ static int amd_gpio_suspend_hibernate_common(struct device *dev, bool is_suspend static int amd_gpio_suspend(struct device *dev) { + pinctrl_dev = dev_get_drvdata(dev); return amd_gpio_suspend_hibernate_common(dev, true); } @@ -1181,6 +1207,7 @@ static int amd_gpio_probe(struct platform_device *pdev) platform_set_drvdata(pdev, gpio_dev); acpi_register_wakeup_handler(gpio_dev->irq, amd_gpio_check_wake, gpio_dev); + acpi_register_lps0_dev(&pinctrl_amd_s2idle_dev_ops); dev_dbg(&pdev->dev, "amd gpio driver loaded\n"); return ret; @@ -1199,6 +1226,7 @@ static void amd_gpio_remove(struct platform_device *pdev) gpiochip_remove(&gpio_dev->gc); acpi_unregister_wakeup_handler(amd_gpio_check_wake, gpio_dev); + acpi_unregister_lps0_dev(&pinctrl_amd_s2idle_dev_ops); } #ifdef CONFIG_ACPI