From patchwork Fri Feb 28 15:56:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iulia Tanasescu X-Patchwork-Id: 869356 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013038.outbound.protection.outlook.com [52.101.67.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32FB326E17F for ; Fri, 28 Feb 2025 15:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.67.38 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740758226; cv=fail; b=pLVfGRRalZpeAB2DLSiG0k5mGstF8MLMWymPwkG+KoyuZyA3fJIK86EP8dGEMY8AC0IBshzelHtoMC+Aeo0n/P+895GReqFTbcaK5IQY+NtP9es8Bz+zkLp7AB5DAUPzbAjU5NCWBrofNuaNeR4/TxsVv7V3P0GsUXAclqhXmxY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740758226; c=relaxed/simple; bh=j6oKxv0dnncWeDZfCxvTWQgMrOzqmE0yFwNM2VE5C5Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=TxuQYG88Dj3D0JiOw2WOhzG4Lvhmema+mD/jIy29KcCVlF347JqafPBUkpcwS/hzxdhDEYRWPj9IYPxAaE75LZv5OzvN+jDyZGBHfUjOrrEpFQnjuFWmfQSdvMvVuXNGnv2owfug2w9k99ho9mTX3Os3/B/HqUgLErrpWPvQFeQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=OMzDpbL4; arc=fail smtp.client-ip=52.101.67.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="OMzDpbL4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZObAjxFWbnDX0MODGRj594px/ims4HAKQcF/EpKNYML2pmT2wmQRDQ+w17x91UnEdV6Ia8ccLE7YHOw94AClFgR5JrkzZQj8MRFTQfncYZpBv+oWfwna+PYRq8e8teAqheZsBbzl4hVaiuIYDm25cVN6kmVKLS5krYtsspXi3J5AvCW0uw+DGj6IawOVDUbFQX+o2QYMPqFL9Gdo3KvXiIS0KQnU/qufBffin2Optjgncz+njWe43ltkzCqQxsowrctqsqMSpa1V1ARCdGQOpes3mLSNkc7zLdg3BydXSQpc1kIzA1k55FIdnA7FpU/SysOT94iUX6vW1jIKTntAnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z7bm3uxDjfHczphW82U81ZMojbAO8vZvmbXj2jAxY90=; b=DYxvpDHZd2EHPXsamAGKceISI0z+V9p55z13LNBK9rSS9xDlzAPdBtE5loCbdZcSS37PS1GzjAgLXuM6jwu2ILp+pkJGJzXT5ZRe75XpGLqbcMQ9cqQZRmmoPuCEzgH2ATGjMnPZ7NNBEXhyHccxZEpPhGLF7OE5z6k2ZLpDwRKCL1okBWW+JiSwsF91fgw6ZrnI+W1MDTA6gcKa9Vx8My0P2vzGcsmRobqyUOqmn1tzrd03FH7hc+rapbQuRi2jGelQHC9qHLfY7cw97FruENK0QnYSixmz/EWBUpCt4xO6s0lV9rPWjDuqqkGgNOIZaKRMXfdcVYNswvMzOGtw4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z7bm3uxDjfHczphW82U81ZMojbAO8vZvmbXj2jAxY90=; b=OMzDpbL4JYvBTmc1ed3KN1usS1f8Cehg4meG2/Fy3QD62H4xVhik3A1KnPdOti/iaWirIZY/HKYljDW5hsQNyaL0F5qniQNlGnD9/ISBMtRjaiCZYWbtry8LwEw+zVKY3Tr20IKMWr9J3Nl1upHm2YxgErI8IVfAZNP/8n6Ch7PAIuHKfF6EZDS/6mEr2cK60r73JGketbdv0GlmGj4AB3cYNyQYxUPsMYDJzuEYefo/ZLti/UATX7EGPY1qFiUVo+9FKqUTIeaohV4fnW6pIVAP/aILVTdq7wYfXLFZ4kXOLB/xkEbYD7TpZf21sXrUpfkvKlx8lnZOIuKHeQVb2Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8898.eurprd04.prod.outlook.com (2603:10a6:20b:42d::15) by GV1PR04MB9118.eurprd04.prod.outlook.com (2603:10a6:150:25::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.23; Fri, 28 Feb 2025 15:57:02 +0000 Received: from AS8PR04MB8898.eurprd04.prod.outlook.com ([fe80::5e22:869c:33c:9654]) by AS8PR04MB8898.eurprd04.prod.outlook.com ([fe80::5e22:869c:33c:9654%4]) with mapi id 15.20.8489.021; Fri, 28 Feb 2025 15:57:02 +0000 From: Iulia Tanasescu To: linux-bluetooth@vger.kernel.org Cc: claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com, andrei.istodorescu@nxp.com, luiz.dentz@gmail.com, Iulia Tanasescu Subject: [PATCH BlueZ 1/3] shared/bap: Add APIs to register broadcast code callback Date: Fri, 28 Feb 2025 17:56:32 +0200 Message-ID: <20250228155634.57979-2-iulia.tanasescu@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250228155634.57979-1-iulia.tanasescu@nxp.com> References: <20250228155634.57979-1-iulia.tanasescu@nxp.com> X-ClientProxiedBy: AS4P192CA0046.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:658::26) To AS8PR04MB8898.eurprd04.prod.outlook.com (2603:10a6:20b:42d::15) Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8898:EE_|GV1PR04MB9118:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d690e8f-b0ed-4414-0f9d-08dd58108a26 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: tGBgQhxcFzVr00t3lpfkyFaWVImcMkSbCackgOAl0kK/Mx4jU0z4t0ubmm9a1dXM5QTvRHX7By3OpgQCqiLz/vWvZO/hp3yNJIUbTTPHUSq8Cj//YbPgrrSzUS2DOg666ylW+r3Cm+DXksuAurG3hUi4q73w9JxSAQZJevBc8IEeutVzQsM+/NRRCz217OCPAYh58QzEECKKMv/f6efJSn2jICh9EUYuj+pUj61ChqkpRKSYmqXNIXffa8qjgsJPwULffnz3TVCnxevF+2GQMjg/CncI4mFcv3vAK7/Oq0vA5ku+DRHNiRcL4ofbw15z2+HgsYOPc0+YyvOflhNIfCe8vjeTQ64iR9gqYYnE9fH/UwIqkegnjFtJXsJ00EAME3ZW1Ocsqu1zB71vocaJPKWAjiTag056/OYofOIu3iV51gXw0TxV/fhII+N2xZPBjeGdwu365dEqgaLfWq1prwI67wmFYXwDzUeK1O8FzVpJQZHLbXnINXYFCA7plH/OeA2mEMXob+/0+onSFY/4Mrz0OKaJAxW9PbspUOkPj5tBQzrDvQpDN9zRtn6yXb5lpJj/HnIpCHYiLKcpuMxtFhycEI0mcgjV/NXFwHUTcJ+UvVBUnb6vrn9Ddpju3hXnbU4ttrvcZj0bEn8dE7j1Va5lwlegdOirReoYRMjY5LmnNHmxorH2YfDbJtN3fIMjjGjEZgpU2WefS/QO5C4n9gYjsEp7HTVi7GzShOXYRz7DJeTmHAgXYLpX5dBeq2Jq/gNmqNgP96sDSmZOT0h0SeOLL81mTGwzKEFSYVYkLX9/OQVGiYkP/7EmrPymRF5NkqwLs7HEfjkQUdO/mW6Ide61ZGV4M8z9V/TvsEZjBeM/wUW0uQo/+LjGp79ojvDBJemAsxnk1Ls0boBb52dNimtx3fbgxB5/3gl2xO/rYpE3Rj15dxhhd+c6v7vmp51mytR/52rmYZESeIMzm1aR3gJycKsyVBZUmEZcA/bDLUm6DpaLL4TFDf6mn1k5tu5+GBmfnq9vvTztDtsIWn5iPOdKMihcSwKLzfYQkwqF61lA3TS/T6DK6/Q9+msQlqFbzH8H90K/8WAl9F2DlRwg5lCaUFCRUy1q0ST00nVdp2XXli+7S+O2M30SvXUNL+HRzrolka6REKBa51V+4LAhJ0zoFE5Qgx9RRGcmxsD1WIsp/UeTZt5d2wqHpd1qDaMeF88UVCpCy54fZk5pq5TwOimI3POgAuM3UudXMe9vLvYo4NtaNc38Rr+mf9XAN6w/5OeaXzh/bO5gg/7SqQQRZIu/3Cw/gbkgI39+OiIOvLgEden5/5gE6mUqrvZknsdUmRUXBdvWmEgTu5XuP0CFyFWKOf8OTLBnD30xblIeVoRtsv0DGu+t9eh3xxl8yuR9 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8898.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: V+eNb3mI2W1XRlCj/KrGQU9urdV6UpwAqYcddnIaBEFpqav1Q/RCrscZVpBjLYDkMEqeG3iA7st4pSCyi1nF4swmhdhdmws0EuI78amDNozQwMnMZcGGHwRwn20OtaDiWfMxrIKReyQzue4FdZnfhLd5D1Lk+ihMJ8J+83dsUG4kOp7S0WL4TOyjD57ArQPy/t5O38zFW23xKRzEpw3dvZJHFOWYDfdq1TKQ0cmbpN/nZvYMTgXdWFxlD98HRKYLFXqcaWMI8RkkPVaZ0v4TSq0cIWGzAG+Kh8o2lGA/N5ZH3MmybvuOurnINiUpRPnmed1sXmXXN/pBrGnk13F7bfVq44LQ7c0+oVGApCn6DDPv+wBbzE2ClZsXqa09jmzi6E8+H9RBau9H/BPIwDsKypa9J8p3lrUV4yhbNzvR3y9DgQoGqQEI95bwqg85w6wp/rSQGC9P9LSSyDiHijdrERA0/HzIZAGHcXU85Joa5fSFQSZ37nWWyvpG1qQhDi1Pr60V5vQy8Db+At2hfydhlBGLE3FKqRJ3LquHUSnUtkkGOTddtt8Kj8g+tUgDyKoxUd0kCCwd6BEeqKOZ+BFM2jzscMM/GQB48d+zfYDcrDgn6CfF4mRrNniHEIAD3Qy3AUcLcmBUcdhunA93eBSpr9+5qlEK98VwyMExelL/BuY/JJenXKXM3qD2hX9RVym6RrJ6IyYBNSkudXR/Zlf4SESyJw2bNdDODIJpqgH5Si04ESj2KdxIOmUjpWyPbg3P6XJKaNSfXzvhnipK9SDcuiYVpcdTiDa9Bbb9cHkdFhBJdrkIoBj3+EppeSaI/EhBAQm7j0tmXZvdKR7Z8OEQwGZWFtWDPV4lc817HU0yKljXJGlcIJVEjQnhMiKMhQi0ubpAVauwywsXPCwPxQ9SSCkXXciTLGE7N2KJAh9gbBTi+UFsT+12JjW+HvOGNt339JEmI1cRbJOzGfLPEEpmxXy+cgA/mPba+u6UjZU0lCpc4xhjNFQYEwIBdvgLVBA3t+drVHSBtGusVhA94VfQsLLV932/A3uGCs+FVN6LSmrRV0FGLLiDdi+9rFSt0qavIBpHuVDSSo9h6yANeKh10UGmbYAyyfkjjOt8uHRjXYM+2MeC9Skt/ZYdmCziyj2Zhz50vJvAOVtbHAB1mP5JnNr+VHYb5lm6+FCoRFmYCOOFGrtwD8dLPE1bDDF5glUpV07B6MOj4DiAvumqKxA3gL2RltyriAlWS0Civg6yATXdIR8KmP3ZqlaBBU01/Lwy8oDoPFyRvLDIEN5NNmfhgk64bT/WRvvtgp80i+1G82hY46qSdSeHTQ8rPdis0n+sxioML6JFrJ3B6QVw1u0Jw0TbukRKqBsuNizXJH9Qr9s9+AmT220k8qqY6uYQoOFfVDEi5Ao2akpZp4KbwgrNbM63lfZP238MeNSbCCkhufa0zINABJ1Z84g3sWAUiYiV3lQFfSy6EcWgn5uHrJG4nfBW1vUwqAeVu7CHd1F4T2fEdw4h7Ym6ZhD4j2O/Nhf68aQCtlI4xTKZAxwyOnKN3XfOk70dr3DS/GZ5cdYThZeCiaKaUhzcU0xtiJsUe8vjxW/xdl/GQduyHfLG4/kccQ== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d690e8f-b0ed-4414-0f9d-08dd58108a26 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2025 15:57:02.0884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 113m+5dkIn12ZDMvlD0JdVjue1yA59eZ8VTV3qODKfJs2u8E/UGqrienp0UhFnY6FI9A4Ar36YsnA9xlyN6CVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9118 This adds support for registering Broadcast Code request callback with shared/bap, to be called when a BAP Scan Delegator needs to receive the Code from peer Broadcast Assistants. --- src/shared/bap.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++ src/shared/bap.h | 17 +++++++++ 2 files changed, 115 insertions(+) diff --git a/src/shared/bap.c b/src/shared/bap.c index aa4b1aa86..8b5010f32 100644 --- a/src/shared/bap.c +++ b/src/shared/bap.c @@ -88,6 +88,13 @@ struct bt_bap_bis_cb { void *data; }; +struct bt_bap_bcode_cb { + unsigned int id; + bt_bap_bcode_func_t func; + bt_bap_destroy_func_t destroy; + void *data; +}; + struct bt_bap_cb { unsigned int id; bt_bap_func_t attached; @@ -189,6 +196,7 @@ struct bt_bap { struct queue *ready_cbs; struct queue *state_cbs; struct queue *bis_cbs; + struct queue *bcode_cbs; bt_bap_debug_func_t debug_func; bt_bap_destroy_func_t debug_destroy; @@ -4226,6 +4234,16 @@ static void bap_bis_cb_free(void *data) free(bis_cb); } +static void bap_bcode_cb_free(void *data) +{ + struct bt_bap_bcode_cb *cb = data; + + if (cb->destroy) + cb->destroy(cb->data); + + free(cb); +} + static void bap_ep_free(void *data) { struct bt_bap_endpoint *ep = data; @@ -4265,6 +4283,7 @@ static void bap_free(void *data) queue_destroy(bap->ready_cbs, bap_ready_free); queue_destroy(bap->state_cbs, bap_state_free); queue_destroy(bap->bis_cbs, bap_bis_cb_free); + queue_destroy(bap->bcode_cbs, bap_bcode_cb_free); queue_destroy(bap->local_eps, free); queue_destroy(bap->remote_eps, bap_ep_free); @@ -4348,6 +4367,7 @@ struct bt_bap *bt_bap_new(struct gatt_db *ldb, struct gatt_db *rdb) bap->streams = queue_new(); bap->state_cbs = queue_new(); bap->bis_cbs = queue_new(); + bap->bcode_cbs = queue_new(); bap->local_eps = queue_new(); if (!rdb) @@ -7350,3 +7370,81 @@ done: return ret; } + +void bt_bap_req_bcode(struct bt_bap_stream *stream, + bt_bap_bcode_reply_t reply, + void *reply_data) +{ + const struct queue_entry *entry; + + if (!bap_stream_valid(stream)) + return; + + bt_bap_stream_ref(stream); + + if (!bt_bap_ref_safe(stream->bap)) + goto done; + + entry = queue_get_entries(stream->bap->bcode_cbs); + + while (entry) { + struct bt_bap_bcode_cb *cb = entry->data; + + entry = entry->next; + + if (cb->func) + cb->func(stream, reply, reply_data, cb->data); + } + + bt_bap_unref(stream->bap); + +done: + bt_bap_stream_unref(stream); +} + +unsigned int bt_bap_bcode_cb_register(struct bt_bap *bap, + bt_bap_bcode_func_t func, + void *user_data, + bt_bap_destroy_func_t destroy) +{ + struct bt_bap_bcode_cb *cb; + static unsigned int id; + + if (!bap) + return 0; + + cb = new0(struct bt_bap_bcode_cb, 1); + cb->id = ++id ? id : ++id; + cb->func = func; + cb->destroy = destroy; + cb->data = user_data; + + queue_push_tail(bap->bcode_cbs, cb); + + return cb->id; +} + +static bool match_bcode_cb_id(const void *data, const void *match_data) +{ + const struct bt_bap_bcode_cb *cb = data; + unsigned int id = PTR_TO_UINT(match_data); + + return (cb->id == id); +} + +bool bt_bap_bcode_cb_unregister(struct bt_bap *bap, unsigned int id) +{ + struct bt_bap_bcode_cb *cb; + + if (!bap) + return false; + + cb = queue_remove_if(bap->bcode_cbs, match_bcode_cb_id, + UINT_TO_PTR(id)); + if (!cb) + return false; + + bap_bcode_cb_free(cb); + + return false; +} diff --git a/src/shared/bap.h b/src/shared/bap.h index adb531b4c..359147b69 100644 --- a/src/shared/bap.h +++ b/src/shared/bap.h @@ -44,6 +44,12 @@ typedef void (*bt_bap_bis_func_t)(uint8_t bis, uint8_t sgrp, struct iovec *caps, struct iovec *meta, struct bt_bap_qos *qos, void *user_data); +typedef void (*bt_bap_bcode_reply_t)(void *user_data, int err); + +typedef void (*bt_bap_bcode_func_t)(struct bt_bap_stream *stream, + bt_bap_bcode_reply_t reply, void *reply_data, + void *user_data); + /* Local PAC related functions */ struct bt_bap_pac_qos { uint8_t framing; @@ -279,3 +285,14 @@ bool bt_bap_bis_cb_unregister(struct bt_bap *bap, unsigned int id); void bt_bap_bis_probe(struct bt_bap *bap, uint8_t bis, uint8_t sgrp, struct iovec *caps, struct iovec *meta, struct bt_bap_qos *qos); void bt_bap_bis_remove(struct bt_bap *bap); + +void bt_bap_req_bcode(struct bt_bap_stream *stream, + bt_bap_bcode_reply_t reply, + void *reply_data); + +unsigned int bt_bap_bcode_cb_register(struct bt_bap *bap, + bt_bap_bcode_func_t func, + void *user_data, + bt_bap_destroy_func_t destroy); + +bool bt_bap_bcode_cb_unregister(struct bt_bap *bap, unsigned int id); From patchwork Fri Feb 28 15:56:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iulia Tanasescu X-Patchwork-Id: 869355 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013030.outbound.protection.outlook.com [52.101.67.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E3F527293A for ; Fri, 28 Feb 2025 15:57:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.67.30 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740758233; cv=fail; b=G6j0OpyPGnN2MwLooo/Ljq7PwtTa4nwjl58Oj48l44zPUpJq9wP0aFLqE/+HJ4fVhj9zeRI0bx2cL5f7FufE3TYNJSvh/NrsMlpSeZd8tNF8HDIsbjbHUIbOY5eAvRNXGrO+itEmwIGMIdQ+9/Xa0qaSFo7Z+FgJwgXAUOaHb+4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740758233; c=relaxed/simple; bh=oz7DrcEp3tGXvapJyE/OoEUdiTUgewdE4MO75aYqLao=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=rXttOEDWHbBX96xPE63BUVfLmIuMhbzl/F5CAOvAPcHGvdx3bekoqZwC3hpONGv+h1vJbVOXeHTCi88S7GliNnp51mwRpizG11KzhEqd0IOc59GzA6QD9UNPP7rslRIoc1ZAB6jL2AsDrY4yZ+QzkC1dqhHQJjZRKWb2pPiK3Tk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=P6ji8q9v; arc=fail smtp.client-ip=52.101.67.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="P6ji8q9v" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hh2GiaNnO4RYi7A0ow+aojJHpvn1bHe9dhOf4PIleTPGQwsQCGTEf189EVm+eMDis131gqc8UDnSv28AX0YJyrvOSpIbmGZnYFD3aFH52BRsx4TIk//pUOhI+Lh2O/iv71lhvIjU0acmYQoCfc+Opqp8JEAJMEBBRh8xV5lfnckGbUHZw8Y83Ppwkm87hwHykIrg1zosBJlpERu3+aIT4uZCYqTvnvIyZYjE/qRmbmfgx5NOu/8PdDaGru2uJQlY/M8bYppS8NyyKKCBS+aY5RjiP1ePn3N5OOupjBGDxnkS+MoPRvQejezPAvo7MS+hQ4JcAVlkHB99W5TRxKP9pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0blx4qU4oMSl8wfuKKrHuQzH5v+NNkE/oKMjnT+StL8=; b=ED8H/4UDZoEmXzHMzq6N1DV4uNz4rslEZtnTwbNcWHk+jEo9eqQw8m+SDes4rlWbQOkF44tfg1WpA13iJy3E5GDcWbMMjkgdqtiDI0E78YaGIxDZc0XvB896Gtj8oVgr8TBHsdMSyH76ptRHandTeHFYXQMXmSp9m6O+c9IP0Rem0L8dCXkYSVSIHaYLACCGiVOn4JLz/Rmg/MyzEC4RChGupek+Qb+8ffwH/fvLaybXawN1oSVnKQZElhwE+2IoQzc5d3BkuVz7WjW+Y8+sU+3BO5ffJ/T82JtLWDd0xaYn8w6yEDLHWTyh7ypYyaKz+Q0tdS4l3a92xvFQzwWRHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0blx4qU4oMSl8wfuKKrHuQzH5v+NNkE/oKMjnT+StL8=; b=P6ji8q9vS3QE3gYhtGqaMtEdT2NgIKpjG5SAxSdJ1y+h074JUVeAhzFpCSErj+EOWUjBuUIRMKkPyJJvb9rmzp+XksEnWxo86xLmt7art5fIYljVx6fjWTC9zC8aNIR7+zaISHhXerrsYlRmxS3+nJth09C776w6s7ZSUe0zaBOu/38jjC1QnO+EtNzF26LBbnJs4tA1TdsWVYWxPvs8zRrbAIGxEBpEKC7Up+pNd8fWX+q0gjXT26d8UjxWtQlQdUf2PwaNGUquscOaHcH4OupSWroXeE5v4dyTE/TU5wXsRH3zO1LewQMNGWMFAbzu3e66DInT5U0S82ZDNWhptg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8898.eurprd04.prod.outlook.com (2603:10a6:20b:42d::15) by GV1PR04MB9118.eurprd04.prod.outlook.com (2603:10a6:150:25::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.23; Fri, 28 Feb 2025 15:57:08 +0000 Received: from AS8PR04MB8898.eurprd04.prod.outlook.com ([fe80::5e22:869c:33c:9654]) by AS8PR04MB8898.eurprd04.prod.outlook.com ([fe80::5e22:869c:33c:9654%4]) with mapi id 15.20.8489.021; Fri, 28 Feb 2025 15:57:08 +0000 From: Iulia Tanasescu To: linux-bluetooth@vger.kernel.org Cc: claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com, andrei.istodorescu@nxp.com, luiz.dentz@gmail.com, Iulia Tanasescu Subject: [PATCH BlueZ 3/3] bass: Remove interface Date: Fri, 28 Feb 2025 17:56:34 +0200 Message-ID: <20250228155634.57979-4-iulia.tanasescu@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250228155634.57979-1-iulia.tanasescu@nxp.com> References: <20250228155634.57979-1-iulia.tanasescu@nxp.com> X-ClientProxiedBy: AM0PR04CA0121.eurprd04.prod.outlook.com (2603:10a6:208:55::26) To AS8PR04MB8898.eurprd04.prod.outlook.com (2603:10a6:20b:42d::15) Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8898:EE_|GV1PR04MB9118:EE_ X-MS-Office365-Filtering-Correlation-Id: 11ac964b-f251-4687-4ccb-08dd58108de3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: dEFdSajyDs/Bbl/oR/54G74vZuhX7/q6+7K6v0pYs3esU1lK56pYRoqgURS51xft2fulhzvf0yOKKXROq7nJcjkPsHVG9VyPExOTFgwHqtjsFECT6M1ARRNdqWFp7WcW0qSLMGa7EhPF+w8GDrRD/KidVABhnZe2EQdaYc1W66UcuQR/7IbjKE7E06Joh7HpomsVwr/mgkXXioRjlQqMbLe85y3dcEuDc5jJrC4/rD9q2gEglkZgL1fYPgmAFk0gJJ/m1y1lWmd+cf9vGOOP1KWGuKPHmce52g/KvY/LLUbkWWUMnA8vMacqJS9DDAAKOUKST7Fv5W30V9tN1fX5kv3MUBnkmihJr/Zl743sMUqRpaJLJIUQuB4YR4P4V7/9TIU6TnfjrKp6UH83yH1yjlEHwfP1BRHKSEgiN0EhP1VRfqmMPcM5/U3J+PJAR/sWZVD/AC6OrW7juExm1QrgfUU/VyxllY5zRYukceGDoTRzJnobikFKexRE7Hbuq6Y6F8HO35ZgKd72OlP/nZjwEtedFc1emYyRHMRauZDefjntKvlLp9nvss/YYjLKECf1l3MmAr7xdMbL8eKvbb4VQrIsV5lneVifzjpDsFLxhDsn05NdILNrUQpNhP8AvyFVszli9nmP2DV+DGQViEo9RK7lBOXLmYNI9/JwdjIXxJdInTfWpVvtJomrAgldaYfqIl1YjT7+lZ+awnyFVkz9R8NudR3Md07xWUfGMpnbSP68yKYK3ggGWjE85QxPw+vhughws0ot88W3dSVvGvnXmNvUlnpu3iZHuOyxsAYjwOxAf4Tru88smXVEAp3L2eIzwIU5VwFTlXWimmGSA2i9F8J+2YhGxSBBuzvYg0Eu8am4I37IlNbHb1S2kA2wG34czi7lJsSNzuHE2ZXKEyTAM1KRvok/U/kwyGBvkiv5VX5riRx3jAscdOdIv38URcOJwuiAA8e1M7nQEHpTcEXZ6Cfi/wPKsW78rGlyuzkDRqOvG5Kh62uRo/VWDCrtv+EXN9q86pKJzbsD8clWzP23W9zzfxDCCkk4iC/OiP3YIo05oP4D567mo+G6lgvrNdRh8WH77VGvaWq+Rt6TB9VcBf7P+z4mtm/cQYsfi4tZUMkoV22Vih6qxTI2UOaXMVTCNf54k9lgKnKmONqdrzI06zhUQ60IAUYJFQd3oFN48eoIX3CPVdg4FaYmPjS3Ht0TE5DsBITRe3gHX/CmSnnPBgJF1Mgwh0UEzw3BC+N8Ae+bdZQeW1miAYHNO2M3pVgCmZPfY8PqDq9YLWaBlZdNi9DJ+U72DJt6qVPUdfS3PKXMkqg6QFFYfo58sszAeOCsK/+MRAeGFNNptxEPoPqXEVnvSnrJrtcPD0nD0hnf+kKMCOOrkFgitcbCt7p8doT3 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8898.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +L1lNyp7ChSCOpc4oPj+9xbm0qO581Ah8rLDI+RmGagTgRuHKCA+V8ai4l0l1zmAImrxyzCoSxbxaXpCIDRxXd8/fK37fuzELGaRY4GpdDm8y/dShnbspn9IsW8FVgzpkQwLLf1uCuvdsu2L9bcNudXOQW3wPzakQeWH2yv99I9/9wz/6nr9lRBef2BYceRrGBuaPw/IYv1HqFeCATb/KzlzZHP/mJfH7OvWJBevNhxAFsMpOMNn7BUqIO6pWFyacG1b5lZ357h9erVOJ9caUgW51WwR7ofg9HEf2bRVAEe2eu1MQUbGlMbAzjdj5nTiLirX7wfp0v0d2/AgdikX4mMSzmSOB3Qb6RGBpmX8YMgKx7mjx1/TaP0WXFE9aoYEIiSTkCWeHsCs0dLPFfLoE+/0uUZ2oyRSCdtKzOiOESsrUKT2WmKD7C5VNU+CLvvzoEYmIg7TgwFtHRDF8FYT4j+F11VuzTr4ZezxeA6rDokfF5OysPkkmnevaybNrCiQBGYQPlZGc6tLWbmdjYcG7AEiGruV3uaFLEqTf9ojerYayC9CTF0Wc+Lnij8UgJcb5bJNlcTqLjYw9g8XYsSRa8wzOn1qK+wjLQEjTt6MyiM4rxqBzOIPPyGju1aEIBTLJxDWl7lmA/MlJdu+w/qLoHU6jNKeSVeGB6l+owLbvZpG/GufZZRXEFrbWDKDLmVKT3svPWl52eZ3oqiFNKTOdvaI3/iHOLk9UUcFDxOk2MTWygt+teCR9FXkVzOE1MwrnIXZux2XAaDtiJDWDpISr5ETKQkdkp+lPq1JX0sj3uTkzxRWQjweNBaEbfk4Bl/rPTBUIGtx7o8yxDfyVFD1ZEDmNw1alUwSDK5ze/GQdv/HAq0PgT68eTpvB8WzIOUEFA7a1/RRhyirMYZNs2ESMp5B1c3JBj6h0fOvvlb3MqHDGZW1oz/q8evCMBJLjuA80ty5EkxGoakOTQtBNOLQijHKnLnD2paMXVvSemuGMWEYaNYMjnuapmh8yj4bSkfRoNcD+kuMdQmiiREn2Nby6EbePzqd+EKFzlZC/icnHI3F3Q4nMdWcXZxvAP+ixXEE9d3dXzZqmcpRbn5k0CZWx/fr2snJHlyg3Ylar3WLa7OirIksdIDgjf91W+nNVMVwW5lqjmCXASSPE70635Q3P2iu/b4OSZ826GfCk0YUkqMzy6UsdTRm/jfD335FuMhyCLMZNxJ8JX/0F/a0o+Klxad/O0Y0TGFPmdH0KCf+eRLYcVttpLwZcyn/mXFs7kYODwgjtbOE/qF6WQdjbINz1pCWETZ4aBNZvEMkfeObVXmpngFvm6jfN+FI5v5Kn0GjxMMVcQ++n0DtFupkIcrek8f53+LJ/pTzcah5suqMAB6IzndLfhWnshXDazy/PStlWpTFywVnbpIFBjIOMgk63lP0A0SXjOLpbhMDHSnttlCdrYGOD51Zoizvt5bFrh00kBfMRT0aSMzfqyF+Nh88abah84z/FTgefZpASTd4QSdddas9huKuWVdey0cKbQox4IHtGQ8mVcpu0p8+rqJBEDpuoRtLghuhj4Lywq0C+zWlTBVT0ckL8dFlZXp8uaTngY11I9A5Oqc7FI+xnHZ52Q== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11ac964b-f251-4687-4ccb-08dd58108de3 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2025 15:57:08.1765 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bXY0CbR1TzBPIarlGiavTKou3+KWLmG+d75ieA9Vg4+LSw87CP8F1Z+32gMHgRmefjkmBrxF0dDXTeDmKI7vJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9118 This removes the BASS plugin interface, since plugins should not make direct calls between each other, but use the shared files instead. --- Makefile.plugins | 2 +- profiles/audio/bap.c | 1 - profiles/audio/bass.c | 1 - profiles/audio/bass.h | 9 --------- profiles/audio/transport.c | 1 - 5 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 profiles/audio/bass.h diff --git a/Makefile.plugins b/Makefile.plugins index 81cf3155a..43e665432 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -118,7 +118,7 @@ endif if BASS builtin_modules += bass -builtin_sources += profiles/audio/bass.h profiles/audio/bass.c +builtin_sources += profiles/audio/bass.c endif if MCP diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c index 37168e58c..0489f6655 100644 --- a/profiles/audio/bap.c +++ b/profiles/audio/bap.c @@ -57,7 +57,6 @@ #include "src/error.h" #include "bap.h" -#include "bass.h" #define ISO_SOCKET_UUID "6fbaf188-05e0-496a-9885-d6ddfdb4e03e" #define PACS_UUID_STR "00001850-0000-1000-8000-00805f9b34fb" diff --git a/profiles/audio/bass.c b/profiles/audio/bass.c index ec5b88ff3..44320a78a 100644 --- a/profiles/audio/bass.c +++ b/profiles/audio/bass.c @@ -52,7 +52,6 @@ #include "src/log.h" #include "src/error.h" -#include "bass.h" #include "bap.h" #define BASS_UUID_STR "0000184f-0000-1000-8000-00805f9b34fb" diff --git a/profiles/audio/bass.h b/profiles/audio/bass.h deleted file mode 100644 index 32c7e4def..000000000 --- a/profiles/audio/bass.h +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* - * - * BlueZ - Bluetooth protocol stack for Linux - * - * Copyright 2024-2025 NXP - * - */ - diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c index bc7ee6e45..3d1f55b70 100644 --- a/profiles/audio/transport.c +++ b/profiles/audio/transport.c @@ -54,7 +54,6 @@ #include "media.h" #include "transport.h" -#include "bass.h" #include "vcp.h" #define MEDIA_TRANSPORT_INTERFACE "org.bluez.MediaTransport1"