From patchwork Tue Mar 11 04:08:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 872422 Delivered-To: patch@linaro.org Received: by 2002:a5d:64ce:0:b0:38f:210b:807b with SMTP id f14csp1300483wri; Mon, 10 Mar 2025 21:10:17 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUCu6L42kzOjbF3B4X2bCYO7Nc4sxzL985rgwgxCHBXV5028GN6Xpo8Zygcg8Vodb6EKxRLhQ==@linaro.org X-Google-Smtp-Source: AGHT+IEUkWsG4wjsR1MqTj605hI+RtgK3J7KEnlu2r0ouro5aVemfYvU+hutE3hPBU3ZrQZEeW1d X-Received: by 2002:a05:622a:53cc:b0:476:704d:9a49 with SMTP id d75a77b69052e-476704da662mr148860241cf.5.1741666216967; Mon, 10 Mar 2025 21:10:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1741666216; cv=none; d=google.com; s=arc-20240605; b=fgedqhZborhXoT0Q0m+peq/XSeH1tDqu4lAgCgH0T6Rn/JPuEpGH89yBFBGZkzI27W yxtZb05BBNsMdVRKve/NxzKLiIKzFZoiwwWPN2x8Ywuf+3PKjBxgU11EbNcFUsdv1P6z rx+wzrvs44XaUpSIoKFa0HuCgZnpWe5i2op/B7heBf38ABBWIdgqc27cLIz1WdkS7A/Q yffwCStmo4I/NbnMps8QK3gieFeEEaa4D9mpsCefwhCw3SJxR2daqNjmgNi17B/KMa+9 3NbTN4a79Kty6/JlKcwWDFnUWbCEDHULd36u8O6QWxB77U4L1ZNIQqVRq189kj2IYJal WaNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=949DeBQijWmgHqYCdDdupcSTn3rDdND8nLqwkILEwEI=; fh=8iGvHhDGxI79y3+vtwcOV7/KUtMLTW09ehmikEFqvLw=; b=KMQ9CWpaCUeoFCDRrPuwKWaw69uc9wzT2bF7qro+4PkFrChxDpvf8tJsWGkLkFCbFv 9e57AcEKX1noa4uGg86ANGdMpK5PlW3dae2Uma3Q4zrzOas0F65p01+cqPhBy2LZ0xQX mQNKDBaoigVFTlcHIYWQxoTZPnPzNxBvnHBK45Cd0i/TKx1mXf0OLDSqRpZ7zHuMOvc2 BI1gH8t7D6irJdm2+bnstUnkvjX4QFDwYkAFJ+e3CAXfGGaC0LmlM3wYmWAstkZnw20L ovRTAbbR8alXPqEP8sYXbTrEB4ID+v5Si6lQuvEo5pzYf5qf8MjHVtCjFlup4ChtM6y7 DDrw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bIDzTMg5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4768cd2529asi30969651cf.277.2025.03.10.21.10.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Mar 2025 21:10:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bIDzTMg5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trqvv-0003Ve-Ub; Tue, 11 Mar 2025 00:09:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trqvP-0003Hu-TT for qemu-devel@nongnu.org; Tue, 11 Mar 2025 00:09:04 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1trqvM-0006OK-7S for qemu-devel@nongnu.org; Tue, 11 Mar 2025 00:09:02 -0400 Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-2ff694d2d4dso7130739a91.0 for ; Mon, 10 Mar 2025 21:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741666138; x=1742270938; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=949DeBQijWmgHqYCdDdupcSTn3rDdND8nLqwkILEwEI=; b=bIDzTMg5oXhqPdANqq0yUjjZcrN5rnVdj5/OPG7J0z3Tp1I2k2OsPHREKF+XcXXKSi 6bhP/DSrYWmfgAesqrnFQvxJk9IeIK/M4aD/tKOCBUSVofuM6hUBxXHlkOicNe4xDVnm JlIWFPBHWaJjWKt9egYp/OGnzHJ3HpZjcCl3BZrM1Yg85E9qk5ZyTju/TkTL2jOy9h6Q Li4LEGcWCmVqZD5Ts6CWjai8eA+zMuAu+QPm0394J3oDd903sUqX3GKcmLzFq88/BTOH KDxl943sIBM6mZeP0uKsCG5UMD2Ux+H8ntFFgVADYVfzFilkzMDzjFoKKE9EfDb7lE+U fVWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741666138; x=1742270938; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=949DeBQijWmgHqYCdDdupcSTn3rDdND8nLqwkILEwEI=; b=h0EqpQ+c1KK2hQ6NZrJGHeJ37BZgn+s+0ssYjTOfEE8cRv8jaorE1etMyyrHW47QBc OHK5GPOxM3tS4GAQp439mhivFw5JAf/WfZXie+5y0+RI0L976YBnKtb3xQ+H94ZynSaJ VcpAfZwAL5juJeebE//gvL4cpOLUKaLMzmJ9GQ2bSav7HVOT6D/rU2cJMCYWZ+YH2Utg JGB9YZ+zz+cCQxuWnUNhgKERAoaDSL1UrVW0dCtHtlkjJE4ZBINxVjga1JkDlf+wdMu+ mGNNqyktoL/ukOAM57IdWXwuBNFsI1SmhhTmqpJXvg7XRSAb66+kLwx6Hv5Po8GOKKa4 nlxQ== X-Gm-Message-State: AOJu0YxXEAGkrrkrHBISEGWXynK2mIYCdAw+iV9I67T030mdARpqiwQI Z6NR7O3EkCIJz+W5rBIQGvkVKapXiUJmB+ELpATUD4cpINSgfrqsSPhHcn7RlBItsnG/XkWbKk5 hpEY= X-Gm-Gg: ASbGnct4X7IP8v7VgFtopIsqAH/u6G2NaRg6RKdFZSOl51J90n1ItjFPWL7LG37z/uk XhLlTwmJcsrcI2sA63ptBR0dm5PIqA127xJNEvCscP85CEAeRh4CV05NjCNWZm2Nj4fF2o5SFxz XSO4MUOHOc1gYjoqkHCRFRdEuA4K8a7/nybO1zuZ+/3pLvKoK99Q5fFfxU6Gw9GGkAEpZRccZEN itGplmx2+xSlFaW400x8k4JL3QTmuaFoyeRublglTd8wKPE9AaVWVOMDRkDsnvmN0LLwOdd/1f+ Hcm3eT2XdOGREFq2TwjOqtSMpzZ7M7j24rqxDPBTB3fJ X-Received: by 2002:a05:6a21:b97:b0:1f5:889c:3cdb with SMTP id adf61e73a8af0-1f5889c6dc7mr5899820637.8.1741666138527; Mon, 10 Mar 2025 21:08:58 -0700 (PDT) Received: from pc.. ([38.39.164.180]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af28c0339cesm7324454a12.46.2025.03.10.21.08.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 21:08:58 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Paul Durrant , Liu Zhiwei , David Hildenbrand , Weiwei Li , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Paolo Bonzini , Richard Henderson , Peter Xu , Nicholas Piggin , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Alistair Francis , "Edgar E. Iglesias" , Stefano Stabellini , Harsh Prateek Bora , alex.bennee@linaro.org, qemu-riscv@nongnu.org, manos.pitsidianakis@linaro.org, Yoshinori Sato , Palmer Dabbelt , Daniel Henrique Barboza , Anthony PERARD , Pierrick Bouvier Subject: [PATCH v2 01/16] exec/tswap: target code can use TARGET_BIG_ENDIAN instead of target_words_bigendian() Date: Mon, 10 Mar 2025 21:08:23 -0700 Message-Id: <20250311040838.3937136-2-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250311040838.3937136-1-pierrick.bouvier@linaro.org> References: <20250311040838.3937136-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/exec/tswap.h | 11 ++++++----- cpu-target.c | 1 + 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/exec/tswap.h b/include/exec/tswap.h index ecd4faef015..2683da0adb7 100644 --- a/include/exec/tswap.h +++ b/include/exec/tswap.h @@ -13,13 +13,14 @@ /** * target_words_bigendian: * Returns true if the (default) endianness of the target is big endian, - * false otherwise. Note that in target-specific code, you can use - * TARGET_BIG_ENDIAN directly instead. On the other hand, common - * code should normally never need to know about the endianness of the - * target, so please do *not* use this function unless you know very well - * what you are doing! + * false otherwise. Common code should normally never need to know about the + * endianness of the target, so please do *not* use this function unless you + * know very well what you are doing! */ bool target_words_bigendian(void); +#ifdef COMPILING_PER_TARGET +#define target_words_bigendian() TARGET_BIG_ENDIAN +#endif /* * If we're in target-specific code, we can hard-code the swapping diff --git a/cpu-target.c b/cpu-target.c index cae77374b38..519b0f89005 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -155,6 +155,7 @@ void cpu_abort(CPUState *cpu, const char *fmt, ...) abort(); } +#undef target_words_bigendian bool target_words_bigendian(void) { return TARGET_BIG_ENDIAN; From patchwork Tue Mar 11 04:08:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 872423 Delivered-To: patch@linaro.org Received: by 2002:a5d:64ce:0:b0:38f:210b:807b with SMTP id f14csp1300517wri; Mon, 10 Mar 2025 21:10:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVj9A34FfOmzu107SLrEg18TX5NKNqNaYsUeenGGQFwIo7jG0r76YOppiW2FqpDkQKoeD0S9g==@linaro.org X-Google-Smtp-Source: AGHT+IE5M8+Uc3W7hA1fBScpYc/6J1/GCM0Yoo2PtHp2TIq7nuE5FK/DLMnakneOImwjO+MCjJTr X-Received: by 2002:a05:622a:1983:b0:476:6d30:8aed with SMTP id d75a77b69052e-4769965c5cbmr36586271cf.49.1741666226933; Mon, 10 Mar 2025 21:10:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1741666226; cv=none; d=google.com; s=arc-20240605; b=J+Xxsa8K/Ec7JKwaQeM7uiuAJ9reVv704LHp99+ZllQSbFjEq9HaA9sxOV6zBkRsA2 AiPGQfvPLp0/ZPu+zLaT1CmBIb7wtqucmFihhX2wSAqidOsXxwelguCkXyVY4jCxrKqb wZJKHD3ckdihpwZOHNydb13vCa2jSdTtlbLazhfkpYCMTap7UbuQvmmsm3e9+cFhe5Wl dKxhn82T7ggaM4jgzh7G+p2xLcNezYCvU7hivBuCc1vnqZy3WGF65biBRUloqnKjC/Ol q90zyJp1gb5RGxQrKUFMa0kxPzuVSR0OBB9nFjZJRAXZyf5MzqZQW4/0eJT17ZnF+L9q duEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=KTcsPgfp4qWHKI5IiGC/xRJnn7HmZtcbIn5ZIF7f/ys=; fh=8iGvHhDGxI79y3+vtwcOV7/KUtMLTW09ehmikEFqvLw=; b=ikaILlVAq+nSR9DJ8fsZGp8OFmkJQZ5FOimv0xuOKQ3v7BhfW25zFqdmDyYz1IqK3j dijAbm2k7ioCGe394KH5IG0a8cUyVy45r/mkGU8sZNxClbbsDnwonduinGRrdjnp64Vf 59Qaal1vSP3AqNXUtPIsq4/FiTnFCDXT8fkW+95YrjErMkaKzupcbUwGjmWiVfkzZB7H symk1HuHaAoDfeDdM49S7McezKhNCpp4l3ucxzRESVbhQsw/tE18voTN9uXp4TTfF/Mq g1Qhxzb8NGfzHD4DvVcVzMxgp38z+yDfoIX9Fn4MFQ3ruYOh1YZyuGl4hk44axEWH0Fr 0NuA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MeHZdvfc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4767bdc80a0si45564291cf.128.2025.03.10.21.10.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Mar 2025 21:10:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MeHZdvfc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trqwT-0003nt-8g; Tue, 11 Mar 2025 00:10:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trqvT-0003J8-23 for qemu-devel@nongnu.org; Tue, 11 Mar 2025 00:09:08 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1trqvO-0006Q2-Ui for qemu-devel@nongnu.org; Tue, 11 Mar 2025 00:09:05 -0400 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-2fec13a4067so7695675a91.2 for ; Mon, 10 Mar 2025 21:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741666141; x=1742270941; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KTcsPgfp4qWHKI5IiGC/xRJnn7HmZtcbIn5ZIF7f/ys=; b=MeHZdvfcVoAs6k4sTWtn1uowH9CceIKI0ogUH4PNDDE4OnT+rchLrvBg3rIlJc+/td WSg1Ap4MbjmryKSLVQJW2mWcelxtiqosYMgFVq4qKPDTBlzchJE33ZuB7CqhR1obZNA0 fQZSqpWyU1t9sDT5uyWLMr25fIqM5PxRaRWPN3rmbuMp+ee2pxChX6AylG7C8N/nQEhM 5cgPvSCrifmoBJ9Fqlcrmty7m7v8yVt/ETv6tSqHbHMwFUg4expI36Il/p8DfQFCUuGy rptfBgyncV8fuDB7qgNj78Jl5vOJYkirh6/+e3IwTjIhKrGpbeM00T2SN/4aCdPNRviX r/uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741666141; x=1742270941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KTcsPgfp4qWHKI5IiGC/xRJnn7HmZtcbIn5ZIF7f/ys=; b=i87gViZnK7h2ReikT1kPo18RYZQtwWAZREVFAvF95QUbObBmdy8lWQtBOMXOO5axBG fiAAAEMXu2C91fo4VZfhvvsvthvFWqGZhQJgsBNClOdfzRGrxkzCAS4uWNMqsYX0coNt fyWWNfXT6eIrw25M0iUJkPrP5NSri3pbtgSskOSatlz8Mi8iRQKie/zsDv5wHJNR/f6F Pp1L7Q+idj/PAvUORd/DQ9hK7R4vRgBPynwXno5YwcRa5+cRogkj9JKcOvtvUxW4ynFU YTcqa/4+wuhZxV3SAntpAvxs1M17gOG6sdEcZoDKsXmw92inH5ipuGkV93mKJQB13tGa loMA== X-Gm-Message-State: AOJu0YyFmZPXgk/MMuY0PS4nWQ7FvZM/GBMgqlp1n7lRZ5LKNUeBIq+1 3YSfuyASBNRoAdSVgoKLLWZV+wtPUb/ks+s0tZh+ZKGisy2GDy/q80za8xoO4wsm8/MhsRmj5dU aOtw= X-Gm-Gg: ASbGncu/L2dB0jvmGVYQm5KF9rIGxnZEH1ZIfuGIwPQkxO+bPfD8m8nCuTwHAp7y09M cezZnhHxznka5vumzdCI/OHMlsk6et14j4iidbYWeaOobFF4cGd3g/3GXPjf2SqFhjsUlnvzxGO mWFs9ss/0/PvwNJ9lMLqcxCDFjOWW2YyfILIu/Fvs2Gejb4P1efZ8Rpvp5vwIDzJ9ashy1u0C20 zZjVuC2oCs2l3WTIfbS3HQYebKK08BGrNOJQKNFkLVxm/R/yP62khvLLkj2lRdD6QnyRtPCv/SF oszjrDo/E4LcovFs4PcVlGNwJLTb6Vo9VyPpHUQfRgc6mGlvd+NjE1U= X-Received: by 2002:a05:6a21:6b18:b0:1ee:c7c8:ca4 with SMTP id adf61e73a8af0-1f58cbef8a4mr4223140637.36.1741666140734; Mon, 10 Mar 2025 21:09:00 -0700 (PDT) Received: from pc.. ([38.39.164.180]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af28c0339cesm7324454a12.46.2025.03.10.21.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 21:09:00 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Paul Durrant , Liu Zhiwei , David Hildenbrand , Weiwei Li , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Paolo Bonzini , Richard Henderson , Peter Xu , Nicholas Piggin , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Alistair Francis , "Edgar E. Iglesias" , Stefano Stabellini , Harsh Prateek Bora , alex.bennee@linaro.org, qemu-riscv@nongnu.org, manos.pitsidianakis@linaro.org, Yoshinori Sato , Palmer Dabbelt , Daniel Henrique Barboza , Anthony PERARD , Pierrick Bouvier Subject: [PATCH v2 03/16] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h Date: Mon, 10 Mar 2025 21:08:25 -0700 Message-Id: <20250311040838.3937136-4-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250311040838.3937136-1-pierrick.bouvier@linaro.org> References: <20250311040838.3937136-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org They are now accessible through exec/memory.h instead, and we make sure all variants are available for common or target dependent code. Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Reviewed-by: Richard Henderson --- include/exec/cpu-all.h | 12 ------------ include/exec/memory_ldst.h.inc | 4 ---- 2 files changed, 16 deletions(-) diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index e56c064d46f..0e8205818a4 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -44,18 +44,6 @@ #include "exec/hwaddr.h" -#define SUFFIX -#define ARG1 as -#define ARG1_DECL AddressSpace *as -#define TARGET_ENDIANNESS -#include "exec/memory_ldst.h.inc" - -#define SUFFIX _cached_slow -#define ARG1 cache -#define ARG1_DECL MemoryRegionCache *cache -#define TARGET_ENDIANNESS -#include "exec/memory_ldst.h.inc" - static inline void stl_phys_notdirty(AddressSpace *as, hwaddr addr, uint32_t val) { address_space_stl_notdirty(as, addr, val, diff --git a/include/exec/memory_ldst.h.inc b/include/exec/memory_ldst.h.inc index 92ad74e9560..7270235c600 100644 --- a/include/exec/memory_ldst.h.inc +++ b/include/exec/memory_ldst.h.inc @@ -19,7 +19,6 @@ * License along with this library; if not, see . */ -#ifdef TARGET_ENDIANNESS uint16_t glue(address_space_lduw, SUFFIX)(ARG1_DECL, hwaddr addr, MemTxAttrs attrs, MemTxResult *result); uint32_t glue(address_space_ldl, SUFFIX)(ARG1_DECL, @@ -34,7 +33,6 @@ void glue(address_space_stl, SUFFIX)(ARG1_DECL, hwaddr addr, uint32_t val, MemTxAttrs attrs, MemTxResult *result); void glue(address_space_stq, SUFFIX)(ARG1_DECL, hwaddr addr, uint64_t val, MemTxAttrs attrs, MemTxResult *result); -#else uint8_t glue(address_space_ldub, SUFFIX)(ARG1_DECL, hwaddr addr, MemTxAttrs attrs, MemTxResult *result); uint16_t glue(address_space_lduw_le, SUFFIX)(ARG1_DECL, @@ -63,9 +61,7 @@ void glue(address_space_stq_le, SUFFIX)(ARG1_DECL, hwaddr addr, uint64_t val, MemTxAttrs attrs, MemTxResult *result); void glue(address_space_stq_be, SUFFIX)(ARG1_DECL, hwaddr addr, uint64_t val, MemTxAttrs attrs, MemTxResult *result); -#endif #undef ARG1_DECL #undef ARG1 #undef SUFFIX -#undef TARGET_ENDIANNESS From patchwork Tue Mar 11 04:08:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 872424 Delivered-To: patch@linaro.org Received: by 2002:a5d:64ce:0:b0:38f:210b:807b with SMTP id f14csp1300518wri; Mon, 10 Mar 2025 21:10:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX/v6Dwgi7SaqBiM4z7e/zKOrLNxbuWnXAkriDEDr32O17k5LMBia4QM4MhcXgi0mMJ/W2F/A==@linaro.org X-Google-Smtp-Source: AGHT+IHmVHdklGAcPKnQydd2SBYhgv9fqJ+VojJmUUDopfqTOResv2PcinYkVC5pecnjz/ZNOv8T X-Received: by 2002:a05:620a:260a:b0:7c5:5229:2f13 with SMTP id af79cd13be357-7c55e90fe2dmr423518685a.36.1741666226994; Mon, 10 Mar 2025 21:10:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1741666226; cv=none; d=google.com; s=arc-20240605; b=HpGov2iWcOy8y2NFL/16BTf7j5JNbpYo3JFtrGii9+0v3aI0MBdvM8/PC5kUErsU21 E4ArUdMG0MzlRAJgp3CKK4bR6xyo+Nz1Cc0J/keqCEuD6tMZe/LHMfV8D3DZ3ESyo2oZ whwXXipC/lKBWHYXvi+9AoH14z1/phFezMA2NRfgxvd0jRMTekrn0yOM0mTuRLTlqLlA 7vDMCdrjAzEfyY5bAcSnsYlEv8v9XhFarD6p+nn2hPaGHEowTQa0yF2qIO+vnl7j1lS9 GGLc76K5weLgDJMGSOB4uwq3cWfi4pzb5vzpDWG664H1xiFekQeZLQp3WlzcvfoaO0P3 E1tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=igRm5DauylZU7kF6A9LJbRIXn+glPoGkFsEjcODvlvM=; fh=8iGvHhDGxI79y3+vtwcOV7/KUtMLTW09ehmikEFqvLw=; b=dxW3aExC/JesWoLBcj8CqXUhz3exKFomR/nSKMPpq12qom+O37MMClV8Zzf47jopbk h9qolCcVfKe2wlYGWDV2V/Nb4M8+a1+LMDJIZ93SUXNIEn51ovpTtwUNBAGbCd4NM4v+ XkOM+Qr3+zeIeMa+Cjn4WbnDcEiA06CkTeoZaq3FXabEFoXGH5eZzO1yxnEwK3NQbtEF vA3WuUPh0bx3+lduwZ5lnfHyTEiOpdu3d+RSGwGirbAlYkM+E0af6mvowUxSyWLugzPa g7sIbxhZqpIn2UCnJIFOyYrzbvETREFsEdu30M2jE7lsLLqQBWKMXKYVX19e33ZNaT12 HZFw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LaAhm2BV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c55396afddsi321621385a.152.2025.03.10.21.10.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Mar 2025 21:10:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LaAhm2BV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trqwM-0003gV-Tz; Tue, 11 Mar 2025 00:10:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trqvV-0003Kw-Hb for qemu-devel@nongnu.org; Tue, 11 Mar 2025 00:09:10 -0400 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1trqvS-0006R2-PE for qemu-devel@nongnu.org; Tue, 11 Mar 2025 00:09:09 -0400 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2fec13a4067so7695711a91.2 for ; Mon, 10 Mar 2025 21:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741666143; x=1742270943; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=igRm5DauylZU7kF6A9LJbRIXn+glPoGkFsEjcODvlvM=; b=LaAhm2BVRNUDJAYX00fcWJKDpIVK4g+BjUmoxtIXm6ldMF5aSksYUBkz+CQ4eVqIgY lv3RxX3+cBQY9SDKwqDcNc/SihQ7UV7/a6WTkoCraOiiLO4HOM1IQy6qKQDHda4PZZa/ TzJYUuIxt5rXw7UjqoqGr66iZ7+zLw1eeK53I0QseZuwdiRj8XZkdQPyyqu2j/phsix4 TimnQ512Boc1dSmtw2vj2xpwW9OZfvdp8c3OWGv9qfw8B1CvR+N0V5VL4DAF626E2YyA eK32QV+JzmvE/9lMzHmi1RKyum5mPh/CSJHXnxANTVyZSVp37XpBbCCkHNTMwXh54qrH o+uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741666143; x=1742270943; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=igRm5DauylZU7kF6A9LJbRIXn+glPoGkFsEjcODvlvM=; b=VxeZAPtRTU1kAaF/PuMtr2R72OVeC3ZF4MmGFu38T+AKyHw3U6tLlbaE1sBologciw y0wAfoKPQgaZpPNltS+H47aJA79ZNkooA4i6AmayNwSfnmvWPFNMCXdGR/J3qFA4GH+i tK5QNvM79pDvBcundXsMftkAMASTsuFJV6mD4jfmTL6d+m/H68E4F0DANT/kvd87QzSy X5JsG1jgRMePoDsYC1nvF9d3gdYsuB9REsPgA2efkB3gfm+k0v1//+SOYXiczg5LkkNV xwsjIUHw70PIh4cBNaktE2mEX0KbdTrEKu2Cn4Op72G9zyuWl8DS1+Nk5tBANC527lXA rSVQ== X-Gm-Message-State: AOJu0Yy6w0uEWTAZLBG5C+6zlGwhEuEkciQ3ci3mz/furFdm9MAbLoHZ 3/Q37iIfu2yecv6n5CRmnBvP9H8ZSTJBA4jC1sOTCUyGXh3PjYygZsZ4iCwzeICqjAVXBPs+dnX NlMY= X-Gm-Gg: ASbGncu4cVZW1eJMHgdaSwMEm2TkpW3Wf4hElvgruoGp60/nB7DzJGeIHSpbRTAAZXh N+P/BJIuPWWNV3iGcwYec6FwVkSUKCL2pqlu6FHOXz5CbbZFhMt3WdnzrJId8F49v4uoH1NpuQ5 +svT/PlaszQKhGBC5HYvuLkVH0UnR4w6E9+CueV2cWCfIcsGzFk5PTn1pV/A1iUoSzVAe0+6X0j yBRNOR2GwigP/QJre6U9kIBitOkX95qB/TOE9mTchYyTL9UrxqHDp9PN5KLAY+yIZWfXi9ys7WM cB0IGFuZZLaCTBwN9yDQB9LnyMPj/8UxcCl9HPGCjOEF X-Received: by 2002:a05:6a21:3a85:b0:1f3:40a9:2c36 with SMTP id adf61e73a8af0-1f58cb20502mr3303668637.10.1741666142929; Mon, 10 Mar 2025 21:09:02 -0700 (PDT) Received: from pc.. ([38.39.164.180]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af28c0339cesm7324454a12.46.2025.03.10.21.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 21:09:02 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Paul Durrant , Liu Zhiwei , David Hildenbrand , Weiwei Li , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Paolo Bonzini , Richard Henderson , Peter Xu , Nicholas Piggin , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Alistair Francis , "Edgar E. Iglesias" , Stefano Stabellini , Harsh Prateek Bora , alex.bennee@linaro.org, qemu-riscv@nongnu.org, manos.pitsidianakis@linaro.org, Yoshinori Sato , Palmer Dabbelt , Daniel Henrique Barboza , Anthony PERARD , Pierrick Bouvier Subject: [PATCH v2 05/16] exec/memory.h: make devend_memop "target defines" agnostic Date: Mon, 10 Mar 2025 21:08:27 -0700 Message-Id: <20250311040838.3937136-6-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250311040838.3937136-1-pierrick.bouvier@linaro.org> References: <20250311040838.3937136-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pj1-x102c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Will allow to make system/memory.c common later. Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- include/exec/memory.h | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index ff3a06e6ced..60c0fb6ccd4 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -3138,25 +3138,17 @@ address_space_write_cached(MemoryRegionCache *cache, hwaddr addr, MemTxResult address_space_set(AddressSpace *as, hwaddr addr, uint8_t c, hwaddr len, MemTxAttrs attrs); -#ifdef COMPILING_PER_TARGET /* enum device_endian to MemOp. */ static inline MemOp devend_memop(enum device_endian end) { QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN && DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN); -#if HOST_BIG_ENDIAN != TARGET_BIG_ENDIAN - /* Swap if non-host endianness or native (target) endianness */ - return (end == DEVICE_HOST_ENDIAN) ? 0 : MO_BSWAP; -#else - const int non_host_endianness = - DEVICE_LITTLE_ENDIAN ^ DEVICE_BIG_ENDIAN ^ DEVICE_HOST_ENDIAN; - - /* In this case, native (target) endianness needs no swap. */ - return (end == non_host_endianness) ? MO_BSWAP : 0; -#endif + bool big_endian = (end == DEVICE_NATIVE_ENDIAN + ? target_words_bigendian() + : end == DEVICE_BIG_ENDIAN); + return big_endian ? MO_BE : MO_LE; } -#endif /* COMPILING_PER_TARGET */ /* * Inhibit technologies that require discarding of pages in RAM blocks, e.g., From patchwork Tue Mar 11 04:08:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 872426 Delivered-To: patch@linaro.org Received: by 2002:a5d:64ce:0:b0:38f:210b:807b with SMTP id f14csp1301350wri; Mon, 10 Mar 2025 21:13:47 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUmuyqSIgIzgUeAsGgI48fzuebPirmS6jmqC9BN+gg+Q14+Rv8RDjs1ZH0rTZJhlBU9hlER6g==@linaro.org X-Google-Smtp-Source: AGHT+IGWQocxDtJLFQJcEPdQlBtNumBHM2E0Ee6+er9n19opbfBGFXMx6U5XXyCK8Z+jHFOYkQOa X-Received: by 2002:a05:6214:21eb:b0:6e8:fcde:58d5 with SMTP id 6a1803df08f44-6ea3a6a9638mr35629706d6.42.1741666427517; Mon, 10 Mar 2025 21:13:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1741666427; cv=none; d=google.com; s=arc-20240605; b=h2WkLvUe8mZp1WXEYoS1Ok9dwLW1qakbLhkRTL13kfVlhjUaexVqyIEE9vQmmdWQTo 61SRwqFTrRppFG/A9rXbpKRs+2zzJDFsUGEYmTVGVnd58mM/wBohD3Kcy3+mtEjU4WDM 54trIZNCz9jTgLaeVauG8b/S/adn8zTABa2WP5wPnVUAWSFnIzvNRZND9SmVcfOWPe3X lPRBs5Jc9TO0Pj72zO8E/Y5vqwNp/Lg3qq23SbBJMOIjhzIpPC65OYNS8iAIStXgySwV rVcOh75VsVBuiBBBviKB5YO0z+2bHXnGZeabUR8gqLGEER5fh3y5II9/vRAkQS7MrlX8 MEUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=v3CzVNwffqVfXfk4NE2Z+/4EFEG8FprDV2OFnBt+VLQ=; fh=8iGvHhDGxI79y3+vtwcOV7/KUtMLTW09ehmikEFqvLw=; b=jTM+XzdcNg0BGf9jiMJcwKDfVogXU6Kbu49bDm+IUP/m5U6ED9G6GCtgb6L/jKwv+3 s4bIkucsKf+Tz1Do3gK5PvEDO9MhkDTkIJMlzq8PfSgVbfQjuoKOaTRWLuSsyhJxumUt NuRw9TEHHoRP/tvpOmnHTUyemBhEWjiI1DKDdD2ziF6fJAU7YSCUbQ2gxJ8eZE1KXSnN fj2VXHFrEPUJznQ9TE0gwY1yvDZKc0ULE3YJIE8LBjb6ulizOKYHEr+NkhycXFe/krEc VsgSR1+VhskzmvDcq+SDAkc7REOG5GYNOZBrAthZWo4dX4TarjX8DuL1Dgxqd4Zd4CGo rNGw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gsZx0LaS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6e8f748303csi105022926d6.472.2025.03.10.21.13.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Mar 2025 21:13:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gsZx0LaS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trqy4-0005wg-7n; Tue, 11 Mar 2025 00:11:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trqvg-0003Qz-KH for qemu-devel@nongnu.org; Tue, 11 Mar 2025 00:09:23 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1trqvb-0006YT-5m for qemu-devel@nongnu.org; Tue, 11 Mar 2025 00:09:19 -0400 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-2ff4a4f901fso7397718a91.2 for ; Mon, 10 Mar 2025 21:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741666154; x=1742270954; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v3CzVNwffqVfXfk4NE2Z+/4EFEG8FprDV2OFnBt+VLQ=; b=gsZx0LaSkfehRQBaUSGoBk2kGCqDwoBmXlnZPgHqtGtI/36h3+larrt+Ab3zq0PDCT RG565/Nx0NJasSE8xe/Y/EYgtKDRmYOUvF3QNpfygcPqtsgc0u0p3L7ED4OKqsqCKBpX l3Ja2atNlRSrImZGiS4fLa95uGi4l7lhBYzVNMVRxa7dF1hhiVgv0zbcbdkP2sJjGMSw qOZIcdp+eQTNu0vqhorreLm9cEiifytoMk6PbyBSI5UndcPIaPlMiCUzz1J4SpQfP4pD T5QM758cNx16v0CvHjTYxeF7HCyWUXeU/N636rwNfa9ch+r6d+F0eBtkO9nwog5as01x DP8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741666154; x=1742270954; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v3CzVNwffqVfXfk4NE2Z+/4EFEG8FprDV2OFnBt+VLQ=; b=N6hUHbi3jPB78g5RJv8P71EA4UaGEdOnRK2BfvFvf8LXon+Ed7EFttJI+cqQUH+r05 40VtBMgJiN+VFQolUsUlLaygcMa/0fXFqoFCKK1IGGHz3AGIMErHsZw0TmRZZRHy4alf 4MUGm19O5NSK/S7dQx854x1a7Q8ugRrN80jNQje8QxI4yeBfs0iUB15veumWW/wwG6cv yw1ngfe30ldSLnFxbS21Xo4miIi0sA1T87qvW7rpZwWKskiXagXDduJUNIlJNph/omvG oBN9azf9yChIUAQiACKT/ywqKSdVT+3Ynarhb12Lb80Y6sn8S5PCV2fpMaZXhYOtkAvi L+Gw== X-Gm-Message-State: AOJu0Yyt6bFKkNThD5ETeJIZ17LKERYRulMS4STSa/YZIyrPs/GgbRxt pnlHd1u7KbAtj2OSu9djX+6j6qBnAQhb1V09Z8hM6M/KoH1et3L1TCUVEbdNmo1y0n0FH8tIipX rhuE= X-Gm-Gg: ASbGncsMvuLPZiqHq+Og397h3ZoMKKFHeaaShF06wu/zV0yovNDYEi3CvjIA6fopTvZ 8j8FNEKDTwoS2WfqbN/E+QKOdPDGEEe/Vc6x7fDfn5y1QYNAgaPHzSJnMEiwZdH+4y+OnHyJvkC NqYPVfZTNpTiOi4m+XkHq6AUaM2OkdCr2KrfCYJ9dYMtyuBgB82Xr+tOOO9Oy60LbxJVePDIgOa O3XlbYiuPYhQsVWvl3cICF0V5SNGl6/IN1XYYYTN+g805PLz8LAeM6MKrBmDPvwkRWqQ9oLcT9t /wr9BsJAAb1t6DUbadm8su2l4OMAVidhhHJhLMW37eq6 X-Received: by 2002:a05:6a20:c6c1:b0:1f5:59e5:8ad2 with SMTP id adf61e73a8af0-1f58cb40fa8mr3753307637.24.1741666153903; Mon, 10 Mar 2025 21:09:13 -0700 (PDT) Received: from pc.. ([38.39.164.180]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af28c0339cesm7324454a12.46.2025.03.10.21.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 21:09:13 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Paul Durrant , Liu Zhiwei , David Hildenbrand , Weiwei Li , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Paolo Bonzini , Richard Henderson , Peter Xu , Nicholas Piggin , kvm@vger.kernel.org, qemu-ppc@nongnu.org, Alistair Francis , "Edgar E. Iglesias" , Stefano Stabellini , Harsh Prateek Bora , alex.bennee@linaro.org, qemu-riscv@nongnu.org, manos.pitsidianakis@linaro.org, Yoshinori Sato , Palmer Dabbelt , Daniel Henrique Barboza , Anthony PERARD , Pierrick Bouvier Subject: [PATCH v2 15/16] system/memory: make compilation unit common Date: Mon, 10 Mar 2025 21:08:37 -0700 Message-Id: <20250311040838.3937136-16-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250311040838.3937136-1-pierrick.bouvier@linaro.org> References: <20250311040838.3937136-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- system/memory.c | 17 +++++------------ system/meson.build | 2 +- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/system/memory.c b/system/memory.c index 4c829793a0a..eddd21a6cdb 100644 --- a/system/memory.c +++ b/system/memory.c @@ -353,15 +353,6 @@ static void flatview_simplify(FlatView *view) } } -static bool memory_region_big_endian(MemoryRegion *mr) -{ -#if TARGET_BIG_ENDIAN - return mr->ops->endianness != DEVICE_LITTLE_ENDIAN; -#else - return mr->ops->endianness == DEVICE_BIG_ENDIAN; -#endif -} - static void adjust_endianness(MemoryRegion *mr, uint64_t *data, MemOp op) { if ((op & MO_BSWAP) != devend_memop(mr->ops->endianness)) { @@ -563,7 +554,7 @@ static MemTxResult access_with_adjusted_size(hwaddr addr, /* FIXME: support unaligned access? */ access_size = MAX(MIN(size, access_size_max), access_size_min); access_mask = MAKE_64BIT_MASK(0, access_size * 8); - if (memory_region_big_endian(mr)) { + if (devend_big_endian(mr->ops->endianness)) { for (i = 0; i < size; i += access_size) { r |= access_fn(mr, addr + i, value, access_size, (size - access_size - i) * 8, access_mask, attrs); @@ -2584,7 +2575,8 @@ void memory_region_add_eventfd(MemoryRegion *mr, unsigned i; if (size) { - adjust_endianness(mr, &mrfd.data, size_memop(size) | MO_TE); + MemOp mop = (target_words_bigendian() ? MO_BE : MO_LE) | size_memop(size); + adjust_endianness(mr, &mrfd.data, mop); } memory_region_transaction_begin(); for (i = 0; i < mr->ioeventfd_nb; ++i) { @@ -2619,7 +2611,8 @@ void memory_region_del_eventfd(MemoryRegion *mr, unsigned i; if (size) { - adjust_endianness(mr, &mrfd.data, size_memop(size) | MO_TE); + MemOp mop = (target_words_bigendian() ? MO_BE : MO_LE) | size_memop(size); + adjust_endianness(mr, &mrfd.data, mop); } memory_region_transaction_begin(); for (i = 0; i < mr->ioeventfd_nb; ++i) { diff --git a/system/meson.build b/system/meson.build index 9d0b0122e54..881cb2736fe 100644 --- a/system/meson.build +++ b/system/meson.build @@ -1,7 +1,6 @@ specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', if_true: [files( 'arch_init.c', 'ioport.c', - 'memory.c', )]) system_ss.add(files( @@ -14,6 +13,7 @@ system_ss.add(files( 'dma-helpers.c', 'globals.c', 'memory_mapping.c', + 'memory.c', 'physmem.c', 'qdev-monitor.c', 'qtest.c',