From patchwork Mon Apr 7 07:13:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879186 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1902879CF for ; Mon, 7 Apr 2025 07:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009999; cv=none; b=ct6yRyI4CovMlJwVX4tJ8hBp4Zskds2KqEW7C/dAAZiWBX9zGsOk1jBU4TpQXIX+xz5SN+2d8yQfUYV3pPNZnslUm6zYTauTbtezoIryB9k5L4PJRFTBOhQKZZoPxZwF6ZpE/sPZZhykKJqKRoXccd1BWgG95558DYBt+NgGlPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009999; c=relaxed/simple; bh=/5Sjz3aLnWW1HWrOcAYyweVPpFM7vC+vJtoK/pB1it0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JYnf6Q2pFZYIRRldF3s1vLaml78T50JTU/BSx7+WEaxfh5VXk3y4lUNJ3n3/46vmDfSiWh3W11Nld4G6GAO4yn2+0wM5uWEvv/V7l3Zp1XjHbOMweIaG//bz0GrCLjbHUFSeoqOwte7hWaY8f6FtWqDmG1C3A4P0a0QWEE7R+dM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=NXaIbDDm; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="NXaIbDDm" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39129fc51f8so3135239f8f.0 for ; Mon, 07 Apr 2025 00:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009996; x=1744614796; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5irncOO7SE3DLhdbNeNA8jd9DPgwzCzzTwzb8eKHP+I=; b=NXaIbDDmSle1F0IPCwn+YbBmNvDZ43f3hyUwKSjrmnbH8Zlw2w6pJ7ViJbpq1Dc9sn psRkom2vRBgHZE3vpN0DmNxp4wPGvVi8sg9DGPitZJjver6a4RC4AEyLf8fy/EYtqw2J c97rp9rssqNLvETLkF4A0kxOvdGZME4m2jCJUcUgrlUUL9UP2rOF81tAanVds/HTu2u1 xYL/Vt9+v3b80VDIQIBfOfaI1j5q+dZDiaom1kioA/cUFODrXfo5CAExPdmiTjjQrs8e PAoVIsLDGNnltFI9Znt7nfY2vP9dLz1an8wHINT3chS1do5bC51PmzM9C2XYGbjiKRvf pDtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009996; x=1744614796; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5irncOO7SE3DLhdbNeNA8jd9DPgwzCzzTwzb8eKHP+I=; b=BLoizyO3EtT1JvYPPRDrhp2h+bbMf5fAqHp1/KVzkTj1ZQvoWD3a5Bjr8GCbgdNPjo YHTgC16C8UwVXRMr7H8kQVvIwsYFjKZnwCj0vZWzL+ij1jVC11/D1Rc0ZyIcDo5hqMQ9 KL5bqLUrFmKtmwv5ftRwMcRYoZ9MgQzfF/vXaTTcvlXZxPeUV9LURoarSPqhaFeV2YBp H7UBxwoqqxiNF/S5AYo5Yp004kcRGNVwj0xaoOkAEkBON4bfsYPv0pC9tQf+ORgeV+Cj 6fzcrFke7OjEFrvzlw4PXYL8omhCGu2kvjVAHVngIbLGkJtZFgyMk1bcP8WzMbgtsXBo ngVA== X-Gm-Message-State: AOJu0Yx7QLViFz/3gM028JawLhUMaFefpxCsjXW2XNT7FdP1DxvLW031 mxPjivdMtjhGBlov9rQTro/91zQgVV4B/cnfYJQ/urd0+tDYOOjcZqgC4zYbRtU= X-Gm-Gg: ASbGnctNzKcXmmHTSXJxKAXKX5F4AZ8heMoMF+Z29N3GbeN2L+UQdI1rQbJyIRhYwI+ 7HMw35tS65p+IVkFtopzkCn1Ke1kyX+L0vbftohLeYqOrBVMKJMOzLcVEeJLXIx6MSAh2LRDswZ mI90TlIn9vLmpOM2qpLGVO1EWyE3DTG0IxmQigER8EM3W3KUNSg+HS9MtXCu8ZwrZ0IUGfEINN+ PrqrnS44EMYGY4c11Sng/7cekKViCYA1s1Az2fBCDRT0gVnNkR00cE7wJQvwL3WI8AZODmZZvNi MaREMdVCxu/24EZ4UZBOWyV/5KIC/55Zne4dqg== X-Google-Smtp-Source: AGHT+IFBHgqI/Cxfb0Fe7GnSQX0dBTR8Ei+wg1va5UMyVSuvAr5jqU2pls0VxHNJRirZpFzVr6R2gA== X-Received: by 2002:a05:6000:4027:b0:38f:4acd:975c with SMTP id ffacd0b85a97d-39d0de28abfmr8610281f8f.27.1744009996357; Mon, 07 Apr 2025 00:13:16 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:15 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:10 +0200 Subject: [PATCH 01/12] gpio: dln2: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-1-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1429; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=+n19bsYgJ9JYV2dFC3UJAuU3dlkEyRxjh8PBYfyEbIM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sIgmH9ntPZ/6dk4gBE6hPGCGhE/lByx8cce k8UINLyU+iJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CAAKCRARpy6gFHHX chDqD/0Z9/1FeuoUlnMoAXDIXhzac/3fSTa6xFAnJgTyJfbhsEsUh5CIYenipRVpDmY5T81G7cH eWYEhbJKuQLRvi9UXr4HhimopV1bi7S0wAg2xoz27GPQAXkW/OxgQs7XfZrgFqaAmUhpf8xj9/l MQQlRFfK2w1olppK1HpMvCSXKQHxeh2r3+ma9sgdTYkWatE4PCI9gZaWjjJi1sGzZzX7FdcP8T8 rYBvaVoMirOR4BmWbhp2vJq4+CKR5TTnTZ/8TZFj6Ibb/gFun89CaQdAH3QVe3myF6YSpeIgXDv U3uv6i4VgMFMuvFP0uvHOa6FN3kD4HDI/Nj1eMPlcdX7NbjC98UCysrNoJqlxngT7QsENrhFeeY vjs2Wik4oEkIiNWChZPE8Mbb54H32/VYDlXenzlw+Iy+UPa04d+5pn6z4zwrAEvWQ4z9Ojl303J Uj25cc2Nl8XKdn+YCb86uOarCsfvisuRAXbOTE4g87GG/5Ssa9S0hmP70yj2SHhYq4o9c9GTAS5 DwDJ2Da246eeAE67fyWnaIrOkPc/YEYSLFhCquFBUdp/gZgTYlhwG/2z9pIxHN2Xl6lBQfF7xgo uoyy4gDFXFQyp18mUyQERyxZLF9nUN4/Do2SdLM47h6x63M8FYf0mVFoDzkhGXgWp+sFkLNunLs MJOQzIRGZ6Q8eLg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-dln2.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c index 596da59d4b13..4bd3c47eaf93 100644 --- a/drivers/gpio/gpio-dln2.c +++ b/drivers/gpio/gpio-dln2.c @@ -220,11 +220,12 @@ static int dln2_gpio_get(struct gpio_chip *chip, unsigned int offset) return dln2_gpio_pin_get_out_val(dln2, offset); } -static void dln2_gpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int dln2_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct dln2_gpio *dln2 = gpiochip_get_data(chip); - dln2_gpio_pin_set_out_val(dln2, offset, value); + return dln2_gpio_pin_set_out_val(dln2, offset, value); } static int dln2_gpio_set_direction(struct gpio_chip *chip, unsigned offset, @@ -468,7 +469,7 @@ static int dln2_gpio_probe(struct platform_device *pdev) dln2->gpio.base = -1; dln2->gpio.ngpio = pins; dln2->gpio.can_sleep = true; - dln2->gpio.set = dln2_gpio_set; + dln2->gpio.set_rv = dln2_gpio_set; dln2->gpio.get = dln2_gpio_get; dln2->gpio.request = dln2_gpio_request; dln2->gpio.free = dln2_gpio_free; From patchwork Mon Apr 7 07:13:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879185 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E162022423F for ; Mon, 7 Apr 2025 07:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010000; cv=none; b=DubsMvVhAYnbXWCGNuwAlV6QhyPVYnJI9s/EflL1HGRs3qddAm2ZJDZ1UUEOX76NYdOTz6EzckE5iQ+GlG3f9E1rqZM7wBg9m8pPh8k2PpM2NvxFrL4oviiXdph/M2T9flwalAgU6w1XCwavfQ6RWKGWiNJMpZQQ8JQrBlLqrC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010000; c=relaxed/simple; bh=v+UnjFHMxAqwy94M3qJUXymRSNqizlBnKqSV3yUkTwE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ImJuPqTCFkO7E3wC5Q5Y7NVSaNQB8F7InVj6Y3ipVV+2YktXnqFmUFrjUHBM6xpGgFBN6tk3X8dKQ5ImjQXW21wpu8ON6Eb96MtMtaiR3+nZwmFaMzKwAzZ6SUiGYr4LZE/3TrMLjTWm8d//6Oa2yahBtkiZSy3jbROM+OvU9Ek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=JOCJVjk2; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="JOCJVjk2" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43edb40f357so16610545e9.0 for ; Mon, 07 Apr 2025 00:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009997; x=1744614797; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1zQjLtm40iNq8UW8XbxtAHLJFCmbbdZctSQ9irwpSVM=; b=JOCJVjk2s3bpMHY/J3TvNY8lBqVbFDDvtxoKs8TEsGQLup924DDGkcnv9YAdUwGSOy zfT/y3vFuTozqYlfCG0sEcSpUXFt9QghRsLqUPEHr9m1kIclXpARuvLruSE8V/7H93tH LrhKBjDBWuvFMwzKPh4nshJP/3+z0Lv+1cBMHDymWmU2QWd1d27YC7ZeXeGFRMjG0X67 hacjxhZ36Kd29ns41Otvxdnt7mB1LHdRG2rWa9ekDv7PnorJ/NZsQKn7Ds9PNVRoqLI5 iq4W0V9diMvsTyK6LOTIRsUbz6f3A6SQhQcL3DzxT4e2pgLdgtzzLN89knlX/iEWK2JX M3+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009997; x=1744614797; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1zQjLtm40iNq8UW8XbxtAHLJFCmbbdZctSQ9irwpSVM=; b=bX5IjH/dr6WGeV6nL1oBzmbKzB/PxMwmkXEiagLz7GlCnB0DHBaU8wulFY5LBvB1T/ GoT3IwNwXqleSaTnkeq6p5gpEUsb134vkcZTRj5TBzDk2MAWwyjD3JCRmmYk3XZmHidk g53EasXxczbKMstVVISNfs0JfjdFeHqmG0EKs4+z/i5KirlgIASp+vo60vkGi/kfOXvj A7Mpdi4inM2aqwbI9LSz2MEJvxcsN1MHgx4vTu23Dvr98b5A3NyeWj+RPFdO4wHghrKX XkIDmQ904dy0FfLaS4Qyuk4nsadqbXooW+PrFe8qWjEmCMNDKx0e2IfaU3Qctv1dj9lM NeUA== X-Gm-Message-State: AOJu0YxD584CpxRjaTkgE/iGhumgzDAQo2GpIMkf1sHiIhNhXwNtkO1r X5IZbZr1LqXeP81BeertjEZwvleULnemHN/AAzX6dCErdAF/XFQWwY13zTLbeNs= X-Gm-Gg: ASbGncvZNetpydSHs1tbQsxHncbMY/34ihGt56xmWYi2N/rkI4yMyUdA8rZVNCLR81T K0ntsJiWlrgzp8ACoRtXz3ou8GaT+KBvjnduz19bStUir/sebrkl0Uj1XfvgIgYb8lsGUKzaS/c GVQAkgwPgjiqBdq5T+6tOTJiKCJUVb8eo4LlzSv2yXG/nW+DBjW2u1OrQx+1ul+WibMSrJ+7e0b C9FbOdyS8hr54WCLpyw9/njCDDCIvj+UAATzhQDZULyheS2GA2UqccfRHcHblKYemMLwsfT0cp8 YTPGvVjLBrq5X91IZ+LOo8pq1VTSgmjDtsifIQ== X-Google-Smtp-Source: AGHT+IEW7+lJhkewxGW5VJOMPuyU/iBjF8bH7O39UlC3ofjb4Ms5uuG30X+9kSf0GSUz28JKAf67NQ== X-Received: by 2002:a05:600c:a013:b0:43c:f8fc:f686 with SMTP id 5b1f17b1804b1-43ee0616fedmr85967385e9.3.1744009997193; Mon, 07 Apr 2025 00:13:17 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:16 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:11 +0200 Subject: [PATCH 02/12] gpio: eic-sprd: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-2-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1334; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=5A6zzhsqbuFQhR5Hofol1LNkPbnT0JcOJ+YNZXE98OE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sI2V8zg5FJxMUMaRkfC07sJYiSRsypxrJAp fMycLk+/4CJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CAAKCRARpy6gFHHX ctb2EACByYklX5SCC5JSBbz7+I0EJoIpsFeBpLsSw9cMfwVJR6/NjsCfNRLBlVKR2r0zQk8BeaV aJzHRRiU/+YR9Ll5nnZ8EzUY61sez3gq4+gS0pmbWUgD5WTXG0iPIji4hc2Zig1ykKotvAPmiOb dLfBqcCq4lKcaJnD4/c9VMa8Xr/JdoQJH13Fj9D8cNFEfVSwkAOEk3E7FOkpKfkm1aPiC+GflqP aZVFO27Rr+HVoZGz5FaWR0is9cEl+bVpfwcMygi+LgBSZTSw/hMj2jFOsRDGePVWZQTbfgTJpIG KpEk3X+2vJXV6BGiL7qlMCdcy5b/yT+zNVUar41GWAYN/XztovlRC0uW0cSF7gc77lY0YxdEYJ9 fUZ4pewLtTQ2lvZYxj0vW+8JePeC8d0te7Yc0GM/Y3try6KhZ/6juUrfIqPzvjLoMHASSJjvzzB DnpUPDEJ5MqMjf2rPZGrombA7n5maN5iGxAelCl4cgJBhjI10bnmUYEY5zTUx+4Xvy45I+Eyly1 d4aEigjzYbpRNlbQ2UxzgqEL7COF/b1BO0h8Gomvvjng2IcPtiomsOOd7dEuwousy/8a5pX/K4y 5Y3Dpb2LRc7TPRSWGnP1ngergD005KqkQdLYkY99nYhVuc/D1crz7tcN/XbcJ/IzFK4APqtbZIs zPRljQkkWVYv2zA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-eic-sprd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c index d4bf8d187e16..f2973d0b7138 100644 --- a/drivers/gpio/gpio-eic-sprd.c +++ b/drivers/gpio/gpio-eic-sprd.c @@ -203,9 +203,10 @@ static int sprd_eic_direction_input(struct gpio_chip *chip, unsigned int offset) return 0; } -static void sprd_eic_set(struct gpio_chip *chip, unsigned int offset, int value) +static int sprd_eic_set(struct gpio_chip *chip, unsigned int offset, int value) { /* EICs are always input, nothing need to do here. */ + return 0; } static int sprd_eic_set_debounce(struct gpio_chip *chip, unsigned int offset, @@ -662,7 +663,7 @@ static int sprd_eic_probe(struct platform_device *pdev) sprd_eic->chip.request = sprd_eic_request; sprd_eic->chip.free = sprd_eic_free; sprd_eic->chip.set_config = sprd_eic_set_config; - sprd_eic->chip.set = sprd_eic_set; + sprd_eic->chip.set_rv = sprd_eic_set; fallthrough; case SPRD_EIC_ASYNC: case SPRD_EIC_SYNC: From patchwork Mon Apr 7 07:13:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 878820 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D818D22423F for ; Mon, 7 Apr 2025 07:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010002; cv=none; b=KnU7Ji6VXlHuGKT9ALpExdUAn7m43/wMTRVSCNUCFsnLfxzOjvoUDuEnL68n3Km7GnpRYNa+4ReIO92Y01PYa5bbRPXxdoT98ZiI6mWu/BiOQiKInhZhiunb2JxgkzEisUgTDu5JLJ5x0l4z0dowUV3KELzemlF6pIYUb5Qi80E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010002; c=relaxed/simple; bh=3UqRWBNBXZo/ZeZgdiat57DVN/jGiDxmQMa8wMm3mEs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bOShQVK2bMk3OYCVR+X0MdtJob6LB4grvKaBw4ZeCUzShy/YK+gg5VrlW4p6QS0gZpPxWvivmPg+TCbyxbaBV1MbQ4b7gIJkNHYdoE+/045I6nxqg2P87i9auYkyvjo0+1H+bR8d9dnLOnQuzOdVxd+DLzsbn2VODvpRss4bV64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=IdPcTtiV; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="IdPcTtiV" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43d04dc73b7so44863465e9.3 for ; Mon, 07 Apr 2025 00:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009998; x=1744614798; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=g1fP3xcbZWM3sDn2ueQ9yrMymsFb75Gu1/jl1pJ8LTw=; b=IdPcTtiVgu7JlkSEIrOoSX9S0r45eoTQzC/eQnA0V77LzBDWGq1H8xEHOh40AHjTNb ET37NePXzcr/KkHMcXrOge393dSSURvNDhVFe+ggEgSYo5bzm85WIzryxHwYe/Kv/GSk 2fF64N9dgt7k+KcOB7sR6VTci5GEm/seVoJBNErUHQ+L3F0aCoHXcSBv+4p2OQJwNSSv 7u7n7nekkr827OxDgBFFM05Yxh+2JFdl04NBHrU2CwQGDqOb3+fhKtXX2eG/RDaiL0Cs l94zo4mUveByPOneXmTjjIGcb7YbisHuzUjKPDcNNGHOe2tpyGTXFL+MDb3yX6oc7/ja 4/Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009998; x=1744614798; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g1fP3xcbZWM3sDn2ueQ9yrMymsFb75Gu1/jl1pJ8LTw=; b=D+vZjg9/hhy7CsM6jvV6yI5Nv6zJlpSTHq2IVLl8G7O8Bfwmv4SZ1sSB3LZmuXSbVn 4IHRMgVvbmyf6Zz6zJ7iNBGDi6vNgEcFsM2CdcKboHnZBHzwvG16aPyOwDRUft1wCgS5 yPgDkBBVpx1e+woh5LgiOKLXUpxifuBleNPNTGMYBp2zXGh8YVGnTc5xf19woMaG7fnN rr+hxCxD+0JBNZSPzCJtN2GbR53qshwnAyuJWbHhAGg2UrJiEEMxPHxNkAP3e0WzmCxC ZI0E5QHkblsGfhOA2w2ARSyY9Uaz81xpp0i6msZGqhNZf1Jy/ak0e8IH7GlH9Czpdt/i 9xTw== X-Gm-Message-State: AOJu0YzpR0nxdQFt256YzpBgdpS4NzW4VwVOvs1dYm0CWYJSBQE5JRe+ aWDzRTnuYrJcMjktfc82CGHwbO2eLdMF48TYSgMxWnTWJpLYCETVoIeYtghCsxk= X-Gm-Gg: ASbGnctZ8A5Gt7dTzZ2+GKoKYXQDf3KT59Ajbc0/a+5I4jMjlLoqYcNRRnasld6je+Z WCw18JUTKdZ+jQy9u8ZnGkkdKtwVHrpiYhs8KEqAV8ZFz52T6pPmX3N6nBHvYHfoYbDhE6/7+Ct i/rKVQ5rOwCPOHzJqW0Uzk5VozSxOVjg1ph2Tm/KMaj5HJgPDci8vPiebr8Lb3OtEjheAlUQJ7i TZi0fw35R4a2Ag4lqP2XYx5rYw1SDSv5RDFvONzcWuR01F/ck5whKy503AZ1JiCNwMYFgpRr3/U 8iNHn1foIzk3O0dGId7UCEHS6kZpgTN5kExPlAi76nnhr8CD X-Google-Smtp-Source: AGHT+IGzLgILttDxO1B8ID6ZmYzo6UknUTAj6YgLYVfn5lH4jvVbwUel10EFxuC86rN+5EElsQDGrw== X-Received: by 2002:a05:600c:1e13:b0:43c:fbbf:7bf1 with SMTP id 5b1f17b1804b1-43ed0da49e6mr130036885e9.30.1744009998188; Mon, 07 Apr 2025 00:13:18 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:17 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:12 +0200 Subject: [PATCH 03/12] gpio: em: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-3-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1477; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zoMPRDHW7Y3vEjectUVkjXPywBkkJrvFak4r8W20jMQ=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sIVNSgQwx43danFZuwlKoFhMjhiY4tXyr3K hPcVKvFHrSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CAAKCRARpy6gFHHX cjyrEADFMysjkLjIc4WN+B46gtwK7IJ+YVCQQCJApl4/0aueqbNPycaFo8kpJ3MlEQABIFK//YC mPYqV+EPiI03ax66V45tvlBnBE4elvx3DUeEvur/yjdOAGJS40SVXUBntZlCnuCuRzHC96vDNcx 5yiV41OIBqFD25ocDJxlIQTnhzfb5usz3+t9bkcvbah6vDS4sHvbxrre+67+vIraZQ58GFE0Jpe IjQUBSkZ2WaA0Uq+4d7HXY9TYEtJvn2nzVwSgyMUQi6iUKG3bxxt/PWDHj+BSIhUOk+AJgRWe63 NNeT8Loi4x5F51xpLgFXHe2/7BrSAZaUQZ2H5YizUY5cR2K7UfXywccY1FUlGl9ImUqV7PnfrFm S/jdAWb9COZ1rkCitxYVX1bEb1Un2DujKjPQJLMzn1HcWr6iURKwXTxTKsjIY+xPG2pecEIzB3o EPnNfFBtGbjvsSaCGDm06EiD4V0o2C3BF2uu4LH7BpQlzuYa0bDjFOueCufLBFhPRWyjOQlUuKd mEZS8chidh6g8GgwfWfOPh+/eT/19cbCPDi6LKp4+TJwlAoFY/6x4XIsAYpNXENGItGQHAZdxUS NEDpumQOLGrDleqcTZwv0xiajhTebODEPE/mzCbAj0Cj9RPyY38A1RuAvw0pTficQbCASosENsf 7kxItCqcsnjKYew== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-em.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-em.c b/drivers/gpio/gpio-em.c index 6c862c572322..857c28895131 100644 --- a/drivers/gpio/gpio-em.c +++ b/drivers/gpio/gpio-em.c @@ -204,13 +204,15 @@ static void __em_gio_set(struct gpio_chip *chip, unsigned int reg, (BIT(shift + 16)) | (value << shift)); } -static void em_gio_set(struct gpio_chip *chip, unsigned offset, int value) +static int em_gio_set(struct gpio_chip *chip, unsigned int offset, int value) { /* output is split into two registers */ if (offset < 16) __em_gio_set(chip, GIO_OL, offset, value); else __em_gio_set(chip, GIO_OH, offset - 16, value); + + return 0; } static int em_gio_direction_output(struct gpio_chip *chip, unsigned offset, @@ -304,7 +306,7 @@ static int em_gio_probe(struct platform_device *pdev) gpio_chip->direction_input = em_gio_direction_input; gpio_chip->get = em_gio_get; gpio_chip->direction_output = em_gio_direction_output; - gpio_chip->set = em_gio_set; + gpio_chip->set_rv = em_gio_set; gpio_chip->to_irq = em_gio_to_irq; gpio_chip->request = pinctrl_gpio_request; gpio_chip->free = em_gio_free; From patchwork Mon Apr 7 07:13:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879183 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC88A226183 for ; Mon, 7 Apr 2025 07:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010004; cv=none; b=j8a39D2qY2GHE/Zz9sgkZFT7ssdZpmbZMVh01gijiL91z8V7Wg5BZe7F4kb5Vbbpowf8kgBs7gHAk4biEfpQa9vxdhvEgHx5f+uYllTbm9Ca94QrgdoMPgE9HyZ2v2ddWgKFO/Bj8rZmEBV0HllLwodcJb+IrHtrYxF2RWTOzoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010004; c=relaxed/simple; bh=RkgKWhSsIhzUGPNoN0mdX6+aMhttLmif45hukjZbTak=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JeKGUgEBdix3fSEvl4nFnkCfyfgAG0pMeeYmXVXJLwOMao1qU6YXS5d72vXszlU8zz36G0ZbTsIgtR+PRcEH9KmX0lxuTDDliUYDfxp2oKL0Q6BESYfD7cTeYhcCajcR59GLOSiT+R7WpT+mCiLbjBHx+wE0IU/lyBBY9DEnlro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Y0eV9Ely; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Y0eV9Ely" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43cfb6e9031so37129365e9.0 for ; Mon, 07 Apr 2025 00:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009999; x=1744614799; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5Wepzn0bSrTUctNYJZv2tNgjnTLDxfYJ7sTLL6ztZhk=; b=Y0eV9ElyEWsNC26ae+aWsk+VQJUCR6i86K83WsCONwlnsgv7DIsfam+//8fTcmI5xm kayKIr4Z448ikiJViaCUQ9OhJG9ckTJmXPvK6oymZfBtIrVVrJQETybdmQ8rkKk1P4o/ d9MEy4E4j3MBvjsOCmr4FNDASS+WdYfdZWEa+nW6oIRswgHARbfY1t+1b7SkHU9xO3Vk 9x2Q8Nr5XUqUOJoU5fYK9tkdfGV/K1gPeiG5hKCRZiV6e2A3bJ9vMs4USVjYu0gLVdz9 lbF9bu2/PheH747IeMkWmSeIiUocxDJ/itcn49n0jTHtIcwtucImmQViNdhJTV9LZQ72 cqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009999; x=1744614799; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Wepzn0bSrTUctNYJZv2tNgjnTLDxfYJ7sTLL6ztZhk=; b=Ys9gh2gWA1SPAa5uqAitjK4C6wT99IXSaikmjP1qsr1csp3c1qbHUdRWRyBXV0vEeR MKxziPDzOPXeFlF+bwd1gFrs0Dp2Kgp6IPJ3FBsCeisXSofujasn8WIgIwl/Hn1wPkjV tefIaPrz6dHVvdZHoJ2ox3TEvjRPbTKlBZwUW736QII70d7Dmpcpk5KOT03h8lv6Qpab nNz2/dYL24JeT3ppiqDS6G77aiduVD6+ograaV3JCbS4Xbxs/eKHDXOaWcwvuo4tAvBg ERomAG13JspC5g4HhHxGjQd2gBfveqYLSk6iTyaosf3j7lSAvy/guU4KsaPsWeci1Ysn SuzQ== X-Gm-Message-State: AOJu0YwtuJz4y8MZd+283T5yB51mdnZcNgm7mgJmt+0oE9tiopmI/r6S RvfW1CJ1Cscjzz6qPuUELHqaN8WzTwOZSXhdIhLkP4rpSRvhuBOAiCHqSQgQrN4= X-Gm-Gg: ASbGncunpWw9H78x28znWA5EShO2JaWnRSsVg2lvdnwc6jSfqWMsfiWfIi2oiLbXlrU gKkjXQFuXos0gNNgChwKQIdnoQomsYiycvi3/DNznLB2tiYCQ+/toeQDYaENJax+KGOARBXycSu PWCzI0iGB36iCY9wcVLRAzJpxa+5Hltk6hmIEwJfiHV3kmVfswM8ldGlrlpNbr36lo0Fzl9n/6H zDzSrJnATCr4zjMQzFlKndlDe2cEI7AAyMRz2RN3jyq45uYwQ9af4Ht7EmX66vXD3lG7fUm2DkU QbS2XODJmAQblwPlmDY94qtMz2Gy4g4IXBpmhA== X-Google-Smtp-Source: AGHT+IGyhcE/IuZZs8QulBbS6kDGMJgDPUGZRwi3YwBtd/IiuYNtNzwObPJBI62CcG4AJbpP58tp4w== X-Received: by 2002:a05:600c:45cc:b0:43d:fa59:be39 with SMTP id 5b1f17b1804b1-43ecfa19d6bmr74493645e9.33.1744009999121; Mon, 07 Apr 2025 00:13:19 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:18 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:13 +0200 Subject: [PATCH 04/12] gpio: exar: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-4-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2554; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=VBaLRwvXCHSMDlXyQDnnPc+JoISPQ5RIJj1Yyuoo2Rs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sIsJh5mSBLL9JNqgm94zsMHoeoOktkEKaU7 V2KAnuiH7+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CAAKCRARpy6gFHHX cvaXD/4ub9soMp+EVeLGnbmKaoZNeP/e4NlLxD38WiXqNsu67ARWHZfjRxY2BrkgMXVjQc73eMA 0oie2U/HcF3/c12LooTmi5brOGQ+fCEyeJQ6VrhV1iPTeUIngkxnqEFSwhjaR3uOZXuBTagR9FE sWH2G2b2tA2dSDIRvZFAq8oagJNspszfKhWNs2a5Y0IUWweZ44MEWAr+vOs+Bglee4oSqzhF4gw L+dzjx1n0A9OV6yCTGJKkT+KE3pMTDPO5iA23NEtZJVkSt6Y8KFr+si/0Xef/BklhQactoHIOIl poLVGDC8YF/35IwvA8WO4TMKQYfIsf5a+yDotBKUHM+cNhf1CvFwFwW0RxBXnawszz/c2nGNTfW ObCZVfJqTLx3OqhlodGwV0RH7nMxqiQddS6k409LOqWQn0NvQ/n2tjISXlVffHCtiKNemayf6aQ aO0x7xQ4PKifW/1pqzo2Qz1c4IrjV0TeZfb6InVjbuDE/r8mJ1QA3F56CGcRkioDtuJwlWMm59K wrw7CeV2oxut2HnUIKiw7T1P8EBT/ZgvZOKNtvgZn1EBxdO4bhEmqY8O7kISkmlxTUET+x+nR66 Z5Erx5zbPnm6l0wBxcpkSjm635yxE+x8qQWpANIRNYqE6xIA0SSfJ+TdfOpqZqiCibCnpkcqXqD LGUtduA/iEYlDSw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-exar.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c index d5909a4f0433..beb98286d13e 100644 --- a/drivers/gpio/gpio-exar.c +++ b/drivers/gpio/gpio-exar.c @@ -93,8 +93,8 @@ static int exar_get_value(struct gpio_chip *chip, unsigned int offset) return !!(regmap_test_bits(exar_gpio->regmap, addr, BIT(bit))); } -static void exar_set_value(struct gpio_chip *chip, unsigned int offset, - int value) +static int exar_set_value(struct gpio_chip *chip, unsigned int offset, + int value) { struct exar_gpio_chip *exar_gpio = gpiochip_get_data(chip); unsigned int addr = exar_offset_to_lvl_addr(exar_gpio, offset); @@ -105,7 +105,7 @@ static void exar_set_value(struct gpio_chip *chip, unsigned int offset, * regmap_write_bits() forces value to be written when an external * pull up/down might otherwise indicate value was already set. */ - regmap_write_bits(exar_gpio->regmap, addr, BIT(bit), bit_value); + return regmap_write_bits(exar_gpio->regmap, addr, BIT(bit), bit_value); } static int exar_direction_output(struct gpio_chip *chip, unsigned int offset, @@ -114,11 +114,13 @@ static int exar_direction_output(struct gpio_chip *chip, unsigned int offset, struct exar_gpio_chip *exar_gpio = gpiochip_get_data(chip); unsigned int addr = exar_offset_to_sel_addr(exar_gpio, offset); unsigned int bit = exar_offset_to_bit(exar_gpio, offset); + int ret; - exar_set_value(chip, offset, value); - regmap_clear_bits(exar_gpio->regmap, addr, BIT(bit)); + ret = exar_set_value(chip, offset, value); + if (ret) + return ret; - return 0; + return regmap_clear_bits(exar_gpio->regmap, addr, BIT(bit)); } static int exar_direction_input(struct gpio_chip *chip, unsigned int offset) @@ -209,7 +211,7 @@ static int gpio_exar_probe(struct platform_device *pdev) exar_gpio->gpio_chip.direction_input = exar_direction_input; exar_gpio->gpio_chip.get_direction = exar_get_direction; exar_gpio->gpio_chip.get = exar_get_value; - exar_gpio->gpio_chip.set = exar_set_value; + exar_gpio->gpio_chip.set_rv = exar_set_value; exar_gpio->gpio_chip.base = -1; exar_gpio->gpio_chip.ngpio = ngpios; exar_gpio->index = index; From patchwork Mon Apr 7 07:13:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879184 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C84BF22655B for ; Mon, 7 Apr 2025 07:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010003; cv=none; b=O6J/2ayYIvfer12CQHvLE6DxSXGQ2dlhAYQa0ZlonoPHA043jqmlqD5YiYrZNqhIQ6uB5/xyR11zdQhyiXKq3tIbaSLfPu/FUF45URP133P1MoKUzz8PRCtYQSiBPd1yKp6Zq+q6yPKbaK5bfqDRXIY4Fa2jBwkx/RoPFXlCPlU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010003; c=relaxed/simple; bh=mlVNd4QzbWckE0pUZqiiANKAP30ys4cnmjE4RIMXci0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CelObB0juRlfusj2Z6NXFRcKSh3Jisq4E7wd/LvIjXK7HBfy5w7Sy7lKZbDgndw7vTF7VF1uQjUh3UZQ252I2NcmOTFgUbEDiaceXbjVuBFO3dxcbZZc+OS82gIdchPlmOkHlMw7HuxtkwuVBTxYj+FYK3hYymkz6kgAhdzh/xY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=MHYJpc5f; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="MHYJpc5f" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43d04ea9d9aso18535815e9.3 for ; Mon, 07 Apr 2025 00:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010000; x=1744614800; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uGiQ86zVLb8JBWVTSCwg7M8Ca/EW2/+PddB7ADI5980=; b=MHYJpc5fDJ/qXwa0o/oh+gFKMpoQetwNZCVxw/J+N7xWlXmyVX8ZzG/A45bZg1kTWV wU9ByJ2RRCSD47gP0JY+sWWjKrVgnRTklrh37tj8OpAuUCymZ43p3b7Txm7DkFGtUCOT PS+BILJaIys5Sx1oNrDUaMiFA1ISjdivmXQywDK1KDEvxDP3kgchGHzWUXxNE95sjYEj fkveT571BZpoP0RISjGs35ec9srkBZeaW3o2/82KsLlPoC7Gt2RSujDU/1O/HpOS+Q1r Mxr1BUB+9wEoqlRqhBLoeLsw274km5277Ec7hmSCwZd22el1HXHzdm1SC0DNMDv3eDtV p+GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010000; x=1744614800; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uGiQ86zVLb8JBWVTSCwg7M8Ca/EW2/+PddB7ADI5980=; b=blcWQlSSDYQwvdJCGNbOueh0uLyFcuSApKOKxA/Ohcfns8NNreCflJfZoP1ud5Jsdp XpZmq1z8zVtlyfpVhiQHJgZbYNyedAxTQ6uspAePh++VSxfrwAgPFIRC9mK0TkiT6uSy xJA3ZDdImGNocyQLqrEddgSkfjF8YeBwGCIPM9UjJM7PdFqGAEMJ2SA1VPnyffc9nVGI 4wBpUUvFZ1xEuUQefNQRUiQbU72hLNSjlI21OG4EVeETtmEo39VHNCgxXTa9nm8A5iaW xToQ/B4UyvJuoiuIMB0LvuKSU8HLJm3Ntq2xTc9WIaOVM+T8b4EwYaQwhyjuhKk0EoUH mgzg== X-Gm-Message-State: AOJu0YzUiRiabqLzRGAXY9UzaC4FuE8cR8NBnv2NbBsPFjtQg/WlmioE Wg0HcEz0uqToKOsNgP6YTujA16OlK2vGUoHS6MYh2ECsvo7tDqQU1CZk0tmZaF4= X-Gm-Gg: ASbGncuRTiJLFNgSW/bNAXEr8OK7CU9/A4VdSJUoymyA4ej99T7uUHLVD4LPoqGQhzf QmYmgBkHwqnmAtMgMg3z1qMRceoHa9cz6zeuTwPKaCVeYNNHoDmBgAnAPKjWxur2vUONPmfWb5q cqA+z4LTVUB0O7VMxm/WFB320jBptR22SNJF9AF/KYFx8srEAPtBuH/CRHc5lJK5Bw1C9o2hKhN zE+v5X3lPomiPdz6K166HABVEuYSfK29MhC9YLmmU1vkdmVADlOHcsUFGD4n2bzmkx/Fi08v6Jb MoM8xSSabeYiRO6/Ry1uYwQA6Jwgb3Ut4NYvtA== X-Google-Smtp-Source: AGHT+IFMnQWMuXkai5VCXN90Uk17NVhGiPupnkywvYdtceCZWC66wkfhrPo8RcuQDGcdn6iuyHqaJA== X-Received: by 2002:a05:600c:3487:b0:43c:f3e4:d6f6 with SMTP id 5b1f17b1804b1-43ecfa19260mr116571865e9.31.1744010000060; Mon, 07 Apr 2025 00:13:20 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:19 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:14 +0200 Subject: [PATCH 05/12] gpio: allow building port-mapped GPIO drivers with COMPILE_TEST=y Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-5-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=700; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ksPOnrqfUjMkoYZLGB0SWQFHhunit4ITjl2uJIRK0Yg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sIDZLdYKCIe/P9+rZTbVOSO0B1bCxS4//IB 3GXgNF/C2uJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CAAKCRARpy6gFHHX ch/oEADNhrWFl02g6tVUm0/cA9jsOsiNTwNcnBwCuDN79Rt4qiexiZbteq21vXqTooFxS63bA72 W6G5cAh26pJlvvhYhprqALqd/sm25sgLImAiDn8SBb3XPsVMzwoqHvXl+th412fMREFfW963Y81 leLjIZ8M3Om09FS/7XTEMMc9n/qfiIJ8MRnJMvl5cliLlJ166xZwTwQBxn8ae4VIXrqPFDS6XDt elwBlZNgyBIt2SfNtfL4qy2uKZgLG+BWCcNo6++0KtsTa+eE01VR2EJIQbIVH1/WnSshLa7yAba 6vtjej0fx2nScSz2EuOe7j/pnDzj1zG3AvgwiZX5L7gtIVT6j37ekiPvjFJ3WnVkq5Jxt0nZ6gl v5Mh7qBhMkh7lASXOYYKOxUVF46ZzBD8h0ew0C/P83rbX7snnPZNzBB8fk2i09u2GUmGySdPWeQ YHB4EqZRol9OX7E6ETcjVj+u5reO7prWA/USytpHLzS7KLYeBQi8RSrEzrnLNNlKDSOvWLMukpc 7tUodVghIv0pVo2hTkRbLNe0smarjiKo0Aup06HfCpUfMolFZZr9Bxae+7wMEFZBZekmd4AoYxJ e3T5sv1CDezEySaexV8NhwaZ+nZJKILew4WcC+twGVIwpL6/poQqr3+ubwShlFHj/AIbgilIYP4 8NiXhKDPZMJEmdg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Extend the build coverage by allowing the port-mapped drivers to be build with COMPILE_TEST enabled. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index f2c39bbff83a..5bbc7f724a09 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -889,7 +889,7 @@ config GPIO_IDT3243X endmenu menu "Port-mapped I/O GPIO drivers" - depends on X86 && HAS_IOPORT # I/O space access + depends on (X86 && HAS_IOPORT) || COMPILE_TEST # I/O space access config GPIO_VX855 tristate "VIA VX855/VX875 GPIO" From patchwork Mon Apr 7 07:13:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 878819 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69773226CE7 for ; Mon, 7 Apr 2025 07:13:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010004; cv=none; b=Kq6jgqoFFbiHofyvzBIYmPHJLvcND1SDfkN43wxpL1B6QyHXRcsD/eYn0S3lNTxF3LMR/PbFzmkS1RpTqqQA8c1GDiSqcZHekcMrX8RXkedAe511FoM0VC8HxHSf+hy5d0Bh9HcjP7hfTODVbczEultSk8ZFGvK0egv8z3dn6qE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010004; c=relaxed/simple; bh=VbZuTeEShYmVixzs0kIfQZ57MYY5VstzY1jAzTWwLiE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SmxWS58/FYiDi2nNjBilsxVzOjyoFUGZVjqpnc+ukTvyqv8PnZOcswLXRXQqvEEg8jSB/cA3TTp+GT7JdsyA8/x+teEOR20kSC9g+tfPWeau+kdy1tOBub5FgFC0CenPHhTR79gziSQYVRqTr/IXG1AW3ZC2h3e0YiAvuC/Dg0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=0riiuzTW; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="0riiuzTW" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43cfb6e9031so37129565e9.0 for ; Mon, 07 Apr 2025 00:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010001; x=1744614801; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YSDY712S0/Wxg4mzs7difRDaGrtlnIVKA23tPccTlsI=; b=0riiuzTWIZrhgp56IlqIG0qCrZIHSCdjtAeA9ugADbOTZXDWPdJ4x4+KgM/vhsMlH0 lMsbQJ5gO9KUCkIUViznu0MGb0rOa8AbVyl63WfdbA6R9ml23efQWm0da7iiFRarNSB0 N4ZCGaioBoNutRBin17ZX+9wOjhwzZkEqfZawGBw8skmsAV6yrJ8ixl1aXOVEIa53EeQ 1uEkhAQfgNbNSyRcuyMZoA4cht3UpLyOj1j60SriPcqizzZaxOWlUOTxL79ezhX0mpKd O8ugHOKJopApn9WgZC6Ba77jrxwR76rljgkUCdK5IeCOiLW6cz8i7USPLrFKwOlHJOVl hgZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010001; x=1744614801; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YSDY712S0/Wxg4mzs7difRDaGrtlnIVKA23tPccTlsI=; b=cct7O3ip0lIaFsvMj4y8vWCBqC04honwDkPRM+RRtPqt314LB21yLrFIiZz57A3d1I JiWtewPYWd9gXnkvljNQrYo3eWfIHkOTZ89yHdHzXBAHQm2jeKGGfkzRhcqgRG2I5kFS A/vq2+79DVznbEITxMIflUui15HW8vc1tzEMmPQiaZC8LGT4aW5NJrEvjZwGkvX7Ystv PNrT/BpYXXjC3eN4dZs1jwPp8wLvdtud6hM7H/im/nR2jt0rwK23sFS53CJK+C6VWIaA BKx+hlfyu3Vc/AUdSu2bSF031C5Go8ar0RA4y784NGLGcsfz40bLNRMJfdYoZ/Q96Yl/ 6ZGA== X-Gm-Message-State: AOJu0YyajuiKMxXsJwTDtO159qGgoG7T6G1iIIhFh29hChez5pGSGAEU qtWDMfnRXXfka2l3AZtwbXEniL4MS6l9A+DbQ79Sj/RmdWJ5ezd+J92nsyaiTnc= X-Gm-Gg: ASbGncvHRwIzrXeVZiWU+6HxNAAN+cTM2UZRNqLooQbDWRojVfJnOxHtVRh2btohmlP yujOfyjpePMSTBzApsbRxICcV4NgdRpM8aucQz/MLblH0WSoKYGUcGAZf68ioHI3uberdIkpMd0 MPfjSTWkNn6Lyc16D+p9ikSv2XMqeUq9mnSFQEJVZA8d5YcFW3WKfOAw9A3ZQDyQUKNCIT4vxwz tp41bhq/JQbJD7PR82apbMZZ/vuaQ42z1OMtlhUGUPd9vz15NcSNjYrNholNfRg6XFR5+ErNT5E ewdt73lmx6bIykFLzCrMrIkbAGT0LanPE5Py5Q== X-Google-Smtp-Source: AGHT+IFCPF3WdKv/HZWi0huYb++Hp4umiM8q5PvJ/9SfnEDEYHIn12Tjg/kKEV6/HcpEk87YT6PKfQ== X-Received: by 2002:a05:600c:a0a:b0:43d:3df:42d8 with SMTP id 5b1f17b1804b1-43ecf842bd2mr89719075e9.6.1744010000897; Mon, 07 Apr 2025 00:13:20 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:20 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:15 +0200 Subject: [PATCH 06/12] gpio: f7188: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-6-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2501; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=1b67qrjUPm1DOh124uZXcfJBUtrwb+Jww2K8ejW16NA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sJQUhmhYV1wPhQ66erTJWK92WtSnk68vdCC H848tLz6NSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CQAKCRARpy6gFHHX coM3D/4uh4t6KFMWNiPcBjAHTAxxSutRwdhsxAOrRc903ShzmAwt20DNlXdasFgvS2DONygGWCM b/sKbNtOrXL2rxomUKGvZhKYliMxzJN1kw4NaDtWELBEfLGWCjb1EaoL1h5QstUbMx5MsLAmI9k Og6hCkTqVrfAvKos6ihvGVG06oINfTtRspW/0zhLVz3uboaSP4NoxEjln/DHiGPtOh23c5Vj/Rh LsbA+RlT1FZfMjHzoUm7tMC2HOGwqUi9hpitMS1DO6bHR0CsaAF86fjT01LBJu/iKPAAxVDzhF/ PNgbFp4VTqdcDi+LIcmn+o8CFKJF635apTB8Z/heElt78ohUO4j5rGUbTPexJvK9LWlDzrYTXJc JJlOozod4hWPtSch8qjkQq7ZNYpUEfuF/MtH3c6lz5zvSMKVhCSZwzlrR8EE0Dp87W4WIuqRKLz 1GlQkCv5MLnsGvpHAvZPJpEvGMHNfSaWwQdMQAD7vGf62ZRGwsKQuVvkdNmYNrcKHV+M4BUC0Sh Gj6crCBsmQH/PQy2lBbBoyALEURBT2mwmwyMW38NHdIbcTGlKmP9nqvrx0YYdnDbKQG7e99TPo7 /pe+YMOodLFD9mYLFDydKk/R3nK3aabXU/OFVZJGDPUtABuUUj/G8GWOC9WjIW9UTopbvaUKVci jvsB/2RCKq8EXFA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-f7188x.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c index 3875fd940ccb..dfcd3634f279 100644 --- a/drivers/gpio/gpio-f7188x.c +++ b/drivers/gpio/gpio-f7188x.c @@ -159,7 +159,8 @@ static int f7188x_gpio_direction_in(struct gpio_chip *chip, unsigned offset); static int f7188x_gpio_get(struct gpio_chip *chip, unsigned offset); static int f7188x_gpio_direction_out(struct gpio_chip *chip, unsigned offset, int value); -static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value); +static int f7188x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value); static int f7188x_gpio_set_config(struct gpio_chip *chip, unsigned offset, unsigned long config); @@ -172,7 +173,7 @@ static int f7188x_gpio_set_config(struct gpio_chip *chip, unsigned offset, .direction_input = f7188x_gpio_direction_in, \ .get = f7188x_gpio_get, \ .direction_output = f7188x_gpio_direction_out, \ - .set = f7188x_gpio_set, \ + .set_rv = f7188x_gpio_set, \ .set_config = f7188x_gpio_set_config, \ .base = -1, \ .ngpio = _ngpio, \ @@ -391,7 +392,8 @@ static int f7188x_gpio_direction_out(struct gpio_chip *chip, return 0; } -static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int f7188x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { int err; struct f7188x_gpio_bank *bank = gpiochip_get_data(chip); @@ -400,7 +402,8 @@ static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value) err = superio_enter(sio->addr); if (err) - return; + return err; + superio_select(sio->addr, sio->device); data_out = superio_inb(sio->addr, f7188x_gpio_data_out(bank->regbase)); @@ -411,6 +414,8 @@ static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value) superio_outb(sio->addr, f7188x_gpio_data_out(bank->regbase), data_out); superio_exit(sio->addr); + + return 0; } static int f7188x_gpio_set_config(struct gpio_chip *chip, unsigned offset, From patchwork Mon Apr 7 07:13:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 878818 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83381226D1C for ; Mon, 7 Apr 2025 07:13:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010005; cv=none; b=gKyi1UrgQjkpWxPje/V2b63DRnoIEz59vofM5K6i1hyzFayLlOeVsk8vgYnOotp5j0OzVSRdWUQ6txhN2SvGoGGbvtaZPQOmuCYg6/gFcogx31ufir9jvATD1xsNsQU03jc8Kzt6Tv6xDLGRGNVe26hwrpmd2ch29U8l2qxdySs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010005; c=relaxed/simple; bh=oI8jFuu+5ewRpLVvmH1QLq08rzgici9rugihnGgwO8Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=srrp2qMuCFaZkShzekTHK7I1e/Lp/erelNW87VXGgAXT+Dbu1UE9y374cyOtoROTcpkLFhJti72/g7E9/HmGZ2H4ZSynmR4IACfV/nYwKBbwwI71soLJWoegvQw6Y0iuNfLdzVJq7dGGCKxLJ5EFkc4HI85H2coOWEhYzwaUqmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=K2zfGrKA; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="K2zfGrKA" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43cec5cd73bso20520855e9.3 for ; Mon, 07 Apr 2025 00:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010002; x=1744614802; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hB1zg5x6R3SiUZ85Ns06SDd5X1MvxEj0zH8XpRThS6M=; b=K2zfGrKAXfq9NcieZIw2LY8YgS+cIgn1g3lU47gra0WwfQOcDEQl5KBtiiLDUNpsdw W0/+OflitSQl9f9ot42059OvbNFyk9m2ndyItJXJNU5EWG6NTVOskmahrRFsU/qipLk1 ncp3BLM6dUoaFMMJDntjlsYUpj2Y3mfnuAS4dNlzCCfJw0xWEv5FYV5scf/HxKzvAbOn FXOx+KJo7ynuzv5lrrH8qs9iyDHOVehoBg7tIN6pTRJ3HF/HDqFJfPuPW+sGwewZUk0r zX1VYLejLplYwGCnUNI9obXelGyT3W5nCPceyYgbc8PSvJbwCJT0KCfs/h3sKnjlLmwi K1lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010002; x=1744614802; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hB1zg5x6R3SiUZ85Ns06SDd5X1MvxEj0zH8XpRThS6M=; b=qfv+Daw+IsWpbrnw7vJBbB3WRoS9l7bAuDVG1w03hu5+SjhPZeY7zQ6PK+FQfhPTGH CA6+sAGzdAaCJDMaP/pjcw9/4fxaocQ6dhmGv2iIc6nCEN0haCMxNeIBtxAc64GfCaLZ rC8IuAYCaNY4t7JFBmsIxiWC9fFomGxc8PnKUWi22UKqjSzJgb0MIaWv3PqYdg1oF5Vf 2hdV91O/sJx/wP3Q4R7W57D2fGfB8C3DhlBHfac3kMW82ZXHSwvEwDe/N9CaWfSxhXTv BXVKks+xgfvTs2qVpmyvvBANQ22v+nVgK6aTiafh/lys4Vr6qMZAMOrwKUR22rM3HDWx GdCw== X-Gm-Message-State: AOJu0YwenG25jXyj6722rxpI0qPXvjets2lSx6rPOrDtgw1pVmpHgyxr MTm9IXAVEHkEjAe/zBNSXQWDwVFoY7DzNGSD2tJyxx1Jon6ytRH1kEYwHcPq+J4= X-Gm-Gg: ASbGncuvPr3/BoanuNx/CpHZ6ZN3RREojDBwI5XOS0nH7bmfr0fyKY5eXsnxKBhSIqS hk05BYycTUJq2aidRfq6kyC8FZFpgHo5AMBUcgOs0Oo8/vvoZ2E6VkJAIV/d68D0QdyHNrdfhDY llXnOVcMnE5PwKJMoR6+QwTo86JrSZjaxqtG2r2JqUdtSqZDkstNS100dJtxI8u2++ndaHBNv6Y FMtjrKXdfnK92Z/w4Hy4NVPRwGZopqbQgAcp0v2UYIrTHczVqVsT0PV0x8YXdJmcsYmxb2cFnP+ NK0KFEn/u1VplNv27TT/IG9P8w4ucbHbrYhFPGeRM8FDJy83 X-Google-Smtp-Source: AGHT+IG+8TMtVOLwysJgLXWutF3235lf6J36NhuS+eEkLI9eABLh7Z4hMkr4mZwyVMSe8Wd+f1kxIA== X-Received: by 2002:a05:600c:a013:b0:43c:f8fc:f686 with SMTP id 5b1f17b1804b1-43ee0616fedmr85970475e9.3.1744010001770; Mon, 07 Apr 2025 00:13:21 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:21 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:16 +0200 Subject: [PATCH 07/12] gpio: graniterapids: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-7-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1568; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=dvZDsrn97I/vO7JgDNAuyR+iCv5I5MBwDV+ZdiZtp8A=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sJG73Q4jjFPBt8Zb6Mg8jP4uTF4MLMf4ktG JGHxv+rP8GJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CQAKCRARpy6gFHHX cok6D/4nVkIJvxYEpyAaRfeyiuHoCE/wuSo+VCjbRPlpk7Ik/pHTuiz6bPepiV2lQVNRiCCu1Rk NXx7IJKLAEmTWc87kA5J1j3hrh/y+i7hiXuRmrXrmzCkV5a7eEQHlOU5FYQZysRDpMUT25cLX9s SHs5mvJPGwn3JqLaB/iih/QRxfKdVCLksRqIOnIl8BN/vzGXJKV8wI2PG1sItwDf7VWCirfbOlT 1gHRw2+U9MZdPvqagXGO/JAVEF+b3r3HBNeAmU8JUmw4AKSmxShpwZtbOnaHn9XoHVmhmSLzk+O VfHfhbF69znTkdOONBqlKh3xT5GYXh6lQo7fn9j7WUL5mWRCgU4baebZ1wpRdvm4OY+rFl6B2bp w+pNJH6K0Jrpg1zlDOxANl5p1GGdk/6Uwptk2SLDIuGY3yaTyYJO2kjZmoBMf+T+CoYDccBzZQB dddhPZGmobWvRwC6BPUVVPgLbMstcQJ8EvdxaBCZfNt/uNpqouCWIDPfACeWsSTt9VRfMK+lQ8a 3B715SVRQrChiPP565MmQGrqv6ZOc45Wy0WYGywbNihzG6/H5AOfdIrglPTXpBfiL3lN/h1gdpG s39skJWR3Pg6SVZ7UjTdEx4mpWRMUIpGAK1yG6Oo9SiopvVZSTgbZ+Labjy2K+r3a2CoD82gKUG G0XWtfPtH/eVi3Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-graniterapids.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-graniterapids.c b/drivers/gpio/gpio-graniterapids.c index ad6a045fd3d2..f25283e5239d 100644 --- a/drivers/gpio/gpio-graniterapids.c +++ b/drivers/gpio/gpio-graniterapids.c @@ -116,7 +116,7 @@ static int gnr_gpio_get(struct gpio_chip *gc, unsigned int gpio) return !!(dw & GNR_CFG_DW_RXSTATE); } -static void gnr_gpio_set(struct gpio_chip *gc, unsigned int gpio, int value) +static int gnr_gpio_set(struct gpio_chip *gc, unsigned int gpio, int value) { u32 clear = 0; u32 set = 0; @@ -126,7 +126,7 @@ static void gnr_gpio_set(struct gpio_chip *gc, unsigned int gpio, int value) else clear = GNR_CFG_DW_TXSTATE; - gnr_gpio_configure_line(gc, gpio, clear, set); + return gnr_gpio_configure_line(gc, gpio, clear, set); } static int gnr_gpio_get_direction(struct gpio_chip *gc, unsigned int gpio) @@ -159,7 +159,7 @@ static const struct gpio_chip gnr_gpio_chip = { .owner = THIS_MODULE, .request = gnr_gpio_request, .get = gnr_gpio_get, - .set = gnr_gpio_set, + .set_rv = gnr_gpio_set, .get_direction = gnr_gpio_get_direction, .direction_input = gnr_gpio_direction_input, .direction_output = gnr_gpio_direction_output, From patchwork Mon Apr 7 07:13:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879182 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41A9A227B88 for ; Mon, 7 Apr 2025 07:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010005; cv=none; b=incdwxvXStfZGP8vfkbG72dLl9znRkwtdl7L0PnyRgDZQ6u0igu5tlaxzsEEscR1YGfpDZzfY3ByW0kjxWaMpSfqqdGGig4e8RYOCAclUb1le/4eDZ0qzuahOvVsD3Fl6mNRVM+ila7a2sXy+iplOIJzIT7hRbT/5qDJZrefPJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010005; c=relaxed/simple; bh=OB+Tod0EAAoKXa54jxrVo7r/BJieP2+52anKQowSyqM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p8AYYtpXAMKy9jVZ4KyxOUxOyLmL3/obGdeuvI1JuugMxO6o2U+K1LLMrLo/uSiYv9bnyDOzl5RuDqppOPAiVlwwNN4opB3bpCijYlypaecrd3mhvyDiY+aRKcSSuh4/4wdj3D8ZTNzGhZTs0Ip3DzwLLHUUabgTQnzau9vVMkQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=aTviwnLy; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="aTviwnLy" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cf680d351so28839505e9.0 for ; Mon, 07 Apr 2025 00:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010002; x=1744614802; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yEJk2fgoO6xuxOx17RjFVCvTWlWoQ9V0bp3uC3N9yno=; b=aTviwnLyRJmiJJ0EC89Ngk8e/gC9fZHxnRUuNB+ejhsA3xq63t2EeT/GLX7cvBAvbb exKQDXi097RqfNAmUvFVLAWl3xfVtZES5ZkFU/3Banjz4RwptzYctqtsElzR6dNmNsbJ o1yyfVkrO/eqZRfAf3/uL9XUSsc+u8ICTvzwlzhq00u7XqFAFICNgMqei2dOowPq9ir0 m740/zwpICXM5Bb7jVp0rFAV6u4BaqQGi7Tif/dXor+blBmsQnYCzzuSk4EiNpUVkv6t f9YWicoZv4fGAgcBq7ybL9s6OipqNRS/OY7L5ldKrdZMeM/6Vbu6NYlC0o2WHvxWFt1u c1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010002; x=1744614802; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yEJk2fgoO6xuxOx17RjFVCvTWlWoQ9V0bp3uC3N9yno=; b=KXsyYI232MAu9NfovOC0sC3toeq1ccm+ecmYAqxt6+OXSlMdjhSRAcwB7IznURG/gZ +lMUh4sqQ+zOQPVj+6vSlfKV0jHcivm61JRypIHYzCszTjkhD1K+P2yU8LaHC89CYNji gr5Th3E0m9DpLVaCvccvKmai5R9FsmFPTxxkUW2sNc+FIHgJORPJIJ9v+567S0X6vWLp aESKrD5IkomFVObrEX9KCRoVVqlKnqNpSmgmgcC2rv4Z9yBkPjJN6G48OSGyspnrDh9w ztUzk5M78DP2urxPC+r/zIiEPtvza/ZlyM9w4a/DFLyfc/wvp+k/NrimMb9l2gZxLejS M73w== X-Gm-Message-State: AOJu0YwpWrq+GBJQCJXKyfERGn9YXz2ds6hnnlQAufTrbd+lws6Mju7O ScDOlQX+CIgtM6xUHe0XLm3HrGaNX34SrT5I18CAZ5gHtJ0f6ug9Jcdz8RTsWcQ= X-Gm-Gg: ASbGncuUmW/Kvhl8w4ZgtC8dUKuyKGB9pNJAUIyrnTOcMqcx6ILP5eenYp4wtNBwLdy 4T4eb1MsGHBSg3m3hKd5X62I3RCuIxBMVDvdyOIMDQzdu2nbSxrrTF6T4/Oe6R4NsnOC+1XIY9d wAAQlUUswqSFP9igT4/bcPBGocf6dm5VkJcGeyqWyHoMy/DGTVSgteU1rQ/KgVzKmaRbPFfHyFp ibE5BvfzaePmk1/hT9egsnhSi/tMJJlgyl9/nxlRaWUG7Hrv/DgKAeVQIYp9Xloow//0eT4sD7E jc/2Zq9FhNCMN8QzICw3LnD6G2HUT+Yzh0onpaCqvwm4XdGk X-Google-Smtp-Source: AGHT+IGQFtkqG3wC9PlTnS9PdEgWUDOmHi2iesezrUO2BuhVyGIBzJ/lLkwgSOkeE2y9buDTHgbKBQ== X-Received: by 2002:a05:600c:83c3:b0:43c:ed33:a500 with SMTP id 5b1f17b1804b1-43ec630446dmr144575625e9.10.1744010002619; Mon, 07 Apr 2025 00:13:22 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:22 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:17 +0200 Subject: [PATCH 08/12] gpio: gw-pld: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-8-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1261; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=B8G8UgFVEWwfpU6misTgZDHXnBftCijWCVk5K0R7qTw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sJb3Oegu6ayXdu37b/nOtXGHZHU0peJ1XBm F0mOrZyysWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CQAKCRARpy6gFHHX crfGD/9I9fXNiLVMd5LIcVDpTYjoPujtaOJ/uuZhqNWwmdJOSOQ8F+hkoSWtHk8j7DzU2oOsoJC t/YwtpS3NfvLHFJJeF58vPQTvYjqSSRtBAsjytTZ6mxXSQ3Ts4rhISO9i/GVFvOPSnvB13AOQ0l lI8cLA6dpBvLmvqw0JMvUMWWCMYBQiosLvripXgLdur7vw10GOHnf4doIF7ViJCEFSupSzl8zIt devI/j+oaUnw0o178HxEDAO8341jx6IPfzTzIRwBtHC6o3q4/97KGs4o/bLuYUnFwfHru3V6WKc isQiT1FphGycPwrE0IpkgHdTadFloUAG/Qz9YjBVci3HxRoaVS9er7n8pLRMkH2PJf4wy/oVs+l eK/LouTu7Y+CkkkflWvFUBz2sNgyXbrwMlBgrKIeOcdUyqObX8PwUZHya6sHJFDm6m1mhmrP9+w R86UBf4qJgs3kmKH55AfKAVNJwePkrkBhEvSUsc14xUmtJHyVjGGvXPyteFQ3qJ73q3Mkm182vR OPOQ5d1NngUCNOqOYAP+aTQyEBH+/TKHGtHVRbofSars/K4zYiAIgwh7BYZcJ5RL+P8TmvWSByA cdekC4GPE/MzSiB6cXLjHYvCweUujad58sM2vSrRSKraM1HflRCeY0bmZ48u/QdyhZHi7PPqXDc 3YgPBpydQY4GAeA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-gw-pld.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-gw-pld.c b/drivers/gpio/gpio-gw-pld.c index 7e29a2d8de1a..a40ba99a3aea 100644 --- a/drivers/gpio/gpio-gw-pld.c +++ b/drivers/gpio/gpio-gw-pld.c @@ -62,9 +62,9 @@ static int gw_pld_output8(struct gpio_chip *gc, unsigned offset, int value) return i2c_smbus_write_byte(gw->client, gw->out); } -static void gw_pld_set8(struct gpio_chip *gc, unsigned offset, int value) +static int gw_pld_set8(struct gpio_chip *gc, unsigned int offset, int value) { - gw_pld_output8(gc, offset, value); + return gw_pld_output8(gc, offset, value); } static int gw_pld_probe(struct i2c_client *client) @@ -86,7 +86,7 @@ static int gw_pld_probe(struct i2c_client *client) gw->chip.direction_input = gw_pld_input8; gw->chip.get = gw_pld_get8; gw->chip.direction_output = gw_pld_output8; - gw->chip.set = gw_pld_set8; + gw->chip.set_rv = gw_pld_set8; gw->client = client; /* From patchwork Mon Apr 7 07:13:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879165 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F01B7221F12 for ; Mon, 7 Apr 2025 07:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744011489; cv=none; b=Wt5Qcje4ivJe6DLHvjOiOIaZCCbeE0QAX48OYFDAXjvpHYQVFABcnyEDyAxL+GM34IvIYU+wBxIO9iL2zbASUsoX0iGW7tgZrarBstjPIa0GDKnGABGgFiVzKqy5I+ZbydTpqh6Wg2R1OC5bPTX/WoA7WC3dVDH4zMeLCFL6YKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744011489; c=relaxed/simple; bh=n3y5S+O7kQ6BuzA99tkggUIPSJO+2r1CKhEXkaomFp0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M2PzJ9EO5N9zl9LM7/lIbJ9/TodyRr88brmeF0HiHIrbIVs/Rp5tCMrnnvKpbIC5Hv9SOxFSakNZX52naliPuQ6Z8n61/mu7jBTDyA0A/UBPg8tvjB7isOY1aR4y4nOPbl1hZF0MFuk3Q/gBH+wwT7LHG1mYvk6ORmMWMZM5cyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=RYa1l+wL; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="RYa1l+wL" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-ac3eb3fdd2eso416406066b.0 for ; Mon, 07 Apr 2025 00:38:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744011486; x=1744616286; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xKdjaegSMAM/rqAxMCD9Qx149zQwzIx25XoQ9FIROmk=; b=RYa1l+wLBzgmaNKvb8FBqxT9BR9KcELWq+iuUf2F8T2BYpVrzsSc2qC9vtrVRSG66V fzBtzD5gIOrTbKoBzmyGoJvlMpbjG7N0Yttb6zMVydzd36TUitSLjRfkcTwaPOJLEsqL Kx9YA0+CJ995zBOaAaRIcMI4aNzfj9vzLCapx6lcZUnlGJkOCOcS1QaBf5wpym0dxSmb 8/pMDjYlWBXHcBcIBGgVdMpqb4DkCOL+QlhFCIY4k7bnkDtZTYURGiLQFqlZe9jIbHgc x867yr8LCrRDNJqV1Cm3axXFulhz4vdyiA9y/OvMiKz81st3LOG5NHe+JXupienDokqf lKxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744011486; x=1744616286; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xKdjaegSMAM/rqAxMCD9Qx149zQwzIx25XoQ9FIROmk=; b=GCpHPgEt8oKhBbKdiOKa9S+bzIf+K5DUj8TogCRo1gYIbGz707BrOre0NmGuAnTiiz W2O4L1Q42IVhLez6ExzY3+3IHFJnhVfNyP+15i6y/EX9J45DNrhk6VlognGHWjY9kKzI YNm9XW6sBouZWfvADr0GiWU93aOVDEeVSRFEl8Evtw+auCNSlBuT9X3PZrP9k9E54H7P A5psb6XA8dFIidKz5KwKltKuPYwtm9kzUo/wPIkbKNzRt3WFgVxbtxvXlql1Xjvbemog kvIVdxL3+TZ4LIVZ41Bg7DTxpLcbeVEqfPP1kw03rXP9ZlRAFbvtSrRwCvchvwKr5ndW Rwfw== X-Gm-Message-State: AOJu0YzTsH27T/T9Io4D/Ri8L3kClODNWxHhD/7UfNpiJFvC8HRyIvJ5 df/SgUL7bQJ8EniIkOYs/g8ZqpiwdfQvDrlzdmteCP59IChVxvm+ZvZVweKCG3eh9Ytqu/rsqad OPYc= X-Gm-Gg: ASbGncs/3dV61DGbETyTfBFuv5Xg8+5G8/jOU0OMSGC+1QrFj42f9lFnbRVY6RhRbnM Czul0rKqierS96810BIYKsFTlnaYGVrQZW8m4I2XKnkIkxQxWDsJOOVK9Lw8lmWEVXB3l2SIFV5 CtzowkzksV59z1NIhDx+107RyhTSND+yoARR4zCejyIAAACSXI3R0PRgmsBMDwUhvfVlUa8WWbK 2w7kWxnKdfMxqsU9wea4NmexxI5f8HBLllAnlwuQYDaO1QnsVqK87Nj9JZphIr4toUxGyGgu6lf +U9D4V62DhN2XRuOzgcwMfkzkAwEqzmfeCxIrzEeIqRZLKM8 X-Google-Smtp-Source: AGHT+IGVJL2F1/8I/lWwJ31vPm5jJXx6hPrzpL71kYNbYKzzALSjHc3IlX+0r79eE3W6Jj2Qgam/hA== X-Received: by 2002:a05:600c:3ecb:b0:43d:7588:66a5 with SMTP id 5b1f17b1804b1-43ecfa06563mr113287175e9.31.1744010003499; Mon, 07 Apr 2025 00:13:23 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:23 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:18 +0200 Subject: [PATCH 09/12] gpio: htc-egpio: enable building with COMPILE_TEST=y Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-9-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=682; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=KsRxiW0W4vPyxl96QeRBfnOsz6q4m3Ci9vZGWLs5JTM=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sJFjAf8szaIrgU5fOqH/7amZ26nGC766Hem EIDJGZEXr+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CQAKCRARpy6gFHHX cq6qEACSrOsrL/eTz+OWDhz4LW60zXJaDDg5Nuceeu5AW1ALzN/2p0KC/vTlpXXplL6RdF7BLRf 2hgVRiqsLE5E03qR0u/5QvjgXLpcIZLvA/diAZ4XpZ4snRlDvtCxE0PjAFuOHG5bY3TD5oJXRHZ AYjngYn1l+FQwvCZbDR1pEgQdgx11SkyUGQduyHYyYrYL1JqGwJpe6wGTNUHAUxAHQL3FvVnVCI 9kERiaMzIwJuLFc/Zl3M0+O67yijJGaMVWhLu4LuQ/lXL0WLApQGgc9ZfQJbflHt+N6v1ks4Hcn ckZx0oGiwVo2rrKoTI9s/LKhVzGqBocBtL6md2qZm/thsYmcxHiEAaoQyF1Hq28m7b6Nbd06T7L mPbAEcwvF66QinqBunjXweN2uCn4H2323sSgaQk2aD9ZCV17q72vySB1My7hgAGeylyutpAfM5y W7dYHtRhWpYpfdF0i0BVuv9A7TWKT6GoaWCKVezB9rGzX9a4JAniOrnnACa8w85M3GkxutuiqO1 0TmbiI1/mcptGer4guYOBZkhxl/oDwmc0/GA5d6DfPnXP5Bzp7l4C7GjsovTpIFNyrgRhm8fDhS WzOqAEi4kuFxf/EW59WI5sce39+te4RlicHYmTDxAJWuSfpOE/mKC11EQughtuzgyvQHJ1bBLFM gdvtyhemCdzldcw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Extend the build coverage by allowing to build the module with COMPILE_TEST enabled. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 5bbc7f724a09..decd150810b7 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -1365,7 +1365,7 @@ config GPIO_DLN2 config HTC_EGPIO bool "HTC EGPIO support" - depends on ARM + depends on ARM || COMPILE_TEST help This driver supports the CPLD egpio chip present on several HTC phones. It provides basic support for input From patchwork Mon Apr 7 07:13:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 878817 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A881225791 for ; Mon, 7 Apr 2025 07:13:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010025; cv=none; b=arW8eiV/FqVrJguH6AWdgVFqBzCYWBLTnbc3Q7rDzxzx9k0Ig6tr50Q9er8PdhlzQUSOIcZnsi3Rb0fz+nVQWnORw/QWJhRDydShikpoKsvz1nnMl3pOIR+3kWhKIXWUxcO5O8XUV5K/SfoLy5V/tyB/75emZGtwEXsvfDayAxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010025; c=relaxed/simple; bh=2smVCm4Nk4w6RvDJ4CqdV/kiPrD8nX20fQhszPXa8tg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L2wMj0T/l9M46OmJkZcofVySzoD78IS+zIVC6bx1K0/1YG7nMv3XfwMsc97LDUOKDpdxbldyI9zg/NLj9R8OXWdnFV3hbqtkuqQj3zeS0c1y+9cPt1dbHQVzHipGp+ZDozwj5bh/yFINKePiJa64b5Gva2y+EN2+kZ33bNShW3U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=PoK7OOs+; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="PoK7OOs+" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43cec5cd73bso20522465e9.3 for ; Mon, 07 Apr 2025 00:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010022; x=1744614822; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B3ZLoOGIRhYWLQwldcB7o4t1OYiqucFtR/EYliiQwSY=; b=PoK7OOs+P2NWjmc85gQg1kBwLJ6y2F5hikZcc0FQ3/cKYyCs+46C0NzfpK3VZ5CG3L WHOOOvhB5UNsDrMVWxeIO6IOwaQ0nPQnh6m7rgMIjKDN38cOjeXey/wogPxEGTVpm2wH 6x5sh4yizKVYJ6UL61ZXJYUN4R9PaMjQVtTeclErC/eTR4+/JIXIviXLMQWDg+tHSAml XAGf0mtqk/snwTqtmiinjnaV0wrOGNQ87SiKSWnxsjbIEgBBUru0bF02hlgCrJnBhWbZ +c4xJdF8shGONg9m6EwZyEGkQcYF0cZa22Vu6nNt09ojWBuoNe8jI+aFb9cc+9XpXvhX nX/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010022; x=1744614822; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B3ZLoOGIRhYWLQwldcB7o4t1OYiqucFtR/EYliiQwSY=; b=W32hTJOyl+z7GXIY/tSPAxBxI+PeWijAiLOOh1cJMl214CAC+XDJwf1IlA7Y2wuU7K FJu7ddYh0VkSDmOAlOJ6GQNd+uiqwfdR6bJQk+aUa/dWcp2ta2h2b/c4AmpAnHh3W5O4 NWBobiN971HMdeY+lFIgLGTImmc13UE6B5FiNoIfts+txX/Myc0j2lN35gshI7Z/PFBg n52+IF7bk3rI9W1PXECuBmOKMD0Vez0Fwaj7tpc3rPypLUV06WlR/akDYl/VQSw25RRw A6iLBP4WG0dcqta0HD2G4nmdwhdG8iVxK3KU2mxY1QFtuVLq5EDbYVhrMRACEfTQkTT7 i6ZQ== X-Gm-Message-State: AOJu0YweYl2DdLq0X+77WcU0ISR8BHdy92ulqoQ2KPVcRDkOWYabJl9K TzGZFsOmxLmZyIOJ7MIsTrt57s4Y4odauZS4VXq5t5LorvxXA5BIADnZUDXu0eA= X-Gm-Gg: ASbGnct9oBx2dCedAk6JrIHK2C5XHQO7Re2WyAmLQNcqzUpL426a8vjOV+QcWly4hkq 8YDH5j21LT0LlpDSECdujLr43No2lx/1xjqcL2sb2N0QnqJHDKDsht/Bk1NAbTNuRhCyKjqH+9p 1WpBl9/r1g2bRSizywZZUqFoJ2o6rzkn6Lv7qh8zW/f4n6HVfO+p6wLJmIxF5GiBHRlYZKS2XFC gMg1bJj81nxUvgDO94gCYaPNkJNs+U+30NWJi9CqXbzu83QmzQ4XYQuOpE1DcH6kXWr2UfGNLUt zRaW/jY2hU+/NrtstD0ioHCOEPnzvjM0haj+zmlxC4txK//O X-Google-Smtp-Source: AGHT+IHGaYmYpxNVnlyOG51iCDGtU+hWITXEbdFp5vavb6DlKfFZk7Ry0ytW0HLUXQjm/j4UfMjV/w== X-Received: by 2002:a05:600c:1e0e:b0:43c:f5e4:895e with SMTP id 5b1f17b1804b1-43ee0616fa2mr64246275e9.1.1744010022069; Mon, 07 Apr 2025 00:13:42 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:41 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:19 +0200 Subject: [PATCH 10/12] gpio: htc-egpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-10-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2113; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=/0ieRZabGPzeqDnW6NtaCAv65QiJcpFkSEoCNKaBrcI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sKCwFZg+pd2UMOnz6PapQrLb1sfFgqPsewe 18VkiXsPOuJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CgAKCRARpy6gFHHX coIpD/9SQklsSGCPmSQA469tG2UiGGue5EihdJi/WdifoIEy2qA01bF80+nYDeSB7I7/5mEkTfM 2u350IQaN4ougKJsPGs9WkWp6N5gObAITokFjnbLXZE/8ooSpShmVBNBYgvMkF056aN81p5/1RS VGflKBLet3lS9VKp5SBbq3nr3v5Kuz7TJio2HQtBl06gonn/LBCcjTL/hxGVtBnbd/iHpEQBW1A TH2BoN1i/avF9XV1QXKwkJPHdauISYbaK5GbIzxeQX+hI+EkOMeKswMyLWYMBbgqdW10/UrUoHc q4vYEVK673bVlRiNamQFMImTBHtWM3yTZMFNf9qMjWhTxi+KNzMqlXeBnXzRuLbMpYoNwjvZCgO 6D8wtnM0RmtrzPKkTOmdSmQITxOVBsQzeX7WryVxwyvA1VTel/AskV+OysEySia1y8aMWFGPp+Q aY5RNmlQURlaS8sXyd1ukXqolnyJYhs7XHAJ+sp2iNCocr4xO0QgBy5AL+mZDQbWZ2/s8k2oXOj N1lSBX1mD7iJUqeJDM6K/it0PYcHtZuJslM6z0nIRswJMHV2pmzwxn+xC77N5T5VThA50jxy+lM IdV5eGgs61u8TzZyHk1NVbYVJFPEw85YAjgIgqtWa5W8K5ffIy2yh1Xb/wXVJuHPgc9tBoCbmQi GJ6rz6KPoPxJYcA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-htc-egpio.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-htc-egpio.c b/drivers/gpio/gpio-htc-egpio.c index a40bd56673fe..b1844a676c7c 100644 --- a/drivers/gpio/gpio-htc-egpio.c +++ b/drivers/gpio/gpio-htc-egpio.c @@ -170,7 +170,7 @@ static int egpio_direction_input(struct gpio_chip *chip, unsigned offset) * Output pins */ -static void egpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int egpio_set(struct gpio_chip *chip, unsigned int offset, int value) { unsigned long flag; struct egpio_chip *egpio; @@ -198,6 +198,8 @@ static void egpio_set(struct gpio_chip *chip, unsigned offset, int value) egpio->cached_values &= ~(1 << offset); egpio_writew((egpio->cached_values >> shift) & ei->reg_mask, ei, reg); spin_unlock_irqrestore(&ei->lock, flag); + + return 0; } static int egpio_direction_output(struct gpio_chip *chip, @@ -206,12 +208,10 @@ static int egpio_direction_output(struct gpio_chip *chip, struct egpio_chip *egpio; egpio = gpiochip_get_data(chip); - if (test_bit(offset, &egpio->is_out)) { - egpio_set(chip, offset, value); - return 0; - } else { - return -EINVAL; - } + if (test_bit(offset, &egpio->is_out)) + return egpio_set(chip, offset, value); + + return -EINVAL; } static int egpio_get_direction(struct gpio_chip *chip, unsigned offset) @@ -324,7 +324,7 @@ static int __init egpio_probe(struct platform_device *pdev) chip->parent = &pdev->dev; chip->owner = THIS_MODULE; chip->get = egpio_get; - chip->set = egpio_set; + chip->set_rv = egpio_set; chip->direction_input = egpio_direction_input; chip->direction_output = egpio_direction_output; chip->get_direction = egpio_get_direction; From patchwork Mon Apr 7 07:13:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879181 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94131225A29 for ; Mon, 7 Apr 2025 07:13:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010026; cv=none; b=X0QK3nBDYZ9TD+OtHIP8SVbbdxpWXsxIDeZo7UQaSLON2flghQmdvpBE+95+Joppjnbo/zn1WOO0qApy3o4YqwmytRfCDypJ4MafBLXm1LDATyVWzBcnHbqXBZWVMlIYvqtkJTvc39HQo8jgZTSOi04wVeq+wUZP/44zNYp/Elc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010026; c=relaxed/simple; bh=RMeEkXCBW8iv2Y+TFnm82PWhhfZrUm8Jf3ZdZTz0Iys=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=berw3OiivWFTFZ7fO/HY8xAjGE5h45PL++gNYWw51EJhsvwF84sCCJ+boZgoGipmNbk8ubzSU5+Wylte/dAdn+eCujuGzU40UCSdbVYPBk/vfKvdxaNsKHLrt6hwKUu5d+KeJQkAPdMAknqzD9yZtxHe0RFFQZvh1PwqpLQgNyM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=gV7LuCbS; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="gV7LuCbS" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cf0d787eeso43903085e9.3 for ; Mon, 07 Apr 2025 00:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010023; x=1744614823; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j6qJH3D3dcBUxqtqFwZKXZHZZ2wy5A88ZUffj6LjIWU=; b=gV7LuCbSC9NpzJvpFjFJw6BhfhnOVkD8h8Q17Pcm00gBwdyoOXzDGMTgSXgz3GTRBa pOAAagRz8A6TflbdJK1MVDAB6xUQUL9XS2ntIKSm68OkMR9axn5H/dk2kAWPnUCwYAKC 5Am24Huu2D7baoPC6NIJkWWGdEfmnHWIMREWNgOzqwwHr9iKM4NDKhQBvXX2ao1fxBeF 8y/fz6uCOxRdyEm3+uqkKCUUm+ngRhDjuYZSIVVcRdctjHVmG1IUYWgmIrkHRyi0U99j 5N5kDyCTSSCUVTMIQVPjoZceT7Nevh9sYq9jzgI30GOfzJGSvllywIm1MddgpOvl29A4 cBUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010023; x=1744614823; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j6qJH3D3dcBUxqtqFwZKXZHZZ2wy5A88ZUffj6LjIWU=; b=Jxzrgwk8KasI+2QQeA+biOuGjY1+JVc1DiQbFVBbt490PJRRU0371Ol+291L8AYarG RKgj+SGWxw3FAdtBNheoB/VT/0pP5v6Sgj3O313pfNywyUuOyqU5cm27NlMpDQBCkSzU cnbMt38sSxSh5BW3fw7x8X228Gp+X4LNj6kLURdBLYAJxy4xsrg/8hdVBvxFGP9QLOWN XCDqK9UqPHZHIeXpGsPpzrGlzoujfqmdXwWnrN1Vj7LKoxKS4zoXujAX/Cdh0hTVB6La CviOm6LSpWjXaQ4fmf58IEkNb1EodflE1cfiWx3FgaukLFqaTPjKykBlbFe9SKgrsu1e h+Kg== X-Gm-Message-State: AOJu0YwRCENuLJMMzZhjfvc86nQTZpUsO9jQyGs8wM8tepKNgfr9VlLR u2Y0zx7GLWMYnIfRY6MSsClke4XIEvR3qQqBM8KNLDYR8cP8OjXYQwJ3pskBom8= X-Gm-Gg: ASbGncveMRlDZ+xxj3uR5wxBpravmbtOmaEVkQZPz2ZH+NlNQH8cD4KRlCtWUsTpLfY xOb6qBmaoiLm9VbjbKaThiO7/gKZt+GUd9oCW68c7fck5PMrXspKAPRSlOBeTQFlxI6yki4/8rf efJGgoJd7LTWbY2gLARTi2rCEFhtXW5Vf9ZJKB7uutToenqsUp+0k9NQ3B79Szc+HuqWCfGiTjv zEYq/rRDrDF2WcWjl6/Giq8dSKIsp9wu9zWxunkxApA8fA4MqiJVkSrbLKaW7psTsmC/+Q/qNWQ yzwQjkrWO6kYCTYydr8CPYyT3R30hgEqlBHPpQ== X-Google-Smtp-Source: AGHT+IGloGrcf25Z1YboLqoCvQQRV0Y4rY1PSNSCcByOr3ebw5HNYIigUdFfZam8QEEwbOxo77ft4g== X-Received: by 2002:a05:600c:46d0:b0:43c:e8a5:87a with SMTP id 5b1f17b1804b1-43ed0c6ba07mr105183105e9.16.1744010022878; Mon, 07 Apr 2025 00:13:42 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:42 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:20 +0200 Subject: [PATCH 11/12] gpio: ich: enable building with COMPILE_TEST=y Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-11-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=743; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Y+UpgWZnyfT06S5T52WHDfnqlvKJzPXnZ8Z2mwrPslg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sKsbO4PjLSWfJMf5W3OYBOsPDhiWwXtL98H 1CAtL8sG8SJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CgAKCRARpy6gFHHX cjS1D/9gvmrt6260PHP7JoS6Rfa5lWXJ+VyA2eHE3JJP0cwS2nWIY/XzeKZyTFYKDhvOYh48DVB V6vMws3AnykW2vZJVtZELgRbWTsvHu/RWW/QJ1HGq2ooHeDB8c0pM1IBJVLFU0c/2UB8rct7Nvc UusLb3lAOAJPBgRwMarhEz/V5hVnQIoWGZnTsNNJOfMLzRsiHXjPp7Z/OvZy6tBwUBk28JEnlhr UHfeBk3qqStK/pndamJiFglWwDvaKjLLi2mMQvUw0OaZdzVU14vvDDASHOfsyO0iSf1uZ4CRVwK iFBlzwLS5C+xGNz2rFJiyzVpeWsEzaZalApiOOsd3l7oVF8KfCBMtkv3tNF4xcCjrwq1N3ud8RZ 9D/lSQ/pasMj5TgkiLPJHwTydDNyqwfch9Osdvgp840YOY9m7PnuPdamnJJc+Rt1fZL48kO5WtG SL+U59LCZBMe4rCBvVibslejYOsIqZ7BwPeVHt0ylLgrjxE2ZxoqhTh/+QVU/CQhCTT5f99pYh8 m6hb3qCZqy33eC1BbzWKcfVSzxAV4GCqZ4xjJvi9A74oh5e/BrgnIKWW4kXIAPU2yph61ZPJIXI 7WA62zzI/VfBXyjOM8XK5IqVr8Hu4uEqak+/zw+A4/gayo361M+jowTLhlMhyOvItc7ZAeomCPL kwfMJPPYVsnFehg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Extend the build coverage by allowing to build the module with COMPILE_TEST enabled. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index decd150810b7..c13b95813c6c 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -368,8 +368,7 @@ config GPIO_HLWD config GPIO_ICH tristate "Intel ICH GPIO" - depends on X86 - depends on LPC_ICH + depends on (X86 && LPC_ICH) || COMPILE_TEST help Say yes here to support the GPIO functionality of a number of Intel ICH-based chipsets. Currently supported devices: ICH6, ICH7, ICH8 From patchwork Mon Apr 7 07:13:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 878816 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 783A7226883 for ; Mon, 7 Apr 2025 07:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010031; cv=none; b=EfkNJxEIAOatTIroO3ZrjYbDuT2nGaixowV/fn6nyk5f14poUTPOlCTALVHSsuBN6AEeyD9zmrxiiolKGiJPsS/+cuJvANAtPRGCPoxsvrYqR5GQF+szNhm9H4R97WarCXRzM0fUPXjHB9r0JNHTCLq0BJNNdi2yZHBku8i+gSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010031; c=relaxed/simple; bh=ksgMNh86Gb5TqWWXr6fwh4KwzaC1B3egBIbaiSO69I0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lBQKTt2hoporItpJgvPG+m548mSq38HsCRH69fz1PCvy8Zu331x5sHRQvuWnPdn2Yndln7Dv1qhC8U0iKyO7DiLtSIJrsZAkoj5gjuWnsK5xEPW88v1sJ+QfnTieib7Q9uvEy76TIpGHQOt5GHGdI7rwSdmgWt2jQ++iGYYp+TY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=k1YtE7Q3; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="k1YtE7Q3" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3914bc3e01aso2343120f8f.2 for ; Mon, 07 Apr 2025 00:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010028; x=1744614828; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sauICvY2GNu/d0iZ8lKdFH04dL21IXhvdergpTZ3jAY=; b=k1YtE7Q3b8SrNWmS9knsazM95riHxPX9ySK34IkIPSd/gRb7wcqGu843kQxgdPiTq/ W/OfLlbubpT5SFM0JMifgZyDgY5xF/Z0fcT6xikOZ2+FFbApBRzfYt9J0caqryNs+Oh9 S5mO78pzE0ftN88RDOIR92/l8VM5/Joa+71tFo3qP9xJ1eSUHJuAafn4F0flbPPKYfLu qrrcVy/mGb7f6G8stCsMvwBkAeFKzJll0XXg9qvkESRerjVQENIj5d8EUUImaurFfu+Y dyYpxW0EeZhaSzmHxoFI/nLdbU73TT9pP6DpdDdWcNU3e8RzCpv/XawkqUQIOg3owJJO RGrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010028; x=1744614828; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sauICvY2GNu/d0iZ8lKdFH04dL21IXhvdergpTZ3jAY=; b=ZiNzwzMqsMo5L66TNxneFRmjS60u2Fxb2n11qgv2H9S1wFgbZ2Xy+1HEq7vlU30Evv Xm7sbgBEU8LpKdFgUhDr8JFZhkkDUbZO+oDVnwz9pcCMc+RJmhAT0fUivqhVjpWT2BRJ oDlNCmPPoiuUF16/pRv7Mg7dx2Q8k2bYUrGOEe8/Qr0TKnDJ+CJPuDRAMGtliuml3vDO 1ymN14Mm7S1hSM5Y25v6e+gCYKUHykE7K81B0e4XtKdhKaa5h4EScl3ARGCk24l9bHBv rU47eJyCXrP4uykPV4GjTUaNagzkKL+j9+S1Z6LMLH0pXpAWgNGdyrkoAwmVBnFalxXV l65w== X-Gm-Message-State: AOJu0YyYZx7ufUGlU4iMMZju22ePUoftVnerBci0qZ+Qao1K0+zUwrPv ahVCAkI9hp51w2oDexfOg1frFpzTvzUxWSbnecJLErkilm/1Tf6kaMAa8/vuBs8= X-Gm-Gg: ASbGncshQiV37wScUUGSONcIqj/yqpTbjeruTr/SuW39LcBi626BbZmJxqN/RKzQmGB Hxsl7qDYqy9gbPZoh/IpezxqZiHIdX4RoDgnzESRxo1EgG1tIvcCzIZAbbYkfPR9Yt4g+GjOPfW 85JtOrO2QB1uyCkHrtDI3xM5+2BlSiyFYAG9UUzzLyIgg1zPen0+feBSwpIfG5GkWdweBDYNy0C lXfMsb+Wte4MDHIIJbEW0K/TczHz4FXNtP7r3QtsTRQaQ2vVbUCAvmZEqoS6vtFChZNf26PznlA ElV/u0EZw75B9hE9ud9V/2DCEqlvK5xjgRS2PAgXyf6wHf6e X-Google-Smtp-Source: AGHT+IET2/k8WYw907bVllamJF5bVLK+JZ/6K0xA/5CGjA1RriXq4TqZb/drjilOXTTBto1d3wZyuQ== X-Received: by 2002:a05:6000:186f:b0:39c:266c:136d with SMTP id ffacd0b85a97d-39d07bcce91mr9558796f8f.12.1744010023815; Mon, 07 Apr 2025 00:13:43 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ea97895e1sm145267115e9.1.2025.04.07.00.13.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:13:43 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:13:21 +0200 Subject: [PATCH 12/12] gpio: ich: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-gpio-part1-v1-12-78399683ca38@linaro.org> References: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-gpio-part1-v1-0-78399683ca38@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Orson Zhai , Baolin Wang , Chunyan Zhang , Andy Shevchenko , Peter Tyser Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1945; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=i9kMgN5vraePIBzVin0YNojFDKLKAlftYcTP7Y1Nccg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83sKeGi3udRSb1Sw3Ipb+p3w9GsXMiEnZljC6 RQzVFe+nVyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N7CgAKCRARpy6gFHHX cuyxD/4o1AmB9t89cQnAf0YyC9wdK7KdIRyopDsQc445ExB/wWNm3fbat43Kj4GGAoLd8KCjc1q PG1mHa4YpBjhmNvU6hg8wUfQyN3C1wf3jXBYHOn7Ts3mHDCVi9WOitafwSf27aYja3RW3lpXl6H nvEbH7KVjuFrjpnYgD4AsJc8mGcUSv+g3mAAk4PUVHEPK+3THey0qzmU1uL/mgxUkw7jnOjcIlt raDjndjF72lCBpjaWK0iQ/WrbKlePVhcMNAUyaN239U4NpX9R3E919D+KCx8ux/6ds6hoKbLqrh hBCHrqgXXLAuyrJVnq8X1aMpu/pvvVW6a6ei51TUDCieBdJ2kBpGQUvO+lTWYOf3y2kd2HPZUhm Fh1WSwnpKe6gaUdgD6e4wC5p2UhZ7KBJonc6vny36UEvo0dZGZrxdHg5UsLO5Tq6Oj6AHxY/ChZ hQMVZtKIZHc2Iqi8e+3BUKD6hbS9z1J6kh/LQpqpHRdO8VxWW0kt5s8js5IKQDpTQUDkpz7hAdk WZpbMj//rZrYjp/djyR5irUHQ7KwBS2RsvGa0TRmdwGgyECJfhrVsIXvZDkKAzWFOJPkQhalyJq sNB38EemKTWipHl6P4JsX8ObhIZvAZxMXGs1fXDfq4OIrKgOQiBQYBQjCKyedokBvd9AIDEBZ7R qgCDTPqepWM2tIQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-ich.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c index 0be9285efebc..67089b2423d8 100644 --- a/drivers/gpio/gpio-ich.c +++ b/drivers/gpio/gpio-ich.c @@ -175,12 +175,16 @@ static int ichx_gpio_direction_input(struct gpio_chip *gpio, unsigned int nr) static int ichx_gpio_direction_output(struct gpio_chip *gpio, unsigned int nr, int val) { + int ret; + /* Disable blink hardware which is available for GPIOs from 0 to 31. */ if (nr < 32 && ichx_priv.desc->have_blink) ichx_write_bit(GPO_BLINK, nr, 0, 0); /* Set GPIO output value. */ - ichx_write_bit(GPIO_LVL, nr, val, 0); + ret = ichx_write_bit(GPIO_LVL, nr, val, 0); + if (ret) + return ret; /* * Try setting pin as an output and verify it worked since many pins @@ -252,9 +256,9 @@ static int ich6_gpio_request(struct gpio_chip *chip, unsigned int nr) return ichx_gpio_request(chip, nr); } -static void ichx_gpio_set(struct gpio_chip *chip, unsigned int nr, int val) +static int ichx_gpio_set(struct gpio_chip *chip, unsigned int nr, int val) { - ichx_write_bit(GPIO_LVL, nr, val, 0); + return ichx_write_bit(GPIO_LVL, nr, val, 0); } static void ichx_gpiolib_setup(struct gpio_chip *chip) @@ -269,7 +273,7 @@ static void ichx_gpiolib_setup(struct gpio_chip *chip) chip->get = ichx_priv.desc->get ? ichx_priv.desc->get : ichx_gpio_get; - chip->set = ichx_gpio_set; + chip->set_rv = ichx_gpio_set; chip->get_direction = ichx_gpio_get_direction; chip->direction_input = ichx_gpio_direction_input; chip->direction_output = ichx_gpio_direction_output;