From patchwork Tue Apr 8 07:39:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879118 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DF81261390 for ; Tue, 8 Apr 2025 07:39:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744098001; cv=none; b=NzQbvdmQPqW55gUByEqZHYTTV4xQFcg1u7rNwCQ6Kzx7x+imUrvJkkmKIuPfbXPfnuQXGq9qZCJDkPrPOPOHT8gqoKhNLnMp3HurDO9bZmyTGPl3J1icrd/TSOtO+ehYxKrow242kzrdKQlyTAAgfWT+/SliTRFFct5TMm8k9iQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744098001; c=relaxed/simple; bh=yY1vgyDd8wMt1OyJ1nZ5GgiLWpilaKVfdLDAwj4zDMY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=NGaSX2SPemcFWGc8c3vTUJj+Qu+/gb8egdWQ1V8Z1gR7hLi15ZjMlqfVl5DBCG0HHgSOf/8Y4A2qka3Fa/CadGNEicVTbOfFWTmF/r1r0v+plhPeq/fJsfq3YDc9YGbr4p6VN51Gwlq+ueOdQMmxINtKdxgzydjq2SW6KObLtd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Rq9GXA5S; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Rq9GXA5S" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43690d4605dso34964535e9.0 for ; Tue, 08 Apr 2025 00:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097998; x=1744702798; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=RzLFKKzd5monlWcdI4nxf5Z84XCk4SaHNdQAmnWtjA0=; b=Rq9GXA5SZNqCeQD2mYgl+xXE3NpNwlNOpkRtoQzwZCzLK9YZXZybYlN0kdVmptL368 AkS3xs8CYhlIlbIYpeEqhkvdktsp4EL9QnzWCcH0JsyXPjzt1g4+kv2OiGQ1H/hbdUqo exW9THMAmU9cKcjC5UgBnsCIAk2cajLMt0D6ujO3BB+0WpmqZ8O3ghzm6d/nxo1YpSeN IKMakU8fcvffezuFWPBFLmZM5F0ZDSO+YOAMYk4QVRQi7ivYe6Atv0THVBTAVpoNpFdh W4GSWMwqGStPIn+PQHzw3rtinYiiTTB8X1Ho3wwiSy760lSmXiuoFSZrpZazmq9q4CWj cZBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097998; x=1744702798; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RzLFKKzd5monlWcdI4nxf5Z84XCk4SaHNdQAmnWtjA0=; b=KaA40kP9EQ3zYZ3AcmE0U3TGEDw9uU3QHDC8pM6hB4zAPf8LwaR/vPaSc/DYUzjeoV EJSDrGiCOe2whPu5E4IVcxEAQGupMlqs5vu+UnGsg89eSeen+E/B2BhIw+joVbJQx3Fu 9lYIEpeWDXwvA6oQFBLGsplE1FeC1kuGzZfeiFE/KYKfz6+BRH5lfmYNuKXeYm3kJ+4U OyUiNLJt8c6yPH+/xDeAX/9z7dTnLk7RXmvnJk5tElM9heRiPtzifWhXzAkkIxqHUOUT NAANmE5jHMLRyd/dUMhLoJDsxa8LJK3PQbp7egq4T8Aln/GtjUxVOLK//U/KZKWYPLd1 UWqw== X-Forwarded-Encrypted: i=1; AJvYcCXl7m7m39PmGbADQxNuPnzUqbzVwVbN/2BPod5Z37+aHs/YEWKJgasOo51LZO/vsl7XYeipZgfBrDZG@vger.kernel.org X-Gm-Message-State: AOJu0Yzcw/M39tHdYo4L9EthJSqEKQCN/oT3XSs9fDVgCQPRGfQAWI7s Qon9ujuJblFie1Dgrp+FhW8cAK5wLYYG93INcIMq6lBYQjvZcxTUVxabUfTy6pE= X-Gm-Gg: ASbGncsgdTRxfhpieFqtpjSL1HVJYOhb7l+bccQtpTdcgFEnCK4Q7j9SRqISh6esfue 1ixdtn5J1UckTjTOJ06EzONMIkOlEqW6yL6O+rZ1DdV/Ee3tCgZIk2VQzfV/p1rrDk+fXC3JXcP 8Vgrf+bCiU4XjYGl3+h9xCm6ren+FQ1csuDnH5WiLV0rb6rCURPQwnPRTxp/FYnNw/ld1XLJ/8x r0L6TzKOXPu/lJTkVvqi774mOQGqmuCgwaw1HwDKGVFPiztd0TWbk1Kf4Mpi5JfZSP+tt2ef36y ZqAS8fN0WCbU/Mj6cFhJd8CSO8GZ5yUzXN1aVw== X-Google-Smtp-Source: AGHT+IFBnscSTWeNc0kbRfBnMhse9CS3IWIkjIUMwm6j+QpSpPJjYHjtNIkqyww/lRRFUe7Se/td3Q== X-Received: by 2002:a05:6000:2906:b0:39c:142a:35f9 with SMTP id ffacd0b85a97d-39cb3575bfamr13615953f8f.10.1744097997952; Tue, 08 Apr 2025 00:39:57 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec342babfsm153692095e9.1.2025.04.08.00.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:39:57 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:39:56 +0200 Subject: [PATCH] spi: xcomm: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-spi-v1-1-597660766654@linaro.org> X-B4-Tracking: v=1; b=H4sIAMvS9GcC/x3MMQqAMAxA0atIZgM1VYpeRRykxjaLlkZEKN7d4 viG/wsoZ2GFqSmQ+RaV86jo2gZ8XI/AKFs1kKHBWHIYkpw+SkLlC/ONmgQdedON1tLeO6hlyrz L81/n5X0/tz0HnmUAAAA= To: Mark Brown , Linus Walleij , Bartosz Golaszewski Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1971; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=UWSVaYTx9qsHllGeuLrfbRAZU1erxA1Jg78sg4AxvDg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9NLNSNlnAzpqfJnJvAMCxXAHB6VrSPj/6kR2x zhNgJWqJv6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TSzQAKCRARpy6gFHHX ck9jD/4xPWmB+Fni73N7cNG6zM+2V5MMthqOUGvEdwLf4iQG13MYHJn0kWkt1OOLf5M/iFMOP/C OI6s+vyvU/kiUf1vmZgju05+1htuxjRnXWQjP3FY/UIgJXVrIlTb2LJp1IZwRJFBMmD4ebjRz5G WXg5RYQhyT1mgKFn2NKMdhvRhYu0E3TDOAQ4eVHWwe7B/5RMKvo0FHYOAvPLYYhCJZPoIP2eaKn zOA7qjZgA0eUmJT8JxIX70Up+6Ag5X5SI9Vq8kM3Vn+ky67KFQfHTP1BLSYBlKm1GFhyR3wL4Rk izNm4QeVas/ZLdbRl7AfOHlOhYMVprk8DWR6GGoctr+KtRwLIOKUhpaK4MYeB8ISY+ZIFbw2BLK A+PLEop321r41E3CubUm8DA/P2qO7onyIBR5Z8pcu4C0rawreqShv0BOrqIWlnj8EQpt9+vTCqK ABk7ltP45GuDWsdw8x6byH77AaRpvcKFfBGbyjB1KO0FDqalSE9ckjgRkJU7cRtAVJNdYWZBTec dG8A5SlZxJ7WuCg7prHi5MvO6h41iwASCMO1nrdpFoJpkB0Kc7AYuwFyRpp1VbacOLe/TuN10rW prIxhDPWdPzf3wg9Kr/9yjGhO/7nsMk0tPF+CirmxtrhyOwni8sQnXR3aCtEEi06MDgP3lP+R56 fqQBKO2M4GagZKg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- Commit 98ce1eb1fd87e ("gpiolib: introduce gpio_chip setters that return values") added new line setter callbacks to struct gpio_chip. They allow to indicate failures to callers. We're in the process of converting all GPIO controllers to using them before removing the old ones. --- drivers/spi/spi-xcomm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8 change-id: 20250327-gpiochip-set-rv-spi-72c019332f47 Best regards, diff --git a/drivers/spi/spi-xcomm.c b/drivers/spi/spi-xcomm.c index 3bd0149d8f4e..1a40c4866ce1 100644 --- a/drivers/spi/spi-xcomm.c +++ b/drivers/spi/spi-xcomm.c @@ -44,8 +44,8 @@ struct spi_xcomm { u8 buf[63]; }; -static void spi_xcomm_gpio_set_value(struct gpio_chip *chip, - unsigned int offset, int val) +static int spi_xcomm_gpio_set_value(struct gpio_chip *chip, + unsigned int offset, int val) { struct spi_xcomm *spi_xcomm = gpiochip_get_data(chip); unsigned char buf[2]; @@ -53,7 +53,7 @@ static void spi_xcomm_gpio_set_value(struct gpio_chip *chip, buf[0] = SPI_XCOMM_CMD_GPIO_SET; buf[1] = !!val; - i2c_master_send(spi_xcomm->i2c, buf, 2); + return i2c_master_send(spi_xcomm->i2c, buf, 2); } static int spi_xcomm_gpio_get_direction(struct gpio_chip *chip, @@ -70,7 +70,7 @@ static int spi_xcomm_gpio_add(struct spi_xcomm *spi_xcomm) return 0; spi_xcomm->gc.get_direction = spi_xcomm_gpio_get_direction; - spi_xcomm->gc.set = spi_xcomm_gpio_set_value; + spi_xcomm->gc.set_rv = spi_xcomm_gpio_set_value; spi_xcomm->gc.can_sleep = 1; spi_xcomm->gc.base = -1; spi_xcomm->gc.ngpio = 1;