From patchwork Thu Apr 17 19:02:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ruben Wauters X-Patchwork-Id: 882048 Received: from sonic309-21.consmr.mail.gq1.yahoo.com (sonic309-21.consmr.mail.gq1.yahoo.com [98.137.65.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A51B185920 for ; Thu, 17 Apr 2025 19:03:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=98.137.65.147 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744916615; cv=none; b=qJLqbXIMdldu+nl+iUILRsn2f26HgPYPiqRTmIwMeYyjMWteHakdfbPfl+cFJofcnIre08ATv997a4NigPmCXDpcfpuUXCAE3v/xuuEjPCk1Bv6vXh31c2/RA7DIujwtzQPl9Utw7DqYmu2H1Qwh1SapiX8bomK5Gl6+kwMnrT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744916615; c=relaxed/simple; bh=5KTeWSc6H47lSlOKdSbwaqeePKMqgOAJ1wGVQhmKp+w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pR5IeUAIe+yB//cJTnletLtPFU+VEnsCFjIwKAX2VIUEfOzvoMCtLpTqQJOgtjVsjwE/2wLxFj0l39sq8F3bMpxRndc51GBiJy3xONf//GXzvnNbXF0QhIlFjJve1+tD97hePGmcmlXplNZcOmbSf0c3aulyOlX9gCoZsMGgDyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=aol.com; spf=pass smtp.mailfrom=aol.com; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b=X2d1usPS; arc=none smtp.client-ip=98.137.65.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=aol.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aol.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b="X2d1usPS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1744916613; bh=d01pl2D+rgtMMJC7n70eJk6IKYF3exP95OX+V1JFanY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=X2d1usPSOHgmQWuZxK+oH4KM6wMOPvC20CkzvOMpQA88TCleN9V0jthkelysBUDvNnvhTJQVtZSQ2w8p+HwjhTOr6dg5r+7OfRw9KPY+D2wPLZHFUXt/anh/vBfthzecFvSfjXtHUcvy6BLMDKbPvEBcHZSskEFUC4g4BGnV+LqoKPfmqW3G2wtjEf+hF+b36XrnlaiuhV2L1ayxQqSoc+kiYUCExIraXWtnuitlSnkgjDt6pIrCQL5qhKBSxHo7BUkQsGVw/Z8wo+EUQBUwTwQrnUztGAwXrZtzPvbeFiwv/Dvj4mD2aNAqekdnzdB0KOSrfv0QbbHh4h5GJo+9Xw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1744916613; bh=JuPl6lCJIn+kFgAKYjUe7CPMFeSmeiVJ08PevGezymR=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=hS98+gLzshMKLeETY5ZYohPalAp/PsrRKmrbyCqnwYj9UNw1aIfjGcObyxdYqrGLvPI2nQAZdNqHhHBOKKdjRH2YJcaBVa92IEgLE5t5SpeCKPuzQieOB81gTM83vaX9WYdqKiv5wNxyI3AN+AYbyvmgfxWYCEs1jP7uOHc6O3EjgZpjsyAhjDZFrNRJEEmdnIFIs0hzs0V8veGemfHvJeOUWNf0f+qAiqxeDl5Brq40/aqMdGelKKh4gCzkG+xbzFfQkrFnNVnoZ73qDcrctJjShPCSOjlfwH8N1L72uX6IsQ47rCRbaI0x09Upb0koGwG/X4MPxuDEL6BSnmwl1A== X-YMail-OSG: QfDLMyUVM1m2NCozMAOX5XmCIhexE_bL6YtVkt.yUNlTz5FJhZMzxvCcbHjCAz5 Ur19sCPTbvlV7iIW6H6OJj_Y8aoaC0B1sRt3DantvkzX6DwWrWf_cms9ozzV.li.3P4tCE5HOrDN yco.rAJY5jya2LY6ZPuVXJ3ApSzzW0yl4O1BHXqQRWHKiOT_g7FRVUiTAUddmKtQlLy6Qkxj1ewm _I8UcZZybvngwfFDOCzj.XaBac6XKFHgf8EbgNGz4QAoqaUi.R4RblHiH6EdhGY4WvoZbPEMSvR1 U_zY0Ab_k1tmz_cA5I2Nzub.yP.x76iBQgR.lLMdWGb1qkhMLBuk6l0hUP.YtFOnzPp_vzYYcpOk sd3krv5Z0FNHECeH.hygvf.ssVR.gmjWoIOkpW4z_hPl9NtARhSaxIneXr_SIGzcT9188uHR0Rpq _e8hM7.P5jFO1UTdocipQPosKJw5lXxks.Gp_y2fzQ7NMk9Bq22SfNAcg3k7DbBVzfQ5VS7W9oiI BjtoRwNB_1RhZTp0lvQpfYsGM8hxMbbNHlMBUxwH2xmMDRcTLYk0fcD0rCzxFGsgqGwzkzRoIAPe PoOji.J7SAiAuPcgLMCmRwBAXtj4OX2CVdBA.4.02aG4tn0SXDLoS1OCVKPN3sHMzfFA4zYbpz4f gTl5bi7PdTJL4oh.xSpmq2Wzs0nn_rqr_321SOIT8xcEHO4j2fgk7PI.Sf5UsyrHsMyh.1wnH4tz Ngsbwv2ViKq755br3eHucJ3ZwblDttBmnEaCoEWLiMHU4EbTf5dIHkjuMFi80w.Dfd34CjnRVLNr S58tebqgsXjMppRZkSjCINJV2OMKxUKSUKZyjLkwXSdl6DgxITS3kSqccdPxI2uFcrJco0ObdHnt __y5m.fb_B.rZvFmyTF0so02DZUFNTu2CViWWJmJ7.huslw24dgsPbVIEyx.mqH_s.m_BxCWFq4X v.v95Ig04bmUGLi2b9pfpLxdDEz5ynrX1vowwmuSbBJV9xA5freUK1aWiwS3E5UIpbbjgYr.mqfs 3ghHyXAVljaTIdHY_YPJ2G6Z6QK4o.0xn8mgUVjPltrDjvOFwf5jhJDXGIkwNksOsrS1Q6MZtZlO eZO8.ae3q.xno2Y_8HDwVHmj_24KGpZmcSc2VYJmE5wv5cck9u0oYXJEH07wkYYGpUdhYMdmCASz IB_L_oXzAvlfU_Spy.limXeYee1EyEgcWgmhDHdP2q5tNXvAb4Qq9Fpqdv5aR8yCM9E5MMJOsorD LmyVaHLW4uOdCDlUSwLIa1DrvA8ZNkqPkpfs1siUWeKDZUuTpAzh75zXZvSR1RPTCLUsB7Kh3iDE zu1N6MbMZpN2.ivCSAoFrcZ0OA9BUTUa9tuXopSCHr8W2F3DQC7w_AMz7DaIiTMU7GHg9jkXvycd WWQqg7mznS95L4DxNEUqa1QXoD2DumGdV0qFrbxqtAXPtpNthiSlE7pBQcIX91_UaPR6AQwqHZ69 wzNckHqLI.f7HGN5c7.B7LCroiFwyjw3qM7rX5jin5t3SmF8ynzVds9cfDmTtv039S8Li5Wu7hLN ssFXMdExU1dYBNymhEs4gS3CcwSWw7BH0Z7BuGKNtwF3MmQcegWgC8NOf1GqM2MtzLoMJ04cS_Ly JenPQbNQ_Q92QHlL_dHT1QH1637S8g1wWE7ntfwLdOx9S.WtYjV7qzy8MBM3kbklbxjGVRWFDjgQ MhCyXjG0TcDXnKtltSzNA_FtsxTJZZDst_PBgqCSRGriWdup9rmMHXzYaF17coyXoK1wqNHOzPa. JdafDp7x71k9awuiAEyfJv8x8hFMecINjQ0XNz4oQAJNxQMRi5DQ2gz.9q4E7Qg3MItCVWRW3v1l X_v3IhqKjsRP6q6_2B0jG4BB6hhLIINDqmCGN2kkIUBRpAEMSsn4yC0p_Omr3hHUfYOsQgUVs2zb G4osYg_o2CnV8X79DJnety.pfLz1UWAMNu.qL_dI47BvYZi3jaJz9jia6CWUq_9ad8dalm2AUZhg 05pZ04pi2JimNcTNpSTBrNaDhMLQ_hwld0yySJfEncUtMtXu4wdfPjhMlzWidIS0ZqV..jkJljgx vUhg_WJQ2ftEpK1AUtlZGcGUTTaLvpDnGPQESaKxTHE2cmCDTozmpj83gM5pj.p4uvpcDepmWCDy xaYKHEvM9H3qwYcjjD45Y4eTjC9kRWgvfEUL4u3MLuu42rAvJHEoax_2Ya_G.Xi2zgqv5hvG8uIW tPpJZPgut3Xec6VjvJSFSIL.3xIkx5z3bHAvfAapoStWYS.0fEIEm.KHWSk.nK3zPupkocEbBsBp 1ttbH5PfJWqJR1OYs X-Sonic-MF: X-Sonic-ID: d68f3c3e-763b-4d8b-bc78-41d73a72a9c4 Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Thu, 17 Apr 2025 19:03:33 +0000 Received: by hermes--production-ir2-858bd4ff7b-9r9sx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6040ee699aaf3d3f072b53831b62751d; Thu, 17 Apr 2025 19:03:26 +0000 (UTC) From: Ruben Wauters To: Greg Kroah-Hartman , Sudip Mukherjee , Teddy Wang , Sudip Mukherjee Cc: Ruben Wauters , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/8] staging: sm250fb: remove USE_HW_I2C check Date: Thu, 17 Apr 2025 20:02:49 +0100 Message-ID: <20250417190302.13811-2-rubenru09@aol.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250417190302.13811-1-rubenru09@aol.com> References: <20250417190302.13811-1-rubenru09@aol.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Removes the USE_HW_I2C check and function defines in ddk750_sii164.c. The software equivalents were never used due to USE_HW_I2C being defined just before the ifdef, meaning the hardware versions were always used. The define names were also triggering checkpatch.pl's camel case check. Signed-off-by: Ruben Wauters --- I am somewhat unsure whether this is the way to go or the correct way would be to add an option/opportunity for the software version to be used. Currently the hardware version is always used, but I am unsure if there ever even would be a case where you would want to use the software version over the hardware version. I do not have the hardware in question so I cannot test what the difference between the two versions exactly is. I also note that the removal is mentioned in the TODO, however once again this is currently hardcoded. --- drivers/staging/sm750fb/ddk750_sii164.c | 63 ++++++++++--------------- 1 file changed, 24 insertions(+), 39 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index 89700fc5dd2e..dd7811b18bf6 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -8,17 +8,6 @@ /* I2C Address of each SII164 chip */ #define SII164_I2C_ADDRESS 0x70 -/* Define this definition to use hardware i2c. */ -#define USE_HW_I2C - -#ifdef USE_HW_I2C - #define i2cWriteReg sm750_hw_i2c_write_reg - #define i2cReadReg sm750_hw_i2c_read_reg -#else - #define i2cWriteReg sm750_sw_i2c_write_reg - #define i2cReadReg sm750_sw_i2c_read_reg -#endif - /* SII164 Vendor and Device ID */ #define SII164_VENDOR_ID 0x0001 #define SII164_DEVICE_ID 0x0006 @@ -39,10 +28,10 @@ unsigned short sii164_get_vendor_id(void) { unsigned short vendorID; - vendorID = ((unsigned short)i2cReadReg(SII164_I2C_ADDRESS, - SII164_VENDOR_ID_HIGH) << 8) | - (unsigned short)i2cReadReg(SII164_I2C_ADDRESS, - SII164_VENDOR_ID_LOW); + vendorID = ((unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, + SII164_VENDOR_ID_HIGH) << 8) | + (unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, + SII164_VENDOR_ID_LOW); return vendorID; } @@ -58,10 +47,10 @@ unsigned short sii164_get_device_id(void) { unsigned short device_id; - device_id = ((unsigned short)i2cReadReg(SII164_I2C_ADDRESS, - SII164_DEVICE_ID_HIGH) << 8) | - (unsigned short)i2cReadReg(SII164_I2C_ADDRESS, - SII164_DEVICE_ID_LOW); + device_id = ((unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, + SII164_DEVICE_ID_HIGH) << 8) | + (unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, + SII164_DEVICE_ID_LOW); return device_id; } @@ -132,12 +121,8 @@ long sii164_init_chip(unsigned char edge_select, unsigned char config; /* Initialize the i2c bus */ -#ifdef USE_HW_I2C /* Use fast mode. */ sm750_hw_i2c_init(1); -#else - sm750_sw_i2c_init(DEFAULT_I2C_SCL, DEFAULT_I2C_SDA); -#endif /* Check if SII164 Chip exists */ if ((sii164_get_vendor_id() == SII164_VENDOR_ID) && @@ -176,7 +161,7 @@ long sii164_init_chip(unsigned char edge_select, else config |= SII164_CONFIGURATION_VSYNC_AS_IS; - i2cWriteReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); + sm750_hw_i2c_write_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); /* * De-skew enabled with default 111b value. @@ -214,7 +199,7 @@ long sii164_init_chip(unsigned char edge_select, config |= SII164_DESKEW_8_STEP; break; } - i2cWriteReg(SII164_I2C_ADDRESS, SII164_DESKEW, config); + sm750_hw_i2c_write_reg(SII164_I2C_ADDRESS, SII164_DESKEW, config); /* Enable/Disable Continuous Sync. */ if (continuous_sync_enable == 0) @@ -231,12 +216,12 @@ long sii164_init_chip(unsigned char edge_select, /* Set the PLL Filter value */ config |= ((pll_filter_value & 0x07) << 1); - i2cWriteReg(SII164_I2C_ADDRESS, SII164_PLL, config); + sm750_hw_i2c_write_reg(SII164_I2C_ADDRESS, SII164_PLL, config); /* Recover from Power Down and enable output. */ - config = i2cReadReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION); + config = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION); config |= SII164_CONFIGURATION_POWER_NORMAL; - i2cWriteReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); + sm750_hw_i2c_write_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); return 0; } @@ -283,17 +268,17 @@ void sii164_set_power(unsigned char powerUp) { unsigned char config; - config = i2cReadReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION); + config = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION); if (powerUp == 1) { /* Power up the chip */ config &= ~SII164_CONFIGURATION_POWER_MASK; config |= SII164_CONFIGURATION_POWER_NORMAL; - i2cWriteReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); + sm750_hw_i2c_write_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); } else { /* Power down the chip */ config &= ~SII164_CONFIGURATION_POWER_MASK; config |= SII164_CONFIGURATION_POWER_DOWN; - i2cWriteReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); + sm750_hw_i2c_write_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); } } @@ -306,7 +291,7 @@ void sii164SelectHotPlugDetectionMode(enum sii164_hot_plug_mode hotPlugMode) { unsigned char detectReg; - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & + detectReg = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & ~SII164_DETECT_MONITOR_SENSE_OUTPUT_FLAG; switch (hotPlugMode) { case SII164_HOTPLUG_DISABLE: @@ -325,7 +310,7 @@ void sii164SelectHotPlugDetectionMode(enum sii164_hot_plug_mode hotPlugMode) break; } - i2cWriteReg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg); + sm750_hw_i2c_write_reg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg); } /* @@ -338,7 +323,7 @@ void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug) { unsigned char detectReg; - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT); + detectReg = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT); /* Depending on each DVI controller, need to enable the hot plug based * on each individual chip design. @@ -361,7 +346,7 @@ unsigned char sii164_is_connected(void) { unsigned char hotPlugValue; - hotPlugValue = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & + hotPlugValue = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_HOT_PLUG_STATUS_MASK; if (hotPlugValue == SII164_DETECT_HOT_PLUG_STATUS_ON) return 1; @@ -381,7 +366,7 @@ unsigned char sii164_check_interrupt(void) { unsigned char detectReg; - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & + detectReg = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_MONITOR_STATE_MASK; if (detectReg == SII164_DETECT_MONITOR_STATE_CHANGE) return 1; @@ -398,9 +383,9 @@ void sii164_clear_interrupt(void) unsigned char detectReg; /* Clear the MDI interrupt */ - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT); - i2cWriteReg(SII164_I2C_ADDRESS, SII164_DETECT, - detectReg | SII164_DETECT_MONITOR_STATE_CLEAR); + detectReg = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT); + sm750_hw_i2c_write_reg(SII164_I2C_ADDRESS, SII164_DETECT, + detectReg | SII164_DETECT_MONITOR_STATE_CLEAR); } #endif From patchwork Thu Apr 17 19:02:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ruben Wauters X-Patchwork-Id: 882047 Received: from sonic313-20.consmr.mail.gq1.yahoo.com (sonic313-20.consmr.mail.gq1.yahoo.com [98.137.65.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2FEE1FE444 for ; Thu, 17 Apr 2025 19:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=98.137.65.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744916621; cv=none; b=ACFC3AmBXKXYAU4UIXfHS1G3hHPEg88xUuckOEKnC5vsnuovR+KF4YCWnOLb4huw4tA1MQVvk2ktkzEHlKrIZrzVlhKoxR086c4DhOS0yvWr5rfjNnQj9LfPbN2qeOH0/2ScFb2lNSFnia4io0QvJ/4Nx0tuH+1GUcap58NVgm8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744916621; c=relaxed/simple; bh=d6TXpPw9uD/T0xtW1qjab8px9bE7kkSDAEaEMHNKvKo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FfacldczvHB4cwawJa/MmvGdiqB0IU7xKhGVn7CqIU2u30mcdPjse6izvt+xvjPwK1fiIOlvb5L0ji9j3QCM6GjpfMGpw7RoyjzbqqxRS6+FWb51HmJhp30hKOk6t4RV5T2hNfZ+iZwdEqE1f+UtsQ39ie/uxzQw5fx7plL1l5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=aol.com; spf=pass smtp.mailfrom=aol.com; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b=kGAXVPAt; arc=none smtp.client-ip=98.137.65.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=aol.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aol.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b="kGAXVPAt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1744916619; bh=ud1w3HfMPHz9i+REhP5oVrV34MnkpVn0N7CAQVP3iGI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=kGAXVPAtok4qk6YWIvFZFCr+8pkR8nu+3JqHECTTEwBR1UIplcedw0fqVHJATq2F/Al+21gPwNUwQmTbr3Y83SV8JcIKlLPhK6pcwmUbQhzINJF78X4Du4tuaxN5T45EEAdmRNHvj1YsxdBc13x4AXuPFRo7f8hnwhSdCQGG6C5ps2HW8OF0Ur/LJTDwIm4lfypaP8qVCvhsffFXMggQ0FuxLmqJK9lXYfUOfL+SiB0F+lv/HeAC1EG8jQI6wZuR/k5LBzXRO7GR8SxnBit4yMflpSVLSkh/PjpHXoTKfYmhkFGJaPlN3VY5dygoF5n2se9+HTtYmx0oEJR/NkhD7A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1744916619; bh=vjsDYOrz4z1LtH3/07pNwWuauWKRxCwJ/qk77a3Au7j=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=rwOr38TLlb3nJvchBNwVIMpq7RrWPYqTdsJc0Ko5iqZCwBW6kadaDYeVFMwx26mfvgzNmkQ1KoHEqUdbrfxbjcooV9gru+VxDQ5cnEFvmlAxOSAnEMXfma1tLr3FxAJW0ssHecux+BTSGhATtDHTBbXj78Xdx4GeBXo+EsJgsmGdM5tLZ68949GQPkMJuoQq5XsRPQc6KkyhUddsanV3+m1GQmionnAYisZuaPqeR7haXBpwv3yU6r8Vy7Dxq0JgarROKavMy9jd3njsquOboiFu9/ZGdY4iVobTJyuKApv4rouKtb+alvwko2HKWr3ElywitqOIXYG/ss7eMrSCnA== X-YMail-OSG: LQkbBBsVM1nOPi2YidBu_FFnD1rUZWGmV8xlN6RzFb.684AioQVlsOKYMZCbrnR lIrbPl6.qH6VIREZjLPdE7rbm5jRu39IFBmGaNI0V5zYX.zAChiPptQoDLfflAUME_y2yNARE9vK BWw8wAi1R.lsE7AByb0dp3zEwPEQrQ4eVyzlIO98bw2eXevM6xTOdsKoKozSoVuX4KLihgeSMqMH 3m1PDyUEHjeQXWh_qitBcSWixLKEvagr1GXi7dUlvAf.in5Sw9pfCLbfKU2mkrmIC13owDia_1ef ampmbFaOAzI0xmwQcrY8qC88MOyVxjDgCuvFqvPPursR7UuXISo.ZmGjwAb0Gv1emCfoE8a2WKpD b_g08QuT_sXhW6lYWAtMDqlazXZVZnsdw.ZM5xEQmc8_vWzSSpJ.fbSiuoEra5UbmU80oPPonN7o 6D.B6DIlLmCgd_RzP6aTzDSUdZla5gvE8mldGIC0R3G1he2VGYtLbrGCCkn7phqLCLwqWhEUXRtO VBaVCefKFMrFUiWXEuF_95lYAeXSHw7sf0NiCO5WPpUOkc44_PctU8mbub.5L396W_DZu.Z9XSsX i_R2eZnev4Gd13Od47.7RIrj5LIhezO25tt2EETk5DmMNxAKmaDnGsIjY4QL2Gm_HRRsq1np2Pue B5b6c95UVrx7YJllk4I_OBeMYEfspdpVcHIYlWFDozwO44anDH3H9fPiwwt3ncN.xKlFRMHeGKbt IaOJ6Cm3CbN1fRlAWJt0GyqW.s.EXJegrWx4IzZXUPsFBqHSL15gY7LveFFCSkjNTGqwbzog.fYx fNMpLE8rrg0T2nQKRrx9YlPM0mo8emfcI.0Z.igdAVataHCAdE1b5kjATo2dn_YUfMfxpGhtNE2s GkuOxLFONF4dHRXatEzKDlXqaRJAdUQmFh7Cd_mlFUOi5mDpxJNXFeOmImoo.FNdOo6KL1yKCEGI VxEEPfQhneDVfTeKicyvG56OBtz3tzFqcWAXz3OSTZKZwp.QiMU6sgzUtjGXOmFaWP1br79nDz7i CThl3P2bwyr3CrsXkf7gx517v90kReOuyITCAlXLErZV3voL5NKudHXx3aI4wJ0QaZxiR2hrwj5o bK.4lh2kku2yV.bdxnC9XLQmVJqrF..ZDOm_ZdCfgReRlXtopZX9lsAK1tiG18QCZIr63rs4Cosm zftGiqsIFiQ4H3Lp_KF8ZFtjQcgvnX5hhgMriiLM_b9qHpj8iqcXDYT70v0YwMouSYgVet90xCBR Sr0_Wn7cdUV5W12tHrXVnlOAT34qGs9ESFk7srBSsfsChI5D.1YoI1yugTdWWkU12agkSd0Zw3Z5 8eZQvVOOXbKsLaKsaacmd5hKGLnxwP393DJtW8bVw4W6EVL0hbOXbTkLKwUFToJjzFhYd1zjurf2 1rlwI3N676yz0XlNVoXEFficP.UpX_SqsWHUkZugyX3u.lrjPb0JwG1ewSZVcGcRYl5Iy0JX5hDi QiBoHol5CFvIaXwQMskqtZaJt6as8e7H4KYnmCCPiQIkbBvhRscHjBYb9QEL_nFyFs6WS7RiFWPm eMOLJtMufjNj0jEF.y9JiH9ugoIz_uFeiV7Y9l6xAqSV5KHlLmLum7djgPY5wmLQFax4dJTj9YXY WNLL.Hw2r3ytHNTcbFi9Jh9IjcTv0WuzaqRfPdYTlzVta1UvwvzwYEasBspGCExEq.18F8s4YroG 7tgU2qIHkLWPlLS8nhZA5xf9GZrTOOt0GkrkGC72ugvWTio1F7NucNAnYx225aZ7ec8e60l_hkQX KnzMOAflzcmhwcp0OlM9caxBSgHjaIda5Mj5zyVlPK2b443dpJohsj1W928JR5754DT2it8ZnssQ FCRLC.lWjOa1rNHwTQgGl5Hdfvotic7shZo8smy_2o3d7toP_BRewUxOCk7fDj5F1wpcG64f13Sz jMN.BDnbTZz.vlpk41hrF4wRDdbaD3uk2NueorBSlREGRoWtetUuN0X58nE_2_z3Tnd2UyeTjjXT AD461536Cwmza7itqUo2djQaRqsrJoU0BaQtLxSjt4gAgC7.DfcMGhOeXdjjS7MnHgVz9bmi3eVe xnJm8aSlLNJdzdo8TwoaRmi.38bpnRCzqIlcr5npzadkF7_Vr0LoKvXEKaF.swlE3bUbqKixXczh QM.NNrppS4MLRRZ2e775MArWbUI2Nw3I7kdiOe8gSflKtDcMVgFqQ.oD7HJCxHumWYKj7ZMFilQW Om6uKCB5aY_Rbr.3gK.jasWP1j_pv_JeXwMDRaraNXMiXcWS5UuqFyiHT3hmgqDM_Q3v0i7BuHhA - X-Sonic-MF: X-Sonic-ID: 576178f9-12c4-4b8e-97f0-a70d14d805be Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Thu, 17 Apr 2025 19:03:39 +0000 Received: by hermes--production-ir2-858bd4ff7b-9r9sx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6040ee699aaf3d3f072b53831b62751d; Thu, 17 Apr 2025 19:03:31 +0000 (UTC) From: Ruben Wauters To: Greg Kroah-Hartman , Sudip Mukherjee , Teddy Wang , Sudip Mukherjee Cc: Ruben Wauters , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/8] staging: sm750fb: rename vendorID to vendor_id Date: Thu, 17 Apr 2025 20:02:51 +0100 Message-ID: <20250417190302.13811-4-rubenru09@aol.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250417190302.13811-1-rubenru09@aol.com> References: <20250417190302.13811-1-rubenru09@aol.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes camel case check reported by checkpatch.pl Signed-off-by: Ruben Wauters --- drivers/staging/sm750fb/ddk750_sii164.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index d4309e0d807f..9f660a9be5d6 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -26,14 +26,14 @@ static char *dvi_controller_chip_name = "Silicon Image SiI 164"; */ unsigned short sii164_get_vendor_id(void) { - unsigned short vendorID; + unsigned short vendor_id; - vendorID = ((unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, + vendor_id = ((unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_VENDOR_ID_HIGH) << 8) | - (unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, - SII164_VENDOR_ID_LOW); + (unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, + SII164_VENDOR_ID_LOW); - return vendorID; + return vendor_id; } /* From patchwork Thu Apr 17 19:02:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ruben Wauters X-Patchwork-Id: 882045 Received: from sonic311-24.consmr.mail.gq1.yahoo.com (sonic311-24.consmr.mail.gq1.yahoo.com [98.137.65.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 180521FF610 for ; Thu, 17 Apr 2025 19:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=98.137.65.205 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744917231; cv=none; b=TRgo+IwPvHk9uDBbal74+FU35GRy8tJyBi2byH3+FIFTALrPsaNSMhOxkCwxVUaSj6G76HQfNER4oc0a8neEAkvHSnmbypXMsVylUB2BDvhrbHsd2D9gMjWLFBReqAYMB5hGUHmywpWbWF/ExKqg7zsp4K0ru2DfcVlyboi02es= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744917231; c=relaxed/simple; bh=L6SdPOd2Ssp0R8bFUEdZpFt0iTf0baqjd0GM0QfWXWo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LHjsBr1qBT0rwP1ote5Lwb37DKWCoHo6G5ujTGO4YI8tC438tqC3+lHsQnWAblwsDITdlcRZEkuha/7CjPlzQ5u1eX+GpBxhuAN7wbeTb+8hOAFLL5dg2w4ivD67sqdCRxXdb8HkTzg5onMTU7LgKtHO40BXCiQlrTiMyPpy0Rw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=aol.com; spf=pass smtp.mailfrom=aol.com; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b=kwmybk/D; arc=none smtp.client-ip=98.137.65.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=aol.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aol.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b="kwmybk/D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1744917229; bh=RxCvByeLEbOiitcXU2m12OSRo5AUDmJRbM2o07h4ujc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=kwmybk/De27dzuUJx95P/uRt7Qk37Kbc1tGoe+T6poy1isGUu/j6rMMON/pWy7fprse8USUCZxZAOSeYi0XCuubALQo72icZPr/ZAYHz/u0Ax4Gq9wpFCl2hKkobX1TnXJSosxDXZGhqxXo5xiUGZCCbfDDCMwPKcf3imBA8YVu6Ibm30ZhPqkTxkv8qd/2JAqUA20atiQSZ/QH02WTAEG+4dusZ2edW1C8drISfiqhAmP3dGgMiewShuOcJ8hDeu97U5R1YtodJj722t3yikepW2LVJuuVu8d6OO9fcnkD4iq9InVTng/ZeAdLFPDJfbLn+xbMTcTGD6OmQRV1Eig== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1744917229; bh=5FWo8cQc/hB9NfLmJn54LX1h79NfN3s9oqpfAOm3Klm=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XNgZEzJG6gRyBfUeJsZGrmUmAGYYHsLPfdka+yKcXLrc5yJS1XhkM0c7lB0MpD0u8Bkfcq0ABttyDlDhLoIsa1nlLXGPUeo7YYmPlZjjtu98edHdplFrAz6wS+KKR5+bs/xAACHFFH/Y3K3/6PdBR3z2JKWgrZ7hZwMfF9/b5/KfUmTuau4hY3dJW0yyjxgzsDS9tUBAjqTLsItEdoSgOjywhhgsMwFw2lZGTooXzH4k7Z4ZK820E4PC6uWlH9svA+22ac8Y5XGNrPksjBlERzqdUTNWu6b8+I0Z/CLxQP//J0DY+IlBjl/uM0bMMD7nmSfQcgYZ5hK5i4KvSmY0hw== X-YMail-OSG: Bsn1QboVM1k.CXjKOD9a40GJDxZ_pa6I7oUPAOlqB1eczFCm6dI2ne.YbUPEwfC PRITJHlXTzxlrI_.YLzdN.VbbR7AdXuFLxvuox1CYYTNuBxZ1kQgGK_ezo878SYScLqQTtBLD_Ky 2IIIAtYjOSSUA5X2AQleqDZT8LxZMF0dElT99yxqfdB8PJGNY6WyLzsB0EuJu_mffCntSj8mEUiJ RgY3Op7cJ190pH1nU2DgehYD3kFs0atW4yesNEfjZzOv_opKHYXrv8RChCQ5AcdpQg4UVFFHlYwe EAjzwNOHCT5WVFu9Fgjsw.AVzrrABZz3OfnNpJX3qitwwCr18yvI_grLVoXzIVoWpBXN40DbR8qB 9vKaPP8ke8jQXz6ALwaO5nUeBEYz8wYF3hoawdoLvBKoduH7nJc2w5u3oK_j1Lbtumk.i99Wb9Md 4ANIdz04YvzBk8XYtvCaOXUlStM9qmOKaWU.ctEGtAdrkfZ79mlS4iCUQwVxdCCltfKseHONQoVt JK4npKFVRCyo0jaX6skI4HviOVGix.x0H3OB_mfdk1sOHvuDhWGXF9FYMiyz.pv4NeyBo3KOHz9O 8kxTtEooN3tHFEB5aJzFRfYb6ZaF37rVfRhWkTEZXjOvX0G.I_C2fIOTnxtdviGNUkfVAx9gDc6s Tw1U_kI7NoX.cQ4umZG44ZNSx_QR8omn2EJ2UV27v4s.O1_MNwo9d_GngUxwIF2Eyx9fDXMK87sZ Zy6fSttMcB.mZYOu.w.qMT6kVZ1.2PbGGtCNK2iyAa0Va9WMyVJbJiYzMVMUwAgAS6w7hPLR41R3 i4D7FzE25Tr_Cv0lzWerQpnL1.3vOpzV2rB1RpyU.C0wetvai.XT2jzafqGueUZm1PgbbTNjT1DB _vEzZ6P.mJedEDyiBqDRo5_SlZXc01.9SE3Yy7d9Rf8g._TF39FJn.4gyYjpbPyvnox9xwouxcvF 1Cr4wNB0k74hNU9Dr646b4yFrm0rYdIoQI6bd8.v9bnWLu62ANPljaC3TS2thyZmLlLZs_c60g3L ImrP3uB.5d_AfvVrMn5AixMQQL2K8PDUtTgZsxpONYVorBzhMytFnud.bAGNojr_OYU_g7b7NXJM VyZuLlqsfoT5j4Ml4Jmn9ooVswjgofAPJ0j_Dal_06DU2arnh55Vif7rXVEj20TxX2cEeu93Wt1O aGJRQGXlF4uplvUx4pgsDx1Z2MqpVND3TODFZAogPc9WYc3LQgDez7R7tI1cCmSUgsXWK3hN3fr0 P73M8PxvsB2TR7.xZKJIkGNTLkbb17Eq0_oAYzUMGD_wPFgZkMiX0Hru4U8YWwGeDehPKWqdmtLB Kvtyy6272zyGXLkANWjYUGUrEJeU0R8QneSa8KFMqrdTRwhzd4z9cWiClLzuMR.uv9ACQZHCuVUx MQF7PbF_TyqJixNcnjLHhBenGAoaTu9dJvopYV_JFXJEQzkJvmiSAonjE9obgl7Fxeb1Snhq2AW1 AC3Aq2GdS0E8EX9D15Xm4ZxK4pSaNmUYSe2ktwvF77YtgxgJzLm9HpZBpDnjqpFDLa0UosoZIT_o tVIof9cX4i4xCdC0rrKnQPOkNKucBFyrcmuCXb0iaUD2Y_zk7DPo8m8Z5IehrwQukyWheG5mZi04 R7jYIDWQanr3N5l9PX8vLVAD8mM8Hy60_niC4i.iCFyS5ZKzTsmE435yps9rxuWJzKQo0IdmwoLb Vt96yjmpy0KhlQIFmonk3KDbF20n9gEn6ZCCsFhKK7paBXkfzbq43q85CKWYloSLX3sEo7fuURpn Ae.VlLb9iIpAGTC231hc7Ftm.zRDMVqqzWLonCCaCJ8lJI2a3NlpiXztbGu9.BBST39qH7LtXoEN eFYKEHlrI.v.H3Tv50ZbsI9aiXCC3Ah9kMCcJ5vAhUuzD36atV7YuYulG_Z0X7jODxduoDz7xfUS F6FnPB0VpYMFXVi8neAoc55dI903DvOVsjpSTvZj1Bx07EdS3WkYk.VsFDWbe_C6lQpxtv.M._tK HxIfxtUFLfhIqL4L.ksPSrbV06hn59ObWMQezzvs8Zgjz6lvIslhqN1dcw3Y4XKeBKhqXIi8odyF 2ni1ufGuvg_v1ZnFJWUuEHIowo0RzdZMu_bcZzfGhL_ziC9yhaVOTjMyMMKUELK9Iv5rgP5wGucC Rwa5CnFiuyJtK39Li4aB013WSH6xNi.7uakZ3lWGsCuvupQHC5D7IPof8x52wW2v3KJJlmr4oK.8 3egxJ2xnSnWlwiFKV6G2o2AUXpKuJLzJgehrgD6MJnBCUUVtHz2JaYyzaUWL.5jhZM591FRHyTBc VLo4BRquFQsYxJ2EF X-Sonic-MF: X-Sonic-ID: 70cf2c66-89ab-47da-9f45-34579a8c2829 Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.gq1.yahoo.com with HTTP; Thu, 17 Apr 2025 19:13:49 +0000 Received: by hermes--production-ir2-858bd4ff7b-9r9sx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6040ee699aaf3d3f072b53831b62751d; Thu, 17 Apr 2025 19:03:38 +0000 (UTC) From: Ruben Wauters To: Greg Kroah-Hartman , Sudip Mukherjee , Teddy Wang , Sudip Mukherjee Cc: Ruben Wauters , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 6/8] staging: sm750fb: rename sii164SelectHotPlugDetectionMode Date: Thu, 17 Apr 2025 20:02:54 +0100 Message-ID: <20250417190302.13811-7-rubenru09@aol.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250417190302.13811-1-rubenru09@aol.com> References: <20250417190302.13811-1-rubenru09@aol.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Renames sii164SelectHotPlugDetectionMode to sii164_select_hot_plug_detection_mode, and the param hotPlugMode to hot_plug_mode. This fixes checkpatch.pl's camel case check. Signed-off-by: Ruben Wauters --- drivers/staging/sm750fb/ddk750_sii164.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index e2da110fab81..2ca72bfc67f2 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -283,17 +283,17 @@ void sii164_set_power(unsigned char power) } /* - * sii164SelectHotPlugDetectionMode + * sii164_select_hot_plug_detection_mode * This function selects the mode of the hot plug detection. */ static -void sii164SelectHotPlugDetectionMode(enum sii164_hot_plug_mode hotPlugMode) +void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode hot_plug_mode) { unsigned char detectReg; detectReg = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & ~SII164_DETECT_MONITOR_SENSE_OUTPUT_FLAG; - switch (hotPlugMode) { + switch (hot_plug_mode) { case SII164_HOTPLUG_DISABLE: detectReg |= SII164_DETECT_MONITOR_SENSE_OUTPUT_HIGH; break; @@ -329,9 +329,9 @@ void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug) * on each individual chip design. */ if (enable_hot_plug != 0) - sii164SelectHotPlugDetectionMode(SII164_HOTPLUG_USE_MDI); + sii164_select_hot_plug_detection_mode(SII164_HOTPLUG_USE_MDI); else - sii164SelectHotPlugDetectionMode(SII164_HOTPLUG_DISABLE); + sii164_select_hot_plug_detection_mode(SII164_HOTPLUG_DISABLE); } /* From patchwork Thu Apr 17 19:02:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ruben Wauters X-Patchwork-Id: 882044 Received: from sonic317-20.consmr.mail.gq1.yahoo.com (sonic317-20.consmr.mail.gq1.yahoo.com [98.137.66.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0697E1FE461 for ; Thu, 17 Apr 2025 19:13:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=98.137.66.146 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744917238; cv=none; b=lvfOtj2BA8+A/ATx7WRYoyBb+OxibCP0EwrP+MWdDXuXXXXchxULDZkXuRMhjzFmjtDJ7ixXN12YO32qAlWGqb2qGc2QkIxwjVNeGkfZAIUtDjciprCq/Xuc4mAgh6oeeZCkAwIgT89HJ7Ft7LrjTrl2xX3nQKudjbv7Izx32+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744917238; c=relaxed/simple; bh=+ec0rFb1W7AeTJVoTuMhsZFoFYiZixA+qBTOKYTMP54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PWxevO0vOIPxVP5YNmkj5EdP/+M85SCRp6oFM8DuKoKnFhcoSm2BM0YdX44M06CuB918xpDNFc71kF5IfxcyRTr0wEHcwVJ8HmdFvjFBdbCNkQ3AyqHmslqaM4tjR5qrsY0jj6mmKhjG7WU+mIiOTVSCyjmd8fQBYbmvKVVlM9Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=aol.com; spf=pass smtp.mailfrom=aol.com; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b=iX7wL4GC; arc=none smtp.client-ip=98.137.66.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=aol.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aol.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b="iX7wL4GC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1744917236; bh=cjitrlGIeWvZm78t1AeQAS6TcUQQ68Ruh4bXLe3iACY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=iX7wL4GC8yrPzXJW2XmONvqfexsk5RORrEfDyox6z0+grLx/XgTJAASjJCFM3y0Rt9kWyB5VPsvJBocLpTafjNU+/U2Voh9XdPcOQFxYHkJtpRmTNXX0PaBA+yoYlTdr33MUNZvcF2gaOw1zKWHtLBecBTiP/0/dov3ixK8QnNExto0bqRalruS8+byguE0FWRc4F329FxXrN12aLOdLBa3YDmDkrXaliHOLpUvAPmeHQ6a5ux3d7punWt43iJUpURolWSyqbMEOjJ5Z05mFdSVjvdDkbf35xMLTqydqx8wTqQqeVY88HPY+qmmwHBXzaVBPgg7FuESXSOJ2CBiw+Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1744917236; bh=NsJmLlxYCGUYUBJCW+7cP6eD76IS5ByO+T68oiB8d5x=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=VSo8qYDtjQvBgGIGoukBAMInb/gqbMocOGgblECO4nRo7nne69p8MO4AxbHzCHYEUEYw4G9B/W7AxDV4BsUPwioRUex2JKiJtZj9XwQOFL062UuSFT6QEDFlIRBAhPL9sDdCxht+052iEhv0KOFuWNbhURUOMSCkGjm+nwzTvIr+vFIpHEhKtgjBBTrXDS/Uhrm3sV9gqs8pB1ZXO7SshMaPx2NMT+un3CSCC4VgrU8voyGUlHJQ8NOBjMiWgWq0/JKyw5Poj04O+xAR4aUl+03JBEl0h/hXE4E42WeBoas6KlprktoZQ8OVlO4vr7DZI1Z/5UyO3HTCp/IkDbh6tw== X-YMail-OSG: kIdUpAEVM1lBKTALP3RK39U5hL_VKxWNvJgxXF7vk9LBIaI.AjgsB3GQ.JEDbKO 9YpmwAGkPuvc_oL2ArM.p4GURLlkyDZB6mYfKicjkqcht1gIne6rJGnk7DmrR9ognFSljILPoQEj 92TXUojusPixOu0Qif5U88hgPHCNgsxcdEHSCsdbLHQOBF_._KSVrzrbvFWluDtITwGaGWRJ_KLW hUHOyQXYoJPkF9qGrQQNFPpx_j4lwGXN4vC5tny4nzVzUyUpW72j5XdzxvJ3x_HHsWKpgfP_wwRe CRcSFoFTxYYK4y1W1tp4gO0WZ1t.QIGhyo2erI05njszeUX49_2GT9hPrhUgA.6PMUH1zCIqGqBG hrVbhPt9YkFRFimX9VnwqHJ2kJgPkCJ8YXFyTQBbE7SJp2HiUqFe2ZfU3Ta6Mc5EOj1T5RvDX070 3S0U_au1MmqCEV5MP.DUViaCkhwVEZ8Hfi6NDKT366motBvB75Q6lWbtHqcYzsIZ_tjZRZ5n54Hd Zqr7.OOGeBBtn3wiAH58DJVvxL.JLFHq0ls9g9Ogvybul2o_BPS_q_swaGieYR2m7RttctrUvlgi wd9ur92VZt0_wlAn5aRtoTvFi4qgkRUQ2WGAdDTE0qMp2L6Yllzz_Mznki3iG1CBqrcKofdA032e v4POYEFhXv3tHjrjN2RHubGENC.bVpKbeprE1ivF3rNmqJLAEc4Q0zr8ML2nfktrgaxlvNmxPjmg Kk0pvv5sw9MdjP0Le4cUUWFGuNHlB5jLltx1.jD2svId0h5mCMMLnzG6XZjefyB0KdUt.KN7u6yh nzCm..yoRk3Xr5e5_DHmaywwDn6B2hyBwhIGM968pqvZXUtlvhTv.l_DA60Ti0QC1_HK6EGhXD.C Nf65nFXJ99qjps3f6pZUznHuboXkFMTr1ZdT3n.gMCNNzfi5rlzQSa1gSBVjHR1HY5f3xHSwdGbT uthZDfEhJ_qAaOMq.zzAv2IDOr8vp3h2piYYZ5nrfx21oc5XLEVy6d66Qf3PkKiJ2dIOwABIW6k8 GxkW03s9wY.gm1DfurPICVgIKsNhZJZ4zOZwZxeG5dpvAv0nK6yqZFW3fkke_tZ2zKENwmngEgbr UuzjwW4Cbo.wUfI4ImiEmPMT9mOAGuXYr2Qm53k4vzX9fXQP90s72CkGp.cYbkjGz8AoKHtZmTEv jVP1rxg067eTO4_6OlwAJIZo4pyTek9EumXT3DPXC7SeKuLRQ4y24jSLOo0NHRNdz8YCx0m82JjO 6KxJHoLIpFYr14z27DXSiuln2hMm7Y2Los8.bqlVvERyHZvjYjtXSADDZqCIEAnP6qwY1OHhEgE2 sXCAMGAa7Qq1REth5DvQ1luIyTf7fTwKF47N87TUbBvzPMBN7WdOgOm6loqaIT5PwakEC71U1N08 SUS2bUisr1Mldg0F6YSZsPXNyRR08IwdxZZBhcuIWTLrveEoYyE0AZM5J.IPed2Gjuk5tQX7nL2X hi.gdwrMgMU7EedGUnq5Lv9wOmFqMqY9ust2QU2EURsqb6I_TliTbPgHiY8epBGqr6ZluIFrS2bs ElC8Dp7imr0E9qWSt0RpCgQPmIGNCp29cDmqMDk056Ty7dW3MYy.B2kHTI0xhDIRRaKMWWvQ2.St dz67uo3ByyR1RCQZ2bVtNsS9Q3hiePdVjbITmar8VFY.J2DxYEC0iYevSriK10YUigRz1d84Cq.. hjrSDSJzLevefMNjDDkZf3zqFpyUe6HadhFagk6nBggYtI.EZ4XlgJ.2X2WUThzdMMnzexglnGNz uOs3SMXdIG0qTAjMfqAkr3aQSz8I.wVhhcjRAw9rNYMxJfbmgVHtSLRG7SgGnTn_qtHS7_KJ2SUO duuX4zZqo0et0y54fIBA.yWROyrDNcFz7GpnOggkIJe08cjtdPlqYP_I_92jBqgDop3t6JYhX8KV DmVVf5jBRMRtAQEgI9E4PhY0Io2LGbWCeJtOeLwvVonl8qqtJRHijFp4d2oX_aT9JKd3tjBYNBXB YI0hk9iOfeAUMYLgeT1ziyVdRxRJkdX1chvz25ff5t61eGJsMK2FIbSHh2GQzzbCohgLTY2pfPFe _zHiqZ5uv8PZhfA.IWoDlTyW_Lwf0h1bv2JTguiDA4EPnIXd1kRyPre3VI3M8yHQa7H8j6u4LMpD _CQU78QnY5Ttz9sOra0T1D_dOo.o._ZHmaITqNsYRHhLdRfbhG07XTYHa317CjDhPNrj3Uy85dQ1 2aSeirX9yPiZQuqour91XE0LnKT3uTaKDrl5rLG3JZsHiXK0pkcn89RUeps42efLSv8Pf4fuagQ- - X-Sonic-MF: X-Sonic-ID: 6fd2d702-25f3-4ce1-8338-2957403ed49a Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.gq1.yahoo.com with HTTP; Thu, 17 Apr 2025 19:13:56 +0000 Received: by hermes--production-ir2-858bd4ff7b-9r9sx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6040ee699aaf3d3f072b53831b62751d; Thu, 17 Apr 2025 19:03:43 +0000 (UTC) From: Ruben Wauters To: Greg Kroah-Hartman , Sudip Mukherjee , Teddy Wang , Sudip Mukherjee Cc: Ruben Wauters , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 8/8] staging: sm750fb: rename hotPlugValue to hot_plug_value Date: Thu, 17 Apr 2025 20:02:56 +0100 Message-ID: <20250417190302.13811-9-rubenru09@aol.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250417190302.13811-1-rubenru09@aol.com> References: <20250417190302.13811-1-rubenru09@aol.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Renames hotPlugValue to hot_plug_value fixes checkpatch.pl's camel case check. Signed-off-by: Ruben Wauters --- drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index 769cbe768c49..86490c87156a 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -344,11 +344,11 @@ void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug) */ unsigned char sii164_is_connected(void) { - unsigned char hotPlugValue; + unsigned char hot_plug_value; - hotPlugValue = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & - SII164_DETECT_HOT_PLUG_STATUS_MASK; - if (hotPlugValue == SII164_DETECT_HOT_PLUG_STATUS_ON) + hot_plug_value = sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & + SII164_DETECT_HOT_PLUG_STATUS_MASK; + if (hot_plug_value == SII164_DETECT_HOT_PLUG_STATUS_ON) return 1; else return 0;