From patchwork Fri May 8 22:01:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 186438 Delivered-To: patch@linaro.org Received: by 2002:a50:3a95:0:0:0:0:0 with SMTP id v21csp6399799ecc; Fri, 8 May 2020 15:03:07 -0700 (PDT) X-Google-Smtp-Source: APiQypIC8dDhHpy1HpDEWbAX+nSvm6eSwQ5TncEAAqNuI2hNfd/6cbCJVsQgqRq+LAiy6d3X5Xvy X-Received: by 2002:aa7:8429:: with SMTP id q9mr5073077pfn.308.1588975387165; Fri, 08 May 2020 15:03:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588975387; cv=none; d=google.com; s=arc-20160816; b=WpA4TEYcNaZIJ/w28jnvQvHGw6KK5EIxzgIuMq560c4QIwsb6kVuaVY3AwzjBLTK0Z bPZRXmC8GCCGA9yT3Hp492g6gF1ovLHMZUh+goGHbxLy3RHANrki443eccGbZJi971Rm 2TyxtoCQewmwdcfB4j6rtDOyYVFqfE8k1tnEL10lg2JJqpiv2l/ed9F6Rs/R9+vOOMmb BEYD91m5LdJwSLgS4Zo/voTe3CZzVkrU54ssbqPJS2+wsCWDTJG7DLsm+ZiGpVAhmj51 7cvGKNNMpouTSdaPvggtWVy7xicNqtIuKdB34tUSjHlinRBJvwuY4ymnssAPixVswM7+ zzmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :delivered-to; bh=/s22rx4oYtP7ek7VY9puhF3RzE2b+y95e+dcKDBWB3Y=; b=Puv211CaV/6z1xNOgxxKKueC8EPkcEwaDQhr9KCY80ThJgQMNqovV3HQxlQy3HChKb 6Sj50rtYSMZM1oiuQLSiBu2IXwtYZnYuVC6gfR+5KupxoFzoWOxSu04/cU8o5IIwBb9r UopVS19L8JUGoFbFntdXEwIlKoBgLwFrsdiW9kcs0whU8043NI3dYKjv8PbBpKZzHv/a i/2k1hJ/yet0QTzsAr/eqLUbqIYto+wxAUeY2wDtakrN8kN7Jtgy6FtR6nUmsYqzMZ1W EJM9QWtHZLjGyHp/RhVqnkTYKpGkwZTvg5e7CmGfO3ViqcXbrOkWHIUQBIZsTnY+bxrJ FSBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id q27si2075911pfl.15.2020.05.08.15.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 15:03:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A3466E29D; Fri, 8 May 2020 22:03:03 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89AFD6E29D for ; Fri, 8 May 2020 22:03:01 +0000 (UTC) Received: from localhost.localdomain ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPA (Nemesis) id 1MCsgS-1jOPdr2RNo-008sQA; Sat, 09 May 2020 00:02:03 +0200 From: Arnd Bergmann To: VMware Graphics , Thomas Hellstrom , David Airlie , Daniel Vetter , =?utf-8?q?Christian_K=C3=B6nig?= Subject: [PATCH] drm: vmwgfx: include linux/highmem.h Date: Sat, 9 May 2020 00:01:31 +0200 Message-Id: <20200508220150.649044-1-arnd@arndb.de> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:TAKq1R05pzqZudtB3/eJjJKa8Xbr2qqNSVjJes2lRdzfJo28ior jpG2oBKBCIM9I0meRg4Do/dfII5ARO/ZpAAObB5iNU3iCCuxDZGC9ur9gy/e8/N5KH40xtl zubxBxUZ2TAxp6I2EEFhblKzvIbDSX2HvY1w7/WTEtxBhmU5S1+U1tGYNScR9bWvVvA9Lwt SUVJX3OpN5y1qagavtf6A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:pQ7ZCJSaxLY=:CvneInVbDCF7wVcYheL91B bulOWg0njJ2uR9LvROcwWe/vwyNzxp5K6WfdXMFHBwEkfhTNw0bVcxvD8IrSFpD0KC8TviK3o 2mf/G8Dp7vGxGjScYm3LYde4pML/2dOUn9jiACrP7euRObZ2ijeOmEhl7jDEy27owpQao6o2f /SO03TB54PKwjk02/NXDsKOt4s7Vlel69d5geccRqk/dbPKsFx8eNeNQ70KZvuXUCYo+4gVNq AyrJYxx33AFDDBvjdTHUp8WSM6BvmQY8xW8tmCKPFZ/OY3h4XDKYApKCqQcok9vc/Qo/vaGhs Cy4G1g/dwFG7OyX+Lzq0K7xNNA1ZNy7YHIwqeqk0Kux4fHCq1lYpEGJqCsjRZ8zv5LJpjF4S2 7p3LKoai6c/b8gZZJsch7W0e69UvHCI8bPdzFlRuGC7rm0ykWB4NZuqLTBuIC/HlzC9Z+kAId aBhvtAWagKCUIX31Q2v8+S47zcy1i2Z7zC+nzpqp3TUXriMCajRt6Kg+rQkJdIQhxFj4HX+jd rcSxAvUskYewdmUfBkJAQ2hiaX28j3DARTaEFxcJRbZdL2FCMy19Ug0uF0zjogz2OxmG2Uqkr 4diBlDY9L7RHRrP3Hfb1MvdUSmkkFobkFN3S/ePNCydC65ZSo35zuFVrC7nvJguXY4+X0LBBM 0Kr81poPPMNRnAsqTGRyZTs6vUqrzVL99DXoxms9mSGpDdIlNAzAvd3gqYwC/y7Ucy7HAA+YU 3LyKV0Rosfc327PpqLHUs9jXHfSB+As31A6g12Nkokh9AIYp17vU1b8xjoLwZtQf1wF1C7YSD 0MBAFq4u699ZjeZp0+NmUAQBJjY3JBFW0XlU185Wm7IMJzeY7w= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Daniel Vetter , Dave Hansen , dri-devel@lists.freedesktop.org, "James E.J. Bottomley" , Max Filippov , Huang Rui , Paul Mackerras , "H. Peter Anvin" , Ira Weiny , Dan Williams , Stephen Rothwell , Helge Deller , Christoph Hellwig , Ingo Molnar , Arnd Bergmann , Borislav Petkov , Al Viro , Andy Lutomirski , Thomas Gleixner , Chris Zankel , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, Andrew Morton , "David S. Miller" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In order to call kmap_atomic() etc, we need to include linux/highmem.h: drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line': drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of function 'kunmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration] 377 | kunmap_atomic(d->src_addr); | ^~~~~~~~~~~~~ | in_atomic drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:391:5: error: implicit declaration of function 'kmap_atomic_prot' [-Werror=implicit-function-declaration] 391 | kmap_atomic_prot(d->dst_pages[dst_page], | ^~~~~~~~~~~~~~~~ drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:390:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] 390 | d->dst_addr = | ^ drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:403:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] 403 | d->src_addr = | ^ Fixes: 46385a895322 ("drm: remove drm specific kmap_atomic code") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 1 + 1 file changed, 1 insertion(+) -- 2.26.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel Reviewed-by: Ira Weiny Acked-by: Randy Dunlap # build-tested diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c index 94d456a1d1a9..1629427d5734 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c @@ -27,6 +27,7 @@ **************************************************************************/ #include "vmwgfx_drv.h" +#include /* * Template that implements find_first_diff() for a generic