From patchwork Fri Apr 25 09:00:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 884625 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4F0D238C19 for ; Fri, 25 Apr 2025 09:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571672; cv=none; b=aH8//VyCMdxIjHvXFwYBnZfSTWzthvA390RmCQ47ZVkhs9jH34kk4kjibEWj3S32DXU2GdUo8kwApy1G3x6MAIjWCw0oTUeMe5UMDrBAkXHvUHffw9JLDpdPG8W+HbS5CQKsW7tTK9yQz+b6JJZdtZ1THfXv4Tf8UlQ6RJHfRz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571672; c=relaxed/simple; bh=phhWviKKhhzzjzPDil2DbjlngOzuC2xCXBD1aK0WBVg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=N3O44sqWKC1AfT53mDhOUoDOsBPoVvwQ9AeGRJpZ4AG3LeFfi0NZzW4Ckh1ECzTuQQT9Den2V3QYndvGGZ+nd5nq7KcsoS8jsbkvpfhCyZxzaYdORc3ErfHOkF25aIMZ48uFjh036EdgETK5wGlEJ+2tlButmaH3nBQeE8GOgTM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=EYnj0Hxi; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="EYnj0Hxi" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3914bc3e01aso1163896f8f.2 for ; Fri, 25 Apr 2025 02:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571668; x=1746176468; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aG92M+ThGG8rcCnZb6WUafkA585r/LuxT+alwijT/5c=; b=EYnj0Hxi6pW4zADwpWaOo3NtQwbi0vT+6Hk+dxRI21HdXhQrg+F2r/uAcsJWHRbrYK pW2OOIgmEZs0gktiK94MCgPEOLud5BwOTeoBdCLQqlekerFZCzSI+9A9JG96uqtQoaiS e4SYx9dg25qQjdKXQhqLtRlWA5iQxdRqLe0uBU0l9JNU2GU04elS0OCVSEFD4JPFJRuO brTs5DQzxozWyP5xoPAK2y8uaIDXXM/hlvIAR9OPPc0QkTOxlmwp03bWeP8FSq3hzS+K ATYpHlNyt7wNzUiYibGon8VZ00bEM7cswU1WbqD1QtIq9bDWgNcgeYcZX5/KO03IE1Hy DmAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571668; x=1746176468; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aG92M+ThGG8rcCnZb6WUafkA585r/LuxT+alwijT/5c=; b=snndeIvm3R9iJ1W908OQ6oLlp5yVhqqrhyLA2+Wx0VLigcCkAJqhSx781YCZQKII0n 5QLSvtmB9IzMYNAz5bKJWhg3aU2iq83vrnpM2jy7WwU0e8WC7H/d077AmzOJTnaKkNV7 TWnNaQTEfRMvFVcL+oATQra6YlCyORZMNU6RnbcmqVDXDXYh48EQcN6ME6ig62ZdI+LO k2gwI3RNsZVCMzhxJt8RZPYyg4TU5laEGaOWtizDt9dnaJYCdt4ZwKBJzM+GIifCzemp ZLTkeoZQPZ+7etnCSePiVhIl+9WZ6tQKVO3czFw3LeCRqXwv8OHmu7vk6oRbIwXAGvav 9IQw== X-Forwarded-Encrypted: i=1; AJvYcCXEFeVDHm+pRK9HTensQMrAHu0X/8kcK/3rSCOuAlQ63xI7kT/qhfoYBS1DvNqn0J4pOQVtAngXwR8K@vger.kernel.org X-Gm-Message-State: AOJu0Yz7EwNBQMJ2orW1UY1muZkfd+6ei2VTzCVDrz3mxoe1aVeixz3n oLbZ0BRJYNHjOd1i6upbWWoPVGg9FoaMu48VPh7iWmd/ypZRuPI+aQCZjDZnptQ= X-Gm-Gg: ASbGncu2N88NVzmcq0AWtcdCTTSI2cAiQwDf72UTbIn1MFC9JAQahppnXSHDP/LmIZy q5MUR13LaejhvxQPT0cbtxyHpuQTFuiTwFPPN+c3t8n8F+S0ljLIvL6S1Cj4PnR9yQzjUMQRqH3 t38c1p4Qf0TMEvxBwPqNN/TLsZ5grWngr/eaeDxeAraa/dES1gshAjC7YUix0CfWEhgPV/zkRNC 3rHQvvhPap6hmq09V6axZd9EVtKCvj2AfaQ3/lPFRzl2expz4QCedhGcU4y0d0ElEsnoJ+SJiHF quvsyTXtssIokQ89tbObaoFg46jPaWclWg== X-Google-Smtp-Source: AGHT+IFW7oHQT2iQkXG5/oplsgKCVuoYvLPqlkf0fWIPHa0BO2c6LkQgBuCA2L7Ixcx9kcJza03b8Q== X-Received: by 2002:a05:6000:1ac6:b0:38f:483f:8319 with SMTP id ffacd0b85a97d-3a074f4853cmr1080551f8f.51.1745571667902; Fri, 25 Apr 2025 02:01:07 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:07 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:00:58 +0200 Subject: [PATCH 2/5] pinctrl: mediatek: paris: don't double-check the GPIO number Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-2-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2274; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nUKaoN4taOpveP3nc3OVuJSxVohaZIGpFohuQJLAScE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09P1im4kKMb6U7RG39p9G/VrnbdkYWFGjboY 3bmo1dLQC6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPTwAKCRARpy6gFHHX crgtD/9is3Kf21qiXzq1VSscbgtqKAJ8hb/XCsd0cS2PtTKxYDWP1SnTIL4KX7ofzZY6+UNXOZp dy+D4aO7WNZsFR0/IHIeqWBWEk3rmMlSGkbfrIVDhpWvtIo6opyCQxql8Q5LViq0LRe6JEPRdoC Lor1QT7DRjA92oRtQppJ2/eJZFWLujiVsYYPLfXICUinmpUOHk2wHZ7Juzozwht7N/RM8hDQi5w Tq5I9jApIX7HuFwuRuILD7KrOPs3yAIkxg5EIl9t/8uEheTZAUl8gjFrt2oXh1d8QjiG6UIsnQ0 FCxUF6W7Qt3yoXvJB7BVE+lfhs5yJuhuQiBz7jSQOmUCnEpPC+rnlE6PEgqlrlB4S3UfQMyfxXu TkZGAWz6/V/ricSCTfoPbWxtHT/fmyIr/PoIil6NMgsEtw2lsTQZclPoBCEjv8FSHBZaLlZp21M QjWftw1cUSxo+sR0S6FDFFCo3EdAN3zIgltKS6I3KlaRXzygoM+OsakxjcXFba51INkzT5w7nD9 EsU0E0Z17ILt6kloAzswTHoIJKQM1NeKw/qUNa1zMq4sLMkRIadcAf8J8lFYGsqLQt+KrRyjmQN 85NWWLYzuxDF0gYe0/Ci8Zos6oglGyM6ff6HvFfXZwh0zf1/igURjsYJ8qyXym9CZlTm2F6YJGx sWnd0wD08yn563g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski GPIO core already makes sure we don't pass invalid GPIO numbers down to the driver callbacks. Remove needless checks from the driver. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-paris.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c index 87e958d827bf..852ce0ac7ff9 100644 --- a/drivers/pinctrl/mediatek/pinctrl-paris.c +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c @@ -840,9 +840,6 @@ static int mtk_gpio_get_direction(struct gpio_chip *chip, unsigned int gpio) const struct mtk_pin_desc *desc; int value, err; - if (gpio >= hw->soc->npins) - return -EINVAL; - /* * "Virtual" GPIOs are always and only used for interrupts * Since they are only used for interrupts, they are always inputs @@ -868,9 +865,6 @@ static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio) const struct mtk_pin_desc *desc; int value, err; - if (gpio >= hw->soc->npins) - return -EINVAL; - desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; err = mtk_hw_get_value(hw, desc, PINCTRL_PIN_REG_DI, &value); @@ -885,9 +879,6 @@ static void mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) struct mtk_pinctrl *hw = gpiochip_get_data(chip); const struct mtk_pin_desc *desc; - if (gpio >= hw->soc->npins) - return; - desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); @@ -895,22 +886,12 @@ static void mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) static int mtk_gpio_direction_input(struct gpio_chip *chip, unsigned int gpio) { - struct mtk_pinctrl *hw = gpiochip_get_data(chip); - - if (gpio >= hw->soc->npins) - return -EINVAL; - return pinctrl_gpio_direction_input(chip, gpio); } static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio, int value) { - struct mtk_pinctrl *hw = gpiochip_get_data(chip); - - if (gpio >= hw->soc->npins) - return -EINVAL; - mtk_gpio_set(chip, gpio, value); return pinctrl_gpio_direction_output(chip, gpio); From patchwork Fri Apr 25 09:01:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 884624 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7042A24A063 for ; Fri, 25 Apr 2025 09:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571674; cv=none; b=Ja7LSHICsuPraujqjNIFu3w43izYTuJfUsIxhDVxU3tsPc0a/qoaX66Y/pOz0Tu301UFPRM+hzJmpgnYYMZA08yrUhtLhNnPvA+Dedl963dSZbA25wX1aPEFZk+qPfEvYn3+baujlVQO1cV5dQgsdG+d9KvUBot25G0GBcaN5+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571674; c=relaxed/simple; bh=uN2bLV37uQ7yhWkU01vCeS3PVLdk4JLJCesbUjcmI9E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=F6hxvW0SvnXokCNDTgEOMVTcnzSEdMXFrVz6WXPYHDpqAbQyjIyGp7C0gH7LaOi+zE0i5VDmqUBmd4dve+B1FLEmWjydQNnHkoeTfucX/SXi7A9tMbb6PdobMXe/DzGAKPX+AJ1ZGR2hwlCnMDZOALhEE1jJGx52Wi3O/okuvDM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=u09wwlHn; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="u09wwlHn" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3914aba1ce4so1485893f8f.2 for ; Fri, 25 Apr 2025 02:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571671; x=1746176471; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vZCsMbe0k2wJLLxto/ZgvqQ6R0v/kHbZTO0AQGYG2lM=; b=u09wwlHnfHMNDB14IRJ3ySkdwNEEpoDiW6DiNs/OFKl1XTlirIgsEA4C5n6UA4BmNH L90RVQd0ut6IwEE5RZPcuoKThp+L3z+lNpO2hHnWlkX9a3ysGwRnr2AK88VbRQmLdZIv 3ED26TSwXN573dFOS9+k+OMnBsskkMO0qahAUdVYyQ/dAEHqm81ft7mjEp8Qdmro0Ogm umSRSffROk3OBzhpyeS5mnZW127/awecrIxgujmsk4gM6a4r8F3RxA4dYrT6X7Ba8ScO FSNHZgq7t2Rt8mD8yTkp0DSvKpEbF+W81EjnRoQDAHw9Yv/9UKMJwLf4OQmRfN1y7tSl +b2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571671; x=1746176471; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vZCsMbe0k2wJLLxto/ZgvqQ6R0v/kHbZTO0AQGYG2lM=; b=E92nZ9JFJbkwVn1zghxyBkoX6aXow7EuPU9PPSnAQ4PnjVoAr0wHW75h6r/5eQyAGJ Kb8KS/zlmQpb7PdceY6WACgQTeTi4i2WckvQ/NBYtNbXrmEQDmiHnWhcdy7B57K38zYL s8NCHfssl81+fKaqVUlpjflVBC1HJ/EH2PXWyMLkgG1FQ20BOpiOkntsLuxEc7KMkObN iepbfWg7G9AX8/+fxeRv7zGxDT108+io57JdtPv22IVF2+6M2niMCxi8KVnHgVrsw9OV 2dvz2fV33TBKS6bgYBSpzv5u6DhRO4O+19P8zeHART8XhxoNmeg2LyxM5HuU49gJsauX cX4w== X-Forwarded-Encrypted: i=1; AJvYcCVS7vrNIEg9JoJLaP0F/Ky4YrU0Cy2VXBr0ZkRouvurAuFyEEp7HOVH/OPUeeBlV/h/LNYiOWIx7tWe@vger.kernel.org X-Gm-Message-State: AOJu0YzjArYhScffwV8skA2ZJUj1Ax/zahYb5SMirmigCoX8kELmAoY3 xSpD9slP3oRYCxHcLkH/i+hRvxIauWepl29skq/YObhmCk8CosZKT0Q60muvVhw= X-Gm-Gg: ASbGncsxsmOczJXjDklHzjh4J057kaeCkgN8exCbaWYMJvS4myz2yPAgxejH54x/9FW xpX/gWOEgVRBTH5PAoL0qVgcXhXmqR/0rpJfBsBCdcDedFRswqrC9wYjUpnjxlpt0yIFKGBC/B/ kU/P4IR5/PGOvzIy0MK6lC61L+zxkkTPc2LuFwrc2Zoz4oF8p2BRwxiHNErTPntLwNMt359sZq8 cWDr3BY709kyW+DAIGgVfmisLy0fHm6gDmW2ou3mxsNGPg3ssc32DSxk94VqUQcwQRbEMHcnsRf S41+kXZq4ngMhIxTh8D7FCtMcIPlbeaSpQ== X-Google-Smtp-Source: AGHT+IGjMuaC5BmBdOAnNw7BlPBWn5JH7qcxJo02GNuwlEcPgWwbqMJDn55V+Su/wdq4y957SwZGFg== X-Received: by 2002:a05:6000:4282:b0:39c:1efb:ee8a with SMTP id ffacd0b85a97d-3a074f39870mr1172764f8f.38.1745571670663; Fri, 25 Apr 2025 02:01:10 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:09 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:01:00 +0200 Subject: [PATCH 4/5] pinctrl: mediatek: moore: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-4-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1973; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=K7gLMO3ecqvlBUfWOX7ZuqqYALbBQMdAQOJ0o+WSEZA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09Qz3rBKY7vXoDHlL6r3flVEWoOZY6T/FJWf h5JONq15geJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPUAAKCRARpy6gFHHX cisXD/9P57W0/UnC7KoUOw8VjozyNtjJ1rN06vVzNxprMdmp9PDpNlGb0vTLsahD+4NFVA3Q1BL p1W7I+viQtlMMu9GaPYfJgGOurfA8HdjHskblOFIVaifefVYzwy2jSyIPjndcW+rdrur5zeAwkl 2zepHYZVYpZK45EtIf+V/938Oo0Sfmprv9Jio66HVvXGnuznGrUD4gS7j1tXl1/KdBqqIks4J7K IZwYIGhxQCVmj55ubdey7G1qgtAqasXlnOmq9xRmLGU3IIqENBgY9EV9KwrH+voXt3ICY6gqxy5 ecCqIeMwR2gTvsucRyqxVP3ZfLDYlzvJG77PA5K+BBEorzi/oTKKRomwKzJl/s/iWZb4zX97gER t2Zzm2q4K5EzXkWxGUzYdSPep/j22uNtt+kTIzw6PK0XYmS5NPOcvVC8rmjW1NGTOGndaoMkDHY 6MGmD/rpGacA17KSYUf+2PPtddEV5m0SDFIR41604HfByN99tInJvAKoH7Kn9s39Mc0stpq/RdX tCJiiYx/RWCcSM5ECjAiBzfR0o3lAyuS7+JcM7IAzc+W1rRG7ZJM6VQyOw95oe3Iupn4SLvv6yR Yw2WuWfIJnLiAzyPLUNqqXVE3CeyFs8pJuou+r91bJDnhIWJo7Ukqz9HMV6keK0XO6MUEid9Dec y24dE/UdR6r4niw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-moore.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-moore.c b/drivers/pinctrl/mediatek/pinctrl-moore.c index aad4891223d3..827d0f191031 100644 --- a/drivers/pinctrl/mediatek/pinctrl-moore.c +++ b/drivers/pinctrl/mediatek/pinctrl-moore.c @@ -496,24 +496,26 @@ static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio) return !!value; } -static void mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) +static int mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) { struct mtk_pinctrl *hw = gpiochip_get_data(chip); const struct mtk_pin_desc *desc; desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; - if (!desc->name) { - dev_err(hw->dev, "Failed to set gpio %d\n", gpio); - return; - } + if (!desc->name) + return -ENOTSUPP; - mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); + return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); } static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio, int value) { - mtk_gpio_set(chip, gpio, value); + int ret; + + ret = mtk_gpio_set(chip, gpio, value); + if (ret) + return ret; return pinctrl_gpio_direction_output(chip, gpio); } @@ -567,7 +569,7 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw) chip->direction_input = pinctrl_gpio_direction_input; chip->direction_output = mtk_gpio_direction_output; chip->get = mtk_gpio_get; - chip->set = mtk_gpio_set; + chip->set_rv = mtk_gpio_set; chip->to_irq = mtk_gpio_to_irq; chip->set_config = mtk_gpio_set_config; chip->base = -1;