From patchwork Tue May 13 14:23:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 889782 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBA421F1932 for ; Tue, 13 May 2025 14:24:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146246; cv=none; b=NCCEq8qjiEcjwkkF/u7c6+rdgQXbWYHRk+AWvcJ+Ol/nHlt7wbTRRdozTWtD7xcC14zJK3wZjXi6OIq11ihVU6JTTvwBDMEXDRMLPxtRQ+cGXvU0nJ+D9vVVRZY/A3b/LB8CiK92om4JJHQ84sPaYgwCYgTmq6zR4qpLAXt88zg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146246; c=relaxed/simple; bh=TEtk0BAez4A9tbONJb+ibjQlQfyN/iZx4xrxbWn0Z5c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K5LicVoTC8GREOA2YjGMPtNQOaxwKpRvHqvN1aaTf10sFh8LQOBT2ORFDpWLRgXa8GlQMIMvBEncFHykYgdoFck99LemrakDYD1Ceqqh0j0E1p1reuG0J7XatI1ovqqgO+Yj/4UnF4DqK34wb6WYXFEqAlC44xFxoZW7A/ZRFTY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cio8mBlS; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cio8mBlS" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-54fccaf9278so469110e87.0 for ; Tue, 13 May 2025 07:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146243; x=1747751043; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=87PeNSaoARSO0xJcDgxfba3OS94iBFvi7PfmwqCHUmQ=; b=cio8mBlSTllkz4DWRti2TqDfgmP3xcLsZoPnt67S8yS8fVSR6a1n7xh17mudDkS/z8 sMCdCCZR3huskBa1YsHzCDv6sjYdjz/auEH6iOAsfGjurZtZzve/C1VZSbWRp0hSLTQf 0cqy/KMwMgvObEjCEcW/QObTMRnTIvCJsqfI6EYF75IW+gdvwRchskgnqDbhz0uTxeAd PZsGeeB9ieMpYKA353z4zTzCObxk2If7jRKj96mzIJ6RPO/VDxJhEx7+O5bXmtKnJOTO GcLvYj5WqDpi//ya/S22vYYvnEguvxHHVLsH2tfwe8oFBpm6xV7rvJtQ4oub8CuqW2vY L4qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146243; x=1747751043; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=87PeNSaoARSO0xJcDgxfba3OS94iBFvi7PfmwqCHUmQ=; b=vw9PjKwizAyKDT7SpZAFF1tZLyQXkbz5Cz7OsmA3P7AJAitsSLYDJSxi55B1Dj/Cj9 fSpThDPbbHL7UOILPIKzuxLriD5BvXln99DV6H48EcumzWhHEMbWN0p4LwbfgBJMxezi beiU8pVfyIyHVpg2mwyCAzsyJeZtx8frkRYDx/KWFUJN/Bv2xQOPjcUGx6XWqSfNKCBI tlz+CyKPuiZift3onF07cbfZ9d4pVvuypVQ6BW5UHjPkQXNy5J0GeLRdWdINtwv1vjVC 0nQwu33tFadUd1PsyXR0DJRIxrvsJ+RGqNIka2L7GLC4xmg2OMFBiQNcocVIiRd5RFIr AYLQ== X-Gm-Message-State: AOJu0YwthsGoVfmJio7zK4u0wiUn9oohI5XwvVyxw94iGGgv1kOFNph9 O7rwE//uXEkip4EeLu9J2WzoshHH0x/0s6ALGBBc42I7mW6l/wOV2/od4Xgk1Tk= X-Gm-Gg: ASbGncvipYXxbaMkQLlUt0c/QI4j1Zaqu0XfdOvsvgiYZY8s4M29fbH3inKlqphluNr qFvmGGLOES1UUXfH2cl9MqcstFeAayUC1UuA72mDvcoMys0i/izJAocUCr5pWzhVwZmnNPxAl/5 mvEiWG6QW0iuycMaqjjyfgwoCMmHcEEht4ii5p/lULV5pQun5N+Z8zcXi5eHLv86/ni9xtWygk6 qlpbO6i7nOPEQiR4d8qKKaYgTMJwQGm3LcghBVGc8M4tbOCsV4atwRALQjEg0mISSqkBC9EUruY n0681Dkbna4QUR4XuP2/106/6KdmgIdEEktLtbLFTJTyNcahf49lO3bX8E0nbMwR9KNwoQEUtm2 nT3jTmJFYnxPJ3Eh/cTx4PjxnovJgoSU9s5+rydxT X-Google-Smtp-Source: AGHT+IFCj6ItwkApXIPWgFlOj214q7Cn7XzHyhJB7R1HfvQX2QzqVdxWqZtWqd1cP42fxdofZLJTcA== X-Received: by 2002:a05:6512:acc:b0:545:2f92:ff5 with SMTP id 2adb3069b0e04-54fc67cead0mr1820285e87.11.1747146242900; Tue, 13 May 2025 07:24:02 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:02 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 1/9] media: qcom: camss: cleanup media device allocated resource on error path Date: Tue, 13 May 2025 17:23:45 +0300 Message-ID: <20250513142353.2572563-2-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 A call to media_device_init() requires media_device_cleanup() counterpart to complete cleanup and release any allocated resources. This has been done in the driver .remove() right from the beginning, but error paths on .probe() shall also be fixed. Fixes: a1d7c116fcf7 ("media: camms: Add core files") Signed-off-by: Vladimir Zapolskiy Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 06f42875702f..f76773dbd296 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3625,7 +3625,7 @@ static int camss_probe(struct platform_device *pdev) ret = v4l2_device_register(camss->dev, &camss->v4l2_dev); if (ret < 0) { dev_err(dev, "Failed to register V4L2 device: %d\n", ret); - goto err_genpd_cleanup; + goto err_media_device_cleanup; } v4l2_async_nf_init(&camss->notifier, &camss->v4l2_dev); @@ -3680,6 +3680,8 @@ static int camss_probe(struct platform_device *pdev) v4l2_device_unregister(&camss->v4l2_dev); v4l2_async_nf_cleanup(&camss->notifier); pm_runtime_disable(dev); +err_media_device_cleanup: + media_device_cleanup(&camss->media_dev); err_genpd_cleanup: camss_genpd_cleanup(camss); From patchwork Tue May 13 14:23:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 890484 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEAE02BD017 for ; Tue, 13 May 2025 14:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146247; cv=none; b=lL+kbaCHy5KkXEjn4hlFHDdh4rrQOuVFM2AzcCLY3iVAU2ba3LS3Z8TiaDBgjvVQBtmI8a8z4e2IsTyxUZE4XBfIrM/rsco/s4ITnQsno9MSg28EK7pts+s5ARwm3BPOq9yKp9CRUtN50NS76Tf+hFzwbphWiH1Aq9pbOc3Kouk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146247; c=relaxed/simple; bh=1dbZKTa/g+MzsnzTQFCT1jdM3evL1vIx93omGHH0mS4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JMw9GtT1a3Twmc5SH2dE01RgE8+cPnLnoWkLMFmjT40RjvP6LnqKAvpMq2KvkSoj/PLPChN9NvWURY51erBbQLjOH+ANTigHP2LeeTdnaWNu6Zvc/amqLz3uoXDTUg71Ohb92Z8eYvPsJXwJpaEQw4+YxXRr2i7mvv5ZRxCYqeE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Vs5/NShG; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vs5/NShG" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-54acb0a5444so711606e87.1 for ; Tue, 13 May 2025 07:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146244; x=1747751044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FLyQNl/IfprA8mrvUU0qzCD9YVX1jlfRaaDTODi+QbM=; b=Vs5/NShGV04HpSXCK/5zy/JjMa9blTs5UiwgGyiEK1kvBWF/aTzhATN5kAGKAy5H7V bkGZVDaoz0zKMABDVh43J4iQiKbee1mKP/+XNbsv2dtmgCV4xLSdiTo+uLQi6J1Cq8Kt 88xNudE8lFtgC6163eAFf/Diblf/r0zyz6Ll1YYaLwk5mGfBjzxiLizcPZOy60zyDLgL r6/+AsJ0gHTxd47sqHEy8ReEEuSXEbTC6C6tK5ymH0o0Xe68Q1gnhiv57ZcJVzzMClYQ R4cJlwbtthIJj8qUUdjdsWwTHPi1XN5Md93CARSX3bl1x124R8RZHZIbm6wHLylWUkoE Huqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146244; x=1747751044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FLyQNl/IfprA8mrvUU0qzCD9YVX1jlfRaaDTODi+QbM=; b=bASycW5GmoUAbmrr/16SWbUBrg6Adnf2j4EijrGQMoM3+SN4i4s8LTFZU3SPF6HAE3 aTLQTbDx6IlHJATs/DKeoF0onxpMQuX7sTHopi/oy1+J4A5TakT0D/gMNWhIUiAuggL5 ZolpVk1I6I2CLcnWsxjpTdzvnrwlU0BMo2Lo+gQ1bCG9GlyAuAUjOThK+iuKhUnn+hMc nd/MRs2XvlR3thz8ZoFo2wgkrul9QRQG+639d3zcL/SldwLYOGvGoVL+U3c0kj3Dml9D j4pK9HoKXMmXcW6zKb3mj0SF+6+XaMCDjB+dWLfqZSiBjz3q4zrwzZeLBoLRhjasMLxD oOXQ== X-Gm-Message-State: AOJu0YyvfrBd+uiYUddT8nFq3gbDLzQ0d2w7ZTTiXwFsb7lSXom/zgAT jWDSckWKYVMJol4tmkNAQc4+2sdMv6MFeFZjKk4/riuXU7s+615HsuSyjkTSniI= X-Gm-Gg: ASbGncsfBOG3qhFO6S7SMq8VJVHnSe4smBVy+ezU368qdLnbEAmFWiDvQV0k2vYoCJ8 LxswfmIoMrpRdFcWjuT5DEyyd+LTpmBc2T3X9RLCHebL7nxboQbCK5C8L0Ze2DNjg0tC7qTfidz a+ateh9rxnnZ45lmBqvzNjFJnNeW/OeQchpL04oGIbVfkkFMCfSzUf04imzCu5W/qXJloL0UbdI hBPW/4ulF33KW/t+fCWG51v8dQyNKG1CGVphgH7y07Ay1NgbW0sfRzM5QCPlArjnZQCyJjwcFlF qgjq+AWTIy7myA/tWvzlSfYNcqdr/JZby0ZpVYXqBgfBXb7Jpg1RSb1mxJP2TUCFOQDsrdAmKMV 8l1ucqSLxe2w/SiqPx6LMPFvsMUN1SWg6h/VZheqi X-Google-Smtp-Source: AGHT+IHtk921lEO/dQfipJFfEuJ1GeNiLuhJwnGHgJR1JF/11YYx8N67y8WnOW6vPy9eWziLe0e9eQ== X-Received: by 2002:a05:6512:3da6:b0:54f:c10b:7286 with SMTP id 2adb3069b0e04-54fc67ad7f5mr2070039e87.3.1747146243820; Tue, 13 May 2025 07:24:03 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:03 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 2/9] media: qcom: camss: remove duplicated csiphy_formats_sc7280 data Date: Tue, 13 May 2025 17:23:46 +0300 Message-ID: <20250513142353.2572563-3-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 It's sufficient to have just one previously set csiphy_formats_sdm845 data. Signed-off-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss-csiphy.c | 5 ----- drivers/media/platform/qcom/camss/camss-csiphy.h | 1 - drivers/media/platform/qcom/camss/camss.c | 10 +++++----- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c index c622efcc92ff..2de97f58f9ae 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy.c +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c @@ -103,11 +103,6 @@ const struct csiphy_formats csiphy_formats_8x96 = { .formats = formats_8x96 }; -const struct csiphy_formats csiphy_formats_sc7280 = { - .nformats = ARRAY_SIZE(formats_sdm845), - .formats = formats_sdm845 -}; - const struct csiphy_formats csiphy_formats_sdm845 = { .nformats = ARRAY_SIZE(formats_sdm845), .formats = formats_sdm845 diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.h b/drivers/media/platform/qcom/camss/camss-csiphy.h index ab91273303b9..895f80003c44 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy.h +++ b/drivers/media/platform/qcom/camss/camss-csiphy.h @@ -126,7 +126,6 @@ void msm_csiphy_unregister_entity(struct csiphy_device *csiphy); extern const struct csiphy_formats csiphy_formats_8x16; extern const struct csiphy_formats csiphy_formats_8x96; -extern const struct csiphy_formats csiphy_formats_sc7280; extern const struct csiphy_formats csiphy_formats_sdm845; extern const struct csiphy_hw_ops csiphy_ops_2ph_1_0; diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index f76773dbd296..8c844ebf9cb6 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -1481,7 +1481,7 @@ static const struct camss_subdev_resources csiphy_res_7280[] = { .csiphy = { .id = 0, .hw_ops = &csiphy_ops_3ph_1_0, - .formats = &csiphy_formats_sc7280 + .formats = &csiphy_formats_sdm845, } }, /* CSIPHY1 */ @@ -1496,7 +1496,7 @@ static const struct camss_subdev_resources csiphy_res_7280[] = { .csiphy = { .id = 1, .hw_ops = &csiphy_ops_3ph_1_0, - .formats = &csiphy_formats_sc7280 + .formats = &csiphy_formats_sdm845, } }, /* CSIPHY2 */ @@ -1511,7 +1511,7 @@ static const struct camss_subdev_resources csiphy_res_7280[] = { .csiphy = { .id = 2, .hw_ops = &csiphy_ops_3ph_1_0, - .formats = &csiphy_formats_sc7280 + .formats = &csiphy_formats_sdm845, } }, /* CSIPHY3 */ @@ -1526,7 +1526,7 @@ static const struct camss_subdev_resources csiphy_res_7280[] = { .csiphy = { .id = 3, .hw_ops = &csiphy_ops_3ph_1_0, - .formats = &csiphy_formats_sc7280 + .formats = &csiphy_formats_sdm845, } }, /* CSIPHY4 */ @@ -1541,7 +1541,7 @@ static const struct camss_subdev_resources csiphy_res_7280[] = { .csiphy = { .id = 4, .hw_ops = &csiphy_ops_3ph_1_0, - .formats = &csiphy_formats_sc7280 + .formats = &csiphy_formats_sdm845, } }, }; From patchwork Tue May 13 14:23:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 889781 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B61192BDC2E for ; Tue, 13 May 2025 14:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146248; cv=none; b=Vkr8GoKhrRFOt+RzHRw9HAB12yO2I2SYqsSw/AkMhBHKHuBJEj7m2bbCbhjkDthoDzr+zUzAAxiXXueekpLNVO1G2ynh9hKeANtzCkJbglQVJqIR/XjTweDnG288JOZPk+CZ8gjPyapn+kcuKoiaX+B3mS60qoxRgMdyCrzB1cU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146248; c=relaxed/simple; bh=wd5OK2vpaUbdVbTuvyN3zcrNtkQAd/14OzJXAvp/rRQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p8mf3Y0HJRqxQhBEugLKL6NUj1mL8//ewNIvQuXu2L1M79u//9JxIU5hz9LGyjuVS6ZOz1pT1OroVHd7SD6dBIhb47ii/ISow0GYwSWRpn/UMiKXZWcKAql63k48BN3Mvu2AeqBfycjTzXTYrng86050fQhxsZhK/4GphkOKWdg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YRAR3QL1; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YRAR3QL1" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-54fccaf9278so469116e87.0 for ; Tue, 13 May 2025 07:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146245; x=1747751045; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JEIMfORhvN5jRYVM9DDW32f9X7YFOQS1p/b7fC45Eds=; b=YRAR3QL1Re1fx1MzODCXIAK0USJlEWwf0LjciRTqe3ijwLebpaRreVtKVhWfrUsab2 Ta8wMX2DSjXF2zUGPLxCdqaM4GkpTZTTtUSMs4wdxnsH7KLE+2G7WRbIhVVO7vEG2h+M 4hDwpz/WE8FlCt+m6fk/DUSUKd/eOssHC7TXXqAWCBRF6Nd8zaz5be64jtsXtrEfiKpg bsW9kznacQMdNiavaovZLwWInaS9hXZP9B0N/i6j+Aiz8fefUodDf8gAPMouqemy5BgF mkKyCQRF1i/j3Gxjfa6xxjQwC3WYWtaudrd0J9bnz3DiwX7GlCaeo5G854w00VfJtffU 4WlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146245; x=1747751045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JEIMfORhvN5jRYVM9DDW32f9X7YFOQS1p/b7fC45Eds=; b=Ciyq+Qz+EpUihoVKmwbATNo3TDXwhfB8opJGWN//WXuoZJVNQh6Z6L+6B7E7wucmzk zxcVzuk/wuCAgOme2sgKyHvF8hLbK4cO7vyskC09G8nTYDqJklF+oj69JSRXDWfmvQTc R/QT53Up+DWPP11eg8bn2Qv+42NiDJXA+7tGIG1HtyGUUFGsxTrelhr///LwwYY/3cG4 spKexkRcOKKQvHFi+0xLWGjkUeHnb+jvK1162I/GYsNB4qZwmM1+4gImop4UtybOo++9 N0WWrqtfzoJLnYIzvIUoskC6sNWSu/GrJ3P0ZRYcXT49JVAI63gfNjKs2KBvP2mm6c6n o7zA== X-Gm-Message-State: AOJu0YzuUYmEaI+8cTKPwQmUSvdKLR0yDMaOYDs/xBnN/fBrgeMA4FKf Yy3tZXun2FYE0K/9iz5pjg7rbG9OHS+Bm0Vxnt1NgAYzaFn0Yu0yWAMv3jTHOBkooxgI1YSD5y4 H X-Gm-Gg: ASbGncuHH6K00A0z2sJPyArIMmTH19q3m/dnmQe6gjW8QobpOnVC8I29YVsujYg1UDA y0Q8SJSGS63PsLWC/72cLF9giUNxOkcGmLshLiraYK9h9v8jHdOKCvTL4aN211M4bAm0e5oC0UE LBnpYsF2VcDae8ePzY1u95167ykBFI8Rcwn1deYqjiZF5J8LAwph9pSJSOQNX0/wIyNO/PqWMmr yU2cRvGRSqhCPExjgSJrjuzslcVI/0wuRWuPs11L8w34qWgs3t8x+IpcZjsmZcGG5G11I1+Z5Zj 6P3ZFpGfnnrNvWHUkUjzAZsvXgZruL68vht1WnhU/YhGvojViZ3zR0oPDKLwOxnxbCVke+BX1YD AFKvFH5uA29jgFII1eZZ7YWzGXmUrEZnpCiRlQoqn X-Google-Smtp-Source: AGHT+IG4ecE3HUplA9i8a8L1PN8LSDGDhOHpOg/H8jWcK3aNKhgRCeYMXpbwZbnyw+FZV+J05fzC9A== X-Received: by 2002:a05:6512:159d:b0:549:8faf:e20b with SMTP id 2adb3069b0e04-54fc67c3400mr2319152e87.9.1747146244761; Tue, 13 May 2025 07:24:04 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:04 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 3/9] media: qcom: camss: remove .link_entities Date: Tue, 13 May 2025 17:23:47 +0300 Message-ID: <20250513142353.2572563-4-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 There is no potential for a custom .link_entities callback, remove it by replacing with a common camss_link_entities(). Signed-off-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 14 +------------- drivers/media/platform/qcom/camss/camss.h | 1 - 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 8c844ebf9cb6..2977aeaf27e1 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3143,7 +3143,6 @@ static int camss_init_subdevices(struct camss *camss) } /* - * camss_link_entities - Register subdev nodes and create links * camss_link_err - print error in case link creation fails * @src_name: name for source of the link * @sink_name: name for sink of the link @@ -3642,7 +3641,7 @@ static int camss_probe(struct platform_device *pdev) if (ret < 0) goto err_v4l2_device_unregister; - ret = camss->res->link_entities(camss); + ret = camss_link_entities(camss); if (ret < 0) goto err_register_subdevs; @@ -3726,7 +3725,6 @@ static const struct camss_resources msm8916_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_8x16), .csid_num = ARRAY_SIZE(csid_res_8x16), .vfe_num = ARRAY_SIZE(vfe_res_8x16), - .link_entities = camss_link_entities }; static const struct camss_resources msm8953_resources = { @@ -3740,7 +3738,6 @@ static const struct camss_resources msm8953_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_8x96), .csid_num = ARRAY_SIZE(csid_res_8x53), .vfe_num = ARRAY_SIZE(vfe_res_8x53), - .link_entities = camss_link_entities }; static const struct camss_resources msm8996_resources = { @@ -3752,7 +3749,6 @@ static const struct camss_resources msm8996_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_8x96), .csid_num = ARRAY_SIZE(csid_res_8x96), .vfe_num = ARRAY_SIZE(vfe_res_8x96), - .link_entities = camss_link_entities }; static const struct camss_resources sdm660_resources = { @@ -3764,7 +3760,6 @@ static const struct camss_resources sdm660_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_660), .csid_num = ARRAY_SIZE(csid_res_660), .vfe_num = ARRAY_SIZE(vfe_res_660), - .link_entities = camss_link_entities }; static const struct camss_resources sdm670_resources = { @@ -3775,7 +3770,6 @@ static const struct camss_resources sdm670_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_670), .csid_num = ARRAY_SIZE(csid_res_670), .vfe_num = ARRAY_SIZE(vfe_res_670), - .link_entities = camss_link_entities }; static const struct camss_resources sdm845_resources = { @@ -3787,7 +3781,6 @@ static const struct camss_resources sdm845_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_845), .csid_num = ARRAY_SIZE(csid_res_845), .vfe_num = ARRAY_SIZE(vfe_res_845), - .link_entities = camss_link_entities }; static const struct camss_resources sm8250_resources = { @@ -3801,7 +3794,6 @@ static const struct camss_resources sm8250_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_8250), .csid_num = ARRAY_SIZE(csid_res_8250), .vfe_num = ARRAY_SIZE(vfe_res_8250), - .link_entities = camss_link_entities }; static const struct camss_resources sc8280xp_resources = { @@ -3816,7 +3808,6 @@ static const struct camss_resources sc8280xp_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_sc8280xp), .csid_num = ARRAY_SIZE(csid_res_sc8280xp), .vfe_num = ARRAY_SIZE(vfe_res_sc8280xp), - .link_entities = camss_link_entities }; static const struct camss_resources sc7280_resources = { @@ -3830,7 +3821,6 @@ static const struct camss_resources sc7280_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_7280), .csid_num = ARRAY_SIZE(csid_res_7280), .vfe_num = ARRAY_SIZE(vfe_res_7280), - .link_entities = camss_link_entities }; static const struct camss_resources sm8550_resources = { @@ -3845,7 +3835,6 @@ static const struct camss_resources sm8550_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_8550), .csid_num = ARRAY_SIZE(csid_res_8550), .vfe_num = ARRAY_SIZE(vfe_res_8550), - .link_entities = camss_link_entities }; static const struct camss_resources x1e80100_resources = { @@ -3860,7 +3849,6 @@ static const struct camss_resources x1e80100_resources = { .csiphy_num = ARRAY_SIZE(csiphy_res_x1e80100), .csid_num = ARRAY_SIZE(csid_res_x1e80100), .vfe_num = ARRAY_SIZE(vfe_res_x1e80100), - .link_entities = camss_link_entities }; static const struct of_device_id camss_dt_match[] = { diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h index 63c0afee154a..1d0f83e4a2c9 100644 --- a/drivers/media/platform/qcom/camss/camss.h +++ b/drivers/media/platform/qcom/camss/camss.h @@ -107,7 +107,6 @@ struct camss_resources { const unsigned int csiphy_num; const unsigned int csid_num; const unsigned int vfe_num; - int (*link_entities)(struct camss *camss); }; struct camss { From patchwork Tue May 13 14:23:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 890483 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE5452BDC2E for ; Tue, 13 May 2025 14:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146251; cv=none; b=rNDvz7wgpUcmO9omPCFMTM5PeJqS6oSJQ/5I6ZBgj08w2te6cHiHROiJSFjerYG4hKG7m2pRNkodINqBWK88eokDwqr4wMuF52chSKay7uHNuS6CSxbYyTiKIIUHhyZJvOc8y68onjGBkBjGKfKCYXUbdEYRdrUrJPbuQHRICUs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146251; c=relaxed/simple; bh=V+yA0wwcS/bVf5oT8EHOGAo5JiL/HicUzO3XXCHGScE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D1gDaJfNB8nYRwqsbdSBDw/iAiRuoA/HeiVEWE/Cn1rc7SHYqS6QgiVtOsK2uPrW8KBZJ71EcgR/48v5hGGWfcxhKSQsPCQr1147Q2WiPqPvm9hp6xCwzflAno+KCcwmhSyGOCffgV9IwhRa5y8Erb9RNFZTaxLaendMvOEt6no= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Vr2C19Q8; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vr2C19Q8" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-327e66237e9so744251fa.2 for ; Tue, 13 May 2025 07:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146248; x=1747751048; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P+mIWe4f7/ePA4eiTd6mBWZ/3eo5UNvBmTQDWz6UZOo=; b=Vr2C19Q8UQrlRGw30BYh5g29Z+4kEMYE9XewAWBKBjrstcr3s+O+J+SReRrVgIpjKy ahCFUFnFRB+e/cM+1U5K39V48VRmKf+gDHZPAIbEdS9WJAnEQa+8UHudDVYP2z6EvHjU R476q71FoTuhEFHJ90kAUeBmwsT2I8L2Zj8Hdt+SthICmAPdX27e1ELRGLhS3Tyi46Y8 8ly41YHABoaF86ZyqSxYhTjdQf2ijut3M858ZOv9C9iNZ6s+dEWG7wKMsRuzzu6jkC3+ 30BZF3AwqdyZevXojPG1x1vOk4vzgHxXmIHStnl/NS7UiwX+jwKL6+efOxrHOV/XN1b+ Ib+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146248; x=1747751048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P+mIWe4f7/ePA4eiTd6mBWZ/3eo5UNvBmTQDWz6UZOo=; b=gMhnLUWwT8I4zrMGf1FQk9BeyyuSmN0JmeYecmt6Y7q1HgfANJglTj6fhLgUqX/gFr TDIyMe+zdcTNrqLmzIoOKaLfqYp6K3EqviLNK0h3bxK05HrtqnuVcxpAa62a2XiHs2Sh akgp5WJDPk3jyPkTldhBStuU0BxkUa+SOaGuKnk1FFh55NhlneMLOaWvEfQnhv1sW13U aIJDG18rH+PrXedGHKWZ9Z56Jg4ukV5bG2Fd9ZrHAzOXN1gCYf3F2Ye185I0LWzv0aqq XXKAfJJMD3cAf/PbpFONfIj3j7WB24T1byGjoL1xQKyfeUyeK9WhR1Er3QTwGF055c7R wL8g== X-Gm-Message-State: AOJu0Yy1qFgvrSjIZ5NG86BLhmzRRzoXPwoi8IcYBLa5n1lrfM5Bb8Gh 4ZWYIKe9+IbPAIa/IEpQ5x7zYUZGOrsAVxl5hMv2okahxFsFGm1QsG5EtleUP5I= X-Gm-Gg: ASbGncuvOXCz6nrr3VckECmJiil2syjYmS11FUX56w1rUH+OKFZZH7qa3B4aqGmgajA kqAFiRoLPQkSCEoeaPOcWeJ3scONb2TKXUv6cLAUlqqcg05JZbODGtnjXOGmfXA1W+87mPXs02m qdbq0Y8o+l6IaCVOz7C+3aLZB1XBQQ4lyDGFY7pjh/KP3Zyhwp5kEYMIOaZ3XPXaTGccXltSIXK DgWD/rXMNQvF+KxOxEow8PFlOAmVgndCgAkjMeyNlO3RteU7X0YbHQ1MUPrA/fGeGR2sPIujLZs yu/Jmvl29bJFh9K1r5KDU/ez4RoDEktj3DktX7/4QrCLtUZa1HFPTqWS/amYWfv/QrPtDziPFAf Fmbn8YsJ4UZ99AExOFWyWxcyAeyf7eaaJ+MP5+gk5 X-Google-Smtp-Source: AGHT+IETgSn1urVnMun+WYtNS1QXqt+HyQMwe0j+DtEuUcdRDUPi7bIqRr9TigWkClOwQ9fQ4/Hijg== X-Received: by 2002:a05:6512:4019:b0:54f:c2ab:c6be with SMTP id 2adb3069b0e04-54fc67bee89mr2089901e87.7.1747146247658; Tue, 13 May 2025 07:24:07 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:07 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 4/9] media: qcom: camss: register camss media device before subdevices Date: Tue, 13 May 2025 17:23:48 +0300 Message-ID: <20250513142353.2572563-5-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 A media device can and at least for sake of simplicity should be registered before V4L2 devices including the ones added on async completion. The change removes the second and out of camss_probe() media device registration path, and it allows to get a working ISP media device independently from connected or not sensor devices. Signed-off-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 25 ++++++++++------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 2977aeaf27e1..976b70cc6d6a 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3417,11 +3417,7 @@ static int camss_subdev_notifier_complete(struct v4l2_async_notifier *async) } } - ret = v4l2_device_register_subdev_nodes(&camss->v4l2_dev); - if (ret < 0) - return ret; - - return media_device_register(&camss->media_dev); + return v4l2_device_register_subdev_nodes(&camss->v4l2_dev); } static const struct v4l2_async_notifier_operations camss_subdev_notifier_ops = { @@ -3645,6 +3641,12 @@ static int camss_probe(struct platform_device *pdev) if (ret < 0) goto err_register_subdevs; + ret = media_device_register(&camss->media_dev); + if (ret < 0) { + dev_err(dev, "Failed to register media device: %d\n", ret); + goto err_register_subdevs; + } + if (num_subdevs) { camss->notifier.ops = &camss_subdev_notifier_ops; @@ -3653,26 +3655,21 @@ static int camss_probe(struct platform_device *pdev) dev_err(dev, "Failed to register async subdev nodes: %d\n", ret); - goto err_register_subdevs; + goto err_media_device_unregister; } } else { ret = v4l2_device_register_subdev_nodes(&camss->v4l2_dev); if (ret < 0) { dev_err(dev, "Failed to register subdev nodes: %d\n", ret); - goto err_register_subdevs; - } - - ret = media_device_register(&camss->media_dev); - if (ret < 0) { - dev_err(dev, "Failed to register media device: %d\n", - ret); - goto err_register_subdevs; + goto err_media_device_unregister; } } return 0; +err_media_device_unregister: + media_device_unregister(&camss->media_dev); err_register_subdevs: camss_unregister_entities(camss); err_v4l2_device_unregister: From patchwork Tue May 13 14:23:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 889780 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A28CF2BCF65 for ; Tue, 13 May 2025 14:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146252; cv=none; b=a5sVidzgJRXeobuYgA0ZijYnzJNmh6ERprBBVYnQqiTAS0yekBDivc64r2sKxAG0ABD/tsHu6LOndLHItJmIOZFe3C8on55IfJ3a3ORUIEOtWYgiamVF+N0hZoH2cs6Ct1tgGZ8I+Lp2zNRX4cbg5IYysUwBckk6d3HaxYR0kd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146252; c=relaxed/simple; bh=erNjneX1ykXPs40HPM7FAn+r4hIz/TDnlNai6OUxWf0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LaEU4CaJ4SJsYn4+EpEy82XVFaYNil2TZy2/1qxJnK1sybCndBIfWal2kJfRS/Z9u6Io+CX8HbCjuRISik0Wrw2hDI6ll1xIzt2cU8xLWtBc3xOKbvTevB4/8WPduIsWB/MuvOFBHoK922xmlM7Ave+Lol0kD9ddcK+8hQ3BSL0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dZRDmxVX; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dZRDmxVX" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-54fc7dcf64fso566546e87.3 for ; Tue, 13 May 2025 07:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146249; x=1747751049; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R1GPv/f99tPbM0UPQ85Mqw1y4SMVAklj5dFNW1gK2Gs=; b=dZRDmxVXe7IgZ59LhcNgMZV0kqJQKStUV9bSymNRtug+eBHpji3Jq1qTlJJKyXPt31 evd4ieac6ybyOq5lNoCyF90hvuwUUe7XvUE6crR5Xk+ywW1x2tIWzT42YomMOeAHCsnf se4zO19xWu717NQmHkcrHMcXXP33xkFYjZf6N2Xt0QodcpGIzdKI2NGN5L9pnhsnTGp4 QloCxIultmNLvSa2lrDdIfSJzSW+PbpTQ5awZy2T5yGhhiMuPNbUJdHgroDie5NdMj/0 4qllg9aGxMfgbI/pCPFSP5wEbqZWRm38SEMT1Shmbp7H5vo72Ci7XrzPnEq9ZyWBfHel Ptlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146249; x=1747751049; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R1GPv/f99tPbM0UPQ85Mqw1y4SMVAklj5dFNW1gK2Gs=; b=BZgRznu0/5DOplFr0AE8+SOy8Nqoax4dqVj/NPSv0XavCxFXEJPfL7As8X/vIw9HnF yZRyROmGrhOArsXvAfq2LXp8/OqASydXsoyDqCRRsSXWhHNz5VxgU0KPkGefW9CpEzcP n3/MOqa04qOd2yZ7S9qGA8cPf4Act+ARoq15v2v6dtS+Mvc8npbaOwjpOAAAX+Ob9uLO 3KaoIvn9oXpzsF8yhvdHjNgn0qxt0iSUW07gbquikA299ozLreUZgXE/E3egWCVdBNBR 4EYhvA5oW+PFFEjw+loacOetem3QngZ9wsf84cMmkL8kStwFk7WBM09Js2u33memaJK/ YEfg== X-Gm-Message-State: AOJu0Yz0pmb1hVOjhTgNQtVPFCZmo8tq0zIr04yOrkf2EHEIYRI4oXBe hEl+ycigAox1EVfefFEdAAo53Z6Wb5GIpAXWd0di5vyOmOUSavl8pClaJI3R6Eo= X-Gm-Gg: ASbGncsbhEpX3B4GirrvkgPDLj5Itrhs2v218PyxRbVZtJugS/zyagZaPMduAk1R5v+ c+TPbJngWA5UPrNozpW8ol27KltIGz4fmw1uDBNgZjgJ1HyRCZHYV5qGRlWRcqNRXW68MNKCmuw t7Iu/jBnI0qRbhj4+pyuTGXhogHbM35bSjyq04P23MZfuIGSmIF/1U+Bwv/HphCVhXkF3Kah5uc lJG6+fxW2hdAah2mPB/exahigheSGirUP/384F49qBrRktF64vcea9uSKlXl9ugnJRP0lgrbmGu n8JJ5GnOvn5tkK8bPn/fLCDwl+PoB9qwx+scQ8XgByu3nPo7fbjcjlsEBTFQJcuEnmhhMtOac+H TXon/0OwXXyzJnEWQNo0F3RHpSrGZ4yQNtzkNS2Lw X-Google-Smtp-Source: AGHT+IGO1rTBMd+2KCdhIBdhmkYdra8c308MKiP+DS9B6TmEo+B1Fa2ub8Is/wdTA9cZdM0jG2ILhg== X-Received: by 2002:a05:6512:a8d:b0:545:760:44ca with SMTP id 2adb3069b0e04-54fc67cfea0mr1793598e87.10.1747146248650; Tue, 13 May 2025 07:24:08 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:08 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 5/9] media: qcom: camss: unconditionally set async notifier of subdevices Date: Tue, 13 May 2025 17:23:49 +0300 Message-ID: <20250513142353.2572563-6-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 For sake of simplicity it makes sense to register async notifier for all type of subdevices, both CAMSS components and sensors. The case of sensors not connected to CAMSS is extraordinary and degenerate, it does not deserve any specific optimization. Signed-off-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 30 ++++++----------------- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 976b70cc6d6a..4e91e4b6ef52 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3556,7 +3556,6 @@ static int camss_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct camss *camss; - int num_subdevs; int ret; camss = devm_kzalloc(dev, sizeof(*camss), GFP_KERNEL); @@ -3627,11 +3626,9 @@ static int camss_probe(struct platform_device *pdev) pm_runtime_enable(dev); - num_subdevs = camss_of_parse_ports(camss); - if (num_subdevs < 0) { - ret = num_subdevs; + ret = camss_of_parse_ports(camss); + if (ret < 0) goto err_v4l2_device_unregister; - } ret = camss_register_entities(camss); if (ret < 0) @@ -3647,23 +3644,12 @@ static int camss_probe(struct platform_device *pdev) goto err_register_subdevs; } - if (num_subdevs) { - camss->notifier.ops = &camss_subdev_notifier_ops; - - ret = v4l2_async_nf_register(&camss->notifier); - if (ret) { - dev_err(dev, - "Failed to register async subdev nodes: %d\n", - ret); - goto err_media_device_unregister; - } - } else { - ret = v4l2_device_register_subdev_nodes(&camss->v4l2_dev); - if (ret < 0) { - dev_err(dev, "Failed to register subdev nodes: %d\n", - ret); - goto err_media_device_unregister; - } + camss->notifier.ops = &camss_subdev_notifier_ops; + ret = v4l2_async_nf_register(&camss->notifier); + if (ret) { + dev_err(dev, + "Failed to register async subdev nodes: %d\n", ret); + goto err_media_device_unregister; } return 0; From patchwork Tue May 13 14:23:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 890482 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D6FC2BD018 for ; Tue, 13 May 2025 14:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146253; cv=none; b=glyc1rcmkM8Vtl3IrVgmAwiKGP0kZ0mQnhPdBE/fiB05H+WTx66fkGPOtL7FS/DuuXoZ4m360bIwXxkNTL/rdLz4SzDMvlSTn2dU1vE4Wus89ttGuJl17X7R5bW7gM7dzPSv/A2ylpNgd6IYivJOSZk4RZ1L/CGPGYHsVNrJavA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146253; c=relaxed/simple; bh=n5GbW9547xms/973wpMFEJ+iyozutW75ILZ3e5FuJag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AWF/nHCzojXA7rDQ+T/v8cpCnWePWvBU42BZq7ytjynPW6ZgZ4xtZlx4v0Tot63mmb7c5T5vF3mFatx/K7/3WkCO0pwxWT6xJ0aNtU7+K8CupqnO13kFXEvIf0vYrJEM3Z71h0WPtY93s0UF1SUr6nQX++WXfBrOOTliB85u+VI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n5fJgXZG; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n5fJgXZG" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-54fcffcbe14so446612e87.1 for ; Tue, 13 May 2025 07:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146250; x=1747751050; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Je1pnbYGeDSwO8l0nWcUWFR3rRs+nLJrQdN1nv9aVoQ=; b=n5fJgXZGNwfmbKs+Ga9tFehNOy7onWR9RNIgdZbdchKERdnzJHaTgL8+LrxADT02gy bByHIe/ohE8pssKrZV0ynxNvNQWhVWRXaxhSnJEqauVb82wkZLMgpefMiyfIAGA2INAS AYQXZmcpTqyvbQAoPjxps4k1AJgp4HKpOhJfB3ORWQDYXRwbQ/UVU1Wd0I5YNy4PhDUs 5ih+0Mx/2AvQg+i1242OYSs2QDDd7ky/UJOKT+TTKJB7sDrkZGYRoFjm87BiI0iGGTLF wc7BaXBrv7LrsNqUrR7fedmyJCPOJX4izU6rE5VrgO1mN96m1ad9DbUGtlvHvbi8L8cV sTjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146250; x=1747751050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Je1pnbYGeDSwO8l0nWcUWFR3rRs+nLJrQdN1nv9aVoQ=; b=I6D+NtsEPRWHomWN/cWXwSmSKcoJ5jHPFcvSsaauHIUAEUng5hOoP07ctUcnBwV0Z+ LifS1Q02ge+bMBoymvAZ05ghDXPCKY1GhSBG4rqFEyVvo3IFQXIwdWodp15XItN+FrjJ tU3eXytjbKweTsd1969IbpLvy4rJkSWPuxDeImD8Jl/oenY2syAoROLJ1LyzFxMhjKx9 KAckiz1Rq7f+CvN6StWmvTP5FzGcQoDUUfoXZ9DEI+EGKM0qOLUsAIxxqIK2Cqo6q+xy MafLp33Y6hLdnZuCJ60Ouxz536/JIwoOBWDNsmsAyhQO+/Q1yiTMaCyVAnhX/p3aaSG/ 78yQ== X-Gm-Message-State: AOJu0Yzo+Ea0vMl9gwO37HxocawAiBhOTDjmbZ8+l42PkXaJzjK+n/JT dWZOhF1BN4AkDsefH6uWFd88dxfqX6b0Z3fm6biHqGLVLr4ahLumFUkmzNVDFx8= X-Gm-Gg: ASbGncvf29gJ4tJiCn3X3d8Pzh49UyCVkNQaRDNOchCC7pEhZnWTut9lDTYuTyjkcGH 7tnJ+mDUL1ZiR4h+sGRzoqES4RhcBg5nlmvlve5o24Cg8Tt6nhvS9qzAESk2ORajzyR4DADMdQk H3KOg0s+uYXtyrldkCehnSFOmHUnSfg7Gqoe52KW/1f+IhjqfAQMgmH5B2nNgjnKuwvFMOsCuD1 145BmDMrmKVeIQ7mrufT3WzORUwEe1lRHxdB0dNlWY4xLtPQ/HIRU+nUfqk29Ko+TuU2qArTDg3 Bhp/hMkXH3MKRvz/yym+xvDgjEOr6e9JSbgRRSclv8jVbBCt/6ZZ8YZTYm+90Uk+aLs3EvUwjdC zVqcDebwfutxgCbMdirm/o/8NaVG6aFkTEE0X5qecVBJ2iOG6BpA= X-Google-Smtp-Source: AGHT+IHTeW9zs26KYKOPDOT1amI557o7iaow9p3jy/WNJzSFNHOCm9k+ajDzGAdoM1UDpUNvywcrSQ== X-Received: by 2002:a05:6512:10c5:b0:54f:c088:fb11 with SMTP id 2adb3069b0e04-54fc67d3101mr2037761e87.13.1747146249850; Tue, 13 May 2025 07:24:09 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:09 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 6/9] media: qcom: camss: simplify camss_subdev_notifier_complete() function Date: Tue, 13 May 2025 17:23:50 +0300 Message-ID: <20250513142353.2572563-7-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 For sake of code simplicity and readability reduce the function code by one level of indentation, the change is non-functional. Signed-off-by: Vladimir Zapolskiy Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss.c | 50 +++++++++++------------ 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 4e91e4b6ef52..39c5472f4552 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3385,35 +3385,35 @@ static int camss_subdev_notifier_complete(struct v4l2_async_notifier *async) struct camss *camss = container_of(async, struct camss, notifier); struct v4l2_device *v4l2_dev = &camss->v4l2_dev; struct v4l2_subdev *sd; - int ret; list_for_each_entry(sd, &v4l2_dev->subdevs, list) { - if (sd->host_priv) { - struct media_entity *sensor = &sd->entity; - struct csiphy_device *csiphy = - (struct csiphy_device *) sd->host_priv; - struct media_entity *input = &csiphy->subdev.entity; - unsigned int i; - - for (i = 0; i < sensor->num_pads; i++) { - if (sensor->pads[i].flags & MEDIA_PAD_FL_SOURCE) - break; - } - if (i == sensor->num_pads) { - dev_err(camss->dev, - "No source pad in external entity\n"); - return -EINVAL; - } + struct csiphy_device *csiphy = sd->host_priv; + struct media_entity *input, *sensor; + unsigned int i; + int ret; + + if (!csiphy) + continue; + + input = &csiphy->subdev.entity; + sensor = &sd->entity; + + for (i = 0; i < sensor->num_pads; i++) { + if (sensor->pads[i].flags & MEDIA_PAD_FL_SOURCE) + break; + } + if (i == sensor->num_pads) { + dev_err(camss->dev, + "No source pad in external entity\n"); + return -EINVAL; + } - ret = media_create_pad_link(sensor, i, - input, MSM_CSIPHY_PAD_SINK, + ret = media_create_pad_link(sensor, i, input, + MSM_CSIPHY_PAD_SINK, MEDIA_LNK_FL_IMMUTABLE | MEDIA_LNK_FL_ENABLED); - if (ret < 0) { - camss_link_err(camss, sensor->name, - input->name, - ret); - return ret; - } + if (ret < 0) { + camss_link_err(camss, sensor->name, input->name, ret); + return ret; } } From patchwork Tue May 13 14:23:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 889779 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5F4D2BE10B for ; Tue, 13 May 2025 14:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146254; cv=none; b=rOlEMwqOV4pd/KyBFV+IIv9it3pjAPqdzwSwLmIRLUmOhHb2c1sHkrEeUltUrySf/ZAQBLO/L72A+IVtULyAToxYC6EkdriNpYVUFqzLkS9ZQBuYMjg75qNFgQr88NxEaibqBZHExxyB2Zt/Q4IkuU8ciFqyJb1fcFTUDQSG0x4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146254; c=relaxed/simple; bh=Dg/kRgRiQN2QvOJWPN/51Hfk4qa0Ifb2gj/F+hVKG5Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ffoMpO8o+jjowTfS1G5lM529RfTlV5czqQmJN8UBMR+FlSBXH4RmHdVSL+btNoY0wEYb/evhGzAYYBljhc9bTgsBoACm1LjIrUiYz+sGn00VFC0UGmb4yq7bb/MLy/QckbU0KH0ui77gyW0TOqyLDrMyK7jWuk7V9r6IoHdX2Ik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WGQEdub4; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WGQEdub4" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-54e66deb66fso891129e87.3 for ; Tue, 13 May 2025 07:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146251; x=1747751051; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5/auQxm3IrAhfUVDmTuHtjr7cikuNi8RLWcR7PSjSIA=; b=WGQEdub4bgnJ3E7gJKXdrCAgNNErSBCU0oi9ccWArHL9gEz4+oKMKlnhX27YaVVjRJ 4de89VU6EzBuwEC5HM7gz0A12B7BP5v6BG8WywLhLTAtyEqEB4QuNa2+4ERAM5M2WC4v NQB14czX3paTVL/1mZIBIrd2xrbOp3BOcJv0CDPv3WnevNpjmaxGeRWcp+YUDoN1Bg3F x9ghImOEm2d8aZK6NSmfppLlGwmKLWwL3aqfJxG5uWEBuKc6lrx17ghgIh5fYvfFU4hB nDrXRGzb4mdaZj5DxnPw+a9mKf59VnHw0VFkY2DhQLO0BtdquVGzk8anEHDrShjy5t9c k30g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146251; x=1747751051; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5/auQxm3IrAhfUVDmTuHtjr7cikuNi8RLWcR7PSjSIA=; b=KEVwmyhHqnbnOmeF6i8o3QfSI+WA+r8FBiiOBsccug7reaMH9NTnPvLez5qSB0cOHr faBrwRTKgYkZ25S5T/cUB1xvIU3biURZqzQPgr4+tDZl8cb8a6umDnrZBUO9J19RWQ6a V81aqAzh5y3OGAnLOFlYhs0WeB1iM1Dz8tPo/q1qnsxlypIEmLQPyFw+zhjhSiU5cPbp Dt8+stjSPqxKqXDLZ02xLclYqil/iDQkmAezDM8j7cPjkN4MKNqnIbq0LmHt75f8q3MO 6YK9QTi/R+22ybFq0uYBrCfeHVlRhxITCUqnGkD7W9fDSZcliN55k7cZhgenUkaIuJMm 7IEw== X-Gm-Message-State: AOJu0YxgQERCPfP1X+YD48ucu/BbDfcB1L43GgN1u9qby5i1lPEN4+6+ OdCZtEVqRslycRppsAs7Y8ySOgkpwExtgXzvRg+lcuv4ujsb/lMuWQp4endz5r4= X-Gm-Gg: ASbGncs3DrRsTI/f+quJK3cNHVCmp+Wbnb55FESZmulCL4p6CsRK9uTLOuTnVM1lw+V Ep6nTR3gvxCFce8SYs0BBHxIdVElwbtTRy7jwfW81KNgw+1VYg/Opvn8eaLV1D27SbTbZF61IQB NBkm6e70MjIrIUiUAVmnsx4JHQj3/W/V6CqVA34aMFMpRpHRCUlMWfzkaUBxeXfcN7+DjPHxkUO iZSRoSlCQjVKCn/DXBl5BdFXro7gO/+5JIa36M+eQ3xJO7NFWgz/KSV9EJ59qU3Q1vK5y+zYXjO K1OTfOF0+8QnT4Nqgr6ISCsQSgw3QfHcRxt4E2u74qm8/ypVXatjGb3/6DQAKcAflr+MYKxvxRg 5d0vEfMPPfi2YZQZ0F+7hh1buwl5wUanpEnFPFt5fDmewEYmXgtk= X-Google-Smtp-Source: AGHT+IHqwEbFhZhgXovx7bSWXvfgsMhzKBNxgoML9g87PhfEO8ZtLUbvptRFKBUuDrk1kKgcCCoHpQ== X-Received: by 2002:a05:6512:b10:b0:54d:6dd3:614e with SMTP id 2adb3069b0e04-54fc67aa84emr2239184e87.1.1747146250792; Tue, 13 May 2025 07:24:10 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:10 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 7/9] media: qcom: camss: change internals of endpoint parsing to fwnode handling Date: Tue, 13 May 2025 17:23:51 +0300 Message-ID: <20250513142353.2572563-8-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Since a few called V4L2 functions operate with fwnode arguments the change from OF device nodes to fwnodes brings a simplification to the code. Because camss_probe() as the single caller of camss_of_parse_endpoint_node() has no need to know a number of async registered remote devices, it makes sense to remove the related computation from it. In addition there is no reason to check for a OF device availability on CAMSS side, the check is useless as the always passed one. Signed-off-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 52 ++++++++++------------- 1 file changed, 23 insertions(+), 29 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 39c5472f4552..d4745fb21152 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -2973,16 +2973,16 @@ static const struct parent_dev_ops vfe_parent_dev_ops = { }; /* - * camss_of_parse_endpoint_node - Parse port endpoint node - * @dev: Device - * @node: Device node to be parsed + * camss_parse_endpoint_node - Parse port endpoint node + * @dev: CAMSS device + * @ep: Device endpoint to be parsed * @csd: Parsed data from port endpoint node * * Return 0 on success or a negative error code on failure */ -static int camss_of_parse_endpoint_node(struct device *dev, - struct device_node *node, - struct camss_async_subdev *csd) +static int camss_parse_endpoint_node(struct device *dev, + struct fwnode_handle *ep, + struct camss_async_subdev *csd) { struct csiphy_lanes_cfg *lncfg = &csd->interface.csi2.lane_cfg; struct v4l2_mbus_config_mipi_csi2 *mipi_csi2; @@ -2990,7 +2990,7 @@ static int camss_of_parse_endpoint_node(struct device *dev, unsigned int i; int ret; - ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(node), &vep); + ret = v4l2_fwnode_endpoint_parse(ep, &vep); if (ret) return ret; @@ -3025,52 +3025,46 @@ static int camss_of_parse_endpoint_node(struct device *dev, } /* - * camss_of_parse_ports - Parse ports node - * @dev: Device - * @notifier: v4l2_device notifier data + * camss_parse_ports - Parse ports node + * @dev: CAMSS device * - * Return number of "port" nodes found in "ports" node + * Return 0 on success or a negative error code on failure */ -static int camss_of_parse_ports(struct camss *camss) +static int camss_parse_ports(struct camss *camss) { struct device *dev = camss->dev; - struct device_node *node = NULL; - struct device_node *remote = NULL; - int ret, num_subdevs = 0; + struct fwnode_handle *fwnode = dev_fwnode(dev), *ep; + int ret; - for_each_endpoint_of_node(dev->of_node, node) { + fwnode_graph_for_each_endpoint(fwnode, ep) { struct camss_async_subdev *csd; + struct fwnode_handle *remote; - if (!of_device_is_available(node)) - continue; - - remote = of_graph_get_remote_port_parent(node); + remote = fwnode_graph_get_remote_port_parent(ep); if (!remote) { dev_err(dev, "Cannot get remote parent\n"); ret = -EINVAL; goto err_cleanup; } - csd = v4l2_async_nf_add_fwnode(&camss->notifier, - of_fwnode_handle(remote), + csd = v4l2_async_nf_add_fwnode(&camss->notifier, remote, struct camss_async_subdev); - of_node_put(remote); + fwnode_handle_put(remote); if (IS_ERR(csd)) { ret = PTR_ERR(csd); goto err_cleanup; } - ret = camss_of_parse_endpoint_node(dev, node, csd); + ret = camss_parse_endpoint_node(dev, ep, csd); if (ret < 0) goto err_cleanup; - - num_subdevs++; } - return num_subdevs; + return 0; err_cleanup: - of_node_put(node); + fwnode_handle_put(ep); + return ret; } @@ -3626,7 +3620,7 @@ static int camss_probe(struct platform_device *pdev) pm_runtime_enable(dev); - ret = camss_of_parse_ports(camss); + ret = camss_parse_ports(camss); if (ret < 0) goto err_v4l2_device_unregister; From patchwork Tue May 13 14:23:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 890481 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7D972BDC1B for ; Tue, 13 May 2025 14:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146255; cv=none; b=E7xKjnJ1JeQ1GQqd05NtdFUnHyxSccD2I4eFCTQiq55eXcpTRXdq6q63KdpB9FgCr0bCEYtm20QkinjzLiTxsR5sQQJwnEqoGdJNFgAVtZ1Tb2dUwTFchxYxcdumeUxvT4IIxLfR9EpDngAUjLAjYhNpBbscE1bp+gLQCUmUd7s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146255; c=relaxed/simple; bh=XdEO4KmhdzkmFgTppxOTLqYmKKiZ4V91Zop709Tv7QM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UqtfK0ObjiWNTZXEJFL4M5jQ+bQEagk0uSF8jVuf99aN3kU/EkvCCC0ek/sDvZPSMr0cs511pnBjxY8QLsgpmJMcAOrlrJWk3yezqr5J2NRHCj864TtxQ2+cva+jEcc4+c8h5ohrYHcOG16zoHczCKCG8C5WF3cb6j5JPkj7F8M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fA0/DqK1; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fA0/DqK1" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-54d72d40343so1292680e87.3 for ; Tue, 13 May 2025 07:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146252; x=1747751052; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bkvIXboeSQ7DpFMEdb2LOpzhdD+Ul3bkMffg79IGGvk=; b=fA0/DqK1u1AHapDtBP7DbQ1EE7NbFRf5SZIFkfVDBavvYxzDxcFJSJBCR11orhq/LQ RivDUbg5JZJCZOhdRRY/rx94p/6tw93fI6SjJqE3ELjv6qmKP5e6yRAiabjVl2AnIfSa LhXjQ7X9DV9j2Q0liUibRkfqEtzGqYCnHs1Kz+3c0jqN3yx711uJXol1mQwN9iF+/VSc MmsC9G4NsNmxApGYRL6WOpllJLPudkrzi/t25K/dISF3/aveuCp9L58uxp+vOzu1FcBC lM07mqOHSojQALWDsw5F6THJcZt7advAgdzAf5HTeVTwU8yav51TZVzwWNz9TsxPwLOD fUxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146252; x=1747751052; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bkvIXboeSQ7DpFMEdb2LOpzhdD+Ul3bkMffg79IGGvk=; b=ObD8QgcTGJFAH5Y2OjoYYVjzZjkEzh4s02dpEfwx1LWC71TKCT16OiKRdBaUeaWblW 6xuNybcHjnLusUwyc2BDE4BlKexa5U2ryCooYsELf93jzoclMpLAjthTNhX2aUvVqyrD 6v0fyj9vLBJt/I/VU4h2x9wFJN6sh9TPp2e0O7Rd8tiV+sgVQNhwyn0rZXecD9KUWwGD DjjkaFXl3fJSAQlAcd5BmTWYM0pSyIG5tLXjYdzdE7zJRFROajMphge7QS0M4/enfm2K XLYSiWrJVSHFf6ZwU32Sm/eteZVlKJmwU17weThkUEP4yq/k7sBIABru2lC3yYMhkoYT DyzQ== X-Gm-Message-State: AOJu0Yw8UOjdIr8EgXM5CcilkkosUepqrRarNyr+8SjJjwb8XYvtWVGJ uqexGtUjOzko9hV/83Wuc2zI6EP5oVIqGrvbj8Xc0SwyjjSIMSSet6OkyORdpy8gwqcORI+iyyu L X-Gm-Gg: ASbGncsqGigME+Kf/3ojQXxicIEYbdIqNBOMeeeTwAwti2JsaU8eDoMU0kJp6oBvyBJ LuN3MGjR7dK0gVZb+1a7Hj+pTjkUQ0jXntn5m/KBsHxBW8UZSUapLk+v7OVGmrlfmdhtu3eUclw 8OTu9toPZpX8oWuZ1l8qa1waLGOAPFlgjwhRgS7jEJQr/Ki0938SHK2aoV7DjSVFOAbgSj+CiLO QQ7M7aeQK/wlorAtsu+Vl0wLeZjgIA31hWkg6EmC9vwRIOhMjnCwwTkceCSOrSWu+Czm648N+j9 8esGIGXRK0d2Cl7IeZJK+BpE8WskGVPEXTgHkWhELd5jT+EEB21ga+67hMMxDsDnMgwhl9h55Uq HAEDsDO7ZS+ljcJc8hPe0hQnIOp7pZQ/bin7iQteAcIYpaGacU2E= X-Google-Smtp-Source: AGHT+IGQvf2B9ZgZKrTjzA36UsxZkfwbIxpb/CDy+kO+0v3DXVBuJa/bdlFuqAoJspo3OGr97iZJ5A== X-Received: by 2002:a05:6512:3d28:b0:54c:a7c:cbda with SMTP id 2adb3069b0e04-54fc67d30e8mr2165049e87.15.1747146251725; Tue, 13 May 2025 07:24:11 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:11 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 8/9] media: qcom: camss: use a handy v4l2_async_nf_add_fwnode_remote() function Date: Tue, 13 May 2025 17:23:52 +0300 Message-ID: <20250513142353.2572563-9-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 One more code simplification makes parsing of remote endpoints easy. Signed-off-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index d4745fb21152..0d05f52a6e92 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -3038,18 +3038,9 @@ static int camss_parse_ports(struct camss *camss) fwnode_graph_for_each_endpoint(fwnode, ep) { struct camss_async_subdev *csd; - struct fwnode_handle *remote; - remote = fwnode_graph_get_remote_port_parent(ep); - if (!remote) { - dev_err(dev, "Cannot get remote parent\n"); - ret = -EINVAL; - goto err_cleanup; - } - - csd = v4l2_async_nf_add_fwnode(&camss->notifier, remote, - struct camss_async_subdev); - fwnode_handle_put(remote); + csd = v4l2_async_nf_add_fwnode_remote(&camss->notifier, ep, + struct camss_async_subdev); if (IS_ERR(csd)) { ret = PTR_ERR(csd); goto err_cleanup; From patchwork Tue May 13 14:23:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 889778 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBD882BE0E0 for ; Tue, 13 May 2025 14:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146256; cv=none; b=VW//mHtSl44b794E8EbjAJ29ncvlyVfObBtyXmG4QrojrRQ6VRDwhhVZpsboQNVQsoPdiPcNNhY/Sd9h1ufphPR4utPZCUMR65xffW23oE7JMRFEkf6eIp+1bNDQAoBmLYSpYQvY7ORpwh0ZOQ/WCnMrZKfs6x20zG3adrS7dE8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747146256; c=relaxed/simple; bh=xuTTjd+g462s92piJzO152zSuWtKaJvpLpSJbcZ7r7A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AcDVTjc4UltT2R+33uCRiPzIOX7/9p6/uyzgktJ4Vcsxrwb1qtWke1EOo+QmgO9gpJ9h+OyWL21t7B0ts8/xxZzUEby9xuwvLpaRbQkVBQJ5e0f4kQUMgeHuSpyxwIF+T4aNEVAUUG3Dh3T/HRPbQgo1Kh++eEjxqs7LsK2q7TI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gpn1+7So; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gpn1+7So" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-54fcbc68213so644357e87.1 for ; Tue, 13 May 2025 07:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747146253; x=1747751053; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jbp09rP7yjvsBo1LKOhlRvBKJcU01MMyhu8zUDGFwjs=; b=gpn1+7So1bBB1yAq2YqdQad9Eu3XhiQ7KYKOOAYWGY9pP2EV//WAtn0+6+HPoZFLkl pf2qeUQy9IRPUl5IGo3lxZji6UVl7Fxr8W2wcvBpuBPPiz17LQzfHMAFXfAvH/a5RSu8 OtQjxAI8fnpDSvDHBxFSTFdqwTAMGeaATx3iuHSRVvBhPNbMOj6Ied3VnaMcgN9lTLAS vf1Fe6kwcTux7TkxeWOkNjVD2yvYPZrlV/L3MPmRvGLkE4k83CRPOvZVr5h3HZssv0OP zsHA+NKv+XpUjMbSVIqMRjAjyl+7Ruv4io0fnww1yRASn25XVBXeQr4DDAmx77Lz/eLM CMdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747146253; x=1747751053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jbp09rP7yjvsBo1LKOhlRvBKJcU01MMyhu8zUDGFwjs=; b=KCrpx54trpRWTNaKdDJbcdx6QkRiY5/8B9/3Km8MogW/GHd0S0bNoLPoOPjW4wsWDN zYaeoRxVbsk9ikFsssZKUOVpo0iMyiBCfF4K57ONBwduA91IPbqXd2wUC/wC3hufuMbN f1vV8rvFgwTkB62R4efcxYF9y3bG+NBA5emVEzK2IDeld8DFP+JXlznCmnEG0GkKk7Gc QJqzPWIIUh/gM2gJQBU/fX8zTggJyv01c3GMb2wkScD9brnTxVo8IMsbq59KsHhf/bGr nGHi4GkqZnayH64CZdbRg3foMgjNwLZzsNK4+qs/aoeqAVvSizL+M1hAHdt7kCuV9Y3r YteQ== X-Gm-Message-State: AOJu0YxjpFpGh6C7js1Evy/mMb+BtMUPLLDs9vv7S/YAbawcTVMu38IU E5SsHjtYUzdMt6bH5tnSOYlT4Gsv/xV86WD0i9ezmS5PaWlxNBHtLwkQMkayotQ= X-Gm-Gg: ASbGncuIXxeRJ3a09FWxzHRTIL3Dcu6dYzytpAGyuSPQNVtJJ7DdtfK3wJgiaceifgb hpXDkuSJ0/0t/Ac6aOhQtvFF6/OV+UYEFLEOWmah8eEWn008HcvBByUa84qjtYT2YoY9LIapmCE Gi+8iPEF8VRnSyY/xEMaZhLkZI7jY7QJJlEVkBCbTGObPgUaqiBAKoqDWn3FDV3SlhkUHCkApkG 0NL7dcp9V+fIl/oX5D00eIXMLf2B3nCEiuIAQVFX7V09/jMo1Aj0jYlbZR5p/3Px7Dwfh6FygS5 d6ZJfMCheggcoFc05rwuzbarNW7GmZsQeCMQ7/DLuOCAA4kzsQOohTa28hdUgGytN/OO4KJykwt qqAAk3Nvb1kODDA9R38agjmD/sHfuyta9OfNEQHN3ZRuXeldCx4w= X-Google-Smtp-Source: AGHT+IEysCfN4QoGm+Kt4uTCWGC/FxersV1Axm+mK3Qn1WIeyAnenQCAPHpytZp/YJF6w/cpc4ZOqg== X-Received: by 2002:a05:6512:3994:b0:549:8c32:78ea with SMTP id 2adb3069b0e04-54fc67bd4e7mr2176139e87.7.1747146252969; Tue, 13 May 2025 07:24:12 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54fc644fba0sm1871813e87.23.2025.05.13.07.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 07:24:12 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 9/9] MAINTAINERS: add myself as a CAMSS patch reviewer Date: Tue, 13 May 2025 17:23:53 +0300 Message-ID: <20250513142353.2572563-10-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> References: <20250513142353.2572563-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add myself as a review of Qualcomm CAMSS subsystem patches. Signed-off-by: Vladimir Zapolskiy --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6dbdf02d6b0c..9b973c0128fa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20135,6 +20135,7 @@ QUALCOMM CAMERA SUBSYSTEM DRIVER M: Robert Foss M: Todor Tomov M: Bryan O'Donoghue +R: Vladimir Zapolskiy L: linux-media@vger.kernel.org S: Maintained F: Documentation/admin-guide/media/qcom_camss.rst