From patchwork Thu May 22 17:29:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Augusto von Dentz X-Patchwork-Id: 892268 Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E8A918EFD4 for ; Thu, 22 May 2025 17:29:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747934998; cv=none; b=tWlCZC6OwsGQmdsag9LiOYbneRXzqViIVHAEvbf6uLPNLjQE9CHj8P0ek+BnXfDxXPkxqy3ZTkBDRyqE3H+khJwLjRjd3skNBGRlxCCwsBd0gc1IC3XVBhQPzbNmPrOEjJpmp9gIzf5L5TBDEvrj2QsSCzLX/jcQ+3cJKRglydY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747934998; c=relaxed/simple; bh=FEii0TmmwgHnUUUTsuH0CL1vMg0ZA4wGA2CELBu6mbM=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=HE+RBwF2WIOr8w0NhxNKkIa1xEDzpkExQlg6hpSJ6qh7RVQzlRDpTkMm01m40pbAvriOJo3YSAQDfu44bJyQw7HZy+z1d5THWgPb+tJ9Wj/WcMYpMeZ6PhazCwwiQIt35QcIq3i45zYH6GEss14Dib/K8/xs1r6ejUWd9qY1TSo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nao1+t+y; arc=none smtp.client-ip=209.85.221.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nao1+t+y" Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-5240b014f47so2723034e0c.1 for ; Thu, 22 May 2025 10:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747934994; x=1748539794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=T78sAGZml+VrZv1K0gsSbOmWw8dQPoEVSBR0LIlFhcE=; b=Nao1+t+yruI/ewt7DTaZ08SyyMv71CYDXEDs9lD5J81RlVnVd/Ob4ia33siNPIwPkM 2PpXumOBh1x/y7bb2u88uinny5+Cd7qwpGP1th2wMT+K1XqpHvbaQCchxjMNpvnI8lVN DzrA4NyTPT8LT8essXBGsaZzxTpRgrj07f2Wag5cmbKNTrhdCBkn8iRqX8GoUsr9bj6m /yCw/vaUZ916yuU3KmyBL7QNmTxeUiuT+s68rL+crb4KRgqm4o4e8mQ532EIicxy26nb XtqS89Yp+2SVTJ7sGNYrUnIFpuPzbV+ilxf5JZm5tWWLzahhadJ55xPFyouiYmwZXuSi 39+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747934994; x=1748539794; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T78sAGZml+VrZv1K0gsSbOmWw8dQPoEVSBR0LIlFhcE=; b=Pah3uj9pjVnoD3/ODsVCq6SdK7IesPs1S3USc3X+fNDLfOCznw39LtJuv5UOqxdW75 RmcVWyOZ6sOW0whwMlayEkT3oy2rqclNT5rtDazu/Hi4SjDPDS2cnBxMdV2kgVQa4J2c Lege+xLMYLr+L/fJUCDuk3d4GQhgjpYjfvFQIhhpsX4L12Au20v+VEzB6XYt4RSz6pbN j193S0JzlJHC21U1nyEkafw4uk7JQfX4FRjE/IB2WrQ7by6fK3BA0FiyYZX/qqODAYWW FZ+hW5XBxt3gToJJkgLoD1fDXGSGx4eQ4/sPzkeGJCM2gC5St1YhMsv5A46OVVpa0Kzj /8yQ== X-Gm-Message-State: AOJu0YzHxEiRecB2JVOORv+j+vYy+jJSoZ1p5XKDHJb72nFn0Ne91D1y raXHMF/C7MzYeUGb2ZuQ4NIF0LN2hddGgUgtaE/y6WkUyNF3XAY+vBINPmQFL0Ge X-Gm-Gg: ASbGncvxffxOeOuR+lZU1ujVpXUpiZkUJtqsfMFYaZNE7DPPIfrxEefnLRUG/YMnSaZ p0K0BfZcyqEPPxHvUy0OJW+JO5Z8hbwajPS0x6Isk/Ly0LJTYJhl3/scfMtHnhVbw7GcK+YgOLj 2XV3OAC1TYc1E6zXLfZSHFu9KysJLJSLqZKW3V+3w+T9c47xjLdwSeJ60Wggpy0QQuo7+cthSIS i7YkRoBXqLg3JM8QR68arrbf2wV+4O08sywEkddHqeF8bErZhbs4GCVk7ISiuuvjwAntLNM5e4E 8xw/qWRhzgOThBF9G0b0z/NCnB8SO4taXKpEHP1SGXSK+c9MJ2DjSneWOpnyVVNTuJzVzupiW4+ oEl4aIrknVuv1Ti8CUDYu X-Google-Smtp-Source: AGHT+IG1/Rg/eUQeQA5YC27JzHPp45KuA850KXtCUEUr9nbl77PhnVNtPplwFcZ3Q6zB1i0t3ZY4DA== X-Received: by 2002:a05:6122:caa:b0:520:61ee:c815 with SMTP id 71dfb90a1353d-52dbce4a585mr22337034e0c.10.1747934994136; Thu, 22 May 2025 10:29:54 -0700 (PDT) Received: from lvondent-mobl5.. (syn-050-089-067-214.res.spectrum.com. [50.89.67.214]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-52dba91076esm12220321e0c.3.2025.05.22.10.29.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 May 2025 10:29:53 -0700 (PDT) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH BlueZ v1 1/4] org.bluez.Adapter: Add AutoConnect to SetDiscoveryFilter Date: Thu, 22 May 2025 13:29:49 -0400 Message-ID: <20250522172952.3312270-1-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Luiz Augusto von Dentz This adds AutoConnect filter option to SetDiscoveryFilter which can be used by application to automatically connect devices found matching a pattern. --- doc/org.bluez.Adapter.rst | 42 ++++++++++++++++++++++----------------- 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/doc/org.bluez.Adapter.rst b/doc/org.bluez.Adapter.rst index 021e4f8e5a9f..c5b8ed8e9132 100644 --- a/doc/org.bluez.Adapter.rst +++ b/doc/org.bluez.Adapter.rst @@ -150,29 +150,35 @@ void SetDiscoveryFilter(dict filter) that don't set any pattern as it work as a logical OR, also setting empty string "" pattern will match any device found. - When discovery filter is set, Device objects will be created as - new devices with matching criteria are discovered regardless of - they are connectable or discoverable which enables listening to - non-connectable and non-discoverable devices. + :bool AutoConnect (Default false): - When multiple clients call SetDiscoveryFilter, their filters are - internally merged, and notifications about new devices are sent - to all clients. Therefore, each client must check that device - updates actually match its filter. + Connect to discovered devices automatically if a Pattern has + been set and it matches the device address or name and it is + connectable. - When SetDiscoveryFilter is called multiple times by the same - client, last filter passed will be active for given client. + When discovery filter is set, Device objects will be created as new + devices with matching criteria are discovered regardless of they are + connectable or discoverable which enables listening to non-connectable + and non-discoverable devices. - SetDiscoveryFilter can be called before StartDiscovery. - It is useful when client will create first discovery session, - to ensure that proper scan will be started right after call to - StartDiscovery. + When multiple clients call SetDiscoveryFilter, their filters are + internally merged, and notifications about new devices are sent to all + clients. Therefore, each client must check that device updates actually + match its filter. - Possible errors: + When SetDiscoveryFilter is called multiple times by the same client, + last filter passed will be active for given client. - :org.bluez.Error.NotReady: - :org.bluez.Error.NotSupported: - :org.bluez.Error.Failed: + SetDiscoveryFilter can be called before StartDiscovery. + It is useful when client will create first discovery session, + to ensure that proper scan will be started right after call to + StartDiscovery. + + Possible errors: + + :org.bluez.Error.NotReady: + :org.bluez.Error.NotSupported: + :org.bluez.Error.Failed: array{string} GetDiscoveryFilters() ``````````````````````````````````` From patchwork Thu May 22 17:29:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Augusto von Dentz X-Patchwork-Id: 891777 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC0B11925BC for ; Thu, 22 May 2025 17:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747934999; cv=none; b=DS3WsTHCgSlMJQjol2JwArIm8pVJ5Yx2ROQ6inTTChycbnBuSSCWOLCEG+qr8FVtL2LcHUxekmUZ3duNEkWPEE2FzRDqNyoUMcmBOvCZbM5f6sTdMCztt6kyOIKjpM/g2GaV9haQiGR2/QPe2MPqhhyI29zHomFoXdbdcL2TtTw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747934999; c=relaxed/simple; bh=1eZrw/AwTuL/+T6HbZsLPlOG2fnve87biyVLFhY7Q5c=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kvjc54tEKQeHgHSq4rfQc/y8iinnUc7m9p6nXP1M9ZaQPyPvc5ieEvopQHG8jtGoQo0zXb4xmRYWvAGfn81YYsnGenHFpUg9V6JGoDvV9Uehi5djXchEJ80JbzamRMDVMKGdNSht1ZdLL/Tgp5sflV+BOul5x172OtGoRQXJ4S4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fO0B0fgP; arc=none smtp.client-ip=209.85.221.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fO0B0fgP" Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-52f036ef186so615315e0c.1 for ; Thu, 22 May 2025 10:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747934996; x=1748539796; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=SSwpShzqkrEEWLovRcsJUJPukGlflT/Ls8V7hd/Y1gs=; b=fO0B0fgP03L0qWYK7C2GqRnSE0Fp0LzONqN3pq9VMSy5TuR/X+bLpXgGSWLvGu6RMf tqjFYoDtkB3llB8qBiHHzLDqPRY+L3LgicPZbJv6xtWgtdfj6IZ3go2go2N/WpbNkxup o2vqLluVZPXlpqO4YO5Tk2+KNMCqPRTu0BzgQC4Yn7QTS9uBGY9P7vMFiPu0yawJvA0p H+Wy2ATuAokzlXQg4Q/Poj9QHtzO9zBs19l71AhpzkJZEnY4DcyNdW+hmcYg734Wf0Yj 1i55KEsXsT8xPmUPSX18UqZq5onyPQS0tSqfqCj2IbooHZlB7tQh78+4P9hqGsjUuTs7 bJVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747934996; x=1748539796; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SSwpShzqkrEEWLovRcsJUJPukGlflT/Ls8V7hd/Y1gs=; b=xBjE13VZmGgodJWyW0Sqb3G7MhTcRb/Dv/TTHKV+sL4oze0JetTBwBYGTNWJe9Eyzv 4Q0FTsdymKMjcpfCgHy5BH6hgzdsoL7QHOwUwtorRFcjVyoaxnsROX9Xzn+w9ciGSWQw IFUOZffNvzCuAVILdmM4FJ1PFhJtGZhHb8uUDjUzgH+zodAgdwBqGWIQs1uJmy/uDx/h zB9dn916AkTNzcjQBZO9xIgMvpCcJ/ZxIDTQI5n/O9cEs2xoG4iUFAfOsRT5gYJyaehm AiUueYFTuuMRC0u8iS39wdoG8p6u8/F2Oqn9Kr3triy9aTCdZAH/kj3bdy9+GOi0vBgx 957w== X-Gm-Message-State: AOJu0YyH52DmXeUBFepBgpJ7lMS1eAaNrJZrbAvlgcy8I92fqvGSC2cG EM6QRkcyFWIoC5NMNDNhdXk9UUqg17GCXDtUqmfacX0zV4zTsC9d+ydVkBjY5yli X-Gm-Gg: ASbGncsEHe1K7dlLeZnBzn7dA3chR9etmpCfg16vgj9EOlF12ZSziyifWhAoTsqfRVO 7SRzVnbN1lqxcxxW4VNbGSlR6GTpjJAk5r07PPNZiSoTvCK40pgdF8I+WoElpIOlHYY+SQNbGge arVbPanyTHROjCyd1VEA4OJriMWWGkyi9QajL5ACk/2/X9qgrPUiVlbssLi41T4UuIejAiOM+YI sE1MbAKV74DPhUVxFXaXrVQ0cyrKJRj8eRv8PSd23DZ6EgVnpvhwrpSr5tssaouU5tCOMR04UGI 4k9z5itNF1qmiebjA4BZEIP/VBp45HsAE5QUNZLWgsvDkOZg4nMCx/ib96XelwbqM5C1RFqz+gn 6ElNLwkz5eUwwF5CAjTpC X-Google-Smtp-Source: AGHT+IGJoounHWcW1aSgTWFDKUCKh2bt5nAUH3/b7E3KvfYYDslbkMpSDIZg7xbG16n3xZOPZX+8+Q== X-Received: by 2002:a05:6122:46a7:b0:52a:cdfb:7ff9 with SMTP id 71dfb90a1353d-52dba866824mr23295309e0c.4.1747934995985; Thu, 22 May 2025 10:29:55 -0700 (PDT) Received: from lvondent-mobl5.. (syn-050-089-067-214.res.spectrum.com. [50.89.67.214]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-52dba91076esm12220321e0c.3.2025.05.22.10.29.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 May 2025 10:29:55 -0700 (PDT) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH BlueZ v1 2/4] adapter: Implement SetFilterPolicy AutoConnect filter Date: Thu, 22 May 2025 13:29:50 -0400 Message-ID: <20250522172952.3312270-2-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250522172952.3312270-1-luiz.dentz@gmail.com> References: <20250522172952.3312270-1-luiz.dentz@gmail.com> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Luiz Augusto von Dentz This implements AutoConnect filter option in SetFilterPolicy method according to its documentation. --- src/adapter.c | 42 +++++++++++++++++++++++++++++++++++++----- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/src/adapter.c b/src/adapter.c index fd425e6d2fe4..328a6baa54d7 100644 --- a/src/adapter.c +++ b/src/adapter.c @@ -214,6 +214,7 @@ struct discovery_filter { GSList *uuids; bool duplicate; bool discoverable; + bool auto_connect; }; struct discovery_client { @@ -2697,6 +2698,21 @@ static bool parse_pattern(DBusMessageIter *value, return true; } +static bool parse_auto_connect(DBusMessageIter *value, + struct discovery_filter *filter) +{ + dbus_bool_t connect; + + if (dbus_message_iter_get_arg_type(value) != DBUS_TYPE_BOOLEAN) + return false; + + dbus_message_iter_get_basic(value, &connect); + + filter->auto_connect = connect; + + return true; +} + struct filter_parser { const char *name; bool (*func)(DBusMessageIter *iter, struct discovery_filter *filter); @@ -2708,6 +2724,7 @@ struct filter_parser { { "DuplicateData", parse_duplicate_data }, { "Discoverable", parse_discoverable }, { "Pattern", parse_pattern }, + { "AutoConnect", parse_auto_connect }, { } }; @@ -7212,7 +7229,7 @@ static void filter_duplicate_data(void *data, void *user_data) static bool device_is_discoverable(struct btd_adapter *adapter, struct eir_data *eir, const char *addr, - uint8_t bdaddr_type) + uint8_t bdaddr_type, bool *auto_connect) { GSList *l; bool discoverable; @@ -7242,15 +7259,21 @@ static bool device_is_discoverable(struct btd_adapter *adapter, discoverable = false; pattern_len = strlen(filter->pattern); - if (!pattern_len) + if (!pattern_len) { + *auto_connect = filter->auto_connect; return true; + } - if (!strncmp(filter->pattern, addr, pattern_len)) + if (!strncmp(filter->pattern, addr, pattern_len)) { + *auto_connect = filter->auto_connect; return true; + } if (eir->name && !strncmp(filter->pattern, eir->name, - pattern_len)) + pattern_len)) { + *auto_connect = filter->auto_connect; return true; + } } return discoverable; @@ -7274,6 +7297,7 @@ void btd_adapter_device_found(struct btd_adapter *adapter, bool name_resolve_failed; bool scan_rsp; bool duplicate = false; + bool auto_connect = false; struct queue *matched_monitors = NULL; confirm = (flags & MGMT_DEV_FOUND_CONFIRM_NAME); @@ -7310,7 +7334,7 @@ void btd_adapter_device_found(struct btd_adapter *adapter, ba2str(bdaddr, addr); discoverable = device_is_discoverable(adapter, &eir_data, addr, - bdaddr_type); + bdaddr_type, &auto_connect); dev = btd_adapter_find_device(adapter, bdaddr, bdaddr_type); if (!dev) { @@ -7483,6 +7507,14 @@ connect_le: if (adapter->connect_le) return; + /* If device has a pattern match and it also set auto-connect then + * attempt to connect. + */ + if (auto_connect) { + device_connect_le(dev); + return; + } + /* * If kernel background scan is used then the kernel is * responsible for connecting. From patchwork Thu May 22 17:29:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Augusto von Dentz X-Patchwork-Id: 892267 Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9032618EFD4 for ; Thu, 22 May 2025 17:29:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747935001; cv=none; b=KA4aAIZ509n3cj3M9ngKRgpnS3Xy0bGJGV9lhfcyjjAGn3AKYAtK88bJVyJjSVZR/TPLXSELc1tcLaqWk34Aw9X2XADwHCqsfGRttr4ZynFrA7lhglrA/cecZphMoSW9eZ1ricwamvu+NiUj43roGYNdrkDkRcy8Pj3vEQRbiLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747935001; c=relaxed/simple; bh=h6N/ltvzcfj7tRVQG9d80Zlz2oDBAWBGAX5OAPvf3FM=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pi0w2Yw98qQmcEUr2vrW25UckPR//+TKVy6RE6OPrLGxFLk6e9/w9+DrhW/V6ZEpykKu8HxTDjTDk4A4RQrOVixGZ99AP4vSut8EMr1cy95uWs6b8jtexkE/+GdwBM+q5hY87RKpBI+D7Rn16MnJhUatlV3TVwxwXeGBlllF4cA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i+veWCJP; arc=none smtp.client-ip=209.85.221.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i+veWCJP" Received: by mail-vk1-f178.google.com with SMTP id 71dfb90a1353d-52410fb2afeso5398176e0c.3 for ; Thu, 22 May 2025 10:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747934998; x=1748539798; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=E4YADi2e17JHtskS5BkrhmLyo+3VegEd3LoVV951SpA=; b=i+veWCJP2/g1aexjsjDKmI4BMD00JyW77RSYmi75udWmggEGOQ79uPotuzJYwjgEt+ 8ocLjne9qjjN8aM0loRcds1fhMdia8HIt1M+BDlGW1dAMwvvVfaW0IIJYS8Akg+ZLrbI nhJErMGJ57KtDUPKlzSFtg+HlNVbuBdYHpSWn5xGt8zrFY/kRA1SNC8NS0o9aWgGzK+T zUG02UbbiEwbvGOdZhvEn2UDElRReWCyFWmhuQTRxdd97EqlZOdmlCbr/8EcnKUE7rOI JrhSxTbMPVHpLQ57OJZ8ToEV4XVE/SDXaxscR/Kkf1LPueQRsJSpfV2ymdZ0La5stytQ /4tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747934998; x=1748539798; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E4YADi2e17JHtskS5BkrhmLyo+3VegEd3LoVV951SpA=; b=XXY1bGB4YasPpoZdMavxRrG1fRL8rQJb4RMw0F36qgvgNBJM0BwSMWNVJa7fJajhcR 7Wh6HggcYmxj6UMZQJqRhahESEzH6++qeK9c2oBsCiYtaIj1U0cC78OwaZWWv4liv2NB l1JyCDN8+1z8h80x5Lv+1JQLONzWB5rQEI9l8QVP6BsansN6Vzgy7MZTQYSU34w+2JH3 jAX+dcxjCGcOZJeEjGJPAYw9cUEZULsL72cFj/+vKb3583MTpEgGyRt80bQrb0e2VQn3 qUxuDCD1cdN0RS3LS9UMsR8V2BccWo1/0KhsZkkRq99UQYOxZqowal6FIWUud75jWNua Q+LA== X-Gm-Message-State: AOJu0YxOsGE1Gx3cmo6784LI9ukvhJeXOLPsGxvqUROZxnTyIL0/+R+I HlF49HLMDKjEpluL5wKn91S4DTIniUQqOLE0aCau/YnQBaoErrqy+5jWHwgCmsQ5 X-Gm-Gg: ASbGncs4xAzfXj6lsOz7HolwbBTif5VqaQhIp7d3trp38ESebQN30r+82z+JzGZwtuD cI00NhGDa0xcq+VZgCDvIoIWJU8ipNGujzvLF9BTGIuChXBJtQ+3DxPhHTAYROBlH84rmLe3yV0 QYCilgE3oGySUbEy/Bu8BIhzE/eyUzDsGcUzdqUPMkDna0NZY4czhjCbJHBHaOvAGKHi49savBu Cj4AQ++Z4/0Kbsm2LXL5oQol9BavKruXwttCBGD4d8Bv8aBNruCD/rX5SqSRJhHHmPQFdI2iMQI u7c4wXVOX6vaOmhrmwesKekiT/D0or8qpkk2ADCIIQui8awGGQDhIC9I+ttb91m1aw244sSmhJL CbeqSxyR3aPXXIesVRjCB X-Google-Smtp-Source: AGHT+IHEj1i2F3o4LLb7qa00axciBQ8f5T6bKroiUfqnceB/JviEGkOKypIYF8IIfdhI7KLUAjQwVA== X-Received: by 2002:a05:6122:221d:b0:520:6773:e5ba with SMTP id 71dfb90a1353d-52dba803151mr25679744e0c.2.1747934997625; Thu, 22 May 2025 10:29:57 -0700 (PDT) Received: from lvondent-mobl5.. (syn-050-089-067-214.res.spectrum.com. [50.89.67.214]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-52dba91076esm12220321e0c.3.2025.05.22.10.29.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 May 2025 10:29:56 -0700 (PDT) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH BlueZ v1 3/4] client: Add scan.auto-connect command Date: Thu, 22 May 2025 13:29:51 -0400 Message-ID: <20250522172952.3312270-3-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250522172952.3312270-1-luiz.dentz@gmail.com> References: <20250522172952.3312270-1-luiz.dentz@gmail.com> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Luiz Augusto von Dentz [bluetoothctl]> scan.auto-connect --help Set/Get auto-connect filter Usage: auto-connect [on/off] --- client/main.c | 40 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/client/main.c b/client/main.c index 5d53a7be11e4..5c31cd8763e2 100644 --- a/client/main.c +++ b/client/main.c @@ -161,6 +161,7 @@ static struct set_discovery_filter_args { size_t uuids_len; dbus_bool_t duplicate; dbus_bool_t discoverable; + dbus_bool_t auto_connect; bool set; bool active; unsigned int timeout; @@ -1253,9 +1254,14 @@ static void set_discovery_filter_setup(DBusMessageIter *iter, void *user_data) DBUS_TYPE_BOOLEAN, &args->discoverable); - if (args->pattern != NULL) + if (args->pattern != NULL) { g_dbus_dict_append_entry(&dict, "Pattern", DBUS_TYPE_STRING, &args->pattern); + if (args->auto_connect) + g_dbus_dict_append_entry(&dict, "Pattern", + DBUS_TYPE_BOOLEAN, + &args->auto_connect); + } dbus_message_iter_close_container(iter, &dict); } @@ -1492,6 +1498,29 @@ static void cmd_scan_filter_pattern(int argc, char *argv[]) set_discovery_filter(false); } +static void cmd_scan_filter_auto_connect(int argc, char *argv[]) +{ + if (argc < 2 || !strlen(argv[1])) { + bt_shell_printf("AutoConnect: %s\n", + filter.auto_connect ? "on" : "off"); + return bt_shell_noninteractive_quit(EXIT_SUCCESS); + } + + if (!strcmp(argv[1], "on")) + filter.auto_connect = true; + else if (!strcmp(argv[1], "off")) + filter.auto_connect = false; + else { + bt_shell_printf("Invalid option: %s\n", argv[1]); + return bt_shell_noninteractive_quit(EXIT_FAILURE); + } + + filter.set = false; + + if (filter.active) + set_discovery_filter(false); +} + static void filter_clear_uuids(void) { g_strfreev(filter.uuids); @@ -1531,6 +1560,11 @@ static void filter_clear_pattern(void) filter.pattern = NULL; } +static void filter_auto_connect(void) +{ + filter.auto_connect = false; +} + struct clear_entry { const char *name; void (*clear) (void); @@ -1544,6 +1578,7 @@ static const struct clear_entry filter_clear[] = { { "duplicate-data", filter_clear_duplicate }, { "discoverable", filter_clear_discoverable }, { "pattern", filter_clear_pattern }, + { "auto-connect", filter_auto_connect }, {} }; @@ -3219,6 +3254,9 @@ static const struct bt_shell_menu scan_menu = { { "pattern", "[value]", cmd_scan_filter_pattern, "Set/Get pattern filter", NULL }, + { "auto-connect", "[on/off]", cmd_scan_filter_auto_connect, + "Set/Get auto-connect filter", + NULL }, { "clear", "[uuids/rssi/pathloss/transport/duplicate-data/discoverable/pattern]", cmd_scan_filter_clear, From patchwork Thu May 22 17:29:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Augusto von Dentz X-Patchwork-Id: 891776 Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com [209.85.221.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37C4B199230 for ; Thu, 22 May 2025 17:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747935002; cv=none; b=Tf8LaMu9ttvf78Me0E0muB31kYQ3t8pbWqy0i2aLIMeEWwDDGTIc0pNrzCi9H7+ciP7ylAD7zDvza0gI64QAOEDjqstkSXSsbjVZIgDoiK4PjEtATz6Ql0nNN9WXqldNNh4s9yuWj4MXwG/Xp5VV5qqzU0QvvwS1F652wYVVNa8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747935002; c=relaxed/simple; bh=V9moyCEvcreBrmKtmYS+DmumWNR2WbQ6dAJHdwX3Rp4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PIRhtl3SNwKNolmwkCOfHlGsgu1xhxz6/aBwcl8Oj+3ryuKwwIXb6ULh6QPzSY/ZwWnmnlz6XIHWajDVXQv8Ux6sRnY1CyaDiAdm/ew1IJCYTY+C4fwfgI/5lf3LwyhF5MtNdHlwdI7Ynga0GdZSK6aHNIO5DIbehz7aMJZLPs8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gbmLA0Mg; arc=none smtp.client-ip=209.85.221.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gbmLA0Mg" Received: by mail-vk1-f182.google.com with SMTP id 71dfb90a1353d-52934f4fb23so5497466e0c.1 for ; Thu, 22 May 2025 10:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747934999; x=1748539799; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=9m4+0OIIskS7vHvSoBI6wzMv5zKIWeD/uVc6SDRQhLc=; b=gbmLA0MgSXzAqMQCPp5iNauIVVJKC3XxvdJJwnfX+5TRWFaF+gsQMR0rrYr2KXIRIP ZOyri0RKYWcrCWwBoWVLYGaq2SghphC89zQx4S97BQwwAbfDED3s/1kWaZGtik69ftGn A+BMxm9hHgDioT65kcWexfkVnpNobtr53SjwJpTxm4To///t41c0fzpZCabxMzCxGGQa PKhtWR47vrZquGZ5iWJzfUeWfHIg8FjPs74bDGxmuX3M2y+FJCXdMS64S/8amR+v451e DctVc0y/Ew1oFKVaRHG8ijs4J8eSXlkOCxQbB3OiclnHVAtauSI2XZiMq8vQwUZHdL2B VsDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747934999; x=1748539799; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9m4+0OIIskS7vHvSoBI6wzMv5zKIWeD/uVc6SDRQhLc=; b=AuJVILFT9NvkptiUiW6dWQx05tPibtak7dIGnX7xYzydUhD1gtTw6keToc3o+jMmUl +mLwuC1aj2jVW4L/GrzrtbvHeHRSgUJwDtbm+PD8xly/OaX1j6utxMXjke6RuVaYJXeL otMjvmvF1a7PeBobu+f/tY9KbcSvGdPLWkn3LB5XhwyylAJrctERLjHI6hZej2WIyFPz HgMCVobJxH6dKIrKoA0yQTrVSEyrtKRkFtm0c7o2Ej4nTcW7zJ0pimoowdIPuHEYrjxq tDtWnmMN1UOMgDfp8qeWGzWXEkXaDNDQWVd8H/WPS99rlwacpkX6wmVxlF5pq5reg6Nu QiXg== X-Gm-Message-State: AOJu0YyH3IXQ1kfUsY0vRtHhGFg4dX3SKY77i4GedCc3w0BgZhYLWuEt cz3oa8J6SQ6bAlWreiDlV3GkN1cyROdR2qpFK2eVSwyx2wha3MTjxcGueQt6kGOM X-Gm-Gg: ASbGnctRCiM8X1EjfgTdfRWEV96l694qbB9O6omoGaDDghQTfDTlrC8s9OY95eUhATT ATcgog4K+moXFrHV22AJNVauIa20/WDeARdt4aSvxZmAeBMu0+neai1C4Y0FWdq8Upzf+mWFc1y xGnTilUHpcdGmqRq6h1cNBAlrvjDMD3xJCXwOupr7h6+nHj5Xy25eVQTiIIDN/TnFlu1hPydiWE yUyeN940cpI/iWk+LniqTI48zQ8WvRbXi1OCcDmG1km+bJAhS0Fr7JAesERSLH0mq10bffo1JlW ItbK8uc/wOunIaIcUDGvyEczFGZUn9LL6ORiaqSreleNdNfmfR5kgB067TCgL9K2WkY6N5ZofzP nrhDhhmNdCKsDCj8607HK X-Google-Smtp-Source: AGHT+IGF7OHmMFMutc7g0hXmE7L2SER26MRxuq5x4Kn7ESipmnKAMMvOC3DS/mgWZNu7wHtzhh9puw== X-Received: by 2002:a05:6122:46a7:b0:523:dd87:fe95 with SMTP id 71dfb90a1353d-52dba928373mr25711335e0c.9.1747934999444; Thu, 22 May 2025 10:29:59 -0700 (PDT) Received: from lvondent-mobl5.. (syn-050-089-067-214.res.spectrum.com. [50.89.67.214]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-52dba91076esm12220321e0c.3.2025.05.22.10.29.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 May 2025 10:29:58 -0700 (PDT) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH BlueZ v1 4/4] bluetoothctl-scan: Add documentation for auto-connect command Date: Thu, 22 May 2025 13:29:52 -0400 Message-ID: <20250522172952.3312270-4-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250522172952.3312270-1-luiz.dentz@gmail.com> References: <20250522172952.3312270-1-luiz.dentz@gmail.com> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Luiz Augusto von Dentz This adds documentation for auto-connect command. --- client/bluetoothctl-scan.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/client/bluetoothctl-scan.rst b/client/bluetoothctl-scan.rst index b4b8315926a2..cee255131622 100644 --- a/client/bluetoothctl-scan.rst +++ b/client/bluetoothctl-scan.rst @@ -122,6 +122,16 @@ When set, it disregards device discoverable flags. :Usage: **> pattern [value]** +auto-connect +------------ + +Set/Get auto-connect filter. + +Connect to discovered devices automatically if pattern filter has been set and +it matches the device address or name and the device is connectable. + +:Usage: **> auto-connect [on/off]** + clear -----