From patchwork Sat May 24 17:47:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892721 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC6B01AAA2F; Sat, 24 May 2025 17:47:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108851; cv=none; b=T7Lxwvg4lssA+BVjJYbrzJfQWMWZ0J5bwfCXiBlTPrzF/XikTYIM4dVecUzFCYk1EpYTenefyoxNi3WgV1BF+zb22TPBcjMUBSH0miMC4+KrFOfCD3Aih8g7GobYSig09MaggoGDspsCXDJaaOpIjDsHWmEu6biTDcFMCWMPlFk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108851; c=relaxed/simple; bh=NhBkhbd6Jx1E/IsoUCmL2IYd5aSujjB3D21WKaqMGwM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HsTPonRsQvlk2mIEudyjFO0RhA4fgiQGjGEVMApJemNv5Ytrwv4T5bwKlC9sUR+0/7KId4FxzdxSSJR2HYRxyGdbhNYFd+ch/TnbWH0v5dzotDiSqxDjsJmH3ZEbUUHNon9zs7Bo+Rg3zvq6DwJF/PnlvF3n2HcnygJjH92YGew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RTpNv3Oe; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RTpNv3Oe" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ad55ded6e84so27213966b.1; Sat, 24 May 2025 10:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108848; x=1748713648; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u+B8SXb+B8sy5Xky/hco7BeIXUH9k3KLsimAeMLmsIs=; b=RTpNv3OeobDGdqvSivG0TPp/AEUXRS49+VJyRRDEq+z4K/5GY4Df+FHcZcx1dbuHB5 Oe9RQne41JBnoWSWcUaZnLMnjDjnd2Ey7MalSmp1NrjW2KokqFT1hj84ngqAzBReuMIa AqPLewBe5N5S9+Fa+Skr47Q62mrBitMyc+l3UuL3LFFK12TIeUWrEZPrqtpSzU2E37Z4 Nd+IzSpEUWm1HLPnmELYFJM52XoREP90rCFTBvv1Bud4UR8MxRzLdMndvxEMpuhBG+pE 9r7jHSSaI11XhPFhFk/lQZJZWdzq/kNAhvtZP4iyHn5IvN45xXf/lvnX6GyzOzEzHc0/ 0iAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108848; x=1748713648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u+B8SXb+B8sy5Xky/hco7BeIXUH9k3KLsimAeMLmsIs=; b=qMoKRy+NkJFlENjGMFi+qUJ9a5D7GduwqwBmgpIGxpDCJTDrlmmzZ73pR15Y5knNb9 NbPR2gcHJgnf4+BjAnEV8fjp6Y74Ugtgtg3MIBdMyZFYLmVRjbtIcKn/j0X2b+3PAW9v /BSei5Tzl26Ivbh53fmEQzU5EtkforAyN3KFP6KZ7MYX3932vuVw/g3Z39VIFpFLrbgj Fe6UlpYj1t1UIjS9Fi7M7go2nAC8a+5D4Co/AHerZ6OsvTiW+W6+xwDHyh/xAHqT3P0m oEe1RZ+UxYsPntiNrf3E0IvXFGbIfLU8A4xpo66ZWUoMjYy6j/MWMJxyM/zhy0tcfnSg DUMQ== X-Forwarded-Encrypted: i=1; AJvYcCVDkvVamRKOVldGrOaIXGAQO0DbsLi7dyWD6o4Qj8w2vo7yzCDvVnyEUkaasIy/O7/tBrxRDlEGSax4@vger.kernel.org, AJvYcCWCtJIb9AHP28281UBvTVZyZ4eLjGzJgbi8RCNGo1vHMs9gxV6+KB3T+Hjal6WDStbUYk608kzLytt7Dg==@vger.kernel.org X-Gm-Message-State: AOJu0YyIWl2YtJX4SbYaob/nQEXthFuYlYZtoqL/TYaW5wvqMLfyXIcz PRt78EtScGOey/H2pGxUN4lDXdJQgttfPYuHkGszq1hEfe94UaubSKzUN0qCgw== X-Gm-Gg: ASbGncv8mg4D+jWehhAfuaw8WVW1qGpp/ilI9PRDyXw3HPykiDS7uWaRvf/1DRPyKDX cP3yhv1wOvkgo7WGb4ixuqITnnZlSkIP6XxdxBoG6XJ4bQx9cy/v2OKYQ7rb/vVENDlwVoT3F4v +cxTc0D/9Z2gO5eyqlV4vCE8vsZaFpvCsfws+6X2aYK+KAuoMT2rEGO2O9/R/nxOHpdq4D9Zy1s ggg6I7pFkq+x7l9vF1n+4FZtLWVZB0FJuun8rQ6TrXxd+VzZf2/gLjK7lVp9ZceGY+qztoyopHa 01vmCJGNUG1PsKl8SQXx4vt3ZIP5ufpGNnEc2L+yl0bepy6lWFofdvbpfGWAdj79KA== X-Google-Smtp-Source: AGHT+IHBa02mxNXKHlSILIA6BZRqpsrCzJbbD9gGhOYzSSZIECNdcg8PHFkqbP+bRmIDAfhKgNEBkw== X-Received: by 2002:a05:6402:2743:b0:602:14f8:9a10 with SMTP id 4fb4d7f45d1cf-602dabc4fd8mr1052135a12.9.1748108848014; Sat, 24 May 2025 10:47:28 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:27 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 01/11] HID: universal-pidff: Fix missing blank lines Date: Sat, 24 May 2025 19:47:14 +0200 Message-ID: <20250524174724.1379440-2-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes errors from checkpatch script Signed-off-by: Tomasz Pakuła --- drivers/hid/hid-universal-pidff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-universal-pidff.c b/drivers/hid/hid-universal-pidff.c index 001a0f5efb9d..dad6c5a6e2df 100644 --- a/drivers/hid/hid-universal-pidff.c +++ b/drivers/hid/hid-universal-pidff.c @@ -57,6 +57,7 @@ static int universal_pidff_probe(struct hid_device *hdev, const struct hid_device_id *id) { int i, error; + error = hid_parse(hdev); if (error) { hid_err(hdev, "HID parse failed\n"); @@ -91,8 +92,8 @@ static int universal_pidff_probe(struct hid_device *hdev, /* Check if HID_PID support is enabled */ int (*init_function)(struct hid_device *, u32); - init_function = hid_pidff_init_with_quirks; + init_function = hid_pidff_init_with_quirks; if (!init_function) { hid_warn(hdev, "HID_PID support not enabled!\n"); return 0; From patchwork Sat May 24 17:47:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892444 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB2FE1B043E; Sat, 24 May 2025 17:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108852; cv=none; b=JXdzv8zkVLqyPlhFicv6Ld9mW155UzgtE+MLnj1PqScHG67M8URq8pX5N+QVl6AWxLs2g2kQ+/7iWg2vTN4Wwjj3rTO6/YOhWlIaUz0vQkk6vgtze5IraccKD5IiPoi4eLP5lxtZRGtHCXJHHKAPFg+80eHkqa5S4FNNjw6hgJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108852; c=relaxed/simple; bh=q7smeA6/r4PWEKs067Q26OKyLMJglVnlffBS/cN5+Es=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Cn/GRYqTMEHpuuIokN1zXIwV+kBV+XizjkYD4XSZO0qKVHeEwSZqBLa8aKwaxPhLQyn5+az65RK/n3/684AWDbWGvKfJNk0qI5w803XFtMZCtV6MVVizf/Jz2UaeA1/dl4LPizvyNemtH/yrvGiQIMctRMBdZcTdhML1XkMz2Qo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HDm//bAL; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HDm//bAL" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-60169001e0cso133337a12.2; Sat, 24 May 2025 10:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108849; x=1748713649; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j76gckhvXinrW9VV0Ck2UDRzltEJE3k9ikLRQ/KXetA=; b=HDm//bALwl/Io0gJVgQ6Olw/4SKUY7W7+z19JWGgBhLLv1hSSE8MBI4OwP2o81NgZ8 eRv7mAnj6k7TgZnV6ii1deDSnUxYDBUBXU5cPP/va9SMedJMLvz5cJDyIT7jwV8f4tfl sZTJwz59Aw+kXfEyWOW2rTB4tK+pHQQGKaZ8UUQptUa7ckqlHSF5VcQxX7Z3XFXABmwo n91UC/ySIekyd0sFv5qlNoDOz1wU9KFP56ZcUjhHR9bwM6Rp5IeKluKMF84vxdUIlkE9 k3kFGbKFJHNoMCL0N7VaB4OUieDbtF6JL3B26/t+cveAAPMMMH/hWk2LNM7iuv6USXgd l7mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108849; x=1748713649; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j76gckhvXinrW9VV0Ck2UDRzltEJE3k9ikLRQ/KXetA=; b=QVaVE0Qc7Upwr8zCmpe0LTBIFWr3rRrdo/3lnXlHeauHhgU6H+H3yqIHY5XUsHpXIj Y65/ZVV3moq1e7ney0vTTtS7+hl9UYBPPtZHcCebo4V6nYrdFelcC4Nr76OGmObr3OuZ 8ILTV55KyMWSXdUjZ+tg3eD7tFXoq/SJY/UAyNylFtxc4W1etXHTk9amhFgXFdT2/Aup Geg2dSxASGGuysH5xgKhVRkjZfkSBhMAUnDjo6tHtgD9Et2txE7ouwdcrbRCgavAAuJ/ yt2HythJIynKxwBicnP1IVc8aKb7rj4F42Zn0vCjo8FqB2XmpCa5UY+lbRJOSoU1Vx3T JPPg== X-Forwarded-Encrypted: i=1; AJvYcCUjv3n587kiG08HF+BEc5eaPrN3Sa/H99BR+KiYMCaBKsXwf0VLZxvgifRyO1QPd0Z4kmGnIxtTbWNZ@vger.kernel.org, AJvYcCWsnI6CRPa+0Icfb/olthNOADZnsZYeMJw8ELapvUzo4mTL0N/uCVT4eNt54W621vcDHEtjz02/bhdDig==@vger.kernel.org X-Gm-Message-State: AOJu0YxbXZsWPsVd4KrJV0Z1vMm9w2fS2hbY1LyaS1oJwTH8417Y+Pft z//DnAbBqzinEkfYRdfrodrRwYxFy0hqbrKV560j8GnrZCFk3s2tLftjhzzU9A== X-Gm-Gg: ASbGncuwOAHHW6RToOe1O95ahcUIdxTbq+n7OU4VBlrfoQ5+3KpJv0gNAE/wzHmEz8E CfKmpJok0mA/G1WP+6BBeWH+SlFfYdOwLKdAXv+gpqZN8+KLwU/DU9qbzbIeUc8xtPvDH7QJGPt OUHDfHEwzFclENgoPoskk+qhAwLXna9IB7BYpv/RZtaOg3XW+BkebK31eCmoKUiIHtYjitXZjnQ P2tasPbetOH4X+yIbEtRP+bdegVELs73xBc1k5xEmCljHx7BLIafk97m0E6JKEZNuoiTnPP72S7 r+EKo0prirptfKm46IQaVOoGpIWNltmYMrsBTXO4tR2qWALaxXPNGYB4h/hRIlr89knse1bBuhe 9 X-Google-Smtp-Source: AGHT+IErSeHhiprcbAvBQsuCOBz0UT/SEe4afsi/ZIa8YSoKGwJ8yaF0qqcIgcbRr9fQCancPO9xhw== X-Received: by 2002:a05:6402:34d6:b0:5f8:e24b:c8c1 with SMTP id 4fb4d7f45d1cf-602da4fd0c3mr1040224a12.9.1748108848962; Sat, 24 May 2025 10:47:28 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:28 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 02/11] HID: hid-ids.h: Fix LITE_STAR_GT987 device id define Date: Sat, 24 May 2025 19:47:15 +0200 Message-ID: <20250524174724.1379440-3-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The name was missing "ID" part Signed-off-by: Tomasz Pakuła --- drivers/hid/hid-ids.h | 2 +- drivers/hid/hid-universal-pidff.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 1062731315a2..5c75c09c5780 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -841,7 +841,7 @@ #define USB_DEVICE_ID_PXN_V12 0x1212 #define USB_DEVICE_ID_PXN_V12_LITE 0x1112 #define USB_DEVICE_ID_PXN_V12_LITE_2 0x1211 -#define USB_DEVICE_LITE_STAR_GT987_FF 0x2141 +#define USB_DEVICE_ID_LITE_STAR_GT987 0x2141 #define USB_VENDOR_ID_LOGITECH 0x046d #define USB_DEVICE_ID_LOGITECH_Z_10_SPK 0x0a07 diff --git a/drivers/hid/hid-universal-pidff.c b/drivers/hid/hid-universal-pidff.c index dad6c5a6e2df..554a6559aeb7 100644 --- a/drivers/hid/hid-universal-pidff.c +++ b/drivers/hid/hid-universal-pidff.c @@ -178,7 +178,7 @@ static const struct hid_device_id universal_pidff_devices[] = { .driver_data = HID_PIDFF_QUIRK_PERIODIC_SINE_ONLY }, { HID_USB_DEVICE(USB_VENDOR_ID_LITE_STAR, USB_DEVICE_ID_PXN_V12_LITE_2), .driver_data = HID_PIDFF_QUIRK_PERIODIC_SINE_ONLY }, - { HID_USB_DEVICE(USB_VENDOR_ID_LITE_STAR, USB_DEVICE_LITE_STAR_GT987_FF), + { HID_USB_DEVICE(USB_VENDOR_ID_LITE_STAR, USB_DEVICE_ID_LITE_STAR_GT987), .driver_data = HID_PIDFF_QUIRK_PERIODIC_SINE_ONLY }, { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_INVICTA) }, { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_FORTE) }, From patchwork Sat May 24 17:47:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892720 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8D1F1F0E20; Sat, 24 May 2025 17:47:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108854; cv=none; b=grt2Ei2tKp2t0jx/YVVCZwvdgbAZObzJmg4cOeRYcMIsGNvWmNs5XzSj9/vK/ave/lamI/ehhdnFrAAxtAR1pMwoKFnZ/mIt1YseWNbI3sxZhoWNiDm+6FdtEleAlKheNu20JFiWlr83R92yulSE4vaeB1tLHDqnamHJ84FFA5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108854; c=relaxed/simple; bh=MbDkQEfeDnF/QckM9qsGWZG70NmMoHW9yiS/9RkPAvU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZHJ28XvHraScFWsjeX8F0KVaKjGpP88i2gm5ZXI9iZWSdZ1shlCPd6ZBccwLL30V1aPeQRWY+imzBqLQluY7E4563YBsBrmt07QJ5BHeXpjDqpq7LT4NQibv+UUApbhpsFxjc5FljV4iHGgeMn4ZqtZGfk57bOfohHcVZwEjMm0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C4aQHu3w; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C4aQHu3w" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5fb55d8671dso161499a12.3; Sat, 24 May 2025 10:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108850; x=1748713650; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EneHRzgAB0PIdlA41lyuKTVYUMWqkGFRPPWOHMxE/4w=; b=C4aQHu3wWxCzEcE26hQS5YYaFcQL1x7dCB+gT8hdhrVuUWwAtWyKg9sAc436ENn913 6xTDx1UEpI4asPtkycaSzwINKlAHTlrA7eMDYoxXSb8WWcA4oekVmUw+NhYECV1jW/Of umeMstMs9VMWaa2PqsphmoZ5iw2yA8CG/kjXXQZjc0sWQbm75LSp2JHIeg5nAQgUEbrc Gq+oz9l7Vbh/K4E0eWfZgCi5BJ3V/IFTSMlxNSs422qnum12G39sXFeW9939kr+t5Ggw o95HHRbaPqdpvYzhMjFGunUSOQe/72ZF7dfeOSHq3GJGmY6JQZpp8UQvD8D1Y+/Rb4J6 Sr+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108850; x=1748713650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EneHRzgAB0PIdlA41lyuKTVYUMWqkGFRPPWOHMxE/4w=; b=Q/CwT9hY6x8q2ZOOoF0i1cKuLQaw/x/bHSdkaHNWBDbZT6d8zWqAGrMMU6GBcG0Kds mBe586V4hQfBt6NTnWNz5LPBc3Tl+l7nZxufDFvxfcm1XnDiKIX4hRC2ehhl4M0nOTrj NnK7WLoCDy7ViJL5an3+LsF9NfT+5synmmBfeFPa7PCFOibJ0UjfVR4PHSUjrud/1IlP QUQXwFG4bLmfm6UYmgHkTJxxl1ELb4QIc6FdMfn1Y5ig6ENwFja2CisD1mGKgZpvjHDr gpULGWyfc4oD0G7e+RjtjQ2a1zWM6W8m5TXqtn4co0xekVi7Jh3W9yQ7UrIdrfPXFQHl 3d4g== X-Forwarded-Encrypted: i=1; AJvYcCVoeDobd8vylh5Y39WJ1nMJs9872t77RWYdmEpHpBrvx3VjWMXs1rr88cgNX1sb/OfD8IgXKc0czmBz@vger.kernel.org, AJvYcCXo96MsziuRSkPZNIiIKObn1BNf2Kt8tnwDbhmyotDzrkWMU8ebBMyq1DjPKlnT0zyvokD0psTSDrNJWA==@vger.kernel.org X-Gm-Message-State: AOJu0Yw2a4pSi/g3C25dADPLoaPiwubBH+H0IJkImoXy6okubMOHSSfi 9pI27kk3/TUEJWnKFqAgCqmZH8oLfHg7+5EL1rg2zwBiicrqQU9VUlvj X-Gm-Gg: ASbGncs4oV9Aqtz/c6cD8seauhacX4P6/uAfWxhHiiTpmUII8J5WxxsRLYcQexthuNa VeIYNgxCJEzoUriQn4o5WS/OOwTvmAU42I/3asfMFZxFeh5WnSuAyU1pJpnUzkAaewzrCheIdyd lQKLmklYWEcs9yqoGct+E6SZVrsQCDcRM9WrZcUY8h6TKos9YziNRc881hwePpMvDhRTCiMH2Z6 0/LvGmwXpX0xrTXp6amrNTP36eO/VshOUTy/dw+CKFM7jWdLlmlSiTF3t6GEU8GPT1NBhqOEoAe TH8YBKvZJA2q3MtH1HwDldZiA8+/nZI9BnCvRDvQbg9hcYnppFWowPHdOKkSxuECm79WJOYiCgi 8 X-Google-Smtp-Source: AGHT+IHrM16dUKZKHqjXf6jOFuaz8P7OPA80LYQiSO9hm7y7BYSGECXlDWOEdBODs1hYijl6JZk15g== X-Received: by 2002:a05:6402:3592:b0:601:f92e:70b with SMTP id 4fb4d7f45d1cf-602dafc0f1fmr1097042a12.9.1748108849901; Sat, 24 May 2025 10:47:29 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:29 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 03/11] HID: hid-pidff.h: Fix comment styling Date: Sat, 24 May 2025 19:47:16 +0200 Message-ID: <20250524174724.1379440-4-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes checkpatch.pl warnings Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.h b/drivers/hid/usbhid/hid-pidff.h index dda571e0a5bd..a53a8b436baa 100644 --- a/drivers/hid/usbhid/hid-pidff.h +++ b/drivers/hid/usbhid/hid-pidff.h @@ -9,8 +9,7 @@ /* Delay field (0xA7) missing. Skip it during set effect report upload */ #define HID_PIDFF_QUIRK_MISSING_DELAY BIT(0) -/* Missing Paramter block offset (0x23). Skip it during SET_CONDITION - report upload */ +/* Missing Paramter block offset (0x23). Skip it during SET_CONDITION upload */ #define HID_PIDFF_QUIRK_MISSING_PBO BIT(1) /* Initialise device control field even if logical_minimum != 1 */ From patchwork Sat May 24 17:47:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892443 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8CC71F09BD; Sat, 24 May 2025 17:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108855; cv=none; b=sWlopS1+rZn9e98mshgZL1KEoFqbFZk9p24Hjhx9HjEEhM4g+9hH3dVHmFXvwJ+G/+eEL0xhAKJb6Fo76MgAbzx/cXL6f+WCL5i15zQ+TssnMwXOpbAV+3pvKHM2h8ISU7GJa3RSeobpQVNcc2y9xkmdpLxq0qbtNEGdAMX7kGE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108855; c=relaxed/simple; bh=8zV2Zz38Klb5MFeLBdrn5DHAzPRNSVUba4ee/qaxcto=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bo5LKwBy98IIKpcitaPnJCVyTWYs1rVHwYd7BR+ppgHDjBazbtQpJk3PXNCCyrjkPjghxuWKUS+LL01ppfglZykcCUFUVEDzbhiTJlsH01NsUejQTgVnsCk9AN4QWKYetSb1GTIr4RAe8CicxR35Z01lZKsetD/fWTPQ6oUMgps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dtEdiDOc; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dtEdiDOc" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-6041b38c94aso67194a12.0; Sat, 24 May 2025 10:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108851; x=1748713651; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LE2pVpuHLxjaHNVGuCXTpw5e/6sQrWu/pWCwQjCGC5c=; b=dtEdiDOckII2V6yx9PM6GSykqg3d/3q6XYOk5HWVVHFl5yf9xUyaUIQwqe0lcBUjzq LTYH/RzvyITmFqSE7AJ6nIqk1tXniqmp2PlX92eVGyRI23JD0c0BSBnCxaGEMTI4w8oA TZbCO3AAJUpIcHmk95smn7jztZ33gYBZ8g7Fj2fjeqGga8XejXEeT3jP3QtnucCK6tTZ +DDegeFNW8lHfNTFzOPY/lyXpXVC+a/J+3qDdcaI/YjOQ1YHYiE/KXQvIMvqwxNJoECz zUpQaAlwjsUF6DoWj1R1RRvl4YkCpXIW518nbUSkEGmk9mTYw0dnhKaRKPA+ny3kBOym i2PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108851; x=1748713651; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LE2pVpuHLxjaHNVGuCXTpw5e/6sQrWu/pWCwQjCGC5c=; b=ZVarOXBX3s7AqYqNCaGNvbzt14oSoOwJO77kqMtQ8jaRV2hY5m88a4rNlTmYa7zw9d wSJfQH/LLmjLIgwAxG7yA/vUjPIvdVtPgJmG/bfKtY/xgMh1vPy4NWuuGv0d8fiu8eWE KUoHsFHmW406g2f9m1EhmiS/D/rGi1vgoA1mF29lDaNoOHK9CMMCiA8goPVcE3HZFxhd ZURg72nI9AjDPzacz0d8LQmiH7/vaPdBlkL0ZPjC/BfhPIbVgtXxTd/X009na3WuHhs3 R3bHhCC01c0Q5Loze2zO+GYS9id4WliNf0rO3odRND+Eqd15p8L0SoiZ8UGKcFAz3+Ez zRag== X-Forwarded-Encrypted: i=1; AJvYcCXT+pEJcNDflr7htb1ZdAWvpnzUxLM54sy2RyknEDVwyimObdEOZNNzi4ZBlY6+sQGbLXbfqSaJ3B/zhQ==@vger.kernel.org, AJvYcCXoPQs8iOu3SIiIFjvs0p1Yfl/hAXvzi9ejrJrACCaApS1P9U5nsqitIktxqVU2MG/1FSRWUtXAwPT5@vger.kernel.org X-Gm-Message-State: AOJu0Yy1Zb2H5j1856sqGgj25Cq6lSMqCPCbCVIM6EWm4Ng67P1k1BbB t7DgMpYlhUudBoKObrwzktV04EFrSdPr4JCxKHNS/OU9Gf+kUBFiZDe7 X-Gm-Gg: ASbGnctxVNz2KXefOGNrmFpZQv3m0d9QMfhhWqCv3vD9rioQPDEvCF8R9HWA7nghDwP 5L3j96rhgEzTVd5gPqcS2m+9WMC6uuCCC1qfsh5OF8sKO9oUnFZ9Mk1panGg0cLkSIyoF6mIHZR 4jUSsRRokWiRgUjCkYwsAIvYFKlaJkcURuT5T/4ZiBITUpsxt7tpfBi/xthTXvLpbKqmdXqqQnE zeQR7FPecLEQNc6blLY/onPBc+6/A5HVMFqaQstIbZ0B2nBWY/psHO5J+x8LmIe2lTsuKVvUkdJ pGlkkVPWp5SNymAGWUju/91mXoUrC/8jciZ3Nz/nBpKe49tkYcxZGsfRONRWa3No7qfAzpidS8F P X-Google-Smtp-Source: AGHT+IER32neNIQnu4ymwLiWZkefU2hS2HcLHAH7jWfX7exDg5CYFWg8TX2TN/91xD2vXPTNQSbH6Q== X-Received: by 2002:a05:6402:27c7:b0:5ff:9994:92d3 with SMTP id 4fb4d7f45d1cf-602d9cfb00fmr1039090a12.2.1748108850977; Sat, 24 May 2025 10:47:30 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:30 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 04/11] HID: pidff: Fix missing blank lines after declarations Date: Sat, 24 May 2025 19:47:17 +0200 Message-ID: <20250524174724.1379440-5-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes chackpatch.pl warnings Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 8dfd2c554a27..3c2b20cf7853 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -241,8 +241,8 @@ static u32 pidff_rescale_time(u16 time, struct hid_field *field) { u32 scaled_time = time; int exponent = field->unit_exponent; - pr_debug("time field exponent: %d\n", exponent); + pr_debug("time field exponent: %d\n", exponent); for (;exponent < FF_TIME_EXPONENT; exponent++) scaled_time *= 10; for (;exponent > FF_TIME_EXPONENT; exponent--) @@ -332,6 +332,7 @@ static int pidff_needs_set_envelope(struct ff_envelope *envelope, struct ff_envelope *old) { bool needs_new_envelope; + needs_new_envelope = envelope->attack_level != 0 || envelope->fade_level != 0 || envelope->attack_length != 0 || @@ -715,6 +716,7 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n) static int pidff_playback(struct input_dev *dev, int effect_id, int value) { struct pidff_device *pidff = dev->ff->private; + pidff_playback_pid(pidff, pidff->pid_id[effect_id], value); return 0; } @@ -1207,6 +1209,7 @@ static int pidff_find_effects(struct pidff_device *pidff, for (i = 0; i < sizeof(pidff_effect_types); i++) { int pidff_type = pidff->type_id[i]; + if (pidff->set_effect_type->usage[pidff_type].hid != pidff->create_new_effect_type->usage[pidff_type].hid) { hid_err(pidff->hid, From patchwork Sat May 24 17:47:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892719 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C67551F12EF; Sat, 24 May 2025 17:47:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108855; cv=none; b=LoJ/6eEy8q0Ux1lce33u5w0pkdNYbaTf1Q3gU3Fdn3Yvst/xnYXz8D3wfzccpM5N+x0dFhqlfqz7vyuiWP2ywWJCY7K4ebYxhigvo2WUnTrYh4nNfJIwbSe3HP+Y+ORYXKh7hYPe2we8o6WsFdAnXYVr8PVWvsAEMU8qINVKfTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108855; c=relaxed/simple; bh=zy8rXkQR/12XJIv/cyUeyxPTECu7UTXOB4DMs/lKhVk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hnqa12OIpOvLm+OrKSSIAdoiH0nfZxR5G85dQg1ijdL+pql1MIJEGzME34t2uD7bbr7thixqAW73PSfhsThtdxY7icYmR+6iC5EiQfArVo0hRbH/BcbVRSz7omyOvffMEZvhFWfTZ6KhguN4zF135wgt+8XzpEn/pfoGXOKEyiI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y4rQGyeb; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y4rQGyeb" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6024302aa2bso59700a12.0; Sat, 24 May 2025 10:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108852; x=1748713652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HcKgn3xaxIsFlAalN0V77zP4gMDiiYFlSgkF4QoAeSU=; b=Y4rQGyebkRGPwRpBKyWdz+u3MdDjIFJ9dDAO6mWUwcbgg7umT3RY/zRtJ59T3KmqlP WcawPcGJc8d8BN28QTHkZNf6rN+ndKslnsUna/mI/hkBi0+0VZ7oTbGng2wOdmvddWCk 3cAIgXs7NVa6wVE3XFHDH3bgNIySz62HxnjTnygLLw51tpWuviWvIEn/SGoRHfLvBB4F Lf9n3O5E6uqqRtDRMzy9qXL9wTNzEsMCQ9YyG+4RL8y+IOQp9L5AWa/yAr1uBQPbsYV9 0/2TI3sznHcA6lA4FtyWrL8LETKDNr+JNqyms15s4FDh1m73MQpBDoda3dsAjg7ApG/g D8dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108852; x=1748713652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HcKgn3xaxIsFlAalN0V77zP4gMDiiYFlSgkF4QoAeSU=; b=EWAGk0haiqbiPUommJI8kl1ucEPGbI0csCsz/ojtIFXAtk6Ge/LOpyLx9e9qulnsAd z0Z89r0S5MiDObhL5w3wyIw2EGwAyQZ6aTt0ojEH5CJdetEK8CNn+lvsjMc0F9V8TOS9 o5arIwrw5LyWHIOwkF3w52X4OVBNX+GwctIxzApFtlHuDcghwrV8NGPtAwDH48PftdI4 NyFHBcmASykAO9bZJIYP6sdk72eGrFJteYO1nPs3KJ1F0SF+rfR0bcJYVZ9k6EODjNlD tl6ZV2Ef0EWBWJ6xHAPiVcwKTGWd/NGC3Nk8PWJJTE8bjd1mzw70RB8Y7bRQ6t7mbBU8 d/Hw== X-Forwarded-Encrypted: i=1; AJvYcCUvhJHc/nyLbWj/6yGhQa2xMutkOPUWYGBsrod3G/G0RBHrKR9o0OYgMH9t2tR6HnCYiNrgs6XBEaJbrg==@vger.kernel.org, AJvYcCVgxpaL21sga0knknso9Ct9DkadUa6Le3VTyrHEhnA0tl9oW5QPC3RRGW3B6TN4rKLjJWKcwXI1ruoZ@vger.kernel.org X-Gm-Message-State: AOJu0YwLL27MBsxbQAwv7U6851RhjUYOIqIC3aYvvvQFogPSfNuU9bdL dYHXIygkQk2stLxgiH5r993Eldx3E3+09aXWIJur08ZejnGFbUHKi0L/ X-Gm-Gg: ASbGncu0BQYrIKjQNZZnxqmq82sGo5pyYipfh07TAcxz8f1gfmKWgAQgOSs6AS82iq/ 6LSKWDUTuPNP+5dM9Vmr4ZRyatgdP2zNr88UD7KPoI9RjrOavZglFDeR+X/9+xg+231+XIvyhRi ABc9V0qczToQf18TUh0G53OtMDHyQcF6zPqa6PbKBNyJDYU7zn9jWRQSC3pIryf2vp3mWRfUMuM JSfxPgxZdHzVSxHMpsMS8klRdggOgdp2JqOiXpNa8b2zmHR5hYYzm5wEw7s6wiENpt5DoC6kxzS 5+cH/yFUqD6Lw6dERV+88PDsWvz4OhKcKjYD4UnXbWnlLBHfzjquMqogbYRap0+4Zd1NuaZ4jR2 H X-Google-Smtp-Source: AGHT+IHH//BIT5GiUxtdk0bodMEIXn2tMUESaLZ9E88lb5sQnxDSYJz/aQvX8kLUyaK0jJxmlo5SPQ== X-Received: by 2002:a05:6402:26d4:b0:5f9:2a29:543b with SMTP id 4fb4d7f45d1cf-602d9dfccf7mr994423a12.5.1748108851936; Sat, 24 May 2025 10:47:31 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:31 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 05/11] HID: pidff: Remove unneeded debug from pidff_clamp() Date: Sat, 24 May 2025 19:47:18 +0200 Message-ID: <20250524174724.1379440-6-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes chechpatch.pl warning about missing blank line Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 3c2b20cf7853..44cbd2a0461a 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -210,9 +210,7 @@ struct pidff_device { */ static s32 pidff_clamp(s32 i, struct hid_field *field) { - s32 clamped = clamp(i, field->logical_minimum, field->logical_maximum); - pr_debug("clamped from %d to %d", i, clamped); - return clamped; + return (s32)clamp(i, field->logical_minimum, field->logical_maximum); } /* From patchwork Sat May 24 17:47:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892442 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6CBE1F1524; Sat, 24 May 2025 17:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108856; cv=none; b=Va5YKXUrgA6u6jaNiF+p2/2EpmHRVhHZrRnqqObAyS6dFo+lYZVK4SAZo9H0407RnIx9QBZj24oO74wevL+Guz6NOfUU31gYdxzWHRBC7NantvRrZjMiCJP5PeYam+DZnOJLm+7g19I+seFuEPQ7pwmmA/xhqOBf7eWsDh6cFHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108856; c=relaxed/simple; bh=plxgnBC3/TSSTHavnweC+mX7Rx6meyv7logqYNGVEVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=g7qXt4UXVUDMffNIzaPODI7xRwqYjLBgo2gTg80OaQ6R67m2L6snzmv1y1FzaAmOicSyISHPjjWNajbf8WPfQnJHS/8Z8GopaTZ3WP+yM9gHbIJVdkTB36BBZ2E9p0qDfhr3iJBPo0mpMEQ+ccN5/CFWmrVPXtaPnww1bPZ4zGs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OTjSaF9y; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OTjSaF9y" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6041b38c94aso67196a12.0; Sat, 24 May 2025 10:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108853; x=1748713653; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s1jNkw/6MR5i6Cr/2hMjKLeS6l2X7bhc8cyPl4fASrY=; b=OTjSaF9yc34vdoW4Pg7fmsPz1kuLT+Do66m5PDR/wwaWDgg51pG7UZ4voQyOGmpeA+ zR0qR0WR7TTHosllbzvEuCCZsvCzCXTP7zHevhI4csdRMPmIARoRL0zv9cqXJoErQXa7 b4riRMuEkglQSEnBkcAAuXFjVU2kuoxK/QnU9pUPtqmdYb6waWwXzq0YVjLqg6Jdy67W XOFZvsmJjGQV9v7KAK0ST9rhHZS4qOdeDZGFoN6Uh8oy3ruT7Zdhd9ZWwlvsaEmXYzhP GN1EKZta2LN6G/FNIxuQ74E6mVfUTPtALQQ2IRIVQ11hlJjh4et7/g7WERzU0vlaP0QU OrEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108853; x=1748713653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s1jNkw/6MR5i6Cr/2hMjKLeS6l2X7bhc8cyPl4fASrY=; b=TZontHfrggnyH0cogtXHOKVhy5eY19SlOPkYU2/WJU/dXJ80tAbyXCwean25wnhpzk ffITmPMdQUOAvNJWizj4wlzmiU22rBpSp3HGeyr5nMzW/bAJ2E7An0nP5THEFSPYrzOi kIi0HqYSvE+wDLjf6CM8pUwDbGi5HWtQw9+fWkplWk1AwiLOQwrYBYoSikqPCPlszRv9 axuOMapg1nmeQN280UBzKWCWBlAae8Co73oqWcN1+LFTwQ5oQCiQ/6O8HI3dKVC0sai3 nj3eYf9kW23pVqVb6dYJWEAmKb3hNFMT8gJmuVYZcEeOgqj8FI/8vvKBH6DtYX0MeF6E Kw3w== X-Forwarded-Encrypted: i=1; AJvYcCU2soY9yZ2DJxVAgkhwjqRIEVnsBn+uBbn9QHPASO2ZTE93Vm3p+i4RzFlEVls68+j7b0/OWsYrhTuo@vger.kernel.org, AJvYcCXkP3xF1jZIinarthylFweXO+wwE2bI6p8N4qVYLnBcAi2RT3ZegEeszN2DUj0sbvv71IqrgZ3Wo9M4Yg==@vger.kernel.org X-Gm-Message-State: AOJu0YwNoqimk1LYvh88OolHAGsEtdv/vndk/Edl7hx6a+QX7xj+wzQw LKc+sPUZRs2T4PsdqS5VDDkX4oBU78qLrES76xJji6ZrISAJB9mm1vfi X-Gm-Gg: ASbGncuEjzqitAKvUW4WqHVf8rs6sf8qhSvIx9XVZj0mqBVoOP7v1W4dr8lkteoM7lh QksFgqQcC+fEUOzf3e6MermYvq+RUZVSqv2cCOXhOZdQ3ffnNtBl7T/egKseIo62Om6LuECW3l7 71d8wfUyZMmj4NndlQrgDeoYiiPrsP3M0yLLhiV9c2BP0ly2SpIe934W3a/1SlofQtIFjHpycvJ jZB7O/E2fOWqpTD8ktuia1Auch9iv2eqWMnRr+aJBEG1LGx/yvk7R/hIG7zFqVhAlmFbAEtHQGa DXnIUFDksI6Nn6Gxvnxct64YjLBywqx2S/eScOKv21Pf6aB+A/ETE8jhu80NC7yHZQ== X-Google-Smtp-Source: AGHT+IE4W1WB8obcvELVn+wfAIx5Jo4kUWsgTf7DpJX77pKDmtKaACgzTfTL+g1STqrPnix5Pr5LPg== X-Received: by 2002:a05:6402:354f:b0:5f6:c5e3:faa0 with SMTP id 4fb4d7f45d1cf-602db3b4ebdmr1141430a12.10.1748108852944; Sat, 24 May 2025 10:47:32 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:32 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 06/11] HID: pidff: Rework pidff_set_time() to fix warnings Date: Sat, 24 May 2025 19:47:19 +0200 Message-ID: <20250524174724.1379440-7-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes blank line warning from checkpatch.pl script Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 44cbd2a0461a..743b76c8d3b2 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -273,8 +273,8 @@ static void pidff_set_signed(struct pidff_usage *usage, s16 value) static void pidff_set_time(struct pidff_usage *usage, u16 time) { - u32 modified_time = pidff_rescale_time(time, usage->field); - usage->value[0] = pidff_clamp(modified_time, usage->field); + usage->value[0] = pidff_clamp( + pidff_rescale_time(time, usage->field), usage->field); } static void pidff_set_duration(struct pidff_usage *usage, u16 duration) From patchwork Sat May 24 17:47:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892718 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5CC11F1531; Sat, 24 May 2025 17:47:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108857; cv=none; b=Hi87tHWVd/R3FYPQ898mn+osXJsuSKC1kbGKUaeAPC3iaKMhQLyHN66EeBwUo2lr+SSdWMND3D7XxsP5yv9AU2D2gzqlkXt89YJDiUk6D5elDgC9COf6aYn8u7fT1cydWA4o4pGpC2GbBYzgkHDSLa8+iyB54zk45C+eRRFktec= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108857; c=relaxed/simple; bh=XA00716b3IbQMmrio7+7hhHn996r7yrSNjAqtof0Ahk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HPmMD/971fKlNpYJ5JAxsk1hR1rzocAWQz4okTswZIDBVcBfF4Ta5Yi74rNlkw1wD++aq05KpNtIFpm0/KIehme6IHqERn1onbKMgofY7CT83g6xqxVEsMFZUZhih89VcWFg/ooduEsyV7Vshz401wgopu7IK9XFSi1rU18xN0A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TT2qAwIK; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TT2qAwIK" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-602b5b4c125so145295a12.3; Sat, 24 May 2025 10:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108854; x=1748713654; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=38NbTUvn/7tUQHvy0B+5g5JMRHCXE64KvfN7AsXyy6E=; b=TT2qAwIKNY5laV5JHDTDORMDMKAePQ0Y5vvev62FsEkWBaS1AqKww8yl38GX1QXW+A s6igDMvTijhisl5AaC+baT0COh06ARiX6bk/Ng7IRg3IJ06KCwFO9NqNrLrX5TGeKhu0 9+fYl72u/l3LGHs7DNZbn884YVMQVDNNcCJB7EdwoDITRW/ZR2mENKYKRBo9yhVZK9by xNiodQrqgoRMvsSEY4xwHbLFY0FRqOZwL441gx0q0E7Lf+GNobVRB1pZ8e4fiYHSPxh9 a1aIFOLoJkRAi4QEXTYREdQoeq/g0FLeDu3tzToESVA1wuV09N+6NJrosPaqFpwTeM3J 0f6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108854; x=1748713654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=38NbTUvn/7tUQHvy0B+5g5JMRHCXE64KvfN7AsXyy6E=; b=O0D0AI7GCpKk/fPkKm7d7pijMBvSi9yZ3YvKs6Bna8b4nFBDYhArgMtskn/x947UOl Uc5FTMw5Vc6gsHmlXV05PabYuIIgo+vMrc4mFlI0datCjE+Pg7Hk7Hr/jua+uPsWLpYG MdcW2tDAQO9n+ZUeExyC33cYlyXjB8WTGH6E8uMfq12VjaNw3zOt3vauwPHn0BU6N6Um HNm2LcBflTjCKmSuCnYgAR8Kq4OLrZ/z2CH7AoeONg9rjK+P/8snmAKJ4bn2rHbPPXoX BgG1G6ZrWymEjU/3q5q5yLhOoBzDG6o2T9EKxt0wMTkiJ3usNFx15AsCIWM8sgsCAhXo 632A== X-Forwarded-Encrypted: i=1; AJvYcCW4WCCcrw5Se09sRu9CLL/CUOXQ62gD/cfRRIUCla+4vItZ8NDCevNLX34n9v48D4b0TmbFgK0uDk4MUQ==@vger.kernel.org, AJvYcCXp0cNg05sm0SALlAy2UN6/RDPFyaIpDfVtjPC2M3pP4VY2UbCuiDhKnZlZ2wYo6XVr/3YsHDYIM0op@vger.kernel.org X-Gm-Message-State: AOJu0Yyh5clWBpV29GP4H23p6m0pMdOajVB+sfUpgCiE7oZaX9YeTr6J EZZSwlWEfX8X7sljHJcL9WeIQ441uZKOdnmiAqS4KlhTm81pPm7DKVJE X-Gm-Gg: ASbGncuLhU/IdKrDvoURubiMBAeIw1ChGx3S0yjUbrFKVL0UZgr5d+ue1YcGBAG5IcW 9YjewzpGWVgJKReMrQ6XQu4xyIiswu9w2OP42Zb/clC6CIddnrx6zW/IbcbXEXtA88Y1k1U/arb ssysoOkYg+iMfCb/EXt8YcyUjDQFVZ9yT7XEQr7XPSCsGfOCg8IfWkN7P+uX+pQ5YdNmgkf6xIG hNGEtu5DciSFBuV8+kLC94aAtkRz1+EJ1M+w/GMwLM9i59SMrtKbTQYKZGIokIpwSP1AAJglzl/ v6XkvxzLtJc7soTrV9pSUDqp5fIyql9vtfpMRqLuDFBXO56dhvN0cFKDmhlnxu4N3Q== X-Google-Smtp-Source: AGHT+IE+Thktzfk7klZt7hbeaYhyzW8cBFMRxZTuTM6H2Ki+Hnon+VOIuikj9iGA0S0PRECHDnQg/g== X-Received: by 2002:a05:6402:26c6:b0:601:f87b:b6d3 with SMTP id 4fb4d7f45d1cf-602da2fb1afmr1060946a12.6.1748108853872; Sat, 24 May 2025 10:47:33 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:33 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 07/11] HID: pidff: Use __func__ in debugs Date: Sat, 24 May 2025 19:47:20 +0200 Message-ID: <20250524174724.1379440-8-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes checkpatch.pl warnings Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 743b76c8d3b2..88eb832265a4 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -940,7 +940,7 @@ static int pidff_find_fields(struct pidff_usage *usage, const u8 *table, struct hid_report *report, int count, int strict) { if (!report) { - pr_debug("pidff_find_fields, null report\n"); + pr_debug("%s, null report\n", __func__); return -1; } @@ -1069,7 +1069,7 @@ static struct hid_field *pidff_find_special_field(struct hid_report *report, int usage, int enforce_min) { if (!report) { - pr_debug("pidff_find_special_field, null report\n"); + pr_debug("%s, null report\n", __func__); return NULL; } From patchwork Sat May 24 17:47:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892441 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEC8B1F1315; Sat, 24 May 2025 17:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108858; cv=none; b=XvmbcegzY22OaXYX3UEg5O34vkRhBHERDpH/xFQbr894qV/7z/dlZLWblTGgE3hosBFZYidLA+RxNwz8vslFwCE8OKIStGiKKEkwBET05MLGd38Bv9k5jShbxD4HCx8eJqg3SmOO1U5rX0tIm/KrCJU7+rou83kq7n6jjR72BGQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108858; c=relaxed/simple; bh=j1BMQHjcfhSqWMrNSBDGMw3T0MHTY3JcNOw5ASp1Aik=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rMyqv2fnc2HeYcm7AYIPPRJPqeLVxdAsarO7580yz+o2G+kvmer/UAjpgNKLFKVvkIM3uhwEJVvbzEjd8W0j5kqloMPZWL3m5DifN413yR06mifl4XpDyqUm+65k6noVJxDUz48duykLeAjqZ92IeAhN9+ubENM5lgQcPGluxUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aAM7dTER; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aAM7dTER" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-601df382301so116918a12.1; Sat, 24 May 2025 10:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108855; x=1748713655; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WDh+Scz/A/iAtqESiw80/C2QD/zEyqnzP4ky3talhiQ=; b=aAM7dTERy6AbUJkgDB5nUnIiIt1P6ZmPb+N06Gzzmr3IwEdMpN8+/cXIXVfCSMBRDC MfPWkTFQOwNtjBB67OktG55YKQ9MzUGYV1A9QDW60m8QkBIn6wEuOuCzlFYn9+YOG3SZ qiO4qlFSrlu8qPoUT4NW+JLsbBdSNvMyGsQOQsjcwGrqYJImSUW2fDsUmuGr58fshBA8 HTAlQCvz2NlJFfgnuXDYVHG/xZugXDgPPcGQAqOqCGrl+r9GdU6BOQrdZGtLfKqIelWe G1hswPXNV3q+GA6KWxNP7uBOqvprtayRc3BL3Xw7v0k48a8DW0YJwQ1tSpkTEotvty5+ dJow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108855; x=1748713655; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WDh+Scz/A/iAtqESiw80/C2QD/zEyqnzP4ky3talhiQ=; b=A+6s+NcUeD6XxbWwyJhOrj46Mfw7RDJlAgvLKjRv8ecH20PwbRbYh/KFJzBMUZ2jE4 +90nG+N1siJ7PsMczp/g2KZyrMfJ7Rk9lnUq5TTTJUpdtb2peaN2I9W9lKnr6H5mOrLp +Spbfb86nKwNlIQUX695pA4vUd78GKLMtEYm+14U4MRTXG6CmYSX0TCeXTKT6GhVQWtC Z/sSDA7AD4R3FttI+aRKGBEMjn3UiYz7w9Kfb0z3sYnjWDP3l17hcBww3OBCtMlSXAfW 8MlYJodpkCMjlrnDk5c9AKX3q2WHk6nBXNs7MnovHQy5Bv8/MWdS2go3LHu0fFxUEiil v6nw== X-Forwarded-Encrypted: i=1; AJvYcCUuk9MfeKNYhHqYt4wYO+bAIQQOVOTKbGiefHgqrjtGifgEIunJO4vH9wIcvuh2FipBYusCtqNn9Fih@vger.kernel.org, AJvYcCX+b6/1981PeFZVuENzscjqccN4HP/2f1XPUsiETWq7oL7kQSagrjVtYsmsDZS7hwKdLDkUaF1IDia1rA==@vger.kernel.org X-Gm-Message-State: AOJu0YyIoRbFjMP2Z/4tThNdh9p5NGwSXbXPV2Pl9Db20eyPvzLyaqI4 O2/6zh9lERYSo1Ebwz4MZQ/s/7a0wB/MAOcFMP+eCER4ho24N/i1tE7Cj0JESw== X-Gm-Gg: ASbGnctvwdNpiQLV3wxhuXAuLO2clFLkEz8je1QGfWeq8z9WAIa+Ug0mPvv6OD2R9BM O/C5+KhlG2KrzyJA93p/gv5eMsd8pFdpszeSOkKMZb2RuztOu5PpXRvErD9pNVJmHVIFXojFhHQ ZknvaYEauCfdAbPp6eBmG0czgS0Jsw+KIU5cZiZX0aubeRFt0GdaTcgI+FAKqmoTNTyaIW0dOiz KEnETz+bwVheaLyPgbd0fLGKYu4Q46N6G2Pn0FTh/XI1L/HfKupWgc1f/Xzv3Mya8LLSFjMo8zG NlRtOPvyQgfj50/JF5uNlXkSUCKUlj5UVabLYNU34dQPLL0QjMoFzciccc9xoZQP1A== X-Google-Smtp-Source: AGHT+IFjAi84HTZ/A4pA+C9Uh4taswArg/OQm9/eLcxntsiK+e5pN7QhquKttk1aEoXnZwZedC5iWg== X-Received: by 2002:a05:6402:3550:b0:602:427c:4570 with SMTP id 4fb4d7f45d1cf-602dafc7e9amr1072307a12.10.1748108854849; Sat, 24 May 2025 10:47:34 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:34 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 08/11] HID: pidff: Remove unneeded else in pidff_find_special_field() Date: Sat, 24 May 2025 19:47:21 +0200 Message-ID: <20250524174724.1379440-9-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes checkpatch.pl warning Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 88eb832265a4..6f25490ce464 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -1081,10 +1081,9 @@ static struct hid_field *pidff_find_special_field(struct hid_report *report, if (!enforce_min || report->field[i]->logical_minimum == 1) return report->field[i]; - else { - pr_err("logical_minimum is not 1 as it should be\n"); - return NULL; - } + + pr_err("logical_minimum is not 1 as it should be\n"); + return NULL; } } return NULL; From patchwork Sat May 24 17:47:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892717 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CFB31F1524; Sat, 24 May 2025 17:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108859; cv=none; b=ZPvdU66HKh+n0z8yXTdIu1Q82TYGnuQhcgyrQhUNvDZvLqM1rpfIrezd6u6IrrYwY7mwhUEeYPi24La6qmfPXrIgcsScqoRB7NIP470CCr1Zri6i7fp+i76BNZT1Fbl5HXOR+vfhEIq0qvdbMQ8hWDxuUW/fBAbM70CWRuiM21Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108859; c=relaxed/simple; bh=pdMN3gqR0nCIKgprSTI96Tpw4rL9tEGYDnSQwpIkAkw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=C3XgQp1RJkpaJyKBVXvT/ND4o31/QOnQLbxvGqzAv5gmYuw0sMUZXLrCm4HV00Vb85Uso0dNs7dxUnEH5QObP/jobSgDa5GHhvOrMf2MJvpzDL8vfCOFjrkucupcY86AuYtzVQArwWJg0GsNNRr9AAusJxLwfVUZSNMWhObhux4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A88vs1tM; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A88vs1tM" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-604593544aaso61306a12.3; Sat, 24 May 2025 10:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108856; x=1748713656; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QKujbtr43XBNO9BoXpBdJOV5AKCFi5xaNdnzF89noMU=; b=A88vs1tMAPIEKx4ysSliPkaQB4qnzVUloxXoDNMwlnnDRHyuD9RySXSLOo+VkfGqCe Vwssy+u3Hp58mfLmiQlC2KUfDDyA2Mtj6qWz7tqKejG/I1bW+JYO4FV3qTRMJN0dCE5I T6RcMmzRMIuqU6Mq1Jq82kNZUu0MCDUWIlUY/LRyV/KJi0PFmsPSmW4pGfmcpY4x8iw5 uyOejDz6RgUbjPKpaeLGGtccoMvxRcntMKmXGl92RAeTZ7BfQWQ2SYvA6lCwaHiLfP3n OBFl8y83YkHkrfh1MpSKYTcs3U07lWazVExNrr6ZbW5FwPjR4pUGxlRtl9rvu/9z7vH4 vaCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108856; x=1748713656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QKujbtr43XBNO9BoXpBdJOV5AKCFi5xaNdnzF89noMU=; b=ZewSnEsMVKibrfwx0HcExUqRdIiLIHLZGZA7xfDsiSmLUh+X/prp342o3LUGjL7s2Z 0x7jBnjK9W/Bs6SWiDOPBi6WSAs6MCa3waA4cBhIS2N/RAiE7DgAD899VGNTKi207jNm RfBetghdf0JqhhGyaNCeO0d294bllW26R4Qdu3Ft8O1i8kMzIjs1I6yEg9wFvPrg6Gu0 ZkFBPDeGOmVn7noTzCTy3f+NUzkJ5dRiT3a2ghRFrh4m1DhcM2nwKYV31AltM4arwwbz 8srTWW1t8QhS+sEls4Zpq9T1UVp+UMfzCJTJaKzOzQKt+I6/VnukvoCWrUrR5bgtVl2l dCtA== X-Forwarded-Encrypted: i=1; AJvYcCVPinuNczXsI6/g1ywpyLyjh+xQhAJlYddbVMLIWum3qszXNs0+u1yEf92SCAoQe/D1eQMDi6/e/4qN@vger.kernel.org, AJvYcCWJ3zrqb/eGzn3JKVrl2GzouvlJ/b7wh+/1SoTTIgdrxJhixEttiOl+jEyxy4MUtl/vcl3pvtdIMVW3AQ==@vger.kernel.org X-Gm-Message-State: AOJu0YyKgaLwQdjCIFg+SjSdWAe1XbvFSwdEacka+pTCMWP9HF5PbiRv 1/+mpOQjjLDplMH3f4s/Lbvq+mdG8L237dzyV4lQURisnSl5kaX2Td96hqf6jA== X-Gm-Gg: ASbGncu2NF9oukdXvY3wPZ1OyhAQrCRHEX6kq65iD00Su1N1VTk6Eea/M5HkUDGkul8 2iutAwpTtUH3KjUnxrBrAJknnMfHbhaIcI5XmKTDYPysNyJtxH+15rxABSoc/MriaYTi1F7jWDF A55pRS4Mdimj4x0yXFYx7y3YCJKexHbbTc2sAJXeT8vGfU5NR2djUmcuKZHjOtYh4KGX+M5kqIQ PsrJHb4Jg3mqnkPsbRfEgQBfA392YxxZFmKMIY+q08+9DwPqVHD/oUAc4DA5izpElMawcf8cIFh dgAsyNJF7DuE+Q8j0tbY9n9j3S4k2kSjbxlXf7H2ruOHMHDrX7xT973aK6wCvGpTJw== X-Google-Smtp-Source: AGHT+IGpa6QYVt9EWNRNfyzjpobBrZSmLOHQFNysUQM1IieI6c2Kn0jcCH9IG16WFAS+I68ohiObtg== X-Received: by 2002:a05:6402:26c3:b0:601:abc4:1b44 with SMTP id 4fb4d7f45d1cf-602d9df6cedmr1033003a12.4.1748108855774; Sat, 24 May 2025 10:47:35 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:35 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 09/11] HID: pidff: Move trailing statements in pidff_rescale_signed() Date: Sat, 24 May 2025 19:47:22 +0200 Message-ID: <20250524174724.1379440-10-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Adds newline before trailing if statements. Fixes checkpatch.pl errors Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 6f25490ce464..0e19d61f4936 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -227,8 +227,10 @@ static int pidff_rescale(int i, int max, struct hid_field *field) */ static int pidff_rescale_signed(int i, struct hid_field *field) { - if (i > 0) return i * field->logical_maximum / S16_MAX; - if (i < 0) return i * field->logical_minimum / S16_MIN; + if (i > 0) + return i * field->logical_maximum / S16_MAX; + if (i < 0) + return i * field->logical_minimum / S16_MIN; return 0; } From patchwork Sat May 24 17:47:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892440 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87BED1F1531; Sat, 24 May 2025 17:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108860; cv=none; b=R4u0Yy0RUDlISIQbbS/azsnyHZniZIzdmUEVBKIxo8pq/DuFhhNdTKnNb6GQrnPT0jmCgULWNr9I0jEMvHXSNpm7484fsYnZs7sgZJiNYtkwbr8HRnZ2FZ+1ONK75wrLUkhEzV4+O87nKpIiR/drJ04gxAfaMfo1oO6aa3NFEAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108860; c=relaxed/simple; bh=nTZ6r0Tda4xGcagX9QEjNojbjy4ea8auhWMH6Rp3B3U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bKAIUAPQt3QxyZBYzKGxogJN9ld9hHaClsPU20VwiGIHJhN1Z5wBWdDEQ6GS4v3U0ft0ybS8pp5GPHLnIKV7FA48I/rpJGYN6gNgBW4Tif3scBFTWqEEd3jEpYpYsUOQmFVY8najeDDlyPQQ7LiBzzfzLdQSrl2qMxfn5soI1io= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Doq59GBD; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Doq59GBD" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-604583107c9so41698a12.1; Sat, 24 May 2025 10:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108857; x=1748713657; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qTp4yJzrpEAf36Dg0kswN0Ez0D2ZNwqFBQu1Ab6aMnA=; b=Doq59GBDb3g7LfFKSdUtjBOLZ41oxOnuYkyRVUiMaZk/1VpH8BGa7le8DO1QUWi9J6 c2CI+nak1SQRMsBHoNk/j3Rn0BMK6gSdyiNJZcgBZLeJsQp/UZoqMQBKn3Zx/5L8W8rx bHemxMvoPxmlnVYtD5+vSn2SG3Oz8jBPNyvZEiWyDx/M797Em4ePXDX2acrNDm+rsLIF it7zhfrDYJp7+BuN1NGZneKqpK0RBV4yy/bGIYsPXoR/QP6eUGm4ftSYlrlysdn5eUM6 WzAEhJ0gQPFBn6Eg1kGiY/thslLfIWK4uLdn6s4J7xDBqkcG+60yWmisu//PTKKeKXQq fbIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108857; x=1748713657; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qTp4yJzrpEAf36Dg0kswN0Ez0D2ZNwqFBQu1Ab6aMnA=; b=R+WN+8dJlIKW7WeThiJ+roACdQVRcLE89U9AZ2K7+bTy24G9H7ACeECpWnmMygMzqv p1UZg1t2QQe+zQ5oIys2Uju66nVVCxprUgcOPEW7lF2mRzd+M3f0xyp4dz7a1lo7nZce 2c76BCOLx4Kb4T8UuqMoMrBT36F0rak2wZOkWY7bOZM+WWXB29Hg+OuBx5KOavZvtApG yC2KlIeXmokIRxx4humEMjZSX11twQCgZ3efGpfpQkNuM9VpRi62HyfntH0NQDl1wd+L Fww/A7J/JiDswch3pnHsgP/GxlkfcdrEWlEWbsmBy58QI7zOCXKPovBK9KBPc8mVzm2z UPrQ== X-Forwarded-Encrypted: i=1; AJvYcCVWCjiAKnGKqtGymQrOUI6YbNGDu41EP6GU/5hfb9TgmAZ+vR+q+Gr3tLJfa++tN7A7E1uWfR+opYHb5g==@vger.kernel.org, AJvYcCXyyqi1wic9IwkKSeIAnMwUTQSx04+kc49gAG2NEabmfoobA1Xup9ybqnYYmPxNV3i9HZ0gMbuTwjMI@vger.kernel.org X-Gm-Message-State: AOJu0Yw8dJQ6kQICMz9XRUR3nqZtsOMduyaKnPDwPUIJ+XiRERtjwg8y xFzJTfNnJkkqgjt9HRf2Zs/Pbv/z4qTrJ5EMrb7dz3hwA0g694Xmh91jWcVncA== X-Gm-Gg: ASbGncuvFsbwdOwUOrOLKAMmcBjvIQ8j727mLINV8vUic03wBkdkei3xQGQ9nRT/r3J EO6l6+RYPALtbU+W9bOFZXP1X9x9t5d8GJgRzTP5vTBmQNsDC7W42Rnq2QnKkop5ZMkOG2AQhBZ 6kzjRAZDz8aAjlEce0PQMRFed1cNhjs/lBJWO8iA44qkuq+qQRzbOc3AssW5ypLqS5P/RKwHHAD peBDHuDOMaSA6CmY2pt4X+I9PS5qKa0ydLDyfqMcU9noa7wdEo52MDRuFFDDz341GU+hjTm4GiN R8XOCvLHZq3McSiAAtJI60wojVQTQh0aAnBwK8NMXofnmQ5s9YQXAo3GL4B+8aaqcw== X-Google-Smtp-Source: AGHT+IFh/1YhdOhvyRdRQV0WancP9s++sWPxCtKHk3dD1D8TocPQ7CfEIuctsg7Y5aEW3ehDowG64Q== X-Received: by 2002:a05:6402:26c3:b0:5f6:261e:db8c with SMTP id 4fb4d7f45d1cf-602da0ed590mr1055021a12.4.1748108856677; Sat, 24 May 2025 10:47:36 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:36 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 10/11] HID: pidff: Add missing spaces Date: Sat, 24 May 2025 19:47:23 +0200 Message-ID: <20250524174724.1379440-11-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes checkpatch.pl errors Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index 0e19d61f4936..a07c5efddbe4 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -243,9 +243,9 @@ static u32 pidff_rescale_time(u16 time, struct hid_field *field) int exponent = field->unit_exponent; pr_debug("time field exponent: %d\n", exponent); - for (;exponent < FF_TIME_EXPONENT; exponent++) + for (; exponent < FF_TIME_EXPONENT; exponent++) scaled_time *= 10; - for (;exponent > FF_TIME_EXPONENT; exponent--) + for (; exponent > FF_TIME_EXPONENT; exponent--) scaled_time /= 10; pr_debug("time calculated from %d to %d\n", time, scaled_time); @@ -569,7 +569,7 @@ static void pidff_set_device_control(struct pidff_device *pidff, int field) hid_dbg(pidff->hid, "DEVICE_CONTROL is a bitmask\n"); /* Clear current bitmask */ - for(i = 0; i < sizeof(pidff_device_control); i++) { + for (i = 0; i < sizeof(pidff_device_control); i++) { index = pidff->control_id[i]; if (index < 1) continue; @@ -620,7 +620,7 @@ static void pidff_fetch_pool(struct pidff_device *pidff) struct hid_device *hid = pidff->hid; /* Repeat if PID_SIMULTANEOUS_MAX < 2 to make sure it's correct */ - for(i = 0; i < 20; i++) { + for (i = 0; i < 20; i++) { hid_hw_request(hid, pidff->reports[PID_POOL], HID_REQ_GET_REPORT); hid_hw_wait(hid); @@ -851,7 +851,7 @@ static int pidff_upload_effect(struct input_dev *dev, struct ff_effect *effect, case FF_INERTIA: case FF_FRICTION: if (!old) { - switch(effect->type) { + switch (effect->type) { case FF_SPRING: type_id = PID_SPRING; break; From patchwork Sat May 24 17:47:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 892716 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 969861F30B2; Sat, 24 May 2025 17:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108861; cv=none; b=WrqskT/WVMXaZXfFg78L+AFluuPfZoXGksXgn4Y8E2atiVcFJu23DxFUHsynTJ5zaDnUqUp0qhOKwGzYbzj3yYlMQVD7Ss6EilwUn5ccS5+xCjEj3XGGvE8EQBHGgC6rTKI8XI2HZwTL9BSdEwECMJw4oRfAziNrTLBNQF+iAVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748108861; c=relaxed/simple; bh=3tGDqnJBbu18AXgYPHchrP1w38yffpx8pAq6cn5Lx7A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OWcB+En0CQncD+ll60x56AsHuFMhnHrVxZ3i+wriA0k+PG03iGSc+Yvelp1rgVBx5Tqr5BwU64b9YA+Ax4+bqf+3Nuj+xZXotwEx0RduqWVzwgXiH62urv5p4JgAEigLiq2v0gdDAeGnS98+yJeSvDqbWqYSmrcuuhP2Zs/5dG0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RS5Qb/zp; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RS5Qb/zp" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-604583107c9so41702a12.1; Sat, 24 May 2025 10:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748108858; x=1748713658; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OpZ3BfemwzqY+Li8lN49igLDWD/37Rv71NUNEjaL7Ps=; b=RS5Qb/zpUvwsz2pVtc/AnKItTOfIT4LqcttjbZz6+Af+JjR6PL5r22lItDju3uLYYc bW8ByrGQn4CN4Mj9BnOR9LhMYyvsu8E+iPnA0YPff/YZW5MGHnv3tzETrpMDbeX0Qppx lrTkwZmEamQlzzzJiI/698/QVtI7cxElASKRtPnbIM3XXQqi6FUGRSiWN79na4cn+Ruk sJz8DAEuayF/D7krXZfqV6IBPIppXVJ836/iuXCqqa9gCt/418susstzZz+2SzRb98KV i4pjAKQzW1RQfduPlH7q6MsEdFaSw0grc/RAWbWVrqw8zYCVnPEZtrlTYvCJbrbJWfMF eBsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748108858; x=1748713658; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OpZ3BfemwzqY+Li8lN49igLDWD/37Rv71NUNEjaL7Ps=; b=bCN/dLTPcaVci74iXvtFBXfSizsk7yGOV7adeFs2TWUmQu8cEXgJXlnsI4Daxw25xM nhTesr++mhEzUTNW/S5Ni3R+fHfihKrq2mGH5tc02uVai4bAIwD2wlT06U/7H5JV8Gas xQvqN8Z9X034kCuPHjBGjjqxZiV8ZjEO9kh7CDt16bKV2HIcesdR57voMKcKQNg/sCMj X6E9YF4CeStcuGhlcG3yRq8p4bUjAdhtQI4fduFe7Wby+cAGpAdgXnfNOmEhDbzxQ29E n7KekBgJ4lb64Y9Rr9rj+H0umthuL9e4xET4E8Vmh59NP8y5HTy5Hx0Bml/jivUIwl3H 5dlA== X-Forwarded-Encrypted: i=1; AJvYcCUcHztsUwaG6RnPTwjmnnNUOUZGxrWkclH/RHIvYzeSpJWLqlo5ESvaNorR6YWwSJ6WQ+epG4Hp/PhH@vger.kernel.org, AJvYcCUvTSZVVsFP6+Ns4b+O5X4no4IpGEs1JCajhu7TMBSHpBXb3H8Y0K2jZw7h86Oj9Piiaj2jslXtzYsEBA==@vger.kernel.org X-Gm-Message-State: AOJu0YwILUNvuWNqA4I54IzBsLHOa8FfoVH6usY/1Ufnc3M49nlHlyEc LFOLF5wSs19Tfkbz8Uh51Pvw9mO+iAYSw3dcoTtmixkgUdHj3m6Pcqoql8pw7g== X-Gm-Gg: ASbGncsmsZ9TmuFz8mNXK2bChiGVvS3w/Mbv3FN7H6lnR4wjErgRAXe1r3sBR8PEavK keW+5BC2S5WHGHh04IB8OdGkKzrijlEnhbF6b/tOhNTn+mA9X/Y2GcCRX/1oyWBlH7Y0swFEHTi t5UTs21siB6NRiib+XKCg9e2pBHWvkyx6m9p9llia9QnwRQIfanCNTDHXKv5sn12Bkwtsy9AC1z 6qRY8pmWPGo/l0JzfND9SIsSecIuUVqdyrOzTwhCkzt5DN5rVjaOou4hWvDq54cFBOwNwvx3wX6 SnzCUkxhpjmco3popDQYk/Y4du8bLgLvZYBITIObB10kRaZIXmNNNRxniky7puoHHg== X-Google-Smtp-Source: AGHT+IGA8M8TaUOaTMJDuUc02SNtUscC7ATlRgFt9ntYyWDQVilaO2DDZt7cyrbxDZs5o+FO7n+U7A== X-Received: by 2002:a05:6402:354f:b0:5f6:c5e3:faa0 with SMTP id 4fb4d7f45d1cf-602db3b4ebdmr1141489a12.10.1748108857627; Sat, 24 May 2025 10:47:37 -0700 (PDT) Received: from laptok.lan ([89.64.31.142]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-602f11a0e0fsm1138789a12.13.2025.05.24.10.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 May 2025 10:47:37 -0700 (PDT) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v2 11/11] HID: pidff: Move else if statements to follow closing braces Date: Sat, 24 May 2025 19:47:24 +0200 Message-ID: <20250524174724.1379440-12-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> References: <20250524174724.1379440-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fixes checkpatch.pl errors Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index a07c5efddbe4..614a20b62023 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -976,13 +976,11 @@ static int pidff_find_fields(struct pidff_usage *usage, const u8 *table, pr_debug("Delay field not found, but that's OK\n"); pr_debug("Setting MISSING_DELAY quirk\n"); return_value |= HID_PIDFF_QUIRK_MISSING_DELAY; - } - else if (!found && table[k] == pidff_set_condition[PID_PARAM_BLOCK_OFFSET]) { + } else if (!found && table[k] == pidff_set_condition[PID_PARAM_BLOCK_OFFSET]) { pr_debug("PBO field not found, but that's OK\n"); pr_debug("Setting MISSING_PBO quirk\n"); return_value |= HID_PIDFF_QUIRK_MISSING_PBO; - } - else if (!found && strict) { + } else if (!found && strict) { pr_debug("failed to locate %d\n", k); return -1; }