From patchwork Mon May 26 11:23:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 892616 Delivered-To: patch@linaro.org Received: by 2002:a5d:6e53:0:b0:3a3:61c9:c5d4 with SMTP id j19csp1148524wrz; Mon, 26 May 2025 04:24:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVA2klPeBEj12Y3vDgCsfdRd7NwLUPUJbNaR3L2XCw4/Jw9uJ120d2nOp6M6KHy1IvOmbFh5A==@linaro.org X-Google-Smtp-Source: AGHT+IENtPwYH+jRynTLTK34fLA2kpFbxapWPRTXyZjtrRjQuQFLXYUaSt2LBeL36YL9i96kIDIj X-Received: by 2002:a05:6602:3a02:b0:85c:96a5:dc2c with SMTP id ca18e2360f4ac-86cbb8bee7emr885136239f.14.1748258661011; Mon, 26 May 2025 04:24:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1748258661; cv=none; d=google.com; s=arc-20240605; b=S0ydS3A2P0RnANE+Mc1Us5AV5CwgqDjRCyaxJ8nCRV3A3/LDL98ClBrX9Qg7qR0Sww 2ZFQhWcUlucEqHgER3FWs01rrgdkes17Y3oCyMyACwmAR3E+I5SKBXldY7k9g/zyAF1L NFTluYEFGYPEqZ1aBZ+4+j/X/pT9GWIoFPXsPHh1TYBobYeNef7UfuXarCBpqOj545E+ HMYv+eF48XyHY4YEi5M6RmmA7vmJSkSPBbXRM2Uuq6n4c6zh5SirZc+Y89MZHD1igdvr JI3oH70qNqj2TbVUNst1gSu9SvGo9YUvVYwmbvIWwz8gXEIU836tGVQAUmjOFQEHgPEM jd1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jNvIkaGWqwIyyf3qPO21sauAQBsDAgapC08M3PdrX3U=; fh=qfHpdDdaM4WI+lgLvXBC+e4AosthDmrnhJWYYS0AQIA=; b=fGhfDzYnM39WQiThQm/lR0rKxi+j23YTeCSBhjt9w8roqG2IE8+KuL3s42sZ7YwdyA NgwgUNxtzWsNLeJGUY/xI5Da1o/or1qfwL/+QplYZj1EbNJ9Ugs5FzOUMvDy7jJrueWy L1RyZvh/y/M2n9jiJhbNeindP1tf3TpkPMIcfring80TLI8DeZ0N/k2i+8qvvxRBY/dL 36ESy9U/3DBbU34XfVNbnfTCoaFEV34hIOsf6pyq662Ag9/pgTHl6/OP0IQ12GpQpwgh RHPXRc8FdTlm9/Cuwm2fqc7CH1hTikMDS6tJ9UEEBRenim6OLLHy+AooliyQfGrTtisq sDvw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kIroOeab; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ca18e2360f4ac-86a235b9381si371668139f.13.2025.05.26.04.24.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 May 2025 04:24:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kIroOeab; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uJVw0-0006Fr-BD; Mon, 26 May 2025 07:24:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uJVvx-0006Eu-H0 for qemu-devel@nongnu.org; Mon, 26 May 2025 07:23:57 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uJVvv-0001pL-KC for qemu-devel@nongnu.org; Mon, 26 May 2025 07:23:57 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3a36efcadb8so2082211f8f.0 for ; Mon, 26 May 2025 04:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748258633; x=1748863433; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jNvIkaGWqwIyyf3qPO21sauAQBsDAgapC08M3PdrX3U=; b=kIroOeabYqKJve8r3aKCpOjFzOlOpNwZcvtiIGBF9WEj2vOYPlRoVC6CnlqnPnFzol QqCvWMKmdVYjGNWej5qccFwGjHYiUKcv2fDk1tq/LU2J1MLqsiF5l75ff+Y33uhg+Zvs 2coAttz0uCs7r1X1bBORVb8AkOyADYIEAb6LkCz+tid0yKdfLyCb1cq9ldwOvSDJaDYf GJJ3zQRpF/DBMV7MPl/Wxm3O6PzwM3Bx6VU67MM5nuuc20SAWCJhsxJpqdeLJAXw1snw bS/VklvSpOdFo4+rXMxrip1KW7RxbYONFHwDWqx9kzzz07NDVysMchMUShWYa8mstdjc KVOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748258633; x=1748863433; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jNvIkaGWqwIyyf3qPO21sauAQBsDAgapC08M3PdrX3U=; b=A0iy832W2DM5s0bu330CZTZo4nbiG5J4xaFgISY71YWoCMSg06RA0JpHi7KOYZ/Ptj EHSBxm9/B0Xg+wqoEiKzyxbdrpvO/SOVL5IY5KDAeIqle7GN4wyqOhpupBeMwW27Gyaq /ULS80u8El78coBjzkK/Wkg4dSaPgkI+Y/nwl26iCgmS2QLN9tdCW0XpBeD+QRBRs2v+ g6wKzKpPB16S4bknK3rTthscQqXUfC/f0bOVT/zCta60oJj47w6WFMPVHD4OT8LgueR9 nAMi9JsYQqB4EP9yYEn3CPYaNwqdhTgM5sc9yU5S8jxw3SSfe/oZCxfeBurD5i+IbUzd Rm2A== X-Gm-Message-State: AOJu0YzhfkgrYFBUm/yW2iDQTprZ7nbLOcF3nOIg4trIOfqGtoVLZtWs TOPzwK8GZ4m1kY7TqrAqEutbPvXUhoNT9aqGQj8mEKstp1glEVAKtwKiaMlfRAiK8mtoZ3qR1lY kqyKaxUC7Ow== X-Gm-Gg: ASbGncvb/to9DBVl4QJjnGJfUG6mn6K+mnWlIAsDhVOlTq2TpasFSaUPBnpEw32PZ+u 3V42Rd12WjlwvAJP7J6xlOvEGyyuzJBncIY4nG+Z4d+g0yBOC6J/X+1OwvVyDFNb6YTV9sv9pU/ 3leNuGPGPl8rdQFO/7dGJehdb84Z+mHiAzZNUL7uMS0plQWsWj7o3fNMdsYc7lcvnteWS519XLA tQzE2MKoaCvdDyOH8fkH+NaMTR77lqh8Q/FDXQ7xw46D70ZcED/twuKpYhxs16/gKkdiRBEEz4f z4LZTnp3mlyjZYCRcexutIobNTwjLRfjkIV5dIkq+XY8yYZj7GzveVSocaX3ADGVycgXR+CAb+3 13IGGbLLVRka8FNRFTnykyrPLXcL+oeM= X-Received: by 2002:adf:f0cc:0:b0:3a4:d02e:84ac with SMTP id ffacd0b85a97d-3a4d02e8731mr4434127f8f.13.1748258632991; Mon, 26 May 2025 04:23:52 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4de9c9853sm549909f8f.27.2025.05.26.04.23.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 26 May 2025 04:23:52 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?b?RnLDqWTDqXJpYyBCYXJyYXQ=?= , "Michael S. Tsirkin" , Nicholas Piggin , Igor Mammedov , Daniel Henrique Barboza , qemu-ppc@nongnu.org, =?utf-8?q?C=C3=A9dric_Le_Goater?= , Ani Sinha , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] hw/acpi: Build IPMI stubs when ACPI is disabled Date: Mon, 26 May 2025 13:23:44 +0200 Message-ID: <20250526112346.48744-2-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250526112346.48744-1-philmd@linaro.org> References: <20250526112346.48744-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org When ACPI is disabled, no ACPI code depends on IPMI, so we don't need the stubs. We need them when IPMI is enabled and ACPI disabled, otherwise when using '--without-default-devices' we get: Undefined symbols for architecture arm64: "_build_ipmi_dev_aml", referenced from: _isa_ipmi_bt_class_init in hw_ipmi_isa_ipmi_bt.c.o ld: symbol(s) not found for architecture arm64 Split the source set list to avoid a too long line. Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/meson.build | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/acpi/meson.build b/hw/acpi/meson.build index 73f02b96912..76948cdd00d 100644 --- a/hw/acpi/meson.build +++ b/hw/acpi/meson.build @@ -26,12 +26,18 @@ acpi_ss.add(when: 'CONFIG_ACPI_PCIHP', if_false: files('acpi-pci-hotplug-stub.c' acpi_ss.add(when: 'CONFIG_ACPI_VIOT', if_true: files('viot.c')) acpi_ss.add(when: 'CONFIG_ACPI_ICH9', if_true: files('ich9.c', 'ich9_tco.c', 'ich9_timer.c')) acpi_ss.add(when: 'CONFIG_ACPI_ERST', if_true: files('erst.c')) -acpi_ss.add(when: 'CONFIG_IPMI', if_true: files('ipmi.c'), if_false: files('ipmi-stub.c')) +acpi_ss.add(when: 'CONFIG_IPMI', if_true: files('ipmi.c')) acpi_ss.add(when: 'CONFIG_PC', if_false: files('acpi-x86-stub.c')) if have_tpm acpi_ss.add(files('tpm.c')) endif -system_ss.add(when: 'CONFIG_ACPI', if_false: files('acpi-stub.c', 'aml-build-stub.c', 'ghes-stub.c', 'acpi_interface.c')) +system_ss.add(when: 'CONFIG_ACPI', if_false: files( + 'acpi-stub.c', + 'acpi_interface.c', + 'aml-build-stub.c', + 'ghes-stub.c', + 'ipmi-stub.c', +)) system_ss.add(when: 'CONFIG_ACPI_PCI_BRIDGE', if_false: files('pci-bridge-stub.c')) system_ss.add_all(when: 'CONFIG_ACPI', if_true: acpi_ss) system_ss.add(files('acpi-qmp-cmds.c')) From patchwork Mon May 26 11:23:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 892618 Delivered-To: patch@linaro.org Received: by 2002:a5d:6e53:0:b0:3a3:61c9:c5d4 with SMTP id j19csp1148671wrz; Mon, 26 May 2025 04:24:47 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVyrPDU45UBCj1FIF2pJBV/K12yrQPFjVV36R+GYRD8CGDbCTi6W4xXi+6K+rSg+uNNPuuRVA==@linaro.org X-Google-Smtp-Source: AGHT+IHOkB/goyz0r5+B84OlWxyNLCLIkiuZpDygDQHMw/v6D8q+FF2F91NCBTZvqCnf+qksJAlr X-Received: by 2002:a05:6602:4192:b0:867:973:f2cb with SMTP id ca18e2360f4ac-86cbb70d17bmr849856139f.7.1748258687563; Mon, 26 May 2025 04:24:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1748258687; cv=none; d=google.com; s=arc-20240605; b=j7Q2B/tPfy4PcG77kO6EBmmjhloc+wRd40OClqBKDasfibP1xy4QCqWJoxVwKqlj+A GhKqxzR3MR34SgMSm6qAY6zOqIIe9x+SNXaGKqhMkY2VEJdGA/smwuKmXPc9/OThk0Q+ kRRYsBeB+Zem8MN8azVE6P6xRCTt9VOyy6S24NnRvKAglbaPbSNjqr7wqW5fpEIpX9xN ihxkX3ZCVParF6/K2hdYD9cW+6gT2OXCwOMEh6Luo/b5kREU+rf3+pQaHdB1a9IAsDL3 WLlRzV8Fuuan9L7WvTRk0U2Scbn00Ee4RU448xhESAnSGdB2uKxOoSfCyt6tVlqiyJFA vxpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wDNGc9uXORNTBpjrU5AzqhH7cBKsBdI7XLELUbLErSA=; fh=qfHpdDdaM4WI+lgLvXBC+e4AosthDmrnhJWYYS0AQIA=; b=MvdEyJcQ5OoHyfSkuK0B6RPMN5KsbH+0ty2jnxkRYFO980/xvufydTbQWXm85alQ4y 4F/zYwBl+nwC+UF8boi8xr82/udgAtdezEIGQjsQtcn8TE17kp4AoNOVwzRP92Ko0Ems bGj069GJegwylOE+xw0I1Aqpz8ZTzoZBGMnzmz0Sdf8fu2Fyi/WUf2uNunvmLcmBfbtx WKobVKLZL/9belDuiAtUuMFDiq0+L0LzpoZIi9yzS22axZNqu05/7EsAg3NDIq62LTSl ENwWo6Zode6ACA0003z87kKcNzAhAyEzsbiiWIR/qtmJUh6ovK4ivmpp/jcA8as0Ttgf kpXw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VUQ6ftxz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ca18e2360f4ac-86a2550b3ecsi1714767739f.67.2025.05.26.04.24.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 May 2025 04:24:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VUQ6ftxz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uJVw4-0006Gj-Do; Mon, 26 May 2025 07:24:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uJVw2-0006GC-1x for qemu-devel@nongnu.org; Mon, 26 May 2025 07:24:03 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uJVvz-0001ps-Vv for qemu-devel@nongnu.org; Mon, 26 May 2025 07:24:01 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-442d146a1aaso25718265e9.1 for ; Mon, 26 May 2025 04:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748258638; x=1748863438; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wDNGc9uXORNTBpjrU5AzqhH7cBKsBdI7XLELUbLErSA=; b=VUQ6ftxzjWsRRtFnYn6R8uk2isreSdsVr+PrEVvwkfsqnD+jHDftf8xtUiwMVlUasX PGePyl05YMalQOc53uYYC3HpcBbDyFcYg1c1KqC0fCzfNT+CktfhIIOIMH5hAmHsLVYt +AK1Z5Qg8Gt1L/G+g/mqMloUaeV1KN7ieb/JKSam5uYasJ8AfZ+ivFGO8LxnjhuMbBra YaTWbagRu2U9dIeZlku9kCgRtjVn1KZJY5br+X6wmRfqzJXlFdVpUrgcGK0YYYbzjKzU B/AD8REEPhf9R90tLK9cZYyYWeo75RLeQTh/Ian7rmxsfDri7mDfW3ZpLLcNEmWwytOz VyHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748258638; x=1748863438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wDNGc9uXORNTBpjrU5AzqhH7cBKsBdI7XLELUbLErSA=; b=j0KXLXFmQ1fzdzVEtSAvK6p00Y8YMeq775wEquhROPxmiXcCQoaEnzTdCIOdb8HEjh hInWzgL1aLrygSXIRNq7qJ5dcZ/iCRtujFBikCKDhLQPuCiUi71wWwSuosVNZgwqG4IZ UnygZBZ0hQbq+pxAEFs1Jc0H1ssii2WbBRvqh3LV5vyZL1o8aj4lQrgIUA181pmkgfwS RCsg3CenDm0yvRQxpsR0t5lSLqmkH80L6SDpP6SdeygOLzGwMehmhmRyCmQVhlRPU69v 2LHQWHmbmK8uoqmR391Le9DhJFJ6FjTSTv0yNAUtVqJWWEfp4n20cnlXX4E/X5uEZhB2 Wq7A== X-Gm-Message-State: AOJu0Yz2k0VUImvsPr6k1z9o5X7ZEuL+vMmrpsA2RrqHCQ1q4F2IxVSe gI1E850jy+nkKSW7TiWz87lMoeDJ2+l/FjNzUdUOjnoIY20ewqu5NFnSgcEtC7NVelyF8KitoeE uuQ9DePwYDA== X-Gm-Gg: ASbGncszS8sSFZ/efTRw8yNTUZ5JHIhu5Zg5BYcbNENI1yzWBFObvPwTA8AEc/xsImn NlYBz29VzmXZL2Ysb02UgVPi6Q1fc5LM4NVc6nVB4f+zda9hdq9InFv4DahE/DU7HCEsZZimI6R jabvGc+eMerQUMbzqIWO/DnkiF9y2cDDJzkhtc64qtRCapr22prGmAEhXZtUBzCTSHCG99p1EE/ U9sA4GtTehs/mYP3C+gpqbkhdR8PFED6EhJ/zHA8yDuSBUzThIQVPCGV6uQG/4lPvhZ8XLkIsZH EZqcvh0Tl7K8FUc3+WG0JheczHy7SWDWxJoEK0YviZNcGKFTmeh64dBqkxsWqpv9lD83M6uq89a wJxoGQjsM3dp/kheBksGUpU+4OAVzTdE= X-Received: by 2002:a05:600c:314b:b0:43d:45a:8fc1 with SMTP id 5b1f17b1804b1-44c93da7c4dmr77361285e9.4.1748258637735; Mon, 26 May 2025 04:23:57 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4de9c9853sm550080f8f.27.2025.05.26.04.23.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 26 May 2025 04:23:57 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?b?RnLDqWTDqXJpYyBCYXJyYXQ=?= , "Michael S. Tsirkin" , Nicholas Piggin , Igor Mammedov , Daniel Henrique Barboza , qemu-ppc@nongnu.org, =?utf-8?q?C=C3=A9dric_Le_Goater?= , Ani Sinha , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] hw/ppc: PowerNV machines expose a I2C bus Date: Mon, 26 May 2025 13:23:45 +0200 Message-ID: <20250526112346.48744-3-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250526112346.48744-1-philmd@linaro.org> References: <20250526112346.48744-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since commit 263b81ee15a, PowerNV machines instanciate a I2C controller, so expose a I2C bus. Express that in Kconfig, otherwise we get a configure error when trying to use '--without-default-devices': The following clauses were found for PCA9552 config PCA9552 depends on I2C select PCA9552 if POWERNV Fixes: 263b81ee15a ("ppc/pnv: Add an I2C controller model") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Cédric Le Goater --- hw/ppc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index ced6bbc7404..0d017df83ee 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -29,6 +29,7 @@ config POWERNV depends on PPC64 && FDT imply PCI_DEVICES imply TEST_DEVICES + select I2C select ISA_IPMI_BT select IPMI_LOCAL select ISA_BUS From patchwork Mon May 26 11:23:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 892617 Delivered-To: patch@linaro.org Received: by 2002:a5d:6e53:0:b0:3a3:61c9:c5d4 with SMTP id j19csp1148612wrz; Mon, 26 May 2025 04:24:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUbrx1aYh0VZeiagDgLKs/Ae3l6n53yWD7aYzfrCRf3k92L5kE6A7laWXEds0QA3DTMFZZlxw==@linaro.org X-Google-Smtp-Source: AGHT+IEzvU5k80AkhuN9pHvwKyVkC8B800Jngh6qctUnLZJ2tDte2JMPFaKVf+F3Gn+eCXnUldkk X-Received: by 2002:a05:620a:4246:b0:7c9:38ce:becd with SMTP id af79cd13be357-7ceec49d71bmr1205654885a.22.1748258678437; Mon, 26 May 2025 04:24:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1748258678; cv=none; d=google.com; s=arc-20240605; b=FxNXsSxeWTRrYDMu8ijmFzqFM582rtHZn6kHAjFRoQGusKjD6Ltro4/TdtBdvWX13w W3yHpfhk3Gv07x3x3M/bKQ/rUg1Ev+wmbb4h8nH905JaQUNAE4y0hrkVlhUmJCCvMyYd uIV9xwc64nFxlhoYjhAnILIDVJaOG5KWJg6xd5dT6FdiAPN2cpCePz60NzQ0YSvCyx0Z cMorHVPKQANbsOR+zhff5XX26dyEj6dS3e8bSXzxgRXbvizeJG1V10gJ93xP58J/aX5i MYNrd5WCh5tpqmGBHUrhiVoQCOuFmoBEk5vgc0EiKeou9Z+sUP8pie4duCaqsBNMKA+A eZRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ELCLDmiYgPuDHAGlIm5WFjN8VBeP03kfHU9C8of95Hc=; fh=yJ49eLpBqpqVFnZJRRPZLNEMbih6QDbHwTTBb20HANU=; b=SJKU5rWnXDmjBpAyiERxU5oET6gNl3ArN6CpK7Q0Y1v0U3HYd7zKDMuoY9vE9zN+vi ANRfje3aPiLUO0JfTpbeP6ZjIa0b9msZjODTIvOHrbqc6MXFdRy6OzePHR3l+tQKLaa/ JfMaD2C/2NakaRXqwnYQy+W/1iMKBVG1e4WMbZ42sduGl5g6+DcNSUL/a0ssZAGiPSzI +bxlm/SL5JzT/dvxruiLaL5FewoUlszXMxxH6mJ6I004pYl+xF0UIt0gfSiaxoaTKPdU uWz3wsCak8Aoqxn7o6EykoBefxICVhKiSZTyJVSyaQsv155MUpLUxqAVfgB9UHXbs6Si ULNA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nfsl29ia; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7cd468adc53si2375072385a.333.2025.05.26.04.24.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 May 2025 04:24:38 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nfsl29ia; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uJVw9-0006Nt-CG; Mon, 26 May 2025 07:24:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uJVw6-0006HN-Ay for qemu-devel@nongnu.org; Mon, 26 May 2025 07:24:06 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uJVw4-0001qZ-JI for qemu-devel@nongnu.org; Mon, 26 May 2025 07:24:06 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3a4d877dfb3so1008403f8f.1 for ; Mon, 26 May 2025 04:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748258642; x=1748863442; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ELCLDmiYgPuDHAGlIm5WFjN8VBeP03kfHU9C8of95Hc=; b=Nfsl29ia8jPOzsHMHnTwNY2JbyR0wHDCdPoW0MpXUhu1oPCffLBdh8A6MjfxGuk/db ja062goDkLmUjiO82hMB84nhfGaAevnQ15+DjeA3GoualCvZ8MKlXCakEd03RIImLkmB ehaR9DDRvV4D+DiHpx4CohbQ80tIckE0mh0z3Wr9+oO+EQg8jr51ZzmyYPt2UNXnHvv0 +FS1Veux8MqOBAikV+xWx28q90Bj6JmuuaTV5pCwkHcXdNB06kT7wCfJ5VX/IjWTDGBN Fql8oPlYPFyYuhwVfFmHPkU6UqLA0L011Z9GmcL4N4rbj+NPpB/jN8ccpVzCeHKco16b MYHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748258642; x=1748863442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ELCLDmiYgPuDHAGlIm5WFjN8VBeP03kfHU9C8of95Hc=; b=r3aHBZYrDf36uPg+tzvzeQyZZxY91sST+cymSuCsEpRJenKF51Dsp7nzevF8Klf/5M 9QwVey3HSZ0HymXO3FmzxMgi1TQqkBhPbn3YePLiQtqoXKNx1qeJOIgWEYuFWyo50Wgo fe7zMgWxLeG7iEWweEhMLd/lmlxUuu/ZdDOC8EQ3WXtOXS+/hTiNg6GCmouJ+NY5eWoZ xmiO3EnNBNVzDr1k99X+tyV58FB4F9UPN0+w6KFLXkHbgNLvfpskakwpsbO8oGb3smxF RWZyoLm09LJIybvKPMFjYMfS/sfZIbnTGYkX5T91QDATfsdoePzq8qVsuA5fng6omxEt uJuQ== X-Gm-Message-State: AOJu0YznkqYfL3BpYJ3urYuvkY0Mt9an2qER0gDjqn8FP7WChfW2MgS3 Vs7hHGT5wXpqVs+1BgtUjajKxvnXN9Qe/OTp/Tq+lylXyBSIqeataq2EAwIV1AjCC9yYDhyzrMm spvZTEr8fhQ== X-Gm-Gg: ASbGncv51IVU8vF7wzQ5EEw3jzDAZrnG9QHWKh0v9kf/0OqjqRUf438NNd+sT7lQbJw XbnI8kGzsduxf/y3fL7pdsTQ4FG7xLMxGn59aDrIoJskMvoz/o6xg7aSaO73S8gGsiyKSOkvMOf iegPJ4DkdaDsD/fy+UcsvHBZ4TSrcUtOb8J3cLMvCOvLEFQDC5nxaevT8RT8Wbi88qhsXkAd9aU DlzOQRE7P7tljDGlIGSpVw4k0bUl7P3I+r+oa1YM94cL31KcZQpp2qUrfvHCIJBPlLge3Ytgmxq gVR0RZjuasAou/5rvgUNgXtBfAsVfizbbRud1f9oIXMOdk67DS48VB8C88NN8jrZG39YP0V3kI6 TXxqkFjrAd9x88TN9cgt1PshGf9As3Wc= X-Received: by 2002:a5d:64cb:0:b0:3a1:fa6c:4735 with SMTP id ffacd0b85a97d-3a4cb474157mr7616249f8f.35.1748258642576; Mon, 26 May 2025 04:24:02 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4d8ea9520sm2841634f8f.70.2025.05.26.04.24.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 26 May 2025 04:24:02 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?b?RnLDqWTDqXJpYyBCYXJyYXQ=?= , "Michael S. Tsirkin" , Nicholas Piggin , Igor Mammedov , Daniel Henrique Barboza , qemu-ppc@nongnu.org, =?utf-8?q?C=C3=A9dric_Le_Goater?= , Ani Sinha , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Thomas Huth Subject: [PATCH 3/3] hw/ppc: Add stub for pnv_chip_find_core() Date: Mon, 26 May 2025 13:23:46 +0200 Message-ID: <20250526112346.48744-4-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250526112346.48744-1-philmd@linaro.org> References: <20250526112346.48744-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since commit 9808ce6d5cb, building QEMU configured with '--without-default-devices' fails: Undefined symbols for architecture arm64: "_pnv_chip_find_core", referenced from: _helper_load_sprd in target_ppc_misc_helper.c.o _helper_store_sprd in target_ppc_misc_helper.c.o ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 Fix by adding a stub when CONFIG_POWERNV is not available. Reported-by: Thomas Huth Fixes: 9808ce6d5cb ("target/ppc: Big-core scratch register fix") Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/pnv_stub.c | 15 +++++++++++++++ hw/ppc/meson.build | 3 ++- 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 hw/ppc/pnv_stub.c diff --git a/hw/ppc/pnv_stub.c b/hw/ppc/pnv_stub.c new file mode 100644 index 00000000000..8d11c8b65bb --- /dev/null +++ b/hw/ppc/pnv_stub.c @@ -0,0 +1,15 @@ +/* + * QEMU PowerPC PowerNV stubs + * + * Copyright (c) Linaro + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "hw/ppc/pnv.h" + +PnvCore *pnv_chip_find_core(PnvChip *chip, uint32_t core_id) +{ + g_assert_not_reached(); +} diff --git a/hw/ppc/meson.build b/hw/ppc/meson.build index 9893f8adebb..02f248f5f46 100644 --- a/hw/ppc/meson.build +++ b/hw/ppc/meson.build @@ -55,7 +55,8 @@ ppc_ss.add(when: 'CONFIG_POWERNV', if_true: files( 'pnv_pnor.c', 'pnv_nest_pervasive.c', 'pnv_n1_chiplet.c', -)) +), if_false: files('pnv_stub.c')) + # PowerPC 4xx boards ppc_ss.add(when: 'CONFIG_PPC440', if_true: files( 'ppc440_bamboo.c',