From patchwork Mon May 26 05:25:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akhil R X-Patchwork-Id: 893429 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A538A33DF; Mon, 26 May 2025 05:26:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748237185; cv=fail; b=psisBTO2DY4/e6zZL3S6rHIhQxG1Wd5HEegq4y1AedTRWDyZLRfH0AWz3qPslym3ePnqrbbX8N6/qyR9aqIDajmp29wJkAXfY2W2OKONT0CSr6wFWz9mNXEVycdumu4iNVoAAqqSGyAE75/TlEfiO2tNKyJ5h5V4Kvk5tk2p3oI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748237185; c=relaxed/simple; bh=sm8AA79VKWiNNvfhcx3ie4VztK4XytASfp01aRnF6co=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=ryc7WoKdkpqGToDRImHmTsMFTp9qkrVsNk8LCNqTp0vRWyFucLMvpGKkxF2AwBlJIq0HxU5Ydq3N31/HqG4e1uRuk7a22ogETO8G+DWiQvFvK4NlGOA1J4LL7Pn8bEXRQptKsb3V1X0fse3toyEZosEGR7ytNhaNlkAHfc6PSR8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=aO9mURyV; arc=fail smtp.client-ip=40.107.236.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="aO9mURyV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sSvIzOddZOYUfYazE+fh8BeY/cdlmilrrCWw/R+DOWHWMwWFDZLpIWG8UE69ssnDe5eO8pKdQA1Xz4gKQX8R3KlrCF91C7bvAvo94ZH5xCDu5fA7McTSWxhqNEuq37VtoHJg2qrSHT+HnKaAfwTilF6na+HPQlm3ViU2sNpRASyHKpIdlRNnvskdP+GXz6MmeMEVfwUl7ksKFU0ZFELQS+HWg0r0D+TjKMc3UXij5B3HAEwax38bn2KrBdhWbN5imevE4DBy3ZgMYdgEcg0eGnwOZouCd6yXIdA1ZjKNyk7kJcustijWfOQwJj2cgAcNWp65pBx6XNlkE7q58TRi1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O7GpbBaoL2p7kUcJTBeJ6RSVxib3TWwJqhguQFQBJ9s=; b=jZJMMySOKsr7IIvUa8qLqMaA/VUqK8uLesSZrTJ1BRJJTLQE+LeyVzdbdvpkV8o/GuD3bAG7PxNekdmDpyhLAhhtaUUT6Ld/l0jgdbpOoOTmOQQCSSQT7uM9vjeHh47HWbNclNCdR4u7WqOqEVObi5Mu5P/zqp+tMly/FEjCJR8Qk03ASe6l+H8uAyU+hydcE9Tnsc91LAtoJTf+gLB7hzH2bmvrcJyorelTQcQrp3pL4Mg6a9bnZ1O/PdsHC9gP/ILKUShL4R4MNUV0AuFniVbrPR/7ySwmjI/E+k8D+ObdPawDvQTovLlSvDLNRl2L+PVq3U7B3Pwbn6YI/14EzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O7GpbBaoL2p7kUcJTBeJ6RSVxib3TWwJqhguQFQBJ9s=; b=aO9mURyVYtWP1NjDf8U0zPAPre0PWpd60IZ4sqcVzACz4li75eY9yMmxtKuQZCWfmhmiCAbqwj4cUQXV4m3sTjsB5uk6NWrvw27xB3hcLhCKGVFQFck+XT9QtlCxbHNNkrtY6RMRJ8GiXBjL10p8xEeRjR/lQJvCKaLHpay9/KqT7EbAi88zaoWzMrIcXMT7NAT5L7Pd+6q+zOS8jxD4YSuDPw0CjIylQ2Vbu4H1HXuBl3VYCnrTMt1yyzvJI5gFI7kGTn4SPZhiFfD1gT6DyT2bI6IdHPV+xBWhRXlrvodWMUFuCR4wPFFURgxsJM3ytgVzCTgDXL5ABD5RPioe1w== Received: from CH2PR10CA0029.namprd10.prod.outlook.com (2603:10b6:610:4c::39) by SA3PR12MB9160.namprd12.prod.outlook.com (2603:10b6:806:399::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.24; Mon, 26 May 2025 05:26:19 +0000 Received: from CH2PEPF00000146.namprd02.prod.outlook.com (2603:10b6:610:4c:cafe::4d) by CH2PR10CA0029.outlook.office365.com (2603:10b6:610:4c::39) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8746.30 via Frontend Transport; Mon, 26 May 2025 05:26:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CH2PEPF00000146.mail.protection.outlook.com (10.167.244.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Mon, 26 May 2025 05:26:19 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 25 May 2025 22:26:14 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 25 May 2025 22:26:13 -0700 Received: from BUILDSERVER-IO-L4T.nvidia.com (10.127.8.9) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sun, 25 May 2025 22:26:10 -0700 From: Akhil R To: , , , , , , , , , , , , CC: Akhil R Subject: [PATCH v3 1/3] dt-bindings: i2c: nvidia,tegra20-i2c: Specify the required properties Date: Mon, 26 May 2025 10:55:51 +0530 Message-ID: <20250526052553.42766-1-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.2 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000146:EE_|SA3PR12MB9160:EE_ X-MS-Office365-Filtering-Correlation-Id: 886878ce-6b02-43f4-8841-08dd9c15d891 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|7416014|1800799024|376014|921020; X-Microsoft-Antispam-Message-Info: 5X81886+0hMzMQll8Jq63Q8fOcsoRqQ6zsP8FO3e+TPBP2X6MJJdcJXSPBs8b6XqKS0e6gncQKsbe2yixMMK1uE861BKtcctJ/a8fk1+IwL9OzvBP+EEKWDwDhm+OcBHyifrmNtvSFOZbVePlL6PmY0vZT8aL/OQrw7+NO2uxIQgRrwhlEO2IAtafFuhapgFExnk2s75t1R3S8DM5vBOqT2haP5sbOu1P2dwnhelzXT4WC0nvDyZlLxdQaicC0mmWseb1uPYix2DxIaV7P0cshHkLQMvbPFBMTfKZ1YveK9/5Ey0rtZYHO0X/7UW7Fu+FglDkEbyf/8wvOKjMhYMfTpw3vaBcK1vs1wKNpQQi1+YetMITujNgYh9ZfJwrUwK5M8aA6dHVYWME9BZZhm2VwkTjJ03lRX8o2c5PwZExYqftNApvUHWR5C54ZeVmiCiwhOBg5Wt1wyzGPlqIFKJOf8b4NPauLPlv8LrmusQqjre21MFXUSBMPD7d8VZ7Uk/GRPctaaHnqnhhr/Fpp4LLqWZgEF54tsRRs2Us9AYsd0E61ealzr+Wq8cPRH6hlU97r8hfhcw/sIJ/bjmTNwsXCLjY99Crsqsv2HoO31cJPKxler/t9sHSkWB7eTRj24SokODX1EEa4doZNN1Vlxmo8rqnNZHpZ/8Czr6F76GnI4LE0rsJ9+bZMJsGvOSExsF749PrzBJmGNnMeLynvY3l6/ndqUmQF1htvef8CpKZOt+xdj21DBQ/FPROmDIgm29TpFdLo7maZF7Mzz5Uqd3Wvm5XLSdug3ctRedsacpSoooA0XGV0v/XUPuzlchQDEBq/C9kZC15UKq985Ka+RhQ1pOyHMz7QNJqtJRa3ZXcCqzM56OOo7uxHa/Urs5gdDnLgp8xCMRaD08QQXG2vTZMFCQVxvU9yh4+hdJRbBSGHj9rmHCAfm2exht/Taapf7IKy1G0EfmGOWtdF7XaQwlSNNAHNfkjCV8ezOXQLKgUVLYR0vOU4HB8ov92ltGB/xX30IuDGWns/m3/9rvxdUKUFzWfdJ0g71CDCwSrfxQRFma8RCCN0qy4ORR0ayEfsWsOn+w1v9O4JWO1Cu/OSlBb+5j0N94hLSAGxrfHhYismJ86+oO+NnWsQQ9mUF87r72yhdMHLr38ANsXoAfx4GsK6pS+8Pg7nKGHloh2RG80rB06gSwPPdkrDkYhEGaPtZOUDQ2w7qo4Snuavle9hwTgxzp9sog/fvYMQ9yQGVeixqEepqAcnFWnMVGsjbeKd+wEyHQG02/bH7k202v9RF+L1Xo33S6XBKnY4L+RTKQgkWqizkIn7BarDsXLrdFy6csdEwLQOWlmsvO8vk+pP/AJn4eHCL7OI3U6AaI+ll4kgiMM5T4aGOKWp4NYBmCiHWS4OWYJtcp19cUvO2XoNwhKXBhuJH1SZE8cOp1DKSk3Itjtt+ki682/OFxhITfWQb9N7OoJHmlnersHIbYUz5x+cPpiKJXUC1QIn39kmiYf22243pX23hwBTOOn9xU8xIQQIP+fJ+/h3iRvm33d058zQ== X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(7416014)(1800799024)(376014)(921020); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2025 05:26:19.6889 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 886878ce-6b02-43f4-8841-08dd9c15d891 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000146.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9160 Specify the properties which are essential for the Tegra I2C driver to function correctly. Though all the existing DT nodes have these properties already, it was not mandated by the DT bindings. Signed-off-by: Akhil R --- v2->v3: * Updated commit description on the details and fixed indentation issue. v1->v2: * Added all required properties .../bindings/i2c/nvidia,tegra20-i2c.yaml | 23 ++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml index b57ae6963e62..c1d38e6ff7d7 100644 --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml @@ -97,7 +97,9 @@ properties: resets: items: - - description: module reset + - description: | + Module reset. This property is optional for controllers in Tegra194 and later + chips where an internal software reset is available as an alternative. reset-names: items: @@ -116,6 +118,13 @@ properties: - const: rx - const: tx +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + allOf: - $ref: /schemas/i2c/i2c-controller.yaml - if: @@ -169,6 +178,18 @@ allOf: properties: power-domains: false + - if: + not: + properties: + compatible: + contains: + enum: + - nvidia,tegra194-i2c + then: + required: + - resets + - reset-names + unevaluatedProperties: false examples: From patchwork Mon May 26 05:25:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akhil R X-Patchwork-Id: 892662 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2046.outbound.protection.outlook.com [40.107.94.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 813281C4A17; Mon, 26 May 2025 05:26:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748237205; cv=fail; b=oADBka1UVHRrhiJ0lHomNn2G2F/ENxR2J4kf54NyQLDXkWLuNAc1W7useIWIpfyIVW/1/y9U9GhbWnb9S9oI7GLuN/MK3mDUimwVTsnJlyijhQhaIblAO1edEoxAVh7njAdRsQpMtT97P6E7tVO940PfsN+JK9VBMDHPgscvsvo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748237205; c=relaxed/simple; bh=W1XGataJvW7y/wD/T4f0w0DtvzaIcqhSRufmsydzVMc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ePNjxaaYIp4FMbUgJcWoM2c4OD9rTEk+9nTbr1UFqNVJ4XxfxuYRwsWxN48w5kdkMuwUFuuRBcxf5ztpoI9plmMlX0/nKvWvw/BhTNMdwarrARIh2AWAKqYPF6wp90QpAm1c+fFxPZUzaBOBvhutrAu6lztSYyS5zRoZChjz4BM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qCTpt3Xj; arc=fail smtp.client-ip=40.107.94.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qCTpt3Xj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fw2SB5TSYWWDeyuQQUAv6FQKbT20wb0a0eoAeh3F9IipbSFFPeWP2SJ0Yi24Tz16fVf6BRqdprxyb25Ohl5eGsXSdKdsaR+J02zsq4sqfrBqer/+/AYNMRFgNH7ptpj3XHIZn/vOHhhR4f7UkY+CBE0bOO23jvzCvov0R5m+aUk15ms8UGCatTKWRyN597d1gBGNu2JbjrA451J9tpfCddz5H5QfXz4QnXrwgqhL92yTTPOxyKdGqq+foMrs5QeJgfL/OD7ku2rKUAK7LxAZZ86uYd1MljPRZljg/wpTI607HS1iLaNVm+7LKnkzVzIskpypn9uOs5gz9O+8PIKHgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=And/Vr+9g9p+CZRWc11+Mf8xS3P+b125IgPGxjWD8Zc=; b=w3g6s45SIymNCujO0XV7sxRZ6q7msDtefbOb6cAYyQO0zj6jzs6vTSDblylUcR3KzLqCqzlGQ8FzE6HRQBJDdJeZC68iKmxr/pG27c+SntWlaeKASlwajSQeUiMeOpLM/gpYqk/VfJ/GngIZSzfOdeGjHT7BwdSz83FFQxp/9m/ugV3fZDtfM7oeAVQMCtC1jJIXLMjzIdQVwiuIx6TFayF0HGRd834QCbsaiWFqEHIm7ie4mg3m5Be1vfRkrWyX3kgPeSP6KJMcRZaecJ+UkQfDA3kVMElz93+Oa8Boi168jD0MgnXXUijKtVCEqalj1lDMotpH+8/xZgUW1AjbLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=And/Vr+9g9p+CZRWc11+Mf8xS3P+b125IgPGxjWD8Zc=; b=qCTpt3XjxfetLDpsibP6EJDA3hTPOWha2sz3cZyQR++VSnRYX7VN6v3tFwtbNXL5Cpw79Amya4nSdhXl4ZdeqBBj/c8B6T4rUDOhJDAqqQ4NnNjuu/jyWCU0XvlrW2M/Y+wv64Ko1xhSYe1Y6gKOMdvdGHjYnzQ6zZVeBr90EAUzCCBjKKdDatNnqdbvFNPPMrRiKz+Qhbuql5F9t3IkvaSAY90dbuWqDEt6874SouxQboJGrNIoRhZWzalVze3ha3IyDsdN6K5Va0fRJLZjmHtc+h8hqHv9RCnD7EasmTbb5QHoYKTxUsT8yqcz9aJr8bJCEGcK8xfpQ2Llc3oNHw== Received: from CH0PR08CA0008.namprd08.prod.outlook.com (2603:10b6:610:33::13) by DS5PPFDF2DDE6CD.namprd12.prod.outlook.com (2603:10b6:f:fc00::665) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.20; Mon, 26 May 2025 05:26:40 +0000 Received: from CH2PEPF00000145.namprd02.prod.outlook.com (2603:10b6:610:33:cafe::e8) by CH0PR08CA0008.outlook.office365.com (2603:10b6:610:33::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Mon, 26 May 2025 05:26:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CH2PEPF00000145.mail.protection.outlook.com (10.167.244.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Mon, 26 May 2025 05:26:39 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 25 May 2025 22:26:28 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 25 May 2025 22:26:28 -0700 Received: from BUILDSERVER-IO-L4T.nvidia.com (10.127.8.9) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sun, 25 May 2025 22:26:24 -0700 From: Akhil R To: , , , , , , , , , , , , CC: Akhil R Subject: [PATCH v3 2/3] i2c: tegra: make reset an optional property Date: Mon, 26 May 2025 10:55:52 +0530 Message-ID: <20250526052553.42766-2-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20250526052553.42766-1-akhilrajeev@nvidia.com> References: <20250526052553.42766-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000145:EE_|DS5PPFDF2DDE6CD:EE_ X-MS-Office365-Filtering-Correlation-Id: a8fe8027-3087-4f76-c2c7-08dd9c15e4af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: /mo9bLPKGT15wHASgcmrFjMz1nX29qn8H/YKvj2WqOG+1X0BNWsLlnNI6jR8W2k2hgKjTetxx75CFYgO+CAjH/qdGyPO303nrWXPH8Mge7zp621P+Vm3VK5sOIxyttA8gl9IXAETN0Juf8H30JFcqu2RwHq4AuTlkJOoKWnGIngFJiFYqJWLkbthzrys6Y9ohF2Ih9BAuieQqkAFTxIM/yk0XrUuWWdYcNIgwAEWfocs8xIdlvTwhySEleo9kfu2sBh9V8UTv/W0fOMHvop//SHAxN/VwTHDLvv+K6IiUdCTOr0QpRxAg8sC6kzeXoAKJYjI737xcDjPDYA9EuHieFZDXlwXn+mGvXQviYPkQwz/hb2cZimteUfQk2rD5JSVQtKumXVQiUggoRZiRwj2Ve3AxwmZi2eWq1UzL7L/9NxPrZ/HY3D32DfuTqic3e9CKkAp2RTY3bunPUTWOT1+DqP2NlVi3ybpS+bKIABOV4vQqUmk2nV3y45LLp9oz11y7t76qF5UU0nrim9PXP37Bb02Skc5hUeTDWNgMc0wn+RoI0K9tZ99aFziFRErHLTsomh1s6W2eaQHSA7YiprjpM0JSyxS+wtwVDajsgk7b71hko/VCSTBCwnVj0r6z+ulRqDPqeAHQGtg2KaenniHrNyfePTX07NA2r3mmS9Tf96y9U+AmxMJnUnIlU4bA/6xtSFO3KdfTxrU4ey9FOLL1TkQYclNZ/H1wO6kMji8roM8syGl5Z0SyfVB++pUzwiUhwm95VveRZLsDM8hERpBkySJrLeBS2WebDkZKwgM6DPMuoQOYuGfhxrxMCEi9LSpcz4Cxwp/vt6i6rNMxB27bHlWrHme1+1O7zbnZdIXFcKw0fPEiMX9gLthN3qxBIv3Ne1JqU6l2//MKZjSptNDYO7Vrf7uvzb+l5UNEi4ARZxXp7SdGU/AkuhsbjuOidFvTRcZbKeAya9mOZwFGqFcAeesa6l2yv6GCkvqWZY+HcgligLWxz3dXEMEa3Pk6ibKcpnchuRoS3PgVyg6SuaJd4KogFxbDg0wdn4bmOFWS0jNrR9fd4O6z9WOn593PQaq8ojM3CEtudCulq/zbVAtWa1pizW04Hd6y/wNBn6pPA/6G8VuHXO0WbiymXgzhZjxrX3+LzGSEf7F2CPOeNmMVM0YrJ0Y8ZldILsqpGQn/5U/F2EqVu8+M+ukZ3flRhMa9erS5ocYFfHd5IvVEegFSWN9O+R3H6jMzoEnQWpACf42u9JFxCyllPsC4q+g+hgAV/qE9Ko4sXOI3zrkgrLtU7U5h/WBac7P1P5Xd30s7Bqpu2GZJDvxXjmZRj529ZYftonYGvjCi/OlCW7YuKLmswgBctBmgxlHuiBsTzTTkJJVZFvGzJhvm4glwCKL/4JU/YNSFZzaoNP1wci9EC7e5a98PxjV/M30HB+GeyyTrHEdZt4dRbG6M1fzQUvXVOF3zcqy75e9vYEb0rknC1JAch5+G1gsf7QLu4xUO8DD1wfeg6WHNxRd2bCf777EjbQ+5vmTQVZ9XDMOvXC2eTiFYQ== X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(7416014)(376014)(921020); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2025 05:26:39.9989 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8fe8027-3087-4f76-c2c7-08dd9c15e4af X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000145.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS5PPFDF2DDE6CD For controllers that has an internal software reset, make the reset property optional. This is useful in systems that choose to restrict reset control from Linux. Signed-off-by: Akhil R --- drivers/i2c/busses/i2c-tegra.c | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 87976e99e6d0..22ddbae9d847 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -134,6 +134,8 @@ #define I2C_MST_FIFO_STATUS_TX GENMASK(23, 16) #define I2C_MST_FIFO_STATUS_RX GENMASK(7, 0) +#define I2C_MASTER_RESET_CNTRL 0x0a8 + /* configuration load timeout in microseconds */ #define I2C_CONFIG_LOAD_TIMEOUT 1000000 @@ -184,6 +186,9 @@ enum msg_end_type { * @has_mst_fifo: The I2C controller contains the new MST FIFO interface that * provides additional features and allows for longer messages to * be transferred in one go. + * @has_mst_reset: The I2C controller contains MASTER_RESET_CTRL register which + * provides an alternative to controller reset when configured as + * I2C master * @quirks: I2C adapter quirks for limiting write/read transfer size and not * allowing 0 length transfers. * @supports_bus_clear: Bus Clear support to recover from bus hang during @@ -213,6 +218,7 @@ struct tegra_i2c_hw_feature { bool has_multi_master_mode; bool has_slcg_override_reg; bool has_mst_fifo; + bool has_mst_reset; const struct i2c_adapter_quirks *quirks; bool supports_bus_clear; bool has_apb_dma; @@ -604,6 +610,20 @@ static int tegra_i2c_wait_for_config_load(struct tegra_i2c_dev *i2c_dev) return 0; } +static int tegra_i2c_master_reset(struct tegra_i2c_dev *i2c_dev) +{ + if (!i2c_dev->hw->has_mst_reset) + return -EOPNOTSUPP; + + i2c_writel(i2c_dev, 0x1, I2C_MASTER_RESET_CNTRL); + udelay(2); + + i2c_writel(i2c_dev, 0x0, I2C_MASTER_RESET_CNTRL); + udelay(2); + + return 0; +} + static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev) { u32 val, clk_divisor, clk_multiplier, tsu_thd, tlow, thigh, non_hs_mode; @@ -621,8 +641,10 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev) */ if (handle) err = acpi_evaluate_object(handle, "_RST", NULL, NULL); - else + else if (i2c_dev->rst) err = reset_control_reset(i2c_dev->rst); + else + err = tegra_i2c_master_reset(i2c_dev); WARN_ON_ONCE(err); @@ -1467,6 +1489,7 @@ static const struct tegra_i2c_hw_feature tegra20_i2c_hw = { .has_multi_master_mode = false, .has_slcg_override_reg = false, .has_mst_fifo = false, + .has_mst_reset = false, .quirks = &tegra_i2c_quirks, .supports_bus_clear = false, .has_apb_dma = true, @@ -1491,6 +1514,7 @@ static const struct tegra_i2c_hw_feature tegra30_i2c_hw = { .has_multi_master_mode = false, .has_slcg_override_reg = false, .has_mst_fifo = false, + .has_mst_reset = false, .quirks = &tegra_i2c_quirks, .supports_bus_clear = false, .has_apb_dma = true, @@ -1515,6 +1539,7 @@ static const struct tegra_i2c_hw_feature tegra114_i2c_hw = { .has_multi_master_mode = false, .has_slcg_override_reg = false, .has_mst_fifo = false, + .has_mst_reset = false, .quirks = &tegra_i2c_quirks, .supports_bus_clear = true, .has_apb_dma = true, @@ -1539,6 +1564,7 @@ static const struct tegra_i2c_hw_feature tegra124_i2c_hw = { .has_multi_master_mode = false, .has_slcg_override_reg = true, .has_mst_fifo = false, + .has_mst_reset = false, .quirks = &tegra_i2c_quirks, .supports_bus_clear = true, .has_apb_dma = true, @@ -1563,6 +1589,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c_hw = { .has_multi_master_mode = false, .has_slcg_override_reg = true, .has_mst_fifo = false, + .has_mst_reset = false, .quirks = &tegra_i2c_quirks, .supports_bus_clear = true, .has_apb_dma = true, @@ -1587,6 +1614,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c_hw = { .has_multi_master_mode = false, .has_slcg_override_reg = true, .has_mst_fifo = false, + .has_mst_reset = false, .quirks = &tegra_i2c_quirks, .supports_bus_clear = true, .has_apb_dma = false, @@ -1611,6 +1639,7 @@ static const struct tegra_i2c_hw_feature tegra194_i2c_hw = { .has_multi_master_mode = true, .has_slcg_override_reg = true, .has_mst_fifo = true, + .has_mst_reset = true, .quirks = &tegra194_i2c_quirks, .supports_bus_clear = true, .has_apb_dma = false, @@ -1666,7 +1695,7 @@ static int tegra_i2c_init_reset(struct tegra_i2c_dev *i2c_dev) if (ACPI_HANDLE(i2c_dev->dev)) return 0; - i2c_dev->rst = devm_reset_control_get_exclusive(i2c_dev->dev, "i2c"); + i2c_dev->rst = devm_reset_control_get_optional_exclusive(i2c_dev->dev, "i2c"); if (IS_ERR(i2c_dev->rst)) return dev_err_probe(i2c_dev->dev, PTR_ERR(i2c_dev->rst), "failed to get reset control\n"); From patchwork Mon May 26 05:25:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akhil R X-Patchwork-Id: 893428 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2051.outbound.protection.outlook.com [40.107.244.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 378DF1BD9D0; Mon, 26 May 2025 05:26:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748237217; cv=fail; b=JGUKw+WgUmo214HHRHdIOPaBF2RAjb7lYobt60tl2Yy9WEzEJKlfsgbGXB9o1OA8UQlJbhcYUgtULauicW9kEyUHLf8DYMHHATE83rKBZpyVDtav0/oKbCrYiV7mP/hsRTS/OKybBcBVELs2XWTxOnAJe18RyeyaAX1VwipKGbs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748237217; c=relaxed/simple; bh=tV2RVZAwY8i1E5kJgxB3khakK01zFMaYfx5b0aWtPho=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GvnY3YaO05qVgafoCbB2XM9P5G1VnV6/xk1qV8zRSftf70MKUqZmQ68FxQbqwqYKPV0kszuqTAO4nKlE9lZEJuxfg69iummHgZXNWMrmjzffNWZIEXuzhNDnW/9arrmoQOd33+0F6rWGpWaWN71SXSnCS3608KCE0EeRrGyNL5I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=kUoQnPFL; arc=fail smtp.client-ip=40.107.244.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="kUoQnPFL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O8BjTM76zrkn0SRlixLWXuImfSBvvlOukZBsE5vwc/8k7CulYPU14vsbU5Rz4OUXK3EGVjOa+3gFh98GfgvaHMtL8FYvtf6d707QleGFvr/emwAcYBneQ9uCMoPu8LPtao2rs4IeH1xHvqZgdNMIIWxMIoC3hWPg0KDTzZYEN1JgTe9h6s+visKSWX3DOXXFjdnM12Eww7tZa1PiRs08mi85ZV3ef2YNooQ0AXKB/egkVtOiXqvcu1NpQdJo3p6pURmv4ZetdNB1WBcPuy/auf9+4ujgFmeBe1OQmiJIe0ZtZsZW3Sxm+LJzJ8HCj/b8eD0Pb7+b1ztOx02ZgDWR6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=13DO5UXDVBpS3CpfOPDd4mgkC3tPH2z/Ri531CW4U0w=; b=SH3Buf/+ZUUULDY7PEpc/kRvxWjLNJidJFOanJKzXQlSxm5mSrJ8E+MWkdhOCpveEvQq7akYY5Qfz74sbRANrK9jLEfk3yArQnQKa6qcY2sSO989jipDki7k6WzIsUgAI6vhgQadzhdelKtTXIEhtRTGm3YXhGKgSgli4u3fp+l/+3gQsic1RyrC8VbENXnvwf5M7Y4WnBHNh7AvmrVibIhtnyJOHYvmtXvfPxFjmMPLFkCq9YPdUsIzc8d4hYyN+6HSsCTfEE11OAA0t6qtpgdOSRHepJUluMPNBkUDJnndwKD4rjVjtQzo9Hb/SQ+Fn2sWq6Yu+rRKp9R7ZymGlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=13DO5UXDVBpS3CpfOPDd4mgkC3tPH2z/Ri531CW4U0w=; b=kUoQnPFLh3EHztglKf130v3Pp3J9mSTzZTtVFMO+KU2oZVnFo+T8hcDMgjatLEw26fhN7vPB2R96af0dqtyZ6eEKdTmfqZ0w92XVLOi55egOn/W66fiDuxQaa5Zd7hgFIcqnUuiWxti8oIdxfD8wwPvhgFyTsAnqxvCz1yiD2zP3y9fGTIXaQX+4fxBRZfoXPhlqjzDmlOH0woGAVcTgPfSjNBHO/TLD738xV/5v0RuDRPf2oXukYtPV9MB7LxMDJUp8G0yWoG98n3jd4Wa2iluEa8SfMFAxswpf35r6thHabn1j7mWUyZpcr/GXuxQW215AJFkVFwQXZD15NHDMLw== Received: from BY1P220CA0003.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:59d::10) by MW5PR12MB5683.namprd12.prod.outlook.com (2603:10b6:303:1a0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8746.30; Mon, 26 May 2025 05:26:51 +0000 Received: from SJ1PEPF000026C8.namprd04.prod.outlook.com (2603:10b6:a03:59d:cafe::c8) by BY1P220CA0003.outlook.office365.com (2603:10b6:a03:59d::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8769.26 via Frontend Transport; Mon, 26 May 2025 05:26:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SJ1PEPF000026C8.mail.protection.outlook.com (10.167.244.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.18 via Frontend Transport; Mon, 26 May 2025 05:26:51 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 25 May 2025 22:26:36 -0700 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sun, 25 May 2025 22:26:35 -0700 Received: from BUILDSERVER-IO-L4T.nvidia.com (10.127.8.9) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Sun, 25 May 2025 22:26:31 -0700 From: Akhil R To: , , , , , , , , , , , , CC: Akhil R , Robin Murphy Subject: [PATCH v3 3/3] i2c: tegra: Remove dma_sync_*() calls Date: Mon, 26 May 2025 10:55:53 +0530 Message-ID: <20250526052553.42766-3-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20250526052553.42766-1-akhilrajeev@nvidia.com> References: <20250526052553.42766-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C8:EE_|MW5PR12MB5683:EE_ X-MS-Office365-Filtering-Correlation-Id: 70010a11-b2b2-4317-6ef0-08dd9c15eb7a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|7416014|82310400026|376014|921020; X-Microsoft-Antispam-Message-Info: PrOHhErzvTBn6v2D5aVG8b7I1GjNGXoFrjUahyR14M1OEgnFi6o9JtcJW2pH+ZbPVMj9JZpzip3RmYBKn35OL6RtbUUnq5VjK4n4BTOOQS0shfH02ODEzy8ObyZ1YQx0hT6EOGoJKV/1szfCOJoqYStcHKDEuNTllfdVbDb2xlqBFJWXysP9hXoKfw/nXpucfFkRuXT4T2Z4h4b+SFBEIstEkyNe5KDeVyoVfPcggg3ChtINjL+XISn11s8p+nsKcYHwPN898hS5N7wnOc4qjymBTyL+kahd1DJW9fSFO6kHmzVz46ZoN62y83s4XT99esOyv4Y6udfFzybMkS/CyGGBZcclHElBUOZK9YCHtwU0LmdZy29ZkRUSkroSYuhWbFL0X4FZp4EWr7eJ9yDyxnBdRc7bS52crFW7ZlfosGY8688d2Df8RLeB50mm8lXD2WRBQAhT33lIpuymHvaJSR2FYgNDVXeaeymyNPFekXbHTIBuw4lmdV5MwEzQBvXsqAqLcxM+MjwkoraBM4m0hTafceQ1pw5hEnnRcgKI6R3Bl08pyejERavoeePsFpkZizGvzccQbADOiNA1ewsMMNGwaGJs0t4l7LBWbeSz/qMZsND4XDSbxU2Pp5l7GHd0ESggOUqPQcVN/w/6q1mm8VskYEeI4QHsXkN8430T9zPXhVQznDQGPeH+lI70IhrtzZctU/83F2tEGnzVl/LwTHtqzDj7zQDa85gsp7tLMkCpszJJ8A6yslJ2xjZMp5Fnr12P7Csa2H8eUNV0vV4lb2Q83WORn53rPBwXzSuq8ISLbQL3Zu2oBYQ1v1lWMRgxz4LpJBMAVmYgL1c6tf+UZU9RhLXc0zrxnP+S9llLy0bUV4QBirFo8moMUvjMGD5vpIg/DhQQ3LrlyZhVjQ6YDWqDWAPDS29qfLilRebGGVP5Nb7BHIkBxNQJx6S8MNExQ749mZtzqahq04TGBYJuumbW/J0X8IBFeJ87MzWycMYBswOi3B5a0vREbkJ7Q5Q855cayQ99xmGC9R9WoEyXfr4n4pVeISiRr5mJSnIRLBthRjKWsKR+p8IwXPR189rlqRnxGjSy32JQx+miB2wkP8QPKUg/Lr0/IjTzUIl01pUAf2SpSjJ4t/jPstigwXZIatmnQk39ETi5q7OfyWkJ3o5takJlcDURC7OGwTMI43oKzWlUsCPoSWHnpw6JrQRs3j3NUiIpbn0UeUIq14EOLFT3TkyV8vdjKmDZ4td0AehjpUbVHhJhmDeeFNBX5fv0fZks6XlgR0J/LrPfaWnQRHF6qfvOFJCBt8l/Y5nGvPX84KnC68zbLBP+DRFiVtpzy1FsIs7/GDFCmbuxToY4nAFXU1sQINniAVwr6EUJ9O/uyyPJdcp3DZgosRsVWwFWUVDjVHM/LiH9FakyhwksOTN0+wJJtWEowAoOvzXsHSUENjeIan0d55Rhwn/c39eyE3bwB1oV/Iqp9mQyJxHUEPXprX0rkrcUBpTBMVLTb7zIX0cfQO0p8W7YNxqBrSQV9Ur84n9XzHP9NCipR0wzfw== X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(7416014)(82310400026)(376014)(921020); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2025 05:26:51.4827 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 70010a11-b2b2-4317-6ef0-08dd9c15eb7a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026C8.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5683 Calling dma_sync_*() on a buffer from dma_alloc_coherent() is pointless. The driver should not be doing its own bounce-buffering if the buffer is allocated through dma_alloc_coherent() Suggested-by: Robin Murphy Signed-off-by: Akhil R --- drivers/i2c/busses/i2c-tegra.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 22ddbae9d847..b10a4bc9cb34 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -1292,17 +1292,9 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, if (i2c_dev->dma_mode) { if (i2c_dev->msg_read) { - dma_sync_single_for_device(i2c_dev->dma_dev, - i2c_dev->dma_phys, - xfer_size, DMA_FROM_DEVICE); - err = tegra_i2c_dma_submit(i2c_dev, xfer_size); if (err) return err; - } else { - dma_sync_single_for_cpu(i2c_dev->dma_dev, - i2c_dev->dma_phys, - xfer_size, DMA_TO_DEVICE); } } @@ -1312,11 +1304,6 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, if (i2c_dev->dma_mode) { memcpy(i2c_dev->dma_buf + I2C_PACKET_HEADER_SIZE, msg->buf, i2c_dev->msg_len); - - dma_sync_single_for_device(i2c_dev->dma_dev, - i2c_dev->dma_phys, - xfer_size, DMA_TO_DEVICE); - err = tegra_i2c_dma_submit(i2c_dev, xfer_size); if (err) return err; @@ -1357,13 +1344,8 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, return -ETIMEDOUT; } - if (i2c_dev->msg_read && i2c_dev->msg_err == I2C_ERR_NONE) { - dma_sync_single_for_cpu(i2c_dev->dma_dev, - i2c_dev->dma_phys, - xfer_size, DMA_FROM_DEVICE); - + if (i2c_dev->msg_read && i2c_dev->msg_err == I2C_ERR_NONE) memcpy(i2c_dev->msg_buf, i2c_dev->dma_buf, i2c_dev->msg_len); - } } time_left = tegra_i2c_wait_completion(i2c_dev, &i2c_dev->msg_complete,