From patchwork Tue May 27 17:11:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Florin X-Patchwork-Id: 892834 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C9FB27E1CA for ; Tue, 27 May 2025 17:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365895; cv=none; b=gsez2X0/AaEY3PUrXlKld9ef+6g6V7R5pdH4YVGqe7Ph5Nf1twbDe9u5a5V/KFJmhwbdZbk3JeHHA4QNHtGkamN00aZUZOhHH2FsJAPk3P26LWRSHUI9AzbqdOnR86xQVs8lcxAkvdHsSpzXzsGQ4kEiZEsiuRNqmZe6LHmhJZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365895; c=relaxed/simple; bh=xRMf5TFiD3IukzwA+3BGS+BrEX4qd2fgpFwrTPSzcOY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=T0JYcrNQzSscHbrHzxalDXs0sUnwP3+4AWgGoZgaYjh8LwJ65/cU+pe0M2E/G7kJ9yTDENJdOgdIJqxagJuq9+Nl/3cNEVijYL/mol8Spjif6uHdVJy0jUYCvv1C2yEG+J9apZtv/SPnDcWsJ/foNy1Nm5i41YQCqmt3ALvE7r0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fRH4nzOh; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fRH4nzOh" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-22e7e097ef7so26466625ad.2 for ; Tue, 27 May 2025 10:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748365893; x=1748970693; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EGpgHQv1Yjhu2NBPNLoBAvCrufXEESK7KYUZZgAiZNA=; b=fRH4nzOh55pr/Z2cuajsgScgvwEXUIlnOPTYNiVs5aOJ6OA9A7WWRfWfa9AlxbfxFz fejADglo52pU5xhA8iGUF3KShmAZVKM44UN0gHkrtY1LNO1FTRsQzDc4YpgrcARd78qD oMeCAAnVpUPTZKT4h0hRva3hcZluc6akFqtkZW1Ru+E+2w5VuPA7Gev/M6me6/Cqp3be q3fTLqdWk6csxFA2IGDwldrqFrkiP12pa0cXfE8hKB+4iBXcd5BLcAd2V9jMNDfOobS9 rQOVf320Jcuk706iDDpuxb1ZAY9wuToYZHkeHL0L5SMLk26ZCSrmMydm04AOuoex9FG9 J73g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748365893; x=1748970693; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EGpgHQv1Yjhu2NBPNLoBAvCrufXEESK7KYUZZgAiZNA=; b=ir/p0Hff/etnVfokJOEPlQ5u1SGDIWpznMq21ZpXloc3GepeYjUVAPtWHlY+mZGhRX NmN5u8pZdCZmgVTv3PZdHaBUriRqm0pOdgxDWJGtZXUfsbq6m3us1GdEnnQF+8k+kWVk xu/QUlDjE7kXXQ39CgM98b2RGs92Jp3z1SthriT0oB7vbwn9Gzh+pqANjPmJguxTbMT+ HSKRWAiwzgqFvdLRvevksKE8i4JEwTVAd0v4lmh683Qe8adWZojgzov2tvSid4zG09oA AtZmRnNGOGtVgbjqcg94O1v349T5WzhRKcqb+7hBvlAJJopM22OMhJGQoIuGwmTuW78R 6AfQ== X-Forwarded-Encrypted: i=1; AJvYcCVBWDql94cWHhTw/Z6sf/9Hdoy5btvnjMURYX0Hk92bvN45P6YloR6pCDMTBlND+V6bcQnwAC6kod7Rrw==@vger.kernel.org X-Gm-Message-State: AOJu0YwnsyRHUVrabG6MUhF2hevLmNlqdOOLF+0jNXafpmq5C+/o061u 0JzRBxIph9Ym2zojMTYbRwOqDDvchvsHshEkNcLrVeHfDajda5AA7If2H2AqAB6eekG4jWyAxix AYzGUfhyqNzlI+W3oIJl/9w== X-Google-Smtp-Source: AGHT+IE3WTlFx1duweMWUtRWUZ+stTGECKFWb4JdL2WHNP9bk0YeoZVjs0fdXgZHMKS+hrjElIbb6qMFX7sMB52f X-Received: from plbld15.prod.google.com ([2002:a17:902:facf:b0:234:1b84:9778]) (user=ericflorin job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:3d0e:b0:22e:59cc:a44e with SMTP id d9443c01a7336-23414fce054mr185474395ad.44.1748365892870; Tue, 27 May 2025 10:11:32 -0700 (PDT) Date: Tue, 27 May 2025 10:11:23 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1164.gab81da1b16-goog Message-ID: <61e6984331cc7ff88a9f8207e187cd5b9ffd9c63.1748365488.git.ericflorin@google.com> Subject: [PATCH 1/6] staging: sm750fb: rename `sBase` parameter From: Eric Florin To: teddy.wang@siliconmotion.com Cc: sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Florin Rename `sBase` to `s_base` in `sm750_hw_copyarea` to conform with style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: Signed-off-by: Eric Florin --- drivers/staging/sm750fb/sm750_accel.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 44b9e3fe3a41..74e4be8103ac 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -132,7 +132,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, /** * sm750_hw_copyarea * @accel: Acceleration device data - * @sBase: Address of source: offset in frame buffer + * @s_base: Address of source: offset in frame buffer * @sPitch: Pitch value of source surface in BYTE * @sx: Starting x coordinate of source surface * @sy: Starting y coordinate of source surface @@ -146,7 +146,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @rop2: ROP value */ int sm750_hw_copyarea(struct lynx_accel *accel, - unsigned int sBase, unsigned int sPitch, + unsigned int s_base, unsigned int sPitch, unsigned int sx, unsigned int sy, unsigned int dBase, unsigned int dPitch, unsigned int Bpp, unsigned int dx, unsigned int dy, @@ -160,7 +160,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, de_ctrl = 0; /* If source and destination are the same surface, need to check for overlay cases */ - if (sBase == dBase && sPitch == dPitch) { + if (s_base == dBase && sPitch == dPitch) { /* Determine direction of operation */ if (sy < dy) { /* +----------+ @@ -234,7 +234,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * It is an address offset (128 bit aligned) * from the beginning of frame buffer. */ - write_dpr(accel, DE_WINDOW_SOURCE_BASE, sBase); /* dpr40 */ + write_dpr(accel, DE_WINDOW_SOURCE_BASE, s_base); /* dpr40 */ /* * 2D Destination Base. From patchwork Tue May 27 17:11:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Florin X-Patchwork-Id: 893417 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BA8627FD63 for ; Tue, 27 May 2025 17:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365896; cv=none; b=iQ+RbxloegSow5E0CgsnBZ/dxOBJ0bNiDrwyW8YpGBny8Xuodxbpce0tbHgyBwdjpeZFYqzJH3eD3gmk34NeyyyqQH//+kC6N+Kob6tI+ByfXLcnmzkUh2wmhJ8dF8cFlbsOxK9SoQXwQIohsMgoWs3aqxoSaMzSg/BPwD5Fxmo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365896; c=relaxed/simple; bh=H4TqEXIjlqRG2Bie9YYiQ3GcjAC/tlMYkOyueCKVWnI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=X0L+KBCyTjzghqAW4ceEeaUrDnohTej7jwA9r/pM62Td9HR7IIufg2Pi4RwXNLImp2pwaV5ydjCWf95PtRo8sq/kwdOTl7layBPN4ICo7/YntjvPFeoAQqZbPZklw1jYoOas7S6IosvOZzvZYnqTeNJ9TsCef6/CPulM6OYajE4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=iYRnx5Oh; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iYRnx5Oh" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-23443196f00so37582645ad.1 for ; Tue, 27 May 2025 10:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748365894; x=1748970694; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ngriwog0WV6bwjlrawORboMmBAKwg+7ahv2Ua2MbkWI=; b=iYRnx5OhQbyQJRBAzFCihU/ira5ZQ1XuEV9MxXLmMDN6S2iZ/So6fNR/S5TMF9DT6Y dNsS/mGTyjyAAVqxE6dsyfs8XOD0LrlxMs8IiF9kCYvzYeCFBRvEiSrbXhaW+lGwBq7M yIbw4VObyW4RUF04e8zn+M8GR3e6WHrq6lN3p4290ItdwxTMUBMegDV9cycauZHkaYD4 Xmf8uzjj76nYOp71oAcFm7OZkTUARsmb2XET5P/MzP45DTopGvmYGC/4cOVV1QOcyEVl FO7XQFokND/t9hr6NsvVQwF5Po8jgimO//5G/s2zEJI+nr4/EyJU266cGjRGYN5PFbKL xlqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748365894; x=1748970694; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ngriwog0WV6bwjlrawORboMmBAKwg+7ahv2Ua2MbkWI=; b=jm3kT82tdl4D0ZcBk63DV4U/k8tphBssCoBm5uUPulTQPIwlOoD+D4b77uOc9hnajp EzxrmAdtAfMKQM4vGfMTVUNZmcBUckgF/t1eEV4Xz0Wlz2Y3hrYdPh79J96npvykbW6l GIwnqOny1f5tL1oBDCCjdcx7huaC4Ul2/U+vzqUUXGhXO1AuCW0xMXprk5UfAV9wouBY Py8f5f2tq9sYY2GPPV2l3QTME/d/7x3TWg1zH09mukklUq/0EyUSWNyqf+qI2lKR+ZgD x23dYwCRUh5AqvWVYP5l9qn/rqSXagV3yeAIZnozOmzaX+FiejrUj/mw8CYAyefEeiQ5 92Aw== X-Forwarded-Encrypted: i=1; AJvYcCX000OX6jV6YYXo5qjdGrpxeeGs5j19qvFcYaa9S7hTpXrL47Mfq8nrpfh8oR8oDJrt5MJS9YAaW5+ljQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yw3VpnpGEjgCWh7NtAypFhXqHfIOktY6flufVl1BAIoWuDFHNVo CBEXLKE/3TVqCu65s216v8PG7vzD898KMjHbmsN/opv59ykG3qd1nffcSIu7mq+i9WqZWTDXUCG R5HRmqxQgGGzGERN4OyyIKA== X-Google-Smtp-Source: AGHT+IEy6fu/76cZYpGjBrmomtCPA6OCWfT7RStBFgB/RS+SDT6QPi765w8a04wj7CvCDq5hZHQLy60AW5Fn7wpF X-Received: from plos6.prod.google.com ([2002:a17:903:1ac6:b0:223:690d:fd84]) (user=ericflorin job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:19e3:b0:224:1781:a947 with SMTP id d9443c01a7336-23414f5ccb5mr235064785ad.21.1748365894466; Tue, 27 May 2025 10:11:34 -0700 (PDT) Date: Tue, 27 May 2025 10:11:24 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1164.gab81da1b16-goog Message-ID: <0ee15444dc0f9430b1c7836c565e305b6dab823a.1748365488.git.ericflorin@google.com> Subject: [PATCH 2/6] staging: sm750fb: rename `sPitch` parameter From: Eric Florin To: teddy.wang@siliconmotion.com Cc: sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Florin Rename `sPitch` to `s_pitch` in `sm750_hw_copyarea` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: Signed-off-by: Eric Florin --- drivers/staging/sm750fb/sm750_accel.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 74e4be8103ac..029f5c013d91 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -133,7 +133,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * sm750_hw_copyarea * @accel: Acceleration device data * @s_base: Address of source: offset in frame buffer - * @sPitch: Pitch value of source surface in BYTE + * @s_pitch: Pitch value of source surface in BYTE * @sx: Starting x coordinate of source surface * @sy: Starting y coordinate of source surface * @dBase: Address of destination: offset in frame buffer @@ -146,7 +146,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @rop2: ROP value */ int sm750_hw_copyarea(struct lynx_accel *accel, - unsigned int s_base, unsigned int sPitch, + unsigned int s_base, unsigned int s_pitch, unsigned int sx, unsigned int sy, unsigned int dBase, unsigned int dPitch, unsigned int Bpp, unsigned int dx, unsigned int dy, @@ -160,7 +160,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, de_ctrl = 0; /* If source and destination are the same surface, need to check for overlay cases */ - if (s_base == dBase && sPitch == dPitch) { + if (s_base == dBase && s_pitch == dPitch) { /* Determine direction of operation */ if (sy < dy) { /* +----------+ @@ -251,7 +251,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, write_dpr(accel, DE_PITCH, ((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (sPitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (s_pitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ /* * Screen Window width in Pixels. @@ -261,7 +261,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, write_dpr(accel, DE_WINDOW_WIDTH, ((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (sPitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ + (s_pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ if (accel->de_wait() != 0) return -1; From patchwork Tue May 27 17:11:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Florin X-Patchwork-Id: 892833 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3BD6280303 for ; Tue, 27 May 2025 17:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365898; cv=none; b=ROgkEK7Sr1ACfCKrKYqgM5VMzMEIJ3QnK/iGLzATwA0bubbPwC5yfwVMaL8/Z/jS5NVe08wAeDjiw6074oYJV/l6U7degSQ8ZGi/9rdplbNMc2HMtsDEVTt+CABQyzHK2a/IsQV1Zs7DmrCxC+AsG4UirswiUftoH5/bIciRNbM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365898; c=relaxed/simple; bh=IxmY7857XxRCML+mmmkccQP5aewturlw2/qLm8OGYQY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=S2i0hAEfsc7JppUA3DJiioe4IyzqltRBCXlJHZfWA2AyNBH08bk88L6qftc0ThivitGqi2C8zKbfdOd6ju7CVaQud363i3nKcN3KX0VJgg418nHyP8mccRAoYwnX1HA6M3czG9dUk/65oGEdblzTW0X0g7WadeZ6x+Xrwy3ucH0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Yak367z1; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Yak367z1" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-742c03c0272so4506440b3a.1 for ; Tue, 27 May 2025 10:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748365896; x=1748970696; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=pdqg5XvDH208k/LZjDauOKrmgmkkgqZoXO6mZxQvsJE=; b=Yak367z1GuVZWG7nbaxCiCD0qTPfnqYCD1orYfLKwfpDl+k0u3MQ8QvvW8cC+DV/aN bKErgaqE+CxCNCrfXa+cUzleu50NVGiwE80/V3bv4UD000lLr0e+3QVL3QtetrKMHY92 kIsmm9J8xw5oNeS8CuysnC3U8BlF7IGszMXL40OAPZ9nFCx1BC8HgOJ9DtBOYL4yewaP iK5EItxGeXZsWmy7YEDIvjNjiKPA/O3roMD90CswGZTNPDNaDVn5RK2V2ca1AyvAuXRw NhhtcADc9uq1d1/RtrpfGGYDfAV8yVeWAugoVWSH6cAbdFXpUH5pZvqrzdaJjY24fVVz gYLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748365896; x=1748970696; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pdqg5XvDH208k/LZjDauOKrmgmkkgqZoXO6mZxQvsJE=; b=CUvjCem/xuu3qvy+ekDv6TYF7I6q3zkALDlzeURcTx4VQIb/czqKOssY/R4BXn1ina +PnsmJ3MfgD+qFcMh8irWmFJvwkOH8tAGDkdtmVRyeAnkL6lOpa14in6bL/z5/7R8C6s RvHmu4XKnXl9pki1FLU9rRMnpYP64bRpDwv/GFInUuVUKm9yPA86cj6u0+kWBMncXD5A 1Ow407/GjtVdzi2wrBv6IEdei/8t9b7k/onIMjD++8DnBHaUSgGF4MU8Cfogn226fSfJ TC6sSfKFgnbPp9Y6z3Erd/bKIep+c6I2EWMh7fAp6CQOKuH2RWJRNcuORF9BST/Dad9G Vtkw== X-Forwarded-Encrypted: i=1; AJvYcCV1ez5wmq5vCfR+1XHlv5yGymNXqSD3uehDSe0CW+NVuGrkjibV5Miq6uHHOmIBqWIqolAQHqfbnRK9bg==@vger.kernel.org X-Gm-Message-State: AOJu0Yy9Z9dipncjpc7xTkHHAExaERrSsC/Hqb77Kl/3ys8671ndr6eV hESjF+6VoLrwKIlOyn7/ZzEZW6QpjfFFG0eBjtrixPCctt2fOcTtQHYHVPMBhRxgFoXrvViCjui 23UA5jBJD/dv4Pqb5lEJ/JA== X-Google-Smtp-Source: AGHT+IH5+jOjV6AZnNuwMZ9fasseQwb0SSCynSsK1tPRGYJuml66W1Zl/d64TGz0CjCDJYTLB9X2dGkAoxI8hH/Q X-Received: from pfbim3.prod.google.com ([2002:a05:6a00:8d83:b0:746:3185:144e]) (user=ericflorin job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1149:b0:73d:b1ff:c758 with SMTP id d2e1a72fcca58-745fe0515b7mr22869683b3a.18.1748365895953; Tue, 27 May 2025 10:11:35 -0700 (PDT) Date: Tue, 27 May 2025 10:11:25 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1164.gab81da1b16-goog Message-ID: Subject: [PATCH 3/6] staging: sm750fb: rename `dBase` parameter From: Eric Florin To: teddy.wang@siliconmotion.com Cc: sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Florin Rename `dBase` to `d_base` in `sm750_hw_copyarea` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: Signed-off-by: Eric Florin --- drivers/staging/sm750fb/sm750_accel.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 029f5c013d91..e5f1f021768b 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -136,7 +136,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @s_pitch: Pitch value of source surface in BYTE * @sx: Starting x coordinate of source surface * @sy: Starting y coordinate of source surface - * @dBase: Address of destination: offset in frame buffer + * @d_base: Address of destination: offset in frame buffer * @dPitch: Pitch value of destination surface in BYTE * @Bpp: Color depth of destination surface * @dx: Starting x coordinate of destination surface @@ -148,7 +148,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int s_base, unsigned int s_pitch, unsigned int sx, unsigned int sy, - unsigned int dBase, unsigned int dPitch, + unsigned int d_base, unsigned int dPitch, unsigned int Bpp, unsigned int dx, unsigned int dy, unsigned int width, unsigned int height, unsigned int rop2) @@ -160,7 +160,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, de_ctrl = 0; /* If source and destination are the same surface, need to check for overlay cases */ - if (s_base == dBase && s_pitch == dPitch) { + if (s_base == d_base && s_pitch == dPitch) { /* Determine direction of operation */ if (sy < dy) { /* +----------+ @@ -241,7 +241,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * It is an address offset (128 bit aligned) * from the beginning of frame buffer. */ - write_dpr(accel, DE_WINDOW_DESTINATION_BASE, dBase); /* dpr44 */ + write_dpr(accel, DE_WINDOW_DESTINATION_BASE, d_base); /* dpr44 */ /* * Program pitch (distance between the 1st points of two adjacent lines). From patchwork Tue May 27 17:11:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Florin X-Patchwork-Id: 893416 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24DBB280333 for ; Tue, 27 May 2025 17:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365899; cv=none; b=o9/X3tJ9lfDSOwMMQdCjG6rhgelSUfPc4+hbei8Q63YNl+b1lVfopccONT8nAc/PFWtGbX/FyRBd8eFjNfTKnGWjlALwIHePc1H46moYbOuPvoy97RThJ1uwpIq4Bh2kj29eDDreAPLXgnMEIAqL/fjR17NIeY1mZlbstKHbsW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365899; c=relaxed/simple; bh=Bvf5XzmK1C7KFxHxm1e5k5vvsnilhL9xB57W1UxAvJw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=PcynnNQIA7PJnVibjrGai0X+xY/NjYTdm1OH2FJyaFSVyB2YqFrMvYwkXxWzZ11LHi9o2OS3oYqkOKI6rLG7IoPZX5buP3FhIa73ZBi+IG8csTUwrtGrneavNfXS8psTY5US4ydKz0KIg/1G7YAs1e+Sag4CSKf83r87Oxyqv/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=uF8W7Dfi; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uF8W7Dfi" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-742c9c92bb1so2654547b3a.3 for ; Tue, 27 May 2025 10:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748365897; x=1748970697; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=6I084BRg7r6NYSuT/XB9CcOlGWZUT2LEK0eREcn7WlY=; b=uF8W7DfijwAYNb8FmYA0sGajcm1OG6VLxS33JLFdKanmDXfGWTKDFIhIW+E6V75W3k aLwnHG2WSIsv3XnPPOTPkA/+Os2SkjwtrvZ2+o1zr1U6dSmtiV7LgeGhqw6hFo75iWR7 4kF4M8ep+dNaV9gtsM0b/Kic9Pe1kwcBy4MojzGdMvdN20clh0QxOpJaB7DgE0aWiUt0 rAlAS7KrvObfYM4LYX7WdwxzXNqiCNE7ukfGsxf3BdPP9gRJO/n6b8WJMoO3PL7GUx16 YlbWslHA1rsrRDExSQlNMD2N+A1rHKmylKrqiWJp1AcFL2W039/lReDQRysr4RbvtoXE GLig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748365897; x=1748970697; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6I084BRg7r6NYSuT/XB9CcOlGWZUT2LEK0eREcn7WlY=; b=r4BcZwapcoCya/6ibU0UZZJ2RrTiikZGPWFpOrRxd/yvGTpRVJRgOEtgVsOnnXhR/W pG6euCtJLvlU3pBxbO0ILNMtVIuvZzI5f+wn4RyThvY1R7Y8rcVgU8QvbaXVP0XKKpiL JIUanOf8UAoAdu24uObvORSra/wyufcJy8EFEEvPMmGAifmaA+sMFtZi+rtUzDgS36G2 CXGjMAoUzOxLT+N3+NXC3DkUV9Y6fBFJONAlpBI5tWEp5DKGw/4evGQA/DG/eHhFHZ/9 OaAhPURIzMHvu+7ohojVO2N/mMNjq7znoPTD9RnEsSXcsnbqZXx+vy8wBZKPI5Y+y29e Z5eg== X-Forwarded-Encrypted: i=1; AJvYcCWkiFPZNKngHWfWGaBuYOqyeHBTEFJkOF8cblqHjvrXnipyfXaI7E86WvSaMosJ2A8IJKYwgqUEphcabw==@vger.kernel.org X-Gm-Message-State: AOJu0Yx71sltSZUQYZcL5HMvcNIyM2m8JqnU8RarrEaS5v7O9jSAmITw ucJ5+0aFB7nGmyw9kErFLNXCcd9Blw6+Ox0aNO4rH1inLzehEb83OHvlp3Wbme0eWDxNlhHHb7o qkbs9sI5zRSLUmB2GQsAEcw== X-Google-Smtp-Source: AGHT+IGZJsWT+MI+7toTUBwc8TwoPdXf5QX/ZfY+HuOurMgYLS6kCgj3PSDcttemfwybHe/5BIi9lzwqWp0FaNq9 X-Received: from pfbko5.prod.google.com ([2002:a05:6a00:4605:b0:740:555:f7af]) (user=ericflorin job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1822:b0:742:a5f2:9c51 with SMTP id d2e1a72fcca58-745fe084addmr20441201b3a.16.1748365897406; Tue, 27 May 2025 10:11:37 -0700 (PDT) Date: Tue, 27 May 2025 10:11:26 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1164.gab81da1b16-goog Message-ID: <5250c76b824f133c04135b0d82b18d85cd958852.1748365488.git.ericflorin@google.com> Subject: [PATCH 4/6] staging: sm750fb: rename `dPitch` parameter From: Eric Florin To: teddy.wang@siliconmotion.com Cc: sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Florin Rename `dPitch` to `d_pitch` in `sm750_hw_copyarea` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: Signed-off-by: Eric Florin --- drivers/staging/sm750fb/sm750_accel.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index e5f1f021768b..ea64e10d4814 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -137,7 +137,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @sx: Starting x coordinate of source surface * @sy: Starting y coordinate of source surface * @d_base: Address of destination: offset in frame buffer - * @dPitch: Pitch value of destination surface in BYTE + * @d_pitch: Pitch value of destination surface in BYTE * @Bpp: Color depth of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface @@ -148,7 +148,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int s_base, unsigned int s_pitch, unsigned int sx, unsigned int sy, - unsigned int d_base, unsigned int dPitch, + unsigned int d_base, unsigned int d_pitch, unsigned int Bpp, unsigned int dx, unsigned int dy, unsigned int width, unsigned int height, unsigned int rop2) @@ -160,7 +160,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, de_ctrl = 0; /* If source and destination are the same surface, need to check for overlay cases */ - if (s_base == d_base && s_pitch == dPitch) { + if (s_base == d_base && s_pitch == d_pitch) { /* Determine direction of operation */ if (sy < dy) { /* +----------+ @@ -249,7 +249,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * pixel values. Need Byte to pixel conversion. */ write_dpr(accel, DE_PITCH, - ((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((d_pitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | (s_pitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ @@ -259,7 +259,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * for a given point. */ write_dpr(accel, DE_WINDOW_WIDTH, - ((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((d_pitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | (s_pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ From patchwork Tue May 27 17:11:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Florin X-Patchwork-Id: 892832 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9222F280A5A for ; Tue, 27 May 2025 17:11:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365901; cv=none; b=nF8qDKuPKJcnACZS4eURMyXyEZAAY4CGqO4EpjSS4xEaJ8RfN0S7mFqLFqEVwJmuWX0bdwvT/kMX00BIzkEsMURGz3jSl/5du4bZkyd3cnIQkYvBSIUPqIdCvcFLhl8qQ7PVGkCkc7YUU4fZ4UbRWxIOdp4UdNDewrOH3Gxw9Aw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365901; c=relaxed/simple; bh=awIVsMJIo6c6lxHwbHS1OrLq4nbMwYCl5k5skXygSzA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ILXbddNreEDZFcdc3b1l/tOarDPBcOJG4/MMPvlITPIvEztYvluEtTmqXv+LdfoVBzyTXSd4LDLVP+DeVCOxM7Fr0hS49CuReuVhO8F6l3aJE9kruQlJO1HeXCnD7jXm/4qRCQUiaNn8so8bLGHO42lVuf+tTd33vNGonA2E0Lw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=OYT3hKmp; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OYT3hKmp" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-7370e73f690so4320949b3a.3 for ; Tue, 27 May 2025 10:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748365899; x=1748970699; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ErNNtp8tIhLsvXDOPpiWELLdI0K19IbrODKRiF2bcdE=; b=OYT3hKmpQFT1uRirWslkF9GEbm48sP1ufcXi6fQAhw7xEiuqIGILhA+qhw8cFdCgeC iuvbIoDNolexyx6UbNt8A4+bsgxnTmR+RRjOLzj5+Vdewc8sz/88VvCrdMBcYgk1p/AV gs8MHTIREsJ+fUoXP4XNo16NuN+t0RQXpBaxVT2lj6BsBH7VhSKsZ89N7V0UVuqvA3fm Nhy/A7GdREG+i27KotwVdr3aj9Vs2TKhvh/6XweRqE7QdITsMysn8h/nCI7Td6lCKN8d TtaYNJ4IwoJuuk1rS3O19q2VKBNLYJBdD2HTLBZd8ZRjfoyT0sv8EKP5MrAMcNPr9Jij zRUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748365899; x=1748970699; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ErNNtp8tIhLsvXDOPpiWELLdI0K19IbrODKRiF2bcdE=; b=j336/oGKvHb1IsmhcRyIMx0p7hXjqV0KC/BJ9NRUpswKLirg1GSjQ4lh/4tQ7dvMMf ZD2OiwRosSPOZZu5HCNF2CWByXAhHy7dU+CZTTrYhy7UcZJhlF/nulQURPHDDiJ425Az 7PqL36LA/fH9SyKUVRfJZ5bGWrICIxHDiZPuAeMHqlhtHkVCNixE8kqXFit8q0MGEoJm tVjTjuSm1MRq5tF4sO6STnMUH7jceSBdArdpBqT5vi0qG4b6NgENduQAPyFQ7BTV9c83 U2h9bRIjyxYSOKN91bbG8KyYTchDu8HSFkMbMHPrXYxF9ec5X3C/affWl+PQTJ2FoeFH Ztug== X-Forwarded-Encrypted: i=1; AJvYcCUPA0OTK8ewgQJLAmgDgNbzP0RUvpcKfRhfCdiM1ODL/oXIH3XcPotDfxBnXAWhcs6RHiWaw39tG/3Rdw==@vger.kernel.org X-Gm-Message-State: AOJu0YwVIJWvZzwj1rtelZyj1af2EYdesAZwwSR2Q8zwAqYRpybCU4Gv Bj5Xdd1TnlGFvYaAsqo31ttwdpG6sfGeE1fFDTMZ+l3MSPaiqkkg9xA2dYavw5/zCM9wwM60Q4X GYUnHXkf7Lu2s82tVquh/NA== X-Google-Smtp-Source: AGHT+IGxxnavX2uarCvCpcN0vhOLeB1NeqH4YORXOSXY3TONJqbGtIy/9hCvgy9XqCYcmWLwyURiyZ3IyPKV3G2i X-Received: from pfwp49.prod.google.com ([2002:a05:6a00:26f1:b0:746:25af:51c4]) (user=ericflorin job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3a1e:b0:736:43d6:f008 with SMTP id d2e1a72fcca58-745fdf77ab7mr21271166b3a.12.1748365899010; Tue, 27 May 2025 10:11:39 -0700 (PDT) Date: Tue, 27 May 2025 10:11:27 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1164.gab81da1b16-goog Message-ID: <5f9c28d0dc0f48151837f11d5f6e7b82f84978ef.1748365488.git.ericflorin@google.com> Subject: [PATCH 5/6] staging: sm750fb: rename `Bpp` parameter From: Eric Florin To: teddy.wang@siliconmotion.com Cc: sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Florin Rename `Bpp` to `bpp` in `sm750_hw_copyarea` to conform with kernel style guidelines. Signed-off-by: Eric Florin --- drivers/staging/sm750fb/sm750_accel.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index ea64e10d4814..a34d8f6a033d 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -138,7 +138,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @sy: Starting y coordinate of source surface * @d_base: Address of destination: offset in frame buffer * @d_pitch: Pitch value of destination surface in BYTE - * @Bpp: Color depth of destination surface + * @bpp: Color depth of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value @@ -149,7 +149,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int s_base, unsigned int s_pitch, unsigned int sx, unsigned int sy, unsigned int d_base, unsigned int d_pitch, - unsigned int Bpp, unsigned int dx, unsigned int dy, + unsigned int bpp, unsigned int dx, unsigned int dy, unsigned int width, unsigned int height, unsigned int rop2) { @@ -249,9 +249,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * pixel values. Need Byte to pixel conversion. */ write_dpr(accel, DE_PITCH, - ((d_pitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((d_pitch / bpp << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (s_pitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (s_pitch / bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ /* * Screen Window width in Pixels. @@ -259,9 +259,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * for a given point. */ write_dpr(accel, DE_WINDOW_WIDTH, - ((d_pitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((d_pitch / bpp << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (s_pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ + (s_pitch / bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ if (accel->de_wait() != 0) return -1; From patchwork Tue May 27 17:11:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Florin X-Patchwork-Id: 893415 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FA42281529 for ; Tue, 27 May 2025 17:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365902; cv=none; b=CkUDy0bnIsB3+5bF28aFDidf+XjHFj6WRm0vIzbOMfDYEImFF5Uvv7Df/Vwgzd6AMj4/MRu3lPiMfL9SGpvtIY3JV/AF8msnM0fRzUFu+TBtDWAdQVq+O+BuSu7RFKCnZ5TlZf/6fdMQ6fqHevmEhqF+LYYqNjQCVYHVcOhQs90= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365902; c=relaxed/simple; bh=WRJHINpKvIzq+kAIFhHGh/uFlb6VeUjDetEZlCoYiZ4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MhfgBZUtCt2H1MkEfbUBKjKarIEOrEUM8ldzFmRlK9jwJ6tCdfg+VJKYO10jmKCYO5yp1qjH68IqMaCHomdaOI7s0DZK93CZ6W9z/LtYezoZa33Hj7qZJCL3Ru84JU8fpj3mz+90vbo/goOwEuS8ulEp5TxolwtJAORvRTWFuNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qpbGGBHI; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qpbGGBHI" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b1ffc678adfso2042144a12.0 for ; Tue, 27 May 2025 10:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748365900; x=1748970700; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7pWVizCte/zfBc5wbZWXELXXuItPZZs1aoRgUlPPJRw=; b=qpbGGBHIN0TqW9C3PippNa15FnnYBgR8Y4balOPlyC+nStPLHg39VtzSOnMNBAi011 yb3BqdDQBoUY7Ia4L24yaZ/sXg1AslzBvTer4QuSI6S514VVT978XDZ6fFsSJX8C5TtO pfkAODU0EiM3ufxCxHbMeospo+Vg3Wuqcf+86BoMVScZXnS8lki07o13p2+LcekoeFWP NWDAWzntfXxhDlbqPWc3KsSObCvyThLg8XDCkE2NTLfkYJtqbg6iJuuI1CZoY1VnnoCq nlil15/ByuQCdnxuJDqjyqg7BFBQV0h15MJAEm60a/JL6AmxdDM4e4j/Z5pscJ/uU7PJ ODww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748365900; x=1748970700; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7pWVizCte/zfBc5wbZWXELXXuItPZZs1aoRgUlPPJRw=; b=ELP8ctxl91D+p89wxcKiYzCBt3nR/ReU5v66bpBKAmuvqIWp+gZXIyS6cayfEgrySn C7YBt8g6UnALAK4QGugVxW2H3pgdKDFEuccXDRpTX5789hTgmChwH1WlYuoF++ckB22/ Ge8BhSqcADvYDsD7QLqQo0050rVBOSrjJcCiB0WcF3aAte9yZ/GI+pM9autJYCOWwoCf ntF/LIiWIf5VddPY4RzZiv9MDz8xAsD3o8Vt6bbpeTtdLMG7TVs3PZk3rf81+mNG6EJD D/blNkzi+7Pg+ZDau/jsoSe1Pziph2cDoeOGcLgrW03rztcOhYCtv3iWM2r61oQOpivI Wfqw== X-Forwarded-Encrypted: i=1; AJvYcCXeA8P67pEcD/UtBMtHlKc+kOzp4qOZQqz8P8lG5QmlmIKAIpMXd6feuwxX0CQ9H8JViJIX14Vexn/N2A==@vger.kernel.org X-Gm-Message-State: AOJu0YztkIV1Bn8Fi3e7CP4eCD9JbOZYryN4bDoLzMkm8/27AQiU5eyJ 6C7juFUDPZM2EGL/79zo7wvbOMdPnE1JnoZPvMqz5abI+nsEAYpE2rur6aO9mvFSgwwppB5RPn1 QOAsFXAjYu3KZe2cT/p6Ztw== X-Google-Smtp-Source: AGHT+IGco4V40TsVlohUm2gdWA+Dyi4GYATtBZ7Xwh96aBepziaL0EAKO0k6gcGCVwhfFEHtJ+i81GuM/G1Mo+NX X-Received: from pjuj14.prod.google.com ([2002:a17:90a:d00e:b0:311:4201:4021]) (user=ericflorin job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:35cc:b0:2fc:a3b7:108e with SMTP id 98e67ed59e1d1-3110f33438emr22861081a91.4.1748365900271; Tue, 27 May 2025 10:11:40 -0700 (PDT) Date: Tue, 27 May 2025 10:11:28 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1164.gab81da1b16-goog Message-ID: Subject: [PATCH 6/6] staging: sm750fb: Rename local var `nDirection` From: Eric Florin To: teddy.wang@siliconmotion.com Cc: sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Florin Rename local variable `nDirection` to `n_direction` in `sm750_hw_copyarea` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: Signed-off-by: Eric Florin --- drivers/staging/sm750fb/sm750_accel.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index a34d8f6a033d..b9f90c934b7d 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -153,9 +153,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int width, unsigned int height, unsigned int rop2) { - unsigned int nDirection, de_ctrl; + unsigned int n_direction, de_ctrl; - nDirection = LEFT_TO_RIGHT; + n_direction = LEFT_TO_RIGHT; /* Direction of ROP2 operation: 1 = Left to Right, (-1) = Right to Left */ de_ctrl = 0; @@ -173,7 +173,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ - nDirection = BOTTOM_TO_TOP; + n_direction = BOTTOM_TO_TOP; } else if (sy > dy) { /* +----------+ * |D | @@ -185,7 +185,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ - nDirection = TOP_TO_BOTTOM; + n_direction = TOP_TO_BOTTOM; } else { /* sy == dy */ @@ -198,7 +198,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ - nDirection = RIGHT_TO_LEFT; + n_direction = RIGHT_TO_LEFT; } else { /* sx > dx */ @@ -210,12 +210,12 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ - nDirection = LEFT_TO_RIGHT; + n_direction = LEFT_TO_RIGHT; } } } - if ((nDirection == BOTTOM_TO_TOP) || (nDirection == RIGHT_TO_LEFT)) { + if ((n_direction == BOTTOM_TO_TOP) || (n_direction == RIGHT_TO_LEFT)) { sx += width - 1; sy += height - 1; dx += width - 1; @@ -277,7 +277,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, (height & DE_DIMENSION_Y_ET_MASK)); /* dpr08 */ de_ctrl = (rop2 & DE_CONTROL_ROP_MASK) | DE_CONTROL_ROP_SELECT | - ((nDirection == RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | + ((n_direction == RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | DE_CONTROL_COMMAND_BITBLT | DE_CONTROL_STATUS; write_dpr(accel, DE_CONTROL, de_ctrl); /* dpr0c */