From patchwork Wed May 28 19:59:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 893002 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34E4B220F55 for ; Wed, 28 May 2025 20:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462413; cv=none; b=NGTsFH5IaGEEVgAnDck17AeXptNbFPo6s+xBV7+UGofn0H+xbyVAlXVZB8A7GEWe8vfI6Sy8AEYyXtqFdfqzvr8Ozsi7BM7iDiw+hEYK/KmZh8zZdi2CtBnBr7TlFCU6DkDXYA9MJS5/upHnfP/O5e/d3ZVAvzw/sGsFIWIn1uM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462413; c=relaxed/simple; bh=Z9SxgzJQKUDvvpklxiiL0R/g7Mpc1YmBxkKUBnHBTw4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fUpr9+Ym7JwjwxYj1EvXUisGEXCQLDP/SsAY1a2/flA8+OQWlO/EeOiC892lvN6Isl/12wXFLZSJUjyhBGB6bDN0QUzlP421IRqJqINTfkSzaGFPLJXhIAXFhcgbvf2W8Zg1BHs4t5LR669eQSwcE+dPKLMP0Jf/O2UBEKIc+h8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ybb0kwwi; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ybb0kwwi" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3a4ee391e6fso13825f8f.3 for ; Wed, 28 May 2025 13:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748462409; x=1749067209; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VojE7/1d0sx/36NX9p5/dlSS3t9d1f2yOUDGBM4pW9o=; b=ybb0kwwi2Y+9glsj0rXv8xppUVtwxGEVyzj/M3Tfc6pWs2AV6fUiGKGhkdqw9HzBN0 LFcORCMUAnKwTtTrQXKTObgY+O4WYR3gt7Odz7EFAy+d1XAdfkcGp23mYNBUJTRRGV/N TyHPHoZQ9MDPwgL2Rn/jxtDP8reVEsFfNPMA1/2D8fy2848n25qRJ4ME/f64+gMvOMLu E/wj+GgdOA5lmMRzWpSeqQBo9vDez55I6RdBy7igSIff7Q+YS5vSzoh0mXQHpRpHQkUJ SmHlq1fXqYroiaibJ48zUkf3J7s1UISwaRtF/sAhPytkPdc3M1+OPtUJoD0cgYD9KR3a 21MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748462409; x=1749067209; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VojE7/1d0sx/36NX9p5/dlSS3t9d1f2yOUDGBM4pW9o=; b=i65TP83WaveP7hmzazCUAT5H75yKxjSYT9CjppNnzHrkh9dNpbSbqznEgnRLp+DhSi 6RyAv3HVyfvqQ/KwN6n0IFGltWDn+IpW63FklmSzwpWSb43WvLseRJxWsmgGWDI+S8Ja are/4AgF6/WbRGdQMv3/JTG+AE1TuUa4hfWccC9sG/v2UxUGei37/41Xv8bVlXVojjmI VJwUdH/PqmJzFAt6QceAqI5HBtGsiJeLjeTz1WMCdpRmi2iT/AXcFGwdV05PF67tciGu u4PH7XqP+/xWFp+l2XauOJ2U5sLaoF8pDgfVzNX1D0Fxb7qh4/AbGuveRwJZjs3MfSs1 jaLQ== X-Forwarded-Encrypted: i=1; AJvYcCWThWLfnBLgqSl/AE36eN0j63xWIVGIZB7RU1FHdwV9c2lJ0XekCCcfKiI/6UneOarruN7A1lcSMq81HXs8@vger.kernel.org X-Gm-Message-State: AOJu0YxV0YBveiesbQVds8jR0kcyRau1qDX57N5qyvpWdPOr/4HB6mhW Vbc2ZD4H/Hau4MPJNpc0vH4M+sqKBkvPHMMN3NqInVXV5Qkhkp4FSkjFszw56oE5c+XBBoVjnkF aw7yU X-Gm-Gg: ASbGncvS85ySK4ZzJUjAH6QYaOAyYNSK3u2CSmlsxn7tat4sgSCwDQHZ4PAgyQB8H8+ 32jkLCEfjZhxtH9DWCAo7bp3nA+/zA58g+wIaha9GFklpuTvj9tPXIqrgaIUb1rZlcAU/mpnpyY YgetHHNuYLA4IFI9ITbHCNdO+tkmLTse2D+ovWuIKXB4njXou7RLheJhUYUEK39I6kIHRGpfO+M mdmdQR4jXc4xSxf5I+XSxIPAoCx6Dc5XMxZPMNt0NS3GI/Xu22g3dCqlvRjZRezBy2hI6Z6Iz9V iR/MgXwR9hIuni2nbCh1i5CMTL6nJ/HrpO19bN2Glg26rPcWpphqL+6YEAJk+4Ym6mQVEuw= X-Google-Smtp-Source: AGHT+IEpJWK04H1Jk2KDz14W33GOaHF4ef97VNekR7RxVVrRDyfOsdZQ8TpRKKVPiZWvjeGWp4YagA== X-Received: by 2002:a05:6000:1445:b0:3a4:e482:ec77 with SMTP id ffacd0b85a97d-3a4e482f096mr1978591f8f.9.1748462409096; Wed, 28 May 2025 13:00:09 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44fcbd61553sm53347665e9.0.2025.05.28.13.00.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 13:00:07 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 28 May 2025 21:59:55 +0200 Subject: [PATCH 1/8] ASoC: codecs: Constify regmap configuration static variables Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250528-asoc-const-unused-v1-1-19a5d07b9d5c@linaro.org> References: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> In-Reply-To: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Support Opensource , Oder Chiou , Srinivas Kandagatla , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=11915; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=Z9SxgzJQKUDvvpklxiiL0R/g7Mpc1YmBxkKUBnHBTw4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoN2s9T7C7p3EFXVEu7vbd0VKKvStX3mTYGqviF zfaFYYh6cCJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDdrPQAKCRDBN2bmhouD 1+m4D/4zCtHkWmOUd+xtdQvuOdYkXQyr9ErCPsRRonOTbYo8OT2BekoBNsyX6yQIFayV8RjrDc7 HMKEsPwff11fxyCPRo9nEG0MhFBedpLBypjJJR6s94LG7gm99lrtZrlrQJHVGTmSf1/bt+SYtiD 2JmoX4ND99VQ2iJ9GVrApj+/M/Oyiy8Jxb2ET9Cwm8iyBwgIJQKdBN3p22SAS3PQRPGuDYANl6y E5PlQCxrlOpTfRPR8ieo3c4KMldAg/phYnnPuoDCsT2glQn68J+Yf8sOmvee257U9539xqeMmRF Y1zvg5YA/6Azhmvvrq8QwID+pDluLiANMzTZMXDbjkQUsEG3BzM4mHG7pWpJ8r44YYtYri4mgyb jom9+J+c8yPkURdEGIgLUVZj4ciXyMTFn4kBMmKHOPkj3YNiEYI6MtqEsqhL+1aQ5o+9lSNu6qc Yz2LngzoBGXK6jNCULmmAzqk7R4m8PU5Lvtx0PvOuKU+vBXOg+gPVnEDnYEVWDjiPro3vzx4x6/ 60eN2wec46edNviz46FVueQz+PR1QEH7UYyvQjmy4LWF3n/aCRcLExbPLRiYwBL8nkCpUWZIGoL TPRDjKLc+PDgn6Q8y2/AS0YmNAKxM+wq885w6ocDeiLYMxWy/FeqElt+ytae235hnhOhMf/+jEe KQ1WZqNJPTrGZCw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Static arrays/structs for regmap configuration like 'struct reg_default', 'struct reg_sequence' and others are not modified so can be changed to const for more safety. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla Reviewed-by: Charles Keepax --- sound/soc/codecs/cs35l36.c | 2 +- sound/soc/codecs/da7218.c | 2 +- sound/soc/codecs/da7219.c | 4 ++-- sound/soc/codecs/es8375.c | 2 +- sound/soc/codecs/max98363.c | 2 +- sound/soc/codecs/max98373-i2c.c | 2 +- sound/soc/codecs/max98373-sdw.c | 2 +- sound/soc/codecs/max98388.c | 2 +- sound/soc/codecs/max98390.c | 2 +- sound/soc/codecs/max98396.c | 4 ++-- sound/soc/codecs/max98504.c | 2 +- sound/soc/codecs/max98520.c | 2 +- sound/soc/codecs/max98927.c | 2 +- sound/soc/codecs/rt722-sdca-sdw.c | 2 +- sound/soc/codecs/wcd938x.c | 2 +- sound/soc/codecs/wsa881x.c | 4 ++-- sound/soc/codecs/wsa883x.c | 2 +- sound/soc/codecs/wsa884x.c | 2 +- 18 files changed, 21 insertions(+), 21 deletions(-) diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c index b49c6905e8727d7c07fd10e668507ca07bf2cff5..b60697ff7a506dccf3dba1b01faa985761bbbc42 100644 --- a/sound/soc/codecs/cs35l36.c +++ b/sound/soc/codecs/cs35l36.c @@ -129,7 +129,7 @@ static const struct cs35l36_pll_config cs35l36_pll_sysclk[] = { {27000000, 0x3F, 0x0A}, }; -static struct reg_default cs35l36_reg[] = { +static const struct reg_default cs35l36_reg[] = { {CS35L36_TESTKEY_CTRL, 0x00000000}, {CS35L36_USERKEY_CTL, 0x00000000}, {CS35L36_OTP_CTRL1, 0x00002460}, diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index 5f2f67e3bd29240acfa0d53a0892c8e92f711c1f..a7539e1a18939683558accd207b57324a1ce6aeb 100644 --- a/sound/soc/codecs/da7218.c +++ b/sound/soc/codecs/da7218.c @@ -3033,7 +3033,7 @@ static const struct snd_soc_component_driver soc_component_dev_da7218 = { * Regmap configs */ -static struct reg_default da7218_reg_defaults[] = { +static const struct reg_default da7218_reg_defaults[] = { { DA7218_SYSTEM_ACTIVE, 0x00 }, { DA7218_CIF_CTRL, 0x00 }, { DA7218_SPARE1, 0x00 }, diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 3958e88a244563c81b373cab38bc221fc8ba795e..221577574525a5fd60180a4441331d7db88f50e2 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -2312,7 +2312,7 @@ static void da7219_handle_pdata(struct snd_soc_component *component) * Regmap configs */ -static struct reg_default da7219_reg_defaults[] = { +static const struct reg_default da7219_reg_defaults[] = { { DA7219_MIC_1_SELECT, 0x00 }, { DA7219_CIF_TIMEOUT_CTRL, 0x01 }, { DA7219_SR_24_48, 0x00 }, @@ -2443,7 +2443,7 @@ static const struct regmap_config da7219_regmap_config = { .cache_type = REGCACHE_RBTREE, }; -static struct reg_sequence da7219_rev_aa_patch[] = { +static const struct reg_sequence da7219_rev_aa_patch[] = { { DA7219_REFERENCES, 0x08 }, }; diff --git a/sound/soc/codecs/es8375.c b/sound/soc/codecs/es8375.c index decc86c92427c0c61a1531fb0fed1d9b853449d5..d12b3dc9e1f7fc03b8737e6b001b44c0d51c1b93 100644 --- a/sound/soc/codecs/es8375.c +++ b/sound/soc/codecs/es8375.c @@ -619,7 +619,7 @@ static bool es8375_writeable_register(struct device *dev, unsigned int reg) } } -static struct regmap_config es8375_regmap_config = { +static const struct regmap_config es8375_regmap_config = { .reg_bits = 8, .val_bits = 8, .max_register = ES8375_REG_MAX, diff --git a/sound/soc/codecs/max98363.c b/sound/soc/codecs/max98363.c index 950105e5bffdc2c7606e10e7af6f3cf97ece5b4c..fd6830a7579d4860c8bc4fdd26d05698834ddcc2 100644 --- a/sound/soc/codecs/max98363.c +++ b/sound/soc/codecs/max98363.c @@ -14,7 +14,7 @@ #include "max98363.h" -static struct reg_default max98363_reg[] = { +static const struct reg_default max98363_reg[] = { {MAX98363_R2021_ERR_MON_CTRL, 0x0}, {MAX98363_R2022_SPK_MON_THRESH, 0x0}, {MAX98363_R2023_SPK_MON_DURATION, 0x0}, diff --git a/sound/soc/codecs/max98373-i2c.c b/sound/soc/codecs/max98373-i2c.c index 56c4ba1f37826f279df4007b0de36fa932257b8f..f58b8c8625a7061fc9564c9f84dd95d77df33b72 100644 --- a/sound/soc/codecs/max98373-i2c.c +++ b/sound/soc/codecs/max98373-i2c.c @@ -23,7 +23,7 @@ static const u32 max98373_i2c_cache_reg[] = { MAX98373_R20B6_BDE_CUR_STATE_READBACK, }; -static struct reg_default max98373_reg[] = { +static const struct reg_default max98373_reg[] = { {MAX98373_R2000_SW_RESET, 0x00}, {MAX98373_R2001_INT_RAW1, 0x00}, {MAX98373_R2002_INT_RAW2, 0x00}, diff --git a/sound/soc/codecs/max98373-sdw.c b/sound/soc/codecs/max98373-sdw.c index 6088278e6503dc7ea743ccc439cd6365c7475017..43b52bda6ad5297d856123aa515e0019f4866097 100644 --- a/sound/soc/codecs/max98373-sdw.c +++ b/sound/soc/codecs/max98373-sdw.c @@ -26,7 +26,7 @@ static const u32 max98373_sdw_cache_reg[] = { MAX98373_R20B6_BDE_CUR_STATE_READBACK, }; -static struct reg_default max98373_reg[] = { +static const struct reg_default max98373_reg[] = { {MAX98373_R0040_SCP_INIT_STAT_1, 0x00}, {MAX98373_R0041_SCP_INIT_MASK_1, 0x00}, {MAX98373_R0042_SCP_INIT_STAT_2, 0x00}, diff --git a/sound/soc/codecs/max98388.c b/sound/soc/codecs/max98388.c index 99986090b4a63a9759763881f3004d0e509e53cd..076f15a9867e13527324354cd6364ade3bca4846 100644 --- a/sound/soc/codecs/max98388.c +++ b/sound/soc/codecs/max98388.c @@ -18,7 +18,7 @@ #include #include "max98388.h" -static struct reg_default max98388_reg[] = { +static const struct reg_default max98388_reg[] = { {MAX98388_R2000_SW_RESET, 0x00}, {MAX98388_R2001_INT_RAW1, 0x00}, {MAX98388_R2002_INT_RAW2, 0x00}, diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index 76296176f9486f72a9d6077a0c69a475e277ed88..a8a282ff9fc5abfbf6c6bdc7fc209ed15bda0cfd 100644 --- a/sound/soc/codecs/max98390.c +++ b/sound/soc/codecs/max98390.c @@ -23,7 +23,7 @@ #include "max98390.h" -static struct reg_default max98390_reg_defaults[] = { +static const struct reg_default max98390_reg_defaults[] = { {MAX98390_INT_EN1, 0xf0}, {MAX98390_INT_EN2, 0x00}, {MAX98390_INT_EN3, 0x00}, diff --git a/sound/soc/codecs/max98396.c b/sound/soc/codecs/max98396.c index c1888cd83dbc6fe2d418012dc1a9b1c58c3ded86..4b4e1fc98a6da5bf3a713133ce974b2f09161ed4 100644 --- a/sound/soc/codecs/max98396.c +++ b/sound/soc/codecs/max98396.c @@ -16,7 +16,7 @@ static const char * const max98396_core_supplies[MAX98396_NUM_CORE_SUPPLIES] = { "dvddio", }; -static struct reg_default max98396_reg[] = { +static const struct reg_default max98396_reg[] = { {MAX98396_R2000_SW_RESET, 0x00}, {MAX98396_R2001_INT_RAW1, 0x00}, {MAX98396_R2002_INT_RAW2, 0x00}, @@ -174,7 +174,7 @@ static struct reg_default max98396_reg[] = { {MAX98396_R21FF_REVISION_ID, 0x00}, }; -static struct reg_default max98397_reg[] = { +static const struct reg_default max98397_reg[] = { {MAX98396_R2000_SW_RESET, 0x00}, {MAX98396_R2001_INT_RAW1, 0x00}, {MAX98396_R2002_INT_RAW2, 0x00}, diff --git a/sound/soc/codecs/max98504.c b/sound/soc/codecs/max98504.c index 6b6a7ece4cecc3d114da276faf859c8176955300..c94142768c818228aae8b90c636cfd6b496e9859 100644 --- a/sound/soc/codecs/max98504.c +++ b/sound/soc/codecs/max98504.c @@ -35,7 +35,7 @@ struct max98504_priv { unsigned int brownout_release_rate; }; -static struct reg_default max98504_reg_defaults[] = { +static const struct reg_default max98504_reg_defaults[] = { { 0x01, 0}, { 0x02, 0}, { 0x03, 0}, diff --git a/sound/soc/codecs/max98520.c b/sound/soc/codecs/max98520.c index adf5a898c6df5b10661861f6329ca54db6445f1a..2bf8976c1828210d2e6106f08e571df650640606 100644 --- a/sound/soc/codecs/max98520.c +++ b/sound/soc/codecs/max98520.c @@ -16,7 +16,7 @@ #include #include "max98520.h" -static struct reg_default max98520_reg[] = { +static const struct reg_default max98520_reg[] = { {MAX98520_R2000_SW_RESET, 0x00}, {MAX98520_R2001_STATUS_1, 0x00}, {MAX98520_R2002_STATUS_2, 0x00}, diff --git a/sound/soc/codecs/max98927.c b/sound/soc/codecs/max98927.c index 55cc18451a2d26e0ad72031d5017d68c215240ef..0e9b8970997cf6485a775a3187b1470f93b5c057 100644 --- a/sound/soc/codecs/max98927.c +++ b/sound/soc/codecs/max98927.c @@ -19,7 +19,7 @@ #include #include "max98927.h" -static struct reg_default max98927_reg[] = { +static const struct reg_default max98927_reg[] = { {MAX98927_R0001_INT_RAW1, 0x00}, {MAX98927_R0002_INT_RAW2, 0x00}, {MAX98927_R0003_INT_RAW3, 0x00}, diff --git a/sound/soc/codecs/rt722-sdca-sdw.c b/sound/soc/codecs/rt722-sdca-sdw.c index 609ca0d6c83a1f28c73a0981f2a8f857816e5eb2..70700bdb80a14374321d1d8d8744356484ac01ac 100644 --- a/sound/soc/codecs/rt722-sdca-sdw.c +++ b/sound/soc/codecs/rt722-sdca-sdw.c @@ -147,7 +147,7 @@ static int rt722_sdca_mbq_size(struct device *dev, unsigned int reg) } } -static struct regmap_sdw_mbq_cfg rt722_mbq_config = { +static const struct regmap_sdw_mbq_cfg rt722_mbq_config = { .mbq_size = rt722_sdca_mbq_size, }; diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index d9b61eab029af3d4782620ee017fc84fbd26ce0b..342d1f7d5dee3ac2d703e5b5602aef9ca2987158 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -275,7 +275,7 @@ static const struct regmap_irq wcd938x_irqs[WCD938X_NUM_IRQS] = { REGMAP_IRQ_REG(WCD938X_IRQ_HPHR_SURGE_DET_INT, 2, 0x08), }; -static struct regmap_irq_chip wcd938x_regmap_irq_chip = { +static const struct regmap_irq_chip wcd938x_regmap_irq_chip = { .name = "wcd938x", .irqs = wcd938x_irqs, .num_irqs = ARRAY_SIZE(wcd938x_irqs), diff --git a/sound/soc/codecs/wsa881x.c b/sound/soc/codecs/wsa881x.c index 6627d2da372206eff879f8f3bd5fae9ddc0757d7..d479521a6d504ee45797be8ea99206a4b1787f73 100644 --- a/sound/soc/codecs/wsa881x.c +++ b/sound/soc/codecs/wsa881x.c @@ -202,7 +202,7 @@ SOC_SINGLE_EXT_TLV(xname, reg, shift, max, invert, \ snd_soc_get_volsw, wsa881x_put_pa_gain, tlv_array) -static struct reg_default wsa881x_defaults[] = { +static const struct reg_default wsa881x_defaults[] = { { WSA881X_CHIP_ID0, 0x00 }, { WSA881X_CHIP_ID1, 0x00 }, { WSA881X_CHIP_ID2, 0x00 }, @@ -346,7 +346,7 @@ static const struct reg_sequence wsa881x_vi_txfe_en_2_0[] = { }; /* Default register reset values for WSA881x rev 2.0 */ -static struct reg_sequence wsa881x_rev_2_0[] = { +static const struct reg_sequence wsa881x_rev_2_0[] = { { WSA881X_RESET_CTL, 0x00, 0x00 }, { WSA881X_TADC_VALUE_CTL, 0x01, 0x00 }, { WSA881X_INTR_MASK, 0x1B, 0x00 }, diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c index f04d99c66f332e18fe4c201f78360416c1607466..13c9d4a6f01537e448a5595f489c1716eb2053f2 100644 --- a/sound/soc/codecs/wsa883x.c +++ b/sound/soc/codecs/wsa883x.c @@ -572,7 +572,7 @@ static const struct sdw_port_config wsa883x_pconfig[WSA883X_MAX_SWR_PORTS] = { }, }; -static struct reg_default wsa883x_defaults[] = { +static const struct reg_default wsa883x_defaults[] = { { WSA883X_REF_CTRL, 0xD5 }, { WSA883X_TEST_CTL_0, 0x06 }, { WSA883X_BIAS_0, 0xD2 }, diff --git a/sound/soc/codecs/wsa884x.c b/sound/soc/codecs/wsa884x.c index fd6ebc25fe894a5981df4e39d10d0f27d21c3a25..07d8a2645404ec49d4b12297d79bbddbe2950a4c 100644 --- a/sound/soc/codecs/wsa884x.c +++ b/sound/soc/codecs/wsa884x.c @@ -899,7 +899,7 @@ static const struct sdw_port_config wsa884x_pconfig[WSA884X_MAX_SWR_PORTS] = { }, }; -static struct reg_default wsa884x_defaults[] = { +static const struct reg_default wsa884x_defaults[] = { { WSA884X_BG_CTRL, 0xa5 }, { WSA884X_ADC_CTRL, 0x00 }, { WSA884X_BOP1_PROG, 0x22 }, From patchwork Wed May 28 19:59:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 893156 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4E76221264 for ; Wed, 28 May 2025 20:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462414; cv=none; b=UCZWPUzNIZuHh0/JD0g8sRb/1osWSh8NKcW6sw3WmzUJetPnWziEQaMcnr/1UlpgP4ifKFMVoiy1pewuQzC+o7u3NOcxt8u0cP10Dxl+Sr3PhToHpgxEMDdAQD5rdUj/U9RtiHqDujytjWWaDXzdkc0Uh5fQFsBw1p1w0qkzQkE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462414; c=relaxed/simple; bh=CpYH823lP1gANgxKRTCYkC1iXZwcMTKwp/L88jc6Xws=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=csNO68V7osu3Lp0EjGG8GV3F5nAjYOy27D8S53XcrpUapUbhe2PKv2an+BagM2qFMYMEjFC5twjygjC978oZGy7wlGyTf3QzBeFSkUv8vfT1Yrw/+zLnLfdtO4Y/Wm9CMiaylTVYxKbMw9IJcH39elP44hbTpmHddoUOaP0LC98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EcqMzV7b; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EcqMzV7b" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-442e9c7cf0eso39775e9.2 for ; Wed, 28 May 2025 13:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748462411; x=1749067211; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PDq0VVP4RBrXESa/PJeathjlPVt4SwgrUucxImBu+7c=; b=EcqMzV7bAeJT1vV4xfnJLSrs9E0OwVyz9EWvG/WxeBZCx33Lbehwn+dOvpGxdUVaU1 OdJxlOX3FWh2ZryuF29StlKMQZ5l2c/s8QZf9c90NHm2v1z5ztyvgnwrns+9K9Jci++O zc15aX+dn0JOiLhvayOmBDaE3/DcnI8Xy+21Q/WPYDHimpeSpG5KuBoI/kJiJ+sp90X1 JXGuKdYrN11aBForg3OicMNIy5u9CuyadSAyxgMajcVLUqP2DaYrYsKnUOFS7uNjtrJ9 LNY1epowm5W+jaPf5VWa4vQVffTMgQ+R9VIZMSGAWsgSjUu0e9L6zBbkBOMf3OxfWSh0 Wn8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748462411; x=1749067211; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PDq0VVP4RBrXESa/PJeathjlPVt4SwgrUucxImBu+7c=; b=QRfrIXMEYsClL9EDw+6uQag2A3tB04iA+6GBjJ7iNG0WbEzx2Jk7JDxNLeBdYCye2A zwN/QatqFqXLUqZ1eOBuT2QgmTvN6sTvEzc+/j0+EvaxGFRftqZ6iiWLEDYLkdbHVwOR t1bpNnEwnB97oSnqou4Ht5A/CcatweAvUy8iFNeESnm7KLdRCYZBdgCmCf5Mzlow2QB+ Xkie4/FX1Si17lLS+LKEMelKh6Tikr5QKYY9ThZiQvFhkFLaiNXzMxaEgdqN9sX3bTWE JNZYr9xudia5VtFksbaaqWVxG3eOfZMtG7fC1uXjy2aj9CT72Eu0QJpvXnZMfXaVFl+M 1KFg== X-Forwarded-Encrypted: i=1; AJvYcCU1BkVvd0W1wOiQkalhoI7e5mZPiejhFLarWjx7tsnNoXVpNDcmColcN2l6Bxc0tHUAYgAmRke5rBFrNM40@vger.kernel.org X-Gm-Message-State: AOJu0YwhmDmP28hoJSzSyPaWT17oudxACh9ifQxniQH8XsSGesukOUts 5gocdL5lqDXFJWY0Y+yESVxlHB/RUh3wxjRZSVN9jw40oW5CWQJ2dJb68b/M/TSiPN1vm2qYG6+ 6jztu X-Gm-Gg: ASbGncuLrleSlBwDFjOVkOjNej9c4DLzQUKT16y6o00kk87aXSxhI/xnbUNEamCodmZ DJuqlWfKYHd6+YnOKAYokFnTKmlOV+3ZBZOa+zIyfXAJmiNbVg3R2sSOXYZ4k2e50PW0EEWcTMO HSoLmTwXyvd8E0wp2RQFQtZldp9g/79N9vzE4MCzmHpeDK/V25ivPpGRuHCiWw1E/Ql7IspW5// +fm7VYP7etEtCB2m0Os2qyH3LuqbTPQbtvllrqbHhzjgRFbCaY3IUM1Z7orjuhb9je4nxy7Ge7t Pq17qw1iORTvFerLffv9RJhWMtqhOjgLlRAql0WRnLy+hWFMClIFx9xfigAIRXNa0sXNfNLOSZ7 YHUvPsQ== X-Google-Smtp-Source: AGHT+IHZUGUK6yTkOMly/UTCf5TfkRX+RuLMJ+zm0TaswuyyY5q5bbmG4zBXo05PBD4iH1y4pl+NdQ== X-Received: by 2002:a05:600c:4752:b0:441:b397:e324 with SMTP id 5b1f17b1804b1-44c93caeb6amr61901665e9.9.1748462410755; Wed, 28 May 2025 13:00:10 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44fcbd61553sm53347665e9.0.2025.05.28.13.00.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 13:00:10 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 28 May 2025 21:59:56 +0200 Subject: [PATCH 2/8] ASoC: fsl: Constify reg_default array Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250528-asoc-const-unused-v1-2-19a5d07b9d5c@linaro.org> References: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> In-Reply-To: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Support Opensource , Oder Chiou , Srinivas Kandagatla , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1754; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=CpYH823lP1gANgxKRTCYkC1iXZwcMTKwp/L88jc6Xws=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoN2s+XsqS9sFfoi0z9c+1UBE4EIIisHahFoDdV IQAKD8fYDSJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDdrPgAKCRDBN2bmhouD 14HkEACFdeeKCanwIs9cv17+UMezTLZWq0x8/jrTebWUBqQqWOfNZFxDU6WjQcbXZ7dXF5S8wQ4 7bLJBjpg/DGuUc+eS4RBF2PEZ6NX2WBqzoXpwQqGh5IU8mjJoaqnNFYzOQandX1OW//JzbLGrGO YFprEji4Oid03TG7/AgU/DvnN4+g+/8BtNMeq1G+VklfGrQKT49hUMNnST2geP66RYQwpi77ogY 2s+J3a1eRLYcA04uRF54ZJyA2FLE6SMIm6kwzLmwGliMUbqO6w3bRbbwMTdizD3zn3aBPEEZtpG ++ayreX9g0cV5IzOIFqbVfycaLLHom3iO7dy3K4L8Pqz4Ozx5YGewOHbcb3G0kllU6sxYLgfkDX tXro/sl120J1X55bh9T2FwBWVNQuFhi6V8REO7tRcZj/cYwyfXrq3tbAWfH+/iUTKX7dFXCWIk4 BafMN7HfrnzbHhhm0m4SrH57UsvnoLA9ZZhao+zwe5EerO0Wb0TKL7tgV3g1I/VdWKCRyHn9wM9 jUvYBzaZqnoxLhtU0JcSwfNjwz5TKbJo0TnrJq35lqZOw+zKvpHlx7hqUiSyr088rslYMHZJXp6 2RAFQfgHUZhqSe2i8GfEeRoanO/1RWmQOD3NOHWI1RbMqJObKGTgBWW3+LYWY5ssXczSr3oHcfu 3MvwM/3z7gf87DQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Static 'struct reg_default' array is not modified so can be changed to const for more safety. Signed-off-by: Krzysztof Kozlowski --- sound/soc/fsl/fsl_asrc.c | 2 +- sound/soc/fsl/fsl_sai.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index 677529916dc0e53a15952c53016930203c56dc9d..637260f306ecab109ed23b92a882cffce1c65421 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -930,7 +930,7 @@ static bool fsl_asrc_writeable_reg(struct device *dev, unsigned int reg) } } -static struct reg_default fsl_asrc_reg[] = { +static const struct reg_default fsl_asrc_reg[] = { { REG_ASRCTR, 0x0000 }, { REG_ASRIER, 0x0000 }, { REG_ASRCNCR, 0x0000 }, { REG_ASRCFG, 0x0000 }, { REG_ASRCSR, 0x0000 }, { REG_ASRCDR1, 0x0000 }, diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index af1a168d35e379e24ce46715ba53b4a4dac65988..c84e3bb1290fd1188118b220adeb4f8e279a3372 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -1059,7 +1059,7 @@ static const struct snd_soc_component_driver fsl_component = { .legacy_dai_naming = 1, }; -static struct reg_default fsl_sai_reg_defaults_ofs0[] = { +static const struct reg_default fsl_sai_reg_defaults_ofs0[] = { {FSL_SAI_TCR1(0), 0}, {FSL_SAI_TCR2(0), 0}, {FSL_SAI_TCR3(0), 0}, @@ -1082,7 +1082,7 @@ static struct reg_default fsl_sai_reg_defaults_ofs0[] = { {FSL_SAI_RMR, 0}, }; -static struct reg_default fsl_sai_reg_defaults_ofs8[] = { +static const struct reg_default fsl_sai_reg_defaults_ofs8[] = { {FSL_SAI_TCR1(8), 0}, {FSL_SAI_TCR2(8), 0}, {FSL_SAI_TCR3(8), 0}, From patchwork Wed May 28 19:59:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 893001 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8039F221562 for ; Wed, 28 May 2025 20:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462417; cv=none; b=VUMCbrr2NZidOYiDxUKxJMizzhw1uKLeigNOvgiBUl1XYQ9R374GfVk0t1i5309UPexWHL8VBjKerCJl2voXFkAg2pm2T/jbfu0CoMV/cbtzkBL4gcap3fgUMqXjKHpYnHBdw66p8M56J3kvd6DX+6PvIhUhvrqX6oDceTk6hD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462417; c=relaxed/simple; bh=0ZRY/+q+W8Hjs6RGmmOVXS/0Gcaj4yO/XRQKw0A/w7A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BgibxfMwjoz6ofhi9IvAJqzm/61TUVrLkLnuPNJWUElnb0B2I+s08/w/XB+RJYLct+E3eiwsz7ijOKWza3M1wdc2JqzrglsLOvuuX7WbMpap8pgVrIKDTJJYzYzciaRbvPhVWMsz2TkzBUXuF4r0bHm9V2hK2Y4DqVmFvB9XCYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Kc+Z8zok; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Kc+Z8zok" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a4ef05f631so15433f8f.3 for ; Wed, 28 May 2025 13:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748462412; x=1749067212; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b7yDCQi4rHSCnETU9ud9r++MJrTNq+R9cHXXFxzlNlc=; b=Kc+Z8zokSQfSKSSoX+O9BcaJvf6OaKxwKmfMF9KHmxlZ2upNYxx/dEvwKN74KJeY0n /rVqdC4BjAQRyBNy677tQTUsvdIW8EJN98D8DLgmXH/DRmUZS0RAlvhDuRyHj2eHjWzO ykCUZgg7xqk0SmV7+yDKGluGa0ess1L/OV5pKn5VypGEtX8CnHWoACVm9rHrsrEWYjag em1JXvuRRRQ3miEGXa26+iZSkssZuLnMXFbyMNiSA3BCJY65/KU8AyKcnmVOyW7bcp87 x4O5LT/UdThdPGFTODNLTlMzTePfQjqc8JPu+cWV1Ob36nqERHuIu8INarX2U10eVFyO r0MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748462412; x=1749067212; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b7yDCQi4rHSCnETU9ud9r++MJrTNq+R9cHXXFxzlNlc=; b=CA/ASHnNFKTZY5Sv+KJI3rQN2VtNhO4aWXNGgJspwS+4HzkoQnLGdL+EuEdCw4mOMK uCNmOSohQpz3iWwO+enwZsCOK4xI5wAXfD0o5mJ0J/QweD+zDP0YEV34lECeaPG5KCqg kznzP1S0NVXJzWX6NiYPdysQaGTgHxJookt3ZCZHcFlcNFGyCCfEkKfWO3WXYVr3nnQw c+7I2uQYzsPyTrxTzBaalHMAIKRMzuc2LaA7pfovRuDQfZGXoJC3ixFE7qZq5+3GzdOw dGHDTBt6B785gJEMNP34WtFugFsGZnrwKiCH2qEskfAPUkJJqLV22goeNzpr7ysDELzQ q8tg== X-Forwarded-Encrypted: i=1; AJvYcCUfc2WsNrr24gqqtEcgRK6wXORYN/aUoNClUiiT8N64DMcttBf9YH8DWz1Qm3trLqK6CTHRrigQZQDYxybo@vger.kernel.org X-Gm-Message-State: AOJu0YxPEItB3AGgPbEuAjQGob2gTS1yuuZhx9zrWxpuE+KnkG+8l5Aj B6HEVRIJ9Ep6Njx/3YICkkM2vKycCP/jYRgGCaz8TT+I3QhZ6F/ajqhhVO4QEo71qt9vfnSTELK e8doU X-Gm-Gg: ASbGncvPocXYq/15vzVJiBLZ+u0MeziehEBK9N8T73jG/0m2/K7P2b7jRGcuaNFCgi2 dHShJk8+JL9iBz0qg4SQm0hC870wQaDrU5fRy2zx+GwdQnasN0SwPnhDW12ywPW+3/K40zpe5jG P1l7SPS2jfZ1Cn0mDRxnHLx2AhTNSJOk5BuT2ory7//Flpk/yRcbeXpMzUrSbQnmR5bwCi48Z7M ejciSM0DcoOuq4VVRJdE4Kx1ETb/PxZ1Y1StlczqeMGvhlnBbUSNXqV6ezHdQaqjFF1rT+LdXk5 Wbtxh+GfDnNAbLEKx6Z0g5Pa6G2eURU3i6tfJO0WmPbrO9yHIJ0V4ItcHHfAIQzgYguoTP4= X-Google-Smtp-Source: AGHT+IFQP0FibM1rqz/lOLHDDJIP46KUlhvU3MMzWhlSZjooZREosH5m2BiFsQxW10TootF1bWqdog== X-Received: by 2002:a05:600c:4f0c:b0:439:a30f:2e49 with SMTP id 5b1f17b1804b1-44ff407200bmr13873405e9.5.1748462412453; Wed, 28 May 2025 13:00:12 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44fcbd61553sm53347665e9.0.2025.05.28.13.00.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 13:00:12 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 28 May 2025 21:59:57 +0200 Subject: [PATCH 3/8] ASoC: codecs: wcd9335: Drop unused sido_input_src field Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250528-asoc-const-unused-v1-3-19a5d07b9d5c@linaro.org> References: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> In-Reply-To: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Support Opensource , Oder Chiou , Srinivas Kandagatla , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1807; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=0ZRY/+q+W8Hjs6RGmmOVXS/0Gcaj4yO/XRQKw0A/w7A=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoN2s/W7KGWelejUXL5jEOanL3Ib8Zn2ryY+42I viAZm3zT/uJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDdrPwAKCRDBN2bmhouD 1w1mD/0TE/pr2WWpzbfzTZpzuf9Ihpzqt5a1AGUtL71i8JsTXwd7jut9/Gm0IH0nme0q1yGZ9dZ praHkDhRMtcT9pyzKbMwyz9ZqNFlKSJPWmGG0tA5kd+cSFAOUcqyIVknxv2katMudoqLAXi72XX VzqQrT4YVsoP95hFaKGCb0lOnpIiHu56DJKJvdGSPV8SOkVmh45MIILx6SgMXVWfJKnNKITmrsP iLTUF2HnE8S5rNM7WCdCxn87Tevk6EREKKWi2BXjLwMPjKYzHGm4sbITJuZ9/Ondk+CZIJGGk37 I6U9dMaoCm9v5m3MNpIW9e+tLL3h1VIUrqfd/egIrkSkMGZZC+HWN8aL4rPPry604hZy4iIt2+/ GoN1EA4gtuKpwN9/1fw/5baSiNgZSkW0b8HIXp/VN8XSAJ/Dy3DTv+8fT55ulerizsBTcpo9RC8 vwIFOktKU74Op6kLo0q2t3TVsCf8YELIge+FEFKbAbORWdq8anQvYDdElWqDxh4JUtI3OzTLb8X jGt5qZZIMoNLTh896qRPaEDJKVnKFsjCOBdxXi59aSKFqEjVUjszRZx0ktaQa/xcUwvi0JKSR9i iSzmtn7L6KTu2Mh8MRgpkPdkbNSXRJQlMteUkQdPsCw3zshP3vKJjvovpudc7fz6o1mBNfGeA/W b6EdcUurjtIG3VQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Member wcd9335_codec.sido_input_src is not read anywhere after assignment, so it can be safely dropped. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd9335.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 5e19e813748dfa0d065287494240007d60478dea..1c050b8c19de43cf494583d2c96f50f65aefe567 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -312,7 +312,6 @@ struct wcd9335_codec { u32 num_rx_port; u32 num_tx_port; - int sido_input_src; enum wcd9335_sido_voltage sido_voltage; struct wcd_slim_codec_dai_data dai[NUM_CODEC_DAIS]; @@ -4725,8 +4724,6 @@ static const struct snd_soc_dapm_widget wcd9335_dapm_widgets[] = { static void wcd9335_enable_sido_buck(struct snd_soc_component *component) { - struct wcd9335_codec *wcd = dev_get_drvdata(component->dev); - snd_soc_component_update_bits(component, WCD9335_ANA_RCO, WCD9335_ANA_RCO_BG_EN_MASK, WCD9335_ANA_RCO_BG_ENABLE); @@ -4740,7 +4737,6 @@ static void wcd9335_enable_sido_buck(struct snd_soc_component *component) WCD9335_ANA_BUCK_CTL_VOUT_D_VREF_EXT); /* 100us sleep needed after VREF settings */ usleep_range(100, 110); - wcd->sido_input_src = SIDO_SOURCE_RCO_BG; } static int wcd9335_enable_efuse_sensing(struct snd_soc_component *comp) @@ -4871,7 +4867,6 @@ static int wcd9335_probe(struct wcd9335_codec *wcd) memcpy(wcd->rx_chs, wcd9335_rx_chs, sizeof(wcd9335_rx_chs)); memcpy(wcd->tx_chs, wcd9335_tx_chs, sizeof(wcd9335_tx_chs)); - wcd->sido_input_src = SIDO_SOURCE_INTERNAL; wcd->sido_voltage = SIDO_VOLTAGE_NOMINAL_MV; return devm_snd_soc_register_component(dev, &wcd9335_component_drv, From patchwork Wed May 28 19:59:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 893155 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D412221277 for ; Wed, 28 May 2025 20:00:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462418; cv=none; b=OIu9GPI2XBEV3VA3q3JSlqj+o9UgxZawwj38IYxXXnSA8UiGzo6GjYkrhKwLzaezTl8CD+GJVYQdAegVh4WuPkttGnjOgS4A9jd1upoY52mBSm+rzl/6j0q6jFubCjiaybbkeUVolHE21pBujq8OJXrQ64dCqEHaxbITYqU6QB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462418; c=relaxed/simple; bh=bE4AstDjnvFxLFE0Ha1Csaz7+vgcKuDvPOFc39zCH/Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gHhcb1O/Dyb8DIca7Wc+eqSrrWTeJW0P3/lhb799YX1+knWs0anuMeJkD78njVkH0aRifiyLlhbhg5ClhJwnVtOHfGU9S+bnk/G3KJLoOvf+YtiVRU1qiVQR/GSax2AEDOTTBmPvGReRUuzZ94fAOueNLEtcd+lnnV7CAlp7nXw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=a31gCKQZ; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a31gCKQZ" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3a4e57d018cso34086f8f.1 for ; Wed, 28 May 2025 13:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748462414; x=1749067214; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mUSrmQGzRLm1yXmwpcZ6EHzpQ97NUziF5cyDbhiDKYw=; b=a31gCKQZFfrFBhW/sLn5IAo96f007/uhu0a74KALSGiC8uLKHJ8LfjQ2J7YMepW86X caeLHrmylAmpgp4FWTfdgOphXvdMG03uOHVE/sBBbDZq7RC45uDhxWmMhczrB+wLdKU+ VCJ4k5UEnp3lweRhr4zM5FIxo2Ost59oZFYqpTQIoQgrLQrYc9Gph0eeHhXSSaM7LLD6 89sfaqYv8PrwDhDZa9MXY+gmXTPU3mzvFEYWcWWAm+OlmGAyI6fMBrsaOKi5ikW5Th7z 7DXec7KNoaAUTJv6cXHiF9FsaPm4KEWTBSLJPTj3ze09lOY1oZx0eajyHPJZM76gtOM2 qh4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748462414; x=1749067214; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mUSrmQGzRLm1yXmwpcZ6EHzpQ97NUziF5cyDbhiDKYw=; b=vzlbRYmHS30kS+tOSfPNDLJruwsRH2RS4on16ZNq7aBOtVL21AnZOEkd9RwS8BDp2k hE/+e3j99/fDlhOEx2kSXSAHX7aJyyWqCiQdwkNDPq/zBHVwSVkGHaEqtxoFd7aUs9Ob gfXLSFkJsExk0oEoWUrHrr/XLb19YjlHxgXAP1Ta7jA7omUPOInEXQ96D4MucHT1XpyI FiPMDdT/i4Dzxeo6pM0uIr/vg8UBw2R3E3pnax+DonQmqvyHCdH2bKMhRxf3GPxoLJ++ XCZ7u+oHUr19LIIrw7K0aKFuSQKGfK2AHAeed9r6qJFAtB0y+bOzJ+FSgVFNn5/IZtQk LmeA== X-Forwarded-Encrypted: i=1; AJvYcCWs5hCATaDz94pZX2L4rVTlr5zUTj8cIbXgs2XVE3uJtX1cIKonivja3TRqkvz8yhJ2Bqa2UJ20cW/coNbB@vger.kernel.org X-Gm-Message-State: AOJu0YxiBYimBqNRVNYEkE78hCNb/NQ3+wxRrD0SgeJzq2XxrzrRSiGm klfiX+muf3kJu6vvIrLKZlqqbefIKoi9LU5HImw6ABay8edjEewm5wCRsA5z+pfLFvWJsiGR07r Eakth X-Gm-Gg: ASbGncuk2k6mAJ3YzDhTjY05teSZh68fkOlx3z7EUCFEt+Mft59prBR49Q4/P5saEXy PAXyCFs7mp23koXQam2RfG5KLspRcNulOPifx6bkgESrzB5+rv22/b+Yfrbl6VQJob+FvFP0sCG +4TkEe2bh3Gfeo5Zo2urUQnPBaooEavn1bXgomOP9dsMXLcbY6dwhv3bcEakUBDhwAPJZ0NWG38 WrKP1vsB2DOo3WO9SYzC/fOZFKeARof18CicXZXUMi7s0vNaAQYB8sUVK0VKDIvdTXrhdjt0KB8 Uew21YYuCjKxJ5YkX6wi/rbJD/s6W80S9ESxQjN7obBO2uC7GmxotCzH30NTh0HQ4N3NMVA= X-Google-Smtp-Source: AGHT+IGfU8NFt+DqotOkDnTjGF7XzJKz4InJeaeMrRliPYDudRhDJYMTWxE+7D8L8v2uiJmW/9+V8Q== X-Received: by 2002:a05:6000:22c7:b0:3a4:d924:e650 with SMTP id ffacd0b85a97d-3a4d924e7acmr4088338f8f.3.1748462414106; Wed, 28 May 2025 13:00:14 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44fcbd61553sm53347665e9.0.2025.05.28.13.00.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 13:00:13 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 28 May 2025 21:59:58 +0200 Subject: [PATCH 4/8] ASoC: codecs: wcd934x: Drop unused num_rx_port/num_tx_port fields Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250528-asoc-const-unused-v1-4-19a5d07b9d5c@linaro.org> References: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> In-Reply-To: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Support Opensource , Oder Chiou , Srinivas Kandagatla , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1164; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=bE4AstDjnvFxLFE0Ha1Csaz7+vgcKuDvPOFc39zCH/Y=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoN2tAPg4TdSpzrnusk8/T1AviguPqy8H5ac0sf fUwz2vi3r6JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDdrQAAKCRDBN2bmhouD 12gcEACIIAskqI79X3CWPeeqtkbf389joGRl9j0Z3/TBo+YE0zAGoLygLCjCxovWSIp4Q9+9bjz tjAG5P4m70aauB0+sUTBy9aS7+sTiY0mxrReQKzqh4FtHSZIorAt5e81IzP8h18ONx4o61A2NW1 ON5zm5321mfYDFeephAO5g+ISQutxjHEbR4Q4QYzIKSHPVJCac1N3gV/xHXRXgCP5TVrBSVbRkZ ugKzBhxgXw8KcMB69mnoHWypcP4AB1GxrDirlql+IywJg9fcBaxe+OhandyVmJaBfqpEW3s6Ce7 2SDdVPdkZhIIPFFwGfcR9gzyW+PhM8l1/m5rq/Tz4/RidVls1Kg8U7woejgDsUakrQsrp2Eia5a MRdps9hdh4dIkJhbUsaQGIrLFKD9d7IvuDTKbLWSA7FWuVt7mVd2aXG+SWTX6sIx6uENZLM/nPq cy114SC/Fq4zEwoLoLbSkgeLj0BXVuJcfm62aSfQFrYCjyZqtHsyEZ5M8VdHZGBffs1eNRo5cue oSSiji8mfSjxawQokubfc+UO99Sr2R65oDtarSkXLjlZtQecJ8yd1WwfobzB96nG8BrQxpsLEDd ArCTD9P0YGhujSOt7JL8FDNkD6Um8WbDDWebxCC6foNi1fKypNRnAZFhdGUrY0nZpclACByimX9 RqKKAUwNqaF8ZcQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Members wcd934x_codec.num_rx_port and num_tx_port are not read anywhere after assignment, so they can be safely dropped. Signed-off-by: Krzysztof Kozlowski --- sound/soc/codecs/wcd934x.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index fa69817c97eaf1bf226b140f3a89095a50a128b2..1bb7e1dc7e6b0a5528cbdb7ada943a7d417fb684 100644 --- a/sound/soc/codecs/wcd934x.c +++ b/sound/soc/codecs/wcd934x.c @@ -537,8 +537,6 @@ struct wcd934x_codec { int rate; u32 version; u32 hph_mode; - int num_rx_port; - int num_tx_port; u32 tx_port_value[WCD934X_TX_MAX]; u32 rx_port_value[WCD934X_RX_MAX]; int sido_input_src; @@ -1928,13 +1926,11 @@ static int wcd934x_set_channel_map(struct snd_soc_dai *dai, return -EINVAL; } - wcd->num_rx_port = rx_num; for (i = 0; i < rx_num; i++) { wcd->rx_chs[i].ch_num = rx_slot[i]; INIT_LIST_HEAD(&wcd->rx_chs[i].list); } - wcd->num_tx_port = tx_num; for (i = 0; i < tx_num; i++) { wcd->tx_chs[i].ch_num = tx_slot[i]; INIT_LIST_HEAD(&wcd->tx_chs[i].list); From patchwork Wed May 28 19:59:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 893000 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2D6C221F26 for ; Wed, 28 May 2025 20:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462419; cv=none; b=AyHtUqlLOEPa3ZeulHbPbqxWA0V6/JUgfo/sJozSpuG/1WeC+biybdUxSiD5T+oSjOfPdcQKUT00o3dxXIgXdWnL/2SR7gLrzlvyfhc0p7QOjMKO66cADPreTIkrz/OOa578s0B45Ob5BMELSdjIMpbBhl6UG8QvWf7xOYkVkxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462419; c=relaxed/simple; bh=lT1m78a5qGVOKbZAbB7diz61bVOOaiAaHoKCKGNWh50=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lU3XzXlEUg9AD5xE9qc4BOy/SG3UwuppaX0W1z2qHAztr4u9/nBeJ+QvC268TOosy4FEfo2gm+tHYrNIBtdMqvq6vNuW1wFpUwAiYfkKfqz92NjJJHCapHT3lCsPdgMjtlZNU+T1hfxD8vSHxdI4hf+8bcDueKNX8I0uROyr0mg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GO3qH29h; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GO3qH29h" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3a4d1e8e02dso16710f8f.1 for ; Wed, 28 May 2025 13:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748462416; x=1749067216; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZDDwbVrb+Lr3lW3ZnLKgMm/1vI4UvBgyIYgvCQObe8g=; b=GO3qH29hydK+KHOrUtMiKKK6AirTwswZhwRee7CPp1ccN7JN3g1HkZ4AFRg0mzoUDu bpRTzCpIm90myFSVu28JeXkxGTSXcNWM/5xu/GRElH9jXutwjbH0hny+soDwR+wQxTrH Sof3wpn4OPM2Tnj8rxOUhyweVxHAR6U2n3QPXSQw/vbg54GJEyommTnlMp2y5lOP5BjD ZrrftRPO9vtUyGfgmJBFW4qsQwxvAE2fo2tyGk0dx7JTR9qzI/6vkHBmUc9VUJxdZB2b 1f04ZbPEtADYxgv+Q7ZpMvVgDesFf34YJ/TN76faVny6bU0FV4g1UvwPtlOjsv0jTrSa 2HQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748462416; x=1749067216; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZDDwbVrb+Lr3lW3ZnLKgMm/1vI4UvBgyIYgvCQObe8g=; b=sbmZ11HhkJA7lmKdg7lmqxyvW7nCP9uzbGwXYOekx0+9v3x1YcV9pSbq3YWdTK/vqQ nIgg/ebykBsWc90Fa7pIwpXJI1ZUbg9/8PNPoE1B3Xzvewj/PR/6WZ3F11i6R1BS8qCK nSp4tBG/cEWMH3iLQn9jsrL/FEBboOlxMDoHlK4HhR0dvPT4Oec2VGyeo/f2dSM6u6Qq glZsSNKySa2TMi3ymypys3qvHL6uE52tS7EN5ZeO9wRHLjwoqDye+fT7QMfuPKrBie+I hwpxmYvSxHylF0yH0I6W6tYM+s13NraQ4N+IXcBMXagJKSfvVmiTJag3/VPlBrQr8f/g ZsfQ== X-Forwarded-Encrypted: i=1; AJvYcCWWE9bCOjd1ZbMLye0/+Xwo+Zb1y/HBzDSoLUb2c85tlA0V9KiUoGit151ZpSTx3FU7mXFdMnxE3Lo3czjE@vger.kernel.org X-Gm-Message-State: AOJu0Yz7TLqJ9sv9N+nsEYREx2SLcLEypuQKwHoVUfnXf0PM2Dpt1KRZ uHIVyQAN4CmkZMZXTUtPXC+REaSEBchebj8aj4PjLT1y6pC8yEuk2YW4Q3JmgsrGMohU6yE40ux BDXeD X-Gm-Gg: ASbGncu5Fm5DWYRjWUhGPeG+OT6dfV1JtKPNJQEFTAaNR6LL9KbsDZ9lWw5zp4xSns2 J6YNFElXvsk1HjlpjjlcyERualDE0v9m+l0J5u3kU9NvjOHbNCxAAr7eV9vp12pmp/SWNOmLqtN XkoKchj2cEyEkhWvWPdf6knrn/JQXPylblMF6loGZwonawTtblIbVQ1CJRBj/FhJfui/SkKn/x3 DcWheFnsH2URNBvf47GytWg/1ka+qIRRwiNCzhlVctQ8QkwrpqQxc9nbZTJest0D4dnbILjmkPt oXsrNdSnjfpgnnVg2RXZSTQ4PMHti1FhotYb/AKvnUR+RamJGT0sl5xdgCSOoiXgOyjoEJM= X-Google-Smtp-Source: AGHT+IEUp9P1Rdo95+j/qcn/d1qWkR9KlqEdDyLtA2WNzV3fonyT5InSDZh/G4WeFsVOslvd6Hfk+w== X-Received: by 2002:a05:600c:4e8e:b0:43d:fa5e:50e6 with SMTP id 5b1f17b1804b1-44c93caf3f6mr63270165e9.9.1748462415869; Wed, 28 May 2025 13:00:15 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44fcbd61553sm53347665e9.0.2025.05.28.13.00.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 13:00:15 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 28 May 2025 21:59:59 +0200 Subject: [PATCH 5/8] ASoC: codecs: wcd937x: Drop unused 'struct wcd937x_priv' fields Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250528-asoc-const-unused-v1-5-19a5d07b9d5c@linaro.org> References: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> In-Reply-To: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Support Opensource , Oder Chiou , Srinivas Kandagatla , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=911; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=lT1m78a5qGVOKbZAbB7diz61bVOOaiAaHoKCKGNWh50=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoN2tAX+wAD12p4wigYDY2/hz3QwOsbso9X89lR Ng5mcXQlruJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDdrQAAKCRDBN2bmhouD 11AFD/9Si+7Fm+Q9EnVv70UQBi958XlJvg081OyT55YpIa1hxdhWjvtPv9J/Tye5eA3z4M6f6uH ne2XxAWlpsZ6axzmSaGie4ev6B8SA8VjFw+WJ9S+35z+X96cXo1U20WxWfFEYOpPuVPQ6JJuwEC j+SjJosdkFzjQmnk8vCjAa49kAcoj1JNwx/7UfGV6zqldKw5KoWcuPd/SQijswZYH322lHgAX4g tjQXn9iAiLMjbk6hJEir6vuX4KW2O0QyBSV57xXbG6WoLRU/wB7pQaazNbmscfplHfdky0k9f9H X+MhRxj7Qu9E7+Z7yaD2LMsY/NNpXCd5P9amcRD5H4qw+lgutinstXm2B0Sta+CRcNkZ41mME5/ ZSJWzxzya2xMJLRzMNXbMNoA2RF+igv9pGmV58qc7vuvOBJpgRLP35kzauyyyBTTXH98KjMpN2S /h96NKtr8WlY1OQHyqo4ht122F7EbXOZaZUjnPIdJyw6QEkLZgjG4rDJhNfPQMPiub/hNA2t6j+ c7UeNznq5hoiDPS6gZd+Xa5n7RI3iqp+xYLrhhxmINw3lC0XfkhcDg20CgFd9iUZH6NHD5FsG0D LFaUlKgXuxHXeK/uKHGbMlSiAvlqasEmdqAx9OswqTLn4b0k/dDqNPuftnlmU20Fikt6/UanITc a1ICln+E/ZwXwFg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B 'wcd_regmap_irq_chip' and 'jack' in 'struct wcd937x_priv' are not used at all. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd937x.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/wcd937x.c b/sound/soc/codecs/wcd937x.c index b9df58b86ce953427e01ffb8c7eb7e52f9c2392a..126a29e0b3ff96c12fdaba2b9344a3040b455e44 100644 --- a/sound/soc/codecs/wcd937x.c +++ b/sound/soc/codecs/wcd937x.c @@ -88,10 +88,8 @@ struct wcd937x_priv { struct wcd_mbhc_intr intr_ids; struct wcd_clsh_ctrl *clsh_info; struct irq_domain *virq; - struct regmap_irq_chip *wcd_regmap_irq_chip; struct regmap_irq_chip_data *irq_chip; struct regulator_bulk_data supplies[WCD937X_MAX_BULK_SUPPLY]; - struct snd_soc_jack *jack; unsigned long status_mask; s32 micb_ref[WCD937X_MAX_MICBIAS]; s32 pullup_ref[WCD937X_MAX_MICBIAS]; From patchwork Wed May 28 20:00:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 893154 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 287332222C0 for ; Wed, 28 May 2025 20:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462421; cv=none; b=ugFBrWRyW/n/CzBaFUtk2/W6MiFj9O64TBGRgitMBr3Vrg6kq2D4fzC/qhwMWbMOlsWaFUdkuG+EO260o1PUmld/YGehW+1THpVqICtFuP3dZES1LtlLcQFfZPGxrgEGNRsTbpa1Bz8bUWw00+p8CnajBxDet5v3XPSLaiG+cxs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462421; c=relaxed/simple; bh=Z3E6oDJPvDaUYacpuceMJjGq51yqfq9d1bcUwD94Ip0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QBH2BsJfcUXw9BWrV0yOddAmkn/+onllsM4f85xurmsxaNyP2JUi+9cSVneQGtBb74L9SSJdA0T0qQ4XeFNjveGS35Igw5DpnQATIn8Rbw+gqD0OhzLk9b+X5Z/wRd9lNdv0gEK6w9p9YQpFABkYRK0bPmqD2OwjTQ1NeoBbotg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QS5fHPff; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QS5fHPff" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43f106a3591so189835e9.3 for ; Wed, 28 May 2025 13:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748462418; x=1749067218; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ea3dEs9bTYxVxfpPjS7I2hituCqW83SA2oFlYXKAEAg=; b=QS5fHPffwBkWqQc2mL8JtNtvOq9ZxWqtMr13hQxeOxl2cQpy8qwEby/kltGya+vTd3 1fobLulXXJTqsValqnBkaM4ieXQdey8ZNiiiUy69ZZ9Fub4vKcqtJ5F22a9RiHvRyzxZ ZnNUs/3RmpErRiDSSDhe7tzVXwXA8+JDjSALQtsD4bVGs5/lys+kZBoLRqRyqbpK5T3J vKIj3Xd1R+ZtBzvHTXm4YD5fKBPF0mEfeIE8h99LRh2Lmld8VTVmJx0MvAFaRmO0hBBT ajYcmlPtxZM8mCrnIjZ+P16y5h71/TJTMf0zReZO1sa21AZcwFOHyEghz/JZ+uoD0Uv6 JKfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748462418; x=1749067218; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ea3dEs9bTYxVxfpPjS7I2hituCqW83SA2oFlYXKAEAg=; b=P2VKtvrQY9y9SgVcmhVU+sFnBCpNzlNjobgR+5O1wak+BZluxOrKs7e+2HJA0mL2IU JsDVw2qct2d80ZZQvlAzH8+v5WLmsQy2iILwutjnkkX3sHiT1J56c1oMB/4qSEI8uMXw 2ZJg5ZAUba7Bwj6QRw8uW0BQNxU7voZ9uCzFhGrd0GUFN6T+7/Ch1td09lJwEbPMDPTf 3D9ImW6ZRxZ9xnDipI1j2J+3EhU5xiwsHHZyDLRaSnqYq9PDIk+kQMxlBWrxWCqdh2DX FMl2qjXvP6c3CSGN3e6Wi7pWtWowYOnQs/MLHkauezKNcaO82jqPl2KNb7MyU63mWiFY RdwA== X-Forwarded-Encrypted: i=1; AJvYcCUkjMWXhR1VBCmb6sK42q/bXkgPH7NrxujvGNqB5eZowV7Rz7/ze+RQQS8EYFyzgigy6oWv4ffrAEIDWSIF@vger.kernel.org X-Gm-Message-State: AOJu0YwlNTSkqPvCT/RpYAUd39+sDRUadLfg+iF8n9ZhXe/b5xAZCB8V UTl6fGPKnsOJ4uQoNDwS3JgGGDgrf6BfSY1ZCkOapIuWaw2lQRkbJvcN0r1fQgcvrHQo+Th+Y4F m7HmJ X-Gm-Gg: ASbGncsp1Oh8s5fWeSAXySwnhRq1zFzRRqbzcZZ2xX8EVzeceSFKB872HaBoxjTKoUe HMCmjlVp9VF6zPIidoG6sV0UHMiRKuTvj9AtXp2rAQIuuJOtfF39zScxY/RoaYts3kXKKdO71Rv BEIuj6Fqm0VnetbY2cfpJGm+ORQEZHCEl8MFyQbaaRePmxJFf1z13eDlZ5TPAfM8W77pT5fe6jH r7IYh78b6CROojlT38kSiX0JsNbVbebVuzrOAxvu+14VH5CHkfEjWrbUSJZNO5BBcA5Lwzm/d9h B+OjWm1css4UiphnyEBLNeLOeU5OKmBuXikRSa1VstdSvd46V9ZXkE0L4axbjaP2W2UiShQ= X-Google-Smtp-Source: AGHT+IFtclKo+09hBvWcaA31MANMniSSR3dkpZhR44JC9e8qX1d5fzwX6jzxBVXv3eOZIbMOIQHv7Q== X-Received: by 2002:a05:600c:1ca3:b0:43b:bbb9:e25f with SMTP id 5b1f17b1804b1-44da83f6d0amr52288855e9.6.1748462418080; Wed, 28 May 2025 13:00:18 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44fcbd61553sm53347665e9.0.2025.05.28.13.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 13:00:17 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 28 May 2025 22:00:00 +0200 Subject: [PATCH 6/8] ASoC: codecs: wcd938x: Drop unused 'struct wcd938x_priv' fields Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250528-asoc-const-unused-v1-6-19a5d07b9d5c@linaro.org> References: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> In-Reply-To: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Support Opensource , Oder Chiou , Srinivas Kandagatla , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=908; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=Z3E6oDJPvDaUYacpuceMJjGq51yqfq9d1bcUwD94Ip0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoN2tBcrZHChf8/ltrvvcWeilQUPKYCEoVAI3WF kFIF1ShmMOJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDdrQQAKCRDBN2bmhouD 1wwZD/9BdU75kK7j0OCvqJCnr/wdNWfI5o0ONXRaXUHwVAJLqxX8XNjGRzJ/VWy368PSGuDEbvp FYmPomg3lI2VXO02pZgFsFlHf+XkHGdDjsFPfzJSTWKYpLqQhQlEOqOwjDex2Qz0AWlx82lyNd+ Z8UP8Z7gg9wOk7ba0/YEcDRcrXNkrhFz6mpYk3U2RjRlfSCP2Zb7xee4Gp41ILpX+Kg1C5arNvY Ip5NrnqJUisJeNee4tk5sNH/sndo6iNngY4CBTZ/39Z0LaPNNSB9p9/quvh7kgHXFsH77hn6uoa 6hF+g18EoEjxz/lP8+p69hyfJBKK2mitWDp9w33WMxxSfo8kSIlV+puRWzu0Ui9/LQEZboQB/nC eBXRcWXVtldTvxM9iHv31XirBezr1HFLPhXqx9RnxttVU/24GsGALDs1ypvK646ekz/UwnYBqUA jaeWQlr4d6wWHxWpyFis2jHH1SOeSXgZ/VwyFU6Mc7WEPsDb5k9odD/qNZh+cdEcrD6wEARB3l5 FKDTfzwPaUxUSmOIqOPULOVbUSmDCYpwrtd/CeOjUJckSU9mmiLN+qUAuz4u3JGSw+p5cO008F7 o1GG3E+avvMiP5RGreaGPOiiQfWdTWTZd2zKu7EJbUt1RCsc+HtSiKk4nZCEiG5edS9XKWgTFtJ kpChjEVikYq/O7Q== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B 'wcd_regmap_irq_chip' and 'jack' in 'struct wcd938x_priv' are not used at all. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd938x.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 342d1f7d5dee3ac2d703e5b5602aef9ca2987158..43347c14070ca6dd8035b0c290f0dacb0326122b 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -159,10 +159,8 @@ struct wcd938x_priv { struct wcd_mbhc_intr intr_ids; struct wcd_clsh_ctrl *clsh_info; struct irq_domain *virq; - struct regmap_irq_chip *wcd_regmap_irq_chip; struct regmap_irq_chip_data *irq_chip; struct regulator_bulk_data supplies[WCD938X_MAX_SUPPLY]; - struct snd_soc_jack *jack; unsigned long status_mask; s32 micb_ref[WCD938X_MAX_MICBIAS]; s32 pullup_ref[WCD938X_MAX_MICBIAS]; From patchwork Wed May 28 20:00:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 892999 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDEB0223706 for ; Wed, 28 May 2025 20:00:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462424; cv=none; b=cl5BXnYyzFSK+U86sxh9uWU4GvtZYw7z7oVy65KseooDHLkoUv6ymNsGuRk1tA4VKHub/Ea8pEfmWzMLRvu9pKcHhYY7UZ5n8adH91ELX2DlJlDn8UpuL8QdVuwtBapgT1XfgRklqEuTbQQBitAdo3GKjOSGxYTyaz1Jm8EYJLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462424; c=relaxed/simple; bh=vpHnKSsMPwOT5apYVShhmLQTAWNAh/9Zf7Yg24ClShA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Mhg+rrdy8N96cgQJMwhdU+E+Hwkkx4UhK1xl1lvOKslLokT+tVK6DJOzm6VLrNPZaiZ8l+U0FEyRb27gMeiY25Ej7ji28ySVPp+XsUNBtpY+52/BDoMRBDagQQ8dXFOsnAZ+pOd9EEDK2JGRjVEyo31NpPFQI2bJ7CnRW8VuyZ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XaZNYvoG; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XaZNYvoG" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-450828af36aso82335e9.1 for ; Wed, 28 May 2025 13:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748462421; x=1749067221; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EhFsa53Dn3tZ/YQodrCRFl/D/vPq2gHvZA39y3H6S1o=; b=XaZNYvoGPgIpE2BoBu5v833ASfjIiQgifzIifW2naDWNwRqiBekhhuWpkliJ4FYBy7 7yc+xwEgzCBGXbLMpnFYfIKiQ3t/DQT0EhgN0LGng9j7SU38EVorV0zwEJ0neaxHBDNt xzPfdO+6yGSBMXavDWkd71v55C2WrL/fkZ5XW378szujaOgHkkaODEgbKb818wW023aa LCEhi2qt+ycOZ3C41+Wjm4/fHY35tMyVGAUWN+AyUtC9brUJzHl4dd3ChG0U5SL64dKL c6+cwlXmBhn5qp8MlbbJxDNbx6RQimPOAwjhPNxK7/2Fe6kpjxFs8SA1XOIqZ/J1eYHV VQGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748462421; x=1749067221; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EhFsa53Dn3tZ/YQodrCRFl/D/vPq2gHvZA39y3H6S1o=; b=uX+IyVN72ltDejPPNC59ygsYkxOPklPwtG+qm2UHh8VdS+y49uyttAz4RjEjq7XTQR sg0Llro1WFH607AuNZywgcpNQfMes1yxISD0vDMQv988UJ2hV2ITEnun0K2mVNOsFDWx OHNHlIh0oq2PZb6AFLvazDJhH3wOSKUFqnDjzPco4zhzQ/WCuUMiFS040AR7ZnlEdWZY XMiYsd52S+pmVDezk1lEb8gyfpcdkDqsXP5EhFyNW8YXzolLuZnNbL7eapL6t0WHgYk1 EuhFlHyaOYqtYyMs+JRRgvnVndGhuqlXICw4TLRoZHRwLegvqW4E5j0ERs3K092GVJDf X0/w== X-Forwarded-Encrypted: i=1; AJvYcCXsA+xd5Ddv/Y0j44Ee4R0WA4feV2Hs3sItbCOB2YxXUmwjd+5bgNdRW57OhFtPgdCbIiBIsZe1zuZWBB0f@vger.kernel.org X-Gm-Message-State: AOJu0YzldeuFTUOHvQeSg1bR7qzWqF48NuwOISc4puUjoUuvdlnsQMIn gb/3bWAWljKdOKDJYc9eNR1LXCA0AOCt6XfbMYjkzb7OxXBheMkh3euUj3PKH/TkGmNP6vkWHln Eq6tT X-Gm-Gg: ASbGnctSpZJteUkChI16OoMwhcZc2/5VxwLvJonEw5OGu5StXJFinDaCJRfSmhGiA8C FNrto9+D26SLauaucmdOAffm3gFnx5K6oeL32qkraj4twtfN2zFddbOij2v1r7/0fKA4bdnqsbc fmCR0Tqmu+lxOUogDLqI/CJ5Mkn/Cea5ZcNO1Ml0j5qXzO16kveU1fo93fVcFycD+7NoqkL807a gnAmRZAcAnYoNHeKHl7ag4Byeyx/KlCpZWUqJrvQskvCUaRRrTv51Pjz2M3uOplY3hy3ZbjxRez pgx87KE0YnvpO58GIC2Vfc8aVrBrk1SPV4RRt9jjEQWnMqVCaccY3Ac7TFGk/SmwwDYdvSI= X-Google-Smtp-Source: AGHT+IFgK2K2RWnYXZ98CP7PqDkbOJ7HD/Q61UfK0JTIS6/x1cpTvbtFdyCFL4yZitYpbOagT+DMiA== X-Received: by 2002:a05:600c:3b99:b0:439:8c80:6aee with SMTP id 5b1f17b1804b1-44ff4071f7dmr15017665e9.4.1748462420725; Wed, 28 May 2025 13:00:20 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44fcbd61553sm53347665e9.0.2025.05.28.13.00.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 13:00:20 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 28 May 2025 22:00:01 +0200 Subject: [PATCH 7/8] ASoC: codecs: wcd938x: Drop unused variant field Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250528-asoc-const-unused-v1-7-19a5d07b9d5c@linaro.org> References: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> In-Reply-To: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Support Opensource , Oder Chiou , Srinivas Kandagatla , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2615; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=vpHnKSsMPwOT5apYVShhmLQTAWNAh/9Zf7Yg24ClShA=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoN2tCjfNAV+kCU10X2cqnxwpT+fWymWyuVDFrl /mM6y3R76iJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDdrQgAKCRDBN2bmhouD 17OSD/9sy1aTm6SlmWbrKPTB24a9SyULGvFc6f8kqmmjgsEgGsx7bS2Sshyxn55QGKOe0ABB2oK kx0dUHpTHoxUnYz1QLaAVl9uHNHNkZkvFx9YfpJkVSJy1O5nK83aqEunkX9blBQ0c1vnFegsPuk 3oygNoAGFieGEpTLsGsHEndt5D+uRBdqWTqwi+BNSom8HvfFN5z21tmO0lRi0dva7fiGwRuED/S Fdx+hpru1FRbJcBAUcnycfOdK3Etc3XAw6gX1gYsERZFT3K2llZoggkubN/jbC9AkDEYYsTHJxo WwxIT5bD18zwQkirmjAeP4oYZ7bUKxsW8VllKXlpNrvsvqEJ+mubb0RuYO1OyeXyphex198W4GH 87yClKM7xjncSPQsTvhavYxQMaNZui6lcQX6Ri8YAuUoIKQns+c7AG5OldMjoKgZC/RnEELjIoP UXc6AeQxYyp56GOQ6tna7ra+FoutpkwAXNX80pvSYaygp2Ca2Ol5Zr7y+IKdWXcO0uQdk8HZDjP GNnvMh0p7TgTTtxYkn0SO015It+ceZYz91KYO1j9glfiZWOBFnaooLovnMMWvKD9a6hJsLjHeaL kmTfNTMgyZWy1hVL4iQ/+vmk6wG33yxjLIUjyLikKYV12gIehXJEahkLId6eIxy7ozrsP9sExAG Jpwt+bKhJF86kUw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Member wcd938x_priv.variant is assigned in probe() function and used immediately thereafter, thus it can be just a local variable for less variables stored in 'struct wcd938x_priv' device-wide state. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd938x.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 43347c14070ca6dd8035b0c290f0dacb0326122b..5a751056a98a5d4cc5716aafc25af27e3ab22786 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -168,7 +168,6 @@ struct wcd938x_priv { u32 tx_mode[TX_ADC_MAX]; int flyback_cur_det_disable; int ear_rx_path; - int variant; struct gpio_desc *reset_gpio; struct gpio_desc *us_euro_gpio; struct mux_control *us_euro_mux; @@ -3044,6 +3043,7 @@ static int wcd938x_soc_codec_probe(struct snd_soc_component *component) struct sdw_slave *tx_sdw_dev = wcd938x->tx_sdw_dev; struct device *dev = component->dev; unsigned long time_left; + unsigned int variant; int ret, i; time_left = wait_for_completion_timeout(&tx_sdw_dev->initialization_complete, @@ -3059,9 +3059,9 @@ static int wcd938x_soc_codec_probe(struct snd_soc_component *component) if (ret < 0) return ret; - wcd938x->variant = snd_soc_component_read_field(component, - WCD938X_DIGITAL_EFUSE_REG_0, - WCD938X_ID_MASK); + variant = snd_soc_component_read_field(component, + WCD938X_DIGITAL_EFUSE_REG_0, + WCD938X_ID_MASK); wcd938x->clsh_info = wcd_clsh_ctrl_alloc(component, WCD938X); if (IS_ERR(wcd938x->clsh_info)) { @@ -3115,14 +3115,14 @@ static int wcd938x_soc_codec_probe(struct snd_soc_component *component) disable_irq_nosync(wcd938x->hphl_pdm_wd_int); disable_irq_nosync(wcd938x->aux_pdm_wd_int); - switch (wcd938x->variant) { + switch (variant) { case WCD9380: ret = snd_soc_add_component_controls(component, wcd9380_snd_controls, ARRAY_SIZE(wcd9380_snd_controls)); if (ret < 0) { dev_err(component->dev, "%s: Failed to add snd ctrls for variant: %d\n", - __func__, wcd938x->variant); + __func__, variant); goto err_free_aux_pdm_wd_int; } break; @@ -3132,7 +3132,7 @@ static int wcd938x_soc_codec_probe(struct snd_soc_component *component) if (ret < 0) { dev_err(component->dev, "%s: Failed to add snd ctrls for variant: %d\n", - __func__, wcd938x->variant); + __func__, variant); goto err_free_aux_pdm_wd_int; } break; From patchwork Wed May 28 20:00:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 893153 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2152223DCE for ; Wed, 28 May 2025 20:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462426; cv=none; b=bLS0xq9r7LK7ZD2FIoKbCLv1Rulimw80m2/Elrx6H3FccvauWbVkNGV/krDHjR8vmY9gXc/bd5NrpqFqOnsUdEGirLMi5db1fLUGm5CwtH73MCwk6DJ/w5xqXEa8YYriZMNN5IBtGqU/4DJSafatq4Mfkc3UapFnpm7GzB8EorQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748462426; c=relaxed/simple; bh=5DA+AqsUHtlrpCLr53RVEPhkKk3E6BWf3tgkSlGM9po=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tHb4Wiv7/OqT22qXTh8sKbTGQtV49BkN9Ye9jQ0UgkICtkR2h417aJfoPHBWanCjRZJlF+HMWTu3qBqGhrxA7BPFBT5f5Ad2B8X4U9P20Kd6aZeb8QnKSX7cgsNsA1RCctHmxGuWBihsjsXigOvbMBx0i4ucreVp7ovuA60xO7s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ljm8VMBd; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ljm8VMBd" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3a4cfa5c8ddso29292f8f.0 for ; Wed, 28 May 2025 13:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748462422; x=1749067222; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UKLxvsv39RxRJwsXICazlS7Jk7LfOfN7XFHnOLZsSTY=; b=ljm8VMBdoZqhlxe5P/bT+dtQhctkx0PtLIDzRLFgvoFsCNNa1w022B1RPMtNW38s9e LeK9tE8DdEfFTplxFWz2ZoF4CJioXarUzXT9nbRbf0t1slS6KcSW0k2iBkyPRVIzCtDm wHj8/q5McGa5JnnIzaG7NvVdR1FCrSKke48j4zhUcn80VJHIIXEZ9mTONIvwtR2K0hSu v4fHh0IEW7KwapWMB43p/ULX1UC88Mg3S9JPRgscKpspvywe/NrGRxV/hOYdC60px6ix wF0jNM+ETBMktFuwvffLU9ixdG0tm10MXUgjF16SmLH/NIieDZfQe/AuP+pEdBZYuoDC nXZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748462422; x=1749067222; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UKLxvsv39RxRJwsXICazlS7Jk7LfOfN7XFHnOLZsSTY=; b=StHMEC0isN9z2F37OkcWp9JKfwV3qR6L3ideRX1EgkPMXMqR/MVSzmr2wXMxb8qsQV 6ObVZ3bagDhn3N6sTGx/KEGmCIrVUvcibjRDVLXr8osVJIkGGH4FmhV6604SsPKPkn7n ywH6udNcXS2xw6q8r8J7V7MRSQ6OeVSsnEFinib+pH1bgZl7CWGxSijrMEbRazD0sejQ A7uCQtDetiSjUeLk0fHSu1UDfQ2xCu+YE+CJwijlBN6Fuw9L9tIjn4sfbemUtsPd0Rnf MOSvy7Ca6PifQpdn8T22YshCjZElHAq+tIOF3eMgzTLQu7c4Pf+OyVL8R54FVsl1qeqE G6Qw== X-Forwarded-Encrypted: i=1; AJvYcCXVL+MY9CkZbm2Br14lR7uCqPyr88k/lrHWtKU4nP/usWtyu2G5bpcbGnF+LV3MYJLWisW6EHPUEwAXGNSz@vger.kernel.org X-Gm-Message-State: AOJu0YytWwHLjmrkhxVnsZCuk1UDuXGMtNAtrFPWwlXmItxk57EvQpu7 Gley7zBXa88zfI4NJ0DKD4dpV6t4zMmcYCE6nz5PT2s+HfkyG94WNBq9DWr3wl3BpDvPaU0wZ8I d2FLm X-Gm-Gg: ASbGncsZqk2TQtdm38YeAy4bj6AaKsNY3WZIJPCGxX2lhZIcLAmhMw4JlJAO7Yiw8x8 SUoX0L1ro0ZCszRRElMD2CeGVFPXKqskNmiEtbVGCOfjhuM5pBb9F2bOY+KaJdigswOcB6lX/sV A0WtgWWb5pqebMwfJwvdhgmUW87Y2oFcphcFDq8Ip7ioHQno5SFnOTl1e5MOYqOT6DcEVQa56Jy H3t2D1E/oqUVUBt19SkzOsa6emtAMVB8kL2CIlSqeCdR6DxzJAqWLtWymW0LZdHZ3EzfVyeIeEP 8sbmuY3wWQ3F9Uy4rCjuuN4z9lu6b375jtcZ+WR51Mgd9qJdVjaU6oAf+o096/L1lcjngZ+LXGV eP8VzHg== X-Google-Smtp-Source: AGHT+IGJ3sSfYBTi3fPzjAN4VbtvolMgUW9qvhXd5IMVHnaBWBDNY4Nx1ZMx26UcQkDgBz2hyRa/zA== X-Received: by 2002:a05:600c:511f:b0:442:e608:12a6 with SMTP id 5b1f17b1804b1-44c91dc9fd0mr58577005e9.1.1748462422502; Wed, 28 May 2025 13:00:22 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-44fcbd61553sm53347665e9.0.2025.05.28.13.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 13:00:21 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 28 May 2025 22:00:02 +0200 Subject: [PATCH 8/8] ASoC: codecs: wcd939x: Drop unused 'struct wcd939x_priv' fields Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250528-asoc-const-unused-v1-8-19a5d07b9d5c@linaro.org> References: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> In-Reply-To: <20250528-asoc-const-unused-v1-0-19a5d07b9d5c@linaro.org> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Support Opensource , Oder Chiou , Srinivas Kandagatla , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=908; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=5DA+AqsUHtlrpCLr53RVEPhkKk3E6BWf3tgkSlGM9po=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoN2tDrfib95CIYvZk4xi7M3DrBPE5m3VnGlzkN aW+v+MbM4yJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDdrQwAKCRDBN2bmhouD 15GKD/9fKywTDMjSHUBEwvsrMSYZ7PJx1H3Kx5RNb5MUtSG25meDZbWaHgDfMYrAPGpDsrgrtFR SGnr2WIOUdS4bx+SOU06YlLibFXpT+Uomolo2M9qHd7FLc9eJoh1VJ51hjHFznCbfpvEHAA7Fd+ S44waPs6dgPrXRiTebK6adQOIYTf0kbBpNxkpwzdU6qNpSXeDzoDhbBYEI6bVp7ACElErAPg+NV HVY1qU+6PYUr2qVy1oTqiRvJoJ+4XQkSRNTLJArUdzXCN0gVU12dVuWu8n02ktCTobOjY1HflB7 N39K6tqGL+Yu3tuQjuBjiF0asayZYqxOU70Zvz4Uj/82wQ3+yPqLWofZZr5nBf4S+eH7A+nUcLn wKuSW0AARL4MBdUQMBsByDZ+1583R5ti1ZzC5jcqWsyd/WUpPz1drs0CH4u9lcIQB6ZrWhQWIzW YoOULhkd7QttJe6kqE7XG2yq13z01RP7ONPPWtgJdlBtic1UKttSPbvib5iqZfIiOL0qhzYmcRA hLLlgRGEGM+6gL4ZMIpaAhypFVgKfBeyC5YlrjiUEy9y+aDSJTcOmrtR9SSI3JrzAB4lg1AQ2bu +t0xvzD0BCNsmMcuB6x3ZWOGTergECuyHVgmIaHVU8ZxvHTWUfHLsqEnc1foLwqqtXekUF4SY7C YLds3m08OwHgHMA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B 'wcd_regmap_irq_chip' and 'jack' in 'struct wcd939x_priv' are not used at all. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd939x.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 067d23c7ecf90ae06da1ad6cc89d273fb7f7f875..bfd4d2c8bdc9bcfcdbf673d20458f779922eb464 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -190,10 +190,8 @@ struct wcd939x_priv { struct wcd_mbhc_intr intr_ids; struct wcd_clsh_ctrl *clsh_info; struct irq_domain *virq; - struct regmap_irq_chip *wcd_regmap_irq_chip; struct regmap_irq_chip_data *irq_chip; struct regulator_bulk_data supplies[WCD939X_MAX_SUPPLY]; - struct snd_soc_jack *jack; unsigned long status_mask; s32 micb_ref[WCD939X_MAX_MICBIAS]; s32 pullup_ref[WCD939X_MAX_MICBIAS];