From patchwork Wed Jun 4 16:13:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 894159 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9398D1DB34B; Wed, 4 Jun 2025 16:13:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749053636; cv=none; b=npvp1gHp6vA7LW0102uejCSrSToUO+ZMxHnpdkLrLn/gWYitRGvIaImlpPacHjW4qT/6TpDc+TjIE4XXSCPoAVe171+nctDhyYF8Cnro8XPQ2MfDn3xgsYFB91jG5s8kffsPzT+s8XHufjfWsMbLvNGWFlP9tjWv/W0HK/nyhVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749053636; c=relaxed/simple; bh=gT9GBvOSDzBhGo5mZNNkNzJ98TDzw354ctI3xOd57PA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HUNZhjkneOsRYbwFeNcv/x/O+ooM3YlQB2BXWwIAVe+DoTnOYHAm6sUaHwrG4xOxbaMgTUUFeoG/h8/rIY4PHJkC0/ptYDQhxMBHQOhnsraJqmT8DpTbl7V/2u8by5izO+QLtoh2UM8lyP52ooYeZCYwN/aRPOvbE/a6CVmcOTw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=PgC3zLsc; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="PgC3zLsc" Received: from fedora.intra.ispras.ru (unknown [10.10.165.17]) by mail.ispras.ru (Postfix) with ESMTPSA id 3DDB0407618E; Wed, 4 Jun 2025 16:13:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 3DDB0407618E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1749053632; bh=nkt1L82aQ6GsktfVLB7qp2/gA1gCgwVjkKxLM6i0PJg=; h=From:To:Cc:Subject:Date:From; b=PgC3zLsc1Ouq2zG3taX0bUnQ8246aBUrrOOsRYI7YKW09WxsJBtAPzE3v5utZ1iW4 FZltqut5lZbVuxM1pzUl8VZDMYOpnObCp9KlzKiaJ3BqHgb9AzM2Ekc5H/UjPrk0a7 CIQ50KdDb/p1jKY+DcZDKk6MbJa/nlhusnlOB4DA= From: Fedor Pchelkin To: Ping-Ke Shih Cc: Fedor Pchelkin , Zong-Zhe Yang , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH rtw-next v2 1/2] wifi: rtw89: sar: drop lockdep assertion in rtw89_set_sar_from_acpi Date: Wed, 4 Jun 2025 19:13:32 +0300 Message-ID: <20250604161339.119954-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The following assertion is triggered on the rtw89 driver startup. It looks meaningless to hold wiphy lock on the early init stage so drop the assertion. WARNING: CPU: 7 PID: 629 at drivers/net/wireless/realtek/rtw89/sar.c:502 rtw89_set_sar_from_acpi+0x365/0x4d0 [rtw89_core] CPU: 7 UID: 0 PID: 629 Comm: (udev-worker) Not tainted 6.15.0+ #29 PREEMPT(lazy) Hardware name: LENOVO 21D0/LNVNB161216, BIOS J6CN50WW 09/27/2024 RIP: 0010:rtw89_set_sar_from_acpi+0x365/0x4d0 [rtw89_core] Call Trace: rtw89_sar_init+0x68/0x2c0 [rtw89_core] rtw89_core_init+0x188e/0x1e50 [rtw89_core] rtw89_pci_probe+0x530/0xb50 [rtw89_pci] local_pci_probe+0xd9/0x190 pci_call_probe+0x183/0x540 pci_device_probe+0x171/0x2c0 really_probe+0x1e1/0x890 __driver_probe_device+0x18c/0x390 driver_probe_device+0x4a/0x120 __driver_attach+0x1a0/0x530 bus_for_each_dev+0x10b/0x190 bus_add_driver+0x2eb/0x540 driver_register+0x1a3/0x3a0 do_one_initcall+0xd5/0x450 do_init_module+0x2cc/0x8f0 init_module_from_file+0xe1/0x150 idempotent_init_module+0x226/0x760 __x64_sys_finit_module+0xcd/0x150 do_syscall_64+0x94/0x380 entry_SYSCALL_64_after_hwframe+0x76/0x7e Found by Linux Verification Center (linuxtesting.org). Fixes: 88ca3107d2ce ("wifi: rtw89: sar: add skeleton for SAR configuration via ACPI") Signed-off-by: Fedor Pchelkin --- v2: no changes drivers/net/wireless/realtek/rtw89/sar.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw89/sar.c b/drivers/net/wireless/realtek/rtw89/sar.c index 517b66022f18..33a4b5c23fe7 100644 --- a/drivers/net/wireless/realtek/rtw89/sar.c +++ b/drivers/net/wireless/realtek/rtw89/sar.c @@ -499,8 +499,6 @@ static void rtw89_set_sar_from_acpi(struct rtw89_dev *rtwdev) struct rtw89_sar_cfg_acpi *cfg; int ret; - lockdep_assert_wiphy(rtwdev->hw->wiphy); - cfg = kzalloc(sizeof(*cfg), GFP_KERNEL); if (!cfg) return; From patchwork Wed Jun 4 16:13:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 894404 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21A021DD9AD; Wed, 4 Jun 2025 16:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749053638; cv=none; b=jaf9lHj+nz4y+3Z6YB3V5dCrvEwqBMOXckix7ZM0J6ROCdl5eESHeZ685Cm/3j67A30N3O94CKc5rDMTrZzUXH0sDRkfFNRPItLSsG0BEWQ2gfxIxvvjhlOdL3lzTyVgUKFPkdyv9Tv6oeYYPHCDz4tTFrszuori57ElyteaO4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749053638; c=relaxed/simple; bh=dar1UznmH1Dll183/KM4lYfwaULVTLS18BvAxxVcJ9A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C/4poRjflEvcY5P+OxUO34nvXLMoBjrmIU1znsq49KUe47/LZa8yDTGbVaoExOsaDlqxMIwFa+a10rY0NysFJxKTGlPjEyc8qj5pTHIyuXWcbeQeiVUxeIYK14W6mATbtPh/9JSdtRdcrD84JlaDAVHEvDmPbGKsAP2O5nQ5X18= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=RqWS4ZkC; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="RqWS4ZkC" Received: from fedora.intra.ispras.ru (unknown [10.10.165.17]) by mail.ispras.ru (Postfix) with ESMTPSA id 7F32E4076195; Wed, 4 Jun 2025 16:13:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 7F32E4076195 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1749053633; bh=4RFK3EPTWy73fhjq1/g3Bo8lLlasyD5LV4zIUsgviZg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RqWS4ZkC2JjCmSRWkLHLSeIZzr14ClDzg0TXia1k4TjEvTxMH+NP4RnmExQagQB9C mc3Ajf1m+x2AK31/OmJFc7m8Qyy/6+O0SSTC8t2dYKiN13WL9280bN83wgB/ADoOpl enqeo2ByGgErB1kYaN9Xm6rE/wr3lb1MTP6xwAPY= From: Fedor Pchelkin To: Ping-Ke Shih Cc: Fedor Pchelkin , Zong-Zhe Yang , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH rtw-next v2 2/2] wifi: rtw89: sar: do not assert wiphy lock held until probing is done Date: Wed, 4 Jun 2025 19:13:33 +0300 Message-ID: <20250604161339.119954-2-pchelkin@ispras.ru> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250604161339.119954-1-pchelkin@ispras.ru> References: <20250604161339.119954-1-pchelkin@ispras.ru> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 rtw89_sar_set_src() may be called at driver early init phase when applying SAR configuration via ACPI. wiphy lock is not held there. Since the assertion was initially added for rtw89_apply_sar_common() call path and may be helpful for other places in future changes, keep it but move it under RTW89_FLAG_PROBE_DONE test. Found by Linux Verification Center (linuxtesting.org). Fixes: 88ca3107d2ce ("wifi: rtw89: sar: add skeleton for SAR configuration via ACPI") Signed-off-by: Fedor Pchelkin --- v2: move the assertion under RTW89_FLAG_PROBE_DONE test (Ping-Ke Shih); add Fixes drivers/net/wireless/realtek/rtw89/sar.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw89/sar.c b/drivers/net/wireless/realtek/rtw89/sar.c index 33a4b5c23fe7..7f568ffb3766 100644 --- a/drivers/net/wireless/realtek/rtw89/sar.c +++ b/drivers/net/wireless/realtek/rtw89/sar.c @@ -199,7 +199,8 @@ struct rtw89_sar_handler rtw89_sar_handlers[RTW89_SAR_SOURCE_NR] = { typeof(_dev) _d = (_dev); \ BUILD_BUG_ON(!rtw89_sar_handlers[_s].descr_sar_source); \ BUILD_BUG_ON(!rtw89_sar_handlers[_s].query_sar_config); \ - lockdep_assert_wiphy(_d->hw->wiphy); \ + if (test_bit(RTW89_FLAG_PROBE_DONE, _d->flags)) \ + lockdep_assert_wiphy(_d->hw->wiphy); \ _d->sar._cfg_name = *(_cfg_data); \ _d->sar.src = _s; \ } while (0)