From patchwork Wed Jun 4 09:16:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lin Ian \(CSS ICW ENG WFS SW WFSW 1\)" X-Patchwork-Id: 894414 Received: from smtp14.infineon.com (smtp14.infineon.com [217.10.52.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE01A1EFF81 for ; Wed, 4 Jun 2025 09:17:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.10.52.160 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749028648; cv=none; b=ht7i4W64b1ovOZuEp3bOsvATYUlFrf9x/9SQutg/F0p+o4rHBajrQpr/ZcQjeuumvO7afL94QTtzpcZ0fNFEH5O76MTwdL2oKmdVa/WjEhlb6ckDyqUgYN4MRgeKtTsh6kDSWX9nloC7Um8sNzHClQ8JT6fyUiuRLi1KDt161ow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749028648; c=relaxed/simple; bh=jaWYOlqJPw2BZWOHnti8Fj3X0sSIXuo768Cq7f6xCrI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Wge6iA0u29tNbrQN/NqK+OpioG7s4U39m21E45u8SO8efcUKd6kC6v6C51ZYXhw+2hkqzFiabM6kTEuFu0q9VvTqQI35XSaeUsXtYlogbxbO22ym7HXi+fQlo0Dz1ehs1KHIM1PCzrmV/0/a+EDC3SjvFU/H4NynkOFCvTfyTxU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infineon.com; spf=pass smtp.mailfrom=infineon.com; dkim=pass (1024-bit key) header.d=infineon.com header.i=@infineon.com header.b=HaFFLU9F; arc=none smtp.client-ip=217.10.52.160 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infineon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infineon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=infineon.com header.i=@infineon.com header.b="HaFFLU9F" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=infineon.com; i=@infineon.com; q=dns/txt; s=IFXMAIL; t=1749028647; x=1780564647; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jaWYOlqJPw2BZWOHnti8Fj3X0sSIXuo768Cq7f6xCrI=; b=HaFFLU9Fgzq4eeko5/aUxwTNkcb24FidVc5LKRfPajVDZYSy6i1gzi+h q7G4GJUCIE1WJxzeOQz0+zEvPq07QIYaybqORvDvxw6LZwggetyl2HMNE I3NXBW7dDwGlnWyCjTk2L01INOWWSNWRB99YCCoE2chkevNXzeJKdPFDn U=; X-CSE-ConnectionGUID: FHBpNLgtSuu/QKtHueU+qA== X-CSE-MsgGUID: UPPv2IZZQ8+KFYIZoDyDMw== X-IronPort-AV: E=McAfee;i="6700,10204,11453"; a="87259717" X-IronPort-AV: E=Sophos;i="6.16,208,1744063200"; d="scan'208";a="87259717" Received: from unknown (HELO MUCSE819.infineon.com) ([172.23.29.45]) by smtp14.infineon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2025 11:17:24 +0200 Received: from MUCSE835.infineon.com (172.23.7.107) by MUCSE819.infineon.com (172.23.29.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 4 Jun 2025 11:17:24 +0200 Received: from iot-wlan-dev-u03.aus.cypress.com (10.161.6.196) by MUCSE835.infineon.com (172.23.7.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 4 Jun 2025 11:17:22 +0200 From: Ian Lin To: , CC: , , , , , , Subject: [PATCH wireless-next 1/4] wifi: brcmfmac: don't allow arp/nd offload to be enabled if ap mode exists Date: Wed, 4 Jun 2025 04:16:26 -0500 Message-ID: <20250604091629.3943-2-ian.lin@infineon.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20250604091629.3943-1-ian.lin@infineon.com> References: <20250604091629.3943-1-ian.lin@infineon.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: MUCSE802.infineon.com (172.23.29.28) To MUCSE835.infineon.com (172.23.7.107) From: Ting-Ying Li Add a check to determine whether arp/nd offload enabling request is allowed. If there is any interface acts as ap mode and is operating, reject the request of arp offload enabling from cfg80211. Signed-off-by: Ting-Ying Li Signed-off-by: Ian Lin --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 17 ++++++++++++++++- .../broadcom/brcm80211/brcmfmac/cfg80211.h | 1 + .../wireless/broadcom/brcm80211/brcmfmac/core.c | 5 +++++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index dc2383faddd1..2e06fd0dbb2a 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -1043,6 +1043,21 @@ void brcmf_set_mpc(struct brcmf_if *ifp, int mpc) } } +bool brcmf_is_apmode_operating(struct wiphy *wiphy) +{ + struct brcmf_cfg80211_info *cfg = wiphy_to_cfg(wiphy); + struct brcmf_cfg80211_vif *vif; + bool ret = false; + + list_for_each_entry(vif, &cfg->vif_list, list) { + if (brcmf_is_apmode(vif) && + test_bit(BRCMF_VIF_STATUS_AP_CREATED, &vif->sme_state)) + ret = true; + } + + return ret; +} + static void brcmf_scan_params_v2_to_v1(struct brcmf_scan_params_v2_le *params_v2_le, struct brcmf_scan_params_le *params_le) { @@ -5416,8 +5431,8 @@ static int brcmf_cfg80211_stop_ap(struct wiphy *wiphy, struct net_device *ndev, bphy_err(drvr, "bss_enable config failed %d\n", err); } brcmf_set_mpc(ifp, 1); - brcmf_configure_arp_nd_offload(ifp, true); clear_bit(BRCMF_VIF_STATUS_AP_CREATED, &ifp->vif->sme_state); + brcmf_configure_arp_nd_offload(ifp, true); brcmf_net_setcarrier(ifp, false); return err; diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h index b83485ec7b87..273c80f2d483 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h @@ -487,6 +487,7 @@ s32 brcmf_notify_escan_complete(struct brcmf_cfg80211_info *cfg, struct brcmf_if *ifp, bool aborted, bool fw_abort); void brcmf_set_mpc(struct brcmf_if *ndev, int mpc); +bool brcmf_is_apmode_operating(struct wiphy *wiphy); void brcmf_abort_scanning(struct brcmf_cfg80211_info *cfg); void brcmf_cfg80211_free_netdev(struct net_device *ndev); diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index 04f41c09deca..862a0336a0b5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -98,6 +98,11 @@ void brcmf_configure_arp_nd_offload(struct brcmf_if *ifp, bool enable) s32 err; u32 mode; + if (enable && brcmf_is_apmode_operating(ifp->drvr->wiphy)) { + brcmf_dbg(TRACE, "Skip ARP/ND offload enable when soft AP is running\n"); + return; + } + if (enable) mode = BRCMF_ARP_OL_AGENT | BRCMF_ARP_OL_PEER_AUTO_REPLY; else From patchwork Wed Jun 4 09:16:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lin Ian \(CSS ICW ENG WFS SW WFSW 1\)" X-Patchwork-Id: 894169 Received: from smtp9.infineon.com (smtp9.infineon.com [217.10.52.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 606D5223DCF for ; Wed, 4 Jun 2025 09:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.10.52.204 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749028650; cv=none; b=dd2R7PDgl4cozK35W0Ca40DIwQES7q7qKpb4rFqkwEy7rhOziT3kQOr02CbA4Gx2069gHM6AqkcOGjoslB863rQSHRdip/n+okpseL6J7oNEKFNM6Zk31XgWavMY5+M3C85Cp9WTLWqOm31Ei+qr4km5TzXqMX/001YpGnV8PqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749028650; c=relaxed/simple; bh=CyqMLRryBn9l9XIH2T7ru7R5sDOJbbCDv+b4CO0v3NQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=M66cDMlo2PxLJlXy+Qoib4WFV8roTFFNWx4A/KY5qj+yG0+TRT9ycmYq1r59DaX1jUfeW0vOY76aV9izLeZa01Vjubd+znndCOT1CYEMGZfBY91llwBxAag94F3v0zybIv7kFoIqjIHAHFgM97Z3T3WZt03om1rbl7bilGukEqQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infineon.com; spf=pass smtp.mailfrom=infineon.com; dkim=pass (1024-bit key) header.d=infineon.com header.i=@infineon.com header.b=Lb5UNkV2; arc=none smtp.client-ip=217.10.52.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infineon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infineon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=infineon.com header.i=@infineon.com header.b="Lb5UNkV2" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=infineon.com; i=@infineon.com; q=dns/txt; s=IFXMAIL; t=1749028649; x=1780564649; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CyqMLRryBn9l9XIH2T7ru7R5sDOJbbCDv+b4CO0v3NQ=; b=Lb5UNkV2GHeU1kx/dGJ1Kr7jqDLygOr+QRlMIgUSPV1v+QR9PEDrxbK2 frbFHX7MAL+RrorXalUF+ILRLfWy4Z0GsayVvbTllWmVrj6C+lfANZM98 FCpV0ipXtVlZwwyYadV0KGhlM2Btzzc1On3D2QLKtxiFHYLM/ktpoK8MV 0=; X-CSE-ConnectionGUID: 4FI2pH4gRcigrLY/tUs9ow== X-CSE-MsgGUID: SSPwCDCATHW2wNFVhF6yzg== X-IronPort-AV: E=McAfee;i="6700,10204,11453"; a="53598474" X-IronPort-AV: E=Sophos;i="6.16,208,1744063200"; d="scan'208";a="53598474" Received: from unknown (HELO MUCSE814.infineon.com) ([172.23.29.40]) by smtp9.infineon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2025 11:17:27 +0200 Received: from MUCSE835.infineon.com (172.23.7.107) by MUCSE814.infineon.com (172.23.29.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 4 Jun 2025 11:17:26 +0200 Received: from iot-wlan-dev-u03.aus.cypress.com (10.161.6.196) by MUCSE835.infineon.com (172.23.7.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 4 Jun 2025 11:17:24 +0200 From: Ian Lin To: , CC: , , , , , , Subject: [PATCH wireless-next 2/4] wifi: brcmfmac: revise SoftAP channel setting Date: Wed, 4 Jun 2025 04:16:27 -0500 Message-ID: <20250604091629.3943-3-ian.lin@infineon.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20250604091629.3943-1-ian.lin@infineon.com> References: <20250604091629.3943-1-ian.lin@infineon.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: MUCSE802.infineon.com (172.23.29.28) To MUCSE835.infineon.com (172.23.7.107) From: Ting-Ying Li Fmac need to update "chanspec" iovar for each SoftAP creation because firmware will update the chanspec to current bsscfg for each bss. If it doesn't update then the wrong chanspec will be shown on the result of 'wl -i [interface] status' command. No need to handle channel resource reusing for mbss mode by the host driver, it should be covered by firmware. Signed-off-by: Ting-Ying Li Signed-off-by: Ian Lin --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index 2e06fd0dbb2a..820dc5fee730 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -5248,17 +5248,17 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev, err); goto exit; } - if (!mbss) { - /* Firmware 10.x requires setting channel after enabling - * AP and before bringing interface up. - */ - err = brcmf_fil_iovar_int_set(ifp, "chanspec", chanspec); - if (err < 0) { - bphy_err(drvr, "Set Channel failed: chspec=%d, %d\n", - chanspec, err); - goto exit; - } + + /* Firmware 10.x requires setting channel after enabling + * AP and before bringing interface up. + */ + err = brcmf_fil_iovar_int_set(ifp, "chanspec", chanspec); + if (err < 0) { + bphy_err(drvr, "Set Channel failed: chspec=%d, %d\n", + chanspec, err); + goto exit; } + err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_UP, 1); if (err < 0) { bphy_err(drvr, "BRCMF_C_UP error (%d)\n", err); From patchwork Wed Jun 4 09:16:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lin Ian \(CSS ICW ENG WFS SW WFSW 1\)" X-Patchwork-Id: 894413 Received: from smtp11.infineon.com (smtp11.infineon.com [217.10.52.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4B7D28C852 for ; Wed, 4 Jun 2025 09:17:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.10.52.105 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749028652; cv=none; b=Bo2q6dU0sdGI/Q9BrOZGk/KJijMhI5c7b3AjSN68LFSSxIskTI/cnNxCF3LGWsiI5mAecEZIKCqpsbzkYmBvBUoy7RVHng+4ka7JhligY7S0sVt7HY4yhVhr4omD0tfmZy8ikpb2KnAt6IgsURdB+gHCnHHPYjE+h+pwoRtO9s8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749028652; c=relaxed/simple; bh=LKNvXTo84MWzYran1behIq/Jj5ZiNQ9EmI8LiVEefZY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sFh5+AZ2ScH3X12v7CU95qvZDJjfIjP31pXANV7hpbh43mKgKl4z7NMTKEMweMcKK2ZO/aSSNSMXhYGQdqpsn7I+js8R094YkgP53r5CFJtt9kl60cw0WsP1qL3yumvj6AB1Iv9lQB78Qh/UIF81zEp9NdwRaPqi5mkIZdNvRnA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infineon.com; spf=pass smtp.mailfrom=infineon.com; dkim=pass (1024-bit key) header.d=infineon.com header.i=@infineon.com header.b=Qf45TxzD; arc=none smtp.client-ip=217.10.52.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infineon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infineon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=infineon.com header.i=@infineon.com header.b="Qf45TxzD" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=infineon.com; i=@infineon.com; q=dns/txt; s=IFXMAIL; t=1749028651; x=1780564651; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LKNvXTo84MWzYran1behIq/Jj5ZiNQ9EmI8LiVEefZY=; b=Qf45TxzDNWNroiyjZYDBNSRwWc/APh/nik1J/kFnIIIGKvUT6Cp4bAPa ZiP5gLT/OVlGsEkSOivSDUW+nfkljCGdLQutt2MyEUmBVoA1bAhc7TbVY +XWZEye2P5XroUk/k0Y43h3EgzdpZCSLJuH+V05Vd1w4cARO4vU7Zbdo/ w=; X-CSE-ConnectionGUID: Tz2lSurhQY+TpIxwdc1xbg== X-CSE-MsgGUID: pPEtBT14RVe5dC77V4KPNw== X-IronPort-AV: E=McAfee;i="6700,10204,11453"; a="97807167" X-IronPort-AV: E=Sophos;i="6.16,208,1744063200"; d="scan'208";a="97807167" Received: from unknown (HELO MUCSE812.infineon.com) ([172.23.29.38]) by smtp11.infineon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2025 11:17:29 +0200 Received: from MUCSE835.infineon.com (172.23.7.107) by MUCSE812.infineon.com (172.23.29.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 4 Jun 2025 11:17:28 +0200 Received: from iot-wlan-dev-u03.aus.cypress.com (10.161.6.196) by MUCSE835.infineon.com (172.23.7.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 4 Jun 2025 11:17:26 +0200 From: Ian Lin To: , CC: , , , , , , Subject: [PATCH wireless-next 3/4] wifi: brcmfmac: Improve the delay during scan Date: Wed, 4 Jun 2025 04:16:28 -0500 Message-ID: <20250604091629.3943-4-ian.lin@infineon.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20250604091629.3943-1-ian.lin@infineon.com> References: <20250604091629.3943-1-ian.lin@infineon.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: MUCSE802.infineon.com (172.23.29.28) To MUCSE835.infineon.com (172.23.7.107) From: Kurt Lee wpa_supplicant sends NL80211_CMD_GET_SURVEY command every time after normal scan, which causes brcmfmac surveying each channel again. Currently brcmfmac implments brcmf_cfg80211_dump_survey focusing on AP mode, thus this change will return the request other than AP mode. Signed-off-by: Kurt Lee Signed-off-by: Ian Lin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index 820dc5fee730..e23cd6fc0f56 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -8122,6 +8122,9 @@ brcmf_cfg80211_dump_survey(struct wiphy *wiphy, struct net_device *ndev, brcmf_dbg(TRACE, "Enter: channel idx=%d\n", idx); + if (!brcmf_is_apmode(ifp->vif)) + return -ENOENT; + /* Do not run survey when VIF in CONNECTING / CONNECTED states */ if ((test_bit(BRCMF_VIF_STATUS_CONNECTING, &ifp->vif->sme_state)) || (test_bit(BRCMF_VIF_STATUS_CONNECTED, &ifp->vif->sme_state))) { From patchwork Wed Jun 4 09:16:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lin Ian \(CSS ICW ENG WFS SW WFSW 1\)" X-Patchwork-Id: 894168 Received: from smtp2.infineon.com (smtp2.infineon.com [217.10.52.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F105C28C841 for ; Wed, 4 Jun 2025 09:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.10.52.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749028654; cv=none; b=pqPbR1NRG3Z2EperUE+Fxq9XbY81e+DK+BbNSmpRjIrmSw9Nv18k9J5RYEa+uqe6aWe5B2CGZHti3k82VKMpF0+40hMqTaE1bJy1EIgEWkau1z4vAInwA9EV/dTXS6BZnt4M6kZ3r6fciJPUaFMdxnKrWOsH7Y7/O05T1nmfr6A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749028654; c=relaxed/simple; bh=rJNLhXV7wx7obIrobisWX5noloSA1mSgI4AkwK9agsg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=K+e/EpieiNDqP9mTgIS+7FAp/2pwQjfVoekxrBcNrercODjj1VhDcCxSXBCvyRqlBOzhS8BEgNZchgbrTfq/FWDX7ikvzplp4qzJ72nBQVxhUn1OZpoGIjKd1Q6Tssu+228FjRxciv3HN89Apq1gzh9JO+fcclyv8zwqC1DnfbI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infineon.com; spf=pass smtp.mailfrom=infineon.com; dkim=pass (1024-bit key) header.d=infineon.com header.i=@infineon.com header.b=Q2QZOxge; arc=none smtp.client-ip=217.10.52.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infineon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infineon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=infineon.com header.i=@infineon.com header.b="Q2QZOxge" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=infineon.com; i=@infineon.com; q=dns/txt; s=IFXMAIL; t=1749028653; x=1780564653; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rJNLhXV7wx7obIrobisWX5noloSA1mSgI4AkwK9agsg=; b=Q2QZOxgeJj1Ezk7FgRnKqQyxQuaI/cm4jXtG+OgruJ/DAJUJu4wDgjEb liJexdX3pOTvbMJkq01ANiPSLJjEX9jboHE9p3vLinkRRbqocpeYNyMg7 t61AQ0+Iso6vwRXPDXCaw9217HJWVRX0jYCFmJeHtegyrl+CEB5hSwnPj k=; X-CSE-ConnectionGUID: wso5d8XsRY6jYeUpEAglPw== X-CSE-MsgGUID: URZCzFLASPqJHRtAQSRlhw== X-IronPort-AV: E=McAfee;i="6700,10204,11453"; a="113054892" X-IronPort-AV: E=Sophos;i="6.16,208,1744063200"; d="scan'208";a="113054892" Received: from unknown (HELO MUCSE805.infineon.com) ([172.23.29.31]) by smtp2.infineon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2025 11:17:31 +0200 Received: from MUCSE835.infineon.com (172.23.7.107) by MUCSE805.infineon.com (172.23.29.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 4 Jun 2025 11:17:30 +0200 Received: from iot-wlan-dev-u03.aus.cypress.com (10.161.6.196) by MUCSE835.infineon.com (172.23.7.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 4 Jun 2025 11:17:28 +0200 From: Ian Lin To: , CC: , , , , , , Subject: [PATCH wireless-next 4/4] wifi: brcmfmac: prevent disable controller in apmode stop Date: Wed, 4 Jun 2025 04:16:29 -0500 Message-ID: <20250604091629.3943-5-ian.lin@infineon.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20250604091629.3943-1-ian.lin@infineon.com> References: <20250604091629.3943-1-ian.lin@infineon.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: MUCSE802.infineon.com (172.23.29.28) To MUCSE835.infineon.com (172.23.7.107) From: Ian Lin Wpa_supplicant will firstly call scan before start apmode. In mbss case, controller will be disabled during stop apmode so next time it reports fail in starting apmpde. Fix by removing the disable operation. Signed-off-by: Ian Lin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index e23cd6fc0f56..b4078e74f135 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -5392,11 +5392,6 @@ static int brcmf_cfg80211_stop_ap(struct wiphy *wiphy, struct net_device *ndev, profile->use_fwauth = BIT(BRCMF_PROFILE_FWAUTH_NONE); } - if (ifp->vif->mbss) { - err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_DOWN, 1); - return err; - } - /* First BSS doesn't get a full reset */ if (ifp->bsscfgidx == 0) brcmf_fil_iovar_int_set(ifp, "closednet", 0);