From patchwork Fri Jun 6 11:01:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Shih X-Patchwork-Id: 895033 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86C8D2874FA; Fri, 6 Jun 2025 11:01:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749207697; cv=none; b=c7CySq59S5maeQSVmT0hknvp5yAviQ5JHQ0cHoHxrCvsEk/yfWpaCs+THSrlgypqMFCDyHx9P8jT0+7jWv1r9wnJtSlsSYsDkQWbTGROdt4WBoSE4f9xuf4TR79Sm1nvGEepwqtBLbBz2COJI9imEMDbcnCnj/hu1BEhI2f2CdY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749207697; c=relaxed/simple; bh=wtVaYsNiDStfS5WGdGavVgrVpCSRq0G8BYhQB1jRh4E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ESdu0WVIs0J3JxWHxm5IxNxlC6fRLwy94K2NslcPS+Q9lusa6llRgbNs3msfu6or5LJQpjytOdNCZX+cXCQCpO3rETPGrud/S/NosjGRGfpnOpANLuWEbOWJs1IAMOrCwk1sozNK2gETYPVY1OWSeLnn75b32trjbDLszGTT0Bs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SWm0teif; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SWm0teif" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2345c60507bso14177495ad.0; Fri, 06 Jun 2025 04:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749207695; x=1749812495; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FdNwp9She6Bw0OnAmilNUKwZ/IFh0LJcOPeTVLWMY00=; b=SWm0teif5kfPfiJ/+VV+nbWf7rZSrBlb8CtWmvQffkQ/5JIUqcdUDm1MKX9sFJUVkO 023YN6mAekEEAQdgsw+qoDqdDtGn5ige66Ktm323hGq5iT3r3g8eJS2ptUK0HuLed/75 mOXlfbLUy2Xa8aYwPsH6/UN9tjMw7SO7epnjtzEtbCpo+JhcheEYUZxZUIrbcromeitn GlBgbpfUrLoH5WU38U2y+sUTeTD9zYwjBH18mOghV8eBX7AbEsFZFGUo+gQP9Xzo7htx O7wtlYWMse2utE9SDQeiIv5NtGHIdI7LeAud2kJKhquk9RXb9InFNYiFazXaup+oIWwF coFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749207695; x=1749812495; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FdNwp9She6Bw0OnAmilNUKwZ/IFh0LJcOPeTVLWMY00=; b=TMxsJWwxfUQAJCilKP9h29URcmLZUEC9Y7dTMavSdJbKYp1HofYBExbrhf6NU2POyq HPpJdlXIT4B1ugc/BAY71dNT/RqMg5Ppeg+/7OTV5WALOEpzaSvXkFHYUO6ek7c+Jvkr e9q1I3cTjDFpgI8pCD7wI7gUMtxvKFFa/PQmspfZMpJ+FxQSO65vRxb6BCmDUsHphT1b kciSIcdcj6InHUpM+94RmiJ2hiyq3nkl+IzSYzszWnZmib4zVdTi57bKizjiYS5wv6mt KSnO9HD3inJELbPOtDRISPheJexO/pYXkh+FekaBNREYc4oyfrZxzYW0c9DTcqGKO0Q6 GNGw== X-Forwarded-Encrypted: i=1; AJvYcCXam+9OzjQ+HNDU0nlfWuz77Ojs4eF7jkfpmjZ1PR5haqZ38QxAM4proBDGPR9iwT9W6O6yChhMATh+j4k=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9GegErYIGoQJ2RzyajFF8nzGFY9Jdr3ygLhzoNsOBXHIcd0wd xm+VvkTTjzEyddiPQ/8WXEoNSfMzt1hFqnX+u2qxYzL2F5YoB9/eidzx X-Gm-Gg: ASbGncspi2ksZzT83BE+ouGIxoie3yh+gvi2tMr4kP4SuhKaTQteL2yEDjKPrmK1Bx2 1OJbXCsiZbKTYQIJ25CwVTgRiJQq17eI26DxOTE87Comr++JL/KAo1/yeSYfLnEJ6hZIxnusM4U FBaS1SRyIAmYL2mC22DDrXE/8HkhCNrdk4Xri+oDkj2nJbE/n/O0njSoQpgAde2j+YP+6Mb4mPS 2X5QDrEz//2vZBAOY7TzKrGXgxbjyI+rSNVLRgjcNSJkPXWPDD/KPy3uHgHrRVabHPP6Sb39ynP kTjmDdIfajEAPzbBAn4UQiY2wY7I3yt8+rUV3MifjRwRv/D2cnIPuXozenk= X-Google-Smtp-Source: AGHT+IH7IVs99gQj/i4GTnZdOMV0vK5KnUZifwyIB+LbN+eYfmSwFI3jY/mHycYlDB+MrahI/y0h2w== X-Received: by 2002:a17:902:ce0f:b0:235:880:cf8a with SMTP id d9443c01a7336-23601d04110mr48586745ad.15.1749207694597; Fri, 06 Jun 2025 04:01:34 -0700 (PDT) Received: from victorshih.. ([2402:7500:477:464b:b7fc:d546:e798:4fbc]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23603406aa9sm10095565ad.188.2025.06.06.04.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 04:01:33 -0700 (PDT) From: Victor Shih To: ulf.hansson@linaro.org, adrian.hunter@intel.com Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, benchuanggli@gmail.com, ben.chuang@genesyslogic.com.tw, HL.Liu@genesyslogic.com.tw, Greg.tu@genesyslogic.com.tw, Victor Shih , Victor Shih Subject: [PATCH V3 1/3] mmc: core: Adjust some error messages for SD UHS-II cards Date: Fri, 6 Jun 2025 19:01:19 +0800 Message-ID: <20250606110121.96314-2-victorshihgli@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250606110121.96314-1-victorshihgli@gmail.com> References: <20250606110121.96314-1-victorshihgli@gmail.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Victor Shih Adjust some error messages to debug mode to avoid causing misunderstanding it is an error. Signed-off-by: Victor Shih Acked-by: Adrian Hunter --- drivers/mmc/core/sd_uhs2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/core/sd_uhs2.c b/drivers/mmc/core/sd_uhs2.c index 1c31d0dfa961..de17d1611290 100644 --- a/drivers/mmc/core/sd_uhs2.c +++ b/drivers/mmc/core/sd_uhs2.c @@ -91,8 +91,8 @@ static int sd_uhs2_phy_init(struct mmc_host *host) err = host->ops->uhs2_control(host, UHS2_PHY_INIT); if (err) { - pr_err("%s: failed to initial phy for UHS-II!\n", - mmc_hostname(host)); + pr_debug("%s: failed to initial phy for UHS-II!\n", + mmc_hostname(host)); } return err; From patchwork Fri Jun 6 11:01:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Shih X-Patchwork-Id: 894632 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 876932882C2; Fri, 6 Jun 2025 11:01:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749207700; cv=none; b=AUHyUzpxR/ZDTBAGuP6AtGAYKsu+i5DECNifXywVhLqC13mlQPMfVTNOSJMMNqOCRkuWh5mdAiz2QE0NZFJxQtlMyMHjsmshONd+EbDUkjx15Gf3jUyymX6RX/BFqu5pBx33EuoyPUbsLW6flfuUmiZJYsFrbsyeyGDvSp6ndxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749207700; c=relaxed/simple; bh=KHL+vq1ykP4Zr71+2wspAda7WJt5Gxkzpx2CSZ9kO9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qohQzrYznpKB87cwS/xNOsjylNa9v6yjvsUZL3UVH3nyRnP/umX1pK9x8Pk2iMRw/G1fR1/AYtrVdgAl9lGqtek/uHHCOGbsESd9QHuGYgvJnp3Np2PLc8UUikw662EQ0vlCzrclOMvc+eYkoXQt6d9OirB3dXa90adGyWZ3BlE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HsDNoJLw; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HsDNoJLw" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-b2c41acd479so1204044a12.2; Fri, 06 Jun 2025 04:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749207699; x=1749812499; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZWmLMoecq6/e0cg6wm8bQxLR4skzTvI3htWCIwVFePU=; b=HsDNoJLww2ivpKAAa+btsAnHF9UjnL7riqYVvUJ0iPQF+6wsI55nZ0/I7BgWmKfzeM 0r3K731cs8nOQvunheSQi09FrAfRzNSzxeAtvv/clkHbsFXBzlR/tQsSAS9+NZNdsIVK CUfNV6n0ttiMwh5yO+jMjEhM4frruNVBMWJnc3OJI5RljMfCsYMXtVBfwroPeEBACF11 539S/0J4Ov4cpcCbIq57kO//5RxiEB9a9xFO8s4k4wNCrkFyRIipnQ9Dh+Jq+e4ccsZo wMohAK3uBvYo7vYG4TuCc+4oS42BsNkGGdDIw55uNq3mHYjAdGrEXnxvi5iEA5XRM/Pf b0sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749207699; x=1749812499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZWmLMoecq6/e0cg6wm8bQxLR4skzTvI3htWCIwVFePU=; b=BVgVZ3hX7nAKLwpvd2nlOrFlmKVO6U/66C46oi9GRmxCUQRCYhI27xXOXAFckq7PSV VOBn9cuWnBzTw1VX58YArBsp3X5XBDGnIFDuuDxuZ8aaPMcTnCB7QCphVJRMEowhhlaA T7RhxLbku5IghTzGvRlp8wLIgQNA3soHhf8PJuUjaJ+3gTwegVkncypMI2vAhFffqbCY hwOQ36VzmKOsJJ4LK+20r4of9EUe4sxEaH+/p+/D+gP7kkx8Mozj/j6SUhHulXaXZkC2 9LYLI54ABCGFP2Reqy2YQH3/y+TpkeI0OZ6Zq3N+9G5BQQP2RJES4u9M1pyAmVURFG33 B2VQ== X-Forwarded-Encrypted: i=1; AJvYcCWvDOMdknXSkaFNmn5JfBXH50Gbxb4pwnnpbxt6h18gfrZo9bbT52yXMF0cIa90vY9RokOKqPNgcqkvHGw=@vger.kernel.org X-Gm-Message-State: AOJu0YxIV6VNg08p0pcXr0f6FUUBd5QMssIWFvuPekIC8r/60VfPShlY O/YJa5j6aaImM8rd8UsAE55Hop9JpZt3+0i10cwuQoD/Ahz4GeuLn6Rt X-Gm-Gg: ASbGncuCIM822lX1jFT8bq+eZuVIPvWFfIJuad9yxHEwuOdG1JBPpymCHAtYYhn3TGd FlqlJoB+8asQNHo1ylmGD+ujbTyFWFPYMNoh/Te8cX0gXJczFRSA5ncum6h6vNxJtEL4V1VrVjH GQiNdgAgMQfxflB0Ae2g0nKDj4Icz5qF+O8sTy+oZNKmvcpvcGk0W4tdYsByYnOdiwOJDoKx3Ip frTRgaR/um4yTgUuz3u9ERKfZfRIpXEbVqD4BnH5vHsmVzR92TLqrU3z85RUF6miKbTTEmJhW8e XVahSopyekLwBv7CsGgn9n5SkkXMk/e2v2dWitLrklVpIhOJ6optb/DCMT4= X-Google-Smtp-Source: AGHT+IFAUQhEkDlOyYk2aG68k7uex0e+ILlWBeTf0nUkHdxjc8cUiLrqvftQtwJvjxdf49NnYncSHw== X-Received: by 2002:a17:90b:53c4:b0:313:1a8c:c2d3 with SMTP id 98e67ed59e1d1-3134767ec1emr3814127a91.22.1749207698474; Fri, 06 Jun 2025 04:01:38 -0700 (PDT) Received: from victorshih.. ([2402:7500:477:464b:b7fc:d546:e798:4fbc]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23603406aa9sm10095565ad.188.2025.06.06.04.01.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 04:01:38 -0700 (PDT) From: Victor Shih To: ulf.hansson@linaro.org, adrian.hunter@intel.com Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, benchuanggli@gmail.com, ben.chuang@genesyslogic.com.tw, HL.Liu@genesyslogic.com.tw, Greg.tu@genesyslogic.com.tw, Victor Shih , Victor Shih Subject: [PATCH V3 2/3] mmc: sdhci: Add a helper function for dump register in dynamic debug mode Date: Fri, 6 Jun 2025 19:01:20 +0800 Message-ID: <20250606110121.96314-3-victorshihgli@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250606110121.96314-1-victorshihgli@gmail.com> References: <20250606110121.96314-1-victorshihgli@gmail.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Victor Shih Add a helper function for dump register in dynamic debug mode. Signed-off-by: Victor Shih Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index f9d65dd0f2b2..70ada1857a4c 100644 --- a/drivers/mmc/host/sdhci.h +++ b/drivers/mmc/host/sdhci.h @@ -900,4 +900,20 @@ void sdhci_switch_external_dma(struct sdhci_host *host, bool en); void sdhci_set_data_timeout_irq(struct sdhci_host *host, bool enable); void __sdhci_set_timeout(struct sdhci_host *host, struct mmc_command *cmd); +#if defined(CONFIG_DYNAMIC_DEBUG) || \ + (defined(CONFIG_DYNAMIC_DEBUG_CORE) && defined(DYNAMIC_DEBUG_MODULE)) +#define SDHCI_DBG_ANYWAY 0 +#elif defined(DEBUG) +#define SDHCI_DBG_ANYWAY 1 +#else +#define SDHCI_DBG_ANYWAY 0 +#endif + +#define sdhci_dbg_dumpregs(host, fmt) \ +do { \ + DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \ + if (DYNAMIC_DEBUG_BRANCH(descriptor) || SDHCI_DBG_ANYWAY) \ + sdhci_dumpregs(host); \ +} while (0) + #endif /* __SDHCI_HW_H */ From patchwork Fri Jun 6 11:01:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Shih X-Patchwork-Id: 895032 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FF5E28688A; Fri, 6 Jun 2025 11:01:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749207705; cv=none; b=T3aey5k9fOJKXD5Cq1LlFfGISSlql3ZBhvKsWYFEMMogXvq2N70rK1uxsc5CKfHvEo3FtEP1MUj0a+ZrAH2PKOfAqcaW428DTT4GEdG2jdT8iCZBQs+r4q9DL/V51jNqRb19sIrB11QeYthZIf35iEYwYP7FnPvwocnmKpchssw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749207705; c=relaxed/simple; bh=rlyKOSjopnnYv5rZ9EMYIXC37icsOlBrqPJsm9ycYS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jkWitpMWulO56+Igx9ncgGZkc5nGNDib4LYE/A6Ohz7XPHNH34USGQ+EXwcS5W9B7S/wpz/GSSSDMXsMEEpxA9X4BxNB1SwnV67A+53oWCbQf+mDgD2oqZSVKGtF4Y9zD/riYfktxDjORsihW9iBO2/1YaiPZt+k9UW1tCVZmtQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MBt4lY79; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MBt4lY79" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-b2c41acd479so1204083a12.2; Fri, 06 Jun 2025 04:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749207702; x=1749812502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BPhR9yX4mSs2h2RIwQ6dpRH1kL3oB4FnAXKq6tC6nJc=; b=MBt4lY79FONx0yOcHFyRldG5J9uqNQvDGiYDF2mzBq/eajtZ9ipSCEshd9dsPCvatS 70u+DGhfj0NglY2ZY8BE4jNLweNbMg6Ri18+nMt0bzTXispxRCcNRo0UL09F3n4DczJm gtztog+cGZsJVO0Kbgdm2AGWF8PidtEYwerpD4Vu6RGypaHTeVxTEICPmOfC4zQrjOvz wIkfbNV7j+s8Wgzgk/ij1ub9ajDThQmjEOmht304KngtyRhJ5mbNFyrGoAt3d5iuzhPb B9cLfRdgtyCShxsXZGEHuY//XPYU5BW4rYf7yyzBL9HDt5dTc1ouLRB39RzX4DWLUvUG SBuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749207702; x=1749812502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BPhR9yX4mSs2h2RIwQ6dpRH1kL3oB4FnAXKq6tC6nJc=; b=NS6qs+Ck4MoPhnYkBKup6zJvsWUA8ij50VIbHZTQVZuVHO9qnV+SEnBPUpD9psU/nn mYEcpExXTfTZj5ZuKDJ6HXwYWwIy00ugPwHmx1GbxfyGze2iu1oLVCOAJI5Ps2cRqVfL mwmXsNi2J/QxOyYru2QvwSHXOudoijGfm+dFbp+xopdRSeyoNw3DQNbuEg8ZeHf9enmN MQ4yYBRZRQYN3hl4Pzt4IAtSmRPvxLln9IJewZFs2CG+ugNg0KLHk7j2KImqZF9CL8nS m5lR76bBCvAom0Wwl14Uie6GniA27cmSahaZ1TxFiPHqIA3/8LmyG/3fdvq3UN1kCb2w GmDw== X-Forwarded-Encrypted: i=1; AJvYcCUmawDoPj1TKocvMDZ9Ae5pOHmTIOtyJAbEZjF63wuSMYlTbgHse8KSn2tvTclHI/qcUW5R1c8FTqKvWrA=@vger.kernel.org X-Gm-Message-State: AOJu0YyyQdg9OprWqyxJ403FS6aTLFB4BCKAQzSl9fjNRuRUzzCRjyRT qM8ZmusSHg0QEWRbldjg1atR6ph64qD+MTF6Z87qo0C6Tuc3k3L+gGN9 X-Gm-Gg: ASbGnct7muaypLgvoi6cd27gGFgFVATVuvgnNshsTzbUQWhHgl16WkdVUxLaVVHLo9+ K8k1U+SvDhk5t0DD4NleOcOxsY6zfi+KoaFz7J6oq6F0F7R8gj6TsMFcWyUkEHpNXfG/GYeq1xe PrsgJl8V4By+zNR1xvshym/29FsfAZNGQVGPcZ5vbKB6RzwlPx/PkeMVZ2VQXGznDx2QHBvsg6x 03dfW5JSu2y1oIqjvsnt+I9bm26cugsx2dVt+vV7hXhMeLnzDrK2JFkL9ql+Rsxb9/BoMIu9GM7 fAcJhnAfhmiM2qmYFNTzke9BpvfTCEcv9YoQOsC651SR+sHdtxye+sYBNWA= X-Google-Smtp-Source: AGHT+IGXb/wYozRMBi61TbjaFbU/cASFsQ/CJ7ePhkkDeM21EM8iCfMvcIs9pazkFUy5Rr77tzVAPA== X-Received: by 2002:a17:90b:3e4b:b0:311:e731:523a with SMTP id 98e67ed59e1d1-313472e628dmr4656133a91.11.1749207702384; Fri, 06 Jun 2025 04:01:42 -0700 (PDT) Received: from victorshih.. ([2402:7500:477:464b:b7fc:d546:e798:4fbc]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23603406aa9sm10095565ad.188.2025.06.06.04.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 04:01:41 -0700 (PDT) From: Victor Shih To: ulf.hansson@linaro.org, adrian.hunter@intel.com Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, benchuanggli@gmail.com, ben.chuang@genesyslogic.com.tw, HL.Liu@genesyslogic.com.tw, Greg.tu@genesyslogic.com.tw, Victor Shih , Victor Shih Subject: [PATCH V3 3/3] mmc: sdhci-uhs2: Adjust some error messages and register dump for SD UHS-II card Date: Fri, 6 Jun 2025 19:01:21 +0800 Message-ID: <20250606110121.96314-4-victorshihgli@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250606110121.96314-1-victorshihgli@gmail.com> References: <20250606110121.96314-1-victorshihgli@gmail.com> Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Victor Shih Adjust some error messages to debug mode and register dump to dynamic debug mode to avoid causing misunderstanding it is an error. Signed-off-by: Victor Shih Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-uhs2.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/host/sdhci-uhs2.c b/drivers/mmc/host/sdhci-uhs2.c index c53b64d50c0d..0efeb9d0c376 100644 --- a/drivers/mmc/host/sdhci-uhs2.c +++ b/drivers/mmc/host/sdhci-uhs2.c @@ -99,8 +99,8 @@ void sdhci_uhs2_reset(struct sdhci_host *host, u16 mask) /* hw clears the bit when it's done */ if (read_poll_timeout_atomic(sdhci_readw, val, !(val & mask), 10, UHS2_RESET_TIMEOUT_100MS, true, host, SDHCI_UHS2_SW_RESET)) { - pr_warn("%s: %s: Reset 0x%x never completed. %s: clean reset bit.\n", __func__, - mmc_hostname(host->mmc), (int)mask, mmc_hostname(host->mmc)); + pr_debug("%s: %s: Reset 0x%x never completed. %s: clean reset bit.\n", __func__, + mmc_hostname(host->mmc), (int)mask, mmc_hostname(host->mmc)); sdhci_writeb(host, 0, SDHCI_UHS2_SW_RESET); return; } @@ -335,8 +335,8 @@ static int sdhci_uhs2_interface_detect(struct sdhci_host *host) if (read_poll_timeout(sdhci_readl, val, (val & SDHCI_UHS2_IF_DETECT), 100, UHS2_INTERFACE_DETECT_TIMEOUT_100MS, true, host, SDHCI_PRESENT_STATE)) { - pr_warn("%s: not detect UHS2 interface in 100ms.\n", mmc_hostname(host->mmc)); - sdhci_dumpregs(host); + pr_debug("%s: not detect UHS2 interface in 100ms.\n", mmc_hostname(host->mmc)); + sdhci_dbg_dumpregs(host, "UHS2 interface detect timeout in 100ms"); return -EIO; } @@ -345,8 +345,8 @@ static int sdhci_uhs2_interface_detect(struct sdhci_host *host) if (read_poll_timeout(sdhci_readl, val, (val & SDHCI_UHS2_LANE_SYNC), 100, UHS2_LANE_SYNC_TIMEOUT_150MS, true, host, SDHCI_PRESENT_STATE)) { - pr_warn("%s: UHS2 Lane sync fail in 150ms.\n", mmc_hostname(host->mmc)); - sdhci_dumpregs(host); + pr_debug("%s: UHS2 Lane sync fail in 150ms.\n", mmc_hostname(host->mmc)); + sdhci_dbg_dumpregs(host, "UHS2 Lane sync fail in 150ms"); return -EIO; } @@ -417,12 +417,12 @@ static int sdhci_uhs2_do_detect_init(struct mmc_host *mmc) host->ops->uhs2_pre_detect_init(host); if (sdhci_uhs2_interface_detect(host)) { - pr_warn("%s: cannot detect UHS2 interface.\n", mmc_hostname(host->mmc)); + pr_debug("%s: cannot detect UHS2 interface.\n", mmc_hostname(host->mmc)); return -EIO; } if (sdhci_uhs2_init(host)) { - pr_warn("%s: UHS2 init fail.\n", mmc_hostname(host->mmc)); + pr_debug("%s: UHS2 init fail.\n", mmc_hostname(host->mmc)); return -EIO; } @@ -504,8 +504,8 @@ static int sdhci_uhs2_check_dormant(struct sdhci_host *host) if (read_poll_timeout(sdhci_readl, val, (val & SDHCI_UHS2_IN_DORMANT_STATE), 100, UHS2_CHECK_DORMANT_TIMEOUT_100MS, true, host, SDHCI_PRESENT_STATE)) { - pr_warn("%s: UHS2 IN_DORMANT fail in 100ms.\n", mmc_hostname(host->mmc)); - sdhci_dumpregs(host); + pr_debug("%s: UHS2 IN_DORMANT fail in 100ms.\n", mmc_hostname(host->mmc)); + sdhci_dbg_dumpregs(host, "UHS2 IN_DORMANT fail in 100ms"); return -EIO; } return 0;