From patchwork Sat Jun 7 02:53:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 894900 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2762D259C80 for ; Sat, 7 Jun 2025 02:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264847; cv=none; b=qEDPyvcTnxSJrqbCyZOwYGoiOOwJmmRNJJ89sYotbjArYqnWHQ/eECyOb5HtdV4Vfl4pam2hQ5ggyB2rGmsW7/k+loZyjC2PFJlwjn3tCEHDZRqx00mzEG5W5qj6T2MQKVQY0rErkheCxYpJgAvC7TkQaYq1H9+XQnbb9FDibPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264847; c=relaxed/simple; bh=8VuAOHFeqx5UMsNpvlh7ZAQit2VLidP6PcKmMQI0hl0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WWFFDvLF2GWJkA22qxR5iaAtG4uoyTxZNbGZPUaDXqhYwc9Q4K8E6/AlO1XcUlRbR8RSxKJRsg2/dwsKMcJr5KMo7YLE8dOWpKnHykwZ2+oXmiFG1D+hqRr3yzAd112qLQdbsG7IgjfvtwR6CAaRoY99b44ELndC8Oydd0Q/qT8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=C/2/n8az; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="C/2/n8az" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-441d437cfaaso17148625e9.1 for ; Fri, 06 Jun 2025 19:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264843; x=1749869643; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=079G7lwbZSdbFJvvw8wIKqroIeNsEJYLRsyPP7yIsHs=; b=C/2/n8azwKyJCTLNIgy7LVyV3KtP358RJIYCZzmXVpd+zfxPgWb8+6uQX7Qm2NzQ4a xA/pXilYEqd8T7TsvpqjWF2z6ij7EnqW0GGqJkK9+aSHj+KAfQ97OnISMuDI2E6ktRh8 mjhnITT0yT4YGOM2BmqzGSHK5pViWU7zVRcMAUoIgj+33M6UPEJ9zuLAaH1043OA6jS9 b2lsjGmcFTUci5jWRBy2d4nt5YUVwXj3QIO/0OOx8ceOEACqJVe5JaaV95XSm3lSHKkU 2PhKtFjI0vvEUoAwwQ4QhnkNwuJVzmHewTQDFp4zDQsUbY9X+DQta4qdKYRtuW607yhn N0Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264843; x=1749869643; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=079G7lwbZSdbFJvvw8wIKqroIeNsEJYLRsyPP7yIsHs=; b=X0VFcKPORoJp7CXkeRZrnCZnN83x8IUHncZJeZ/LAzfkwZJEOIdFCfx9nAix9sf8Tt DdEo4WLjin6h73I7dwoTZB0Skm73IRRk4Xv39Nb6iC87c1atFafTXRFemTrNNUM22fhr Tw7uv9y/Ac88RS4rR+8iO+0PboqFz/bj7UvXDFM/Go8892M3aOA4nIzvJLFhI4k8tMp9 DubXvUvYTBUCDPTHI+rFo1ulAY87MtGWIK9Y+4thX0a7g4BEENp9VGW8AOUIAxV4KkmB O5yfGQ8l2qzG8LvyIS6Gxteyvnr6xsDsDaYG9S4XUd2A6s7iK74G3qWxohdv0wCIYJj9 Lw6g== X-Forwarded-Encrypted: i=1; AJvYcCWj990o+Q1ikK9nOEpX18pG3RAarFi254VEKGp2pFRGMVZrPGlKjDqPxqx8Utie/PCIHWhov5zngcrK/h8=@vger.kernel.org X-Gm-Message-State: AOJu0YwNuwWt0Fpv31gWmeBWRF2kACjyLs7OBtGMNnyLEdYGAr+qlD8R +IsFRFdi0w2vgN3vfReiAas0ILQAMc6af8l3Q84jL8iShWKtf2qoOBKLqV6yf1Sob8c= X-Gm-Gg: ASbGncu8YSLmJsGtW+Hvef+NDkqBYvLMXlzHFx6XBVLPA374/A74GX5bWyW3EjK7Kkb RZykvMBhU+1gWfiqYXoHbcg0+ZLGkF351gV5TsFNEigkv4dw7iON/dxgD0IAQHKH3T7ESpdUPn6 9FLB0+PXoh+USekwWRtV2ByEaR+q+oa1IbxP3yvCgFt3W/BEvb9wJ9YEjcv7RCcvennvMve+4IQ BroyBBNabvawx8WKBLceHSSvRmoQ36s2gMHmZ7SBH3bNkGPvfGRwHGYycnjJA1rxlkTF+m2OVpn M4w54AEESMhCUDDnozjbUOdFLWh7S+74x6Ns6JwhcgXN8yOLBRboK0mvVKo= X-Google-Smtp-Source: AGHT+IEFMaOycz8paZH8Dwc7eB8/xeQCEwaltIN87YJjZdoV9BEkV0ZK9L7/PCQxBolImcH3wDz9CQ== X-Received: by 2002:a05:600c:8b08:b0:440:9b1a:cd78 with SMTP id 5b1f17b1804b1-4520141635bmr68757385e9.10.1749264843376; Fri, 06 Jun 2025 19:54:03 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:02 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:43 -0300 Subject: [PATCH 1/7] printk: Make console_{suspend,resume} handle CON_SUSPENDED Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250606-printk-cleanup-part2-v1-1-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=1467; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=8VuAOHFeqx5UMsNpvlh7ZAQit2VLidP6PcKmMQI0hl0=; b=T3wYMARjrMBrnSS0B53XQkjL8a0KEFURCPDHgsLUslXubhtqe5kSsdH3AVNiC4itsQepzSKEL bCiOgTyAtZ1BpRW6LdXAAFDz3h5mWwilxfoY0pptQZniRHvG6Kc9OCL X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= Since commit 9e70a5e109a4 ("printk: Add per-console suspended state") the CON_SUSPENDED flag was introced, and this flag was being checked on console_is_usable function, which returns false if the console is suspended. No functional changes. Signed-off-by: Marcos Paulo de Souza --- kernel/printk/printk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 1eea80d0648ed3583375cce3dfe60407894d659c..6d3cf488f4261a3dfd8809a5ab7164b218238c13 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3530,7 +3530,7 @@ void console_suspend(struct console *console) { __pr_flush(console, 1000, true); console_list_lock(); - console_srcu_write_flags(console, console->flags & ~CON_ENABLED); + console_srcu_write_flags(console, console->flags | CON_SUSPENDED); console_list_unlock(); /* @@ -3543,13 +3543,14 @@ void console_suspend(struct console *console) } EXPORT_SYMBOL(console_suspend); +/* Unset CON_SUSPENDED flag so the console can start printing again. */ void console_resume(struct console *console) { struct console_flush_type ft; bool is_nbcon; console_list_lock(); - console_srcu_write_flags(console, console->flags | CON_ENABLED); + console_srcu_write_flags(console, console->flags & ~CON_SUSPENDED); is_nbcon = console->flags & CON_NBCON; console_list_unlock(); From patchwork Sat Jun 7 02:53:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 894764 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 214232580F3 for ; Sat, 7 Jun 2025 02:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264854; cv=none; b=Q8TAnvRZKwJBTtExscA0AURIfteP0dndyjK0pXocPW38ebNn0hTi8ku8mAxiPCPzdUbBVLVIiU5j1P9GUnPlzBaASPRD9lkvXcd3Ex+vqXKe1fq0nsoh1ONosxtupi3j9ntceUpBKQFwLJKdUi0zBxHPK2vO5BwNTrBWicp69ik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264854; c=relaxed/simple; bh=1gk8U8A9Tp8dYd1sZPBSwCndj58kUaiYwQ9Z81qrFXo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LPA2oHQQJ3UM6EK1UofANycrkzgSTv9xhQ/rJa5lOiIQAhZ4N20BLRkM+otv9GVBVg+wyzza8/ZxAvCTzRSMJ5NO9uvlIiwT/tUacNmwFf3jB+9nExW7FWxiELSeMBIUpWyp+zcIyEN7VfWVcxhkyrhPGpKFdX7WsQ+4VXIiXuo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=HrzHXgEU; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="HrzHXgEU" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a4fea34e07so1570519f8f.1 for ; Fri, 06 Jun 2025 19:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264850; x=1749869650; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mX7Kpvr3d8Igbqg1Pi5Y0v9vR933SOfz9K97ZuvSH2o=; b=HrzHXgEU2yt4Pv3F4UD8ayJcVuMQmC4tISl5Fv8etbHyHuB/5ItjQMERxBhn/6CY7j 8WZN4g/L33MuU9C+KS9djt5EZaL01P5uPA7ASPMi8NiTiR5uzbytWF8/YK16XmwUnEV2 vNdJM4H9BLTNtXpZ4kIRHv2Th1eFTFP48VhzBjv0ySEozKeRDkoyvGK05Ct63iaaZ5NQ xkKBRm7DogdLmYnsAN2cd0E4zsdgwK3T+H1kTx/hg70DZc7sVyptPH/gMINzMkjsJsNX 35Dktci8FIt797QmIJDixyclxvHyAHXXc+eNaWfgLGw5tHfE56OJF+kw7HIt+aZWfCzc 1Eew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264850; x=1749869650; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mX7Kpvr3d8Igbqg1Pi5Y0v9vR933SOfz9K97ZuvSH2o=; b=wF1ExKDg4ltegF4fKiU7gOBP74MKZgNisxm8FXbqi0axYDyv6smFg2Oem5v2d7VUei fhvvWS9PMRaw9TCfouVZzY9xryNRgpRFrKxoeknU3s7raTv+SZuyr75714Hz/CleWCm0 5HMlkk58WJ4+lNrUVncHhAGznD4g2H9Ybqz3LJufQU1NQOiQJmb+WPmpYmKVfFdIc6ZB rZqsDt6O0pi02A3o6IFU1FxI08fa9k+2aLddrl694P17MEzQtFU6aJCekCLNDGMGPFiP 70znPSLFmhJjNhvgN2p11Ns/QyfGD2KvHiccvy6p2sWAsNYUJAJmsCy9dFNMMADB7ltT aG/Q== X-Forwarded-Encrypted: i=1; AJvYcCW8K20NrLQTDjytCvHxibPyvyUtqdTjA38ADIcgSgOKcb/YOvMZW2kBZtr51YN5moDTg2oUiSoHIbMLUiQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwH3BT0ZS8cWkeJ0zFX71b18T6lMRk7HRDVDWwYj71hq75+0iMX sEeH/Z7sYSqCZecX943XuD2SB2Bc9mW2zHsjH2iVNXQYK2kEHHTWwJ0cLILKAGI9A0w= X-Gm-Gg: ASbGncvu6+xhIsbqlSmvnuCV6oykHjkHtriZDrEecKKw7F7KTJIlE8YUoOVbPX4x3aH vdXENmT0GpikENrPcTaO0waDbpIOghnRGSvXCeWtJZfUnzP539ZMfHrZ+wDLZ1RbGm1C3eSVSGH jYJEds0pkVxsl4yAPUBXnPMSdZvvtqpyG7UVS7S/T9ixvENQA0i1GfrNGvEKFJBBwHTvYorNPLV yu/mRpZyMi0WqxltGcI9xU5Rmwfjt8VN2D6mKeItRoosLtqtEvbCz7Dpr5bRRgVs0jCxZCNwufA d7hlDoM+pVBRUivJg5F+XoguvxFNiVVr+JtybEQuYmX1AhPaavlt+nMYToNhAlgvTzDPDA== X-Google-Smtp-Source: AGHT+IHTkyMEV1xuLGonC7LtgR95ygfYX+hJ/eUxGPUUwzB9N83jBsaILJv4Qv7aHZROQ6yhMrIkHQ== X-Received: by 2002:a05:6000:188f:b0:3a4:f7dc:8a62 with SMTP id ffacd0b85a97d-3a531453ce7mr4234829f8f.0.1749264850369; Fri, 06 Jun 2025 19:54:10 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:09 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:44 -0300 Subject: [PATCH 2/7] printk: Use consoles_suspended flag when suspending/resuming all consoles Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250606-printk-cleanup-part2-v1-2-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=6242; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=1gk8U8A9Tp8dYd1sZPBSwCndj58kUaiYwQ9Z81qrFXo=; b=wvHq6UkjGv8LUZFpyT85kU4YEf7UvDpnRljGGj2r3IAnPOf6zps3o5cncvffNGYqnHhCIQTlN 5oFz1z/ahtlC5MWr0tDhAmLDLFHk/lTOiZuZ/P7/OtnsVSS6Dx7AMqH X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= Instead of update a per-console CON_SUSPENDED flag, use the console_list locks to protect this flag. This is also applied to console_is_usable functions, which now also checks if consoles_suspend is set. Signed-off-by: Marcos Paulo de Souza --- kernel/printk/internal.h | 7 ++++++- kernel/printk/nbcon.c | 8 ++++---- kernel/printk/printk.c | 23 ++++++++++------------- 3 files changed, 20 insertions(+), 18 deletions(-) diff --git a/kernel/printk/internal.h b/kernel/printk/internal.h index 48a24e7b309db20fdd7419f7aeda68ea7c79fd80..752101904f44b13059b6a922519d88e24c9f32c0 100644 --- a/kernel/printk/internal.h +++ b/kernel/printk/internal.h @@ -118,8 +118,12 @@ void nbcon_kthreads_wake(void); * which can also play a role in deciding if @con can be used to print * records. */ -static inline bool console_is_usable(struct console *con, short flags, bool use_atomic) +static inline bool console_is_usable(struct console *con, short flags, + bool use_atomic, bool consoles_suspended) { + if (consoles_suspended) + return false; + if (!(flags & CON_ENABLED)) return false; @@ -212,6 +216,7 @@ extern bool have_boot_console; extern bool have_nbcon_console; extern bool have_legacy_console; extern bool legacy_allow_panic_sync; +extern bool consoles_suspended; /** * struct console_flush_type - Define available console flush methods diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c index fd12efcc4aeda8883773d9807bc215f6e5cdf71a..72de12396e6f1bc5234acfdf6dcc393acf88d216 100644 --- a/kernel/printk/nbcon.c +++ b/kernel/printk/nbcon.c @@ -1147,7 +1147,7 @@ static bool nbcon_kthread_should_wakeup(struct console *con, struct nbcon_contex cookie = console_srcu_read_lock(); flags = console_srcu_read_flags(con); - if (console_is_usable(con, flags, false)) { + if (console_is_usable(con, flags, false, consoles_suspended)) { /* Bring the sequence in @ctxt up to date */ ctxt->seq = nbcon_seq_read(con); @@ -1206,7 +1206,7 @@ static int nbcon_kthread_func(void *__console) con_flags = console_srcu_read_flags(con); - if (console_is_usable(con, con_flags, false)) + if (console_is_usable(con, con_flags, false, consoles_suspended)) backlog = nbcon_emit_one(&wctxt, false); console_srcu_read_unlock(cookie); @@ -1584,7 +1584,7 @@ static void __nbcon_atomic_flush_pending(u64 stop_seq, bool allow_unsafe_takeove if (!(flags & CON_NBCON)) continue; - if (!console_is_usable(con, flags, true)) + if (!console_is_usable(con, flags, true, consoles_suspended)) continue; if (nbcon_seq_read(con) >= stop_seq) @@ -1795,7 +1795,7 @@ void nbcon_device_release(struct console *con) */ cookie = console_srcu_read_lock(); printk_get_console_flush_type(&ft); - if (console_is_usable(con, console_srcu_read_flags(con), true) && + if (console_is_usable(con, console_srcu_read_flags(con), true, consoles_suspended) && !ft.nbcon_offload && prb_read_valid(prb, nbcon_seq_read(con), NULL)) { /* diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 6d3cf488f4261a3dfd8809a5ab7164b218238c13..658acf92aa3d2a3d1e294b7e17e5ee96d8169afe 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -241,7 +241,7 @@ int devkmsg_sysctl_set_loglvl(const struct ctl_table *table, int write, /** * console_list_lock - Lock the console list * - * For console list or console->flags updates + * For console list, console->flags and consoles_suspended updates */ void console_list_lock(void) { @@ -383,6 +383,8 @@ bool other_cpu_in_panic(void) */ static int console_locked; +bool consoles_suspended; + /* * Array of consoles built from command line options (console=) */ @@ -2755,16 +2757,13 @@ MODULE_PARM_DESC(console_no_auto_verbose, "Disable console loglevel raise to hig */ void console_suspend_all(void) { - struct console *con; - if (!console_suspend_enabled) return; pr_info("Suspending console(s) (use no_console_suspend to debug)\n"); pr_flush(1000, true); console_list_lock(); - for_each_console(con) - console_srcu_write_flags(con, con->flags | CON_SUSPENDED); + consoles_suspended = true; console_list_unlock(); /* @@ -2779,14 +2778,12 @@ void console_suspend_all(void) void console_resume_all(void) { struct console_flush_type ft; - struct console *con; if (!console_suspend_enabled) return; console_list_lock(); - for_each_console(con) - console_srcu_write_flags(con, con->flags & ~CON_SUSPENDED); + consoles_suspended = false; console_list_unlock(); /* @@ -3214,7 +3211,7 @@ static bool console_flush_all(bool do_cond_resched, u64 *next_seq, bool *handove if ((flags & CON_NBCON) && (ft.nbcon_atomic || ft.nbcon_offload)) continue; - if (!console_is_usable(con, flags, !do_cond_resched)) + if (!console_is_usable(con, flags, !do_cond_resched, consoles_suspended)) continue; any_usable = true; @@ -3604,7 +3601,7 @@ static bool legacy_kthread_should_wakeup(void) if ((flags & CON_NBCON) && (ft.nbcon_atomic || ft.nbcon_offload)) continue; - if (!console_is_usable(con, flags, false)) + if (!console_is_usable(con, flags, false, consoles_suspended)) continue; if (flags & CON_NBCON) { @@ -4165,7 +4162,7 @@ static int unregister_console_locked(struct console *console) if (!console_is_registered_locked(console)) res = -ENODEV; - else if (console_is_usable(console, console->flags, true)) + else if (console_is_usable(console, console->flags, true, consoles_suspended)) __pr_flush(console, 1000, true); /* Disable it unconditionally */ @@ -4445,8 +4442,8 @@ static bool __pr_flush(struct console *con, int timeout_ms, bool reset_on_progre * that they make forward progress, so only increment * @diff for usable consoles. */ - if (!console_is_usable(c, flags, true) && - !console_is_usable(c, flags, false)) { + if (!console_is_usable(c, flags, true, consoles_suspended) && + !console_is_usable(c, flags, false, consoles_suspended)) { continue; } From patchwork Sat Jun 7 02:53:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 894899 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50319259CAF for ; Sat, 7 Jun 2025 02:54:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264859; cv=none; b=sFrxQN/bf4pVjhmrIa/Nuh0EnnIs4YmVkmLKpejmyo2PxfI+6VZ65ulkHoRE3qkH7fvvMYTWw+vqTpSuRAPAokgzSkbGAxTJcsYRUiQzWhsa72LS3ok+F7dOxP0DDFgMfQHMTmNtLpzbYdp75aGOiPy1wC4saPaWQ7mGYsoVHNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264859; c=relaxed/simple; bh=9kLsFVdVHZC1/N9aRdTRVFrJ42xC1c+3yhppaJpMsio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mFZ2TwnsZ12tvuLtUkYEr5uMdtz2OU0FUJoJf8KvmlVTc3Dax3LCkHqsM+GI6ZwgzXC5TwgPPu3ZJnmdb6ac5IdwdYMLRoHo8IKEnjpnMfhDORtcc/tdAbH7+SOCFiYCGMHXYnCXKTO9m4sDixMO7nCxhX0mqmz6cHHETQfQdiE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=VzmvQCE2; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="VzmvQCE2" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3a4f78ebec8so1615978f8f.0 for ; Fri, 06 Jun 2025 19:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264856; x=1749869656; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=blYZX9SALP3mKTtW5/j2PauIX7nPWCX8bAWtr1pxWl0=; b=VzmvQCE2peWp2L63NLmLKZMio1jAlZ9G1z+X6Ob6JvrVNq+IU9Cwqg2jED1w1JOvJB 2aqLmrdFnNG3+k66uqjzG3kqbCE0xCPSl8ajEWvMmrcNMpTLYLoAQhmNIKeNrQl7i0sC 0C54h12js4MVJElzAmPFzokO5BUswssMjV9Ih6n6ryBNVFMhocVlDa9ngIim5LAfatx2 oiw7KyBob3rFqQ0HBCH0hne2LwiEngoKJiKnjnHyPRVmUozo05Fnz20p8Eb1Qx4cw9BZ eE03TyKPnAIu2PMBxkFdufbHwlvRXFUrj4U+/gQtQ4zG5p6FILCNtjiATM6yR/F+5Jcj Tssw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264856; x=1749869656; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=blYZX9SALP3mKTtW5/j2PauIX7nPWCX8bAWtr1pxWl0=; b=l4S/FMjLZc229OQ9n/YY9PjGbWNGjACrqPHApgWuXNxntgMQBi17ekEPc1l5YY49As sVoN4+wTk94TW/1NWq29VCO+TbnwfARSXX/+XX+6LC5wZZVh39Dn4aSqMfDqdek9L/+h J3VmhLwWKQPVkemr20C138JCPX+EJNErB0eqepesVIA5JoJfS5zuMR5aHWwp/fz9lv8Q o9NQJc12CDt1xfiVX9ucpaO58yw78dTtV38TTJIPnJFXKXqc5gxCYwXpr1PVirF/hm9D ICqv33PT7Neotvjwwh+ONyJG//eRsjqL+gd8hM4OKqjxIy15CWnFHaGorYjDZQ6JFBRF 3cmQ== X-Forwarded-Encrypted: i=1; AJvYcCWE8uNQEwxUjRNVLeidOqO0ga+W/ZnPWJPhOzpTZr7Ac8Fur2oYAXB5JVHsT3YIUjdjMCDxN0OoztgGHWY=@vger.kernel.org X-Gm-Message-State: AOJu0YyoeLoGfZMbyIeiDWWSPRaqQqOrBWKMV1/3uj0O676rFRPW2KjJ Tq4x3ABFiwsS6o4AaL73ldASlFO5kF9Bln3xYwxGvgxBk9lrzleJHIccS2/P47VMGmo= X-Gm-Gg: ASbGncuuD6erlexAMzS8L8nDhwuONEtR/SsFB7MpJbVBWxm6HbEWQS930Ggg6iRCMJG Vo4kYHYEIh9qubg433bLzhQqSYsuceETOU0cNFcd7S8YhZFOXmrfCKVyYY10wpVWp7xYLg/TS5c zKOzfrjtRaChdMDMxe4NpgWgEMTNSycz2yAD64tpo89J3evDeKwtMHiHy35FEb3zMU1ZI+ANWq9 K4a3XrlElHjzVeos1xzBF5wvHjCoucxQoQRDe1DoG46pC8eSdKNLwJ3WQz1ld8O9NYCe8+A1GF2 ertpFIPz2jvD0oqp4KUoKRPGdnp9sEfuPdfXkHEhIDXkI0DM X-Google-Smtp-Source: AGHT+IHJ8LwIhaZRKIgzpbwHMvqzg7hdB3xBlwSSNm2xX/hnuxNAGse4PY3D/NNj8BudY/DwljmTRg== X-Received: by 2002:a5d:584c:0:b0:3a4:f024:6717 with SMTP id ffacd0b85a97d-3a531cec750mr4573998f8f.53.1749264855737; Fri, 06 Jun 2025 19:54:15 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:15 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:45 -0300 Subject: [PATCH 3/7] drivers: tty: Check CON_SUSPENDED instead of CON_ENABLED Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250606-printk-cleanup-part2-v1-3-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=849; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=9kLsFVdVHZC1/N9aRdTRVFrJ42xC1c+3yhppaJpMsio=; b=V7C9sb6tGmba5WbbzCCzgvis2cX9AK+EeOcGSXwItak8TkY+K+TnnSUrBrbGp4mQBLXbhFXa1 b5sMv8+wDMXDBlakfIx+M5fO23Lt7wo09cled0jB6DCtxtxEcDyqWTt X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= All consoles found on for_each_console are registered, meaning that all of them are CON_ENABLED. The code tries to find an active console, so check if the console is not suspended instead. Signed-off-by: Marcos Paulo de Souza --- drivers/tty/tty_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index ca9b7d7bad2b6807b29d3768bb655528ea162816..42f81573d8dfc668b38cd0b1c14962a7370cd954 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -3570,7 +3570,7 @@ static ssize_t show_cons_active(struct device *dev, continue; if (!(c->flags & CON_NBCON) && !c->write) continue; - if ((c->flags & CON_ENABLED) == 0) + if (c->flags & CON_SUSPENDED) continue; cs[i++] = c; if (i >= ARRAY_SIZE(cs)) From patchwork Sat Jun 7 02:53:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 894763 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 989BA259C92 for ; Sat, 7 Jun 2025 02:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264865; cv=none; b=Mn6lgHXqyXS1mGd7vCYPt2NcvD+viHWUwKRq+mWrnJR7ANHER5PdQppqOkE7RRZfk3ojY1NuV0zrFSt3pGTi/y4k+4TY5R2yqe5EzqPK00GxLj4of7pzOrVrUklPyt3a0CT/fMiEILD7Vny6A0Uu4FJpEI3P5x0L+DsuXS4ZNjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264865; c=relaxed/simple; bh=YnwRdm6I1xYkzMWD2CGBnm+ACwq/qI6QghdxR3iROfM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DRbOjC22x9t5Ea5ZbTLO0Jpf4AYiCOhKizNVO7Rmb+4SCWXGOgZ1J5TdFKnGZ1t5anfkgwNGUMix6Zo3diEMRxLP8VcC3I1JpS/fjnPMn8mzWjiL6DYoXGRGSpqIYSnSg0Sb8UGiCaCYd3HC+g8aOKmK4rzSHpdLYK1zqk/AjQ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Qf5MZWxJ; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Qf5MZWxJ" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3a5257748e1so1869969f8f.2 for ; Fri, 06 Jun 2025 19:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264862; x=1749869662; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yF8FpTtagcV7Kwh1mn8c83YxOz5Y2vKGfOZjELVv36A=; b=Qf5MZWxJexFH2124i8pTNAGf8WOmsLQuRV0YRcPwUcHKnWCVLR/Ov9pMgu/CvpeoT5 /Av2Tn+Y5CbkHdil95WFsrvifakKs/Itn6GibO8NVHc5ib5wLOmCi4ZnYQu8Gwcl92LC 3aDkIu5/5u9YJBMdj6pY6bp+5FV4VnqRHBBUJOQ+/bG7IPzmnXzuV+1FYOw1dVX+gxuW i0vxwVhdZutMruF10HHARyj3Az+HR/k9FmNzs5tcjmoulbT3ljSf0hhWKSBZPnK7Dlt2 ZkGfIaALuoqAS5MVLtZwazrM5of55OcOB0olfKhpnjE9mpyH/4AlDC1XGC9/ILGSGqul n9MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264862; x=1749869662; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yF8FpTtagcV7Kwh1mn8c83YxOz5Y2vKGfOZjELVv36A=; b=KDoip4FeN1SIGuAvyCZ33p+VKq61gowXngGGWl6dYK6YRtfmwVCX4n/eUp8rGlcdMS 54urhtflmcKhkynE0zrqIyKfOsk2//21eLzfr+8fxqKq7IWY6HiLaCtsMzUtKRVsWmmh dAEcIa25GHUkg3Ya+BV+e6TQ7hiEcNp8VBKBp5OeOuAm2iauwJ6/IH4aoqA9wVplPfQu +kEIlGwAj/ZiDybD39N50529UZM+0ThfBaGi7GTsnQNmrDExpxU0Rb31otEbR4q4SnRP bR1m8fjnKyQVXV/Z0iYfoAL+Csrmw6IZzeVCR/Lo6tdyUDufI1sROzUAaMCWf7K+EE2z Vi1A== X-Forwarded-Encrypted: i=1; AJvYcCWSKO+ErYOasSetp4GW+RLmyO78161i2IWgTMU7yjx+H4u3HUJd7oKZKcMQKLgnr2u4LwiUZJV5kH3PxSc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzmj0k2/CXjNKLQcyrVeNVcqOEAC1i0bPFq3bGw4VE9vXV3ixG5 IvFCBHOqxlDCtSgqow0TZlzN7nzsxaFQxnxFAv/H2pQPXVCKZEHYQwsYGdzUmQWQaJc= X-Gm-Gg: ASbGnctEV5hNLA1UXyhimodlbzz43YDBiAglRE7HrOAuEUuKc8ZTLcjIZSk7KTouGKJ j9+31wXGV+dxE4YqAAc2Ghs8RMUEsSgsSH8QJ+l/TqTE/c0A7hFdJmxlJeBMSnVCieBdchvX1+S mPXH98NhGjNMrslCiJ445jq3KcoMc8O1Q3T92T0C3YbeDqmPkpjMFQynm4s0P9LXf7/1Oy3HaO8 oQhUmK89JsrStgqTprQTPHNHweB33U8tDs/ieyTftTiajIVpRsW43fwRnyQy4wZyxVfGKFEK5ya b3ZlJHpZ+Ol5izfOgFN8AvHA3Vwhz253d6pke0lzeLp+N+490ZKe1WLlJ2Y= X-Google-Smtp-Source: AGHT+IEkD+heqmJq9m8IHeuM06OadoFmpx1jvpTqHM7h9oaBrwao22/Hk/I57LZwA/2jHABWh1ERAw== X-Received: by 2002:a05:6000:1a8e:b0:3a4:d0ed:257b with SMTP id ffacd0b85a97d-3a531786a6cmr4798069f8f.22.1749264861807; Fri, 06 Jun 2025 19:54:21 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:20 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:46 -0300 Subject: [PATCH 4/7] drivers: serial: kgdboc: Check CON_SUSPENDED instead of CON_ENABLED Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250606-printk-cleanup-part2-v1-4-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=966; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=YnwRdm6I1xYkzMWD2CGBnm+ACwq/qI6QghdxR3iROfM=; b=cqiZ/O0p08p72ACNj+Qgo78sWzdqazBUHR38ZvlGqr0UR3ruYfxho4i+1leIYi6KW5or2wglX aqm/XqqSk0/Dl9v/iYzwAQDXRcTlLt/HqbQYzkxp32RFtqmxiFoy6EG X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= All consoles found on for_each_console are registered, meaning that all of them are CON_ENABLED. The code tries to find an active console, so check if the console is not suspended instead. Signed-off-by: Marcos Paulo de Souza --- drivers/tty/serial/kgdboc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c index 85f6c5a76e0fff556f86f0d45ebc5aadf5b191e8..af6d2208b8ddb82d62f33292b006b2923583a0d2 100644 --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c @@ -577,7 +577,8 @@ static int __init kgdboc_earlycon_init(char *opt) console_list_lock(); for_each_console(con) { if (con->write && con->read && - (con->flags & (CON_BOOT | CON_ENABLED)) && + (con->flags & CON_BOOT) && + ((con->flags & CON_SUSPENDED) == 0) && (!opt || !opt[0] || strcmp(con->name, opt) == 0)) break; } From patchwork Sat Jun 7 02:53:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 894898 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078C325A2C7 for ; Sat, 7 Jun 2025 02:54:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264872; cv=none; b=UwJSgrpLN/NPDkshLU+hYK8zbtmxu2YxSDGTYEVjE4m4ECxKGst2mHg+oybOrCG+4hYH+3KxpOPLgpUPzGkHPXDLSRZN93yIcLDdZFqrLOV6jUKmA2DTSX8dy1Wgw78JG3A7ZghI5408PPRmLVoDHW1IVD4codXOoZyWjQxatV8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264872; c=relaxed/simple; bh=ZiQkH309SsPv8lN8ObW99ERD0AIPkQszerT12qHwgsk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=alMW8YcMsGQaQ4dI7Oyy3uruslu3C9P1MqUv+udJ6P/uiaaOj70bFlfAa2sFwqAbxOYwVY0mxARPtldXtt6Xe2KyOgG4vWkWE4UHzj9vVGmpMc4Ne3mQaTTm5cAZr3Ue/leP2KqjaVBGVwUV67IdLINEcMCA1qN9ouoN9Bd9NYc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=QseZwSqS; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QseZwSqS" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-451d54214adso23536315e9.3 for ; Fri, 06 Jun 2025 19:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264868; x=1749869668; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X/JKVoHG52bM7iYj5PS7gTiSERcG5UqrCOig8DJiksU=; b=QseZwSqSj0+A5J2VqodR6bP8uCtr+YN/25CKSwPgCAYSqOaOq9nWxcTUNf26G4W72m 5nWvitpDE/jzkLGoDXgsOQ5EyKEC5fphVEWkOgTDaAX+KERF/Vz6hayl31vB55Pjo/Hc 5BHp3p+BQCeC0+Quo0/K+3MIUg17U0iLN+cnH+33Es34KDbOetvEKwwAVT2E1O3H5XoB i/3J9jSZ1PUgw3twgxNM6ZzwzgT3Z2S3vgSdvTZmVjDc7bGch1tAaSdkm+06eAxVZey+ f86/7ro+EGaVf0HlqSHH3oF4ywDmmoexk9KjMvYmLCY1bc5UMiMKlNPwk1gYrjhisnzP 7YMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264868; x=1749869668; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X/JKVoHG52bM7iYj5PS7gTiSERcG5UqrCOig8DJiksU=; b=GgKR/vmevvU2pm7X85Op1T4CoZAXAqC09jkBp5KEFBKwnK4vfjjF9CbcA0+aBrCWxP 2ATj/7F0Qe0spimSRai7Hgvm/l8i49vsBpxS2RrYWCDBEvYK8mZZUH2X+u2ya5pCgb4o iVcaHVZtOlkC/NB0h5El2AI4ZE8TWXkXt6MTBLdfCUKy0NeajnOQkvhnrQGaYljk5gti 35it8Bk0fcjLf5UjEH53O9Mb2tE56QGUuv5sWV/aEl/uZz036e6hWB31NSZEJzNvTP4e +FYR6rxq84ML8DVUWJnkVi6aoYwwpVa8DXJYyV9ifu/k09CP5FrH4YmXDVxI+uE6Q014 fWZA== X-Forwarded-Encrypted: i=1; AJvYcCWxUptcV/FpYlmY3ewY3BsUium2D9++JRLOc/t+JQ9HbxRRXltL3n+3dvz0zEAuD+KEymR0jmNdYGw408o=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1Mv1ImNEqYeYQnXwGGERzkNJFKs4OCJh6lA28XCHVIjbgKFQC PRcECz6xtDjl/sReM5rnVNhNwOqGvZcWKx+Ch8PMNVtHq+Swtn39GOEdVSZlCgh5UO4= X-Gm-Gg: ASbGnctXqsAaM4P6JqwjlFP0INyvccGe6ax+WZS89RjzXUa8gaz24nA89e4ij2aqZUG LdEt4Vbyeqgr/b6oqb2EDJzfCpq+d6oHx07MsrMdj0pN6HJZ5yR/rWTsbjdfpBKXtpsuPRGDvgw 3Kn0Jd+aqT9wzbWC8lXsnoldZRN+UmgB1U4guZAR1z7KhQAAcZ6z4OahvEXsunnT60K2UJgg9tU lykjbUskPZrcN/hQRdnBKYpu4+vd15YRwcYAfWKhVdk1ICD2FmEjRYCCX0b4yMeJBSdHPTb4pPE 4i6C04oRSPLNAXquXQWxYX19kG+UPZE76JDt8BMF5snX4yjv X-Google-Smtp-Source: AGHT+IH5d/vDAJyZSz6fuV0j5C8IVfGiu/PKk0FvmAPHACrM59+l4DsDYjrQIDTW1PtMdxhQU8+9aQ== X-Received: by 2002:adf:e705:0:b0:3a5:39bb:3d61 with SMTP id ffacd0b85a97d-3a539bb41abmr1337284f8f.27.1749264868362; Fri, 06 Jun 2025 19:54:28 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:27 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:47 -0300 Subject: [PATCH 5/7] arch: um: kmsg_dump: Don't check for CON_ENABLED Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250606-printk-cleanup-part2-v1-5-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=916; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=ZiQkH309SsPv8lN8ObW99ERD0AIPkQszerT12qHwgsk=; b=jWqGiPKl/XV1kWO8hkwg925xr1q6tsYBxos9FuxBE92z/Pq14tW6oRTqYnah8nuO92j1JK2AA efZNwgbsN74BdsXUFSv+HbPRvTzvr8dhPJfS5pW4gOs10Hl/GEHry89 X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= All consoles found on for_each_console are registered, meaning that all of them are CON_ENABLED. The code tries to find an active console, so check if the console is not suspended instead. Signed-off-by: Marcos Paulo de Souza --- arch/um/kernel/kmsg_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/kernel/kmsg_dump.c b/arch/um/kernel/kmsg_dump.c index 4190211752726593dd2847f66efd9d3a61cea982..f3025b2a813453f479d720618c630bee135d4e08 100644 --- a/arch/um/kernel/kmsg_dump.c +++ b/arch/um/kernel/kmsg_dump.c @@ -31,7 +31,7 @@ static void kmsg_dumper_stdout(struct kmsg_dumper *dumper, * expected to output the crash information. */ if (strcmp(con->name, "ttynull") != 0 && - (console_srcu_read_flags(con) & CON_ENABLED)) { + (console_srcu_read_flags(con) & CON_SUSPENDED) == 0) { break; } } From patchwork Sat Jun 7 02:53:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 894762 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 549BC25A342 for ; Sat, 7 Jun 2025 02:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264877; cv=none; b=LAhL4JfBhsEhaWKc1DPnI9Z+o4pd6B3ncl+ybofWfb615K6f2bU1izv//ftg8hQGm/9D5TFu5w9dbfuqIWZVXwdNzBM3thRyFPwxXxjTPHdkAdno7K0g2TUgRotoE7C8FcG25A+ztKnHmVEk17E6Cl3dYlAOEg3d8C63+XgN98g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264877; c=relaxed/simple; bh=iLfgT9HQWZUDDzN0tovkdkdRnEgGdMwJcOWfpYFBuU0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hNUfgHIEMR9f1DBFObluU1q3qH/UjNRbiXloZi5pVe+/fxeNVocXZO3/PAsjkOIWRITcMggjIyWeojJitB+R+Bw6ZfAMWxzNGzJFDCN/abStz2CDwtdPmkGU22S8mKlqUv7UTaR9AD/ngukPkLNz9wDkWyHLq1EXiDP759PPGwA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=NOa0jP8T; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="NOa0jP8T" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-450cfb79177so14363655e9.0 for ; Fri, 06 Jun 2025 19:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264874; x=1749869674; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Cwhjr/MwOcrXAJEej0LaRMGIcO9EQcwPYBdM3grsn/c=; b=NOa0jP8TfuHGiGnE7hKL/+QAnBqOu8pKY/DhDXe5P9VJfjY7iRMfLnONAUSTr+Mvd4 B1Jlr95oEadJ5TCKALdU6JkMmFwGF3ENn1eQp7EN2Z/+4UvUiqQVI5W4PGUERz43Xlch hEnp024VJ6/Eij3jsd5E0f0003wZ/QVfEX4dk84yOlmGl9RoXvkjuxHIs7M87lMrAkSe mrjU7Dqrg0J/S8T8aP00xcasX0yogg40c2JNpJQVzmxb2ALn0RB9fumYFYHhdbm9aa5/ kBaWSE9U0GBO/SREpkKwC+YDCyXHRnkBmhJ1pMwxQ94Sk7rk6IKkn7ifO4ud1s1reKNY RWOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264874; x=1749869674; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cwhjr/MwOcrXAJEej0LaRMGIcO9EQcwPYBdM3grsn/c=; b=qJyBOwW4v3zbd5EPre/Ai2/CWgye9v/a8zko2mOngmJ+q0xm844cduwKJNgKGIqKYi wazHTd+jTxTjJ4E9cktU7S2vONTDwgEe5olfBf+ZRu/692KSb3noEXQUvxRoz750yF13 R/tQFWpib5jIhxeW4/dhPLadkuP5CPLCeo6Tgk3gz2RvwrUVapmRig4wIZkLYSjjnfgh mE4JM0eETik1v0y3uEOBfpIXjlL+wRDoyq0PP8Eh14vRel7ofSkwupwW160ivfF3Jpvy cwmXYR4afG6LJHZ/jZxLbOp6hrhOSw/8jbnMq9qpI0Fi4ip2YY02SiKcpGf6U1bXROkR 7Pqw== X-Forwarded-Encrypted: i=1; AJvYcCWXc1JQ/QK/+3/+7mwKhs3kpTsRpOb2emuPjptcWfGN+XuEc3kxlSDuxhjpWisds06Pu/lp5gtCcJ/hpbM=@vger.kernel.org X-Gm-Message-State: AOJu0YwFA+F4vfzojrpmuH9v777ovcAwRHheWIgaJXqrH//MaGACZ3SH OwjjtqO/5U18EQwZxUrPc0XUkyLfTTvCXZedIGHmqgvEjxQcWHAjSSADkNok9+p2GnU= X-Gm-Gg: ASbGncuvZyIzg1zpPT0wAYmEWDuyHR/AHDOIYZkOVdVix6Lj+ZcR41C2DLi+GQVqPp/ zMJjvzl7JctywS6ghoWHfA7BCYa8HLDqjcyUkdvC3XgW2X+9T54XawhD8GPe0L668vwm8Po5B7p 91KSKHHQg7zX8JHtforsjHVYPrq1DI4zp4wlTE6/gnDhX15+AEh7MFChYQqO1ic+m2N01iVQbqM 4OtDvTIBXmNvi8Qu3KWgteT6Fah4Q5F9+kzJ+w4+bLoREHlbo8T9uR7VmTLBxXYepV/DsiOnEgx Luvk5gK5JHFDAtoyraXbJDWgNyMJBuV3YYHL/8/FQWNP8C9n X-Google-Smtp-Source: AGHT+IHvN9wEy6EKNYkDxnnT81hoywOQZ08WI1JRYEWNl3eQSXHLiVXm+Dos5iynM7Sa+3YILwrh5Q== X-Received: by 2002:a05:6000:1786:b0:3a4:d452:fff with SMTP id ffacd0b85a97d-3a5318837d3mr4663312f8f.17.1749264873645; Fri, 06 Jun 2025 19:54:33 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:33 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:48 -0300 Subject: [PATCH 6/7] debug: kgd_io: Don't check for CON_ENABLED Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250606-printk-cleanup-part2-v1-6-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=912; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=iLfgT9HQWZUDDzN0tovkdkdRnEgGdMwJcOWfpYFBuU0=; b=lwh6KzwEyh2dinkiRzMgjAoctl1hygotlVKEbxBK2YgOdS8fCmLq/Q05gztFUdw0JdxCeH0Hs zy4lhvv4ZsBAeKV44NBYiajx6Sqj8Awb920ZzuYNMmySvPls0kFGTyP X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= All consoles found on for_each_console_srcu are registered, meaning that all of them are CON_ENABLED. The code tries to find an active console, so check if the console is not suspended instead. Signed-off-by: Marcos Paulo de Souza --- kernel/debug/kdb/kdb_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index 9b11b10b120cf07e451a7a4d92ce50f9a6c066b2..cdc1ee81d7332a9a00b967af719939f438f26cef 100644 --- a/kernel/debug/kdb/kdb_io.c +++ b/kernel/debug/kdb/kdb_io.c @@ -589,7 +589,7 @@ static void kdb_msg_write(const char *msg, int msg_len) */ cookie = console_srcu_read_lock(); for_each_console_srcu(c) { - if (!(console_srcu_read_flags(c) & CON_ENABLED)) + if (console_srcu_read_flags(c) & CON_SUSPENDED) continue; if (c == dbg_io_ops->cons) continue; From patchwork Sat Jun 7 02:53:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 894897 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5397D25A343 for ; Sat, 7 Jun 2025 02:54:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264885; cv=none; b=o8zVm67wq1dGK4BijvX3gRdPnHxFdIEtCotssnaWAmntqpnIiESTGqjBXgg/p3j6Ujz+2NcroxR9czrV/U9z0jVXJbwyJk0CnjC8+m76v5emlhOWdSX/rWl6In9DXzd/FaG3Qml7f4MoO+Aqh5gepyhuRGPPu/Uf4C7/+yrRSi0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749264885; c=relaxed/simple; bh=KOAUnN3mMocWtW+iziCjb9nXWoqfOr6DrzuAgP6VLcQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M7pVUvyse7CZvFm/znqZMLFufm7dci6gjsKMe6cVLza7c99W2RC5PURNxuuKTs9Xb0dpYxHNUzNJaWjl+9UuxLczKlTHLjfFqYTRv/PiN5bn5DdLADpGFUV9jqsWP+jXgVVytB934RJPAscJLw2So8vz8P3OafJidqH4D5nfUaI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CJcrzyez; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CJcrzyez" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3a4fea34e07so1570624f8f.1 for ; Fri, 06 Jun 2025 19:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749264880; x=1749869680; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YhevvUMxwyVlQTogYhSNRf8D9k2NBoggWts0KZ88AYA=; b=CJcrzyez/E1Usfgi01lgUL2c+RqAUQMQSrj1cIzoQrqQIbJOSbTJTBMMLLvOWrEPZQ wMLdQFQM0cQgDFfeHy8VfuY4MWMBBPAmkw/QkD97BIrhJR3J6/KAuxsmGdTZNvICkN0V zoxInN+bLGbvnZavRPCutHEoEXdvRDYQpH84PoYOGfPQWW3eB0PVtBfyoxQ7xjmF8zPf Xq1wosHczSVOmlu6HZvyttS/nEqBiOiBMUWSucrT9XvLPccRDgVSRRukDN5KHH8CYZpR rVm2eDrwRhiLKJKEPrATzX+odR7AQiaURMbgQpH1U/e1qmmDbf/NmvHyoesIKHCo1rLr uJKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749264880; x=1749869680; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YhevvUMxwyVlQTogYhSNRf8D9k2NBoggWts0KZ88AYA=; b=fCEwdtmxqXuMGJUzAspVx7vLzwxJlSD/fchYJPZIALXWleWJ5A56TUospnjz4jC1ub UtNLjeCjXrGQQQlt2vtHJWgNpXjMa8GbOL1mUt0RKsTMZw95+yLVGoi8wIAEinNHf4b4 OpfjzZdQGqIO7mt5GlM6bohR9jna5VX3yJ6XkCn4+CUv5BXzxpaw8ffX6MjEiYgHa5Cd gkXUvUFB7eCNgKp/N96H3SnKpe0PQgbgf+SICxC4SPcBWEdh0xnladDcbbwt2ggT4dCZ c1pYyksttDeGAm6wGWXmBxj7JHvJV5LUBwzbHjT3+LtazH/EP/PFasLhZ9thZY4r0yrj +Pmw== X-Forwarded-Encrypted: i=1; AJvYcCWvheNqHlgh0HY59Mw6WvBQu1TYhNVtOuqiPittXhhFa60M4514ufrB67sU4aQu9wyqgZe6XQW25+hHDP4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5zIqF+XXBg0FE0h8ILj7MYuvXHdyXaVMKBEgVqAzzxOYcJMD6 3yTSCJ7Jq+fsIM+U/kU20aev5hc1CqLZwmCHiZ5tk+MfpZ4VjtK/u+4cubnbwNB1+fQ= X-Gm-Gg: ASbGnctzIAtHaOGZkIldz0PN373BYk3C2h7IAWZfS4F0n3zIkNCAL7OqB6gVOEIpJ5F eMi3Be84EG8mFVVB+M6MacwvS+Z8T/7HbTQYd89BbuNcD5sxF0oJgJ8AgFq2t3IpeBhTQvZJKoC fxk4w0W4WXeXBIR5CxQjnxnkFJzmGIMzUrzfFCzf33L6sMzqSpaRCcI0YtTX+HmRmNE9t+fGUdi l4NrTuPg0V/XUVEcTB3vdxzNAJMtOWk7jOjV8Z5HLPvJH+QV3fNh1SErjlMwpjvLq/Y06wJGiF/ t8a3RCR+FjL+N6BJ41qEagqVUgTk+eWPO4w9OiwNg97M9w/u0l3rz8N/J3A= X-Google-Smtp-Source: AGHT+IESa5LLq7OFr0HT18MGGSGcdVKv/63HG++r/KCtTOueAXQ6KBohd01OZ9//J5xOfwZkn5rCSw== X-Received: by 2002:a05:6000:381:b0:3a4:e4ee:4ca9 with SMTP id ffacd0b85a97d-3a53189bb71mr4901248f8f.23.1749264879655; Fri, 06 Jun 2025 19:54:39 -0700 (PDT) Received: from [127.0.0.1] ([2804:5078:80f:b600:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-530e6429475sm2005465e0c.45.2025.06.06.19.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 19:54:38 -0700 (PDT) From: Marcos Paulo de Souza Date: Fri, 06 Jun 2025 23:53:49 -0300 Subject: [PATCH 7/7] printk: Don't check for CON_ENABLED on console_unblank Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250606-printk-cleanup-part2-v1-7-f427c743dda0@suse.com> References: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> In-Reply-To: <20250606-printk-cleanup-part2-v1-0-f427c743dda0@suse.com> To: Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Jason Wessel , Daniel Thompson , Douglas Anderson , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-um@lists.infradead.org, Marcos Paulo de Souza X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749264832; l=938; i=mpdesouza@suse.com; s=20231031; h=from:subject:message-id; bh=KOAUnN3mMocWtW+iziCjb9nXWoqfOr6DrzuAgP6VLcQ=; b=GzfZv5dsvZ/BfI8fHIsSyKjTfbS5OZlYtux/fj2GG7XKCatBH6tyzKUHv0GzkPE/uoQqkVILv HIUpyd53iTgDChm4XdkV5M0tDGRMvQF8qArv0LcgKdpzVAZ3g/sR/hJ X-Developer-Key: i=mpdesouza@suse.com; a=ed25519; pk=/Ni/TsKkr69EOmdZXkp1Q/BlzDonbOBRsfPa18ySIwU= All consoles found on for_each_console_srcu are registered, meaning that all of them are already CON_ENABLEDed. Signed-off-by: Marcos Paulo de Souza --- kernel/printk/printk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 658acf92aa3d2a3d1e294b7e17e5ee96d8169afe..8074a0f73691cfc5f637361048097ace1545c7c0 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3360,7 +3360,7 @@ void console_unblank(void) if (flags & CON_SUSPENDED) continue; - if ((flags & CON_ENABLED) && c->unblank) { + if (c->unblank) { found_unblank = true; break; } @@ -3402,7 +3402,7 @@ void console_unblank(void) if (flags & CON_SUSPENDED) continue; - if ((flags & CON_ENABLED) && c->unblank) + if (c->unblank) c->unblank(); } console_srcu_read_unlock(cookie);