From patchwork Tue Jun 10 12:58:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 895368 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A865D29899B for ; Tue, 10 Jun 2025 12:58:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560337; cv=none; b=T/hRjZ2msnNvzirfDOl+Mc043950RNYyrZQT+s6nXBA7xbKcv2ky5HLNwYpLOvWqWMSRtsmDuw9b4MxKgBzYmZ7V3BdPV/OxO4SjgOYAjiDLuHWeMTwu7ObI0qHETq8Erhrn6fYI0ZMpaANRa5tkodKOD40DaiViZi98v1MZ58k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560337; c=relaxed/simple; bh=dg7NTbAf068nkPAyseuYOJ95j/6EnHMv20djyj9AJ+Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QoCexCHUxtv7Ug7De3uEQjPnaYWzOZ9o7eVtX7xMaRXKPGqAQGzpG1hevqrj7i9E0jYOe8dcaBuw+qb/6PPqq3ijta2GDi0UM4bcrN4NNVw3wMvvRBMbxozmz4Jw0hx/F4Dhm4IyPaMPCfqRH6UUIwO08SMPoPVdJUJHd5IEqj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=fj0ZfVgE; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="fj0ZfVgE" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3a522224582so3326292f8f.3 for ; Tue, 10 Jun 2025 05:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749560334; x=1750165134; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gjtG0M1yLqqaJE2dvBiQ0tkCCMrIQMLQEJb8hOYQ7U4=; b=fj0ZfVgEShJLEF00AfWncm2gyeOEm0n9F/myoJW1I+ZuqA9uI1Sq0BvP3SGBB5Ypg0 pzyYnEPEGakniXZq0UoU+4l/5bHAkm/fBLEODf6LJ5oU1e/8O6r5BY26q3aJTbdWCi7A Vcax/tc4MYgy2j3ikTHoJHBSTMl8+1P8sbj174uozirS1PgBtFlhFTB1WriKRINEDziX F5ufMU1Y3VV7zuVJOTIp6B0AJAP09qHed1vEQTar3wcjNPJrEb7EQcUD/mzmerwAMmOQ bK+E+mSc5qJtM1KlKfONzdDsgEkuujTsUKb9dsnZYivyaiHm15ruy+ETZrgeTP69zCtL A0Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749560334; x=1750165134; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gjtG0M1yLqqaJE2dvBiQ0tkCCMrIQMLQEJb8hOYQ7U4=; b=cTn3sDU8628JwNB6jfFGGBbEkj8KkZm+WFrLaSiTQ1ix1ioWS832LV4A05A4RjCSAW Ok6FoAD7obeHJ9pwoH+xR/3pQilN3GkiRlxUtu2Uxoy0w9X1DarBLNZ4c3fWjEReLZDX UC7vgVOJM3kiXZTlbVs0UhC5Chi8Fq9SKJWty8A5X42whFYfYSfTsqsjd9QmYHJpEMAM Ht5BAkAEvBHUY79OdIcC9IpbJOSuUOqbHL1fUOTTsdvtmydb0oGDXGRBUzh7GOq5EZzP +mvzH5wn2lZYMMg9L7ca+HNRg3MNco5a9IU0ek7SGbGxcaRTb77h9oQng4o5jPM4otS+ cM7Q== X-Gm-Message-State: AOJu0Yw3t1kBy0WNqm8g5/3Jt7pDcRYwPYKiZs5f5Uc80g0AKN+inbZ7 FHDj0XSORTHIyq/G0UC90+G9xqAQGvFSW2WzXHW8HReZ8t+33SwxFGKFODhYVIc0CUg= X-Gm-Gg: ASbGncvMjM5YtfjlcQR7SWu6uUC1zjaVArSinRLwVYN7TsfdMe2A1QbSNbEcH8CkPa4 Mq/ohrbHNhDbayPWabiJCm5ng8oXBOhepJjfHVibqZNPbgSx/jVHEQH6mxURAzUDJeLjz/jg1zT zMc9Mi5OCKC6n0fBOuiqdbuZU7c7kxKPnbz6HvWO30SUmB+ihj+DbajP2NfPKMMcXh+x0EPgvqY iQ7Biz6seWyVVubOZuZA4EHwzJrYowwL4rMx7tESiUlDyur8bpLrZ60FjRPQueEDbl6LdQ5dOmb kpLbPjU0yUV8Bdsn/K6oV2HboSKyv0h3w0J7CoFCCoRpo4Ojx6WGlQ== X-Google-Smtp-Source: AGHT+IG9PzUqyoN06LxiZpOjCCdywW8bf+fgtQ2tu92Z0cLy0kTBBzQ8suzPDSLtmma55Nz49ZsvWw== X-Received: by 2002:a05:6000:381:b0:3a4:e4ee:4ca9 with SMTP id ffacd0b85a97d-3a53189bb71mr14507284f8f.23.1749560333951; Tue, 10 Jun 2025 05:58:53 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209ce17f9sm143671135e9.11.2025.06.10.05.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:58:53 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:58:47 +0200 Subject: [PATCH 1/4] pinctrl: baytrail: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-pinctrl-intel-v1-1-d7a773ff864e@linaro.org> References: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> To: Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1892; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=b/W4ziaIZgNvt2gfFSTw+J+YlxD2KTxq4CHCw9mjq48=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCwLGwnzqVkLfUS1V0SOYonbSmRblxE+rHBQp gKdYAYGONyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgsCwAKCRARpy6gFHHX cjyLEADFOQ54jPSO1HZsx7GXyUdHxTSOgbMwKyCsouhFb1ic9GsIv81XFtVmDIlfLe42EIZPsrq YzhuHu1Z1uBlqSN20j6lzNUTZDEElUoGkF02jXUQtlEu14Ses7HTX7UWoKQjR2UFrKbwrJtAg/C dH+dIi7HNmOvTFIz6hP9Ucseb5X/qnk3YJxK++l45GkykXw6y56XAl1CRRoQzL/UpzoDkE5RfbZ 1AfQ6jOirYN7jhtpG2k26WLHbdBjzLRtPTe3XvH8VkHbStlh3rXsRODdT4x6lJ7L+Q9yfTaZ4Pb BCLiIDzYCfbDsiECjaGAdJkntnGMsf95nWF7A6B931P1zSaHBvBeOTyvU/KUviN+C2SUsWADSfn K7cL5wHQOBKXS1f+zrKIs04FPoZGOywEhuQ9VwCTgBa3qm+thDcXSX8DwromAtJ962uqvWrMc7o /T5v1SXV0njvWlp1OR991KWFw62yyasWyl6pUrc3me+xV/9MoPcJIh7DyZ2OLBYiGOISTY/IRvS 1beiSF4cisCm2OWopR8NuNzxg5YWIhegNmoBVxgD3z75FUm229GTK8Nr7jf86dZdolOJQmnDsPJ wI/oEITFoAMMtytOHl+G0ao7Z4P2TrY1VuvM2vmqHobdVWbrRxyMXG5m5j87og7gwNzHJHU4biY JisDOVmnzXNNhgA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/intel/pinctrl-baytrail.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index 969137c4cb0659fc66bf461bcbcdc60fb2d0dcb6..6eb649f1ffd6e09c0a8c99704eb165dac58d9736 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -1045,7 +1045,7 @@ static int byt_gpio_get(struct gpio_chip *chip, unsigned int offset) return !!(val & BYT_LEVEL); } -static void byt_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) +static int byt_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) { struct intel_pinctrl *vg = gpiochip_get_data(chip); void __iomem *reg; @@ -1053,7 +1053,7 @@ static void byt_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) reg = byt_gpio_reg(vg, offset, BYT_VAL_REG); if (!reg) - return; + return -EINVAL; guard(raw_spinlock_irqsave)(&byt_lock); @@ -1062,6 +1062,8 @@ static void byt_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) writel(old_val | BYT_LEVEL, reg); else writel(old_val & ~BYT_LEVEL, reg); + + return 0; } static int byt_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) @@ -1229,7 +1231,7 @@ static const struct gpio_chip byt_gpio_chip = { .direction_input = byt_gpio_direction_input, .direction_output = byt_gpio_direction_output, .get = byt_gpio_get, - .set = byt_gpio_set, + .set_rv = byt_gpio_set, .set_config = gpiochip_generic_config, .dbg_show = byt_gpio_dbg_show, }; From patchwork Tue Jun 10 12:58:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 896401 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92D382BD001 for ; Tue, 10 Jun 2025 12:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560338; cv=none; b=Q4aJE/gHJD5bjBeh56AuqLCl3bCoPBk37okpNYFKd2gauJxJqarfRWYNmI3L2UHQOeI3dAgR3rP60UJsrcc6saQLoML5UjzJ/XiWAE0lSCVNBePu8Owvk5KSBXhZU1uB0HI5CDZEw4m9H7S2z8PxMWaBsHmKcBOS+TkMgULtt3o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560338; c=relaxed/simple; bh=DdvAUUlpfYflNBsr++lX3Sffa6O7XE3YDx/EEjD7pcc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XExWxDrp2rwQSDpQmHNmI/Ifl4737RHoO9TNlgaHg/xh2HWrQlwz8LAkbsggMkZqtIinGgh1zWd7K1D2BOvtTuHUXz1pMBtfe2a8i/JnBoxzkI2CrfHT3+iRZAJkQEfPxGOxdQvmoYBqkFLLbkLigaG5w7aNaVRsYl+ZO/eszk8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=vs7g0i+C; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="vs7g0i+C" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-441d437cfaaso34253855e9.1 for ; Tue, 10 Jun 2025 05:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749560335; x=1750165135; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=v2fx/CQtVPLgqKAQGUIys9feEJNoyOh+nIa3K3QYL5w=; b=vs7g0i+C3no14+8TWVhnRCZw0NjYedJV1h73gUAkM4GlGdtj9SDZ/pHWo25vWVA5Bw VPUIbmVISTZ9Uo2vaOsJVdGrRz5i4590KWhr41mU+6dz5ce2M5QTs/SyPWIlc3ON3FUN RDRd3Kx7QEucZbb/+ke9xPEUQ9d+mdOlaI+6fSKGYPo9JLHBWsCA45F1Z2AcbErdNk80 KcmEXy35iYyIc37u6dxmu8OOeKZHaoLdG2NVd7MHHs35bCoAyfgQ+3HX+rh68GCH1SqK OiWP4/mLVria9nLl17tcaRJ+CxS0F2hohqAOzBGHS3twJy8d+gieGMcCsEd7cksoXtBK E2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749560335; x=1750165135; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v2fx/CQtVPLgqKAQGUIys9feEJNoyOh+nIa3K3QYL5w=; b=Z9AhaqpOtm631Pa0LUE/CpJ5YIWxxzToztdHpULjo6lP4jJ3uSwYyPeKoMLnpG7Bgi NAeWZ8mLVQQH9LZWSlJfwI1whul5v1HcWnge1DgwsuLP5o+1P0B/EiHrUYHwThfAigIn Ph3bgEmwzKSR8nBRen+jT/bNHV1HPd7VDKFghv0JHMp4EDu5K/AQNfY9BJzIz0WVtKpg 7RZqK/9XNB+VYxpJ0zSusRC7iQwSGgrHO7pqlqvDBXqI5gfKF6A5KoBCCmwWKaflx9Vd 9qLUMQ0ri/gTxL+ebLCtxoD4IuGjgFQol4FFpOo4i3ZHVcMzkEFPQ6iNTehtS61nP4bD CN4A== X-Gm-Message-State: AOJu0Yy2qlysenwvf1b/9gVjhXt+LHPithQUQIM8aPM523YwcM/seKb/ zHE8tbF6SZaNDEqoh93Q4DuKu2l7sYofCpQ/e/XHKSSjJJ22Jwgj1NOdF4YMk22rmYo= X-Gm-Gg: ASbGnctvrD60pyEzWg+vbfG1kMhYN8Rb7U+vglXHdnIy6iKM2/CDD85jrmMp8GuAj7V DIe9CtaMptZSJwOggDp+CVoUTk9K4Ubeb6w6S1JmhcBqSZh0ncqrpzOL+tfQMCPfZJyODlzMOGh HO1VsVHtA25KdRs80Ho43NNfzZTkCjJ5agh5g6AeygN5HcT6nsNaVyKtBj+f2ziMHqePs9q12uy BXcpyys4Xl3Ldr41olrWBY3bREy3vB9B+kfBITdnvvDDYPm1hPdfK/WTRCqNt/KFKYM5cEk05Y9 hTUl1dpYyVjkP4d0ooYf1porFX7mN8RlI+DTpDDpEjBi5sIuqM8yfA== X-Google-Smtp-Source: AGHT+IF+VHD3s49e6mkIi7baJjgBta7jhRVW7T+zJTDwVWSyLkMtpH6WZvfsMNjwBe2x2P104McBsQ== X-Received: by 2002:a05:6000:2287:b0:3a4:eec5:443d with SMTP id ffacd0b85a97d-3a53188e420mr12880272f8f.29.1749560334947; Tue, 10 Jun 2025 05:58:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209ce17f9sm143671135e9.11.2025.06.10.05.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:58:54 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:58:48 +0200 Subject: [PATCH 2/4] pinctrl: cherryview: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-pinctrl-intel-v1-2-d7a773ff864e@linaro.org> References: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> To: Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1642; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=sQCPPAeXHrozxhJ3sspmTsp1b+UMiXj/1Pgwkfb/eRo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCwLNXY2X4JtFYzVdb+ziESNPH6YyzM7IUOtN gi3WIyKNViJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgsCwAKCRARpy6gFHHX cgvCD/0ckNOwzxrinNTI5YFdtzkyxslAiEfJyvsHu8k75/3cSGjeB3N0HqgCdpkRegPYOWv5bP8 biZ/vhKj1VICyiSmi4Q6P3VLtPntDEf4uEpw6MOAs3/naM3eil1xknCxKJcwXKoif8fk3hgkEaR pJccbUa0S4Btrnnti+eBFVaFr0Tip/g2t87GFizMMCYwWdbys/zV8whbXSRRpFpTIXV/lZYgtbf tOLzWZvAq+eKzI04mDzjFLyojb3Xb94JVq/pt7vMpKeW9GkPw0LSrPinfQFM5y2K4L/MNfZhRly 3gtidAvCQsnWUYxlnUJwTflV7rdz2ZSxh0BInpTzKbk6XBxfQbE7mkk0AKErYiQBg5ILoYSMvYT zyM1+qOKOjm2d8Dobn+/q4J7TKLiOvSOW/FsCYE0hYu1a2uzO9lpKp//1Ls2k2BxeYRcv9mWts3 7diBoyTJHjPSEsJXn4vXQ1+BYrSaWBivDoLpSrkepbNqmmHWK22ChQ3C94y5NWD2VCRGGGtms5U IN5zSBYEOdFu3R3g0S8phWT1XmSTnxZw6JLsVu9SVFoRlpIp48JcraDCvL9Sabl2CWeqUnJv51F Vq8NBEnZrAETtqNW6KE0Fjqm4ZnwVp8utlHbdS/umHpPeikbrcAqN0qdcjflobRx8od2Ew+S+zH MTvu+FEhDl88m0w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/intel/pinctrl-cherryview.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c index 69b18ce0f68588db30f7954a141641116c9094db..769e8c4102a5f64479201bd8f791d3f155e949b0 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c @@ -1112,7 +1112,7 @@ static int chv_gpio_get(struct gpio_chip *chip, unsigned int offset) return !!(ctrl0 & CHV_PADCTRL0_GPIORXSTATE); } -static void chv_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) +static int chv_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) { struct intel_pinctrl *pctrl = gpiochip_get_data(chip); u32 ctrl0; @@ -1127,6 +1127,8 @@ static void chv_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) ctrl0 &= ~CHV_PADCTRL0_GPIOTXSTATE; chv_writel(pctrl, offset, CHV_PADCTRL0, ctrl0); + + return 0; } static int chv_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) @@ -1166,7 +1168,7 @@ static const struct gpio_chip chv_gpio_chip = { .direction_input = chv_gpio_direction_input, .direction_output = chv_gpio_direction_output, .get = chv_gpio_get, - .set = chv_gpio_set, + .set_rv = chv_gpio_set, }; static void chv_gpio_irq_ack(struct irq_data *d) From patchwork Tue Jun 10 12:58:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 895367 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1F712BD01C for ; Tue, 10 Jun 2025 12:58:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560339; cv=none; b=BxgcGlFoNWxabQvPyd7wb6jOtOTLkg4HUlpoFnVMN/Vwq8ej81FQlgih3OoMh2hJK7/cMMRY9Ii+PYxOHLrv0uFbjYP5TZfDksnDeTZZOilaljKZZUfVO7hnNKtY2KwEcM2Tt9hCdRhlVpbYmdU5guae64uatQQiT+eJgQ7QOHE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560339; c=relaxed/simple; bh=17xCbJ24nw7sQxktnCslGe/MRxFJ2bFt5zYCSuRk9uM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E2fOoohKkyZuaLC4f/Nv8frQcmsmSr0GrRN+2KHCOFacrmQUrDlAe+DU1kzECkWAvGqcJZ5KXYzlbPL+gsCUY5geBRP5ovnBCDqEUotxtnX+gAH9vx6vj++9NuobKWkuqur+ShFxEshf8BxrjM4atoVRADqkyM7BUMIOIrL4Jec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=eeHJtNGO; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="eeHJtNGO" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3a54836cb7fso1471618f8f.2 for ; Tue, 10 Jun 2025 05:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749560336; x=1750165136; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CP0pr1RnwJJZDVZHWlvpAZF1INYr5USAQasxBrkQ0FE=; b=eeHJtNGORp2c4gs30u1SpExUu5dyEWsoZcqeKqrVgUbC7cl3Co5kU5ZO8dGsZacQkr o/FyncMm1Ma9MlJJhz7RybCQm0Zb33lMX+fj7OgXLer/NLJPQ1qdOlw7kTvU2iSew8aO dunC/+9/vYOf4ESS3tKCpyoga76miKQC2rYvEhB69G4vCWAKT8YfJknvI/2jcpGVpZLk YrjC/iPczm0lJ2vSReaxR8PeER1Jr6OpDZ51qJ636KBIyfD1WKlGNmYk3t5w3wywSlSU T8rtAXp9p6hxClkx5jIrwDUkyfmFY4A5E4FwbZHPnvOnXeW9YG9NIGQUY+0QSkfVGzxC RHlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749560336; x=1750165136; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CP0pr1RnwJJZDVZHWlvpAZF1INYr5USAQasxBrkQ0FE=; b=EBKuaC2FM27qvunoBW3/xk0a9O4JxHzOiJdcIahJNaae7d8rTRuUVCI7Jx8UvzyEqE KRYnqhpxa/rvv45Mc3cY07sT/57FN1U/Yqs2Ymbatsf2QwI3vEZMweFB0GxtoQPggPpP wm9Cbb/vlxKgCDDekKcwVx3KQaq8dC3T4Xy48LqI4CFjd/myX/CaupBL4ZmfE4XLAMLd xjMfQgf0uE26bfPaibbKGaMcYjFxqVvK608uCXlzidOoP4oVtrcQPTh6b4dPs8Y7p810 yr6zNbeWfld1Kl/wO+7/dUa5xiRWRoOATDvMhmbtr68I8Xpkd7kko2bNf5KcniugMaFq dvsQ== X-Gm-Message-State: AOJu0Yx70LTUVBDhvYMV7onpFqxU3lUpUYHUpbFcatGH1IovVaoF0Nmg mHDhFJIUZIBO9ESueNehhQpZiIXu6e7ZvgX9sdWjfFP6F4hbKZJExV/9ZvdPAxuIQM2ucEArsen amQC4 X-Gm-Gg: ASbGncvyUNkvV63P15S6f789pwk0eEeFk3qnU57Nv2A4pLRYpMQncs4GQeu4EpUuMCl Fd0QE/i0VlM9c/WEbuZTznF8ckn8cX9hJr0Effhlqc1dPHiK9jemgAqRPKCYj7PbJ6cqTBCoJne 9QL+AsnFBeZOALdk+shOq/SAYw4Tj2ru/1NzZc+1Rw+5ZkDuo+Lhho6KwOLU1OiPbPS4q7U/O30 p/MeVZZ+ySb6jvLzFUDk4wxOHl/CQKqXn/3hnK9HI2WsenOQ4Me/MCqhR0nZpu6oiVhznTMOgUw JDx/33Qzy9UVYGKmkH2r+VbsnqpVt7gDcgQf0zKZa7BIliivUGzqEQ== X-Google-Smtp-Source: AGHT+IExRR4e9dlTcGN0ufmc1c99ii86pLeqcP2EuDaO9z8bj9vuw25+GX3iaPffRFFpJyv3B0e5Iw== X-Received: by 2002:a5d:5846:0:b0:3a4:e6c6:b8b1 with SMTP id ffacd0b85a97d-3a53189b3f0mr13321169f8f.17.1749560335886; Tue, 10 Jun 2025 05:58:55 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209ce17f9sm143671135e9.11.2025.06.10.05.58.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:58:55 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:58:49 +0200 Subject: [PATCH 3/4] pinctrl: intel: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-pinctrl-intel-v1-3-d7a773ff864e@linaro.org> References: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> To: Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2394; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ZGNRH3kU8gUncy2AaRa7wuxQkW9WPpCNaL0R2YfhoJI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCwMdKsPhgfXUHquenNk6O7A/jRl4HMET9q+Q vCVfzIewKOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgsDAAKCRARpy6gFHHX cn0mEACuGd8lWVugJKtZTsp2ckp+ZOy5qIkiOu0UNfHYwOVPLUVQqrU4nIf7sFW5kEcLyb2GVmR l17L0oGHkynm2j9qDNkIpDcy7wAgZKMELOxF0DDtrrk0dZDahrNR+7ovYixYvIivlcZ6ViMyBnu g/PmF/bj4bkm3+tGcVcx7KnZroUmn3ygekpd7WI9+/VwnqatFqD7hNRoFfcvsaDHxiDs9luvYli RKAoInuHzG+O81vY7hTSjEeajfxLR0oP7T3MX5Rcn9LkX7XpUWhjJS/MmOvYpXXbMcv5O8xXMGi URhroPZQajcaRMAW8MKbcurtmRRxEJrwLczNNXAd5MrIlN33/SY1Fp8Sifr/Fe1EpbfXy9FQFHx eVXJ7mHNAOmPjviFKkOXQVpzczVkmR8i8ccjUttwHIcqTtLk6DdcWhW5COLuj6t8EjTPVYtLyN+ OZ0qesKfituFBYF6U+s+BrlL593yQLFtl+DDqvTWRawXKDmIkRYH7oSfMzWYiiXQQbka83/scO3 8A73lDmyky/V4FBpz7j3JSYhQ636mPn0FBoRt5ZiJNUUzdbBrA+T/OoZHnuxKt/p0JgJtGpUPUI qcXE1fGfrq9c98zvbkgzqlJIvppyHPYRTQpfiswCO5dTaIYmQDhideWchlvW1x+Ohm8IMDZHy7o Oc65rVBuouZ/J+g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/intel/pinctrl-intel.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index d889c7c878e2d57eb075f4147a3eb2e2ae05ec5b..846b25ed1cc44cf9549aafc63192c80d8e66a797 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1033,8 +1033,8 @@ static int intel_gpio_get(struct gpio_chip *chip, unsigned int offset) return !!(padcfg0 & PADCFG0_GPIORXSTATE); } -static void intel_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int intel_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct intel_pinctrl *pctrl = gpiochip_get_data(chip); void __iomem *reg; @@ -1043,11 +1043,11 @@ static void intel_gpio_set(struct gpio_chip *chip, unsigned int offset, pin = intel_gpio_to_pin(pctrl, offset, NULL, NULL); if (pin < 0) - return; + return -EINVAL; reg = intel_get_padcfg(pctrl, pin, PADCFG0); if (!reg) - return; + return -EINVAL; guard(raw_spinlock_irqsave)(&pctrl->lock); @@ -1057,6 +1057,8 @@ static void intel_gpio_set(struct gpio_chip *chip, unsigned int offset, else padcfg0 &= ~PADCFG0_GPIOTXSTATE; writel(padcfg0, reg); + + return 0; } static int intel_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) @@ -1094,7 +1096,12 @@ static int intel_gpio_direction_input(struct gpio_chip *chip, unsigned int offse static int intel_gpio_direction_output(struct gpio_chip *chip, unsigned int offset, int value) { - intel_gpio_set(chip, offset, value); + int ret; + + ret = intel_gpio_set(chip, offset, value); + if (ret) + return ret; + return pinctrl_gpio_direction_output(chip, offset); } @@ -1106,7 +1113,7 @@ static const struct gpio_chip intel_gpio_chip = { .direction_input = intel_gpio_direction_input, .direction_output = intel_gpio_direction_output, .get = intel_gpio_get, - .set = intel_gpio_set, + .set_rv = intel_gpio_set, .set_config = gpiochip_generic_config, }; From patchwork Tue Jun 10 12:58:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 896400 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A20E22BDC0A for ; Tue, 10 Jun 2025 12:58:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560340; cv=none; b=iX/3SGmvUaeVI4bbE8kdIeamGwN9Y2YfqLVT/32AtOPR/d9+8XPdPq8eKkY2044AlSevrZo6BzhPgv6IFX7OOkT2lI6zV5vMJC7DBVbLo+b2/iOptGNdgbSQMCmh7h0Jvll0ByV/ipCWB1QZtGFWRH9jNk52umR18UgE+oU1Zb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560340; c=relaxed/simple; bh=oTpSgC31PAVO+aE1pNh07rDeXdPKl1jobKVG3g/UHhs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gmiyftdKFrGBdWIMMy6lpkE2DFUqIns7a9WBIM0U/+EtFodGWYEw5WRSwRhXk4UY46aK/kHDMpIsh6ldu6FFzAyJz9pWPC0sPjuKR1ginivC7rE7F6TTEEf9nvVq6nTQRak1lmrIK/cHk9R5zwAW782/bnGKNqSTjTQ0TgdQsds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=En33Eu96; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="En33Eu96" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-450ce671a08so34554655e9.3 for ; Tue, 10 Jun 2025 05:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749560337; x=1750165137; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zrVIKmBA62tYbIrJangPWC0arTIQiP6CcWv/1Ljn/5A=; b=En33Eu96zcymiNC2h35W1Xal+iA+QRvuk35z/U0AcTO9tvb/MryxRirrfoQL2EcIr9 11LvL0KfZdQYgqMs+029SghHUo5a+klA9s7JAYEP9oKPam8SoIfximmuJ8R/4/MT3nmf 0Nm3esTDr4x6tC5xmAHKdF3CbCbVPx3V1jCSskYl//rpZtsq4+B8Iza5OmHM2nn+lw7B 0Z8BTSro/QQkwKP3EXvTEfh3kld3tlnDQ4yhRPVBZ7B4H4t/Dss2oSkB34LhKk72L1Lp eMHS02MDIt+2oKSgx2ZVIr06f9iho82KffdFpZjzvPkhvcrQiVat3d0YSLjSmxxgYc1i VVJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749560337; x=1750165137; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zrVIKmBA62tYbIrJangPWC0arTIQiP6CcWv/1Ljn/5A=; b=BCNUOGEaGfQsLC9JWhnavBlb0dMP1GKZ85MPvgjtOc5gyBGI5F2x2H9Jvp1NqAPV9C Dd+jnvqH2GwsGhWN3crYG42ZBHMrJoJCvvprDSsaq5VW9+o3aObVzSuyeA+PBxDbK3iX YqbL4YjlpFp+mOP5tL9/dP/MX/ahZbWIoiMajIzel1T0UzPjLmkFY7M1EdVWHtwEfJe9 /mz2Ff7/AkI0fXqpnjCtxbNIP470azXyqC0Vrbxhbuq3nQ0yzzHjw5zVwClfps0/hOJI b+L+iC8Bk1Fx8C+JB6v0O744fc/UKIfzf3uWqm1cZvIrHEhPyvWt7Y6H5m9bCON1I7cx 6vdg== X-Gm-Message-State: AOJu0YxaevF0fVh6JlUGKj5nY/BgU2+3vePEuTB/XJKPnni4jKDN138B 6+cuv2wlpCaYb6lqPuSzpfrQigftRo91UbybHSoE9razFS1TojSGlxvEluTGXHXnGCsYqFhsvae OqZ3f X-Gm-Gg: ASbGncuIIDDNrTZKVaK6YXniAvBj1nFditcEOHlUy7lc7dGLTwh9M3s79iwYB+oVxsX 6qufJKDA/MGofu8vois10NF0322vK+DfYkpEO15CAQEXC2/GJKCGc8U8Mt70RntDkHsmTxIYHYu EOACYuK6ZocAEda3Wc+ognbzMYdU+xp5bVrQkvY9xNCJ+sl6ct3//6hiLMuXhtk95li/ZUs2D9B DDLkfli3ifYVlGnxh6J3GG1IGFnZXdYDvUVPoiGCnSB+LhDSw2AKaxqX9sqWGjNilovjAODWO4x cXhquPxKZrLErvu1VhZdVv1v/Oq6w61DzJ+cA78dgUuCJjs2oYw6NQ== X-Google-Smtp-Source: AGHT+IFdJ91jmVZS5b+CzAH2GS7Lj2zbRrdX46WwyeQXZY1GxVzkN/B3QcrAI/8YtMDq52owlFoArg== X-Received: by 2002:a05:600c:1907:b0:43d:db5:7af8 with SMTP id 5b1f17b1804b1-45201414a65mr127985455e9.21.1749560336865; Tue, 10 Jun 2025 05:58:56 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209ce17f9sm143671135e9.11.2025.06.10.05.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:58:56 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:58:50 +0200 Subject: [PATCH 4/4] pinctrl: lynxpoint: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-pinctrl-intel-v1-4-d7a773ff864e@linaro.org> References: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> To: Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1747; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=pi3gOCuYMaPz/JFg+eWCQsR8jJCkFM1RNWFtAInCAqk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCwMTeUKdwG9/vVWjkQR0UDigBpG37Jv++1xL lBW+SFGjR6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgsDAAKCRARpy6gFHHX cih7D/0WJnBIQjNu7CfhOsitHfBqojk2Xrt7W0ojZT/JR/BoihIxylpdRHVhjnAICLkRF+TFS7R N8cNsWHs0YvmW8RXDA6hraMDhrtPxMrK5SCIStK0Al8WwaY+tNXfapYfx/A9c2ZAIQ88hW5JB3X ZO2TLU4+dDdYorYL0pVizwXYHpmATBxLJ5BJShkJs89VRAOOGtznAfRheKiNt+47uNa8hHB2HOZ V6gpfLVhrNQV3qQvpO2AyMehduOtEF3UFI0ilJoW6pdRWl/ed425LwS3fpae3pq0EsoRDlZUSOd 1xqlmO+Lz6bHQROaHJTL7fFtVOcMFHLQx8fkcFzVY66smtmxqP7BSa5Q780wvwKlzV4wwHa5XeS gxs/t5VcqgQBQ7vdUlG4sbznvIVvt7LdcRaipOH1QYvGLUR3UOq0XumfUTTif90pbnrJLuXT1yb MhLkCRPFewQPf47JaIm6TyATI8YdTEcdve0nBboGY4riH80PaQnBJOLgPgyaLWlxavjpZP4j+RU hlUVhglebjCFkQwIbdeDEwYkIMHuZGEwzEU0/zYuROSletrrSh98wPa0ceUNnMNdBt0A1CcJeqz aipK/5PNcKz6WfgVwao5uBRPxFy5mtKi/s8Bh+jEsMNk1/yg6GEAyw5veWppvTaigiX1rzXOyp4 OZDe7EFboNR7XZA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/intel/pinctrl-lynxpoint.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-lynxpoint.c b/drivers/pinctrl/intel/pinctrl-lynxpoint.c index ac5459a4c63e054ae4dd975f0a19112e4382aa99..5d4a5dd493d1bfbbc6051163758fd8a9341b43a8 100644 --- a/drivers/pinctrl/intel/pinctrl-lynxpoint.c +++ b/drivers/pinctrl/intel/pinctrl-lynxpoint.c @@ -503,7 +503,7 @@ static int lp_gpio_get(struct gpio_chip *chip, unsigned int offset) return !!(ioread32(reg) & IN_LVL_BIT); } -static void lp_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) +static int lp_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) { struct intel_pinctrl *lg = gpiochip_get_data(chip); void __iomem *reg = lp_gpio_reg(chip, offset, LP_CONFIG1); @@ -514,6 +514,8 @@ static void lp_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) iowrite32(ioread32(reg) | OUT_LVL_BIT, reg); else iowrite32(ioread32(reg) & ~OUT_LVL_BIT, reg); + + return 0; } static int lp_gpio_direction_input(struct gpio_chip *chip, unsigned int offset) @@ -775,7 +777,7 @@ static int lp_gpio_probe(struct platform_device *pdev) gc->direction_input = lp_gpio_direction_input; gc->direction_output = lp_gpio_direction_output; gc->get = lp_gpio_get; - gc->set = lp_gpio_set; + gc->set_rv = lp_gpio_set; gc->set_config = gpiochip_generic_config; gc->get_direction = lp_gpio_get_direction; gc->base = -1;