From patchwork Mon Jun 9 18:28:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Walter X-Patchwork-Id: 895486 Received: from mout.perfora.net (mout.perfora.net [74.208.4.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD2A021CC71 for ; Mon, 9 Jun 2025 18:29:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.208.4.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749493744; cv=none; b=AdLt3br4pLvNPy10Fv/kKSvSgiXESGAQo/xqwHfyMSxaz2pNTWntj3dkJNXWBdfGNtkuIj0m2bB0ARiV300JEtu2O905eGr4QwNijSnO0nw5oHtCuarHZgyPJoMME/R0ZrlYxRFzgG3ox+dSEA8W4QYFE1QjihIQcRETybPagh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749493744; c=relaxed/simple; bh=Kaj00o+B2KXXV4WXwzq0v8aTYcoEOj2DcRQPSdeve3o=; h=Date:From:To:Cc:Message-ID:Subject:MIME-Version:Content-Type; b=hawi0lMkrTxFBCDopXn/Aa0p4efYAB0F4c3z3qCidcsKYX9vfSZAV8jLA7fh71BeDoFiMfQ/Pj57kqPyFw1Z1BHXK4/BnQ3kO6qkkacFxfNONfQzlYqZw9GarF0uZYgXG8T3PqXvL5RvpUkQ7hcdD/tKyAEieUudLZaVBaSYWHs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=codesensesolutions.com; spf=pass smtp.mailfrom=codesensesolutions.com; dkim=pass (2048-bit key) header.d=codesensesolutions.com header.i=joe.walter@codesensesolutions.com header.b=agR7y074; arc=none smtp.client-ip=74.208.4.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=codesensesolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codesensesolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codesensesolutions.com header.i=joe.walter@codesensesolutions.com header.b="agR7y074" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codesensesolutions.com; s=s1-ionos; t=1749493735; x=1750098535; i=joe.walter@codesensesolutions.com; bh=Ra5pxwXMJqZ6J3ljb2AJG1vu0fPUAPsgccbDXHMPw0M=; h=X-UI-Sender-Class:Date:From:To:Cc:Message-ID:Subject: MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=agR7y0747kOHlVotYDHhrjRezXzFty9m6rUrnJRooBk3rkwqsdwIE/bZM9LLV7Tg sqTCxVMhg+oAFJWztXlQUutqw9vnRD/jbQiHXuogyO6WKQP2DXID0b9iLDWQftbkp pJLaY0ukBtvuXra0mrpu5iWjX1U5vIYKD+1aa6LzQhL9xe2J2OiE96THVsV/5ETrl znU418kHx7wpdNSvkTlQlcY2WcRRUIaYM1XVFbTSJZ5WbOVoBk5BpDK4KcN4kmep9 ZTe21PgwJcJDnVdP8Amifwgp7iqJPCoL3+FBflXIJ2HgOQokqyH7U0to7oUonrfdV PThDxta+NCVxS4py+Q== X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from open-xchange-core-mw-default-0.open-xchange-core-mw-hazelcast-headless.open-xchange.svc.cluster.local ([10.73.158.221]) by mrelay.perfora.net (mreueus002 [172.19.143.1]) with ESMTPSA (Nemesis) id 0Mgd8b-1u9eOe2AgJ-00ITVM; Mon, 09 Jun 2025 20:28:55 +0200 Date: Mon, 9 Jun 2025 14:28:55 -0400 (EDT) From: Joe Walter To: "srinivas.pandruvada@intel.linux.com" Cc: "rafael@kernel.org" , "linux-pm@vger.kernel.org" Message-ID: <639429100.102270.1749493735270@email.ionos.com> Subject: [PATCH] cpufreq: intel_pstate: Add EPP default for Kaby Lake Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v8.36.54 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K1:8D0IMAclchht8ICVkcFGjWl/uL0OUDZl2YjuQQqYEZh55UPe937 7r6rkBgl7J+Yf3uSTdkKyPaL8sSStapEEXRvMkC3djmJDYX83T9cP+a7T3jWzlMtNbOYqw3 rE5507WctRVY6bNqLHd3ELonxxrUIXNtNqIvTXd0d6BzjY+Y+DOjHyg1OhwzssPdkjGPhK4 M3s6qp23OUAf//XlkGk8w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:QmX2vXzcgJQ=;AaFMVTOe2NmTrz5PvN8L7l8uhkz 14+2rmp2sXyqdw/tO4TM4ufTvYBo3hbHiQNBAK0DWH23H+S8bg+jvBUN5OKQaL3qHcKxforYL NnolQNV2OlKhtijR52afwlCk7urzL8mKr8uAHdNHO7pNL/p64f5aoV/OP0bTqFxGr5aokVJ66 mUH1U+Gw00nfbyd4KMUKKEB1V01Z8GujU+wOIjFl6o6wJyOcEFuRqMwZMjubCGvhkryKzc7RM 1neXLvnB2z2cM66LtUrRQkZhGVQXCT84I7isQvMvj8+7d03/trAKzY7qwVMUCCt8KNn13VJJ8 n9W+iZxuGrTYEEx75Ozr7MCr5nK+CsKAwMVVJ7p0iMkmH70jFqsIiYdjW2q5wP9zZ9TQjHHlt O6mTtOg3WZJ09BNchMq8jEHcbhRQMeIJdYCPyXdXfuPL8YSbX9yzBTNAj3ZrwlsOuwCxe1b7N exsbSG6fvNPrrKqULko0BisDbrtJPDBQILyefnIuh7StGAj+Pqd66Wr68gctJrbxmd5pqSoAS Qmov7tqzaVu17nIhxdeeITHFDsiktwPWzvYG//RGol58JfxlTnknwJWW0mVDSlj5PrVcxIFXG 1Ccq1DUExn66l1mBb/22uP399IN5L+35YmT39bUT4Ht/rxVdoXhAtbHJbhop1CEK6ne6PRrYK Owsu5iWV++iWq1O5EudfZ/ggDtMzUH12QzD43EYyz9k/mqWA+L/KAVaf0d8bFp+LunM2Ogl+N IBb1sI/C/6zNxnnv7W6IMrV8AKIGsGmiOCLDggqceQjUtjO3s6gpiEVq08hX2RwYVJxGb+uCM t87w2B58vyLlQSH1q67viqrFpQoyEgeGOR/1bhWDIPVucAQgeo5Sb/UvQo/GtDeT+y0MWV5ka 76wrE+apMmdEGEuLzW7m+LzTk1ppXHawujULIwUujqKIkVibGXLEmfIshUv37NvHKQFoxsDsT 7Mj3WdccegD02ILMJIgbIVgTbY710v7WEnTX2+xKKz6RQgdgeb1Dhj6M9nOi6khUho0pVB43m 0ZTNm1ju7zqrn17VttCtgkGMWmvKV9aIOiDIP77AG+J4kOCwtwC7+0uEto7wr42WxCHieO5R/ Vf/B2MDQ663BwD/ZHgsKS1SGjgxGMDWohyKh5N+4vT0X3n0AmgB779Os/cFWmDFtYGBXShVVX /sJNHvzeRH+nnvFbHY3JV/0ApKyml7PSbidERxD+f7ijgRw+Opy3OPrCbJXO/kO9As1e09dR8 T5hawI5Q9dlLp7WlzL+4jU85m0oUo84lmv1W4t7+hXtVegem1ZQ4f8DTPMjAGR8Tpog1tAohu Dn7q7FCSgtNzMt4acUxJ6B8fmz1L8VI6fNUc3mwc9PJRrqPlHvry5pHfFdzWXn/ozdZrFz5jV 9mGdT4VWLe0D96rA== Hi Srinivas, Thank you for the clarification and your patience with my questions. You're absolutely right that EPP is working correctly and is a user choice. The issue I'm addressing is that Kaby Lake systems currently get a default EPP value that causes suboptimal performance (900MHz frequency lock under load), while users may not realize they need to manually adjust EPP settings. My patch follows the existing pattern in the intel_epp_default[] table where other CPU families (Alder Lake, Sapphire Rapids, etc.) have optimized default EPP values set by the kernel. This ensures Kaby Lake systems work well "out of the box" while still allowing users to override EPP settings as needed. Is this the correct approach, or would you prefer a different solution for setting better defaults on Kaby Lake systems? I apologize for the multiple emails on this issue - I wanted to make sure I understood the proper solution. This will be my final submission on this topic. Thanks for your patience, Joe Walter >From 776a4483e8423570205f42768e510ad001050899 Mon Sep 17 00:00:00 2001 From: Joe Walter Date: Mon, 9 Jun 2025 11:15:05 -0700 Subject: [PATCH 1/1] cpufreq: intel_pstate: Add EPP default for Kaby Lake Kaby Lake processors (family 6, model 158) experience frequency scaling issues where the CPU gets locked at minimum frequency (~900MHz) under load when using the default EPP value. Testing on Dell Inspiron systems with i5-7300HQ shows that setting EPP to HWP_EPP_BALANCE_PERFORMANCE (128) resolves the issue and allows proper frequency scaling up to 3+ GHz. This affects at least Dell Inspiron 7567 systems, and likely other Kaby Lake laptops with similar power management configurations. Reported-by: Joe Walter Tested-by: Joe Walter Fixes: (EPP frequency scaling issues on Kaby Lake) Signed-off-by: Joe Walter --- drivers/cpufreq/intel_pstate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 64587d318267..dc79dd626b67 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -3781,6 +3781,7 @@ static const struct x86_cpu_id intel_epp_default[] = { X86_MATCH_VFM(INTEL_EMERALDRAPIDS_X, HWP_SET_DEF_BALANCE_PERF_EPP(32)), X86_MATCH_VFM(INTEL_GRANITERAPIDS_X, HWP_SET_DEF_BALANCE_PERF_EPP(32)), X86_MATCH_VFM(INTEL_GRANITERAPIDS_D, HWP_SET_DEF_BALANCE_PERF_EPP(32)), + X86_MATCH_VFM(INTEL_KABYLAKE, HWP_SET_DEF_BALANCE_PERF_EPP(128)), X86_MATCH_VFM(INTEL_METEORLAKE_L, HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE, 179, 64, 16)), X86_MATCH_VFM(INTEL_ARROWLAKE, HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE, -- 2.48.1