From patchwork Wed Jun 11 07:27:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 895618 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 508DF1EE7BE for ; Wed, 11 Jun 2025 07:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749626884; cv=none; b=pevUQroZedNRIkW+jgtO45oEnb6hpwLA7LwK8JR0ooQp2TxDp9DgaO7c4X7xy94f5ZjOvAEX2NUcE2mE1VPx5wFgFErKn2qG3mztO22OOf3wXmy7eHp7jG3Dx1PRZhSj8hNccIu9IQhzBVDdf8ypuqpnEyMvHCFR4+kelNVy/TQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749626884; c=relaxed/simple; bh=RS4CyQB+rgcczv2KGEGJBmS0LZsJo7kx7f6neyBFGR8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K4Px/70aqwYdvSbU/TMQ6LIVpeHmNc32q3kQlmkIVdUDvvUIQjnBMHix07mvskX2W9UdAVWqA0L+daUvRxwmZHVhhyzsbtjJBpPb33vuWXiwEQagmQ1s4UL86eiWWP3VrzuzcL2EospryD4xDzulNmZns9MB04CVHSvm8nj98B8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=kYjUR9Oi; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="kYjUR9Oi" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3a4f78ebec8so3788449f8f.0 for ; Wed, 11 Jun 2025 00:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749626879; x=1750231679; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4jEAzpdm9dv0stSM/DeKw+5NkfJshNWGxpEezo0eZW0=; b=kYjUR9OiDxVzMtnGucpT3TpfV0Dw+o8F+dKBn7Q5plMAogAhV5iii0D3NOGuCj+UFd IZvMYgYRQMoucu4B5f5VX9ISSycY4GXkWJ6fHwWyFOY/Mm9Vf+SYB2Vv+vuXbOAAGmAH seDvsHwotJg+zp0S+lczl5Qj2WLCF/qlq12607wc6CzY/+XKOxBtUVlK2cXZDhwghhr0 b886N9iy7StUFhUOaEa6id/tduMJEwcN6av92NrkVU/Vh8hDQfKMjjmkflrozI3Pr2jj tSStajEZoKqeSmTDrBpma05vZAQRMuliS0mbHFDggSHKQj567PR/iXVFE70VyFk+S2wW E0ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749626880; x=1750231680; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4jEAzpdm9dv0stSM/DeKw+5NkfJshNWGxpEezo0eZW0=; b=e2sZRzSAx3zMYGXHr2zqY3BvesVm0bMjkvYRRK49hdsjAuaUcfcLt1YyH2D7bx/+ty Gag5+KwkA52GAb0PLCNMWix8/6NIcxE9advxxFziaXA6UXvaoF6EqKRXNRixnI4AZvxv mBW3dfR7gCNEre1YfdvowgFApU18JTZ1X6BeDrW2GoFsU1i/HSddw6nYsEkZwPem7+rf XCckt9IcWek9q43KWJl00snmcZbB93ObaoSAOJ+otgIkHZj41lVOFSxGixBPPStXewzD GC6GDI4Szd8gGxtzNBoIurZb2g2bTebcwSu0jnxwFf2CNsz5aQj15+jbE/22lwAyVqdU OvjA== X-Forwarded-Encrypted: i=1; AJvYcCUdp2c8w8/VWg8PT/shnYSEOhhbrzj+qdPP9Uu5rx8eB5MtY0zRPWtSQeYBYP1zZoHz5x6q96RKslxL@vger.kernel.org X-Gm-Message-State: AOJu0YxIthAZrDPUASHfQxD1tyzdxg5fNeL9Y8Gi0K/0SWobHCtNoOEF OgS3NP/xsZTm6h/Adloof7tfyVHgL6zEwGFKs1XTHCXqYIUCUVUBhhYiCy0BHOTgzDw= X-Gm-Gg: ASbGncseEVDvyb5JCKVQHBZuqb3RojetOWFmPkcnEsXQul62TmzRGkSRdxhKk6COXHp EH1aL9iz88p6bGJPrlvmlTaYVtwXxGMgQ2HkXjUDDlGvD9LV7ep9U+zr8VxHaPCNwOOhBwOskrH VBpKThr6Geh0eabmEnpUj/WpxABLijvOKhSXqRlxrk7Tc5byk0UzRIBv61FFAFW0T96gy8X0cJO IdDudK5Oqr/I1G/J1i2hj3C0WR5YU0tZF5xiDtvy3wBMgF5xnVr1kjnOOEQInMm+c9iV9QFXgtj A38S27n8sMBvYdhvVLC5Ce4b+KLEZmbq3T2voYYukf3hMJ9usYHtEnWG X-Google-Smtp-Source: AGHT+IE0hJOzY7LJtTMTbdjEazmpPBmb/gf43dyCP5jRg9hLuZEXiN8v7yfIQF4Wwppejxa8WDnCdw== X-Received: by 2002:a5d:5f91:0:b0:3a4:f8fa:9c94 with SMTP id ffacd0b85a97d-3a558aad4efmr1275728f8f.13.1749626879627; Wed, 11 Jun 2025 00:27:59 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3994:acce:fbc8:2f34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532463e11sm14572552f8f.90.2025.06.11.00.27.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 00:27:58 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 11 Jun 2025 09:27:52 +0200 Subject: [PATCH 1/5] pinctrl: renesas: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-1-ad169a794ef0@linaro.org> References: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-0-ad169a794ef0@linaro.org> In-Reply-To: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-0-ad169a794ef0@linaro.org> To: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski Cc: linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1383; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=EF2NoiLrO5mFY3b4LKo/6fs7QDwtljXgSNhM7dbgzb4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSS/8hfi7DIiO6cnBLKJaBzV0cLclvzDD2zI/C 1pgZlb8eh+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEkv/AAKCRARpy6gFHHX cgN+D/9yKqC26tQL2PDABM3NvnjwOYV04jiZL7pXY60pHNF4z7Q4f38JGIhZ5D6vVxE9Dd/OKl7 tnEBx/4h0k5qPwLlgOiudnPZm8N8Jaiwf7ceGomrAX6lVjDbR3kj6eYv3OWRHXMz9gUCBE4HFG9 KFMC/N+cMx/nOX45dGlGewHJ8VljyTjWpkt2/X6XtgeZtIzBFHWYW3Wb7NJtGZRO7I4O8W/fSMR PkVphbCdRXuO0daeV/zTooc8kRgxfrRtEou/53hFGnnlZlUEGg9Z+koPw2lIX0xHelSW6mzkABv d/Gc0BSLyEnj6RuT2Wnnh5nSiWnLB5rTBLY9AkddadsMKDaVb0fx5FaImn52VkDUoC+XH+7eDNW lJHRCFneMyLJn+mJdUXOnJOxvsADC4bNsdtc4MXZL3UBOvvYyXXRGyY1SoLXhyFLYUBALbedIHW HM6WNUjs3XJqP8jqzYP9YjUtbRFN/1H0DpBJXuvRq+JoEDvOh9oDe/QqMSRW9V+xIl4UpZavlA8 vEXem45p9khNG0nE0WmHYIXQ5/AcSGQqRHOORf2HN0QdTLnm1x0fa3KIhx9cTEnROvuEJAtkAE/ 52C2bdklgNhjE3FVcMxtsiIP9jPw4cUF1BCf7vaN1cDrlUuJGo24xbbjQFX+pxpTbvX+sG/cTDh Uob1rONI6jG7HKA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/renesas/gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/renesas/gpio.c b/drivers/pinctrl/renesas/gpio.c index a5136dacaaf212ee711262c599f3e273b01b6670..8efbdc1b0078c3bdea3064b31422f8e60698ef49 100644 --- a/drivers/pinctrl/renesas/gpio.c +++ b/drivers/pinctrl/renesas/gpio.c @@ -189,9 +189,11 @@ static int gpio_pin_get(struct gpio_chip *gc, unsigned offset) return (gpio_read_data_reg(chip, reg->info) >> pos) & 1; } -static void gpio_pin_set(struct gpio_chip *gc, unsigned offset, int value) +static int gpio_pin_set(struct gpio_chip *gc, unsigned int offset, int value) { gpio_pin_set_value(gpiochip_get_data(gc), offset, value); + + return 0; } static int gpio_pin_to_irq(struct gpio_chip *gc, unsigned offset) @@ -232,7 +234,7 @@ static int gpio_pin_setup(struct sh_pfc_chip *chip) gc->direction_input = gpio_pin_direction_input; gc->get = gpio_pin_get; gc->direction_output = gpio_pin_direction_output; - gc->set = gpio_pin_set; + gc->set_rv = gpio_pin_set; gc->to_irq = gpio_pin_to_irq; gc->label = pfc->info->name; From patchwork Wed Jun 11 07:27:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 896359 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2663230BD8 for ; Wed, 11 Jun 2025 07:28:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749626884; cv=none; b=YKHbAAZGFVUu+8MKKmyU6uofxceLldVYt1SJ2oiujKulXFQlfYO2QhzlsfCnlRmoFsFIOmCsfAraWPXaAN2Py9zA8au/hRlLhMUVbEAntJcULu1X+Ytlw8Vs+Cssc0GGuHxbFmg9s5kQiVacg9ceV/HoYRPPfP4Ca1esqi5pKGo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749626884; c=relaxed/simple; bh=PouxT8/wcx9ILpmSgxCQsoaBvGqYtSxNMtkiY0xxIg8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f2UPau1lBLsePlkKFhcz+jzySrTZbgnzhI3mUEphkC0670wW7vhao3gLXhURWe/sEaH+uYhJGnZGZNtr7w4oVInbpvqw9auhEB4U2M50a7LEx9ZuVcWcSquVgm5s/F1f3CqqboAaOKhLPGU/my/bYzqblnhK94dMg4XqA8iChjM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=hgK24EF0; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="hgK24EF0" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3a365a6804eso3875229f8f.3 for ; Wed, 11 Jun 2025 00:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749626881; x=1750231681; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hDQFUaBpcFdo7BAW9qKIWqwPursqxpHgccCnfB4M+2g=; b=hgK24EF0RsEUdXBpvRzgiQrkEMKiMnKpsipXzNNcD/ISCBNnebUjErKbgQ3EoqkRfp TWU6VSVMIbiWH6kFPIILKxwbJgISB1eOUe4OOUBmKlcj4V2PcQuF71qkNFxstn8nZytp JUuWykBYT36uPNlw+/3WFgVUsHz4PgfD/5GLGdekgrzoD7NMIqJe6+xcXAJ5mikIT508 HEP27zm8lezs4KtrTJJdW586tYDaxqQEsbjqTUBDGi6j7EDSOEu+DlzjRFMS0s1D2I0R ZV5+AaeOPjaKGaxuN366orgGEKWTtFUCwVAEBQwJ90+dfVX0sNxzLNjPOJnsIrBntZHc zq4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749626881; x=1750231681; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hDQFUaBpcFdo7BAW9qKIWqwPursqxpHgccCnfB4M+2g=; b=OhmhlxNP+DDFQo9nrE5HcUghccWoKWJl3tU2e4UwfgHmvC6aIVZtj4gY4ycNMZintk W7K8qt1BQoKdiEP2XKnik174U+zg2GKbyhQMuv7d/y05epNI/c7m6kQiQFsYWuueezAA smOPPr1W7PBaF/dOgGejwAfA9ff2P3il89ozdGRuqXSfqt2CWRHa4cDXSOYqV+KdfFRN ozpdb6V49olsCUSFSzKV9tbfTanGpd/qIY7GckJyt1aZUucCYoL2qa4jhQFu9BZcjffx ZxqapYZbrL6LyB8kGS72/q+LDDbkSY67nvXrvUAchcZ776sHWm2NMBmGZHhGm8Fy1dj9 bgLQ== X-Forwarded-Encrypted: i=1; AJvYcCVNGcOq+5m8diqVXq7IoADYLUHhq6EMImtsKLQi+4tHJhLzTTLLc4o2VQgV3RIOKRNZsEV1fA/0/tha@vger.kernel.org X-Gm-Message-State: AOJu0Yz4LqUneNBTV4zvmdxmOe3a+f+q/NgV4/lmCyjTRvhn7cinv3sE kk3//iVXA0O49nTGs4TMVzkTw8WBYyklMJQaYi+BoPdpCRzw2CgkIYlW8BxMHCPuJlA= X-Gm-Gg: ASbGncvqY579p5ySgPuZE9sUHTkZ3+8tBaE+Bl0hnS/pbuFAButqRZwCNizz/lJVGJT mBqexWG4bSxM38r8VuO474dvbCr2L55hk6aHrCg7bqIKL8ieC5FYEFUjseLV8RjNwb3RaYkunQP EXc7dWBRyYfHrSS+rEnqd7h2Mb7N8U6/ucQep+GOGChTQ6Ahis3nzbrHNBrkvnJ7ROF98X17OtA yYXIaUztHWPOEKlrwjzgq3I0No/q3xcxuVIDwAv5/Rx3UUy7x10qQ5ghVeihu4tPMQQRhG2VqCZ HvLBSNc2bOFOOkKPqSFPK59xh1IM3u7qjKZ5GPybR/8wN/GhihQncGy0 X-Google-Smtp-Source: AGHT+IGiG3fUAwJmIC1zqW77bGn7Xb/Gq/+0n8hUHLUeOeWmdrObhllcG2HUigHyXHPea5oo+7hzkw== X-Received: by 2002:a05:6000:4284:b0:3a0:b308:8427 with SMTP id ffacd0b85a97d-3a5586cb11fmr1345439f8f.37.1749626880804; Wed, 11 Jun 2025 00:28:00 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3994:acce:fbc8:2f34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532463e11sm14572552f8f.90.2025.06.11.00.27.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 00:27:59 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 11 Jun 2025 09:27:53 +0200 Subject: [PATCH 2/5] pinctrl: rzg2l: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-2-ad169a794ef0@linaro.org> References: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-0-ad169a794ef0@linaro.org> In-Reply-To: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-0-ad169a794ef0@linaro.org> To: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski Cc: linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1719; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=3MTlx7bJZQmY6Yu79zWoCYOs6t3uBUPc+M/VIDm8O/I=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSS/8wL1M+vhrKvglFzNWwTSc2zr2YkUb4nqEO U9Vdlv+7m+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEkv/AAKCRARpy6gFHHX cqv+D/4g+kmGgMV5yOgvtDSnqNsCXfU7NI0BaNvcapUfhMWzXh9jSOsDHaFIZbyq+r3NA9/jjlE QO9uYscsRYFCYMZdIB4Fh9TtXQ0DroAsXX4iAKOFn6DIMNgxgKYTo/MJd8kKBipHsQFlgrCnQIj bJyXgXYOMsJxCUhj7D743jsxnHmV9rwTg85ixE7S8XbEHOWYFzx41DGnBOs/smbHyVIlWDCrbpA RJhw1BU2rPVNnMvw99gPos3sItuZQGWWTkrmt/gKkj9EIHdlHyjXAgfZvkLE8AQjpOEQuUT+Ytf /+Q1QWnZ3/8LWlEsH55HohpNcFdqYj99fkNQSyL4ocWZAmn9U70alxVUmfAo+gMxyYVma8UrtdO EvmcyQa06BU3KZUPTZFY8dMAqy3iL9cHk0MNxeQzwohKJoiuHLEvnvOlo02/ZQp+SIsvPyqrJhr rOHbSsMu/r7RkG1+hu1lbVnkiwUGP7aEbPDH1xr0rCOlYH3l7G2dnkBUWJZWx69cqVEvD5la1no P9q3BptGw0pe8jYJ/+IDyyrE5dVqnd/8zoVAnstC/+UHZH3EgT+5Oo31HKwT/UJebdobrHTm8oK oIHsaiNlHoeTCpepY8HL5mrV0dYJz/iQiB74/GqVrJcDQAg9RA2rh3D+bbBxP1sWTIAXx4iS1GI m9qGJtYhUH3UwhQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c index 78fa08ff0faa821d217c241aea116b0d6572380e..59c32a0d87f19b9ed62aadb698dfb1793882f91a 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -1758,8 +1758,8 @@ static int rzg2l_gpio_direction_input(struct gpio_chip *chip, return 0; } -static void rzg2l_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int rzg2l_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct rzg2l_pinctrl *pctrl = gpiochip_get_data(chip); const struct pinctrl_pin_desc *pin_desc = &pctrl->desc.pins[offset]; @@ -1779,6 +1779,8 @@ static void rzg2l_gpio_set(struct gpio_chip *chip, unsigned int offset, writeb(reg8 & ~BIT(bit), pctrl->base + P(off)); spin_unlock_irqrestore(&pctrl->lock, flags); + + return 0; } static int rzg2l_gpio_direction_output(struct gpio_chip *chip, @@ -2788,7 +2790,7 @@ static int rzg2l_gpio_register(struct rzg2l_pinctrl *pctrl) chip->direction_input = rzg2l_gpio_direction_input; chip->direction_output = rzg2l_gpio_direction_output; chip->get = rzg2l_gpio_get; - chip->set = rzg2l_gpio_set; + chip->set_rv = rzg2l_gpio_set; chip->label = name; chip->parent = pctrl->dev; chip->owner = THIS_MODULE; From patchwork Wed Jun 11 07:27:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 895617 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BA7323183F for ; Wed, 11 Jun 2025 07:28:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749626885; cv=none; b=swfZmY1v6o1DhPkMTgYwekzxW4roM6ptRzB1QP2MdboysFTOdWUD8d6CGL4swxAQ7Aq2GmSf+/59yDeXQ7UIHbD0BEQ2I00mGOUUZO7+O8i/m8pfF77vme9pQjR6w72kjTqwvL6pqAT+GNyMHanr6sB0MzoRUDdQgTErC45mKXU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749626885; c=relaxed/simple; bh=ZmzFKZJkP78DlEuTQx92TLfbg/qZJDAB88ySq06CL5I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X9MFkt4C+liNfvQolFt2GB6WsuVlIEoDyElWSVlFShKIJ6rxTG+mheUaWfm/vq5cgYiaMGG2GG6SeglttQOPVKpTJN25e3trwE0ODeiclpCrdKInJplS6977qxMIXP1g6ZcGUQ2fsBUEX2dIqu1hk8cihkzUhlSnwc7dZpuhyTs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=C4q8Cb/X; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="C4q8Cb/X" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a531fcaa05so2662624f8f.3 for ; Wed, 11 Jun 2025 00:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749626882; x=1750231682; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5b7KiJcZC38GOmum8tkvCWEpaNDs2GuKtb4NqvqE9+Y=; b=C4q8Cb/XWF8hHYMZqmgGAJ34rA+IAKjDUfaYzzjJ+Ryq/P2Z0Yc7FZsme9dznt6cRn XAaGcEDkpK8dEnAbpxAyJIB4LkHZqKL3QD3IA68q6JtaRd7d8Z7Bj1RKgXU0mxIJPbGl FuUkRSiSo5UwIPwrIE4PifVDuojhYunOu19L8m44viH0FryKeglq679d7KSyCqw9dXks TxubCvo09oTjnfSv5E44/z1nDEyyfgtOYrLOqrKmZPp57HGyJuiD7d5RU4Uw9at1nZQL FtKauP9aATuU3c42CP8mUIhUQd5kAlIHrKav7SN/+RkmmOO1UbyFeTjtHofmAXvPGsUn iD2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749626882; x=1750231682; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5b7KiJcZC38GOmum8tkvCWEpaNDs2GuKtb4NqvqE9+Y=; b=e8qdLmNzudz4tP69T0CTQSLRkWs9itacXzEq/bhjj8DlA6Y4AFu3xX/c183gWpzzCM 0Im3N1xptejkUW9EU/ovrSogB1P+BECjt/fTzTOULKU2vr0s0zcLuFwdmyb4fsG8U6hi +mWW1XuDtzbJEZtQtbks3l9dbOxBVzFJYunh9vYFULbpi7N7Tyj9J7paa200E8ulvtf6 TbQHHAn/JER8NwfMh8emr4exETppS9MNuIRnH/TpQH70kY5YL21WUPDRPYxYQH/ZmZK7 PcMIfLBqWwefXMQbt/M7Aw8/B5PPns7RaUeFZgw1qeLYjD/M286Xg8MJB+L1cpDIsGgi 7nFQ== X-Forwarded-Encrypted: i=1; AJvYcCXSS+FRoVMN3CudsL6To2PW+RCusv7jyjTfEaXrICMtGGevs/pcRhTxRdY7NR2aEsgQbomEzxHNr8c/@vger.kernel.org X-Gm-Message-State: AOJu0YwYP63eSRSbuhFuspoZNl91AkKzXATFkJ4yh8TImgLR/27qBUWK dn9JvjXnYSizP9oXrssbM63IhSna2T5suvqJs2ZNbWPRxN9eA7td/u7rTQp4AwMNfuk= X-Gm-Gg: ASbGncv8tG9qoTv5Mg3dR7CF2K7JOwtoAUI6daCT2LNovoc3Bv2nwH9YiEDkzqYhr4U WLcM52QYV2rPkRUTzUImb/gS1G2ZZLR+FlHwV8x3Pro1d0IA93u6VGhjw9vyHOsqXhgJewIPuJa tGgT6jQ/zea/LxVbjfxNKIe484lw7n9I3mBMz3KiqVsAsJx/b5krN6YgXJ3CUvU0BVkOFk1OhZj lci0dmCl2Dqc4tjaSUFmBjTHwtJ5fDzFMLY9ctdsRUTbCbp7BoDeY9o9ty+xhXYOphgLYJnLtFp meT7aldFoFZd1Ni53WnR6VLL130BEqDoFdHmTUMC0Hdmu/dFuY+iB5gbFUB0RRY5Igk= X-Google-Smtp-Source: AGHT+IHo+a/giD3KOuRSI6Txn7wgTN3MjofXYie1Hm/9oQ70BP5UcGVJlwTt4NkvED2pEWah9gQSTg== X-Received: by 2002:a05:6000:290a:b0:3a4:eeeb:7e76 with SMTP id ffacd0b85a97d-3a558aa5ad4mr1345576f8f.9.1749626881856; Wed, 11 Jun 2025 00:28:01 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3994:acce:fbc8:2f34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532463e11sm14572552f8f.90.2025.06.11.00.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 00:28:01 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 11 Jun 2025 09:27:54 +0200 Subject: [PATCH 3/5] pinctrl: rza1: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-3-ad169a794ef0@linaro.org> References: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-0-ad169a794ef0@linaro.org> In-Reply-To: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-0-ad169a794ef0@linaro.org> To: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski Cc: linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1492; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=pP/oNTY+jKTjqoh8Y3FwDaZwU+GC9Jsw4vp0KbfKuMw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSS/9w6ivG0bcYQcQVi816zZdcCnUI93QCAxvw h4chHAyu4KJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEkv/QAKCRARpy6gFHHX ci0zEADhc7hf79+f1Kg51T7M/9zj+dlodBnMUOaB7rwbfS1K72grf5h2K44YI8laelqcrumcbTp lIGha3HpMAAf0zCWYQWMHQcYHLDpg7zGC0z2Ed9MTEfEY6Pqrpmm5jzy0f/rzl1o6l0PCq8lJCI Qbs5AqutuHK7ltEenIJvZmA+GQhCYzmQK8ugAq6Dsl/nwYw8XlcVgkBofUeJGsy7oKplJ9djW82 RiRHqCokJ8gRug/7VPTFhBc74F6wKuALnLfWobCq/UzYjB34W/aX6yYAX7Nf9uEbqfhX/TGVPd9 1V52If7RrLaASxAGhqaEsAUSrShjnb1Lh4yGt0TB8a5fleOyM3c4Zije7w4hCEURfrP64kDXf8x ywaUKZP2TNs6BFslIy2wpsiFKLCj1MTGcE9uPAJxGLWCex5Z1Ii+MEYqNlyFf5xyJeUTVwRscLX qFfwP0ciwhEV8J3C6h73627f4TGENwseJm70QvwNpmuLAi9tErK0a6MVQpbSWcu9U2NxmF/J5bK E3qPx1KdC2Y440XQKfM4sLg/rdeZ9j1RmNt4a01245WDD+W5fFEn0Fqq7ehjOhDAP4TbWS+7e9A GP4y/vs4GhfEDy0TFXk1wCEAtQpqwkE4CVQmM9UYR3mtzGh5l2/DZYQVKmyx+jK9cSS6asrvCbq UBTgONolXmnUUyg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/renesas/pinctrl-rza1.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rza1.c b/drivers/pinctrl/renesas/pinctrl-rza1.c index b1058504e0bb3eb4dae8ac5b0eb848eeaeb907af..b0ba1d836ca822833416f809df570bf459c1298b 100644 --- a/drivers/pinctrl/renesas/pinctrl-rza1.c +++ b/drivers/pinctrl/renesas/pinctrl-rza1.c @@ -830,12 +830,14 @@ static int rza1_gpio_get(struct gpio_chip *chip, unsigned int gpio) return rza1_pin_get(port, gpio); } -static void rza1_gpio_set(struct gpio_chip *chip, unsigned int gpio, - int value) +static int rza1_gpio_set(struct gpio_chip *chip, unsigned int gpio, + int value) { struct rza1_port *port = gpiochip_get_data(chip); rza1_pin_set(port, gpio, value); + + return 0; } static const struct gpio_chip rza1_gpiochip_template = { @@ -845,7 +847,7 @@ static const struct gpio_chip rza1_gpiochip_template = { .direction_input = rza1_gpio_direction_input, .direction_output = rza1_gpio_direction_output, .get = rza1_gpio_get, - .set = rza1_gpio_set, + .set_rv = rza1_gpio_set, }; /* ---------------------------------------------------------------------------- * pinctrl operations From patchwork Wed Jun 11 07:27:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 896358 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F0D8233726 for ; Wed, 11 Jun 2025 07:28:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749626886; cv=none; b=SHeoUh7kS/BIzrBHjNf5LWWCVCJQ2I8QDmj2smUDBMqUsLPVEzhntXqkYFFMlvr8t3YLNQBW2Y/x+JEnzxSBtCeoM/VufvZdcNWRL8YJ5j5eFIkHj7Mrhn+imi6rHgx3kF/CGv/wCg/JjlbgSW4XwTGZjZ8X0ivJa7a9RiwNsyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749626886; c=relaxed/simple; bh=ZMckEftaur0awqo/yKW4VecLuHYo3Jj+Dpx2jIF7DDQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=H2tI7ENMVNM2XfGsnJMtZN0l8ztkBhc538Ye1+vmTgdeA4VAHjUeJ9Ra4CsgDUOYMrvYqdh0SNk7viV9Pk+OA+72XZozCxnTmsZx4Ctv5bx22ys5MphHJVK37CfzV1D9Rn34rLYDwUgwuJrQcorgpZDsC2oFPK4MRAAQMcOdpoQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=efTa7A1g; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="efTa7A1g" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-451d41e1ad1so50416945e9.1 for ; Wed, 11 Jun 2025 00:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749626883; x=1750231683; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fz5ZJtTWraCxO84eZToYsMCR6vkVrOOU3h2l01GftKA=; b=efTa7A1gXjZbLJ7NIyHtT8ZrBKckenDEJsn/wl27wBQM1eKPmT7cncdgrfoEu1/WBt 3jbb/1aHuX0xF1M5CHCE8eOX9PMlkONRDwhW7E4+9GWvGySIHkQUQiS0HSeV/GI4IlVS IuvPlEu4CA1ex0lNMLv/1Nj+xI7B8eIZ1SvwIV/bULxTtIx2Yvj8mlHZIu9ToJYQWVv1 N+Rgc13ycgWlAo4Lmgy3m6DtROf4Cvz9qOnITAWaXzN6B8DkqM5JdRXZPhn8Izi9E+6r 7gxQbGATN6BO9GORHCzP1fK3EVLQQUIF7Lz20L3el/kysfZp4S6rMGmWJKACDEiTQo69 SYgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749626883; x=1750231683; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fz5ZJtTWraCxO84eZToYsMCR6vkVrOOU3h2l01GftKA=; b=rlthZSAQqiB0paLRuFfYOOMTsniu/4+5zG7kuszzn4WzgiSgybtrI+f14laFDCtJGa tT94lyDiB6txa9Z13lG4LAWRjHrA4PI+DTsB2upCBwzqJDDRVmA4vFjjH4CqibVJ1/pX 9i3tYhTxWDpVgizJVAG1EBJ0RKBWUU+6B7ZgMf54N9R1wgpjc2C8BqrMgSaY6TzSVYHS sfXXRuDpnpXXaHGw0/xjwmB6TED0tVVDmMMQII9FSzMKRLLiKYRLuoh6jqIqzBhPM2Ak /s8r/r+MVyVSXo5D/MnvaAs84g66jFuvJIt89x1T5KDKZ5lazSkoB/CcW10iN2EwI/wo monw== X-Forwarded-Encrypted: i=1; AJvYcCWsSdsETvTgIqKDiIMq8bvqJMVJoSj/gPO1Sn15a0g4s5VJABFH8CtiukH0umaa6wt2RLfGXXrBsW7o@vger.kernel.org X-Gm-Message-State: AOJu0Yyi+Q8iWyqVwdsFQDowpOOekGrl3y8KtZ1d9LLsqCSZuPizZPiz 0Lqvrh4DzgkV76SF/6ed9jGIPvRwQBnTT2eK3qHOdScruiUndytmGLhLB9cDWaT4rhk= X-Gm-Gg: ASbGnct12WLwmMdYNvqz6BRN+1OsZh6rqfZ1ZGhggU17cTCsGYApe+STrMc5xstaJ08 1ieyRUP6d3aLcYYcn7ssvcWjzvxNnjFUaGKHOs1sy/1NXt/kVoTzJiTi+ruWi6Tqu1434nEH93s X/6Mz211I2ecG6GDl19a1X2gZBEFNDxdltCW6dibd2hs93b0YtsZxyNFXeMKrmuobYOT4EG9KtG FqzCltFJjPkyVBM0OiZAo4PMkZDPrtY/Pn/PpVAx0E7k3UOYjqdGsSk7svsMbJLCkStR6m4ZSg8 IrCa7GwxXb1ZyBT7LVPNhXiIC7T1dI9dQtH7bv845i7tuEiU9LEAdWzC X-Google-Smtp-Source: AGHT+IHqWcTXTC99slfypNY0J9/R51fSuHI2YW+gpFEROt5HmX5Uek+3vp75fg822snEUAb4UYU7yQ== X-Received: by 2002:a05:600c:154c:b0:43c:ec4c:25b4 with SMTP id 5b1f17b1804b1-453248b0ee1mr19824435e9.10.1749626882786; Wed, 11 Jun 2025 00:28:02 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3994:acce:fbc8:2f34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532463e11sm14572552f8f.90.2025.06.11.00.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 00:28:02 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 11 Jun 2025 09:27:55 +0200 Subject: [PATCH 4/5] pinctrl: rzv2m: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-4-ad169a794ef0@linaro.org> References: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-0-ad169a794ef0@linaro.org> In-Reply-To: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-0-ad169a794ef0@linaro.org> To: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski Cc: linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1593; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=4WbKIM0oy4jYhp0GxcNLcfPlrGEmjN+KK2bG6xszgaA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSS/94JhCtS4qT2pc9oKKMLm7V6mr5W1LPvI+L HrCCwC4EgWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEkv/QAKCRARpy6gFHHX cg68EADPjlzfffAjS9JziCwkMELfjtNZrm68yRRW4u6BaMBuFpQ7bmviRD7VISXRGQ3eRyTlgRu 2eJvyX8g6hrCG0RVFyHG7TzWTk5gReiV7oAl1fK7ufi+m3hSIn08JEP7tv9ybZYJ4Qhnr4iYNSm GpXH4eXdmCPhQ2m4QnYWItQTGv5b25tLfYYJc39PJs8y/oHBGvyDOxCzAdu2KSP3sbIG1KKzuva sQPZngx9vz8JyPfLVCJrwhkbhmQoowNzJxyt78dE7AYBMBmbIQLhlolZkgkWMZ9nhvNpsSBPLwW G5a5aiIDMrCTsq33Yy3S+sXf7z1pJO5h/p1D9cAXoKLEhc+ox8VbaLa2O7m5Dy8KocrnbgwQBBw A8LOBOxQk4Ge5uhdiY8CEKm+9VkiFCkoTK2NJV/Lg3jQxDlNJQ22AucvH9T2rRar73KS/gUE4Z6 CQFxrRdHWbFcpBUU6dwLh1YgjrZA+4jhmjHrckjgXMHqWeexo75Ld6RuYrQAX1uNZpIU8EHHt6t OVTxj1Pp7FsBZG37ZU4+apTO7hvzn97y3I6aAs/1rJu5bvXf7faLk902BCnB+I6AqJMWTU1sBon wPdEjA+izWVPoNVMg33DatFFsRkjOd5ZSRir+jRm+sU2aIF3uztPu1XD/iV8eQCf2i+lmJA3OIs W8aaDT/xF26HjoQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/renesas/pinctrl-rzv2m.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rzv2m.c b/drivers/pinctrl/renesas/pinctrl-rzv2m.c index 8c7169db4fcce6144d26b963dfd3b11bacd66d80..a17b68b4c466e2ca91cb26a713a088e309d5e167 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzv2m.c +++ b/drivers/pinctrl/renesas/pinctrl-rzv2m.c @@ -790,14 +790,16 @@ static int rzv2m_gpio_direction_input(struct gpio_chip *chip, return 0; } -static void rzv2m_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int rzv2m_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct rzv2m_pinctrl *pctrl = gpiochip_get_data(chip); u32 port = RZV2M_PIN_ID_TO_PORT(offset); u8 bit = RZV2M_PIN_ID_TO_PIN(offset); rzv2m_writel_we(pctrl->base + DO(port), bit, !!value); + + return 0; } static int rzv2m_gpio_direction_output(struct gpio_chip *chip, @@ -955,7 +957,7 @@ static int rzv2m_gpio_register(struct rzv2m_pinctrl *pctrl) chip->direction_input = rzv2m_gpio_direction_input; chip->direction_output = rzv2m_gpio_direction_output; chip->get = rzv2m_gpio_get; - chip->set = rzv2m_gpio_set; + chip->set_rv = rzv2m_gpio_set; chip->label = name; chip->parent = pctrl->dev; chip->owner = THIS_MODULE; From patchwork Wed Jun 11 07:27:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 895616 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AB67233D85 for ; Wed, 11 Jun 2025 07:28:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749626887; cv=none; b=YbLgfKNramCMayoCog/jbyoZsA3CJwH4T5hTUnOAEJrxVc4A2h1DE/lD8UT2D2ecG3SobXNYbuEm0Sw4bu92W4WSCNwSAuK20f7WMR46IIx1jaMLu1V3cgP/9/2abMnMEVp2+yjMRTs0LqDK4HB1y9kO3e4BCMixE5LfmvIsIy8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749626887; c=relaxed/simple; bh=yVmzGgYzPpsvarSqDW2/PP372tTPQpqVJ+GOc/oGKWM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PuQ6IClMPGIGUFzQOHkgm70cKDp3jgxGgTiEgYPzNKXXKmIhrLG4eD6j6S6kprCL+9rqQAqz8Q5OwAr98kNOz7uYEyc5SZBzjIrn+aqPye33CPUokCg/BAI+bWriW98p6MkItmQUXV9CD2q03uBCy4FcBKhQnLuOOcysx8mbKs4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=t2tscF6Q; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="t2tscF6Q" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a35c894313so5543421f8f.2 for ; Wed, 11 Jun 2025 00:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749626883; x=1750231683; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Y3EhQp70qH3zaX+UEuYmCaMSBeRCwsSI90EFC2bDZhw=; b=t2tscF6QXgaah1kmFa5Gaitt/k4Zuv3HHVjFwfIbRtISTnLEUHUFMrprgkI1MGZpBM Iw7RDDj7X98S21XHN2cTpi8vRV9gAkUvXZJLkOfyfVh2+491R3ysX+vIJrYKAB1Jp6xy 0TJHCCzc9dQnBeT4b6uBFbGNRs/+55Bq0H9hsQcRGfBjC1eKxBXdkZdUwknC5OF3OJCS xTQuNILqKbOGOPY4uIO+kzgs+u9m1YLuFgoAU7gNH3yMJL1+6Mdkj81iYjrJ0h4rCZYS yrCzNry22rQu21Pzp0o4QNdluxS0QRI/JomArMm11rVlnhvILfGBCEu/CS5PQzekdnyJ 8KwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749626883; x=1750231683; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y3EhQp70qH3zaX+UEuYmCaMSBeRCwsSI90EFC2bDZhw=; b=B/R27uqE8rDrzOHcqNvp9s4RtVyohFtYI3NVXDJzWnOT1YszwsVKs1S9ycgOTDRyKQ 88+waoCMoP/5o1Zn9rPA74SyKKTuaAWsQCLWtRwBiBGgMsodGCMnrPxjjP3F27PeYS3U 65KAvdCFaj8sqnYBzXq+J46Hvxw8jjmZxeA8Ta4e9QnmsVodvNUdAGfbU7Sng251PVDK N0NgQad7UZxrWgwKyIFxsuFH+Bwzn7cEWMiKaji40SgCywhdlL8UU3A4VtkRpdMvsHya oho7TV/GIPpdcAtHW4VDqCRjOydr2AKbS2qwuYtcd6vjlgKAZJIty9RNunN8WqYuDEai MJ8g== X-Forwarded-Encrypted: i=1; AJvYcCXwyEKd+QFtEWclJj8AHsWGv+kMxe4JtfdmloTcJYwO5JNaAzO0p0EfI83ehT/+PvAlC5MdZjgJbHU4@vger.kernel.org X-Gm-Message-State: AOJu0Yzslm7OtyYNs+sSP65lEz6dedLIwzF0Yawy11eT2aYOSz5hE/GH B2OONXJOAPtGxJOin9PJkVJztby7B4ZNBcWyjZGa3by5JJdLhELUYs/sOovRAbRYAwA= X-Gm-Gg: ASbGncuzCY55bYZlv4NcddQZDeD5ci/mPqFaSONmOmuGGhOutreLpEz0ZJRcHwaifMq WwBPGArZJa3D7XN7aXICVf95YRUfFniGTW+ogSqgDW5qZ0EJQHWV+vS4Dn275DaAlfgc2TseLaC HmFDtCPxq9EysyFGBlz/whZoJnvz1nNqkqagJ2f3nBChI/2fQFtEmPaatfzASJN6F+DC1Rea+30 YsZ3Yy3lJBafNKJFYUZCNSRL1x3CVCd5Gk7tjUqLlvbBNZmkcd1+X/C7njQVtEJazgbjv6ds+FW 3Z8M6NdmiU6WWm2MTK3Q9ifR5imDMesqroDRGiwYaFtF/xhVy87+2Dqfp1YyVRjy83I= X-Google-Smtp-Source: AGHT+IGCOfI9OsABR6ZwJzn5YCmjzJfCM3HRsAqGAD69hOl0O0+GwNKUhrrHE4WyoxHmo7aiXOLXCw== X-Received: by 2002:a5d:64ca:0:b0:3a4:d0dc:184f with SMTP id ffacd0b85a97d-3a558a1a8b4mr1463911f8f.39.1749626883562; Wed, 11 Jun 2025 00:28:03 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3994:acce:fbc8:2f34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532463e11sm14572552f8f.90.2025.06.11.00.28.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 00:28:03 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 11 Jun 2025 09:27:56 +0200 Subject: [PATCH 5/5] pinctrl: rza2: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-5-ad169a794ef0@linaro.org> References: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-0-ad169a794ef0@linaro.org> In-Reply-To: <20250611-gpiochip-set-rv-pinctrl-renesas-v1-0-ad169a794ef0@linaro.org> To: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski Cc: linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1644; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=W1QNIGjpDMxA0+ez52KTCBTigMpTmRu9JngqOUaR2S4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSS/9gl/0jI3xDL7vGI3DKAGtiuipeoZWlFZtN fATdyQNL6+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEkv/QAKCRARpy6gFHHX chxwD/0QhzQJG6sxgN5aq0MeNzSbGXVbei54QA12GRaXDpZVuZJGjmsgVbjSM+gOXSYy1WxiGru sKq5AlY54se7FKoosLZBKtsyMZoV4a41c3XSKTBTWx3N9vZ/jJHVD4LSVVSuFtAGiyv37wnLlsI ze6JXWKUfOEDiNCRO0KewzsodL9XVjn9Ac1S4nhlW+ZagfOWe+Znt+Mokvjgk41+7MBHh2JVVLq CFpDDrlZOcip1Q7eB8eeNaqU63k6lGas/SIQ0WTAX42GN+GWFM8ZmNdDmaXWKyk8Yv1GCC6LiS5 ZxicBUBQsYxl1BUx8xHU31/P+ZvzF4lo40VYpXzt/9UM0Gdj2w3GCNN2j/rm95R+lmx5B2xUAwd AOCsWIpXzewy/rKMeBrb3p6FGWDvULwRMSRWRc2M/guKRqZGhWgUVaIktSpOyyge6qrBn8Ob+0H lPmxDg81ZWiCE2dy8Y8jDnLizERV8FLXZ2EcQKk/yOaUcNB11ZKUp8xNFMysvO5Py+3OVIKypH7 s+tCYPBsqrda9D3HTPGXhLi+6Hcjvw2Qb85reD4hhckQG95m0szQlUnbjcX+WY5csizvSamiCZU 5oPJzly0uq345zi8uML+VzVMKjBhtLEAQqEOia266czsbA15mxbLjbPBK9TraviasNUtRuR/atG D6RIJz0zBD0KUlQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Wolfram Sang --- drivers/pinctrl/renesas/pinctrl-rza2.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rza2.c b/drivers/pinctrl/renesas/pinctrl-rza2.c index 3b58129638500eef61058e43e49e6f39fde3cb4e..1ada8852d4f1258bc955acb044e99c748d250c41 100644 --- a/drivers/pinctrl/renesas/pinctrl-rza2.c +++ b/drivers/pinctrl/renesas/pinctrl-rza2.c @@ -172,8 +172,8 @@ static int rza2_chip_get(struct gpio_chip *chip, unsigned int offset) return !!(readb(priv->base + RZA2_PIDR(port)) & BIT(pin)); } -static void rza2_chip_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int rza2_chip_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct rza2_pinctrl_priv *priv = gpiochip_get_data(chip); u8 port = RZA2_PIN_ID_TO_PORT(offset); @@ -188,6 +188,8 @@ static void rza2_chip_set(struct gpio_chip *chip, unsigned int offset, new_value &= ~BIT(pin); writeb(new_value, priv->base + RZA2_PODR(port)); + + return 0; } static int rza2_chip_direction_output(struct gpio_chip *chip, @@ -236,7 +238,7 @@ static struct gpio_chip chip = { .direction_input = rza2_chip_direction_input, .direction_output = rza2_chip_direction_output, .get = rza2_chip_get, - .set = rza2_chip_set, + .set_rv = rza2_chip_set, }; static int rza2_gpio_register(struct rza2_pinctrl_priv *priv)