From patchwork Thu Jun 12 20:11:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 895767 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A184C2D543F; Thu, 12 Jun 2025 20:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749759209; cv=none; b=mIwJQSwb3EWaDL5vSrmeDa4bCAKR0nAOBdDdJrgA6ITKCheuZTCBoPm1Q9tY/ed2G2iiO8Yr6H6iqEViqLC+F3VnioYvQvXv3gHguMrjAYg+iTu5+fok9rD+La5kEz/BhGFHi01r5SbwxDAuGCxvCEjKPqIYGdty33M1qJtbxw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749759209; c=relaxed/simple; bh=jiXN2lT2Mg8lozoTHx7bb4oAfcHcxJtAnRZWPKNM9jA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MrsJJukTUOCvrxn7OqbH7v5iKgX1ccRhXrxwz7Il0mA0UW/7yrwewjt7jtogzdYtLZ8IzGrlFMy2PhasMIHoUxOTmLLBYNZeuNef+5N6G8ummzsXoNIutfWjZSLMNk2tV/NAOU8tiOfUmUUkDqoXUwOwN68JOKdgcW+BKx0nb98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ioT39UGF; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ioT39UGF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749759208; x=1781295208; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jiXN2lT2Mg8lozoTHx7bb4oAfcHcxJtAnRZWPKNM9jA=; b=ioT39UGFLn3lBQVmcYgAdewVFfzsrQZsUNVj+5HTJzqwi2+JLll1lSed RSMEsJYLzsRXzDCuIXRJC880VqgRSXU6wGMbSgrLDbdR8dPAWHBuS/sro 8ZQLCLISmaMkQdWfH4FgsE0qKQpfVovJ48WDfExa/UEml+Pw3/g/rAb66 ebxxtTC7guNnF3UMUhG+5DnZtQT/MaHNdu+UPvatf9RXcCfjPqR92rlSD u34fJAI3AtGY/OxK5WvjMGJ6HATdqRagZIj8RPFXYKylgUJryNNLEFanT J7UjVdCbjkC878+mx6CKOrN3Y8tb0v/EGHREssKD8V0kpPKixu66Ht1PD w==; X-CSE-ConnectionGUID: 1PDLsv7DQIawsjTi/sCRpA== X-CSE-MsgGUID: JxREkC0mRtO2R5TEP5N7hw== X-IronPort-AV: E=McAfee;i="6800,10657,11462"; a="54588551" X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="54588551" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2025 13:13:27 -0700 X-CSE-ConnectionGUID: oDHZJ1YPQFG1TZoPK6Dmjw== X-CSE-MsgGUID: /D1v+w8vSWWKV8FfU4PFcQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="152393996" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa003.jf.intel.com with ESMTP; 12 Jun 2025 13:13:25 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 59414168; Thu, 12 Jun 2025 23:13:24 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Len Brown Subject: [PATCH v1 1/5] ACPI: wakeup: Drop unneeded casting for sleep_state Date: Thu, 12 Jun 2025 23:11:25 +0300 Message-ID: <20250612201321.3536493-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612201321.3536493-1-andriy.shevchenko@linux.intel.com> References: <20250612201321.3536493-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Back to the original patch [1] sleep_state was defined as a custom acpi_integer type variable. Nowadays it's plain u64. No need to have casting for it anymore. Link: https://bugzilla.kernel.org/show_bug.cgi?id=1415 [1] Signed-off-by: Andy Shevchenko --- drivers/acpi/wakeup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/wakeup.c b/drivers/acpi/wakeup.c index b02bf770aead..ff6dc957bc11 100644 --- a/drivers/acpi/wakeup.c +++ b/drivers/acpi/wakeup.c @@ -42,7 +42,7 @@ void acpi_enable_wakeup_devices(u8 sleep_state) list_for_each_entry_safe(dev, tmp, &acpi_wakeup_device_list, wakeup_list) { if (!dev->wakeup.flags.valid - || sleep_state > (u32) dev->wakeup.sleep_state + || sleep_state > dev->wakeup.sleep_state || !(device_may_wakeup(&dev->dev) || dev->wakeup.prepare_count)) continue; @@ -67,7 +67,7 @@ void acpi_disable_wakeup_devices(u8 sleep_state) list_for_each_entry_safe(dev, tmp, &acpi_wakeup_device_list, wakeup_list) { if (!dev->wakeup.flags.valid - || sleep_state > (u32) dev->wakeup.sleep_state + || sleep_state > dev->wakeup.sleep_state || !(device_may_wakeup(&dev->dev) || dev->wakeup.prepare_count)) continue; From patchwork Thu Jun 12 20:11:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 896021 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09D5B2E0B56; Thu, 12 Jun 2025 20:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749759211; cv=none; b=G18G/5p0kO6IF06aFbd/3hMki7myvQbTGXl6KlhQAZE/yoXzwlU4TUsfuHnWBsgbQTKgzPl4DiSFFRZP35IsD995LLSA2eK74H7XaPuTWidZwIOwaFXMo4aWKEg1dWKPwDDlCgUY9Mr8zRhL768HKr5VMc7gEutnK/8nJVqB3kI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749759211; c=relaxed/simple; bh=+pCE1xm1azKhfoWVwggxBY79YjQj7FFgR2g3ro0J8wI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OKHeozt8dpuFIJyefzk2zKilIH0NTC3nf2RaR9ohKsgxINb9gUKnB2j7vm42SJ8YT6/Ioq6/R9DvAETYO4SLS2grLZMGX47OANZbXcVKpdKIkSX2q7HJhtrDRRbU2XA4egBxukqt9OIkEbPZfB+mOVhZU1Zwh0dQDGADM1gYg1E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZiX7CHmW; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZiX7CHmW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749759210; x=1781295210; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+pCE1xm1azKhfoWVwggxBY79YjQj7FFgR2g3ro0J8wI=; b=ZiX7CHmWywciOkdqTHya17z9nX5EqBCy4i0mTvkpwpgAj6Ovlb9moQWD ZrYQ69DK5EPXMV5koHTKhCyjNDFAU8RtqyYzCzhEOp2wAuLLEGhAbL46q /LJEHx1CHH+5nY477A/v+xfUnE0uRd2E6OdpaqpTJQcHgAsEqUUyo1RRi 0v5qXxCxtlo5ddVo4EHYG2FlZus6vF3BDWmGFO5Q3nNir5lFHMAsapgsA swFc+Tsa5MR85dw7/5srNqSyOFmgpnNhXEQ7Z49xAcmvIFh7va9wTBKat X7OwrFkEmKNMWGmSZ5be9rm2YfFIhCgcFGACvQ9pH6L5FOfCGMD3BTDyp A==; X-CSE-ConnectionGUID: M7l/9g89TpCFWm/64YX6xg== X-CSE-MsgGUID: o5Qdr29eTLu+h5Rh+2aa6w== X-IronPort-AV: E=McAfee;i="6800,10657,11462"; a="54588555" X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="54588555" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2025 13:13:27 -0700 X-CSE-ConnectionGUID: Vgwf6eOUT5+d3c7tMK7HpA== X-CSE-MsgGUID: QB+ioz5jSkWNOjoxfwOCsQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="152393998" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa003.jf.intel.com with ESMTP; 12 Jun 2025 13:13:25 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 6E11C1DF; Thu, 12 Jun 2025 23:13:24 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Len Brown Subject: [PATCH v1 2/5] ACPI: proc: Use correct format specifier and drop casting Date: Thu, 12 Jun 2025 23:11:26 +0300 Message-ID: <20250612201321.3536493-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612201321.3536493-1-andriy.shevchenko@linux.intel.com> References: <20250612201321.3536493-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The format string in acpi_system_wakeup_device_seq_show() uses incorrect specifier along with explicit (unneeded) casting. Drop the latter and update the former. Signed-off-by: Andy Shevchenko --- drivers/acpi/proc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c index 4322f2da6d10..48215ba09193 100644 --- a/drivers/acpi/proc.c +++ b/drivers/acpi/proc.c @@ -30,9 +30,9 @@ acpi_system_wakeup_device_seq_show(struct seq_file *seq, void *offset) if (!dev->wakeup.flags.valid) continue; - seq_printf(seq, "%s\t S%d\t", + seq_printf(seq, "%s\t S%llu\t", dev->pnp.bus_id, - (u32) dev->wakeup.sleep_state); + dev->wakeup.sleep_state); mutex_lock(&dev->physical_node_lock); From patchwork Thu Jun 12 20:11:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 896022 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 910AE2E0B43; Thu, 12 Jun 2025 20:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749759211; cv=none; b=fz9/RRrS6SYVc7ip0Jf42Yf1zctplZTqDe2eyTbDsluCAGCvW/NBkrisTvuDrMVZxQJQU3KfxlSsSki5zMEomU4nNWbGQ3tdjXWbmZ8vPdCj6u0ytHfiIk1Y1G5942GUbnnAK6WAgSERiOkML64lEWQrbHYtI6ZzXw1LGypdMhE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749759211; c=relaxed/simple; bh=EnVJN8LV8zlQmIIqQMgDmiHwPvTuuDXjAG3xnNRsrNA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sBYPN4WEMYzskssD6zDldGlBdB2+5gfIL74mk0qmeEQL0v18lxWdWBgbE7AYhupZ+YBxzIFjz5G/BS02O46tW7wetOSAms8OaJgDUfEUjkDksYRwSupnMVe9pOw8InydghZjPSwJVvf3mO+/FYK1d00tpquhBCGqXo7tn9zX+EE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FrAA8lsw; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FrAA8lsw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749759210; x=1781295210; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EnVJN8LV8zlQmIIqQMgDmiHwPvTuuDXjAG3xnNRsrNA=; b=FrAA8lsw7s7rthG9Nx/cGj4TzC/v68pfj92Izg2rjpnQRr4IjL9eB5x6 AE7SzJtEVSpn6/BO93ohtLB7PW1sj/SANJ/0SOeGuSYmgLInXCk525l1g 9x4j4BFEmC/CxctTgGCncvpexZx31lAhkNnqlQd2Hrm1CE60sosL3E+pt KMOefVyF6Lc4/IyL+YAkgOKz+b+Nc6kM4SymDVHDsVuvVOFRHpdry1s9P UYI+6FZ4tCaZiHhyMhBS8qtAY4OaV+HrV0Ii+5p8EdrxtXvM7BWo+rMbZ 5KpMuW7yz6+dtwWZm025jVb6wPQbg4BjaSFdcpCIUxg/h87qGV+3XoPo2 A==; X-CSE-ConnectionGUID: zrb2N3p9Rl2yvVIQGgsWiQ== X-CSE-MsgGUID: Kn69xNhGSz+nOzu1VmHfMA== X-IronPort-AV: E=McAfee;i="6800,10657,11462"; a="54588554" X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="54588554" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2025 13:13:27 -0700 X-CSE-ConnectionGUID: 1WBicYbcSEGilXMCcA8r+w== X-CSE-MsgGUID: c8exKA/cRQ29cv54MDF1YQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="152393997" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa003.jf.intel.com with ESMTP; 12 Jun 2025 13:13:25 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 7E80F3F6; Thu, 12 Jun 2025 23:13:24 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Len Brown Subject: [PATCH v1 3/5] ACPI: proc: Remove unused header Date: Thu, 12 Jun 2025 23:11:27 +0300 Message-ID: <20250612201321.3536493-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612201321.3536493-1-andriy.shevchenko@linux.intel.com> References: <20250612201321.3536493-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 With `make W=1` build we get a warning: drivers/acpi/proc.c: warning: EXPORT_SYMBOL() is not used, but #include is present Fix it by removing unused inclusion. Signed-off-by: Andy Shevchenko --- drivers/acpi/proc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c index 48215ba09193..8ae85b06c422 100644 --- a/drivers/acpi/proc.c +++ b/drivers/acpi/proc.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 #include #include -#include #include #include #include From patchwork Thu Jun 12 20:11:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 895765 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DF9C2E0B42; Thu, 12 Jun 2025 20:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749759211; cv=none; b=DG2CDWjODne2fIHhE6BQ7WCOtf1fIRxE5Xzo27sYxR5w4Ug4evTQCRdnNAKOgLxWjF9tukpzWPFVyXJEIcU562/p3CbqQnR1tv0nGNPo2oGz2TDBHqQGEwZY4oTw6LIpIV65PtrcwRsUZflQGJ4Sf1NkdV+haP11f/zP6eFE3Aw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749759211; c=relaxed/simple; bh=OvLIOLHVYmoxljxXazIm7M7nVajoTtrRYOwqHR9k41E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RsBNBmuM93hCALaHF0Ai2O/m9ccbf9O/kfWFlyn8mN6AIDVHovenYZGC9+wvAUsmSUznKoG5bm5M62m7vRzfBhSVT1Np0Ij9IH4TSxFhVB0tR/RPvYf/YEe5QJWW4Wq6Z1RI+gDf/UMx0Hq7pLTxTl8ME9wDZ3w7Fn+mWrhfFd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HP36LuGH; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HP36LuGH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749759210; x=1781295210; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OvLIOLHVYmoxljxXazIm7M7nVajoTtrRYOwqHR9k41E=; b=HP36LuGHtlMx9Y3uO6MgD0r4MxzzyayLLa4YEEkCFROvAG1rhRtoaMDq uuCWZgcQ7P8Ee+gju1sgPbjxlHcoT6RDMFqTHkn04glMCDWz910GKvfFP WF8GVmlKfDzTRZouucihDk//ymNw9YdPpm/CiJeQk5Da5v6bHWyTxl+w1 9hqIde2hRlkgchCR+kMD5NqiV40uZOVN+i/WO9RnLCaR98z8e9Bq+iD9v 4Oy0kCqx9e+0fR35HSpB6Ozm4OJSV+3BO+ZFLrutJo99S54hqrfgKtqZI L7TAZu6h6Qrf1V9Xx1CwrT5W2SmiGV19B6dHrsx89UPRrh/9+nJUaZWrW A==; X-CSE-ConnectionGUID: pIxWrbF/THOOPpcgR1KzZw== X-CSE-MsgGUID: 2KEX5CFkRe268L/X8ll76Q== X-IronPort-AV: E=McAfee;i="6800,10657,11462"; a="55761136" X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="55761136" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2025 13:13:27 -0700 X-CSE-ConnectionGUID: X9nk8NKgReKV/lCbVGS/fA== X-CSE-MsgGUID: D36gT3dqTQmSr7Trd8kdIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="148114138" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa010.fm.intel.com with ESMTP; 12 Jun 2025 13:13:25 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 8C8E819E; Thu, 12 Jun 2025 23:13:24 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Len Brown Subject: [PATCH v1 4/5] ACPI: proc: Use str_enabled_disabled() helper Date: Thu, 12 Jun 2025 23:11:28 +0300 Message-ID: <20250612201321.3536493-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612201321.3536493-1-andriy.shevchenko@linux.intel.com> References: <20250612201321.3536493-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Replace ternary (condition ? "enabled" : "disabled") with str_enabled_disabled() from string_choices.h to improve readability, maintain uniform string usage, and reduce binary size through linker deduplication. Signed-off-by: Andy Shevchenko --- drivers/acpi/proc.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c index 8ae85b06c422..440150c67ba6 100644 --- a/drivers/acpi/proc.c +++ b/drivers/acpi/proc.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 #include #include +#include #include #include #include @@ -38,8 +39,7 @@ acpi_system_wakeup_device_seq_show(struct seq_file *seq, void *offset) if (!dev->physical_node_count) { seq_printf(seq, "%c%-8s\n", dev->wakeup.flags.valid ? '*' : ' ', - device_may_wakeup(&dev->dev) ? - "enabled" : "disabled"); + str_enabled_disabled(device_may_wakeup(&dev->dev))); } else { struct device *ldev; list_for_each_entry(entry, &dev->physical_node_list, @@ -54,9 +54,8 @@ acpi_system_wakeup_device_seq_show(struct seq_file *seq, void *offset) seq_printf(seq, "%c%-8s %s:%s\n", dev->wakeup.flags.valid ? '*' : ' ', - (device_may_wakeup(&dev->dev) || - device_may_wakeup(ldev)) ? - "enabled" : "disabled", + str_enabled_disabled(device_may_wakeup(ldev) || + device_may_wakeup(&dev->dev)), ldev->bus ? ldev->bus->name : "no-bus", dev_name(ldev)); put_device(ldev); From patchwork Thu Jun 12 20:11:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 895766 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CACF12E0B4E; Thu, 12 Jun 2025 20:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749759211; cv=none; b=EpVWJVLDW++nfuOVZ3wf8oBhOzDAXMj9tJKzIT9yk+fsXrs1FlxJPMLoTd1jeY24WcOtgXd5yKxTIQPY4Na594akFrylQaXra0QiRWirxThD5GCzOUw+eUNUbGVMP3eMx3OTmIOLuIFEd0CAuNYK0PsJ+goGlGVgzJGajeykKwc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749759211; c=relaxed/simple; bh=L7YFZq1wVfVaEXIz+Ocyiu/l1qr9rs048kh/X14R9zs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xrn7/AdZphFalZEjlOllG7TtxHAFX0zm8oFdpnq1o/glwHKppN3BcE8nVtg3PJHAbJl3q3ra/NKPGDXjnYtNdiBjXUL4hDkus/ChM+IMqZh6zXYQydiyaWLfo/NHBLR/ziBlfxTs/Ig6ZIDIRgg0SIrxc3or6AgLi9iVL2ihzio= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Fhh5t5Vr; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Fhh5t5Vr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749759210; x=1781295210; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=L7YFZq1wVfVaEXIz+Ocyiu/l1qr9rs048kh/X14R9zs=; b=Fhh5t5VrMuX27GLe4BssjmFXV0AcsarI/5EQKCY85GJwu1cipNlWVcYi kJQC7BCcgV14rMLuvMjTW9YWLyOvzuIMUiUU/GeZRh4BnS2PMtckEZ+Mi mSz1mtWxdskDZI9oS8y3sIuV6Zs4gZJkL4gYT3iHfMuQB+jArhONkKCZ9 E/MiuBDczROcrUSNkacRdT4AyT9rrdy8oGe/RQqFTj8cZFnBx70hYMwDJ 4X9/R6x1jZQ1A5jYg1vhhyXwvlfY1S9F4yZordszdlc5h68h/TqP0dsij HFL8PR6zY4M/BjvyKfeUPQC97mbAYewkBy/BDCYGwa2eMclCqQ0/36C80 Q==; X-CSE-ConnectionGUID: IDO+sNWVQN66MnmtXhSa6Q== X-CSE-MsgGUID: AglEISMMRWeOSqehryN+yQ== X-IronPort-AV: E=McAfee;i="6800,10657,11462"; a="55761144" X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="55761144" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2025 13:13:29 -0700 X-CSE-ConnectionGUID: vkz1oB/3TPi/juxiPwfG9g== X-CSE-MsgGUID: 7Fi6nuDhR3KDt1gH0/cmKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="148114144" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa010.fm.intel.com with ESMTP; 12 Jun 2025 13:13:27 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9CA4351D; Thu, 12 Jun 2025 23:13:24 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Len Brown Subject: [PATCH v1 5/5] ACPI: proc: Prefer to use octal permission Date: Thu, 12 Jun 2025 23:11:29 +0300 Message-ID: <20250612201321.3536493-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250612201321.3536493-1-andriy.shevchenko@linux.intel.com> References: <20250612201321.3536493-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Octal permissions are preferred over the symbolics ones for readbility. This ceases warning message pointed by checkpatch. Signed-off-by: Andy Shevchenko --- drivers/acpi/proc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c index 440150c67ba6..c08ead07252b 100644 --- a/drivers/acpi/proc.c +++ b/drivers/acpi/proc.c @@ -139,6 +139,5 @@ static const struct proc_ops acpi_system_wakeup_device_proc_ops = { void __init acpi_sleep_proc_init(void) { /* 'wakeup device' [R/W] */ - proc_create("wakeup", S_IFREG | S_IRUGO | S_IWUSR, - acpi_root_dir, &acpi_system_wakeup_device_proc_ops); + proc_create("wakeup", 0644, acpi_root_dir, &acpi_system_wakeup_device_proc_ops); }