From patchwork Fri Jun 13 18:55:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 896304 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2A5A231837 for ; Fri, 13 Jun 2025 18:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749840970; cv=none; b=ZKC/8ubsxb7FpCBPLFnryyBcZjLQ7NV2aYZcr7lhkIvEwAmjGnMeC1GWVvDs6EWeYQ6y4/RV+3oaZMSAbuKz0YioCFZmbzJi7NIcUPY5O8ZA16K7vaDCkiLByGf+cZZ/xsP1XTh6Sd9mkXWUayuLkNXvBF3kmGmksuDp8DFMMfg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749840970; c=relaxed/simple; bh=SFpLyUrSkeov8lTDekLTl8UML1Z5oaveGJ3pRpViCz0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=T5ZP7WdB4fTYRI3qtW11Vx2hEls0uw19BDDuLZbmBNObN9k/IUKyNAHLfZ0wgnH8eJydN4srdriu9oU2gZLwOQq4yPt7cap0fNS9j/rC4A6uEVkmNZZ8rKlhijrhOhdPMvn0H6xT9YNFhcxe8r8koLIfVdayVnpDCBcoG+EOYKg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=XZy4Us3r; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="XZy4Us3r" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-60d63174f05so704504eaf.0 for ; Fri, 13 Jun 2025 11:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749840967; x=1750445767; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=XZy4Us3rETpdOs8rSguyLgEueKNrF7UXsBDyQq63PQewHEzDg45E9sj5vF2AdZNVye wNn6sr44diTYkKGU9j3PupDfpj/vXWVFVIYmDZyrWuhr6h8GIn5d3EISdPHvLBF/YRUu 6kMqj4FOv6TCkfBMG/0Y9t9BEf30vouDSm5eE6jCZYrAk0/BqxX5UUrTHwGRnwQeQS9O KiAJqjguwWEmVf8v5/DyEvkzGEZRQ5HerAuA81Ov6cxn8x1qSFAbwxAqIDkHcgyqjpPI fbC2VETmrowmW2HjsULKu+AEUL1Zi1T+RWFfnMJ/Egf5seRyl6gAiLpKIeZqZpUBtd+N e1/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749840967; x=1750445767; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dI+YClki4Q+OM8j5JXLpkAENpDyF7Cb60VCru1h+I9Y=; b=kzpye7dL+GIUtBgwWalkK14pttD4kjX/uixbedO3euy52PM8vTKlgEDfhtWsG7MvQA K/QfBMIxdCVVocPlkWDKn8B7rq7EF+7jL9RWTcXigrSJ2DMAsu0ZAutxvGKMeacBO9ZZ lyDAqGHMXF2wz466nOgvp+KTsrSkpAMPkDGdOWVrFUORX5pqXNCN1M8BS9UAX5DCurET DNB+PHtqDibA9VDiPZS9RkFknFg/FgLyps1TDxFHdnq/pHl8UN//InM5UrQ0ryvzDAIq Itca8ipVoatgZJQQnZKfbdKysHWqZJeycLngyyp5YxK/MAMbBuPxwxZTZT/X19JRDoJj /XUQ== X-Forwarded-Encrypted: i=1; AJvYcCXxUgZtkaQAFseeE1X4p9IbwbTZ8U4V6KhloNsvZsU7Gj29Ximm/cm3NLD+W0oCN4942blIKaLST55G@vger.kernel.org X-Gm-Message-State: AOJu0Yy6a6g7o1NK3Orc0Yvr6j77hOydB9OEbsdJ3g4c3h2igFyIu7Ul 70o6togUe7s9dGSyCfoktyA9W8oeYjuGBdY/1JBdGjYu5cBhjd/0Dpd6eglZsQkRtL0P+gFQZS5 Znuhk X-Gm-Gg: ASbGncuX5mKtzYU7lvfKxbJaavFYT6Ab7YTsiDWglbdH43eE17yfWw0jikyKpDefTmO TPweyPd3h9C3kgCeFHAb1e1+jtiJ2a22o7MMd+70YRIyStWFEV274jPDrA0ixGVvQSUvREw2svv kVrRXepv/jMC9tw43XZSV78Am1uNRrsVdfvtfb65H30LjQzIP4OPoxbrRFhar6hJgjCnLiVF9v3 rNsLYAIHm38YV6QrlVLCIOxOXfb4ihtQeRelswfpjvUZR17ghMSwlU/4+iJYhD1ymN8Y7edMnEk 1jrGvSdneBs3ZX7nILkjCJf+xj4wShmNXOpnw3F+0f92+X/NAFxTF/A6tJhBk/VpNAo= X-Google-Smtp-Source: AGHT+IHIDNuqhtDyrUFqLqhDihe2otHFXjR2z0Uj0/IxHd8WHsBb5KQ/hfkoGSBN5gTvsdjyeJ771A== X-Received: by 2002:a05:6820:2220:b0:60b:d6f1:7c50 with SMTP id 006d021491bc7-61110dfc503mr554725eaf.0.1749840967556; Fri, 13 Jun 2025 11:56:07 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4647:c57:a73c:39d8]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-61108f07e08sm256244eaf.27.2025.06.13.11.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 11:56:06 -0700 (PDT) From: David Lechner Date: Fri, 13 Jun 2025 13:55:28 -0500 Subject: [PATCH v5 1/3] bus: ts-nbus: validate ts,data-gpios array size Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250613-gpio-set-array-helper-v5-1-273fab50cc8e@baylibre.com> References: <20250613-gpio-set-array-helper-v5-0-273fab50cc8e@baylibre.com> In-Reply-To: <20250613-gpio-set-array-helper-v5-0-273fab50cc8e@baylibre.com> To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1149; i=dlechner@baylibre.com; h=from:subject:message-id; bh=SFpLyUrSkeov8lTDekLTl8UML1Z5oaveGJ3pRpViCz0=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoTHQuTsVQSh+FA+OKrMbq7r95SDLAKurmzl6n4 eF3OJTvep2JATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEx0LgAKCRDCzCAB/wGP wLf/CACNf5sXMZSBwHrR52sDXKkT4pw+mfyzKQkTvQU/RNoOzSFHeNzl3etvgs8aItFSQTCaZDH +Kn1nNY/N/mbvJKdZpsMAD/LgP5aR3hLOcp+IfbZ1pzhZj3uMQ8XXf0VVGzRhEVhy/z/sIzJZpi bA2KUclSU5ndPJZS96FRk+LAbirsKK97ExHRQFZFC8xgl0II20W/hPiGtdgs5A/1YeGynRLaomM 3s9oScLTVwynnmJT4qlp0I2iFLDFrL1qz65UzoUG3nUabTPNVmjHfYqNSOsYfzXW8bfZemySSAD ZfmCDJLVCIdbBRkoiY/FfEcScqIm2bvrZwi+vSvvOwjU54BE X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Add validation of ts,data-gpios array size during probe. The driver later hard-codes 8 as the size of the array when using it, so we should be validating that the array is actually that big to prevent possible out of bounds accesses. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 2328c48b9b1260e805c631f2aa7379d620084537..d3ee102a13893c83c50e41f7298821f4d7ae3487 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -48,6 +48,10 @@ static int ts_nbus_init_pdata(struct platform_device *pdev, return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->data), "failed to retrieve ts,data-gpio from dts\n"); + if (ts_nbus->data->ndescs != 8) + return dev_err_probe(&pdev->dev, -EINVAL, + "invalid number of ts,data-gpios\n"); + ts_nbus->csn = devm_gpiod_get(&pdev->dev, "ts,csn", GPIOD_OUT_HIGH); if (IS_ERR(ts_nbus->csn)) return dev_err_probe(&pdev->dev, PTR_ERR(ts_nbus->csn), From patchwork Fri Jun 13 18:55:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 897120 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16DCE2356D9 for ; Fri, 13 Jun 2025 18:56:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749840973; cv=none; b=m88K1Od2Ph5WdlryZ0ta8aVhU/FUY1Hhkkw5gIQhfLAmIg2AtMNgTvpD5bVd5nZUbNKmmq9+UDzMZQR1UeSYLxF+8ec1jtZROFuDbAAGJ+qlRUjg+IfXaCIGmL2k+XqYghnuNuY1/jXkJVs0eQTnTBVoQ1KjlX9iwvW1dQbLy0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749840973; c=relaxed/simple; bh=K5V5TnWu+110nnHuULWw1Pwd0QiBFgzUapmy9BeC2p8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=koInGDBNmdhf7pARZnGKfQMyOZwr9KmL69NZzMQn4bFbWHYc5xWPjBaWRVULvlEOzy18jJrpTnFHNdodMsBJmY0DLRl6zAdzIZuCMwcNSRyiWaZSdrlu6RGOgqPKRYBtY3xZBBfkwwVV4spVGSJ3h1iKo36DAZrHdyaQhg2YKrQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=3GUuqvCX; arc=none smtp.client-ip=209.85.161.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="3GUuqvCX" Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-606648c3f9eso704246eaf.3 for ; Fri, 13 Jun 2025 11:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749840970; x=1750445770; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=3GUuqvCXzOER9gYjAw8DH8d3ptDrU+pCP05Q0Kk9aknw1wHzyoHwN6TxZ2Q9oQD2Mp prmwDcRjfltiw7pDEUQKaVBSFXXw5GoNdCwrhDOFsxR1ugsUDrrkOhjdcuALL2z47On6 HtxmiiUeYlL33XsU66obZMDy2ETHHJ5y+PAukUkpSZwDgpjPpCOZf51ZBB8za8eBLE0W dYhYrilzP/N5j7fh3INzcbtoBsdzKOgAnla2t4VJIR6snoeK8wRqg9AFTT1tFaiMaN0c DHO5w0IxR26Su77E0eCXuGgWhxjjXkOm91M+3S8vuD6r5I3Ab+QWynrSqmWzo6CxEOE9 JNsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749840970; x=1750445770; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oAgdP5/7nbSCpei3bdgHz+Kvp3J/VbeQ+Dc9cWuRxQY=; b=baXBPP+fM1Q/j6yG5sE78nuICGd3vVuq7dLylKmIz4vOirEmYLBJsEO/bYlKisIN0K lgQBkM+nsqPZxEnPKvi/EtpXSge7fqcOygQMTOfsMVyLLZcfrHfj6kqVKJlyOYVPsQHN 1aXrEJYZr8B7drjfs/rzYc2OaxfQTVKowXQBiPQN3U5Tcq5PUcgvdLz6PPYEVelvrf+Z FIk5vnI0xsksLw9i8OfYVU/53Z8GtOIToyvKDFts/cN6mbCChF1KkQq1TnUc4rePbdbE 91SyB1Lxq0F0w5aFmfEjvavf7lazP8cpKNIb0zF94gvY1wvQl7zWffnITnSBcdjJV8si Qbeg== X-Forwarded-Encrypted: i=1; AJvYcCXUfSUEwaqRJGE21e4tLICtbEadprBBUJM+e9gEOvTHm4nH536FXqw7MKI6KQdEqMT5CgYBqckr84h5@vger.kernel.org X-Gm-Message-State: AOJu0Yx21fn2KIwqPvmtwPcXkNYvKW/RGFQTNGuLnn6WUsoFSKtJDvxQ fS/WbE7OYxlRFUde1wUNZFKdGC3u/q4XZzBxeAlCQG2c1b0QbC3zNAKQEQkU5enQarR8VphHyEU LiqGj X-Gm-Gg: ASbGncsjR5K/OzaANmww/w2cm7TTGVb1S3RU70p07qyJL++PCC7d3Ackkrsl4obfLEE 1sYQ481Rwc1BB3Zh9dzv7L3cnZFCkg5mpFxQxXJyGne7rKz3MmjTbVGhYLbbhkqoDtFYR+Mi+UP VFJ+VpHIwJVVTkXiaxNDT7e7ytPl3RNKk1gNXY1loB3uoX4C70QG/s9d8sG537NVEye6HceBuXE TSw0+XPrdbZf91Cd2b9waQjawABof1a3x05cz+prUrXsyEBRkq2YXg/fmFnyV8ZTPqcOKzspkq+ i04bxPXSCuGJW6xq+RWEu4xFFIi+cKsmsd0xT+0UrlbDPmTCXldApN0T2OaFko/NIN8= X-Google-Smtp-Source: AGHT+IEc8pztUfxk7EvjJ4ca8xkYjBhnyFgil/uaxtXzmvi6qgA+H+IzcVrvfK0nGCVD5jHUwQ2P9w== X-Received: by 2002:a05:6820:60d:b0:610:dff3:425a with SMTP id 006d021491bc7-61110f0e204mr421428eaf.4.1749840970240; Fri, 13 Jun 2025 11:56:10 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4647:c57:a73c:39d8]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-61108f07e08sm256244eaf.27.2025.06.13.11.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 11:56:08 -0700 (PDT) From: David Lechner Date: Fri, 13 Jun 2025 13:55:29 -0500 Subject: [PATCH v5 2/3] bus: ts-nbus: use gpiod_multi_set_value_cansleep Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250613-gpio-set-array-helper-v5-2-273fab50cc8e@baylibre.com> References: <20250613-gpio-set-array-helper-v5-0-273fab50cc8e@baylibre.com> In-Reply-To: <20250613-gpio-set-array-helper-v5-0-273fab50cc8e@baylibre.com> To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1487; i=dlechner@baylibre.com; h=from:subject:message-id; bh=K5V5TnWu+110nnHuULWw1Pwd0QiBFgzUapmy9BeC2p8=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoTHQ157bdDa74GvX+bG28rLClC1BSRU3wN/Yeg GfP5Zo1E3qJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEx0NQAKCRDCzCAB/wGP wAa9CACBPCfBNH+pO03QhAZu48GDH9Pe8785qJwwmYJ8uxbrfK5oNLibo2TDWLSwOA9dhdzlRzK UZm3UcyjpEdTCIi+jkzqdhNv4tt/GFRl5mcEx7/G7llmupPdbCHGBxp+pNpfNc4hEkastfYG4oT VhVmlesVVRo2sTlipN1chPDsRTi15Timt+SDFDzJle5Bx86/1sHVoVDAP9/xPBvu5CMRk4NxIu1 6/vA9C3Z/QoZi7Z7NTV3V3Boo2v96y4xxIJpCs37+AmjypU+lyJU0pLMBJvyVE5oeN2JYtxvUEn nZz5ep3mokRJK3TjorCi6b7p64tgzyIwpbsnC+RID9iN8bSB X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of gpiod_set_array_value_cansleep(). ts_nbus->data->ndescs is validated to be 8 during probe, so will have the same value as the hard-coded 8 that is removed by this change. Reviewed-by: Linus Walleij Signed-off-by: David Lechner --- drivers/bus/ts-nbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index d3ee102a13893c83c50e41f7298821f4d7ae3487..b4c9308caf0647a3261071d9527fffce77784af2 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) values[0] = 0; - gpiod_set_array_value_cansleep(8, ts_nbus->data->desc, - ts_nbus->data->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); gpiod_set_value_cansleep(ts_nbus->strobe, 0); gpiod_set_value_cansleep(ts_nbus->ale, 0); @@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u8 *val) */ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { - struct gpio_descs *gpios = ts_nbus->data; DECLARE_BITMAP(values, 8); values[0] = byte; - gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values); + gpiod_multi_set_value_cansleep(ts_nbus->data, values); } /* From patchwork Fri Jun 13 18:55:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 896303 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04F5E2356D9 for ; Fri, 13 Jun 2025 18:56:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749840975; cv=none; b=mAsKzndEv/lMCY9MVxooI3+dhTobUFndIvtUuezisTdzYzOCBulzVXZvCB/YksA69kpd7UHnbiG4udbgoPckbyQ8f2GUazxRnraew8gJtevDpZtGMsZRJBl073xljpygHRUtRkZH6B2BVQ/kzk3RcWRDGV3rP5B95fpFg1GsDDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749840975; c=relaxed/simple; bh=CAL7obHrndJnr3rxcS12mN4GTY+FeLhfpJLw2svY0Jw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qbJCxEtciwMPn6H+GRCDSuj3PwwJ7M1UJBL1d7HJRZsfraJpqSSMdUNUhm+pQpUubLXMzivRqe58M+6uN55nBxb96kgKHLWVrPRVvnOjYpYaSHD6leDHNlHVaULpErLyVHlE1ik3suklLGq22lANnMmRvNeewvZjDEB77xfwEck= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=OggyQU+j; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="OggyQU+j" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-4067b7d7e52so649918b6e.2 for ; Fri, 13 Jun 2025 11:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749840973; x=1750445773; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=m/Jw1HzLyXz3aA6jCt0RjdVyqCzrscgvid1cM/aOBW4=; b=OggyQU+jiAC3Jp30HbM7WZiMRU+ktkuxbLd62PikXn5Qe9DySQ0tvMgE+A3SocbjqJ Ry43KBN3omFMAOSUIhyVAfCfC8gNbfHSJlXTi/9dhs3TkmPoPaI2ahalDOoM+YnpUCq3 XUTTljqkCwZ8YfN1kLsprrfmMuv0C/Bs4rEPQvTDKiciLDTFW26bK/WEhRcAdW0xa3VG S5f/w9B2Fh46pCIpB87Ht9mlSCyuqo3qj9+CgLoIn+0zMHIZ8rKSI9aTRp84UaMoEcWh TdGL0irh+qk4lIDxr47gopOiaIGgIOw++c/JoC7MJzG5x6aPhcsKWuioMg7RWfrSwZjx NL5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749840973; x=1750445773; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m/Jw1HzLyXz3aA6jCt0RjdVyqCzrscgvid1cM/aOBW4=; b=Cb0SgS6QawpBTdP+k4kDA2mXsfbz6Ytkn2I5Arbg9Wy7SN7zQkY60dS0g1Wye96DxW In6K8YHHav0tlGa5SgAfhBMWy9ES/Rst/3uP9Rh2TUEPUwHCVr5foZ6+reS+TVhPiDFU 4E3E+e3g769mVoBzczYq0gUyEf4ZtcEEZ4bYc5VHvH7CexmW5dR3m7XT8wwBNfnF5nmJ j1y/1ab/0E5Ly/GDRA2cQ7EpJSibDlJ77b5HCSRguoAY3hF6LReulTa1ITQ/glWZ5F5j 9NlWDuijiU/rqAe7uPPneLhWrYsaMJbrsN42iAnQM66ToIQYTvMIX00xL/Feqg+C4hRD M77A== X-Forwarded-Encrypted: i=1; AJvYcCUFe289XDFUiuyzEiRZqTI0gWezVsPHOhy+H7Tit3J/eZaqx5gaYKSsvcA++/STX7debBe4xQU/6xpx@vger.kernel.org X-Gm-Message-State: AOJu0YxojlYO4+D3LZX52f4cAxvAtnwmlyTIzVrO5l63kblRvDiebFxP PWycUJ9P1fUOCLnV2G2kGnSM3/a2GP+5jCAvfHGof2tI7F0sevNnP5pycafnZ+TVwjofv/zjPFe IYq5B X-Gm-Gg: ASbGncturRuK68dVrl44eft74462o2m8KrU7GlZd/iT3bwOfizPagHhh+GRHjQM/9WL sBwn+VFFxulbgN9UylcvGry50WWuN3ecYefsrQyBav4wzK+SWjfxrXcVuUvIHe75SpDprdgiBP8 vIxNOt5VTI+PaYlI/ftr2Iw8kNw2vkm8iS1qIupxHplXFu6DlwgjhomZfzLNuNKw/iHTcF/3T/H tEYyzNkkw890g4zxe1By9t7CfQo15wr18r9UsdGaXzcoVHG2UH54RTA+brRbw3rYptjxuUSytY3 yzjNgVVsjLUc8U8+h6FdezDKS6u0ntyFeXbYj1ov8OSVn3qyQOqkZfH5UK6FqEfio1g= X-Google-Smtp-Source: AGHT+IF46sUC7fpnm70pdQWqZs7Gy/g+8A9DyCLSCMcbG6MfejW4kWoNwjo5H4XZGjACXLhKZ/slUw== X-Received: by 2002:a05:6808:2224:b0:403:3973:23c4 with SMTP id 5614622812f47-40a7c119d5dmr395805b6e.9.1749840973013; Fri, 13 Jun 2025 11:56:13 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4647:c57:a73c:39d8]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-61108f07e08sm256244eaf.27.2025.06.13.11.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 11:56:11 -0700 (PDT) From: David Lechner Date: Fri, 13 Jun 2025 13:55:30 -0500 Subject: [PATCH v5 3/3] bus: ts-nbus: use bitmap_set_value8() Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250613-gpio-set-array-helper-v5-3-273fab50cc8e@baylibre.com> References: <20250613-gpio-set-array-helper-v5-0-273fab50cc8e@baylibre.com> In-Reply-To: <20250613-gpio-set-array-helper-v5-0-273fab50cc8e@baylibre.com> To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2005; i=dlechner@baylibre.com; h=from:subject:message-id; bh=CAL7obHrndJnr3rxcS12mN4GTY+FeLhfpJLw2svY0Jw=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoTHQ7wb/Wqd5uM0itH561zbuzBZLhf8SMVLJOo +RXFtT1YgmJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEx0OwAKCRDCzCAB/wGP wPGUB/9sOLa34ENc9yrrXBypfPUlomEv0iV2hsaVnJZ7RH8Sat74YHznsdIkYCNfuDpNPMux7Px qwv0u/hJtQSgKwdbZkssK8MMoTgQ16JXlUiovxbdDzyM/HqGmvA64mNvfNOvTN8ZDO7nlTG2ojo OeZ+7yGMbprFMal41StzydFs9R7FcCDVt8TQI1XvIYRFyQgrjfWqQMY/AEE+l2jDJeFywjM1qtj USF53Wt1ke3qkG3Cew8U48WrOPHIhpKgc0r8m69ZbqT2oehrZqy9cP3q3E/64OrKuvuPocmGIny wum0JT1pzp68jmyLwG6V9nlIm0RDYuvUFTUFGdT30gnshHMK X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use bitmap_set_value8() instead of accessing the bitmap directly. Accessing the bitmap directly is not considered good practice. We now have a helper function that can be used instead, so let's use it. The bitmap has to be zero-initialized now to avoid a compiler warning since bitmap_set_value8() does read/modify/write rather than just the write that this is replacing. In ts_nbus_reset_bus(), this zero- initialization is enough and we don't need to replace the array access with bitmap_clear(). Suggested-by: Andy Shevchenko Signed-off-by: David Lechner --- v5 changes: - Fix undeclared variable in ts_nbus_reset_bus() v4 changes: - Fix typo s/get/set/ in commit message - Zero-initialize the bitmap to avoid compiler warning --- drivers/bus/ts-nbus.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index b4c9308caf0647a3261071d9527fffce77784af2..371fa83ad0db424ea48cd7c23e3070f56162d7ad 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -10,6 +10,7 @@ * TS-4600 SoM. */ +#include #include #include #include @@ -105,9 +106,7 @@ static void ts_nbus_set_direction(struct ts_nbus *ts_nbus, int direction) */ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus) { - DECLARE_BITMAP(values, 8); - - values[0] = 0; + DECLARE_BITMAP(values, 8) = { }; gpiod_multi_set_value_cansleep(ts_nbus->data, values); gpiod_set_value_cansleep(ts_nbus->csn, 0); @@ -149,9 +148,9 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u8 *val) */ static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte) { - DECLARE_BITMAP(values, 8); + DECLARE_BITMAP(values, 8) = { }; - values[0] = byte; + bitmap_set_value8(values, byte, 8); gpiod_multi_set_value_cansleep(ts_nbus->data, values); }