From patchwork Mon Jun 16 07:18:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 897101 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 981D01DE3CA for ; Mon, 16 Jun 2025 07:19:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058343; cv=none; b=jVRl98LVqlcIWyLOEmt92LoSmeiOTIEP5nGjPc4prYeGhIrueJXFgClQ6F4SyC/qYEpvWeX82+4Cgfun/0LWDl1IXzDzye9pSZ9uxPK46KX511PoGMYJBn4e+9+X+IxkdvdiPWaj5yyrtCr926KC0WNOWqyWc3rS6B9XReuRJyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058343; c=relaxed/simple; bh=b/qgu6/medib2vu4jNB/RyGMXO6WslAvUTV0AIziuY8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fI9gNMJMo/UBIL/9sL/g7ZD24yvjvnHd5MmX6/FrH3b4LpfR0JWNrLR4ey6i5mFbCw+FRKY/XVUXKxE+B+5JjZpCxuWOIE9jAmUP61CRXll/noHp4c0wNKjYy/ZnES2b0tGv/jUJbUyyFohmNaHYqT4nU70484f/f1i5+/2DT2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=E2jNH6+9; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="E2jNH6+9" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3a536ecbf6fso2747161f8f.2 for ; Mon, 16 Jun 2025 00:19:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058340; x=1750663140; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WTP8xNB64zIn9DIEvp87doAXF5a/sVMPLzzHk43KYWg=; b=E2jNH6+95ccs3apCDnOeCeCVIp3e28riGIqxDeP6CV0xsG8fjtvYgFHZg9TcSFl3RG fakQDhH7vxDEftiTC/WhMqMK0IUdJVqAt/rqF5fnYh5jpsMLe0gvAJdTbVtnJONmmvF+ gVkjEE5P+o7ZErW64Ynjc6cbapiC/BR9MXouOFr6GRNJq2FgUhcqBdrMGM5nxTtzO5qJ 2z/6onPmGxsbZNP8jf6IjiVoHN1U0i06r4NnUDLFPzlw1s5xQKYbuNzmmVDDJCnDSsa9 CYAOvGP+5K55m9D7qRXWHUo+NveFvwB4EIp3iEnLw4fNJgskOVLX1UtsEbM8tiGG7oTH azgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058340; x=1750663140; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WTP8xNB64zIn9DIEvp87doAXF5a/sVMPLzzHk43KYWg=; b=wsrzF0FATsP4qN9W7HdRWLMRy+7suqRGcY471RPkAPJqSO5tU0Pr0T0QFm/a9b6ysW e6W3xZRPrbqREfla81sPk8cXMHUJQ0S+Sf7WP/zVN7BsNa+Uya573EFnoKqWKO1NVGyE sRMXJx51qrqEKWEfBjGiqroxulxAz3MSsVT4rZBj3bCXwO5bnBz1jdjUnbKtD97ffBpf URu+y8I6aUAGlF9Pe+NflhrOe8aWEO/blCXeshNwpJDf0onziTCIuy6RZUfVlJvihgDk VzoRBu1uhwxw/HBVbi/q4v38EXEd2tfAICmc4eRNWzKeNZ1DFvP1zRedOeXpN9vNTseq PGig== X-Forwarded-Encrypted: i=1; AJvYcCVBG4uL0DiOjGckMh50C9Ff6O4YwpvncQYZJ3eFxmkQr6Sme5w52urd2ZyuR5wWVk4GLh3EFuJwexll@vger.kernel.org X-Gm-Message-State: AOJu0YyKSQIwFo+QlFCzjTZQwG450FJI9ueLbmrB8nnQyOw0VeCQySnr pue18bOl2UwAsdNl50DgUSE9r2M7iKoNMs7bu+KQHanIYskMPi6JIdBkBo2R5PIVvtI= X-Gm-Gg: ASbGncuSkNmn+5bE2H5tV75QcBw5qT2Imh7Mo22gDse6G2DHYPy/zBiEZzjOzCducK/ rvku9BfVw4IbbRoBPFaf5cmE0fiAQQVR9Od8UAvY8Sfn/608w6cnfE6kEt/ykKGTUUqvF0TIW45 LGYqUbC1ID35hnZn+Qahy8EoS9GB+LVO1oNvfyiQDu1fQ9YtUTzUCv+hVnOp4sVvhh+a9M8825Z z+dr6ERZD5hx2mnBQ+G6PBlMq7hVx1F2LKn+ZsZ+8Khi6dY3mghwhNtzjKs3VKrWZpvk85Ns4qq zmkTLBxoGC3L4psUpPdusN4xPXsf9InoEe9lW7mYppYTCnEaEBhIAGFR X-Google-Smtp-Source: AGHT+IHJwXDSA4Z5xe9culUJGL+TV3WkdcCjz/o5pvo+YDSZ+lGiZKhbROr9J7tnrwvTTu9uyJoTTg== X-Received: by 2002:a05:6000:708:b0:3a5:2cb5:6402 with SMTP id ffacd0b85a97d-3a572366594mr5798288f8f.12.1750058339835; Mon, 16 Jun 2025 00:18:59 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:18:59 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:50 +0200 Subject: [PATCH v2 1/7] media: dvb-frontends/cxd2820r: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250616-gpiochip-set-rv-media-v2-1-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1778; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=N9OvQ6idGerlmLwTIQS5N5xpWnMU9Eqb+M235W9W9/w=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8VfUCH8X17r5pnPQAArlMx0ie4BcV65lDtej K8ofAVFSluJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FXwAKCRARpy6gFHHX cvILD/40T92AubfBQ0A8MrcZS9ZOtc0sRIrcm7vjV8QU5m0Lru+HCv3binRNDyv9ye9PnZguVzc pHNNVZfUmjnE700pWtmvPiUKImzBBxc3wo8X4nxNbFUBqbf3FkzOfAdRFj4Ptr+sECms7XQrBMi qb5soJkuQSqUoK3VV7i4y04lqUgK6Bs5BKr/LQ90PByxbqmu8hbm65oUYYfOua9Iz5FEVqdHJMO HKBSjKlxYAb58ym9Jzg0SXl2Zm8PQwo7/+e5NjRRcGkO3PsL0spUPHvtGUQBJrFYMt+CQroAcGm 4tM9cXn+TNRPy1uZDLhtec9BexB+WJArnAkUJOC01FYge8qEmzRDTnnhGdJTxPE0D5pNDLFz5U+ FDz+XYD68WTOxF3uNS3/uhg+hPIS02qMy1FdRR32NndRoG9xWM+uet2lJjRl9RshUoZSN1ThDnd j1NTqoz69lwsigEBYVsbsDAffI+7Y0B0bVnqNmeP/jzqD5R9XXS4gWRt5IHOW5mdYkO0dmTh/DS XqOT8uCr2K/TI65F1Sor+rOppLSeodjPpxOiaUqQOy8GMXrcJr8zccM0VZ0XBb6sHxFIog02RFm Is0dOfI6ESG3494of5kAFh1UuVtYqtMZcsEI6+F3vN4zJrZnE0XqA8oslJmZRJ7FQcIgli99oyW /Deo8F6L0mnbwFg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/dvb-frontends/cxd2820r_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/cxd2820r_core.c b/drivers/media/dvb-frontends/cxd2820r_core.c index c3d8ced6c3baa6608e17cc4797dbeddc5a5ed510..a31a8a6a494652e6aae874c399fc70df3f9ee172 100644 --- a/drivers/media/dvb-frontends/cxd2820r_core.c +++ b/drivers/media/dvb-frontends/cxd2820r_core.c @@ -433,7 +433,7 @@ static int cxd2820r_gpio_direction_output(struct gpio_chip *chip, unsigned nr, return cxd2820r_gpio(&priv->fe, gpio); } -static void cxd2820r_gpio_set(struct gpio_chip *chip, unsigned nr, int val) +static int cxd2820r_gpio_set(struct gpio_chip *chip, unsigned int nr, int val) { struct cxd2820r_priv *priv = gpiochip_get_data(chip); struct i2c_client *client = priv->client[0]; @@ -446,7 +446,7 @@ static void cxd2820r_gpio_set(struct gpio_chip *chip, unsigned nr, int val) (void) cxd2820r_gpio(&priv->fe, gpio); - return; + return 0; } static int cxd2820r_gpio_get(struct gpio_chip *chip, unsigned nr) @@ -651,7 +651,7 @@ static int cxd2820r_probe(struct i2c_client *client) priv->gpio_chip.parent = &client->dev; priv->gpio_chip.owner = THIS_MODULE; priv->gpio_chip.direction_output = cxd2820r_gpio_direction_output; - priv->gpio_chip.set = cxd2820r_gpio_set; + priv->gpio_chip.set_rv = cxd2820r_gpio_set; priv->gpio_chip.get = cxd2820r_gpio_get; priv->gpio_chip.base = -1; /* Dynamic allocation */ priv->gpio_chip.ngpio = GPIO_COUNT; From patchwork Mon Jun 16 07:18:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 897100 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDFD81C1741 for ; Mon, 16 Jun 2025 07:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058345; cv=none; b=GeSO8s+xP//RV5gqeMIysSyHIT+tn229XWoFII6HP6XgDFuCUT8RVzwK8G6ovkp+TiTYHV5UUKs7pSaFsD2+Ji4GWyzhuggnFrYCR6qcUMD+cqV6ZJfSiCoHhxIIteX2+YuwqbbN4EG13t+85sxpLJwcL+4pkhVLKxnSJb2Cd/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058345; c=relaxed/simple; bh=i4HUX8ifaxrfpP6Wtp01EbUr03JCgVc5lw8n3/X/fHI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HW5ZeLLB83A06qKDada1ofhSUiok2wc7jS5l9H6SMgEqFsrKEvxI5XMqumzKvXomG/2fno7+wVWkDUQyZfNzTPZ3EyNHDjP73x2c/4W8rwiiCQ/lESttoeP70MbazrTLjt6x3AFZa7LTW1ulkbnIsLeXpIlpEqN3ugYmKGMLTxs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=lI6DAoFS; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="lI6DAoFS" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a5257748e1so2923537f8f.2 for ; Mon, 16 Jun 2025 00:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058342; x=1750663142; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xq7xfBYrivDdeg+8ZFQsb9LtSkPdVzHMYNYxsllkpTQ=; b=lI6DAoFSCwEkV3XVYgkKECKIGHWbqLkSptW4rW7WSgY5qRikCyrL32UYn7ZKafAaD8 ZsjntKOX8U6+I7cw3B0Vivav29Qsrv0yIOkv2/jK2vj/c5Y2u7K2IbxibWmUcJlDnExt 3vfn9XA96g0QxZ3iXqeetoXISzcsRl1ugwiq26d7CZd43Nz4jK8xP4hvyyOqh0R2qZEV HOa7r7VlEzdAcLmn2cELHU3DU/ztCEg5GNhhiifoqfKpYEqR4XsvFYr3pazcQq3O4uCZ hVAJ2/T9GP3/ElPptWUFKp4g7IUk+5jDkCRRFFJH46q+YRbdY9AJse7Eyk+YhjeWKMie zP+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058342; x=1750663142; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xq7xfBYrivDdeg+8ZFQsb9LtSkPdVzHMYNYxsllkpTQ=; b=JzRMQrKtIOpUJCtNGkfsYgjwC0uupDozXKqUUADgnhYjBKNujOtKPcG+Kc3iv/C6d9 RSwfDMSv/lBr4KhQ0J6AAFVUDVq9tG7FyqDJQfjSTz2QHNxAk0860bIHkMFyhqYyBqsB Y3Xriw90ab+cwFORTap8SRnjiuWtLgjsa5KoezEGYMhU8Bc3iJWK28kiA/NXu4RcBcBU LaE0jQOmqm4oF1kp5vJM9kyOw70p/MW+ctYeL+DoS9RP2DBDolLbb4qvXlT7sZCXeKvd xGvF1kzhTRc5/ljRqsRxinE3WDdWbvN4jIU9Qwtb85PBnMDjUYkShAXJu4wb2qtE4NpA Tybg== X-Forwarded-Encrypted: i=1; AJvYcCUHU4cukHecwB7oQhuc04D5RaFjkCkLZweC+cobEdZn0ys6RUAhvphF6y+wMov/aznX8gB6TaLA9E8t@vger.kernel.org X-Gm-Message-State: AOJu0YyIwpZbJO2oX81Jn+COD+DRbccxF3Zx9ys9nNffnRPcgbOz5Ldj dysDG4QDjCpTOI0VBxTunuSxfl69Rr61+BRbxhCqM8jTLNhjGwVuu6Tqvz+HD26GglQ= X-Gm-Gg: ASbGncuV7KmTmjrlG1kBgFNt3ttS0tqOjbgbJV2s2XZXTcyk00Ajm6HxUuIFZygM1HE LqDRBoMw0Brh4Rulab/Phzzwj5AZRZe5LDymCg8ndY6ZxJ32Y4xfkxlAxKnMfm5vCu63QXUZiN9 uVwmyvpk2xvs1tzANkqVH431d+QN8RGWx4tN8m3a+vqacuak2aYhfSaIzsutr4xNa6yp1gfqHW+ NL+UNrP+36HBq3GpyIcOdECCCimDBotaNSld61A67aNRm1p5L5EH2dWj29TeEVPmu10Q/sHGrVb AtfXSg2pPkQ3p3HR2yDSylTkRz73X6HhjLQ9RLMlnRLgEB0I6s1CtMdg X-Google-Smtp-Source: AGHT+IGqRQFtwLQB2XoRi5EOneCYIsZXe+77XlPZZC7TAn7DBrw2xMQ1XvuYegfIi9R1ySJiXAmKpg== X-Received: by 2002:a05:6000:290c:b0:3a4:f35b:d016 with SMTP id ffacd0b85a97d-3a572367993mr5930123f8f.11.1750058341928; Mon, 16 Jun 2025 00:19:01 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:19:01 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:52 +0200 Subject: [PATCH v2 3/7] media: solo6x10: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250616-gpiochip-set-rv-media-v2-3-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1584; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=x0xLHApMRQLh5h/Yrn6OODER6U8QbupzF1WTnrs22BE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8VgnkyfY9zXwUwAbF3pDGBMJaaSofXadbbUu oURaRqaoYiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FYAAKCRARpy6gFHHX cgNZEACfPdzwFh2olDjXYlCjJ4Sr3vGyHbfYbeSG5KnAngNEJzuwjX/R3eFGn2wmsj3A9G7fpTc k098NBx1cBk+qV95tArmvsGnNTVbZYI06Ug6fsC0u5JdDzMTCV9qMhkRnEHQ6HF/Njn4Tbyf7oc lYBbQh1zRPHrp7zwafBO/eYQsiNymFErIsYGlbZYgqFBOVqkroc8SrWR4EP97q1XDLZ82+28iMQ YTcM+AGVcqTDwaAItFQP4Li+A/2o80vhh5xGX9P9lG/iK+cIL9VvtLbSNkZ9b8+5jp3jhw4T+18 MULYURcxjfSAwZDgcyLeJKzG1b9BL98+6YtxkKMZjPLfwQMX9phMRMPANX6LF3VDP7M5GSWAnMv Trk568ROBMSljKU7XjzFrivOYLtn+oM5HqSc9jf8uHfbe5KTLl8odnVgQ6qniJlttsoTxk0f3Tq uS9jRORJBa4YyVhT5sopoTsrAxPlZafLCHtv9zD/O6GjIHk5AK9uq6ZRHKR8/qiJf9eYXdzHyp2 949IQEE71+rInMxcYWjjiZjDl2PnQ/v+KWOSms6Be890tRXeyV5bL9MFgqPYN6VsDkllD5LUouX lEhaWJ8HIuEeaUzC4REk124DK/wNRtA9YPmkExi5ohmfvqKV3i5gAifkzF1dTOb1M1ChpDVrBC1 U1VIpWct/4X0IKA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/pci/solo6x10/solo6x10-gpio.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-gpio.c b/drivers/media/pci/solo6x10/solo6x10-gpio.c index f51f865c69bd7b04fac7a1f951c734965d8fc993..b16a8453a62afd5a420b03bfb1967d18e1cb1167 100644 --- a/drivers/media/pci/solo6x10/solo6x10-gpio.c +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c @@ -127,8 +127,8 @@ static int solo_gpiochip_get(struct gpio_chip *chip, return 1 & (ret >> (offset + 8)); } -static void solo_gpiochip_set(struct gpio_chip *chip, - unsigned int offset, int value) +static int solo_gpiochip_set(struct gpio_chip *chip, + unsigned int offset, int value) { struct solo_dev *solo_dev = gpiochip_get_data(chip); @@ -136,6 +136,8 @@ static void solo_gpiochip_set(struct gpio_chip *chip, solo_gpio_set(solo_dev, 1 << (offset + 8)); else solo_gpio_clear(solo_dev, 1 << (offset + 8)); + + return 0; } #endif @@ -156,7 +158,7 @@ int solo_gpio_init(struct solo_dev *solo_dev) solo_dev->gpio_dev.get_direction = solo_gpiochip_get_direction; solo_dev->gpio_dev.get = solo_gpiochip_get; - solo_dev->gpio_dev.set = solo_gpiochip_set; + solo_dev->gpio_dev.set_rv = solo_gpiochip_set; ret = gpiochip_add_data(&solo_dev->gpio_dev, solo_dev); From patchwork Mon Jun 16 07:18:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 897099 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D85D202F8E for ; Mon, 16 Jun 2025 07:19:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058348; cv=none; b=E9LZWdqRREhp6T0nxL5yiKW0BCbC7/edqXplfHzPxKHads7D7xqp1gXko7RiAyBy8hOnfY7JKmI6hCWxwpwUZOf+KFJsa0kAtSTLcN4kJxNZ2O8tDykpLSCUH9Ts/ckFHw2C9ZF1hSfEXne52cDgpvoMBIC3L94kwqje/MYcY84= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058348; c=relaxed/simple; bh=kgpyXSnZmCFwqfmomq7FGHn3gBVV4OHMPubpvkjXFrI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EyjZs9RhpnUBy+kdst+E0MElNjshjfnyBTygC5SVy8FV2M6xj6YKBM6dRiPlXkAZ4hGVZn2nI5XEk9qmAxC1i3qUceiTeI8fl/JBiA4ukBIR/WgD8E++ZabIKeKc+EQorZQ0pQeGxSHVL16nm5t7JD8h2qPacm3YK6qSliUuDSM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Yk7SGk2c; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Yk7SGk2c" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a4ef2c2ef3so3438975f8f.2 for ; Mon, 16 Jun 2025 00:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058344; x=1750663144; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EmUjxGb9YXlrFmgTBSGtVdHlWeBBc2YrESubaUeQXrg=; b=Yk7SGk2cUaQrxHdo+Cmw3V7rIXT21M8xtRYzyFrUXsM3LttxxV6DkZCLwPZO9BIBd5 sVCpOe7EF/mr37LHz4NXISyWxZFNDqqkl4jerxFg7+tu/draaozz3cIL6v+EeA4AvXTa k4PpFOE6ice0zu3SaQjOonFN/ohGT3QJMH/JfFUJKWSunO+wQ6dAxsK8Vlg8mHVvg86C xIBW6WEgLmPmjWhqv4nkv+GNaDtM6xpR/nD5p9/IVfkkyz13SVYc9BxCaUBwsTKh4W32 it1buN3iyNUXO0JFXpBT+ekoJpvF9LSBZVYNz7mNOjfxaLfx31u8l4F0efblzhAq5AbY mttQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058344; x=1750663144; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EmUjxGb9YXlrFmgTBSGtVdHlWeBBc2YrESubaUeQXrg=; b=fzzxNrbmwewkuj4yFd2nZUEQiyUqM56Phe4DtEVOKoLvfNOtHt6uZwVrej2669RwvF N5ZUntN8WRJHH8ttpNaOgfy/MZJreHZkKpfs/926hc5pOSyXEb49YEm5nurqPyavM3gR 1FuaAzMmYtMlTuvox9qePo7QhZpZa4L1yRlotl0L1n2HR/lky7EnX7RMk0m8Xmli8HJB TMz4EquB55NhssDVEaIwUtQxTsWiOB8PBz6akBV/U70QbWnczPMo9qdgk297tYI7y1wQ yeDVYUyg/qfhev+tuKsGMf/1t/M1kT3kgrQilyzuCOXO/QX6T0tjD9XF9gMz35ExqdWP 9GhQ== X-Forwarded-Encrypted: i=1; AJvYcCW1VVp8efQYaJD782tKBiYaYBZ8ObAqUffzbyA+IJcIjrOt6zA/sgF3vry8rDJWA+O3stZmtC4x051b@vger.kernel.org X-Gm-Message-State: AOJu0Yz55fD9L9wJmYCj1iKxtxCpHYxIM0dWZnsyVSPARJohFdqM9YmK 9xgXn0+pGiFOKVBq7xdrLTzLANeLaqhaeu+RQPk1/cBGmSqL7P6QHp0WmmgbLhnVlHU= X-Gm-Gg: ASbGncuf7irfKWsoMFwVXmWKLtuNJh+S1QBcdc7X5OXP0hAgzmSY2HRFOmDhCmOSmay 8117twfIHrMyXhOhW/1xz/zfYSoToDu8Z23GxP9gmSEsuPjAx+IyP/n8r0fgkFpna3fsTa2dxnT Q0i+ksOzSYtHhbhzCgbcsT83/wBt9C1mMsTCMGecyY0Kug1GZKT8hQDIWnDeD3oukdF8DJZXMz1 zjSGMZQ7vzi+2dUh+RlKBositkFACkPJAlOmWvcH7xY7t7kofhhZfx+e1+APeL1BzLNvoTE+8xI cC/1dElOPp+Oe2OBdyrFlXvm/4RSa6xmkEKpg+zrrvpISgdzWpMcTsIR X-Google-Smtp-Source: AGHT+IGz82INEfm0MrBcQOnfOvjXW+7kZRw4hSg52Kw3fKhlwkINRRZt46P4IvIxeYULedfUDuAn2A== X-Received: by 2002:a05:6000:4308:b0:3a4:cfbf:519b with SMTP id ffacd0b85a97d-3a572c455d4mr7114649f8f.44.1750058344156; Mon, 16 Jun 2025 00:19:04 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.19.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:19:03 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:54 +0200 Subject: [PATCH v2 5/7] media: i2c: ds90ub913: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250616-gpiochip-set-rv-media-v2-5-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1383; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=uirTvdGFKLj1HJ829gQF9CK8Tn6xJqSzhqLKMW/nEqE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8Vg+JQxKi0/cLa/njC60fyp3VsUhtFUxANbk eGSVyRl2Y+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FYAAKCRARpy6gFHHX cu/PEACIrLPskE3Cw9Fq5/8R9425tpr+lSdYx/OQR1KNyOkXNpvTibWSiDJ4ipusnmH870tGlOt XXXBh3avCHvuPMfv8hQN3nANOImkOtLDt6333qnRFAvJsPbiYXvIhzxjBYCaLStZlAIAkjxFCmg Wlc/nS3aaqSUaQIvy55jpV2bL8kiHAISTJhdIEKnlXG3fs/Z/wpgpMeEnjLJyix8k2diDf/L9st Td/YJuetQOMZX6aJYPulZ2VW3OizRSr03tueMjZTWn8a9b80YypEo2QtQW1nVXx49cMi12DlSp9 EMRKglTjv+TSa5gvoIu2th1p7hbbg/XvTYCEryChn0sNuaXbbWLvZ1q82lrrZ/DTQyREyEg49gv hMwSW5kEHAAyZ6SgYDI2sBAbeSLt/ET8x2TFPCps5Ff8sMtArSTZa1k0REaidF9rienGiifo8PE +7HqS2ETNyqQbWX7KFIGJpCMskfQacSrXxzl/2Dst2Z6b2WXPAM29doi+isHi81esf8+fKZGCGh M7FC0jBfBOatPBt4l9HXhmb9U0MXJftJ4yi4GNzIqqsJlvEtxf6qjoG1o30WW7Gd95DSCtzIHae kR9KkQmHmiOA8nOI9y6KZ3iYSDif1AVvXBiW1yf+QAnUi3gfZgwqkpmYp6ls/MvZ1Gx4AJwUdFZ iwenE4uVn5nKqLA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/i2c/ds90ub913.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c index 6d3f8617ef136c6f47871f5886193fe934c6f3b7..c34ffeae5f5080875463b6b6d45acbd9e107d461 100644 --- a/drivers/media/i2c/ds90ub913.c +++ b/drivers/media/i2c/ds90ub913.c @@ -203,9 +203,9 @@ static int ub913_gpio_direction_out(struct gpio_chip *gc, unsigned int offset, 0)); } -static void ub913_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) +static int ub913_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) { - ub913_gpio_direction_out(gc, offset, value); + return ub913_gpio_direction_out(gc, offset, value); } static int ub913_gpio_of_xlate(struct gpio_chip *gc, @@ -235,7 +235,7 @@ static int ub913_gpiochip_probe(struct ub913_data *priv) gc->ngpio = UB913_NUM_GPIOS; gc->get_direction = ub913_gpio_get_direction; gc->direction_output = ub913_gpio_direction_out; - gc->set = ub913_gpio_set; + gc->set_rv = ub913_gpio_set; gc->of_xlate = ub913_gpio_of_xlate; gc->of_gpio_n_cells = 2; From patchwork Mon Jun 16 07:18:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 897098 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 531632101B3 for ; Mon, 16 Jun 2025 07:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058351; cv=none; b=TyfrqmfuqivYU07Qjwkp4cCykbLTwMhUIbjNtz3PVMb6tNPZjFRuAewU0QdDGZoGCO4824Mf4fy29AOns8Z5wwzQaDWQ4hh0JVe4jl6X/tRWWAcNVlIh69Lq4iLunTF6dJ2JYcPdqgIe60SRU3KEcwDnupqpzBZc4YC4K/uZRcQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750058351; c=relaxed/simple; bh=j8Ee5zNRTgD6Im7szjj0YX+ao0qiLzGNAn/JhbhBZbo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R4rA4APqvlfhp4PZsqEidgL+QZzibk2ncTX3Qsnq8naM56iEvmRgw4sztQVhz/wNh42fN6MeoTt1EQZNpqtKLk+rcvdXWOWB03TnDEqPPC7ALbcArJW3/X+ygJYBPzTiw8VqLuj2eZ5isqOzhhL6S6wNro4LRNofAErPC7a48B8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=qDCrGNw6; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="qDCrGNw6" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3a507e88b0aso4083762f8f.1 for ; Mon, 16 Jun 2025 00:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750058348; x=1750663148; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UnEiJ0DPVJeTNWgLtlb3XDcjvamvu9NbT3oHT6+NmYs=; b=qDCrGNw6vOVtCYsWW6pZuP63jtcaTzjRYotoYEfzsBcsOw77W8+OTE6sqlWN2IplRj /Lw4SofKdSF5agcg/Ab3aQvGFlMSFeACELVDKms3zaZU0xZXOttedeNdzTwI9chwpeQM bLJLEOpGSAjSaU37wZiuN0BwFEsRAkGMhvJ5rfDixq87wbIW4eNjy8kG1/o+18mPbrhs w72yENPZ92jOI1BVtK7pToaDHZSwASfVUrdML4MH2Kq7RUWFB6Ep6YoVlYtONRa1X1RH aXZ/3cKlPu4tvP0Zy6Nn2u+UXIEZr+lNCv2zyZKx1b0Jbg/DaIQUONF8U8K9iVv5V5Gs P6qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750058348; x=1750663148; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UnEiJ0DPVJeTNWgLtlb3XDcjvamvu9NbT3oHT6+NmYs=; b=uSSjYxPmrmBiNj7x1z8s7QBuf340EL1BwVkTrVF/ElB6/IT1ghPLf5y2+JoSVc9Tfc SY2yPgVaUcFaFsEzExQ8cy+MSSzyTFbqhpNpK/c9+0JZPf+R55HfebCFC9PwVFs3zYJp Tqnng6FsEvQOaXnUeqtJCnr4tTB0zZWk2J4vXZwtbYzJfnzWVlNdkE3S0WRBGpFPyx+k f5RG1bWf1ETZbRj8Mv8/GpqNJfR1K1AmuQ9K8veyxOtASzoidJoB5MW8R8eKijfrBHG7 ZUnllm2Z9qAIUIHpheXmbnxM+C3sa7su/B6J+aBVkO/J/d9gxy2dPjKWEN5SbbeTbJpG 8nrw== X-Forwarded-Encrypted: i=1; AJvYcCWSjB//k9IvDyqNRMEe2ycwBve1q+j6W+ObKbKkh5JpSpjExxCDe1xG/o9tX5byB4g7GpLyWpoBs+Za@vger.kernel.org X-Gm-Message-State: AOJu0YyEruGxtGvSvkLCRltOC2W98Sk4LTgRqYsxmqETPxZsuyX3Xh0j itzFd4kaxkxyB/zvPta8UW1SjK7j6RimQjhU/f65Qs2avJEkeGAptlWY5Q0HxtsbYfk= X-Gm-Gg: ASbGnctqwhBE5gQ9aYH0pP5TiOcJ0yOLg+HM5uClSfISfetYNqj+MxbtRlrhhEajNWK 0dTTAna3KTqyVS7zGc7+nK9Q/uj6FbNnKy/NVyWyUPAzuDaVVFsQqnTvPZy7rCpWlUa5JmFeQWG FPHiw9Z1l0J1Q1jM82B6djPWx+hRqw3kpUdIFyr84Ol4tSMeENxLBhVWTedSL17GP/L4PusscuN 7Ms0mFUN4Fgaa1JmGWquimSyAVGrrQoDZuzwLaEMLjkNgOsE/Ue+hrPZZpk38vNLTQ47qTkfIAz +bbM9NDbfbu8jjS72jKoamB6VP5acFhr80Ncbc80gG0Vvnz/nVyJBVN+ X-Google-Smtp-Source: AGHT+IF+qO7rWbAY/SNylys3RMK9GUs1aiqLgKMYCwlF9r3dPIWRev8VFgPCt2yqZehByEZR5PrtlA== X-Received: by 2002:a05:6000:430e:b0:3a5:1c3c:8d8d with SMTP id ffacd0b85a97d-3a572e56dc1mr6643153f8f.55.1750058346514; Mon, 16 Jun 2025 00:19:06 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4238:f8a4:c034:8590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a800d9sm10104675f8f.45.2025.06.16.00.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:19:06 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 16 Jun 2025 09:18:56 +0200 Subject: [PATCH v2 7/7] media: i2c: max9286: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250616-gpiochip-set-rv-media-v2-7-6825114f18b0@linaro.org> References: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> In-Reply-To: <20250616-gpiochip-set-rv-media-v2-0-6825114f18b0@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1468; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=HgIaQmZBN+2BMb6XtS/4r6T+Stu0X4lPC1c0+Nqlo58=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoT8VhkafOCJzunwHbvzisJ4lCYekKB0yX6Z1BU lA0/7SwGLeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaE/FYQAKCRARpy6gFHHX ct50D/0R/5NlZeCsQ88EZ/XCDrW343VojK/G9nbfS4hJar5K6EYRhVcDHsK+tMtcwIOj+0f1ozw OjUPWbhs742QvGSlKtHOqOmq0AUJwSteNm3ejtzQa9EYOfB2dfGfxmuV40c36KwLbWsDvqQAiBe yy+ikCLRngH3/7nCo59Lo5rKfr+O8tb4jhbIY2p3R8UPlZEGn5mmyC6Nre6P4qcYRymZ1InB+YS 8pTjnbsKf4znlbuzFq3DCWdw3kkLja6z/U+BK8h5N1wtkoYA26csJVzcxeFCSGTvGX1JbbOa1/E IbzmubKPKPUAiwp5T8yUhuCweat4prnW3G6L53LZ6An5q9WhvnYR/EFOb5IEyxlMLT+mCT6Go+S 99sue8AZtPQ6RZc0UUKhuYM8EvHy0Sr9FylULPazl+k1DxGjqp6udkaAQcJ3fhdtHO5b4bmA1jB X/NVEzdIFrJh8ql+dxLTcROLtdTLpFBf+ErT2WrLXXRttzaGq7fx9ycItE1Ub8uh/kkEaOECwNA SvDORHEtVtlOjehTqC+sd29sNRNVxhLYEA15W0tcZYH5p+cOJt6NVH96vtEMgtZzbnDuLZ4w+oT N8HktFnOdHwD56w/WQ4v+yNbF/AYhECgLsA95l2vZ68K2cNVR8yaGTfzSUZ8b4GL4h+HysK/HlX QKE2oo1JlgG9XGA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/i2c/max9286.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 9fc4e130a273f8547d7e7ec194cade5b5e9c8df2..1d0b5f56f989874e46f87db4a49d935049e6e7ce 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -1193,12 +1193,12 @@ static int max9286_gpio_set(struct max9286_priv *priv, unsigned int offset, MAX9286_0X0F_RESERVED | priv->gpio_state); } -static void max9286_gpiochip_set(struct gpio_chip *chip, - unsigned int offset, int value) +static int max9286_gpiochip_set(struct gpio_chip *chip, + unsigned int offset, int value) { struct max9286_priv *priv = gpiochip_get_data(chip); - max9286_gpio_set(priv, offset, value); + return max9286_gpio_set(priv, offset, value); } static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset) @@ -1220,7 +1220,7 @@ static int max9286_register_gpio(struct max9286_priv *priv) gpio->owner = THIS_MODULE; gpio->ngpio = 2; gpio->base = -1; - gpio->set = max9286_gpiochip_set; + gpio->set_rv = max9286_gpiochip_set; gpio->get = max9286_gpiochip_get; gpio->can_sleep = true;