From patchwork Mon Jun 16 08:57:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anvith Dosapati X-Patchwork-Id: 897283 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B2E427057B for ; Mon, 16 Jun 2025 08:58:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750064313; cv=none; b=SsHZxRQz3Lj7jkHVWDSBRjdEi3L0kPKrbNQGQVL35n6w48+8pphm3XfRSIWXYDOteCE8hnCseUaTh431vhXcbM4AFLwVv4mgV35Q6iJJI8wfMtJ18WcSH3qmJ4zWkwFXm5hYCZ4H4BDtZUdPkg024rorxXrlFoo/xAs7m0dTnZ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750064313; c=relaxed/simple; bh=g7tlwdRNtN0gqtJClqvwnCStjM6vCVUxxCaFkz13PfI=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=okzreILlBx/RfTQpwpPR/bshr6hDKkNc+W0pV1MXRSL/4F8Se22VtimIfwJkHlBcDdTfH0Pt+R/lnXSWQGmCxxx4mN2cxtiw+XaaKuHdKJzK5vAMpPjumAdJ3qEV4dY36+KiGvY+vmfeK/jy+wrsbEVf8ng2IeXs6rZxPy1J3E4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--anvithdosapati.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=JkzNPxan; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--anvithdosapati.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JkzNPxan" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-742c03c0272so5240528b3a.1 for ; Mon, 16 Jun 2025 01:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1750064311; x=1750669111; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=ERVQz1A2O2BXzPah5knZjJSx5XV0pxIWUqYZQG345/A=; b=JkzNPxanarVjXL7Iu8RW6H+YSn7e2LqAE2rbonskKeaGa54b0QtsCjbK7mquaxZkLu bSgnGjTJ4iPfa7PXIOiPD6ZIoGR7n3WAIDimHE6yXUVgtMIaZwFr+cHJV6P1ueO8OO89 vuVgQBw4a6SKkgMD6DXgdDgT4KAY8+WdJy/L8VADaSfB1IyB0WQwOT90teMNHhNClHs+ eFhudXrrMI5Ga95QHpWOq/Ep0t8hhnlcTx8k3O2bxash4G3JRZAD19ZGUhuZOhUETCOD PFwR3VzDbpjgmNHomILvkx7pdtTaqugSB8xzZ5Sc/8y5Vw2KbcmiAzG9LOCRkST1Rxcq Vx1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750064311; x=1750669111; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ERVQz1A2O2BXzPah5knZjJSx5XV0pxIWUqYZQG345/A=; b=gE9pE2oomfM8jYqydnMdddsknR/CJSwhJZUcxGv79KWpiZjT9Szc22kRJxtEgGQ31e /TgX0DDjSo1m7SEXJRCvICqBbUZFlI8BWEdGLXQpDviKMB08bt6MuyImk1S1+tgU35xe eW1NwfIFmat9jhxJvzfEsbVcAzoUU7k86dT9R5nrsCq+kesjt8UgQjEZzuzOcU3cmS6X G2/5SJentKsmZs1Onu2Yha9Hy9rF/sK1Qa+W0tKOzyJGRgd4+AsUGn5Pc2wQcswflKbP C4/DpofjntdXJHSvFJ/kK93bAXnN/VfwKkmLZLltnIRA9FR13g9/QCzF3xn08gxZcPGV chNA== X-Forwarded-Encrypted: i=1; AJvYcCVsdT8qh3De2ET39Ff/CsTkFbP8ct0lCIr4jcMLaWRAzdy65nk/2B1t+s5HKrIk1elTmEUw0uJ+6i7c@vger.kernel.org X-Gm-Message-State: AOJu0Yz5in+P+2W9B/bctNhVzRfEYJCOzpQXQ0CAsxvuBDtVVXDNGLsJ yfeiqFP+eYJr02mGOEJUv6tYa7NVnWqbLaWlyCfFeh9OO8w88JkL01EMI0Esz6vffbqN2B6uPHJ FuuxnsOtTa++Ut+I4Z7PS1aCGhJf7UKl/qT1O3g== X-Google-Smtp-Source: AGHT+IFhXs6n3o6icotL1+3XeLD9ZY9eTAmeu2x57RShZxqj4RSih7awjaXGE2lMq+jpHBr9PWJ3C6BLb0Iepg4J0wUDcg== X-Received: from pgam2.prod.google.com ([2002:a05:6a02:2b42:b0:b2c:2104:8856]) (user=anvithdosapati job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:9ccb:b0:215:eafc:abda with SMTP id adf61e73a8af0-21fbd4d48f6mr11377195637.18.1750064310866; Mon, 16 Jun 2025 01:58:30 -0700 (PDT) Date: Mon, 16 Jun 2025 08:57:34 +0000 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.50.0.rc1.591.g9c95f17f64-goog Message-ID: <20250616085734.2133581-1-anvithdosapati@google.com> Subject: [PATCH v2] scsi: ufs: core: Fix clk scaling to be conditional in reset and restore From: Anvith Dosapati To: Alim Akhtar , Avri Altman , Bart Van Assche Cc: Manivannan Sadhasivam , Subhash Jadavani , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, manugautam@google.com, vamshigajjela@google.com, anvithdosapati , stable@vger.kernel.org From: anvithdosapati In ufshcd_host_reset_and_restore, scale up clocks only when clock scaling is supported. Without this change cpu latency is voted for 0 (ufshcd_pm_qos_update) during resume unconditionally. Signed-off-by: anvithdosapati Fixes: a3cd5ec55f6c7 ("scsi: ufs: add load based scaling of UFS gear") Cc: stable@vger.kernel.org --- v2: - Update commit message - Add Fixes and Cc stable drivers/ufs/core/ufshcd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 4410e7d93b7d..fac381ea2b3a 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -7802,7 +7802,8 @@ static int ufshcd_host_reset_and_restore(struct ufs_hba *hba) hba->silence_err_logs = false; /* scale up clocks to max frequency before full reinitialization */ - ufshcd_scale_clks(hba, ULONG_MAX, true); + if (ufshcd_is_clkscaling_supported(hba)) + ufshcd_scale_clks(hba, ULONG_MAX, true); err = ufshcd_hba_enable(hba);