From patchwork Wed Jun 24 14:57:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191679 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp674551ile; Wed, 24 Jun 2020 08:04:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3tuUSzXmAvVNH404GQd33xJC9FjrwyLAx31wKHLgovTv9PJLxVlPmhiiGsSnCV8RUDeB5 X-Received: by 2002:aa7:d313:: with SMTP id p19mr20941439edq.32.1593011090891; Wed, 24 Jun 2020 08:04:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011090; cv=none; d=google.com; s=arc-20160816; b=DvQw6Iboebo5kXWNcZuvVfiTA6c2XAPE23lLRrhTPvY3c88R5jIPI789TTh36qIGWW 4yiTHUKyVdVuC8WnxiLmhyFMnYaiKz7bW325jujeWvAR3I4LDweMgelDf6rF31PNLafT luUcUxijL3sK4gZX/Qx1EP2luIFQ2eP1KgJntozFXIGaWydzibI96Ecvb5/2Rm6tgNDE AYROv0nt0HPOmK7uDzv0k3s0nsrUCMiiFqzteA9/UNex27Sns2DElde6AXDg29T4U6GT ltVSbzYmpJTX6e3cbgnrxz56meTZd18sFppGveWT+AASKhbVLMHMiZ/hW78N9Mlb+6RI eiCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+OscN/rzPmV+Ca3LDqP3+7QfjG8tQ3er8qfNyGN0efc=; b=uIsSUWNWVStwgAgtzN+kM77N21ud3QJ8TDdgmgu4R4/TvfkXgjBOe9jAFvTG3mFuU1 DfCILE1AqAH+xUQEaIJ4ROKz24RBu4rCE83btbOslRCEFYFIp5jkUqpeTVaa3/DWn4d/ EmczQnehP2WTUZSwmp4H0qhCzPZq5eemwGPBsbKoQ9NbHPdbBzVtlhqauLgZC42nD/ZO 0iabL4a/GLnboP5RhNeqkPgQcFHpXPxcrNYnMjiEWBNwmGxigJR0r8b9zP14CY9n51d/ WBcWzHjSrn3acfGA0dBlS+M9CxM6a/WFVGxpPVTj+16HkA8RpuSUV39x6sO48G+TXIR6 ci4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XNDfNdRi; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e19si14198281edr.418.2020.06.24.08.04.50 for ; Wed, 24 Jun 2020 08:04:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XNDfNdRi; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404358AbgFXPEt (ORCPT ); Wed, 24 Jun 2020 11:04:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404348AbgFXPEr (ORCPT ); Wed, 24 Jun 2020 11:04:47 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5AC1C061795 for ; Wed, 24 Jun 2020 08:04:46 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id g75so2635771wme.5 for ; Wed, 24 Jun 2020 08:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+OscN/rzPmV+Ca3LDqP3+7QfjG8tQ3er8qfNyGN0efc=; b=XNDfNdRiXmh7t9RgId/4XIu21fy4oogY+Nr/WCo6/NyZHQ4Itv6OslAVjjAeFK19iG i0f5xKyDMsV7Y4sxJPI9YCbK1EV5DMyQj7kn5az4goE+ZWa4Hc/EbVOv8PPGwvzyvzbE 4WqWCqGHmNWK5VT5Y/FG+T47fTbw53DNfdHg44MNHKBE2UAvgbjqSEO0jtByy5F7T5G/ ErFuGywjPZ/ZLSOfBNKzhIRi6Zi+cXmpf6gCITOXFnk+trenk9HoqGajs0aLJ5DdlAuo iL8KWarHIl3WczC77gRnj4JI3dHaFMqREtkO9wIJig1PkRUTzCNZ3nVTe0zR5R0gh3Gu h8rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+OscN/rzPmV+Ca3LDqP3+7QfjG8tQ3er8qfNyGN0efc=; b=nOy2zxs4GhvS5eADC0Mp71ldaUEZ+aIosrq0cmqNKRrJmwHn64zDfFm9qUkcE7ldJq MV84VQxIHSMEv6CYEG0adUKR4aw8X4hRzbtJpHdkD+uIatVyb/dm4zCCdTsIrQbxouCm nX9dSBWSypXTLtY5WtZgl9TbD0J4RBGRhIDSc9UfxXG6sKIrHOV9hWR1U8ggTYY+x1p0 L6l8iSbDbj10JCOtEb8oHVc7M2PFKwP5+Fku5qC3vWmJ+WFxZmqj0CBMpTyWu0qnbYCc aIeMw2/lia10q+khY7KLhnIuQBMSpDouyzmg8Skxz/TwqhVIunUTWmmmGCGINOI1d2P2 DjPw== X-Gm-Message-State: AOAM533hMWBB7vu+cX5ZrueyE/TBFqUxiZyL4bdznFUz0D0UIzPyoJnb TPtxWPKUJWIoPXYcHySQLk0hfw== X-Received: by 2002:a7b:cbc5:: with SMTP id n5mr16795235wmi.95.1593011085576; Wed, 24 Jun 2020 08:04:45 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f186sm8200319wmf.29.2020.06.24.08.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:04:44 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Software Engineering Subject: [PATCH 4/8] backlight: ili922x: Remove invalid use of kerneldoc syntax Date: Wed, 24 Jun 2020 15:57:17 +0100 Message-Id: <20200624145721.2590327-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Kerneldoc is for documenting function arguments and return values. Prevents warnings like: drivers/video/backlight/ili922x.c:127: warning: cannot understand function prototype: 'int ili922x_id = 1; ' drivers/video/backlight/ili922x.c:136: warning: cannot understand function prototype: 'struct ili922x ' Cc: Cc: Bartlomiej Zolnierkiewicz Cc: Software Engineering Signed-off-by: Lee Jones --- drivers/video/backlight/ili922x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 Reviewed-by: Daniel Thompson diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c index 8cb4b9d3c3bba..cd41433b87aeb 100644 --- a/drivers/video/backlight/ili922x.c +++ b/drivers/video/backlight/ili922x.c @@ -123,7 +123,7 @@ #define set_tx_byte(b) (tx_invert ? ~(b) : b) -/** +/* * ili922x_id - id as set by manufacturer */ static int ili922x_id = 1; @@ -132,7 +132,7 @@ module_param(ili922x_id, int, 0); static int tx_invert; module_param(tx_invert, int, 0); -/** +/* * driver's private structure */ struct ili922x { From patchwork Wed Jun 24 14:57:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191681 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp674590ile; Wed, 24 Jun 2020 08:04:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyK0mBr6NomkMlrEoRkO+ZrkAy39ppcwEoFSVggbcjDsthkkHO46m2LtgcmzOV1LIrMra8b X-Received: by 2002:a05:6402:6c6:: with SMTP id n6mr26335423edy.277.1593011092918; Wed, 24 Jun 2020 08:04:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011092; cv=none; d=google.com; s=arc-20160816; b=zfmQZhwgbad5SYq5IV1VaJlvSPGUx1eqEN/GFDv02OOsGv/ppPa4InMHBN/Af/Jcgz CfloWAOQySfPm02d36UzQN/wyYdGjumH9h6qA98ZYoj2W5G9cQqNmqSWVpFvs9hBVtN/ PcX5W2cDeTTOfCHUuD1Ormc6ZYImOX+TJd6nJLs5SXfZV0hOKYpTqmuEHfVNzcJMjG9P aJF4HTFwB8payQeG5qGJmTQhBzBqFvtc9PWWS/9i21sjrMZoVkKXE2tExWNwFlOHLkAz 1a/t5AsSJR4PLh2ZqnY/7jzNDlFVMBJqykW7p0yZg7UfX2/JuK6i6E/IGL4ZnQbtOAZa MFaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RVepsW5AvbKSelkDGpeRLJ59PttgtzeSmv2QlhFjJvQ=; b=bgFyIS+WtqJRK4tG6+v07WZQ6GiljZTdIpSycBw6gQEVv1nBYu9tDh3TztsQ/78Jfo IvqHFQp83ShsuxP4AcaQvO89Ja3dq8yN0xz8/ulUvhr01Yt5GnyJcJEAHnzKblR31SWS ei/NKLtpmB7N0QVPU/YRw10XiYVguJDiJkCui0htJpzcU9HIIgWktIbfPYGFZp9SO62N woQb4rs+2QpxSdbJQvz0RrvTsAWYqrNbqNc54RA9EntU+gHQATTYAECEKHr+TaiGahmP OYVpORtjZIUozaHW97LbpjyaCyfBAk6S5lVo4R1iBnAFZXUoCQ7R17+er2lhbCd0C1O3 YrPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LsBw1uV8; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e19si14198281edr.418.2020.06.24.08.04.52 for ; Wed, 24 Jun 2020 08:04:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LsBw1uV8; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404365AbgFXPEu (ORCPT ); Wed, 24 Jun 2020 11:04:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404362AbgFXPEt (ORCPT ); Wed, 24 Jun 2020 11:04:49 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBC47C061796 for ; Wed, 24 Jun 2020 08:04:49 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id h5so2625894wrc.7 for ; Wed, 24 Jun 2020 08:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RVepsW5AvbKSelkDGpeRLJ59PttgtzeSmv2QlhFjJvQ=; b=LsBw1uV8LrG03R4u2wAAHV9lr+txMyw7+BdND15xIDswqXzGkXd922uezxszzxlKxa y6z1rBpFXRbiDLX/DYinCMp07ITmQAaZc4ADuyeddcvqYS9TdDbGAYOWzoL2rDSQWcw9 85nofVUxEK24RYZvCHdW4bsSTMWEs4SAqGBcHF+XCYhgfe54ZZFoXKhSjLS2/c9PD9N3 MjSyj4nMjZzhJNj1+kmNeddik1BNOt9Qx4pJUmMe8atuBq0wU6WIA3OgGX8lEd5hIh7w uQSnwO83jCtGstF7Qtm4upnJkXj8EyJ26Ib+qAdCMXuKvWx55yEiYohCoEgTdLNct4K9 AsXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RVepsW5AvbKSelkDGpeRLJ59PttgtzeSmv2QlhFjJvQ=; b=DJcFAwx1QWibhvIm1J6ftQD2XCwgSQR3X5mkhogNt0p5AdOhQJWJtnLG3sqvCDx1md tgXITm8IjkgHIqis9CHuVJZ0OquTK97+vaUBVJkrJBmipup9X9yu4Vy2Ot8Ioqvdscxi Za08oot3PWc3f8OWUFOD6ctBPkee5HiPv5WyYuOgBzRBZJhN6PIE3bVvJlJyWd7EAqoO 7sfvRcDkudchERibKbGLwlXbQ0nznb6l5qXUis5noRDuD1V0O6N5S4dQj+BHmJH80MTp QGyFdyXgiq0TFiclI3bXc/34YWfJ0XMmY0Pr5IB2ZKJ1Wawqz9n7ZtLzT3C0HMC6goL2 aqog== X-Gm-Message-State: AOAM531L6Df1KwafC8083CD7YJF5Fn5rlyCqM3SRKBxFICee5CEo5dZE HizQ8Sjq4mbtUWz5YsyAgpsAOg== X-Received: by 2002:adf:e782:: with SMTP id n2mr31179657wrm.417.1593011088504; Wed, 24 Jun 2020 08:04:48 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f186sm8200319wmf.29.2020.06.24.08.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:04:47 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jamey Hicks , Andrew Zabolotny Subject: [PATCH 6/8] backlight: backlight: Supply description for function args in existing Kerneldocs Date: Wed, 24 Jun 2020 15:57:19 +0100 Message-Id: <20200624145721.2590327-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Kerneldoc syntax is used, but not complete. Descriptions required. Prevents warnings like: drivers/video/backlight/backlight.c:329: warning: Function parameter or member 'reason' not described in 'backlight_force_update' drivers/video/backlight/backlight.c:354: warning: Function parameter or member 'props' not described in 'backlight_device_register' Cc: Cc: Bartlomiej Zolnierkiewicz Cc: Jamey Hicks Cc: Andrew Zabolotny Signed-off-by: Lee Jones --- drivers/video/backlight/backlight.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index 92d80aa0c0ef1..744ba58488e01 100644 --- a/drivers/video/backlight/backlight.c +++ b/drivers/video/backlight/backlight.c @@ -320,6 +320,7 @@ ATTRIBUTE_GROUPS(bl_device); * backlight_force_update - tell the backlight subsystem that hardware state * has changed * @bd: the backlight device to update + * @reason: reason for update * * Updates the internal state of the backlight in response to a hardware event, * and generate a uevent to notify userspace @@ -344,6 +345,7 @@ EXPORT_SYMBOL(backlight_force_update); * @devdata: an optional pointer to be stored for private driver use. The * methods may retrieve it by using bl_get_data(bd). * @ops: the backlight operations structure. + * @props: pointer to backlight's properties structure. * * Creates and registers new backlight device. Returns either an * ERR_PTR() or a pointer to the newly allocated device.