From patchwork Tue Jun 30 13:33:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192083 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3822276ilg; Tue, 30 Jun 2020 06:33:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPDWQmJpieuknto7CZEasvrlqbdpuPovPl0OhFsU4BrlslcB/UF4JsoBV/nS1fV4K1JF95 X-Received: by 2002:aa7:c2c5:: with SMTP id m5mr22866645edp.214.1593524036969; Tue, 30 Jun 2020 06:33:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593524036; cv=none; d=google.com; s=arc-20160816; b=rQKK+ph8Y0v7jLVk3A9TBRdlywdBxS8kFM/gXNhbloP2Av1V3hICzVTq7pxmsho+JB U+oSiargIs+cmArexlwBlxl4uRAHJxFWbduqR5U9Nw+9pcOSFWcYaEQscxpgpEYN2lyb xDT+/+PRvg2P/8oXR5NeQA4/g9ac4LuUYcX0S1MYHZO8PIBe6RmF0c+I3qb01Nsl20Im yh/HiB8f1sb6PKkkjfWQPinoyzvXiaionsu7KsXK5Ur6iE2E+2vQoFmsLJtQedSsqEZB SxO3BP3CkcbqdhdFBLSrj7YylOj30mky5va964pC4xaWUHqHtn9uzVmFuVbFvKR7iRuR VL0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zyIUTlmpGUcnH+LiKgtC/ATIX5960EbAPmpzyReDmls=; b=qfXZPZtQov/SZfJtYUQfUNEW8+bet3l4uSgk5tqSBJx9uWn9nkXpofW1RoDPVwHVzw Ik5TN9nNsjP0wZcMdwnwAzTE80vxNfieBIQ3r2Fa247T79noaj7JKEWOFWLRHug1jjoT AxxRu17IyU5c/DrM1FPPoS4LGTF29AHGp6N/3RhfNRovdrd9StALAlKULeo5XLLhSDS1 Ad/19GI1yK5H4uo7jZwiGX9zFqla2oVTMDm6rLjNHjsKFpZM9pKE0MQelNYe8MhlWYSP Td5eg0ddvQA6rgLfhDs+LA4R6avWlYaHtLW4xiA00KHswDAgorugH9bZL8XXTSvBy4g9 965A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q6mGE5E3; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ck17si1574683edb.508.2020.06.30.06.33.56; Tue, 30 Jun 2020 06:33:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q6mGE5E3; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388165AbgF3Ndy (ORCPT + 5 others); Tue, 30 Jun 2020 09:33:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388149AbgF3Ndw (ORCPT ); Tue, 30 Jun 2020 09:33:52 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6B59C03E97B for ; Tue, 30 Jun 2020 06:33:51 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id f139so19613059wmf.5 for ; Tue, 30 Jun 2020 06:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zyIUTlmpGUcnH+LiKgtC/ATIX5960EbAPmpzyReDmls=; b=Q6mGE5E3X/8/+zlhENHURAJbLrEQhKKP61fNSre5+zd/awBDhaniAZCqLJv3T/K+xB LLaHcTkwe5z7mGfkbouNMs2GcI+AqRHhuq6Gz1QCCRJe0Y+hn/YHQuGUZWAqb7RUpdaE 70+NaU99UEzrWJmcUxMJBjS1r9r8XFy8753y04wH/FBtreZ39DbEg4yxDeqSHADl49s1 crYCHpqzEp8rRerMgtEmyT9czhG4JiM8cwA7eHXPiSnTgDUgjm80qrR51MCfCoBh7bds M2AxS/fr2tEVYfL0+cYxhEvrKD3lrdVVxo3BgjB+eZHFrUSXOVioVHn0oc/fAVoRStuq SWvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zyIUTlmpGUcnH+LiKgtC/ATIX5960EbAPmpzyReDmls=; b=uWevhmGn+nQ0aNI3s9bdvA466V83tdo8SfPqwqYKG3E5M+jPbeYKpJXt/t0AraPIl3 deTbZ4xgnUwrQymJX56NfmCIfacAberFDyvpy+ubTMs/dNQFFF6LajEJzKvE/7tcAZIg oOFpGJdVg7kfTZlWhICOeOIhfjMShW3OiMS7dWtT8TFRNOimkc7fmgja/ItJpyHpTMJV JGUPqyo8bY5y/S9KPbc1Y/xgVy8Wy2sP6zMMJLqXahdKOfau4zptoFiMzbYJzjI7ae/Q 4f1tJ/eQs1Az+aAfrTXiD8uvOnRsXoN8oWpoVserBRYv2Xh9pcLSWg2xnsbdA+HDgtBM gIaw== X-Gm-Message-State: AOAM530BAeDtpAbRZ+A56c2QnXYyAHTIHLmYJc7GPE2yYD8YUrhk0DFx kQZk++bWlQ7dB68AJZQEvr78Hw== X-Received: by 2002:a05:600c:2058:: with SMTP id p24mr21449910wmg.74.1593524029704; Tue, 30 Jun 2020 06:33:49 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:49 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , Anton Vorontsov Subject: [PATCH 01/10] gpio: gpiolib-of: Provide documentation for of_gpio_spi_cs_get_count() Date: Tue, 30 Jun 2020 14:33:36 +0100 Message-Id: <20200630133345.2232932-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Descriptions for of_gpio_spi_cs_get_count()'s 2 arguments are missing. Document both 'dev' and 'con_id'. Fixes the following W=1 kernel build warnings: drivers/gpio/gpiolib-of.c:36: warning: Function parameter or member 'dev' not described in 'of_gpio_spi_cs_get_count' drivers/gpio/gpiolib-of.c:36: warning: Function parameter or member 'con_id' not described in 'of_gpio_spi_cs_get_count' Cc: Anton Vorontsov Signed-off-by: Lee Jones --- drivers/gpio/gpiolib-of.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.25.1 diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 219eb00542334..236985714ea92 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -25,6 +25,9 @@ /** * of_gpio_spi_cs_get_count() - special GPIO counting for SPI + * @dev: Consuming device + * @con_id: Function within the GPIO consumer + * * Some elder GPIO controllers need special quirks. Currently we handle * the Freescale GPIO controller with bindings that doesn't use the * established "cs-gpios" for chip selects but instead rely on From patchwork Tue Jun 30 13:33:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192084 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3822307ilg; Tue, 30 Jun 2020 06:33:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJys7GWYG7gm8b6pkQZei50r1hCD1kXT4jAwqENW6huSPhDt4RrAHwcuoMTPUyzKN/4IcLbp X-Received: by 2002:aa7:c54e:: with SMTP id s14mr23345956edr.81.1593524039210; Tue, 30 Jun 2020 06:33:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593524039; cv=none; d=google.com; s=arc-20160816; b=ccWXehquFOFjV95zBJO0UCWokW7lVuuPsqlQbzUgntMnfaMkhqZ62VkzGnOgIzTuGg vX9cL8gakBtwkp1NQYKfrG8zZnWQT7Hrc3OTrGkJY3roNw9SCuQD/+lVacjnF2UsqRAJ 7GdQqPnRqP2hjNswHHQtGdGAHkxH36aLOoQ10ZcW9RKy2xwdpIwYQo3o8z6mX8bhb7gD E37nGtA8HIA8ivv2+s4MMTIj4QjBQzY5PeX4oJDfuDHB3DgiSSGutV7z495/M1XS64sN U7uksu1S0WJ7ZiIJWqQLB6ujqtX0PKXW7hSw88J9b+mqZxo7lUh1lWIvvtTtHChpJ1Ni WzwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0KDVLpzHsMQDeKu96sh9LYIj12RVnAxA/ichztsrMZQ=; b=SvqtLcmXqgZh3CEGYYzS269Se3OE2CDULrMhIOEHbjN4E3usTDpPOODU27zECA2Xvx zzpYufYQ9TYRlVmnpWJGn6LmdWEmmW1ro33Q6JxnQgG/MVW1yTz21pTRhW1igBtIqryF rQPZrg44gUYGyznaDxKj6USB2xste+MZBO0zacBDVNrMnaycN4pKNFWKN7qYiyIvfEfi bmNtxiVgMJYFJhN1M/KgbKazw+Uo1QJgO8U0MUvR3m9PX8gKc3Dix8y2re4odUiMeIG7 Z3q+AEKUAvEx3fIxUiWXFr0TTeAuJUOsXs/dmrp7th3Sttarb+7EEPGsg0kDBV9EAWuU Ic9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="x/GhyMw3"; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ck17si1574683edb.508.2020.06.30.06.33.59; Tue, 30 Jun 2020 06:33:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="x/GhyMw3"; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388167AbgF3Ndz (ORCPT + 5 others); Tue, 30 Jun 2020 09:33:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388151AbgF3Ndw (ORCPT ); Tue, 30 Jun 2020 09:33:52 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F05BFC03E97E for ; Tue, 30 Jun 2020 06:33:51 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id j18so18841039wmi.3 for ; Tue, 30 Jun 2020 06:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0KDVLpzHsMQDeKu96sh9LYIj12RVnAxA/ichztsrMZQ=; b=x/GhyMw3/PifnbCbFgYc7YsXMeDkSg5tTzV3oQIeQg6caOEYi+xswGvOI4ODzVR/8n iYpm0sI3ldVEWE09KVrxRclwDY+yPK6PRD4DJgs9uGscSp38D6ptpQ1FCdluuhPOl+3a fjUpiqUFSOdZEY8qRBCBH2z1Xp7eeoe0+lVECx17sZjtUMuLT84RMxJ1egmxJL5M4AyA FyjcF0JSFT6aIyLB57aBRZk7L9szqdI9Oh3iXaf7HgtrY7jWAvB45lA39yduqcbnBQ/4 YDdIIUEW1DQrsDmASh/wUS7qq16C1l2mnsG2iKBst8FVZG1WDGPO9hfscMSITQxIUidG 53Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0KDVLpzHsMQDeKu96sh9LYIj12RVnAxA/ichztsrMZQ=; b=bhZH+ALV4RLyY90KB+8eAxsSUoN0l5pasxcLz2TGS5ciLygdKZj4Kke89c29N0WPTQ dj3fnrEeUCrA5K6YiVlBvTuc1yvW5MyrqVZ5BWm40HBcSEqn4UDcKLEXcfZMbZcUvX1A 81/86d06OWf7vQagcvtj2qNf8XVTfaHe/wISwitmrOebA34aCND0sDvLK1a3vN0EzNdh Q/iirkYBIXfA1KVpUciXi+d4oZPRZgxPMlgswhKy/k7+m7APXcmxn1H/upzN3+QK/DcR 4B1smsnpp31BL08Q7kkVB04bLDw88RkaUeBXv5mjJQQGWZsT7llEHzumhfyIPG1R+mEv tJnQ== X-Gm-Message-State: AOAM531qiZL77pNTpv56Wou+07flONQMFSgkc1tjnXbkDtb914i2+CeO i2AjrsIu5gyQFvxy+OCHIVrrGA== X-Received: by 2002:a1c:80d3:: with SMTP id b202mr22156497wmd.111.1593524030718; Tue, 30 Jun 2020 06:33:50 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:50 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , Joyce Ooi , Tien Hock Loh Subject: [PATCH 02/10] gpio: gpio-altera: Add missing kerneldoc entry and demote comment Date: Tue, 30 Jun 2020 14:33:37 +0100 Message-Id: <20200630133345.2232932-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org 'struct altera_gpio_chip's 'irq_chip' property is undocumented. So add property description to the struct's kerneldoc header. Also demote comment block which is clearly not in kerneldoc format. Fixes the following W=1 warnings: drivers/gpio/gpio-altera.c:34: warning: Function parameter or member 'irq_chip' not described in 'altera_gpio_chip' drivers/gpio/gpio-altera.c:78: warning: Function parameter or member 'd' not described in 'altera_gpio_irq_set_type' drivers/gpio/gpio-altera.c:78: warning: Function parameter or member 'type' not described in 'altera_gpio_irq_set_type' Cc: Joyce Ooi Cc: Tien Hock Loh Signed-off-by: Lee Jones --- drivers/gpio/gpio-altera.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c index cc4ba71e4fe3c..b7932ecc3b613 100644 --- a/drivers/gpio/gpio-altera.c +++ b/drivers/gpio/gpio-altera.c @@ -24,6 +24,7 @@ * @interrupt_trigger : specifies the hardware configured IRQ trigger type * (rising, falling, both, high) * @mapped_irq : kernel mapped irq number. +* @irq_chip : IRQ chip configuration */ struct altera_gpio_chip { struct of_mm_gpio_chip mmchip; @@ -69,7 +70,7 @@ static void altera_gpio_irq_mask(struct irq_data *d) raw_spin_unlock_irqrestore(&altera_gc->gpio_lock, flags); } -/** +/* * This controller's IRQ type is synthesized in hardware, so this function * just checks if the requested set_type matches the synthesized IRQ type */ From patchwork Tue Jun 30 13:33:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192091 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3823003ilg; Tue, 30 Jun 2020 06:34:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyw3qsDSkmcTWTQ1Q575t3bvpcePNNjTSht+OCLo/4sXlJs4DC8/x35q9/J1wnvn9oquREf X-Received: by 2002:a50:a45d:: with SMTP id v29mr22870742edb.284.1593524088349; Tue, 30 Jun 2020 06:34:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593524088; cv=none; d=google.com; s=arc-20160816; b=Pq9MvYrxYYVf9MOhI1Dsl4ghlpOhuHhNKUtju8DsTVBPrJLgE1bxYJk6xY1hY3gJCX OajJYfo4V1CckdAx9aoWmXZ7c41rlIIhNnTfQ2FOZP6f4YvaP5fQ4dhBFyLoG+sL351g CmjyobszxIFkKclQVkEM5MfapzWvgucxmN0RipHgSO0ZSPr6/9h1CN255BD6gsPgJYfa YGpT1udlUJhIsFIl6ko9dI+Qf2fU6177e2LGfpGasloGwpwkTb9xgVwj/OkZXbQeWyQ0 6zvN1+ejYJGqc22FzaFAabxwXi2AejtwBUKZ2iczkSIZbMihYaY8SjPQh+GmkfJLdlzD YkyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+qGhRYBFyg4w70/+i8v0aKH3im1q1Wu84G6qHkN10ns=; b=CIg+Luitao4yb1SOv6S/x0uRCGLpy5Bqd9zRth/O6ToaUVqjNj9DkeQ9WxtIdLLHS3 sObkAhyKObKCSHuSEaffV6H8TNo4MbGaGZkzz01MZaOVbe/9QavGs4sH4zkcpyfKWDZm Av43BpLRpM/bMLQ++sTCD3yGj2yxT/9V9ikow+mwovQmzS+upVowz8ovEfXCYoZ5cf+8 8NiR5CeSqGRfqSiMSMjRsSeOfJykZE4zofJmGmzWpoikfLbabDLevyk/lKbuAIj8DwcD p+XklCMQIiCtVV7jM49GrJNm/Z2pLU30i/uT/12idrr5b5PQkc+qy39mtsfc1ZMwgtYC SRSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="m5TXu/t5"; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id me25si1767817ejb.164.2020.06.30.06.34.48; Tue, 30 Jun 2020 06:34:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="m5TXu/t5"; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388257AbgF3Neh (ORCPT + 5 others); Tue, 30 Jun 2020 09:34:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388129AbgF3Ndy (ORCPT ); Tue, 30 Jun 2020 09:33:54 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FBE7C08C5DC for ; Tue, 30 Jun 2020 06:33:53 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id w3so7159288wmi.4 for ; Tue, 30 Jun 2020 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+qGhRYBFyg4w70/+i8v0aKH3im1q1Wu84G6qHkN10ns=; b=m5TXu/t5DKfMXruQKZB68+3bIMiutcLyKBEStN8LN7fnI7W31+Ke2AzvBR8VwgqjKR LqwayMuHUVg/5efbOBN+c7Jr5PsEe+CE1FN9f+EDZU+XR2HKF77dvsLsvNzwSw9+Sszb /3M/mw8soiSberSwHv7Zi15ZVc7HUq0eVnUrtWiLDFwj5IJXDUbjclnJKU9rbOXe+LbB ONz02j168Rt3Gw6tn+TFBAHJ94k922AEa2refrxFnJrzSG1Zr+nOH/sHdeKLyXNxx50T hfXn4EeRnGQ/vOjTI860tqbnIymxlU+3sB0X9hZgmUyDUB3MDcTHNcsEB6oyKaSQOmbo Snvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+qGhRYBFyg4w70/+i8v0aKH3im1q1Wu84G6qHkN10ns=; b=phA1e6a2zIVkv9RlE5yOs4foZoufyApK1hm9yG8MPkU2LC+AcLyaSMxpIVhG4Y5zIr k9iei9W8RV8/ZUZZNgNPYFnMdcPq7LTlKmsdi25cxDCUdsLzDFCUiGm99/SPl81AQZeQ L9QmdI0oC2a9h5X62pKXSPD1IDoamcvPa38XT4YtEbcOzn0n/Gt+GTu74RzHe/J8ahJx fKCUx2W+YAnFcEmbJj/cAcqOTbR4Y+1Gro6m7RZOTE1/LU/3p+GNUBPgp8eaxU+bgZJh IlaItPcWTSFr977s+yJ2WBbmm92G1K6Btz4vwkDNfw3+5Kq1Wc9JlCWz4UUtJx5dMo0T wtbA== X-Gm-Message-State: AOAM533W1ykD6etiy8hbrJWhXOfbZmCzO/rLDQstf3slJO1MesXUNXbj vAH5Rc4gte7lDQ016cLdm4ix6g== X-Received: by 2002:a1c:16:: with SMTP id 22mr20990748wma.42.1593524031756; Tue, 30 Jun 2020 06:33:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:51 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , Andy Shevchenko Subject: [PATCH 03/10] gpio: gpio-ml-ioh: Fix missing ':' in 'struct ioh_gpio_reg_data Date: Tue, 30 Jun 2020 14:33:38 +0100 Message-Id: <20200630133345.2232932-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org 'struct ioh_gpio_reg_data's 'ien_reg' property is missing a ':' which confuses the kerneldoc tooling/parsers/validators. Replacing it squashes the following W=1 warning: drivers/gpio/gpio-ml-ioh.c:63: warning: Function parameter or member 'ien_reg' not described in 'ioh_gpio_reg_data' Cc: Andy Shevchenko Signed-off-by: Lee Jones --- drivers/gpio/gpio-ml-ioh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c index 92b6e958cfed5..53d4abefa6ff2 100644 --- a/drivers/gpio/gpio-ml-ioh.c +++ b/drivers/gpio/gpio-ml-ioh.c @@ -44,7 +44,7 @@ struct ioh_regs { /** * struct ioh_gpio_reg_data - The register store data. - * @ien_reg To store contents of interrupt enable register. + * @ien_reg: To store contents of interrupt enable register. * @imask_reg: To store contents of interrupt mask regist * @po_reg: To store contents of PO register. * @pm_reg: To store contents of PM register. From patchwork Tue Jun 30 13:33:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192092 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3823010ilg; Tue, 30 Jun 2020 06:34:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRJ7OTGiW3rI6jis1t+XHAPM3tG3do0yiWWjOTtEf7MOjDXzsLwhRHMoARR49qPktDKqTt X-Received: by 2002:a50:9e2e:: with SMTP id z43mr23552816ede.385.1593524088765; Tue, 30 Jun 2020 06:34:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593524088; cv=none; d=google.com; s=arc-20160816; b=Hh3yGJYDf2t0be9Ej+bMXdWolVUKonvvksykul37tFnJv9Ayb+p2SAItAzlbzJ+bZ8 CcmS+ixFcnkKP2I051geLJhwLfPY6r/hmT27oP4JP+jpY7fRN4MIS6cxse2iXHmsXSm8 odB/yt2az9zbP0kImkZVyQ8nYVlV32Ksc4dObpivkEB+KOKoEPJWWmuwDJwfUhs5xPNO 2dd4LWrbHoPoJstwjNreV2pOU4a0/g654xRShtiE5WNlrmLg/UpBzhAUu4rSdI067bqT lKLyjjijFOLp2l/3ghhEMX4kQJ0w+DYMix3RJhXfVDDuj6q68eGZAwnmck1lxT9qoUTS WQUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LxMqnKZ6/vF3Sz1VG4ZmVbGw0fGc694S11E5HGVbx6s=; b=bMJM8NWEGcFFxmlZr2rJenR1PPsmN2uyW3ACIdWJbNK2N7ZeegzcI9h1rhKOVEgvBo ODG6RHOEC38RXId7NDZmBVCXFhxDCm5CSZn3h8zLKOpCg3Ki/GXp8Twq7ViuNzh72jO1 /RCpK5VylVofYq4fcMR+T4KNcbhf42++5GS2Cb7A5fimFW22mL/cXLAzhhARX4ZuuVzx pxH4+6KSqMwzTqTvAA7C2mqMeUTQcQxvHqR2UylB9hOUZ5SSjhoqvLhlqR5una1EVt1n MAUVxAaxLvDf0sEsfHvZNT1LG/W/TqEefyxEGnGWRIJJV+7ssyETYVt3MPfnLOtf1hYA 6Nfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a52p8zpD; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id me25si1767817ejb.164.2020.06.30.06.34.48; Tue, 30 Jun 2020 06:34:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=a52p8zpD; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388254AbgF3Neh (ORCPT + 5 others); Tue, 30 Jun 2020 09:34:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388163AbgF3Ndy (ORCPT ); Tue, 30 Jun 2020 09:33:54 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A53DC03E979 for ; Tue, 30 Jun 2020 06:33:54 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id j18so18841172wmi.3 for ; Tue, 30 Jun 2020 06:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LxMqnKZ6/vF3Sz1VG4ZmVbGw0fGc694S11E5HGVbx6s=; b=a52p8zpDtHp2BZaKl7cLaCsGbQRImiqq+vdYMe+DEp24dRvPaj0y8e3Kju7zD0XhYx CLwU8KT53+rUeG44oD/jA/JijDdkch9F3RMzyJ1ppCeX6KBs/ucps8SozbJzpjtw6mOt jBoBo02vlcgoUfsxeIazznL9FhHExCEjjRFK8stugey1p6cx+rMZ1SxHayD+46hcaVCM 8V8ZwOXV3CqPMIqYBokS0zQGkEJG0UQuUU44tgL2m9+EtAqzEEXvqj+MCGmqaek2aBnk AuLUNAngsZhaTMBEpLkFjYtH/YvrrGCbOElVQH/o+cZUwBRqtDsh5w6OHa0fU394DeRV X+6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LxMqnKZ6/vF3Sz1VG4ZmVbGw0fGc694S11E5HGVbx6s=; b=RPjoFe1DyDalXnvLGzyAIbZd7zPpaID7iyfXc0lr4Yd8VJJwwlGJEaEv8SQTaSSFDF fQb/PQWL1AMCH67OQFcro0Pei5NlpKNclisnAcHTVlJd2SRNup6kzo2TEc0hs2CzBKSn 7wn+60Fk11CZXKcy2J3KlisRR91SUD7nRSg/IuUFWvVBKVg+00nZGoLqj6kL4gGGFNsd +9e3pUEpl/zalDC2E7rXI1Qlqs2CogXZH9mp6V22cOlLn1BUfuIPrQVGgvCxf0+Rja0z DY0YVfwKTUmNmxZBHAOHTBaS7DP9BFBHxFo4VmevWAa6DT4JXQW/LzEMhoD06LLO/FFf H5fA== X-Gm-Message-State: AOAM531wkiByVflTKepN9zrx211tdVk/o+m0wNr55tIvGHo6aYM7gW1v mIeBAs5BryJzVSra0mG2zaplDg== X-Received: by 2002:a1c:1d04:: with SMTP id d4mr22807105wmd.156.1593524032982; Tue, 30 Jun 2020 06:33:52 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:52 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , Orson Zhai , Baolin Wang , Chunyan Zhang Subject: [PATCH 04/10] gpio: gpio-pmic-eic-sprd: Fix incorrectly named property 'map' Date: Tue, 30 Jun 2020 14:33:39 +0100 Message-Id: <20200630133345.2232932-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org A good attempt has been made to properly document 'struct sprd_pmic_eic', but 'map' has been incorrectly described as 'regmap' since the driver's inception in 2018. Fixes the following W=1 kernel build warning: drivers/gpio/gpio-pmic-eic-sprd.c:65: warning: Function parameter or member 'map' not described in 'sprd_pmic_eic' Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Lee Jones --- drivers/gpio/gpio-pmic-eic-sprd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 Reviewed-by: Baolin Wang diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c index 05000cace9b24..9382851905662 100644 --- a/drivers/gpio/gpio-pmic-eic-sprd.c +++ b/drivers/gpio/gpio-pmic-eic-sprd.c @@ -48,7 +48,7 @@ enum { * struct sprd_pmic_eic - PMIC EIC controller * @chip: the gpio_chip structure. * @intc: the irq_chip structure. - * @regmap: the regmap from the parent device. + * @map: the regmap from the parent device. * @offset: the EIC controller's offset address of the PMIC. * @reg: the array to cache the EIC registers. * @buslock: for bus lock/sync and unlock. From patchwork Tue Jun 30 13:33:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192086 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3822394ilg; Tue, 30 Jun 2020 06:34:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoBpuaxdqd4JGAL3d5lPWFi1JM/S+cKW9sCQduPi+d4mvlR20RNrE+xfjh7YMFfBDicUj9 X-Received: by 2002:a50:fd12:: with SMTP id i18mr23589294eds.371.1593524044002; Tue, 30 Jun 2020 06:34:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593524043; cv=none; d=google.com; s=arc-20160816; b=vx6M8RPVfTzCM43B14UmHtoW/1kH/wkXxTUWoEnUwYzXWxHFEyJzwaniPPIUdFTPmd aVKGUXAbaN/GsL69wyQ0QChwDkvnApHcAjo8sOScqea8e9z1P3bOrhG3ZfJuuBw6TGzy 5ZFRtfDHyYrI6wrA5UKPlYNezr17RDHFH0cDce4OmvM3sE3VijqRIW0nAiqlTaNN0WSm +eXWNF22cwGfEekadbHuvmYuh5RUYXIn6//YfOBYRzQwYywNA6g+TkUTLAND9h8/TueC hJaWTqsXV3+sTNwWC+3c2MaedMww75gb0M7H8qM1QrX75Qtq32MdAAbHlOGhFO+urOQo Yvnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mVRFyI7gMPSCpFThQPOO71zLy3/PBdN3qWCTPbMiXks=; b=0nzLmDXLEL5zwHYvhI+AokSp0nhtByQTcJQmEKLdoDzAOtE96vkz2XirsMQ4+K6OoP AchDwr08xpGnjX7Mt2MGFG6gL8v78M2SSC3Wkq7M31T9mGR3th0fPVGqcjIDRDJqTJdY ngqcNIiEDXL7cTi9ecXygwyY00KrXPkE8t+Y6Nt/8fkLZ5/auYqheY+vkzUSHXViCLTc 4pqPnUvao5/e1FadDZmwhZKH0OfnOO/ZqYYwNPpqe6++M4WYORVfMiqA0BI3E2fzBXPD zqt+HkcsILpmwvaHHWNZZk0KhEjJKvi0Xvs5t8Wd2qNn4EA8LAFCGkp6Q+n88R1fgwd8 xG0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qgt19lMG; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j18si1886545eja.217.2020.06.30.06.34.03; Tue, 30 Jun 2020 06:34:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qgt19lMG; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388194AbgF3NeC (ORCPT + 5 others); Tue, 30 Jun 2020 09:34:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388169AbgF3Ndz (ORCPT ); Tue, 30 Jun 2020 09:33:55 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D2D8C03E97E for ; Tue, 30 Jun 2020 06:33:55 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o2so19624617wmh.2 for ; Tue, 30 Jun 2020 06:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mVRFyI7gMPSCpFThQPOO71zLy3/PBdN3qWCTPbMiXks=; b=qgt19lMGK+EwYSjtxdGtnfQI+W4/0k5CuiIuR80c/9n/twpmcJ6PiG2Uu1mz5GFFkK AUTe0bdiZWK0juZgx80T2vbTxbfPXM+cjTrYjRQbjmsbmhbS9C0U6/shpZXE6Z5V5DqD KGdB2MA/Ap0lBLfXKNkTY/YevFiJ0KdsreHz/dM9+h2/Gntcfo7AhMM9o4Qb2RLQYdwj 1lfjqrZazfSzDW2nHscL+gd/e+98e4KmtSfApChaUTKTxwYIIDjTGbfIa+VDaUrRtsT5 F9Qv0dpXUaovM1dIRPgj9VJdlruRfLYko0xsY+TucjB+K42meBmljWjWADwwB4WClmzT O8XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mVRFyI7gMPSCpFThQPOO71zLy3/PBdN3qWCTPbMiXks=; b=icJxH0GlAur6u7AjO0wuLBN3rK8L2jJT1Qp8c+KqGtRSads9ZXQK5xCmMv181tK0JK l8DqvLfGfRVJQbAbsLZZ8xvl+PsXRYneVE7Qlbfvk0q2NyqFcNnFVO0h60fwhJ91b9GB vOiUX6p3DB6Kw5qa4660L1InXndEZjB2d5zAyBsxZsNfhLA6I1OW+chKQwMv0Le9LPlm pQz2ryU9wyYap8x7C0gqF9/ToJkeua8S5IAFNZVQff2SjZHQ4e3/409Dc+5DqWOj10FQ 9MKoHdhMJ85mbS10u2coRrHghL3rbEVS7PijVokqH7rI78r0VxFvXR5W1DdHVcjHRtez eGgA== X-Gm-Message-State: AOAM532Q9/X9O2u/Vo5kLxhMqS9b80j54bw5F4epULIBghKcY9m2XIuY CZENVvLgvyPVqqfwos60o8jKrw== X-Received: by 2002:a05:600c:2f17:: with SMTP id r23mr20601830wmn.167.1593524034128; Tue, 30 Jun 2020 06:33:54 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:53 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , Ludovic Desroches , Andrei Stefanescu Subject: [PATCH 05/10] gpio: gpio-sama5d2-piobu: Demote all kerneldoc headers to basic comment blocks Date: Tue, 30 Jun 2020 14:33:40 +0100 Message-Id: <20200630133345.2232932-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org No attempt has been made to provide proper descriptions for each of the function arguments throughout the file. Simply demote all kerneldoc headers to basic function headers. Fixes the following W=1 kernel build warnings: drivers/gpio/gpio-sama5d2-piobu.c:59: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_setup_pin' drivers/gpio/gpio-sama5d2-piobu.c:59: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_setup_pin' drivers/gpio/gpio-sama5d2-piobu.c:81: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_write_value' drivers/gpio/gpio-sama5d2-piobu.c:81: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_write_value' drivers/gpio/gpio-sama5d2-piobu.c:81: warning: Function parameter or member 'mask' not described in 'sama5d2_piobu_write_value' drivers/gpio/gpio-sama5d2-piobu.c:81: warning: Function parameter or member 'value' not described in 'sama5d2_piobu_write_value' drivers/gpio/gpio-sama5d2-piobu.c:97: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_read_value' drivers/gpio/gpio-sama5d2-piobu.c:97: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_read_value' drivers/gpio/gpio-sama5d2-piobu.c:97: warning: Function parameter or member 'mask' not described in 'sama5d2_piobu_read_value' drivers/gpio/gpio-sama5d2-piobu.c:116: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_get_direction' drivers/gpio/gpio-sama5d2-piobu.c:116: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_get_direction' drivers/gpio/gpio-sama5d2-piobu.c:131: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_direction_input' drivers/gpio/gpio-sama5d2-piobu.c:131: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_direction_input' drivers/gpio/gpio-sama5d2-piobu.c:140: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_direction_output' drivers/gpio/gpio-sama5d2-piobu.c:140: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_direction_output' drivers/gpio/gpio-sama5d2-piobu.c:140: warning: Function parameter or member 'value' not described in 'sama5d2_piobu_direction_output' drivers/gpio/gpio-sama5d2-piobu.c:154: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_get' drivers/gpio/gpio-sama5d2-piobu.c:154: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_get' drivers/gpio/gpio-sama5d2-piobu.c:174: warning: Function parameter or member 'chip' not described in 'sama5d2_piobu_set' drivers/gpio/gpio-sama5d2-piobu.c:174: warning: Function parameter or member 'pin' not described in 'sama5d2_piobu_set' drivers/gpio/gpio-sama5d2-piobu.c:174: warning: Function parameter or member 'value' not described in 'sama5d2_piobu_set' Cc: Ludovic Desroches Cc: Andrei Stefanescu Signed-off-by: Lee Jones --- drivers/gpio/gpio-sama5d2-piobu.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- 2.25.1 Acked-by: Ludovic Desroches diff --git a/drivers/gpio/gpio-sama5d2-piobu.c b/drivers/gpio/gpio-sama5d2-piobu.c index 4d47b2c411868..b7c9506581701 100644 --- a/drivers/gpio/gpio-sama5d2-piobu.c +++ b/drivers/gpio/gpio-sama5d2-piobu.c @@ -49,7 +49,7 @@ struct sama5d2_piobu { struct regmap *regmap; }; -/** +/* * sama5d2_piobu_setup_pin() - prepares a pin for set_direction call * * Do not consider pin for tamper detection (normal and backup modes) @@ -73,7 +73,7 @@ static int sama5d2_piobu_setup_pin(struct gpio_chip *chip, unsigned int pin) return regmap_update_bits(piobu->regmap, PIOBU_WKPR, mask, 0); } -/** +/* * sama5d2_piobu_write_value() - writes value & mask at the pin's PIOBU register */ static int sama5d2_piobu_write_value(struct gpio_chip *chip, unsigned int pin, @@ -88,7 +88,7 @@ static int sama5d2_piobu_write_value(struct gpio_chip *chip, unsigned int pin, return regmap_update_bits(piobu->regmap, reg, mask, value); } -/** +/* * sama5d2_piobu_read_value() - read the value with masking from the pin's PIOBU * register */ @@ -108,7 +108,7 @@ static int sama5d2_piobu_read_value(struct gpio_chip *chip, unsigned int pin, return val & mask; } -/** +/* * sama5d2_piobu_get_direction() - gpiochip get_direction */ static int sama5d2_piobu_get_direction(struct gpio_chip *chip, @@ -123,7 +123,7 @@ static int sama5d2_piobu_get_direction(struct gpio_chip *chip, GPIO_LINE_DIRECTION_OUT; } -/** +/* * sama5d2_piobu_direction_input() - gpiochip direction_input */ static int sama5d2_piobu_direction_input(struct gpio_chip *chip, @@ -132,7 +132,7 @@ static int sama5d2_piobu_direction_input(struct gpio_chip *chip, return sama5d2_piobu_write_value(chip, pin, PIOBU_DIRECTION, PIOBU_IN); } -/** +/* * sama5d2_piobu_direction_output() - gpiochip direction_output */ static int sama5d2_piobu_direction_output(struct gpio_chip *chip, @@ -147,7 +147,7 @@ static int sama5d2_piobu_direction_output(struct gpio_chip *chip, val); } -/** +/* * sama5d2_piobu_get() - gpiochip get */ static int sama5d2_piobu_get(struct gpio_chip *chip, unsigned int pin) @@ -166,7 +166,7 @@ static int sama5d2_piobu_get(struct gpio_chip *chip, unsigned int pin) return !!ret; } -/** +/* * sama5d2_piobu_set() - gpiochip set */ static void sama5d2_piobu_set(struct gpio_chip *chip, unsigned int pin, From patchwork Tue Jun 30 13:33:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192085 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3822387ilg; Tue, 30 Jun 2020 06:34:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwm7hAECtp9R35Bvru8NdkMdwrk82evyG2QqaDiF347UdosnWnvHEJ3ZaL0aP5JXCiifkJQ X-Received: by 2002:a17:906:856:: with SMTP id f22mr17484156ejd.245.1593524043629; Tue, 30 Jun 2020 06:34:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593524043; cv=none; d=google.com; s=arc-20160816; b=R7zr8No6OhJHyQ7f/dmN2hIf9Mw/wc3URlT6eQtscNSdGVshVJ4m28aEk6MEgPGyay H9q3kLzFVJTyKX0qDQGTN77HFh0zk6qMGiz+FYMCMZXxhZjxsvnbdC6qiAyufY8e1WV1 z/dJNTLkUPHJVQtX2kW3u3Gi2nKykLSBaED5/+np4cTdjl6cRZXf22ty9CkLqC2HTYtq 0kvMhdUTypweOP2nHI0VgZNtMPNoOhKR47Hiytu5RHreq9E94CPc6rqPi47zc57Jb+Ja IdUUGPlolndDG99fxp+cyzZ7zx+0OqW/51yieECbffRFK2V5tQzR6qRCS/9JrJizRyKK QB7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ed8H2szCHThwNArdetIOxqgfOUbWnaN816hTwHMkdbs=; b=nU5pdEFDmwasgISj1o+FnDEYWrVfbvDPpBokG41TXW/UPlM3L5WQFPlBA1Jm8KRcce I6/3dqD5pSXzG8SIY5CKQLYA7EkOJYGnkg2BKsQb/ucjB4hOdO6Yw0fEl/nQzYg9UNOn El8MgpjbhNy/2RfSr0+Ry6AnlKcR4Kn2F+O6MKvYzc74SqvKM/BG3YcQeJM6r8TTiaaG 41kHfPe7p1vSPEkMjRCeEUqr3U+/0eT3pH6pniNNnH9sjAGFvXUt/k/93r5IMHhSEhfJ rjLvX6vOU2x01jjWxzRFJ3qVrTNjqJYX4CZ7bZ7qUX7q2nGG3h68sn1v8AGdYvYjivk5 hUVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LDOoBlOc; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j18si1886545eja.217.2020.06.30.06.34.03; Tue, 30 Jun 2020 06:34:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LDOoBlOc; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388193AbgF3NeB (ORCPT + 5 others); Tue, 30 Jun 2020 09:34:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388172AbgF3Nd4 (ORCPT ); Tue, 30 Jun 2020 09:33:56 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FA7DC08C5DF for ; Tue, 30 Jun 2020 06:33:56 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id r12so20129717wrj.13 for ; Tue, 30 Jun 2020 06:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ed8H2szCHThwNArdetIOxqgfOUbWnaN816hTwHMkdbs=; b=LDOoBlOcdm5PNPBUjDlyXJMjFJoTSFbyLvEFfk2MSUYrchcD9tFEd0BZXO9SrTscoH eA/vQ6GAXtpXOUjef9fBRpi0CJvg8ckXzJXuEz09kLvdNWWqgqE1w+ordm7P5ftaJrHD a0mfbn07kQRfTm7ePl7W2Q76YlUgaNcjabzztkrqEVWKBpwBuKDZpQ0ySSp7J3V99l2j FbzF3FM16U5AgKguFp3o6KOWA4WGAskO5BV+OW1Ott1uuGymscZa01d/Fo66kvqK+Cnd 3apKWuCiSlV53s2VaJ5tXUiP4AQaF9MKFHjnCVFdG0y9wiripankDZXkPRCESZJ47G42 r9QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ed8H2szCHThwNArdetIOxqgfOUbWnaN816hTwHMkdbs=; b=n2msv9OjbtVD0SVZrxtjLwzhSWOhQOn3ljmojgsFopGv9eCTmn3vua1SWlC1XPMpnz ra4TmvzSJQd7QXQZgRyeMORwQ028FDPNYw3fps95lXHvXwHn1ddUumItLvyHre/9p7Ys ShrutsI3gXmM0XxgZs4jXY6JZkgpSJvhfENAOGTeSt3ApbZturnC9wjiicIgXZDat/1x O20jQjqAlH5ZIXIv875X9/sdCbMDN0zvGV0fgTHVoHkSD9nepVCmuEUK5mMsG3k3Y5XG R/l7xwflmCbNMeolGGEA9au587syOYeqfepbQfflXal5rCYliutPbRT551IANmoiAATi u00A== X-Gm-Message-State: AOAM531/tFx/wkhJYo1lSLuggxpq/Wx1pRtQcJ52i4A7Pxl2Jin+RYPG hrwO8o4h5g6+fTtYuEeGe9698g== X-Received: by 2002:a05:6000:1006:: with SMTP id a6mr20905598wrx.332.1593524035124; Tue, 30 Jun 2020 06:33:55 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:54 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , Alexander Shiyan Subject: [PATCH 06/10] gpio: gpio-syscon: Fix formatting issues which confuse kerneldoc Date: Tue, 30 Jun 2020 14:33:41 +0100 Message-Id: <20200630133345.2232932-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Kerneldoc expects struct properties to be documented using the syntax '@.*: ', but no '@' has been provided in 'struct syscon_gpio_data's header. Add them to stop confusing kerneldoc. Fixes the following W=1 warnings: drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'compatible' not described in 'syscon_gpio_data' drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'flags' not described in 'syscon_gpio_data' drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'bit_count' not described in 'syscon_gpio_data' drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'dat_bit_offset' not described in 'syscon_gpio_data' drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'dir_bit_offset' not described in 'syscon_gpio_data' drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'set' not described in 'syscon_gpio_data' Cc: Alexander Shiyan Signed-off-by: Lee Jones --- drivers/gpio/gpio-syscon.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.25.1 diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c index 31f332074d7d5..fdd3d497b5350 100644 --- a/drivers/gpio/gpio-syscon.c +++ b/drivers/gpio/gpio-syscon.c @@ -24,16 +24,16 @@ /** * struct syscon_gpio_data - Configuration for the device. - * compatible: SYSCON driver compatible string. - * flags: Set of GPIO_SYSCON_FEAT_ flags: + * @compatible: SYSCON driver compatible string. + * @flags: Set of GPIO_SYSCON_FEAT_ flags: * GPIO_SYSCON_FEAT_IN: GPIOs supports input, * GPIO_SYSCON_FEAT_OUT: GPIOs supports output, * GPIO_SYSCON_FEAT_DIR: GPIOs supports switch direction. - * bit_count: Number of bits used as GPIOs. - * dat_bit_offset: Offset (in bits) to the first GPIO bit. - * dir_bit_offset: Optional offset (in bits) to the first bit to switch + * @bit_count: Number of bits used as GPIOs. + * @dat_bit_offset: Offset (in bits) to the first GPIO bit. + * @dir_bit_offset: Optional offset (in bits) to the first bit to switch * GPIO direction (Used with GPIO_SYSCON_FEAT_DIR flag). - * set: HW specific callback to assigns output value + * @set: HW specific callback to assigns output value * for signal "offset" */ From patchwork Tue Jun 30 13:33:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192087 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3822399ilg; Tue, 30 Jun 2020 06:34:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw24ynl2muYmR24VUpjxl9HTIjnZX62+i5YTf2Xx0x+g6QJZivhU8dChLQeQ7sj6c6fN6HR X-Received: by 2002:aa7:c50e:: with SMTP id o14mr23294707edq.168.1593524044488; Tue, 30 Jun 2020 06:34:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593524044; cv=none; d=google.com; s=arc-20160816; b=WZyJIuufxGSHABatZ/3yZrO3ZaXNfc4DLtMwHDX1yiOTMOt+fS+83izz7Zz1NEoqQp HCIQu5+O3GR38ZPF8GxsP1PekUk6tU6WyPd5QdibUpQFiIX56iht9eq+YrHOZPhppmlN 95iyVfsEfziBaWEDiMBRXpq3RfN18PichCtvc5+P3cK0l1Ilgt5NkkD1nxjlGSi5hjis kpn4/Pgk16xbMClvIlGPFzXiiMmDTjbR+oA8Zenuc6YUdKjjDia3Gde23tPkFyvH5Hsh jG7CU9wQIniUuqyeacAH46px9rEDQwELulCcH06q3NbE2oVxi+JzS6NlZAPm3O7gALiF fdTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Qg/i7Z+DVHnxMJURbtuvnuqmQ2dblOKzOYHmn2TAyNw=; b=AHf2HKNX4s19uZc6J9RAv3HUseLmGDLRV52QFaj6VEo5I3U7VJp7JmIt/uZ4IXn2+k aW+P8mkd9ElDoMndh3RUaMvWe9JSDAnnXvb3HZFmcs26+Nf6yvuVsI+E7yyzwcKbvruV //8gukuE2uAb/iiWrJFdcWGq42/MpJOaNl9amEzWtAQOv3nwACWVJFUtD3TqzpO5XDX/ wWFG6QfM6l5vXcX2xGJHOt6AGoVqvRhGPlafh/tChtgleiL0JMGYzfI68HX34gAcIdJF /c15pr9sjHb0Jl+bRrl78sxtDZasW/hlFG7a7/jDY6tr+zuchoV40RRXdYf+xFvo1DNK oEgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wTYsKZg6; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j18si1886545eja.217.2020.06.30.06.34.04; Tue, 30 Jun 2020 06:34:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wTYsKZg6; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388169AbgF3NeD (ORCPT + 5 others); Tue, 30 Jun 2020 09:34:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388175AbgF3Nd6 (ORCPT ); Tue, 30 Jun 2020 09:33:58 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 838D2C061755 for ; Tue, 30 Jun 2020 06:33:57 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id f139so19613378wmf.5 for ; Tue, 30 Jun 2020 06:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qg/i7Z+DVHnxMJURbtuvnuqmQ2dblOKzOYHmn2TAyNw=; b=wTYsKZg6XOOwxF3oDluUk1u7aO7yNTj639l5CvuRCOC6RNDIbnTV/IcodT/0pqXNw5 pFneNKZwxITWnSGPM7dh/ReDTHF6g0AZZopWTNoTm3SVu8g3gabrkJMYF+fLUxsCAOtc g2sEqrZ62BMpGwWgQhxIyK1xLKtDhgVq7F4kMmb84oNfW36RuTgAnkrQ2AUiRMYHq5mb 5Z1wMXrCHXX73X50iSEhunoIGLBqslyiYCHs+Ekoh9ShjjyXgkgMDYMdvtVrgjQCiCAw crp4lzcA5lAPU0j8es+fPggZvMOjmHObzD87nJW7VuLRDGYln9cRTzANzvJR6PXgUd8P FLzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qg/i7Z+DVHnxMJURbtuvnuqmQ2dblOKzOYHmn2TAyNw=; b=kTMSz0HkLRQtu2QCHTvCEPJJ1PGvi/4JV5CRnwjaoQjTrGj2lu9kjvAw7V7BGZ9tu5 Nq90uPuqqjTa2prCNrl4uqm4YCtDFVU2xiiysX49VOmGSFNG3erNe0xp/opVa1th5P5J OCqxHkWKmebZH5bdh45/M/OCqUC7gSMZg+7T0AMzuwwIVbmLSrLCoQDuYE4uKpro84r8 CHL4aoSSwES4sZ182BqrO+waDFqqaNClXmlilI2V3xC5WVfyn33QBil3J0dbXrQUTjZx xOJfDvCFI+yXMnM+cASe1Xu9/nAvhNFv+0MIcN8/K1Ekl1L8J2YZVrwuDQd16W8b5G5A a5TQ== X-Gm-Message-State: AOAM530DIkv28C8GJBgeCnSRfpEnpwEuTBgHOuqVf70n5ycaWM6Algcz QwHRSNMOtX1IhUOCmLvJRQvo+Q== X-Received: by 2002:a1c:6102:: with SMTP id v2mr22253807wmb.6.1593524036198; Tue, 30 Jun 2020 06:33:56 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:55 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , =?utf-8?q?Diego_Elio_Petten=C3=B2?= Subject: [PATCH 07/10] gpio: gpio-it87: Fix formatting issues which confuse kerneldoc Date: Tue, 30 Jun 2020 14:33:42 +0100 Message-Id: <20200630133345.2232932-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Kerneldoc expects struct properties to be documented using the syntax '@.*: ', but no ':' has been provided in 'struct it87_gpio's header. Add them to stop confusing kerneldoc. Fixes the following W=1 warnings: drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'chip' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'lock' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'io_base' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'io_size' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'output_base' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'simple_base' not described in 'it87_gpio' drivers/gpio/gpio-it87.c:69: warning: Function parameter or member 'simple_size' not described in 'it87_gpio' Cc: "Diego Elio Pettenò" Signed-off-by: Lee Jones --- drivers/gpio/gpio-it87.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.25.1 diff --git a/drivers/gpio/gpio-it87.c b/drivers/gpio/gpio-it87.c index b497a1d18ca9b..8f1be34953ce4 100644 --- a/drivers/gpio/gpio-it87.c +++ b/drivers/gpio/gpio-it87.c @@ -47,13 +47,13 @@ /** * struct it87_gpio - it87-specific GPIO chip - * @chip the underlying gpio_chip structure - * @lock a lock to avoid races between operations - * @io_base base address for gpio ports - * @io_size size of the port rage starting from io_base. - * @output_base Super I/O register address for Output Enable register - * @simple_base Super I/O 'Simple I/O' Enable register - * @simple_size Super IO 'Simple I/O' Enable register size; this is + * @chip: the underlying gpio_chip structure + * @lock: a lock to avoid races between operations + * @io_base: base address for gpio ports + * @io_size: size of the port rage starting from io_base. + * @output_base: Super I/O register address for Output Enable register + * @simple_base: Super I/O 'Simple I/O' Enable register + * @simple_size: Super IO 'Simple I/O' Enable register size; this is * required because IT87xx chips might only provide Simple I/O * switches on a subset of lines, whereas the others keep the * same status all time. From patchwork Tue Jun 30 13:33:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192090 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3822857ilg; Tue, 30 Jun 2020 06:34:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOgDPTXgejHz1HdH4y2cFkz1t8Yb9qXmPGn3djy3V9lApodcKzTpHCd7Mt2WwVrca4cH6V X-Received: by 2002:a17:906:469a:: with SMTP id a26mr17377986ejr.198.1593524077468; Tue, 30 Jun 2020 06:34:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593524077; cv=none; d=google.com; s=arc-20160816; b=UaCI8FwLm/mwzM+gCbZHCONtlprk8yZTE16RW67fJ/TgLCUJCbf9bOGQpSUfEczcZ0 zfpkZ7U0rYX7s6e078nJd7WIYYH7pPP7IAUHWdbfJOhn5xp776kgl+ZTBHYQptVywzrq jaYqlCHj+6MF6dTXaXDs/rinbDT14icsugs5PvTHpRY3OyJ9Q4Bra8yBdMES0wJ9Z5A5 C35BWrRFx8Jwiqppx0Sn+wbSmYx8GYxW0C/MCUuVj9T2wE/VcYADPmDBzPSpcY9LahtW c/XRnC0JjGo8xFVWJKITUW4IdkRF5ZaRVLR7xYHPeht2kB5WLxgwV76smHsNpqb3jvRA R1xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7A8fd8K6Xg2GcpEMDl/hEl1oZDzE0C0aQNCJLDk0izk=; b=NLJXupdjzhAs6yKZqiqaf5gsO3pl+ejYlTA66G9ndmj+4mfU+BFTWbfg89HHg2Fl94 0Vhle4GwX5XiJHbncK1+elK56CbrzJc7b62+WwX0AbYnOEoYvI/AgQZL1Dy3nPW4V87B N+xz3B/6MoFwibjjrNWGwUaeuCr8yH19C52l1XQo7wBV/yN5mGpA7gvVVuQkCPoWqe31 K6Rtd3jEcbBVhaV0FstUhBxtMxrnv1dEX97twYP0oBuroxOOyMwl0isFmNlkcnf2wfNl pQKzpdizsQH7D8Vd2SLUNw0kUD/t8/etkxtjF1C3dD2X9MyrozMq8GrBXJcY3tvZYugA 3ybQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XwN9XpGG; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n11si1672293ejs.209.2020.06.30.06.34.37; Tue, 30 Jun 2020 06:34:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XwN9XpGG; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388175AbgF3Neg (ORCPT + 5 others); Tue, 30 Jun 2020 09:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388182AbgF3Nd7 (ORCPT ); Tue, 30 Jun 2020 09:33:59 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85FFBC08C5DC for ; Tue, 30 Jun 2020 06:33:58 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id g75so18824946wme.5 for ; Tue, 30 Jun 2020 06:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7A8fd8K6Xg2GcpEMDl/hEl1oZDzE0C0aQNCJLDk0izk=; b=XwN9XpGGLLINb9bmDd9M7rq+kabOna2BscILWUe9Ys6KgtxEY+IvgWHLEoz0xXSSe1 tuwsdOmyH6jqNLGgiXb9sxAWHTg8xzvjeuK3NpnVTdmeORXc/6gyDSIH8o1nFbzHzJic 9mxzn+WvbvuC7gCHzWU847yTLCQ9aDVzScRidwsujRs5m/5XB7/akP33NYHmgwaLteWb 5IVrU1IZ+BCLITm0zbvFvVtao1FhFbrp1lU6tlXx+IWW1lpfOnrLK7No9Ji4DgdYUe7k eGwkbeAZy0xAdcYz2AkElYtIHM9E1mzVMV2z+gBLshSbpcRyFtkZNinm5+eXnkBBEgvl UAlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7A8fd8K6Xg2GcpEMDl/hEl1oZDzE0C0aQNCJLDk0izk=; b=PXqHWkgU21PiYzac5GjtfVgvDhlt7TN0r6ilQ+8BB0W/8w1Z1KqpZTfBoPfZCQZGdD 5k8AqALaR5WcavL3jMVPw78j+J5n50t9fe8ItRmXlZZGU9NJX2hbhjv1RAxXKul1cbks HTSt/XkJDz98vXknZ/GukO8045rTvwtmXfWpCMU3WLUOJpqBacgfiRmhMxQc7+9wZsHM kjiMfsDLEhxXz4eVoVXgDhYS5ntXK5g+MYXTKuvKOazvfd10kWrGtfvfluvOV9kZ98fl QuTEuuyreEmozD3IFJEl0U02rP8HzRqgFLbuViT3WQr699gr4LpbmX8SZfu+Ef+ITCzn Z9qQ== X-Gm-Message-State: AOAM533ueGh6ISBWmNu9WKXyVLuT74xVQdJ3ZFYQ1WEEpWtZHKTjoSsr ETYfecLb8jN2OpQJ12i2naiBpA== X-Received: by 2002:a1c:1bc4:: with SMTP id b187mr22909206wmb.105.1593524037244; Tue, 30 Jun 2020 06:33:57 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:56 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , Shravan Kumar Ramani Subject: [PATCH 08/10] gpio: gpio-mlxbf: Tell the compiler that ACPI functions may not be used Date: Tue, 30 Jun 2020 14:33:43 +0100 Message-Id: <20200630133345.2232932-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org ... as is the case when !CONFIG_ACPI. Fixes the following W=1 kernel build warning: drivers/gpio/gpio-mlxbf.c:130:36: warning: ‘mlxbf_gpio_acpi_match’ defined but not used [-Wunused-const-variable=] 130 | static const struct acpi_device_id mlxbf_gpio_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~ Cc: Shravan Kumar Ramani Signed-off-by: Lee Jones --- drivers/gpio/gpio-mlxbf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/gpio/gpio-mlxbf.c b/drivers/gpio/gpio-mlxbf.c index 894aaf55fc96c..1fa9973f55b96 100644 --- a/drivers/gpio/gpio-mlxbf.c +++ b/drivers/gpio/gpio-mlxbf.c @@ -127,7 +127,7 @@ static int mlxbf_gpio_resume(struct platform_device *pdev) } #endif -static const struct acpi_device_id mlxbf_gpio_acpi_match[] = { +static const struct acpi_device_id __maybe_unused mlxbf_gpio_acpi_match[] = { { "MLNXBF02", 0 }, {} }; From patchwork Tue Jun 30 13:33:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192088 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3822762ilg; Tue, 30 Jun 2020 06:34:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzv7Vw4u/YqBG2W0wRarkqC8bZ1wLIAOvus0H4ZMmfL2susoxeRlNrj/PJR6s0pVdizr8ci X-Received: by 2002:a17:906:5283:: with SMTP id c3mr17253572ejm.22.1593524070220; Tue, 30 Jun 2020 06:34:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593524070; cv=none; d=google.com; s=arc-20160816; b=u6+XDDPjgN/aDxmwbYkDq6jLC55PymkVOchziQw3LumLMbXKPk2P8HfRaywgHxZoed makUctlCvMmy5XvbqL+eSKnmmYWfAqiIIMy6l5wDuQuWHbMipjC7bWUujkPn8AUsFYuW UP1CfB07sq26oHRPCxiVJtPC4ZgqzgR6FwnalLb0ebX2YMmGAEnDiQ+JKG75AHFW2XeC qygCZDglgomArI2ihi/7b4O9bQIoLCXpc39/cKzD4eMCeq6zESpumSwkzsAiXFSOe8UW 0mEqZIRkzxPFmvhwtMDzWbBvl+4eUJA72uNfeGHhilXBHpGR5KXegGVxm1UTxtA9YA0u jDJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EdUmnOFS5TbxKtJS43wBP3LOOE3V1mwzgMQ7fgYmUtc=; b=XUW/SlzNqd+G3O7naIoWA01CppepjqVTd2zwAvRFprkDOLj/UMAGJyAzmsa3xp5aMo CejhnKmbcif9gUlJiu5VzhW3l15Bh0GS5NEuNjR+Nsbn8gd7fd3r8VR6UrllujioZTG6 bABq9XhUx3Ksmt6lFAvsufr9F7FABqOdvy1q/uBRewMH/hOryotoWTnhRhOnRp+ssliC DG/vu7UfojwdkaAiwtv5B/50b/arzkePXpI0M0gv81C68FGXgFVY3fejgWOHfLIOem8t L98ib233UDBc6dUYZb2onIOu6Gu6DuuuYldQr5e0bNeB5KNZdE4NeI1KXkV6ENMImV8y 2nCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=b3TJl39h; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id re20si1789653ejb.31.2020.06.30.06.34.29; Tue, 30 Jun 2020 06:34:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=b3TJl39h; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388228AbgF3Ne1 (ORCPT + 5 others); Tue, 30 Jun 2020 09:34:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388187AbgF3NeA (ORCPT ); Tue, 30 Jun 2020 09:34:00 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0321C03E97B for ; Tue, 30 Jun 2020 06:33:59 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id o11so20199222wrv.9 for ; Tue, 30 Jun 2020 06:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EdUmnOFS5TbxKtJS43wBP3LOOE3V1mwzgMQ7fgYmUtc=; b=b3TJl39h/HPdI2rcHJlyhWwzcXi/la21VXhkpUf8MYbyH+xEy9gT+dwl26vyTyJJpN TKYzfmEoTP9+Q1yO4ACJSyyqiV5lmloZPd5X1g5PhacwvpOk6vPRbCgx6FvmWqfqnUEx 1JflzHOd2GaJyjWgT2sUZbp2H5sV9YJFC1Oy/2/HkAroipRDUy0VNFU2/35nhrr4XXSd zhCCnXHoaLbQJZO71+qjKO39/0wxT0NlDB7pNBpZbRoIkMdbdDJHxLtqe6ggwn7ejT6o RGd+Kf5hIBNxVTP+yMGrIexXx53Wi7fs0b/59vKSfzaYDlVAcmjdXLooHBLqFC1lFVVR tGlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EdUmnOFS5TbxKtJS43wBP3LOOE3V1mwzgMQ7fgYmUtc=; b=D5V87nXPWm3rg6sTOqDzZ0RQWMh2lj3RvkHwYGjo9I7Y/lEGUY+GJNmsa7J+dgDv1w iChg38t4Z3MJ0Dj46SiHrcNZ5rb4PrJqijcfZ5WfWwTsqZ7awNzY1oaDeWFy9r3VC96q s0Nv50bbnMV12p2I+C+sRMGay0fV4iJxloMAiJKYaOUaX/5rjI48X/sk80REN4tXNKfW SsjIs19lCfr2x9sVUFRpWcX3xBwok0ene2WkG0vBWSgtTKSCL9rXtWuuMwWiSwE1QZ5o D/a+k83nBusqUYfKbhOWV4bAbQ8fIQt2xvtrj4mualqcihngnBAm0gCT5AksXGCy0YcH 2M4g== X-Gm-Message-State: AOAM533q55EYlxiZSGtreM5YOpf9vDU1SbnZeuGdSZ4NjZOlsylosuSS +ojocvfaOaZFoo8j1VWGHdS/eg== X-Received: by 2002:a05:6000:11cc:: with SMTP id i12mr21614495wrx.224.1593524038502; Tue, 30 Jun 2020 06:33:58 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:57 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , Asmaa Mnebhi Subject: [PATCH 09/10] gpio: gpio-mlxbf2: Tell the compiler that ACPI functions may not be use Date: Tue, 30 Jun 2020 14:33:44 +0100 Message-Id: <20200630133345.2232932-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org ... as is the case when !CONFIG_ACPI. Fixes the following W=1 kernel build warning: drivers/gpio/gpio-mlxbf2.c:312:36: warning: ‘mlxbf2_gpio_acpi_match’ defined but not used [-Wunused-const-variable=] 312 | static const struct acpi_device_id mlxbf2_gpio_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~~ Cc: Asmaa Mnebhi Signed-off-by: Lee Jones --- drivers/gpio/gpio-mlxbf2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 Reviewed-by: Asmaa Mnebhi Signed-off-by: Lee Jones diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c index 94d5efce1721c..861a8d0a84be0 100644 --- a/drivers/gpio/gpio-mlxbf2.c +++ b/drivers/gpio/gpio-mlxbf2.c @@ -309,7 +309,7 @@ static int mlxbf2_gpio_resume(struct platform_device *pdev) } #endif -static const struct acpi_device_id mlxbf2_gpio_acpi_match[] = { +static const struct acpi_device_id __maybe_unused mlxbf2_gpio_acpi_match[] = { { "MLNXBF22", 0 }, {}, }; From patchwork Tue Jun 30 13:33:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192089 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3822761ilg; Tue, 30 Jun 2020 06:34:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwA3MHzDjmA5MR770Rfu/Gc1Z60DK91kJ/G9a6b308XPJ0V0XqCbqJMZdQgSu4DiNpocHW/ X-Received: by 2002:a17:906:aac9:: with SMTP id kt9mr15365013ejb.488.1593524069171; Tue, 30 Jun 2020 06:34:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593524069; cv=none; d=google.com; s=arc-20160816; b=WGjMu2Ik32ePJDD5eXyMLf9W5PRMoeF+8R0/iH+FM2YyGn6n3i1+VLhMgzywRY0gFZ tAfBOvSTHEV7X/j5np9q7Kttc9s8kJKs/cM9oOSLySwr71a/KhNqw1zyJzZCdGAuVIa3 0JP8UawSANWtW6P5Jyu3w853okgLSXqDkIbGvH5MmGSTvaO72dpWiMNCIgkIVS66N/yS XvWhlcNQFI0bn7xcmcJd6qQcwOex+Sq7mpJ2h4mLxszqFyLC1UHA4B9LIZ07Jabtxn9S 4RQB9echBybGz98DJczNVnGJZOcTnCF8yWzh84C20x5qmP+S2vP9a/06guIsnqJ2G1RN ghQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Aqos2NxgL6TqV6vtAHFj09o8FM67bpNGP+lJI0qHUic=; b=C5evAC0e3szUKvB006uZPCgQbG/z9kW1W1clYyQY8entqgVqgqgdX8OBlvZ4OZff79 NcAynATrHXSPWwYDIgkkFfojPh7030fZPcw/YcCZQBJ8zoPhUDsY32AA91czsm2QjVDu Be8CHxevVMKyWWbmB3qCFKBtm66lgzPNnZ9+kTRiCFYDfozjw7+Vn1N5xbYxQObAooh3 Y4XrE5K1Cu5iAzJAjNjiFg9LeUw1EPv8qOaIoFg1bpLBaO5xo9TLwQqA51DnnGFTPWKr LTdizCwu0Bdv3Tw47QuQh1oj2zayqGn09sPFW6WWtZZJA2m48UDK//9SUhvrZypTtpCS rIog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tUr7wg3W; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id re20si1789653ejb.31.2020.06.30.06.34.28; Tue, 30 Jun 2020 06:34:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tUr7wg3W; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732879AbgF3Ne1 (ORCPT + 5 others); Tue, 30 Jun 2020 09:34:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388188AbgF3NeC (ORCPT ); Tue, 30 Jun 2020 09:34:02 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EB87C03E97E for ; Tue, 30 Jun 2020 06:34:01 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z15so8920569wrl.8 for ; Tue, 30 Jun 2020 06:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Aqos2NxgL6TqV6vtAHFj09o8FM67bpNGP+lJI0qHUic=; b=tUr7wg3Wznr91hdBXq50eNTGAccm33bM6tBl1CH1AYKPp7JvNXSuZ0fLootAup+nLZ 7xkoMJq1lUn19jzjKvVfTuaHmloQm+V871dkMcRy9T/bH3j7+hJYql6Pv+wj15mhtdHE z+p3HQuk511W60JvRiiE4ZaHUMC3YYw6cpfddvAPSL7oz94GQ5JxL/eIwpYYN7AI7zER 02C7um3AfjHlBzqoZ7eQY2pLhJAu4hgYRRVaj6miRKRa0ZaL2ZCGcKELxqLOX9qJJhcc kU1S0ht8R33R/0IqyPDqJyOcr1Rc3GifN2tOTQKD40fTDw1T9liHtszfTp2Uvn3pJlru HMeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Aqos2NxgL6TqV6vtAHFj09o8FM67bpNGP+lJI0qHUic=; b=WBpfl2CUbuBTkDAfmgN/HgEhfT0O+4Txma16EA5EUfq4jrlpcgHBc3MeMAWlG5iGI7 JNwPDPdKcYFWOW44CNZ4iubGwnxiSs/hbEG42krpJF+C/Dk0QP4i251frr3SmKFkS8/g plQm3+A8C0QpyGx4b99ZxNR0pus67W8AAEHyhs9K6idcKPB+hpWU30S2ul1sAjXmMC4w b5b3olrD84G8D3qxaWcWzl43A4EAm9klYz3hZA67CtYcTre+TVXyVvDRItqC53vfQ/io n2kWIfnPJ4F55oQaNoBMEN4xtukucf3ZVPIxsfr8ay3UhddmqYm3LPPE9YGNH2bFpaxS 4gSQ== X-Gm-Message-State: AOAM533wfPO23oiArj5cLECEQYon9d09RrgpYGMkGNhzkJwEQgJ62hBd uhqREm7FKxgLd+m+F2cfPG5smA== X-Received: by 2002:a5d:68c7:: with SMTP id p7mr23139275wrw.16.1593524039424; Tue, 30 Jun 2020 06:33:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id z16sm3682464wrr.35.2020.06.30.06.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:58 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones , Asmaa Mnebhi Subject: [PATCH 10/10] gpio: gpio-mlxbf2.c: Provide __releases() annotation to stop confusing Sparse Date: Tue, 30 Jun 2020 14:33:45 +0100 Message-Id: <20200630133345.2232932-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133345.2232932-1-lee.jones@linaro.org> References: <20200630133345.2232932-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Sparse cannot peer into other functions to see when and if locks are acquired and released, thus it simply warns that a 'context imbalance' is detected instead. Let's be kind to Sparse and let it know that this behaviour is intentional. drivers/gpio/gpio-mlxbf2.c:125:12: warning: context imbalance in 'mlxbf2_gpio_lock_acquire' - different lock contexts for basic block drivers/gpio/gpio-mlxbf2.c:151:13: warning: context imbalance in 'mlxbf2_gpio_lock_release' - unexpected unlock Cc: Asmaa Mnebhi Signed-off-by: Lee Jones --- drivers/gpio/gpio-mlxbf2.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 Reviewed-by: Asmaa Mnebhi Signed-off-by: Lee Jones diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c index 861a8d0a84be0..befa5e1099439 100644 --- a/drivers/gpio/gpio-mlxbf2.c +++ b/drivers/gpio/gpio-mlxbf2.c @@ -149,6 +149,8 @@ static int mlxbf2_gpio_lock_acquire(struct mlxbf2_gpio_context *gs) * Release the YU arm_gpio_lock after changing the direction mode. */ static void mlxbf2_gpio_lock_release(struct mlxbf2_gpio_context *gs) + __releases(&gs->gc.bgpio_lock) + __releases(yu_arm_gpio_lock_param.lock) { writel(YU_ARM_GPIO_LOCK_RELEASE, yu_arm_gpio_lock_param.io); spin_unlock(&gs->gc.bgpio_lock);