From patchwork Thu Sep 10 06:54:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249547 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp467224ilk; Wed, 9 Sep 2020 23:57:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKDe1pK46h4VkEWYYgV2MMTlj+0OV9TVaUxNCVTV4w0LS4mjTvBje5jvAF8qDxraDRJY80 X-Received: by 2002:a17:906:3993:: with SMTP id h19mr7580899eje.111.1599721064870; Wed, 09 Sep 2020 23:57:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599721064; cv=none; d=google.com; s=arc-20160816; b=E9VXBMdj5gbZbaEIorpHJayycf9mpkwNcMgROMC8+Qapypuae0ProjE0VTDEVTjVb3 1Y3LovRUmBzbJg6Kc/JQ787lYND5w0qSYUp0JzY+Hai5HaIPPROHRY5401buNvOYAGLx irxbQgUue6Ens1SJMGQIAUuhYtc9j4v8LpZyKY/KKPFdYXe5OCQavLNx/qx/k8XEiOri mec93HhvuC/zO2qp1i7dONoTDm5HJiqNW75Qacc+48qUWGqDopHdTnRrqvjWKWPgQjkv rTDcWYmiEp5hENtnvY4VgBfJ4f/2BIsCqNrjxF1S/hrWkbTeFmvgiuh3Evo5/qbN2Uuh IXHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PbKBLvVHaH2v5GCYgGjIlYZDy81EB6VKwDmcXvqDNxg=; b=if6yqvv9xn/8awz07/S3DkoKACFLssROh+gGJmOjFsBsGLlA5wG1MjNZU1Jz4iAcH+ ya5fFjpCs1jbJyIWSCcUMszU75iIlkxY4eJwpjkENtQPh+Vs5sjq7bPVQ6Wcq9OwCQef H55m9RFj0s9jzdAaAPKO1ZZ+0hREoNPNJYSM2rbfK6IMJvj747kNYOISJF0ftpbWd5jK VOsB+zuEv/erMgolzV0aCI7NcMr4w/XyMYeo8ut6iF9io6B4x4tAfo4oiCt/j5rpXE9h XJLvJzsNO1bs+9gKNeI+1JbiKPrZaopQ0WvbwqOjpLkEHVrc9Df580JKMwJpzqdK/Etz 3A6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n41ntEOL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si2960213ejr.667.2020.09.09.23.57.44; Wed, 09 Sep 2020 23:57:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n41ntEOL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730157AbgIJG4u (ORCPT + 2 others); Thu, 10 Sep 2020 02:56:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729449AbgIJGzY (ORCPT ); Thu, 10 Sep 2020 02:55:24 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46F7DC06179E for ; Wed, 9 Sep 2020 23:54:58 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id s12so5390840wrw.11 for ; Wed, 09 Sep 2020 23:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PbKBLvVHaH2v5GCYgGjIlYZDy81EB6VKwDmcXvqDNxg=; b=n41ntEOLrKSWt8PibAE37DqGU6i4Ib98B7O4G+ELSKMayn33X+WA2m6oj9Mf1sa4yu 6gP2/1WIBLHLD2tW6ZOT9PlerxqYybifK1HCfy6dZ7yaGgNHPcLXuSew0F+qynqicKBf ptLisDmdEUSlMlke34+vjTZ5soOPDnmc+3WtniR0WmLmLZsP2UzzGR6Q4yfGhhxUxwq3 jUWJGb2CQIgBD7cqZn+Nm2KThPlUoWkr1qnGkDOWXFhy0nr5k7Y6iY8S8no6VcBTPt0u AL4t8Ep5ypOKHvWf1Y2e8JxHw7j02kp0PZ0L/FP7OL8LGKf7Ea1QfhwWXrkbTmNA6cS/ bHDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PbKBLvVHaH2v5GCYgGjIlYZDy81EB6VKwDmcXvqDNxg=; b=BCzbRzscC4SWwS3v2y35uiJ6I4XWClWiagYAPmXzhbbA+a1Z7/kk7KUKqy46TIMukB zS9jMNVlIrxizLel9VCRYugHaV4ntf7x8MYxmO3uCOXkWrA/NB5cnfOELb/GJ3ooaCoU ZpjK8SEIiuHzGSniSt8uHdUoUScSyQ1mhMBiceefdl8envo9xPJaOWCBJrRCK8FKWvh/ QmMJ+WvbtUYzDdEIoMJkFlKjMz19WX+jhvuiKh2Y759VIN8uDg8CPf4eW/saUThviIbt kh/mYThcndE9Q83dSMLwbDZ/ziOMmuhk0QZ4JetGTVPZU7QjJreoTUtKsoCxSI6lh7L4 GnVw== X-Gm-Message-State: AOAM5332tJWeA/ybjyyu+4SlcgQZPl8zuao0pUDQbXgPK9yibqE9L9Bv 1SS2TQ49Cd2iThzQ2MTxuBJYQA== X-Received: by 2002:adf:82b1:: with SMTP id 46mr7933654wrc.271.1599720896760; Wed, 09 Sep 2020 23:54:56 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:54:56 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless Subject: [PATCH 03/29] iwlwifi: dvm: tx: Demote non-compliant kernel-doc headers Date: Thu, 10 Sep 2020 07:54:05 +0100 Message-Id: <20200910065431.657636-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org None of these headers attempt to document any function parameters. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/dvm/tx.c:811: warning: Function parameter or member 'priv' not described in 'iwlagn_hwrate_to_tx_control' drivers/net/wireless/intel/iwlwifi/dvm/tx.c:811: warning: Function parameter or member 'rate_n_flags' not described in 'iwlagn_hwrate_to_tx_control' drivers/net/wireless/intel/iwlwifi/dvm/tx.c:811: warning: Function parameter or member 'info' not described in 'iwlagn_hwrate_to_tx_control' drivers/net/wireless/intel/iwlwifi/dvm/tx.c:1267: warning: Function parameter or member 'priv' not described in 'iwlagn_rx_reply_compressed_ba' drivers/net/wireless/intel/iwlwifi/dvm/tx.c:1267: warning: Function parameter or member 'rxb' not described in 'iwlagn_rx_reply_compressed_ba' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/dvm/tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/tx.c b/drivers/net/wireless/intel/iwlwifi/dvm/tx.c index fd454836adbed..e3962bb523289 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/tx.c @@ -803,7 +803,7 @@ static void iwlagn_non_agg_tx_status(struct iwl_priv *priv, rcu_read_unlock(); } -/** +/* * translate ucode response to mac80211 tx status control values */ static void iwlagn_hwrate_to_tx_control(struct iwl_priv *priv, u32 rate_n_flags, @@ -1256,7 +1256,7 @@ void iwlagn_rx_reply_tx(struct iwl_priv *priv, struct iwl_rx_cmd_buffer *rxb) } } -/** +/* * iwlagn_rx_reply_compressed_ba - Handler for REPLY_COMPRESSED_BA * * Handles block-acknowledge notification from device, which reports success From patchwork Thu Sep 10 06:54:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249571 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp480183ilk; Thu, 10 Sep 2020 00:19:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOFC+5WXAiSs7rlNlkQ81pidxemMODuCKEfjAwIBD8sJXo9K7CMvIQugNBaUPxIGjxiqEg X-Received: by 2002:a17:907:7206:: with SMTP id dr6mr7768005ejc.546.1599722392775; Thu, 10 Sep 2020 00:19:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599722392; cv=none; d=google.com; s=arc-20160816; b=UDlkNBkp+swq8cvH/Q3u0jN7lr2157A4Vd0PhnuasvkfoVioay5c9yBjI/haNimUC6 +iQesz1G/TOAT/Hgr6sb7y2TBkxAq/yqNHRlDFpI6lWcmxyvIONj0B7qjIFIi8Wd3f2r TwNzGTsfrH7HwHDBCUm14KSlElWbYIlM4fc9Tn9XajUwKdomn9GRdlSjrj1xi3RQh8Tf pzADeRNlnsEzIDAO4O1+rWUy2AlDMomKZVPErtDgKp+DMQIUC1mVgRXE+S/xF8EskAuL N7mt+YX1IyEY65HWQoRZkVuvH3ppbRvBOXlhZONGgi59dRbba/EU1JlaZJ38JSUrqxJR w8Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gHJHQOsrS1Lf8CGsUJv+l1dxeez2PhjcwxgjgiaDN24=; b=UQnHIRGC+44Ci65Z5rV+BuT7zm0fnBr+q5d4UnB/uPVFWoV5vhF3MNw4wYOJK2T2QF p2J2fhxi3aLA6gpZwshsnTx2g6LjMV3E0b6kOs5RAdsbBIu/nW2/3ICEkXCKPUo4BUCd ZTIrgNEdneuZFfgV35d/2tSJPIsvBXqCQ7uNCr4TWB29qSnIKn4pmJP4zxtNwenteDq+ l+cNJtvm/avQ0DQPCJxYRcHDkJ26flf93D6ZJN8AQnNbEjCq+TVxektD4rC6EOGKpxfT dWJfXBJsWSTilR74xiB6YqLpqhwYc+BLsJiwKeqqyG6YpkFr0U2jtR2zYA5P6q7hJwMe nM7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OzXJQefC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca20si3009529edb.445.2020.09.10.00.19.52; Thu, 10 Sep 2020 00:19:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OzXJQefC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730317AbgIJHTo (ORCPT + 2 others); Thu, 10 Sep 2020 03:19:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729789AbgIJGzs (ORCPT ); Thu, 10 Sep 2020 02:55:48 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F94BC0617A5 for ; Wed, 9 Sep 2020 23:55:01 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id t10so5439702wrv.1 for ; Wed, 09 Sep 2020 23:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gHJHQOsrS1Lf8CGsUJv+l1dxeez2PhjcwxgjgiaDN24=; b=OzXJQefC1e+7qdSuahZz0Emy7KZKAcxdICX2H//vEvlg/EuHw31k+1hvtaAC7dYQTr lmYxXKN5q7uMzNLx5HydBotZmqVI+40XHCq6D8NPEe3e/RRYH4jNuL59hKdngUY3IGbl 7w/A+FKqUhYyisPOd/rfuhV1d7tD56Jx+HwNrUXyecr5D3VqiGccHraOgx3aNf5qa6Bq Q9+82mLEGGt+UWQj5tx/Rdo7Wlkpjw5CvvuBgkHrh87upFJ7UHxkZaeZ+tDfakTXlJXw MH90l/t1JLFLWZ06cuVcaaY+Ig9PsGkdt9pZM4mcII5TSTZpJRIST6ir8pQ6qoTtzDuB ysMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gHJHQOsrS1Lf8CGsUJv+l1dxeez2PhjcwxgjgiaDN24=; b=AOeLPQon+0CU3YbI0XJesO24j/qrqpsBkoKUYcp55XfWfafNjHoRAdmMiQQdg78Ev3 Io3leDNjBS8ILsxlVrQbsYm1R6N6s0pOzo2bttAjbn9H9ERU7r5ytDP8nyOqNk108LOt 5qOQ9/MI+MPuo1mbmT5eufKCFN3xAbhP+G/XnoGPfXb9Tu3CDpTo5/0Y+g1H+JD/I46u Jip+KWnAOvp59KtlvIgfgQLfjGPikjFk/Y08WELMo+BKsdo2nHWHHocZJMbOOh8Dg41C FuQwwAIjF+PBQo7QF2wkScLzRNIzDD87DYMTxtwxCL0WjDhiIs02R8sM/rOVBA/jXLHd SIlw== X-Gm-Message-State: AOAM532NBEqxYpRu8ISK9o/OPzPE1uDfr/O4gLemsmCqDTAcHkBsIP4N 5ZfgjzloadIwjRunk4KMYQ/PwwfG8vfKVg== X-Received: by 2002:adf:eece:: with SMTP id a14mr7071043wrp.330.1599720900244; Wed, 09 Sep 2020 23:55:00 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:54:59 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , wil6210@qti.qualcomm.com, Maya Erez Subject: [PATCH 06/29] wil6210: Fix a couple of formatting issues in 'wil6210_debugfs_init' Date: Thu, 10 Sep 2020 07:54:08 +0100 Message-Id: <20200910065431.657636-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kerneldoc expects attributes/parameters to be in '@*.: ' format and gets confused if the variable does not follow the type/attribute definitions. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'wil' not described in 'wil6210_debugfs_init_offset' drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'dbg' not described in 'wil6210_debugfs_init_offset' drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'base' not described in 'wil6210_debugfs_init_offset' drivers/net/wireless/ath/wil6210/debugfs.c:456: warning: Function parameter or member 'tbl' not described in 'wil6210_debugfs_init_offset' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Reviewed-by: Maya Erez Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/debugfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c index 11d0c79e90562..2d618f90afa7b 100644 --- a/drivers/net/wireless/ath/wil6210/debugfs.c +++ b/drivers/net/wireless/ath/wil6210/debugfs.c @@ -443,10 +443,10 @@ DEFINE_DEBUGFS_ATTRIBUTE(wil_fops_ulong, wil_debugfs_ulong_get, /** * wil6210_debugfs_init_offset - create set of debugfs files - * @wil - driver's context, used for printing - * @dbg - directory on the debugfs, where files will be created - * @base - base address used in address calculation - * @tbl - table with file descriptions. Should be terminated with empty element. + * @wil: driver's context, used for printing + * @dbg: directory on the debugfs, where files will be created + * @base: base address used in address calculation + * @tbl: table with file descriptions. Should be terminated with empty element. * * Creates files accordingly to the @tbl. */ From patchwork Thu Sep 10 06:54:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249570 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp479567ilk; Thu, 10 Sep 2020 00:18:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzygCI0b7nMRrgVwdQBvb64DPMkvRfsadUkPLa1BQ+GJY+LLOrfiS73N7rxDd7UHhRj+3HP X-Received: by 2002:a17:906:4e4a:: with SMTP id g10mr7133879ejw.274.1599722325832; Thu, 10 Sep 2020 00:18:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599722325; cv=none; d=google.com; s=arc-20160816; b=rZLUWptYscalW8yR1/IBG3S6uTB2OqUzmlP8oZGHq/qCs0ouc/8hOw1QBvtdSTWit9 /G+cq1BaYAnoGhrWPECjn21oNL/B9FTDuvbbPJexeOXeeI/DNPNNTDDgq1DzTf26ygHx 2L0prSxc98J8LTEY7z1Z190bxSOBNS/k2Qx2QgbksDW/nDiHyUk7iowRGR32MeoYVtgd 7LkFJ/waRT4Fgiv1gC2HLZN8UxE8OQE/1sNNQJ13tyNiQJOF6q4UMXPI13E5Tkh97Cw2 MhdYpPX5a+tx4Yo1dLSWZ9j4oxEdyGVDIQ1rlQOtL+E73xS8/Y7H7LkD6GMr9fwInhIr 6YGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=glqW/Gnt3wlpIqCq2zLjhjH68Neg4Dhca059SWlN3nQ=; b=0a2WGnbfbG4T5Sorq/hK6OsxxpinUXzlZjtaKKof/dCYJm73o/ImGyjL4gsOTJjeEW Woq0F9Va5ywipF9rVo7mSHuo5K0oAA2WDlSnmXAq9CgpBMvw3kARo/WdAwqnpwtKJfiJ cGYk1839D7Q3DwxDbH86TDgYvbth4AYRtm+LcrU3xL3+FHYe15VP2PXpFQSlJed8NgVZ oh98dFoxelPjh+1MoVYYFbzYMoqkna73M8/k4xsAaDwwMPZoGnfjnkM001Pp1EV+IqDJ smdLf1SmddhBww3P8T8VdO7rWZeqWjzpuVv+TT9Ac0ZRMTqk7Fdchad1NJc1RE+FwgWm ydtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x1yK7ffZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x25si2899596edi.558.2020.09.10.00.18.45; Thu, 10 Sep 2020 00:18:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x1yK7ffZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730355AbgIJHSi (ORCPT + 2 others); Thu, 10 Sep 2020 03:18:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730025AbgIJGz7 (ORCPT ); Thu, 10 Sep 2020 02:55:59 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFB09C0617AB for ; Wed, 9 Sep 2020 23:55:02 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id t10so5439753wrv.1 for ; Wed, 09 Sep 2020 23:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=glqW/Gnt3wlpIqCq2zLjhjH68Neg4Dhca059SWlN3nQ=; b=x1yK7ffZ3J3xAQzQZqR4Endaib4uWtU22Q6EA7ozusuppeg1M2uuzMZRIC6HH3Vvab 7mpNSeB5DZIaTyd1bXOfG1yXjX7RqVJTlhMvBIL+LvbVGvcQdaydo6toV8eQVEw6ltf0 edDwaZZsuVuoktbaZyDJwGAZo9IczmTViYQG6gRewbuJZ7LjgCxLcavKW/GfjEQNPHq1 Jcg2alLeCcS60W6G5cXsLG9kNUZ4jZ8Ny1eDqsrTZKWLe/BsvV4m6ODpjg5f3bojA3Ty 7u/3ke4QssHuk3Z4EO1b5Y4RsPz8xhn7XqeYHeWKDgSzYhmBtGd3h4foVJAOpCDowSa/ Cd1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=glqW/Gnt3wlpIqCq2zLjhjH68Neg4Dhca059SWlN3nQ=; b=GFNMxm+W1i9obCm1V44jnMQ9qPJuoJB2eiNU2p8lj81higqtFfN9KcujG6tnvlADCV FCU93dXRr+ap+SI6NBlQHHRKNNJBTmpF4O4Ld3EhXTjvEwBacUOQbdBmndj+ci69Hb8v KQCMB2M+RXoK4YcjFN5lcN00Brb8/THSFbnAiuvkMFqqn+v13hyOSdZU1Oo/FNykKYvO Xo75uqdadhaxvTjgEYHbhtAQLZdjHAuKMyGYw8hxXSBy6hj84U+EjTMcW1AnHacnBV5K a1ODW5Cpd6267BYmvyohyQ3Z0CkHNFCprCE5wtpzmswt8gHRne83UgDebe8TM9NqFFZq 2dAQ== X-Gm-Message-State: AOAM533I/j5Bw+lPhxWa5VCrWi1YHEq3nXGwQt12Z9sXvqTRz3d4JPBB 8iKz1pU7HLYJ5H9ZP6QucoCvMXmoPo4uwg== X-Received: by 2002:adf:e843:: with SMTP id d3mr5240652wrn.290.1599720901447; Wed, 09 Sep 2020 23:55:01 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:00 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless Subject: [PATCH 07/29] iwlwifi: dvm: sta: Demote a bunch of nonconformant kernel-doc headers Date: Thu, 10 Sep 2020 07:54:09 +0100 Message-Id: <20200910065431.657636-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/dvm/sta.c:244: warning: Function parameter or member 'priv' not described in 'iwl_prep_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:244: warning: Function parameter or member 'ctx' not described in 'iwl_prep_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:244: warning: Function parameter or member 'addr' not described in 'iwl_prep_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:244: warning: Function parameter or member 'is_ap' not described in 'iwl_prep_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:244: warning: Function parameter or member 'sta' not described in 'iwl_prep_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:332: warning: Function parameter or member 'priv' not described in 'iwl_add_station_common' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:332: warning: Function parameter or member 'ctx' not described in 'iwl_add_station_common' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:332: warning: Function parameter or member 'addr' not described in 'iwl_add_station_common' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:332: warning: Function parameter or member 'is_ap' not described in 'iwl_add_station_common' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:332: warning: Function parameter or member 'sta' not described in 'iwl_add_station_common' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:332: warning: Function parameter or member 'sta_id_r' not described in 'iwl_add_station_common' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:390: warning: Function parameter or member 'priv' not described in 'iwl_sta_ucode_deactivate' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:390: warning: Function parameter or member 'sta_id' not described in 'iwl_sta_ucode_deactivate' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:459: warning: Function parameter or member 'priv' not described in 'iwl_remove_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:459: warning: Function parameter or member 'sta_id' not described in 'iwl_remove_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:459: warning: Function parameter or member 'addr' not described in 'iwl_remove_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:614: warning: Function parameter or member 'priv' not described in 'iwl_clear_ucode_stations' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:614: warning: Function parameter or member 'ctx' not described in 'iwl_clear_ucode_stations' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:648: warning: Function parameter or member 'priv' not described in 'iwl_restore_stations' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:648: warning: Function parameter or member 'ctx' not described in 'iwl_restore_stations' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:790: warning: Function parameter or member 'priv' not described in 'is_lq_table_valid' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:790: warning: Function parameter or member 'ctx' not described in 'is_lq_table_valid' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:790: warning: Function parameter or member 'lq' not described in 'is_lq_table_valid' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:822: warning: Function parameter or member 'priv' not described in 'iwl_send_lq_cmd' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:822: warning: Function parameter or member 'ctx' not described in 'iwl_send_lq_cmd' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:822: warning: Function parameter or member 'lq' not described in 'iwl_send_lq_cmd' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:822: warning: Function parameter or member 'flags' not described in 'iwl_send_lq_cmd' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:1270: warning: Function parameter or member 'priv' not described in 'iwlagn_alloc_bcast_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:1270: warning: Function parameter or member 'ctx' not described in 'iwlagn_alloc_bcast_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:1309: warning: Function parameter or member 'priv' not described in 'iwl_update_bcast_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:1309: warning: Function parameter or member 'ctx' not described in 'iwl_update_bcast_station' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:1348: warning: Function parameter or member 'priv' not described in 'iwl_sta_tx_modify_enable_tid' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:1348: warning: Function parameter or member 'sta_id' not described in 'iwl_sta_tx_modify_enable_tid' drivers/net/wireless/intel/iwlwifi/dvm/sta.c:1348: warning: Function parameter or member 'tid' not described in 'iwl_sta_tx_modify_enable_tid' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/dvm/sta.c | 22 ++++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/sta.c b/drivers/net/wireless/intel/iwlwifi/dvm/sta.c index 51158edce15b0..e622948661fa8 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/sta.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/sta.c @@ -234,7 +234,7 @@ static void iwl_set_ht_add_station(struct iwl_priv *priv, u8 index, priv->stations[index].sta.station_flags |= flags; } -/** +/* * iwl_prep_station - Prepare station information for addition * * should be called with sta_lock held @@ -323,7 +323,7 @@ u8 iwl_prep_station(struct iwl_priv *priv, struct iwl_rxon_context *ctx, #define STA_WAIT_TIMEOUT (HZ/2) -/** +/* * iwl_add_station_common - */ int iwl_add_station_common(struct iwl_priv *priv, struct iwl_rxon_context *ctx, @@ -383,7 +383,7 @@ int iwl_add_station_common(struct iwl_priv *priv, struct iwl_rxon_context *ctx, return ret; } -/** +/* * iwl_sta_ucode_deactivate - deactivate ucode status for a station */ static void iwl_sta_ucode_deactivate(struct iwl_priv *priv, u8 sta_id) @@ -451,7 +451,7 @@ static int iwl_send_remove_station(struct iwl_priv *priv, return ret; } -/** +/* * iwl_remove_station - Remove driver's knowledge of station. */ int iwl_remove_station(struct iwl_priv *priv, const u8 sta_id, @@ -601,7 +601,7 @@ static void iwl_sta_fill_lq(struct iwl_priv *priv, struct iwl_rxon_context *ctx, link_cmd->sta_id = sta_id; } -/** +/* * iwl_clear_ucode_stations - clear ucode station table bits * * This function clears all the bits in the driver indicating @@ -636,7 +636,7 @@ void iwl_clear_ucode_stations(struct iwl_priv *priv, "No active stations found to be cleared\n"); } -/** +/* * iwl_restore_stations() - Restore driver known stations to device * * All stations considered active by driver, but not present in ucode, is @@ -773,7 +773,7 @@ static inline void iwl_dump_lq_cmd(struct iwl_priv *priv, } #endif -/** +/* * is_lq_table_valid() - Test one aspect of LQ cmd for validity * * It sometimes happens when a HT rate has been in use and we @@ -807,7 +807,7 @@ static bool is_lq_table_valid(struct iwl_priv *priv, return true; } -/** +/* * iwl_send_lq_cmd() - Send link quality command * @init: This command is sent as part of station initialization right * after station has been added. @@ -1258,7 +1258,7 @@ int iwl_set_dynamic_key(struct iwl_priv *priv, return ret; } -/** +/* * iwlagn_alloc_bcast_station - add broadcast station into driver's station table. * * This adds the broadcast station into the driver's station table @@ -1298,7 +1298,7 @@ int iwlagn_alloc_bcast_station(struct iwl_priv *priv, return 0; } -/** +/* * iwl_update_bcast_station - update broadcast station's LQ command * * Only used by iwlagn. Placed here to have all bcast station management @@ -1341,7 +1341,7 @@ int iwl_update_bcast_stations(struct iwl_priv *priv) return ret; } -/** +/* * iwl_sta_tx_modify_enable_tid - Enable Tx for this TID in station table */ int iwl_sta_tx_modify_enable_tid(struct iwl_priv *priv, int sta_id, int tid) From patchwork Thu Sep 10 06:54:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249569 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp479531ilk; Thu, 10 Sep 2020 00:18:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4KYV4o3Doh69Fr11Tx8mgQwd+VygyNoxOBntDUGtPUa5NmUM7nLDOG5y8MB/xdpp1vdui X-Received: by 2002:a17:906:7856:: with SMTP id p22mr7291192ejm.262.1599722321003; Thu, 10 Sep 2020 00:18:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599722320; cv=none; d=google.com; s=arc-20160816; b=c227TbLl1KPen3G0snrheZO5nyWk9QpH/2u9aJ6claJTQai7UnNG47kRWHUpFonQPa 1FUM7UHC07r6yAHhpQ0w7h5BrmrYdgRY/pegLLzK93jerPCE8DeLwTU81/Z6YZ+5xTwk zAqUsfa5pH0T/ydBXQ+95kxrmRjfFdVFovVxG6/v6U6iqcbqQjpboQrfhSQfgErg0aFO oakmejmvTXv2Ui5OTqzQzxhrSDjfc+PmSCR7yL9YWHH4XYiQNGE1IK3F2ZSQujAxiZx9 kjKpKrMdHBL6O6+ZDSrr7crwxoW9h2U8q55T6nnSfoqpQPP6yYV2+cIBrXHVT8b4Emgt YkhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jkJnqXxLKchHWxEQRJwgWXXCncTXSd4DzK09wyk1JRk=; b=QqBT85ZPg1eZ0VKXXxrLHAvG4+YXevYbqWk9TzDt5zRGPgpuBfhHpnCXAAJrRbN5f0 ZHc/0GXWxzqWp5TvcooCKrP9krjvmih5Q5J6LOO69KR47rRr+673UwSVbs91mthmTsQ3 2cBME6UZD6p5M0a5DxOePk+t2c5mzBPReoLEjU0wmDbHdc8CckYN0O2DoV7eTrQiD77v kf7MhdKONxviSXxpMn0x5fi2Mlg1xidMKGulJFX0ecz7MhPm/XE2c9/+0YN4qU0WVtQk tP13wNGEiZBIKeaoLPI/rnVrwOJd+sdCULx1bRa69TVEq0fFnC/3gy19kCtLUavj3lAL 8eQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DYJqd1E6; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x25si2899596edi.558.2020.09.10.00.18.40; Thu, 10 Sep 2020 00:18:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DYJqd1E6; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730280AbgIJHSb (ORCPT + 2 others); Thu, 10 Sep 2020 03:18:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729911AbgIJG4W (ORCPT ); Thu, 10 Sep 2020 02:56:22 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB965C0617BA for ; Wed, 9 Sep 2020 23:55:03 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id l9so4616050wme.3 for ; Wed, 09 Sep 2020 23:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jkJnqXxLKchHWxEQRJwgWXXCncTXSd4DzK09wyk1JRk=; b=DYJqd1E6K+y9QXkHGAIL5L1tXb7g2KMB7ljmLob/AWKP/B3CE0VlYJ+ZmLnA1JsU+W XzeKdAFsy3l664YPEVaTMsQyAxViTd7y/szoEgOR3KBWpL4pzwKQAlvQV69no2+57iAO sBvvSBR2DbNxQ6bNR8Lzl1VEXxN5F6qC0fQHRQ5TFDTnBG5oX1mfdBa2iCtghm17AxG2 1V8A2AfOYwH8cVYYPvNFSVtl154KCArcSZDn+zizPSCxWsvuJh+9xjvKibqeFwq8iOur LZ6006V9Brdrycp32HJO4D2kbIXGA4X8S9D03PGja1KroF6T4l90Ual4A97wbQRlGduW 3ifg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jkJnqXxLKchHWxEQRJwgWXXCncTXSd4DzK09wyk1JRk=; b=Zg7PAPTIK5sGQc3Ioq4K9qUcOUE/Ya4Id0z0X8G4a84Py2NxzV1CEVgSvCt87HbhE7 g3g1+F1Ze+GOmYqJKmpCSNjL8lwc8pAbwkOqUN10hmF7xvrRCmigI5RjtohvqFGGOdbL KalAAGlUmyHu7pNG8cb7M+b11gFZCbd+Ux01u/IgedBVR02pkNcz0X0zmPDD1dhfx05P 9UactWRcUY4Zb/HC393xvGtAKvA4xviN0Vn4nLnycFGPMGrAqt6Ylv6kH54h8g+PbLml 4dJ5ZRLthR4YcMn7Nk3CQzzN2tVN3PxRP/OTVc5PYlfz1ftv4kgLzroylY4DMzkzg0TN RLlg== X-Gm-Message-State: AOAM530tDmuwxKL+MaP7S1+z4QcJaENShUMROIXzXb+fQDS6f2XpCB1v QpzH8IEGWuX7z7pLEvoNHUbixOq/w01StA== X-Received: by 2002:a1c:c90d:: with SMTP id f13mr7063757wmb.25.1599720902615; Wed, 09 Sep 2020 23:55:02 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:02 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless Subject: [PATCH 08/29] iwlwifi: mvm: ops: Remove unused static struct 'iwl_mvm_debug_names' Date: Thu, 10 Sep 2020 07:54:10 +0100 Message-Id: <20200910065431.657636-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Looks as if it's never been used. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/mvm/ops.c:466:36: warning: ‘iwl_mvm_debug_names’ defined but not used [-Wunused-const-variable=] Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c index d095ff847be92..8e1e9ffbbf59a 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c @@ -460,15 +460,6 @@ static const struct iwl_hcmd_names iwl_mvm_data_path_names[] = { HCMD_NAME(RX_QUEUES_NOTIFICATION), }; -/* Please keep this array *SORTED* by hex value. - * Access is done through binary search - */ -static const struct iwl_hcmd_names iwl_mvm_debug_names[] = { - HCMD_NAME(DBGC_SUSPEND_RESUME), - HCMD_NAME(BUFFER_ALLOCATION), - HCMD_NAME(MFU_ASSERT_DUMP_NTF), -}; - /* Please keep this array *SORTED* by hex value. * Access is done through binary search */ From patchwork Thu Sep 10 06:54:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259274 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5CFBC43461 for ; Thu, 10 Sep 2020 07:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CF5A2078B for ; Thu, 10 Sep 2020 07:19:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f7I7/sOE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729005AbgIJHSQ (ORCPT ); Thu, 10 Sep 2020 03:18:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730116AbgIJG4a (ORCPT ); Thu, 10 Sep 2020 02:56:30 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2537AC061385 for ; Wed, 9 Sep 2020 23:55:06 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id s13so4475401wmh.4 for ; Wed, 09 Sep 2020 23:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dJ089mc+jG2SVa5Dv6nfNI2A1vqsj2U3E/4seGpFeQ0=; b=f7I7/sOE5MX2MwYG0P7i9T0mXlgEc/Xg/VnzodtaTudMO88woJ1hS+eKDB7SiFV+vH TJKdZ0nKQdU1VSMvuH4XRX5knInP266MCc9oE6QVW9gxLQVPipXHQIH0bSkFz3Tu4rWX aoSPEOSa5W5RxBACYetaAr29wn4cv2jy3eFHeaqqx6nGqHAmvtW8UUn841lHiqv7Mfjq vpfncZHtm/KM57VHcU5w1jnbMhIBCKRNh0i8yG5XorXF5b3mUpoz1TpN09FostJpBILe cABq3qJleabsAl1uYBqTq58PkKy5sb6NOfqbfWjbrZf3FUmqGyCb9Q5uJzq1s1gqj1pI mr0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dJ089mc+jG2SVa5Dv6nfNI2A1vqsj2U3E/4seGpFeQ0=; b=jielpzKeTD3nDONlNCE9Fwu6aaFBY3hDl00jH/BIBj1c6tL03CBnBuG4innDcTodJ2 WyblCFpyCr28vvmyfnv1oEXuN3gQOgWRhmPgp4mTBwL/0xEBCDwIspil0wReGrxgBFTq bi7ppqxn73U6uA2XCruzCcITCqYRYnSS5xGzlkz3WEXb/2OcdIK2bm01SwLSTFgMgGjp 2XbVCCOkHHE9k1R2lvPJcoNUwcpcB+rZ/dfh5u1uJ2G9IeQ+4DXrgdhM0WryGGlnt6el ypoFv8LooYJk9oopgiv3tZRFM8hx+YJq0yXt+DKnizY/IN/5DdYUmdzYbB13aX+bRZ0N fVmA== X-Gm-Message-State: AOAM531pWWcYQHVDguSBcUyD8C7YFl1tuZ0rvrJ/gyl7Y0T5Zauj+yaF FWjkJVPFjOUmnqc0SYvmaoVJIA== X-Google-Smtp-Source: ABdhPJx8tJ70LHF6HpOyRTSAL+A8LVJtbLNEjzH/eMpBtN3oalvlMo2E8ReiliY1BaBveE11V2DF9Q== X-Received: by 2002:a05:600c:2246:: with SMTP id a6mr7270091wmm.38.1599720904847; Wed, 09 Sep 2020 23:55:04 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:04 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless Subject: [PATCH 10/29] iwlwifi: mvm: utils: Fix some doc-rot Date: Thu, 10 Sep 2020 07:54:12 +0100 Message-Id: <20200910065431.657636-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fix misnamed, and missing descriptions likely due to doc-rot. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/mvm/utils.c:669: warning: Function parameter or member 'mvm' not described in 'iwl_mvm_send_lq_cmd' drivers/net/wireless/intel/iwlwifi/mvm/utils.c:669: warning: Function parameter or member 'lq' not described in 'iwl_mvm_send_lq_cmd' drivers/net/wireless/intel/iwlwifi/mvm/utils.c:669: warning: Excess function parameter 'sync' description in 'iwl_mvm_send_lq_cmd' drivers/net/wireless/intel/iwlwifi/mvm/utils.c:695: warning: Function parameter or member 'mvm' not described in 'iwl_mvm_update_smps' drivers/net/wireless/intel/iwlwifi/mvm/utils.c:695: warning: Function parameter or member 'vif' not described in 'iwl_mvm_update_smps' drivers/net/wireless/intel/iwlwifi/mvm/utils.c:695: warning: Function parameter or member 'smps_request' not described in 'iwl_mvm_update_smps' drivers/net/wireless/intel/iwlwifi/mvm/utils.c:695: warning: Excess function parameter 'smps_requests' description in 'iwl_mvm_update_smps' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/mvm/utils.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/utils.c b/drivers/net/wireless/intel/iwlwifi/mvm/utils.c index be57b83918506..71eda04946023 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/utils.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/utils.c @@ -658,7 +658,8 @@ int iwl_mvm_reconfig_scd(struct iwl_mvm *mvm, int queue, int fifo, int sta_id, /** * iwl_mvm_send_lq_cmd() - Send link quality command - * @sync: This command can be sent synchronously. + * @mvm: Driver data. + * @lq: Link quality command to send. * * The link quality command is sent as the last step of station creation. * This is the special case in which init is set and we call a callback in @@ -683,8 +684,10 @@ int iwl_mvm_send_lq_cmd(struct iwl_mvm *mvm, struct iwl_lq_cmd *lq) /** * iwl_mvm_update_smps - Get a request to change the SMPS mode + * @mvm: Driver data. + * @vif: Pointer to the ieee80211_vif structure * @req_type: The part of the driver who call for a change. - * @smps_requests: The request to change the SMPS mode. + * @smps_request: The request to change the SMPS mode. * * Get a requst to change the SMPS mode, * and change it according to all other requests in the driver. From patchwork Thu Sep 10 06:54:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259276 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F48C433E2 for ; Thu, 10 Sep 2020 07:17:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A86542078B for ; Thu, 10 Sep 2020 07:17:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XNwHAFYL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730021AbgIJHQv (ORCPT ); Thu, 10 Sep 2020 03:16:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730170AbgIJG44 (ORCPT ); Thu, 10 Sep 2020 02:56:56 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6473C06138D for ; Wed, 9 Sep 2020 23:55:08 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id y15so4635457wmi.0 for ; Wed, 09 Sep 2020 23:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ORROKc4zS4isv+NiIKK9DX3bTWpPv9GkX3d9qrOHUaI=; b=XNwHAFYLI6xhX2vkpi2xe5/VpsSZo+TVtfRCP25YQcCAiV4/6dYbkr3YB6pJ0alyxm bnE2P+slAwR0e/GQAVby3W+CrGYMXZyBdibRXjTM2e1C1r+xtJFknw9hUhi/bNzYbT0z vRnUELULOJ3/LcFTZYfe9/rPL8/6trg4pweA0SAP3V/9rTbxw3sdrQSFoCb8dhHq11DX gTQsbzahldCf4Y+6HXQjIdUoP15WKlhXuCozKezhOx32CeR5ALXBdetvAsL51Hy/gGax hjMuJdvDrLvlSQnkw6piihjPw+cq7FETIrPBvVJaoYHD1I7KepJslP3kZ2qrHS6JPbNa hp4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ORROKc4zS4isv+NiIKK9DX3bTWpPv9GkX3d9qrOHUaI=; b=Mlg5QIUk9a/ZJ04Fc4ZID4CqrptFawY/RgDoZZ4nCEXpEMzkYhZQQ2/sisaRyiF6oX uRR9tEpbw8pZtbvpYBRFUTizcDoHW/6z0IlDScJVom5Qa+6Gs1k11Il39MDv3vZZ2q7n DdkldCNd2of0NS3Z25euaRRUdNLlu8mrdZ24/xHSkKZ3YwwnZa576gVMrJECr4JBgtmG FtgdaxQF3elSqitRDaKK72e9MIen5fgeNN1UId1D62eOndONQaQmEH/tokax30ivuxaX 0hVuODB69PH164g9361/zLZxjrmmSRdYdO+uq++WbEjXhe5RVgcBo0gnbbTrFlkv9n1V HT9A== X-Gm-Message-State: AOAM530IzwwPKX3pte86y4Jd7rJYDmhFddAgXvh85q++6afLRSctd4Hp THik8fw6/jYyzklMletv/iLwoQ== X-Google-Smtp-Source: ABdhPJySiRPvcSS8cpL9kt4JKM6/jZo5Fv2pqIoqM5g4KGu2xB54ejlLh0R8gdhFDjlTVqLNJL8yug== X-Received: by 2002:a1c:5a56:: with SMTP id o83mr7191248wmb.77.1599720907356; Wed, 09 Sep 2020 23:55:07 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:06 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless Subject: [PATCH 12/29] iwlwifi: dvm: rxon: Demote non-conformant kernel-doc headers Date: Thu, 10 Sep 2020 07:54:14 +0100 Message-Id: <20200910065431.657636-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/dvm/rxon.c:695: warning: bad line: drivers/net/wireless/intel/iwlwifi/dvm/rxon.c:701: warning: Function parameter or member 'priv' not described in 'iwl_set_rxon_channel' drivers/net/wireless/intel/iwlwifi/dvm/rxon.c:701: warning: Function parameter or member 'ctx' not described in 'iwl_set_rxon_channel' drivers/net/wireless/intel/iwlwifi/dvm/rxon.c:839: warning: Function parameter or member 'ctx' not described in 'iwl_full_rxon_required' drivers/net/wireless/intel/iwlwifi/dvm/rxon.c:1029: warning: Function parameter or member 'priv' not described in 'iwlagn_commit_rxon' drivers/net/wireless/intel/iwlwifi/dvm/rxon.c:1029: warning: Function parameter or member 'ctx' not described in 'iwlagn_commit_rxon' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/dvm/rxon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/rxon.c b/drivers/net/wireless/intel/iwlwifi/dvm/rxon.c index 6f37c9fac31d9..12a3d464ae640 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/rxon.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/rxon.c @@ -689,7 +689,7 @@ void iwl_set_rxon_ht(struct iwl_priv *priv, struct iwl_ht_config *ht_conf) _iwl_set_rxon_ht(priv, ht_conf, ctx); } -/** +/* * iwl_set_rxon_channel - Set the band and channel values in staging RXON * @ch: requested channel as a pointer to struct ieee80211_channel @@ -826,7 +826,7 @@ static int iwl_check_rxon_cmd(struct iwl_priv *priv, return errors ? -EINVAL : 0; } -/** +/* * iwl_full_rxon_required - check if full RXON (vs RXON_ASSOC) cmd is needed * @priv: staging_rxon is compared to active_rxon * @@ -1007,7 +1007,7 @@ static void iwl_calc_basic_rates(struct iwl_priv *priv, ctx->staging.ofdm_basic_rates = ofdm; } -/** +/* * iwlagn_commit_rxon - commit staging_rxon to hardware * * The RXON command in staging_rxon is committed to the hardware and From patchwork Thu Sep 10 06:54:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259277 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC2B5C433E2 for ; Thu, 10 Sep 2020 07:15:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D31E2075B for ; Thu, 10 Sep 2020 07:15:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PKx+JXyK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730277AbgIJHPK (ORCPT ); Thu, 10 Sep 2020 03:15:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730177AbgIJG45 (ORCPT ); Thu, 10 Sep 2020 02:56:57 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF244C06138F for ; Wed, 9 Sep 2020 23:55:09 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id a9so4638996wmm.2 for ; Wed, 09 Sep 2020 23:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UFEv542Lhp8Q0f61EAB5CHsxrkFJGeJ0ctv6xlXdr9A=; b=PKx+JXyKX6oNJ99FSi8jIpQx1PBRxa50KrYhj3ZbAsKzw5r4J6yMp99KeO9WcPFB8c Ceceo6MnvArOwhTkJxPQXGShN/2HzVNXnJwyGmbROSYiv+l4qdxh92n/WtlKUSGL4PzO I4V7/mu+d/TlApnB0zv0n0RWo2Wf4r6mk3pEueiHLdFzA1m1LBd3gizya+K8Q7zFVx/b 6EoLYVG3XkxF1RHCyOqAOMo3/V1yLm3UW3V4MNcJ/8RMC0wW5a1zinqsSE+SMjhTsZeJ oHUEBLEIe6t2SoaD466VF37n2SXfzhQS8z+1379EkeJp6Oe3m+DmSea4CteDsobRPWxB ZY5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UFEv542Lhp8Q0f61EAB5CHsxrkFJGeJ0ctv6xlXdr9A=; b=CD75ktnk/kdfzg8arUOlmsBEBGzgGh8oxpbIWXl61eEeaOex0jYueMg/yTXfAOJDUH /+tKSAz5bgjYFsk6XSFpUhDBqN0aF2ZJTywBtkJ6eNRvqDHni4pRXTvGtgIaqQfn84WQ CTZkIHc7Zcw5ooyRnOfYCmruklB2K2mkJtwcKabDD7oXem+8uBUzmxYDqcRmJv+JIQvg CD1j/XAqp8SJNu38iweH9NO87XX/adoiLVjz21OsdbqDmWfVQCj3EBw8yuZLTGTB2JUr 55335jJHfxtC+Je5A01gjk1/P/fvmmPUdBeuQzn/y1dZmkdjz+3YIjwQLUlxxkwPU3NJ zDyw== X-Gm-Message-State: AOAM530eGUjguWHTloCftVFZfIQj5F7PfPiNKRJXmyDoDCv1OR/YDRd0 gVYlyC9ZLkgv/rx4KSpuHJ27hA== X-Google-Smtp-Source: ABdhPJwglt/9uW5KPkunmXazmtb24J49GEPBxD3Bb9hG8tmIdx9pCeW1n4r7+1K7+lnSzxSbiVjn3g== X-Received: by 2002:a7b:c3da:: with SMTP id t26mr6622241wmj.23.1599720908553; Wed, 09 Sep 2020 23:55:08 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:08 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless Subject: [PATCH 13/29] iwlwifi: mvm: tx: Demote misuse of kernel-doc headers Date: Thu, 10 Sep 2020 07:54:15 +0100 Message-Id: <20200910065431.657636-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/mvm/tx.c:1379: warning: Function parameter or member 'rate_n_flags' not described in 'iwl_mvm_hwrate_to_tx_status' drivers/net/wireless/intel/iwlwifi/mvm/tx.c:1379: warning: Function parameter or member 'info' not described in 'iwl_mvm_hwrate_to_tx_status' drivers/net/wireless/intel/iwlwifi/mvm/tx.c:1431: warning: Function parameter or member 'mvm' not described in 'iwl_mvm_get_scd_ssn' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c index 2f6484e0d726c..82ebf264de397 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c @@ -1371,7 +1371,7 @@ void iwl_mvm_hwrate_to_tx_rate(u32 rate_n_flags, } } -/** +/* * translate ucode response to mac80211 tx status control values */ static void iwl_mvm_hwrate_to_tx_status(u32 rate_n_flags, @@ -1413,7 +1413,7 @@ static void iwl_mvm_tx_status_check_trigger(struct iwl_mvm *mvm, } } -/** +/* * iwl_mvm_get_scd_ssn - returns the SSN of the SCD * @tx_resp: the Tx response from the fw (agg or non-agg) * From patchwork Thu Sep 10 06:54:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249550 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp467911ilk; Wed, 9 Sep 2020 23:59:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTNNUIAmOWzrvbO4jY7a9FMntNP5AjluRDKr9/wsc0bxPLOAI7JyoStlbg4oaj3t9228lB X-Received: by 2002:a17:906:e50:: with SMTP id q16mr7687152eji.544.1599721159869; Wed, 09 Sep 2020 23:59:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599721159; cv=none; d=google.com; s=arc-20160816; b=OsDIyKnwfBJbeNuJwGkIdmaN3F555LWaRrPjt1g9HS+f9u77XAWnqTS36F1Uwq3T0p VV+eDa75n8x8Tp6+LPBZkdV0tyCmnzdzlb2reTNkqKgtbqvnJDdosZHqN5YJkf0WpKpn Y8zUUDd3vMexUHgPiNSpFhzpnSx3J1nTDdI9wBLyfio3DAO/2aKwVrYwPUchGtRn/Syu VChne7qTbeVbwoSoclmRXpbDrS7GL4SNrbtj9+eF6yGtpjdyXM0zJ9ynKd92gkhNN5MT YXdpyxnSuWfcQG4nLQ9r64i8wJZdXk5nNFr3IlKXab/MQPmNRXxgwZuOxNR02TVE4OoG KbXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bsXVZlb3+RPh6wsFFLtZip9Xh8c8BRLlYFokPA0kQU8=; b=G4kztolUoSU8UoZ+GudIWl/COPREjHCFRAtsdqScEe//twcnQriV6lk09aHg+KWEc6 eIFqXw38AWa0EDai4HaJgU7093ifnDU1PyWRo4TJPyUZ1Hle8oy183K4viihR3wD4gf+ p5eoGJnkh/Ef/0KYMNkfSUD5sS1BnbDm5I0MKazhL9NMa0dhDRsRfCsjNtcM4oKWajZl HXGlZND0LRzO6tfgpwQOUGt4oy9FNLxQ5NEGm8wCg8O7NyPrj0gW/pBBBJwheTv6RvEF CCCGlvlQEYzdCw6v43OiAIkDx3ydS11CVIfk3xMxRdwPMarlJNoSY+1fFdi4YvO6d1an O0iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GGGwrmHV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si2960213ejr.667.2020.09.09.23.59.19; Wed, 09 Sep 2020 23:59:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GGGwrmHV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730128AbgIJG7P (ORCPT + 2 others); Thu, 10 Sep 2020 02:59:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726935AbgIJG5e (ORCPT ); Thu, 10 Sep 2020 02:57:34 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07845C061344 for ; Wed, 9 Sep 2020 23:55:11 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id t10so5440156wrv.1 for ; Wed, 09 Sep 2020 23:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bsXVZlb3+RPh6wsFFLtZip9Xh8c8BRLlYFokPA0kQU8=; b=GGGwrmHVuW8tISGSbeUd6+mreB0TqZjr9Mv60GpNUIJGeEQFdPjdrvKI61DszWVfu5 /ePSPwlEdTcxWdmnKD2tESH2TihMllXcQ//mkE1jmvx99vxjyjlpq/KsDdwjpbmrSFBo AhMzCPngkCrNSXGtbyJkCO1uh/786/ZD3Ylu6VKSDpJ/T9C8mLUgC4IuehgIvq+CBLqm 7ZhR+09i4ueLroX6DN3hk+WG6/yHvABcg4BSrBCgxkLwOTtwLZnJYc/8U5tqlGi3664M TC76zw5b6tNpsKxQvg5ZG8TQ4TrDOT4WtdLFk+gy1A8GObfa9vHHpoEMvhkcKxBIvhnu mHVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bsXVZlb3+RPh6wsFFLtZip9Xh8c8BRLlYFokPA0kQU8=; b=knKgoIC9LdhPaywsLv/vrbDjkR4hOU6X7Sws8+WDPcf3O9JCrR6042sMrqCDWDqpAv YAlADrSrMTN/FcMz5bkttK4HnRShZTNtkcirF1Q/GfidJLfEbGusklUGd+6ZlOAwQIZJ fPA0rJ6o9hGdkWH6x8fQIBI7cS5y/o44+sjFeQiBddjaJuj2Vp783Y+1IA4D8ZPSmRrV rj8mhP0FMwhKcrE16BuLFQ2Y0X6cLdLWh6rBH3JAUi2eRny97lC/54duYmXNKoxlnzCn WpQpwglkjyQFqaRc1ou09OHtpYO/Epo9ae6cgUoVaWCwyL2/P2x7nLnvJdJg4KSnWGUS pP3g== X-Gm-Message-State: AOAM5303+hVLJGxcGdgxD0sJ5ktEHZPmwYNIhhtVWkz8l/fIVd9IKPpP ewI4t7bT3D1TsOBwMPOSvj17aA== X-Received: by 2002:a5d:56c1:: with SMTP id m1mr7002737wrw.87.1599720909708; Wed, 09 Sep 2020 23:55:09 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:09 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless Subject: [PATCH 14/29] iwlwifi: dvm: devices: Fix function documentation formatting issues Date: Thu, 10 Sep 2020 07:54:16 +0100 Message-Id: <20200910065431.657636-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kerneldoc expects attributes/parameters to be in '@*.: ' format and gets confused if the variable does not follow the type/attribute definitions. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/dvm/devices.c:66: warning: Function parameter or member 'priv' not described in 'iwl_beacon_time_mask_low' drivers/net/wireless/intel/iwlwifi/dvm/devices.c:66: warning: Function parameter or member 'tsf_bits' not described in 'iwl_beacon_time_mask_low' drivers/net/wireless/intel/iwlwifi/dvm/devices.c:77: warning: Function parameter or member 'priv' not described in 'iwl_beacon_time_mask_high' drivers/net/wireless/intel/iwlwifi/dvm/devices.c:77: warning: Function parameter or member 'tsf_bits' not described in 'iwl_beacon_time_mask_high' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/dvm/devices.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/devices.c b/drivers/net/wireless/intel/iwlwifi/dvm/devices.c index d42bc46fe5662..c3e25885d1943 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/devices.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/devices.c @@ -58,8 +58,8 @@ static void iwl1000_nic_config(struct iwl_priv *priv) /** * iwl_beacon_time_mask_low - mask of lower 32 bit of beacon time - * @priv -- pointer to iwl_priv data structure - * @tsf_bits -- number of bits need to shift for masking) + * @priv: pointer to iwl_priv data structure + * @tsf_bits: number of bits need to shift for masking) */ static inline u32 iwl_beacon_time_mask_low(struct iwl_priv *priv, u16 tsf_bits) @@ -69,8 +69,8 @@ static inline u32 iwl_beacon_time_mask_low(struct iwl_priv *priv, /** * iwl_beacon_time_mask_high - mask of higher 32 bit of beacon time - * @priv -- pointer to iwl_priv data structure - * @tsf_bits -- number of bits need to shift for masking) + * @priv: pointer to iwl_priv data structure + * @tsf_bits: number of bits need to shift for masking) */ static inline u32 iwl_beacon_time_mask_high(struct iwl_priv *priv, u16 tsf_bits) From patchwork Thu Sep 10 06:54:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249551 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp467973ilk; Wed, 9 Sep 2020 23:59:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzq7/2ASJKR8YfV/dLlzBmp7oHDKuXyRKFRlJU2hWWT+zrgrd+vagXNqcw4Y2fzAI/u8b7x X-Received: by 2002:a17:906:2ac5:: with SMTP id m5mr7105533eje.210.1599721168989; Wed, 09 Sep 2020 23:59:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599721168; cv=none; d=google.com; s=arc-20160816; b=V70qt3vDU62lpEt8XmS/hGFmN2CtwkTn1944FOFhP1JwkzHhWq726x16Ykok7gpas0 5gbuzKpkBA516G1vu6UiFRTswUkXhhRvFZNINZUFob37jbXuF5GZy6+qslBokBsXt6dt IVsw/Hs9IJ0sFa5IdrQWI+u6HBQJ8vFw017PjnkiTyzdbDEihZGZ6euPCksdErFINSHK yelCRuaNvG6kAlM9/N1SKbDaT8093bFWaXRj49qQ30VDbHpr75jXqAN1iNMZ31pauSLE rktzNPlpgjTO5p5u4aS9gQvrf/kfaYR2c/+sUQoFdtw2MtL2v11kUN+YmKgf9Z80R7mW vYzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QBwZYByjjh942d4ggJkaITmm4qS6KFDbT+209YIFm2k=; b=ebZqgm+sYzhy77PU/ZFKv/hYhaqwS6ypYbPW1qjsJwZ++Z3KeYQjqT04ymaeW5FX7r bOGXfFxe6xC4byI6EPZJGgekR1bob/KbIUb+FMUOrYGMKsSDIKnR/qnqrZeo3wpVyCNB rQrUaM64QDqnl5Uit1Xe/KlIA9/lY0zvQFutOsvKRPbRqqgqw0myzyVG2QeCfSBp8mA/ VYB6ne/qnC28XA9wcxP9cZ4QzXJMkOHlhDXTZ2WgT20zqDRCxAFo1KSPT2WXmmVeouPl gtpw5kfEf90RyshPDRlKTIfYUZEm9U6KqMEoghASZTfXadJ21p8ZxvX8DAaInVj19skQ HDKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="o/wDvUp3"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si2960213ejr.667.2020.09.09.23.59.28; Wed, 09 Sep 2020 23:59:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="o/wDvUp3"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730022AbgIJG7U (ORCPT + 2 others); Thu, 10 Sep 2020 02:59:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729785AbgIJG5e (ORCPT ); Thu, 10 Sep 2020 02:57:34 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8102DC061347 for ; Wed, 9 Sep 2020 23:55:12 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id k18so4605767wmj.5 for ; Wed, 09 Sep 2020 23:55:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QBwZYByjjh942d4ggJkaITmm4qS6KFDbT+209YIFm2k=; b=o/wDvUp3hJQejPqXu9BVpd4DAZVvxNEGCvwNBjgtKaCHOvkvK2PixeedyU+euKj3uM 6RE7sSsFhFn7II5R/AT4j99dXRYjA64fISNqweLwk21m2ilur2CuKdp/ldA/0ExeQSGq diVFzJGZeH2I02ScPXSS9m+HBcHIDpVwWqSW1r9F9iwqMgVKVdY4b2m6LsXoe2I6Rhrd qtpxpuulD/8hye47v78oTqmg0QNkvrzcxD/6+noLrHjKzcw3SIkL670d75vQivrpQE5q T54i9iRRejeNy+G8gWYcBfd7RPfc2DxpwcbWyOpeX0qNDjoHkUvj6rD+YIlXhopr6css qhTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QBwZYByjjh942d4ggJkaITmm4qS6KFDbT+209YIFm2k=; b=ntfqcP7MVvCycpNKBxNuxzQHGBICwGVHHgTn5IayFHJd7oK6fsb/OC3evbWLxjWZ2o uH5BsiJME82JGIrtkr/67fazruAOGAjBq482McfhQzjLS7uGH9Kdpk8e0u5lazNUsQYQ 0mGODE6EOqZOS9pNZZJ/3xAlJLmBq7Uox5LKwtZgjmS0HYiBEUtTo1bKpMKVrzL7IsV7 dLLOe/Kf47bnVZa5Q16MEqBS+q4RIC0Jl8tHlNZwZIreFHP6Fs8ObP5GrdH3FNX1HPvD AnNh4tcD5AG9cisml2g9A2BWeOatI+8LM3GjZIDHUTgkqC32ncbdys9J9bc08xF8w0rY uXFQ== X-Gm-Message-State: AOAM5308ub4sVHgZnYKQ5scWn8hxfK0MyLiOZhHIa+NGMNjMGFZt9FL4 TX2PqnzTtNzKU/10E61t8rQSeA== X-Received: by 2002:a7b:c5c1:: with SMTP id n1mr6617171wmk.125.1599720910831; Wed, 09 Sep 2020 23:55:10 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:10 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless Subject: [PATCH 15/29] iwlwifi: iwl-drv: Provide descriptions debugfs dentries Date: Thu, 10 Sep 2020 07:54:17 +0100 Message-Id: <20200910065431.657636-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Also demote a non-conforming kernel-doc function header. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/iwl-drv.c:124: warning: Function parameter or member 'dbgfs_drv' not described in 'iwl_drv' drivers/net/wireless/intel/iwlwifi/iwl-drv.c:124: warning: Function parameter or member 'dbgfs_trans' not described in 'iwl_drv' drivers/net/wireless/intel/iwlwifi/iwl-drv.c:124: warning: Function parameter or member 'dbgfs_op_mode' not described in 'iwl_drv' drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1329: warning: Function parameter or member 'ucode_raw' not described in 'iwl_req_fw_callback' drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1329: warning: Function parameter or member 'context' not described in 'iwl_req_fw_callback' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c index 04f14bfdd0914..2a9075b1b3747 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c @@ -102,6 +102,9 @@ static struct dentry *iwl_dbgfs_root; * @fw_index: firmware revision to try loading * @firmware_name: composite filename of ucode file to load * @request_firmware_complete: the firmware has been obtained from user space + * @dbgfs_drv: debugfs root directory entry + * @dbgfs_trans: debugfs transport directory entry + * @dbgfs_op_mode: debugfs op_mode directory entry */ struct iwl_drv { struct list_head list; @@ -1319,7 +1322,7 @@ static void _iwl_op_mode_stop(struct iwl_drv *drv) } } -/** +/* * iwl_req_fw_callback - callback when firmware was loaded * * If loaded successfully, copies the firmware into buffers From patchwork Thu Sep 10 06:54:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259284 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9E01C433E2 for ; Thu, 10 Sep 2020 07:01:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67AD32078E for ; Thu, 10 Sep 2020 07:01:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o4RYptxu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729663AbgIJG7w (ORCPT ); Thu, 10 Sep 2020 02:59:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730067AbgIJG5z (ORCPT ); Thu, 10 Sep 2020 02:57:55 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D013C06134A for ; Wed, 9 Sep 2020 23:55:13 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id q9so4485717wmj.2 for ; Wed, 09 Sep 2020 23:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oWmssmRDs9wD67bjPcBNZ7suDiU6o2jmm0CnpGzG4Gs=; b=o4RYptxuopBdft3ihpsYx4uNTDHkjdwyLoWFYKkz+MMLkgQpwIALHK6RxNTUhYmDSI VTAp3cMImohyS+WupMHc8DEf+ssuIzm5vexaUOMn4vNVhBVrTldZAHS3oz9JmCNpwjIR 4U+VKxv5Pv31p/xMfChqv2xcwJviJGWlZe52OjrPZwBy7Jj9+zHAOgYg5fq97NrHHSHY XQd48xJG98SwPLWUVywGarl3ZX/vL4Om60vc+qmu5klQSsngbLM/AbWGNxfbdBon09sc JovnDUDNuuOtLNPJznaG6T6xwcL7j6c8bJN7DGnsvycgcJjtbYKlRWohuZK1nNC7cs0T HFJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oWmssmRDs9wD67bjPcBNZ7suDiU6o2jmm0CnpGzG4Gs=; b=TmbFOVoR2hKUby5Ru0r6ELHObOwStGlSoo24ctrgujPAwZACQSjCOs1Xq2SnDkMGys XKhNoZgdcXilvIQtGPmAMfQO8VOHcOa/vS7KF1hZ4VTzO6ucMB+XHkcQLwzZhHdfa2eu L4zSOP25D0yxDKRg5apY9otJWdrxn+lgdMB2uPWLxxiaEPzHTUPQ/UV0XZq+7wT+/Y+s OMdu9KHRnzSjF7J3MWohTf5bxitARAloXPVtLpzE/TYY2VE5uKN91T/g+HntGXo6+4yH eJYEOcahhPvNPv9uHBoC56le+qTHPEIyhriIptCs1kD55TVbmXW5GJAwddAh2tq4uuIu dm/g== X-Gm-Message-State: AOAM532DV2AwPjzRqVvp8zw8Uo+kFbvGKHt3GZCfqUt7LVuFlJHZl1pm KMCyDhpjIEWdw2sRqrK98w6OzQ== X-Google-Smtp-Source: ABdhPJxGOuIKK6/snCNwluZ6DgphR+vi68NV19yl/SqMT1q01pjsoFOL6VlnJMHMnkhojdj1+zUqAA== X-Received: by 2002:a7b:c44b:: with SMTP id l11mr6833665wmi.52.1599720912025; Wed, 09 Sep 2020 23:55:12 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:11 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Maya Erez , wil6210@qti.qualcomm.com Subject: [PATCH 16/29] wil6210: wmi: Fix formatting and demote non-conforming function headers Date: Thu, 10 Sep 2020 07:54:18 +0100 Message-Id: <20200910065431.657636-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/wmi.c:52: warning: Incorrect use of kernel-doc format: * Addressing - theory of operations drivers/net/wireless/ath/wil6210/wmi.c:70: warning: Incorrect use of kernel-doc format: * @sparrow_fw_mapping provides memory remapping table for sparrow drivers/net/wireless/ath/wil6210/wmi.c:80: warning: cannot understand function prototype: 'const struct fw_map sparrow_fw_mapping[] = ' drivers/net/wireless/ath/wil6210/wmi.c:107: warning: Cannot understand * @sparrow_d0_mac_rgf_ext - mac_rgf_ext section for Sparrow D0 drivers/net/wireless/ath/wil6210/wmi.c:115: warning: Cannot understand * @talyn_fw_mapping provides memory remapping table for Talyn drivers/net/wireless/ath/wil6210/wmi.c:158: warning: Cannot understand * @talyn_mb_fw_mapping provides memory remapping table for Talyn-MB drivers/net/wireless/ath/wil6210/wmi.c:236: warning: Function parameter or member 'x' not described in 'wmi_addr_remap' drivers/net/wireless/ath/wil6210/wmi.c:255: warning: Function parameter or member 'section' not described in 'wil_find_fw_mapping' drivers/net/wireless/ath/wil6210/wmi.c:278: warning: Function parameter or member 'wil' not described in 'wmi_buffer_block' drivers/net/wireless/ath/wil6210/wmi.c:278: warning: Function parameter or member 'ptr_' not described in 'wmi_buffer_block' drivers/net/wireless/ath/wil6210/wmi.c:278: warning: Function parameter or member 'size' not described in 'wmi_buffer_block' drivers/net/wireless/ath/wil6210/wmi.c:307: warning: Function parameter or member 'wil' not described in 'wmi_addr' drivers/net/wireless/ath/wil6210/wmi.c:307: warning: Function parameter or member 'ptr' not described in 'wmi_addr' drivers/net/wireless/ath/wil6210/wmi.c:1589: warning: Function parameter or member 'wil' not described in 'wil_find_cid_ringid_sta' drivers/net/wireless/ath/wil6210/wmi.c:1589: warning: Function parameter or member 'vif' not described in 'wil_find_cid_ringid_sta' drivers/net/wireless/ath/wil6210/wmi.c:1589: warning: Function parameter or member 'cid' not described in 'wil_find_cid_ringid_sta' drivers/net/wireless/ath/wil6210/wmi.c:1589: warning: Function parameter or member 'ringid' not described in 'wil_find_cid_ringid_sta' drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or member 'vif' not described in 'wmi_evt_ignore' drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or member 'id' not described in 'wmi_evt_ignore' drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or member 'd' not described in 'wmi_evt_ignore' drivers/net/wireless/ath/wil6210/wmi.c:1876: warning: Function parameter or member 'len' not described in 'wmi_evt_ignore' drivers/net/wireless/ath/wil6210/wmi.c:2588: warning: Function parameter or member 'wil' not described in 'wmi_rxon' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/wmi.c | 36 +++++++++++--------------- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c index c7136ce567eea..421aebbb49e54 100644 --- a/drivers/net/wireless/ath/wil6210/wmi.c +++ b/drivers/net/wireless/ath/wil6210/wmi.c @@ -32,7 +32,7 @@ MODULE_PARM_DESC(led_id, #define WIL_WMI_PCP_STOP_TO_MS 5000 /** - * WMI event receiving - theory of operations + * DOC: WMI event receiving - theory of operations * * When firmware about to report WMI event, it fills memory area * in the mailbox and raises misc. IRQ. Thread interrupt handler invoked for @@ -49,7 +49,7 @@ MODULE_PARM_DESC(led_id, */ /** - * Addressing - theory of operations + * DOC: Addressing - theory of operations * * There are several buses present on the WIL6210 card. * Same memory areas are visible at different address on @@ -66,8 +66,7 @@ MODULE_PARM_DESC(led_id, * AHB address must be used. */ -/** - * @sparrow_fw_mapping provides memory remapping table for sparrow +/* sparrow_fw_mapping provides memory remapping table for sparrow * * array size should be in sync with the declaration in the wil6210.h * @@ -103,16 +102,14 @@ const struct fw_map sparrow_fw_mapping[] = { {0x800000, 0x804000, 0x940000, "uc_data", false, false}, }; -/** - * @sparrow_d0_mac_rgf_ext - mac_rgf_ext section for Sparrow D0 +/* sparrow_d0_mac_rgf_ext - mac_rgf_ext section for Sparrow D0 * it is a bit larger to support extra features */ const struct fw_map sparrow_d0_mac_rgf_ext = { 0x88c000, 0x88c500, 0x88c000, "mac_rgf_ext", true, true }; -/** - * @talyn_fw_mapping provides memory remapping table for Talyn +/* talyn_fw_mapping provides memory remapping table for Talyn * * array size should be in sync with the declaration in the wil6210.h * @@ -154,8 +151,7 @@ const struct fw_map talyn_fw_mapping[] = { {0x800000, 0x808000, 0xa78000, "uc_data", false, false}, }; -/** - * @talyn_mb_fw_mapping provides memory remapping table for Talyn-MB +/* talyn_mb_fw_mapping provides memory remapping table for Talyn-MB * * array size should be in sync with the declaration in the wil6210.h * @@ -229,7 +225,7 @@ u8 led_polarity = LED_POLARITY_LOW_ACTIVE; /** * return AHB address for given firmware internal (linker) address - * @x - internal address + * @x: internal address * If address have no valid AHB mapping, return 0 */ static u32 wmi_addr_remap(u32 x) @@ -247,7 +243,7 @@ static u32 wmi_addr_remap(u32 x) /** * find fw_mapping entry by section name - * @section - section name + * @section: section name * * Return pointer to section or NULL if not found */ @@ -265,8 +261,9 @@ struct fw_map *wil_find_fw_mapping(const char *section) /** * Check address validity for WMI buffer; remap if needed - * @ptr - internal (linker) fw/ucode address - * @size - if non zero, validate the block does not + * @wil: driver data + * @ptr: internal (linker) fw/ucode address + * @size: if non zero, validate the block does not * exceed the device memory (bar) * * Valid buffer should be DWORD aligned @@ -300,9 +297,7 @@ void __iomem *wmi_buffer(struct wil6210_priv *wil, __le32 ptr_) return wmi_buffer_block(wil, ptr_, 0); } -/** - * Check address validity - */ +/* Check address validity */ void __iomem *wmi_addr(struct wil6210_priv *wil, u32 ptr) { u32 off; @@ -1577,8 +1572,7 @@ wmi_evt_link_stats(struct wil6210_vif *vif, int id, void *d, int len) evt->payload, payload_size); } -/** - * find cid and ringid for the station vif +/* find cid and ringid for the station vif * * return error, if other interfaces are used or ring was not found */ @@ -1868,8 +1862,7 @@ wmi_evt_link_monitor(struct wil6210_vif *vif, int id, void *d, int len) cfg80211_cqm_rssi_notify(ndev, event_type, evt->rssi_level, GFP_KERNEL); } -/** - * Some events are ignored for purpose; and need not be interpreted as +/* Some events are ignored for purpose; and need not be interpreted as * "unhandled events" */ static void wmi_evt_ignore(struct wil6210_vif *vif, int id, void *d, int len) @@ -2578,6 +2571,7 @@ int wmi_update_ft_ies(struct wil6210_vif *vif, u16 ie_len, const void *ie) /** * wmi_rxon - turn radio on/off + * @wil: driver data * @on: turn on if true, off otherwise * * Only switch radio. Channel should be set separately. From patchwork Thu Sep 10 06:54:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249565 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp477484ilk; Thu, 10 Sep 2020 00:15:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyObwerDrzNIar7PhMYpvyJ7IBcF4ONgQQzQKbfeuFLfj1KFeqA2WgmyAo2b7v1gToAUdSL X-Received: by 2002:a50:a2e6:: with SMTP id 93mr7463194edm.147.1599722110775; Thu, 10 Sep 2020 00:15:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599722110; cv=none; d=google.com; s=arc-20160816; b=wqSNweOsp1gv0bI2McyaC0AfMYgRW9lS74nGgGM+E9Dlj9soDu+WWe8WmLJd4hAtPh VwiU6mFARX1wJz5MNEQAOt/ZuYLb4m7DRl1q+CA4PWqm7oxgJ92OeB1X48rxw+zZg7Ie 9WjgxCdIrwtkWnSG7gzL2iPtVGeF4NPHwK3f+pwegOk4lQR4SHRrlTN08zJWbrMhhsMs 3zWl4LBjRh4ZLHHdrQbMB2aptmZ8BNtZ6CarZ6WUzKnr3x8rAWy/yseYdL/TmWqLlQoQ BgRHZAxI8avECrfLWjDOAU6N6f6QuTuQVbx1UarqhvJflPMS2ZWDM1NsYfJruo4z7nRO bRVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=F4SNZL7u3gsccSrH9enIbNris8FkjNdKg3vRM/mztQ8=; b=rAPj2YfUh0VIZ0g25cDq1u3GFZRuQskNmFSp1nGo/c0PXDSOg4VXuCP0dpF1aCiOYm bw5obZxRjdL51FShA+2HZxjky3OOJpy4qc+to/cl1fQawqoIDVxtJmJozDXguONToxy+ 7NQU8bhNa1acgSS3txQPoDGp8lI7HILA0maWwXXmHABz1KoTG/khkcxdzfRxHK1YY/yo UWVi/t47nlSyD3WCHvdL6E7sGZqNEfjbS88Z+/jHUozUeoTXAvMnWM3xOErGffnYX7Qo 0NquHxzcYoR1lFGkK3DLYpiRdTVMfXjICUH4Ns3pS8C6KKAy4k2FaRmK4pSSLA1pQIWx JyOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wNMmsQ+F; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f4si3013888ejt.278.2020.09.10.00.15.10; Thu, 10 Sep 2020 00:15:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wNMmsQ+F; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730104AbgIJHPD (ORCPT + 2 others); Thu, 10 Sep 2020 03:15:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730233AbgIJG6K (ORCPT ); Thu, 10 Sep 2020 02:58:10 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FEDEC06134D for ; Wed, 9 Sep 2020 23:55:14 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id k18so4605846wmj.5 for ; Wed, 09 Sep 2020 23:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F4SNZL7u3gsccSrH9enIbNris8FkjNdKg3vRM/mztQ8=; b=wNMmsQ+FjmUb41jHniIimRBXAYxYZBPfjc0OAmv7yy+rkAU2vQpWyUCSWHpnSZHZQ3 6FLbR7fHF7QSrGLvpYbjAhMw9XV+hNCuIoWer16Vy8D+AUdryZJUxluxkBASciRrGGkP rMVDSILqO4wp+sZ6aDEJyhRKuE0v6eEv7Wo3B5cdwMfv4TNC5+nS3Yg6TXIWhdy5+BOv LOdncogF6/wEjTM14GC6RdfkZ5bmzHvGmdYP/XqijNoIxk0I0Z4+vKnu25X16fG41Bvv gUDs9LUYkfBHbXLuVP/XzJ+JJ/2EPoxjGZyXfWcEW7twMAJHz4ILUcszEEvf2/mOQJrh NYVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F4SNZL7u3gsccSrH9enIbNris8FkjNdKg3vRM/mztQ8=; b=Zfr0Wg/YxyYTt57CrguHVWA8sgj/ntXlHcHWosNyD+FZqP6L6SOieU3ZvqcRXHICtd 7YPAW8QI5HjNXUEPR+nUsPQQLkrBsz02v0hFOLD1sx/GIcGsSLLIewFIiyxL3FdobVDi zXlbkDwT6NyecTA8LGx3uX6ZGLM96ZNXS8ADjsSt+X481aqflNcukoHArh/NdzOsahQF fyTZmxLsS8OmomkIhfApP2ZZkxNYr78KV32em7Pt0Le3kDIVHBLNS+lcJXnR4R3UCcoz /Ufon7JNjwccCE9zvhDq8yolwnaHmMM31/s847LzgxJhcNO8wuIQI5ihmDcDxMLbt/h8 +1+A== X-Gm-Message-State: AOAM530tSJTrjqeKX72kKwtZvyHVNyPQqJq6jiC0rBZd1qay9U03tSTG GWlQ/fkSs91v9IlY8eM3yp8gKQ== X-Received: by 2002:a1c:2742:: with SMTP id n63mr6799933wmn.24.1599720913070; Wed, 09 Sep 2020 23:55:13 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:12 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Maya Erez , wil6210@qti.qualcomm.com Subject: [PATCH 17/29] wil6210: interrupt: Demote comment header which is clearly not kernel-doc Date: Thu, 10 Sep 2020 07:54:19 +0100 Message-Id: <20200910065431.657636-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/interrupt.c:652: warning: Function parameter or member 'irq' not described in 'wil6210_thread_irq' drivers/net/wireless/ath/wil6210/interrupt.c:652: warning: Function parameter or member 'cookie' not described in 'wil6210_thread_irq' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/interrupt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/wil6210/interrupt.c b/drivers/net/wireless/ath/wil6210/interrupt.c index b1480b41cd3a0..d13d081fdcc6f 100644 --- a/drivers/net/wireless/ath/wil6210/interrupt.c +++ b/drivers/net/wireless/ath/wil6210/interrupt.c @@ -645,9 +645,7 @@ static irqreturn_t wil6210_irq_misc_thread(int irq, void *cookie) return IRQ_HANDLED; } -/** - * thread IRQ handler - */ +/* thread IRQ handler */ static irqreturn_t wil6210_thread_irq(int irq, void *cookie) { struct wil6210_priv *wil = cookie; From patchwork Thu Sep 10 06:54:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259278 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F77C433E2 for ; Thu, 10 Sep 2020 07:14:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A86E2075B for ; Thu, 10 Sep 2020 07:14:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QljOQg6a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730077AbgIJHOF (ORCPT ); Thu, 10 Sep 2020 03:14:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730252AbgIJG6c (ORCPT ); Thu, 10 Sep 2020 02:58:32 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77506C061350 for ; Wed, 9 Sep 2020 23:55:15 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id z4so5440264wrr.4 for ; Wed, 09 Sep 2020 23:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nMutSp2j8lDpsARJd2bf3g5RNBU3idpv78njSHIfOe8=; b=QljOQg6ahzpYjtb0kGIGCOo64fMNlgB1cVe0SNBFGpY0ii1cbB3Sr9cenvrboi77Lw NdZv76OAyTL9u0uR8KeiUdB4cpaDuUc6xZ5ptiP+22K4CrnOIWTJru2o4coGISsMHlzp xlXIZjbRN6Cv6VSxWiU1CzA4o5hIl9/GmU02bF4MuCrSNoRgJSZhyAJcjHELXnhMiDEW hXfucooZSwn7SGDOyzf9EGqSR3/upMRcxev7uYgIS/9wijrOb2ycLY0PhSLqnmr5hHnt qLLjlITbCTXR/9+w3D+m0FCcu1PrwNWOzisEJiqeclHGTyBnS3DQwDj12DMBJyaxVvOu hm7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nMutSp2j8lDpsARJd2bf3g5RNBU3idpv78njSHIfOe8=; b=lSOQ/OFBd0x3+MF9VOrincuwT9VumQPQU/WtMzJc9p0AsKgpkJh54Do9OWgG8tF6XJ n1Dhly1oUY+ETFvpoAl1wMYh7fHAWehDkRDyw6OGuHCvdYRfMWfSMznsoSpcxeZhyjvz Do16Yu9HyxUH8SjWw5bLfh9IfbEPkKZYAzDraRRpant/xm0gqmCfQ7VEOI8Q/yZw2sI0 orTKQct4/48L1om8TuOEqvxEtj+52axoc566D8xLA1ke7iH6Blwx/lGCn0K6rVyh4i1T 44uMvwVKRJMQpnu7zoDQ4u0RRtlJ01j2rYD11Dmf0eDFRRrR37+rI3hbcM6R5JYx5I9Q iEeg== X-Gm-Message-State: AOAM532v83WVPUzP1FXktV/VN5/F1o5W28UlK0AO+hUNiUXmOfU7lzIs 55Rw8EFZ4ljltYGFpBlSi1o6YQ== X-Google-Smtp-Source: ABdhPJxezyb1HS3XFxzcfbbIQd/MatQOfGqknEyXcbxMZIDF2Fv0wwqEmHgQBEDTOHmpkq+4ePJrUw== X-Received: by 2002:a5d:4645:: with SMTP id j5mr6648574wrs.388.1599720914289; Wed, 09 Sep 2020 23:55:14 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:13 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Maya Erez , wil6210@qti.qualcomm.com Subject: [PATCH 18/29] wil6210: txrx: Demote obvious abuse of kernel-doc Date: Thu, 10 Sep 2020 07:54:20 +0100 Message-Id: <20200910065431.657636-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org None of these headers provide any parameter documentation. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/txrx.c:259: warning: Function parameter or member 'wil' not described in 'wil_vring_alloc_skb' drivers/net/wireless/ath/wil6210/txrx.c:259: warning: Function parameter or member 'vring' not described in 'wil_vring_alloc_skb' drivers/net/wireless/ath/wil6210/txrx.c:259: warning: Function parameter or member 'i' not described in 'wil_vring_alloc_skb' drivers/net/wireless/ath/wil6210/txrx.c:259: warning: Function parameter or member 'headroom' not described in 'wil_vring_alloc_skb' drivers/net/wireless/ath/wil6210/txrx.c:309: warning: Function parameter or member 'wil' not described in 'wil_rx_add_radiotap_header' drivers/net/wireless/ath/wil6210/txrx.c:309: warning: Function parameter or member 'skb' not described in 'wil_rx_add_radiotap_header' drivers/net/wireless/ath/wil6210/txrx.c:444: warning: Function parameter or member 'wil' not described in 'wil_vring_reap_rx' drivers/net/wireless/ath/wil6210/txrx.c:444: warning: Function parameter or member 'vring' not described in 'wil_vring_reap_rx' drivers/net/wireless/ath/wil6210/txrx.c:610: warning: Function parameter or member 'wil' not described in 'wil_rx_refill' drivers/net/wireless/ath/wil6210/txrx.c:610: warning: Function parameter or member 'count' not described in 'wil_rx_refill' drivers/net/wireless/ath/wil6210/txrx.c:1011: warning: Function parameter or member 'wil' not described in 'wil_rx_handle' drivers/net/wireless/ath/wil6210/txrx.c:1011: warning: Function parameter or member 'quota' not described in 'wil_rx_handle' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'd' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'skb' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'tso_desc_type' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'is_ipv4' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'tcp_hdr_len' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1643: warning: Function parameter or member 'skb_net_hdr_len' not described in 'wil_tx_desc_offload_setup_tso' drivers/net/wireless/ath/wil6210/txrx.c:1674: warning: Function parameter or member 'd' not described in 'wil_tx_desc_offload_setup' drivers/net/wireless/ath/wil6210/txrx.c:1674: warning: Function parameter or member 'skb' not described in 'wil_tx_desc_offload_setup' drivers/net/wireless/ath/wil6210/txrx.c:2240: warning: Function parameter or member 'wil' not described in '__wil_update_net_queues' drivers/net/wireless/ath/wil6210/txrx.c:2240: warning: Function parameter or member 'vif' not described in '__wil_update_net_queues' drivers/net/wireless/ath/wil6210/txrx.c:2240: warning: Function parameter or member 'ring' not described in '__wil_update_net_queues' drivers/net/wireless/ath/wil6210/txrx.c:2240: warning: Function parameter or member 'check_stop' not described in '__wil_update_net_queues' drivers/net/wireless/ath/wil6210/txrx.c:2430: warning: Function parameter or member 'vif' not described in 'wil_tx_complete' drivers/net/wireless/ath/wil6210/txrx.c:2430: warning: Function parameter or member 'ringid' not described in 'wil_tx_complete' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/txrx.c | 30 +++++++++---------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c index 080e5aa60bea4..cc830c795b33c 100644 --- a/drivers/net/wireless/ath/wil6210/txrx.c +++ b/drivers/net/wireless/ath/wil6210/txrx.c @@ -249,8 +249,7 @@ static void wil_vring_free(struct wil6210_priv *wil, struct wil_ring *vring) vring->ctx = NULL; } -/** - * Allocate one skb for Rx VRING +/* Allocate one skb for Rx VRING * * Safe to call from IRQ */ @@ -295,8 +294,7 @@ static int wil_vring_alloc_skb(struct wil6210_priv *wil, struct wil_ring *vring, return 0; } -/** - * Adds radiotap header +/* Adds radiotap header * * Any error indicated as "Bad FCS" * @@ -432,8 +430,7 @@ static int wil_rx_get_cid_by_skb(struct wil6210_priv *wil, struct sk_buff *skb) return cid; } -/** - * reap 1 frame from @swhead +/* reap 1 frame from @swhead * * Rx descriptor copied to skb->cb * @@ -597,8 +594,7 @@ static struct sk_buff *wil_vring_reap_rx(struct wil6210_priv *wil, return skb; } -/** - * allocate and fill up to @count buffers in rx ring +/* allocate and fill up to @count buffers in rx ring * buffers posted at @swtail * Note: we have a single RX queue for servicing all VIFs, but we * allocate skbs with headroom according to main interface only. This @@ -1002,8 +998,7 @@ void wil_netif_rx_any(struct sk_buff *skb, struct net_device *ndev) wil_netif_rx(skb, ndev, cid, stats, true); } -/** - * Proceed all completed skb's from Rx VRING +/* Proceed all completed skb's from Rx VRING * * Safe to call from NAPI poll, i.e. softirq with interrupts enabled */ @@ -1629,8 +1624,7 @@ void wil_tx_desc_set_nr_frags(struct vring_tx_desc *d, int nr_frags) d->mac.d[2] |= (nr_frags << MAC_CFG_DESC_TX_2_NUM_OF_DESCRIPTORS_POS); } -/** - * Sets the descriptor @d up for csum and/or TSO offloading. The corresponding +/* Sets the descriptor @d up for csum and/or TSO offloading. The corresponding * @skb is used to obtain the protocol and headers length. * @tso_desc_type is a descriptor type for TSO: 0 - a header, 1 - first data, * 2 - middle, 3 - last descriptor. @@ -1660,8 +1654,7 @@ static void wil_tx_desc_offload_setup_tso(struct vring_tx_desc *d, d->dma.d0 |= BIT(DMA_CFG_DESC_TX_0_PSEUDO_HEADER_CALC_EN_POS); } -/** - * Sets the descriptor @d up for csum. The corresponding +/* Sets the descriptor @d up for csum. The corresponding * @skb is used to obtain the protocol and headers length. * Returns the protocol: 0 - not TCP, 1 - TCPv4, 2 - TCPv6. * Note, if d==NULL, the function only returns the protocol result. @@ -2216,8 +2209,7 @@ static int wil_tx_ring(struct wil6210_priv *wil, struct wil6210_vif *vif, return rc; } -/** - * Check status of tx vrings and stop/wake net queues if needed +/* Check status of tx vrings and stop/wake net queues if needed * It will start/stop net queues of a specific VIF net_device. * * This function does one of two checks: @@ -2419,8 +2411,7 @@ void wil_tx_latency_calc(struct wil6210_priv *wil, struct sk_buff *skb, sta->stats.tx_latency_max_us = skb_time_us; } -/** - * Clean up transmitted skb's from the Tx VRING +/* Clean up transmitted skb's from the Tx VRING * * Return number of descriptors cleared * @@ -2460,8 +2451,7 @@ int wil_tx_complete(struct wil6210_vif *vif, int ringid) while (!wil_ring_is_empty(vring)) { int new_swtail; struct wil_ctx *ctx = &vring->ctx[vring->swtail]; - /** - * For the fragmented skb, HW will set DU bit only for the + /* For the fragmented skb, HW will set DU bit only for the * last fragment. look for it. * In TSO the first DU will include hdr desc */ From patchwork Thu Sep 10 06:54:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249563 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp476903ilk; Thu, 10 Sep 2020 00:14:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVYVx6CJgkHJp/TLPqpMhJ1WKSyGPQP4mJKrmR30MrNhSi6flIT5kuiKV6NfYcY0RjblOp X-Received: by 2002:a17:906:d94:: with SMTP id m20mr7802182eji.133.1599722051982; Thu, 10 Sep 2020 00:14:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599722051; cv=none; d=google.com; s=arc-20160816; b=L9abt4P7veGvjhEDcuc/sXNlOs+wCnQfAiXjvQNpEICnm9y2z6E7USeScF7BRQZZ8q Efrv00XTrGe8UT0wviQwZbTfXqe89ta0U+mYKhNSTy5vLam8wP1SmtOSbYHEHzHW8vd6 r9GG4WfCvAcsO1nX5idkmh/UzU8VNKYxcoWCRehlmIWBZTdCwKfgX7E+G3e/rFbmT7RF 6Uj6PGhgIWXxlF38f6h5EuPlERSbO89RrrOsyRggpBoLzZixp9gU/LndYKZAz04OTW9/ R+37vWbfiZukhUEaSXYwl1cKJdqucDcRT3PyUbf/UeIF5FOJovUIcEHQyEqAMJHXp46V 4Yyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=y3aNmNMSAAKySSaB5bb9ahC7IKT1fIK3BKBDgaZqfos=; b=jNEtwXnDMTZAkFV6Iv5JgZZxCHZeOsCP5Lka3K16dQDSJYvxIAW0rz9H9et4PJNGbu 90Q6sx3j9ddTpbb33ZyOfLOFdvdXHhNbFXdyPJm6hoG5ag3XQ6s3CwiLJfBwQ801S9n0 +gwXJw0lOA72Wc1rsDbFat2kiyvg3o9jogPPwmYpfD4F+1VPANJOraZvO4+2e7PPsdXX H9MYBMWpzq/RwwiBGPizGHBNhxzYm9Adj3UNwlh65eBF50TFTozotzwm5VZM2a6g07xL ibUFlpluYtMSh6w9ZL9ilpPewaIDohkSenG6ysSQFmV2q1vgCW2TCVGLdRrDRgpG+wvy RLYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j0p5N0Io; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q25si3168212edb.467.2020.09.10.00.14.11; Thu, 10 Sep 2020 00:14:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=j0p5N0Io; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730353AbgIJHOG (ORCPT + 2 others); Thu, 10 Sep 2020 03:14:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730257AbgIJG6d (ORCPT ); Thu, 10 Sep 2020 02:58:33 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE6D0C061358 for ; Wed, 9 Sep 2020 23:55:16 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id e16so5448015wrm.2 for ; Wed, 09 Sep 2020 23:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y3aNmNMSAAKySSaB5bb9ahC7IKT1fIK3BKBDgaZqfos=; b=j0p5N0IoFnkC0jPzzxrex1C4xZe5aqi7g6j7/iQDrX3ZY1pp2W9F2bfHuZYIRNydrj KlOKCcnfhmEoNdCXqyyG17AKOphxep4Vd4sIUaMX3x4JDf0n45cBzPGc1pVDmxZYVkcT DdK4cwwSNEQcSQRQtDfbjaFUSWibF+0u30DoOXwBI2pDXDPy+CzzOl7TqK1vjMACZOsd ajwsR0fa5ZIQjHWY8iMNVui88rI0EiJLA7avrXk9qYWqQ8PDHmNnFAJzShdUAyRXW3Ab O1rF88b8mqzTArTf4DnuTfbti2t432HCpO/IXwpbSS0+sYI+MaiDSo+lcirO860FBW6Y DL/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y3aNmNMSAAKySSaB5bb9ahC7IKT1fIK3BKBDgaZqfos=; b=KKgYVpgaYF5+jbsDQCMuah6imqOKBZxn6MMkQ6brdGZb9mWFrp2xVHpCeR/oMCFt58 wP26leczS46bZhIFo9e2tyVlEcmVfnCTazDRKAD5KL8SWJlsX/Hh7inAttO8WD9AYXEc PF6xGUei3SHZfeqEBDRw8DtqCwUpTogyQYMAoggblYKcJImlMpHYJiaVZ8bkc2UiHH83 /025NXNMuwPYFOWd8G3UIW336JerdDcZrIVFphOPAeTannuXlvg1noOXnJLvanwY1vlM 40GP8GY5oxjOqlwNqKtKkJE8AhdGUN6Cr3l0xtxFtG3BVPjaZ9yEwtztZbSt6lDImvsd o/+g== X-Gm-Message-State: AOAM531GIAbJWIaam/JLEinEhY5qBRp5+8DcN/4VqROPgEcPWF8GDW/U bXrZK91xvsJC4Lq+xf5eAwTknfRCk9xGKA== X-Received: by 2002:a5d:40c7:: with SMTP id b7mr7393943wrq.300.1599720915498; Wed, 09 Sep 2020 23:55:15 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:14 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Maya Erez , wil6210@qti.qualcomm.com Subject: [PATCH 19/29] wil6210: txrx_edma: Demote comments which are clearly not kernel-doc Date: Thu, 10 Sep 2020 07:54:21 +0100 Message-Id: <20200910065431.657636-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/txrx_edma.c:155: warning: Function parameter or member 'wil' not described in 'wil_ring_alloc_skb_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:155: warning: Function parameter or member 'ring' not described in 'wil_ring_alloc_skb_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:155: warning: Function parameter or member 'i' not described in 'wil_ring_alloc_skb_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1161: warning: Function parameter or member 'wil' not described in 'wil_tx_sring_handler' drivers/net/wireless/ath/wil6210/txrx_edma.c:1161: warning: Function parameter or member 'sring' not described in 'wil_tx_sring_handler' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'd' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'tso_desc_type' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'is_ipv4' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'tcp_hdr_len' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'skb_net_hdr_len' not described in 'wil_tx_desc_offload_setup_tso_edma' drivers/net/wireless/ath/wil6210/txrx_edma.c:1328: warning: Function parameter or member 'mss' not described in 'wil_tx_desc_offload_setup_tso_edma' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/txrx_edma.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/wil6210/txrx_edma.c b/drivers/net/wireless/ath/wil6210/txrx_edma.c index 7bfe867c7509e..8ca2ce51c83ef 100644 --- a/drivers/net/wireless/ath/wil6210/txrx_edma.c +++ b/drivers/net/wireless/ath/wil6210/txrx_edma.c @@ -147,9 +147,7 @@ static int wil_tx_init_edma(struct wil6210_priv *wil) return rc; } -/** - * Allocate one skb for Rx descriptor RING - */ +/* Allocate one skb for Rx descriptor RING */ static int wil_ring_alloc_skb_edma(struct wil6210_priv *wil, struct wil_ring *ring, u32 i) { @@ -1152,8 +1150,7 @@ wil_get_next_tx_status_msg(struct wil_status_ring *sring, u8 *dr_bit, *msg = *_msg; } -/** - * Clean up transmitted skb's from the Tx descriptor RING. +/* Clean up transmitted skb's from the Tx descriptor RING. * Return number of descriptors cleared. */ int wil_tx_sring_handler(struct wil6210_priv *wil, @@ -1314,8 +1311,7 @@ int wil_tx_sring_handler(struct wil6210_priv *wil, return desc_cnt; } -/** - * Sets the descriptor @d up for csum and/or TSO offloading. The corresponding +/* Sets the descriptor @d up for csum and/or TSO offloading. The corresponding * @skb is used to obtain the protocol and headers length. * @tso_desc_type is a descriptor type for TSO: 0 - a header, 1 - first data, * 2 - middle, 3 - last descriptor. From patchwork Thu Sep 10 06:54:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249562 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp476537ilk; Thu, 10 Sep 2020 00:13:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpiB+ITtWo34fSbINTPU4hemwtC/fV4787FE2wIcMyquC1U7RQwv9LOcc4fTP60zjIbo9P X-Received: by 2002:aa7:d296:: with SMTP id w22mr7884067edq.327.1599722017418; Thu, 10 Sep 2020 00:13:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599722017; cv=none; d=google.com; s=arc-20160816; b=vYa8h5q5v0uRvPR2bT/nuNRHR3KlWx08LO06eq2raF21fWWZUAm0Lje8zVIYiHqYYn rvXgBHlLo9B/DncerzKs7cyMviLdKD+Os2AG80ozi0veW4Akgnj7wyKUl3Tc2Z0u9p8Q 4I/9Pg5vIEwaFswG9YAzs78e3IRPjdR+RGHFkBxyARtMAfDlm8S3EdTlyHlY2VC21MV0 3KCLWYU3efyXTsInPJT9fQEex1kZosemsBJS3g/9I0kLl2PyqyHElIeVz/TI/CT5XxWO N/uthkm70qSBjFujvN1B4j0NX1SI/aAWe5VNAvjeZ0OaKaDJUeS73N3a0ev5rV0KTO2Q 7VXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=urR5WKC0YHrLgprPWWXo12lMVDtV/KRxTWx7J20eMag=; b=x0Q5Mucfs6+XCrKlAEEwpy+awBzoKrdbUaDwGsYMCip9MKsfYUqD744z+W6b+La7Th YARFVYQBq9vRdJ9DP7LF+4fih05aiqcMnM1I5L1iPq6ficPm5NhxtKx0veFK5KIhHy8s I6IXtHlOjH7+1jPfTZzwZfRQ6xECjuhER4HhB+7eA0Jgalp4+sZXFbguAMKMqTmUAV3z ldfJiACu0mdj+FwoP7K0IT/E0Jl1JplLcrjEGs7fjb3mGmxuXNUj3Rl71ctWnbh48NnP PmNbA+nm65NfGfuQOL2UVEPfVdgxwxDeWlf9vbvFm1OwvWWYMkR0V84eVpRunndK34Nm caBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Um8KwA1D; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id df5si3093134edb.398.2020.09.10.00.13.37; Thu, 10 Sep 2020 00:13:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Um8KwA1D; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730277AbgIJHNV (ORCPT + 2 others); Thu, 10 Sep 2020 03:13:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726893AbgIJG6y (ORCPT ); Thu, 10 Sep 2020 02:58:54 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E53CFC06135C for ; Wed, 9 Sep 2020 23:55:17 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id a65so4458959wme.5 for ; Wed, 09 Sep 2020 23:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=urR5WKC0YHrLgprPWWXo12lMVDtV/KRxTWx7J20eMag=; b=Um8KwA1D4nIc4VA3tMizMDPtconF94POnFFEiyvMu3k4y7FSvoND21OeGbm+bAy1J8 zCnYdcakCq3Jcls8OG7Y2VwajhWCpd9uGplZP7Iy5fdTFfsiU/zmqt5wiV2G/w0MawBz c/G2KJLf5RfnXlK7TrwVvC8l1kP98cVggxizpOz8NRXJ4DWpZwqZpxVMnZeIKE/6qlQ1 j8weuOyLbe/0sPRZtPmPEO3j4sFEFDIgB1GhECyBdRWg3eCqRFp/EUwqOD+n9h5ta+LH w63dFMwCRoZ49GopwAJ0zBEgdGHCI9gh0n07yikSfxMDE4IPJK3ZaiTA0+Hjnu1kKcX9 KUXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=urR5WKC0YHrLgprPWWXo12lMVDtV/KRxTWx7J20eMag=; b=Y235P2PKv9CCV17rCn6uXy+mTYuD6MNQFFco7ZzLFjeaO++JKrvOZ6caRLS7Mh3h2h 5iUXFa6eCZL87htOqdqfXooILhUGG0F7I+pRg+xOmOeo8Iul/mahSuXKw6MgUW/KXG61 vyNWFKekLb6w3TOV1m1+U1UetWKhXnb1I2A7DUXENaYzI8vVb7KIJKOXUtJGDNpr++hJ YsYwbmcLUOFnzdRF9AbIoCpfMEGRUxY037Zgwqf+h6GbVUOyIwhNwLZ4GXxKX8NkOzOT FP+jlm0s4a1AelVo2+2M3r2RUZQkflY2YBI/0QoazPVHJZ8BoVShuH9Nkvw/MjGGvx2c 47vw== X-Gm-Message-State: AOAM5315XBJldrKlAn6G+6/MPzHCc3ReHV6sS17NRtxdDF0q80rOhlGm 1NMuU0XLakkg+HPgaHqTnyxTlA== X-Received: by 2002:a1c:dd45:: with SMTP id u66mr7042690wmg.117.1599720916617; Wed, 09 Sep 2020 23:55:16 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:16 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Maya Erez , wil6210@qti.qualcomm.com Subject: [PATCH 20/29] wil6210: pmc: Demote a few nonconformant kernel-doc function headers Date: Thu, 10 Sep 2020 07:54:22 +0100 Message-Id: <20200910065431.657636-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/pmc.c:43: warning: Function parameter or member 'wil' not described in 'wil_pmc_alloc' drivers/net/wireless/ath/wil6210/pmc.c:43: warning: Function parameter or member 'num_descriptors' not described in 'wil_pmc_alloc' drivers/net/wireless/ath/wil6210/pmc.c:43: warning: Function parameter or member 'descriptor_size' not described in 'wil_pmc_alloc' drivers/net/wireless/ath/wil6210/pmc.c:229: warning: Function parameter or member 'wil' not described in 'wil_pmc_free' drivers/net/wireless/ath/wil6210/pmc.c:229: warning: Function parameter or member 'send_pmc_cmd' not described in 'wil_pmc_free' drivers/net/wireless/ath/wil6210/pmc.c:307: warning: Function parameter or member 'wil' not described in 'wil_pmc_last_cmd_status' drivers/net/wireless/ath/wil6210/pmc.c:320: warning: Function parameter or member 'filp' not described in 'wil_pmc_read' drivers/net/wireless/ath/wil6210/pmc.c:320: warning: Function parameter or member 'buf' not described in 'wil_pmc_read' drivers/net/wireless/ath/wil6210/pmc.c:320: warning: Function parameter or member 'count' not described in 'wil_pmc_read' drivers/net/wireless/ath/wil6210/pmc.c:320: warning: Function parameter or member 'f_pos' not described in 'wil_pmc_read' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/pmc.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/wil6210/pmc.c b/drivers/net/wireless/ath/wil6210/pmc.c index 9b4ca6b256d26..a2f7b4c1da48d 100644 --- a/drivers/net/wireless/ath/wil6210/pmc.c +++ b/drivers/net/wireless/ath/wil6210/pmc.c @@ -29,8 +29,7 @@ void wil_pmc_init(struct wil6210_priv *wil) mutex_init(&wil->pmc.lock); } -/** - * Allocate the physical ring (p-ring) and the required +/* Allocate the physical ring (p-ring) and the required * number of descriptors of required size. * Initialize the descriptors as required by pmc dma. * The descriptors' buffers dwords are initialized to hold @@ -221,8 +220,7 @@ void wil_pmc_alloc(struct wil6210_priv *wil, mutex_unlock(&pmc->lock); } -/** - * Traverse the p-ring and release all buffers. +/* Traverse the p-ring and release all buffers. * At the end release the p-ring memory */ void wil_pmc_free(struct wil6210_priv *wil, int send_pmc_cmd) @@ -299,8 +297,7 @@ void wil_pmc_free(struct wil6210_priv *wil, int send_pmc_cmd) mutex_unlock(&pmc->lock); } -/** - * Status of the last operation requested via debugfs: alloc/free/read. +/* Status of the last operation requested via debugfs: alloc/free/read. * 0 - success or negative errno */ int wil_pmc_last_cmd_status(struct wil6210_priv *wil) @@ -311,8 +308,7 @@ int wil_pmc_last_cmd_status(struct wil6210_priv *wil) return wil->pmc.last_cmd_status; } -/** - * Read from required position up to the end of current descriptor, +/* Read from required position up to the end of current descriptor, * depends on descriptor size configured during alloc request. */ ssize_t wil_pmc_read(struct file *filp, char __user *buf, size_t count, From patchwork Thu Sep 10 06:54:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259280 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE6DC433E2 for ; Thu, 10 Sep 2020 07:12:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 899682075B for ; Thu, 10 Sep 2020 07:12:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vZf4VFr5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730260AbgIJHMG (ORCPT ); Thu, 10 Sep 2020 03:12:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730099AbgIJG7P (ORCPT ); Thu, 10 Sep 2020 02:59:15 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43367C06135E for ; Wed, 9 Sep 2020 23:55:20 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id x23so4473852wmi.3 for ; Wed, 09 Sep 2020 23:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rWq4EIZLBdjUFDSSQaVD1PvQUVhVWlX38rMGrIxZmlM=; b=vZf4VFr50U74u75SGpXYrch3+0R3YHtrpUnIDTh4Iwn8P9ALwP8X066Eu+kg8na2RZ 0ff7H7RyyEqy0MTTFYq3oeaPMPYSvC2zLCiJDq6qwLzw8oP9EMJSZT6/GthEyT3irFBU spadF5xHegJ0j7SbOTJq+QvrQLiw/hvKrvjRkrbsBghA9/qgiLPkLUGHJ3ZPYpJjAVjw xXez+57QSZeI7Mo1d9eAtHA4hVN57fEP7rQEHgMv7QD2n5ASP4DPh8uphMBUj0Ui2/Rr ZpDz50hf/2nOJYpmKlqkNFlDT9LpJy191ux12isWCgMmFYcwuqZzi5Qd/zH9d1c/YMx9 6o5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rWq4EIZLBdjUFDSSQaVD1PvQUVhVWlX38rMGrIxZmlM=; b=VjGZreArgshhQBGenbA91Y/9lOlwen4Oj5/js08WmR7aH3oWdE0hG3tFjnJrzaLrqX LfetZm/G4IA21bRHONs7WxhYBLAIxagRQP8X2/0KVJAKGzJMPaFX48zvnUSN9jr8Im8t 9DsRGnbceMLqmy0BHed1InmgwRnElwrCKD40mmjNHkDQMEjGoLABuoj+ahTZHCozEoZK a3922UhFNz/uZdZo9uUwRRA08KYXd5t4wePdQ1Lk3xbH/K8ps5Eb+2IxvC8YH8KGFCLy kdI60gFeREadRm7X0ztq42uY8/ee2sC0+lSx3c6aUPx7bmUFBp8obx/ZfOqwpyJTjBgg 5ymw== X-Gm-Message-State: AOAM533g9NSs7bZ091WuaFFxmcb7gBQpv6WzR/XevWeAg/2K4t9UqhUG XihGgQ9ZPto0UI8tkZ9jUvsNVA== X-Google-Smtp-Source: ABdhPJxYc4wxvPHg+Y+0uosZNsNdwaYE7td5fUHWGXb0CT4vstdMdqxPg6zr4aysxFfG6RuXte4dNw== X-Received: by 2002:a1c:5f41:: with SMTP id t62mr6870731wmb.22.1599720918933; Wed, 09 Sep 2020 23:55:18 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:18 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Maya Erez , wil6210@qti.qualcomm.com Subject: [PATCH 22/29] wil6210: wmi: Correct misnamed function parameter 'ptr_' Date: Thu, 10 Sep 2020 07:54:24 +0100 Message-Id: <20200910065431.657636-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or member 'ptr_' not described in 'wmi_buffer_block' drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Excess function parameter 'ptr' description in 'wmi_buffer_block' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c index 421aebbb49e54..8699f8279a8be 100644 --- a/drivers/net/wireless/ath/wil6210/wmi.c +++ b/drivers/net/wireless/ath/wil6210/wmi.c @@ -262,7 +262,7 @@ struct fw_map *wil_find_fw_mapping(const char *section) /** * Check address validity for WMI buffer; remap if needed * @wil: driver data - * @ptr: internal (linker) fw/ucode address + * @ptr_: internal (linker) fw/ucode address * @size: if non zero, validate the block does not * exceed the device memory (bar) * From patchwork Thu Sep 10 06:54:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249559 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp475265ilk; Thu, 10 Sep 2020 00:11:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNuYm2zSA8z9a/rlc1vf0dLT9txtgy5tW37R0UzVUNLE8rmsl+M6qx9eFJhKoG7n8+id5V X-Received: by 2002:a17:906:3785:: with SMTP id n5mr7848968ejc.218.1599721895007; Thu, 10 Sep 2020 00:11:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599721895; cv=none; d=google.com; s=arc-20160816; b=H6qRVYZuda4o9T07a0KMpYB7Oa94B4NbbXyk4SIagMIcb3g2jHjqgeCkGTQu4O9c7v VNhJfhglZb2ugpwp7FDwD2gfBZZp0ZGfEO+6OjLKgRVYMs5DawLyRcnC5mSMjs7fCdt3 uRivYEHRDqmf8bnx/5BJePHypT7snbi+FxF/jzBqW6wZYBCDj/OP44JVJ2qrwhlsFn9r ByPY2nIowGGuC2SmTid3Ykh+L5JoNxDQXrXOvex2erCO4D7jQlEjDaRNhzLw/bUnslbl BsOXCWOLcHWyDn/YgH9VMemFmAZo9g9PNvijwe4/y7+wbSpp2YZXwr6QfIxWHLqP7a+f C0zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qElmRnHsar7tn4JV1a4MOU4ECliWfWuqmHMN13MnixU=; b=TaMCCZsJkQvemZYACYL5Dt5TMehAjq1gNnGL3BPBRLBgLWssye1QGI60yZZmmpFEPd qxU21INWQJUQexGCY7/C+cqwhGYjkhwSIUNa+uPkqLgx2R8GhbMWJaLqMggyvErbVOep M4Rn815r9lta1dG77znbMRrJ8IJRzfcCYjFIrISyJBb71J1g1QM/oMNTLJA7mG6pp3OO FpZi9HAVrNxqAgZi4IjTQVnMQHhMGQQg43lQ2b8yFdD06X/u39GX1MmsMkG9/JVsWLxv jN0qBOlvmSnO4+AT02XN/gViTgdkRGq4fuXpnsgb+y0iOzZL6cXKXUY3X0tCmfj9VnPj p9AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ynl5uR9/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ck10si2920231ejb.167.2020.09.10.00.11.34; Thu, 10 Sep 2020 00:11:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ynl5uR9/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730410AbgIJHLc (ORCPT + 2 others); Thu, 10 Sep 2020 03:11:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729781AbgIJG7l (ORCPT ); Thu, 10 Sep 2020 02:59:41 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71DADC061361 for ; Wed, 9 Sep 2020 23:55:21 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id q9so4486034wmj.2 for ; Wed, 09 Sep 2020 23:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qElmRnHsar7tn4JV1a4MOU4ECliWfWuqmHMN13MnixU=; b=ynl5uR9/TghAML8h3nkWxFysaN59Ld5+yQaEG9uUHi0tVn58MpWSSTN1nZwEJbNnDt zWqNp0B8x8emHhs6TS0WXNWn1E5ax8L3pGLwjHANK9SbqQxYUv3e0h7lAi3fIcFcyuRh 2eMaUmYBb7K568PkAqSAY68HyUmV5QoutOvE0qqm8zkOpeC4+dqqryExT2Qa7Fu2sLjE gExMNSoYwJUCvSnA2GEyFGcZqshoOWH1Mj+diqfyBGMDZgsYOt8btBL3Nbqv7mRVZXIb 7tsxg5OcMl2i5Ap+bzm4/vhiHL9Hf7gz7rH1pmjkJ+fCfpLw8Qj9M4Wn/b6QUPYdswDk stRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qElmRnHsar7tn4JV1a4MOU4ECliWfWuqmHMN13MnixU=; b=bEei6sRiCJaH9yHGDk0fpzoNtBLAOlRf+AbXnKPeb2snOdDtQpciXpmNUd1iqBLfTo Rh2OmuuoH03IvJOFpeskZJl84q9h2IcwphRLYkhWEDhbmUolwKli1tocyKqr53NJS/hj fqMWD5VMkXUSFFV1gP2gV1hZVDWCtNzLpQhVgMBMyxkoF3ST+xzFWohSVCnMRtvBlRFH lXLITF/ZL7W0XdkZ4Mn6VlSUCBRYoW4welkVwnnRntdm8GYCUTM4U8WGXltC89rBkG/q 7n/JpSL28Gm4+Nf4rhIUS++NJO8bFwOfbZ4azut+HIP0RM1jCUC5mjACPoGhOTGbqCkz jYug== X-Gm-Message-State: AOAM5305U6Sriv1RN6IQt2JTcSzvRs4H9W1m9K4PfkkX6LQZoz2vOq/S c+wace3+/ON7vDmBr5MSIrQe9A== X-Received: by 2002:a05:600c:2183:: with SMTP id e3mr7393106wme.49.1599720920090; Wed, 09 Sep 2020 23:55:20 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:19 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones Subject: [PATCH 23/29] ath6kl: wmi: Remove unused variable 'rate' Date: Thu, 10 Sep 2020 07:54:25 +0100 Message-Id: <20200910065431.657636-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath6kl/wmi.c: In function ‘ath6kl_wmi_bitrate_reply_rx’: drivers/net/wireless/ath/ath6kl/wmi.c:1204:6: warning: variable ‘rate’ set but not used [-Wunused-but-set-variable] Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/ath6kl/wmi.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index 6885d2ded53a8..a4339cca661f0 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.c +++ b/drivers/net/wireless/ath/ath6kl/wmi.c @@ -1201,8 +1201,7 @@ static int ath6kl_wmi_pstream_timeout_event_rx(struct wmi *wmi, u8 *datap, static int ath6kl_wmi_bitrate_reply_rx(struct wmi *wmi, u8 *datap, int len) { struct wmi_bit_rate_reply *reply; - s32 rate; - u32 sgi, index; + u32 index; if (len < sizeof(struct wmi_bit_rate_reply)) return -EINVAL; @@ -1211,15 +1210,10 @@ static int ath6kl_wmi_bitrate_reply_rx(struct wmi *wmi, u8 *datap, int len) ath6kl_dbg(ATH6KL_DBG_WMI, "rateindex %d\n", reply->rate_index); - if (reply->rate_index == (s8) RATE_AUTO) { - rate = RATE_AUTO; - } else { + if (reply->rate_index != (s8) RATE_AUTO) { index = reply->rate_index & 0x7f; if (WARN_ON_ONCE(index > (RATE_MCS_7_40 + 1))) return -EINVAL; - - sgi = (reply->rate_index & 0x80) ? 1 : 0; - rate = wmi_rate_tbl[index][sgi]; } ath6kl_wakeup_event(wmi->parent_dev); From patchwork Thu Sep 10 06:54:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249553 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp469854ilk; Thu, 10 Sep 2020 00:02:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzL0+d3PbeEFSHk0kWElejy3lVM8PPbcNZcej7dB5PLY1BUDSXshDar6z8s31w9uUC6sbMZ X-Received: by 2002:a17:906:3e90:: with SMTP id a16mr6919698ejj.363.1599721353806; Thu, 10 Sep 2020 00:02:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599721353; cv=none; d=google.com; s=arc-20160816; b=Fxj9gVbq8j+d7g5JNepIHzqAvnsfDTdMx08dW8dGObEyaOw09SqHnRjD3BJh4+a5gp J1sxBHHd596yiFl/G3Smy73EC4cwBlXBL6xImaVgNqTbK0li4SRsD0OFgLGBFX5aF168 yE8czjzszjytkfEaX0adwcA0TVG891OqktGiXhiSJTeeA3TyXm1hzS01UtZVqVvAzlZD xyxFAZkmng14hjWqTI53hr10QKAPc9RWtY7B3cb65lE3vhrCHgEkA48XPumHA3V4cd1r VnOczKB7UvghmKY8tyAm0fXSXsUrhADNCqT8+mz/XENEIJPmBqI8CpHyZJkNNxYlVk8E 4vgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1sh6GJ0mJWJb3ICmo91l9UDo6bvtBy9zVj1QpKnJ7Ig=; b=Ib69z7zohvUhlItXs7Wf20qFTDrLCSqsq4Fi937MaMXvfLB6VTV/Aw3tutABMkix9n GqCOYotdJX+Pwig5KtNakw2ULmcEP/y7VUbVP8clIx6RVOtm4CeLU2atCwKlSHp201J5 cgNe7Zos4AoLkmkJU7Zk0fGW8uis5LMHCiSvMoLQBN8KuYiIJ04DZ+DdIjVJ0IJe7Gdu HTTWd0tQwFkCwpeCR2DYOuDul4tpqxAYGpPm4Kwa4W3U8jb+Zc5BNOWHDV2aUFummLa2 S1vmO8ytA0HIqPb7sUA8h4eupoB5M57TaOVLav0WuRviIrschLv4iYo4KIn7R5BgDCsK Fu3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C4soKIQr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si2969137ejt.659.2020.09.10.00.02.33; Thu, 10 Sep 2020 00:02:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C4soKIQr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730276AbgIJHCH (ORCPT + 2 others); Thu, 10 Sep 2020 03:02:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730285AbgIJG77 (ORCPT ); Thu, 10 Sep 2020 02:59:59 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C10FC061364 for ; Wed, 9 Sep 2020 23:55:22 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id a9so4639578wmm.2 for ; Wed, 09 Sep 2020 23:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1sh6GJ0mJWJb3ICmo91l9UDo6bvtBy9zVj1QpKnJ7Ig=; b=C4soKIQr+HtIx13rx9qA/15FRHFKVdvspCRsPnq/goUVkiQ4KZNEepatmbLTp2tc3C ctqDXC+sft2sLmaCxPWFVqy1wjtwIvIBpREamtN4rJ/LVvlDdEi2MJu1cNiQSxnQD4VE GgMMRYv2oCxVohRyT3aSUb5j0mD7xM2sZKmpxpCyBm8JAZaFPCCxQQ+bV8NjJKJKx9RI kxwK/4ZD646Lcol5oAd8xIPIhFj1TridIQ0n8S8PuxUHc+2LskD63txFM8mBTn+CzvgY j3bSz3NJOG4J2WrBJaWnu/qLYBGNnrA3NqcKKZsebBbl9Q9V9U/a9z+aLQBwA59U/hBs 56wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1sh6GJ0mJWJb3ICmo91l9UDo6bvtBy9zVj1QpKnJ7Ig=; b=kkGUnbb6zha8LIh4rpecSqlYGZEHdxcMgTEVMM6X5QvIfyJjLjw6PbRN+FIUGPsioy XaRug4PdsPYRkoRco+zQw2OY2W8cz13Inpwd1lFPEJbTq1X+ggIuiZJGGSItOHkakjhs e+pMoXrrge8Cb5iswSBqEfd/0aMudi2vudyTE96rbFtaBwTXEpOFO7HrdwbfkpJFn+wD PMGb+zCcU6Vh1bXp9aT3cGfRI4lh+x96mCkv//TRZF+AunzjJDanhBhBHVQzjYsqEPsA NxlvoMHkIDEssuEoJsS3GRQb/Fh+zdM/UVaLVb5twWTk5Eulovf/XHgd6kIjXO28Qmdm gNLA== X-Gm-Message-State: AOAM532eR+l2wzx9oV0v611gUkdQNG1Ayw8LIYWqFDP43jXqLLe5PQh5 4qWRBNFko7C8+gVtsKc+9BUJRw== X-Received: by 2002:a7b:c5c1:: with SMTP id n1mr6617738wmk.125.1599720921171; Wed, 09 Sep 2020 23:55:21 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:20 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , QCA ath9k Development Subject: [PATCH 24/29] ath9k: ar9002_initvals: Remove unused array 'ar9280PciePhy_clkreq_off_L1_9280' Date: Thu, 10 Sep 2020 07:54:26 +0100 Message-Id: <20200910065431.657636-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9002_initvals.h:900:18: warning: ‘ar9280PciePhy_clkreq_off_L1_9280’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/ath9k/ar9002_initvals.h | 14 -------------- 1 file changed, 14 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/ath9k/ar9002_initvals.h b/drivers/net/wireless/ath/ath9k/ar9002_initvals.h index 4d18c66a67903..e01b5c3728b86 100644 --- a/drivers/net/wireless/ath/ath9k/ar9002_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar9002_initvals.h @@ -897,20 +897,6 @@ static const u32 ar9280Modes_original_tx_gain_9280_2[][5] = { {0x00007844, 0x92592480, 0x92592480, 0x92592480, 0x92592480}, }; -static const u32 ar9280PciePhy_clkreq_off_L1_9280[][2] = { - /* Addr allmodes */ - {0x00004040, 0x9248fd00}, - {0x00004040, 0x24924924}, - {0x00004040, 0xa8000019}, - {0x00004040, 0x13160820}, - {0x00004040, 0xe5980560}, - {0x00004040, 0xc01dcffc}, - {0x00004040, 0x1aaabe41}, - {0x00004040, 0xbe105554}, - {0x00004040, 0x00043007}, - {0x00004044, 0x00000000}, -}; - static const u32 ar9280PciePhy_clkreq_always_on_L1_9280[][2] = { /* Addr allmodes */ {0x00004040, 0x9248fd00}, From patchwork Thu Sep 10 06:54:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 259281 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B94DEC43461 for ; Thu, 10 Sep 2020 07:11:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B5822078E for ; Thu, 10 Sep 2020 07:11:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="trv3TSNs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730339AbgIJHLL (ORCPT ); Thu, 10 Sep 2020 03:11:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730309AbgIJHAy (ORCPT ); Thu, 10 Sep 2020 03:00:54 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DEA9C061368 for ; Wed, 9 Sep 2020 23:55:23 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id a65so4459230wme.5 for ; Wed, 09 Sep 2020 23:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WVfVHRbfLs77xvEowdNmRYJl1Eqf3t8uGBw9b5yOc7s=; b=trv3TSNssv4jT0t36HHkekyc5oQb9OrM4SsI9V82hbXUfKMjBOl87eNt5/GlaRiJ1N b4CNDROwIGksCc9TQn1MhsscUtgT/gCzPhxxv7ckxHZzRvTEQZQRI4+UyxSQYnsefY4g 3atu7eH/kqNeLVaFi3AswTh+b5onrTfyRZT/tX7cIE1CB6xhSCPAHi7uHcYpHkgtNqYe s6Oz2ylbPHLbs+GIgOUP9cmpxIPC0uj8VvmFFHqDLm4uTLp1PvIA1JvhpPmFICzV5CAJ hydx8KqkleMdHQbi2lCMJWP3Air13xuIRIVXhXyjZm4+RYumUgaXf4MZQMY64yV19jso kgdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WVfVHRbfLs77xvEowdNmRYJl1Eqf3t8uGBw9b5yOc7s=; b=kKgsJEwqkgSnT70CHKm65shF1tEtI12um/2QKdr11OK2QxTThe8Fergw5TP/5BUH0C XUQSGL5uS8Et1JogQoA1QXX3DtS7wvd0L0rgnkziFILu5D4438+YCWrQR6e2d0L9TMNC znPfWJgEDp7r1nhmKJNM4ckL3BnBD//EoPXYgV8Pw75x9Jz8lD4iDeNz8IZgQkuthFy7 6Pi/llB5EeqMBAPpuGZLIC7n89psuhTxCuWPBRb6fwXjxmZldu3OFvnNT+Gn8NiEakpa epXl1FmjtUceRufPKIjT8D5edykAm5dlVogFegz1l84xKvoPT40rR1OF8NIGGklWzOzB Gz6g== X-Gm-Message-State: AOAM531KsZA1g7TjXvS5C+aaJMtHWQUM+gVcdYPrWOE4diVof2u1M0IG PL6HxdqJ58avUl0yV+Ss3m0724yyQaK8cw== X-Google-Smtp-Source: ABdhPJyK8KGbYnywMP2YHH8s/CfQGpRnnXKWDD5/aH/JPxN4EAvG/bWpYAX3/8b5XNDbUCTa5/8R9Q== X-Received: by 2002:a7b:c44b:: with SMTP id l11mr6834265wmi.52.1599720922334; Wed, 09 Sep 2020 23:55:22 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:21 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , QCA ath9k Development Subject: [PATCH 25/29] ath9k: ar9001_initvals: Remove unused array 'ar5416Bank6_9100' Date: Thu, 10 Sep 2020 07:54:27 +0100 Message-Id: <20200910065431.657636-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9001_initvals.h:462:18: warning: ‘ar5416Bank6_9100’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/ath/ath9k/ar9001_initvals.h | 37 ------------------- 1 file changed, 37 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar9001_initvals.h b/drivers/net/wireless/ath/ath9k/ar9001_initvals.h index 59524e1d4678c..aa5f086fa3b0b 100644 --- a/drivers/net/wireless/ath/ath9k/ar9001_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar9001_initvals.h @@ -459,43 +459,6 @@ static const u32 ar5416Common_9100[][2] = { {0x0000a3e0, 0x000001ce}, }; -static const u32 ar5416Bank6_9100[][3] = { - /* Addr 5G 2G */ - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00e00000, 0x00e00000}, - {0x0000989c, 0x005e0000, 0x005e0000}, - {0x0000989c, 0x00120000, 0x00120000}, - {0x0000989c, 0x00620000, 0x00620000}, - {0x0000989c, 0x00020000, 0x00020000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x005f0000, 0x005f0000}, - {0x0000989c, 0x00870000, 0x00870000}, - {0x0000989c, 0x00f90000, 0x00f90000}, - {0x0000989c, 0x007b0000, 0x007b0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00f50000, 0x00f50000}, - {0x0000989c, 0x00dc0000, 0x00dc0000}, - {0x0000989c, 0x00110000, 0x00110000}, - {0x0000989c, 0x006100a8, 0x006100a8}, - {0x0000989c, 0x004210a2, 0x004210a2}, - {0x0000989c, 0x0014000f, 0x0014000f}, - {0x0000989c, 0x00c40002, 0x00c40002}, - {0x0000989c, 0x003000f2, 0x003000f2}, - {0x0000989c, 0x00440016, 0x00440016}, - {0x0000989c, 0x00410040, 0x00410040}, - {0x0000989c, 0x000180d6, 0x000180d6}, - {0x0000989c, 0x0000c0aa, 0x0000c0aa}, - {0x0000989c, 0x000000b1, 0x000000b1}, - {0x0000989c, 0x00002000, 0x00002000}, - {0x0000989c, 0x000000d4, 0x000000d4}, - {0x000098d0, 0x0000000f, 0x0010000f}, -}; - static const u32 ar5416Bank6TPC_9100[][3] = { /* Addr 5G 2G */ {0x0000989c, 0x00000000, 0x00000000}, From patchwork Thu Sep 10 06:54:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249558 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp474500ilk; Thu, 10 Sep 2020 00:10:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxp46ei3Tm7p3/SdfMW77+NFh1CCYaG22VhxEI6crmJb5lVXTT2OybvBMxiKFR0YyjmMT88 X-Received: by 2002:a17:906:9712:: with SMTP id k18mr7251085ejx.76.1599721820598; Thu, 10 Sep 2020 00:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599721820; cv=none; d=google.com; s=arc-20160816; b=QyQCZxKOwXZXZtWbuxA2KJ/flMZ2dJHtX65ct93AiS7X7MY0he+kXcYewBLUvEfvZV iUernOo2uXCFms36GAJJHb9IBxMfC5hDcjmJvmvT3O0/xT9ZU/Y4E+owU9AmHNvj0XqI gELm3ZkVPzZs6m4xQKlRFGWpVEXqHaNIjKRoV/WxL4nr9n9NvD/LGQTwQ5hV/+UThy3w EOBpGYuLYVQWuLjjTVCPtUbsQTHEEjEH9swe31kVNXlHlrlm5ytQobCNbQwzgN4/b55O LOQywe338uzZUC2kOMAT8b1mLEHfNnAV2tftBU829Kz5UB2gMmrXjTlv+1Gf3nO4+84k cXKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ce/xQKtB6h18AIsA1S/vHOwsBOtcRFWUAHoCEtAF9MI=; b=IH8DL7a0IE8Ak6KCUwKwXwyfxQ35yqgkiKdzo4tkWjtTN7Gcgw9wli4HK60q+xRHlS 5DF34SB98XMj3/GN+O6gl+Dm0v3WFzW1OOdDmEc1uUH0A+C2MlcmKVY9d1leq8dF7Hqg YmIphWX/ChmlwTgmLLPyAsxMnoIKErkmphNBgEbG/Ix1i6pGdh59TDSKNZDERHM3gWnG wiSn4KipOqmLbI6rKKjtw+P9MjSRZRxIFn3aaS23NvrX5WXPMp+dFpKpzCj5aJqnneaO 2F9Je7kO56FzW+s3cvvnVdcjKtvVzh2TZdUr4AKwdUc6U5yYgZ2Sdn1QlN5aHaZWB7nG Ik4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Bykaar4y; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x26si3217090ejy.168.2020.09.10.00.10.20; Thu, 10 Sep 2020 00:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Bykaar4y; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728015AbgIJHKS (ORCPT + 2 others); Thu, 10 Sep 2020 03:10:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730176AbgIJHAy (ORCPT ); Thu, 10 Sep 2020 03:00:54 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B17D6C06136A for ; Wed, 9 Sep 2020 23:55:24 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id a65so4459274wme.5 for ; Wed, 09 Sep 2020 23:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ce/xQKtB6h18AIsA1S/vHOwsBOtcRFWUAHoCEtAF9MI=; b=Bykaar4y+OM56UQs41qd+HfFRBUKI2PbUH/c2CRXCxsuJjuxK9RLw25jDs+wUJM5F7 8u3vrIp+saNA2o2D2s2c5DZd9t/EzbKpkmYlzxjiIR1WqCbZ5s5wWHMP16n9uo2wrcYe SzprGrr3/V2AASVdwkkcRDIA1ahj1bVbIcsGcTmmIH4Yxd8AaYeJ7BLfmzGnfraksfvE M1vq+5HnPLEOVO7uVST3qrq7DEb6tGkEsb3eM6z41um6rN1M3U1Ay8YwKb9cfKjnqXkR n3clNLb0VPr+kzO6l0O122vhJpjxqyqGsyow82Ad/XA3d+N1UEV0xm8IHCBaLqd+ZrJp vcjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ce/xQKtB6h18AIsA1S/vHOwsBOtcRFWUAHoCEtAF9MI=; b=VYYyybdHed76RA5F7zZBWZ0yDTwPjpoSmodG+iO7kI6/7xgUhlaYMXANZRM7JPYPvp g56cekg3Wa0mJ+QunSVTcmGtErWEYH9iUYD72pPbRayeINOHXzP4qc++BfZuptW+yGL1 evwza5bLHzl4XkcEFaDLQwzUrPbZrwugn8XHUDb7Be4+pV9ua6bXhhhEgTCE16k1YHre hqZqK1BckGVzGu5I7A2aNKBKHFiDf8tsWjnTqSdQ63rLDIJJ2aGEvC1cebH4C7X7zBRY UjubG/hGh94zava8GmurvamEiVFKMQGAHHK3hsipdetOf/Dqr6rZY373OeefeC4JKyMX 0l2A== X-Gm-Message-State: AOAM530ZEuwepyXHKidyNDEF9Dw1CYDkpldp7rfDzR6KkQjWLfXYn/OF dvYmHt12ORLZyeKH9uvzEjPbNg== X-Received: by 2002:a1c:c90d:: with SMTP id f13mr7065149wmb.25.1599720923433; Wed, 09 Sep 2020 23:55:23 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:22 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , QCA ath9k Development Subject: [PATCH 26/29] ath9k: ar5008_initvals: Remove unused table entirely Date: Thu, 10 Sep 2020 07:54:28 +0100 Message-Id: <20200910065431.657636-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar5008_initvals.h:553:18: warning: ‘ar5416Bank6’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/ath/ath9k/ar5008_initvals.h | 37 ------------------- 1 file changed, 37 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/ath9k/ar5008_initvals.h b/drivers/net/wireless/ath/ath9k/ar5008_initvals.h index 467ccfae2ceed..8d251600d8458 100644 --- a/drivers/net/wireless/ath/ath9k/ar5008_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar5008_initvals.h @@ -550,43 +550,6 @@ static const u32 ar5416Bank3[][3] = { {0x000098f0, 0x01400018, 0x01c00018}, }; -static const u32 ar5416Bank6[][3] = { - /* Addr 5G 2G */ - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00000000, 0x00000000}, - {0x0000989c, 0x00e00000, 0x00e00000}, - {0x0000989c, 0x005e0000, 0x005e0000}, - {0x0000989c, 0x00120000, 0x00120000}, - {0x0000989c, 0x00620000, 0x00620000}, - {0x0000989c, 0x00020000, 0x00020000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x40ff0000, 0x40ff0000}, - {0x0000989c, 0x005f0000, 0x005f0000}, - {0x0000989c, 0x00870000, 0x00870000}, - {0x0000989c, 0x00f90000, 0x00f90000}, - {0x0000989c, 0x007b0000, 0x007b0000}, - {0x0000989c, 0x00ff0000, 0x00ff0000}, - {0x0000989c, 0x00f50000, 0x00f50000}, - {0x0000989c, 0x00dc0000, 0x00dc0000}, - {0x0000989c, 0x00110000, 0x00110000}, - {0x0000989c, 0x006100a8, 0x006100a8}, - {0x0000989c, 0x004210a2, 0x004210a2}, - {0x0000989c, 0x0014008f, 0x0014008f}, - {0x0000989c, 0x00c40003, 0x00c40003}, - {0x0000989c, 0x003000f2, 0x003000f2}, - {0x0000989c, 0x00440016, 0x00440016}, - {0x0000989c, 0x00410040, 0x00410040}, - {0x0000989c, 0x0001805e, 0x0001805e}, - {0x0000989c, 0x0000c0ab, 0x0000c0ab}, - {0x0000989c, 0x000000f1, 0x000000f1}, - {0x0000989c, 0x00002081, 0x00002081}, - {0x0000989c, 0x000000d4, 0x000000d4}, - {0x000098d0, 0x0000000f, 0x0010000f}, -}; - static const u32 ar5416Bank6TPC[][3] = { /* Addr 5G 2G */ {0x0000989c, 0x00000000, 0x00000000}, From patchwork Thu Sep 10 06:54:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 249555 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp470818ilk; Thu, 10 Sep 2020 00:04:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzz+ddeE9OV+Xeb8u/LAfStYURWTnswavV249/1SHPkA9QQRW6Pb9WJW64t2Y9qa9/ULZ2w X-Received: by 2002:a17:906:4305:: with SMTP id j5mr7659183ejm.102.1599721439888; Thu, 10 Sep 2020 00:03:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599721439; cv=none; d=google.com; s=arc-20160816; b=hLXxWEzstfVfv+3q5B9e0j/0OqPOILHtmgEa0BL7kRMNWGeJmO1okh2zZSCR+kxs53 ZZbpDQElUcROYb5R7al43/L3SGgQgdShzYWsuqhzb5wiEGXDVUIZTc42eXZ2dzmuL7/A 87AwvrxtivTj6CIBksXeVhWNVLZiFhIC3zXS5+ptLMrI8gHl/E3f6MIQsUoNib7ef8ee M+ZagA1BUFtenFHJfiG1STZgFRZthcm36n2cXd4Rq7Ck0Ug3p2XqlfSMsFOttONsKy3I PEKLc0Gt9QYf7yA8uZIUoQww8lBLw1eaeHU793b+s+2UjpcaWn2/zVGXldYzlJbNGdS1 lQxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=b0baAohHUTXp74ql/ottX2BRpMM66QSQWOVDthKtH1c=; b=FZiKH6JgtTK7lH8Vy5jsXMnXFLIO85qkbwvIIgMAA/7f7cx1USzM6OiVc5DKSRWtpM Af+Nt5VYfKol01eIgnfBfcjZdZCnliB7CbtakNQATMU2nhq30aBDGciJaCN7bzsXFWdl WHUFGE0ea6gqLi6hcsAaA6unBJIzjDqOzGH960J+y8aZA1Vdayfgo+yEyBGB0tY59LY6 vkwGT7eR4TT0UulkEy59/RvHqEsyzX1j259GAKnTM7qXJUGEmWsxZIbTWTz3SoTj/+tm k3WZaWRSlODEZ5j78RMNlGh0abvlYzCemIk8ObikPgXcq96dyZjr8PR5lXLnmx+Snb3p enjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HKVrT14h; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u5si3172194edy.385.2020.09.10.00.03.59; Thu, 10 Sep 2020 00:03:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HKVrT14h; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729876AbgIJHDB (ORCPT + 2 others); Thu, 10 Sep 2020 03:03:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730167AbgIJHA7 (ORCPT ); Thu, 10 Sep 2020 03:00:59 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D246EC06136E for ; Wed, 9 Sep 2020 23:55:25 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id j2so5419155wrx.7 for ; Wed, 09 Sep 2020 23:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b0baAohHUTXp74ql/ottX2BRpMM66QSQWOVDthKtH1c=; b=HKVrT14haY/mNZj96mGTF/IUCFO6AmmnHLrg6BbCJj06DT9z3r3APc76S4/SRI5Pog AefDbMBOTenz8QMyYyPpVKmlpQJ6zZcLbKZWSjLdV691EswPxgcUIpujucAzma9WtqbJ rufxLGvV3DutfHDWZ/+WjNV7qado49VFvzPUI4xexCRCu3LjpZPoHLCBnbsRy1ZganI7 NtTJPczGu+POYAc2gj/xSaQ+PXsF7hkLfRfPUp+PwI+TnkU7Q/gt2jsx3Ctp4R8fA01E dSkk/2pOg4241/gcbQsJHiKpWTttTDxQXD1IDtImVMosR6idtXD1+iE4bCNGK9wRey6P JPlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b0baAohHUTXp74ql/ottX2BRpMM66QSQWOVDthKtH1c=; b=C3i7UP2ePL45cF4hJx+28LjwruVOGRiMsFCCRZkWTgWhCuimQKnhQXJPV28NI6+Rbi 2YnF3vmAdMYShqzX/wARm33Xh0J85+mLUtQLNos1pCO8ohXBJXRflpyaKzMKXncqcpQn BcVd+uU8kLsmDM0jMsB1A9zd3+YIKQT1HfG9+iVDDIYXKH4D2cSWsdTAyLHKobuoBBPL ctD8hodqff5XqL5/GMjKMBzZ/iDJ+TxvhKplBeeXBP5mted3ZNYln3jE+Yolk/5G+FK8 x4XJc5F1e8vQu6Nu7EbzM4v35YksmpFMixmvcLQTmJo9FRQl10re23jd4eQ5jh18jWTk DIdg== X-Gm-Message-State: AOAM530kjoOShKP5kYBx6cv/I5KLqgPIa51GFKtdk0XS9Xe/+JfeuMDo 8FXzkskBl5DPbPVkTqf2rH3/RA== X-Received: by 2002:adf:f58b:: with SMTP id f11mr7405676wro.250.1599720924532; Wed, 09 Sep 2020 23:55:24 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:24 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , QCA ath9k Development Subject: [PATCH 27/29] ath9k: ar5008_initvals: Move ar5416Bank{0, 1, 2, 3, 7} to where they are used Date: Thu, 10 Sep 2020 07:54:29 +0100 Message-Id: <20200910065431.657636-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar5008_initvals.h:627:18: warning: ‘ar5416Bank7’ defined but not used [-Wunused-const-variable=] 627 | static const u32 ar5416Bank7[][2] = { | ^~~~~~~~~~~ drivers/net/wireless/ath/ath9k/ar5008_initvals.h:548:18: warning: ‘ar5416Bank3’ defined but not used [-Wunused-const-variable=] 548 | static const u32 ar5416Bank3[][3] = { | ^~~~~~~~~~~ drivers/net/wireless/ath/ath9k/ar5008_initvals.h:542:18: warning: ‘ar5416Bank2’ defined but not used [-Wunused-const-variable=] 542 | static const u32 ar5416Bank2[][2] = { | ^~~~~~~~~~~ drivers/net/wireless/ath/ath9k/ar5008_initvals.h:536:18: warning: ‘ar5416Bank1’ defined but not used [-Wunused-const-variable=] 536 | static const u32 ar5416Bank1[][2] = { | ^~~~~~~~~~~ drivers/net/wireless/ath/ath9k/ar5008_initvals.h:462:18: warning: ‘ar5416Bank0’ defined but not used [-Wunused-const-variable=] 462 | static const u32 ar5416Bank0[][2] = { | ^~~~~~~~~~~ Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/ath/ath9k/ar5008_initvals.h | 31 ------------------- drivers/net/wireless/ath/ath9k/ar5008_phy.c | 31 ++++++++++++++++++- 2 files changed, 30 insertions(+), 32 deletions(-) -- 2.25.1 diff --git a/drivers/net/wireless/ath/ath9k/ar5008_initvals.h b/drivers/net/wireless/ath/ath9k/ar5008_initvals.h index 8d251600d8458..7da8365ae69a8 100644 --- a/drivers/net/wireless/ath/ath9k/ar5008_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar5008_initvals.h @@ -459,12 +459,6 @@ static const u32 ar5416Common[][2] = { {0x0000a3e0, 0x000001ce}, }; -static const u32 ar5416Bank0[][2] = { - /* Addr allmodes */ - {0x000098b0, 0x1e5795e5}, - {0x000098e0, 0x02008020}, -}; - static const u32 ar5416BB_RfGain[][3] = { /* Addr 5G 2G */ {0x00009a00, 0x00000000, 0x00000000}, @@ -533,23 +527,6 @@ static const u32 ar5416BB_RfGain[][3] = { {0x00009afc, 0x000000f9, 0x000000f9}, }; -static const u32 ar5416Bank1[][2] = { - /* Addr allmodes */ - {0x000098b0, 0x02108421}, - {0x000098ec, 0x00000008}, -}; - -static const u32 ar5416Bank2[][2] = { - /* Addr allmodes */ - {0x000098b0, 0x0e73ff17}, - {0x000098e0, 0x00000420}, -}; - -static const u32 ar5416Bank3[][3] = { - /* Addr 5G 2G */ - {0x000098f0, 0x01400018, 0x01c00018}, -}; - static const u32 ar5416Bank6TPC[][3] = { /* Addr 5G 2G */ {0x0000989c, 0x00000000, 0x00000000}, @@ -587,13 +564,6 @@ static const u32 ar5416Bank6TPC[][3] = { {0x000098d0, 0x0000000f, 0x0010000f}, }; -static const u32 ar5416Bank7[][2] = { - /* Addr allmodes */ - {0x0000989c, 0x00000500}, - {0x0000989c, 0x00000800}, - {0x000098cc, 0x0000000e}, -}; - static const u32 ar5416Addac[][2] = { /* Addr allmodes */ {0x0000989c, 0x00000000}, @@ -634,4 +604,3 @@ static const u32 ar5416Addac[][2] = { {0x0000989c, 0x00000000}, {0x000098c4, 0x00000000}, }; - diff --git a/drivers/net/wireless/ath/ath9k/ar5008_phy.c b/drivers/net/wireless/ath/ath9k/ar5008_phy.c index 0d34356baf73a..2fa30834a88db 100644 --- a/drivers/net/wireless/ath/ath9k/ar5008_phy.c +++ b/drivers/net/wireless/ath/ath9k/ar5008_phy.c @@ -18,7 +18,6 @@ #include "hw-ops.h" #include "../regd.h" #include "ar9002_phy.h" -#include "ar5008_initvals.h" /* All code below is for AR5008, AR9001, AR9002 */ @@ -51,6 +50,36 @@ static const int m2ThreshLowExt_off = 127; static const int m1ThreshExt_off = 127; static const int m2ThreshExt_off = 127; +static const u32 ar5416Bank0[][2] = { + /* Addr allmodes */ + {0x000098b0, 0x1e5795e5}, + {0x000098e0, 0x02008020}, +}; + +static const u32 ar5416Bank1[][2] = { + /* Addr allmodes */ + {0x000098b0, 0x02108421}, + {0x000098ec, 0x00000008}, +}; + +static const u32 ar5416Bank2[][2] = { + /* Addr allmodes */ + {0x000098b0, 0x0e73ff17}, + {0x000098e0, 0x00000420}, +}; + +static const u32 ar5416Bank3[][3] = { + /* Addr 5G 2G */ + {0x000098f0, 0x01400018, 0x01c00018}, +}; + +static const u32 ar5416Bank7[][2] = { + /* Addr allmodes */ + {0x0000989c, 0x00000500}, + {0x0000989c, 0x00000800}, + {0x000098cc, 0x0000000e}, +}; + static const struct ar5416IniArray bank0 = STATIC_INI_ARRAY(ar5416Bank0); static const struct ar5416IniArray bank1 = STATIC_INI_ARRAY(ar5416Bank1); static const struct ar5416IniArray bank2 = STATIC_INI_ARRAY(ar5416Bank2);