From patchwork Thu Aug 13 06:25:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 258884 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54D18C433DF for ; Thu, 13 Aug 2020 06:25:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 349D52078D for ; Thu, 13 Aug 2020 06:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597299942; bh=4uTIK2w8MtZvJJn/E0Mq5SkQK2HfkkABx1AyI5zNJKk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mJ1TSepBm2qS69hMpqVzEWdethBT/iVgmkADXsTZ60ykeHwvHgz4GhXfUgprl3z7w LJBb56uzWp1mYJ3jkiWGYO+eRrXx+65dtOjKBpK5bB6oVPi1PCnuGNx5E6VOzG+4x2 P/b1//25K7dCeWxFymSnhAIFkSMttqR9ZzL31aYU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726107AbgHMGZl (ORCPT ); Thu, 13 Aug 2020 02:25:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:37988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbgHMGZk (ORCPT ); Thu, 13 Aug 2020 02:25:40 -0400 Received: from saruman.elisa-laajakaista.fi (unknown [194.34.132.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A3F0D2078D; Thu, 13 Aug 2020 06:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597299940; bh=4uTIK2w8MtZvJJn/E0Mq5SkQK2HfkkABx1AyI5zNJKk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Aw5rvs+/6S/WPNiqgmQodMpDOUJjASmwQDOhlHkOr7Y8niLeE83+ntqX9EUMU71d6 QHQ1Mb0I2BWBTMhF1Th0f3Rs+CPS24ewY/x75LOEGEdEhlLDUZ0Z6d1E/p/EolABdy 35mnYNDngNo7yagX4eYTsd2FmcOfPiQq2dNMUbgE= From: balbi@kernel.org To: Linux USB Cc: Felipe Balbi Subject: [PATCH 02/11] dwc3: debug: fix sparse warning Date: Thu, 13 Aug 2020 09:25:23 +0300 Message-Id: <20200813062532.829720-2-balbi@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200813062532.829720-1-balbi@kernel.org> References: <20200813062532.829720-1-balbi@kernel.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Felipe Balbi Fix the following sparse warning: drivers/usb/dwc3/trace.c: note: in included file (through drivers/usb/dwc3/trace.h): drivers/usb/dwc3/debug.h:374:39: warning: cast to non-scalar Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/debug.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/debug.h b/drivers/usb/dwc3/debug.h index 3d16dac4e5cc..8e03bcb77da8 100644 --- a/drivers/usb/dwc3/debug.h +++ b/drivers/usb/dwc3/debug.h @@ -371,7 +371,9 @@ static inline const char *dwc3_gadget_event_type_string(u8 event) static inline const char *dwc3_decode_event(char *str, size_t size, u32 event, u32 ep0state) { - const union dwc3_event evt = (union dwc3_event) event; + union dwc3_event evt; + + memcpy(&evt, &event, sizeof(event)); if (evt.type.is_devspec) return dwc3_gadget_event_string(str, size, &evt.devt); From patchwork Thu Aug 13 06:25:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 258883 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99B33C433DF for ; Thu, 13 Aug 2020 06:25:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6981A2080C for ; Thu, 13 Aug 2020 06:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597299947; bh=sDrMmYcP4o7K9LD9J2okuR9gIb8aKW38EpjKeOsy/90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=b4Yj04lEsgPnWPT/0vr0zCMZvX3TQcfuSyIyLTq7MhRpSMh0BQTzczvd5cbjz3uEd ADZSAkeFiRU274Cl8mIB7RJTmA19HdVHcAORQqMiOH/vcp7PROIujXx40Frkm/kzVF GjCNftGKBL2fPiXElLheYLomYFqIHXp9U6V2t30Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726144AbgHMGZp (ORCPT ); Thu, 13 Aug 2020 02:25:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:38062 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbgHMGZo (ORCPT ); Thu, 13 Aug 2020 02:25:44 -0400 Received: from saruman.elisa-laajakaista.fi (unknown [194.34.132.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A7012206B5; Thu, 13 Aug 2020 06:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597299944; bh=sDrMmYcP4o7K9LD9J2okuR9gIb8aKW38EpjKeOsy/90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pGYF8w4EZHa8EWzUiOBPqO+R+yoPZOQ6N0T+ryJjnEo40LpY33FhjvVIUY4ta6FgG 0IkB3Z2qJQax9She9ANU7nC5Ydj8U+mj7Mlh3erq6L7ow1PmnAbiGDTBUQVYQI6pLF A4yeC6HeCu2n0LN1XqYR0TyhWUy75sgQj+2IwNDY= From: balbi@kernel.org To: Linux USB Cc: Felipe Balbi Subject: [PATCH 05/11] dwc3: trace: fix checkpatch warnings Date: Thu, 13 Aug 2020 09:25:26 +0300 Message-Id: <20200813062532.829720-5-balbi@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200813062532.829720-1-balbi@kernel.org> References: <20200813062532.829720-1-balbi@kernel.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Felipe Balbi no functional changes Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/trace.h | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h index da1be01637c8..97f4f1125a41 100644 --- a/drivers/usb/dwc3/trace.h +++ b/drivers/usb/dwc3/trace.h @@ -104,8 +104,8 @@ DECLARE_EVENT_CLASS(dwc3_log_request, TP_STRUCT__entry( __string(name, req->dep->name) __field(struct dwc3_request *, req) - __field(unsigned, actual) - __field(unsigned, length) + __field(unsigned int, actual) + __field(unsigned int, length) __field(int, status) __field(int, zero) __field(int, short_not_ok) @@ -246,6 +246,7 @@ DECLARE_EVENT_CLASS(dwc3_log_trb, __entry->dequeue, __entry->bph, __entry->bpl, ({char *s; int pcm = ((__entry->size >> 24) & 3) + 1; + switch (__entry->type) { case USB_ENDPOINT_XFER_INT: case USB_ENDPOINT_XFER_ISOC: @@ -291,12 +292,12 @@ DECLARE_EVENT_CLASS(dwc3_log_ep, TP_ARGS(dep), TP_STRUCT__entry( __string(name, dep->name) - __field(unsigned, maxpacket) - __field(unsigned, maxpacket_limit) - __field(unsigned, max_streams) - __field(unsigned, maxburst) - __field(unsigned, flags) - __field(unsigned, direction) + __field(unsigned int, maxpacket) + __field(unsigned int, maxpacket_limit) + __field(unsigned int, max_streams) + __field(unsigned int, maxburst) + __field(unsigned int, flags) + __field(unsigned int, direction) __field(u8, trb_enqueue) __field(u8, trb_dequeue) ), From patchwork Thu Aug 13 06:25:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 258882 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BE69C433DF for ; Thu, 13 Aug 2020 06:25:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 482CF20716 for ; Thu, 13 Aug 2020 06:25:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597299949; bh=RxZSywwUjM7t+PF7lnR/LsgIuwxf6BBZyopTs7zv51I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TcyOvqzCLvoZuvgnCWj9LAAEl6Goji3j1F8XEeeOuv3RTdJGH+7moueNAm0xnwTVt bLGcclCEngWlyWx3GMjwvYZeW84KGevRjCCiJhzYQ6nevoJj2Ok3yJPWpIfTKA0RPW TBKPqMv7isxy3+NtpbciQJsitWEJpGA6B/4Oj8qg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726192AbgHMGZr (ORCPT ); Thu, 13 Aug 2020 02:25:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:38098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbgHMGZp (ORCPT ); Thu, 13 Aug 2020 02:25:45 -0400 Received: from saruman.elisa-laajakaista.fi (unknown [194.34.132.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC77A2078B; Thu, 13 Aug 2020 06:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597299945; bh=RxZSywwUjM7t+PF7lnR/LsgIuwxf6BBZyopTs7zv51I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0lV893FstK9YmHYQClN0dzK+/ZD+N74OpyxGMHJmfqRLM94El5vwHtRVN7zYv7evh 7snszShLEL3LCTRxN54w1aPJefgGl90RL6RuBhiEnRtQ4wopDCXzcOggzWdGrmdpif Cr7EGjL92Z385Ve+reCzuzgu8gzioHfXAiPigfx4= From: balbi@kernel.org To: Linux USB Cc: Felipe Balbi Subject: [PATCH 06/11] dwc3: debug: fix checkpatch warning Date: Thu, 13 Aug 2020 09:25:27 +0300 Message-Id: <20200813062532.829720-6-balbi@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200813062532.829720-1-balbi@kernel.org> References: <20200813062532.829720-1-balbi@kernel.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Felipe Balbi no functional changes Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/debug.h b/drivers/usb/dwc3/debug.h index 8e03bcb77da8..8ab394942360 100644 --- a/drivers/usb/dwc3/debug.h +++ b/drivers/usb/dwc3/debug.h @@ -413,8 +413,8 @@ static inline const char *dwc3_gadget_generic_cmd_status_string(int status) #ifdef CONFIG_DEBUG_FS -extern void dwc3_debugfs_init(struct dwc3 *); -extern void dwc3_debugfs_exit(struct dwc3 *); +extern void dwc3_debugfs_init(struct dwc3 *d); +extern void dwc3_debugfs_exit(struct dwc3 *d); #else static inline void dwc3_debugfs_init(struct dwc3 *d) { } From patchwork Thu Aug 13 06:25:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 258881 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16CFEC433E1 for ; Thu, 13 Aug 2020 06:25:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9EEE20791 for ; Thu, 13 Aug 2020 06:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597299951; bh=3l06lVbHyKOg+g6w8AjVaqYHrYNKKb/MzVL/EIbgA7w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xxJZt/42WzO0sKT5Anq0dlScsfPWDJ+Ni9BrNde3bJDZoHbiLrj+edEseeZPqoFr7 i07BI7LRxhUZzeoMoYijKGNtwt5NA9MZ8+gTZM4uyJ3GGYVhrGT1kxQr1K9sWfEG+V EVHPY3nWFz7ThADNatB+FAMqPeIbBXrZRqGRVyRg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726249AbgHMGZu (ORCPT ); Thu, 13 Aug 2020 02:25:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:38146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbgHMGZs (ORCPT ); Thu, 13 Aug 2020 02:25:48 -0400 Received: from saruman.elisa-laajakaista.fi (unknown [194.34.132.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 474B62078D; Thu, 13 Aug 2020 06:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597299948; bh=3l06lVbHyKOg+g6w8AjVaqYHrYNKKb/MzVL/EIbgA7w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=InyJYVatEhZ2kY9mY8h+SyJcd6od85JJxzWYeqVHhrJC/qlA8G8IUzk3KFweUCHgg cSOvd73WZrKgh2DFnGvrHOlNSXDwK7C2gfCWTiUTvSp1/CuXgW/fQ4sLcuF5wzn+nQ Dg5VcgXbLlrTT1ykNE1OB5UKkPkatXQLAoRayrng= From: balbi@kernel.org To: Linux USB Cc: Felipe Balbi Subject: [PATCH 08/11] dwc3: gadget: fix checkpatch warnings Date: Thu, 13 Aug 2020 09:25:29 +0300 Message-Id: <20200813062532.829720-8-balbi@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200813062532.829720-1-balbi@kernel.org> References: <20200813062532.829720-1-balbi@kernel.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Felipe Balbi no functional changes Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index e44bfc3b5096..6b9f891b7e40 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -227,7 +227,8 @@ void dwc3_gadget_giveback(struct dwc3_ep *dep, struct dwc3_request *req, * Caller should take care of locking. Issue @cmd with a given @param to @dwc * and wait for its completion. */ -int dwc3_send_gadget_generic_command(struct dwc3 *dwc, unsigned cmd, u32 param) +int dwc3_send_gadget_generic_command(struct dwc3 *dwc, unsigned int cmd, + u32 param) { u32 timeout = 500; int status = 0; @@ -268,7 +269,7 @@ static int __dwc3_gadget_wakeup(struct dwc3 *dwc); * Caller should handle locking. This function will issue @cmd with given * @params to @dep and wait for its completion. */ -int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd, +int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned int cmd, struct dwc3_gadget_ep_cmd_params *params) { const struct usb_endpoint_descriptor *desc = dep->endpoint.desc; @@ -564,6 +565,7 @@ static int dwc3_gadget_set_ep_config(struct dwc3_ep *dep, unsigned int action) /* Burst size is only needed in SuperSpeed mode */ if (dwc->gadget.speed >= USB_SPEED_SUPER) { u32 burst = dep->endpoint.maxburst; + params.param0 |= DWC3_DEPCFG_BURST_SIZE(burst - 1); } @@ -942,9 +944,10 @@ static u32 dwc3_calc_trbs_left(struct dwc3_ep *dep) } static void __dwc3_prepare_one_trb(struct dwc3_ep *dep, struct dwc3_trb *trb, - dma_addr_t dma, unsigned length, unsigned chain, unsigned node, - unsigned stream_id, unsigned short_not_ok, - unsigned no_interrupt, unsigned is_last) + dma_addr_t dma, unsigned int length, unsigned int chain, + unsigned int node, unsigned int stream_id, + unsigned int short_not_ok, unsigned int no_interrupt, + unsigned int is_last) { struct dwc3 *dwc = dep->dwc; struct usb_gadget *gadget = &dwc->gadget; @@ -1058,15 +1061,15 @@ static void __dwc3_prepare_one_trb(struct dwc3_ep *dep, struct dwc3_trb *trb, * @node: only for isochronous endpoints. First TRB needs different type. */ static void dwc3_prepare_one_trb(struct dwc3_ep *dep, - struct dwc3_request *req, unsigned chain, unsigned node) + struct dwc3_request *req, unsigned int chain, unsigned int node) { struct dwc3_trb *trb; + unsigned int stream_id = req->request.stream_id; + unsigned int short_not_ok = req->request.short_not_ok; + unsigned int no_interrupt = req->request.no_interrupt; + unsigned int is_last = req->request.is_last; unsigned int length; dma_addr_t dma; - unsigned stream_id = req->request.stream_id; - unsigned short_not_ok = req->request.short_not_ok; - unsigned no_interrupt = req->request.no_interrupt; - unsigned is_last = req->request.is_last; if (req->request.num_sgs > 0) { length = sg_dma_len(req->start_sg); @@ -1104,7 +1107,7 @@ static void dwc3_prepare_one_trb_sg(struct dwc3_ep *dep, unsigned int length = req->request.length; unsigned int maxp = usb_endpoint_maxp(dep->endpoint.desc); unsigned int rem = length % maxp; - unsigned chain = true; + unsigned int chain = true; /* * IOMMU driver is coalescing the list of sgs which shares a @@ -1586,9 +1589,8 @@ static int __dwc3_gadget_ep_queue(struct dwc3_ep *dep, struct dwc3_request *req) return 0; if ((dep->flags & DWC3_EP_PENDING_REQUEST)) { - if (!(dep->flags & DWC3_EP_TRANSFER_STARTED)) { + if (!(dep->flags & DWC3_EP_TRANSFER_STARTED)) return __dwc3_gadget_start_isoc(dep); - } } } @@ -1726,8 +1728,8 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value, int protocol) if (value) { struct dwc3_trb *trb; - unsigned transfer_in_flight; - unsigned started; + unsigned int transfer_in_flight; + unsigned int started; if (dep->number > 1) trb = dwc3_ep_prev_trb(dep, dep->trb_enqueue); From patchwork Thu Aug 13 06:25:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 258880 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1363BC433E1 for ; Thu, 13 Aug 2020 06:25:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8DC320716 for ; Thu, 13 Aug 2020 06:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597299952; bh=PUZCkfKqM56/EMsMa6LaRKqzxfbN7vt7o481UC1U8V4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uV4FKQozjeRleQ+LJskOmDfOBuOLxZcF1olVl7pESD313JtCnwWZylbE5rlER1mXY 1fvtZoOMMsjsBbrWh9R7vBwTJVO4551Oee9hw7W+ZYc6uHesAYoO1nmBofv8SdLo6g x0vgpZBFAeNq6E5DiYdXRgpW+D4fCkRr5Ye87yzY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726427AbgHMGZw (ORCPT ); Thu, 13 Aug 2020 02:25:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:38198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726334AbgHMGZu (ORCPT ); Thu, 13 Aug 2020 02:25:50 -0400 Received: from saruman.elisa-laajakaista.fi (unknown [194.34.132.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A64B320716; Thu, 13 Aug 2020 06:25:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597299950; bh=PUZCkfKqM56/EMsMa6LaRKqzxfbN7vt7o481UC1U8V4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sqAiN2dQOO0dBbfnl2VxcQjxHbkqwef9eW/WnQDlVMQjHUe42wjb87PI1VX0WpT+d 7MhOab7+V0I7QP05FnNvDESY+OUEHnsddpAQxI5iKALamOwuZGPH9PCutYyJ8NzLbi SJNDzMV4LrhjJKiTLJi9LRmiSrNA2+7r5P8jAueQ= From: balbi@kernel.org To: Linux USB Cc: Felipe Balbi Subject: [PATCH 10/11] dwc3: qcom: fix checkpatch warnings Date: Thu, 13 Aug 2020 09:25:31 +0300 Message-Id: <20200813062532.829720-10-balbi@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200813062532.829720-1-balbi@kernel.org> References: <20200813062532.829720-1-balbi@kernel.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Felipe Balbi no functional changes Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/dwc3-qcom.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index fcf7f79fb983..c703d552bbcf 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -444,7 +444,9 @@ static int dwc3_qcom_setup_irq(struct platform_device *pdev) { struct dwc3_qcom *qcom = platform_get_drvdata(pdev); const struct dwc3_acpi_pdata *pdata = qcom->acpi_pdata; - int irq, ret; + int irq; + int ret; + irq = dwc3_qcom_get_irq(pdev, "hs_phy_irq", pdata ? pdata->hs_phy_irq_index : -1); if (irq > 0) { @@ -563,7 +565,7 @@ static const struct property_entry dwc3_qcom_acpi_properties[] = { static int dwc3_qcom_acpi_register_core(struct platform_device *pdev) { - struct dwc3_qcom *qcom = platform_get_drvdata(pdev); + struct dwc3_qcom *qcom = platform_get_drvdata(pdev); struct device *dev = &pdev->dev; struct resource *res, *child_res = NULL; int irq; @@ -623,7 +625,7 @@ static int dwc3_qcom_acpi_register_core(struct platform_device *pdev) static int dwc3_qcom_of_register_core(struct platform_device *pdev) { - struct dwc3_qcom *qcom = platform_get_drvdata(pdev); + struct dwc3_qcom *qcom = platform_get_drvdata(pdev); struct device_node *np = pdev->dev.of_node, *dwc3_np; struct device *dev = &pdev->dev; int ret;